language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
emberjs
ember.js
d3326e56bcaffd35bee39400f180518138b17920.json
Add stricter typing
packages/ember-glimmer/lib/template.ts
@@ -7,18 +7,20 @@ import { OWNER } from 'ember-utils'; export interface Container { lookup<T>(name: string): T; + factoryFor<T>(name: string): T; } export type OwnedTemplate = Template<{ moduleName: string; owner: Container; }>; -class WrappedTemplateFactory { +export class WrappedTemplateFactory { ...
true
Other
emberjs
ember.js
d3326e56bcaffd35bee39400f180518138b17920.json
Add stricter typing
packages/ember-metal/lib/index.d.ts
@@ -41,7 +41,7 @@ export function watchKey(obj: any, keyName: string, meta?: any): void; export function isProxy(value: any): boolean; -export class Cache { - constructor(limit: number, func: (obj: any) => any, key: any, store?: any) - get(obj): any -} \ No newline at end of file +export class Cache<T, V> { + c...
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/component-managers/abstract.ts
@@ -2,7 +2,6 @@ import { ProgramSymbolTable } from '@glimmer/interfaces'; import { Tag, VersionedPathReference } from '@glimmer/reference'; import { Bounds, - CompiledDynamicProgram, CompiledDynamicTemplate, ComponentDefinition, ComponentManager, @@ -12,23 +11,24 @@ import { PreparedArguments, } from...
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/component-managers/mount.ts
@@ -23,7 +23,7 @@ interface EngineBucket { } class MountManager extends AbstractManager<EngineBucket> { - create(environment, { name }, args, dynamicScope) { + create(environment, { name }, args) { if (DEBUG) { this._pushEngineToDebugStack(`engine:${name}`, environment); } @@ -41,7 +41,7 @@ class...
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/component-managers/outlet.ts
@@ -42,7 +42,7 @@ class StateBucket { } class OutletComponentManager extends AbstractManager<StateBucket> { - create(environment: Environment, definition: OutletComponentDefinition, args, dynamicScope: OutletDynamicScope) { + create(environment: Environment, definition: OutletComponentDefinition, _args, dynamicSc...
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/component-managers/render.ts
@@ -1,13 +1,9 @@ -import { - VersionedPathReference, -} from '@glimmer/reference'; import { ComponentDefinition, } from '@glimmer/runtime'; import { IArguments } from '@glimmer/runtime/dist/types/lib/vm/arguments'; import { Destroyable } from '@glimmer/util'; -import { assert } from 'ember-debug'; import { D...
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/component-managers/root.ts
@@ -1,9 +1,6 @@ import { ComponentDefinition, } from '@glimmer/runtime'; -import { - assert, -} from 'ember-debug'; import { DEBUG } from 'ember-env-flags'; import { _instrumentStart, @@ -15,7 +12,7 @@ import CurlyComponentManager, { } from './curly'; class RootComponentManager extends CurlyComponentMana...
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/components/link-to.ts
@@ -543,10 +543,10 @@ const LinkComponent = EmberComponent.extend({ @private */ disabled: computed({ - get(key, value) { + get(_key) { return false; }, - set(key, value) { + set(_key, value) { if (value !== undefined) { this.set('_isDisabled', value); } return value ? ...
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/components/text_field.ts
@@ -103,7 +103,7 @@ export default Component.extend(TextSupport, { return 'text'; }, - set(key, value) { + set(_key, value) { let type = 'text'; if (canSetTypeOfInput(value)) {
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/environment.ts
@@ -1,11 +1,9 @@ -/// <reference path="../externs.d.ts"/> import { Reference, } from '@glimmer/reference'; import { AttributeManager, compileLayout, - DOMTreeConstruction, Environment as GlimmerEnvironment, getDynamicVar, isSafeString, @@ -14,7 +12,7 @@ import { import { Destroyable, Opaque, ...
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/helpers/-class.ts
@@ -23,6 +23,6 @@ function classHelper({ positional }) { return value; } -export default function(vm, args) { +export default function(_vm, args) { return new InternalHelperReference(classHelper, args.capture()); }
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/helpers/-html-safe.ts
@@ -6,6 +6,6 @@ function htmlSafe({ positional }) { return new SafeString(path.value()); } -export default function(vm, args) { +export default function(_vm, args) { return new InternalHelperReference(htmlSafe, args.capture()); }
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/helpers/-input-type.ts
@@ -1,13 +1,13 @@ import { InternalHelperReference } from '../utils/references'; -function inputTypeHelper({ positional, named }) { +function inputTypeHelper({ positional }) { let type = positional.at(0).value(); if (type === 'checkbox') { return '-checkbox'; } return '-text-field'; } -export def...
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/helpers/-normalize-class.ts
@@ -1,7 +1,7 @@ import { String as StringUtils } from 'ember-runtime'; import { InternalHelperReference } from '../utils/references'; -function normalizeClass({ positional, named }) { +function normalizeClass({ positional }) { let classNameParts = positional.at(0).value().split('.'); let className = className...
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/helpers/action.ts
@@ -270,7 +270,7 @@ export const ACTION = symbol('ACTION'); @for Ember.Templates.helpers @public */ -export default function(vm, args): UnboundReference { +export default function(_vm, args): UnboundReference { let { named, positional } = args; let capturedArgs = positional.capture(); @@ -308,15 +308,15 ...
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/helpers/component.ts
@@ -144,6 +144,10 @@ import { CachedReference } from '../utils/references'; @public */ export class ClosureComponentReference extends CachedReference { + static create(args, meta, env) { + return new ClosureComponentReference(args, meta, env); + } + public defRef: any; public tag: any; public args: a...
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/helpers/concat.ts
@@ -25,6 +25,6 @@ function concat({ positional }) { return positional.value().map(normalizeTextValue).join(''); } -export default function(vm, args) { +export default function(_vm, args) { return new InternalHelperReference(concat, args.capture()); }
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/helpers/each-in.ts
@@ -115,7 +115,7 @@ export function isEachIn(ref): boolean { return ref && ref[EACH_IN_REFERENCE]; } -export default function(vm, args) { +export default function(_vm, args) { let ref = Object.create(args.positional.at(0)); ref[EACH_IN_REFERENCE] = true; return ref;
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/helpers/get.ts
@@ -60,7 +60,7 @@ import { CachedReference, UPDATE } from '../utils/references'; @since 2.1.0 */ -export default function(vm, args) { +export default function(_vm, args) { return GetHelperReference.create(args.positional.at(0), args.positional.at(1)); }
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/helpers/hash.ts
@@ -41,6 +41,6 @@ @public */ -export default function(vm, args) { +export default function(_vm, args) { return args.named.capture(); }
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/helpers/if-unless.ts
@@ -133,7 +133,7 @@ class ConditionalHelperReference extends CachedReference { @for Ember.Templates.helpers @public */ -export function inlineIf(vm, { positional }) { +export function inlineIf(_vm, { positional }) { assert( 'The inline form of the `if` helper expects two or three arguments, e.g. ' + ...
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/helpers/loc.ts
@@ -41,6 +41,6 @@ function locHelper({ positional }) { return StringUtils.loc.apply(null, positional.value()); } -export default function(vm, args) { +export default function(_vm, args) { return new InternalHelperReference(locHelper, args.capture()); }
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/helpers/log.ts
@@ -22,6 +22,6 @@ function log({ positional }) { Logger.log.apply(null, positional.value()); } -export default function(vm, args) { +export default function(_vm, args) { return new InternalHelperReference(log, args.capture()); }
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/helpers/mut.ts
@@ -86,7 +86,7 @@ export function unMut(ref) { return ref[SOURCE] || ref; } -export default function(vm, args) { +export default function(_vm, args) { let rawRef = args.positional.at(0); if (isMut(rawRef)) {
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/helpers/query-param.ts
@@ -23,13 +23,14 @@ import { InternalHelperReference } from '../utils/references'; @public */ function queryParams({ positional, named }) { + // tslint:disable-next-line:max-line-length assert('The `query-params` helper only accepts hash parameters, e.g. (query-params queryParamPropertyName=\'foo\') as opposed...
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/helpers/readonly.ts
@@ -102,7 +102,7 @@ import { unMut } from './mut'; @for Ember.Templates.helpers @private */ -export default function(vm, args) { +export default function(_vm, args) { let ref = unMut(args.positional.at(0)); let wrapped = Object.create(ref);
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/helpers/unbound.ts
@@ -33,7 +33,7 @@ import { UnboundReference } from '../utils/references'; @public */ -export default function(vm, args) { +export default function(_vm, args) { assert( 'unbound helper cannot be called with multiple params or hash params', args.positional.length === 1 && args.named.length === 0,
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/modifiers/action.ts
@@ -164,7 +164,7 @@ export class ActionState { // implements ModifierManager<Action> export default class ActionModifierManager { - create(element, args, dynamicScope, dom) { + create(element, args, _dynamicScope, dom) { let { named, positional } = args.capture(); let implicitTarget; let actionName...
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/renderer.ts
@@ -1,7 +1,3 @@ -interface FreeformObject { - [key: string]: any; -} - import { Simple } from '@glimmer/interfaces'; import { CURRENT_TAG, VersionedPathReference } from '@glimmer/reference'; import { IteratorResult } from '@glimmer/runtime'; @@ -174,7 +170,7 @@ function loopBegin() { function K() { /* noop */ } ...
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/syntax/-text-area.ts
@@ -1,7 +1,7 @@ import { wrapComponentClassAttribute } from '../utils/bindings'; import { hashToArgs } from './utils'; -export function textAreaMacro(name, params, hash, builder) { +export function textAreaMacro(_name, params, hash, builder) { let definition = builder.env.getComponentDefinition('-text-area', bui...
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/syntax/dynamic-component.ts
@@ -11,7 +11,7 @@ function dynamicComponentFor(vm, args, meta) { return new DynamicComponentReference({ nameRef, env, meta, args: null }); } -export function dynamicComponentMacro(params, hash, _default, inverse, builder) { +export function dynamicComponentMacro(params, hash, _default, _inverse, builder) { let...
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/syntax/input.ts
@@ -148,7 +148,7 @@ function buildSyntax(type, params, hash, builder) { @public */ -export function inputMacro(name, params, hash, builder) { +export function inputMacro(_name, params, hash, builder) { let keys; let values; let typeIndex = -1;
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/syntax/mount.ts
@@ -2,7 +2,6 @@ @module ember */ import { assert } from 'ember-debug'; -import { DEBUG } from 'ember-env-flags'; import { EMBER_ENGINES_MOUNT_PARAMS } from 'ember/features'; import { MountDefinition } from '../component-managers/mount'; import { hashToArgs } from './utils'; @@ -55,7 +54,7 @@ function dynamicEngin...
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/syntax/outlet.ts
@@ -128,7 +128,7 @@ function outletComponentFor(vm, args) { @for Ember.Templates.helpers @public */ -export function outletMacro(name, params, hash, builder) { +export function outletMacro(_name, params, _hash, builder) { if (!params) { params = []; }
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/syntax/render.ts
@@ -16,10 +16,12 @@ function makeComponentDefinition(vm, args) { let nameRef = args.positional.at(0); assert(`The first argument of {{render}} must be quoted, e.g. {{render "sidebar"}}.`, isConst(nameRef)); + // tslint:disable-next-line:max-line-length assert(`The second argument of {{render}} must be a pat...
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/utils/iterable.ts
@@ -54,8 +54,8 @@ function keyForArray(keyPath) { } } -function index(item, index) { - return String(index); +function index(_item, i) { + return String(i); } function identity(item) { @@ -249,7 +249,7 @@ class ArrayIterable { return get(iterable, 'length') > 0 ? new EmberArrayIterator(iterable, keyF...
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
packages/ember-glimmer/lib/utils/references.ts
@@ -6,7 +6,6 @@ import { isConst, TagWrapper, UpdatableTag, - VersionedPathReference, } from '@glimmer/reference'; import { ConditionalReference as GlimmerConditionalReference, @@ -24,7 +23,6 @@ import { } from 'ember-metal'; import { HAS_NATIVE_WEAKMAP, - Opaque, symbol, } from 'ember-utils'; ...
true
Other
emberjs
ember.js
3c74b385a7d0e2b1ee7ec75b52723e87173fb82a.json
add more strictness and few more types.
tsconfig.json
@@ -16,8 +16,8 @@ // Enhance Strictness // "noImplicitAny": true, // "suppressImplicitAnyIndexErrors": true, - // "noUnusedLocals": true, - // "noUnusedParameters": true, + "noUnusedLocals": true, + "noUnusedParameters": true, // "allowUnreachableCode": false, // "strictNullChecks":...
true
Other
emberjs
ember.js
2757794e4a8f80767e228fd2882c254c1b872e68.json
Fix ESLint errors
packages/loader/lib/index.js
@@ -1,45 +1,8 @@ +/*global process */ var enifed, requireModule, Ember; var mainContext = this; // Used in ember-environment/lib/global.js (function() { - var isNode = typeof window === 'undefined' && - typeof process !== 'undefined' && {}.toString.call(process) === '[object process]'; - - if (!isNode) { - ...
true
Other
emberjs
ember.js
2757794e4a8f80767e228fd2882c254c1b872e68.json
Fix ESLint errors
packages/node-module/lib/node-module.js
@@ -1,3 +1,4 @@ +/*global enifed */ enifed('node-module', ['exports'], function(_exports) { var IS_NODE = typeof module === 'object' && typeof module.require === 'function'; if (IS_NODE) {
true
Other
emberjs
ember.js
42eb72a8038fa5de532e1c098521d8f8a4fcffa4.json
fix last type errors
packages/ember-glimmer/lib/environment.ts
@@ -17,7 +17,9 @@ import { AttributeManager, isSafeString, compileLayout, - getDynamicVar + getDynamicVar, + DOMTreeConstruction, + PartialDefinition } from '@glimmer/runtime'; import { Opaque @@ -64,6 +66,7 @@ import { GLIMMER_CUSTOM_COMPONENT_MANAGER, EMBER_MODULE_UNIFICATION } from 'ember/fe...
false
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-debug/lib/index.d.ts
@@ -1,3 +1,5 @@ -export function assert(message: string, test: boolean): void; +export function assert(message: string, test?: boolean): void; -export function warn(message: string, test: boolean, options?: any): void; \ No newline at end of file +export function warn(message: string, test: boolean, options?: any): v...
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-glimmer/externs.d.ts
@@ -1,3 +1,12 @@ +declare module 'ember/features' { + export const EMBER_MODULE_UNIFICATION: any; + export const GLIMMER_CUSTOM_COMPONENT_MANAGER: any; + export const EMBER_ENGINES_MOUNT_PARAMS: any; + export const EMBER_GLIMMER_DETECT_BACKTRACKING_RERENDER: any; + export const EMBER_GLIMMER_ALLOW_BACKTRACKING_RER...
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-glimmer/lib/component-managers/abstract.ts
@@ -4,11 +4,15 @@ import { DEBUG } from 'ember-env-flags'; // https://github.com/glimmerjs/glimmer-vm/blob/v0.24.0-beta.4/packages/%40glimmer/runtime/lib/component/interfaces.ts#L21 export default class AbstractManager { + public debugStack: any; + public _pushToDebugStack: (name: string, environment: any) => voi...
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-glimmer/lib/component-managers/curly.ts
@@ -1,4 +1,8 @@ -import { OWNER, assign } from 'ember-utils'; +import { + Opaque, + OWNER, + assign +} from 'ember-utils'; import { combineTagged } from '@glimmer/reference'; import { PrimitiveReference, @@ -41,15 +45,15 @@ function aliasIdToElementId(args, props) { } // We must traverse the attributeBindin...
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-glimmer/lib/component-managers/mount.ts
@@ -2,6 +2,9 @@ import { ComponentDefinition } from '@glimmer/runtime'; import { UNDEFINED_REFERENCE } from '@glimmer/reference'; +import { + Opaque +} from '@glimmer/util'; import { DEBUG } from 'ember-env-flags'; import { RootReference } from '../utils/references'; @@ -10,6 +13,17 @@ import AbstractManager ...
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-glimmer/lib/component-managers/outlet.ts
@@ -14,6 +14,9 @@ function instrumentationPayload({ render: { name, outlet } }) { function NOOP() {} class StateBucket { + public outletState: any; + public finalizer: any; + constructor(outletState) { this.outletState = outletState; this.instrument(); @@ -76,7 +79,8 @@ class TopLevelOutletComponentM...
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-glimmer/lib/component-managers/render.ts
@@ -74,7 +74,11 @@ class NonSingletonRenderManager extends AbstractRenderManager { export const NON_SINGLETON_RENDER_MANAGER = new NonSingletonRenderManager(); -export class RenderDefinition extends ComponentDefinition { +export class RenderDefinition extends ComponentDefinition<any> { + public name: string; + p...
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-glimmer/lib/component-managers/root.ts
@@ -49,7 +49,9 @@ class RootComponentManager extends CurlyComponentManager { const ROOT_MANAGER = new RootComponentManager(); -export class RootComponentDefinition extends ComponentDefinition { +export class RootComponentDefinition extends ComponentDefinition<any> { + public template: any; + public args: any; ...
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-glimmer/lib/environment.ts
@@ -1,7 +1,7 @@ +/// <reference path="../externs.d.ts"/> import { guidFor, OWNER } from 'ember-utils'; import { Cache, _instrumentStart } from 'ember-metal'; import { assert, warn } from 'ember-debug'; -import { EMBER_MODULE_UNIFICATION } from 'ember/features'; import { DEBUG } from 'ember-env-flags'; import { ...
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-glimmer/lib/helpers/action.ts
@@ -270,7 +270,7 @@ export const ACTION = symbol('ACTION'); @for Ember.Templates.helpers @public */ -export default function(vm, args) { +export default function(vm, args): UnboundReference { let { named, positional } = args; let capturedArgs = positional.capture();
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-glimmer/lib/helpers/component.ts
@@ -144,6 +144,14 @@ import { assert } from 'ember-debug'; @public */ export class ClosureComponentReference extends CachedReference { + public defRef: any; + public tag: any; + public args: any; + public meta: any; + public env: any; + public lastDefinition: any; + public lastName: string; + static crea...
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-glimmer/lib/helpers/get.ts
@@ -65,6 +65,13 @@ export default function(vm, args) { } class GetHelperReference extends CachedReference { + public sourceReference: any; + public pathReference: any; + public lastPath: any; + public innerReference: any; + public innerTag: UpdatableTag; + public tag: any; + static create(sourceReference, ...
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-glimmer/lib/helpers/if-unless.ts
@@ -15,6 +15,12 @@ import { } from '@glimmer/reference'; class ConditionalHelperReference extends CachedReference { + public branchTag: UpdatableTag; + public tag: any; + public cond: any; + public truthy: any; + public falsy: any; + static create(_condRef, truthyRef, falsyRef) { let condRef = Conditio...
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-glimmer/lib/modifiers/action.ts
@@ -53,6 +53,16 @@ export let ActionHelper = { }; export class ActionState { + public element: HTMLElement; + public actionId: any; + public actionName: any; + public actionArgs: any; + public namedArgs: any; + public positional: any; + public implicitTarget: any; + public dom: any; + public eventName: any...
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-glimmer/lib/syntax.ts
@@ -53,7 +53,7 @@ function refineBlockSyntax(name, params, hash, _default, inverse, builder) { return false; } -export const experimentalMacros = []; +export const experimentalMacros: Array<any> = []; // This is a private API to allow for experimental macros // to be created in user space. Registering a macro...
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-glimmer/lib/syntax/dynamic-component.ts
@@ -9,7 +9,7 @@ function dynamicComponentFor(vm, args, meta) { let env = vm.env; let nameRef = args.positional.at(0); - return new DynamicComponentReference({ nameRef, env, meta }); + return new DynamicComponentReference({ nameRef, env, meta, args: null }); } export function dynamicComponentMacro(para...
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-glimmer/lib/syntax/mount.ts
@@ -75,6 +75,12 @@ export function mountMacro(name, params, hash, builder) { } class DynamicEngineReference { + public tag: any; + public nameRef: any; + public env: any; + public meta: any; + private _lastName: any; + private _lastDef: any; constructor({ nameRef, env, meta }) { this.tag = nameRef.tag...
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-glimmer/lib/syntax/outlet.ts
@@ -6,6 +6,13 @@ import { import { OutletComponentDefinition } from '../component-managers/outlet'; class OutletComponentReference { + public outletNameRef: any; + public parentOutletStateRef: any; + public definition: any; + public lastState: any; + public outletStateTag: UpdatableTag; + public tag: any; + ...
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-glimmer/lib/utils/bindings.ts
@@ -14,7 +14,7 @@ import { assert } from 'ember-debug'; import { get } from 'ember-metal'; import { String as StringUtils } from 'ember-runtime'; import { ROOT_REF } from '../component'; -import { htmlSafe, isHTMLSafe } from './string'; +import { htmlSafe, isHTMLSafe, SafeString } from './string'; function refere...
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-glimmer/lib/utils/curly-component-state-bucket.ts
@@ -24,7 +24,7 @@ function NOOP() {} @private */ export default class ComponentStateBucket { - private classRef: Opaque = null; + public classRef: Opaque = null; private argsRevision: Revision; constructor(private environment: Environment, private component: Component, private args: Tagged, private final...
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-glimmer/lib/utils/process-args.ts
@@ -38,6 +38,7 @@ export function processComponentArgs(namedArgs) { const REF = symbol('REF'); class MutableCell { + public value: any; constructor(ref, value) { this[MUTABLE_CELL] = true; this[REF] = ref;
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-glimmer/lib/utils/references.ts
@@ -57,19 +57,25 @@ class EmberPathReference { // @abstract get tag() // @abstract value() - get(key) { + get(key?): any { return PropertyReference.create(this, key); } } // @abstract export class CachedReference extends EmberPathReference { + private _lastRevision: any; + private _lastValue: a...
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-glimmer/lib/utils/string.ts
@@ -5,6 +5,8 @@ import { deprecate } from 'ember-debug'; export class SafeString { + public string: string; + constructor(string) { this.string = string; }
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-glimmer/lib/views/outlet.ts
@@ -5,6 +5,9 @@ import { OWNER } from 'ember-utils'; import { run } from 'ember-metal'; class OutletStateReference { + public outletView: any; + public tag: any; + constructor(outletView) { this.outletView = outletView; this.tag = outletView._tag; @@ -31,6 +34,9 @@ class OutletStateReference { // in...
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/ember-metal/lib/index.d.ts
@@ -1,21 +1,47 @@ -declare module 'ember-metal' { - export const run: { [key: string]: any }; +interface IBackburner { + join(...args: any[]): void; + on(...args: any[]): void; + scheduleOnce(...args: any[]): void; +} +interface IRun { + (...args: any[]): any; + schedule(...args: any[]): void; + later(...args: a...
true
Other
emberjs
ember.js
74b2679634955f54bc424c486a64d44c93c13b42.json
Fix missing property and other minor TS errors
packages/node-module/lib/index.d.ts
@@ -0,0 +1,3 @@ +export const IS_NODE: boolean; + +export function require(url: string): string; \ No newline at end of file
true
Other
emberjs
ember.js
3d32cc0e8aea7b5664f697dd3ca1f9e3cc2e7a18.json
Modify build to handle typescript
broccoli/glimmer-template-compiler.js
@@ -21,7 +21,7 @@ function GlimmerTemplatePrecompiler (inputTree, options) { } GlimmerTemplatePrecompiler.prototype.extensions = ['hbs']; -GlimmerTemplatePrecompiler.prototype.targetExtension = 'ts'; +GlimmerTemplatePrecompiler.prototype.targetExtension = 'js'; GlimmerTemplatePrecompiler.prototype.baseDir = func...
true
Other
emberjs
ember.js
3d32cc0e8aea7b5664f697dd3ca1f9e3cc2e7a18.json
Modify build to handle typescript
broccoli/packages.js
@@ -7,6 +7,7 @@ const Funnel = require('broccoli-funnel'); const filterTypeScript = require('broccoli-typescript-compiler').filterTypeScript; const TypeScriptPlugin = require('broccoli-typescript-compiler').TypeScriptPlugin; const BroccoliDebug = require('broccoli-debug'); +const MergeTrees = require('broccoli-merge...
true
Other
emberjs
ember.js
3d32cc0e8aea7b5664f697dd3ca1f9e3cc2e7a18.json
Modify build to handle typescript
ember-cli-build.js
@@ -73,7 +73,10 @@ module.exports = function(options) { let inlineParser = toES5(handlebarsES(), { annotation: 'handlebars' }); let tokenizer = toES5(simpleHTMLTokenizerES(), { annotation: 'tokenizer' }); let rsvp = toES5(rsvpES(), { annotation: 'rsvp' }); - let emberMetal = new Funnel('packages/ember-metal/l...
true
Other
emberjs
ember.js
3d32cc0e8aea7b5664f697dd3ca1f9e3cc2e7a18.json
Modify build to handle typescript
tsconfig.json
@@ -19,29 +19,21 @@ // "noUnusedLocals": true, // "noUnusedParameters": true, // "allowUnreachableCode": false, - "strictNullChecks": true, + // "strictNullChecks": true, // "noImplicitReturns": true, // "noImplicitThis": true, "newLine": "LF", - "noEmit": false, - "allowJs":...
true
Other
emberjs
ember.js
26f30a5e4cdd94896e8dde3ffaa9d6f456edfc95.json
Change some util files into TS
packages/ember-debug/lib/index.d.ts
@@ -0,0 +1 @@ +export function assert(message: string, test: boolean): void;
true
Other
emberjs
ember.js
26f30a5e4cdd94896e8dde3ffaa9d6f456edfc95.json
Change some util files into TS
packages/ember-glimmer/externs.d.ts
@@ -0,0 +1,3 @@ +declare module 'ember-env-flags' { + export const DEBUG: boolean; +}
true
Other
emberjs
ember.js
26f30a5e4cdd94896e8dde3ffaa9d6f456edfc95.json
Change some util files into TS
packages/ember-glimmer/lib/renderer.js
@@ -161,7 +161,7 @@ function loopEnd(current, next) { backburner.on('begin', loopBegin); backburner.on('end', loopEnd); -class Renderer { +export class Renderer { constructor(env, rootTemplate, _viewRegistry = fallbackViewRegistry, destinedForDOM = false) { this._env = env; this._rootTemplate = rootTem...
true
Other
emberjs
ember.js
26f30a5e4cdd94896e8dde3ffaa9d6f456edfc95.json
Change some util files into TS
packages/ember-glimmer/lib/templates/root.d.ts
@@ -0,0 +1,2 @@ +declare const TEMPLATE: any; +export default TEMPLATE;
true
Other
emberjs
ember.js
26f30a5e4cdd94896e8dde3ffaa9d6f456edfc95.json
Change some util files into TS
packages/ember-glimmer/lib/utils/bindings.ts
@@ -2,8 +2,11 @@ import { CachedReference, combine, map, - referenceFromParts + referenceFromParts, + Reference, + Tag } from '@glimmer/reference'; +import { Opaque, Option } from '@glimmer/interfaces'; import { Ops } from '@glimmer/wire-format'; @@ -100,22 +103,21 @@ export const AttributeBinding = ...
true
Other
emberjs
ember.js
26f30a5e4cdd94896e8dde3ffaa9d6f456edfc95.json
Change some util files into TS
packages/ember-glimmer/lib/utils/curly-component-state-bucket.ts
@@ -1,3 +1,16 @@ +import { Opaque } from '@glimmer/interfaces'; +import { Revision, Tagged } from '@glimmer/reference'; + +interface Environment { + isInteractive: boolean; + destroyedComponents: Component[]; +} + +interface Component { + trigger(event: string); +} + +type Finalizer = () => void; function NOOP() {}...
true
Other
emberjs
ember.js
26f30a5e4cdd94896e8dde3ffaa9d6f456edfc95.json
Change some util files into TS
packages/ember-glimmer/lib/utils/debug-stack.ts
@@ -1,21 +1,20 @@ +// @ts-check + import { DEBUG } from 'ember-env-flags'; let DebugStack; if (DEBUG) { class Element { - constructor(name) { - this.name = name; + constructor(public name: string) { } } class TemplateElement extends Element { } class EngineElement extends Element { ...
true
Other
emberjs
ember.js
d23a1ccbe9f50f304805fcb4cd6ffb0d3b66b012.json
Remove .d.ts files
packages/ember-debug/lib/ember-env-flags.d.ts
@@ -1,3 +0,0 @@ -declare module 'ember-env-flags' { - export const DEBUG: boolean; -}
true
Other
emberjs
ember.js
d23a1ccbe9f50f304805fcb4cd6ffb0d3b66b012.json
Remove .d.ts files
packages/ember-debug/lib/index.d.ts
@@ -1 +0,0 @@ -export function assert(message: string, test: boolean): void;
true
Other
emberjs
ember.js
039dee9d9478ceaeab44e5daa7efb6a99f088202.json
Enable typescript for ember-glimmer.
.gitignore
@@ -39,3 +39,4 @@ publish_to_bower/ bower_components/ npm-debug.log .ember-cli +DEBUG/
true
Other
emberjs
ember.js
039dee9d9478ceaeab44e5daa7efb6a99f088202.json
Enable typescript for ember-glimmer.
broccoli/glimmer-template-compiler.js
@@ -21,7 +21,7 @@ function GlimmerTemplatePrecompiler (inputTree, options) { } GlimmerTemplatePrecompiler.prototype.extensions = ['hbs']; -GlimmerTemplatePrecompiler.prototype.targetExtension = 'js'; +GlimmerTemplatePrecompiler.prototype.targetExtension = 'ts'; GlimmerTemplatePrecompiler.prototype.baseDir = func...
true
Other
emberjs
ember.js
039dee9d9478ceaeab44e5daa7efb6a99f088202.json
Enable typescript for ember-glimmer.
broccoli/packages.js
@@ -4,6 +4,9 @@ const { readFileSync } = require('fs'); const path = require('path'); const Rollup = require('broccoli-rollup'); const Funnel = require('broccoli-funnel'); +const filterTypeScript = require('broccoli-typescript-compiler').filterTypeScript; +const TypeScriptPlugin = require('broccoli-typescript-compil...
true
Other
emberjs
ember.js
039dee9d9478ceaeab44e5daa7efb6a99f088202.json
Enable typescript for ember-glimmer.
ember-cli-build.js
@@ -1,6 +1,12 @@ 'use strict'; /* eslint-env node */ +// To create fast production builds (without ES3 support, minification, derequire, or JSHint) +// run the following: +// +// DISABLE_ES3=true DISABLE_JSCS=true DISABLE_JSHINT=true DISABLE_MIN=true DISABLE_DEREQUIRE=true ember serve --environment=production + +co...
true
Other
emberjs
ember.js
039dee9d9478ceaeab44e5daa7efb6a99f088202.json
Enable typescript for ember-glimmer.
package.json
@@ -85,9 +85,11 @@ "backburner.js": "^1.2.2", "broccoli-babel-transpiler": "next", "broccoli-concat": "^3.2.2", + "broccoli-debug": "^0.6.3", "broccoli-file-creator": "^1.1.1", "broccoli-lint-eslint": "^3.2.1", "broccoli-rollup": "^1.2.0", + "broccoli-source": "^1.1.0", "broccol...
true
Other
emberjs
ember.js
039dee9d9478ceaeab44e5daa7efb6a99f088202.json
Enable typescript for ember-glimmer.
packages/ember-glimmer/index.js
@@ -259,37 +259,37 @@ @public */ -export { INVOKE } from './helpers/action'; -export { default as RootTemplate } from './templates/root'; -export { default as template } from './template'; -export { default as Checkbox } from './components/checkbox'; -export { default as TextField } from './components/text_field'...
true
Other
emberjs
ember.js
039dee9d9478ceaeab44e5daa7efb6a99f088202.json
Enable typescript for ember-glimmer.
tsconfig.json
@@ -0,0 +1,37 @@ +{ + "compilerOptions": { + // Compilation Configuration + "target": "es5", + "module": "es2015", + "inlineSources": true, + "inlineSourceMap": true, + "outDir": "dist", + "baseUrl" : "packages", + "rootDir": "packages", + + // Environment Configuration + "experimentalDec...
true
Other
emberjs
ember.js
039dee9d9478ceaeab44e5daa7efb6a99f088202.json
Enable typescript for ember-glimmer.
yarn.lock
@@ -1128,6 +1128,18 @@ broccoli-debug@^0.6.1: symlink-or-copy "^1.1.8" tree-sync "^1.2.2" +broccoli-debug@^0.6.3: + version "0.6.3" + resolved "https://registry.yarnpkg.com/broccoli-debug/-/broccoli-debug-0.6.3.tgz#1f33bb0eacb5db81366f0492524c82b1217eb578" + dependencies: + broccoli-plugin "^1.2.1" + ...
true
Other
emberjs
ember.js
448c29120b2e0a11e8b8d26a2645cf55bb8a83c7.json
Make observer static
packages/ember-metal/lib/mixin.js
@@ -743,6 +743,7 @@ export function aliasMethod(methodName) { @param {Function} func @return func @public + @static */ export function observer(...args) { let _paths, func; @@ -776,7 +777,7 @@ export function observer(...args) { ```javascript import EmberObject from '@ember/object'; - + Embe...
false
Other
emberjs
ember.js
32b09dcb339861b9a6a9208ec2aa292682366670.json
Fix various oversights with initial 176 deploy
packages/ember-debug/lib/deprecate.js
@@ -7,7 +7,10 @@ import Logger from 'ember-console'; import { ENV } from 'ember-environment'; import { registerHandler as genericRegisterHandler, invoke } from './handlers'; - +/** + @module @ember/debug + @public +*/ /** Allows for runtime registration of handler functions that override the default deprecation...
true
Other
emberjs
ember.js
32b09dcb339861b9a6a9208ec2aa292682366670.json
Fix various oversights with initial 176 deploy
packages/ember-runtime/lib/system/core_object.js
@@ -739,6 +739,8 @@ let ClassMixinProps = { see `reopenClass` @method reopen + @for @ember/object + @static @public */ reopen() { @@ -800,6 +802,8 @@ let ClassMixinProps = { see `reopen` @method reopenClass + @for @ember/object + @static @public */ reopenClass()...
true
Other
emberjs
ember.js
32b09dcb339861b9a6a9208ec2aa292682366670.json
Fix various oversights with initial 176 deploy
packages/ember-runtime/lib/system/native_array.js
@@ -1,5 +1,5 @@ /** -@module @ember/array +@module ember */ import Ember, { // Ember.A circular replace, @@ -29,9 +29,9 @@ import copy from '../copy'; false, this will be applied automatically. Otherwise you can apply the mixin at anytime by calling `Ember.NativeArray.apply(Array.prototype)`. - @class Em...
true
Other
emberjs
ember.js
32b09dcb339861b9a6a9208ec2aa292682366670.json
Fix various oversights with initial 176 deploy
packages/ember-runtime/lib/system/object.js
@@ -19,7 +19,7 @@ let OVERRIDE_OWNER = symbol('OVERRIDE_OWNER'); @class EmberObject @extends CoreObject - @uses Ember.Observable + @uses Observable @public */ const EmberObject = CoreObject.extend(Observable, {
true
Other
emberjs
ember.js
32b09dcb339861b9a6a9208ec2aa292682366670.json
Fix various oversights with initial 176 deploy
packages/ember-utils/lib/assign.js
@@ -17,6 +17,7 @@ @param {Object} ...args The objects to copy properties from @return {Object} @public + @static */ export function assign(original) { for (let i = 1; i < arguments.length; i++) {
true
Other
emberjs
ember.js
d7d40fcc3a8fa4be3310bcff0c6d14eac084a422.json
convert `Registry` to es6 class
packages/container/lib/registry.js
@@ -19,39 +19,36 @@ const VALID_FULL_NAME_REGEXP = /^[^:]+:[^:]+$/; @class Registry @since 1.11.0 */ -export default function Registry(options = {}) { - this.fallback = options.fallback || null; +export default class Registry { + constructor(options = {}) { + this.fallback = options.fallback || null; + thi...
false
Other
emberjs
ember.js
0c62821a2f773457b57f1218ffede3f19e9b426d.json
convert `Container` to es6 class
packages/container/lib/container.js
@@ -26,20 +26,20 @@ const CONTAINER_OVERRIDE = symbol('CONTAINER_OVERRIDE'); @private @class Container */ -export default function Container(registry, options = {}) { - this.registry = registry; - this.owner = options.owner || null; - this.cache = dictionary(options.cache || null); -...
false
Other
emberjs
ember.js
99b43dc699bede8be3c371b41ca4f1074196ffde.json
Update Changelog for 2.17.0-beta.3 [ci skip] (cherry picked from commit 2131f66c85888d8a74eb555334886e45d856787b)
CHANGELOG.md
@@ -1,5 +1,10 @@ # Ember Changelog +### 2.17.0-beta.3 (October 23, 2017) +- [#15606](https://github.com/emberjs/ember.js/pull/15606) [BUGFIX] Add fs-extra to deps +- [#15697](https://github.com/emberjs/ember.js/pull/15697) [BUGFIX] Move accessing meta out of the loop +- [#15710](https://github.com/emberjs/ember.js/p...
false
Other
emberjs
ember.js
1ee77481bbb6edfcc0d32806c2913447e7815708.json
remove fs-extra dependency
node-tests/blueprints/route-test.js
@@ -1,9 +1,6 @@ 'use strict'; -var fs = require('fs-extra'); -var path = require('path'); -var RSVP = require('rsvp'); -var remove = RSVP.denodeify(fs.remove); +var path = require('path'); var blueprintHelpers = require('ember-cli-blueprint-test-helpers/help...
true
Other
emberjs
ember.js
1ee77481bbb6edfcc0d32806c2913447e7815708.json
remove fs-extra dependency
package.json
@@ -55,7 +55,6 @@ "ember-cli-valid-component-name": "^1.0.0", "ember-cli-version-checker": "^1.3.1", "ember-router-generator": "^1.2.3", - "fs-extra": "^4.0.1", "inflection": "^1.12.0", "jquery": "^3.2.1", "resolve": "^1.3.3",
true
Other
emberjs
ember.js
1ee77481bbb6edfcc0d32806c2913447e7815708.json
remove fs-extra dependency
yarn.lock
@@ -2905,14 +2905,6 @@ fs-extra@^2.0.0: graceful-fs "^4.1.2" jsonfile "^2.1.0" -fs-extra@^4.0.1: - version "4.0.1" - resolved "https://registry.yarnpkg.com/fs-extra/-/fs-extra-4.0.1.tgz#7fc0c6c8957f983f57f306a24e5b9ddd8d0dd880" - dependencies: - graceful-fs "^4.1.2" - jsonfile "^3.0.0" - univers...
true