language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/internal-test-helpers/lib/test-resolver.js | @@ -40,4 +40,4 @@ class ModuleBasedResolver extends Resolver {
}
}
-export { ModuleBasedResolver }
+export { ModuleBasedResolver }; | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/node-module/lib/node-module.js | @@ -4,10 +4,10 @@ enifed('node-module', ['exports'], function(_exports) {
if (IS_NODE) {
_exports.require = module.require;
_exports.module = module;
- _exports.IS_NODE = IS_NODE
+ _exports.IS_NODE = IS_NODE;
} else {
_exports.require = null;
_exports.module = null;
- _exports.IS_NODE... | true |
Other | emberjs | ember.js | 4caeb8c84dc317af1346337536909c2164e7e3fe.json | ember-glimmer/string: Fix escapeExpression() types
escapeExpression() accepts anything and always returns a string | packages/ember-glimmer/lib/utils/string.ts | @@ -53,7 +53,7 @@ function escapeChar(chr: keyof typeof escape) {
return escape[chr];
}
-export function escapeExpression(string: string | SafeString) {
+export function escapeExpression(string: any): string {
if (typeof string !== 'string') {
// don't escape SafeStrings, since they're already safe
i... | false |
Other | emberjs | ember.js | f366bc672291c6d3e70c6ac5dcefcecfcd82ad41.json | Remove obsolete JSCS code
We're using ESLint now... | lib/jscs-rules/disallow-const-outside-module-scope.js | @@ -1,38 +0,0 @@
-var assert = require('assert');
-
-module.exports = function() { };
-
-module.exports.prototype = {
- configure: function(option) {
- assert(option === true, this.getOptionName() + ' requires a true value');
- },
-
- getOptionName: function() {
- return 'disallowConstOutsideModuleScope';
- }... | true |
Other | emberjs | ember.js | f366bc672291c6d3e70c6ac5dcefcecfcd82ad41.json | Remove obsolete JSCS code
We're using ESLint now... | lib/jscs-rules/disallow-multiple-var-decl-with-assignment.js | @@ -1,39 +0,0 @@
-var assert = require('assert');
-
-module.exports = function() {};
-
-module.exports.prototype = {
- configure: function(disallowMultipleVarDeclWithAssignment) {
- assert(
- typeof disallowMultipleVarDeclWithAssignment === 'boolean',
- 'disallowMultipleVarDeclWithAssignment option requir... | true |
Other | emberjs | ember.js | f366bc672291c6d3e70c6ac5dcefcecfcd82ad41.json | Remove obsolete JSCS code
We're using ESLint now... | lib/jscs-rules/disallow-space-before-semicolon.js | @@ -1,29 +0,0 @@
-var assert = require('assert');
-
-module.exports = function() {};
-
-module.exports.prototype = {
- configure: function(disallowSpacesBeforeSemicolons) {
- assert(
- typeof disallowSpacesBeforeSemicolons === 'boolean',
- 'disallowSpacesBeforeSemicolons option requires boolean value'
- ... | true |
Other | emberjs | ember.js | f366bc672291c6d3e70c6ac5dcefcecfcd82ad41.json | Remove obsolete JSCS code
We're using ESLint now... | lib/jscs-rules/disallow-space-inside-round-braces-in-call-expression.js | @@ -1,74 +0,0 @@
-var assert = require('assert');
-
-function spaceAfterBrace(arg, braceToken) {
- if (arg) {
- var supportedArgs = arg.type !== 'UnaryExpression' && arg.type !== 'BinaryExpression';
-
- return supportedArgs && braceToken.value === '(' && braceToken.range[1] + 1 === arg.range[0];
- }
-
- return... | true |
Other | emberjs | ember.js | f366bc672291c6d3e70c6ac5dcefcecfcd82ad41.json | Remove obsolete JSCS code
We're using ESLint now... | lib/jscs-rules/require-comments-to-include-access.js | @@ -1,44 +0,0 @@
-var assert = require('assert');
-
-function isDocComment(comment) {
- return comment.value[0] === '*';
-}
-
-function isModuleOnlyComment(comment) {
- return comment.value.match(/^\*\r?\n\s*@module.+\r?\n(?:\s*@submodule.+\r?\n)?$/);
-}
-
-function accessDeclarationCount(comment) {
- var matched = ... | true |
Other | emberjs | ember.js | f366bc672291c6d3e70c6ac5dcefcecfcd82ad41.json | Remove obsolete JSCS code
We're using ESLint now... | lib/jscs-rules/require-spaces-after-closing-parenthesis-in-function-declaration.js | @@ -1,69 +0,0 @@
-var assert = require('assert');
-
-module.exports = function() {};
-
-module.exports.prototype = {
- configure: function(options) {
- assert(
- typeof options === 'object',
- 'requireSpacesAfterClosingParenthesisInFunctionDeclaration option must be the object'
- );
-
- assert(
- ... | true |
Other | emberjs | ember.js | f366bc672291c6d3e70c6ac5dcefcecfcd82ad41.json | Remove obsolete JSCS code
We're using ESLint now... | packages/ember-glimmer/lib/utils/string.ts | @@ -39,9 +39,7 @@ const escape = {
'<': '<',
'>': '>',
'"': '"',
- // jscs:disable
"'": ''',
- // jscs:enable
'`': '`',
'=': '=',
}; | true |
Other | emberjs | ember.js | f366bc672291c6d3e70c6ac5dcefcecfcd82ad41.json | Remove obsolete JSCS code
We're using ESLint now... | packages/ember-metal/tests/run_loop/later_test.js | @@ -27,9 +27,7 @@ function wait(callback, maxWaitCount) {
// run loop has to flush, it would have considered
// the timer already expired.
function pauseUntil(time) {
- // jscs:disable
while (+new Date() < time) { /* do nothing - sleeping */ }
- // jscs:enable
}
QUnit.module('run.later', { | true |
Other | emberjs | ember.js | f366bc672291c6d3e70c6ac5dcefcecfcd82ad41.json | Remove obsolete JSCS code
We're using ESLint now... | packages/ember-routing/tests/location/util_test.js | @@ -80,7 +80,6 @@ QUnit.test('Feature-Detecting onhashchange', function() {
equal(supportsHashChange(8, { onhashchange() {} }), true, 'When in IE8+, use onhashchange existence as evidence of the feature');
});
-// jscs:disable
QUnit.test("Feature-detecting the history API", function() {
equal(supportsHistory(... | true |
Other | emberjs | ember.js | 131bf7ba6c18d4ea711297e58764a7b05f7ba51a.json | Add 2.17.0-beta.5 to CHANGELOG
[ci skip] | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### 2.17.0-beta.5 (November 7, 2017)
+- [#15797](https://github.com/emberjs/ember.js/pull/15797) [BUGFIX] Fix issues with using partials nested within other partials.
+- [#15808](https://github.com/emberjs/ember.js/pull/15808) [BUGFIX] Fix a memory leak in certain testing scenarios... | false |
Other | emberjs | ember.js | 32b79662675b2a1ba0db836f72fd8fb5f433be85.json | WIP: Upgrade glimmer-vm to 0.29.10
There is much left to do here. This is just the first pass, where I have
done nothing but try to clear out the errors caused by the upgrade. Not
all of the errors are cleared yet, largely because several exports from
glimmer-vm have been removed and I don't know how to replace them (... | ember-cli-build.js | @@ -65,8 +65,11 @@ module.exports = function(options) {
glimmerPkgES('@glimmer/compiler', ['@glimmer/util', '@glimmer/wire-format', '@glimmer/syntax']),
{ annotation: '@glimmer/compiler' }
);
+ let glimmerEncoder = toES5(glimmerPkgES('@glimmer/encoder'));
+ let glimmerOpcodeComiler = toES5(glimmerPkgES('... | true |
Other | emberjs | ember.js | 32b79662675b2a1ba0db836f72fd8fb5f433be85.json | WIP: Upgrade glimmer-vm to 0.29.10
There is much left to do here. This is just the first pass, where I have
done nothing but try to clear out the errors caused by the upgrade. Not
all of the errors are cleared yet, largely because several exports from
glimmer-vm have been removed and I don't know how to replace them (... | package.json | @@ -42,6 +42,11 @@
"test:testem": "testem -f testem.dist.json"
},
"dependencies": {
+ "@glimmer/compiler": "^0.29.10",
+ "@glimmer/node": "^0.29.10",
+ "@glimmer/reference": "^0.29.10",
+ "@glimmer/runtime": "^0.29.10",
+ "@glimmer/vm": "^0.29.10",
"broccoli-funnel": "^2.0.1",
"brocc... | true |
Other | emberjs | ember.js | 32b79662675b2a1ba0db836f72fd8fb5f433be85.json | WIP: Upgrade glimmer-vm to 0.29.10
There is much left to do here. This is just the first pass, where I have
done nothing but try to clear out the errors caused by the upgrade. Not
all of the errors are cleared yet, largely because several exports from
glimmer-vm have been removed and I don't know how to replace them (... | packages/ember-glimmer/lib/component-managers/abstract.ts | @@ -1,13 +1,14 @@
-import { ProgramSymbolTable } from '@glimmer/interfaces';
+import {
+ ComponentCapabilities,
+} from '@glimmer/interfaces';
import { Tag, VersionedPathReference } from '@glimmer/reference';
import {
Bounds,
- CompiledDynamicTemplate,
- ComponentDefinition,
ComponentManager,
DynamicScope... | true |
Other | emberjs | ember.js | 32b79662675b2a1ba0db836f72fd8fb5f433be85.json | WIP: Upgrade glimmer-vm to 0.29.10
There is much left to do here. This is just the first pass, where I have
done nothing but try to clear out the errors caused by the upgrade. Not
all of the errors are cleared yet, largely because several exports from
glimmer-vm have been removed and I don't know how to replace them (... | packages/ember-glimmer/lib/component-managers/curly.ts | @@ -1,4 +1,3 @@
-import { Option } from '@glimmer/interfaces';
import {
combineTagged,
Tag,
@@ -7,19 +6,22 @@ import {
import {
Arguments,
Bounds,
- CompiledDynamicProgram,
- ComponentClass,
ComponentDefinition,
- ComponentManager,
ElementOperations,
+ Invocation,
NamedArguments,
Positiona... | true |
Other | emberjs | ember.js | 32b79662675b2a1ba0db836f72fd8fb5f433be85.json | WIP: Upgrade glimmer-vm to 0.29.10
There is much left to do here. This is just the first pass, where I have
done nothing but try to clear out the errors caused by the upgrade. Not
all of the errors are cleared yet, largely because several exports from
glimmer-vm have been removed and I don't know how to replace them (... | packages/ember-glimmer/lib/component-managers/definition-state.ts | @@ -0,0 +1,28 @@
+import {
+ ComponentCapabilities,
+ ProgramSymbolTable,
+ VMHandle
+} from '@glimmer/interfaces';
+import {
+ Option
+} from '@glimmer/util';
+
+export const CAPABILITIES: ComponentCapabilities = {
+ dynamicLayout: true,
+ dynamicTag: true,
+ prepareArgs: false,
+ createArgs: true,
+ attribut... | true |
Other | emberjs | ember.js | 32b79662675b2a1ba0db836f72fd8fb5f433be85.json | WIP: Upgrade glimmer-vm to 0.29.10
There is much left to do here. This is just the first pass, where I have
done nothing but try to clear out the errors caused by the upgrade. Not
all of the errors are cleared yet, largely because several exports from
glimmer-vm have been removed and I don't know how to replace them (... | packages/ember-glimmer/lib/component-managers/mount.ts | @@ -2,21 +2,29 @@ import {
Arguments,
ComponentDefinition,
} from '@glimmer/runtime';
+import {
+ ComponentCapabilities,
+ VMHandle
+} from '@glimmer/interfaces';
import {
Destroyable,
Opaque,
Option
} from '@glimmer/util';
import {
+ Tag,
VersionedPathReference
} from '@glimmer/reference';
i... | true |
Other | emberjs | ember.js | 32b79662675b2a1ba0db836f72fd8fb5f433be85.json | WIP: Upgrade glimmer-vm to 0.29.10
There is much left to do here. This is just the first pass, where I have
done nothing but try to clear out the errors caused by the upgrade. Not
all of the errors are cleared yet, largely because several exports from
glimmer-vm have been removed and I don't know how to replace them (... | packages/ember-glimmer/lib/component-managers/outlet.ts | @@ -1,10 +1,16 @@
-import { Option } from '@glimmer/interfaces';
+import {
+ ComponentCapabilities,
+ Option
+} from '@glimmer/interfaces';
import {
Arguments,
ComponentDefinition,
DynamicScope,
- Environment,
+ Environment
} from '@glimmer/runtime';
+import {
+ Tag
+} from '@glimmer/reference';
import... | true |
Other | emberjs | ember.js | 32b79662675b2a1ba0db836f72fd8fb5f433be85.json | WIP: Upgrade glimmer-vm to 0.29.10
There is much left to do here. This is just the first pass, where I have
done nothing but try to clear out the errors caused by the upgrade. Not
all of the errors are cleared yet, largely because several exports from
glimmer-vm have been removed and I don't know how to replace them (... | packages/ember-glimmer/lib/component-managers/render.ts | @@ -1,20 +1,27 @@
import {
- ComponentDefinition,
- ComponentManager,
+ ComponentCapabilities,
+} from '@glimmer/interfaces';
+import {
+ Tag
+} from '@glimmer/reference';
+import {
+ Arguments,
+ ComponentDefinition
} from '@glimmer/runtime';
-import { IArguments } from '@glimmer/runtime/dist/types/lib/vm/argu... | true |
Other | emberjs | ember.js | 32b79662675b2a1ba0db836f72fd8fb5f433be85.json | WIP: Upgrade glimmer-vm to 0.29.10
There is much left to do here. This is just the first pass, where I have
done nothing but try to clear out the errors caused by the upgrade. Not
all of the errors are cleared yet, largely because several exports from
glimmer-vm have been removed and I don't know how to replace them (... | packages/ember-glimmer/lib/component-managers/root.ts | @@ -1,7 +1,13 @@
+import {
+ VMHandle
+} from '@glimmer/interfaces';
import {
Arguments,
ComponentDefinition
} from '@glimmer/runtime';
+import {
+ Option
+} from '@glimmer/util';
import { DEBUG } from 'ember-env-flags';
import {
_instrumentStart,
@@ -10,13 +16,16 @@ import ComponentStateBucket from '../... | true |
Other | emberjs | ember.js | 32b79662675b2a1ba0db836f72fd8fb5f433be85.json | WIP: Upgrade glimmer-vm to 0.29.10
There is much left to do here. This is just the first pass, where I have
done nothing but try to clear out the errors caused by the upgrade. Not
all of the errors are cleared yet, largely because several exports from
glimmer-vm have been removed and I don't know how to replace them (... | packages/ember-glimmer/lib/environment.ts | @@ -1,20 +1,22 @@
+import {
+ Simple,
+ VMHandle
+} from '@glimmer/interfaces';
+import {
+ WrappedBuilder
+} from '@glimmer/opcode-compiler';
import {
Reference,
} from '@glimmer/reference';
import {
- AttributeManager,
- CompilableLayout,
- CompiledDynamicProgram,
- compileLayout,
ComponentDefinition,... | true |
Other | emberjs | ember.js | 32b79662675b2a1ba0db836f72fd8fb5f433be85.json | WIP: Upgrade glimmer-vm to 0.29.10
There is much left to do here. This is just the first pass, where I have
done nothing but try to clear out the errors caused by the upgrade. Not
all of the errors are cleared yet, largely because several exports from
glimmer-vm have been removed and I don't know how to replace them (... | packages/ember-glimmer/lib/helpers/component.ts | @@ -4,7 +4,6 @@
import {
Arguments,
Environment,
- isComponentDefinition,
VM
} from '@glimmer/runtime';
import { assert } from 'ember-debug';
@@ -217,7 +216,9 @@ function createCurriedDefinition(definition: CurlyComponentDefinition, args: Arg
return new CurlyComponentDefinition(
definition.name,
... | true |
Other | emberjs | ember.js | 32b79662675b2a1ba0db836f72fd8fb5f433be85.json | WIP: Upgrade glimmer-vm to 0.29.10
There is much left to do here. This is just the first pass, where I have
done nothing but try to clear out the errors caused by the upgrade. Not
all of the errors are cleared yet, largely because several exports from
glimmer-vm have been removed and I don't know how to replace them (... | packages/ember-glimmer/lib/helpers/concat.ts | @@ -1,7 +1,6 @@
import {
Arguments,
CapturedArguments,
- normalizeTextValue,
VM
} from '@glimmer/runtime';
import { InternalHelperReference } from '../utils/references'; | true |
Other | emberjs | ember.js | 32b79662675b2a1ba0db836f72fd8fb5f433be85.json | WIP: Upgrade glimmer-vm to 0.29.10
There is much left to do here. This is just the first pass, where I have
done nothing but try to clear out the errors caused by the upgrade. Not
all of the errors are cleared yet, largely because several exports from
glimmer-vm have been removed and I don't know how to replace them (... | packages/ember-glimmer/lib/modifiers/action.ts | @@ -1,11 +1,19 @@
+import {
+ Simple
+} from '@glimmer/interfaces';
+import {
+ TagWrapper
+} from '@glimmer/reference';
import {
Arguments,
CapturedNamedArguments,
CapturedPositionalArguments,
DynamicScope,
- Simple
+ ModifierManager,
} from '@glimmer/runtime';
-import { Destroyable } from '@glimmer/... | true |
Other | emberjs | ember.js | 32b79662675b2a1ba0db836f72fd8fb5f433be85.json | WIP: Upgrade glimmer-vm to 0.29.10
There is much left to do here. This is just the first pass, where I have
done nothing but try to clear out the errors caused by the upgrade. Not
all of the errors are cleared yet, largely because several exports from
glimmer-vm have been removed and I don't know how to replace them (... | packages/ember-glimmer/lib/syntax/mount.ts | @@ -113,6 +113,7 @@ class DynamicEngineReference {
}
this._lastName = nameOrDef;
+ // TODO: maybe I've got the MountDefinition constructor wrong...
this._lastDef = new MountDefinition(nameOrDef);
return this._lastDef; | true |
Other | emberjs | ember.js | 32b79662675b2a1ba0db836f72fd8fb5f433be85.json | WIP: Upgrade glimmer-vm to 0.29.10
There is much left to do here. This is just the first pass, where I have
done nothing but try to clear out the errors caused by the upgrade. Not
all of the errors are cleared yet, largely because several exports from
glimmer-vm have been removed and I don't know how to replace them (... | packages/ember-glimmer/lib/template.ts | @@ -25,8 +25,6 @@ export class WrappedTemplateFactory {
constructor(public factory: TemplateFactory<{
moduleName: string;
- }, {
- owner: Container;
}>) {
this.id = factory.id;
this.meta = factory.meta; | true |
Other | emberjs | ember.js | 32b79662675b2a1ba0db836f72fd8fb5f433be85.json | WIP: Upgrade glimmer-vm to 0.29.10
There is much left to do here. This is just the first pass, where I have
done nothing but try to clear out the errors caused by the upgrade. Not
all of the errors are cleared yet, largely because several exports from
glimmer-vm have been removed and I don't know how to replace them (... | packages/ember-glimmer/lib/utils/bindings.ts | @@ -1,15 +1,17 @@
-import { Opaque, Option } from '@glimmer/interfaces';
+import {
+ Opaque,
+ Option,
+ Simple
+} from '@glimmer/interfaces';
import {
CachedReference,
combine,
map,
Reference,
- referenceFromParts,
Tag,
} from '@glimmer/reference';
import {
- ElementOperations,
- Simple
+ Elem... | true |
Other | emberjs | ember.js | 32b79662675b2a1ba0db836f72fd8fb5f433be85.json | WIP: Upgrade glimmer-vm to 0.29.10
There is much left to do here. This is just the first pass, where I have
done nothing but try to clear out the errors caused by the upgrade. Not
all of the errors are cleared yet, largely because several exports from
glimmer-vm have been removed and I don't know how to replace them (... | yarn.lock | @@ -2,78 +2,117 @@
# yarn lockfile v1
-"@glimmer/compiler@^0.25.6":
- version "0.25.6"
- resolved "https://registry.yarnpkg.com/@glimmer/compiler/-/compiler-0.25.6.tgz#dcc2b8bfa6f36b70c34e41e85626f888315d3ad7"
- dependencies:
- "@glimmer/interfaces" "^0.25.6"
- "@glimmer/syntax" "^0.25.6"
- "@glimmer/u... | true |
Other | emberjs | ember.js | c432844ce4666d9a0813e026d22a85ccc0541d37.json | Add 2.17.0-beta.4 to CHANGELOG
[ci skip]
(cherry picked from commit 96671cbe447b091968120780a29425d5acd055fb) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### 2.17.0-beta.4 (October 30, 2017)
+- [#15746](https://github.com/emberjs/ember.js/pull/15746) [BUGFIX] Fix computed sort regression when array property is initally `null`.
+- [#15777](https://github.com/emberjs/ember.js/pull/15777) [BUGFIX] Fix various issues around accessing dy... | false |
Other | emberjs | ember.js | 53bfb16e72f0493f4ab6d4c73f6296b271527209.json | run node-tests through eslint | node-tests/.eslintrc.js | @@ -0,0 +1,9 @@
+module.exports = {
+ env: {
+ mocha: true,
+ node: true,
+ },
+ rules: {
+ 'semi': 'error',
+ },
+}; | true |
Other | emberjs | ember.js | 53bfb16e72f0493f4ab6d4c73f6296b271527209.json | run node-tests through eslint | node-tests/blueprints/component-test.js | @@ -263,10 +263,8 @@ describe('Acceptance: ember generate component', function() {
.to.contain("integration: true");
}));
});
- /**
- * Pod tests
- *
- */
+
+ // Pod tests
it('component x-foo --pod', function() {
var args = ['component', 'x-foo', '--pod'];
@@ -751,7 +749,7 @@ desc... | true |
Other | emberjs | ember.js | 53bfb16e72f0493f4ab6d4c73f6296b271527209.json | run node-tests through eslint | package.json | @@ -34,7 +34,7 @@
"start": "ember serve",
"pretest": "ember build",
"prepare": "ember build -prod",
- "lint": "tslint -p tsconfig.json",
+ "lint": "tslint -p tsconfig.json && eslint node-tests",
"test": "node bin/run-tests.js",
"test:blueprints": "node node-tests/nodetest-runner.js",
... | true |
Other | emberjs | ember.js | 5b30f6ebfc2392603cdf0b225d112b2f4f26cc98.json | remove unused requires in eslint config | .eslintrc.js | @@ -1,7 +1,4 @@
-var fs = require('fs');
-var path = require('path');
-
-var options = {
+module.exports = {
root: true,
parserOptions: {
ecmaVersion: 6,
@@ -43,5 +40,3 @@ var options = {
'comma-dangle': 'off',
},
};
-
-module.exports = options; | false |
Other | emberjs | ember.js | 896ce04ed0797a503672db0a5c56d28e7b4074ad.json | use fixture for helper-addon blueprint test | node-tests/blueprints/helper-test.js | @@ -53,7 +53,7 @@ describe('Acceptance: ember generate and destroy helper', function() {
expect(_file('addon/helpers/foo/bar-baz.js'))
.to.equal(file('helper.js'));
expect(_file('app/helpers/foo/bar-baz.js'))
- .to.contain("export { default, fooBarBaz } from 'my-addon/helpers/foo/b... | true |
Other | emberjs | ember.js | 896ce04ed0797a503672db0a5c56d28e7b4074ad.json | use fixture for helper-addon blueprint test | node-tests/fixtures/helper-addon.js | @@ -0,0 +1 @@
+export { default, fooBarBaz } from 'my-addon/helpers/foo/bar-baz'; | true |
Other | emberjs | ember.js | b8914d1217ae89df13402e6973395a0c8479048b.json | fix newlines in integration helper test blueprint | blueprints/helper-test/qunit-files/tests/__testType__/helpers/__name__-test.js | @@ -1,5 +1,4 @@
-<% if (testType == 'integration') { %>
-import { moduleForComponent, test } from 'ember-qunit';
+<% if (testType == 'integration') { %>import { moduleForComponent, test } from 'ember-qunit';
import hbs from 'htmlbars-inline-precompile';
moduleForComponent('<%= dasherizedModuleName %>', 'helper:<%= ... | true |
Other | emberjs | ember.js | b8914d1217ae89df13402e6973395a0c8479048b.json | fix newlines in integration helper test blueprint | node-tests/fixtures/helper-test/integration.js | @@ -1,4 +1,3 @@
-
import { moduleForComponent, test } from 'ember-qunit';
import hbs from 'htmlbars-inline-precompile';
@@ -14,4 +13,3 @@ test('it renders', function(assert) {
assert.equal(this.$().text().trim(), '1234');
});
- | true |
Other | emberjs | ember.js | cb8dc6c82bde289f4339d65c0c0a53ddf1a233ca.json | add test coverage of helper unit test
will fix new line issues in followup | node-tests/blueprints/helper-test.js | @@ -33,6 +33,23 @@ describe('Acceptance: ember generate and destroy helper', function() {
}));
});
+ it('helper foo/bar-baz unit', function() {
+ var args = ['helper', '--test-type=unit', 'foo/bar-baz'];
+
+ return emberNew()
+ .then(() => emberGenerateDestroy(args, _file => {
+ expect(_f... | true |
Other | emberjs | ember.js | cb8dc6c82bde289f4339d65c0c0a53ddf1a233ca.json | add test coverage of helper unit test
will fix new line issues in followup | node-tests/fixtures/helper-test/unit.js | @@ -0,0 +1,12 @@
+
+import { fooBarBaz } from 'my-app/helpers/foo/bar-baz';
+import { module, test } from 'qunit';
+
+module('Unit | Helper | foo/bar baz');
+
+// Replace this with your real tests.
+test('it works', function(assert) {
+ let result = fooBarBaz([42]);
+ assert.ok(result);
+});
+ | true |
Other | emberjs | ember.js | d90545005d1cae84705bb0f2635ab0c10b106e8a.json | Add CHANGELOG for 2.16.2.
[ci skip]
(cherry picked from commit 7538da2cd04157d4a513509e71a830e9c6672d69)
(cherry picked from commit 09a5fe326961bf0a21c2852402ec11b8034f279a) | CHANGELOG.md | @@ -16,6 +16,10 @@
- [#15265](https://github.com/emberjs/ember.js/pull/15265) [BUGFIX] fixed issue when passing `false` to `activeClass` for `{{link-to}}`
- [#15672](https://github.com/emberjs/ember.js/pull/15672) Update router_js to 2.0.0.
+### 2.16.2 (November 1, 2017)
+
+- [#15797](https://github.com/emberjs/emb... | false |
Other | emberjs | ember.js | 19bbc77f82140140975610727be11293ccd21c7c.json | Remove duplicate dependency | package.json | @@ -41,7 +41,6 @@
"test:testem": "testem -f testem.dist.json"
},
"dependencies": {
- "broccoli-funnel": "^1.2.0",
"broccoli-funnel": "^2.0.1",
"broccoli-merge-trees": "^2.0.0",
"ember-cli-get-component-path-option": "^1.0.0", | false |
Other | emberjs | ember.js | 3e5d79be58a34bbcc0d441f59c1f77dadf8efb9f.json | remove unused babel plugins | package.json | @@ -66,8 +66,6 @@
"aws-sdk": "^2.46.0",
"babel-plugin-check-es2015-constants": "^6.22.0",
"babel-plugin-debug-macros": "^0.1.10",
- "babel-plugin-feature-flags": "^0.3.1",
- "babel-plugin-filter-imports": "^0.3.1",
"babel-plugin-minify-dead-code-elimination": "^0.2.0",
"babel-plugin-trans... | true |
Other | emberjs | ember.js | 3e5d79be58a34bbcc0d441f59c1f77dadf8efb9f.json | remove unused babel plugins | yarn.lock | @@ -646,14 +646,6 @@ babel-plugin-eval@^1.0.1:
version "1.0.1"
resolved "https://registry.yarnpkg.com/babel-plugin-eval/-/babel-plugin-eval-1.0.1.tgz#a2faed25ce6be69ade4bfec263f70169195950da"
-babel-plugin-feature-flags@^0.3.1:
- version "0.3.1"
- resolved "https://registry.yarnpkg.com/babel-plugin-feature-fl... | true |
Other | emberjs | ember.js | 8032640f5e51ffd3692dd68cd64b86f915275186.json | fix lint warnings | packages/ember-glimmer/lib/components/link-to.ts | @@ -311,8 +311,6 @@
@public
*/
-import Logger from 'ember-console';
-import { assert, deprecate } from 'ember-debug';
import { DEBUG } from 'ember-env-flags';
import { assert, deprecate, warn } from 'ember-debug';
import {
@@ -655,7 +653,7 @@ const LinkComponent = EmberComponent.extend({
if (get(this, '... | false |
Other | emberjs | ember.js | 8f3ec0523780e799751656842aff3265e4c7c23a.json | Add 2.16.1 to CHANGELOG.
[ci skip] | CHANGELOG.md | @@ -16,6 +16,13 @@
- [#15265](https://github.com/emberjs/ember.js/pull/15265) [BUGFIX] fixed issue when passing `false` to `activeClass` for `{{link-to}}`
- [#15672](https://github.com/emberjs/ember.js/pull/15672) Update router_js to 2.0.0.
+### 2.16.1 (October 29, 2017)
+
+- [#15722](https://github.com/emberjs/emb... | false |
Other | emberjs | ember.js | a8a8059de482d6f636b99d1d1c82c5341a4da684.json | avoid bool coercion in `Registry` | packages/container/lib/registry.js | @@ -223,7 +223,7 @@ export default class Registry {
resolve(fullName, options) {
assert('fullName must be a proper full name', this.validateFullName(fullName));
let factory = resolve(this, this.normalize(fullName), options);
- if (factory === undefined && this.fallback) {
+ if (factory === undefined ... | false |
Other | emberjs | ember.js | 3b22f49e857f959edc8b5bfeca5dbfff47b38b25.json | convert throws to assertions in `Registry` | packages/container/lib/registry.js | @@ -139,16 +139,10 @@ export default class Registry {
*/
register(fullName, factory, options = {}) {
assert('fullName must be a proper full name', this.validateFullName(fullName));
-
- if (factory === undefined) {
- throw new TypeError(`Attempting to register an unknown factory: '${fullName}'`);
- ... | true |
Other | emberjs | ember.js | 3b22f49e857f959edc8b5bfeca5dbfff47b38b25.json | convert throws to assertions in `Registry` | packages/container/tests/registry_test.js | @@ -62,7 +62,7 @@ QUnit.test('Throw exception when trying to inject `type:thing` on all type(s)',
registry.register('controller:post', PostController);
- throws(() => {
+ expectAssertion(() => {
registry.typeInjection('controller', 'injected', 'controller:post');
}, /Cannot inject a 'controller:post' o... | true |
Other | emberjs | ember.js | bc550ed597a70e6c1f15f22b3a9d6f574cbcf547.json | avoid extra boolean conversion | packages/ember-routing/lib/system/router.js | @@ -116,10 +116,8 @@ const EmberRouter = EmberObject.extend(Evented, {
},
_buildDSL() {
- let moduleBasedResolver = this._hasModuleBasedResolver();
- let options = {
- enableLoadingSubstates: !!moduleBasedResolver
- };
+ let enableLoadingSubstates = this._hasModuleBasedResolver();
+ let opti... | false |
Other | emberjs | ember.js | 64da9d6fcab25e34af916917f992fef627510594.json | use strippable `warn` in `link-to` | packages/ember-console/lib/index.js | @@ -56,7 +56,7 @@ export default {
@param {*} arguments
@public
*/
- log: consoleMethod('log') || K,
+ log: consoleMethod('log') || K,
/**
Prints the arguments to the console with a warning icon.
@@ -72,7 +72,7 @@ export default {
@param {*} arguments
@public
*/
- warn: consoleMet... | true |
Other | emberjs | ember.js | 64da9d6fcab25e34af916917f992fef627510594.json | use strippable `warn` in `link-to` | packages/ember-glimmer/lib/components/link-to.ts | @@ -314,6 +314,7 @@
import Logger from 'ember-console';
import { assert, deprecate } from 'ember-debug';
import { DEBUG } from 'ember-env-flags';
+import { assert, deprecate, warn } from 'ember-debug';
import {
computed,
flaggedInstrument,
@@ -654,7 +655,7 @@ const LinkComponent = EmberComponent.extend({
... | true |
Other | emberjs | ember.js | 64da9d6fcab25e34af916917f992fef627510594.json | use strippable `warn` in `link-to` | packages/ember/tests/helpers/link_to_test.js | @@ -1430,20 +1430,9 @@ moduleFor('The {{link-to}} helper - nested routes and link-to arguments', class
moduleFor('The {{link-to}} helper - loading states and warnings', class extends ApplicationTestCase {
- constructor() {
- super();
- this._oldWarn = Logger.warn;
- this.warnCalled = false;
- Logger.w... | true |
Other | emberjs | ember.js | bb01997f2edf3baa868ae600c523de9bb05fda1c.json | Add types to the rest of /helpers | packages/ember-glimmer/lib/helpers/if-unless.ts | @@ -1,5 +1,6 @@
/**
@module ember
+@submodule ember-glimmer
*/
import {
@@ -9,6 +10,11 @@ import {
TagWrapper,
UpdatableTag,
} from '@glimmer/reference';
+import {
+ Arguments,
+ PrimitiveReference,
+ VM
+} from '@glimmer/runtime'
import { assert } from 'ember-debug';
import {
CachedReference,
@@ -... | true |
Other | emberjs | ember.js | bb01997f2edf3baa868ae600c523de9bb05fda1c.json | Add types to the rest of /helpers | packages/ember-glimmer/lib/helpers/loc.ts | @@ -2,6 +2,12 @@
/**
@module ember
*/
+
+import {
+ Arguments,
+ CapturedArguments,
+ VM
+} from '@glimmer/runtime';
import { String as StringUtils } from 'ember-runtime';
import { InternalHelperReference } from '../utils/references';
@@ -37,10 +43,10 @@ import { InternalHelperReference } from '../utils/refer... | true |
Other | emberjs | ember.js | bb01997f2edf3baa868ae600c523de9bb05fda1c.json | Add types to the rest of /helpers | packages/ember-glimmer/lib/helpers/log.ts | @@ -1,3 +1,8 @@
+import {
+ Arguments,
+ CapturedArguments,
+ VM
+} from '@glimmer/runtime';
import { InternalHelperReference } from '../utils/references';
/**
@module ember
@@ -18,10 +23,10 @@ import Logger from 'ember-console';
@param {Array} params
@public
*/
-function log({ positional }) {
+function lo... | true |
Other | emberjs | ember.js | bb01997f2edf3baa868ae600c523de9bb05fda1c.json | Add types to the rest of /helpers | packages/ember-glimmer/lib/helpers/mut.ts | @@ -1,6 +1,10 @@
/**
@module ember
*/
+import {
+ Arguments,
+ VM
+} from '@glimmer/runtime';
import { assert } from 'ember-debug';
import { symbol } from 'ember-utils';
import { UPDATE } from '../utils/references';
@@ -78,15 +82,15 @@ import { INVOKE } from './action';
const MUT_REFERENCE = symbol('MUT');
co... | true |
Other | emberjs | ember.js | bb01997f2edf3baa868ae600c523de9bb05fda1c.json | Add types to the rest of /helpers | packages/ember-glimmer/lib/helpers/query-param.ts | @@ -1,6 +1,11 @@
/**
@module ember
*/
+import {
+ Arguments,
+ CapturedArguments,
+ VM
+} from '@glimmer/runtime';
import { assert } from 'ember-debug';
import { QueryParams } from 'ember-routing';
import { assign } from 'ember-utils';
@@ -22,7 +27,7 @@ import { InternalHelperReference } from '../utils/referen... | true |
Other | emberjs | ember.js | bb01997f2edf3baa868ae600c523de9bb05fda1c.json | Add types to the rest of /helpers | packages/ember-glimmer/lib/helpers/readonly.ts | @@ -1,6 +1,10 @@
/**
@module ember
*/
+import {
+ Arguments,
+ VM
+} from '@glimmer/runtime';
import { UPDATE } from '../utils/references';
import { unMut } from './mut';
@@ -102,7 +106,7 @@ import { unMut } from './mut';
@for Ember.Templates.helpers
@private
*/
-export default function(_vm, args) {
+ex... | true |
Other | emberjs | ember.js | bb01997f2edf3baa868ae600c523de9bb05fda1c.json | Add types to the rest of /helpers | packages/ember-glimmer/lib/helpers/unbound.ts | @@ -2,6 +2,10 @@
@module ember
*/
+import {
+ Arguments,
+ VM
+} from '@glimmer/runtime';
import { assert } from 'ember-debug';
import { UnboundReference } from '../utils/references';
@@ -33,7 +37,7 @@ import { UnboundReference } from '../utils/references';
@public
*/
-export default function(_vm, args)... | true |
Other | emberjs | ember.js | bb01997f2edf3baa868ae600c523de9bb05fda1c.json | Add types to the rest of /helpers | packages/ember-routing/lib/index.d.ts | @@ -195,7 +195,8 @@ export const Route: {
};
export const QueryParams: {
isQueryParams: boolean;
- values: any
+ values: any;
+ create(obj: any): any;
};
export const RoutingService: {
router: any; | true |
Other | emberjs | ember.js | c2a5884b0d6ed480ec4f78e49a66681cf16a829e.json | Use actual types (mostly) for component-managers/
There are a few uses of `any` still, and a few errors I'm still trying
to figure out. | packages/ember-glimmer/lib/component-managers/curly.ts | @@ -141,7 +141,7 @@ export class PositionalArgumentReference {
}
export default class CurlyComponentManager extends AbstractManager<ComponentStateBucket> {
- prepareArgs(definition: ComponentDefinition<ComponentStateBucket>, args: Arguments): Option<PreparedArguments> {
+ prepareArgs(definition: CurlyComponentDef... | true |
Other | emberjs | ember.js | c2a5884b0d6ed480ec4f78e49a66681cf16a829e.json | Use actual types (mostly) for component-managers/
There are a few uses of `any` still, and a few errors I'm still trying
to figure out. | packages/ember-glimmer/lib/component-managers/outlet.ts | @@ -1,5 +1,6 @@
import { Option } from '@glimmer/interfaces';
import {
+ Arguments,
ComponentDefinition,
DynamicScope,
Environment,
@@ -9,10 +10,11 @@ import { DEBUG } from 'ember-env-flags';
import { _instrumentStart } from 'ember-metal';
import { generateGuid, guidFor } from 'ember-utils';
import Ember... | true |
Other | emberjs | ember.js | c2a5884b0d6ed480ec4f78e49a66681cf16a829e.json | Use actual types (mostly) for component-managers/
There are a few uses of `any` still, and a few errors I'm still trying
to figure out. | packages/ember-glimmer/lib/component-managers/render.ts | @@ -1,23 +1,25 @@
import {
ComponentDefinition,
+ ComponentManager
} from '@glimmer/runtime';
import { IArguments } from '@glimmer/runtime/dist/types/lib/vm/arguments';
import { Destroyable } from '@glimmer/util';
import { DEBUG } from 'ember-env-flags';
import { generateController, generateControllerFactor... | true |
Other | emberjs | ember.js | c2a5884b0d6ed480ec4f78e49a66681cf16a829e.json | Use actual types (mostly) for component-managers/
There are a few uses of `any` still, and a few errors I'm still trying
to figure out. | packages/ember-glimmer/lib/component-managers/root.ts | @@ -1,5 +1,6 @@
import {
- ComponentDefinition,
+ Arguments,
+ ComponentDefinition
} from '@glimmer/runtime';
import { DEBUG } from 'ember-env-flags';
import {
@@ -9,10 +10,13 @@ import ComponentStateBucket from '../utils/curly-component-state-bucket';
import CurlyComponentManager, {
initialRenderInstrumentD... | true |
Other | emberjs | ember.js | c2a5884b0d6ed480ec4f78e49a66681cf16a829e.json | Use actual types (mostly) for component-managers/
There are a few uses of `any` still, and a few errors I'm still trying
to figure out. | packages/ember-routing/lib/index.d.ts | @@ -63,7 +63,7 @@ export const AutoLocation: {
};
export function generateController(owner: any, controllerName: string): any;
-export function generateControllerFactory(owner: any, controllerName: string, context: any): any;
+export function generateControllerFactory(owner: any, controllerName: string, context?: a... | true |
Other | emberjs | ember.js | b7abdfb14f94db3e22044dd2ea0055dfaa1227b9.json | Use WrappedTemplateFactory as template type | packages/ember-glimmer/lib/component-managers/curly.ts | @@ -43,6 +43,7 @@ import {
} from '../component';
import Environment from '../environment';
import { DynamicScope } from '../renderer';
+import { WrappedTemplateFactory } from '../template';
import {
AttributeBinding,
ClassNameBinding,
@@ -105,9 +106,9 @@ function ariaRole(vm: VM) {
class CurlyComponentLay... | true |
Other | emberjs | ember.js | b7abdfb14f94db3e22044dd2ea0055dfaa1227b9.json | Use WrappedTemplateFactory as template type | packages/ember-glimmer/lib/environment.ts | @@ -227,7 +227,7 @@ export default class Environment extends GlimmerEnvironment {
// normally templates should be exported at the proper module name
// and cached in the container, but this cache supports templates
// that have been set directly on the component's layout property
- getTemplate(Template, owner... | true |
Other | emberjs | ember.js | d53214afed6550f593298f137e58354b061f925b.json | Add better types for ember-routing | packages/ember-glimmer/lib/component-managers/curly.ts | @@ -16,6 +16,7 @@ import {
PreparedArguments,
PrimitiveReference,
Simple,
+ VM,
} from '@glimmer/runtime';
import { Opaque, Destroyable } from '@glimmer/util';
import { Option } from '@glimmer/interfaces';
@@ -91,14 +92,14 @@ function applyAttributeBindings(element: Simple.Element, attributeBindings: any,
... | true |
Other | emberjs | ember.js | d53214afed6550f593298f137e58354b061f925b.json | Add better types for ember-routing | packages/ember-routing/lib/index.d.ts | @@ -1,16 +1,229 @@
-export const Location: any;
-export const NoneLocation: any;
-export const HashLocation: any;
-export const HistoryLocation: any;
-export const AutoLocation: any;
-
-export const generateController: any;
-export const generateControllerFactory: any;
-export const controllerFor: any;
-export const Ro... | true |
Other | emberjs | ember.js | d53214afed6550f593298f137e58354b061f925b.json | Add better types for ember-routing | packages/ember-routing/lib/location/none_location.js | @@ -93,7 +93,7 @@ export default EmberObject.extend({
@private
@method handleURL
- @param callback {Function}
+ @param url {String}
*/
handleURL(url) {
set(this, 'path', url); | true |
Other | emberjs | ember.js | 145711188a89a8cbdec0edc281d96cd74ba5780f.json | add more typing | packages/ember-environment/lib/index.d.ts | @@ -0,0 +1,10 @@
+export const environment: {
+ hasDOM: boolean;
+ isChrome: boolean;
+ isFirefox: boolean;
+ isPhantom: boolean;
+ location: Location | null;
+ history: History | null;
+ userAgent: string;
+ window: Window | null;
+}; | true |
Other | emberjs | ember.js | 145711188a89a8cbdec0edc281d96cd74ba5780f.json | add more typing | packages/ember-glimmer/lib/component-managers/curly.ts | @@ -3,6 +3,7 @@ import {
ComponentDefinition,
PrimitiveReference,
} from '@glimmer/runtime';
+import { Opaque } from '@glimmer/util';
import { privatize as P } from 'container';
import {
assert,
@@ -14,7 +15,6 @@ import {
} from 'ember-metal';
import {
assign,
- Opaque,
OWNER,
} from 'ember-utils'... | true |
Other | emberjs | ember.js | 145711188a89a8cbdec0edc281d96cd74ba5780f.json | add more typing | packages/ember-glimmer/lib/component.ts | @@ -617,11 +617,14 @@ const Component = CoreView.extend(
this._super();
},
- __defineNonEnumerable(property) {
+ __defineNonEnumerable(property: {
+ name: string;
+ descriptor: { value: any }
+ }) {
this[property.name] = property.descriptor.value;
},
- [PROPERTY_DID_CHA... | true |
Other | emberjs | ember.js | 145711188a89a8cbdec0edc281d96cd74ba5780f.json | add more typing | packages/ember-glimmer/lib/utils/string.ts | @@ -7,7 +7,7 @@ import { deprecate } from 'ember-debug';
export class SafeString {
public string: string;
- constructor(string) {
+ constructor(string: string) {
this.string = string;
}
@@ -49,11 +49,11 @@ const escape = {
const possible = /[&<>"'`=]/;
const badChars = /[&<>"'`=]/g;
-function esca... | true |
Other | emberjs | ember.js | 145711188a89a8cbdec0edc281d96cd74ba5780f.json | add more typing | packages/ember-glimmer/lib/utils/to-bool.ts | @@ -1,7 +1,8 @@
+import { Opaque } from '@glimmer/interfaces';
import { get } from 'ember-metal';
import { isArray } from 'ember-runtime';
-export default function toBool(predicate) {
+export default function toBool(predicate: Opaque) {
if (!predicate) {
return false;
} | true |
Other | emberjs | ember.js | 145711188a89a8cbdec0edc281d96cd74ba5780f.json | add more typing | packages/ember-glimmer/lib/views/outlet.ts | @@ -14,7 +14,7 @@ export class RootOutletStateReference implements VersionedPathReference<Option<O
this.tag = outletView._tag;
}
- get(key: string): VersionedPathReference<Option<OutletState>> {
+ get(key: string): VersionedPathReference<any> {
return new ChildOutletStateReference(this, key);
}
@@... | true |
Other | emberjs | ember.js | 145711188a89a8cbdec0edc281d96cd74ba5780f.json | add more typing | packages/ember-runtime/lib/index.d.ts | @@ -0,0 +1,23 @@
+export const TargetActionSupport: any;
+export function isArray(arr: any): boolean;
+export const ControllerMixin: any;
+
+export function deprecatingAlias(name: string, opts: {
+ id: string;
+ until: string;
+}): any;
+
+export const inject: {
+ service(name: string): any;
+};
+
+export const Fram... | true |
Other | emberjs | ember.js | 145711188a89a8cbdec0edc281d96cd74ba5780f.json | add more typing | packages/ember-utils/lib/index.d.ts | @@ -0,0 +1,12 @@
+import { Opaque } from '@glimmer/interfaces';
+
+export const NAME_KEY: string;
+export function getOwner(obj: any): any;
+export function symbol(debugName: string): string;
+export function assign(original: any, ...args: any[]): any;
+export const OWNER: string;
+export const HAS_NATIVE_WEAKMAP: bool... | true |
Other | emberjs | ember.js | 145711188a89a8cbdec0edc281d96cd74ba5780f.json | add more typing | packages/ember-utils/lib/symbol.js | @@ -6,5 +6,5 @@ export default function symbol(debugName) {
// want to require non-enumerability for this API, which
// would introduce a large cost.
let id = GUID_KEY + Math.floor(Math.random() * new Date());
- return intern(`__${debugName}__ [id=${id}]`);
+ return intern(`__${debugName}${id}__`);
} | true |
Other | emberjs | ember.js | 145711188a89a8cbdec0edc281d96cd74ba5780f.json | add more typing | packages/ember-views/lib/index.d.ts | @@ -0,0 +1,36 @@
+import { Opaque } from '@glimmer/util';
+
+export const ActionSupport: any;
+export const ChildViewsSupport: any;
+export const ClassNamesSupport: any;
+export const CoreView: any;
+export const ViewMixin: any;
+export const ViewStateSupport: any;
+export const TextSupport: any;
+
+export function get... | true |
Other | emberjs | ember.js | 809720f8dd5dc305f76becb70d7738de99fcdcde.json | add strict null checking | packages/ember-glimmer/lib/component-managers/outlet.ts | @@ -1,13 +1,14 @@
-import { Option } from '@glimmer/interfaces/dist/types';
+import { Option } from '@glimmer/interfaces';
import {
ComponentDefinition,
DynamicScope,
+ Environment,
} from '@glimmer/runtime';
import { Destroyable } from '@glimmer/util/dist/types';
import { DEBUG } from 'ember-env-flags';
-im... | true |
Other | emberjs | ember.js | 809720f8dd5dc305f76becb70d7738de99fcdcde.json | add strict null checking | packages/ember-glimmer/lib/component-managers/render.ts | @@ -38,7 +38,7 @@ class SingletonRenderManager extends AbstractRenderManager {
_args: IArguments,
dynamicScope: DynamicScope) {
let { name } = definition;
- let controller = env.owner.lookup(`controller:${name}`) || generateController(env.owner, name);
+ let controller = env.owner.lookup<... | true |
Other | emberjs | ember.js | 809720f8dd5dc305f76becb70d7738de99fcdcde.json | add strict null checking | packages/ember-glimmer/lib/environment.ts | @@ -6,9 +6,12 @@ import {
CompilableLayout,
CompiledDynamicProgram,
compileLayout,
+ ComponentDefinition,
Environment as GlimmerEnvironment,
getDynamicVar,
+ Helper,
isSafeString,
+ ModifierManager,
PartialDefinition,
} from '@glimmer/runtime';
import {
@@ -90,18 +93,18 @@ export default class... | true |
Other | emberjs | ember.js | 809720f8dd5dc305f76becb70d7738de99fcdcde.json | add strict null checking | packages/ember-glimmer/lib/helpers/action.ts | @@ -1,7 +1,9 @@
/**
@module ember
*/
-import { isConst } from '@glimmer/reference';
+import { isConst, VersionedPathReference } from '@glimmer/reference';
+import { IArguments } from '@glimmer/runtime/dist/types/lib/vm/arguments';
+import { Opaque } from '@glimmer/util';
import { assert } from 'ember-debug';
impor... | true |
Other | emberjs | ember.js | 809720f8dd5dc305f76becb70d7738de99fcdcde.json | add strict null checking | packages/ember-glimmer/lib/helpers/component.ts | @@ -154,7 +154,7 @@ export class ClosureComponentReference extends CachedReference {
public meta: any;
public env: any;
public lastDefinition: any;
- public lastName: string;
+ public lastName: string | undefined;
constructor(args, meta, env) {
super();
@@ -175,7 +175,7 @@ export class ClosureCompo... | true |
Other | emberjs | ember.js | 809720f8dd5dc305f76becb70d7738de99fcdcde.json | add strict null checking | packages/ember-glimmer/lib/modifiers/action.ts | @@ -190,7 +190,7 @@ export default class ActionModifierManager {
}
}
- let actionArgs = [];
+ let actionArgs: any[] = [];
// The first two arguments are (1) `this` and (2) the action name.
// Everything else is a param.
for (let i = 2; i < positional.length; i++) { | true |
Other | emberjs | ember.js | 809720f8dd5dc305f76becb70d7738de99fcdcde.json | add strict null checking | packages/ember-glimmer/lib/renderer.ts | @@ -1,9 +1,11 @@
-import { Simple } from '@glimmer/interfaces';
+import { Option, Simple } from '@glimmer/interfaces';
import { CURRENT_TAG, VersionedPathReference } from '@glimmer/reference';
-import { IteratorResult } from '@glimmer/runtime';
+import {
+ DynamicScope as GlimmerDynamicScope,
+ IteratorResult,
+} fr... | true |
Other | emberjs | ember.js | 809720f8dd5dc305f76becb70d7738de99fcdcde.json | add strict null checking | packages/ember-glimmer/lib/templates/component.d.ts | @@ -1,2 +1,3 @@
-declare const TEMPLATE: any;
+import { WrappedTemplateFactory } from '../template';
+declare const TEMPLATE: WrappedTemplateFactory;
export default TEMPLATE; | true |
Other | emberjs | ember.js | 809720f8dd5dc305f76becb70d7738de99fcdcde.json | add strict null checking | packages/ember-glimmer/lib/templates/empty.d.ts | @@ -1,2 +1,3 @@
-declare const TEMPLATE: any;
+import { WrappedTemplateFactory } from '../template';
+declare const TEMPLATE: WrappedTemplateFactory;
export default TEMPLATE; | true |
Other | emberjs | ember.js | 809720f8dd5dc305f76becb70d7738de99fcdcde.json | add strict null checking | packages/ember-glimmer/lib/templates/link-to.d.ts | @@ -1,2 +1,3 @@
-declare const TEMPLATE: any;
+import { WrappedTemplateFactory } from '../template';
+declare const TEMPLATE: WrappedTemplateFactory;
export default TEMPLATE; | true |
Other | emberjs | ember.js | 809720f8dd5dc305f76becb70d7738de99fcdcde.json | add strict null checking | packages/ember-glimmer/lib/templates/outlet.d.ts | @@ -1,2 +1,3 @@
-declare const TEMPLATE: any;
+import { WrappedTemplateFactory } from '../template';
+declare const TEMPLATE: WrappedTemplateFactory;
export default TEMPLATE; | true |
Other | emberjs | ember.js | 809720f8dd5dc305f76becb70d7738de99fcdcde.json | add strict null checking | packages/ember-glimmer/lib/templates/root.d.ts | @@ -1,2 +1,3 @@
-declare const TEMPLATE: any;
+import { WrappedTemplateFactory } from '../template';
+declare const TEMPLATE: WrappedTemplateFactory;
export default TEMPLATE; | true |
Other | emberjs | ember.js | 809720f8dd5dc305f76becb70d7738de99fcdcde.json | add strict null checking | packages/ember-glimmer/lib/views/outlet.ts | @@ -1,28 +1,28 @@
import { Simple } from '@glimmer/interfaces';
-import { DirtyableTag, VersionedPathReference } from '@glimmer/reference';
+import { DirtyableTag, Tag, TagWrapper, VersionedPathReference } from '@glimmer/reference';
+import { Opaque, Option } from '@glimmer/util';
import { environment } from 'ember-e... | true |
Other | emberjs | ember.js | 809720f8dd5dc305f76becb70d7738de99fcdcde.json | add strict null checking | packages/ember-glimmer/tests/integration/outlet-test.js | @@ -19,7 +19,6 @@ moduleFor('outlet view', class extends RenderingTest {
outlet: 'main',
name: 'application',
controller: undefined,
- ViewClass: undefined,
template: undefined
},
@@ -41,7 +40,6 @@ moduleFor('outlet view', class extends RenderingTest {
outlet... | true |
Other | emberjs | ember.js | 809720f8dd5dc305f76becb70d7738de99fcdcde.json | add strict null checking | packages/ember-routing/lib/system/route.js | @@ -2178,7 +2178,6 @@ let Route = EmberObject.extend(ActionHandler, Evented, {
name: connection.name,
controller: undefined,
template: undefined,
- ViewClass: undefined
};
run.once(this.router, '_setOutlets');
}
@@ -2283,7 +2282,6 @@ function buildRende... | true |
Other | emberjs | ember.js | 809720f8dd5dc305f76becb70d7738de99fcdcde.json | add strict null checking | tests/node/helpers/component-module.js | @@ -74,8 +74,7 @@ function setupComponentTest() {
outlet: 'main',
name: 'application',
controller: module,
- ViewClass: undefined,
- template: OutletTemplate
+ template: OutletTemplate,
},
outlets: { }
@@ -108,7 +107,6 @@ function render(_template) {
outlet: 'main',
... | true |
Other | emberjs | ember.js | 809720f8dd5dc305f76becb70d7738de99fcdcde.json | add strict null checking | tsconfig.json | @@ -19,7 +19,7 @@
"noUnusedLocals": true,
"noUnusedParameters": true,
// "allowUnreachableCode": false,
- // "strictNullChecks": true,
+ "strictNullChecks": true,
"noImplicitReturns": true,
"noImplicitThis": true,
| true |
Other | emberjs | ember.js | d3326e56bcaffd35bee39400f180518138b17920.json | Add stricter typing | packages/ember-glimmer/lib/environment.ts | @@ -3,6 +3,8 @@ import {
} from '@glimmer/reference';
import {
AttributeManager,
+ CompilableLayout,
+ CompiledDynamicProgram,
compileLayout,
Environment as GlimmerEnvironment,
getDynamicVar,
@@ -64,12 +66,21 @@ import {
EMBER_MODULE_UNIFICATION,
GLIMMER_CUSTOM_COMPONENT_MANAGER,
} from 'ember/fe... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.