language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | 4842f036a330a39c57147898ca074c8a66946783.json | remove `router.router` deprecation | packages/ember-routing/lib/system/router.js | @@ -1356,8 +1356,6 @@ function updatePaths(router) {
}
EmberRouter.reopenClass({
- router: null,
-
/**
The `Router.map` function allows you to define mappings from URLs to routes
in your application. These mappings are defined within the
@@ -1583,10 +1581,4 @@ function representEmptyRoute(liveRoutes, ... | true |
Other | emberjs | ember.js | 4842f036a330a39c57147898ca074c8a66946783.json | remove `router.router` deprecation | packages/ember-routing/tests/system/router_test.js | @@ -262,21 +262,3 @@ QUnit.test('Router#triggerEvent ignores handlers that have not loaded yet', func
triggerEvent(handlerInfos, false, ['loading']);
});
-
-QUnit.test('Router#router deprecates when called', function(assert) {
- assert.expect(2);
-
- let router = createRouter();
-
- expectDeprecation(function(... | true |
Other | emberjs | ember.js | acdd288d1ea52cee19587eb3be30857069233fb8.json | add fs-extra to deps | package.json | @@ -55,6 +55,7 @@
"ember-cli-valid-component-name": "^1.0.0",
"ember-cli-version-checker": "^1.3.1",
"ember-router-generator": "^1.2.3",
+ "fs-extra": "^4.0.1",
"inflection": "^1.12.0",
"jquery": "^3.2.1",
"resolve": "^1.3.3", | true |
Other | emberjs | ember.js | acdd288d1ea52cee19587eb3be30857069233fb8.json | add fs-extra to deps | yarn.lock | @@ -2905,6 +2905,14 @@ fs-extra@^2.0.0:
graceful-fs "^4.1.2"
jsonfile "^2.1.0"
+fs-extra@^4.0.1:
+ version "4.0.1"
+ resolved "https://registry.yarnpkg.com/fs-extra/-/fs-extra-4.0.1.tgz#7fc0c6c8957f983f57f306a24e5b9ddd8d0dd880"
+ dependencies:
+ graceful-fs "^4.1.2"
+ jsonfile "^3.0.0"
+ univers... | true |
Other | emberjs | ember.js | 15e1d153b8198776df51915459cd12b1e8d67f1d.json | Fix script that publishes to Rubygems
Apparently a brilliant young man tacked a `.strip` to the end of a bash command in hopes that it would strip whitespace.
Of course, what ended up happening was that a gem with `.strip` tacked on to the end of the name would not be found in the filesystem by the publish command. | bin/publish_npm_and_bower | @@ -88,7 +88,7 @@ if [[ "$TRAVIS_TAG" =~ ^v[0-9.]+ ]]; then
chmod 0600 ~/.gem/credentials
gem build ember-source.gemspec
- gem push `echo *.gem`.strip
+ gem push `echo *.gem`
fi
#### BOWER PUBLISHING | false |
Other | emberjs | ember.js | 922aed6f70b6daae16a0c0c5a351d9e243916c77.json | Add 2.15.3 to CHANGELOG.md.
[ci skip]
(cherry picked from commit 53cfa5995c79fcf5892fd4910b43882a50240b46) | CHANGELOG.md | @@ -30,6 +30,10 @@
- [#15528](https://github.com/emberjs/ember.js/pull/15528) [DEPRECATION] Deprecate `Controller#content` alias.
- [#15552](https://github.com/emberjs/ember.js/pull/15552) [FEATURE] Update blueprints and tests to RFC #176.
+### 2.15.3 (October 9, 2017)
+
+- [#15718](https://github.com/emberjs/ember... | false |
Other | emberjs | ember.js | 8bfa2013de2c15108b123f41b6a407a56f64108e.json | Add 2.17.0-beta.2 to CHANGELOG
[ci skip]
(cherry picked from commit 99d993cf529ee19e0ce29779eaf5524255d8f999) | CHANGELOG.md | @@ -1,5 +1,11 @@
# Ember Changelog
+### 2.17.0-beta.2 (October 17, 2017)
+- [#15613](https://github.com/emberjs/ember.js/pull/15613) [BUGFIX] Don't throw an error, when not all query params are passed to routerService.transitionTo
+- [#15707](https://github.com/emberjs/ember.js/pull/15707) [BUGFIX] Fix `canInvoke` f... | false |
Other | emberjs | ember.js | 70a3d879b8b7a64b7bf11da5479fd3dfc6191241.json | Add v2.17.0-beta.1 to CHANGELOG.
[ci skip]
(cherry picked from commit 07d4236bd94604d9392f50dbf0941f168e2ee9de) | CHANGELOG.md | @@ -1,5 +1,10 @@
# Ember Changelog
+### 2.17.0-beta.1 (October 9, 2017)
+
+- [#15265](https://github.com/emberjs/ember.js/pull/15265) [BUGFIX] fixed issue when passing `false` to `activeClass` for `{{link-to}}`
+- [#15672](https://github.com/emberjs/ember.js/pull/15672) Update router_js to 2.0.0.
+
### 2.16.0 (Octo... | false |
Other | emberjs | ember.js | 64dfd70b4e875c8b5b0fe0def3da5b358fdea904.json | Add 2.16.0 to CHANGELOG.md.
[ci skip]
(cherry picked from commit 3576aee3e04970d25a1470ad784c14d504516c1d) | CHANGELOG.md | @@ -1,19 +1,20 @@
# Ember Changelog
-### 2.16.0-beta.2 (October, 2, 2017)
+### 2.16.0 (October 9, 2017)
+- [#15604](https://github.com/emberjs/ember.js/pull/15604) Data Adapter: Only trigger model type update if the record live array count actually changed
+- [#15610](https://github.com/emberjs/ember.js/pull/15610... | false |
Other | emberjs | ember.js | c46c19dbc6cc2c6bf9bb033400a818fcbfcebe99.json | Add 2.15.2 to CHANGELOG.
[ci skip] | CHANGELOG.md | @@ -18,6 +18,11 @@
- [#15528](https://github.com/emberjs/ember.js/pull/15528) [DEPRECATION] Deprecate `Controller#content` alias.
- [#15552](https://github.com/emberjs/ember.js/pull/15552) [FEATURE] Update blueprints and tests to RFC #176.
+### 2.15.2 (October 4, 2017)
+
+- [#15604](https://github.com/emberjs/ember... | false |
Other | emberjs | ember.js | 9a6b038d303ade2f643ad0499054457403f86294.json | Add 2.15.1 to CHANGELOG.md.
[ci skip] | CHANGELOG.md | @@ -18,6 +18,11 @@
- [#15528](https://github.com/emberjs/ember.js/pull/15528) [DEPRECATION] Deprecate `Controller#content` alias.
- [#15552](https://github.com/emberjs/ember.js/pull/15552) [FEATURE] Update blueprints and tests to RFC #176.
+### 2.15.1 (October 2, 2017)
+
+- [#15600](https://github.com/emberjs/ember... | false |
Other | emberjs | ember.js | a9a36f4f8931488de40c64f4f190c0c3ce5be035.json | Update CHANGELOG for 2.16.0-beta.2.
[ci skip] | CHANGELOG.md | @@ -1,5 +1,17 @@
# Ember Changelog
+### 2.16.0-beta.2 (October, 2, 2017)
+
+- [#15577](https://github.com/emberjs/ember.js/pull/15577) [BUGFIX] Include missing sourcemaps in vendorTree.
+- [#15552](https://github.com/emberjs/ember.js/pull/15552) [FEATURE] Update blueprints and tests to RFC #176.
+- [#15600](https://... | false |
Other | emberjs | ember.js | 774a192ece628d08a3fcd877f8395f858aa33972.json | move `normalizeInjectionsHash` definition to debug | packages/container/lib/container.js | @@ -404,7 +404,7 @@ class FactoryManager {
}
toString() {
- if (!this.madeToString) {
+ if (this.madeToString === undefined) {
this.madeToString = this.container.registry.makeToString(this.class, this.fullName);
}
| true |
Other | emberjs | ember.js | 774a192ece628d08a3fcd877f8395f858aa33972.json | move `normalizeInjectionsHash` definition to debug | packages/container/lib/registry.js | @@ -568,23 +568,6 @@ Registry.prototype = {
return VALID_FULL_NAME_REGEXP.test(fullName);
},
- normalizeInjectionsHash(hash) {
- let injections = [];
-
- for (let key in hash) {
- if (hash.hasOwnProperty(key)) {
- assert(`Expected a proper full name, given '${hash[key]}'`, this.validateFull... | true |
Other | emberjs | ember.js | 6aab203232c633486ef42189eaf66261550c9168.json | reuse meta for `didUnwatch` and `willWatch` | packages/ember-metal/lib/alias.js | @@ -41,12 +41,12 @@ export class AliasedProperty extends Descriptor {
}
}
- willWatch(obj, keyName) {
- addDependentKeys(this, obj, keyName, metaFor(obj));
+ willWatch(obj, keyName, meta) {
+ addDependentKeys(this, obj, keyName, meta);
}
- didUnwatch(obj, keyName) {
- removeDependentKeys(this... | true |
Other | emberjs | ember.js | 6aab203232c633486ef42189eaf66261550c9168.json | reuse meta for `didUnwatch` and `willWatch` | packages/ember-metal/lib/watch_key.js | @@ -13,34 +13,33 @@ import {
let handleMandatorySetter;
-export function watchKey(obj, keyName, meta) {
+export function watchKey(obj, keyName, _meta) {
if (typeof obj !== 'object' || obj === null) { return; }
- let m = meta === undefined ? metaFor(obj) : meta;
- let count = m.peekWatching(keyName) || 0;
- ... | true |
Other | emberjs | ember.js | e9399bfdcea7c0580ae6e24ec5cef372af4d6086.json | Update router_js to 2.0.0.
The diff of the changes is pretty noisey (due to lots of general
cleanup work that was done), but for the most part the changes are:
* Drop support for non ES5 browsers (use `Array.isArray`,
`Object.create`, etc directly)
* Refactor the dist output to emit `module` entry point.
* Update t... | broccoli/packages.js | @@ -16,24 +16,10 @@ const { stripIndent } = require('common-tags');
const toES5 = require('./to-es5');
module.exports.routerES = function _routerES() {
- return new Rollup(findLib('router_js', 'lib'), {
+ return new Rollup(findLib('router_js'), {
rollup: {
external: ['route-recognizer', 'rsvp'],
- ... | true |
Other | emberjs | ember.js | e9399bfdcea7c0580ae6e24ec5cef372af4d6086.json | Update router_js to 2.0.0.
The diff of the changes is pretty noisey (due to lots of general
cleanup work that was done), but for the most part the changes are:
* Drop support for non ES5 browsers (use `Array.isArray`,
`Object.create`, etc directly)
* Refactor the dist output to emit `module` entry point.
* Update t... | package.json | @@ -112,7 +112,7 @@
"qunit-phantomjs-runner": "^2.2.0",
"qunitjs": "^1.22.0",
"route-recognizer": "^0.3.3",
- "router_js": "^1.2.8",
+ "router_js": "^2.0.0-beta.1",
"semver": "^5.3.0",
"serve-static": "^1.12.2",
"simple-dom": "^0.3.0", | true |
Other | emberjs | ember.js | e9399bfdcea7c0580ae6e24ec5cef372af4d6086.json | Update router_js to 2.0.0.
The diff of the changes is pretty noisey (due to lots of general
cleanup work that was done), but for the most part the changes are:
* Drop support for non ES5 browsers (use `Array.isArray`,
`Object.create`, etc directly)
* Refactor the dist output to emit `module` entry point.
* Update t... | yarn.lock | @@ -5322,9 +5322,9 @@ route-recognizer@^0.3.3:
version "0.3.3"
resolved "https://registry.yarnpkg.com/route-recognizer/-/route-recognizer-0.3.3.tgz#1d365e27fa6995e091675f7dc940a8c00353bd29"
-router_js@^1.2.8:
- version "1.2.8"
- resolved "https://registry.yarnpkg.com/router_js/-/router_js-1.2.8.tgz#d2ea5d0072... | true |
Other | emberjs | ember.js | a66d9a5369108a43263b445aa9316af66e64b7c1.json | move method definition to es6 class `Mixin` | packages/ember-metal/lib/mixin.js | @@ -521,76 +521,106 @@ export default class Mixin {
return ret;
}
-}
-Mixin._apply = applyMixin;
+ /**
+ @method reopen
+ @param arguments*
+ @private
+ */
+ reopen() {
+ let currentMixin;
+
+ if (this.properties) {
+ currentMixin = new Mixin(undefined, this.properties);
+ this.p... | false |
Other | emberjs | ember.js | 55031ce070aa38edbc4ba6eda166d316a9fd4860.json | avoid boolean coercion when checking for object | packages/ember-metal/lib/merge.js | @@ -16,7 +16,7 @@
@public
*/
export default function merge(original, updates) {
- if (!updates || typeof updates !== 'object') {
+ if (updates === null || typeof updates !== 'object') {
return original;
}
| true |
Other | emberjs | ember.js | 55031ce070aa38edbc4ba6eda166d316a9fd4860.json | avoid boolean coercion when checking for object | packages/ember-metal/lib/set_properties.js | @@ -23,7 +23,7 @@ import { set } from './property_set';
@public
*/
export default function setProperties(obj, properties) {
- if (!properties || typeof properties !== 'object') { return properties; }
+ if (properties === null || typeof properties !== 'object') { return properties; }
changeProperties(() => {
... | true |
Other | emberjs | ember.js | b3bbb86ad71e1a1ba26a8cffa856deaca7b1e7e3.json | remove unused things in `helpers/component` | packages/ember-glimmer/lib/helpers/component.js | @@ -6,14 +6,12 @@ import { assign } from 'ember-utils';
import { CachedReference } from '../utils/references';
import {
CurlyComponentDefinition,
- validatePositionalParameters,
- PositionalArgumentsReference
+ validatePositionalParameters
} from '../component-managers/curly';
import {
isComponentDefinitio... | false |
Other | emberjs | ember.js | 76930018d95954d8a5bab1972f5c8b57eee96081.json | run Travis on tagged builds | .travis.yml | @@ -36,6 +36,8 @@ branches:
- master
- beta
- stable
+ # npm version tags
+ - /^v\d+\.\d+\.\d+$/
env:
global: | false |
Other | emberjs | ember.js | e1df71dc5a28777e86def60b1404b26c8095cc88.json | avoid boolean coercion for meta value | packages/ember-metal/lib/alias.js | @@ -36,7 +36,7 @@ export class AliasedProperty extends Descriptor {
}
teardown(obj, keyName, meta) {
- if (meta && meta.peekWatching(keyName)) {
+ if (meta.peekWatching(keyName)) {
removeDependentKeys(this, obj, keyName, meta);
}
} | true |
Other | emberjs | ember.js | e1df71dc5a28777e86def60b1404b26c8095cc88.json | avoid boolean coercion for meta value | packages/ember-metal/lib/computed.js | @@ -547,8 +547,8 @@ export default function computed(...args) {
*/
function cacheFor(obj, key) {
let meta = peekMeta(obj);
- let cache = meta && meta.source === obj && meta.readableCache();
- let ret = cache && cache[key];
+ let cache = meta !== undefined ? meta.source === obj && meta.readableCache() : undefine... | true |
Other | emberjs | ember.js | e1df71dc5a28777e86def60b1404b26c8095cc88.json | avoid boolean coercion for meta value | packages/ember-metal/lib/events.js | @@ -146,7 +146,7 @@ export function suspendListeners(obj, eventNames, target, method, callback) {
*/
export function watchedEvents(obj) {
let meta = peekMeta(obj);
- return meta && meta.watchedEvents() || [];
+ return meta !== undefined ? meta.watchedEvents() : [];
}
/**
@@ -167,7 +167,7 @@ export function w... | true |
Other | emberjs | ember.js | e1df71dc5a28777e86def60b1404b26c8095cc88.json | avoid boolean coercion for meta value | packages/ember-metal/lib/mixin.js | @@ -291,7 +291,7 @@ function connectBindings(obj, meta) {
}
function finishPartial(obj, meta) {
- connectBindings(obj, meta || metaFor(obj));
+ connectBindings(obj, meta === undefined ? metaFor(obj) : meta);
return obj;
}
| true |
Other | emberjs | ember.js | e1df71dc5a28777e86def60b1404b26c8095cc88.json | avoid boolean coercion for meta value | packages/ember-metal/lib/property_events.js | @@ -42,10 +42,10 @@ let deferred = 0;
@private
*/
function propertyWillChange(obj, keyName, _meta) {
- let meta = _meta || peekMeta(obj);
- if (meta && !meta.isInitialized(obj)) { return; }
+ let meta = _meta === undefined ? peekMeta(obj) : _meta;
+ if (meta !== undefined && !meta.isInitialized(obj)) { return;... | true |
Other | emberjs | ember.js | e1df71dc5a28777e86def60b1404b26c8095cc88.json | avoid boolean coercion for meta value | packages/ember-metal/lib/property_set.js | @@ -73,7 +73,7 @@ export function set(obj, keyName, value, tolerant) {
if (MANDATORY_SETTER) {
var setWithMandatorySetter = (meta, obj, keyName, value) => {
- if (meta && meta.peekWatching(keyName) > 0) {
+ if (meta !== undefined && meta.peekWatching(keyName) > 0) {
makeEnumerable(obj, keyName);
... | true |
Other | emberjs | ember.js | e1df71dc5a28777e86def60b1404b26c8095cc88.json | avoid boolean coercion for meta value | packages/ember-metal/lib/tags.js | @@ -15,7 +15,7 @@ function makeTag() {
export function tagForProperty(object, propertyKey, _meta) {
if (typeof object !== 'object' || object === null) { return CONSTANT_TAG; }
- let meta = _meta || metaFor(object);
+ let meta = _meta === undefined ? metaFor(object) : _meta;
if (meta.isProxy()) {
return ... | true |
Other | emberjs | ember.js | e1df71dc5a28777e86def60b1404b26c8095cc88.json | avoid boolean coercion for meta value | packages/ember-metal/lib/watch_key.js | @@ -16,7 +16,7 @@ let handleMandatorySetter;
export function watchKey(obj, keyName, meta) {
if (typeof obj !== 'object' || obj === null) { return; }
- let m = meta || metaFor(obj);
+ let m = meta === undefined ? metaFor(obj) : meta;
let count = m.peekWatching(keyName) || 0;
m.writeWatching(keyName, count ... | true |
Other | emberjs | ember.js | e1df71dc5a28777e86def60b1404b26c8095cc88.json | avoid boolean coercion for meta value | packages/ember-metal/lib/watch_path.js | @@ -11,7 +11,7 @@ export function makeChainNode(obj) {
export function watchPath(obj, keyPath, meta) {
if (typeof obj !== 'object' || obj === null) { return; }
- let m = meta || metaFor(obj);
+ let m = meta === undefined ? metaFor(obj) : meta;
let counter = m.peekWatching(keyPath) || 0;
m.writeWatching(... | true |
Other | emberjs | ember.js | e1df71dc5a28777e86def60b1404b26c8095cc88.json | avoid boolean coercion for meta value | packages/ember-metal/lib/watching.js | @@ -44,7 +44,7 @@ export function isWatching(obj, key) {
export function watcherCount(obj, key) {
let meta = peekMeta(obj);
- return (meta && meta.peekWatching(key)) || 0;
+ return (meta !== undefined && meta.peekWatching(key)) || 0;
}
export function unwatch(obj, _keyPath, m) { | true |
Other | emberjs | ember.js | e1df71dc5a28777e86def60b1404b26c8095cc88.json | avoid boolean coercion for meta value | packages/ember-runtime/lib/mixins/array.js | @@ -657,7 +657,7 @@ EachProxy.prototype = {
let lim = removedCnt > 0 ? idx + removedCnt : -1;
let meta;
for (let key in keys) {
- meta = meta || peekMeta(this);
+ meta = meta === undefined ? peekMeta(this) : meta;
if (lim > 0) {
removeObserverForContentKey(content, key, this, id... | true |
Other | emberjs | ember.js | cb2cadf9912e1b4616aea1e090b8c2b920b3db77.json | use a fixture to test `helper-test` blueprint | node-tests/blueprints/helper-test.js | @@ -1,5 +1,6 @@
'use strict';
+const file = require('../helpers/file');
var blueprintHelpers = require('ember-cli-blueprint-test-helpers/helpers');
var setupTestHooks = blueprintHelpers.setupTestHooks;
var emberNew = blueprintHelpers.emberNew;
@@ -28,26 +29,26 @@ describe('Acceptance: ember generate and destroy h... | true |
Other | emberjs | ember.js | cb2cadf9912e1b4616aea1e090b8c2b920b3db77.json | use a fixture to test `helper-test` blueprint | node-tests/fixtures/helper-test/integration.js | @@ -0,0 +1,17 @@
+
+import { moduleForComponent, test } from 'ember-qunit';
+import hbs from 'htmlbars-inline-precompile';
+
+moduleForComponent('foo/bar-baz', 'helper:foo/bar-baz', {
+ integration: true
+});
+
+// Replace this with your real tests.
+test('it renders', function(assert) {
+ this.set('inputValue', '123... | true |
Other | emberjs | ember.js | cb2cadf9912e1b4616aea1e090b8c2b920b3db77.json | use a fixture to test `helper-test` blueprint | node-tests/helpers/file.js | @@ -0,0 +1,8 @@
+'use strict';
+
+const path = require('path');
+const file = require('ember-cli-blueprint-test-helpers/chai').file;
+
+module.exports = function(filePath) {
+ return file(path.join(__dirname, '../fixtures', filePath));
+}; | true |
Other | emberjs | ember.js | 21ab4894123b8ff69fe09422120dc0ee5b92d10c.json | Update CHANGELOG.md for 2.16.0-beta.1.
[ci skip]
(cherry picked from commit 8903e1cb2c8e7ab1457eef9261f27359a046104f) | CHANGELOG.md | @@ -1,5 +1,11 @@
# Ember Changelog
+### 2.16.0-beta.1 (August 31, 2017)
+
+- [#14764](https://github.com/emberjs/ember.js/pull/14764) Fixed string capitalize for accented characters.
+- [#15528](https://github.com/emberjs/ember.js/pull/15528) [DEPRECATION] Deprecate `Controller#content` alias.
+- [#15552](https://gi... | false |
Other | emberjs | ember.js | defdd1e27472a99875ce928bc138d46b3d2a770b.json | Update CHANGELOG for 2.15.0.
[ci skip] | CHANGELOG.md | @@ -1,22 +1,17 @@
# Ember Changelog
-### 2.15.0-beta.3 (August 8, 2017)
+### 2.15.0 (August 31, 2017)
+- [#15577](https://github.com/emberjs/ember.js/pull/15577) [BUGFIX] Include missing sourcemaps in vendorTree.
- [#14848](https://github.com/emberjs/ember.js/pull/14848) [BUGFIX] Allow boolean values for current-... | false |
Other | emberjs | ember.js | 979190c8f6b0023f4672508d0be3d8d53b585019.json | Update CHANGELOG for v2.15.0-beta.3.
[ci skip] | CHANGELOG.md | @@ -1,5 +1,14 @@
# Ember Changelog
+### 2.15.0-beta.3 (August 8, 2017)
+
+- [#14848](https://github.com/emberjs/ember.js/pull/14848) [BUGFIX] Allow boolean values for current-when
+- [#15572](https://github.com/emberjs/ember.js/pull/15572) [BUGFIX] Fix issue with using negative numbers as an argument passed in from ... | false |
Other | emberjs | ember.js | 19ae330fd582ca3a9b97b70d16aceceb40f94261.json | Bring query params fix up to date. | packages/ember-routing/lib/system/route.js | @@ -848,7 +848,10 @@ let Route = EmberObject.extend(ActionHandler, Evented, {
} else {
if (presentKey) {
svalue = params[presentKey];
- value = route.deserializeQueryParam(svalue, qp.urlKey, qp.type);
+
+ if (svalue !== undefined) {
+ value = route.des... | true |
Other | emberjs | ember.js | 19ae330fd582ca3a9b97b70d16aceceb40f94261.json | Bring query params fix up to date. | packages/ember-routing/lib/system/router.js | @@ -702,7 +702,7 @@ const EmberRouter = EmberObject.extend(Evented, {
*/
_serializeQueryParam(value, type) {
if (value === null || value === undefined) {
- return null;
+ return value;
} else if (type === 'array') {
return JSON.stringify(value);
}
@@ -739,7 +739,9 @@ const EmberRou... | true |
Other | emberjs | ember.js | 19ae330fd582ca3a9b97b70d16aceceb40f94261.json | Bring query params fix up to date. | packages/ember/tests/routing/query_params_test.js | @@ -1153,62 +1153,59 @@ moduleFor('Query Params - main', class extends QueryParamTestCase {
});
}
- test("Setting bound query pram property to null or undefined do not seralize to url", function() {
- Router.map(function() {
- this.route("home", { path: '/home' });
- });
+ ['@test Setting bound q... | true |
Other | emberjs | ember.js | bc633b24cd8d699a288b36615253a78e79ce6a1d.json | add inflection to dependencies | package.json | @@ -54,6 +54,7 @@
"ember-cli-valid-component-name": "^1.0.0",
"ember-cli-version-checker": "^1.3.1",
"ember-router-generator": "^1.2.3",
+ "inflection": "^1.12.0",
"jquery": "^3.2.1",
"resolve": "^1.3.3",
"rsvp": "^3.6.1", | false |
Other | emberjs | ember.js | 846227b17eeca2b4500508f92fd1c831ffcf7ba7.json | remove unused imports | packages/ember-glimmer/lib/component-managers/outlet.js | @@ -4,8 +4,7 @@
*/
import { generateGuid, guidFor } from 'ember-utils';
import {
- ComponentDefinition,
- CompiledArgs
+ ComponentDefinition
} from '@glimmer/runtime';
import { DEBUG } from 'ember-env-flags';
import { _instrumentStart } from 'ember-metal'; | true |
Other | emberjs | ember.js | 846227b17eeca2b4500508f92fd1c831ffcf7ba7.json | remove unused imports | packages/ember-glimmer/lib/component-managers/root.js | @@ -2,7 +2,6 @@ import {
ComponentDefinition
} from '@glimmer/runtime';
import {
- get,
_instrumentStart
} from 'ember-metal';
import {
@@ -12,8 +11,6 @@ import { DEBUG } from 'ember-env-flags';
import ComponentStateBucket from '../utils/curly-component-state-bucket';
import CurlyComponentManager, {
ini... | true |
Other | emberjs | ember.js | dac942a86eedc8f71727ae1bed7abfaac9aee935.json | Remove outdated {{with}} documentation
`{{with}}` no longer changes the scope of `this` so this note no longer applies | packages/ember-glimmer/lib/index.js | @@ -95,9 +95,7 @@
{{/each}}
{{/with}}
```
-
- Without the `as` operator, it would be impossible to reference `user.name` in the example above.
-
+
NOTE: The alias should not reuse a name from the bound property path.
For example: `{{#with foo.bar as |foo|}}` is not supported because it attempts to... | false |
Other | emberjs | ember.js | 282185535b7bde56437d6d3a78d89a201dac0e53.json | Fix casing of JavaScript in README | README.md | @@ -12,10 +12,10 @@
<a href="https://saucelabs.com/u/ember-ci"><img src="https://saucelabs.com/browser-matrix/ember-ci.svg" alt="Sauce Test Status"></a>
</p>
-Ember.js is a Javascript framework that greatly reduces the time, effort and resources needed
+Ember.js is a JavaScript framework that greatly reduces the ... | false |
Other | emberjs | ember.js | 5a7356fe741455e171093369838fa18745fc5fd2.json | remove unused deps | package.json | @@ -43,7 +43,6 @@
"@glimmer/node": "^0.25.3",
"@glimmer/reference": "^0.25.3",
"@glimmer/runtime": "^0.25.3",
- "@glimmer/util": "^0.25.3",
"broccoli-funnel": "^1.2.0",
"broccoli-merge-trees": "^2.0.0",
"ember-cli-get-component-path-option": "^1.0.0",
@@ -55,7 +54,6 @@
"ember-cli-v... | false |
Other | emberjs | ember.js | 56dcb2f360709fe9fdd52aac6e1de29b72079468.json | Update @glimmer packages to 0.25.3. | package.json | @@ -39,11 +39,11 @@
"link:glimmer": "node bin/yarn-link-glimmer.js"
},
"dependencies": {
- "@glimmer/compiler": "^0.25.1",
- "@glimmer/node": "^0.25.1",
- "@glimmer/reference": "^0.25.1",
- "@glimmer/runtime": "^0.25.1",
- "@glimmer/util": "^0.25.1",
+ "@glimmer/compiler": "^0.25.3",
+ "... | true |
Other | emberjs | ember.js | 56dcb2f360709fe9fdd52aac6e1de29b72079468.json | Update @glimmer packages to 0.25.3. | yarn.lock | @@ -2,78 +2,78 @@
# yarn lockfile v1
-"@glimmer/compiler@^0.25.1":
- version "0.25.1"
- resolved "https://registry.yarnpkg.com/@glimmer/compiler/-/compiler-0.25.1.tgz#81fb9f51349f819525da737ae953a5f8461fdef1"
- dependencies:
- "@glimmer/interfaces" "^0.25.1"
- "@glimmer/syntax" "^0.25.1"
- "@glimmer/ut... | true |
Other | emberjs | ember.js | c74f76ca663db7a47fac8abae0271bd48656cd7a.json | check `meta` for being `undefined` only | packages/ember-metal/lib/chains.js | @@ -113,13 +113,11 @@ function addChainWatcher(obj, keyName, node) {
}
function removeChainWatcher(obj, keyName, node, _meta) {
- if (!isObject(obj)) {
- return;
- }
+ if (!isObject(obj)) { return; }
- let meta = _meta || peekMeta(obj);
+ let meta = _meta === undefined ? peekMeta(obj) : _meta;
- if (!m... | true |
Other | emberjs | ember.js | c74f76ca663db7a47fac8abae0271bd48656cd7a.json | check `meta` for being `undefined` only | packages/ember-metal/lib/computed.js | @@ -299,7 +299,7 @@ ComputedPropertyPrototype.didChange = function(obj, keyName) {
// don't create objects just to invalidate
let meta = peekMeta(obj);
- if (!meta || meta.source !== obj) {
+ if (meta === undefined || meta.source !== obj) {
return;
}
| true |
Other | emberjs | ember.js | c74f76ca663db7a47fac8abae0271bd48656cd7a.json | check `meta` for being `undefined` only | packages/ember-metal/lib/events.js | @@ -210,7 +210,7 @@ export function sendEvent(obj, eventName, params, actions, _meta) {
*/
export function hasListeners(obj, eventName) {
let meta = peekMeta(obj);
- if (!meta) { return false; }
+ if (meta === undefined) { return false; }
let matched = meta.matchingListeners(eventName);
return matched !== ... | true |
Other | emberjs | ember.js | c74f76ca663db7a47fac8abae0271bd48656cd7a.json | check `meta` for being `undefined` only | packages/ember-metal/lib/is_proxy.js | @@ -3,7 +3,7 @@ import { peekMeta } from './meta';
export function isProxy(value) {
if (typeof value === 'object' && value !== null) {
let meta = peekMeta(value);
- return meta && meta.isProxy();
+ return meta === undefined ? false : meta.isProxy();
}
return false; | true |
Other | emberjs | ember.js | c74f76ca663db7a47fac8abae0271bd48656cd7a.json | check `meta` for being `undefined` only | packages/ember-metal/lib/mixin.js | @@ -516,7 +516,7 @@ export default class Mixin {
static mixins(obj) {
let meta = peekMeta(obj);
let ret = [];
- if (!meta) { return ret; }
+ if (meta === undefined) { return ret; }
meta.forEachMixins((key, currentMixin) => {
// skip primitive mixins since these are always anonymous
@@ -... | true |
Other | emberjs | ember.js | c74f76ca663db7a47fac8abae0271bd48656cd7a.json | check `meta` for being `undefined` only | packages/ember-metal/lib/properties.js | @@ -58,7 +58,7 @@ export function MANDATORY_SETTER_FUNCTION(name) {
export function DEFAULT_GETTER_FUNCTION(name) {
return function GETTER_FUNCTION() {
let meta = peekMeta(this);
- if (meta !== null && meta !== undefined) {
+ if (meta !== undefined) {
return meta.peekValues(name);
}
};
@@ ... | true |
Other | emberjs | ember.js | c74f76ca663db7a47fac8abae0271bd48656cd7a.json | check `meta` for being `undefined` only | packages/ember-metal/lib/watch_key.js | @@ -87,7 +87,7 @@ export function unwatchKey(obj, keyName, _meta) {
let meta = _meta || peekMeta(obj);
// do nothing of this object has already been destroyed
- if (!meta || meta.isSourceDestroyed()) { return; }
+ if (meta === undefined || meta.isSourceDestroyed()) { return; }
let count = meta.peekWatchi... | true |
Other | emberjs | ember.js | c74f76ca663db7a47fac8abae0271bd48656cd7a.json | check `meta` for being `undefined` only | packages/ember-runtime/lib/mixins/array.js | @@ -139,7 +139,7 @@ export function arrayContentDidChange(array, startIdx, removeAmt, addAmt) {
sendEvent(array, '@array:change', [array, startIdx, removeAmt, addAmt]);
let meta = peekMeta(array);
- let cache = meta && meta.readableCache();
+ let cache = meta !== undefined ? meta.readableCache() : undefined;
... | true |
Other | emberjs | ember.js | dc60f97e9dab2479ff78d696ca6a0b4acf486d01.json | remove unused imports | packages/ember-routing/lib/services/router.js | @@ -7,9 +7,7 @@ import {
Service,
readOnly
} from 'ember-runtime';
-import { assign } from 'ember-utils';
import { shallowEqual } from '../utils';
-import RouterDSL from '../system/dsl';
/**
The Router service is the public API that provides component/view layer | false |
Other | emberjs | ember.js | e2f4d058a4e766b49c5917c3f32f951e842c3557.json | avoid boolean coarsion in `computed` | packages/ember-metal/lib/computed.js | @@ -142,7 +142,7 @@ function ComputedProperty(config, opts) {
this._meta = undefined;
this._volatile = false;
this._dependentKeys = opts && opts.dependentKeys;
- this._readOnly = false;
+ this._readOnly = false;
}
ComputedProperty.prototype = new Descriptor();
@@ -304,7 +304,7 @@ ComputedPropertyPrototy... | false |
Other | emberjs | ember.js | 2b0918303ce33256b5ae8505193b6e490c161251.json | avoid boolean coarsion in weak_map | packages/ember-metal/lib/weak_map.js | @@ -57,12 +57,12 @@ WeakMap.prototype.get = function(obj) {
let meta = peekMeta(obj);
if (meta) {
let map = meta.readableWeak();
- if (map) {
- if (map[this._id] === UNDEFINED) {
+ if (map !== undefined) {
+ let val = map[this._id];
+ if (val === UNDEFINED) {
return undefined;
... | false |
Other | emberjs | ember.js | 49f01699a9c209c3134ac85895cba4456a58b935.json | reuse meta `arrayContentDidChange` | packages/ember-runtime/lib/mixins/array.js | @@ -149,16 +149,16 @@ export function arrayContentDidChange(array, startIdx, removeAmt, addAmt) {
let normalStartIdx = startIdx < 0 ? previousLength + startIdx : startIdx;
if (cache.firstObject !== undefined && normalStartIdx === 0) {
- propertyWillChange(array, 'firstObject');
- propertyDidChange... | false |
Other | emberjs | ember.js | ba3d6f467cf8c7e3752b613fcdd850412e275ece.json | avoid boolean coarsion | packages/ember-metal/lib/weak_map.js | @@ -52,12 +52,12 @@ export class WeakMapPolyfill {
let meta = peekMeta(obj);
if (meta) {
let map = meta.readableWeak();
- if (map) {
- if (map[this._id] === UNDEFINED) {
+ if (map !== undefined) {
+ let val = map[this._id];
+ if (val === UNDEFINED) {
return und... | false |
Other | emberjs | ember.js | cd150fa456a160e534a474683c844524b1d3dfb6.json | remove extra type check | packages/ember-metal/lib/watching.js | @@ -1,7 +1,6 @@
/**
@module ember-metal
*/
-
import {
watchKey,
unwatchKey
@@ -40,11 +39,7 @@ export function watch(obj, _keyPath, m) {
}
export function isWatching(obj, key) {
- if (typeof obj !== 'object' || obj === null) {
- return false;
- }
- let meta = peekMeta(obj);
- return (meta && meta.pe... | true |
Other | emberjs | ember.js | cd150fa456a160e534a474683c844524b1d3dfb6.json | remove extra type check | packages/ember-runtime/lib/computed/computed_macros.js | @@ -251,8 +251,7 @@ export function bool(dependentKey) {
export function match(dependentKey, regexp) {
return computed(dependentKey, function() {
let value = get(this, dependentKey);
-
- return typeof value === 'string' ? regexp.test(value) : false;
+ return regexp.test(value);
});
}
| true |
Other | emberjs | ember.js | 14243438756b908b4557f9f3e296d3af89bcda81.json | remove unnecessary check | packages/ember-metal/lib/property_set.js | @@ -95,9 +95,9 @@ function setPath(root, path, value, tolerant) {
let parts = path.split('.');
let keyName = parts.pop();
- assert('Property set failed: You passed an empty path', keyName && keyName.length > 0)
+ assert('Property set failed: You passed an empty path', keyName.trim().length > 0)
- let newPa... | true |
Other | emberjs | ember.js | 14243438756b908b4557f9f3e296d3af89bcda81.json | remove unnecessary check | packages/ember-metal/lib/weak_map.js | @@ -115,7 +115,7 @@ WeakMap.prototype.has = function(obj) {
*/
WeakMap.prototype.delete = function(obj) {
if (this.has(obj)) {
- delete metaFor(obj).writableWeak()[this._id];
+ delete peekMeta(obj).writableWeak()[this._id];
return true;
} else {
return false; | true |
Other | emberjs | ember.js | bd60d853d76252e379dc4876b24475cb3c5d3a10.json | Release reference to root components after destroy | packages/ember-glimmer/lib/renderer.js | @@ -241,6 +241,7 @@ class Renderer {
let root = roots[i];
if (root.isFor(view)) {
root.destroy();
+ roots.splice(i, 1);
}
}
} | true |
Other | emberjs | ember.js | bd60d853d76252e379dc4876b24475cb3c5d3a10.json | Release reference to root components after destroy | packages/ember-glimmer/tests/integration/components/append-test.js | @@ -323,6 +323,23 @@ class AbstractAppendTest extends RenderingTest {
this.assert.equal(willDestroyCalled, 1);
}
+ ['@test releasing a root component after it has been destroy'](assert) {
+ let renderer = this.owner.lookup('renderer:-dom');
+
+ this.registerComponent('x-component', {
+ ComponentCl... | true |
Other | emberjs | ember.js | 6721c736edb2395497d61f3c53eab69868706f42.json | remove unnecessary binding | packages/ember-metal/lib/observer_set.js | @@ -29,12 +29,12 @@ export default class ObserverSet {
let observers = this.observers;
let senderGuid = guidFor(sender);
let keySet = observerSet[senderGuid];
- let index;
- if (!keySet) {
+ if (keySet === undefined) {
observerSet[senderGuid] = keySet = {};
}
- index = keySet[ke... | true |
Other | emberjs | ember.js | 6721c736edb2395497d61f3c53eab69868706f42.json | remove unnecessary binding | packages/ember-metal/lib/property_events.js | @@ -15,7 +15,7 @@ import {
} from 'ember/features';
import { assertNotRendered } from './transaction';
-export let PROPERTY_DID_CHANGE = symbol('PROPERTY_DID_CHANGE');
+export const PROPERTY_DID_CHANGE = symbol('PROPERTY_DID_CHANGE');
const beforeObserverSet = new ObserverSet();
const observerSet = new Observer... | true |
Other | emberjs | ember.js | aeff86a8314795197e5daa3168d41cd2aeaee2df.json | Remove meta check | packages/ember-metal/lib/property_events.js | @@ -266,7 +266,6 @@ function indexOf(array, target, method) {
}
function accumulateListeners(obj, eventName, otherActions, meta) {
- if (meta === null || meta === undefined) { return; }
let actions = meta.matchingListeners(eventName);
if (actions === undefined) { return; }
let newActions = []; | false |
Other | emberjs | ember.js | c6a52be3da2d035c149ef65ebc6ca92baab56fb9.json | correct function extensions | packages/ember-runtime/lib/ext/function.js | @@ -5,12 +5,12 @@
import { ENV } from 'ember-environment';
import {
+ on,
computed,
observer
} from 'ember-metal';
import { assert, deprecateFunc } from 'ember-debug';
-const a_slice = Array.prototype.slice;
const FunctionPrototype = Function.prototype;
if (ENV.EXTEND_PROTOTYPES.Function) {
@@ -74,10... | false |
Other | emberjs | ember.js | 6ccb09546ecc300148b737eaed653b0361c16311.json | Add 2.15.0-beta.1 to CHANGELOG.md.
[ci skip] | CHANGELOG.md | @@ -1,5 +1,15 @@
# Ember Changelog
+### 2.15.0-beta.1 (July 5, 2017)
+
+- [#14338](https://github.com/emberjs/ember.js/pull/14338) [FEATURE] Remove explicit names from initializers.
+- [#15325](https://github.com/emberjs/ember.js/pull/15325) / [#15326](https://github.com/emberjs/ember.js/pull/15326) [FEATURE ember-e... | false |
Other | emberjs | ember.js | 2e45c053542f92ed363162b5d27f3da070310c62.json | Add 2.13.4 to CHANGELOG.md.
[ci skip] | CHANGELOG.md | @@ -24,6 +24,10 @@
- [#15178](https://github.com/emberjs/ember.js/pull/15178) Refactor route to lookup controller for QPs.
- [#15129](https://github.com/emberjs/ember.js/pull/15129) Fix access to service:-document in ember-engines
+### 2.13.4 (July 5, 2017)
+
+- [#15321](https://github.com/emberjs/ember.js/pull/153... | false |
Other | emberjs | ember.js | f20ef314db6e26751014acf21a62e6fe6503490d.json | Update CHANGELOG to 2.14.0.
[ci skip] | CHANGELOG.md | @@ -1,22 +1,20 @@
# Ember Changelog
-### 2.14.0-beta.3 (May 30, 2017)
+### 2.14.0 (July 5, 2017)
+- [#15312](https://github.com/emberjs/ember.js/pull/15312) [BUGFIX] Avoid re-freezing already frozen objects.
+- [#15315](https://github.com/emberjs/ember.js/pull/15315) [FEATURE] Add minlength to TextSupport
+- [#153... | false |
Other | emberjs | ember.js | 44eb0488467cf4ea7cd84f8f4ba5b6dbf47edd8b.json | Add deprecated annotation to API docs | packages/ember/lib/index.js | @@ -232,6 +232,7 @@ Object.defineProperty(Ember, 'onerror', {
@method K
@return {Object}
@public
+ @deprecated
*/
function deprecatedEmberK() { return this; }
| false |
Other | emberjs | ember.js | 4ce419565db027fa7fb8e0821fe74f353c3ea402.json | reuse empty func in `ember-debug` | packages/ember-debug/lib/index.js | @@ -6,30 +6,31 @@ import EmberError from './error';
import { default as isFeatureEnabled } from './features';
import * as FLAGS from 'ember/features';
let { DEFAULT_FEATURES, FEATURES } = FLAGS;
-
import _deprecate from './deprecate';
import _warn from './warn';
+
export { registerHandler as registerWarnHandler }... | false |
Other | emberjs | ember.js | 71de1162c7e20f04eb61339a1aee1fa7b3b02dc0.json | remove unused vars | packages/ember-metal/lib/mixin.js | @@ -37,19 +37,18 @@ import {
removeListener
} from './events';
-const a_slice = Array.prototype.slice;
const a_concat = Array.prototype.concat;
const { isArray } = Array;
function isMethod(obj) {
return 'function' === typeof obj &&
- obj.isMethod !== false &&
- obj !== Boolean &&
- ... | true |
Other | emberjs | ember.js | 71de1162c7e20f04eb61339a1aee1fa7b3b02dc0.json | remove unused vars | packages/ember-runtime/lib/system/core_object.js | @@ -854,11 +854,10 @@ let ClassMixinProps = {
metaForProperty(key) {
let proto = this.proto();
let possibleDesc = proto[key];
- let isDescriptor = possibleDesc !== null && typeof possibleDesc === 'object' && possibleDesc.isDescriptor;
assert(
`metaForProperty() could not find a computed pr... | true |
Other | emberjs | ember.js | 662e76dfe834dafa1a8c519896438bfcd5e723ab.json | use inheritance for iterators in `iterable` | packages/ember-glimmer/lib/utils/iterable.js | @@ -68,7 +68,7 @@ function identity(item) {
function ensureUniqueKey(seen, key) {
let seenCount = seen[key];
- if (seenCount) {
+ if (seenCount > 0) {
seen[key]++;
return `${key}${ITERATOR_KEY_GUID}${seenCount}`;
} else {
@@ -91,13 +91,21 @@ class ArrayIterator {
return false;
}
+ getMem... | false |
Other | emberjs | ember.js | eea8c112213138a47a53547fc15fb37300e747b9.json | avoid toboolean coercion in `meta_listeners` | packages/ember-metal/lib/is_proxy.js | @@ -1,7 +1,7 @@
import { peekMeta } from './meta';
export function isProxy(value) {
- if (typeof value === 'object' && value) {
+ if (typeof value === 'object' && value !== null) {
let meta = peekMeta(value);
return meta && meta.isProxy();
} | true |
Other | emberjs | ember.js | eea8c112213138a47a53547fc15fb37300e747b9.json | avoid toboolean coercion in `meta_listeners` | packages/ember-metal/lib/meta_listeners.js | @@ -17,19 +17,19 @@ export const SUSPENDED = 2;
export const protoMethods = {
addToListeners(eventName, target, method, flags) {
- if (!this._listeners) {
+ if (this._listeners === undefined) {
this._listeners = [];
}
this._listeners.push(eventName, target, method, flags);
},
_final... | true |
Other | emberjs | ember.js | eea8c112213138a47a53547fc15fb37300e747b9.json | avoid toboolean coercion in `meta_listeners` | packages/ember-metal/lib/tags.js | @@ -28,7 +28,7 @@ export function tagForProperty(object, propertyKey, _meta) {
}
export function tagFor(object, _meta) {
- if (typeof object === 'object' && object) {
+ if (typeof object === 'object' && object !== null) {
let meta = _meta || metaFor(object);
return meta.writableTag(makeTag);
} else { | true |
Other | emberjs | ember.js | 5d7ae49a64600d1e107dbbbac37b4ca901cd7ef9.json | helpers/current_route_name: Fix example rendering | packages/ember-testing/lib/helpers/current_route_name.js | @@ -5,13 +5,16 @@
import { get } from 'ember-metal';
/**
Returns the currently active route name.
+
Example:
+
```javascript
function validateRouteName() {
equal(currentRouteName(), 'some.path', "correct route was transitioned into.");
}
visit('/some/path').then(validateRouteName)
```
+
@method currentRo... | false |
Other | emberjs | ember.js | 974155e35d23785a6ddcd0a4a2f131a41c7cffd5.json | avoid bool conversion | packages/ember-metal/lib/property_events.js | @@ -51,10 +51,10 @@ function propertyWillChange(obj, keyName, _meta) {
let watching = meta && meta.peekWatching(keyName) > 0;
let possibleDesc = obj[keyName];
- let desc = (possibleDesc !== null && typeof possibleDesc === 'object' && possibleDesc.isDescriptor) ? possibleDesc : undefined;
+ let isDescriptor = ... | true |
Other | emberjs | ember.js | 974155e35d23785a6ddcd0a4a2f131a41c7cffd5.json | avoid bool conversion | packages/ember-metal/lib/watch_key.js | @@ -22,10 +22,9 @@ export function watchKey(obj, keyName, meta) {
m.writeWatching(keyName, 1);
let possibleDesc = obj[keyName];
- let desc = (possibleDesc !== null &&
- typeof possibleDesc === 'object' &&
- possibleDesc.isDescriptor) ? possibleDesc : undefined;
- if (desc... | true |
Other | emberjs | ember.js | 974155e35d23785a6ddcd0a4a2f131a41c7cffd5.json | avoid bool conversion | packages/ember-runtime/lib/system/core_object.js | @@ -107,9 +107,6 @@ function makeCtor() {
m.writeBindings(keyName, value);
}
- let possibleDesc = this[keyName];
- let desc = (possibleDesc !== null && typeof possibleDesc === 'object' && possibleDesc.isDescriptor) ? possibleDesc : undefined;
-
assert(
... | true |
Other | emberjs | ember.js | 5f386095aa9ba6ee3b193e0d7ddc74d7ff27a5f9.json | remove dead code | packages/ember-metal/lib/meta.js | @@ -506,14 +506,6 @@ if (HAS_NATIVE_WEAKMAP) {
metaStore.set(obj, meta);
};
- peekMeta = function WeakMap_peekMeta(obj) {
- if (DEBUG) {
- counters.peekCalls++
- }
-
- return metaStore.get(obj);
- };
-
peekMeta = function WeakMap_peekParentMeta(obj) {
let pointer = obj;
let meta; | false |
Other | emberjs | ember.js | 6d9a9735eeb04182589ff9bd98569288667cb8d8.json | use flat array in `dsl` | packages/ember-routing/lib/system/dsl.js | @@ -68,7 +68,7 @@ class DSL {
if (url === '' || url === '/' || parts[parts.length - 1] === 'index') { this.explicitIndex = true; }
- this.matches.push([url, name, callback]);
+ this.matches.push(url, name, callback);
}
resource(name, options = {}, callback) {
@@ -90,9 +90,8 @@ class DSL {
}
... | false |
Other | emberjs | ember.js | 9208dd1ae96fc23b52e55f656981cc6d99b59e0d.json | Remove runloop from abstract click helper.
In #15358, we discovered that not returning visit functions was
causing us to use unecessary run loops. A click event shouldn't
need to be scheduled in the run loop, and when that is something
else is going wrong. | packages/internal-test-helpers/lib/test-cases/abstract.js | @@ -88,7 +88,7 @@ export default class AbstractTestCase {
}
click(selector) {
- this.runTask(() => this.$(selector).click());
+ return this.$(selector).click();
}
textValue() { | false |
Other | emberjs | ember.js | 6899ef4799b921c30ca1c6ff8a1011a4ba821cd9.json | sync .editorconfig with default new app | .editorconfig | @@ -3,9 +3,15 @@
root = true
[*]
+end_of_line = lf
charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true
indent_style = space
indent_size = 2
-end_of_line = lf
-insert_final_newline = true
-trim_trailing_whitespace = true
+
+[*.hbs]
+insert_final_newline = false
+
+[*.{diff,md}]
+trim_tra... | false |
Other | emberjs | ember.js | e5f9748cc9598854395f967858af5ef379b0cc8b.json | Remove unused Meta methods.
These methods have existed since we started with the current meta system,
but they were added via meta-programming (which meant that all of the
similar types of things ended up with all of the methods).
Now that the meta-programming is unrolled, these methods are not used any
longer. | packages/ember-metal/lib/meta.js | @@ -353,38 +353,6 @@ export class Meta {
return this._findInherited('_watching', subkey);
}
- forEachWatching(fn) {
- let pointer = this;
- let seen;
- while (pointer !== undefined) {
- let map = pointer._watching;
- if (map !== undefined) {
- for (let key in map) {
- seen =... | true |
Other | emberjs | ember.js | e5f9748cc9598854395f967858af5ef379b0cc8b.json | Remove unused Meta methods.
These methods have existed since we started with the current meta system,
but they were added via meta-programming (which meant that all of the
similar types of things ended up with all of the methods).
Now that the meta-programming is unrolled, these methods are not used any
longer. | packages/ember-metal/tests/accessors/mandatory_setters_test.js | @@ -18,7 +18,7 @@ function hasMandatorySetter(object, property) {
}
function hasMetaValue(object, property) {
- return metaFor(object).hasInValues(property);
+ return metaFor(object).peekValues(property) !== undefined;
}
if (MANDATORY_SETTER) { | true |
Other | emberjs | ember.js | e5f9748cc9598854395f967858af5ef379b0cc8b.json | Remove unused Meta methods.
These methods have existed since we started with the current meta system,
but they were added via meta-programming (which meant that all of the
similar types of things ended up with all of the methods).
Now that the meta-programming is unrolled, these methods are not used any
longer. | packages/ember-metal/tests/meta_test.js | @@ -89,18 +89,6 @@ QUnit.test('meta.writeWatching issues useful error after destroy', function(asse
}, 'Cannot update watchers for `hello` on `<special-sauce:123>` after it has been destroyed.');
});
-QUnit.test('meta.clearWatching issues useful error after destroy', function(assert) {
- let target = {
- toSt... | true |
Other | emberjs | ember.js | 271d8cd7b6987f177318081925a5e3c74abe9762.json | use flat array in `meta/_forEachIn` | packages/ember-metal/lib/meta.js | @@ -305,17 +305,17 @@ export class Meta {
if (seen[innerKey] === undefined) {
seen[innerKey] = true;
calls = calls || [];
- calls.push([innerKey, innerMap[innerKey]]);
+ calls.push(innerKey, innerMap[innerKey]);
}
}
}
... | false |
Other | emberjs | ember.js | eb2559f96e9e5300807e976702111fa27836bfa2.json | Change Object to any | packages/ember-testing/lib/helpers/wait.js | @@ -30,7 +30,7 @@ import { pendingRequests } from '../test/pending_requests';
@method wait
@param {Object} value The value to be returned.
- @return {RSVP.Promise<Object>} Promise that resolves to the passed value.
+ @return {RSVP.Promise<any>} Promise that resolves to the passed value.
@public
@since 1... | false |
Other | emberjs | ember.js | 2e01276c2a4c0eee51669f3e12092dcf720fb46a.json | Add 2.14.0-beta.3 to CHANGELOG.md.
[ci skip] | CHANGELOG.md | @@ -1,13 +1,20 @@
# Ember Changelog
+### 2.14.0-beta.3 (May 30, 2017)
+
+- [#15242](https://github.com/emberjs/ember.js/pull/15242) [BUGFIX] Fix EmberError import in system/router
+- [#15204](https://github.com/emberjs/ember.js/pull/15204) [DEPRECATION] `Ember.MODEL_FACTORY_INJECTIONS` is now always false, and issue... | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.