language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | 5291c74d5ec0125161e8b7c72d7c6b0688efb4b2.json | Add 2.13.3 to CHANGELOG.md
[ci skip] | CHANGELOG.md | @@ -19,6 +19,11 @@
- [#15178](https://github.com/emberjs/ember.js/pull/15178) Refactor route to lookup controller for QPs.
- [#15129](https://github.com/emberjs/ember.js/pull/15129) Fix access to service:-document in ember-engines
+### 2.13.3 (May 31, 2017)
+
+- [#15284](https://github.com/emberjs/ember.js/pull/152... | false |
Other | emberjs | ember.js | 787e0894144fb498f5350d25a72559217b227403.json | Add 2.13.2 to CHANGELOG.md
[ci skip] | CHANGELOG.md | @@ -19,6 +19,10 @@
- [#15178](https://github.com/emberjs/ember.js/pull/15178) Refactor route to lookup controller for QPs.
- [#15129](https://github.com/emberjs/ember.js/pull/15129) Fix access to service:-document in ember-engines
+### 2.13.2 (May 18, 2017)
+
+- Revert over eager dependency upgrades in 2.13.1.
+
#... | false |
Other | emberjs | ember.js | f7615bd2817563226d699824e5487b21c84abb97.json | Add 2.13.1 to CHANGELOG.
[ci skip] | CHANGELOG.md | @@ -19,6 +19,14 @@
- [#15178](https://github.com/emberjs/ember.js/pull/15178) Refactor route to lookup controller for QPs.
- [#15129](https://github.com/emberjs/ember.js/pull/15129) Fix access to service:-document in ember-engines
+### 2.13.1 (May 17, 2017)
+
+- [#15129](https://github.com/emberjs/ember.js/pull/151... | false |
Other | emberjs | ember.js | c2f40bf6e1cc898a4fa2b7c5e76d7127acbb7bcc.json | Add EventDispatcher tests for event bubbling | packages/ember-glimmer/tests/integration/event-dispatcher-test.js | @@ -37,6 +37,59 @@ moduleFor('EventDispatcher', class extends RenderingTest {
assert.strictEqual(receivedEvent.target, this.$('#is-done')[0]);
}
+ ['@test events bubble to parent view'](assert) {
+ let receivedEvent;
+
+ this.registerComponent('x-foo', {
+ ComponentClass: Component.extend({
+ ... | false |
Other | emberjs | ember.js | 44f8068ade5b917f0a9dae6d80b9d95bcfc9e9f0.json | Update yarn.lock to use `backburner.js@1.0.0`.
Looks like this was not done when the `package.json` was updated. | yarn.lock | @@ -835,9 +835,9 @@ backbone@^1.1.2:
dependencies:
underscore ">=1.8.3"
-backburner.js@^0.4.0:
- version "0.4.0"
- resolved "https://registry.yarnpkg.com/backburner.js/-/backburner.js-0.4.0.tgz#fabf211381b8c17309fda1fbea698b4204f447b5"
+backburner.js@^1.0.0:
+ version "1.0.0"
+ resolved "https://registry.... | false |
Other | emberjs | ember.js | 1ec2e33c65403abbe258c51db13475ab1c3a1277.json | clean undefined check | packages/ember-routing/lib/system/router.js | @@ -197,7 +197,7 @@ const EmberRouter = EmberObject.extend(Evented, {
let initialURL = get(this, 'initialURL');
if (this.setupRouter()) {
- if (typeof initialURL === 'undefined') {
+ if (initialURL === undefined) {
initialURL = get(this, 'location').getURL();
}
let initialTr... | false |
Other | emberjs | ember.js | 2f5f544b2901589f02d953a11e2617fa1e4ae61b.json | Update glimmer versions to 0.24.0-alpha.2. | package.json | @@ -39,11 +39,11 @@
"link:glimmer": "node bin/yarn-link-glimmer.js"
},
"dependencies": {
- "@glimmer/compiler": "^0.23.0-alpha.17",
- "@glimmer/node": "^0.23.0-alpha.17",
- "@glimmer/reference": "^0.23.0-alpha.17",
- "@glimmer/runtime": "^0.23.0-alpha.17",
- "@glimmer/util": "^0.23.0-alpha.17"... | true |
Other | emberjs | ember.js | 2f5f544b2901589f02d953a11e2617fa1e4ae61b.json | Update glimmer versions to 0.24.0-alpha.2. | yarn.lock | @@ -2,78 +2,78 @@
# yarn lockfile v1
-"@glimmer/compiler@^0.23.0-alpha.17":
- version "0.23.0-alpha.17"
- resolved "https://registry.yarnpkg.com/@glimmer/compiler/-/compiler-0.23.0-alpha.17.tgz#ac30e7c24e14e6f7d299d141108b881c439f7f9c"
- dependencies:
- "@glimmer/interfaces" "^0.23.0-alpha.17"
- "@glimmer... | true |
Other | emberjs | ember.js | 3da5219649a7e2cd2a929468e97b7a11f7641590.json | Remove iterableForObject tests.
These are largely duplication functionality in `{{each-in}}`'s own
tests. They were added as a way to flesh out the iterable implementation. | packages/ember-glimmer/tests/unit/utils/iterable-test.js | @@ -98,70 +98,6 @@ moduleFor('Iterable', class extends TestCase {
}
}
- ['@test iterates over an object\'s own properties']() {
- let iterator = iteratorForObject({ first: 'foo', second: 'bar' });
-
- this.assert.deepEqual(iterator.next(), { key: 'first', memo: 'first', value: 'foo' });
- this.asser... | false |
Other | emberjs | ember.js | 21696d7f4a4fe7e4d38523c809d594ef16bac9cf.json | remove extra wrapping function | packages/ember-routing/lib/location/hash_location.js | @@ -110,16 +110,14 @@ export default EmberObject.extend({
onUpdateURL(callback) {
this._removeEventListener();
- this._hashchangeHandler = () => {
- run(() => {
- let path = this.getURL();
- if (get(this, 'lastSetURL') === path) { return; }
+ this._hashchangeHandler = run.bind(this, f... | false |
Other | emberjs | ember.js | 15c10d5692f7eb3b354334d03a54c4c6a20a388c.json | blueprints: remove explicit names from initializers.
See https://github.com/emberjs/guides/pull/1654 and https://github.com/ember-cli/ember-cli-legacy-blueprints/pull/54. | blueprints/initializer/files/__root__/initializers/__name__.js | @@ -3,6 +3,5 @@ export function initialize(/* application */) {
}
export default {
- name: '<%= dasherizedModuleName %>',
initialize
}; | true |
Other | emberjs | ember.js | 15c10d5692f7eb3b354334d03a54c4c6a20a388c.json | blueprints: remove explicit names from initializers.
See https://github.com/emberjs/guides/pull/1654 and https://github.com/ember-cli/ember-cli-legacy-blueprints/pull/54. | blueprints/instance-initializer/files/__root__/instance-initializers/__name__.js | @@ -3,6 +3,5 @@ export function initialize(/* appInstance */) {
}
export default {
- name: '<%= dasherizedModuleName %>',
initialize
}; | true |
Other | emberjs | ember.js | 15c10d5692f7eb3b354334d03a54c4c6a20a388c.json | blueprints: remove explicit names from initializers.
See https://github.com/emberjs/guides/pull/1654 and https://github.com/ember-cli/ember-cli-legacy-blueprints/pull/54. | node-tests/blueprints/initializer-test.js | @@ -24,7 +24,6 @@ describe('Acceptance: ember generate and destroy initializer', function() {
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo',\n" +
" initialize\n" +
"};");
@... | true |
Other | emberjs | ember.js | 15c10d5692f7eb3b354334d03a54c4c6a20a388c.json | blueprints: remove explicit names from initializers.
See https://github.com/emberjs/guides/pull/1654 and https://github.com/ember-cli/ember-cli-legacy-blueprints/pull/54. | node-tests/blueprints/instance-initializer-test.js | @@ -24,7 +24,6 @@ describe('Acceptance: ember generate and destroy instance-initializer', function
"}\n" +
"\n" +
"export default {\n" +
- " name: 'foo',\n" +
" initialize\n" +
"};")... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | CHANGELOG.md | @@ -218,7 +218,7 @@
- [#13672](https://github.com/emberjs/ember.js/pull/13672) [BUGFIX] Fix issue with `this.render` and `this.disconnectOutlet` in routes.
- [#13716](https://github.com/emberjs/ember.js/pull/13716) [BUGFIX] Ensure that `Ember.Test.waiters` allows access to configured test waiters.
- [#13273](https:/... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | CODE_OF_CONDUCT.md | @@ -2,7 +2,7 @@ The Ember team and community are committed to everyone having a safe and inclusi
**Our Community Guidelines / Code of Conduct can be found here**:
-http://emberjs.com/guidelines/
+https://emberjs.com/guidelines/
For a history of updates, see the page history here:
| true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | CONTRIBUTING.md | @@ -90,7 +90,7 @@ along.
In short, if you have an idea that would be nice to have, create an issue on the
emberjs/rfcs repo. If you have a question about requesting a feature, start a
-discussion at [discuss.emberjs.com](http://discuss.emberjs.com)
+discussion at [discuss.emberjs.com](https://discuss.emberjs.com)
... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | FEATURES.md | @@ -1,6 +1,6 @@
## About Features
-Please read the [Feature Flag Guide](http://emberjs.com/guides/configuring-ember/feature-flags/)
+Please read the [Feature Flag Guide](https://emberjs.com/guides/configuring-ember/feature-flags/)
for a detailed explanation.
## Feature Flags | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | README.md | @@ -1,5 +1,5 @@
<p align="center">
- <a href="http://emberjs.com"><img width="300" src="https://raw.githubusercontent.com/emberjs/website/master/source/images/brand/ember_Ember-Light.png"></a>
+ <a href="https://emberjs.com"><img width="300" src="https://raw.githubusercontent.com/emberjs/website/master/source/images... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | package.json | @@ -5,7 +5,7 @@
"keywords": [
"ember-addon"
],
- "homepage": "http://emberjs.com/",
+ "homepage": "https://emberjs.com/",
"bugs": {
"url": "https://github.com/emberjs/ember.js/issues"
}, | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/container/lib/registry.js | @@ -622,7 +622,7 @@ Registry.prototype = {
function deprecateResolverFunction(registry) {
deprecate('Passing a `resolver` function into a Registry is deprecated. Please pass in a Resolver object with a `resolve` method.',
false,
- { id: 'ember-application.registry-resolver-as-function', unti... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember-application/lib/system/engine.js | @@ -131,7 +131,7 @@ const Engine = Namespace.extend(RegistryProxyMixin, {
false, {
id: 'ember-application.app-initializer-initialize-arguments',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x/#toc_initializer-arity'
+ url: 'https://emberjs.com/dep... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember-debug/lib/deprecate.js | @@ -15,7 +15,7 @@ import { registerHandler as genericRegisterHandler, invoke } from './handlers';
/**
Allows for runtime registration of handler functions that override the default deprecation behavior.
- Deprecations are invoked by calls to [Ember.deprecate](http://emberjs.com/api/classes/Ember.html#method_depr... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember-debug/lib/warn.js | @@ -16,7 +16,7 @@ let missingOptionsDeprecation, missingOptionsIdDeprecation;
if (DEBUG) {
/**
Allows for runtime registration of handler functions that override the default warning behavior.
- Warnings are invoked by calls made to [Ember.warn](http://emberjs.com/api/classes/Ember.html#method_warn).
+ Wa... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember-glimmer/lib/component.js | @@ -550,7 +550,7 @@ const Component = CoreView.extend(
{
id: 'ember-views.component.defaultLayout',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x/#toc_ember-component-defaultlayout'
+ url: 'https://emberjs.com/deprecations/v2.x/#toc_ember-compone... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember-glimmer/lib/syntax/input.js | @@ -16,7 +16,7 @@ function buildTextFieldSyntax(params, hash, builder) {
The `{{input}}` helper lets you create an HTML `<input />` component.
It causes an `Ember.TextField` component to be rendered. For more info,
see the [Ember.TextField](/api/classes/Ember.TextField.html) docs and
- the [templates guide](... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember-glimmer/lib/syntax/outlet.js | @@ -49,7 +49,7 @@ function outletComponentFor(vm) {
{{my-footer}}
```
- See [templates guide](http://emberjs.com/guides/templates/the-application-template/) for
+ See [templates guide](https://emberjs.com/guides/templates/the-application-template/) for
additional information on using `{{outlet}}` in `appli... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember-glimmer/lib/utils/string.js | @@ -26,7 +26,7 @@ export function getSafeString() {
{
id: 'ember-htmlbars.ember-handlebars-safestring',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x#toc_use-ember-string-htmlsafe-over-ember-handlebars-safestring'
+ url: 'https://emberjs.com/deprecations/v2.x#toc_use-ember-st... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember-glimmer/tests/integration/application/rendering-test.js | @@ -91,7 +91,7 @@ moduleFor('Application test: rendering', class extends ApplicationTest {
`);
this.addTemplate('nav', strip`
- <a href="http://emberjs.com/">Ember</a>
+ <a href="https://emberjs.com/">Ember</a>
`);
this.add('route:application', Route.extend({
@@ -122,7 +122,7 @@ module... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember-metal/lib/binding.js | @@ -44,7 +44,7 @@ class Binding {
/**
@class Binding
@namespace Ember
- @deprecated See http://emberjs.com/deprecations/v2.x#toc_ember-binding
+ @deprecated See https://emberjs.com/deprecations/v2.x#toc_ember-binding
@public
*/
@@ -303,17 +303,17 @@ function fireDeprecations(obj, toPath, fr... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember-metal/lib/computed.js | @@ -121,7 +121,7 @@ const DEEP_EACH_REGEX = /\.@each\.[^.]+\./;
Additional resources:
- [New CP syntax RFC](https://github.com/emberjs/rfcs/blob/master/text/0011-improved-cp-syntax.md)
- - [New computed syntax explained in "Ember 1.12 released" ](http://emberjs.com/blog/2015/05/13/ember-1-12-released.html#toc_... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember-metal/lib/core.js | @@ -14,7 +14,7 @@ import { context } from 'ember-environment';
cross-platform compatibility and object property observing. Ember-Runtime is
small and performance-focused so you can use it alongside other
cross-platform libraries such as jQuery. For more details, see
- [Ember-Runtime](http://emberjs.com/api/m... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember-metal/lib/events.js | @@ -84,7 +84,7 @@ export function addListener(obj, eventName, target, method, once) {
{
id: 'ember-views.did-init-attrs',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x#toc_ember-component-didinitattrs'
+ url: 'https://emberjs.com/deprecations/v2.x#toc_ember-component-didinita... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember-routing/lib/services/router.js | @@ -27,7 +27,7 @@ const RouterService = Service.extend({
Transition the application into another route. The route may
be either a single route or route path:
- See [Route.transitionTo](http://emberjs.com/api/classes/Ember.Route.html#method_transitionTo) for more info.
+ See [Route.transitionTo](ht... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember-routing/lib/system/route.js | @@ -66,7 +66,7 @@ export function hasDefaultSerialize(route) {
/**
The `Ember.Route` class is used to define individual routes. Refer to
- the [routing guide](http://emberjs.com/guides/routing/) for documentation.
+ the [routing guide](https://emberjs.com/guides/routing/) for documentation.
@class Route
... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember-routing/lib/system/router.js | @@ -53,7 +53,7 @@ const { slice } = Array.prototype;
/**
The `Ember.Router` class manages the application state and URLs. Refer to
- the [routing guide](http://emberjs.com/guides/routing/) for documentation.
+ the [routing guide](https://emberjs.com/guides/routing/) for documentation.
@class Router
@nam... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember-runtime/lib/mixins/array.js | @@ -307,7 +307,7 @@ const ArrayMixin = Mixin.create(Enumerable, {
deprecate(
'`Enumerable#contains` is deprecated, use `Enumerable#includes` instead.',
false,
- { id: 'ember-runtime.enumerable-contains', until: '3.0.0', url: 'http://emberjs.com/deprecations/v2.x#toc_enumerable-contains' }
+ ... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember-runtime/lib/mixins/enumerable.js | @@ -221,7 +221,7 @@ const Enumerable = Mixin.create({
```
@method contains
- @deprecated Use `Enumerable#includes` instead. See http://emberjs.com/deprecations/v2.x#toc_enumerable-contains
+ @deprecated Use `Enumerable#includes` instead. See https://emberjs.com/deprecations/v2.x#toc_enumerable-contain... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember-runtime/lib/mixins/registry_proxy.js | @@ -286,7 +286,7 @@ function buildFakeRegistryFunction(instance, typeForMessage, deprecatedProperty,
{
id: 'ember-application.app-instance-registry',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x/#toc_ember-application-registry-ember-applicationinstance-registry'
+ ... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember-template-compiler/lib/plugins/deprecate-render-model.js | @@ -20,7 +20,7 @@ DeprecateRenderModel.prototype.transform = function DeprecateRenderModel_transfo
deprecate(deprecationMessage(moduleName, node, param), false, {
id: 'ember-template-compiler.deprecate-render-model',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x#toc_model-... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember-template-compiler/lib/plugins/deprecate-render.js | @@ -19,7 +19,7 @@ DeprecateRender.prototype.transform = function DeprecateRender_transform(ast) {
deprecate(deprecationMessage(moduleName, node), false, {
id: 'ember-template-compiler.deprecate-render',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x#toc_code-render-code-hel... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember-views/lib/mixins/view_support.js | @@ -430,7 +430,7 @@ export default Mixin.create({
{
id: 'ember-views.did-init-attrs',
until: '3.0.0',
- url: 'http://emberjs.com/deprecations/v2.x#toc_ember-component-didinitattrs'
+ url: 'https://emberjs.com/deprecations/v2.x#toc_ember-component-didinitattrs'
}
);
| true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember-views/lib/system/utils.js | @@ -18,7 +18,7 @@ export function constructStyleDeprecationMessage(affectedStyle) {
'Binding style attributes may introduce cross-site scripting vulnerabilities; ' +
'please ensure that values being bound are properly escaped. For more information, ' +
'including how to disable this warning, see ' +
- ... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember-views/lib/views/view.js | @@ -7,7 +7,7 @@
@class View
@namespace Ember
@extends Ember.CoreView
- @deprecated See http://emberjs.com/deprecations/v1.x/#toc_ember-view
+ @deprecated See https://emberjs.com/deprecations/v1.x/#toc_ember-view
@uses Ember.ClassNamesSupport
@private
*/ | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | packages/ember/lib/index.js | @@ -185,7 +185,7 @@ if (DEBUG) {
{
id: 'ember-metal.model_factory_injections',
until: '2.17.0',
- url: 'http://emberjs.com/deprecations/v2.x#toc_code-ember-model-factory-injections'
+ url: 'https://emberjs.com/deprecations/v2.x#toc_code-ember-model-factory-injections'
... | true |
Other | emberjs | ember.js | 2db2c79e647d48dd86b52654d6992977f8d1b4e7.json | Use https in references to emberjs website | yuidoc.json | @@ -1,7 +1,7 @@
{
"name": "The Ember API",
"description": "The Ember API: a framework for building ambitious web applications",
- "url": "http://emberjs.com/",
+ "url": "https://emberjs.com/",
"options": {
"paths": [
"packages/ember/lib", | true |
Other | emberjs | ember.js | 5c3393920dad5145bae7c76b14f23a109341eb5f.json | use test instead of match in `isBlank` | packages/ember-metal/lib/is_blank.js | @@ -25,5 +25,5 @@ import isEmpty from './is_empty';
@public
*/
export default function isBlank(obj) {
- return isEmpty(obj) || (typeof obj === 'string' && obj.match(/\S/) === null);
+ return isEmpty(obj) || (typeof obj === 'string' && /\S/.test(obj) === false);
} | false |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | CHANGELOG.md | @@ -604,7 +604,7 @@
### 1.13.10 (September 6, 2015)
- [#12104](https://github.com/emberjs/ember.js/pull/12104) [BUGFIX] Ensure `concatenatedProperties` are not stomped.
-- [#12256](https://github.com/emberjs/ember.js/pull/12256) [BUGFIX] Ensure concat streams unsubscribe properly. Fixes memory leak with attributes ... | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | CONTRIBUTING.md | @@ -56,7 +56,7 @@ original notice.
* If you submit a feature request as an issue, you will be invited to follow the
[instructions in this document](https://github.com/emberjs/ember.js/blob/master/CONTRIBUTING.md#requesting-a-feature)
and the issue will be closed
-* Issues that become inactive will be labelled accord... | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/container/lib/container.js | @@ -60,7 +60,7 @@ Container.prototype = {
/**
Given a fullName return a corresponding instance.
- The default behaviour is for lookup to return a singleton instance.
+ The default behavior is for lookup to return a singleton instance.
The singleton is scoped to the container, allowing multiple contai... | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/container/lib/registry.js | @@ -263,7 +263,7 @@ Registry.prototype = {
},
/**
- A hook to enable custom fullName normalization behaviour
+ A hook to enable custom fullName normalization behavior
@private
@method normalizeFullName | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/ember-glimmer/lib/components/link-to.js | @@ -75,7 +75,7 @@
any passed value to `disabled` will disable it except `undefined`.
to ensure that only `true` disable the `link-to` component you can
- override the global behaviour of `Ember.LinkComponent`.
+ override the global behavior of `Ember.LinkComponent`.
```javascript
Ember.LinkComponent.r... | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/ember-glimmer/lib/helpers/action.js | @@ -84,7 +84,7 @@ export const ACTION = symbol('ACTION');
Two options can be passed to the `action` helper when it is used in this way.
* `target=someProperty` will look to `someProperty` instead of the current
- context for the `actions` hash. This can be useful when targetting a
+ context for the `actio... | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/ember-glimmer/lib/helpers/get.js | @@ -17,7 +17,7 @@ import {
Dynamically look up a property on an object. The second argument to `{{get}}`
should have a string value, although it can be bound.
- For example, these two usages are equivilent:
+ For example, these two usages are equivalent:
```handlebars
{{person.height}} | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/ember-glimmer/lib/renderer.js | @@ -252,7 +252,7 @@ class Renderer {
}
getElement(view) {
- // overriden in the subclasses
+ // overridden in the subclasses
}
getBounds(view) { | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/ember-glimmer/lib/syntax.js | @@ -71,7 +71,7 @@ function refineBlockSyntax(sexp, builder) {
export const experimentalMacros = [];
-// This is a private API to allow for expiremental macros
+// This is a private API to allow for experimental macros
// to be created in user space. Registering a macro should
// should be done in an initializer.... | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/ember-glimmer/tests/integration/components/attrs-lookup-test.js | @@ -207,7 +207,7 @@ moduleFor('Components test: attrs lookup', class extends RenderingTest {
assert.equal(instance.get('second'), 'second', 'matches known value');
}
- ['@test bound computed properties can be overriden in extensions, set during init, and passed in as attrs']() {
+ ['@test bound computed pro... | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/ember-glimmer/tests/integration/components/contextual-components-test.js | @@ -835,14 +835,14 @@ moduleFor('Components test: contextual components', class extends RenderingTest
assert.ok(!isEmpty(instance), 'a instance was created');
assert.equal(previousInstance, undefined, 'no previous component exists');
assert.equal(initCount, 1, 'the component was constructed exactly 1 tim... | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/ember-glimmer/tests/integration/components/curly-components-test.js | @@ -1485,7 +1485,7 @@ moduleFor('Components test: curly components', class extends RenderingTest {
this.assertComponentElement(this.firstChild, { attrs: { role: 'main' } });
}
- ['@test `template` specified in component is overriden by block']() {
+ ['@test `template` specified in component is overridden by... | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/ember-metal/lib/run_loop.js | @@ -259,7 +259,7 @@ run.end = function() {
will be resolved on the target object at the time the scheduled item is
invoked allowing you to change the target function.
@param {Object} [arguments*] Optional arguments to be passed to the queued method.
- @return {*} Timer information for use in cancelling, s... | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/ember-metal/tests/accessors/get_test.js | @@ -55,19 +55,19 @@ testBoth('should call unknownProperty on watched values if the value is undefine
equal(get(obj, 'foo'), 'FOO', 'should return value from unknown');
});
-QUnit.test('warn on attemps to call get with no arguments', function() {
+QUnit.test('warn on attempts to call get with no arguments', functi... | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/ember-metal/tests/events_test.js | @@ -254,7 +254,7 @@ QUnit.test('a listener added as part of a mixin may be overridden', function() {
SecondMixin.apply(obj);
sendEvent(obj, 'bar');
- equal(triggered, 0, 'should not invoke from overriden property');
+ equal(triggered, 0, 'should not invoke from overridden property');
sendEvent(obj, 'baz'... | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/ember-metal/tests/injected_property_test.js | @@ -19,7 +19,7 @@ QUnit.test('injected properties should be overridable', function() {
set(obj, 'foo', 'bar');
- equal(get(obj, 'foo'), 'bar', 'should return the overriden value');
+ equal(get(obj, 'foo'), 'bar', 'should return the overridden value');
});
QUnit.test('getting on an object without an owner o... | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/ember-metal/tests/mixin/observer_test.js | @@ -184,7 +184,7 @@ testBoth('observing chain with property in mixin after', function(get, set) {
equal(get(obj, 'count'), 1, 'should invoke observer after change');
});
-testBoth('observing chain with overriden property', function(get, set) {
+testBoth('observing chain with overridden property', function(get, se... | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/ember-routing/lib/ext/controller.js | @@ -17,7 +17,7 @@ ControllerMixin.reopen({
`this.category` and `this.page`.
By default, Ember coerces query parameter values using `toggleProperty`.
This behavior may lead to unexpected results.
- To explicity configure a query parameter property so it coerces as expected, you must define a type prope... | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/ember-routing/lib/system/router.js | @@ -71,7 +71,7 @@ const EmberRouter = EmberObject.extend(Evented, {
* `history` - use the browser's history API to make the URLs look just like any standard URL
* `hash` - use `#` to separate the server part of the URL from the Ember part: `/blog/#/posts/new`
* `none` - do not store the Ember URL in the ... | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/ember-runtime/lib/mixins/container_proxy.js | @@ -50,7 +50,7 @@ let containerProxyMixin = {
/**
Given a fullName return a corresponding instance.
- The default behaviour is for lookup to return a singleton instance.
+ The default behavior is for lookup to return a singleton instance.
The singleton is scoped to the container, allowing multiple cont... | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/ember-runtime/tests/system/array_proxy/arranged_content_test.js | @@ -300,7 +300,7 @@ QUnit.test('firstObject - returns first arranged object', function() {
});
QUnit.test('arrangedContentArray{Will,Did}Change are called when the arranged content changes', function() {
- // The behaviour covered by this test may change in the future if we decide
+ // The behavior covered by thi... | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/ember-runtime/tests/system/array_proxy/content_change_test.js | @@ -95,7 +95,7 @@ QUnit.test('The ArrayProxy doesn\'t explode when assigned a destroyed object', f
});
QUnit.test('arrayContent{Will,Did}Change are called when the content changes', function() {
- // The behaviour covered by this test may change in the future if we decide
+ // The behavior covered by this test ma... | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/ember-views/lib/mixins/text_support.js | @@ -19,7 +19,7 @@ const KEY_EVENTS = {
`TextSupport` is a shared mixin used by both `Ember.TextField` and
`Ember.TextArea`. `TextSupport` adds a number of methods that allow you to
specify a controller action to invoke when a certain event is fired on your
- text field or textarea. The specifed controller act... | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/ember-views/lib/system/utils.js | @@ -158,7 +158,7 @@ export function getViewClientRects(view) {
`getViewBoundingClientRect` provides information about the position of the
bounding border box edges of a view relative to the viewport.
- It is only intended to be used by development tools like the Ember Inpsector
+ It is only intended to be use... | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/ember/tests/routing/basic_test.js | @@ -2032,7 +2032,7 @@ QUnit.test('Generated route should be an instance of App.Route if provided', fun
ok(generatedRoute instanceof App.Route, 'should extend the correct route');
});
-QUnit.test('Nested index route is not overriden by parent\'s implicit index route', function() {
+QUnit.test('Nested index route i... | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/ember/tests/routing/query_params_test.js | @@ -204,7 +204,7 @@ moduleFor('Query Params - main', class extends QueryParamTestCase {
this.assertCurrentPath('/', 'QP did not update due to being overriden');
this.setAndFlush(indexController, 'c', false);
- this.assertCurrentPath('/?c=false', 'QP updated with overriden param');
+ this.asser... | true |
Other | emberjs | ember.js | 62aaae02656ed14859588dc7edfe34118337e161.json | fix typos with misspell
This PR is part of a campaign to fix a lot of typos on github!
You can see the progress on https://github.com/fixTypos/fix_typos/
https://github.com/client9/misspell | packages/external-helpers/lib/external-helpers-dev.js | @@ -56,7 +56,7 @@ export function defaults(obj, defaults) {
export const possibleConstructorReturn = (function (self, call) {
if (!self) {
- throw new ReferenceError(`this hasn't been initialised - super() hasn't been called`);
+ throw new ReferenceError(`this hasn't been initialized - super() hasn't been c... | true |
Other | emberjs | ember.js | d3f6ffa976a0f8b9b12baf6347b60508b0278266.json | Fix non-singleton `{{render` tests. | packages/ember-glimmer/lib/syntax/render.js | @@ -130,7 +130,7 @@ export function renderMacro(name, params, hash, builder) {
class AbstractRenderManager extends AbstractManager {
prepareArgs(definition, args) {
- return args;
+ return null;
}
/* abstract create(environment, definition, args, dynamicScope); */ | false |
Other | emberjs | ember.js | 19316037b03cf7e012dd8342c6764a3159603f45.json | Fix iterable hook | packages/ember-glimmer/lib/environment.js | @@ -236,9 +236,8 @@ export default class Environment extends GlimmerEnvironment {
return ConditionalReference.create(reference);
}
- iterableFor(ref, args) {
- let keyPath = args.named.get('key').value();
- return createIterable(ref, keyPath);
+ iterableFor(ref, key) {
+ return createIterable(ref, ... | false |
Other | emberjs | ember.js | 6d1983c98a3210717689e22c3ac99dbcba72e7ca.json | Update helpers to use new args | packages/ember-glimmer/lib/helpers/-class.js | @@ -24,5 +24,5 @@ function classHelper({ positional }) {
}
export default function(vm, args) {
- return new InternalHelperReference(classHelper, args);
+ return new InternalHelperReference(classHelper, args.capture());
} | true |
Other | emberjs | ember.js | 6d1983c98a3210717689e22c3ac99dbcba72e7ca.json | Update helpers to use new args | packages/ember-glimmer/lib/helpers/-html-safe.js | @@ -7,5 +7,5 @@ function htmlSafe({ positional }) {
}
export default function(vm, args) {
- return new InternalHelperReference(htmlSafe, args);
+ return new InternalHelperReference(htmlSafe, args.capture());
} | true |
Other | emberjs | ember.js | 6d1983c98a3210717689e22c3ac99dbcba72e7ca.json | Update helpers to use new args | packages/ember-glimmer/lib/helpers/-input-type.js | @@ -9,5 +9,5 @@ function inputTypeHelper({ positional, named }) {
}
export default function(vm, args) {
- return new InternalHelperReference(inputTypeHelper, args);
+ return new InternalHelperReference(inputTypeHelper, args.capture());
} | true |
Other | emberjs | ember.js | 6d1983c98a3210717689e22c3ac99dbcba72e7ca.json | Update helpers to use new args | packages/ember-glimmer/lib/helpers/-normalize-class.js | @@ -16,5 +16,5 @@ function normalizeClass({ positional, named }) {
}
export default function(vm, args) {
- return new InternalHelperReference(normalizeClass, args);
+ return new InternalHelperReference(normalizeClass, args.capture());
} | true |
Other | emberjs | ember.js | 6d1983c98a3210717689e22c3ac99dbcba72e7ca.json | Update helpers to use new args | packages/ember-glimmer/lib/helpers/component.js | @@ -275,6 +275,6 @@ function curryArgs(definition, newArgs) {
return mergedArgs;
}
-export default function(vm, args, symbolTable) {
- return ClosureComponentReference.create(args, symbolTable, vm.env);
+export default function(vm, args, meta) {
+ return ClosureComponentReference.create(args.capture(), meta, vm... | true |
Other | emberjs | ember.js | 6d1983c98a3210717689e22c3ac99dbcba72e7ca.json | Update helpers to use new args | packages/ember-glimmer/lib/helpers/concat.js | @@ -27,5 +27,5 @@ function concat({ positional }) {
}
export default function(vm, args) {
- return new InternalHelperReference(concat, args);
+ return new InternalHelperReference(concat, args.capture());
} | true |
Other | emberjs | ember.js | 6d1983c98a3210717689e22c3ac99dbcba72e7ca.json | Update helpers to use new args | packages/ember-glimmer/lib/helpers/loc.js | @@ -43,5 +43,5 @@ function locHelper({ positional }) {
}
export default function(vm, args) {
- return new InternalHelperReference(locHelper, args);
+ return new InternalHelperReference(locHelper, args.capture());
} | true |
Other | emberjs | ember.js | 6d1983c98a3210717689e22c3ac99dbcba72e7ca.json | Update helpers to use new args | packages/ember-glimmer/lib/helpers/log.js | @@ -24,5 +24,5 @@ function log({ positional }) {
}
export default function(vm, args) {
- return new InternalHelperReference(log, args);
+ return new InternalHelperReference(log, args.capture());
} | true |
Other | emberjs | ember.js | 6d1983c98a3210717689e22c3ac99dbcba72e7ca.json | Update helpers to use new args | packages/ember-glimmer/lib/helpers/query-param.js | @@ -32,5 +32,5 @@ function queryParams({ positional, named }) {
}
export default function(vm, args) {
- return new InternalHelperReference(queryParams, args);
+ return new InternalHelperReference(queryParams, args.capture());
} | true |
Other | emberjs | ember.js | 6d1983c98a3210717689e22c3ac99dbcba72e7ca.json | Update helpers to use new args | packages/ember-glimmer/lib/helpers/unbound.js | @@ -37,7 +37,7 @@ import { UnboundReference } from '../utils/references';
export default function(vm, args) {
assert(
'unbound helper cannot be called with multiple params or hash params',
- args.positional.values.length === 1 && args.named.keys.length === 0
+ args.positional.length === 1 && args.named.l... | true |
Other | emberjs | ember.js | 10a2e8b84591c593ccfa79d1c6055054ef93da26.json | Fix build scripts for latest Glimmer | broccoli/packages.js | @@ -186,7 +186,7 @@ module.exports.emberPkgES = function _emberPkgES(name, rollup, externs) {
}
module.exports.glimmerPkgES = function _glimmerPkgES(name, externs = []) {
- return new Rollup(findLib(name, 'dist/modules'), {
+ return new Rollup(findLib(name, 'dist/modules/es5'), {
rollup: {
entry: 'ind... | true |
Other | emberjs | ember.js | 10a2e8b84591c593ccfa79d1c6055054ef93da26.json | Fix build scripts for latest Glimmer | ember-cli-build.js | @@ -58,7 +58,7 @@ module.exports = function(options) {
let emberTemplateCompiler = emberPkgES('ember-template-compiler');
let emberTemplateCompilerES5 = toES5(emberTemplateCompiler, { annotation: 'ember-template-compiler' });
let glimmerSyntax = toES5(
- glimmerPkgES('@glimmer/syntax', ['handlebars', 'simpl... | true |
Other | emberjs | ember.js | 1e5b8a90f82d1e81cb673c4f1f6e3a8fdd5a6a2c.json | Add 2.14.0-beta.2 to changelog.
[ci skip] | CHANGELOG.md | @@ -1,5 +1,13 @@
# Ember Changelog
+### 2.14.0-beta.2 (May 10, 2017)
+
+- [#15138](https://github.com/emberjs/ember.js/pull/15138) [BUGFIX] Fix mocha blueprint service test filename
+- [#15193](https://github.com/emberjs/ember.js/pull/15193) [BUGFIX] Ensure `factoryFor` does validation.
+- [#15207](https://github.co... | false |
Other | emberjs | ember.js | af1a6f5289a4ec08fa40e3c8357789fe904f4b37.json | Remove blank line from qunit test file | blueprints/component-test/qunit-files/tests/__testType__/__path__/__test__.js | @@ -8,8 +8,7 @@ moduleForComponent('<%= componentPathName %>', '<%= friendlyTestDescription %>',
});
test('it renders', function(assert) {
-<% if (testType === 'integration' ) { %>
- // Set any properties with this.set('myProperty', 'value');
+ <% if (testType === 'integration' ) { %>// Set any properties with th... | false |
Other | emberjs | ember.js | 579f857f822eef990a2f9520128120c103c240fe.json | Remove factory injections.
These were only around to support `lookupFactory` semantics. | packages/container/lib/registry.js | @@ -32,8 +32,6 @@ export default function Registry(options) {
this._typeInjections = dictionary(null);
this._injections = dictionary(null);
- this._factoryTypeInjections = dictionary(null);
- this._factoryInjections = dictionary(null);
this._localLookupCache = Object.create(nul... | true |
Other | emberjs | ember.js | 579f857f822eef990a2f9520128120c103c240fe.json | Remove factory injections.
These were only around to support `lookupFactory` semantics. | packages/container/tests/registry_test.js | @@ -436,29 +436,6 @@ QUnit.test('`getTypeInjections` includes type injections from a fallback registr
equal(registry.getTypeInjections('model').length, 1, 'Injections from the fallback registry are merged');
});
-QUnit.test('`getFactoryInjections` includes factory injections from a fallback registry', function() ... | true |
Other | emberjs | ember.js | a787c8274c5290512cc3fdbc60cb9e27938a6674.json | Add 2.14.0-beta.1 to the CHANGELOG.
[ci skip] | CHANGELOG.md | @@ -1,16 +1,25 @@
# Ember Changelog
-### 2.13.0-beta.2 (April 7, 2017)
+### 2.14.0-beta.1 (April 27, 2017)
+
+- [#15015](https://github.com/emberjs/ember.js/pull/15015) Allow mounting routeless engines with a bound engine name
+- [#15078](https://github.com/emberjs/ember.js/pull/15078) [DEPRECATION] Deprecate `Event... | false |
Other | emberjs | ember.js | 466960d48fcb83cd53a92f353eccb7461307ede2.json | Add 2.12.2 to CHANGELOG.md.
[ci skip] | CHANGELOG.md | @@ -1,6 +1,6 @@
# Ember Changelog
-# 2.13.0-beta.2 (April 7, 2017)
+### 2.13.0-beta.2 (April 7, 2017)
- [#15111](https://github.com/emberjs/ember.js/pull/15111) / [#15029](https://github.com/emberjs/ember.js/pull/15029) [PERF] `factoryFor` should cache when possible.
- [#14961](https://github.com/emberjs/ember.j... | false |
Other | emberjs | ember.js | 6fead69599393c79b7ff72c9f4ace1f955fce9e2.json | Add 2.13.0-beta.2 to CHANGELOG.
[ci skip] | CHANGELOG.md | @@ -1,5 +1,14 @@
# Ember Changelog
+# 2.13.0-beta.2 (April 7, 2017)
+
+- [#15111](https://github.com/emberjs/ember.js/pull/15111) / [#15029](https://github.com/emberjs/ember.js/pull/15029) [PERF] `factoryFor` should cache when possible.
+- [#14961](https://github.com/emberjs/ember.js/pull/14961) [BUGIX] [Fixes #1492... | false |
Other | emberjs | ember.js | 3ce075b880e130508e4d7e253ae2930a0d80016c.json | Add 2.12.1 to CHANGELOG.md.
[ci skip] | CHANGELOG.md | @@ -10,7 +10,12 @@
- [#14919](https://github.com/emberjs/ember.js/pull/14919) [DEPRECATION] Deprecate the private `Ember.Router.router` property in favor of `Ember.Router._routerMicrolib`.
- [#14970](https://github.com/emberjs/ember.js/pull/14970) [BUGFIX] Generate integration tests for template helpers by default.
... | false |
Other | emberjs | ember.js | b1161bce30e1150f39c1a943ef5a7b51f6909815.json | Lock testem down to 1.15.0. | package.json | @@ -116,7 +116,7 @@
"semver": "^5.3.0",
"serve-static": "^1.12.2",
"simple-dom": "^0.3.0",
- "testem": "^1.16.0"
+ "testem": "1.15.0"
},
"ember-addon": {
"after": "ember-cli-legacy-blueprints" | true |
Other | emberjs | ember.js | b1161bce30e1150f39c1a943ef5a7b51f6909815.json | Lock testem down to 1.15.0. | yarn.lock | @@ -1732,7 +1732,7 @@ crc32-stream@^1.0.0:
buffer-crc32 "^0.2.1"
readable-stream "^2.0.0"
-cross-spawn@^5.1.0:
+cross-spawn@^5.0.0, cross-spawn@^5.1.0:
version "5.1.0"
resolved "https://registry.yarnpkg.com/cross-spawn/-/cross-spawn-5.1.0.tgz#e8bd0efee58fcff6f8f94510a0a554bbfa235449"
dependencies:
... | true |
Other | emberjs | ember.js | c32446792cee3f1006c00b2aa546438693a6cae5.json | Remove usage of `LOOKUP_FACTORY`.
This was added as a "backdoor" to use `container.lookupFactory`
(and its double extend semantics) without triggering a deprecation. | packages/container/lib/container.js | @@ -14,7 +14,6 @@ import {
import { ENV } from 'ember-environment';
const CONTAINER_OVERRIDE = symbol('CONTAINER_OVERRIDE');
-export const LOOKUP_FACTORY = symbol('LOOKUP_FACTORY');
/**
A container used to instantiate and cache objects.
@@ -121,11 +120,6 @@ Container.prototype = {
return deprecatedFactory... | true |
Other | emberjs | ember.js | c32446792cee3f1006c00b2aa546438693a6cae5.json | Remove usage of `LOOKUP_FACTORY`.
This was added as a "backdoor" to use `container.lookupFactory`
(and its double extend semantics) without triggering a deprecation. | packages/container/lib/index.js | @@ -8,6 +8,5 @@ The public API, specified on the application namespace should be considered the
export { default as Registry, privatize } from './registry';
export {
default as Container,
- buildFakeContainerWithDeprecations,
- LOOKUP_FACTORY
+ buildFakeContainerWithDeprecations
} from './container'; | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.