language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | 27b852ac99c7846162f8b263ced800bbfed2833c.json | blueprints/component-test: Add RFC232 variants | blueprints/component-test/qunit-rfc-232-files/tests/__testType__/__path__/__test__.js | @@ -0,0 +1,36 @@
+<% if (testType === 'integration') { %>import { module, test } from 'qunit';
+import { setupRenderingTest } from 'ember-qunit';
+import { render } from '@ember/test-helpers';
+import hbs from 'htmlbars-inline-precompile';
+
+module('<%= friendlyTestDescription %>', function(hooks) {
+ setupRenderingT... | true |
Other | emberjs | ember.js | 27b852ac99c7846162f8b263ced800bbfed2833c.json | blueprints/component-test: Add RFC232 variants | node-tests/blueprints/component-test.js | @@ -805,6 +805,28 @@ describe('Acceptance: ember generate component', function() {
}));
});
+ it('component-test x-foo for RFC232', function() {
+ var args = ['component-test', 'x-foo'];
+
+ return emberNew()
+ .then(() => generateFakePackageManifest('ember-cli-qunit', '4.1.1'))
+ .then(() ... | true |
Other | emberjs | ember.js | 27b852ac99c7846162f8b263ced800bbfed2833c.json | blueprints/component-test: Add RFC232 variants | node-tests/fixtures/component-test/rfc232-unit.js | @@ -0,0 +1,11 @@
+import { module, test } from 'qunit';
+import { setupTest } from 'ember-qunit';
+
+module('Unit | Component | x foo', function(hooks) {
+ setupTest(hooks);
+
+ test('it exists', function(assert) {
+ let component = this.owner.factoryFor('component:x-foo').create();
+ assert.ok(component);
+ }... | true |
Other | emberjs | ember.js | 27b852ac99c7846162f8b263ced800bbfed2833c.json | blueprints/component-test: Add RFC232 variants | node-tests/fixtures/component-test/rfc232.js | @@ -0,0 +1,26 @@
+import { module, test } from 'qunit';
+import { setupRenderingTest } from 'ember-qunit';
+import { render } from '@ember/test-helpers';
+import hbs from 'htmlbars-inline-precompile';
+
+module('Integration | Component | x foo', function(hooks) {
+ setupRenderingTest(hooks);
+
+ test('it renders', as... | true |
Other | emberjs | ember.js | 32482baeaa617ff7feb90aec5147782bbff15bb3.json | tests/blueprints/component-test: Use fixture files | node-tests/blueprints/component-test.js | @@ -13,6 +13,7 @@ var chai = require('ember-cli-blueprint-test-helpers/chai');
var expect = chai.expect;
var generateFakePackageManifest = require('../helpers/generate-fake-package-manifest');
+var fixture = require('../helpers/file');
describe('Acceptance: ember generate component', function() {
setupTestHoo... | true |
Other | emberjs | ember.js | 32482baeaa617ff7feb90aec5147782bbff15bb3.json | tests/blueprints/component-test: Use fixture files | node-tests/fixtures/component-test/default.js | @@ -0,0 +1,24 @@
+import { moduleForComponent, test } from 'ember-qunit';
+import hbs from 'htmlbars-inline-precompile';
+
+moduleForComponent('x-foo', 'Integration | Component | x foo', {
+ integration: true
+});
+
+test('it renders', function(assert) {
+ // Set any properties with this.set('myProperty', 'value');
+... | true |
Other | emberjs | ember.js | 32482baeaa617ff7feb90aec5147782bbff15bb3.json | tests/blueprints/component-test: Use fixture files | node-tests/fixtures/component-test/mocha-0.12-unit.js | @@ -0,0 +1,20 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { setupComponentTest } from 'ember-mocha';
+
+describe('Unit | Component | x foo', function() {
+ setupComponentTest('x-foo', {
+ // Specify the other units that are required for this test
+ // needs: ['component:foo'... | true |
Other | emberjs | ember.js | 32482baeaa617ff7feb90aec5147782bbff15bb3.json | tests/blueprints/component-test: Use fixture files | node-tests/fixtures/component-test/mocha-0.12.js | @@ -0,0 +1,24 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { setupComponentTest } from 'ember-mocha';
+import hbs from 'htmlbars-inline-precompile';
+
+describe('Integration | Component | x foo', function() {
+ setupComponentTest('x-foo', {
+ integration: true
+ });
+
+ it('re... | true |
Other | emberjs | ember.js | 32482baeaa617ff7feb90aec5147782bbff15bb3.json | tests/blueprints/component-test: Use fixture files | node-tests/fixtures/component-test/mocha-unit.js | @@ -0,0 +1,20 @@
+import { expect } from 'chai';
+import { describeComponent, it } from 'ember-mocha';
+
+describeComponent('x-foo', 'Unit | Component | x foo',
+ {
+ // Specify the other units that are required for this test
+ // needs: ['component:foo', 'helper:bar'],
+ unit: true
+ },
+ function() {
+ ... | true |
Other | emberjs | ember.js | 32482baeaa617ff7feb90aec5147782bbff15bb3.json | tests/blueprints/component-test: Use fixture files | node-tests/fixtures/component-test/mocha.js | @@ -0,0 +1,24 @@
+import { expect } from 'chai';
+import { describeComponent, it } from 'ember-mocha';
+import hbs from 'htmlbars-inline-precompile';
+
+describeComponent('x-foo', 'Integration | Component | x foo',
+ {
+ integration: true
+ },
+ function() {
+ it('renders', function() {
+ // Set any prope... | true |
Other | emberjs | ember.js | 32482baeaa617ff7feb90aec5147782bbff15bb3.json | tests/blueprints/component-test: Use fixture files | node-tests/fixtures/component-test/unit.js | @@ -0,0 +1,16 @@
+import { moduleForComponent, test } from 'ember-qunit';
+
+moduleForComponent('x-foo', 'Unit | Component | x foo', {
+ // Specify the other units that are required for this test
+ // needs: ['component:foo', 'helper:bar'],
+ unit: true
+});
+
+test('it renders', function(assert) {
+
+ // Creates... | true |
Other | emberjs | ember.js | 71f453292eb7d6bb253c0c7222ab8cfc9f2a739f.json | Remove empty willMergeMixin function | packages/ember-metal/lib/mixin.js | @@ -237,6 +237,7 @@ function mergeMixins(mixins, meta, descs, values, base, keys) {
if (props === CONTINUE) { continue; }
if (props) {
+ // remove willMergeMixin after 3.4 as it was used for _actions
if (base.willMergeMixin) { base.willMergeMixin(props); }
concats = concatenatedMixinPrope... | true |
Other | emberjs | ember.js | 71f453292eb7d6bb253c0c7222ab8cfc9f2a739f.json | Remove empty willMergeMixin function | packages/ember-runtime/lib/mixins/action_handler.js | @@ -210,9 +210,7 @@ const ActionHandler = Mixin.create({
);
target.send(...arguments);
}
- },
-
- willMergeMixin() {}
+ }
});
export default ActionHandler; | true |
Other | emberjs | ember.js | 774608b3dfddc07f1070a8b0ab7c74c9e6ecde6e.json | Update Backburner.js to 2.0.0.
Updates to require native Map (aka drops IE < 10 and phantomjs support). | package.json | @@ -78,7 +78,7 @@
"babel-plugin-transform-es2015-template-literals": "^6.22.0",
"babel-plugin-transform-proto-to-assign": "^6.23.0",
"babel-template": "^6.24.1",
- "backburner.js": "^1.3.1",
+ "backburner.js": "^2.0.0",
"broccoli-babel-transpiler": "^6.1.1",
"broccoli-concat": "^3.2.2",
... | true |
Other | emberjs | ember.js | 774608b3dfddc07f1070a8b0ab7c74c9e6ecde6e.json | Update Backburner.js to 2.0.0.
Updates to require native Map (aka drops IE < 10 and phantomjs support). | yarn.lock | @@ -908,9 +908,9 @@ backbone@^1.1.2:
dependencies:
underscore ">=1.8.3"
-backburner.js@^1.3.1:
- version "1.3.1"
- resolved "https://registry.yarnpkg.com/backburner.js/-/backburner.js-1.3.1.tgz#f89ebd433063693f2ab13b6f8a3427fefc31cdcf"
+backburner.js@^2.0.0:
+ version "2.0.0"
+ resolved "https://registry.... | true |
Other | emberjs | ember.js | 37c0e0c5e7291800cddf57ff2c6b782661016b8d.json | Remove unused import | packages/ember-runtime/lib/mixins/registry_proxy.js | @@ -5,7 +5,6 @@
import {
Mixin
} from 'ember-metal';
-import { deprecate } from 'ember-debug';
/**
RegistryProxyMixin is used to provide public access to specific | false |
Other | emberjs | ember.js | 32b6244772dc68f9b92fcaee008accb2ed36678e.json | Remove unused legacy shims. | vendor/ember/shims.js | @@ -1,253 +0,0 @@
-(function() {
-/* globals define, Ember, jQuery */
-
- function processEmberShims() {
- var shims = {
- 'ember': {
- 'default': Ember
- },
- 'ember-application': {
- 'default': Ember.Application
- },
- 'ember-array': {
- 'default': Ember.Array
- ... | false |
Other | emberjs | ember.js | d354a728c4dde56c7d91d74b41cd8e5b6eb72571.json | Improve error message when calling `inject()`.
Fixes #15904 | packages/ember-runtime/lib/inject.js | @@ -10,7 +10,10 @@ import { assert } from 'ember-debug';
@public
*/
export default function inject() {
- assert(`Injected properties must be created through helpers, see '${Object.keys(inject).join('"', '"')}'`);
+ const helpers = Object.keys(inject)
+ .map(k => `'inject.${k}'`)
+ .join(' or ');
+ assert(... | false |
Other | emberjs | ember.js | f156c0d2c1f7273c31ad30b35e1ea7814732577d.json | Remove currentWhen property from link-to component | packages/ember-glimmer/lib/components/link-to.ts | @@ -350,13 +350,6 @@ const LinkComponent = EmberComponent.extend({
tagName: 'a',
- /**
- @deprecated Use current-when instead.
- @property currentWhen
- @private
- */
- currentWhen: deprecatingAlias('current-when', { id: 'ember-routing-view.deprecated-current-when', until: '3.0.0' }),
-
/**
U... | true |
Other | emberjs | ember.js | f156c0d2c1f7273c31ad30b35e1ea7814732577d.json | Remove currentWhen property from link-to component | packages/ember-glimmer/tests/integration/components/link-to-test.js | @@ -15,26 +15,6 @@ moduleFor('Link-to component', class extends ApplicationTest {
return p;
}
- ['@test accessing `currentWhen` triggers a deprecation'](assert) {
- let component;
- this.addComponent('link-to', {
- ComponentClass: LinkComponent.extend({
- init() {
- this._super(...... | true |
Other | emberjs | ember.js | f156c0d2c1f7273c31ad30b35e1ea7814732577d.json | Remove currentWhen property from link-to component | packages/ember/tests/helpers/link_to_test.js | @@ -417,26 +417,6 @@ moduleFor('The {{link-to}} helper - nested routes and link-to arguments', class
assert.equal(normalizeUrl(this.$('#item a').attr('href')), '/about');
}
- ['@test The {{link-to}} helper supports currentWhen (DEPRECATED)'](assert) {
- expectDeprecation('Usage of `currentWhen` is depreca... | true |
Other | emberjs | ember.js | a0245da171c19ee7987ae0be2cf0369f79241da1.json | Emit valid test counts after each test run.
Both in browser and in CI runs. | bin/run-tests.js | @@ -59,6 +59,9 @@ function runInBrowser(url, retries, resolve, reject) {
var addLogging = function() {
window.document.addEventListener('DOMContentLoaded', function() {
+ var testsTotal = 0;
+ var testsPassed = 0;
+ var testsFailed = 0;
var currentTestAssertions =... | true |
Other | emberjs | ember.js | a0245da171c19ee7987ae0be2cf0369f79241da1.json | Emit valid test counts after each test run.
Both in browser and in CI runs. | tests/index.html | @@ -172,11 +172,29 @@
QUnit.config.reorder = false;
}
+ var testsTotal, testsPassed, testsFailed;
+
QUnit.begin(function() {
+ testsTotal = testsPassed = testsFailed = 0;
+
if (QUnit.urlParams.hideskipped) {
$('#qunit-tests').addClass('hideskipped')... | true |
Other | emberjs | ember.js | a92a7cd003f7202a397aef2bbe95397ffe483034.json | Simplify `console` event handler.
Prior to this change, the only content emitted was `[Object object]`
(this is due to how puppeteer provides the argument to
`page.on('console', ...)`). | bin/run-tests.js | @@ -40,20 +40,10 @@ function runInBrowser(url, retries, resolve, reject) {
puppeteer.launch().then(function(browser) {
browser.newPage().then(function(page) {
- page.on('console', function() {
+ page.on('console', function(msg) {
+ console.log(msg.text);
- var string = Array.prototyp... | false |
Other | emberjs | ember.js | 92b459ca954fe395247a029375b4bd31572a4b83.json | Remove `chrome` from `testem.travis-browsers.json`
Chrome is now the default browser used, no need to test it _again_... | bin/run-travis-browser-tests.js | @@ -35,23 +35,7 @@ function run(command, _args) {
}
-function setupChrome() {
- return RSVP.resolve()
- .then(function() {
- return run('sudo', ['apt-get', 'install', '-y', 'google-chrome-stable']);
- })
- .then(function() {
- return run('/usr/bin/google-chrome', ['--version']);
- });
-}
-
... | true |
Other | emberjs | ember.js | 92b459ca954fe395247a029375b4bd31572a4b83.json | Remove `chrome` from `testem.travis-browsers.json`
Chrome is now the default browser used, no need to test it _again_... | testem.travis-browsers.js | @@ -29,11 +29,9 @@ module.exports = {
disable_watching: true,
launch_in_dev: [
'Firefox',
- 'Chrome'
],
launch_in_ci: [
'Firefox',
- 'Chrome'
],
reporter: new FailureOnlyReporter()
}; | true |
Other | emberjs | ember.js | 0a5388b28ba81139fec663c792dd062451c08776.json | Remove phantomjs infrastructure. | .travis.yml | @@ -14,7 +14,6 @@ cache:
before_install:
- |
- phantomjs --version
export DISPLAY=:99.0
sh -e /etc/init.d/xvfb start
| true |
Other | emberjs | ember.js | 0a5388b28ba81139fec663c792dd062451c08776.json | Remove phantomjs infrastructure. | bin/run-tests.js | @@ -28,7 +28,6 @@ function run(queryString) {
return new RSVP.Promise(function(resolve, reject) {
var url = 'http://localhost:' + PORT + '/tests/?' + queryString;
runInBrowser(url, 3, resolve, reject);
- //runInPhantom(url, 3, resolve, reject);
});
}
@@ -171,62 +170,6 @@ function runInBrowser(url,... | true |
Other | emberjs | ember.js | 0a5388b28ba81139fec663c792dd062451c08776.json | Remove phantomjs infrastructure. | package.json | @@ -112,7 +112,6 @@
"mocha": "^2.4.5",
"puppeteer": "^0.13.0",
"qunit-extras": "^1.5.0",
- "qunit-phantomjs-runner": "^2.2.0",
"qunitjs": "^1.22.0",
"route-recognizer": "^0.3.3",
"router_js": "^2.0.0-beta.1", | true |
Other | emberjs | ember.js | 0a5388b28ba81139fec663c792dd062451c08776.json | Remove phantomjs infrastructure. | testem.dist.json | @@ -38,7 +38,7 @@
"protocol": "tap"
}
},
- "launch_in_dev": ["PhantomJS"],
+ "launch_in_dev": [],
"launch_in_ci": [
"SL_Safari_Current",
"SL_MS_Edge", | true |
Other | emberjs | ember.js | 0a5388b28ba81139fec663c792dd062451c08776.json | Remove phantomjs infrastructure. | testem.json | @@ -4,5 +4,5 @@
"timeout": 540,
"parallel": 4,
"disable_watching": true,
- "launch_in_dev": ["PhantomJS"]
+ "launch_in_dev": []
} | true |
Other | emberjs | ember.js | 0a5388b28ba81139fec663c792dd062451c08776.json | Remove phantomjs infrastructure. | yarn.lock | @@ -5046,16 +5046,6 @@ qunit-extras@^1.5.0:
version "1.5.0"
resolved "https://registry.yarnpkg.com/qunit-extras/-/qunit-extras-1.5.0.tgz#a64d1c5088ab20c01c0e1b04c72132c397b3964c"
-qunit-phantomjs-runner@^2.2.0:
- version "2.3.0"
- resolved "https://registry.yarnpkg.com/qunit-phantomjs-runner/-/qunit-phantomjs... | true |
Other | emberjs | ember.js | 66e14cf65a909dfb415495006a25e3e4f5a761d8.json | Run tests with Chrome headless
TL;DR: Drop-in code replacement for Phantom with Chrome headless.
The Google Chrome team came out with a slick JavaScript client library
called [puppeteer](https://github.com/googlechrome/puppeteer) to control
Chrome headless. This is a fairly (IMHO) straightforward port from
running QU... | bin/run-tests.js | @@ -27,10 +27,150 @@ server.listen(PORT);
function run(queryString) {
return new RSVP.Promise(function(resolve, reject) {
var url = 'http://localhost:' + PORT + '/tests/?' + queryString;
- runInPhantom(url, 3, resolve, reject);
+ runInBrowser(url, 3, resolve, reject);
+ //runInPhantom(url, 3, resolve,... | true |
Other | emberjs | ember.js | 66e14cf65a909dfb415495006a25e3e4f5a761d8.json | Run tests with Chrome headless
TL;DR: Drop-in code replacement for Phantom with Chrome headless.
The Google Chrome team came out with a slick JavaScript client library
called [puppeteer](https://github.com/googlechrome/puppeteer) to control
Chrome headless. This is a fairly (IMHO) straightforward port from
running QU... | package.json | @@ -110,6 +110,7 @@
"html-differ": "^1.3.4",
"lodash.uniq": "^4.5.0",
"mocha": "^2.4.5",
+ "puppeteer": "^0.9.0",
"qunit-extras": "^1.5.0",
"qunit-phantomjs-runner": "^2.2.0",
"qunitjs": "^1.22.0", | true |
Other | emberjs | ember.js | 66e14cf65a909dfb415495006a25e3e4f5a761d8.json | Run tests with Chrome headless
TL;DR: Drop-in code replacement for Phantom with Chrome headless.
The Google Chrome team came out with a slick JavaScript client library
called [puppeteer](https://github.com/googlechrome/puppeteer) to control
Chrome headless. This is a fairly (IMHO) straightforward port from
running QU... | yarn.lock | @@ -1775,7 +1775,7 @@ concat-map@0.0.1:
version "0.0.1"
resolved "https://registry.yarnpkg.com/concat-map/-/concat-map-0.0.1.tgz#d8a96bd77fd68df7793a73036a3ba0d5405d477b"
-concat-stream@^1.4.7, concat-stream@^1.5.2:
+concat-stream@1.6.0, concat-stream@^1.4.7, concat-stream@^1.5.2:
version "1.6.0"
resolved... | true |
Other | emberjs | ember.js | 39b18554c7cd59853cfb1f14e1e0c21113881310.json | Add v2.18.0-beta.1 to CHANGELOG.
[ci skip] | CHANGELOG.md | @@ -1,5 +1,10 @@
# Ember Changelog
+### 2.18.0-beta.1 (November 29, 2017)
+
+- [#14590](https://github.com/emberjs/ember.js/pull/14590) [DEPRECATION] Deprecate using `targetObject`.
+- [#15754](https://github.com/emberjs/ember.js/pull/15754) [CLEANUP] Remove `router.router` deprecation.
+
### 2.17.0 (November 29, 2... | false |
Other | emberjs | ember.js | 1d554114a323064be740a27a28a598bbac6f4a9b.json | fix AST plugins | packages/ember-template-compiler/lib/plugins/assert-input-helper-without-block.js | @@ -7,7 +7,7 @@ export default function errorOnInputWithContent(env) {
return {
name: 'assert-input-helper-without-block',
- visitors: {
+ visitor: {
BlockStatement(node) {
if (node.path.original !== 'input') { return; }
| true |
Other | emberjs | ember.js | 1d554114a323064be740a27a28a598bbac6f4a9b.json | fix AST plugins | packages/ember-template-compiler/lib/plugins/assert-reserved-named-arguments.js | @@ -7,7 +7,7 @@ export default function assertReservedNamedArguments(env) {
return {
name: 'assert-reserved-named-arguments',
- visitors: {
+ visitor: {
PathExpression(node) {
if (node.original[0] === '@') {
assert(assertMessage(moduleName, node)); | true |
Other | emberjs | ember.js | 1d554114a323064be740a27a28a598bbac6f4a9b.json | fix AST plugins | packages/ember-template-compiler/lib/plugins/deprecate-render-model.js | @@ -8,7 +8,7 @@ export default function deprecateRenderModel(env) {
return {
name: 'deprecate-render-model',
- visitors: {
+ visitor: {
MustacheStatement(node) {
if (node.path.original === 'render' && node.params.length > 1) {
node.params.forEach(param => { | true |
Other | emberjs | ember.js | 1d554114a323064be740a27a28a598bbac6f4a9b.json | fix AST plugins | packages/ember-template-compiler/lib/plugins/deprecate-render.js | @@ -7,7 +7,7 @@ export default function deprecateRender(env) {
return {
name: 'deprecate-render',
- visitors: {
+ visitor: {
MustacheStatement(node) {
if (node.path.original !== 'render') { return; }
if (node.params.length !== 1) { return; } | true |
Other | emberjs | ember.js | 1d554114a323064be740a27a28a598bbac6f4a9b.json | fix AST plugins | packages/ember-template-compiler/lib/plugins/extract-pragma-tag.js | @@ -6,7 +6,7 @@ export default function extractPragmaTag(env) {
return {
name: 'exract-pragma-tag',
- visitors: {
+ visitor: {
MustacheStatement: {
enter(node) {
if (node.path.type === 'PathExpression' && node.path.original === PRAGMA_TAG) { | true |
Other | emberjs | ember.js | 1d554114a323064be740a27a28a598bbac6f4a9b.json | fix AST plugins | packages/ember-template-compiler/lib/plugins/transform-action-syntax.js | @@ -29,7 +29,7 @@ export default function transformActionSyntax({ syntax }) {
return {
name: 'transform-action-syntax',
- visitors: {
+ visitor: {
ElementModifierStatement(node) {
if (isAction(node)) {
insertThisAsFirstParam(node, b); | true |
Other | emberjs | ember.js | 1d554114a323064be740a27a28a598bbac6f4a9b.json | fix AST plugins | packages/ember-template-compiler/lib/plugins/transform-angle-bracket-components.js | @@ -2,7 +2,7 @@ export default function transformAngleBracketComponents(env) {
return {
name: 'transform-angle-bracket-components',
- visitors: {
+ visitor: {
ComponentNode(node) {
node.tag = `<${node.tag}>`;
} | true |
Other | emberjs | ember.js | 1d554114a323064be740a27a28a598bbac6f4a9b.json | fix AST plugins | packages/ember-template-compiler/lib/plugins/transform-attrs-into-args.js | @@ -30,7 +30,7 @@ export default function transformAttrsIntoArgs(env) {
return {
name: 'transform-attrs-into-args',
- visitors: {
+ visitor: {
Program: {
enter(node) {
let parent = stack[stack.length - 1]; | true |
Other | emberjs | ember.js | 1d554114a323064be740a27a28a598bbac6f4a9b.json | fix AST plugins | packages/ember-template-compiler/lib/plugins/transform-dot-component-invocation.js | @@ -58,7 +58,7 @@ export default function transformDotComponentInvocation(env) {
return {
name: 'transform-dot-component-invocation',
- visitors: {
+ visitor: {
MustacheStatement: (node) => {
if (isInlineInvocation(node.path, node.params, node.hash)) {
wrapInComponent(node, b)... | true |
Other | emberjs | ember.js | 1d554114a323064be740a27a28a598bbac6f4a9b.json | fix AST plugins | packages/ember-template-compiler/lib/plugins/transform-each-in-into-each.js | @@ -24,7 +24,7 @@ export default function transformEachInIntoEach(env) {
return {
name: 'transform-each-in-into-each',
- visitors: {
+ visitor: {
BlockStatement(node) {
if (node.path.original === 'each-in') {
node.params[0] = b.sexpr(b.path('-each-in'), [node.params[0]]); | true |
Other | emberjs | ember.js | 1d554114a323064be740a27a28a598bbac6f4a9b.json | fix AST plugins | packages/ember-template-compiler/lib/plugins/transform-has-block-syntax.js | @@ -30,7 +30,7 @@ export default function transformHasBlockSyntax(env) {
return {
name: 'transform-has-block-syntax',
- visitors: {
+ visitor: {
PathExpression(node) {
if (TRANSFORMATIONS[node.original]) {
return b.sexpr(b.path(TRANSFORMATIONS[node.original])); | true |
Other | emberjs | ember.js | 1d554114a323064be740a27a28a598bbac6f4a9b.json | fix AST plugins | packages/ember-template-compiler/lib/plugins/transform-inline-link-to.js | @@ -26,7 +26,7 @@ export default function transformInlineLinkTo(env) {
return {
name: 'transform-inline-link-to',
- visitors: {
+ visitor: {
MustacheStatement(node) {
if (node.path.original === 'link-to') {
let content = node.escaped ? node.params[0] : unsafeHtml(b, node.param... | true |
Other | emberjs | ember.js | 1d554114a323064be740a27a28a598bbac6f4a9b.json | fix AST plugins | packages/ember-template-compiler/lib/plugins/transform-input-on-to-onEvent.js | @@ -30,7 +30,7 @@ export default function transformInputOnToOnEvent(env) {
return {
name: 'transform-input-on-to-onEvent',
- visitors: {
+ visitor: {
MustacheStatement(node) {
if (node.path.original !== 'input') {
return; | true |
Other | emberjs | ember.js | 1d554114a323064be740a27a28a598bbac6f4a9b.json | fix AST plugins | packages/ember-template-compiler/lib/plugins/transform-input-type-syntax.js | @@ -29,7 +29,7 @@ export default function transformInputTypeSyntax(env) {
return {
name: 'transform-input-type-syntax',
- visitors: {
+ visitor: {
MustacheStatement(node) {
if (isInput(node)) {
insertTypeHelperParameter(node, b); | true |
Other | emberjs | ember.js | 1d554114a323064be740a27a28a598bbac6f4a9b.json | fix AST plugins | packages/ember-template-compiler/lib/plugins/transform-old-binding-syntax.js | @@ -8,7 +8,7 @@ export default function transformOldBindingSyntax(env) {
return {
name: 'transform-old-binding-syntax',
- visitors: {
+ visitor: {
BlockStatement(node) {
processHash(b, node, moduleName);
}, | true |
Other | emberjs | ember.js | 1d554114a323064be740a27a28a598bbac6f4a9b.json | fix AST plugins | packages/ember-template-compiler/lib/plugins/transform-old-class-binding-syntax.js | @@ -4,7 +4,7 @@ export default function transformOldClassBindingSyntax(env) {
return {
name: 'transform-old-class-binding-syntax',
- visitors: {
+ visitor: {
MustacheStatement(node) {
process(b, node);
}, | true |
Other | emberjs | ember.js | 1d554114a323064be740a27a28a598bbac6f4a9b.json | fix AST plugins | packages/ember-template-compiler/lib/plugins/transform-quoted-bindings-into-just-bindings.js | @@ -3,7 +3,7 @@ export default function transformQuotedBindingsIntoJustBindings(env) {
return {
name: 'transform-quoted-bindings-into-just-bindings',
- visitors: {
+ visitor: {
ElementNode(node) {
let styleAttr = getStyleAttr(node);
| true |
Other | emberjs | ember.js | 1d554114a323064be740a27a28a598bbac6f4a9b.json | fix AST plugins | packages/ember-template-compiler/lib/plugins/transform-top-level-components.js | @@ -2,7 +2,7 @@ export default function transformTopLevelComponent(env) {
return {
name: 'transform-top-level-component',
- visitors: {
+ visitor: {
Program(node) {
hasSingleComponentNode(node, component => {
component.tag = `@${component.tag}`; | true |
Other | emberjs | ember.js | aaada07db8c4f2d6242c4954c732da59ceadf80e.json | WIP: Start getDynamicLayout and compileTemplate | packages/ember-glimmer/lib/component-managers/curly.ts | @@ -4,6 +4,7 @@ import {
Simple,
VMHandle
} from '@glimmer/interfaces';
+import { WrappedBuilder } from '@glimmer/opcode-compiler';
import {
combineTagged,
Tag,
@@ -150,8 +151,23 @@ export default class CurlyComponentManager extends AbstractManager<ComponentStat
implements WithDynamicTagName<Opaque>,
... | true |
Other | emberjs | ember.js | aaada07db8c4f2d6242c4954c732da59ceadf80e.json | WIP: Start getDynamicLayout and compileTemplate | packages/ember-glimmer/lib/component-managers/root.ts | @@ -10,12 +10,13 @@ import {
} from 'ember-metal';
import Environment from '../environment';
import { DynamicScope } from '../renderer';
+import RuntimeResolver from '../resolver';
import ComponentStateBucket, { Component } from '../utils/curly-component-state-bucket';
import CurlyComponentManager, {
initialRen... | true |
Other | emberjs | ember.js | aaada07db8c4f2d6242c4954c732da59ceadf80e.json | WIP: Start getDynamicLayout and compileTemplate | packages/ember-glimmer/lib/resolver.ts | @@ -133,19 +133,16 @@ export default class RuntimeResolver implements IRuntimeResolver<TemplateMeta> {
return (vm, args) => componentHelper(vm, args, meta);
}
- let helper = this.builtInHelpers[name];
+ const helper = this.builtInHelpers[name];
if (helper !== undefined) {
return helper;
... | true |
Other | emberjs | ember.js | aaada07db8c4f2d6242c4954c732da59ceadf80e.json | WIP: Start getDynamicLayout and compileTemplate | packages/internal-test-helpers/lib/test-cases/abstract-rendering.js | @@ -72,7 +72,7 @@ export default class AbstractRenderingTestCase extends AbstractTestCase {
layoutName: '-top-level'
});
- owner.register('component:-top-level', Component.extend(attrs));
+ owner.register('-top-level', Component.extend(attrs));
this.component = owner.lookup('component:-top-le... | true |
Other | emberjs | ember.js | b7271b65e2fc0ca628ac90f5fa63a5ba5d2586ad.json | Add 2.17.0-beta.6 to CHANGELOG
[ci skip]
(cherry picked from commit d6dea181a9b3c5ce2f2f5f19dbb316a02dc19e44) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### 2.17.0-beta.6 (November 13, 2017)
+- [#15848](https://github.com/emberjs/ember.js/pull/15848) [BUGFIX] Ensure helpers have a consistent API.
+- [#15849](https://github.com/emberjs/ember.js/pull/15849) [BUGFIX] Fix issue when observing a computed property that is clobbered durin... | false |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | .eslintrc.js | @@ -35,6 +35,8 @@ module.exports = {
'ember-internal/require-yuidoc-access': 'error',
'ember-internal/no-const-outside-module-scope': 'error',
+ 'semi': 'error',
+
// temporarily disabled
'no-unused-vars': 'off',
'comma-dangle': 'off', | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | node-tests/.eslintrc.js | @@ -4,6 +4,5 @@ module.exports = {
node: true,
},
rules: {
- 'semi': 'error',
},
}; | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/container/lib/registry.js | @@ -627,7 +627,7 @@ if (DEBUG) {
}
return injections;
- }
+ };
Registry.prototype.validateInjections = function(injections) {
if (!injections) { return; }
@@ -639,7 +639,7 @@ if (DEBUG) {
assert(`Attempting to inject an unknown injection: '${fullName}'`, this.has(fullName));
}
- }... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-application/tests/system/application_instance_test.js | @@ -126,15 +126,15 @@ QUnit.test('unregistering a factory clears all cached instances of that factory'
let postController1 = appInstance.lookup('controller:post');
let postController1Factory = appInstance.factoryFor('controller:post');
assert.ok(postController1 instanceof PostController1, 'precond - lookup cre... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-application/tests/system/application_test.js | @@ -218,7 +218,7 @@ moduleFor('Ember.Application, default resolver with autoboot', class extends Def
[`@test can specify custom router`](assert) {
let MyRouter = Router.extend();
this.runTask(() => {
- this.createApplication()
+ this.createApplication();
this.application.Router = MyRouter;... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-application/tests/system/dependency_injection/default_resolver_test.js | @@ -183,7 +183,7 @@ moduleFor('Ember.Application Dependency Injection - Integration - default resolv
this.application.FooRoute = Component.extend();
expectAssertion(() => {
- this.privateRegistry.resolve(`route:foo`)
+ this.privateRegistry.resolve(`route:foo`);
}, /to resolve to an Ember.Rout... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-application/tests/system/visit_test.js | @@ -128,7 +128,7 @@ moduleFor('Ember.Application - visit()', class extends ApplicationTestCase {
* Destroy the instance.
*/
return this.runTask(() => {
- this.applicationInstance.destroy()
+ this.applicationInstance.destroy();
this.applicationInstance = null;
});
... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-debug/lib/deprecate.js | @@ -53,7 +53,7 @@ let missingOptionsDeprecation, missingOptionsIdDeprecation, missingOptionsUntilD
if (DEBUG) {
registerHandler = function registerHandler(handler) {
genericRegisterHandler('deprecate', handler);
- }
+ };
let formatMessage = function formatMessage(_message, options) {
let message = ... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-debug/lib/handlers.js | @@ -12,7 +12,7 @@ if (DEBUG) {
HANDLERS[type] = (message, options) => {
callback(message, options, nextHandler);
};
- }
+ };
invoke = function invoke(type, message, test, options) {
if (test) { return; }
@@ -22,10 +22,10 @@ if (DEBUG) {
if (handlerForType) {
handlerForType(messa... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-debug/lib/index.js | @@ -1,4 +1,4 @@
-import { DEBUG } from 'ember-env-flags'
+import { DEBUG } from 'ember-env-flags';
import { ENV, environment } from 'ember-environment';
import Logger from 'ember-console';
import { isTesting } from './testing';
@@ -297,4 +297,4 @@ export {
setDebugFunction,
getDebugFunction,
_warnIfUsingStr... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-debug/lib/warn.js | @@ -46,7 +46,7 @@ if (DEBUG) {
*/
registerHandler = function registerHandler(handler) {
genericRegisterHandler('warn', handler);
- }
+ };
registerHandler(function logWarning(message, options) {
Logger.warn(`WARNING: ${message}`);
@@ -109,12 +109,12 @@ if (DEBUG) {
}
invoke('warn', mes... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-extension-support/tests/container_debug_adapter_test.js | @@ -38,7 +38,7 @@ moduleFor('Container Debug Adapter', class extends ApplicationTestCase {
}
['@test default ContainerDebugAdapter catalogs controller entries'](assert) {
- this.application.PostController = EmberController.extend()
+ this.application.PostController = EmberController.extend();
let con... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-glimmer/tests/integration/application/engine-test.js | @@ -596,12 +596,12 @@ moduleFor('Application test: engine rendering', class extends ApplicationTest {
resolveLoading.resolve();
this.runTaskNext(() => {
- this.assertText('ApplicationEnginePost')
+ this.assertText('ApplicationEnginePost');
done();
});
});... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-glimmer/tests/integration/components/curly-components-test.js | @@ -2916,7 +2916,7 @@ moduleFor('Components test: curly components', class extends RenderingTest {
this.registerComponent('foo-bar', {
ComponentClass: Component.extend({
didReceiveAttrs() {
- assert.equal(1, this.get('foo'), 'expected attrs to have correct value')
+ assert.equal(1... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-metal/lib/map.js | @@ -158,7 +158,7 @@ class OrderedSet {
@private
*/
forEach(fn /*, ...thisArg*/) {
- assert(`${Object.prototype.toString.call(fn)} is not a function`, typeof fn === 'function')
+ assert(`${Object.prototype.toString.call(fn)} is not a function`, typeof fn === 'function');
if (this.size === 0) { re... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-metal/lib/property_set.js | @@ -98,7 +98,7 @@ function setPath(root, path, value, tolerant) {
let parts = path.split('.');
let keyName = parts.pop();
- assert('Property set failed: You passed an empty path', keyName.trim().length > 0)
+ assert('Property set failed: You passed an empty path', keyName.trim().length > 0);
let newPath ... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-metal/tests/alias_test.js | @@ -8,7 +8,7 @@ import {
addObserver,
removeObserver,
tagFor
-} from '..'
+} from '..';
let obj, count;
| true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-metal/tests/mixin/reopen_test.js | @@ -3,7 +3,7 @@ import {
run,
get,
Mixin
-} from '../..'
+} from '../..';
QUnit.module('Ember.Mixin#reopen');
| true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-metal/tests/observer_test.js | @@ -33,15 +33,15 @@ QUnit.module('addObserver');
testBoth('observer should assert to invalid input', function(get, set) {
expectAssertion(()=> {
- observer(()=>{})
+ observer(()=>{});
}, 'observer called without valid path');
- expectDeprecation('Passing the dependentKeys after the callback function i... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-routing/lib/system/router.js | @@ -145,7 +145,7 @@ const EmberRouter = EmberObject.extend(Evented, {
this._resetQueuedQueryParameterChanges();
this._handledErrors = dictionary(null);
this._engineInstances = Object.create(null);
- this._engineInfoByRoute = Object.create(null)
+ this._engineInfoByRoute = Object.create(null);
},... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-routing/lib/utils.js | @@ -5,7 +5,7 @@ import { Error as EmberError } from 'ember-debug';
const ALL_PERIODS_REGEX = /\./g;
export function extractRouteArgs(args) {
- args = args.slice()
+ args = args.slice();
let possibleQueryParams = args[args.length - 1];
let queryParams; | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-runtime/lib/computed/reduce_computed_macros.js | @@ -23,7 +23,7 @@ function reduceMacro(dependentKey, callback, initialValue) {
let arr = get(this, dependentKey);
if (arr === null || typeof arr !== 'object') { return initialValue; }
return arr.reduce(callback, initialValue, this);
- }, { dependentKeys: [`${dependentKey}.[]`], readOnly: true })
+ }, {... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-runtime/lib/system/native_array.js | @@ -54,7 +54,7 @@ let NativeArray = Mixin.create(MutableArray, Observable, Copyable, {
// primitive for array support.
replace(idx, amt, objects) {
assert(FROZEN_ERROR, !this.isFrozen);
- assert('The third argument to replace needs to be an array.', objects === null || objects === undefined || Array.isArr... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-runtime/tests/suites/mutable_array/insertAt.js | @@ -141,7 +141,7 @@ suite.test('[A,B,C].insertAt(1,X) => [A,X,B,C] + notify', function() {
obj.objectAt = (ix) => {
objectAtCalls.push(ix);
return objectAt.call(obj, ix);
- }
+ };
obj.getProperties('firstObject', 'lastObject'); /* Prime the cache */
| true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-runtime/tests/system/string/camelize_test.js | @@ -15,7 +15,7 @@ function test(given, expected, description) {
if (ENV.EXTEND_PROTOTYPES.String) {
deepEqual(given.camelize(), expected);
}
- })
+ });
}
test('my favorite items', 'myFavoriteItems', 'camelize normal string'); | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-template-compiler/lib/plugins/assert-reserved-named-arguments.js | @@ -14,7 +14,7 @@ export default function assertReservedNamedArguments(env) {
}
}
}
- }
+ };
}
function assertMessage(moduleName, node) { | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-template-compiler/lib/plugins/deprecate-render-model.js | @@ -23,7 +23,7 @@ export default function deprecateRenderModel(env) {
}
}
}
- }
+ };
}
function deprecationMessage(moduleName, node, param) { | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-template-compiler/lib/plugins/transform-dot-component-invocation.js | @@ -66,11 +66,11 @@ export default function transformDotComponentInvocation(env) {
},
BlockStatement: (node) => {
if (isMultipartPath(node.path)) {
- wrapInComponent(node, b)
+ wrapInComponent(node, b);
}
}
}
- }
+ };
}
function isMultipartPath(path) ... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-template-compiler/lib/plugins/transform-has-block-syntax.js | @@ -47,5 +47,5 @@ export default function transformHasBlockSyntax(env) {
}
}
}
- }
+ };
} | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-template-compiler/lib/plugins/transform-quoted-bindings-into-just-bindings.js | @@ -12,7 +12,7 @@ export default function transformQuotedBindingsIntoJustBindings(env) {
styleAttr.value = styleAttr.value.parts[0];
}
}
- }
+ };
}
function validStyleAttr(attr) { | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-template-compiler/lib/plugins/transform-top-level-components.js | @@ -10,7 +10,7 @@ export default function transformTopLevelComponent(env) {
});
}
}
- }
+ };
}
function hasSingleComponentNode(program, componentCallback) { | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember-testing/tests/ext/rsvp_test.js | @@ -92,7 +92,7 @@ QUnit.module('TestPromise');
QUnit.test('does not throw error when falsy value passed to then', function() {
expect(1);
return new TestPromise(function(resolve) {
- resolve()
+ resolve();
})
.then(null)
.then(function() {
@@ -104,14 +104,14 @@ QUnit.test('able to get last Promise... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember/lib/index.js | @@ -11,7 +11,7 @@ import { Registry, Container } from 'container';
// ****ember-metal****
import Ember, * as metal from 'ember-metal';
import { EMBER_METAL_WEAKMAP } from 'ember/features';
-import * as FLAGS from 'ember/features'
+import * as FLAGS from 'ember/features';
// ember-utils exports
Ember.getOwner = u... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember/tests/component_context_test.js | @@ -43,7 +43,7 @@ moduleFor('Application Lifecycle - Component Context', class extends Application
});
this.visit('/').then(() => {
- let text = this.$('#wrapper').text().trim()
+ let text = this.$('#wrapper').text().trim();
assert.equal(text, 'outer', 'The component is composed correctly')... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember/tests/helpers/link_to_test.js | @@ -219,7 +219,7 @@ moduleFor('The {{link-to}} helper - basic tests', class extends ApplicationTestC
assert.equal(this.$('#about-link.foo-is-true').length, 1, 'The about-link was rendered with the truthy class after toggling the property');
}
-})
+});
moduleFor('The {{link-to}} helper - location hooks', cl... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember/tests/helpers/link_to_test/link_to_with_query_params_test.js | @@ -8,7 +8,7 @@ moduleFor('The {{link-to}} helper: invoking with query params', class extends Ap
let indexProperties = {
foo: '123',
bar: 'abc'
- }
+ };
this.add('controller:index', Controller.extend({
queryParams: ['foo', 'bar', 'abool'],
foo: indexProperties.foo,
@@ -158,7 ... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember/tests/production_build_test.js | @@ -1,4 +1,4 @@
-import { DEBUG } from 'ember-env-flags'
+import { DEBUG } from 'ember-env-flags';
import {
assert as emberAssert,
runInDebug | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember/tests/reexports_test.js | @@ -240,11 +240,11 @@ if (DEBUG) {
assert.equal(descriptor.enumerable, false, 'descriptor is not enumerable');
assert.equal(descriptor.configurable, false, 'descriptor is not configurable');
- assert.equal(Ember.MODEL_FACTORY_INJECTIONS, false)
+ assert.equal(Ember.MODEL_FACTORY_INJECTIONS, false);
... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember/tests/routing/basic_test.js | @@ -2510,7 +2510,7 @@ QUnit.test('Specifying non-existent controller name in route#render throws', fun
renderTemplate() {
expectAssertion(() => {
this.render('homepage', { controller: 'stefanpenneristhemanforme' });
- }, 'You passed `controller: \'stefanpenneristhemanforme\'` into the `render`... | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember/tests/routing/decoupled_basic_test.js | @@ -272,7 +272,7 @@ class extends ApplicationTestCase {
'Monday through Friday: 9am to 5pm',
'Saturday: Noon to Midnight',
'Sunday: Noon to 6pm'
- ]))
+ ]));
}
}));
return this.visit('/').then(() => { | true |
Other | emberjs | ember.js | cd364f5c15081c9e20ccb475f9216cf8be779c9f.json | promote eslint rule "semi" to entire project | packages/ember/tests/routing/substates_test.js | @@ -104,7 +104,7 @@ moduleFor('Loading/Error Substates', class extends ApplicationTestCase {
this.router.map(function() {
this.route('dummy');
- })
+ });
this.add('route:dummy', Route.extend({
model() {
return deferred.promise;
@@ -204,7 +204,7 @@ moduleFor('Loading/Error Substa... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.