language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | f48d1e1abbbd27c5dd0cf964d663f1fbd48d1f6c.json | Update yarn.lock to latest allowed deps. | yarn.lock | @@ -86,35 +86,38 @@
resolved "https://registry.yarnpkg.com/@types/estree/-/estree-0.0.38.tgz#c1be40aa933723c608820a99a373a16d215a1ca2"
"@types/node@^8.0.53":
- version "8.0.53"
- resolved "https://registry.yarnpkg.com/@types/node/-/node-8.0.53.tgz#396b35af826fa66aad472c8cb7b8d5e277f4e6d8"
+ version "8.5.8"
+ ... | false |
Other | emberjs | ember.js | bffc7e74e6461c2486df68d94724b0a5389205fc.json | Fix bad merge | packages/ember-glimmer/lib/syntax.ts | @@ -3,15 +3,15 @@ import { Option } from '@glimmer/util';
import { Core } from '@glimmer/wire-format';
import { ENV } from 'ember-environment';
import { OwnedTemplateMeta } from 'ember-views';
+import { EMBER_TEMPLATE_BLOCK_LET_HELPER } from 'ember/features';
import { textAreaMacro } from './syntax/-text-area';
im... | false |
Other | emberjs | ember.js | a8bb87b4a1606c83cf0b30783d2addcdf6f24955.json | Fix template injection tests. | packages/ember-application/tests/system/application_test.js | @@ -164,7 +164,7 @@ moduleFor('Ember.Application', class extends ApplicationTestCase {
verifyRegistration(assert, application, P`template:components/-default`);
verifyRegistration(assert, application, 'template:-outlet');
verifyInjection(assert, application, 'view:-outlet', 'template', 'template:-outlet'... | true |
Other | emberjs | ember.js | a8bb87b4a1606c83cf0b30783d2addcdf6f24955.json | Fix template injection tests. | packages/ember-application/tests/system/engine_test.js | @@ -77,7 +77,7 @@ moduleFor('Ember.Engine', class extends TestCase {
verifyRegistration(assert, engine, P`template:components/-default`);
verifyRegistration(assert, engine, 'template:-outlet');
verifyInjection(assert, engine, 'view:-outlet', 'template', 'template:-outlet');
- verifyInjection(assert, e... | true |
Other | emberjs | ember.js | f7f92863501625fc4677a5f787c8be24286ce92e.json | Add v3.0.0-beta.1 to CHANGELOG.md.
(cherry picked from commit ac88593e040b16e4f7d306c9620040d76e80b433) | CHANGELOG.md | @@ -1,5 +1,40 @@
# Ember Changelog
+### 3.0.0-beta.1 (January 1, 2018)
+
+- [#15901](https://github.com/emberjs/ember.js/pull/15901) [CLEANUP] Remove Ember.Handlebars.SafeString
+- [#15894](https://github.com/emberjs/ember.js/pull/15894) [CLEANUP] removed `immediateObserver`
+- [#15897](https://github.com/emberjs/em... | false |
Other | emberjs | ember.js | 44f52006414f11a49ff5efcc5f6088093f4e3ab0.json | Fix textarea helper tests | packages/ember-glimmer/lib/syntax/-text-area.ts | @@ -1,8 +1,12 @@
+import {
+ LazyOpcodeBuilder,
+ TemplateMeta
+} from '@glimmer/opcode-compiler';
import { wrapComponentClassAttribute } from '../utils/bindings';
import { hashToArgs } from './utils';
-export function textAreaMacro(_name: string, params: any[], hash: any, builder: any) {
- let definition = buil... | false |
Other | emberjs | ember.js | 21c4c133daca61ebf8b5b42433e50b189d2d4ece.json | fix some more tests | packages/ember-metal/lib/tags.js | @@ -40,7 +40,7 @@ export function markObjectAsDirty(meta, propertyKey) {
let objectTag = meta.readableTag();
if (objectTag !== undefined) {
- objectTag.dirty();
+ objectTag.inner.dirty();
}
let tags = meta.readableTags();
@@ -51,7 +51,7 @@ export function markObjectAsDirty(meta, propertyKey) {
... | false |
Other | emberjs | ember.js | ce3ab8f23c5be2dac4bdc944c911b92342aa04f9.json | Remove API no longer present in QUnit 2.0 | packages/ember/tests/helpers/link_to_test.js | @@ -1508,7 +1508,7 @@ function assertNav(options, callback) {
let nav = false;
function check(event) {
- QUnit.equal(event.defaultPrevented, options.prevented, `expected defaultPrevented=${options.prevented}`);
+ QUnit.assert.equal(event.defaultPrevented, options.prevented, `expected defaultPrevented=${op... | false |
Other | emberjs | ember.js | 2b80a62e2893c2c937213f8fce419d647baff7c4.json | Fix stragglers that were not QUnit 2 compatible. | packages/ember-debug/tests/main_test.js | @@ -27,6 +27,7 @@ import {
let originalEnvValue;
let originalDeprecateHandler;
+let originalWarnHandler;
let originalWarnOptions;
let originalDeprecationOptions;
@@ -37,6 +38,7 @@ moduleFor('ember-debug', class extends TestCase {
originalEnvValue = ENV.RAISE_ON_DEPRECATION;
originalDeprecateHandler ... | true |
Other | emberjs | ember.js | 2b80a62e2893c2c937213f8fce419d647baff7c4.json | Fix stragglers that were not QUnit 2 compatible. | packages/ember-runtime/tests/mixins/promise_proxy_test.js | @@ -263,14 +263,14 @@ QUnit.test('should reset isFulfilled and isRejected when promise is reset', func
assert.equal(get(proxy, 'isFulfilled'), false, 'expects the proxy to indicate that it is not fulfilled');
});
-QUnit.test('should have content when isFulfilled is set', function() {
+QUnit.test('should have cont... | true |
Other | emberjs | ember.js | 2b80a62e2893c2c937213f8fce419d647baff7c4.json | Fix stragglers that were not QUnit 2 compatible. | packages/ember/tests/routing/basic_test.js | @@ -2612,7 +2612,7 @@ QUnit.test('rejecting the model hooks promise with a string shows a good error',
}
});
- assert.throws(() => bootApplication(), rejectedMessage, 'expected an exception');
+ assert.throws(() => bootApplication(), new RegExp(rejectedMessage), 'expected an exception');
Logger.error =... | true |
Other | emberjs | ember.js | 2b80a62e2893c2c937213f8fce419d647baff7c4.json | Fix stragglers that were not QUnit 2 compatible. | packages/internal-test-helpers/lib/ember-dev/assertion.js | @@ -32,7 +32,7 @@ AssertionAssert.prototype = {
let { assert } = QUnit.config.current;
if (this.env.runningProdBuild) {
- QUnit.ok(true, 'Assertions disabled in production builds.');
+ assert.ok(true, 'Assertions disabled in production builds.');
return;
}
| true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/array.js | @@ -23,12 +23,12 @@ const ObserverClass = EnumerableTestsObserverClass.extend({
},
arrayWillChange() {
- equal(this._before, null, 'should only call once');
+ QUnit.config.current.assert.equal(this._before, null, 'should only call once');
this._before = Array.prototype.slice.call(arguments);
},
... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/array/includes.js | @@ -4,36 +4,36 @@ const suite = SuiteModuleBuilder.create();
suite.module('includes');
-suite.test('includes returns correct value if startAt is positive', function() {
+suite.test('includes returns correct value if startAt is positive', function(assert) {
let data = this.newFixture(3);
let obj = this.newOb... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/array/indexOf.js | @@ -4,21 +4,21 @@ const suite = SuiteModuleBuilder.create();
suite.module('indexOf');
-suite.test('should return index of object', function() {
+suite.test('should return index of object', function(assert) {
let expected = this.newFixture(3);
let obj = this.newObject(expected);
let len = 3;
... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/array/lastIndexOf.js | @@ -5,55 +5,55 @@ const suite = SuiteModuleBuilder.create();
suite.module('lastIndexOf');
-suite.test('should return index of object\'s last occurrence', function() {
+suite.test('should return index of object\'s last occurrence', function(assert) {
let expected = this.newFixture(3);
let obj = this.newO... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/array/objectAt.js | @@ -5,24 +5,24 @@ const suite = SuiteModuleBuilder.create();
suite.module('objectAt');
-suite.test('should return object at specified index', function() {
+suite.test('should return object at specified index', function(assert) {
let expected = this.newFixture(3);
let obj = this.newObject(expected);
l... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/copyable/copy.js | @@ -4,10 +4,10 @@ const suite = SuiteModuleBuilder.create();
suite.module('copy');
-suite.test('should return an equivalent copy', function() {
+suite.test('should return an equivalent copy', function(assert) {
let obj = this.newObject();
let copy = obj.copy();
- ok(this.isEqual(obj, copy), 'old object and ... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/enumerable.js | @@ -146,12 +146,12 @@ const ObserverClass = EmberObject.extend({
},
enumerableWillChange() {
- equal(this._before, null, 'should only call once');
+ QUnit.config.current.assert.equal(this._before, null, 'should only call once');
this._before = Array.prototype.slice.call(arguments);
},
enumera... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/enumerable/any.js | @@ -9,7 +9,7 @@ const suite = SuiteModuleBuilder.create();
suite.module('any');
-suite.test('any should should invoke callback on each item as long as you return false', function() {
+suite.test('any should should invoke callback on each item as long as you return false', function(assert) {
let obj = this.newOb... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/enumerable/compact.js | @@ -4,10 +4,10 @@ const suite = SuiteModuleBuilder.create();
suite.module('compact');
-suite.test('removes null and undefined values from enumerable', function() {
+suite.test('removes null and undefined values from enumerable', function(assert) {
let obj = this.newObject([null, 1, false, '', undefined, 0, null... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/enumerable/every.js | @@ -9,7 +9,7 @@ const suite = SuiteModuleBuilder.create();
suite.module('every');
-suite.test('every should should invoke callback on each item as long as you return true', function() {
+suite.test('every should should invoke callback on each item as long as you return true', function(assert) {
let obj = this.n... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/enumerable/filter.js | @@ -9,7 +9,7 @@ const suite = SuiteModuleBuilder.create();
suite.module('filter');
-suite.test('filter should invoke on each item', function() {
+suite.test('filter should invoke on each item', function(assert) {
let obj = this.newObject();
let ary = this.toArray(obj);
let cnt = ary.length - 2;
@@ -21,8 +... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/enumerable/find.js | @@ -8,7 +8,7 @@ const suite = SuiteModuleBuilder.create();
suite.module('find');
-suite.test('find should invoke callback on each item as long as you return false', function() {
+suite.test('find should invoke callback on each item as long as you return false', function(assert) {
let obj = this.newObject();
... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/enumerable/firstObject.js | @@ -5,22 +5,22 @@ const suite = SuiteModuleBuilder.create();
suite.module('firstObject');
-suite.test('returns first item in enumerable', function() {
+suite.test('returns first item in enumerable', function(assert) {
let obj = this.newObject();
- equal(get(obj, 'firstObject'), this.toArray(obj)[0]);
+ assert... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/enumerable/forEach.js | @@ -6,19 +6,19 @@ const suite = SuiteModuleBuilder.create();
suite.module('forEach');
-suite.test('forEach should iterate over list', function() {
+suite.test('forEach should iterate over list', function(assert) {
let obj = this.newObject();
let ary = this.toArray(obj);
let found = [];
obj.forEach(i ... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/enumerable/includes.js | @@ -4,22 +4,22 @@ const suite = SuiteModuleBuilder.create();
suite.module('includes');
-suite.test('includes returns true if item is in enumerable', function() {
+suite.test('includes returns true if item is in enumerable', function(assert) {
let data = this.newFixture(1);
let obj = this.newObject([...data,... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/enumerable/invoke.js | @@ -5,7 +5,7 @@ const suite = SuiteModuleBuilder.create();
suite.module('invoke');
-suite.test('invoke should call on each object that implements', function() {
+suite.test('invoke should call on each object that implements', function(assert) {
let cnt, ary, obj;
function F(amt) {
@@ -24,11 +24,11 @@ suite... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/enumerable/is_any.js | @@ -9,56 +9,56 @@ const suite = SuiteModuleBuilder.create();
suite.module('isAny');
-suite.test('should return true of any property matches', function() {
+suite.test('should return true of any property matches', function(assert) {
let obj = this.newObject([
{ foo: 'foo', bar: 'BAZ' },
EmberObject.cre... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/enumerable/lastObject.js | @@ -5,26 +5,26 @@ const suite = SuiteModuleBuilder.create();
suite.module('lastObject');
-suite.test('returns last item in enumerable', function() {
+suite.test('returns last item in enumerable', function(assert) {
let obj = this.newObject();
let ary = this.toArray(obj);
- equal(get(obj, 'lastObject'), ar... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/enumerable/map.js | @@ -8,19 +8,19 @@ suite.module('map');
const mapFunc = item => item ? item.toString() : null;
-suite.test('map should iterate over list', function() {
+suite.test('map should iterate over list', function(assert) {
let obj = this.newObject();
let ary = this.toArray(obj).map(mapFunc);
let found = [];
f... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/enumerable/mapBy.js | @@ -4,14 +4,14 @@ const suite = SuiteModuleBuilder.create();
suite.module('mapBy');
-suite.test('get value of each property', function() {
+suite.test('get value of each property', function(assert) {
let obj = this.newObject([{ a: 1 }, { a: 2 }]);
- equal(obj.mapBy('a').join(''), '12');
+ assert.equal(obj.map... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/enumerable/reduce.js | @@ -4,22 +4,22 @@ const suite = SuiteModuleBuilder.create();
suite.module('reduce');
-suite.test('collects a summary value from an enumeration', function() {
+suite.test('collects a summary value from an enumeration', function(assert) {
let obj = this.newObject([1, 2, 3]);
let res = obj.reduce((previousValue... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/enumerable/reject.js | @@ -9,24 +9,24 @@ const suite = SuiteModuleBuilder.create();
suite.module('reject');
-suite.test('should reject any item that does not meet the condition', function() {
+suite.test('should reject any item that does not meet the condition', function(assert) {
let obj = this.newObject([1, 2, 3, 4]);
let result... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/enumerable/sortBy.js | @@ -5,20 +5,20 @@ const suite = SuiteModuleBuilder.create();
suite.module('sortBy');
-suite.test('sort by value of property', function() {
+suite.test('sort by value of property', function(assert) {
let obj = this.newObject([{ a: 2 }, { a: 1 }]);
let sorted = obj.sortBy('a');
- equal(get(sorted[0], 'a'), ... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/enumerable/toArray.js | @@ -4,9 +4,9 @@ const suite = SuiteModuleBuilder.create();
suite.module('toArray');
-suite.test('toArray should convert to an array', function() {
+suite.test('toArray should convert to an array', function(assert) {
let obj = this.newObject();
- deepEqual(obj.toArray(), this.toArray(obj));
+ assert.deepEqual(... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/enumerable/uniq.js | @@ -4,7 +4,7 @@ const suite = SuiteModuleBuilder.create();
suite.module('uniq');
-suite.test('should return new instance with duplicates removed', function() {
+suite.test('should return new instance with duplicates removed', function(assert) {
let before, after, obj, ret;
after = this.newFixture(3);
@@ -... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/enumerable/uniqBy.js | @@ -4,13 +4,13 @@ const suite = SuiteModuleBuilder.create();
suite.module('uniqBy');
-suite.test('should return new instance with duplicates removed', function() {
+suite.test('should return new instance with duplicates removed', function(assert) {
let numbers = this.newObject([
{ id: 1, value: 'one' },
... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/enumerable/without.js | @@ -4,37 +4,37 @@ const suite = SuiteModuleBuilder.create();
suite.module('without');
-suite.test('should return new instance with item removed', function() {
+suite.test('should return new instance with item removed', function(assert) {
let before, after, obj, ret;
before = this.newFixture(3);
after =... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/mutable_array/addObject.js | @@ -5,13 +5,13 @@ const suite = SuiteModuleBuilder.create();
suite.module('addObject');
-suite.test('should return receiver', function() {
+suite.test('should return receiver', function(assert) {
let before = this.newFixture(3);
let obj = this.newObject(before);
- equal(obj.addObject(before[1]), obj, 'sh... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/mutable_array/clear.js | @@ -5,27 +5,27 @@ const suite = SuiteModuleBuilder.create();
suite.module('clear');
-suite.test('[].clear() => [] + notify', function () {
+suite.test('[].clear() => [] + notify', function (assert) {
let before = [];
let after = [];
let obj = this.newObject(before);
let observer = this.newObserver(obj... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/mutable_array/insertAt.js | @@ -5,7 +5,7 @@ const suite = SuiteModuleBuilder.create();
suite.module('insertAt');
-suite.test('[].insertAt(0, X) => [X] + notify', function() {
+suite.test('[].insertAt(0, X) => [X] + notify', function(assert) {
let after = this.newFixture(1);
let obj = this.newObject([]);
let observer = this.newObserv... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/mutable_array/popObject.js | @@ -5,24 +5,24 @@ const suite = SuiteModuleBuilder.create();
suite.module('popObject');
-suite.test('[].popObject() => [] + returns undefined + NO notify', function() {
+suite.test('[].popObject() => [] + returns undefined + NO notify', function(assert) {
let obj = this.newObject([]);
let observer = this.new... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/mutable_array/pushObject.js | @@ -5,14 +5,14 @@ const suite = SuiteModuleBuilder.create();
suite.module('pushObject');
-suite.test('returns pushed object', function() {
+suite.test('returns pushed object', function(assert) {
let exp = this.newFixture(1)[0];
let obj = this.newObject([]);
- equal(obj.pushObject(exp), exp, 'should return... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/mutable_array/pushObjects.js | @@ -4,10 +4,10 @@ const suite = SuiteModuleBuilder.create();
suite.module('pushObjects');
-suite.test('should raise exception if not Ember.Enumerable is passed to pushObjects', function() {
+suite.test('should raise exception if not Ember.Enumerable is passed to pushObjects', function(assert) {
let obj = this.n... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/mutable_array/removeAt.js | @@ -6,116 +6,116 @@ const suite = SuiteModuleBuilder.create();
suite.module('removeAt');
-suite.test('removeAt([X], 0) => [] + notify', function() {
+suite.test('removeAt([X], 0) => [] + notify', function(assert) {
let before = this.newFixture(1);
let after = [];
let obj = this.newObject(before);
let ... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/mutable_array/removeObject.js | @@ -5,14 +5,14 @@ const suite = SuiteModuleBuilder.create();
suite.module('removeObject');
-suite.test('should return receiver', function() {
+suite.test('should return receiver', function(assert) {
let before = this.newFixture(3);
let obj = this.newObject(before);
- equal(obj.removeObject(before[1]), ... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/mutable_array/replace.js | @@ -4,7 +4,7 @@ const suite = SuiteModuleBuilder.create();
suite.module('replace');
-suite.test('[].replace(0,0,\'X\') => [\'X\'] + notify', function() {
+suite.test('[].replace(0,0,\'X\') => [\'X\'] + notify', function(assert) {
let exp = this.newFixture(1);
let obj = this.newObject([]);
let observer = t... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/mutable_array/reverseObjects.js | @@ -5,24 +5,24 @@ const suite = SuiteModuleBuilder.create();
suite.module('reverseObjects');
-suite.test('[A,B,C].reverseObjects() => [] + notify', function () {
+suite.test('[A,B,C].reverseObjects() => [] + notify', function (assert) {
let before = this.newFixture(3);
let after = [before[2], before[1], bef... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/mutable_array/setObjects.js | @@ -5,44 +5,44 @@ const suite = SuiteModuleBuilder.create();
suite.module('setObjects');
-suite.test('[A,B,C].setObjects([]) = > [] + notify', function() {
+suite.test('[A,B,C].setObjects([]) = > [] + notify', function(assert) {
let before = this.newFixture(3);
let after = [];
let obj = this.newObject(be... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/mutable_array/shiftObject.js | @@ -5,66 +5,66 @@ const suite = SuiteModuleBuilder.create();
suite.module('shiftObject');
-suite.test('[].shiftObject() => [] + returns undefined + NO notify', function() {
+suite.test('[].shiftObject() => [] + returns undefined + NO notify', function(assert) {
let before = [];
let after = [];
let obj = ... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/mutable_array/unshiftObject.js | @@ -5,14 +5,14 @@ const suite = SuiteModuleBuilder.create();
suite.module('unshiftObject');
-suite.test('returns unshifted object', function() {
+suite.test('returns unshifted object', function(assert) {
let obj = this.newObject([]);
let item = this.newFixture(1)[0];
- equal(obj.unshiftObject(item), item,... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/mutable_array/unshiftObjects.js | @@ -5,14 +5,14 @@ const suite = SuiteModuleBuilder.create();
suite.module('unshiftObjects');
-suite.test('returns receiver', function() {
+suite.test('returns receiver', function(assert) {
let obj = this.newObject([]);
let items = this.newFixture(3);
- equal(obj.unshiftObjects(items), obj, 'should return ... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/mutable_enumerable/addObject.js | @@ -5,14 +5,14 @@ const suite = SuiteModuleBuilder.create();
suite.module('addObject');
-suite.test('should return receiver', function() {
+suite.test('should return receiver', function(assert) {
let before = this.newFixture(3);
let obj = this.newObject(before);
- equal(obj.addObject(before[1]), obj, 'sho... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/mutable_enumerable/removeObject.js | @@ -6,14 +6,14 @@ const suite = SuiteModuleBuilder.create();
suite.module('removeObject');
-suite.test('should return receiver', function() {
+suite.test('should return receiver', function(assert) {
let before = this.newFixture(3);
let obj = this.newObject(before);
- equal(obj.removeObject(before[1]), ... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/mutable_enumerable/removeObjects.js | @@ -6,14 +6,14 @@ const suite = SuiteModuleBuilder.create();
suite.module('removeObjects');
-suite.test('should return receiver', function() {
+suite.test('should return receiver', function(assert) {
let before = emberA(this.newFixture(3));
let obj = before;
- equal(obj.removeObjects(before[1]), obj, 'sho... | true |
Other | emberjs | ember.js | cceca7ee192c8f034f6ddb09dcd2c8faf9de68bd.json | Upgrade "suites" to be QUnit 2 compat. | packages/ember-runtime/tests/suites/suite.js | @@ -73,15 +73,15 @@ Suite.reopenClass({
let title = get(this, 'name') + ': ' + desc;
let ctx = this;
QUnit.module(title, {
- beforeEach() {
+ beforeEach(assert) {
if (setup) {
- setup.call(ctx);
+ setup.call(ctx, assert);
}... | true |
Other | emberjs | ember.js | e8a0dba69acd454e8e830616fef751126cdcbc22.json | Remove tests for QUnit 1.x adapter. | packages/ember-testing/tests/adapters/qunit_test.js | @@ -4,57 +4,6 @@ import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
var adapter;
-moduleFor('ember-testing QUnitAdapter: QUnit 1.x', class extends AbstractTestCase {
- constructor() {
- super();
- adapter = new QUnitAdapter();
- }
-
- teardown() {
- run(adapter, adapter.destroy);
- }... | false |
Other | emberjs | ember.js | b5cfcf55875770c4d917854459e753c134332e5f.json | Update node tests to be QUnit 2 compatible. | tests/node/app-boot-test.js | @@ -9,7 +9,7 @@ QUnit.test("App boots and routes to a URL", function(assert) {
assert.ok(this.app);
});
-QUnit.test("nested {{component}}", function() {
+QUnit.test("nested {{component}}", function(assert) {
this.template('index', "{{root-component}}");
this.template('components/root-component', "\
@@ -27... | true |
Other | emberjs | ember.js | b5cfcf55875770c4d917854459e753c134332e5f.json | Update node tests to be QUnit 2 compatible. | tests/node/helpers/assert-html-matches.js | @@ -11,10 +11,15 @@ var htmlDiffer = new HtmlDiffer(diffOptions);
* ignore whitespace and certain attributes values, such as IDs, which Ember
* auto-generates. Attribute ordering is also ignored.
*/
-function assertHTMLMatches(actual, expected, message) {
+function assertHTMLMatches(assert, actual, expected, mess... | true |
Other | emberjs | ember.js | b5cfcf55875770c4d917854459e753c134332e5f.json | Update node tests to be QUnit 2 compatible. | tests/node/template-compiler-test.js | @@ -9,11 +9,11 @@ var test = QUnit.test;
var templateCompiler;
module('ember-template-compiler.js', {
- setup: function() {
+ beforeEach: function() {
templateCompiler = require(templateCompilerPath);
},
- teardown: function() {
+ afterEach: function() {
// clear the previously cached version of ... | true |
Other | emberjs | ember.js | e071537003b2e12655cadd0765ea3616b0312304.json | Remove QUnit monkey patches. | tests/index.html | @@ -128,21 +128,6 @@
window.EmberDev = window.EmberDev || {};
EmberDev.runningProdBuild = !!QUnit.urlParams.prod;
- // hack qunit to not suck for Ember objects
- var originalTypeof = QUnit.jsDump.typeOf;
-
- QUnit.jsDump.typeOf = function(obj) {
- if (Ember && Ember.Obj... | false |
Other | emberjs | ember.js | e4f08b41f2b45f4970cbbe822d5a7079d7498bb8.json | Remove usages of asyncTest. | packages/ember/tests/routing/basic_test.js | @@ -405,42 +405,6 @@ QUnit.test('The loading state doesn\'t get entered for promises that resolve on
assert.equal(jQuery('p', '#qunit-fixture').text(), '1', 'The app is now in the specials state');
});
-/*
-asyncTest("The Special page returning an error fires the error hook on SpecialRoute", function(assert) {
- ... | false |
Other | emberjs | ember.js | 69b95f515642b10110076ebdd37ab6a04a69d32c.json | Use primitive reference for static class names
Using just a string is not enough because operations.setAttribute
expects a reference, not a primitive | packages/ember-glimmer/lib/utils/bindings.ts | @@ -173,8 +173,7 @@ export const ClassNameBinding = {
let isStatic = prop === '';
if (isStatic) {
- operations.setAttribute('class', truthy, true, null);
- // operations.addStaticAttribute(element, 'class', truthy);
+ operations.setAttribute('class', PrimitiveReference.create(truthy), true, n... | false |
Other | emberjs | ember.js | 1327a9661a1343c283f5e543e1f48e0afcc1ed76.json | Add codeclimate config | .codeclimate.yml | @@ -0,0 +1,33 @@
+version: "2"
+checks:
+ argument-count:
+ config:
+ threshold: 4
+ complex-logic:
+ config:
+ threshold: 4
+ file-lines:
+ enabled: false
+ method-complexity:
+ config:
+ threshold: 5
+ method-count:
+ enabled: false
+ method-lines:
+ config:
+ threshold: 25... | false |
Other | emberjs | ember.js | f5b1875ce909a6122f6cd3cb2b6abd9760e02372.json | Give credit to BrowserStack in Readme | README.md | @@ -23,3 +23,9 @@ Ember.js also provides access to the most advanced features of JavaScript, HTML
# Contribution
See [CONTRIBUTING.md](https://github.com/emberjs/ember.js/blob/master/CONTRIBUTING.md)
+
+---
+
+Cross-browser testing provided by:
+
+<a href="http://browserstack.com"><img height="70" src="https://p3.z... | false |
Other | emberjs | ember.js | e8d57fa726dc79cf1868e94a84808ee34db3716d.json | Add browserstack credentials | .travis.yml | @@ -44,6 +44,8 @@ branches:
env:
global:
+ - BROWSERSTACK_USERNAME=emberjscoreteam1
+ - BROWSERSTACK_ACCESS_KEY=YsPxXKcahx9XszyHS2Gr
- DISABLE_SOURCE_MAPS=true
- BROCCOLI_ENV=production
- S3_BUCKET_NAME=builds.emberjs.com | false |
Other | emberjs | ember.js | 63e19eb79ddb6c6fe9df9c1c7e43caf1629c32d8.json | Update getTag to actually get a useful tag | packages/ember-glimmer/lib/component-managers/curly.ts | @@ -8,6 +8,7 @@ import {
} from '@glimmer/interfaces';
import { ParsedLayout, TemplateOptions, WrappedBuilder } from '@glimmer/opcode-compiler';
import {
+ combine,
combineTagged,
Tag,
VersionedPathReference,
@@ -436,8 +437,9 @@ export default class CurlyComponentManager extends AbstractManager<ComponentSt... | false |
Other | emberjs | ember.js | 9c329597ab21f032b95c80e2a5033fe6cb4284fc.json | Use latest testem
- Update passing of custom reporter to testem to reflect changes in
https://github.com/testem/testem/pull/1148 | package.json | @@ -122,7 +122,7 @@
"serve-static": "^1.12.2",
"simple-dom": "^0.3.0",
"simple-html-tokenizer": "^0.4.1",
- "testem": "1.15.0",
+ "testem": "^1.18.4",
"tslint": "^5.8.0"
},
"ember-addon": { | true |
Other | emberjs | ember.js | 9c329597ab21f032b95c80e2a5033fe6cb4284fc.json | Use latest testem
- Update passing of custom reporter to testem to reflect changes in
https://github.com/testem/testem/pull/1148 | testem.travis-browsers.js | @@ -33,5 +33,5 @@ module.exports = {
launch_in_ci: [
'Firefox',
],
- reporter: new FailureOnlyReporter()
+ reporter: FailureOnlyReporter
}; | true |
Other | emberjs | ember.js | 9c329597ab21f032b95c80e2a5033fe6cb4284fc.json | Use latest testem
- Update passing of custom reporter to testem to reflect changes in
https://github.com/testem/testem/pull/1148 | yarn.lock | @@ -1902,7 +1902,7 @@ crc@^3.4.4:
version "3.4.4"
resolved "https://registry.yarnpkg.com/crc/-/crc-3.4.4.tgz#9da1e980e3bd44fc5c93bf5ab3da3378d85e466b"
-cross-spawn@^5.0.0:
+cross-spawn@^5.0.0, cross-spawn@^5.1.0:
version "5.1.0"
resolved "https://registry.yarnpkg.com/cross-spawn/-/cross-spawn-5.1.0.tgz#e8... | true |
Other | emberjs | ember.js | 2702d8156624ae7506cd5077ca26ad7222e46415.json | Allow prerelease tags to trigger CI builds.
[ci skip] | .travis.yml | @@ -36,7 +36,7 @@ branches:
- beta
- stable
# npm version tags
- - /^v\d+\.\d+\.\d+$/
+ - /^v\d+\.\d+\.\d+/
env:
global: | false |
Other | emberjs | ember.js | cf41205ad8c4820d6984ef45adac4f89b748467d.json | Prepare CHANGELOG for 2.18.0.
(cherry picked from commit e2ae732967fe841654f9ed43928efcfba6a9882b)
[ci skip] | CHANGELOG.md | @@ -1,25 +1,16 @@
# Ember Changelog
-### 2.18.0-beta.5 (December 27, 2017)
-- [#15952](https://github.com/emberjs/ember.js/pull/15952) [BUGFIX] fix regression of clicking link-to with disabled=true
+### 2.18.0 (January 1, 2018)
-### 2.18.0-beta.4 (December 19, 2017)
+- [95b449](https://github.com/emberjs/ember.js/... | false |
Other | emberjs | ember.js | eccb77d292980dd71ee02631d66b00a342c66588.json | Publish tarballs to S3 for channel builds.
For a single commit to master, would result in the following tarballs:
```
http://builds.emberjs.com/canary.tgz
http://builds.emberjs.com/canary/daily/20180101.tgz
http://builds.emberjs.com/canary/shas/SOMESHAHERE.tgz
``` | config/s3ProjectConfig.js | @@ -1,5 +1,9 @@
+'use strict';
+
+const semver = require('semver');
+
function fileMap(revision, tag, date) {
- return {
+ let filesToPublish = {
"ember.debug.js": fileObject("ember.debug", ".js", "text/javascript", revision, tag, date),
"ember-testing.js": fileObject("... | false |
Other | emberjs | ember.js | 7f97511a034dccf140a39127bd6a93bf8ceb0a7b.json | Remove this.resource from RouterDSL | packages/ember-routing/lib/index.d.ts | @@ -71,7 +71,6 @@ export class RouterDSL {
constructor(name: string, options: any);
route(name: string, options: any, callback: ()=>any): void;
push(url: string, name: string, callback: ()=>any, serialize: ()=>any): void;
- resource(name: string, options: any, callback: ()=>any): void;
genearte(): (match: ... | true |
Other | emberjs | ember.js | 7f97511a034dccf140a39127bd6a93bf8ceb0a7b.json | Remove this.resource from RouterDSL | packages/ember-routing/lib/system/dsl.js | @@ -1,5 +1,5 @@
import { assign } from 'ember-utils';
-import { assert, deprecate } from 'ember-debug';
+import { assert } from 'ember-debug';
let uuid = 0;
@@ -66,17 +66,6 @@ class DSL {
this.matches.push(url, name, callback);
}
- resource(name, options = {}, callback) {
- if (arguments.length === ... | true |
Other | emberjs | ember.js | 7f97511a034dccf140a39127bd6a93bf8ceb0a7b.json | Remove this.resource from RouterDSL | packages/ember-routing/tests/system/dsl_test.js | @@ -15,10 +15,9 @@ moduleFor('Ember Router DSL', class extends AbstractTestCase {
}
['@test should fail when using a reserved route name'](assert) {
- expectDeprecation('this.resource() is deprecated. Use this.route(\'name\', { resetNamespace: true }, function () {}) instead.');
let reservedNames = ['ar... | true |
Other | emberjs | ember.js | efb900ae302f9bdecb7ebdfbe13f84c3882cb704.json | Add *.tgz to .gitignore | .gitignore | @@ -40,3 +40,5 @@ bower_components/
npm-debug.log
.ember-cli
DEBUG/
+*.tgz
+*.tar.gz | false |
Other | emberjs | ember.js | b94109a244270d65bd865032117c421fc1e71227.json | Fix version number generation.
Will no longer include `-null`. | broccoli/version.js | @@ -11,7 +11,8 @@ module.exports.VERSION = (() => {
let packageVersion = require('../package.json').version;
let sha = info.sha || '';
- let prefix = `${packageVersion}-${(process.env.BUILD_TYPE || info.branch)}`;
+ let suffix = process.env.BUILD_TYPE || info.branch;
+ let metadata = sha.slice(0, 8);
- r... | false |
Other | emberjs | ember.js | b9a40bb59e0684134a7370ac0ec8455de3f6327e.json | Apply some feedback | packages/ember-testing/tests/ext/rsvp_test.js | @@ -18,11 +18,9 @@ moduleFor('ember-testing RSVP', class extends AbstractTestCase {
setAdapter({
asyncStart() {
asyncStarted++;
- QUnit.stop();
},
asyncEnd() {
asyncEnded++;
- QUnit.start();
}
});
}
@@ -35,6 +33,7 @@ moduleFor('ember-testing RSVP'... | false |
Other | emberjs | ember.js | a54a5e30c8b129ffa2fd0f094456d67a20ddf4c0.json | Add 2.18.0-beta.5 to CHANGELOG
[ci skip]
(cherry picked from commit ca040bdd5b420661b812fa9c36ded1229cf01b11) | CHANGELOG.md | @@ -1,5 +1,8 @@
# Ember Changelog
+### 2.18.0-beta.5 (December 27, 2017)
+- [#15952](https://github.com/emberjs/ember.js/pull/15952) [BUGFIX] fix regression of clicking link-to with disabled=true
+
### 2.18.0-beta.4 (December 19, 2017)
- [#15982](https://github.com/emberjs/ember.js/pull/15982) [BUGFIX] Fix issue w... | false |
Other | emberjs | ember.js | 49e672759bfcd89e92c98a6d61bb6a17dd593b82.json | Fix stray `#` in change to getElementById | packages/internal-test-helpers/lib/test-cases/abstract.js | @@ -49,7 +49,7 @@ export default class AbstractTestCase {
}
setupFixture(innerHTML) {
- let fixture = document.getElementById('#qunit-fixture');
+ let fixture = document.getElementById('qunit-fixture');
fixture.innerHTML = innerHTML;
}
| false |
Other | emberjs | ember.js | f71bbd07cacd406d3ac12db7d170be791b3a5c50.json | Run tests without jQuery (package by package).
Adds support for running tests per-package without jQuery so that jQuery
requirements do not creep into the rest of the framework. | bin/run-tests.js | @@ -184,9 +184,15 @@ function generateEachPackageTests() {
testFunctions.push(function() {
return run('package=' + packageName);
});
+ if (packages[packageName].requiresJQuery === false) {
+ testFunctions.push(function() {
+ return run('package=' + packageName + '&jquery=none');
+ }... | true |
Other | emberjs | ember.js | f71bbd07cacd406d3ac12db7d170be791b3a5c50.json | Run tests without jQuery (package by package).
Adds support for running tests per-package without jQuery so that jQuery
requirements do not creep into the rest of the framework. | lib/packages.js | @@ -1,14 +1,14 @@
module.exports = function() {
var packages = {
- 'container': { trees: null, requirements: ['ember-utils'], isTypeScript: true, vendorRequirements: ['@glimmer/di'] },
- 'ember-environment': { trees: null, requirements: [], skipTests: true },
- 'ember-utils': ... | true |
Other | emberjs | ember.js | ef04a33961d48de1065ee6a306d01917b44f9cd9.json | Remove jQuery usage in ember-application tests. | packages/ember-application/tests/system/application_test.js | @@ -35,14 +35,13 @@ import {
} from 'internal-test-helpers';
moduleFor('Ember.Application, autobooting multiple apps', class extends ApplicationTestCase {
- constructor() {
- jQuery('#qunit-fixture').html(`
+ get fixture() {
+ return `
<div id="one">
<div id="one-child">HI</div>
</div... | true |
Other | emberjs | ember.js | ef04a33961d48de1065ee6a306d01917b44f9cd9.json | Remove jQuery usage in ember-application tests. | packages/ember-application/tests/system/bootstrap-test.js | @@ -23,6 +23,6 @@ moduleFor('Ember.Application with default resolver and autoboot', class extends
['@test templates in script tags are extracted at application creation'](assert) {
this.runTask(() => this.createApplication());
- assert.equal(this.$('#app').text(), 'Hello World!');
+ assert.equal(documen... | true |
Other | emberjs | ember.js | ef04a33961d48de1065ee6a306d01917b44f9cd9.json | Remove jQuery usage in ember-application tests. | packages/ember-application/tests/system/dependency_injection/custom_resolver_test.js | @@ -26,9 +26,8 @@ moduleFor('Ember.Application with extended default resolver and autoboot', class
});
}
- [`@test a resolver can be supplied to application`](assert) {
+ [`@test a resolver can be supplied to application`]() {
this.runTask(() => this.createApplication());
- assert.equal(this.$('h1')... | true |
Other | emberjs | ember.js | ef04a33961d48de1065ee6a306d01917b44f9cd9.json | Remove jQuery usage in ember-application tests. | packages/ember-application/tests/system/initializers_test.js | @@ -1,15 +1,12 @@
import { assign } from 'ember-utils';
import { moduleFor, AutobootApplicationTestCase } from 'internal-test-helpers';
import { Application } from 'ember-application';
-import { jQuery } from 'ember-views';
moduleFor('Ember.Application initializers', class extends AutobootApplicationTestCase {
- ... | true |
Other | emberjs | ember.js | ef04a33961d48de1065ee6a306d01917b44f9cd9.json | Remove jQuery usage in ember-application tests. | packages/ember-application/tests/system/instance_initializers_test.js | @@ -1,15 +1,12 @@
import { assign } from 'ember-utils';
import { moduleFor, AutobootApplicationTestCase } from 'internal-test-helpers';
import { Application, ApplicationInstance } from 'ember-application';
-import { jQuery } from 'ember-views';
moduleFor('Ember.Application instance initializers', class extends Au... | true |
Other | emberjs | ember.js | ef04a33961d48de1065ee6a306d01917b44f9cd9.json | Remove jQuery usage in ember-application tests. | packages/ember-application/tests/system/visit_test.js | @@ -12,7 +12,6 @@ import Engine from '../../system/engine';
import { Route } from 'ember-routing';
import { Component, helper } from 'ember-glimmer';
import { compile } from 'ember-template-compiler';
-import { jQuery } from 'ember-views';
function expectAsyncError() {
RSVP.off('error');
@@ -29,6 +28,13 @@ mod... | true |
Other | emberjs | ember.js | ef04a33961d48de1065ee6a306d01917b44f9cd9.json | Remove jQuery usage in ember-application tests. | packages/ember-glimmer/tests/integration/application/engine-test.js | @@ -311,7 +311,10 @@ moduleFor('Application test: engine rendering', class extends ApplicationTest {
this.setupAppAndRoutableEngine(hooks);
return this.visit('/blog', { shouldRender: false }).then(() => {
- this.assertText('');
+ assert.strictEqual(
+ document.getElementById('qunit-fixture'... | true |
Other | emberjs | ember.js | b78514e8ad6aab85e6d1ed66bb7ce0d9c18cfb31.json | Remove jQuery usage in abstract test cases. | packages/ember/tests/helpers/link_to_test.js | @@ -654,7 +654,7 @@ moduleFor('The {{link-to}} helper - nested routes and link-to arguments', class
<ul>
{{#each model as |person|}}
<li>
- {{#link-to 'item' person}}
+ {{#link-to 'item' person id=person.id}}
{{person.name}}
{{/link-to}}
... | true |
Other | emberjs | ember.js | b78514e8ad6aab85e6d1ed66bb7ce0d9c18cfb31.json | Remove jQuery usage in abstract test cases. | packages/internal-test-helpers/lib/test-cases/abstract-application.js | @@ -1,5 +1,4 @@
import { compile } from 'ember-template-compiler';
-import { jQuery } from 'ember-views';
import { EMBER_GLIMMER_REMOVE_APPLICATION_TEMPLATE_WRAPPER } from 'ember/features';
import AbstractTestCase from './abstract';
import { runDestroy } from '../run';
@@ -10,9 +9,9 @@ export default class Abstract... | true |
Other | emberjs | ember.js | b78514e8ad6aab85e6d1ed66bb7ce0d9c18cfb31.json | Remove jQuery usage in abstract test cases. | packages/internal-test-helpers/lib/test-cases/abstract-rendering.js | @@ -1,6 +1,6 @@
import { assign } from 'ember-utils';
import { compile } from 'ember-template-compiler';
-import { jQuery, EventDispatcher } from 'ember-views';
+import { EventDispatcher } from 'ember-views';
import { helper, Helper, Component, _resetRenderers} from 'ember-glimmer';
import AbstractTestCase from '... | true |
Other | emberjs | ember.js | b78514e8ad6aab85e6d1ed66bb7ce0d9c18cfb31.json | Remove jQuery usage in abstract test cases. | packages/internal-test-helpers/lib/test-cases/abstract.js | @@ -88,11 +88,17 @@ export default class AbstractTestCase {
}
click(selector) {
- return this.$(selector).click();
+ let element;
+ if (typeof selector === 'string') {
+ element = this.element.querySelector(selector);
+ } else {
+ element = selector;
+ }
+ return element.click();
... | true |
Other | emberjs | ember.js | aaafab2bc9ee88ed2141b12b40c6930817f7d068.json | Remove eager jQuery destructuring. | packages/ember-template-compiler/tests/system/bootstrap-test.js | @@ -16,8 +16,6 @@ import {
AbstractTestCase
} from 'internal-test-helpers';
-const { trim } = jQuery;
-
let component, fixture;
function checkTemplate(templateName, assert) {
@@ -84,7 +82,7 @@ moduleFor('ember-templates: bootstrap', class extends AbstractTestCase {
assert.ok(template, 'template with name... | true |
Other | emberjs | ember.js | aaafab2bc9ee88ed2141b12b40c6930817f7d068.json | Remove eager jQuery destructuring. | packages/ember/tests/routing/basic_test.js | @@ -32,8 +32,6 @@ import { compile } from 'ember-template-compiler';
import { Application, Engine } from 'ember-application';
import { Transition } from 'router';
-let trim = jQuery.trim;
-
let Router, App, router, registry, container, originalLoggerError, originalRenderSupport;
function bootApplication() {
@@ ... | true |
Other | emberjs | ember.js | 4ac08b87abc67c8b2f9f8705e46a924b40f3c21b.json | Tell eslint to ignore Typescript files.
Prior to this in-editor `eslint`ing will trigger annoying
warnings/errors about "invalid eslint config" for typescript files.
Since we are using tslint for these files anyways, this just makes
eslint properly ignore them... | .eslintignore | @@ -1,3 +1,4 @@
blueprints/*/*files/**/*.js
dist/
tmp/
+**/*.ts | false |
Other | emberjs | ember.js | 621eecaec3ed7e3e6470ef9ed596cf801238e0db.json | Use resolver for input component lookup | packages/ember-glimmer/lib/syntax/input.ts | @@ -1,13 +1,17 @@
/**
@module ember
*/
+import {
+ LazyOpcodeBuilder,
+ TemplateMeta
+} from '@glimmer/opcode-compiler';
import { assert } from 'ember-debug';
import { wrapComponentClassAttribute } from '../utils/bindings';
import { dynamicComponentMacro } from './dynamic-component';
import { hashToArgs } from... | false |
Other | emberjs | ember.js | 3aace9b6fee8da49c1e7672647fd42ef0309c0e8.json | Use inner tag for dirtying | packages/ember-glimmer/lib/component.ts | @@ -594,7 +594,7 @@ const Component = CoreView.extend(
},
rerender() {
- this[DIRTY_TAG].dirty();
+ this[DIRTY_TAG].inner.dirty();
this._super();
},
| true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.