language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | daa39359c2b3811d7053e2162a5717dcf40b04a1.json | Move objectAt to ember-metal
... and fix some tests that should ahve been testing the
method version of objectAt. | packages/ember-runtime/tests/suites/array/objectAt.js | @@ -1,5 +1,4 @@
import { SuiteModuleBuilder } from '../suite';
-import { objectAt } from '../../../mixins/array';
const suite = SuiteModuleBuilder.create();
@@ -11,18 +10,18 @@ suite.test('should return object at specified index', function(assert) {
let len = expected.length;
for (let idx = 0; idx < ... | true |
Other | emberjs | ember.js | daa39359c2b3811d7053e2162a5717dcf40b04a1.json | Move objectAt to ember-metal
... and fix some tests that should ahve been testing the
method version of objectAt. | packages/ember-runtime/tests/system/array_proxy/arranged_content_test.js | @@ -1,7 +1,6 @@
-import { run, computed } from 'ember-metal';
+import { run, computed, objectAt } from 'ember-metal';
import ArrayProxy from '../../../system/array_proxy';
import { A as emberA } from '../../../mixins/array';
-import { objectAt } from '../../../mixins/array';
let array;
| true |
Other | emberjs | ember.js | 7f8f5944417516ffcfd3b6b30179f71d7cdf450b.json | Add 3.0.0-beta.6 to CHANGELOG
[ci skip]
(cherry picked from commit 558d800239529672b5dc86e905ba3d5b6d880545) | CHANGELOG.md | @@ -1,5 +1,10 @@
# Ember Changelog
+### 3.0.0-beta.6 (February 5, 2018)
+
+- [#16199](https://github.com/emberjs/ember.js/pull/16199) [BUGFIX] Mention "computed properties" in the assertion message
+- [#16200](https://github.com/emberjs/ember.js/pull/16200) [BUGFIX] Prevent test error by converting illegal character... | false |
Other | emberjs | ember.js | c345bfc40317d6d4e93c73ff34f42c431d379c5f.json | Make `rsvpAfter` a private randomized queue name.
This queue is _never_ intended to be scheduled into by anyone other than
Ember itself, this change makes that much more likely. | packages/ember-metal/lib/run_loop.js | @@ -1,3 +1,4 @@
+import { privatize as P } from 'container';
import { assert, deprecate, isTesting } from 'ember-debug';
import {
onErrorTarget
@@ -31,7 +32,7 @@ const backburner = new Backburner(
// used to re-throw unhandled RSVP rejection errors specifically in this
// position to avoid breaking any... | true |
Other | emberjs | ember.js | c345bfc40317d6d4e93c73ff34f42c431d379c5f.json | Make `rsvpAfter` a private randomized queue name.
This queue is _never_ intended to be scheduled into by anyone other than
Ember itself, this change makes that much more likely. | packages/ember-runtime/lib/ext/rsvp.js | @@ -4,6 +4,7 @@ import {
getDispatchOverride
} from 'ember-metal';
import { assert } from 'ember-debug';
+import { privatize as P } from 'container';
const backburner = run.backburner;
@@ -12,7 +13,7 @@ RSVP.configure('async', (callback, promise) => {
});
RSVP.configure('after', cb => {
- backburner.sche... | true |
Other | emberjs | ember.js | 0c81a324d99cefb525bf316c8708e5c1e7f435eb.json | remove unused `caches` export | packages/ember-metal/lib/path_cache.js | @@ -2,10 +2,6 @@ import Cache from './cache';
const firstDotIndexCache = new Cache(1000, key => key.indexOf('.'));
-export const caches = {
- firstDotIndexCache
-};
-
export function isPath(path) {
return firstDotIndexCache.get(path) !== -1;
} | false |
Other | emberjs | ember.js | ddda91699a68c4417c59465e07dd5071f555750c.json | remove jquery from component context tests | packages/ember/tests/component_context_test.js | @@ -79,14 +79,14 @@ moduleFor('Application Lifecycle - Component Context', class extends Application
this.addComponent('my-component', {
ComponentClass: Component.extend({
didInsertElement() {
- this.$().html('Some text inserted by jQuery');
+ this.element.innerHTML = 'Some text i... | false |
Other | emberjs | ember.js | 872eb97fad1bd7f8f34001182cc9b37d06f82858.json | Remove require() for backburner instance | packages/ember-metal/lib/tags.js | @@ -1,6 +1,6 @@
import { CONSTANT_TAG, DirtyableTag } from '@glimmer/reference';
import { meta as metaFor } from './meta';
-import require from 'require';
+import run from './run_loop';
let hasViews = () => false;
@@ -62,8 +62,7 @@ export function markObjectAsDirty(meta, propertyKey) {
let backburner;
function... | false |
Other | emberjs | ember.js | afedeaae2e7502c6b696d2e433979307c9f4542e.json | Add 3.0.0-beta.5 to CHANGELOG
[ci skip]
(cherry picked from commit 9a2a138479265a22bafcdbb8c60942ec080196c7) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### 3.0.0-beta.5 (January 29, 2018)
+
+- [#16179](https://github.com/emberjs/ember.js/pull/16179) [BUGFIX] Fix a few bugs in the caching ArrayProxy implementation
+
### 3.0.0-beta.4 (January 25, 2018)
- [#16160](https://github.com/emberjs/ember.js/pull/16160) [BUGFIX] Remove hu... | false |
Other | emberjs | ember.js | 28753cf193ed8fccacc535dc9af09a9d1cb91f09.json | Update CHANGELOG for 3.0.0-beta.4
[ci skip]
(cherry picked from commit 233a34e3aec8d77d85f562c7892d37f47105f8da) | CHANGELOG.md | @@ -1,5 +1,20 @@
# Ember Changelog
+### 3.0.0-beta.4 (January 25, 2018)
+
+- [#16160](https://github.com/emberjs/ember.js/pull/16160) [BUGFIX] Remove humanize() call from generated test descriptions
+- [#16101](https://github.com/emberjs/ember.js/pull/16101) [CLEANUP] Remove legacy ArrayProxy features
+- [#16116](ht... | false |
Other | emberjs | ember.js | b314d66a911819de88549d3f37866c3ebc191ea2.json | remove event flags | packages/ember-metal/lib/events.js | @@ -5,7 +5,6 @@ import { applyStr } from 'ember-utils';
import { ENV } from 'ember-environment';
import { deprecate, assert } from 'ember-debug';
import { meta as metaFor, peekMeta } from './meta';
-import { ONCE } from './meta_listeners';
/*
The event system uses a series of nested hashes to store listeners o... | true |
Other | emberjs | ember.js | b314d66a911819de88549d3f37866c3ebc191ea2.json | remove event flags | packages/ember-metal/lib/meta_listeners.js | @@ -10,14 +10,11 @@
save that for dispatch time, if an event actually happens.
*/
-/* listener flags */
-export const ONCE = 1;
-
export const protoMethods = {
- addToListeners(eventName, target, method, flags) {
+ addToListeners(eventName, target, method, once) {
if (this._listeners === undefined) { th... | true |
Other | emberjs | ember.js | 86e9790abd624631944d32b70a2d0aecdb356549.json | convert `BucketCache` to es6 class | packages/ember-application/lib/system/application.js | @@ -1069,7 +1069,7 @@ function commonSetupRegistry(registry) {
registry.register('location:history', HistoryLocation);
registry.register('location:none', NoneLocation);
- registry.register(P`-bucket-cache:main`, BucketCache);
+ registry.register(P`-bucket-cache:main`, { create() { return new BucketCache(); } ... | true |
Other | emberjs | ember.js | 86e9790abd624631944d32b70a2d0aecdb356549.json | convert `BucketCache` to es6 class | packages/ember-routing/lib/index.d.ts | @@ -221,9 +221,9 @@ export const RouterService: {
isActive(...args: any[]): boolean;
_extractArguments(routeName: string, ...models: any[]): {routeName: string, models: any[], queryParams: any};
};
-export const BucketCache: {
- init(): void;
+export class BucketCache {
+ constructor();
has(bucketKey: strin... | true |
Other | emberjs | ember.js | 86e9790abd624631944d32b70a2d0aecdb356549.json | convert `BucketCache` to es6 class | packages/ember-routing/lib/system/cache.js | @@ -1,42 +1,40 @@
-import { Object as EmberObject } from 'ember-runtime';
-
/**
A two-tiered cache with support for fallback values when doing lookups.
Uses "buckets" and then "keys" to cache values.
@private
@class BucketCache
*/
-export default EmberObject.extend({
- init() {
- this.cache = Object... | true |
Other | emberjs | ember.js | 86e9790abd624631944d32b70a2d0aecdb356549.json | convert `BucketCache` to es6 class | packages/ember-routing/tests/system/cache_test.js | @@ -5,7 +5,7 @@ moduleFor('BucketCache', class extends AbstractTestCase {
constructor() {
super();
- this.cache = BucketCache.create();
+ this.cache = new BucketCache();
}
['@test has - returns false when bucket is not in cache'](assert) { | true |
Other | emberjs | ember.js | 56183a1c248bd60a3ec3f92c8fefa0ddf4e423fe.json | utilize `Map` and `Set` in `property_events` | packages/ember-metal/lib/property_events.js | @@ -1,4 +1,4 @@
-import { guidFor, symbol } from 'ember-utils';
+import { symbol } from 'ember-utils';
import {
descriptorFor,
peekMeta
@@ -115,16 +115,16 @@ function notifyPropertyChange(obj, keyName, _meta) {
}
}
-let DID_SEEN;
+let DID_SEEN = null;
// called whenever a property has just changed to up... | false |
Other | emberjs | ember.js | b6068455ba1296bb50d1ba5631cb02f9ad84e617.json | Avoid extra var in CoreObject during prod builds. | packages/ember-runtime/lib/system/core_object.js | @@ -68,7 +68,12 @@ function makeCtor() {
initProperties = [arguments[0]];
}
- let beforeInitCalled = true;
+ let beforeInitCalled; // only used in debug builds to enable the proxy trap
+
+ // using DEBUG here to avoid the extraneous variable when not needed
+ if (DEBUG) {
+ ... | false |
Other | emberjs | ember.js | eeecb9b2c88fb5ec7943bae52950c1e2fa439b42.json | Fix backwards compat shim for custom AST plugins. | packages/ember-template-compiler/lib/index.js | @@ -14,7 +14,8 @@ export { default as precompile } from './system/precompile';
export { default as compile } from './system/compile';
export {
default as compileOptions,
- registerPlugin
+ registerPlugin,
+ unregisterPlugin
} from './system/compile-options';
export { default as defaultPlugins } from './plugin... | true |
Other | emberjs | ember.js | eeecb9b2c88fb5ec7943bae52950c1e2fa439b42.json | Fix backwards compat shim for custom AST plugins. | packages/ember-template-compiler/lib/system/compile-options.js | @@ -16,27 +16,24 @@ export default function compileOptions(_options) {
options.plugins = { ast: [...USER_PLUGINS, ...PLUGINS] };
} else {
let potententialPugins = [...USER_PLUGINS, ...PLUGINS];
+ let providedPlugins = options.plugins.ast.map(plugin => wrapLegacyPluginIfNeeded(plugin));
let pluginsT... | true |
Other | emberjs | ember.js | eeecb9b2c88fb5ec7943bae52950c1e2fa439b42.json | Fix backwards compat shim for custom AST plugins. | packages/ember-template-compiler/tests/system/compile_options_test.js | @@ -1,6 +1,5 @@
-import { compileOptions } from '../../index';
-import { defaultPlugins } from '../../index';
-import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
+import { compile, compileOptions, defaultPlugins, registerPlugin, unregisterPlugin } from '../../index';
+import { moduleFor, AbstractTestC... | true |
Other | emberjs | ember.js | 17ec6c465938d35ba5106e599067bbfe84766a94.json | fix proxy issue | packages/ember-glimmer/lib/component-managers/abstract.ts | @@ -4,14 +4,14 @@ import {
} from '@glimmer/interfaces';
import { Tag, VersionedPathReference } from '@glimmer/reference';
import {
+ Arguments,
Bounds,
ComponentManager,
DynamicScope,
ElementOperations,
Environment,
PreparedArguments,
} from '@glimmer/runtime';
-import { Arguments } from '@glimm... | true |
Other | emberjs | ember.js | 17ec6c465938d35ba5106e599067bbfe84766a94.json | fix proxy issue | packages/ember-runtime/lib/system/core_object.js | @@ -60,6 +60,14 @@ function makeCtor() {
constructor() {
let self = this;
+ if (!wasApplied) {
+ Class.proto(); // prepare prototype...
+ }
+
+ if (arguments.length > 0) {
+ initProperties = [arguments[0]];
+ }
+
if (MANDATORY_GETTER && EMBER_METAL_ES5_GETTERS && H... | true |
Other | emberjs | ember.js | 06e86935339148ecc18d91fd76484d3b3a90100f.json | blueprints/controller-test: Use dasherizedModuleName for test description | blueprints/controller-test/index.js | @@ -1,7 +1,6 @@
'use strict';
const stringUtil = require('ember-cli-string-utils');
-const testInfo = require('ember-cli-test-info');
const useTestFrameworkDetector = require('../test-framework-detector');
@@ -12,7 +11,7 @@ module.exports = useTestFrameworkDetector({
let controllerPathName = dasherizedMod... | false |
Other | emberjs | ember.js | 461988481aa50eda4ede938308e42a061584afff.json | blueprints/component-test: Use dasherizedModuleName for test description | blueprints/component-test/index.js | @@ -1,7 +1,6 @@
'use strict';
const path = require('path');
-const testInfo = require('ember-cli-test-info');
const stringUtil = require('ember-cli-string-utils');
const isPackageMissing = require('ember-cli-is-package-missing');
const getPathOption = require('ember-cli-get-component-path-option');
@@ -42,16 +41... | true |
Other | emberjs | ember.js | 461988481aa50eda4ede938308e42a061584afff.json | blueprints/component-test: Use dasherizedModuleName for test description | node-tests/fixtures/component-test/default.js | @@ -1,7 +1,7 @@
import { moduleForComponent, test } from 'ember-qunit';
import hbs from 'htmlbars-inline-precompile';
-moduleForComponent('x-foo', 'Integration | Component | x foo', {
+moduleForComponent('x-foo', 'Integration | Component | x-foo', {
integration: true
});
| true |
Other | emberjs | ember.js | 461988481aa50eda4ede938308e42a061584afff.json | blueprints/component-test: Use dasherizedModuleName for test description | node-tests/fixtures/component-test/mocha-0.12-unit.js | @@ -2,7 +2,7 @@ import { expect } from 'chai';
import { describe, it } from 'mocha';
import { setupComponentTest } from 'ember-mocha';
-describe('Unit | Component | x foo', function() {
+describe('Unit | Component | x-foo', function() {
setupComponentTest('x-foo', {
// Specify the other units that are requi... | true |
Other | emberjs | ember.js | 461988481aa50eda4ede938308e42a061584afff.json | blueprints/component-test: Use dasherizedModuleName for test description | node-tests/fixtures/component-test/mocha-0.12.js | @@ -3,7 +3,7 @@ import { describe, it } from 'mocha';
import { setupComponentTest } from 'ember-mocha';
import hbs from 'htmlbars-inline-precompile';
-describe('Integration | Component | x foo', function() {
+describe('Integration | Component | x-foo', function() {
setupComponentTest('x-foo', {
integration:... | true |
Other | emberjs | ember.js | 461988481aa50eda4ede938308e42a061584afff.json | blueprints/component-test: Use dasherizedModuleName for test description | node-tests/fixtures/component-test/mocha-unit.js | @@ -1,7 +1,7 @@
import { expect } from 'chai';
import { describeComponent, it } from 'ember-mocha';
-describeComponent('x-foo', 'Unit | Component | x foo',
+describeComponent('x-foo', 'Unit | Component | x-foo',
{
// Specify the other units that are required for this test
// needs: ['component:foo', 'h... | true |
Other | emberjs | ember.js | 461988481aa50eda4ede938308e42a061584afff.json | blueprints/component-test: Use dasherizedModuleName for test description | node-tests/fixtures/component-test/mocha.js | @@ -2,7 +2,7 @@ import { expect } from 'chai';
import { describeComponent, it } from 'ember-mocha';
import hbs from 'htmlbars-inline-precompile';
-describeComponent('x-foo', 'Integration | Component | x foo',
+describeComponent('x-foo', 'Integration | Component | x-foo',
{
integration: true
}, | true |
Other | emberjs | ember.js | 461988481aa50eda4ede938308e42a061584afff.json | blueprints/component-test: Use dasherizedModuleName for test description | node-tests/fixtures/component-test/rfc232-unit.js | @@ -1,7 +1,7 @@
import { module, test } from 'qunit';
import { setupTest } from 'ember-qunit';
-module('Unit | Component | x foo', function(hooks) {
+module('Unit | Component | x-foo', function(hooks) {
setupTest(hooks);
test('it exists', function(assert) { | true |
Other | emberjs | ember.js | 461988481aa50eda4ede938308e42a061584afff.json | blueprints/component-test: Use dasherizedModuleName for test description | node-tests/fixtures/component-test/rfc232.js | @@ -3,7 +3,7 @@ import { setupRenderingTest } from 'ember-qunit';
import { render } from '@ember/test-helpers';
import hbs from 'htmlbars-inline-precompile';
-module('Integration | Component | x foo', function(hooks) {
+module('Integration | Component | x-foo', function(hooks) {
setupRenderingTest(hooks);
t... | true |
Other | emberjs | ember.js | 461988481aa50eda4ede938308e42a061584afff.json | blueprints/component-test: Use dasherizedModuleName for test description | node-tests/fixtures/component-test/unit.js | @@ -1,6 +1,6 @@
import { moduleForComponent, test } from 'ember-qunit';
-moduleForComponent('x-foo', 'Unit | Component | x foo', {
+moduleForComponent('x-foo', 'Unit | Component | x-foo', {
// Specify the other units that are required for this test
// needs: ['component:foo', 'helper:bar'],
unit: true | true |
Other | emberjs | ember.js | 8910a0dc8a1693b907d358e002d08a77101baa5a.json | Increase browser start and total run timeout times. | testem.dist.js | @@ -50,38 +50,38 @@ module.exports = {
test_page: "dist/tests/index.html?hidepassed&hideskipped&timeout=60000",
timeout: 540,
reporter: FailureOnlyPerBrowserReporter,
- browser_start_timeout: 600,
+ browser_start_timeout: 1200,
parallel: 4,
disable_watching: true,
launchers: {
BS_Chrome_Current... | false |
Other | emberjs | ember.js | 96265b11c58b933b87be2a77f99069e3f1a1e699.json | fix Object.assign issues | packages/ember-glimmer/lib/component-managers/outlet.ts | @@ -1,5 +1,4 @@
import { ComponentCapabilities, Option, Unique } from '@glimmer/interfaces';
-import { ParsedLayout, WrappedBuilder } from '@glimmer/opcode-compiler';
import {
CONSTANT_TAG, Tag, VersionedPathReference
} from '@glimmer/reference';
@@ -16,7 +15,7 @@ import {
import { Destroyable } from '@glimmer/u... | true |
Other | emberjs | ember.js | 96265b11c58b933b87be2a77f99069e3f1a1e699.json | fix Object.assign issues | packages/ember-glimmer/lib/component-managers/root.ts | @@ -5,10 +5,7 @@ import {
} from '@glimmer/runtime';
import { FACTORY_FOR } from 'container';
import { DEBUG } from 'ember-env-flags';
-import {
- _instrumentStart,
- peekMeta,
-} from 'ember-metal';
+import { _instrumentStart } from 'ember-metal';
import { DIRTY_TAG } from '../component';
import Environment fro... | true |
Other | emberjs | ember.js | 96265b11c58b933b87be2a77f99069e3f1a1e699.json | fix Object.assign issues | packages/ember-glimmer/lib/resolver.ts | @@ -17,7 +17,7 @@ import {
import { privatize as P } from 'container';
import { assert } from 'ember-debug';
import { _instrumentStart } from 'ember-metal';
-import { LookupOptions, Owner, setOwner } from 'ember-utils';
+import { assign, LookupOptions, Owner, setOwner } from 'ember-utils';
import {
lookupCompone... | true |
Other | emberjs | ember.js | f616b3bdd941f653438cb99c9e276fc161f3e732.json | Reduce flakiness with IE11 test runs.
Under some circumstances (e.g. under heavy load) IE11 triggers the
`focusin` event twice. The only way I was able to reproduce this was by
severely restricting the resources available to my local VM when
testing.
The changes here are not ideal (I would much prefer to expect _exac... | packages/ember-glimmer/tests/integration/helpers/input-test.js | @@ -318,17 +318,19 @@ moduleFor('Helpers test: {{input}}', class extends InputRenderingTest {
}
['@test triggers `focus-in` when focused'](assert) {
- assert.expect(1);
+ let wasFocused = false;
this.render(`{{input focus-in='foo'}}`, {
actions: {
foo() {
- assert.ok(true, ... | true |
Other | emberjs | ember.js | f616b3bdd941f653438cb99c9e276fc161f3e732.json | Reduce flakiness with IE11 test runs.
Under some circumstances (e.g. under heavy load) IE11 triggers the
`focusin` event twice. The only way I was able to reproduce this was by
severely restricting the resources available to my local VM when
testing.
The changes here are not ideal (I would much prefer to expect _exac... | packages/ember-testing/tests/helpers_test.js | @@ -1,6 +1,7 @@
import {
moduleFor,
- AutobootApplicationTestCase
+ AutobootApplicationTestCase,
+ isIE11
} from 'internal-test-helpers';
import { Route } from 'ember-routing';
@@ -361,7 +362,20 @@ if (!jQueryDisabled) {
wrapper.addEventListener('mousedown', e => events.push(e.type));
w... | true |
Other | emberjs | ember.js | f616b3bdd941f653438cb99c9e276fc161f3e732.json | Reduce flakiness with IE11 test runs.
Under some circumstances (e.g. under heavy load) IE11 triggers the
`focusin` event twice. The only way I was able to reproduce this was by
severely restricting the resources available to my local VM when
testing.
The changes here are not ideal (I would much prefer to expect _exac... | packages/internal-test-helpers/lib/browser-detect.js | @@ -0,0 +1,4 @@
+// `window.ActiveXObject` is "falsey" in IE11 (but not `undefined` or `false`)
+// `"ActiveXObject" in window` returns `true` in all IE versions
+// only IE11 will pass _both_ of these conditions
+export const isIE11 = !window.ActiveXObject && 'ActiveXObject' in window; | true |
Other | emberjs | ember.js | f616b3bdd941f653438cb99c9e276fc161f3e732.json | Reduce flakiness with IE11 test runs.
Under some circumstances (e.g. under heavy load) IE11 triggers the
`focusin` event twice. The only way I was able to reproduce this was by
severely restricting the resources available to my local VM when
testing.
The changes here are not ideal (I would much prefer to expect _exac... | packages/internal-test-helpers/lib/index.js | @@ -35,3 +35,5 @@ export {
default as TestResolver,
ModuleBasedResolver as ModuleBasedTestResolver
} from './test-resolver';
+
+export { isIE11 } from './browser-detect'; | true |
Other | emberjs | ember.js | 5d01bb0de2b0457995f348861c455bc7638e4b3f.json | Add a resolver setter to local lookup test case
Since RenderingTestCase is setting `resolver` in its constructor, a
setter is necessary, even if it doesn't do anything. | packages/ember-glimmer/tests/integration/components/local-lookup-test.js | @@ -258,6 +258,10 @@ if (EMBER_MODULE_UNIFICATION) {
get resolver() {
return this.owner.__registry__.fallback.resolver;
}
+ set resolver(resolver) {
+ // `resolver` needs a setter because RenderingTestCase sets `resolver` in
+ // its constructor
+ }
getResolver() {
return ... | false |
Other | emberjs | ember.js | 670d490146e04577ac8799ba2c7f3d5d9f8a76a6.json | Get everything that needs to be cached into place | packages/ember-glimmer/lib/component-managers/curly.ts | @@ -5,7 +5,6 @@ import {
Simple,
VMHandle
} from '@glimmer/interfaces';
-import { ParsedLayout, TemplateOptions, WrappedBuilder } from '@glimmer/opcode-compiler';
import {
combine,
Tag,
@@ -37,7 +36,6 @@ import { String as StringUtils } from 'ember-runtime';
import {
getOwner,
guidFor,
- setOwner
... | true |
Other | emberjs | ember.js | 670d490146e04577ac8799ba2c7f3d5d9f8a76a6.json | Get everything that needs to be cached into place | packages/ember-glimmer/lib/resolver.ts | @@ -3,9 +3,10 @@ import {
Opaque,
Option,
RuntimeResolver as IRuntimeResolver,
- VMHandle
+ VMHandle,
+ ComponentCapabilities
} from '@glimmer/interfaces';
-import { LazyOpcodeBuilder, Macros, OpcodeBuilderConstructor, TemplateOptions } from '@glimmer/opcode-compiler';
+import { LazyOpcodeBuilder, Macros, ... | true |
Other | emberjs | ember.js | 21e2eae7903eab8fbfa90cd92a58db301e922973.json | fix experimental syntax | packages/ember-glimmer/tests/integration/syntax/experimental-syntax-test.js | @@ -1,16 +1,15 @@
import { moduleFor, RenderingTest } from '../../utils/test-case';
import { strip } from '../../utils/abstract-test-case';
import { _registerMacros, _experimentalMacros } from 'ember-glimmer';
-import { compileExpression } from '@glimmer/runtime';
moduleFor('registerMacros', class extends Renderi... | false |
Other | emberjs | ember.js | db1717b34dc92a266ae54c687bc350b7dcb07de2.json | Simplify implementation of some array methods | packages/ember-runtime/lib/mixins/array.js | @@ -160,17 +160,6 @@ export function isEmberArray(obj) {
return obj && obj[EMBER_ARRAY];
}
-const contexts = [];
-
-function popCtx() {
- return contexts.length === 0 ? {} : contexts.pop();
-}
-
-function pushCtx(ctx) {
- contexts.push(ctx);
- return null;
-}
-
function iter(key, value) {
let valueProvided... | false |
Other | emberjs | ember.js | 764b8a71c87785478d0ffa44f095c3762e5ff9d0.json | Remove Enumerable.detect checks | packages/ember-runtime/lib/mixins/mutable_array.js | @@ -8,7 +8,6 @@ import {
beginPropertyChanges,
endPropertyChanges
} from 'ember-metal';
-import Enumerable from './enumerable';
import MutableEnumerable from './mutable_enumerable';
import EmberArray, { objectAt } from './array';
import { Error as EmberError } from 'ember-debug';
@@ -187,7 +186,7 @@ export de... | true |
Other | emberjs | ember.js | 764b8a71c87785478d0ffa44f095c3762e5ff9d0.json | Remove Enumerable.detect checks | packages/ember-runtime/lib/system/array_proxy.js | @@ -12,7 +12,6 @@ import {
} from '../utils';
import EmberObject from './object';
import MutableArray from '../mixins/mutable_array';
-import Enumerable from '../mixins/enumerable';
import {
addArrayObserver,
removeArrayObserver,
@@ -257,7 +256,7 @@ export default EmberObject.extend(MutableArray, {
},
... | true |
Other | emberjs | ember.js | bb626b6b15479c477f3c46c86d38d6581b8455d6.json | Remove private enumerableContent{Will,Did}Change | packages/ember-runtime/lib/mixins/array.js | @@ -90,7 +90,11 @@ export function arrayContentWillChange(array, startIdx, removeAmt, addAmt) {
sendEvent(array, '@array:before', [array, startIdx, removeAmt, addAmt]);
- array.enumerableContentWillChange(removeAmt, addAmt);
+ propertyWillChange(array, '[]');
+
+ if (addAmt < 0 || removeAmt < 0 || addAmt - re... | false |
Other | emberjs | ember.js | 1a29eb96a49e642ad8a7b8d07a96ffc0f3f2a6a4.json | Move enumerable mixin methods into array mixins | packages/ember-runtime/lib/mixins/array.js | @@ -2,14 +2,13 @@
@module @ember/array
*/
-// ..........................................................
-// HELPERS
-//
import { symbol, toString } from 'ember-utils';
-import Ember, { // ES6TODO: Ember.A
+import {
get,
+ set,
computed,
isNone,
+ aliasMethod,
Mixin,
propertyWillChange,
propert... | true |
Other | emberjs | ember.js | 1a29eb96a49e642ad8a7b8d07a96ffc0f3f2a6a4.json | Move enumerable mixin methods into array mixins | packages/ember-runtime/lib/mixins/enumerable.js | @@ -1,1046 +1,16 @@
+import { Mixin } from 'ember-metal';
+
/**
-@module @ember/enumerable
-@private
+@module ember
*/
-// ..........................................................
-// HELPERS
-//
-
-import {
- get,
- set,
- Mixin,
- aliasMethod,
- computed,
- propertyWillChange,
- propertyDidChange
-} from... | true |
Other | emberjs | ember.js | 1a29eb96a49e642ad8a7b8d07a96ffc0f3f2a6a4.json | Move enumerable mixin methods into array mixins | packages/ember-runtime/lib/mixins/mutable_array.js | @@ -2,23 +2,20 @@
@module @ember/array
*/
-
-const OUT_OF_RANGE_EXCEPTION = 'Index out of range';
-const EMPTY = [];
-
-// ..........................................................
-// HELPERS
-//
-
import {
get,
- Mixin
+ Mixin,
+ beginPropertyChanges,
+ endPropertyChanges
} from 'ember-metal';
-import E... | true |
Other | emberjs | ember.js | 1a29eb96a49e642ad8a7b8d07a96ffc0f3f2a6a4.json | Move enumerable mixin methods into array mixins | packages/ember-runtime/lib/mixins/mutable_enumerable.js | @@ -1,120 +1,18 @@
import Enumerable from './enumerable';
-import {
- Mixin,
- beginPropertyChanges,
- endPropertyChanges
-} from 'ember-metal';
+import { Mixin } from 'ember-metal';
/**
@module ember
*/
/**
- This mixin defines the API for modifying generic enumerables. These methods
- can be applied to ... | true |
Other | emberjs | ember.js | d190957863dc95e2cdde88ca70d56992278c61e1.json | Add v3.0.0-beta.3 to CHANGELOG
[ci skip]
(cherry picked from commit 6b81acc9a6182594f3bc43e74c4cae543ace00fd) | CHANGELOG.md | @@ -1,5 +1,12 @@
# Ember Changelog
+### 3.0.0-beta.3 (January 15, 2018)
+
+- [#16095](https://github.com/emberjs/ember.js/pull/16095) [CLEANUP] Fix ember-2-legacy support for Ember.Binding.
+- [#16117](https://github.com/emberjs/ember.js/pull/16117) [BUGFIX] link-to active class applied when params change
+- [#16097... | false |
Other | emberjs | ember.js | 60331387c366d9a4f08486ffab8056e72a84702f.json | Simplify npm publishing.
Rely on auto-dist-tag to do its magic... | bin/build-for-publishing.js | @@ -39,6 +39,8 @@ function updateDocumentationVersion() {
}
updatePackageJSONVersion();
+// ensures that we tag this correctly
+execSync('auto-dist-tag -w');
// do a production build
execSync('yarn build'); | true |
Other | emberjs | ember.js | 60331387c366d9a4f08486ffab8056e72a84702f.json | Simplify npm publishing.
Rely on auto-dist-tag to do its magic... | bin/publish_builds | @@ -8,5 +8,18 @@ if [ "$TRAVIS_PULL_REQUEST" == "false" ] && [ "$PUBLISH" == "true" ]; then
./bin/build-for-publishing.js
./bin/publish_to_s3.js
- ./bin/publish_npm
+
+ #### NPM PUBLISHING
+ if [[ "$TRAVIS_TAG" =~ ^v[0-9.]+ ]]; then
+ echo -e "CURRENT_TAG: ${TRAVIS_TAG}\n"
+ echo $NPM_AUTH_TOKEN > ~/.n... | true |
Other | emberjs | ember.js | 60331387c366d9a4f08486ffab8056e72a84702f.json | Simplify npm publishing.
Rely on auto-dist-tag to do its magic... | bin/publish_npm | @@ -1,61 +0,0 @@
-#!/usr/bin/env bash
-
-git config --global user.email "tomster@emberjs.com"
-git config --global user.name "Tomster"
-
-echo -e "CURRENT_BRANCH: ${TRAVIS_BRANCH}\n"
-echo -e "CURRENT_TAG: ${TRAVIS_TAG}\n"
-
-if [[ $TRAVIS_PULL_REQUEST != "false" ]]; then
- echo "not publishing because this is a pull ... | true |
Other | emberjs | ember.js | c09fa056a31552a34ae29a76e341e422d7c15837.json | Remove remaining (unused) ruby files.
🔚😭 | scripts/list_file_sizes.rb | @@ -1,43 +0,0 @@
-files = Dir["packages/ember-*/lib/**/*.js"] - Dir["packages/ember-runtime/**/*.js"]
-files = Dir["packages/ember-{metal,views,handlebars}/lib/**/*.js"]
-
-def uglify(string)
- IO.popen("uglifyjs", "r+") do |io|
- io.puts string
- io.close_write
- return io.read
- end
-end
-
-def gzip(string... | false |
Other | emberjs | ember.js | abf7bd3727cd1ce12d06b68a2410c44d5404d998.json | Fix model with model param | packages/ember-glimmer/lib/component-managers/mount.ts | @@ -25,7 +25,6 @@ import { EMBER_ENGINES_MOUNT_PARAMS } from 'ember/features';
import Environment from '../environment';
import RuntimeResolver from '../resolver';
import { OwnedTemplate } from '../template';
-import { Component } from '../utils/curly-component-state-bucket';
import { RootReference } from '../utils... | true |
Other | emberjs | ember.js | abf7bd3727cd1ce12d06b68a2410c44d5404d998.json | Fix model with model param | packages/ember-glimmer/lib/syntax/mount.ts | @@ -1,7 +1,7 @@
/**
@module ember
*/
-import { Option } from '@glimmer/interfaces';
+import { Option, Opaque } from '@glimmer/interfaces';
import { OpcodeBuilder } from '@glimmer/opcode-compiler';
import { Tag, VersionedPathReference } from '@glimmer/reference';
import {
@@ -19,9 +19,10 @@ import { MountDefinitio... | true |
Other | emberjs | ember.js | 1e539dbc8c57a2a90d9db0c0ee703bb8572bfd17.json | remove unused thing | packages/ember-glimmer/tests/integration/custom-component-manager-test.js | @@ -1,32 +1,10 @@
-import {
- PrimitiveReference
-} from '@glimmer/runtime';
import { moduleFor, RenderingTest } from '../utils/test-case';
import {
GLIMMER_CUSTOM_COMPONENT_MANAGER
} from 'ember/features';
import { AbstractComponentManager } from 'ember-glimmer';
if (GLIMMER_CUSTOM_COMPONENT_MANAGER) {
- /... | false |
Other | emberjs | ember.js | 135d84b7ad494cc04e34f512b58a117d271d1fd5.json | Fix args for model | packages/ember-glimmer/lib/syntax/render.ts | @@ -58,10 +58,14 @@ export function renderHelper(vm: VM, args: Arguments): VersionedPathReference<Cu
controllerName = templateName;
}
- let manager = args.positional.length === 1 ? SINGLETON_RENDER_MANAGER : NON_SINGLETON_RENDER_MANAGER;
-
- let def = new RenderDefinition(controllerName, template, env, mana... | false |
Other | emberjs | ember.js | 9240931232dc8adb99aaf24dce8739421ae44a44.json | Fix helper and part of render | packages/ember-glimmer/lib/component-managers/render.ts | @@ -63,7 +63,7 @@ const CAPABILITIES = {
dynamicLayout: false,
dynamicTag: false,
prepareArgs: false,
- createArgs: false,
+ createArgs: true,
attributeHook: false,
elementHook: false
}; | true |
Other | emberjs | ember.js | 9240931232dc8adb99aaf24dce8739421ae44a44.json | Fix helper and part of render | packages/ember-glimmer/lib/helper.ts | @@ -39,8 +39,7 @@ export interface HelperInstance {
export function isHelperFactory(helper: any | undefined | null): helper is HelperFactory {
return typeof helper === 'object' &&
helper !== null &&
- typeof helper.class === 'function' &&
- helper.class.isHelperFactory;
+ helper.cl... | true |
Other | emberjs | ember.js | c7a7bc7665883fa872ebb423bb08c0aea3bf3be8.json | Fix remaining contextual component tests.
Issue deprecation when conflicting named and positional params exist
(changed from per-layer assert to post-merge deprecation). | packages/ember-glimmer/lib/component-managers/curly.ts | @@ -28,6 +28,7 @@ import { Destroyable, EMPTY_ARRAY, Opaque } from '@glimmer/util';
import { privatize as P } from 'container';
import {
assert,
+ deprecate,
} from 'ember-debug';
import { DEBUG } from 'ember-env-flags';
import {
@@ -223,7 +224,10 @@ export default class CurlyComponentManager extends AbstractM... | true |
Other | emberjs | ember.js | c7a7bc7665883fa872ebb423bb08c0aea3bf3be8.json | Fix remaining contextual component tests.
Issue deprecation when conflicting named and positional params exist
(changed from per-layer assert to post-merge deprecation). | packages/ember-glimmer/tests/integration/components/contextual-components-test.js | @@ -318,58 +318,57 @@ moduleFor('Components test: contextual components', class extends RenderingTest
this.assertText('Hi Max 9');
}
- ['@test nested components positional parameters are overridden by named parameters']() {
+ ['@test nested components positional parameters override named parameters [DEPRECA... | true |
Other | emberjs | ember.js | 3e005da51f57cf050d36cf919d44fea15525d24f.json | remove jquery from ember-testing | lib/packages.js | @@ -9,7 +9,12 @@ module.exports = function() {
'ember-runtime': { trees: null, vendorRequirements: ['rsvp'], requirements: ['container', 'ember-environment', 'ember-console', 'ember-metal'], requiresJQuery: false },
'ember-views': { trees: null, requirements: ['ember-runtime'], s... | true |
Other | emberjs | ember.js | 3e005da51f57cf050d36cf919d44fea15525d24f.json | remove jquery from ember-testing | packages/ember-testing/lib/events.js | @@ -1,25 +1,32 @@
-import { jQuery } from 'ember-views';
import { run } from 'ember-metal';
+import { assign } from 'ember-utils';
+import isFormControl from './helpers/-is-form-control';
const DEFAULT_EVENT_OPTIONS = { canBubble: true, cancelable: true };
const KEYBOARD_EVENT_TYPES = ['keydown', 'keypress', 'keyu... | true |
Other | emberjs | ember.js | 3e005da51f57cf050d36cf919d44fea15525d24f.json | remove jquery from ember-testing | packages/ember-testing/lib/helpers/-is-form-control.js | @@ -0,0 +1,16 @@
+const FORM_CONTROL_TAGS = ['INPUT', 'BUTTON', 'SELECT', 'TEXTAREA'];
+
+/**
+ @private
+ @param {Element} element the element to check
+ @returns {boolean} `true` when the element is a form control, `false` otherwise
+*/
+export default function isFormControl(element) {
+ let { tagName, type } = e... | true |
Other | emberjs | ember.js | 3e005da51f57cf050d36cf919d44fea15525d24f.json | remove jquery from ember-testing | packages/ember-testing/lib/helpers/fill_in.js | @@ -2,6 +2,7 @@
@module ember
*/
import { focus, fireEvent } from '../events';
+import isFormControl from './-is-form-control';
/**
Fills in an input element with some text.
@@ -32,7 +33,12 @@ export default function fillIn(app, selector, contextOrText, text) {
el = $el[0];
focus(el);
- $el.eq(0).val(... | true |
Other | emberjs | ember.js | 3e005da51f57cf050d36cf919d44fea15525d24f.json | remove jquery from ember-testing | packages/ember-testing/lib/helpers/find.js | @@ -2,6 +2,8 @@
@module ember
*/
import { get } from 'ember-metal';
+import { assert } from 'ember-debug';
+import { jQueryDisabled } from 'ember-views';
/**
Finds an element in the context of the app's container element. A simple alias
@@ -20,13 +22,16 @@ import { get } from 'ember-metal';
```
@method... | true |
Other | emberjs | ember.js | 3e005da51f57cf050d36cf919d44fea15525d24f.json | remove jquery from ember-testing | packages/ember-testing/lib/helpers/find_with_assert.js | @@ -22,7 +22,7 @@
@param {String} [context] (optional) jQuery selector that will limit the
selector argument to find only within the context's children
@return {Object} jQuery object representing the results of the query
- @throws {Error} throws error if jQuery object returned has a length of 0
+ @throws {Er... | true |
Other | emberjs | ember.js | 3e005da51f57cf050d36cf919d44fea15525d24f.json | remove jquery from ember-testing | packages/ember-testing/lib/setup_for_testing.js | @@ -1,7 +1,6 @@
/* global self */
import { setTesting } from 'ember-debug';
-import { jQuery } from 'ember-views';
import {
getAdapter,
setAdapter
@@ -35,13 +34,11 @@ export default function setupForTesting() {
setAdapter((typeof self.QUnit === 'undefined') ? new Adapter() : new QUnitAdapter());
}
... | true |
Other | emberjs | ember.js | 3e005da51f57cf050d36cf919d44fea15525d24f.json | remove jquery from ember-testing | packages/ember-testing/lib/support.js | @@ -43,7 +43,7 @@ if (environment.hasDOM && !jQueryDisabled) {
$.event.special.click = {
// For checkbox, fire native event so checked state will be right
trigger() {
- if ($.nodeName(this, 'input') && this.type === 'checkbox' && this.click) {
+ if (this.nodeName ===... | true |
Other | emberjs | ember.js | 3e005da51f57cf050d36cf919d44fea15525d24f.json | remove jquery from ember-testing | packages/ember-testing/lib/test/pending_requests.js | @@ -8,11 +8,13 @@ export function clearPendingRequests() {
requests.length = 0;
}
-export function incrementPendingRequests(_, xhr) {
+export function incrementPendingRequests({ detail } = { detail: { xhr: null }}) {
+ let xhr = detail.xhr;
requests.push(xhr);
}
-export function decrementPendingRequests(_,... | true |
Other | emberjs | ember.js | 3e005da51f57cf050d36cf919d44fea15525d24f.json | remove jquery from ember-testing | packages/ember-testing/tests/acceptance_test.js | @@ -8,382 +8,385 @@ import Test from '../test';
import QUnitAdapter from '../adapters/qunit';
import { Route } from 'ember-routing';
import { RSVP } from 'ember-runtime';
+import { jQueryDisabled } from 'ember-views';
-moduleFor('ember-testing Acceptance', class extends AutobootApplicationTestCase {
- constructor... | true |
Other | emberjs | ember.js | 3e005da51f57cf050d36cf919d44fea15525d24f.json | remove jquery from ember-testing | packages/ember-testing/tests/helpers_test.js | @@ -9,18 +9,19 @@ import {
RSVP
} from 'ember-runtime';
import { run } from 'ember-metal';
-import { jQuery } from 'ember-views';
import {
Component,
} from 'ember-glimmer';
+import { jQueryDisabled } from 'ember-views';
import Test from '../test';
import setupForTesting from '../setup_for_testing';
im... | true |
Other | emberjs | ember.js | 3e005da51f57cf050d36cf919d44fea15525d24f.json | remove jquery from ember-testing | packages/ember-testing/tests/integration_test.js | @@ -8,6 +8,7 @@ import {
A as emberA
} from 'ember-runtime';
import { Route } from 'ember-routing';
+import { jQueryDisabled } from 'ember-views';
moduleFor('ember-testing Integration tests of acceptance', class extends AutobootApplicationTestCase {
@@ -52,39 +53,56 @@ moduleFor('ember-testing Integration tes... | true |
Other | emberjs | ember.js | d342a2a1dc89200a941040e7eefaaede161a39bb.json | Remove private enumerable observers | packages/ember-runtime/lib/mixins/array.js | @@ -59,8 +59,6 @@ export function objectAt(content, idx) {
}
export function arrayContentWillChange(array, startIdx, removeAmt, addAmt) {
- let removing, lim;
-
// if no args are passed assume everything changes
if (startIdx === undefined) {
startIdx = 0;
@@ -81,18 +79,7 @@ export function arrayContentW... | true |
Other | emberjs | ember.js | d342a2a1dc89200a941040e7eefaaede161a39bb.json | Remove private enumerable observers | packages/ember-runtime/lib/mixins/enumerable.js | @@ -14,11 +14,7 @@ import {
aliasMethod,
computed,
propertyWillChange,
- propertyDidChange,
- addListener,
- removeListener,
- sendEvent,
- hasListeners
+ propertyDidChange
} from 'ember-metal';
import { assert } from 'ember-debug';
import compare from '../compare';
@@ -842,76 +838,6 @@ const Enumerab... | true |
Other | emberjs | ember.js | d342a2a1dc89200a941040e7eefaaede161a39bb.json | Remove private enumerable observers | packages/ember-runtime/tests/mixins/array_test.js | @@ -213,7 +213,7 @@ QUnit.module('notify array observers', {
}
});
-QUnit.test('should notify enumerable observers when called with no params', function(assert) {
+QUnit.test('should notify array observers when called with no params', function(assert) {
arrayContentWillChange(obj);
assert.deepEqual(observer... | true |
Other | emberjs | ember.js | d342a2a1dc89200a941040e7eefaaede161a39bb.json | Remove private enumerable observers | packages/ember-runtime/tests/mixins/enumerable_test.js | @@ -184,7 +184,7 @@ let DummyEnum = EmberObject.extend(Enumerable, {
length: 0
});
-let obj, observer;
+let obj;
// ..........................................................
// NOTIFY ENUMERABLE PROPERTY
@@ -278,82 +278,3 @@ QUnit.test('should notify when passed old index API with delta', function(assert
... | true |
Other | emberjs | ember.js | d342a2a1dc89200a941040e7eefaaede161a39bb.json | Remove private enumerable observers | packages/ember-runtime/tests/suites/enumerable.js | @@ -130,29 +130,6 @@ const ObserverClass = EmberObject.extend({
*/
timesCalled(key) {
return this._keys[key] || 0;
- },
-
- /*
- begins acting as an enumerable observer.
- */
- observeEnumerable(obj) {
- obj.addEnumerableObserver(this);
- return this;
- },
-
- stopObserveEnumerable(obj) {
- ... | true |
Other | emberjs | ember.js | d342a2a1dc89200a941040e7eefaaede161a39bb.json | Remove private enumerable observers | packages/ember-runtime/tests/suites/mutable_array/replace.js | @@ -147,18 +147,6 @@ suite.test('[A,B,C,D].replace(-1,1) => [A,B,C] + notify', function(assert) {
assert.equal(observer.validate('firstObject'), false, 'should NOT have notified firstObject once');
});
-suite.test('Adding object should notify enumerable observer', function(assert) {
- let fixtures = this.newFixt... | true |
Other | emberjs | ember.js | d342a2a1dc89200a941040e7eefaaede161a39bb.json | Remove private enumerable observers | packages/ember-runtime/tests/suites/mutable_enumerable/addObject.js | @@ -56,15 +56,4 @@ suite.test('[A,B,C].addObject(A) => [A,B,C] + NO notify', function(assert) {
}
});
-suite.test('Adding object should notify enumerable observer', function(assert) {
- let obj = this.newObject(this.newFixture(3));
- let observer = this.newObserver(obj).observeEnumerable(obj);
- let item = thi... | true |
Other | emberjs | ember.js | d342a2a1dc89200a941040e7eefaaede161a39bb.json | Remove private enumerable observers | packages/ember-runtime/tests/suites/mutable_enumerable/removeObject.js | @@ -58,16 +58,4 @@ suite.test('[A,B,C].removeObject(D) => [A,B,C]', function(assert) {
}
});
-suite.test('Removing object should notify enumerable observer', function(assert) {
- let fixtures = this.newFixture(3);
- let obj = this.newObject(fixtures);
- let observer = this.newObserver(obj).observeEnumerable(ob... | true |
Other | emberjs | ember.js | d342a2a1dc89200a941040e7eefaaede161a39bb.json | Remove private enumerable observers | packages/ember-runtime/tests/suites/mutable_enumerable/removeObjects.js | @@ -168,16 +168,4 @@ suite.test('[A,B,C].removeObjects([D]) => [A,B,C]', function(assert) {
}
});
-suite.test('Removing objects should notify enumerable observer', function(assert) {
- let fixtures = this.newFixture(3);
- let obj = this.newObject(fixtures);
- let observer = this.newObserver(obj).observeEnumera... | true |
Other | emberjs | ember.js | 41985bda1ab20b62fbad46aaf2abc406e570bd19.json | Publish metadata file to S3.
Remove publishing tarball to `/${channel}.tgz` due to npm and yarn
caching issues.
Publishes a new `/${channel}.json` file (in a stable location) that can
be used by tooling to determine the correct asset path for the current
channel build SHA. | bin/build-for-publishing.js | @@ -4,14 +4,14 @@
const fs = require('fs');
const path = require('path');
const execSync = require('child_process').execSync;
+const VERSION = require('../broccoli/version').VERSION;
/*
Updates the `package.json`'s `version` string to be the same value that
the built assets will have as `Ember.VERSION`.
*/... | true |
Other | emberjs | ember.js | 41985bda1ab20b62fbad46aaf2abc406e570bd19.json | Publish metadata file to S3.
Remove publishing tarball to `/${channel}.tgz` due to npm and yarn
caching issues.
Publishes a new `/${channel}.json` file (in a stable location) that can
be used by tooling to determine the correct asset path for the current
channel build SHA. | config/s3ProjectConfig.js | @@ -26,27 +26,40 @@ function fileMap(revision, tag, date) {
contentType: 'application/x-gzip',
destinations: {
'alpha': [
- `alpha.tgz`,
`alpha/daily/${date}.tgz`,
`alpha/shas/${revision}.tgz`,
],
'canary': [
- `canary.tgz`,
`canary/daily/${date}.t... | true |
Other | emberjs | ember.js | abf3db1b78a708515c5b3ee58e9c1756dd527cef.json | Simplify outlet and fix stability. | packages/ember-glimmer/lib/component-managers/outlet.ts | @@ -26,32 +26,35 @@ import RuntimeResolver from '../resolver';
import {
OwnedTemplate,
} from '../template';
+import { OutletState } from '../utils/outlet';
import { RootReference } from '../utils/references';
-import { default as OutletView, OutletState } from '../views/outlet';
+import OutletView from '../views... | true |
Other | emberjs | ember.js | abf3db1b78a708515c5b3ee58e9c1756dd527cef.json | Simplify outlet and fix stability. | packages/ember-glimmer/lib/helpers/outlet.ts | @@ -1,56 +1,79 @@
-import { combine, ConstReference, Reference, RevisionTag, TagWrapper, UpdatableTag, VersionedPathReference } from '@glimmer/reference';
+import { ConstReference, Reference, Tag, VersionedPathReference } from '@glimmer/reference';
import {
Arguments,
CurriedComponentDefinition,
curry,
UND... | true |
Other | emberjs | ember.js | abf3db1b78a708515c5b3ee58e9c1756dd527cef.json | Simplify outlet and fix stability. | packages/ember-glimmer/lib/renderer.ts | @@ -1,13 +1,13 @@
-import { Option, Simple } from '@glimmer/interfaces';
+import { Simple } from '@glimmer/interfaces';
import { CURRENT_TAG, VersionedPathReference } from '@glimmer/reference';
import {
clientBuilder,
CurriedComponentDefinition,
curry,
DynamicScope as GlimmerDynamicScope,
IteratorResul... | true |
Other | emberjs | ember.js | abf3db1b78a708515c5b3ee58e9c1756dd527cef.json | Simplify outlet and fix stability. | packages/ember-glimmer/lib/utils/outlet.ts | @@ -0,0 +1,170 @@
+import { Opaque } from '@glimmer/interfaces';
+import { combine, DirtyableTag, Reference, Tag, VersionedPathReference } from '@glimmer/reference';
+import { Owner } from 'ember-utils';
+import { OwnedTemplate } from '../template';
+
+export interface RenderState {
+ /**
+ * Not sure why this is he... | true |
Other | emberjs | ember.js | abf3db1b78a708515c5b3ee58e9c1756dd527cef.json | Simplify outlet and fix stability. | packages/ember-glimmer/lib/views/outlet.ts | @@ -1,122 +1,22 @@
import { Simple } from '@glimmer/interfaces';
-import { DirtyableTag, Tag, TagWrapper, VersionedPathReference } from '@glimmer/reference';
-import { Opaque, Option } from '@glimmer/util';
import { environment } from 'ember-environment';
import { run } from 'ember-metal';
import { assign, OWNER, O... | true |
Other | emberjs | ember.js | abf3db1b78a708515c5b3ee58e9c1756dd527cef.json | Simplify outlet and fix stability. | tests/node/helpers/component-module.js | @@ -107,7 +107,6 @@ function render(_template) {
name: 'index',
controller: this,
template: this.owner.lookup(templateFullName),
- outlets: { }
};
stateToRender.name = 'index'; | true |
Other | emberjs | ember.js | f3ed85359760121ce71ab8f61d9167857f4b24bc.json | Add the rest of the tests from #15287 | packages/ember-glimmer/tests/integration/components/contextual-components-test.js | @@ -369,6 +369,76 @@ moduleFor('Components test: contextual components', class extends RenderingTest
this.assertText('Hodi Sigmundur 33');
}
+ ['@test nested components with positional params at middle layer are partially overwriten by hash parameters']() {
+ this.registerComponent('-looked-up', {
+ ... | false |
Other | emberjs | ember.js | 2f135f97081443881bd063cd26ace65ab9f94a6e.json | Remove hasHelper method used only in assertion | packages/ember-glimmer/lib/resolver.ts | @@ -164,14 +164,6 @@ export default class RuntimeResolver implements IRuntimeResolver<OwnedTemplateMe
}
// end CompileTimeLookup
- hasHelper(name: string, {owner, moduleName}: OwnedTemplateMeta): boolean {
- if (name === 'component' || this.builtInHelpers[name]) {
- return true;
- }
- let options... | true |
Other | emberjs | ember.js | 2f135f97081443881bd063cd26ace65ab9f94a6e.json | Remove hasHelper method used only in assertion | packages/ember-glimmer/lib/syntax.ts | @@ -15,7 +15,6 @@ import { hashToArgs } from './syntax/utils';
import { wrapComponentClassAttribute } from './utils/bindings';
function refineInlineSyntax(name: string, params: Option<Core.Params>, hash: Option<Core.Hash>, builder: OpcodeBuilder<OwnedTemplateMeta>): boolean {
- console.log('fail');
assert(
... | true |
Other | emberjs | ember.js | d26676cab6a1e60ae5cd7985675f8314c89cb2f4.json | remove unused jQueryDisabled flag | packages/ember-glimmer/tests/integration/event-dispatcher-test.js | @@ -6,7 +6,6 @@ import {
run
} from 'ember-metal';
import { EMBER_IMPROVED_INSTRUMENTATION } from 'ember/features';
-import { jQueryDisabled } from 'ember-views';
let canDataTransfer = !!document.createEvent('HTMLEvents').dataTransfer;
| false |
Other | emberjs | ember.js | c27f2cd20a16fca45094e6e81fd14042ac8a01d9.json | Fix style warning tests | packages/ember-glimmer/lib/environment.ts | @@ -1,13 +1,11 @@
-import {
- Simple,
-} from '@glimmer/interfaces';
import {
Reference,
} from '@glimmer/reference';
import {
DynamicAttributeFactory,
Environment as GlimmerEnvironment,
PrimitiveReference,
+ SafeString
} from '@glimmer/runtime';
import {
Destroyable, Opaque,
@@ -36,6 +34,10 @@ im... | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.