language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | cfaa47e48b0d6badb5e84419f117a46fd2f2ae8e.json | Introduce source to injections
Ember templates use a `source` argument to the container. This hints
where to look for "local lookup", and also what namespace to look in for
a partial specifier. For example a template in an addon's `src` tree can
invoke components and helpers in that tree becuase it has a `source`
argu... | packages/container/tests/container_test.js | @@ -388,15 +388,18 @@ moduleFor('Container', class extends AbstractTestCase {
assert.deepEqual(resolveWasCalled, ['foo:post']);
}
- ['@test A factory\'s lazy injections are validated when first instantiated'](assert) {
+ [`@test A factory's lazy injections are validated when first instantiated`](assert) {
... | true |
Other | emberjs | ember.js | cfaa47e48b0d6badb5e84419f117a46fd2f2ae8e.json | Introduce source to injections
Ember templates use a `source` argument to the container. This hints
where to look for "local lookup", and also what namespace to look in for
a partial specifier. For example a template in an addon's `src` tree can
invoke components and helpers in that tree becuase it has a `source`
argu... | packages/ember-application/tests/system/application_instance_test.js | @@ -121,6 +121,29 @@ moduleFor('ApplicationInstance', class extends TestCase {
assert.notStrictEqual(postController1, postController2, 'lookup creates a brand new instance, because the previous one was reset');
}
+ ['@skip unregistering a factory clears caches with source of that factory'](assert) {
+ ass... | true |
Other | emberjs | ember.js | cfaa47e48b0d6badb5e84419f117a46fd2f2ae8e.json | Introduce source to injections
Ember templates use a `source` argument to the container. This hints
where to look for "local lookup", and also what namespace to look in for
a partial specifier. For example a template in an addon's `src` tree can
invoke components and helpers in that tree becuase it has a `source`
argu... | packages/ember-application/tests/test-helpers/registry-check.js | @@ -18,7 +18,7 @@ export function verifyInjection(assert, owner, fullName, property, injectionName
for (let i = 0, l = injections.length; i < l; i++) {
injection = injections[i];
- if (injection.property === property && injection.fullName === normalizedName) {
+ if (injection.property === property && in... | true |
Other | emberjs | ember.js | cfaa47e48b0d6badb5e84419f117a46fd2f2ae8e.json | Introduce source to injections
Ember templates use a `source` argument to the container. This hints
where to look for "local lookup", and also what namespace to look in for
a partial specifier. For example a template in an addon's `src` tree can
invoke components and helpers in that tree becuase it has a `source`
argu... | packages/ember-glimmer/tests/integration/components/local-lookup-test.js | @@ -1,5 +1,7 @@
import { moduleFor, RenderingTest } from '../../utils/test-case';
+import { compile } from 'ember-template-compiler';
import { ModuleBasedTestResolver } from 'internal-test-helpers';
+import { moduleFor as applicationModuleFor, ApplicationTestCase } from 'internal-test-helpers';
import { Component } ... | true |
Other | emberjs | ember.js | cfaa47e48b0d6badb5e84419f117a46fd2f2ae8e.json | Introduce source to injections
Ember templates use a `source` argument to the container. This hints
where to look for "local lookup", and also what namespace to look in for
a partial specifier. For example a template in an addon's `src` tree can
invoke components and helpers in that tree becuase it has a `source`
argu... | packages/ember-metal/lib/injected_property.js | @@ -20,11 +20,12 @@ import { descriptorFor } from './meta';
@private
*/
export default class InjectedProperty extends ComputedProperty {
- constructor(type, name) {
+ constructor(type, name, options) {
super(injectedPropertyGet);
this.type = type;
this.name = name;
+ this.source = options ? o... | true |
Other | emberjs | ember.js | cfaa47e48b0d6badb5e84419f117a46fd2f2ae8e.json | Introduce source to injections
Ember templates use a `source` argument to the container. This hints
where to look for "local lookup", and also what namespace to look in for
a partial specifier. For example a template in an addon's `src` tree can
invoke components and helpers in that tree becuase it has a `source`
argu... | packages/ember-runtime/lib/inject.js | @@ -1,5 +1,7 @@
import { InjectedProperty, descriptorFor } from 'ember-metal';
import { assert } from 'ember-debug';
+import { EMBER_MODULE_UNIFICATION } from 'ember/features';
+
/**
@module ember
*/
@@ -35,7 +37,11 @@ const typeValidators = {};
export function createInjectionHelper(type, validator) {
typeVali... | true |
Other | emberjs | ember.js | cfaa47e48b0d6badb5e84419f117a46fd2f2ae8e.json | Introduce source to injections
Ember templates use a `source` argument to the container. This hints
where to look for "local lookup", and also what namespace to look in for
a partial specifier. For example a template in an addon's `src` tree can
invoke components and helpers in that tree becuase it has a `source`
argu... | packages/ember-runtime/lib/mixins/registry_proxy.js | @@ -2,6 +2,7 @@
@module ember
*/
+import { assert } from 'ember-debug';
import {
Mixin
} from 'ember-metal';
@@ -24,7 +25,10 @@ export default Mixin.create({
@param {String} fullName
@return {Function} fullName's factory
*/
- resolveRegistration: registryAlias('resolve'),
+ resolveRegistration(fu... | true |
Other | emberjs | ember.js | cfaa47e48b0d6badb5e84419f117a46fd2f2ae8e.json | Introduce source to injections
Ember templates use a `source` argument to the container. This hints
where to look for "local lookup", and also what namespace to look in for
a partial specifier. For example a template in an addon's `src` tree can
invoke components and helpers in that tree becuase it has a `source`
argu... | packages/ember-runtime/lib/system/core_object.js | @@ -1020,7 +1020,10 @@ if (DEBUG) {
for (key in proto) {
desc = descriptorFor(proto, key);
if (desc instanceof InjectedProperty) {
- injections[key] = `${desc.type}:${desc.name || key}`;
+ injections[key] = {
+ specifier: `${desc.type}:${desc.name || key}`,
+ source: d... | true |
Other | emberjs | ember.js | cfaa47e48b0d6badb5e84419f117a46fd2f2ae8e.json | Introduce source to injections
Ember templates use a `source` argument to the container. This hints
where to look for "local lookup", and also what namespace to look in for
a partial specifier. For example a template in an addon's `src` tree can
invoke components and helpers in that tree becuase it has a `source`
argu... | packages/ember-runtime/tests/inject_test.js | @@ -61,6 +61,11 @@ if (DEBUG) {
bar: new InjectedProperty('quux')
});
- assert.deepEqual(AnObject._lazyInjections(), { 'foo': 'foo:bar', 'bar': 'quux:bar' }, 'should return injected container keys');
+ assert.deepEqual(
+ AnObject._lazyInjections(),
+ {
+ 'foo': { specifier: 'foo:ba... | true |
Other | emberjs | ember.js | cfaa47e48b0d6badb5e84419f117a46fd2f2ae8e.json | Introduce source to injections
Ember templates use a `source` argument to the container. This hints
where to look for "local lookup", and also what namespace to look in for
a partial specifier. For example a template in an addon's `src` tree can
invoke components and helpers in that tree becuase it has a `source`
argu... | packages/ember/tests/service_injection_test.js | @@ -2,7 +2,7 @@ import { Controller } from 'ember-runtime';
import { moduleFor, ApplicationTestCase } from 'internal-test-helpers';
import { inject, Service } from 'ember-runtime';
import { computed } from 'ember-metal';
-import { EMBER_METAL_ES5_GETTERS } from 'ember/features';
+import { EMBER_METAL_ES5_GETTERS, EM... | true |
Other | emberjs | ember.js | cfaa47e48b0d6badb5e84419f117a46fd2f2ae8e.json | Introduce source to injections
Ember templates use a `source` argument to the container. This hints
where to look for "local lookup", and also what namespace to look in for
a partial specifier. For example a template in an addon's `src` tree can
invoke components and helpers in that tree becuase it has a `source`
argu... | packages/internal-test-helpers/lib/test-resolver.js | @@ -1,6 +1,6 @@
import { compile } from 'ember-template-compiler';
-const DELIMITER = '\0';
+const DELIMITER = '%';
function serializeKey(specifier, source) {
return [specifier, source].join(DELIMITER);
@@ -11,8 +11,19 @@ class Resolver {
this._registered = {};
this.constructor.lastInstance = this;
... | true |
Other | emberjs | ember.js | 8b8ae79a1f78b3be1b39ae500cb9f85f65cfc3f7.json | Set proper moduleName values | packages/ember-glimmer/tests/integration/application/rendering-test.js | @@ -407,7 +407,7 @@ moduleFor('Application test: rendering', class extends ApplicationTest {
template: 'Hi {{person.name}} from component'
});
- let expectedBacktrackingMessage = /modified "model\.name" twice on \[object Object\] in a single render\. It was rendered in "template:routeWithError" and mod... | true |
Other | emberjs | ember.js | 8b8ae79a1f78b3be1b39ae500cb9f85f65cfc3f7.json | Set proper moduleName values | packages/ember-glimmer/tests/integration/components/local-lookup-test.js | @@ -202,14 +202,20 @@ function buildResolver() {
let [sourceType, sourceName ] = sourceFullName.split(':');
let [type, name ] = fullName.split(':');
- if (type !== 'template' && sourceType === 'template' && sourceName.slice(0, 11) === 'components/') {
- sourceName = sourceName.slice(11);
+ ... | true |
Other | emberjs | ember.js | 8b8ae79a1f78b3be1b39ae500cb9f85f65cfc3f7.json | Set proper moduleName values | packages/ember-glimmer/tests/integration/mount-test.js | @@ -64,7 +64,7 @@ moduleFor('{{mount}} test', class extends ApplicationTest {
}
['@test it boots an engine, instantiates its application controller, and renders its application template'](assert) {
- this.engineRegistrations['template:application'] = compile('<h2>Chat here, {{username}}</h2>', { moduleName: ... | true |
Other | emberjs | ember.js | 8b8ae79a1f78b3be1b39ae500cb9f85f65cfc3f7.json | Set proper moduleName values | packages/ember-glimmer/tests/unit/template-factory-test.js | @@ -9,7 +9,7 @@ moduleFor('Template factory test', class extends RenderingTest {
let { runtimeResolver } = this;
let templateStr = 'Hello {{name}}';
- let options = { moduleName: 'some-module' };
+ let options = { moduleName: 'my-app/templates/some-module.hbs' };
let spec = precompile(templateS... | true |
Other | emberjs | ember.js | 8b8ae79a1f78b3be1b39ae500cb9f85f65cfc3f7.json | Set proper moduleName values | packages/ember/tests/integration/multiple-app-test.js | @@ -61,15 +61,15 @@ moduleFor('View Integration', class extends ApplicationTestCase {
this.compile(`
<h1>Node 1</h1>{{special-button}}
`, {
- moduleName: 'index'
+ moduleName: 'my-app/templates/index.hbs'
})
);
resolver.add(
'template:components/special-butto... | true |
Other | emberjs | ember.js | 8b8ae79a1f78b3be1b39ae500cb9f85f65cfc3f7.json | Set proper moduleName values | packages/internal-test-helpers/lib/test-cases/abstract-rendering.js | @@ -98,8 +98,7 @@ export default class AbstractRenderingTestCase extends AbstractTestCase {
registerPartial(name, template) {
let owner = this.env.owner || this.owner;
if (typeof template === 'string') {
- let moduleName = `template:${name}`;
- owner.register(moduleName, this.compile(template, { ... | true |
Other | emberjs | ember.js | 8b8ae79a1f78b3be1b39ae500cb9f85f65cfc3f7.json | Set proper moduleName values | packages/internal-test-helpers/lib/test-cases/test-resolver-application.js | @@ -17,7 +17,7 @@ export default class TestResolverApplicationTestCase extends AbstractApplication
addTemplate(templateName, templateString) {
this.resolver.add(`template:${templateName}`, this.compile(templateString, {
- moduleName: templateName
+ moduleName: `my-app/templates/${templateName}.hbs`
... | true |
Other | emberjs | ember.js | 8b8ae79a1f78b3be1b39ae500cb9f85f65cfc3f7.json | Set proper moduleName values | packages/internal-test-helpers/lib/test-resolver.js | @@ -38,7 +38,7 @@ class Resolver {
throw new Error(`You called addTemplate for "${templateName}" with a template argument of type of '${templateType}'. addTemplate expects an argument of an uncompiled template as a string.`);
}
return this._registered[serializeKey(`template:${templateName}`)] = compile... | true |
Other | emberjs | ember.js | 9c2c2eaf256077203e242d0b3a31b6f27e3962ec.json | Add code sample to `trySet` | packages/ember-metal/lib/property_set.js | @@ -136,6 +136,13 @@ function setPath(root, path, value, tolerant) {
This is primarily used when syncing bindings, which may try to update after
an object has been destroyed.
+
+ ```javascript
+ import { trySet } from '@ember/object';
+
+ let obj = { name: "Zoey" };
+ trySet(obj, "contacts.twitter", "@e... | false |
Other | emberjs | ember.js | 25c2ec05bb9364ad2a489864d4ac80015feb2630.json | Add v3.1.0-beta.3 to CHANGELOG
[ci skip]
(cherry picked from commit 7662c8a700448ed34f4bf7d726cc04b6a2765505) | CHANGELOG.md | @@ -1,5 +1,14 @@
# Ember Changelog
+### v3.1.0-beta.3 (February 26, 2018)
+- [#16271](https://github.com/emberjs/ember.js/pull/16271) [BUGFIX] Fix ChainNode unchaining
+- [#16274](https://github.com/emberjs/ember.js/pull/16274) [BUGFIX] Ensure accessing a "proxy" itself does not error.
+- [#16282](https://github.com... | false |
Other | emberjs | ember.js | 5c6eef38fd59b58e1bf39ef3b8e1fc4e4064ab8f.json | Add failing tests for -addon blueprints with --pod
* helper-addon
* initializer-addon
* instance-initializer-addon | node-tests/blueprints/helper-addon-test.js | @@ -24,5 +24,12 @@ describe('Blueprint: helper-addon', function() {
.to.equal(fixture('helper-addon.js'));
});
});
+
+ it('helper-addon foo/bar-baz --pod', function() {
+ return emberGenerateDestroy(['helper-addon', 'foo/bar-baz', '--pod'], _file => {
+ expect(_file('app/helpers/fo... | true |
Other | emberjs | ember.js | 5c6eef38fd59b58e1bf39ef3b8e1fc4e4064ab8f.json | Add failing tests for -addon blueprints with --pod
* helper-addon
* initializer-addon
* instance-initializer-addon | node-tests/blueprints/initializer-addon-test.js | @@ -22,5 +22,12 @@ describe('Blueprint: initializer-addon', function() {
.to.contain("export { default, initialize } from 'my-addon/initializers/foo';");
});
});
+
+ it('initializer-addon foo --pod', function() {
+ return emberGenerateDestroy(['initializer-addon', 'foo', '--pod'], _file =... | true |
Other | emberjs | ember.js | 5c6eef38fd59b58e1bf39ef3b8e1fc4e4064ab8f.json | Add failing tests for -addon blueprints with --pod
* helper-addon
* initializer-addon
* instance-initializer-addon | node-tests/blueprints/instance-initializer-addon-test.js | @@ -22,5 +22,12 @@ describe('Blueprint: instance-initializer-addon', function() {
.to.contain("export { default, initialize } from 'my-addon/instance-initializers/foo';");
});
});
+
+ it('instance-initializer-addon foo --pod', function() {
+ return emberGenerateDestroy(['instance-initiali... | true |
Other | emberjs | ember.js | 3509c99d6de5201cdb29dc4c267c60ed13f9801c.json | fix(link-to): add id to "inactive loading state" warning
Without an ID, this triggers an assertion with the message "When calling warn you must provide an options hash as the third parameter. options should include an id property." | packages/ember-glimmer/lib/components/link-to.ts | @@ -628,7 +628,9 @@ const LinkComponent = EmberComponent.extend({
if (get(this, 'loading')) {
// tslint:disable-next-line:max-line-length
- warn('This link-to is in an inactive loading state because at least one of its parameters presently has a null/undefined value, or the provided route name is inv... | false |
Other | emberjs | ember.js | 810c2c6a82ce797a6a9f3e397f4796c890e28b6b.json | Improve eachComputedProperty implementation | packages/ember-metal/lib/descriptor.js | @@ -16,6 +16,7 @@ class Descriptor extends EmberDescriptor {
constructor(desc) {
super();
this.desc = desc;
+ this.enumerable = desc.enumerable;
}
setup(obj, key) { | true |
Other | emberjs | ember.js | 810c2c6a82ce797a6a9f3e397f4796c890e28b6b.json | Improve eachComputedProperty implementation | packages/ember-metal/lib/index.js | @@ -72,8 +72,7 @@ export {
} from './property_events';
export {
defineProperty,
- Descriptor,
- _hasCachedComputedProperties
+ Descriptor
} from './properties';
export {
watchKey, | true |
Other | emberjs | ember.js | 810c2c6a82ce797a6a9f3e397f4796c890e28b6b.json | Improve eachComputedProperty implementation | packages/ember-metal/lib/meta.js | @@ -446,6 +446,27 @@ if (EMBER_METAL_ES5_GETTERS) {
Meta.prototype.removeDescriptors = function(subkey) {
this.writeDescriptors(subkey, UNDEFINED);
};
+
+ Meta.prototype.forEachDescriptors = function(fn) {
+ let pointer = this;
+ let seen;
+ while (pointer !== undefined) {
+ let map = pointer.... | true |
Other | emberjs | ember.js | 810c2c6a82ce797a6a9f3e397f4796c890e28b6b.json | Improve eachComputedProperty implementation | packages/ember-metal/lib/properties.js | @@ -7,7 +7,6 @@ import { HAS_NATIVE_PROXY } from 'ember-utils';
import { descriptorFor, meta as metaFor, peekMeta, DESCRIPTOR, UNDEFINED } from './meta';
import { overrideChains } from './property_events';
import { DESCRIPTOR_TRAP, EMBER_METAL_ES5_GETTERS, MANDATORY_SETTER } from 'ember/features';
-import { peekCach... | true |
Other | emberjs | ember.js | 810c2c6a82ce797a6a9f3e397f4796c890e28b6b.json | Improve eachComputedProperty implementation | packages/ember-runtime/lib/system/core_object.js | @@ -18,7 +18,6 @@ import {
import {
PROXY_CONTENT,
descriptorFor,
- get,
meta,
peekMeta,
finishChains,
@@ -27,12 +26,10 @@ import {
REQUIRED,
defineProperty,
ComputedProperty,
- computed,
InjectedProperty,
run,
deleteMeta,
- descriptor,
- _hasCachedComputedProperties
+ descriptor
... | true |
Other | emberjs | ember.js | 810c2c6a82ce797a6a9f3e397f4796c890e28b6b.json | Improve eachComputedProperty implementation | packages/ember-runtime/tests/system/object/computed_test.js | @@ -2,7 +2,8 @@ import {
alias,
computed,
get as emberGet,
- observer
+ observer,
+ defineProperty
} from 'ember-metal';
import { testWithDefault } from 'internal-test-helpers';
import EmberObject from '../../../system/object';
@@ -149,6 +150,26 @@ QUnit.test('can retrieve metadata for a computed propert... | true |
Other | emberjs | ember.js | c6386c043f1c8aafc858f1990da51b1b041c1ff1.json | Remove unnecessary runTask | packages/ember-application/tests/system/visit_test.js | @@ -68,34 +68,32 @@ moduleFor('Application - visit()', class extends ApplicationTestCase {
ENV._APPLICATION_TEMPLATE_WRAPPER = false;
- return this.runTask(() => {
- return this.visit('/', bootOptions)
- .then((instance) => {
+ return this.visit('/', bootOptions)
+ .then((instance) => {
... | false |
Other | emberjs | ember.js | 0627ae68cbbfbc7179f39ad0ed7eee670d5f371a.json | update serialized format to new glimmer-vm output
This is meant to be a temporary test. Want a more robust test that
doesn't rely on the actual serialization format of glimmer's serializer
builder | packages/ember-application/tests/system/visit_test.js | @@ -55,7 +55,7 @@ moduleFor('Application - visit()', class extends ApplicationTestCase {
[`@test _renderMode: rehydrate`](assert) {
- let initialHTML = `<!--%+block:0%--><!--%+block:1%--><!--%+block:2%--><!--%+block:3%--><!--%+block:4%--><!--%+block:5%--><!--%+block:6%--><div class=\"foo\">Hi, Mom!</div><!--%... | false |
Other | emberjs | ember.js | 882bbdd5df177fa4c9690679d91774e80bfbc269.json | Ensure correct signature for renderMain | packages/ember-glimmer/lib/renderer.ts | @@ -105,7 +105,7 @@ class RootState {
env,
self,
dynamicScope,
- builder: builder(env, { element: parentElement, nextSibling: null}),
+ builder(env, { element: parentElement, nextSibling: null }),
handle
);
let iteratorResult: IteratorResult<RenderResult>; | false |
Other | emberjs | ember.js | 45b9f15b874068f2e8d6c8789602e697942c0f40.json | Convert Descriptor and Alias to native classes | packages/ember-metal/lib/mixin.js | @@ -656,13 +656,13 @@ export function required() {
return REQUIRED;
}
-function Alias(methodName) {
- this.isDescriptor = true;
- this.methodName = methodName;
+class Alias extends Descriptor {
+ constructor(methodName) {
+ super();
+ this.methodName = methodName;
+ }
}
-Alias.prototype = new Descrip... | true |
Other | emberjs | ember.js | 45b9f15b874068f2e8d6c8789602e697942c0f40.json | Convert Descriptor and Alias to native classes | packages/ember-metal/lib/properties.js | @@ -19,8 +19,10 @@ import { peekCacheFor } from './computed';
@class Descriptor
@private
*/
-export function Descriptor() {
- this.isDescriptor = true;
+export class Descriptor {
+ constructor() {
+ this.isDescriptor = true;
+ }
}
// .......................................................... | true |
Other | emberjs | ember.js | 455c4c44410f55c2d77258934d903dcd3328782e.json | Add v3.1.0-beta.2 to CHANGELOG
[ci skip]
(cherry picked from commit 0f8e2f4d823c590a76e0158960a8b05aeb5f64e1) | CHANGELOG.md | @@ -1,5 +1,11 @@
# Ember Changelog
+### v3.1.0-beta.2 (February 19, 2018)
+
+- [#13355](https://github.com/emberjs/ember.js/pull/13355) [BUGFIX] Fix issue with `Ember.trySet` on destroyed objects.
+- [#16245](https://github.com/emberjs/ember.js/pull/16245) [BUGFIX] Ensure errors in deferred component hooks can be re... | false |
Other | emberjs | ember.js | 6e01000e4002910ddc966de07714323c101b95af.json | Remove Ember global from ember-glimmer loc tests | packages/ember-glimmer/tests/integration/helpers/loc-test.js | @@ -1,21 +1,20 @@
import { RenderingTest, moduleFor } from '../../utils/test-case';
import { set } from 'ember-metal';
-import Ember from 'ember';
+import { setStrings } from 'ember-runtime';
moduleFor('Helpers test: {{loc}}', class extends RenderingTest {
constructor() {
super();
- this.oldString = E... | false |
Other | emberjs | ember.js | 52c48d08158857329e8bdd52873fefca32780057.json | Remove custom manager test | packages/ember-glimmer/tests/integration/custom-component-manager-test.js | @@ -1,41 +0,0 @@
-import { moduleFor, RenderingTest } from '../utils/test-case';
-import {
- GLIMMER_CUSTOM_COMPONENT_MANAGER
-} from 'ember/features';
-import { AbstractComponentManager } from 'ember-glimmer';
-
-if (GLIMMER_CUSTOM_COMPONENT_MANAGER) {
- /*
- Implementation of custom component manager, `Component... | false |
Other | emberjs | ember.js | b3786610acdad73be20092876bf60f0b17af83c3.json | Add v3.1.0-beta.1 to CHANGELOG.md. | CHANGELOG.md | @@ -1,5 +1,14 @@
# Ember Changelog
+### v3.1.0-beta.1 (February 14, 2018)
+
+- [emberjs/rfcs#276](https://github.com/emberjs/rfcs/blob/master/text/0276-named-args.md) [FEATURE named-args] enabled by default.
+- [emberjs/rfcs#278](https://github.com/emberjs/rfcs/blob/master/text/0278-template-only-components.md) [FEA... | false |
Other | emberjs | ember.js | 080ba6643251209dd7f88974955aae5848bdc8e2.json | Add v3.0.0 to CHANGELOG.md. | CHANGELOG.md | @@ -1,16 +1,12 @@
# Ember Changelog
-### 3.0.0-beta.6 (February 5, 2018)
+### v3.0.0 (February 13, 2018)
+- [#16218](https://github.com/emberjs/ember.js/pull/16218) [BUGFIX beta] Prevent errors when using const `(get arr 1)`.
+- [#16241](https://github.com/emberjs/ember.js/pull/16241) [BUGFIX lts] Avoid excessivel... | false |
Other | emberjs | ember.js | 8222f4eafd2a1ff305cb1e465b359badb77097fb.json | Add v2.18.1 to CHANGELOG.md. | CHANGELOG.md | @@ -77,6 +77,11 @@
- [#16036](https://github.com/emberjs/ember.js/pull/16036) [CLEANUP] Convert ember-metal accessors tests to new style
- [#16023](https://github.com/emberjs/ember.js/pull/16023) Make event dispatcher work without jQuery
+### 2.18.1 (February 13, 2018)
+
+- [#16174](https://github.com/emberjs/ember... | false |
Other | emberjs | ember.js | 5112d7a4443670dbf965432540a468dc59b4e850.json | Add v2.17.1 to CHANGELOG.md
(cherry picked from commit 6e0b9fdec1b500050e117744e3d7216d21833833) | CHANGELOG.md | @@ -91,6 +91,11 @@
- [#14590](https://github.com/emberjs/ember.js/pull/14590) [DEPRECATION] Deprecate using `targetObject`.
- [#15754](https://github.com/emberjs/ember.js/pull/15754) [CLEANUP] Remove `router.router` deprecation.
+### 2.17.1 (February 13, 2018)
+
+- [#16174](https://github.com/emberjs/ember.js/pull/... | false |
Other | emberjs | ember.js | 85c78893f5ae84a8587755faa9f8c2d9073298c9.json | Add v2.16.2 to CHANGELOG.md. | CHANGELOG.md | @@ -114,6 +114,13 @@
- [#15265](https://github.com/emberjs/ember.js/pull/15265) [BUGFIX] fixed issue when passing `false` to `activeClass` for `{{link-to}}`
- [#15672](https://github.com/emberjs/ember.js/pull/15672) Update router_js to 2.0.0.
+### 2.16.3 (February 13, 2018)
+
+- [#15927](https://github.com/emberjs/... | false |
Other | emberjs | ember.js | 35889593cb05d8934413be96efa31a375fd0b4e3.json | Add referrer capability to the test resolver | packages/container/tests/registry_test.js | @@ -1,5 +1,10 @@
import { Registry, privatize } from '..';
-import { factory, moduleFor, AbstractTestCase } from 'internal-test-helpers';
+import {
+ factory,
+ moduleFor,
+ AbstractTestCase,
+ ModuleBasedTestResolver
+} from 'internal-test-helpers';
import { EMBER_MODULE_UNIFICATION } from 'ember/features';
imp... | true |
Other | emberjs | ember.js | 35889593cb05d8934413be96efa31a375fd0b4e3.json | Add referrer capability to the test resolver | packages/internal-test-helpers/lib/test-resolver.js | @@ -1,25 +1,43 @@
import { compile } from 'ember-template-compiler';
+const DELIMITER = '\0';
+
+function serializeKey(specifier, source) {
+ return [specifier, source].join(DELIMITER);
+}
+
class Resolver {
constructor() {
this._registered = {};
this.constructor.lastInstance = this;
}
- resolve(s... | true |
Other | emberjs | ember.js | 7c4e925553ac3a0bdfcc14ba44d19c5719ab6c95.json | Fix failing tests | packages/ember-runtime/tests/helpers/array.js | @@ -49,9 +49,8 @@ const ArrayTestsObserverClass = EmberObject.extend({
return this;
},
- observe(obj) {
+ observe(obj, ...keys) {
if (obj.addObserver) {
- let keys = Array.prototype.slice.call(arguments, 1);
let loc = keys.length;
while (--loc >= 0) { | true |
Other | emberjs | ember.js | 7c4e925553ac3a0bdfcc14ba44d19c5719ab6c95.json | Fix failing tests | packages/ember-runtime/tests/mutable-array/unshiftObjects-test.js | @@ -70,7 +70,7 @@ class UnshiftObjectsTests extends AbstractTestCase {
this.assert.equal(observer.timesCalled('@each'), 0, 'should not have notified @each once');
this.assert.equal(observer.timesCalled('length'), 1, 'should have notified length once');
- this.assert.equal(observer.validate('firstObject')... | true |
Other | emberjs | ember.js | 30702be41b358b5cb8e65f3c66bb484342003d56.json | Kill Array Suites | packages/ember-runtime/tests/mixins/array_test.js | @@ -7,7 +7,6 @@ import {
computed
} from 'ember-metal';
import { testBoth } from 'internal-test-helpers';
-import { ArrayTests } from '../suites/array';
import EmberObject from '../../system/object';
import EmberArray, {
addArrayObserver,
@@ -53,26 +52,7 @@ const TestArray = EmberObject.extend(EmberArray, {
... | true |
Other | emberjs | ember.js | 30702be41b358b5cb8e65f3c66bb484342003d56.json | Kill Array Suites | packages/ember-runtime/tests/mixins/copyable_test.js | @@ -1,39 +0,0 @@
-import { generateGuid } from 'ember-utils';
-import CopyableTests from '../suites/copyable';
-import Copyable from '../../mixins/copyable';
-import EmberObject from '../../system/object';
-import { set, get } from 'ember-metal';
-
-QUnit.module('Ember.Copyable');
-
-const CopyableObject = EmberObject.... | true |
Other | emberjs | ember.js | 30702be41b358b5cb8e65f3c66bb484342003d56.json | Kill Array Suites | packages/ember-runtime/tests/mixins/mutable_array_test.js | @@ -1,69 +0,0 @@
-import { computed } from 'ember-metal';
-import MutableArrayTests from '../suites/mutable_array';
-import EmberObject from '../../system/object';
-import { A as emberA, MutableArray } from '../../mixins/array';
-import {
- arrayContentDidChange,
- arrayContentWillChange
-} from '../../mixins/array';... | true |
Other | emberjs | ember.js | 30702be41b358b5cb8e65f3c66bb484342003d56.json | Kill Array Suites | packages/ember-runtime/tests/suites/array.js | @@ -1,204 +0,0 @@
-import { guidFor, generateGuid } from 'ember-utils';
-import { Suite } from './suite';
-import { computed, get } from 'ember-metal';
-import {
- addArrayObserver,
- removeArrayObserver
-} from '../../mixins/array';
-import EmberObject from '../../system/object';
-
-const ArrayTestsObserverClass = E... | true |
Other | emberjs | ember.js | 30702be41b358b5cb8e65f3c66bb484342003d56.json | Kill Array Suites | packages/ember-runtime/tests/suites/copyable.js | @@ -1,32 +0,0 @@
-import { Suite } from './suite';
-
-const CopyableTests = Suite.extend({
-
- /*
- __Required.__ You must implement this method to apply this mixin.
-
- Must be able to create a new object for testing.
-
- @returns {Object} object
- */
- newObject: null,
-
- /*
- __Required.__ You must ... | true |
Other | emberjs | ember.js | 30702be41b358b5cb8e65f3c66bb484342003d56.json | Kill Array Suites | packages/ember-runtime/tests/suites/mutable_array.js | @@ -1,5 +0,0 @@
-import { ArrayTests } from './array';
-
-const MutableArrayTests = ArrayTests.extend();
-
-export default MutableArrayTests; | true |
Other | emberjs | ember.js | 30702be41b358b5cb8e65f3c66bb484342003d56.json | Kill Array Suites | packages/ember-runtime/tests/suites/suite.js | @@ -1,143 +0,0 @@
-import { guidFor } from 'ember-utils';
-import EmberObject from '../../system/object';
-import { get } from 'ember-metal';
-
-/*
- @class
- A Suite can be used to define a reusable set of unit tests that can be
- applied to any object. Suites are most useful for defining tests that
- work agains... | true |
Other | emberjs | ember.js | 30702be41b358b5cb8e65f3c66bb484342003d56.json | Kill Array Suites | packages/ember-runtime/tests/system/array_proxy/suite_test.js | @@ -1,21 +0,0 @@
-import MutableArrayTests from '../../suites/mutable_array';
-import ArrayProxy from '../../../system/array_proxy';
-import { get } from 'ember-metal';
-import { A as emberA } from '../../../mixins/array';
-
-MutableArrayTests.extend({
- name: 'Ember.ArrayProxy',
-
- newObject(ary) {
- let ret = a... | true |
Other | emberjs | ember.js | 30702be41b358b5cb8e65f3c66bb484342003d56.json | Kill Array Suites | packages/ember-runtime/tests/system/native_array/copyable_suite_test.js | @@ -1,31 +1,4 @@
-import { generateGuid } from 'ember-utils';
import { A as emberA } from '../../../mixins/array';
-import CopyableTests from '../../suites/copyable';
-
-CopyableTests.extend({
- name: 'NativeArray Copyable',
-
- newObject() {
- return emberA([generateGuid()]);
- },
-
- isEqual(a, b) {
- if (... | true |
Other | emberjs | ember.js | 30702be41b358b5cb8e65f3c66bb484342003d56.json | Kill Array Suites | packages/ember-runtime/tests/system/native_array/suite_test.js | @@ -1,18 +0,0 @@
-import { A as emberA } from '../../../mixins/array';
-import MutableArrayTests from '../../suites/mutable_array';
-
-MutableArrayTests.extend({
- name: 'Native Array',
-
- newObject(ary) {
- return emberA(ary ? ary.slice() : this.newFixture(3));
- },
-
- mutate(obj) {
- obj.pushObject(obj.le... | true |
Other | emberjs | ember.js | 235193ef315cf2351e942da277b3d3ace245a400.json | Get new infra in place | packages/ember-runtime/tests/mixins/array_test.js | @@ -56,7 +56,7 @@ const TestArray = EmberObject.extend(EmberArray, {
ArrayTests.extend({
- name: 'Basic Mutable Array',
+ name: 'Basic Ember Array',
newObject(ary) {
ary = ary ? ary.slice() : this.newFixture(3); | true |
Other | emberjs | ember.js | 235193ef315cf2351e942da277b3d3ace245a400.json | Get new infra in place | packages/ember-runtime/tests/suites/array.js | @@ -201,7 +201,7 @@ const ArrayTests = Suite.extend({
observerClass: ArrayTestsObserverClass
});
-import anyTests from './array/any';
+// import './array/any';
import compactTests from './array/compact';
import everyTests from './array/every';
import filterTests from './array/filter';
@@ -225,7 +225,7 @@ impor... | true |
Other | emberjs | ember.js | 235193ef315cf2351e942da277b3d3ace245a400.json | Get new infra in place | packages/ember-runtime/tests/suites/array/any.js | @@ -1,67 +1,167 @@
-import { SuiteModuleBuilder } from '../suite';
+// import { SuiteModuleBuilder } from '../suite';
import { A as emberA } from '../../../mixins/array';
+import { get } from 'ember-metal';
+import { AbstractTestCase, moduleFor } from 'internal-test-helpers';
+import { generateGuid } from 'ember-utils... | true |
Other | emberjs | ember.js | 235193ef315cf2351e942da277b3d3ace245a400.json | Get new infra in place | packages/internal-test-helpers/lib/apply-mixins.js | @@ -15,11 +15,17 @@ export default function applyMixins(TestClass, ...mixins) {
generator.cases.forEach((value, idx) => {
assign(mixin, generator.generate(value, idx));
});
+
+ assign(TestClass.prototype, mixin);
+ } else if (typeof mixinOrGenerator === 'function') {
+ mixin = new mi... | true |
Other | emberjs | ember.js | 235193ef315cf2351e942da277b3d3ace245a400.json | Get new infra in place | packages/internal-test-helpers/lib/module-for.js | @@ -38,7 +38,9 @@ export default function moduleFor(description, TestClass, ...mixins) {
}
});
- applyMixins(TestClass, mixins);
+ if (mixins.length > 0) {
+ applyMixins(TestClass, ...mixins);
+ }
let proto = TestClass.prototype;
| true |
Other | emberjs | ember.js | 93080b5879d02412b737eacaaf25e0f0d8e7db9e.json | Update semver regex to support uppercase branches
Having an uppercase character within your git branch name would
cause the regex to fail. Updating the regex to support this use
case. | packages/ember-metal/tests/main_test.js | @@ -1,7 +1,7 @@
import Ember from '..'; // testing reexports
-// From sindresourhus/semver-regex https://github.com/sindresorhus/semver-regex/blob/795b05628d96597ebcbe6d31ef4a432858365582/index.js#L3
-const SEMVER_REGEX = /^\bv?(?:0|[1-9][0-9]*)\.(?:0|[1-9][0-9]*)\.(?:0|[1-9][0-9]*)(?:-[\da-z\-]+(?:\.[\da-z\-]+)*)?(... | false |
Other | emberjs | ember.js | bb506f48135df05450e97fe34ce04a627dd3004c.json | Move TestAdapter tests into ember-testing | packages/ember-testing/lib/index.js | @@ -1,6 +1,5 @@
export { default as Test } from './test';
export { default as Adapter } from './adapters/adapter';
-export { setAdapter, getAdapter } from './test/adapter';
export { default as setupForTesting } from './setup_for_testing';
export { default as QUnitAdapter } from './adapters/qunit';
| true |
Other | emberjs | ember.js | bb506f48135df05450e97fe34ce04a627dd3004c.json | Move TestAdapter tests into ember-testing | packages/ember-testing/tests/adapters_test.js | @@ -1,13 +1,26 @@
-import { run } from 'ember-metal';
+import { run, setOnerror } from 'ember-metal';
import Test from '../test';
import Adapter from '../adapters/adapter';
import QUnitAdapter from '../adapters/qunit';
import { Application as EmberApplication } from 'ember-application';
import { moduleFor, Abstrac... | true |
Other | emberjs | ember.js | bb506f48135df05450e97fe34ce04a627dd3004c.json | Move TestAdapter tests into ember-testing | packages/ember/tests/error_handler_test.js | @@ -1,21 +1,12 @@
import { isTesting, setTesting } from 'ember-debug';
import { run, getOnerror, setOnerror } from 'ember-metal';
-import { DEBUG } from 'ember-env-flags';
import RSVP from 'rsvp';
-import require, { has } from 'require';
let WINDOW_ONERROR;
-let setAdapter;
-let QUnitAdapter;
QUnit.module('e... | true |
Other | emberjs | ember.js | 253556651d74fd0bd5c5a50d0abb6bcd20bf9028.json | Remove Ember global usage when testing onError | packages/ember-testing/lib/index.js | @@ -1,5 +1,6 @@
export { default as Test } from './test';
export { default as Adapter } from './adapters/adapter';
+export { setAdapter, getAdapter } from './test/adapter';
export { default as setupForTesting } from './setup_for_testing';
export { default as QUnitAdapter } from './adapters/qunit';
| true |
Other | emberjs | ember.js | 253556651d74fd0bd5c5a50d0abb6bcd20bf9028.json | Remove Ember global usage when testing onError | packages/ember/tests/error_handler_test.js | @@ -1,28 +1,36 @@
-import Ember from 'ember';
-import { run } from 'ember-metal';
+import { isTesting, setTesting } from 'ember-debug';
+import { run, getOnerror, setOnerror } from 'ember-metal';
import { DEBUG } from 'ember-env-flags';
import RSVP from 'rsvp';
-
-const ONERROR = Ember.onerror;
-const ADAPTER = Ember... | true |
Other | emberjs | ember.js | 507196da7be456628202e93525a30e13a2cc9a1d.json | Remove Ember from NameSpace list | packages/ember-extension-support/lib/container_debug_adapter.js | @@ -87,14 +87,12 @@ export default EmberObject.extend({
let typeSuffixRegex = new RegExp(`${StringUtils.classify(type)}$`);
namespaces.forEach(namespace => {
- if (namespace.toString() !== 'Ember') {
- for (let key in namespace) {
- if (!namespace.hasOwnProperty(key)) { continue; }
- ... | true |
Other | emberjs | ember.js | 507196da7be456628202e93525a30e13a2cc9a1d.json | Remove Ember from NameSpace list | packages/ember-runtime/lib/system/namespace.js | @@ -2,7 +2,7 @@
@module ember
*/
import { guidFor } from 'ember-utils';
-import Ember, {
+import {
get,
Mixin,
hasUnprocessedMixins,
@@ -74,10 +74,8 @@ const Namespace = EmberObject.extend({
});
Namespace.reopenClass({
- NAMESPACES: [Ember],
- NAMESPACES_BY_ID: {
- Ember
- },
+ NAMESPACES: [],
+ ... | true |
Other | emberjs | ember.js | 6eb4b1d0d330d75a3f72f6253cacad4a82259a11.json | Expose meta counters (privately).
Various counters are being tracked around meta usage (how many
instantiated, how many prototype walks, etc) but this data is not
exposed (even privately) at the moment.
This PR updates `Ember.meta` to tack on `Ember.meta._counters` which
exposes the counters object in debug builds on... | packages/ember-metal/lib/meta.js | @@ -563,6 +563,10 @@ export function meta(obj) {
return newMeta;
}
+if (DEBUG) {
+ meta._counters = counters;
+}
+
// Using `symbol()` here causes some node test to fail, presumably
// because we define the CP with one copy of Ember and boot the app
// with a different copy, so the random key we generate do n... | false |
Other | emberjs | ember.js | 7f3f3872f23871f134006836bf1c531a94186f86.json | Move computed property caches into a weak map | packages/ember-metal/lib/alias.js | @@ -6,7 +6,7 @@ import {
Descriptor,
defineProperty
} from './properties';
-import { ComputedProperty } from './computed';
+import { ComputedProperty, getCacheFor } from './computed';
import { meta as metaFor } from './meta';
import {
addDependentKeys,
@@ -52,9 +52,9 @@ export class AliasedProperty extends ... | true |
Other | emberjs | ember.js | 7f3f3872f23871f134006836bf1c531a94186f86.json | Move computed property caches into a weak map | packages/ember-metal/lib/chains.js | @@ -1,7 +1,7 @@
import { get } from './property_get';
import { descriptorFor, meta as metaFor, peekMeta } from './meta';
import { watchKey, unwatchKey } from './watch_key';
-import { cacheFor } from './computed';
+import { getCachedValueFor } from './computed';
import { eachProxyFor } from './each_proxy';
const ... | true |
Other | emberjs | ember.js | 7f3f3872f23871f134006836bf1c531a94186f86.json | Move computed property caches into a weak map | packages/ember-metal/lib/computed.js | @@ -1,7 +1,7 @@
import { inspect } from 'ember-utils';
import { assert, warn, Error as EmberError } from 'ember-debug';
import { set } from './property_set';
-import { meta as metaFor, peekMeta, UNDEFINED } from './meta';
+import { meta as metaFor, peekMeta } from './meta';
import expandProperties from './expand_pr... | true |
Other | emberjs | ember.js | 7f3f3872f23871f134006836bf1c531a94186f86.json | Move computed property caches into a weak map | packages/ember-metal/lib/index.js | @@ -2,7 +2,9 @@
export { default } from './core'; // reexports
export {
default as computed,
- cacheFor,
+ getCacheFor,
+ getCachedValueFor,
+ peekCacheFor,
ComputedProperty
} from './computed';
export { default as alias } from './alias'; | true |
Other | emberjs | ember.js | 7f3f3872f23871f134006836bf1c531a94186f86.json | Move computed property caches into a weak map | packages/ember-metal/lib/meta.js | @@ -45,8 +45,6 @@ export class Meta {
counters.metaInstantiated++;
}
- this._cache = undefined;
-
if (EMBER_METAL_ES5_GETTERS) {
this._descriptors = undefined;
}
@@ -266,9 +264,6 @@ export class Meta {
}
}
- writableCache() { return this._getOrCreateOwnMap('_cache'); }
- re... | true |
Other | emberjs | ember.js | 7f3f3872f23871f134006836bf1c531a94186f86.json | Move computed property caches into a weak map | packages/ember-metal/lib/properties.js | @@ -7,6 +7,7 @@ import { HAS_NATIVE_PROXY } from 'ember-utils';
import { descriptorFor, meta as metaFor, peekMeta, DESCRIPTOR, UNDEFINED } from './meta';
import { overrideChains } from './property_events';
import { DESCRIPTOR_TRAP, EMBER_METAL_ES5_GETTERS, MANDATORY_SETTER } from 'ember/features';
+import { peekCach... | true |
Other | emberjs | ember.js | 7f3f3872f23871f134006836bf1c531a94186f86.json | Move computed property caches into a weak map | packages/ember-metal/tests/computed_test.js | @@ -4,7 +4,7 @@ import { testBoth } from 'internal-test-helpers';
import {
ComputedProperty,
computed,
- cacheFor,
+ getCachedValueFor,
Descriptor,
defineProperty,
get,
@@ -316,24 +316,24 @@ testBoth('inherited property should not pick up cache', function(get, set, asser
assert.equal(get(objB, 'foo... | true |
Other | emberjs | ember.js | 7f3f3872f23871f134006836bf1c531a94186f86.json | Move computed property caches into a weak map | packages/ember-metal/tests/observer_test.js | @@ -6,7 +6,7 @@ import {
notifyPropertyChange,
defineProperty,
computed,
- cacheFor,
+ getCachedValueFor,
Mixin,
mixin,
observer,
@@ -484,7 +484,7 @@ testBoth('depending on a chain with a computed property', function(get, set, ass
changed++;
});
- assert.equal(cacheFor(obj, 'computed'), u... | true |
Other | emberjs | ember.js | 7f3f3872f23871f134006836bf1c531a94186f86.json | Move computed property caches into a weak map | packages/ember-runtime/lib/mixins/array.js | @@ -22,7 +22,8 @@ import {
eachProxyArrayWillChange,
eachProxyArrayDidChange,
beginPropertyChanges,
- endPropertyChanges
+ endPropertyChanges,
+ peekCacheFor
} from 'ember-metal';
import { assert, deprecate } from 'ember-debug';
import Enumerable from './enumerable';
@@ -105,7 +106,7 @@ export function a... | true |
Other | emberjs | ember.js | 7f3f3872f23871f134006836bf1c531a94186f86.json | Move computed property caches into a weak map | packages/ember-runtime/lib/mixins/observable.js | @@ -17,7 +17,7 @@ import {
endPropertyChanges,
addObserver,
removeObserver,
- cacheFor,
+ getCachedValueFor,
isNone
} from 'ember-metal';
import { assert } from 'ember-debug';
@@ -476,6 +476,6 @@ export default Mixin.create({
@public
*/
cacheFor(keyName) {
- return cacheFor(this, keyName);... | true |
Other | emberjs | ember.js | 7f3f3872f23871f134006836bf1c531a94186f86.json | Move computed property caches into a weak map | packages/ember/lib/index.js | @@ -40,7 +40,7 @@ const computed = metal.computed;
computed.alias = metal.alias;
Ember.computed = computed;
Ember.ComputedProperty = metal.ComputedProperty;
-Ember.cacheFor = metal.cacheFor;
+Ember.cacheFor = metal.getCachedValueFor;
Ember.assert = EmberDebug.assert;
Ember.warn = EmberDebug.warn; | true |
Other | emberjs | ember.js | 7f3f3872f23871f134006836bf1c531a94186f86.json | Move computed property caches into a weak map | packages/ember/tests/reexports_test.js | @@ -40,7 +40,7 @@ let allExports =[
['computed', 'ember-metal'],
['computed.alias', 'ember-metal', 'alias'],
['ComputedProperty', 'ember-metal'],
- ['cacheFor', 'ember-metal'],
+ ['cacheFor', 'ember-metal', 'getCachedValueFor'],
['merge', 'ember-metal'],
['instrument', 'ember-metal'],
['Instrumentat... | true |
Other | emberjs | ember.js | 00a74888f7776f3808534d6a2a3af5dc9c6d5b98.json | Move each proxies into a weak map | packages/ember-metal/lib/chains.js | @@ -2,6 +2,7 @@ import { get } from './property_get';
import { descriptorFor, meta as metaFor, peekMeta } from './meta';
import { watchKey, unwatchKey } from './watch_key';
import { cacheFor } from './computed';
+import { eachProxyFor } from './each_proxy';
const FIRST_KEY = /^([^\.]+)/;
@@ -326,7 +327,9 @@ fun... | true |
Other | emberjs | ember.js | 00a74888f7776f3808534d6a2a3af5dc9c6d5b98.json | Move each proxies into a weak map | packages/ember-metal/lib/each_proxy.js | @@ -0,0 +1,131 @@
+import { assert } from 'ember-debug';
+import { get } from './property_get';
+import { notifyPropertyChange } from './property_events';
+import { addObserver, removeObserver } from './observer';
+import { meta, peekMeta } from './meta';
+import { objectAt } from './array';
+
+const EACH_PROXIES = new... | true |
Other | emberjs | ember.js | 00a74888f7776f3808534d6a2a3af5dc9c6d5b98.json | Move each proxies into a weak map | packages/ember-metal/lib/index.js | @@ -40,6 +40,11 @@ export {
trySet
} from './property_set';
export { objectAt } from './array';
+export {
+ eachProxyFor,
+ eachProxyArrayWillChange,
+ eachProxyArrayDidChange
+} from './each_proxy';
export {
addListener,
hasListeners, | true |
Other | emberjs | ember.js | 00a74888f7776f3808534d6a2a3af5dc9c6d5b98.json | Move each proxies into a weak map | packages/ember-runtime/lib/mixins/array.js | @@ -17,14 +17,14 @@ import {
removeListener,
sendEvent,
hasListeners,
- addObserver,
- removeObserver,
- meta,
peekMeta,
+ eachProxyFor,
+ eachProxyArrayWillChange,
+ eachProxyArrayDidChange,
beginPropertyChanges,
endPropertyChanges
} from 'ember-metal';
-import { assert } from 'ember-debug';
+... | true |
Other | emberjs | ember.js | 00a74888f7776f3808534d6a2a3af5dc9c6d5b98.json | Move each proxies into a weak map | packages/ember-runtime/lib/system/core_object.js | @@ -101,7 +101,6 @@ function makeCtor() {
property === 'willWatchProperty' ||
property === 'didUnwatchProperty' ||
property === 'didAddListener' ||
- property === '__each' ||
property in target
) {
return Reflect.get(ta... | true |
Other | emberjs | ember.js | 00a74888f7776f3808534d6a2a3af5dc9c6d5b98.json | Move each proxies into a weak map | packages/ember-runtime/tests/mixins/array_test.js | @@ -288,6 +288,14 @@ QUnit.test('adding an object should notify (@each.isDone)', function(assert) {
assert.equal(called, 1, 'calls observer when object is pushed');
});
+QUnit.test('getting @each is deprecated', function(assert) {
+ assert.expect(1);
+
+ expectDeprecation(() => {
+ get(ary, '@each');
+ }, /... | true |
Other | emberjs | ember.js | daa39359c2b3811d7053e2162a5717dcf40b04a1.json | Move objectAt to ember-metal
... and fix some tests that should ahve been testing the
method version of objectAt. | packages/ember-extension-support/lib/data_adapter.js | @@ -1,13 +1,12 @@
import { getOwner } from 'ember-utils';
-import { get, run } from 'ember-metal';
+import { get, run, objectAt } from 'ember-metal';
import {
String as StringUtils,
Namespace,
Object as EmberObject,
A as emberA,
addArrayObserver,
- removeArrayObserver,
- objectAt
+ removeArrayObserv... | true |
Other | emberjs | ember.js | daa39359c2b3811d7053e2162a5717dcf40b04a1.json | Move objectAt to ember-metal
... and fix some tests that should ahve been testing the
method version of objectAt. | packages/ember-glimmer/lib/utils/iterable.ts | @@ -6,11 +6,16 @@ import {
UpdatableTag,
} from '@glimmer/reference';
import { Opaque } from '@glimmer/util';
-import { get, isProxy, tagFor, tagForProperty } from 'ember-metal';
import {
- _contentFor,
- isEmberArray,
+ get,
+ isProxy,
objectAt,
+ tagFor,
+ tagForProperty
+} from 'ember-metal';
+import ... | true |
Other | emberjs | ember.js | daa39359c2b3811d7053e2162a5717dcf40b04a1.json | Move objectAt to ember-metal
... and fix some tests that should ahve been testing the
method version of objectAt. | packages/ember-metal/lib/array.js | @@ -0,0 +1,7 @@
+export function objectAt(content, idx) {
+ if (typeof content.objectAt === 'function') {
+ return content.objectAt(idx);
+ } else {
+ return content[idx];
+ }
+} | true |
Other | emberjs | ember.js | daa39359c2b3811d7053e2162a5717dcf40b04a1.json | Move objectAt to ember-metal
... and fix some tests that should ahve been testing the
method version of objectAt. | packages/ember-metal/lib/index.d.ts | @@ -33,6 +33,8 @@ export function get(obj: any, keyName: string): any;
export function set(obj: any, keyName: string, value: any, tolerant?: boolean): void;
+export function objectAt(arr: any, i: number): any;
+
export function computed(...args: Array<any>): any;
export function didRender(object: any, key: str... | true |
Other | emberjs | ember.js | daa39359c2b3811d7053e2162a5717dcf40b04a1.json | Move objectAt to ember-metal
... and fix some tests that should ahve been testing the
method version of objectAt. | packages/ember-metal/lib/index.js | @@ -39,6 +39,7 @@ export {
set,
trySet
} from './property_set';
+export { objectAt } from './array';
export {
addListener,
hasListeners, | true |
Other | emberjs | ember.js | daa39359c2b3811d7053e2162a5717dcf40b04a1.json | Move objectAt to ember-metal
... and fix some tests that should ahve been testing the
method version of objectAt. | packages/ember-runtime/lib/index.d.ts | @@ -18,8 +18,6 @@ export const String: {
loc(s: string, ...args: string[]): string;
};
-export function objectAt(arr: any, i: number): any;
-
export function isEmberArray(arr: any): boolean;
export function _contentFor(proxy: any): any; | true |
Other | emberjs | ember.js | daa39359c2b3811d7053e2162a5717dcf40b04a1.json | Move objectAt to ember-metal
... and fix some tests that should ahve been testing the
method version of objectAt. | packages/ember-runtime/lib/index.js | @@ -12,7 +12,6 @@ export { default as compare } from './compare';
export { default as isEqual } from './is-equal';
export {
default as Array,
- objectAt,
isEmberArray,
addArrayObserver,
removeArrayObserver, | true |
Other | emberjs | ember.js | daa39359c2b3811d7053e2162a5717dcf40b04a1.json | Move objectAt to ember-metal
... and fix some tests that should ahve been testing the
method version of objectAt. | packages/ember-runtime/lib/mixins/array.js | @@ -6,6 +6,8 @@ import { symbol, toString } from 'ember-utils';
import {
get,
set,
+ objectAt,
+ replace,
computed,
isNone,
aliasMethod,
@@ -25,9 +27,6 @@ import {
import { assert } from 'ember-debug';
import Enumerable from './enumerable';
import compare from '../compare';
-import {
- replace
-} ... | true |
Other | emberjs | ember.js | daa39359c2b3811d7053e2162a5717dcf40b04a1.json | Move objectAt to ember-metal
... and fix some tests that should ahve been testing the
method version of objectAt. | packages/ember-runtime/lib/system/array_proxy.js | @@ -4,6 +4,7 @@
import {
get,
+ objectAt,
computed,
alias,
PROPERTY_DID_CHANGE
@@ -15,8 +16,7 @@ import EmberObject from './object';
import { MutableArray } from '../mixins/array';
import {
addArrayObserver,
- removeArrayObserver,
- objectAt
+ removeArrayObserver
} from '../mixins/array';
impo... | true |
Other | emberjs | ember.js | daa39359c2b3811d7053e2162a5717dcf40b04a1.json | Move objectAt to ember-metal
... and fix some tests that should ahve been testing the
method version of objectAt. | packages/ember-runtime/tests/mixins/array_test.js | @@ -1,6 +1,7 @@
import {
get,
set,
+ objectAt,
addObserver,
observer as emberObserver,
computed
@@ -12,8 +13,7 @@ import EmberArray, {
addArrayObserver,
removeArrayObserver,
arrayContentDidChange,
- arrayContentWillChange,
- objectAt
+ arrayContentWillChange
} from '../../mixins/array';
i... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.