language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-glimmer/lib/views/outlet.ts | @@ -1,6 +1,6 @@
import { Simple } from '@glimmer/interfaces';
import { environment } from 'ember-environment';
-import { run } from 'ember-metal';
+import { schedule } from 'ember-metal';
import { assign, OWNER, Owner } from 'ember-utils';
import { OutletDefinitionState } from '../component-managers/outlet';
impor... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-glimmer/tests/integration/application/engine-test.js | @@ -5,7 +5,7 @@ import { Controller, RSVP } from 'ember-runtime';
import { Component } from 'ember-glimmer';
import { Engine } from 'ember-application';
import { Route } from 'ember-routing';
-import { run } from 'ember-metal';
+import { next } from 'ember-metal';
moduleFor('Application test: engine rendering', c... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-glimmer/tests/integration/components/life-cycle-test.js | @@ -1,4 +1,4 @@
-import { set, setProperties, run } from 'ember-metal';
+import { set, setProperties, schedule } from 'ember-metal';
import { A as emberA } from 'ember-runtime';
import { Component } from '../../utils/helpers';
import { strip } from '../../utils/abstract-test-case';
@@ -139,7 +139,7 @@ class LifeCycl... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-glimmer/tests/integration/event-dispatcher-test.js | @@ -3,7 +3,8 @@ import { Component } from '../utils/helpers';
import {
instrumentationSubscribe,
instrumentationReset,
- run
+ run,
+ getCurrentRunLoop,
} from 'ember-metal';
import { EMBER_IMPROVED_INSTRUMENTATION } from 'ember/features';
@@ -93,7 +94,7 @@ moduleFor('EventDispatcher', class extends Rende... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-glimmer/tests/integration/helpers/closure-action-test.js | @@ -1,5 +1,5 @@
import {
- run,
+ getCurrentRunLoop,
set,
computed,
instrumentationSubscribe,
@@ -987,7 +987,7 @@ moduleFor('Helpers test: closure {{action}}', class extends RenderingTest {
let OuterComponent = Component.extend({
actions: {
submit() {
- capturedRunLoop = run.cu... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-glimmer/tests/integration/render-settled-test.js | @@ -5,7 +5,7 @@ import {
} from 'internal-test-helpers';
import { renderSettled } from 'ember-glimmer';
import { all } from 'rsvp';
-import { run } from 'ember-metal';
+import { run, schedule } from 'ember-metal';
moduleFor('renderSettled', class extends RenderingTestCase {
['@test resolves when no rendering i... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-glimmer/tests/unit/outlet-test.js | @@ -1,5 +1,5 @@
import { OutletView } from 'ember-glimmer';
-import { run } from 'ember-metal';
+import { run, schedule } from 'ember-metal';
QUnit.module('Glimmer OutletView');
@@ -22,7 +22,7 @@ QUnit.test('render in the render queue', function(assert) {
outletView.appendTo(expectedOutlet);
assert.equa... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-metal/lib/index.d.ts | @@ -6,18 +6,15 @@ interface IBackburner {
scheduleOnce(...args: any[]): void;
schedule(queueName: string, target: Object | null, method: Function | string): void;
}
-interface IRun {
- (...args: any[]): any;
- schedule(...args: any[]): void;
- later(...args: any[]): void;
- join(...args: any[]): void;
- bac... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-metal/lib/index.js | @@ -67,7 +67,26 @@ export { default as isNone } from './is_none';
export { default as isEmpty } from './is_empty';
export { default as isBlank } from './is_blank';
export { default as isPresent } from './is_present';
-export { default as run } from './run_loop';
+export {
+ getCurrentRunLoop,
+ backburner,
+ run,... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-metal/lib/run_loop.js | @@ -9,31 +9,49 @@ import {
} from './property_events';
import Backburner from 'backburner';
+let currentRunLoop = null;
+export function getCurrentRunLoop() {
+ return currentRunLoop;
+}
+
function onBegin(current) {
- run.currentRunLoop = current;
+ currentRunLoop = current;
}
function onEnd(current, next)... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-metal/lib/tags.js | @@ -2,7 +2,7 @@ import { CONSTANT_TAG, UpdatableTag, DirtyableTag, combine } from '@glimmer/refe
import { EMBER_METAL_TRACKED_PROPERTIES } from 'ember/features';
import { meta as metaFor } from './meta';
import { isProxy } from './is_proxy';
-import run from './run_loop';
+import { backburner } from './run_loop';
... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-metal/tests/run_loop/debounce_test.js | @@ -1,4 +1,4 @@
-import { run } from '../..';
+import { debounce } from '../..';
import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
moduleFor('debounce', class extends AbstractTestCase {
@@ -12,9 +12,9 @@ moduleFor('debounce', class extends AbstractTestCase {
}
};
- run.debounce(t... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-metal/tests/run_loop/later_test.js | @@ -1,16 +1,23 @@
import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
import { assign } from 'ember-utils';
-import { run, isNone } from '../..';
+import {
+ run,
+ later,
+ backburner,
+ isNone,
+ hasScheduledTimers,
+ getCurrentRunLoop,
+} from '../..';
const originalSetTimeout = window.se... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-metal/tests/run_loop/next_test.js | @@ -1,12 +1,12 @@
-import { run } from '../..';
+import { run, next, getCurrentRunLoop } from '../..';
import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
moduleFor('run.next', class extends AbstractTestCase {
['@test should invoke immediately on next timeout'](assert) {
let done = assert.a... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-metal/tests/run_loop/once_test.js | @@ -1,14 +1,14 @@
-import { run } from '../..';
+import { run, getCurrentRunLoop, once } from '../..';
import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
moduleFor('system/run_loop/once_test', class extends AbstractTestCase {
['@test calling invokeOnce more than once invokes only once'](assert)... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-metal/tests/run_loop/run_bind_test.js | @@ -1,4 +1,4 @@
-import { run } from '../..';
+import { bind, getCurrentRunLoop } from '../..';
import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
moduleFor('system/run_loop/run_bind_test', class extends AbstractTestCase {
@@ -8,12 +8,12 @@ moduleFor('system/run_loop/run_bind_test', class extends ... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-metal/tests/run_loop/schedule_test.js | @@ -1,13 +1,13 @@
-import { run } from '../..';
+import { run, cancel, schedule, getCurrentRunLoop } from '../..';
import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
moduleFor('system/run_loop/schedule_test', class extends AbstractTestCase {
['@test scheduling item in queue should defer until f... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-metal/tests/run_loop/sync_test.js | @@ -1,4 +1,4 @@
-import { run } from '../..';
+import { run, schedule } from '../..';
import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
moduleFor('system/run_loop/sync_test', class extends AbstractTestCase {
@@ -11,10 +11,10 @@ moduleFor('system/run_loop/sync_test', class extends AbstractTestCase... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-metal/tests/run_loop/unwind_test.js | @@ -1,40 +1,34 @@
-import { run } from '../..';
+import { run, schedule, getCurrentRunLoop } from '../..';
import { Error as EmberError } from 'ember-debug';
import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
moduleFor('system/run_loop/unwind_test', class extends AbstractTestCase {
['@test Run... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-routing/lib/location/hash_location.js | @@ -1,7 +1,7 @@
import {
get,
set,
- run
+ bind
} from 'ember-metal';
import { Object as EmberObject } from 'ember-runtime';
@@ -127,7 +127,7 @@ export default EmberObject.extend({
onUpdateURL(callback) {
this._removeEventListener();
- this._hashchangeHandler = run.bind(this, function() {
+ ... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-routing/lib/system/route.js | @@ -5,7 +5,7 @@ import {
getProperties,
setProperties,
computed,
- run,
+ once,
isEmpty
} from 'ember-metal';
import { assert, info, isTesting, deprecate } from 'ember-debug';
@@ -2082,7 +2082,7 @@ let Route = EmberObject.extend(ActionHandler, Evented, {
let renderOptions = buildRenderOptions(thi... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-routing/lib/system/router.js | @@ -7,7 +7,11 @@ import {
set,
defineProperty,
computed,
- run
+ run,
+ once,
+ scheduleOnce,
+ schedule,
+ cancel,
} from 'ember-metal';
import {
Error as EmberError,
@@ -258,7 +262,7 @@ const EmberRouter = EmberObject.extend(Evented, {
// Put this in the runloop so url will be accurate. See... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-runtime/lib/ext/rsvp.js | @@ -1,13 +1,11 @@
import * as RSVP from 'rsvp';
import {
- run,
+ backburner,
getDispatchOverride
} from 'ember-metal';
import { assert } from 'ember-debug';
import { privatize as P } from 'container';
-const backburner = run.backburner;
-
RSVP.configure('async', (callback, promise) => {
backburner.sche... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-runtime/lib/system/core_object.js | @@ -25,7 +25,7 @@ import {
defineProperty,
ComputedProperty,
InjectedProperty,
- run,
+ schedule,
deleteMeta,
descriptor
} from 'ember-metal';
@@ -36,7 +36,6 @@ import { DEBUG } from 'ember-env-flags';
import { ENV } from 'ember-environment';
import { MANDATORY_GETTER, MANDATORY_SETTER, EMBER_METAL_... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-runtime/tests/ext/rsvp_test.js | @@ -1,7 +1,9 @@
import {
setOnerror,
getOnerror,
- run
+ run,
+ schedule,
+ next,
} from 'ember-metal';
import RSVP from '../../ext/rsvp';
import { isTesting, setTesting } from 'ember-debug';
@@ -177,20 +179,20 @@ QUnit.test('handled within the same micro-task (via Ember.RVP.Promise)', functio
QUnit.test... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-testing/lib/ext/rsvp.js | @@ -1,5 +1,5 @@
import { RSVP } from 'ember-runtime';
-import { run } from 'ember-metal';
+import { backburner } from 'ember-metal';
import { isTesting } from 'ember-debug';
import {
asyncStart,
@@ -8,14 +8,14 @@ import {
RSVP.configure('async', function(callback, promise) {
// if schedule will cause autoru... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-testing/lib/helpers/wait.js | @@ -3,7 +3,7 @@
*/
import { checkWaiters } from '../test/waiters';
import { RSVP } from 'ember-runtime';
-import { run } from 'ember-metal';
+import { getCurrentRunLoop, hasScheduledTimers, run } from 'ember-metal';
import { pendingRequests } from '../test/pending_requests';
/**
@@ -50,7 +50,7 @@ export default ... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-testing/lib/test/run.js | @@ -1,7 +1,7 @@
-import { run as emberRun } from 'ember-metal';
+import { run as emberRun, getCurrentRunLoop } from 'ember-metal';
export default function run(fn) {
- if (!emberRun.currentRunLoop) {
+ if (!getCurrentRunLoop()) {
return emberRun(fn);
} else {
return fn(); | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-testing/tests/acceptance_test.js | @@ -3,7 +3,7 @@ import {
AutobootApplicationTestCase
} from 'internal-test-helpers';
-import { run } from 'ember-metal';
+import { later } from 'ember-metal';
import Test from '../test';
import QUnitAdapter from '../adapters/qunit';
import { Route } from 'ember-routing';
@@ -85,7 +85,7 @@ if (!jQueryDisabled) ... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-testing/tests/adapters_test.js | @@ -1,4 +1,4 @@
-import { run, setOnerror } from 'ember-metal';
+import { run, next, setOnerror } from 'ember-metal';
import Test from '../test';
import Adapter from '../adapters/adapter';
import QUnitAdapter from '../adapters/qunit';
@@ -21,7 +21,7 @@ function runThatThrowsSync(message = 'Error for testing error ha... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-testing/tests/ext/rsvp_test.js | @@ -1,7 +1,7 @@
import RSVP from '../../ext/rsvp';
import { getAdapter, setAdapter } from '../../test/adapter';
import TestPromise, { getLastPromise } from '../../test/promise';
-import { run } from 'ember-metal';
+import { getCurrentRunLoop } from 'ember-metal';
import { isTesting, setTesting } from 'ember-debug';... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-testing/tests/helpers_test.js | @@ -9,7 +9,7 @@ import {
Controller,
RSVP
} from 'ember-runtime';
-import { run } from 'ember-metal';
+import { later } from 'ember-metal';
import {
Component,
} from 'ember-glimmer';
@@ -561,7 +561,7 @@ if (!jQueryDisabled) {
});
let waitDone = false;
- run.later(() => {
+ later((... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember-views/lib/views/states/has_element.js | @@ -1,6 +1,6 @@
import { assign } from 'ember-utils';
import _default from './default';
-import { run, flaggedInstrument } from 'ember-metal';
+import { join, flaggedInstrument } from 'ember-metal';
const hasElement = Object.create(_default);
@@ -20,7 +20,7 @@ assign(hasElement, {
// Handler should be abl... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember/lib/index.js | @@ -85,7 +85,28 @@ Ember.isNone = metal.isNone;
Ember.isEmpty = metal.isEmpty;
Ember.isBlank = metal.isBlank;
Ember.isPresent = metal.isPresent;
-Ember.run = metal.run;
+// Using _globalsRun here so that mutating the function (adding `next`,
+// `later`, etc to it) does not appear available throughout the rest of th... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember/tests/error_handler_test.js | @@ -1,5 +1,5 @@
import { isTesting, setTesting } from 'ember-debug';
-import { run, getOnerror, setOnerror } from 'ember-metal';
+import { run, later, getOnerror, setOnerror } from 'ember-metal';
import RSVP from 'rsvp';
let WINDOW_ONERROR;
@@ -118,7 +118,7 @@ QUnit.test('does not swallow exceptions by default (Em... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/ember/tests/reexports_test.js | @@ -70,7 +70,21 @@ let allExports =[
['isBlank', 'ember-metal'],
['isPresent', 'ember-metal'],
['_Backburner', 'backburner', 'default'],
- ['run', 'ember-metal'],
+ ['run', 'ember-metal', '_globalsRun'],
+ ['run.backburner', 'ember-metal', 'backburner'],
+ ['run.begin', 'ember-metal', 'begin'],
+ ['run.bi... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/internal-test-helpers/lib/ember-dev/run-loop.js | @@ -1,3 +1,10 @@
+import {
+ getCurrentRunLoop,
+ hasScheduledTimers,
+ cancelTimers,
+ end,
+} from 'ember-metal';
+
function RunLoopAssertion(env){
this.env = env;
}
@@ -7,18 +14,17 @@ RunLoopAssertion.prototype = {
inject: function(){},
assert: function(){
let { assert } = QUnit.config.current;
-... | true |
Other | emberjs | ember.js | 3b77850fa877c1872b126f6a0661159f57173b03.json | Make run loop functions named exports. | packages/internal-test-helpers/lib/test-cases/abstract.js | @@ -1,7 +1,7 @@
/* global Element */
import { assign } from 'ember-utils';
-import { run } from 'ember-metal';
+import { run, next, hasScheduledTimers, getCurrentRunLoop } from 'ember-metal';
import NodeQuery from './node-query';
import equalInnerHTML from '../equal-inner-html';
@@ -50,7 +50,7 @@ export default... | true |
Other | emberjs | ember.js | a155b309541e7077c31cf0a7e1a4302d4c87fb17.json | Remove `Controller#content` alias.
This was deprecated and labeled as `until` 2.17. With 3.2 approaching
beta soon, its time has passed... | packages/ember-runtime/lib/mixins/controller.js | @@ -40,13 +40,4 @@ export default Mixin.create(ActionHandler, {
@public
*/
model: null,
-
- /**
- @private
- */
- content: deprecatingAlias('model', {
- id: 'ember-runtime.controller.content-alias',
- until: '2.17.0',
- url: 'https://emberjs.com/deprecations/v2.x/#toc_controller-content-alias'... | true |
Other | emberjs | ember.js | a155b309541e7077c31cf0a7e1a4302d4c87fb17.json | Remove `Controller#content` alias.
This was deprecated and labeled as `until` 2.17. With 3.2 approaching
beta soon, its time has passed... | packages/ember-runtime/tests/controllers/controller_test.js | @@ -106,17 +106,6 @@ QUnit.module('Controller deprecations');
QUnit.module('Controller Content -> Model Alias');
-QUnit.test('`content` is a deprecated alias of `model`', function(assert) {
- assert.expect(2);
- let controller = Controller.extend({
- model: 'foo-bar'
- }).create();
-
- expectDeprecation(fun... | true |
Other | emberjs | ember.js | 3ea74706473b7f4d14fa14b521e979ea8b72d820.json | Use explicit `/index` for importing from folder. | packages/ember-template-compiler/lib/index.js | @@ -17,7 +17,7 @@ export {
registerPlugin,
unregisterPlugin
} from './system/compile-options';
-export { default as defaultPlugins } from './plugins';
+export { default as defaultPlugins } from './plugins/index';
// used for adding Ember.Handlebars.compile for backwards compat
import './compat';
@@ -27,4 +27... | true |
Other | emberjs | ember.js | 3ea74706473b7f4d14fa14b521e979ea8b72d820.json | Use explicit `/index` for importing from folder. | packages/ember-template-compiler/lib/system/compile-options.js | @@ -1,5 +1,5 @@
import { assign } from 'ember-utils';
-import PLUGINS from '../plugins';
+import PLUGINS from '../plugins/index';
let USER_PLUGINS = [];
| true |
Other | emberjs | ember.js | d4645deaf0f3c7d462895c63a08b0bd20338001d.json | Use native class for promise inheritance test.
Prior to this change, when testing untranspiled ES an error is thrown
(cannot call promise constructor without `new`). | packages/ember-runtime/tests/mixins/promise_proxy_test.js | @@ -214,12 +214,7 @@ QUnit.test('unhandled rejects still propagate to RSVP.on(\'error\', ...) ', func
});
QUnit.test('should work with promise inheritance', function(assert) {
- function PromiseSubclass() {
- RSVP.Promise.apply(this, arguments);
- }
-
- PromiseSubclass.prototype = Object.create(RSVP.Promise.p... | false |
Other | emberjs | ember.js | 7d5a9c300b6275b58bb1c8c42af071cf145bcb94.json | Enable tests using ES<latest> AMD bundle... | tests/index.html | @@ -80,10 +80,17 @@
<script>
var dist = QUnit.urlParams.dist;
- if (dist) {
- loadScript('../ember.' + dist + '.js');
- } else {
- loadScript('../ember.debug.js');
+ switch (dist) {
+ case 'prod':
+ case 'min':
+ loadScript('../ember.' + dist + '.js');
+... | false |
Other | emberjs | ember.js | 7b9c1a19535eb334c9caf39bf6a946987c9582fe.json | remove redundant existence checks | packages/ember-runtime/lib/compare.js | @@ -95,14 +95,12 @@ export default function compare(v, w) {
let type1 = typeOf(v);
let type2 = typeOf(w);
- if (Comparable) {
- if (type1 === 'instance' && Comparable.detect(v) && v.constructor.compare) {
- return v.constructor.compare(v, w);
- }
+ if (type1 === 'instance' && Comparable.detect(v) &... | false |
Other | emberjs | ember.js | 6d64f3b48811efe4ed961c63e1afb673621edf22.json | Add tests for native Set | packages/ember-glimmer/tests/integration/syntax/each-test.js | @@ -94,6 +94,36 @@ class ArrayDelegate {
}
}
+const makeSet = (() => {
+ // IE11 does not support `new Set(items);`
+ let set = new Set([1,2,3]);
+
+ if (set.size === 3) {
+ return items => new Set(items);
+ } else {
+ return items => {
+ let s = new Set();
+ items.forEach(value => s.add(value... | false |
Other | emberjs | ember.js | ed27baafef1ce299e624b6c7acb36d1f9d476230.json | Remove build time linting.
We have a specific CI build that runs eslint, tsc, and tslint. Doing
this also in the build has turned out to be expensive and needlessly
bloat the final browser builds (which has a direct impact on IE11 test
run times)... | broccoli/lint.js | @@ -1,9 +0,0 @@
-'use strict';
-
-const ESLint = require('broccoli-lint-eslint');
-
-module.exports = function _lint(tree) {
- return new ESLint(tree, {
- testGenerator: 'qunit'
- });
-}; | true |
Other | emberjs | ember.js | ed27baafef1ce299e624b6c7acb36d1f9d476230.json | Remove build time linting.
We have a specific CI build that runs eslint, tsc, and tslint. Doing
this also in the build has turned out to be expensive and needlessly
bloat the final browser builds (which has a direct impact on IE11 test
run times)... | ember-cli-build.js | @@ -1,6 +1,5 @@
'use strict';
-const UnwatchedDir = require('broccoli-source').UnwatchedDir;
const MergeTrees = require('broccoli-merge-trees');
const Funnel = require('broccoli-funnel');
const babelHelpers = require('./broccoli/babel-helpers');
@@ -10,7 +9,6 @@ const testIndexHTML = require('./broccoli/test-inde... | true |
Other | emberjs | ember.js | ed27baafef1ce299e624b6c7acb36d1f9d476230.json | Remove build time linting.
We have a specific CI build that runs eslint, tsc, and tslint. Doing
this also in the build has turned out to be expensive and needlessly
bloat the final browser builds (which has a direct impact on IE11 test
run times)... | package.json | @@ -91,7 +91,6 @@
"broccoli-concat": "^3.2.2",
"broccoli-debug": "^0.6.4",
"broccoli-file-creator": "^1.1.1",
- "broccoli-lint-eslint": "^3.2.2",
"broccoli-rollup": "^2.1.0",
"broccoli-source": "^1.1.0",
"broccoli-string-replace": "^0.1.2", | true |
Other | emberjs | ember.js | ed27baafef1ce299e624b6c7acb36d1f9d476230.json | Remove build time linting.
We have a specific CI build that runs eslint, tsc, and tslint. Doing
this also in the build has turned out to be expensive and needlessly
bloat the final browser builds (which has a direct impact on IE11 test
run times)... | yarn.lock | @@ -261,12 +261,6 @@ anymatch@^1.3.0:
micromatch "^2.1.5"
normalize-path "^2.0.0"
-aot-test-generators@^0.1.0:
- version "0.1.0"
- resolved "https://registry.yarnpkg.com/aot-test-generators/-/aot-test-generators-0.1.0.tgz#43f0f615f97cb298d7919c1b0b4e6b7310b03cd0"
- dependencies:
- jsesc "^2.5.0"
-
ap... | true |
Other | emberjs | ember.js | 87980e24a49c46cea29c08b76a90a3bc979f54e6.json | avoid iteration when possible in `each_proxy` | packages/ember-metal/lib/array.js | @@ -12,8 +12,8 @@ export function objectAt(array, index) {
return array[index];
} else {
return array.objectAt(index);
- }
-}
+ }
+}
export function replace(array, start, deleteCount, items = EMPTY_ARRAY) {
if (Array.isArray(array)) {
@@ -104,17 +104,18 @@ export function arrayContentDidChange(... | true |
Other | emberjs | ember.js | 87980e24a49c46cea29c08b76a90a3bc979f54e6.json | avoid iteration when possible in `each_proxy` | packages/ember-metal/lib/each_proxy.js | @@ -44,8 +44,8 @@ class EachProxy {
arrayWillChange(content, idx, removedCnt, addedCnt) { // eslint-disable-line no-unused-vars
let keys = this._keys;
let lim = removedCnt > 0 ? idx + removedCnt : -1;
- for (let key in keys) {
- if (lim > 0) {
+ if (lim > 0) {
+ for (let key in keys) {
... | true |
Other | emberjs | ember.js | 9579cad57ad3c1dea32c8cfac84e968a7bd5f72a.json | fix broken imports | packages/ember-views/lib/views/states/default.js | @@ -1,19 +1,19 @@
-import {
- EmberError
-} from 'ember-debug';
+import { Error as EmberError } from 'ember-debug';
export default {
// appendChild is only legal while rendering the buffer.
appendChild() {
- throw new EmberError('You can\'t use appendChild outside of the rendering process');
+ throw new... | true |
Other | emberjs | ember.js | 9579cad57ad3c1dea32c8cfac84e968a7bd5f72a.json | fix broken imports | packages/ember/lib/index.js | @@ -93,7 +93,7 @@ Ember.overrideChains = metal.overrideChains;
Ember.beginPropertyChanges = metal.beginPropertyChanges;
Ember.endPropertyChanges = metal.endPropertyChanges;
Ember.changeProperties = metal.changeProperties;
-Ember.platform = {
+Ember.platform = {
defineProperty: true,
hasPropertyAccessors... | true |
Other | emberjs | ember.js | 97ed5c28a1d4fe4dbeee6cb2de3931f725dfbdd2.json | add small doc for `unwatch` | packages/ember-metal/lib/observer.js | @@ -21,14 +21,14 @@ export function changeEvent(keyName) {
@static
@for @ember/object/observers
@param obj
- @param {String} _path
+ @param {String} path
@param {Object|Function} target
@param {Function|String} [method]
@public
*/
-export function addObserver(obj, _path, target, method) {
- addLis... | true |
Other | emberjs | ember.js | 97ed5c28a1d4fe4dbeee6cb2de3931f725dfbdd2.json | add small doc for `unwatch` | packages/ember-metal/lib/watching.js | @@ -26,13 +26,14 @@ import {
@method watch
@for Ember
@param obj
- @param {String} _keyPath
+ @param {String} keyPath
+ @param {Object} meta
*/
-export function watch(obj, _keyPath, m) {
- if (isPath(_keyPath)) {
- watchPath(obj, _keyPath, m);
+export function watch(obj, keyPath, meta) {
+ if (isPath(... | true |
Other | emberjs | ember.js | 27de208c87685aa3ea4e51ac967d23da15e0181c.json | Move array internals to ember-metal | packages/ember-extension-support/lib/data_adapter.js | @@ -1,12 +1,16 @@
import { getOwner } from 'ember-utils';
-import { get, run, objectAt } from 'ember-metal';
+import {
+ get,
+ run,
+ objectAt,
+ addArrayObserver,
+ removeArrayObserver
+} from 'ember-metal';
import {
String as StringUtils,
Namespace,
Object as EmberObject,
A as emberA,
- addArrayO... | true |
Other | emberjs | ember.js | 27de208c87685aa3ea4e51ac967d23da15e0181c.json | Move array internals to ember-metal | packages/ember-metal/lib/array.js | @@ -1,7 +1,110 @@
+import { notifyPropertyChange } from "./property_events";
+import { eachProxyArrayDidChange, eachProxyArrayWillChange } from "./each_proxy";
+import { peekMeta } from "./meta";
+import { sendEvent, removeListener, addListener } from "./events";
+import { peekCacheFor } from "./computed";
+import { ge... | true |
Other | emberjs | ember.js | 27de208c87685aa3ea4e51ac967d23da15e0181c.json | Move array internals to ember-metal | packages/ember-metal/lib/index.js | @@ -41,7 +41,13 @@ export {
set,
trySet
} from './property_set';
-export { objectAt } from './array';
+export {
+ objectAt,
+ addArrayObserver,
+ removeArrayObserver,
+ arrayContentWillChange,
+ arrayContentDidChange
+} from './array';
export {
eachProxyFor,
eachProxyArrayWillChange, | true |
Other | emberjs | ember.js | 27de208c87685aa3ea4e51ac967d23da15e0181c.json | Move array internals to ember-metal | packages/ember-runtime/lib/index.js | @@ -13,8 +13,6 @@ export { default as isEqual } from './is-equal';
export {
default as Array,
isEmberArray,
- addArrayObserver,
- removeArrayObserver,
NativeArray,
A,
MutableArray, | true |
Other | emberjs | ember.js | 27de208c87685aa3ea4e51ac967d23da15e0181c.json | Move array internals to ember-metal | packages/ember-runtime/lib/mixins/array.js | @@ -12,18 +12,14 @@ import {
isNone,
aliasMethod,
Mixin,
- notifyPropertyChange,
- addListener,
- removeListener,
- sendEvent,
hasListeners,
- peekMeta,
eachProxyFor,
- eachProxyArrayWillChange,
- eachProxyArrayDidChange,
beginPropertyChanges,
endPropertyChanges,
- peekCacheFor
+ addArrayO... | true |
Other | emberjs | ember.js | 27de208c87685aa3ea4e51ac967d23da15e0181c.json | Move array internals to ember-metal | packages/ember-runtime/lib/system/array_proxy.js | @@ -7,17 +7,15 @@ import {
objectAt,
computed,
alias,
- PROPERTY_DID_CHANGE
+ PROPERTY_DID_CHANGE,
+ addArrayObserver,
+ removeArrayObserver
} from 'ember-metal';
import {
isArray
} from '../utils';
import EmberObject from './object';
import { MutableArray } from '../mixins/array';
-import {
- add... | true |
Other | emberjs | ember.js | 27de208c87685aa3ea4e51ac967d23da15e0181c.json | Move array internals to ember-metal | packages/ember-runtime/tests/helpers/array.js | @@ -1,15 +1,18 @@
import ArrayProxy from '../../system/array_proxy';
import EmberArray, {
A as emberA,
- MutableArray,
- arrayContentDidChange,
- arrayContentWillChange,
- addArrayObserver,
- removeArrayObserver,
+ MutableArray
} from '../../mixins/array';
import { generateGuid, guidFor } from 'ember-utils... | true |
Other | emberjs | ember.js | 27de208c87685aa3ea4e51ac967d23da15e0181c.json | Move array internals to ember-metal | packages/ember-runtime/tests/mixins/array_test.js | @@ -4,16 +4,15 @@ import {
objectAt,
addObserver,
observer as emberObserver,
- computed
-} from 'ember-metal';
-import { testBoth } from 'internal-test-helpers';
-import EmberObject from '../../system/object';
-import EmberArray, {
+ computed,
addArrayObserver,
removeArrayObserver,
arrayContentDidCh... | true |
Other | emberjs | ember.js | 4feeed7daeb442b9575603d5f48a32c9f786cd8f.json | Upgrade backburner.js to 2.2.2.
Upstream issue causing revert of 2.2.0 and 2.2.1 has been addressed,
this updates to the fixed version 2.2.2.
Once landed, further testing can be done.. | package.json | @@ -86,7 +86,7 @@
"babel-plugin-transform-object-assign": "^6.22.0",
"babel-plugin-transform-proto-to-assign": "^6.26.0",
"babel-template": "^6.26.0",
- "backburner.js": "2.1.0",
+ "backburner.js": "^2.2.2",
"broccoli-babel-transpiler": "^6.1.2",
"broccoli-concat": "^3.2.2",
"broccol... | true |
Other | emberjs | ember.js | 4feeed7daeb442b9575603d5f48a32c9f786cd8f.json | Upgrade backburner.js to 2.2.2.
Upstream issue causing revert of 2.2.0 and 2.2.1 has been addressed,
this updates to the fixed version 2.2.2.
Once landed, further testing can be done.. | yarn.lock | @@ -988,9 +988,9 @@ backbone@^1.1.2:
dependencies:
underscore ">=1.8.3"
-backburner.js@2.1.0:
- version "2.1.0"
- resolved "https://registry.yarnpkg.com/backburner.js/-/backburner.js-2.1.0.tgz#2dd3b0f5043fc495b91407cf9f27d976e86159d5"
+backburner.js@^2.2.2:
+ version "2.2.2"
+ resolved "https://registry.y... | true |
Other | emberjs | ember.js | 66c39c2f1888c6533f0d807d7f4804ec2bfbcb65.json | Add v3.1.0-beta.5 to CHANGELOG
[ci skip]
(cherry picked from commit 8f395f06a2b6140ecfa326945bf657c040a1a6f9) | CHANGELOG.md | @@ -1,5 +1,13 @@
# Ember Changelog
+### v3.1.0-beta.5 (March 12, 2018)
+- [#15601](https://github.com/emberjs/ember.js/pull/15601) [BUGFIX] Ensure Mixin.prototype.toString does not return constructor code
+- [#16326](https://github.com/emberjs/ember.js/pull/16326) [BUGFIX] Expanded syntax error for if handlebars hel... | false |
Other | emberjs | ember.js | 06c40663a22e1a225d3308fd35487b27bdeef83d.json | add weakset polyfill | packages/ember-metal/lib/is_proxy.js | @@ -1,9 +1,11 @@
-const PROXIES = new WeakMap();
+import WeakSet from './weak_set';
+
+const PROXIES = new WeakSet();
export function isProxy(object) {
return PROXIES.has(object);
}
export function setProxy(object) {
- return PROXIES.set(object, true);
+ return PROXIES.add(object);
} | true |
Other | emberjs | ember.js | 06c40663a22e1a225d3308fd35487b27bdeef83d.json | add weakset polyfill | packages/ember-metal/lib/weak_set.js | @@ -0,0 +1,22 @@
+const HAS_WEAK_SET = typeof WeakSet === 'function';
+
+class WeakSetPolyFill {
+ constructor() {
+ this._weakmap = new WeakMap();
+ }
+
+ add(val) {
+ this._weakmap.set(val, true);
+ return this;
+ }
+
+ delete(val) {
+ return this._weakmap.delete(val);
+ }
+
+ has(val) {
+ retur... | true |
Other | emberjs | ember.js | b2fc87ee1184c9aa8a9960758ae6a023e65ae91d.json | Add tracked properties behind a feature flag | features.json | @@ -9,7 +9,8 @@
"ember-engines-mount-params": true,
"ember-module-unification": null,
"glimmer-custom-component-manager": null,
- "ember-template-block-let-helper": null
+ "ember-template-block-let-helper": null,
+ "ember-metal-tracked-properties": null
},
"deprecations": {
"container... | true |
Other | emberjs | ember.js | b2fc87ee1184c9aa8a9960758ae6a023e65ae91d.json | Add tracked properties behind a feature flag | packages/ember-glimmer/tests/integration/application/engine-test.js | @@ -717,8 +717,8 @@ moduleFor('Application test: engine rendering', class extends ApplicationTest {
let href1337 = this.element.querySelector('.author-1337').href;
// check if link ends with the suffix
- assert.ok(this.stringsEndWith(href1, suffix1));
- assert.ok(this.stringsEndWith(href1337, ... | true |
Other | emberjs | ember.js | b2fc87ee1184c9aa8a9960758ae6a023e65ae91d.json | Add tracked properties behind a feature flag | packages/ember-metal/externs.d.ts | @@ -0,0 +1,12 @@
+declare module 'ember/features' {
+ export const EMBER_TEMPLATE_BLOCK_LET_HELPER: boolean | null;
+ export const EMBER_MODULE_UNIFICATION: boolean | null;
+ export const GLIMMER_CUSTOM_COMPONENT_MANAGER: boolean | null;
+ export const EMBER_ENGINES_MOUNT_PARAMS: boolean | null;
+ export const EMB... | true |
Other | emberjs | ember.js | b2fc87ee1184c9aa8a9960758ae6a023e65ae91d.json | Add tracked properties behind a feature flag | packages/ember-metal/lib/computed.js | @@ -2,6 +2,7 @@ import { inspect } from 'ember-utils';
import { assert, warn, Error as EmberError } from 'ember-debug';
import { set } from './property_set';
import { meta as metaFor, peekMeta } from './meta';
+import { EMBER_METAL_TRACKED_PROPERTIES } from 'ember/features';
import expandProperties from './expand_p... | true |
Other | emberjs | ember.js | b2fc87ee1184c9aa8a9960758ae6a023e65ae91d.json | Add tracked properties behind a feature flag | packages/ember-metal/lib/index.js | @@ -135,3 +135,4 @@ export {
setProxy
} from './is_proxy';
export { default as descriptor } from './descriptor';
+export { tracked } from './tracked'; | true |
Other | emberjs | ember.js | b2fc87ee1184c9aa8a9960758ae6a023e65ae91d.json | Add tracked properties behind a feature flag | packages/ember-metal/lib/property_get.js | @@ -4,9 +4,11 @@
import { assert, deprecate } from 'ember-debug';
import { HAS_NATIVE_PROXY, symbol } from 'ember-utils';
-import { DESCRIPTOR_TRAP, EMBER_METAL_ES5_GETTERS, MANDATORY_GETTER } from 'ember/features';
+import { DESCRIPTOR_TRAP, EMBER_METAL_ES5_GETTERS, EMBER_METAL_TRACKED_PROPERTIES, MANDATORY_GETTER... | true |
Other | emberjs | ember.js | b2fc87ee1184c9aa8a9960758ae6a023e65ae91d.json | Add tracked properties behind a feature flag | packages/ember-metal/lib/tags.js | @@ -1,4 +1,5 @@
-import { CONSTANT_TAG, DirtyableTag } from '@glimmer/reference';
+import { CONSTANT_TAG, UpdatableTag, DirtyableTag, combine } from '@glimmer/reference';
+import { EMBER_METAL_TRACKED_PROPERTIES } from 'ember/features';
import { meta as metaFor } from './meta';
import { isProxy } from './is_proxy';
... | true |
Other | emberjs | ember.js | b2fc87ee1184c9aa8a9960758ae6a023e65ae91d.json | Add tracked properties behind a feature flag | packages/ember-metal/lib/tracked.js | @@ -0,0 +1,202 @@
+import { combine, CONSTANT_TAG } from '@glimmer/reference';
+import { tagFor, tagForProperty, dirty, update } from './tags';
+/**
+ An object that that tracks @tracked properties that were consumed.
+
+ @private
+ */
+class Tracker {
+ constructor() {
+ this.tags = new Set();
+ thi... | true |
Other | emberjs | ember.js | b2fc87ee1184c9aa8a9960758ae6a023e65ae91d.json | Add tracked properties behind a feature flag | packages/ember-metal/lib/tracked.ts | @@ -0,0 +1,246 @@
+import { combine, CONSTANT_TAG, CURRENT_TAG, DirtyableTag, Tag, TagWrapper, UpdatableTag } from '@glimmer/reference';
+
+import {
+ MANDATORY_SETTER
+} from 'ember/features';
+import { meta as metaFor } from './meta';
+import { dirty, markObjectAsDirty, tagFor, tagForProperty, TRACKED_GETTERS, updat... | true |
Other | emberjs | ember.js | b2fc87ee1184c9aa8a9960758ae6a023e65ae91d.json | Add tracked properties behind a feature flag | packages/ember-metal/tests/tracked/computed_test.js | @@ -0,0 +1,68 @@
+import { createWithDescriptors } from './support';
+import { get, set, tracked } from '../..';
+
+import { EMBER_METAL_TRACKED_PROPERTIES } from 'ember/features';
+
+if (EMBER_METAL_TRACKED_PROPERTIES) {
+
+ QUnit.module('tracked getters');
+
+ QUnit.test('works without get', assert => {
+ let co... | true |
Other | emberjs | ember.js | b2fc87ee1184c9aa8a9960758ae6a023e65ae91d.json | Add tracked properties behind a feature flag | packages/ember-metal/tests/tracked/get_test.js | @@ -0,0 +1,78 @@
+import {
+ get,
+ getWithDefault,
+ tracked
+} from '../..';
+
+import { createTracked } from './support';
+
+import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
+
+import { EMBER_METAL_TRACKED_PROPERTIES } from 'ember/features';
+
+if (EMBER_METAL_TRACKED_PROPERTIES) {
+
+ module... | true |
Other | emberjs | ember.js | b2fc87ee1184c9aa8a9960758ae6a023e65ae91d.json | Add tracked properties behind a feature flag | packages/ember-metal/tests/tracked/set_test.js | @@ -0,0 +1,47 @@
+import {
+ get,
+ set,
+ setHasViews
+} from '../..';
+import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
+
+import { createTracked } from './support';
+
+import { EMBER_METAL_TRACKED_PROPERTIES } from 'ember/features';
+
+if (EMBER_METAL_TRACKED_PROPERTIES) {
+
+ moduleFor('trac... | true |
Other | emberjs | ember.js | b2fc87ee1184c9aa8a9960758ae6a023e65ae91d.json | Add tracked properties behind a feature flag | packages/ember-metal/tests/tracked/support.js | @@ -0,0 +1,30 @@
+import {
+ tracked
+} from '../..';
+
+export function createTracked(values, proto = {}) {
+ function Class() {
+ for (let prop in values) {
+ this[prop] = values[prop];
+ }
+ }
+
+ for (let prop in values) {
+ Object.defineProperty(proto, prop, tracked(proto, prop, { enumerable: tru... | true |
Other | emberjs | ember.js | b2fc87ee1184c9aa8a9960758ae6a023e65ae91d.json | Add tracked properties behind a feature flag | packages/ember-metal/tests/tracked/validation_test.js | @@ -0,0 +1,214 @@
+import {
+ computed,
+ defineProperty,
+ get,
+ set,
+ tracked
+} from '../..';
+
+import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
+import { tagForProperty } from '../..';
+
+import { EMBER_METAL_TRACKED_PROPERTIES } from 'ember/features';
+
+if (EMBER_METAL_TRACKED_PROPERTI... | true |
Other | emberjs | ember.js | b2fc87ee1184c9aa8a9960758ae6a023e65ae91d.json | Add tracked properties behind a feature flag | packages/ember-runtime/tests/computed/reduce_computed_macros_test.js | @@ -29,6 +29,7 @@ import {
} from '../../computed/reduce_computed_macros';
import { isArray } from '../../utils';
import { A as emberA, removeAt } from '../../mixins/array';
+import { EMBER_METAL_TRACKED_PROPERTIES } from 'ember/features';
let obj;
QUnit.module('map', {
@@ -1299,19 +1300,25 @@ QUnit.test('changi... | true |
Other | emberjs | ember.js | 80c11595d506cf1dafae565f7889137085aead9c.json | reuse mixin array build logic | packages/ember-metal/lib/mixin.js | @@ -429,25 +429,7 @@ export function mixin(obj, ...args) {
export default class Mixin {
constructor(mixins, properties) {
this.properties = properties;
-
- let length = mixins && mixins.length;
-
- if (length > 0) {
- let m = new Array(length);
-
- for (let i = 0; i < length; i++) {
- le... | false |
Other | emberjs | ember.js | ae867e537eae207b81c4bb2d7c2ada433a63cbc5.json | remove leftover `__ember_observesBefore__` | packages/ember-utils/lib/super.js | @@ -61,7 +61,6 @@ function _wrap(func, superFunc) {
superWrapper.wrappedFunction = func;
superWrapper.__ember_observes__ = func.__ember_observes__;
- superWrapper.__ember_observesBefore__ = func.__ember_observesBefore__;
superWrapper.__ember_listens__ = func.__ember_listens__;
return superWrapper; | false |
Other | emberjs | ember.js | b7c0efd71a2a7ff7bdad221828572583c7a711e5.json | remove empty constructor | packages/ember-glimmer/lib/utils/iterable.ts | @@ -99,7 +99,7 @@ class ArrayIterator implements Iterator {
let { length } = array;
if (length > 0) {
- return new this(array, array.length, keyFor);
+ return new this(array, length, keyFor);
} else {
return EMPTY_ITERATOR;
}
@@ -149,10 +149,6 @@ class EmberArrayIterator extends A... | false |
Other | emberjs | ember.js | 6ce518024c8360a861e742c67f767b7ae74ac5d5.json | Fix spelling on LinkComponent documentation | packages/ember-glimmer/lib/components/link-to.ts | @@ -279,7 +279,7 @@
It is also possible to override the default event in this manner:
```javascript
- import LinkCompoennt from '@ember/routing/link-component';
+ import LinkComponent from '@ember/routing/link-component';
export default LinkComponent.extend({
eventName: 'customEventName' | false |
Other | emberjs | ember.js | 86f1591012d76cdee6929d7ae265910b13ed9edf.json | remove string constant from global | packages/ember-glimmer/lib/index.ts | @@ -305,4 +305,4 @@ export { default as DebugStack } from './utils/debug-stack';
export { default as OutletView } from './views/outlet';
export { default as CustomComponentManager } from './component-managers/custom';
export { COMPONENT_MANAGER, componentManager } from './utils/custom-component-manager';
-export { i... | true |
Other | emberjs | ember.js | 86f1591012d76cdee6929d7ae265910b13ed9edf.json | remove string constant from global | packages/ember-glimmer/lib/utils/serialization-first-node-helpers.ts | @@ -1 +1 @@
-export { isSerializationFirstNode, SERIALIZATION_FIRST_NODE_STRING } from '@glimmer/util';
+export { isSerializationFirstNode } from '@glimmer/util'; | true |
Other | emberjs | ember.js | 86f1591012d76cdee6929d7ae265910b13ed9edf.json | remove string constant from global | packages/ember/lib/index.js | @@ -430,8 +430,7 @@ import {
template,
TextField,
TextArea,
- isSerializationFirstNode,
- SERIALIZATION_FIRST_NODE_STRING
+ isSerializationFirstNode
} from 'ember-glimmer';
Ember.Component = Component;
@@ -510,8 +509,7 @@ Ember.ViewUtils = {
getViewBoundingClientRect: views.getViewBoundingClientRect,... | true |
Other | emberjs | ember.js | 86f1591012d76cdee6929d7ae265910b13ed9edf.json | remove string constant from global | packages/ember/tests/reexports_test.js | @@ -115,7 +115,6 @@ let allExports =[
['ViewUtils.getRootViews', 'ember-views', 'getRootViews'],
['ViewUtils.getChildViews', 'ember-views', 'getChildViews'],
['ViewUtils.isSerializationFirstNode', 'ember-glimmer', 'isSerializationFirstNode'],
- ['ViewUtils.SERIALIZATION_FIRST_NODE_STRING', 'ember-glimmer', 'S... | true |
Other | emberjs | ember.js | 24070c437bcce9c8e563081b32a28ee549decf4e.json | Use isSerializationFirstNode in _renderMode test | packages/ember-application/tests/system/visit_test.js | @@ -10,7 +10,7 @@ import Application from '../../system/application';
import ApplicationInstance from '../../system/application-instance';
import Engine from '../../system/engine';
import { Route } from 'ember-routing';
-import { Component, helper } from 'ember-glimmer';
+import { Component, helper, isSerializationF... | false |
Other | emberjs | ember.js | 777bfd860d2ea30bd65d8070e3cf2c29e022c0a6.json | Add v3.1.0-beta.4 to CHANGELOG
[ci skip]
(cherry picked from commit 3be23a21a90a063913920e5c57fb3760eb278fcb) | CHANGELOG.md | @@ -1,5 +1,11 @@
# Ember Changelog
+### v3.1.0-beta.4 (March 5, 2018)
+- [#16294](https://github.com/emberjs/ember.js/pull/16294) [BUGFIX] Fix input macro params handling
+- [#16297](https://github.com/emberjs/ember.js/pull/16297) [BUGFIX] Revert "Update to backburner.js@2.2.0."
+- [#16299](https://github.com/emberj... | false |
Other | emberjs | ember.js | 401ff152f52b14f24f0df1167ff74c5661f76df6.json | Add 2.18.2 to the CHANGELOG.md.
(cherry picked from commit 3ebe27c84ee51578efa070ffa75a5e27cda5c9e6) | CHANGELOG.md | @@ -86,6 +86,10 @@
- [#16036](https://github.com/emberjs/ember.js/pull/16036) [CLEANUP] Convert ember-metal accessors tests to new style
- [#16023](https://github.com/emberjs/ember.js/pull/16023) Make event dispatcher work without jQuery
+### 2.18.2 (February 14, 2018)
+
+- [#16245](https://github.com/emberjs/ember... | false |
Other | emberjs | ember.js | 80c5127dc13de3abc9e5c9894d0edddd6737a668.json | Remove unnecessary resolverCacheKey | packages/container/lib/container.js | @@ -130,10 +130,6 @@ export default class Container {
return { [OWNER]: this.owner };
}
- _resolverCacheKey(name) {
- return this.registry.resolverCacheKey(name);
- }
-
/**
Given a fullName, return the corresponding factory. The consumer of the factory
is responsible for the destruction of any... | true |
Other | emberjs | ember.js | 80c5127dc13de3abc9e5c9894d0edddd6737a668.json | Remove unnecessary resolverCacheKey | packages/container/lib/registry.js | @@ -151,10 +151,9 @@ export default class Registry {
assert(`Attempting to register an unknown factory: '${fullName}'`, factory !== undefined);
let normalizedName = this.normalize(fullName);
- let cacheKey = this.resolverCacheKey(normalizedName);
- assert(`Cannot re-register: '${fullName}', as it has ... | true |
Other | emberjs | ember.js | cfaa47e48b0d6badb5e84419f117a46fd2f2ae8e.json | Introduce source to injections
Ember templates use a `source` argument to the container. This hints
where to look for "local lookup", and also what namespace to look in for
a partial specifier. For example a template in an addon's `src` tree can
invoke components and helpers in that tree becuase it has a `source`
argu... | FEATURES.md | @@ -43,9 +43,8 @@ for a detailed explanation.
([RFC](https://github.com/dgeb/rfcs/blob/module-unification/text/0000-module-unification.md))
to Ember. This includes:
- - Passing the `source` of a `lookup`/`factoryFor` call as the second argument
- to an Ember resolver's `resolve` method (as a positional arg ... | true |
Other | emberjs | ember.js | cfaa47e48b0d6badb5e84419f117a46fd2f2ae8e.json | Introduce source to injections
Ember templates use a `source` argument to the container. This hints
where to look for "local lookup", and also what namespace to look in for
a partial specifier. For example a template in an addon's `src` tree can
invoke components and helpers in that tree becuase it has a `source`
argu... | packages/container/lib/container.js | @@ -130,8 +130,8 @@ export default class Container {
return { [OWNER]: this.owner };
}
- _resolverCacheKey(name, options) {
- return this.registry.resolverCacheKey(name, options);
+ _resolverCacheKey(name) {
+ return this.registry.resolverCacheKey(name);
}
/**
@@ -168,29 +168,7 @@ export defau... | true |
Other | emberjs | ember.js | cfaa47e48b0d6badb5e84419f117a46fd2f2ae8e.json | Introduce source to injections
Ember templates use a `source` argument to the container. This hints
where to look for "local lookup", and also what namespace to look in for
a partial specifier. For example a template in an addon's `src` tree can
invoke components and helpers in that tree becuase it has a `source`
argu... | packages/container/lib/registry.js | @@ -151,9 +151,10 @@ export default class Registry {
assert(`Attempting to register an unknown factory: '${fullName}'`, factory !== undefined);
let normalizedName = this.normalize(fullName);
- assert(`Cannot re-register: '${fullName}', as it has already been resolved.`, !this._resolveCache[normalizedName... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.