language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | a4fc9a5cdc9dacca9aa5e179d1885abb10e5c91a.json | start meta package
add types and change imports | packages/ember-metal/lib/watching.js | @@ -4,7 +4,7 @@
import { watchKey, unwatchKey } from './watch_key';
import { watchPath, unwatchPath } from './watch_path';
import { isPath } from './path_cache';
-import { peekMeta } from './meta';
+import { peekMeta } from 'ember-meta';
/**
Starts watching a property on an object. Whenever the property change... | true |
Other | emberjs | ember.js | d5a9092c3f97290fa40e65b15d03015909f98587.json | Fix browserstack tests. | testem.dist.js | @@ -100,7 +100,7 @@ module.exports = {
'--b',
'safari',
'--bv',
- '11',
+ 'latest',
'-t',
'1200',
'--u',
@@ -118,7 +118,7 @@ module.exports = {
'--b',
'safari',
'--bv',
- '10.1',
+ 'latest',
'-t',
... | false |
Other | emberjs | ember.js | 2eec20843c4f951eb52a32efeb06c57d6789509a.json | Add v3.2.0-beta.4 to CHANGELOG
[ci skip]
(cherry picked from commit 38cbfffda6dc04b6be4299eaa39848cca98c7a3d) | CHANGELOG.md | @@ -1,5 +1,10 @@
# Ember Changelog
+### v3.2.0-beta.4 (May 7, 2018)
+- [#16597](https://github.com/emberjs/ember.js/pull/16597) [BUGFIX] Ensure `Ember.run.cancelTimers` is present.
+- [#16605](https://github.com/emberjs/ember.js/pull/16605) [BUGFIX] Use resetCache on container destroy
+- [#16615](https://github.com/... | false |
Other | emberjs | ember.js | 53a0166abc45632c78c7d065cc619873ac59513b.json | Add v3.1.2 and v3.1.1 to CHANGELOG.
[ci skip] | CHANGELOG.md | @@ -32,6 +32,12 @@
- [#16462](https://github.com/emberjs/ember.js/pull/16462) [CLEANUP] Remove deprecated `MODEL_FACTORY_INJECTIONS`
- [emberjs/rfcs#286](https://github.com/emberjs/rfcs/blob/master/text/0286-block-let-template-helper.md) [FEATURE] Enabled block `let` handlebars helper by default.
+### v3.1.2 (May 7... | false |
Other | emberjs | ember.js | d9ec0aac21a72e4fcb203ce0dd426a3db64fa8b8.json | Update code-quality to avoid needless build. | .travis.yml | @@ -74,6 +74,9 @@ jobs:
env: TEST_SUITE=each-package-tests
- env: TEST_SUITE=code-quality
+ script:
+ # avoiding `yarn test` here because pretest does a build, which isn't needed
+ - node bin/run-tests.js
- stage: additional tests
| false |
Other | emberjs | ember.js | 8ef863f10275318241bc6cc33a7ff1517b052ce7.json | fix template only components | packages/ember/tests/component_registration_test.js | @@ -3,6 +3,7 @@ import Controller from '@ember/controller';
import { Component } from 'ember-glimmer';
import { compile } from 'ember-template-compiler';
import { moduleFor, ApplicationTestCase } from 'internal-test-helpers';
+import { ENV } from 'ember-environment';
moduleFor(
'Application Lifecycle - Compone... | false |
Other | emberjs | ember.js | 22ae321e3a671a66b8efc519e9183d6cc1fa30aa.json | move function meta data to WeakMap and WeakSet | packages/ember-metal/lib/events.js | @@ -3,6 +3,7 @@
*/
import { ENV } from 'ember-environment';
import { assert, deprecate } from '@ember/debug';
+import { setListeners } from 'ember-utils';
import { meta as metaFor, peekMeta } from './meta';
/*
@@ -196,6 +197,6 @@ export function on(...args) {
events.length > 0 && events.every(p => typeof p ... | true |
Other | emberjs | ember.js | 22ae321e3a671a66b8efc519e9183d6cc1fa30aa.json | move function meta data to WeakMap and WeakSet | packages/ember-metal/lib/mixin.js | @@ -2,7 +2,16 @@
@module @ember/object
*/
import { assign } from '@ember/polyfills';
-import { guidFor, ROOT, wrap, makeArray, NAME_KEY } from 'ember-utils';
+import {
+ guidFor,
+ ROOT,
+ wrap,
+ makeArray,
+ NAME_KEY,
+ getObservers,
+ getListeners,
+ setObservers,
+} from 'ember-utils';
import { assert }... | true |
Other | emberjs | ember.js | 22ae321e3a671a66b8efc519e9183d6cc1fa30aa.json | move function meta data to WeakMap and WeakSet | packages/ember-utils/index.ts | @@ -12,7 +12,15 @@ export { default as symbol, isInternalSymbol } from './lib/symbol';
export { default as dictionary } from './lib/dictionary';
export { uuid, GUID_KEY, generateGuid, guidFor } from './lib/guid';
export { default as intern } from './lib/intern';
-export { checkHasSuper, ROOT, wrap } from './lib/supe... | true |
Other | emberjs | ember.js | 22ae321e3a671a66b8efc519e9183d6cc1fa30aa.json | move function meta data to WeakMap and WeakSet | packages/ember-utils/lib/super.ts | @@ -1,3 +1,5 @@
+import WeakSet from './weak_set';
+
const HAS_SUPER_PATTERN = /\.(_super|call\(this|apply\(this)/;
const fnToString = Function.prototype.toString;
@@ -20,19 +22,46 @@ export const checkHasSuper = (() => {
};
})();
-export const ROOT = function ROOT() {} as {
- (): void;
- __hasSuper: boolea... | true |
Other | emberjs | ember.js | 856c5356a0d94bf46fb64fc0fd705306f8feb2b6.json | add a comma | packages/ember-runtime/lib/system/array_proxy.js | @@ -60,7 +60,7 @@ const ARRAY_OBSERVER_MAPPING = {
ap.get('firstObject'); // . 'DOG'
```
- When overriding this class it is important to place the call to
+ When overriding this class, it is important to place the call to
`_super` *after* setting `content` so the internal observers have
a chance to fire... | false |
Other | emberjs | ember.js | 2be3c32b34f63af631aaa39bb3c41b5d16afd106.json | use es6 default parameter wherever possible | packages/@ember/runloop/tests/later_test.js | @@ -1,15 +1,12 @@
import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
import { assign } from '@ember/polyfills';
-import { isNone } from 'ember-metal';
import { run, later, backburner, hasScheduledTimers, getCurrentRunLoop } from '..';
const originalSetTimeout = window.setTimeout;
const original... | true |
Other | emberjs | ember.js | 2be3c32b34f63af631aaa39bb3c41b5d16afd106.json | use es6 default parameter wherever possible | packages/ember-runtime/lib/mixins/array.js | @@ -9,7 +9,6 @@ import {
objectAt,
replaceInNativeArray,
computed,
- isNone,
aliasMethod,
Mixin,
hasListeners,
@@ -226,17 +225,15 @@ const ArrayMixin = Mixin.create(Enumerable, {
@return {Array} New array with specified slice
@public
*/
- slice(beginIndex, endIndex) {
+ slice(beginInde... | true |
Other | emberjs | ember.js | 2be3c32b34f63af631aaa39bb3c41b5d16afd106.json | use es6 default parameter wherever possible | packages/ember-runtime/lib/mixins/observable.js | @@ -18,7 +18,6 @@ import {
addObserver,
removeObserver,
getCachedValueFor,
- isNone,
} from 'ember-metal';
import { assert } from '@ember/debug';
@@ -419,10 +418,7 @@ export default Mixin.create({
@return {Number} The new property value
@public
*/
- incrementProperty(keyName, increment) {
- ... | true |
Other | emberjs | ember.js | 2cd2605db2643506f1a3bb5d9ad3447eaeb9a893.json | Add v3.1.1 to CHANGELOG
[ci skip]
(cherry picked from commit 508277bfcecddab6af233a89d2e7d7a5279f8aaf) | CHANGELOG.md | @@ -32,6 +32,17 @@
- [#16462](https://github.com/emberjs/ember.js/pull/16462) [CLEANUP] Remove deprecated `MODEL_FACTORY_INJECTIONS`
- [emberjs/rfcs#286](https://github.com/emberjs/rfcs/blob/master/text/0286-block-let-template-helper.md) [FEATURE] Enabled block `let` handlebars helper by default.
+### v3.1.1 (April... | false |
Other | emberjs | ember.js | 7f310a6185aabf5a4b828ca64f78b0a22e3a8b74.json | Add 3.2.0-beta.3 to CHANGELOG
[ci skip]
(cherry picked from commit f894ff5d0662cc105ea4bd5e5b4f272045b7bbe8) | CHANGELOG.md | @@ -1,5 +1,16 @@
# Ember Changelog
+### v3.2.0-beta.3 (April 23, 2018)
+- [#16539](https://github.com/emberjs/ember.js/pull/16539) [BUGFIX] Ember is already registered by the libraries registry already.
+- [#16559](https://github.com/emberjs/ember.js/pull/16559) [BUGFIX] Fix property normalization, Update glimmer-vm... | false |
Other | emberjs | ember.js | d8c983448cbcd419c7bde408ee550fcbf09be538.json | fix conditions in `lib/name` | packages/ember-utils/lib/name.ts | @@ -1,9 +1,9 @@
const NAMES = new WeakMap();
export function setName(obj: object, name: string) {
- if (obj !== null || typeof obj === 'object' || typeof obj === 'function') NAMES.set(obj, name);
+ if ((obj !== null && typeof obj === 'object') || typeof obj === 'function') NAMES.set(obj, name);
}
export funct... | false |
Other | emberjs | ember.js | f8adb1fdc1059127b1b66fb2a33b017f2ffe2e34.json | use hash for `seen` in `Unique` | packages/ember-glimmer/lib/utils/iterable.ts | @@ -139,18 +139,15 @@ class ObjectIterator extends BoundedIterator {
let keys: Opaque[] = [];
let values: Opaque[] = [];
let length = 0;
-
let isMapLike = false;
obj.forEach((value: Opaque, key: Opaque) => {
isMapLike = isMapLike || arguments.length >= 2;
if (isMapLike) {
... | false |
Other | emberjs | ember.js | e1c8e4fe41ad1856cba8a491d18229118ec8fb36.json | Update glimmer-vm to 0.33.7. | package.json | @@ -66,14 +66,14 @@
"resolve": "^1.6.0"
},
"devDependencies": {
- "@glimmer/compiler": "0.33.6",
+ "@glimmer/compiler": "0.33.7",
"@glimmer/env": "^0.1.7",
- "@glimmer/interfaces": "0.33.6",
- "@glimmer/node": "0.33.6",
- "@glimmer/opcode-compiler": "0.33.6",
- "@glimmer/program": "0.3... | true |
Other | emberjs | ember.js | e1c8e4fe41ad1856cba8a491d18229118ec8fb36.json | Update glimmer-vm to 0.33.7. | yarn.lock | @@ -2,105 +2,105 @@
# yarn lockfile v1
-"@glimmer/compiler@0.33.6":
- version "0.33.6"
- resolved "https://registry.yarnpkg.com/@glimmer/compiler/-/compiler-0.33.6.tgz#bb5948a7035f13a2c8406abffa89504d1a98ac51"
+"@glimmer/compiler@0.33.7":
+ version "0.33.7"
+ resolved "https://registry.yarnpkg.com/@glimmer/com... | true |
Other | emberjs | ember.js | 37d0294d68fd83cca0819087f2ba8216e4e0f4ac.json | Move Cache from ember-metal to ember-utils.
Also remove usage of `UNDEFINED` symbol (just use Map behaviors). | packages/@ember/string/index.js | @@ -5,7 +5,7 @@
export { getStrings as _getStrings, setStrings as _setStrings } from './lib/string_registry';
import { ENV } from 'ember-environment';
-import { Cache } from 'ember-metal';
+import { Cache } from 'ember-utils';
import { getString } from './lib/string_registry';
const STRING_DASHERIZE_REGEXP = /[... | true |
Other | emberjs | ember.js | 37d0294d68fd83cca0819087f2ba8216e4e0f4ac.json | Move Cache from ember-metal to ember-utils.
Also remove usage of `UNDEFINED` symbol (just use Map behaviors). | packages/ember-metal/index.d.ts | @@ -27,15 +27,5 @@ export function isNone(obj: any): boolean;
export function watchKey(obj: any, keyName: string, meta?: any): void;
-export class Cache<T, V> {
- constructor(
- limit: number,
- func: (obj: T) => V,
- key?: (obj: T) => string,
- store?: any
- );
- get(obj: T): V;
-}
-
export { tagF... | true |
Other | emberjs | ember.js | 37d0294d68fd83cca0819087f2ba8216e4e0f4ac.json | Move Cache from ember-metal to ember-utils.
Also remove usage of `UNDEFINED` symbol (just use Map behaviors). | packages/ember-metal/index.js | @@ -9,7 +9,6 @@ export {
export { default as alias } from './lib/alias';
export { deprecateProperty } from './lib/deprecate_property';
export { descriptorFor, meta, peekMeta, deleteMeta } from './lib/meta';
-export { default as Cache } from './lib/cache';
export { PROXY_CONTENT, _getPath, get, getWithDefault } from... | true |
Other | emberjs | ember.js | 37d0294d68fd83cca0819087f2ba8216e4e0f4ac.json | Move Cache from ember-metal to ember-utils.
Also remove usage of `UNDEFINED` symbol (just use Map behaviors). | packages/ember-metal/lib/cache.js | @@ -1,55 +0,0 @@
-import { UNDEFINED } from './meta';
-
-export default class Cache {
- constructor(limit, func, key, store) {
- this.size = 0;
- this.misses = 0;
- this.hits = 0;
- this.limit = limit;
- this.func = func;
- this.key = key;
- this.store = store || new Map();
- }
-
- get(obj) {
- ... | true |
Other | emberjs | ember.js | 37d0294d68fd83cca0819087f2ba8216e4e0f4ac.json | Move Cache from ember-metal to ember-utils.
Also remove usage of `UNDEFINED` symbol (just use Map behaviors). | packages/ember-metal/lib/path_cache.js | @@ -1,4 +1,4 @@
-import Cache from './cache';
+import { Cache } from 'ember-utils';
const firstDotIndexCache = new Cache(1000, key => key.indexOf('.'));
| true |
Other | emberjs | ember.js | 37d0294d68fd83cca0819087f2ba8216e4e0f4ac.json | Move Cache from ember-metal to ember-utils.
Also remove usage of `UNDEFINED` symbol (just use Map behaviors). | packages/ember-utils/index.ts | @@ -23,6 +23,7 @@ export { HAS_NATIVE_SYMBOL } from './lib/symbol-utils';
export { HAS_NATIVE_PROXY } from './lib/proxy-utils';
export { default as WeakSet } from './lib/weak_set';
export { isProxy, setProxy } from './lib/is_proxy';
+export { default as Cache } from './lib/cache';
import symbol from './lib/symbol... | true |
Other | emberjs | ember.js | 37d0294d68fd83cca0819087f2ba8216e4e0f4ac.json | Move Cache from ember-metal to ember-utils.
Also remove usage of `UNDEFINED` symbol (just use Map behaviors). | packages/ember-utils/lib/cache.ts | @@ -0,0 +1,39 @@
+export default class Cache<T, V> {
+ public size = 0;
+ public misses = 0;
+ public hits = 0;
+
+ constructor(private limit: number, private func: (obj: T) => V, private store?: any) {
+ this.store = store || new Map();
+ }
+
+ get(key: T): V {
+ let value = this.store.get(key);
+ if (t... | true |
Other | emberjs | ember.js | 37d0294d68fd83cca0819087f2ba8216e4e0f4ac.json | Move Cache from ember-metal to ember-utils.
Also remove usage of `UNDEFINED` symbol (just use Map behaviors). | packages/ember-utils/tests/cache_test.js | @@ -44,28 +44,6 @@ moduleFor(
assert.equal(count, 2);
}
- ['@test caches computation correctly with custom cache keys'](assert) {
- let count = 0;
- let cache = new Cache(
- 100,
- obj => {
- count++;
- return obj.value.toUpperCase();
- },
- obj =... | true |
Other | emberjs | ember.js | 37d0294d68fd83cca0819087f2ba8216e4e0f4ac.json | Move Cache from ember-metal to ember-utils.
Also remove usage of `UNDEFINED` symbol (just use Map behaviors). | packages/ember/index.js | @@ -189,6 +189,7 @@ Ember.tryInvoke = utils.tryInvoke;
Ember.wrap = utils.wrap;
Ember.uuid = utils.uuid;
Ember.NAME_KEY = utils.NAME_KEY;
+Ember._Cache = utils.Cache;
// ****container****
Ember.Container = Container;
@@ -264,7 +265,7 @@ Ember._getPath = metal._getPath;
Ember.set = metal.set;
Ember.trySet = met... | true |
Other | emberjs | ember.js | 37d0294d68fd83cca0819087f2ba8216e4e0f4ac.json | Move Cache from ember-metal to ember-utils.
Also remove usage of `UNDEFINED` symbol (just use Map behaviors). | packages/ember/tests/reexports_test.js | @@ -101,7 +101,7 @@ let allExports = [
['_getPath', 'ember-metal'],
['getWithDefault', 'ember-metal'],
['trySet', 'ember-metal'],
- ['_Cache', 'ember-metal', 'Cache'],
+ ['_Cache', 'ember-utils', 'Cache'],
['on', 'ember-metal'],
['addListener', 'ember-metal'],
['removeListener', 'ember-metal'], | true |
Other | emberjs | ember.js | 3db7357a47731a448f7b51d23cfb16c75b9a3e59.json | remove unused isDescriptorTrap | packages/ember-metal/lib/meta.js | @@ -673,12 +673,6 @@ if (DEBUG) {
meta._counters = counters;
}
-// Using `symbol()` here causes some node test to fail, presumably
-// because we define the CP with one copy of Ember and boot the app
-// with a different copy, so the random key we generate do not line
-// up. Is that testing a legit scenario?
-ex... | false |
Other | emberjs | ember.js | e64390d6f2044cb43466333e1a93b1074cc29498.json | remove EMBER_METAL_ES5_GETTER flag | broccoli/features.js | @@ -21,9 +21,6 @@ function getFeatures(isDebug) {
}
}
- features['descriptor-trap'] = isDebug;
- features['mandatory-getter'] = isDebug;
- features['mandatory-setter'] = isDebug;
features['ember-glimmer-detect-backtracking-rerender'] = isDebug;
return features; | true |
Other | emberjs | ember.js | e64390d6f2044cb43466333e1a93b1074cc29498.json | remove EMBER_METAL_ES5_GETTER flag | features.json | @@ -4,7 +4,6 @@
"ember-libraries-isregistered": null,
"ember-improved-instrumentation": null,
"ember-glimmer-named-arguments": true,
- "ember-metal-es5-getters": true,
"ember-routing-router-service": true,
"ember-engines-mount-params": true,
"ember-module-unification": null, | true |
Other | emberjs | ember.js | e64390d6f2044cb43466333e1a93b1074cc29498.json | remove EMBER_METAL_ES5_GETTER flag | packages/ember-glimmer/externs.d.ts | @@ -4,5 +4,4 @@ declare module 'ember/features' {
export const GLIMMER_CUSTOM_COMPONENT_MANAGER: boolean | null;
export const EMBER_ENGINES_MOUNT_PARAMS: boolean | null;
export const EMBER_GLIMMER_DETECT_BACKTRACKING_RERENDER: boolean | null;
- export const MANDATORY_SETTER: boolean | null;
} | true |
Other | emberjs | ember.js | e64390d6f2044cb43466333e1a93b1074cc29498.json | remove EMBER_METAL_ES5_GETTER flag | packages/ember-glimmer/lib/utils/references.ts | @@ -22,7 +22,7 @@ import {
import { Option } from '@glimmer/util';
import { didRender, get, set, tagFor, tagForProperty, watchKey } from 'ember-metal';
import { isProxy, symbol } from 'ember-utils';
-import { EMBER_GLIMMER_DETECT_BACKTRACKING_RERENDER, MANDATORY_SETTER } from 'ember/features';
+import { EMBER_GLIMME... | true |
Other | emberjs | ember.js | e64390d6f2044cb43466333e1a93b1074cc29498.json | remove EMBER_METAL_ES5_GETTER flag | packages/ember-glimmer/tests/integration/components/curly-components-test.js | @@ -1,4 +1,5 @@
import { run } from '@ember/runloop';
+import { DEBUG } from '@glimmer/env';
/* globals EmberDev */
import { set, get, observer, on, computed } from 'ember-metal';
import { Object as EmberObject, A as emberA, inject, Service } from 'ember-runtime';
@@ -8,7 +9,6 @@ import { Component, compile, htmlSa... | true |
Other | emberjs | ember.js | e64390d6f2044cb43466333e1a93b1074cc29498.json | remove EMBER_METAL_ES5_GETTER flag | packages/ember-metal/lib/meta.js | @@ -2,7 +2,6 @@ import { lookupDescriptor, symbol, toString } from 'ember-utils';
import { protoMethods as listenerMethods } from './meta_listeners';
import { assert } from 'ember-debug';
import { DEBUG } from '@glimmer/env';
-import { DESCRIPTOR_TRAP, EMBER_METAL_ES5_GETTERS, MANDATORY_SETTER } from 'ember/features... | true |
Other | emberjs | ember.js | e64390d6f2044cb43466333e1a93b1074cc29498.json | remove EMBER_METAL_ES5_GETTER flag | packages/ember-metal/lib/mixin.js | @@ -1,7 +1,6 @@
/**
@module @ember/object
*/
-import { EMBER_METAL_ES5_GETTERS } from 'ember/features';
import { assign } from '@ember/polyfills';
import { guidFor, ROOT, wrap, makeArray, NAME_KEY } from 'ember-utils';
import { assert } from 'ember-debug';
@@ -100,10 +99,7 @@ function giveMethodSuper(obj, key, me... | true |
Other | emberjs | ember.js | e64390d6f2044cb43466333e1a93b1074cc29498.json | remove EMBER_METAL_ES5_GETTER flag | packages/ember-metal/lib/properties.js | @@ -3,10 +3,10 @@
*/
import { assert } from 'ember-debug';
-import { HAS_NATIVE_PROXY, HAS_NATIVE_SYMBOL } from 'ember-utils';
-import { descriptorFor, meta as metaFor, peekMeta, DESCRIPTOR, UNDEFINED } from './meta';
+import { DEBUG } from '@glimmer/env';
+import { descriptorFor, meta as metaFor, peekMeta, UNDEFIN... | true |
Other | emberjs | ember.js | e64390d6f2044cb43466333e1a93b1074cc29498.json | remove EMBER_METAL_ES5_GETTER flag | packages/ember-metal/lib/property_get.js | @@ -1,15 +1,10 @@
/**
@module @ember/object
*/
-
+import { DEBUG } from '@glimmer/env';
import { assert, deprecate } from 'ember-debug';
import { HAS_NATIVE_PROXY, symbol } from 'ember-utils';
-import {
- DESCRIPTOR_TRAP,
- EMBER_METAL_ES5_GETTERS,
- EMBER_METAL_TRACKED_PROPERTIES,
- MANDATORY_GETTER,
-} from ... | true |
Other | emberjs | ember.js | e64390d6f2044cb43466333e1a93b1074cc29498.json | remove EMBER_METAL_ES5_GETTER flag | packages/ember-metal/lib/property_set.js | @@ -1,12 +1,13 @@
import { toString } from 'ember-utils';
import EmberError from '@ember/error';
+import { DEBUG } from '@glimmer/env';
import { assert } from 'ember-debug';
import { getPossibleMandatoryProxyValue, _getPath as getPath } from './property_get';
import { notifyPropertyChange } from './property_events... | true |
Other | emberjs | ember.js | e64390d6f2044cb43466333e1a93b1074cc29498.json | remove EMBER_METAL_ES5_GETTER flag | packages/ember-metal/lib/watch_key.js | @@ -1,5 +1,5 @@
import { lookupDescriptor } from 'ember-utils';
-import { MANDATORY_SETTER } from 'ember/features';
+import { DEBUG } from '@glimmer/env';
import { descriptorFor, isDescriptor, meta as metaFor, peekMeta, UNDEFINED } from './meta';
import {
MANDATORY_SETTER_FUNCTION,
@@ -26,14 +26,14 @@ export func... | true |
Other | emberjs | ember.js | e64390d6f2044cb43466333e1a93b1074cc29498.json | remove EMBER_METAL_ES5_GETTER flag | packages/ember-metal/tests/accessors/mandatory_setters_test.js | @@ -1,4 +1,4 @@
-import { MANDATORY_SETTER } from 'ember/features';
+import { DEBUG } from '@glimmer/env';
import { get, set, watch, unwatch, meta as metaFor } from '../..';
import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
@@ -14,7 +14,7 @@ function hasMetaValue(object, property) {
return met... | true |
Other | emberjs | ember.js | e64390d6f2044cb43466333e1a93b1074cc29498.json | remove EMBER_METAL_ES5_GETTER flag | packages/ember-metal/tests/computed_test.js | @@ -1,4 +1,4 @@
-import { DESCRIPTOR_TRAP, EMBER_METAL_ES5_GETTERS } from 'ember/features';
+import { DEBUG } from '@glimmer/env';
import { Object as EmberObject } from 'ember-runtime';
import {
ComputedProperty,
@@ -46,29 +46,26 @@ moduleFor(
}
['@test computed property can be accessed without `get`']... | true |
Other | emberjs | ember.js | e64390d6f2044cb43466333e1a93b1074cc29498.json | remove EMBER_METAL_ES5_GETTER flag | packages/ember-runtime/lib/system/core_object.js | @@ -35,7 +35,6 @@ import { validatePropertyInjections } from '../inject';
import { assert } from 'ember-debug';
import { DEBUG } from '@glimmer/env';
import { ENV } from 'ember-environment';
-import { MANDATORY_GETTER, MANDATORY_SETTER, EMBER_METAL_ES5_GETTERS } from 'ember/features';
const applyMixin = Mixin._ap... | true |
Other | emberjs | ember.js | e64390d6f2044cb43466333e1a93b1074cc29498.json | remove EMBER_METAL_ES5_GETTER flag | packages/ember-runtime/tests/system/object/create_test.js | @@ -1,6 +1,6 @@
import { getOwner, setOwner } from 'ember-owner';
import { computed, Mixin, observer } from 'ember-metal';
-import { MANDATORY_SETTER } from 'ember/features';
+import { DEBUG } from '@glimmer/env';
import EmberObject from '../../../lib/system/object';
import { moduleFor, AbstractTestCase } from 'int... | true |
Other | emberjs | ember.js | e64390d6f2044cb43466333e1a93b1074cc29498.json | remove EMBER_METAL_ES5_GETTER flag | packages/ember-runtime/tests/system/object/destroy_test.js | @@ -8,7 +8,7 @@ import {
peekMeta,
} from 'ember-metal';
import EmberObject from '../../../lib/system/object';
-import { MANDATORY_SETTER } from 'ember/features';
+import { DEBUG } from '@glimmer/env';
import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
moduleFor(
@@ -36,7 +36,7 @@ moduleFor(
... | true |
Other | emberjs | ember.js | e64390d6f2044cb43466333e1a93b1074cc29498.json | remove EMBER_METAL_ES5_GETTER flag | packages/ember-runtime/tests/system/object_proxy_test.js | @@ -1,6 +1,6 @@
+import { DEBUG } from '@glimmer/env';
import { addObserver, computed, get, set, isWatching, removeObserver } from 'ember-metal';
import { HAS_NATIVE_PROXY } from 'ember-utils';
-import { MANDATORY_GETTER, EMBER_METAL_ES5_GETTERS } from 'ember/features';
import ObjectProxy from '../../lib/system/obje... | true |
Other | emberjs | ember.js | e64390d6f2044cb43466333e1a93b1074cc29498.json | remove EMBER_METAL_ES5_GETTER flag | packages/ember/tests/service_injection_test.js | @@ -3,7 +3,7 @@ import Controller from '@ember/controller';
import { inject, Service, _ProxyMixin } from 'ember-runtime';
import { moduleFor, ApplicationTestCase } from 'internal-test-helpers';
import { computed } from 'ember-metal';
-import { EMBER_METAL_ES5_GETTERS, EMBER_MODULE_UNIFICATION } from 'ember/features'... | true |
Other | emberjs | ember.js | 8cb2c6b27e68c30f1528a55970a943eee1a6a9f2.json | fix template compiler | ember-cli-build.js | @@ -96,6 +96,8 @@ module.exports = function() {
'container/lib/**',
'ember-environment/index.js',
'ember-environment/lib/**',
+ 'ember-browser-environment/index.js',
+ 'ember-browser-environment/lib/**',
'ember-glimmer/index.js',
'ember-glimmer/lib/**',
... | false |
Other | emberjs | ember.js | c77ddd2edbaf5595c4ddbea114a7eda50c55a727.json | Add v3.2.0-beta.2 to CHANGELOG
[ci skip]
(cherry picked from commit b66cd523fae329800f4b5f2580d4c925ccfb874f) | CHANGELOG.md | @@ -1,5 +1,15 @@
# Ember Changelog
+### v3.2.0-beta.2 (April 16, 2018)
+
+- [#16493](https://github.com/emberjs/ember.js/pull/16493) [BUGFIX] Ensure proxies have access to `getOwner(this)`.
+- [#16494](https://github.com/emberjs/ember.js/pull/16494) [BUGFIX] Adjust assertion to allow for either undefined or null
+- ... | false |
Other | emberjs | ember.js | 9e17a486e599f9f1b0e6d8d0b9910b1936ef73aa.json | Convert ember-environment to typescript. | packages/ember-environment/index.d.ts | @@ -1,16 +0,0 @@
-export const environment: {
- hasDOM: boolean;
- isChrome: boolean;
- isFirefox: boolean;
- location: Location | null;
- history: History | null;
- userAgent: string;
- window: Window | null;
-};
-
-export const ENV: {
- _ENABLE_DID_INIT_ATTRS_SUPPORT: boolean;
- _APPLICATION_TEMPLATE_WRAPPER... | true |
Other | emberjs | ember.js | 9e17a486e599f9f1b0e6d8d0b9910b1936ef73aa.json | Convert ember-environment to typescript. | packages/ember-environment/index.ts | @@ -0,0 +1,3 @@
+export * from './lib/context';
+export * from './lib/env';
+export * from './lib/has-dom'; | true |
Other | emberjs | ember.js | 9e17a486e599f9f1b0e6d8d0b9910b1936ef73aa.json | Convert ember-environment to typescript. | packages/ember-environment/lib/context.ts | @@ -0,0 +1,32 @@
+import global from './global';
+
+export interface GlobalContext {
+ imports: object;
+ exports: object;
+ lookup: object;
+}
+
+// legacy imports/exports/lookup stuff (should we keep this??)
+export const context = (function(
+ global: object,
+ Ember: Partial<GlobalContext> | undefined
+): Glob... | true |
Other | emberjs | ember.js | 9e17a486e599f9f1b0e6d8d0b9910b1936ef73aa.json | Convert ember-environment to typescript. | packages/ember-environment/lib/env.ts | @@ -1,5 +1,22 @@
-import global from './lib/global';
-import { defaultFalse, defaultTrue, normalizeExtendPrototypes } from './lib/utils';
+import global from './global';
+import { defaultFalse, defaultTrue, normalizeExtendPrototypes } from './utils';
+
+export interface Environment {
+ ENABLE_ALL_FEATURES: boolean;
+ ... | true |
Other | emberjs | ember.js | 9e17a486e599f9f1b0e6d8d0b9910b1936ef73aa.json | Convert ember-environment to typescript. | packages/ember-environment/lib/global.ts | @@ -1,18 +1,19 @@
/* globals global, window, self, mainContext */
+declare const mainContext: object | undefined;
// from lodash to catch fake globals
-function checkGlobal(value) {
+function checkGlobal(value: any | null | undefined): value is object {
return value && value.Object === Object ? value : undefined... | true |
Other | emberjs | ember.js | 9e17a486e599f9f1b0e6d8d0b9910b1936ef73aa.json | Convert ember-environment to typescript. | packages/ember-environment/lib/has-dom.ts | @@ -0,0 +1,33 @@
+import { ENV } from './env';
+import global from './global';
+
+// check if window exists and actually is the global
+const hasDOM =
+ typeof window !== 'undefined' &&
+ window === global &&
+ window.document &&
+ window.document.createElement &&
+ !(ENV as any).disableBrowserEnvironment; // is t... | true |
Other | emberjs | ember.js | 9e17a486e599f9f1b0e6d8d0b9910b1936ef73aa.json | Convert ember-environment to typescript. | packages/ember-environment/lib/utils.js | @@ -1,21 +0,0 @@
-export function defaultTrue(v) {
- return v === false ? false : true;
-}
-
-export function defaultFalse(v) {
- return v === true ? true : false;
-}
-
-export function normalizeExtendPrototypes(obj) {
- if (obj === false) {
- return { String: false, Array: false, Function: false };
- } else if ... | true |
Other | emberjs | ember.js | 9e17a486e599f9f1b0e6d8d0b9910b1936ef73aa.json | Convert ember-environment to typescript. | packages/ember-environment/lib/utils.ts | @@ -0,0 +1,21 @@
+export function defaultTrue(v: any | undefined | null) {
+ return v === false ? false : true;
+}
+
+export function defaultFalse(v: any | undefined | null) {
+ return v === true ? true : false;
+}
+
+export function normalizeExtendPrototypes(obj: any | undefined | null) {
+ if (obj === false) {
+ ... | true |
Other | emberjs | ember.js | e5d33f60b33d48eecc19e04c2d84b39701604add.json | Move Ember.Engine to @ember/engine. | packages/@ember/application/lib/application.js | @@ -21,7 +21,7 @@ import {
BucketCache,
} from 'ember-routing';
import ApplicationInstance from '@ember/application/instance';
-import { Engine } from 'ember-application';
+import Engine from '@ember/engine';
import { privatize as P } from 'container';
import { setupApplicationRegistry } from 'ember-glimmer';
i... | true |
Other | emberjs | ember.js | e5d33f60b33d48eecc19e04c2d84b39701604add.json | Move Ember.Engine to @ember/engine. | packages/@ember/application/tests/application_instance_test.js | @@ -1,4 +1,4 @@
-import { Engine } from 'ember-application';
+import Engine from '@ember/engine';
import Application from '@ember/application';
import ApplicationInstance from '@ember/application/instance';
import { run } from '@ember/runloop'; | true |
Other | emberjs | ember.js | e5d33f60b33d48eecc19e04c2d84b39701604add.json | Move Ember.Engine to @ember/engine. | packages/@ember/application/tests/visit_test.js | @@ -3,7 +3,7 @@ import { Object as EmberObject, inject, RSVP, onerrorDefault } from 'ember-runti
import { later } from '@ember/runloop';
import Application from '@ember/application';
import ApplicationInstance from '@ember/application/instance';
-import { Engine } from 'ember-application';
+import Engine from '@embe... | true |
Other | emberjs | ember.js | e5d33f60b33d48eecc19e04c2d84b39701604add.json | Move Ember.Engine to @ember/engine. | packages/@ember/engine/index.js | @@ -8,7 +8,7 @@ import DAG from 'dag-map';
import { assert } from 'ember-debug';
import { get, set } from 'ember-metal';
import DefaultResolver from '@ember/application/globals-resolver';
-import EngineInstance from './engine-instance';
+import { EngineInstance } from 'ember-application';
import { RoutingService } ... | true |
Other | emberjs | ember.js | e5d33f60b33d48eecc19e04c2d84b39701604add.json | Move Ember.Engine to @ember/engine. | packages/@ember/engine/tests/engine_initializers_test.js | @@ -1,5 +1,5 @@
import { run } from '@ember/runloop';
-import Engine from '../../lib/system/engine';
+import Engine from '@ember/engine';
import { moduleFor, AbstractTestCase as TestCase } from 'internal-test-helpers';
let MyEngine, myEngine, myEngineInstance; | true |
Other | emberjs | ember.js | e5d33f60b33d48eecc19e04c2d84b39701604add.json | Move Ember.Engine to @ember/engine. | packages/@ember/engine/tests/engine_test.js | @@ -1,9 +1,12 @@
import { context } from 'ember-environment';
import { run } from '@ember/runloop';
-import Engine from '../../lib/system/engine';
+import Engine from '@ember/engine';
import { Object as EmberObject } from 'ember-runtime';
import { privatize as P } from 'container';
-import { verifyInjection, verify... | true |
Other | emberjs | ember.js | e5d33f60b33d48eecc19e04c2d84b39701604add.json | Move Ember.Engine to @ember/engine. | packages/ember-application/index.js | @@ -1,3 +1,2 @@
-export { default as Engine } from './lib/system/engine';
export { default as EngineInstance } from './lib/system/engine-instance';
export { getEngineParent, setEngineParent } from './lib/system/engine-parent'; | true |
Other | emberjs | ember.js | e5d33f60b33d48eecc19e04c2d84b39701604add.json | Move Ember.Engine to @ember/engine. | packages/ember-application/tests/system/engine_instance_initializers_test.js | @@ -1,5 +1,5 @@
import { run } from '@ember/runloop';
-import Engine from '../../lib/system/engine';
+import Engine from '@ember/engine';
import EngineInstance from '../../lib/system/engine-instance';
import { setEngineParent } from '../../lib/system/engine-parent';
import { moduleFor, AbstractTestCase as TestCase ... | true |
Other | emberjs | ember.js | e5d33f60b33d48eecc19e04c2d84b39701604add.json | Move Ember.Engine to @ember/engine. | packages/ember-application/tests/system/engine_instance_test.js | @@ -1,4 +1,4 @@
-import Engine from '../../lib/system/engine';
+import Engine from '@ember/engine';
import EngineInstance from '../../lib/system/engine-instance';
import { getEngineParent, setEngineParent } from '../../lib/system/engine-parent';
import { run } from '@ember/runloop'; | true |
Other | emberjs | ember.js | e5d33f60b33d48eecc19e04c2d84b39701604add.json | Move Ember.Engine to @ember/engine. | packages/ember-glimmer/tests/integration/application/engine-test.js | @@ -3,7 +3,7 @@ import { strip } from '../../utils/abstract-test-case';
import { compile } from '../../utils/helpers';
import { Controller, RSVP } from 'ember-runtime';
import { Component } from 'ember-glimmer';
-import { Engine } from 'ember-application';
+import Engine from '@ember/engine';
import { Route } from ... | true |
Other | emberjs | ember.js | e5d33f60b33d48eecc19e04c2d84b39701604add.json | Move Ember.Engine to @ember/engine. | packages/ember-glimmer/tests/integration/mount-test.js | @@ -3,7 +3,8 @@ import { moduleFor, ApplicationTest, RenderingTest } from '../utils/test-case';
import { compile, Component } from '../utils/helpers';
import { Controller } from 'ember-runtime';
import { set } from 'ember-metal';
-import { Engine, getEngineParent } from 'ember-application';
+import Engine from '@emb... | true |
Other | emberjs | ember.js | e5d33f60b33d48eecc19e04c2d84b39701604add.json | Move Ember.Engine to @ember/engine. | packages/ember/index.js | @@ -109,6 +109,7 @@ import { getOwner, setOwner } from 'ember-owner';
import Application, { onLoad, runLoadHooks } from '@ember/application';
import Resolver from '@ember/application/globals-resolver';
import ApplicationInstance from '@ember/application/instance';
+import Engine from '@ember/engine';
// ****ember... | true |
Other | emberjs | ember.js | e5d33f60b33d48eecc19e04c2d84b39701604add.json | Move Ember.Engine to @ember/engine. | packages/ember/tests/reexports_test.js | @@ -265,7 +265,7 @@ let allExports = [
// ember-application
['Application', '@ember/application', 'default'],
['ApplicationInstance', '@ember/application/instance', 'default'],
- ['Engine', 'ember-application'],
+ ['Engine', '@ember/engine', 'default'],
['EngineInstance', 'ember-application'],
['Resolv... | true |
Other | emberjs | ember.js | e5d33f60b33d48eecc19e04c2d84b39701604add.json | Move Ember.Engine to @ember/engine. | packages/ember/tests/routing/decoupled_basic_test.js | @@ -10,7 +10,7 @@ import { run } from '@ember/runloop';
import { Mixin, computed, set, addObserver, observer } from 'ember-metal';
import { getTextOf } from 'internal-test-helpers';
import { Component } from 'ember-glimmer';
-import { Engine } from 'ember-application';
+import Engine from '@ember/engine';
import { ... | true |
Other | emberjs | ember.js | db08764fd0affda46dd068347e886597aef93cb1.json | Use function for externals in rolled up packages.
Instead of a hard coded list we swap to using a function with a "simple"
detection: if it starts with a `.` or `/` its internal otherwise its
external.
This prevents some pretty annoying issues when new externals are used
that aren't in the predefined list... | ember-cli-build.js | @@ -312,32 +312,6 @@ function glimmerDependenciesES() {
}
function rollupPackage(packagesES, name) {
- let externs = [
- '@glimmer/reference',
- '@glimmer/runtime',
- '@glimmer/node',
- '@glimmer/opcode-compiler',
- '@glimmer/program',
- '@glimmer/wire-format',
- '@glimmer/util',
- 'ember-c... | false |
Other | emberjs | ember.js | 67532742036d74e16e53e02da0559d56457da379.json | Reduce rollup rebuilds by restricting inputs... | ember-cli-build.js | @@ -338,7 +338,15 @@ function rollupPackage(packagesES, name) {
'backburner',
];
- return new Rollup(packagesES, {
+ // this prevents broccoli-rollup from "seeing" changes in
+ // its input that are unrelated to what we are building
+ // and therefore noop on rebuilds...
+ let rollupRestrictedInput = new... | false |
Other | emberjs | ember.js | 8a7318e9c0f3e58f1e9cc7a6ce591d6c83fcb351.json | Remove legacy packages structure. | bin/run-tests.js | @@ -6,15 +6,14 @@ var execa = require('execa');
var RSVP = require('rsvp');
var execFile = require('child_process').execFile;
var chalk = require('chalk');
-var FEATURES = require('../broccoli/features');
-var getPackages = require('../lib/packages');
var runInSequence = require('../lib/run-in-sequence');
var path... | true |
Other | emberjs | ember.js | 8a7318e9c0f3e58f1e9cc7a6ce591d6c83fcb351.json | Remove legacy packages structure. | lib/packages.js | @@ -1,101 +0,0 @@
-module.exports = function() {
- var packages = {
- container: {
- trees: null,
- requirements: ['ember-utils'],
- isTypeScript: true,
- vendorRequirements: ['@glimmer/di'],
- requiresJQuery: false,
- },
- 'ember-environment': {
- trees: null,
- requirement... | true |
Other | emberjs | ember.js | 31477ddc14b7e8fcc3ebeb7c69788aacdd0408d3.json | Simplify bundle building for non-production assets.
ember.debug.js, ember-template-compiler.js, and ember-testing.js | broccoli/packages.js | @@ -63,7 +63,7 @@ module.exports.qunit = function _qunit() {
module.exports.getPackagesES = function getPackagesES() {
let input = new Funnel(`packages`, {
- exclude: ['packages/node-module/**', 'packages/loader/**', 'packages/external-helpers/**'],
+ exclude: ['node-module/**', 'loader/**', 'external-helpe... | true |
Other | emberjs | ember.js | 31477ddc14b7e8fcc3ebeb7c69788aacdd0408d3.json | Simplify bundle building for non-production assets.
ember.debug.js, ember-template-compiler.js, and ember-testing.js | ember-cli-build.js | @@ -24,56 +24,63 @@ const {
backburnerES,
dagES,
routeRecognizerES,
- emberPkgES,
glimmerTrees,
nodeModuleUtils,
emberVersionES,
emberLicense,
emberFeaturesES,
nodeTests,
- rollupEmberMetal,
buildEmberEnvFlagsES,
getPackagesES,
} = require('./broccoli/packages');
-const SHOULD_ROLLUP... | true |
Other | emberjs | ember.js | 3cd99c8b24572978c625ffad7365d5c857407690.json | Add v3.2.0-beta.1 to CHANGELOG
[ci skip]
(cherry picked from commit e11e9d820c5fb17538fd10e4859aab7d3336bc03) | CHANGELOG.md | @@ -1,5 +1,16 @@
# Ember Changelog
+### v3.2.0-beta.1 (April 10, 2018)
+
+- [#16250](https://github.com/emberjs/ember.js/pull/16250) [DEPRECATION] Deprecation of `Ember.Logger`
+- [#16436](https://github.com/emberjs/ember.js/pull/16436) [BUGFIX] Refactor `CoreObject` to leverage native JS semantics.
+- [#16382](http... | false |
Other | emberjs | ember.js | b33720734607970789f936e7a4cd1426c440214a.json | Add v3.1.0 to CHANGELOG
[ci skip]
(cherry picked from commit 2a19b7be81029c21ace8411644be371c4a5aaf34) | CHANGELOG.md | @@ -1,42 +1,20 @@
# Ember Changelog
-### v3.1.0-beta.5 (March 12, 2018)
-- [#15601](https://github.com/emberjs/ember.js/pull/15601) [BUGFIX] Ensure Mixin.prototype.toString does not return constructor code
+### v3.1.0 (April 10, 2018)
+- [#16293](https://github.com/emberjs/ember.js/pull/16293) [BUGFIX] Ignore --pod ... | false |
Other | emberjs | ember.js | ff00bb2f7da6389ad043c6ba08f48d9e22d5bb64.json | Ensure publishing scripts are invoked properly. | bin/publish_builds | @@ -8,9 +8,9 @@ echo -e "PULL_REQUEST: ${TRAVIS_PULL_REQUEST}\n"
if [ "$TRAVIS_PULL_REQUEST" == "false" ] && [ "$PUBLISH" == "true" ]; then
- ./bin/build-for-publishing.js
+ node ./bin/build-for-publishing.js
- ./bin/publish_to_s3.js
+ node ./bin/publish_to_s3.js
#### NPM PUBLISHING
if [[ "$TRAVIS_TA... | false |
Other | emberjs | ember.js | b876d72bed76178bffc993d13f95f5060dbe40db.json | Fix lazy local import of bootstrapping module.
This was lazy required when the boostrapping was being done in
ember-glimmer, but now lives "together" so can use a normal import... | packages/ember-template-compiler/lib/system/initializer.js | @@ -1,4 +1,5 @@
import require, { has } from 'require';
+import bootstrap from './bootstrap';
// Globals mode template compiler
if (has('ember-application') && has('ember-environment') && has('ember-glimmer')) {
@@ -9,15 +10,11 @@ if (has('ember-application') && has('ember-environment') && has('ember-glimmer')
... | false |
Other | emberjs | ember.js | f96f8bb74d776c5fc0349a5745b7ee4ec9a3c615.json | Fix deep imports from external packages. | packages/ember-glimmer/tests/integration/components/contextual-components-test.js | @@ -3,7 +3,7 @@ import { Component } from '../../utils/helpers';
import { applyMixins, strip } from '../../utils/abstract-test-case';
import { moduleFor, RenderingTest } from '../../utils/test-case';
import { isEmpty } from 'ember-metal';
-import { A as emberA } from 'ember-runtime/mixins/array';
+import { A as embe... | true |
Other | emberjs | ember.js | f96f8bb74d776c5fc0349a5745b7ee4ec9a3c615.json | Fix deep imports from external packages. | packages/ember-glimmer/tests/integration/components/curly-components-test.js | @@ -1,7 +1,7 @@
/* globals EmberDev */
import { set, get, observer, on, computed, run } from 'ember-metal';
import { Object as EmberObject, A as emberA, inject, Service } from 'ember-runtime';
-import { jQueryDisabled } from 'ember-views/system/jquery';
+import { jQueryDisabled } from 'ember-views';
import { ENV } ... | true |
Other | emberjs | ember.js | f96f8bb74d776c5fc0349a5745b7ee4ec9a3c615.json | Fix deep imports from external packages. | packages/ember-glimmer/tests/integration/components/dynamic-components-test.js | @@ -1,5 +1,5 @@
import { set, computed } from 'ember-metal';
-import { jQueryDisabled } from 'ember-views/system/jquery';
+import { jQueryDisabled } from 'ember-views';
import { Component } from '../../utils/helpers';
import { strip } from '../../utils/abstract-test-case';
import { moduleFor, RenderingTest } from '... | true |
Other | emberjs | ember.js | 65f35c8a6e37785988c753f4328e9c27d5c6974b.json | Fix paths for ember-source addon.
The refactor to move `index.js` -> `lib/index.js` left this in a broken
state (the paths are incorrect and therefore the funnel threw an error
at build time). | lib/index.js | @@ -66,6 +66,7 @@ module.exports = {
files: ['jquery.js'],
});
+ let emberSourceDistPath = path.join(__dirname, '..', 'dist');
var emberFiles = [
'ember-runtime.js',
'ember-template-compiler.js',
@@ -81,12 +82,12 @@ module.exports = {
return flat.concat(jsAndMap);
}, ... | false |
Other | emberjs | ember.js | dfaa8676b0fa854e672692891afb26596da95ce1.json | clarify documentation for makeArray
Resolve #14741. | packages/ember-utils/lib/make-array.js | @@ -5,7 +5,7 @@ const { isArray } = Array;
/**
Forces the passed object to be part of an array. If the object is already
an array, it will return the object. Otherwise, it will add the object to
- an array. If obj is `null` or `undefined`, it will return an empty array.
+ an array. If object is `null` or `undefine... | false |
Other | emberjs | ember.js | a6ab4c692fd385b338fe837587c2cd1452010482.json | Remove unused code. | packages/ember-runtime/lib/system/application.js | @@ -1,3 +0,0 @@
-import Namespace from './namespace';
-
-export default Namespace.extend(); | true |
Other | emberjs | ember.js | a6ab4c692fd385b338fe837587c2cd1452010482.json | Remove unused code. | packages/ember-runtime/tests/system/application/base_test.js | @@ -1,12 +0,0 @@
-import Namespace from '../../../system/namespace';
-import Application from '../../../system/application';
-import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
-
-moduleFor(
- 'Ember.Application',
- class extends AbstractTestCase {
- ['@test Ember.Application should be a subclass... | true |
Other | emberjs | ember.js | 505dbe681943bc25d55b654f298f6723e3dcb1be.json | Update controllerName documentation
Update outdated route naming in `controllerName` documentation. | packages/ember-routing/lib/system/route.js | @@ -563,7 +563,7 @@ let Route = EmberObject.extend(ActionHandler, Evented, {
The name of the controller to associate with this route.
By default, Ember will lookup a route's controller that matches the name
- of the route (i.e. `App.PostController` for `App.PostRoute`). However,
+ of the route (i.e. `... | false |
Other | emberjs | ember.js | 27e61169b35fc8481de971290a630476f6c2c9b4.json | Apply prettier configuration changes to *.ts files. | packages/ember-glimmer/index.ts | @@ -268,12 +268,7 @@ export { default as LinkComponent } from './lib/components/link-to';
export { default as Component, ROOT_REF } from './lib/component';
export { default as Helper, helper } from './lib/helper';
export { default as Environment } from './lib/environment';
-export {
- SafeString,
- escapeExpressio... | true |
Other | emberjs | ember.js | 27e61169b35fc8481de971290a630476f6c2c9b4.json | Apply prettier configuration changes to *.ts files. | packages/ember-glimmer/lib/compile-time-lookup.ts | @@ -1,10 +1,17 @@
-import { CompilableTemplate, CompileTimeLookup as ICompileTimeLookup, ComponentCapabilities, Option, ProgramSymbolTable } from '@glimmer/interfaces';
+import {
+ CompilableTemplate,
+ CompileTimeLookup as ICompileTimeLookup,
+ ComponentCapabilities,
+ Option,
+ ProgramSymbolTable,
+} from '@glim... | true |
Other | emberjs | ember.js | 27e61169b35fc8481de971290a630476f6c2c9b4.json | Apply prettier configuration changes to *.ts files. | packages/ember-glimmer/lib/component-managers/abstract.ts | @@ -7,7 +7,7 @@ import {
DynamicScope,
ElementOperations,
Environment,
- PreparedArguments
+ PreparedArguments,
} from '@glimmer/runtime';
import { Destroyable, Opaque, Option } from '@glimmer/util';
import { DEBUG } from 'ember-env-flags';
@@ -17,8 +17,7 @@ import DebugStack from '../utils/debug-stack';
... | true |
Other | emberjs | ember.js | 27e61169b35fc8481de971290a630476f6c2c9b4.json | Apply prettier configuration changes to *.ts files. | packages/ember-glimmer/lib/component-managers/curly.ts | @@ -3,13 +3,9 @@ import {
Option,
ProgramSymbolTable,
Simple,
- VMHandle
+ VMHandle,
} from '@glimmer/interfaces';
-import {
- combine,
- Tag,
- VersionedPathReference,
-} from '@glimmer/reference';
+import { combine, Tag, VersionedPathReference } from '@glimmer/reference';
import {
Arguments,
Bou... | true |
Other | emberjs | ember.js | 27e61169b35fc8481de971290a630476f6c2c9b4.json | Apply prettier configuration changes to *.ts files. | packages/ember-glimmer/lib/component-managers/custom.ts | @@ -13,7 +13,7 @@ import DefinitionState from './definition-state';
export interface CustomComponentManagerDelegate<T> {
version: 'string';
- create(options: { ComponentClass: T, args: {} }): T;
+ create(options: { ComponentClass: T; args: {} }): T;
getContext(instance: T): Opaque;
update(instance: T, arg... | true |
Other | emberjs | ember.js | 27e61169b35fc8481de971290a630476f6c2c9b4.json | Apply prettier configuration changes to *.ts files. | packages/ember-glimmer/lib/component-managers/definition-state.ts | @@ -1,19 +1,16 @@
-import {
- ComponentCapabilities,
- ProgramSymbolTable,
- VMHandle
-} from '@glimmer/interfaces';
-import {
- Option
-} from '@glimmer/util';
+import { ComponentCapabilities, ProgramSymbolTable, VMHandle } from '@glimmer/interfaces';
+import { Option } from '@glimmer/util';
import { Factory } fr... | true |
Other | emberjs | ember.js | 27e61169b35fc8481de971290a630476f6c2c9b4.json | Apply prettier configuration changes to *.ts files. | packages/ember-glimmer/lib/component-managers/mount.ts | @@ -1,21 +1,7 @@
-import {
- ComponentCapabilities,
-} from '@glimmer/interfaces';
-import {
- CONSTANT_TAG,
- Tag,
- VersionedPathReference,
-} from '@glimmer/reference';
-import {
- ComponentDefinition,
- Invocation,
- WithDynamicLayout,
-} from '@glimmer/runtime';
-import {
- Destroyable,
- Opaque,
- Optio... | true |
Other | emberjs | ember.js | 27e61169b35fc8481de971290a630476f6c2c9b4.json | Apply prettier configuration changes to *.ts files. | packages/ember-glimmer/lib/component-managers/outlet.ts | @@ -1,7 +1,5 @@
import { ComponentCapabilities, Option, Unique } from '@glimmer/interfaces';
-import {
- CONSTANT_TAG, Tag, VersionedPathReference
-} from '@glimmer/reference';
+import { CONSTANT_TAG, Tag, VersionedPathReference } from '@glimmer/reference';
import {
Arguments,
ComponentDefinition,
@@ -10,7 +8,... | true |
Other | emberjs | ember.js | 27e61169b35fc8481de971290a630476f6c2c9b4.json | Apply prettier configuration changes to *.ts files. | packages/ember-glimmer/lib/component-managers/render.ts | @@ -1,15 +1,6 @@
-import {
- ComponentCapabilities,
-} from '@glimmer/interfaces';
-import {
- CONSTANT_TAG, Tag, VersionedPathReference
-} from '@glimmer/reference';
-import {
- Arguments,
- ComponentDefinition,
- Invocation,
- WithStaticLayout
-} from '@glimmer/runtime';
+import { ComponentCapabilities } from '... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.