language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | 6d2e29bbe7dd760235ae8f95e790d2de3cd99654.json | fix: forbid throwing of literals | node-tests/blueprints/component-test-test.js | @@ -177,7 +177,7 @@ describe('Blueprint: component-test', function() {
it('component-test x-foo --unit', function() {
return emberGenerate(['component-test', 'x-foo', '--unit'])
.then(() => {
- throw 'the command should raise an exception';
+ throw new Error('the command should ra... | true |
Other | emberjs | ember.js | 6d2e29bbe7dd760235ae8f95e790d2de3cd99654.json | fix: forbid throwing of literals | node-tests/helpers/expect-error.js | @@ -6,7 +6,7 @@ const expect = chai.expect;
module.exports = function expectError(promise, expectedErrorText) {
return promise
.then(() => {
- throw 'the command should raise an exception';
+ throw new Error('the command should raise an exception');
})
.catch(error => {
expect(error)... | true |
Other | emberjs | ember.js | 6d2e29bbe7dd760235ae8f95e790d2de3cd99654.json | fix: forbid throwing of literals | packages/ember/tests/routing/decoupled_basic_test.js | @@ -767,7 +767,7 @@ moduleFor(
'route:special',
Route.extend({
setup() {
- throw 'Setup error';
+ throw new Error('Setup error');
},
actions: {
error(reason) {
@@ -827,7 +827,7 @@ moduleFor(
'route:special',
Route.ex... | true |
Other | emberjs | ember.js | 4534399097361c17f3f568b6d2599761ca97f38e.json | Remove duplicate in is-present-helper | packages/@ember/-internals/metal/lib/is_present.ts | @@ -20,7 +20,6 @@ import isBlank from './is_blank';
isPresent(0); // true
isPresent(function() {}); // true
isPresent({}); // true
- isPresent(false); // true
isPresent('\n\t Hello'); // true
isPresent([1, 2, 3]); // true
``` | false |
Other | emberjs | ember.js | aca371cb177d504cf844fb81b7de70578e29e611.json | use willDestroy in stead of destroy | packages/@ember/-internals/runtime/lib/mixins/-proxy.js | @@ -61,9 +61,9 @@ export default Mixin.create({
m.writableTag(() => combine([DirtyableTag.create(), UpdatableTag.create(CONSTANT_TAG)]));
},
- destroy() {
- this._super(...arguments);
+ willDestroy() {
this.set('content', null);
+ this._super(...arguments);
},
isTruthy: computed('content'... | false |
Other | emberjs | ember.js | e8b58eed1b58edd902ba5b6782cc18ccdb3b7c34.json | add mocha rfc 232 test blueprints for helpers | blueprints/helper-test/mocha-rfc-232-files/tests/__testType__/__path__/__name__-test.js | @@ -0,0 +1,28 @@
+import { expect } from 'chai';
+<% if (testType == 'integration') { %>import { describe, it } from 'mocha';
+import { setupRenderingTest } from 'ember-mocha';
+import { render } from '@ember/test-helpers';
+import hbs from 'htmlbars-inline-precompile';
+
+describe('<%= friendlyTestName %>', function()... | true |
Other | emberjs | ember.js | e8b58eed1b58edd902ba5b6782cc18ccdb3b7c34.json | add mocha rfc 232 test blueprints for helpers | node-tests/blueprints/helper-test-test.js | @@ -109,6 +109,32 @@ describe('Blueprint: helper-test', function() {
});
});
});
+
+ describe('with ember-mocha@0.14.0', function() {
+ beforeEach(function() {
+ modifyPackages([
+ { name: 'ember-cli-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ... | true |
Other | emberjs | ember.js | e8b58eed1b58edd902ba5b6782cc18ccdb3b7c34.json | add mocha rfc 232 test blueprints for helpers | node-tests/fixtures/helper-test/mocha-rfc232-unit.js | @@ -0,0 +1,12 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { fooBarBaz } from 'my-app/helpers/foo/bar-baz';
+
+describe('Unit | Helper | foo/bar-baz', function() {
+
+ // Replace this with your real tests.
+ it('works', function() {
+ let result = fooBarBaz(42);
+ expect(res... | true |
Other | emberjs | ember.js | e8b58eed1b58edd902ba5b6782cc18ccdb3b7c34.json | add mocha rfc 232 test blueprints for helpers | node-tests/fixtures/helper-test/mocha-rfc232.js | @@ -0,0 +1,18 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { setupRenderingTest } from 'ember-mocha';
+import { render } from '@ember/test-helpers';
+import hbs from 'htmlbars-inline-precompile';
+
+describe('Integration | Helper | foo/bar-baz', function() {
+ setupRenderingTest();... | true |
Other | emberjs | ember.js | d73ca4c96abbebc8ff060593dcf5f48eaddcd16c.json | add RFC 232 mocha controller tests | blueprints/controller-test/mocha-rfc-232-files/__root__/__testType__/__path__/__test__.js | @@ -0,0 +1,13 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { setupTest } from 'ember-mocha';
+
+describe('<%= friendlyTestDescription %>', function() {
+ setupTest();
+
+ // Replace this with your real tests.
+ it('exists', function() {
+ let controller = this.owner.lookup('co... | true |
Other | emberjs | ember.js | d73ca4c96abbebc8ff060593dcf5f48eaddcd16c.json | add RFC 232 mocha controller tests | node-tests/blueprints/controller-test-test.js | @@ -110,6 +110,32 @@ describe('Blueprint: controller-test', function() {
});
});
});
+
+ describe('with ember-mocha@0.14.0', function() {
+ beforeEach(function() {
+ modifyPackages([
+ { name: 'ember-cli-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
... | true |
Other | emberjs | ember.js | d73ca4c96abbebc8ff060593dcf5f48eaddcd16c.json | add RFC 232 mocha controller tests | node-tests/fixtures/controller-test/mocha-rfc232-nested.js | @@ -0,0 +1,13 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { setupTest } from 'ember-mocha';
+
+describe('Unit | Controller | foo/bar', function() {
+ setupTest();
+
+ // Replace this with your real tests.
+ it('exists', function() {
+ let controller = this.owner.lookup('contr... | true |
Other | emberjs | ember.js | d73ca4c96abbebc8ff060593dcf5f48eaddcd16c.json | add RFC 232 mocha controller tests | node-tests/fixtures/controller-test/mocha-rfc232.js | @@ -0,0 +1,13 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { setupTest } from 'ember-mocha';
+
+describe('Unit | Controller | foo', function() {
+ setupTest();
+
+ // Replace this with your real tests.
+ it('exists', function() {
+ let controller = this.owner.lookup('controlle... | true |
Other | emberjs | ember.js | 75adb683aac7dc203340a8b6533fbe322b89880a.json | add mocha rfc 232 route blueprint | blueprints/route-test/mocha-rfc-232-files/__root__/__testType__/__path__/__test__.js | @@ -0,0 +1,12 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { setupTest } from 'ember-mocha';
+
+describe('<%= friendlyTestDescription %>', function() {
+ setupTest();
+
+ it('exists', function() {
+ let route = this.owner.lookup('route:<%= dasherizedModuleName %>');
+ expect... | true |
Other | emberjs | ember.js | 75adb683aac7dc203340a8b6533fbe322b89880a.json | add mocha rfc 232 route blueprint | node-tests/blueprints/route-test-test.js | @@ -71,6 +71,24 @@ describe('Blueprint: route-test', function() {
});
});
});
+
+ describe('with ember-mocha@0.14.0', function() {
+ beforeEach(function() {
+ modifyPackages([
+ { name: 'ember-cli-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ... | true |
Other | emberjs | ember.js | 75adb683aac7dc203340a8b6533fbe322b89880a.json | add mocha rfc 232 route blueprint | node-tests/fixtures/route-test/mocha-rfc232.js | @@ -0,0 +1,12 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { setupTest } from 'ember-mocha';
+
+describe('Unit | Route | foo', function() {
+ setupTest();
+
+ it('exists', function() {
+ let route = this.owner.lookup('route:foo');
+ expect(route).to.be.ok;
+ });
+}); | true |
Other | emberjs | ember.js | 2efbfac00652c97a89ba7eadc9a15796648790ea.json | add mocha rfc 232 util test | blueprints/util-test/mocha-rfc-232-files/__root__/__testType__/__name__-test.js | @@ -0,0 +1,11 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import <%= camelizedModuleName %> from '<%= dasherizedPackageName %>/utils/<%= dasherizedModuleName %>';
+
+describe('<%= friendlyTestName %>', function() {
+ // Replace this with your real tests.
+ it('works', function() {
+ ... | true |
Other | emberjs | ember.js | 2efbfac00652c97a89ba7eadc9a15796648790ea.json | add mocha rfc 232 util test | node-tests/blueprints/util-test-test.js | @@ -55,6 +55,24 @@ describe('Blueprint: util-test', function() {
});
});
});
+
+ describe('with ember-mocha@0.14.0', function() {
+ beforeEach(function() {
+ modifyPackages([
+ { name: 'ember-cli-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ... | true |
Other | emberjs | ember.js | 2efbfac00652c97a89ba7eadc9a15796648790ea.json | add mocha rfc 232 util test | node-tests/fixtures/util-test/mocha-rfc232.js | @@ -0,0 +1,11 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import fooBar from 'my-app/utils/foo-bar';
+
+describe('Unit | Utility | foo-bar', function() {
+ // Replace this with your real tests.
+ it('works', function() {
+ let result = fooBar();
+ expect(result).to.be.ok;
+ });
+... | true |
Other | emberjs | ember.js | 4f51ebd5c47ec3e8089eadc2bdbfeca5f11f7581.json | add mocha rfc 232 service test blueprint | blueprints/service-test/mocha-rfc-232-files/__root__/__testType__/__path__/__test__.js | @@ -0,0 +1,13 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { setupTest } from 'ember-mocha';
+
+describe('<%= friendlyTestDescription %>', function() {
+ setupTest();
+
+ // Replace this with your real tests.
+ it('exists', function() {
+ let service = this.owner.lookup('servi... | true |
Other | emberjs | ember.js | 4f51ebd5c47ec3e8089eadc2bdbfeca5f11f7581.json | add mocha rfc 232 service test blueprint | node-tests/blueprints/service-test-test.js | @@ -80,6 +80,24 @@ describe('Blueprint: service-test', function() {
});
});
+ describe('with ember-mocha@0.14.0', function() {
+ beforeEach(function() {
+ modifyPackages([
+ { name: 'ember-cli-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ]);
+ ... | true |
Other | emberjs | ember.js | 4f51ebd5c47ec3e8089eadc2bdbfeca5f11f7581.json | add mocha rfc 232 service test blueprint | node-tests/fixtures/service-test/mocha-rfc232.js | @@ -0,0 +1,13 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import { setupTest } from 'ember-mocha';
+
+describe('Unit | Service | foo', function() {
+ setupTest();
+
+ // Replace this with your real tests.
+ it('exists', function() {
+ let service = this.owner.lookup('service:foo');
... | true |
Other | emberjs | ember.js | 95cb1d274c1cda6f9ee2e68d99a03dfe7b0449f6.json | add rfc 232 mocha mixin blueprint | blueprints/mixin-test/mocha-rfc-232-files/__root__/__testType__/__name__-test.js | @@ -0,0 +1,13 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import EmberObject from '@ember/object';
+import <%= classifiedModuleName %>Mixin from '<%= dasherizedPackageName %>/mixins/<%= dasherizedModuleName %>';
+
+describe('<%= friendlyTestName %>', function() {
+ // Replace this with y... | true |
Other | emberjs | ember.js | 95cb1d274c1cda6f9ee2e68d99a03dfe7b0449f6.json | add rfc 232 mocha mixin blueprint | node-tests/blueprints/mixin-test-test.js | @@ -53,6 +53,24 @@ describe('Blueprint: mixin-test', function() {
});
});
});
+
+ describe('with ember-mocha@0.14.0', function() {
+ beforeEach(function() {
+ modifyPackages([
+ { name: 'ember-cli-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ... | true |
Other | emberjs | ember.js | 95cb1d274c1cda6f9ee2e68d99a03dfe7b0449f6.json | add rfc 232 mocha mixin blueprint | node-tests/fixtures/mixin-test/mocha-rfc232.js | @@ -0,0 +1,13 @@
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+import EmberObject from '@ember/object';
+import FooMixin from 'my-app/mixins/foo';
+
+describe('Unit | Mixin | foo', function() {
+ // Replace this with your real tests.
+ it('works', function() {
+ let FooObject = EmberObjec... | true |
Other | emberjs | ember.js | 73012f9d4ec06b7e3e6a09fe56b1a7bccd3dc7e3.json | Correct doc on paths for component templates | packages/@ember/-internals/glimmer/index.ts | @@ -15,7 +15,7 @@
});
```
- ```app/components/person-profile.hbs
+ ```app/templates/components/person-profile.hbs
{{name}}
<div>{{name}}</div>
<span data-name={{name}}></span> | true |
Other | emberjs | ember.js | 73012f9d4ec06b7e3e6a09fe56b1a7bccd3dc7e3.json | Correct doc on paths for component templates | packages/@ember/-internals/glimmer/lib/component.ts | @@ -38,15 +38,15 @@ export const BOUNDS = symbol('BOUNDS');
The easiest way to create a `Component` is via
a template. If you name a template
- `app/components/my-foo.hbs`, you will be able to use
+ `app/templates/components/my-foo.hbs`, you will be able to use
`{{my-foo}}` in other templates, which will m... | true |
Other | emberjs | ember.js | 1661db0df6a5821160c9729ddc721b2d733f29b6.json | Remove deprecated 'RENDER_SUPPORT' | packages/@ember/-internals/environment/lib/env.ts | @@ -111,10 +111,6 @@ export const ENV = {
*/
_JQUERY_INTEGRATION: true,
- // the following for addon support
- _ENABLE_ORPHANED_OUTLETS_SUPPORT: false,
- _ENABLE_RENDER_SUPPORT: false,
-
EMBER_LOAD_HOOKS: {} as {
[hook: string]: Function[];
}, | true |
Other | emberjs | ember.js | 1661db0df6a5821160c9729ddc721b2d733f29b6.json | Remove deprecated 'RENDER_SUPPORT' | packages/@ember/-internals/glimmer/lib/component-managers/render.ts | @@ -1,166 +0,0 @@
-import { RENDER_HELPER } from '@ember/deprecated-features';
-import { ComponentCapabilities } from '@glimmer/interfaces';
-import { CONSTANT_TAG, Tag, VersionedPathReference } from '@glimmer/reference';
-import { Arguments, ComponentDefinition, Invocation, WithStaticLayout } from '@glimmer/runtime';
... | true |
Other | emberjs | ember.js | 1661db0df6a5821160c9729ddc721b2d733f29b6.json | Remove deprecated 'RENDER_SUPPORT' | packages/@ember/-internals/glimmer/lib/resolver.ts | @@ -4,7 +4,6 @@ import { LookupOptions, Owner, setOwner } from '@ember/-internals/owner';
import { lookupComponent, lookupPartial, OwnedTemplateMeta } from '@ember/-internals/views';
import { EMBER_MODULE_UNIFICATION, GLIMMER_CUSTOM_COMPONENT_MANAGER } from '@ember/canary-features';
import { assert } from '@ember/de... | true |
Other | emberjs | ember.js | 1661db0df6a5821160c9729ddc721b2d733f29b6.json | Remove deprecated 'RENDER_SUPPORT' | packages/@ember/-internals/glimmer/lib/syntax.ts | @@ -1,7 +1,6 @@
import { OwnedTemplateMeta } from '@ember/-internals/views';
import { EMBER_TEMPLATE_BLOCK_LET_HELPER } from '@ember/canary-features';
import { assert } from '@ember/debug';
-import { RENDER_HELPER } from '@ember/deprecated-features';
import { CompilableBlock } from '@glimmer/interfaces';
import { ... | true |
Other | emberjs | ember.js | 1661db0df6a5821160c9729ddc721b2d733f29b6.json | Remove deprecated 'RENDER_SUPPORT' | packages/@ember/-internals/glimmer/lib/syntax/render.ts | @@ -1,194 +0,0 @@
-/**
- @module ember
-*/
-
-// Remove after 3.4 once _ENABLE_RENDER_SUPPORT flag is no longer needed.
-
-import { ENV } from '@ember/-internals/environment';
-import { OwnedTemplateMeta } from '@ember/-internals/views';
-import { assert } from '@ember/debug';
-import { RENDER_HELPER } from '@ember/dep... | true |
Other | emberjs | ember.js | 1661db0df6a5821160c9729ddc721b2d733f29b6.json | Remove deprecated 'RENDER_SUPPORT' | packages/@ember/-internals/glimmer/tests/integration/helpers/render-test.js | @@ -1,522 +0,0 @@
-import { observer, set, computed } from '@ember/-internals/metal';
-import Controller from '@ember/controller';
-import { ENV } from '@ember/-internals/environment';
-import { RenderingTest, moduleFor } from '../../utils/test-case';
-
-moduleFor(
- 'Helpers test: {{render}}',
- class extends Render... | true |
Other | emberjs | ember.js | 1661db0df6a5821160c9729ddc721b2d733f29b6.json | Remove deprecated 'RENDER_SUPPORT' | packages/@ember/-internals/glimmer/tests/integration/refinements-test.js | @@ -16,12 +16,6 @@ moduleFor(
---
- {{#with var as |render|}}
- {{render}}
- {{/with}}
-
- ---
-
{{#with var as |outlet|}}
{{outlet}}
{{/with}}
@@ -58,17 +52,15 @@ moduleFor(
{ var: 'var' }
);
- this.assertText('var---var---var---var---var--... | true |
Other | emberjs | ember.js | 1661db0df6a5821160c9729ddc721b2d733f29b6.json | Remove deprecated 'RENDER_SUPPORT' | packages/@ember/-internals/routing/lib/system/router.js | @@ -1,9 +1,9 @@
import { getOwner } from '@ember/-internals/owner';
import { assign } from '@ember/polyfills';
-import { cancel, once, run, scheduleOnce, schedule } from '@ember/runloop';
+import { cancel, once, run, scheduleOnce } from '@ember/runloop';
import { get, set, defineProperty, computed } from '@ember/-in... | true |
Other | emberjs | ember.js | 1661db0df6a5821160c9729ddc721b2d733f29b6.json | Remove deprecated 'RENDER_SUPPORT' | packages/@ember/deprecated-features/index.ts | @@ -9,6 +9,5 @@ export const PROPERTY_DID_CHANGE = !!'3.1.0-beta.1';
export const ROUTER_ROUTER = !!'3.2.0-beta.1';
export const ARRAY_AT_EACH = !!'3.1.0-beta.1';
export const TARGET_OBJECT = !!'2.18.0-beta.1';
-export const RENDER_HELPER = !!'2.11.0-beta.1';
export const MAP = !!'3.3.0-beta.1';
export const ORDER... | true |
Other | emberjs | ember.js | 1661db0df6a5821160c9729ddc721b2d733f29b6.json | Remove deprecated 'RENDER_SUPPORT' | packages/ember-template-compiler/lib/plugins/deprecate-render-model.ts | @@ -1,48 +0,0 @@
-import { deprecate } from '@ember/debug';
-import { RENDER_HELPER } from '@ember/deprecated-features';
-import { AST, ASTPlugin, ASTPluginEnvironment } from '@glimmer/syntax';
-import calculateLocationDisplay from '../system/calculate-location-display';
-
-// Remove after 3.4 once _ENABLE_RENDER_SUPPO... | true |
Other | emberjs | ember.js | 1661db0df6a5821160c9729ddc721b2d733f29b6.json | Remove deprecated 'RENDER_SUPPORT' | packages/ember-template-compiler/lib/plugins/deprecate-render.ts | @@ -1,51 +0,0 @@
-import { deprecate } from '@ember/debug';
-import { RENDER_HELPER } from '@ember/deprecated-features';
-import { AST, ASTPlugin, ASTPluginEnvironment } from '@glimmer/syntax';
-import calculateLocationDisplay from '../system/calculate-location-display';
-
-// Remove after 3.4 once _ENABLE_RENDER_SUPPO... | true |
Other | emberjs | ember.js | 1661db0df6a5821160c9729ddc721b2d733f29b6.json | Remove deprecated 'RENDER_SUPPORT' | packages/ember-template-compiler/lib/plugins/index.ts | @@ -2,8 +2,6 @@ import AssertIfHelperWithoutArguments from './assert-if-helper-without-arguments
import AssertInputHelperWithoutBlock from './assert-input-helper-without-block';
import AssertReservedNamedArguments from './assert-reserved-named-arguments';
import AssertSplattributeExpressions from './assert-splattrib... | true |
Other | emberjs | ember.js | 1661db0df6a5821160c9729ddc721b2d733f29b6.json | Remove deprecated 'RENDER_SUPPORT' | packages/ember-template-compiler/tests/plugins/deprecate-render-model-test.js | @@ -1,19 +0,0 @@
-import { compile } from '../../index';
-import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
-
-moduleFor(
- 'ember-template-compiler: deprecate-model-render',
- class extends AbstractTestCase {
- ['@test Using `{{render` with model provides a deprecation']() {
- let expected... | true |
Other | emberjs | ember.js | 1661db0df6a5821160c9729ddc721b2d733f29b6.json | Remove deprecated 'RENDER_SUPPORT' | packages/ember-template-compiler/tests/plugins/deprecate-render-test.js | @@ -1,19 +0,0 @@
-import { compile } from '../../index';
-import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
-
-moduleFor(
- 'ember-template-compiler: deprecate-render',
- class extends AbstractTestCase {
- ['@test Using `{{render` without a model provides a deprecation']() {
- let expectedM... | true |
Other | emberjs | ember.js | 1661db0df6a5821160c9729ddc721b2d733f29b6.json | Remove deprecated 'RENDER_SUPPORT' | packages/ember/tests/routing/decoupled_basic_test.js | @@ -2,7 +2,6 @@
import { getOwner } from '@ember/-internals/owner';
import RSVP from 'rsvp';
import { compile } from 'ember-template-compiler';
-import { ENV } from '@ember/-internals/environment';
import { Route, NoneLocation, HistoryLocation } from '@ember/-internals/routing';
import Controller from '@ember/cont... | true |
Other | emberjs | ember.js | 75dfa757a88bfd20ef8539cc332e45a1b4c4095d.json | Remove deprecated flags | packages/@ember/-internals/environment/lib/env.ts | @@ -112,25 +112,9 @@ export const ENV = {
_JQUERY_INTEGRATION: true,
// the following for addon support
- _ENABLE_EMBER_K_SUPPORT: false,
- _ENABLE_SAFE_STRING_SUPPORT: false,
- _ENABLE_ENUMERABLE_CONTAINS_SUPPORT: false,
- _ENABLE_UNDERSCORE_ACTIONS_SUPPORT: false,
- _ENABLE_REVERSED_OBSERVER_SUPPORT: fal... | false |
Other | emberjs | ember.js | 790f13fedc8c3abaaea4810cc7d2e1d6be763f55.json | Use bare `require` in conditional URL import
This commit changes the code that sets up URL parsing in Glimmer to use the bare, global `require` in Node.js environments, rather than importing from our `node-module` helper package.
The `node-module` package is a shim we emit in the AMD build that exposes the Node `modu... | packages/@ember/-internals/glimmer/lib/protocol-for-url.ts | @@ -1,7 +1,6 @@
/* globals module, URL */
import { hasDOM } from '@ember/-internals/browser-environment';
-import { IS_NODE, require } from 'node-module';
import Environment from './environment';
let nodeURL: any;
@@ -24,7 +23,7 @@ export default function installProtocolForURL(environment: Environment) {
/... | false |
Other | emberjs | ember.js | b94707f11819866919a47005ac9c3aa241ad706e.json | Write package.json to ES package builds | broccoli/package-json-writer.js | @@ -0,0 +1,109 @@
+const fs = require('fs');
+const path = require('path');
+const glob = require('glob');
+const mkdirp = require('mkdirp');
+const Plugin = require('broccoli-plugin');
+
+const DEFAULT_PACKAGE_JSON = {
+ main: './index.js',
+ module: './index.js',
+ license: 'MIT',
+};
+
+/**
+ * Broccoli plugin th... | true |
Other | emberjs | ember.js | b94707f11819866919a47005ac9c3aa241ad706e.json | Write package.json to ES package builds | broccoli/packages.js | @@ -11,6 +11,7 @@ const findLib = require('./find-lib');
const findPackage = require('./find-package');
const funnelLib = require('./funnel-lib');
const { VERSION } = require('./version');
+const PackageJSONWriter = require('./package-json-writer');
const WriteFile = require('broccoli-file-creator');
const StringR... | true |
Other | emberjs | ember.js | b94707f11819866919a47005ac9c3aa241ad706e.json | Write package.json to ES package builds | package.json | @@ -101,6 +101,7 @@
"broccoli-debug": "^0.6.4",
"broccoli-file-creator": "^1.1.1",
"broccoli-persistent-filter": "^1.4.3",
+ "broccoli-plugin": "^1.3.1",
"broccoli-rollup": "^2.1.0",
"broccoli-source": "^1.1.0",
"broccoli-string-replace": "^0.1.2",
@@ -131,6 +132,7 @@
"glob": "^7.1... | true |
Other | emberjs | ember.js | b94707f11819866919a47005ac9c3aa241ad706e.json | Write package.json to ES package builds | yarn.lock | @@ -1482,6 +1482,15 @@ broccoli-plugin@^1.0.0, broccoli-plugin@^1.1.0, broccoli-plugin@^1.2.0, broccoli
rimraf "^2.3.4"
symlink-or-copy "^1.1.8"
+broccoli-plugin@^1.3.1:
+ version "1.3.1"
+ resolved "https://registry.yarnpkg.com/broccoli-plugin/-/broccoli-plugin-1.3.1.tgz#a26315732fb99ed2d9fb58f12a1e14e98... | true |
Other | emberjs | ember.js | c26405508704bcceea751f3769a282024dc2730b.json | Fix eslint errors | .eslintrc.js | @@ -86,6 +86,7 @@ module.exports = {
files: [
'packages/*/tests/**/*.js',
'packages/@ember/*/tests/**/*.js',
+ 'packages/@ember/-internals/*/tests/**/*.js',
'packages/internal-test-helpers/**/*.js',
],
env: { | true |
Other | emberjs | ember.js | c26405508704bcceea751f3769a282024dc2730b.json | Fix eslint errors | packages/@ember/application/lib/application.js | @@ -8,7 +8,11 @@ import { hasDOM } from '@ember/-internals/browser-environment';
import { assert, isTesting } from '@ember/debug';
import { DEBUG } from '@glimmer/env';
import { bind, join, once, run, schedule } from '@ember/runloop';
-import { libraries, processAllNamespaces, setNamespaceSearchDisabled } from '@emb... | true |
Other | emberjs | ember.js | c26405508704bcceea751f3769a282024dc2730b.json | Fix eslint errors | packages/@ember/object/lib/computed/reduce_computed_macros.js | @@ -2,7 +2,13 @@
@module @ember/object
*/
import { assert } from '@ember/debug';
-import { get, ComputedProperty, addObserver, removeObserver, getProperties } from '@ember/-internals/metal';
+import {
+ get,
+ ComputedProperty,
+ addObserver,
+ removeObserver,
+ getProperties,
+} from '@ember/-internals/metal';... | true |
Other | emberjs | ember.js | c26405508704bcceea751f3769a282024dc2730b.json | Fix eslint errors | packages/ember-runtime/lib/mixins/evented.js | @@ -1,4 +1,10 @@
-import { Mixin, addListener, removeListener, hasListeners, sendEvent } from '@ember/-internals/metal';
+import {
+ Mixin,
+ addListener,
+ removeListener,
+ hasListeners,
+ sendEvent,
+} from '@ember/-internals/metal';
/**
@module @ember/object | true |
Other | emberjs | ember.js | c26405508704bcceea751f3769a282024dc2730b.json | Fix eslint errors | packages/ember-runtime/tests/system/object/computed_test.js | @@ -1,4 +1,12 @@
-import { alias, computed, set, get, getWithDefault, observer, defineProperty } from '@ember/-internals/metal';
+import {
+ alias,
+ computed,
+ set,
+ get,
+ getWithDefault,
+ observer,
+ defineProperty,
+} from '@ember/-internals/metal';
import { oneWay as reads } from '@ember/object/computed... | true |
Other | emberjs | ember.js | c26405508704bcceea751f3769a282024dc2730b.json | Fix eslint errors | packages/ember-runtime/tests/system/object/destroy_test.js | @@ -1,5 +1,11 @@
import { run } from '@ember/runloop';
-import { observer, get, set, beginPropertyChanges, endPropertyChanges } from '@ember/-internals/metal';
+import {
+ observer,
+ get,
+ set,
+ beginPropertyChanges,
+ endPropertyChanges,
+} from '@ember/-internals/metal';
import { peekMeta } from 'ember-meta... | true |
Other | emberjs | ember.js | c26405508704bcceea751f3769a282024dc2730b.json | Fix eslint errors | packages/ember-runtime/tests/system/object/es-compatibility-test.js | @@ -1,5 +1,12 @@
import EmberObject from '../../../lib/system/object';
-import { Mixin, defineProperty, computed, addObserver, addListener, sendEvent } from '@ember/-internals/metal';
+import {
+ Mixin,
+ defineProperty,
+ computed,
+ addObserver,
+ addListener,
+ sendEvent,
+} from '@ember/-internals/metal';
i... | true |
Other | emberjs | ember.js | c26405508704bcceea751f3769a282024dc2730b.json | Fix eslint errors | packages/ember-runtime/tests/system/object_proxy_test.js | @@ -1,5 +1,12 @@
import { DEBUG } from '@glimmer/env';
-import { addObserver, computed, get, set, isWatching, removeObserver } from '@ember/-internals/metal';
+import {
+ addObserver,
+ computed,
+ get,
+ set,
+ isWatching,
+ removeObserver,
+} from '@ember/-internals/metal';
import { HAS_NATIVE_PROXY } from '@... | true |
Other | emberjs | ember.js | 428e41e864a2b109174b1c5111b2e10619a3c62d.json | Add v3.5.0-beta.1 to CHANGELOG
[ci skip]
(cherry picked from commit e77d544aa433fb57c0d2ba018eea04a21ced4f22) | CHANGELOG.md | @@ -1,6 +1,12 @@
# Ember Changelog
+### v3.5.0-beta.1 (August 28, 2018)
+
+- [#16877](https://github.com/emberjs/ember.js/pull/16877) [CLEANUP] Allow routes to be named "array" and "object"
+- [#16907](https://github.com/emberjs/ember.js/pull/16907) Upgrade to TypeScript 3.0
+
### v3.4.0 (August 27, 2018)
+
- [#16... | false |
Other | emberjs | ember.js | b2cc5662e9c020aa46f84f5801b0f1f7ce5cd0d8.json | Add v3.4.0 to CHANGELOG
[ci skip]
(cherry picked from commit 0143d4a97d9d63d4015518345e0ea71a0d3c34be) | CHANGELOG.md | @@ -1,18 +1,9 @@
# Ember Changelog
-### v3.4.0-beta.3 (August 21, 2018)
-
-- [#16870](https://github.com/emberjs/ember.js/pull/16870) [BUGFIX] Enable @ember/object#get to be called with an empty string
+### v3.4.0 (August 27, 2018)
- [#16603](https://github.com/emberjs/ember.js/pull/16603) [BUGFIX] Support mouseEnt... | false |
Other | emberjs | ember.js | 888d0070d00edca518ffb3b145aa94f24732143b.json | Remove unneeded import | packages/ember-metal/tests/tracked/set_test.ts | @@ -1,5 +1,5 @@
import { AbstractTestCase, moduleFor } from 'internal-test-helpers';
-import { get, set, setHasViews, tracked } from '../..';
+import { get, set, tracked } from '../..';
import { EMBER_METAL_TRACKED_PROPERTIES } from '@ember/canary-features';
| false |
Other | emberjs | ember.js | d593d86db88c595f3864ee08ad36578ddfe318f1.json | Add v3.4.0-beta.3 to CHANGELOG
[ci skip]
(cherry picked from commit 84770c4624696aa43ceea5f1e9ab42cfe20714a0) | CHANGELOG.md | @@ -1,5 +1,10 @@
# Ember Changelog
+### v3.4.0-beta.3 (August 21, 2018)
+
+- [#16870](https://github.com/emberjs/ember.js/pull/16870) [BUGFIX] Enable @ember/object#get to be called with an empty string
+- [#16603](https://github.com/emberjs/ember.js/pull/16603) [BUGFIX] Support mouseEnter/Leave events w/o jQuery
+
... | false |
Other | emberjs | ember.js | 4423239563501e6115688e75862d29f635bbb01c.json | Fix all type errors | packages/ember-metal/tests/tracked/computed_test.ts | @@ -7,7 +7,7 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
moduleFor(
'@tracked getters',
class extends AbstractTestCase {
- ['@test works without get'](assert) {
+ ['@test works without get'](assert: Assert) {
let count = 0;
class Count {
@@ -24,7 +24,7 @@ if (EMBER_METAL_TRACKED_... | true |
Other | emberjs | ember.js | 4423239563501e6115688e75862d29f635bbb01c.json | Fix all type errors | packages/ember-metal/tests/tracked/get_test.ts | @@ -43,7 +43,7 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
let obj = new Obj();
- this.assert.equal(get(obj, 1), 'first');
+ this.assert.equal(get(obj, '1'), 'first');
}
'@test should retrieve an empty key on an object'() {
@@ -112,7 +112,7 @@ if (EMBER_METAL_TRACKED_PROPERTIES) ... | true |
Other | emberjs | ember.js | 4423239563501e6115688e75862d29f635bbb01c.json | Fix all type errors | packages/ember-metal/tests/tracked/set_test.ts | @@ -32,30 +32,34 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
setHasViews(() => false);
}
- ['@test should set arbitrary properties on an object'](assert) {
+ ['@test should set arbitrary properties on an object'](assert: Assert) {
let obj = createObj();
- let newObj = new clas... | true |
Other | emberjs | ember.js | 4423239563501e6115688e75862d29f635bbb01c.json | Fix all type errors | packages/ember-metal/tests/tracked/support.js | @@ -1,12 +0,0 @@
-import { tracked } from '../..';
-
-export function createWithDescriptors(values) {
- function Class() {}
-
- for (let prop in values) {
- let descriptor = Object.getOwnPropertyDescriptor(values, prop);
- Object.defineProperty(Class.prototype, prop, tracked(Class.prototype, prop, descriptor));... | true |
Other | emberjs | ember.js | 4423239563501e6115688e75862d29f635bbb01c.json | Fix all type errors | packages/ember-metal/tests/tracked/validation_test.ts | @@ -91,18 +91,20 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
[`@test interaction with Ember object model (Ember computed property depending on tracked property)`](
assert: Assert
) {
+ let self: EmberObject;
class EmberObject {
name: Name;
constructor(name: Name... | true |
Other | emberjs | ember.js | 5c2d210691ca486cb73a5a3242eb65bfa2b60c23.json | change descriptor check | packages/ember-metal/lib/tracked.ts | @@ -102,9 +102,7 @@ export function tracked(target: any, key: any, descriptor: PropertyDescriptor):
export function tracked(...dependencies: any[]): any {
let [, key, descriptor] = dependencies;
- if (!descriptor) return;
-
- if ('value' in descriptor) {
+ if (descriptor === undefined || 'initializer' in descr... | true |
Other | emberjs | ember.js | 5c2d210691ca486cb73a5a3242eb65bfa2b60c23.json | change descriptor check | packages/ember-metal/tests/tracked/validation_test.ts | @@ -8,17 +8,17 @@ if (EMBER_METAL_TRACKED_PROPERTIES) {
'@tracked get validation',
class extends AbstractTestCase {
[`@test validators for tracked getters with dependencies should invalidate when the dependencies invalidate`](
- assert
+ assert: Assert
) {
class Tracked {
... | true |
Other | emberjs | ember.js | 26bf0d2b1a163ed7afe995dd6d318b75e8c96397.json | Add v3.3.2 to CHANGELOG
[ci skip]
(cherry picked from commit 32474519a8820e6be38c76b44add3db0c3e3f20b) | CHANGELOG.md | @@ -18,6 +18,11 @@
- [#16794](https://github.com/emberjs/ember.js/pull/16794) [BUGFIX] Fix instance-initializer-test blueprint for new QUnit testing API ([emberjs/rfcs#232](https://github.com/emberjs/rfcs/pull/232))
- [#16797](https://github.com/emberjs/ember.js/pull/16797) [BUGFIX] Drop autorun assertion
+### v3.3... | false |
Other | emberjs | ember.js | a47ff0933376f30cc6076f9750666f843114e796.json | add mocha rfc 268 acceptance tests | blueprints/acceptance-test/mocha-rfc-232-files/tests/acceptance/__name__-test.js | @@ -0,0 +1,13 @@
+import { describe, it } from 'mocha';
+import { expect } from 'chai';
+import { setupApplicationTest } from 'ember-mocha';
+import { visit, currentURL } from '@ember/test-helpers';
+
+describe('<%= friendlyTestName %>', function() {
+ setupApplicationTest();
+
+ it('can visit /<%= dasherizedModuleNa... | true |
Other | emberjs | ember.js | a47ff0933376f30cc6076f9750666f843114e796.json | add mocha rfc 268 acceptance tests | node-tests/blueprints/acceptance-test-test.js | @@ -58,6 +58,24 @@ describe('Blueprint: acceptance-test', function() {
});
});
});
+
+ describe('with ember-mocha@0.14.0', function() {
+ beforeEach(function() {
+ modifyPackages([
+ { name: 'ember-cli-qunit', delete: true },
+ { name: 'ember-mocha', dev: true },
+ ... | true |
Other | emberjs | ember.js | a47ff0933376f30cc6076f9750666f843114e796.json | add mocha rfc 268 acceptance tests | node-tests/fixtures/acceptance-test/mocha-rfc268.js | @@ -0,0 +1,13 @@
+import { describe, it } from 'mocha';
+import { expect } from 'chai';
+import { setupApplicationTest } from 'ember-mocha';
+import { visit, currentURL } from '@ember/test-helpers';
+
+describe('Acceptance | foo', function() {
+ setupApplicationTest();
+
+ it('can visit /foo', async function() {
+ ... | true |
Other | emberjs | ember.js | c504069851276f1e8156a180221d33b0b23a36d8.json | Remove references to unused dist/ember-runtime.js | lib/index.js | @@ -68,7 +68,6 @@ module.exports = {
let emberSourceDistPath = path.join(__dirname, '..', 'dist');
var emberFiles = [
- 'ember-runtime.js',
'ember-template-compiler.js',
'ember-testing.js',
'ember.debug.js', | true |
Other | emberjs | ember.js | c504069851276f1e8156a180221d33b0b23a36d8.json | Remove references to unused dist/ember-runtime.js | package.json | @@ -14,8 +14,6 @@
"files": [
"build-metadata.json",
"blueprints",
- "dist/ember-runtime.js",
- "dist/ember-runtime.map",
"dist/ember-template-compiler.js",
"dist/ember-template-compiler.map",
"dist/ember-testing.js", | true |
Other | emberjs | ember.js | 8974f23965dbd38f4ff4497f76e3d28c3ddb3abf.json | Add v3.1.4 to CHANGELOG.md.
[ci skip]
(cherry picked from commit 9f846821af454f858e7577708b7b615c0576b551) | CHANGELOG.md | @@ -78,6 +78,11 @@
- [#16462](https://github.com/emberjs/ember.js/pull/16462) [CLEANUP] Remove deprecated `MODEL_FACTORY_INJECTIONS`.
- [emberjs/rfcs#286](https://github.com/emberjs/rfcs/blob/master/text/0286-block-let-template-helper.md) [FEATURE] Enabled block `let` handlebars helper by default.
+### v3.1.4 (Augu... | false |
Other | emberjs | ember.js | ddec402d601c9791f2f8a7ca1c83265e0e48de6c.json | Add v3.4.0-beta.2 to CHANGELOG
[ci skip]
(cherry picked from commit df84704d3b267ada2b074e7ee6aace7168fb8941) | CHANGELOG.md | @@ -1,5 +1,11 @@
# Ember Changelog
+### v3.4.0-beta.2 (August 06, 2018)
+
+- [#16857](https://github.com/emberjs/ember.js/pull/16857) [BUGFIX] Prevents the recursive redefinition of root chains
+- [#16854](https://github.com/emberjs/ember.js/pull/16854) [BUGFIX] Don't thread FactoryManager through createComponent
+-... | false |
Other | emberjs | ember.js | 1cbd034ce0c7f0c26970b9923d17b51c00c9ea53.json | Add v3.4.0-beta.1 to CHANGELOG
[ci skip]
(cherry picked from commit c8b6aa15884db3e93475c01583cfc86ceb9004a8) | CHANGELOG.md | @@ -1,5 +1,17 @@
# Ember Changelog
+### v3.4.0-beta.1 (July 16, 2018)
+
+- [#16773](https://github.com/emberjs/ember.js/pull/16773) [FEATURE] Custom component manager (see [emberjs/rfcs#213](https://github.com/emberjs/rfcs/blob/master/text/0213-custom-components.md) for more details)
+- [#16708](https://github.com/e... | false |
Other | emberjs | ember.js | d08990a3045367d4be73729899c6c8016c92167b.json | Add v3.3.0 to CHANGELOG
[ci skip]
(cherry picked from commit 1d3ab4e3033f3a46db5a7dd985e7699d196a0154) | CHANGELOG.md | @@ -1,28 +1,19 @@
# Ember Changelog
-### v3.3.0-beta.5 (July 2, 2018)
-- [#16781](https://github.com/emberjs/ember.js/pull/16781) [BUGFIX] Ensure tests from @ember/* are excluded from debug/prod builds.
-
-### v3.3.0-beta.4 (June 25, 2018)
-- [#16754](https://github.com/emberjs/ember.js/pull/16754) [BUGFIX] Fix cont... | false |
Other | emberjs | ember.js | 10cad8712e1ba4942fd88b20e0dc5a838425684a.json | remove double ending line | blueprints/service-test/qunit-rfc-232-files/__root__/__testType__/__path__/__test__.js | @@ -10,4 +10,3 @@ module('<%= friendlyTestDescription %>', function(hooks) {
assert.ok(service);
});
});
- | true |
Other | emberjs | ember.js | 10cad8712e1ba4942fd88b20e0dc5a838425684a.json | remove double ending line | node-tests/fixtures/service-test/rfc232.js | @@ -10,4 +10,3 @@ module('Unit | Service | foo', function(hooks) {
assert.ok(service);
});
});
- | true |
Other | emberjs | ember.js | cff0b102833de4a5953ba303b3955b0164a153b7.json | Drop autorun assertion
This removes the autorun assertion in test mode. The original conditions that caused it to be added are no longer true, as we are on a version of backburner that uses microtask scheduling. | packages/@ember/runloop/index.js | @@ -1,4 +1,4 @@
-import { assert, deprecate, isTesting } from '@ember/debug';
+import { assert, deprecate } from '@ember/debug';
import { onErrorTarget } from 'ember-error-handling';
import { beginPropertyChanges, endPropertyChanges } from 'ember-metal';
import Backburner from 'backburner';
@@ -325,11 +325,6 @@ expo... | true |
Other | emberjs | ember.js | cff0b102833de4a5953ba303b3955b0164a153b7.json | Drop autorun assertion
This removes the autorun assertion in test mode. The original conditions that caused it to be added are no longer true, as we are on a version of backburner that uses microtask scheduling. | packages/@ember/runloop/tests/schedule_test.js | @@ -82,18 +82,5 @@ moduleFor(
assert.deepEqual(order, ['sync', 'actions', 'sync', 'actions', 'destroy']);
}
-
- ['@test makes sure it does not trigger an autorun during testing']() {
- expectAssertion(
- () => schedule('actions', () => {}),
- /wrap any code with asynchronous side-eff... | true |
Other | emberjs | ember.js | 64fe277d0d5c3c87bc1eac9d118f0e5c01f8c4de.json | Add v3.3.0-beta.5 to CHANGELOG
[ci skip]
(cherry picked from commit 22811d6821de39caf5c010f930ac696db720cb93) | CHANGELOG.md | @@ -1,5 +1,8 @@
# Ember Changelog
+### v3.3.0-beta.5 (July 2, 2018)
+- [#16781](https://github.com/emberjs/ember.js/pull/16781) [BUGFIX] Ensure tests from @ember/* are excluded from debug/prod builds.
+
### v3.3.0-beta.4 (June 25, 2018)
- [#16754](https://github.com/emberjs/ember.js/pull/16754) [BUGFIX] Fix contai... | false |
Other | emberjs | ember.js | 38bf61d9d11ceda9dddd90230ac3e412fca7791b.json | build release branches | .travis.yml | @@ -34,6 +34,8 @@ branches:
- master
- beta
- release
+ # release branches
+ - /^(?:release|lts)-\d+-\d+$/
# npm version tags
- /^v\d+\.\d+\.\d+/
| false |
Other | emberjs | ember.js | 72733afb5e9cb11308f8e21115ccc7d6d9335f6a.json | Convert ObjectProxy and ArrayProxy | packages/ember-runtime/lib/mixins/array.js | @@ -208,7 +208,6 @@ const ArrayMixin = Mixin.create(Enumerable, {
@property {Number} length
@public
*/
- length: null,
/**
Returns the object at the given `index`. If the given `index` is negative
@@ -234,13 +233,6 @@ const ArrayMixin = Mixin.create(Enumerable, {
@return {*} item at index o... | true |
Other | emberjs | ember.js | 72733afb5e9cb11308f8e21115ccc7d6d9335f6a.json | Convert ObjectProxy and ArrayProxy | packages/ember-runtime/lib/system/array_proxy.js | @@ -5,7 +5,6 @@
import {
get,
objectAt,
- computed,
alias,
PROPERTY_DID_CHANGE,
addArrayObserver,
@@ -80,9 +79,9 @@ const ARRAY_OBSERVER_MAPPING = {
@uses MutableArray
@public
*/
-export default EmberObject.extend(MutableArray, {
+export default class ArrayProxy extends EmberObject {
init() {... | true |
Other | emberjs | ember.js | 72733afb5e9cb11308f8e21115ccc7d6d9335f6a.json | Convert ObjectProxy and ArrayProxy | packages/ember-runtime/lib/system/object_proxy.js | @@ -77,5 +77,5 @@ import _ProxyMixin from '../mixins/-proxy';
@uses Ember.ProxyMixin
@public
*/
-
-export default FrameworkObject.extend(_ProxyMixin);
+export default class ObjectProxy extends FrameworkObject {}
+ObjectProxy.PrototypeMixin.reopen(_ProxyMixin); | true |
Other | emberjs | ember.js | e3895580d7a4f40890cf104b43584fe3baef33ba.json | Add v3.3.0-beta.4 to CHANGELOG
[ci skip]
(cherry picked from commit 4f543588238b63d639a0f046b31c27b6139e23dc) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v3.3.0-beta.4 (June 25, 2018)
+- [#16754](https://github.com/emberjs/ember.js/pull/16754) [BUGFIX] Fix container destroy timing
+- [#16767](https://github.com/emberjs/ember.js/pull/16767) [BUGFIX] Ensure meta._parent is initialized
+
### v3.3.0-beta.3 (June 18, 2018)
- [#1674... | false |
Other | emberjs | ember.js | 16b8df445f008d34cd56e6395ba9b1cea62a872e.json | Add v3.1.3 to CHANGELOG
[ci skip]
(cherry picked from commit 175fb43be30098433a3a868a75c74210e3c5e54e) | CHANGELOG.md | @@ -58,6 +58,9 @@
- [#16462](https://github.com/emberjs/ember.js/pull/16462) [CLEANUP] Remove deprecated `MODEL_FACTORY_INJECTIONS`.
- [emberjs/rfcs#286](https://github.com/emberjs/rfcs/blob/master/text/0286-block-let-template-helper.md) [FEATURE] Enabled block `let` handlebars helper by default.
+### v3.1.3 (June ... | false |
Other | emberjs | ember.js | 51e5b48a11ec1386ece8ef94606cbd6cd122ee0e.json | Make EmberObject and Namespace use extends | packages/ember-runtime/lib/system/namespace.js | @@ -33,12 +33,10 @@ import EmberObject from './object';
@extends EmberObject
@public
*/
-const Namespace = EmberObject.extend({
- isNamespace: true,
-
+export default class Namespace extends EmberObject {
init() {
addNamespace(this);
- },
+ }
toString() {
let name = get(this, 'name') || get(... | true |
Other | emberjs | ember.js | 51e5b48a11ec1386ece8ef94606cbd6cd122ee0e.json | Make EmberObject and Namespace use extends | packages/ember-runtime/lib/system/object.js | @@ -5,7 +5,7 @@
import { FACTORY_FOR } from 'container';
import { OWNER } from 'ember-owner';
import { symbol, setName } from 'ember-utils';
-import { on, descriptor } from 'ember-metal';
+import { addListener } from 'ember-metal';
import CoreObject from './core_object';
import Observable from '../mixins/observabl... | true |
Other | emberjs | ember.js | 2b80236e26a48a17f976c62f0b71ceb0d21261ee.json | Ensure meta._parent is initialized | packages/ember-meta/lib/meta.ts | @@ -64,6 +64,7 @@ export class Meta {
counters!.metaInstantiated++;
this._values = undefined;
}
+ this._parent = undefined;
this._descriptors = undefined;
this._watching = undefined;
this._mixins = undefined; | false |
Other | emberjs | ember.js | 244b647ebcb984d813a4d93d5d39037dddcd9d08.json | Add v3.2.2 to CHANGELOG
[ci skip]
(cherry picked from commit e0f32cc98d61868895c8fae7ea7f683d77ecd8fb) | CHANGELOG.md | @@ -17,6 +17,9 @@
- [#16691](https://github.com/emberjs/ember.js/pull/16691) [DEPRECATION] [emberjs/rfcs#237](https://github.com/emberjs/rfcs/pull/237) Implement `Ember.Map`, `Ember.MapWithDefault`, and `Ember.OrderedSet` deprecation.
- [#16692](https://github.com/emberjs/ember.js/pull/16692) [DEPRECATION] [emberjs/r... | false |
Other | emberjs | ember.js | 28d4b76017fe23bdb2e38611692f42a111091780.json | add interop testing for compatibility
make meta.parent lazier | packages/ember-meta/lib/meta.ts | @@ -49,15 +49,15 @@ export class Meta {
_flags: number;
source: object;
proto: object | undefined;
- parent: Meta | undefined;
+ _parent: Meta | undefined | null;
_listeners: any | undefined;
_listenersFinalized: boolean;
// DEBUG
_values: any | undefined;
_bindings: any | undefined;
- co... | true |
Other | emberjs | ember.js | 28d4b76017fe23bdb2e38611692f42a111091780.json | add interop testing for compatibility
make meta.parent lazier | packages/ember-runtime/tests/system/object/es-compatibility-test.js | @@ -1,5 +1,5 @@
import EmberObject from '../../../lib/system/object';
-import { Mixin, defineProperty, computed } from 'ember-metal';
+import { Mixin, defineProperty, computed, addObserver, addListener, sendEvent } from 'ember-metal';
import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
moduleFor(
... | true |
Other | emberjs | ember.js | 7ed1f804ebf238b07152d7fd1f24086816ee336d.json | remove unused code | packages/ember-runtime/lib/ext/function.js | @@ -118,29 +118,6 @@ if (ENV.EXTEND_PROTOTYPES.Function) {
},
},
- _observesImmediately: {
- configurable: true,
- enumerable: false,
- writable: true,
- value: function() {
- assert(
- 'Immediate observers must observe internal properties only, ' +
- 'not... | false |
Other | emberjs | ember.js | 277294f8dabf25980d80010bc07d2950db9d2a92.json | Remove unused export. | packages/@ember/application/globals-resolver.js | @@ -11,23 +11,6 @@ import validateType from './lib/validate-type';
import { getTemplate } from 'ember-glimmer';
import { DEBUG } from '@glimmer/env';
-export const Resolver = EmberObject.extend({
- /*
- This will be set to the Application instance when it is
- created.
-
- @property namespace
- */
- nam... | false |
Other | emberjs | ember.js | 0ddac17b8d4172dd77bd6a1e3183b67a728e3558.json | CHANGELOG entries for `{{#each}}` & `{{#each-in}}` | CHANGELOG.md | @@ -26,31 +26,33 @@
- [#16613](https://github.com/emberjs/ember.js/pull/16613) [BUGFIX] Prevent errors in ember-engines + 3.1 + proxies.
- [#16597](https://github.com/emberjs/ember.js/pull/16597) [BUGFIX] Ensure `Ember.run.cancelTimers` is present.
-- [#16605](https://github.com/emberjs/ember.js/pull/16605) [BUGFIX... | false |
Other | emberjs | ember.js | 372aca378c51e19daa3bd82be07b759b0b0003ce.json | Add v3.2.1 to CHANGELOG
[ci skip]
(cherry picked from commit d8c83ff9443138185b43c1e19ee7fd4bbdd94be8) | CHANGELOG.md | @@ -18,6 +18,10 @@
- [#16692](https://github.com/emberjs/ember.js/pull/16692) [DEPRECATION] [emberjs/rfcs#322](https://github.com/emberjs/rfcs/pull/322) Implement `Ember.copy`/`Ember.Copyable` deprecation.
+### v3.2.1 (June 19, 2018)
+
+- [#16750](https://github.com/emberjs/ember.js/pull/16750) [BUGFIX] Bring back... | false |
Other | emberjs | ember.js | 7863b093cb86c47fef4d9044d8beeb4d8ffef76f.json | Add v3.3.0-beta.3 to CHANGELOG
[ci skip]
(cherry picked from commit 60b68a350c111ec662daa025853d4a70d35be499) | CHANGELOG.md | @@ -1,5 +1,9 @@
# Ember Changelog
+### v3.3.0-beta.3 (June 18, 2018)
+- [#16743](https://github.com/emberjs/ember.js/pull/16743) [BUGFIX] Update glimmer-vm to 0.35.4.
+- [#16750](https://github.com/emberjs/ember.js/pull/16750) [BUGFIX] Bring back isObject guard for ember-utils/is_proxy
+
### v3.3.0-beta.2 (June 11,... | false |
Other | emberjs | ember.js | d38033daaa53db4857e775bbe491af80a5e467cd.json | Fix code style | packages/ember-runtime/tests/mixins/container_proxy_test.js | @@ -25,14 +25,17 @@ moduleFor(
assert.equal(result[OWNER], this.instance, 'returns an object with the OWNER symbol');
}
- ["@test actions queue completes before destruction"](assert) {
+ ['@test actions queue completes before destruction'](assert) {
assert.expect(1);
- this.registry.re... | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.