language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | ab27246721029814ca3feb1264d09f3965b7d734.json | Add blueprints for MU instance initializer | node-tests/fixtures/instance-initializer-test/module-unification/dummy.js | @@ -0,0 +1,25 @@
+import Application from '@ember/application';
+import { run } from '@ember/runloop';
+import { initialize } from 'dummy/init/instance-initializers/foo';
+import { module, test } from 'qunit';
+
+module('Unit | Instance Initializer | foo', {
+ beforeEach() {
+ run(() => {
+ this.application = ... | true |
Other | emberjs | ember.js | ab27246721029814ca3feb1264d09f3965b7d734.json | Add blueprints for MU instance initializer | node-tests/fixtures/instance-initializer-test/module-unification/mocha.js | @@ -0,0 +1,30 @@
+import { expect } from 'chai';
+import { describe, it, beforeEach } from 'mocha';
+import Application from '@ember/application';
+import { run } from '@ember/runloop';
+import { initialize } from 'my-app/init/instance-initializers/foo';
+import destroyApp from '../../helpers/destroy-app';
+
+describe(... | true |
Other | emberjs | ember.js | ab27246721029814ca3feb1264d09f3965b7d734.json | Add blueprints for MU instance initializer | node-tests/fixtures/instance-initializer-test/module-unification/rfc232.js | @@ -0,0 +1,28 @@
+import Application from '@ember/application';
+
+import { initialize } from 'my-app/init/instance-initializers/foo';
+import { module, test } from 'qunit';
+import { run } from '@ember/runloop';
+
+module('Unit | Instance Initializer | foo', function(hooks) {
+ hooks.beforeEach(function() {
+ this... | true |
Other | emberjs | ember.js | 2765c4806f805100cf2ab8693eb7bb9a31922df1.json | Add v3.6.0-beta.4 to CHANGELOG
[ci skip]
(cherry picked from commit 0f0f59d3606d615338dd8f6efb6aafac7a00ed46) | CHANGELOG.md | @@ -1,5 +1,11 @@
# Ember Changelog
+### v3.6.0-beta.4 (November 12, 2018)
+
+- [#17184](https://github.com/emberjs/ember.js/pull/17184) [BUGFIX] Ensures removeAllListeners does not break subsequent adds
+- [#17186](https://github.com/emberjs/ember.js/pull/17186) [BUGFIX] Fix RouteInfo QP mutability
+- [#17192](https... | false |
Other | emberjs | ember.js | 08ff5b991e2a42ab20adaa8d939ec680a3055c67.json | remove redundant arg flipping in Evented#one | packages/@ember/-internals/runtime/lib/mixins/evented.js | @@ -94,11 +94,6 @@ export default Mixin.create({
@public
*/
one(name, target, method) {
- if (!method) {
- method = target;
- target = null;
- }
-
addListener(this, name, target, method, true);
return this;
}, | false |
Other | emberjs | ember.js | 0f55cd9d21a6de8202e3d761b00f0d9e95d5501e.json | Add v3.6.0-beta.3 to CHANGELOG
[ci skip]
(cherry picked from commit bf773e88fe2960d7d9e45f8dd3eb1354777b5df9) | CHANGELOG.md | @@ -1,5 +1,11 @@
# Ember Changelog
+### v3.6.0-beta.3 (November 5, 2018)
+
+- [#17169](https://github.com/emberjs/ember.js/pull/17169) [BUGFIX] Add default implementations of Component lifecycle hooks
+- [#17165](https://github.com/emberjs/ember.js/pull/17165) [BUGFIX] Fix RouteInfo.find and transition.froms
+- [#17... | false |
Other | emberjs | ember.js | 313ce30dfaea576f126dd02a067864756f06567b.json | Add some missing CHANGELOG entries [ci skip]
(cherry picked from commit 6e0f477f1cf5d6b5a9bf476a1d43408039619521) | CHANGELOG.md | @@ -4,6 +4,8 @@
- [#17130](https://github.com/emberjs/ember.js/pull/17130) [BUGFIX] Ensure that timers scheduled after a system sleep are fired properly.
- [#17137](https://github.com/emberjs/ember.js/pull/17137) [BUGFIX] Assert when local variables shadow modifier invocations
+- [#17132](https://github.com/emberjs... | false |
Other | emberjs | ember.js | b05f4da9b5c7cca4f1badc021a8ebb0183380906.json | Adjust browser class name | bin/run-tests-browser-runner.js | @@ -4,7 +4,7 @@ const puppeteer = require('puppeteer');
const chalk = require('chalk');
const fs = require('fs');
-module.exports = class BroswerRunner {
+module.exports = class BrowserRunner {
constructor() {
this.resolveTest = undefined;
this.rejectTest = undefined; | true |
Other | emberjs | ember.js | b05f4da9b5c7cca4f1badc021a8ebb0183380906.json | Adjust browser class name | bin/run-tests.js | @@ -31,8 +31,8 @@ let browserRunner;
function getBrowserRunner() {
if (browserRunner === undefined) {
// requires new node
- let BroswerRunner = require('./run-tests-browser-runner');
- browserRunner = new BroswerRunner();
+ let BrowserRunner = require('./run-tests-browser-runner');
+ browserRunner... | true |
Other | emberjs | ember.js | e2352e6071af9c1a0865478d24f8f2c44778ebc8.json | Fix incorrect date in CHANGELOG
[ci skip] | CHANGELOG.md | @@ -1,6 +1,6 @@
# Ember Changelog
-### v3.6.0-beta.2 (October 27, 2018)
+### v3.6.0-beta.2 (October 29, 2018)
- [#17130](https://github.com/emberjs/ember.js/pull/17130) [BUGFIX] Ensure that timers scheduled after a system sleep are fired properly.
- [#17137](https://github.com/emberjs/ember.js/pull/17137) [BUGFI... | false |
Other | emberjs | ember.js | e529ae76a1582b2213f8dc723db17e1dad8628b7.json | Add v3.6.0-beta.2 to CHANGELOG
[ci skip]
(cherry picked from commit 596bdee3434f7d1a5369f0b11a870e38e56a7bf0) | CHANGELOG.md | @@ -1,5 +1,14 @@
# Ember Changelog
+### v3.6.0-beta.2 (October 27, 2018)
+
+- [#17130](https://github.com/emberjs/ember.js/pull/17130) [BUGFIX] Ensure that timers scheduled after a system sleep are fired properly.
+- [#17137](https://github.com/emberjs/ember.js/pull/17137) [BUGFIX] Assert when local variables shadow... | false |
Other | emberjs | ember.js | 19f5c8919052d1acea9147b341dbbc8009c34f59.json | Add 3.4.6 and 3.5.1 to the CHANGELOG.md.
[ci skip] | CHANGELOG.md | @@ -8,11 +8,24 @@
- [#17025](https://github.com/emberjs/ember.js/pull/17025) / [#17034](https://github.com/emberjs/ember.js/pull/17034) / [#17036](https://github.com/emberjs/ember.js/pull/17036) / [#17038](https://github.com/emberjs/ember.js/pull/17038) / [#17040](https://github.com/emberjs/ember.js/pull/17040) / [#17... | false |
Other | emberjs | ember.js | e7263d43e4454746c46b15d4faef805af8b883d1.json | Remove extraneous variable. Return inside if/else | packages/@ember/-internals/utils/lib/cache.ts | @@ -8,17 +8,14 @@ export default class Cache<T, V> {
}
get(key: T): V {
- let value;
if (this.store.has(key)) {
this.hits++;
- value = this.store.get(key);
+ return this.store.get(key);
} else {
this.misses++;
- value = this.set(key, this.func(key));
+ return thi... | false |
Other | emberjs | ember.js | 196a208a83edb2f4a88c42116a20631ca8bcb1fa.json | Change logic to remove variable that is never read | packages/@ember/-internals/utils/lib/cache.ts | @@ -8,11 +8,11 @@ export default class Cache<T, V> {
}
get(key: T): V {
- let value = this.store.get(key);
+ let value;
if (this.store.has(key)) {
this.hits++;
- return this.store.get(key);
+ value = this.store.get(key);
} else {
this.misses++;
value = this.set(k... | false |
Other | emberjs | ember.js | 05301603cdb00f800473ca3d8eb941ea63254f07.json | add test for setComponentManager with a factory | packages/@ember/-internals/glimmer/tests/integration/custom-component-manager-test.js | @@ -8,28 +8,27 @@ import {
import { setComponentManager, capabilities } from '@ember/-internals/glimmer';
if (GLIMMER_CUSTOM_COMPONENT_MANAGER) {
- class ComponentManagerTest extends RenderingTest {
- constructor(assert) {
- super(...arguments);
+ let BasicComponentManager = EmberObject.extend({
+ capa... | false |
Other | emberjs | ember.js | 101322cdc5cb4bc669322d9f4c117de3c7dd228d.json | Add tests for current AST plugin format.
We had previously only tested the legacy plugin format, and I went to
look for a reference plugin in the "new style" and was surprised that
there wasn't one in the tests.
I fixed that mistake in this commit... :D | packages/ember-template-compiler/tests/system/compile_options_test.js | @@ -28,7 +28,7 @@ moduleFor(
);
let customTransformCounter = 0;
-class CustomTransform {
+class LegacyCustomTransform {
constructor(options) {
customTransformCounter++;
this.options = options;
@@ -56,6 +56,26 @@ class CustomTransform {
}
}
+function customTransform() {
+ customTransformCounter++... | false |
Other | emberjs | ember.js | 8bc9483d6e5f5c138246aa2e39e5d7715dcb5f32.json | Share more stuff between custom managers | packages/@ember/-internals/glimmer/index.ts | @@ -307,4 +307,5 @@ export { default as OutletView } from './lib/views/outlet';
export { capabilities } from './lib/component-managers/custom';
export { setComponentManager, getComponentManager } from './lib/utils/custom-component-manager';
export { setModifierManager, getModifierManager } from './lib/utils/custom-m... | true |
Other | emberjs | ember.js | 8bc9483d6e5f5c138246aa2e39e5d7715dcb5f32.json | Share more stuff between custom managers | packages/@ember/-internals/glimmer/lib/component-managers/custom.ts | @@ -22,6 +22,7 @@ import { Destroyable } from '@glimmer/util';
import Environment from '../environment';
import RuntimeResolver from '../resolver';
import { OwnedTemplate } from '../template';
+import { ManagerArgs, valueForCapturedArgs } from '../utils/managers';
import { RootReference } from '../utils/references'... | true |
Other | emberjs | ember.js | 8bc9483d6e5f5c138246aa2e39e5d7715dcb5f32.json | Share more stuff between custom managers | packages/@ember/-internals/glimmer/lib/modifiers/custom.ts | @@ -1,16 +1,19 @@
import { Factory } from '@ember/-internals/owner';
-import { Dict, Opaque } from '@glimmer/interfaces';
+import { Opaque } from '@glimmer/interfaces';
import { Tag } from '@glimmer/reference';
import { Arguments, CapturedArguments, ModifierManager } from '@glimmer/runtime';
+import { ManagerArgs, v... | true |
Other | emberjs | ember.js | 8bc9483d6e5f5c138246aa2e39e5d7715dcb5f32.json | Share more stuff between custom managers | packages/@ember/-internals/glimmer/lib/resolver.ts | @@ -41,7 +41,7 @@ import { default as queryParams } from './helpers/query-param';
import { default as readonly } from './helpers/readonly';
import { default as unbound } from './helpers/unbound';
import ActionModifierManager from './modifiers/action';
-import { CustomModifierDefinition } from './modifiers/custom';
+... | true |
Other | emberjs | ember.js | 8bc9483d6e5f5c138246aa2e39e5d7715dcb5f32.json | Share more stuff between custom managers | packages/@ember/-internals/glimmer/lib/utils/custom-component-manager.ts | @@ -1,27 +1,24 @@
+import { Owner } from '@ember/-internals/owner';
import { GLIMMER_CUSTOM_COMPONENT_MANAGER } from '@ember/canary-features';
+import { Opaque } from '@glimmer/interfaces';
+import { getManager, ManagerFactory, setManager } from './managers';
-const getPrototypeOf = Object.getPrototypeOf;
-const MAN... | true |
Other | emberjs | ember.js | 8bc9483d6e5f5c138246aa2e39e5d7715dcb5f32.json | Share more stuff between custom managers | packages/@ember/-internals/glimmer/lib/utils/custom-modifier-manager.ts | @@ -1,32 +1,15 @@
-import { Owner } from '@ember/-internals/owner';
import { GLIMMER_MODIFIER_MANAGER } from '@ember/canary-features';
import { Opaque } from '@glimmer/util';
-import { ModifierManagerDelegate } from '../modifiers/custom';
+import { getManager, ManagerFactory, setManager } from './managers';
-const ... | true |
Other | emberjs | ember.js | 8bc9483d6e5f5c138246aa2e39e5d7715dcb5f32.json | Share more stuff between custom managers | packages/@ember/-internals/glimmer/lib/utils/managers.ts | @@ -0,0 +1,39 @@
+import { Owner } from '@ember/-internals/owner';
+import { Dict, Opaque } from '@glimmer/interfaces';
+import { CapturedArguments } from '@glimmer/runtime';
+
+const MANAGERS: WeakMap<any, ManagerFactory<Opaque>> = new WeakMap();
+
+const getPrototypeOf = Object.getPrototypeOf;
+
+export type ManagerF... | true |
Other | emberjs | ember.js | 506b8841888190de9cc35814d16a8d3098cfb20e.json | add more counters, fix performance issues | packages/@ember/-internals/meta/lib/meta.ts | @@ -12,10 +12,14 @@ export interface MetaCounters {
deleteCalls: number;
metaCalls: number;
metaInstantiated: number;
+ matchingListenersCalls: number;
addToListenersCalls: number;
removeFromListenersCalls: number;
removeAllListenersCalls: number;
listenersInherited: number;
+ listenersFlattened:... | true |
Other | emberjs | ember.js | 506b8841888190de9cc35814d16a8d3098cfb20e.json | add more counters, fix performance issues | packages/@ember/-internals/meta/tests/listeners_test.js | @@ -0,0 +1,159 @@
+import { AbstractTestCase, moduleFor } from 'internal-test-helpers';
+import { meta, counters } from '..';
+
+moduleFor(
+ 'Ember.meta listeners',
+ class extends AbstractTestCase {
+ ['@test basics'](assert) {
+ let t = {};
+ let m = meta({});
+ m.addToListeners('hello', t, 'm', ... | true |
Other | emberjs | ember.js | 506b8841888190de9cc35814d16a8d3098cfb20e.json | add more counters, fix performance issues | packages/@ember/-internals/meta/tests/meta_test.js | @@ -1,5 +1,5 @@
import { AbstractTestCase, moduleFor } from 'internal-test-helpers';
-import { meta, counters } from '..';
+import { meta } from '..';
moduleFor(
'Ember.meta',
@@ -33,102 +33,6 @@ moduleFor(
}
}
- ['@test meta.listeners basics'](assert) {
- let t = {};
- let m = meta({}... | true |
Other | emberjs | ember.js | 62433af49fbaed42507f758bd4e0b37885caf339.json | Fix Component#layout example | packages/@ember/-internals/glimmer/lib/component.ts | @@ -454,7 +454,15 @@ export const BOUNDS = symbol('BOUNDS');
});
```
- The above will result in the following HTML output:
+ If you call the `person-profile` component like so:
+
+ ```
+ {{#person-profile}}
+ <h2>Chief Basket Weaver</h2>
+ <h3>Fisherman Industries</h3>
+ {{/person-profile}}
+
+ It... | false |
Other | emberjs | ember.js | 9343f34813538dc20f35f139c0aa5ff9f68df483.json | add simple test for missing yuidocs | bin/yuidoc-tests.js | @@ -0,0 +1,51 @@
+'use strict';
+
+/**
+ * This tests whether there is a change in the number of modules, classes, or properties that yuidoc sees. It is not a guarantee that all documentation will show up in the Ember API docs app, but it checks for major regressions.
+ */
+
+const fs = require('fs');
+const docData = ... | true |
Other | emberjs | ember.js | 9343f34813538dc20f35f139c0aa5ff9f68df483.json | add simple test for missing yuidocs | package.json | @@ -46,7 +46,7 @@
"test:node": "qunit tests/**/*-test.js",
"test:browserstack": "node bin/run-browserstack-tests.js",
"test:testem": "testem -f testem.dist.js",
- "test:docs": "ember ember-cli-yuidoc && node bin/yuidoc-tests.js"
+ "test:docs": "qunit bin/yuidoc-tests.js"
},
"dependencies": {
... | true |
Other | emberjs | ember.js | 6416d56ff3c64a05bead27fd348ff187ceb52a43.json | add command to run yuidoc tests | package.json | @@ -45,7 +45,8 @@
"test:blueprints-debugger": "node --inspect-brk node-tests/nodetest-runner.js",
"test:node": "qunit tests/**/*-test.js",
"test:browserstack": "node bin/run-browserstack-tests.js",
- "test:testem": "testem -f testem.dist.js"
+ "test:testem": "testem -f testem.dist.js",
+ "test:d... | false |
Other | emberjs | ember.js | 1c04ff5a4e18a06035620f2e1eb73effa55ae660.json | Add return type to hash helper | packages/@ember/-internals/glimmer/lib/helpers/hash.ts | @@ -1,4 +1,6 @@
+import { PathReference } from '@glimmer/reference';
import { Arguments, VM } from '@glimmer/runtime';
+import { Dict, Opaque } from '@glimmer/util';
/**
@module ember
@@ -43,6 +45,6 @@ import { Arguments, VM } from '@glimmer/runtime';
@public
*/
-export default function(_vm: VM, args: Argu... | false |
Other | emberjs | ember.js | 239809aa477a46c45607cad84678a47a12c80b29.json | Add v3.6.0-beta.1 to CHANGELOG
[ci skip]
(cherry picked from commit ae33dc752ff30e4cb646e072f3fff5a6dc440651) | CHANGELOG.md | @@ -1,5 +1,13 @@
# Ember Changelog
+### v3.6.0-beta.1 (October 8, 2018)
+
+- [#16956](https://github.com/emberjs/ember.js/pull/16956) [DEPRECATION] Deprecate Ember.merge
+- [#16795](https://github.com/emberjs/ember.js/pull/16795) [FEATURE] Native Class Constructor Update (see [emberjs/rfcs#337](https://github.com/em... | false |
Other | emberjs | ember.js | 1dfe789b3d62b47d93602c619e123db7cd7e49d3.json | Add v3.5.0 to CHANGELOG
[ci skip]
(cherry picked from commit cae13d41674d4950766ba25f458c349ccfb0de1f) | CHANGELOG.md | @@ -1,23 +1,9 @@
# Ember Changelog
-### v3.5.0-beta.4 (October 1, 2018)
-
-- [#17003](https://github.com/emberjs/ember.js/pull/17003) / [#17013](https://github.com/emberjs/ember.js/pull/17013) [BUGFIX] Fix rendering of empty content with `{{{...}}}` or `{{...}}` with `htmlSafe('')`
-
-### v3.5.0-beta.3 (September 24... | false |
Other | emberjs | ember.js | b5b50b031eab48661bc8875bf54c9d9882690f3a.json | reuse meta in `property_set` | packages/@ember/-internals/metal/lib/property_get.ts | @@ -96,7 +96,6 @@ export function get(obj: object, keyName: string): any {
let isFunction = type === 'function';
let isObjectLike = isObject || isFunction;
- let descriptor;
let value: any;
if (isObjectLike) {
@@ -105,7 +104,7 @@ export function get(obj: object, keyName: string): any {
if (track... | true |
Other | emberjs | ember.js | b5b50b031eab48661bc8875bf54c9d9882690f3a.json | reuse meta in `property_set` | packages/@ember/-internals/metal/lib/property_set.ts | @@ -76,11 +76,11 @@ export function set(obj: object, keyName: string, value: any, tolerant?: boolean
return setPath(obj, keyName, value, tolerant);
}
- let possibleDesc = descriptorFor(obj, keyName);
+ let meta = peekMeta(obj);
+ let descriptor = descriptorFor(obj, keyName, meta);
- if (possibleDesc !==... | true |
Other | emberjs | ember.js | 94b9fccf11e1c87476cfe7899a55bc9c00c14194.json | Add urls for router related deprecations | packages/@ember/-internals/routing/lib/system/route.ts | @@ -2537,6 +2537,7 @@ if (EMBER_ROUTING_ROUTER_SERVICE && ROUTER_EVENTS) {
{
id: 'deprecate-router-events',
until: '4.0.0',
+ url: 'https://emberjs.com/deprecations/v3.x#toc_deprecate-router-events',
}
);
}
@@ -2548,6 +2549,7 @@ if (EMBER_ROUTIN... | true |
Other | emberjs | ember.js | 94b9fccf11e1c87476cfe7899a55bc9c00c14194.json | Add urls for router related deprecations | packages/@ember/-internals/routing/lib/system/router.ts | @@ -86,6 +86,7 @@ if (TRANSITION_STATE) {
{
id: 'transition-state',
until: '3.9.0',
+ url: 'https://emberjs.com/deprecations/v3.x#toc_transition-state',
}
);
}
@@ -102,6 +103,7 @@ if (TRANSITION_STATE) {
{
id: 'transition... | true |
Other | emberjs | ember.js | 8df967b9c9e2a74efb2bb72deff87eb162c4a9b0.json | Fix typo on line 75
an -> and
(cherry picked from commit 4eaf54125da8c9d20c79b2c747846990f64ab2d4) | packages/@ember/-internals/glimmer/lib/helper.ts | @@ -72,7 +72,7 @@ export function isSimpleHelper(helper: SimpleHelper | HelperInstance): helper is
Each time the input to a helper changes, the `compute` function will be
called again.
- As instances, these helpers also have access to the container an will accept
+ As instances, these helpers also have access... | false |
Other | emberjs | ember.js | ac740b817f6493b3694b9d1f0d17514aa9e71d3e.json | Remove testem import from tests/index.html | tests/index.html | @@ -10,7 +10,6 @@
}
</style>
<script src="../qunit/qunit.js"></script>
- <script src="/testem.js"></script>
<script type="text/javascript">
window.loadScript = function(url) { | false |
Other | emberjs | ember.js | 716f194164840d524f82c36ff810ca574830298a.json | Add v3.4.5 to CHANGELOG
[ci skip]
(cherry picked from commit 82b0b2dfe95e59025246148856624af327085f5a) | CHANGELOG.md | @@ -19,6 +19,10 @@
- [#16877](https://github.com/emberjs/ember.js/pull/16877) [CLEANUP] Allow routes to be named "array" and "object"
- [#16907](https://github.com/emberjs/ember.js/pull/16907) Upgrade to TypeScript 3.0
+### v3.4.5 (October 4, 2018)
+
+- [#17029](https://github.com/emberjs/ember.js/pull/17029) [BUGF... | false |
Other | emberjs | ember.js | 0f95c777fe507940f2922e6d256125677d5bb882.json | Remove old Router Service FF
This removes the FF around all the router service features that were
go'd earlier this year. It also reuses the same flag to guard the new
features that we are adding. | packages/@ember/application/lib/application.js | @@ -30,7 +30,6 @@ import Engine from '@ember/engine';
import { privatize as P } from '@ember/-internals/container';
import { setupApplicationRegistry } from '@ember/-internals/glimmer';
import { RouterService } from '@ember/-internals/routing';
-import { EMBER_ROUTING_ROUTER_SERVICE } from '@ember/canary-features';
... | true |
Other | emberjs | ember.js | 0f95c777fe507940f2922e6d256125677d5bb882.json | Remove old Router Service FF
This removes the FF around all the router service features that were
go'd earlier this year. It also reuses the same flag to guard the new
features that we are adding. | packages/@ember/canary-features/index.ts | @@ -10,7 +10,7 @@ export const DEFAULT_FEATURES = {
EMBER_LIBRARIES_ISREGISTERED: null,
EMBER_IMPROVED_INSTRUMENTATION: null,
EMBER_GLIMMER_NAMED_ARGUMENTS: true,
- EMBER_ROUTING_ROUTER_SERVICE: true,
+ EMBER_ROUTING_ROUTER_SERVICE: null,
EMBER_ENGINES_MOUNT_PARAMS: true,
EMBER_MODULE_UNIFICATION: null... | true |
Other | emberjs | ember.js | 0f95c777fe507940f2922e6d256125677d5bb882.json | Remove old Router Service FF
This removes the FF around all the router service features that were
go'd earlier this year. It also reuses the same flag to guard the new
features that we are adding. | packages/ember/tests/routing/decoupled_basic_test.js | @@ -12,6 +12,7 @@ import { getTextOf } from 'internal-test-helpers';
import { Component } from '@ember/-internals/glimmer';
import Engine from '@ember/engine';
import { InternalTransition as Transition } from 'router_js';
+import { EMBER_ROUTING_ROUTER_SERVICE } from '@ember/canary-features';
let originalConsoleE... | true |
Other | emberjs | ember.js | 0f95c777fe507940f2922e6d256125677d5bb882.json | Remove old Router Service FF
This removes the FF around all the router service features that were
go'd earlier this year. It also reuses the same flag to guard the new
features that we are adding. | packages/ember/tests/routing/deprecated_handler_infos_test.js | @@ -60,9 +60,11 @@ if (EMBER_ROUTING_ROUTER_SERVICE) {
'@test handlerInfos are deprecated and associated private apis'(assert) {
let done = assert.async();
- return this.visit('/parent').then(() => {
- done();
- });
+ expectDeprecation(() => {
+ return this.visit... | true |
Other | emberjs | ember.js | 0f95c777fe507940f2922e6d256125677d5bb882.json | Remove old Router Service FF
This removes the FF around all the router service features that were
go'd earlier this year. It also reuses the same flag to guard the new
features that we are adding. | packages/ember/tests/routing/router_service_test/basic_test.js | @@ -2,94 +2,90 @@ import { Route, NoneLocation } from '@ember/-internals/routing';
import { set } from '@ember/-internals/metal';
import { RouterTestCase, moduleFor } from 'internal-test-helpers';
-import { EMBER_ROUTING_ROUTER_SERVICE } from '@ember/canary-features';
+moduleFor(
+ 'Router Service - main',
+ clas... | true |
Other | emberjs | ember.js | 0f95c777fe507940f2922e6d256125677d5bb882.json | Remove old Router Service FF
This removes the FF around all the router service features that were
go'd earlier this year. It also reuses the same flag to guard the new
features that we are adding. | packages/ember/tests/routing/router_service_test/currenturl_lifecycle_test.js | @@ -5,145 +5,141 @@ import { Route } from '@ember/-internals/routing';
import { get } from '@ember/-internals/metal';
import { RouterTestCase, moduleFor } from 'internal-test-helpers';
-import { EMBER_ROUTING_ROUTER_SERVICE } from '@ember/canary-features';
-
-if (EMBER_ROUTING_ROUTER_SERVICE) {
- let results = [];... | true |
Other | emberjs | ember.js | 0f95c777fe507940f2922e6d256125677d5bb882.json | Remove old Router Service FF
This removes the FF around all the router service features that were
go'd earlier this year. It also reuses the same flag to guard the new
features that we are adding. | packages/ember/tests/routing/router_service_test/isActive_test.js | @@ -1,113 +1,109 @@
import Controller from '@ember/controller';
import { RouterTestCase, moduleFor } from 'internal-test-helpers';
-import { EMBER_ROUTING_ROUTER_SERVICE } from '@ember/canary-features';
-
-if (EMBER_ROUTING_ROUTER_SERVICE) {
- moduleFor(
- 'Router Service - isActive',
- class extends RouterT... | true |
Other | emberjs | ember.js | 0f95c777fe507940f2922e6d256125677d5bb882.json | Remove old Router Service FF
This removes the FF around all the router service features that were
go'd earlier this year. It also reuses the same flag to guard the new
features that we are adding. | packages/ember/tests/routing/router_service_test/replaceWith_test.js | @@ -3,142 +3,138 @@ import { RouterTestCase, moduleFor } from 'internal-test-helpers';
import { InternalTransition as Transition } from 'router_js';
import Controller from '@ember/controller';
-import { EMBER_ROUTING_ROUTER_SERVICE } from '@ember/canary-features';
-
-if (EMBER_ROUTING_ROUTER_SERVICE) {
- moduleFor... | true |
Other | emberjs | ember.js | 0f95c777fe507940f2922e6d256125677d5bb882.json | Remove old Router Service FF
This removes the FF around all the router service features that were
go'd earlier this year. It also reuses the same flag to guard the new
features that we are adding. | packages/ember/tests/routing/router_service_test/transitionTo_test.js | @@ -7,364 +7,360 @@ import { get } from '@ember/-internals/metal';
import { RouterTestCase, moduleFor } from 'internal-test-helpers';
import { InternalTransition as Transition } from 'router_js';
-import { EMBER_ROUTING_ROUTER_SERVICE } from '@ember/canary-features';
-
-if (EMBER_ROUTING_ROUTER_SERVICE) {
- module... | true |
Other | emberjs | ember.js | 0f95c777fe507940f2922e6d256125677d5bb882.json | Remove old Router Service FF
This removes the FF around all the router service features that were
go'd earlier this year. It also reuses the same flag to guard the new
features that we are adding. | packages/ember/tests/routing/router_service_test/urlFor_test.js | @@ -4,8 +4,6 @@ import { Route } from '@ember/-internals/routing';
import { get } from '@ember/-internals/metal';
import { RouterTestCase, moduleFor } from 'internal-test-helpers';
-import { EMBER_ROUTING_ROUTER_SERVICE } from '@ember/canary-features';
-
function setupController(app, name) {
let controllerName ... | true |
Other | emberjs | ember.js | d8ee5524036703d377a50fa5709bc4634b90c300.json | add docs and more deprecations | packages/@ember/-internals/routing/lib/services/router.ts | @@ -38,6 +38,79 @@ import { extractRouteArgs, resemblesURL, shallowEqual } from '../utils';
export default class RouterService extends Service {
_router!: EmberRouter;
+ init() {
+ this._super(...arguments);
+ this._router.on('routeWillChange', (transition: Transition) => {
+ this.trigger('routeWillCh... | true |
Other | emberjs | ember.js | d8ee5524036703d377a50fa5709bc4634b90c300.json | add docs and more deprecations | packages/@ember/-internals/routing/lib/system/route.ts | @@ -7,8 +7,9 @@ import {
Object as EmberObject,
typeOf,
} from '@ember/-internals/runtime';
+import { EMBER_ROUTING_ROUTER_SERVICE } from '@ember/canary-features';
import { assert, deprecate, info, isTesting } from '@ember/debug';
-import { ROUTER_ROUTER } from '@ember/deprecated-features';
+import { ROUTER_EVE... | true |
Other | emberjs | ember.js | d8ee5524036703d377a50fa5709bc4634b90c300.json | add docs and more deprecations | packages/@ember/-internals/routing/lib/system/router.ts | @@ -11,7 +11,12 @@ import { DEBUG } from '@glimmer/env';
import EmberLocation, { EmberLocation as IEmberLocation } from '../location/api';
import { calculateCacheKey, extractRouteArgs, getActiveTargetName, resemblesURL } from '../utils';
import EmberRouterDSL from './dsl';
-import Route, { defaultSerialize, hasDefau... | true |
Other | emberjs | ember.js | d8ee5524036703d377a50fa5709bc4634b90c300.json | add docs and more deprecations | packages/ember/tests/routing/router_service_test/events_test.js | @@ -635,15 +635,60 @@ if (EMBER_ROUTING_ROUTER_SERVICE) {
moduleFor(
'Router Service - deprecated events',
class extends RouterTestCase {
- '@test willTransition is deprecated'() {
+ '@test willTransition events are deprecated'() {
return this.visit('/').then(() => {
expectDep... | true |
Other | emberjs | ember.js | 7c45f2066931bb779ced201797b5a8ff7eef0322.json | Add v3.5.0-beta.4 to CHANGELOG
[ci skip]
(cherry picked from commit 942fdb76ddb64376eca1070d8476a766bd172e4f) | CHANGELOG.md | @@ -1,8 +1,8 @@
# Ember Changelog
-### v3.6.0-beta.1 (Unreleased)
+### v3.5.0-beta.4 (October 1, 2018)
-- [#17003](https://github.com/emberjs/ember.js/pull/17003) / [#17013](https://github.com/emberjs/ember.js/pull/17013) [BUGFIX] Fix rendering of empty content with `{{{...}}}` and `htmlSafe`
+- [#17003](https://g... | false |
Other | emberjs | ember.js | fba532061ae4f158c22d55b9c9d780d383079091.json | Fix jquery-none.js request in tests
Fixes #17017 | tests/index.html | @@ -21,7 +21,7 @@
<script type="text/javascript">
// Load custom version of jQuery if possible (assign to window so IE8 can use in later blocks)
var jQueryVersion = QUnit.urlParams.jquery;
- if (jQueryVersion) {
+ if (jQueryVersion && jQueryVersion !== 'none') {
loadScript('https:/... | false |
Other | emberjs | ember.js | 373e9820b65b7200f24064a42bc9fe885926d88e.json | Add failing test for #16314
(cherry picked from commit 74ebe7b0e9513bb9446ffd2c272e4101c3e5deb7) | packages/@ember/-internals/glimmer/tests/integration/content-test.js | @@ -702,6 +702,22 @@ moduleFor(
this.assertTextNode(this.firstChild, content);
// this.takeSnapshot();
}
+
+ ['@test it can render empty safe strings [GH#16314]']() {
+ this.render('before {{value}} after', { value: htmlSafe('hello') });
+
+ this.assertHTML('before hello after');
+
+ ... | true |
Other | emberjs | ember.js | 373e9820b65b7200f24064a42bc9fe885926d88e.json | Add failing test for #16314
(cherry picked from commit 74ebe7b0e9513bb9446ffd2c272e4101c3e5deb7) | packages/@ember/-internals/glimmer/tests/integration/syntax/each-test.js | @@ -2,9 +2,8 @@ import { get, set, notifyPropertyChange } from '@ember/-internals/metal';
import { applyMixins, strip } from '../../utils/abstract-test-case';
import { moduleFor, RenderingTest } from '../../utils/test-case';
import { A as emberA, ArrayProxy, RSVP } from '@ember/-internals/runtime';
-import { Compone... | true |
Other | emberjs | ember.js | b5ab036ff0f741557646850fcaeb40ce9d4dde24.json | Add failing test for #14924 and #16172
(cherry picked from commit 830d766071a2a09e0805660ccb25201dc542fb5c) | packages/@ember/-internals/glimmer/tests/integration/application/rendering-test.js | @@ -503,5 +503,28 @@ moduleFor(
}, expectedBacktrackingMessage);
});
}
+
+ ['@test route templates with {{{undefined}}} [GH#14924] [GH#16172]']() {
+ this.router.map(function() {
+ this.route('first');
+ this.route('second');
+ });
+
+ this.addTemplate('first', 'firs... | false |
Other | emberjs | ember.js | 1140e27ea947dc7bf6d8adcf9aed658d2b83155e.json | Add failing test for #14978
(cherry picked from commit 793d123292a2756321f254eb7506eb72951af544) | packages/@ember/-internals/glimmer/tests/integration/content-test.js | @@ -818,6 +818,42 @@ moduleFor(
this.assertContent('<b>Max</b><i>James</i>');
}
+
+ ['@test empty content in trusted curlies [GH#14978]']() {
+ this.render('before {{{value}}} after', {
+ value: 'hello',
+ });
+
+ this.assertContent('before hello after');
+
+ this.runTask(() ... | false |
Other | emberjs | ember.js | a835354b5f91454403caa21fc8b9fc267b3483be.json | Add v3.5.0-beta.3 to CHANGELOG
[ci skip]
(cherry picked from commit 15a47a25d947cc58b95d4e5fff0f8575be0fafca) | CHANGELOG.md | @@ -1,5 +1,10 @@
# Ember Changelog
+### v3.5.0-beta.3 (September 24, 2018)
+
+- [#16978](https://github.com/emberjs/ember.js/pull/16978) [BUGFIX] Properly teardown alias
+- [#16999](https://github.com/emberjs/ember.js/pull/16999) [BUGFIX] Fix mouseEnter/Leave event delegation w/o jQuery
+
### v3.5.0-beta.2 (Septemb... | false |
Other | emberjs | ember.js | cdc02da11d9dffd3766d21ead0bdab7de8ac923d.json | Add v3.4.2 to CHANGELOG
[ci skip]
(cherry picked from commit af8f4ee249f4f16134610b6b6372a9d4ce0a1720) | CHANGELOG.md | @@ -10,7 +10,13 @@
- [#16877](https://github.com/emberjs/ember.js/pull/16877) [CLEANUP] Allow routes to be named "array" and "object"
- [#16907](https://github.com/emberjs/ember.js/pull/16907) Upgrade to TypeScript 3.0
+### v3.4.2 (September 24, 2018)
+
+- [#16860](https://github.com/emberjs/ember.js/pull/16860) [B... | false |
Other | emberjs | ember.js | 9a817d4de69e8b57ce9b85bf496ab5d6919353a0.json | remove new usage from tests | packages/@ember/-internals/runtime/tests/helpers/array.js | @@ -171,7 +171,7 @@ class CopyableNativeArray extends AbstractArrayHelper {
class CopyableArray extends AbstractArrayHelper {
newObject() {
- return new CopyableObject();
+ return CopyableObject.create();
}
isEqual(a, b) {
@@ -280,15 +280,15 @@ const CopyableObject = EmberObject.extend(Copyable, {
... | true |
Other | emberjs | ember.js | 9a817d4de69e8b57ce9b85bf496ab5d6919353a0.json | remove new usage from tests | packages/@ember/-internals/runtime/tests/mixins/array_test.js | @@ -63,7 +63,7 @@ moduleFor(
}
['@test slice supports negative index arguments'](assert) {
- let testArray = new TestArray({ _content: [1, 2, 3, 4] });
+ let testArray = TestArray.create({ _content: [1, 2, 3, 4] });
assert.deepEqual(testArray.slice(-2), [3, 4], 'slice(-2)');
assert... | true |
Other | emberjs | ember.js | 9a817d4de69e8b57ce9b85bf496ab5d6919353a0.json | remove new usage from tests | packages/@ember/-internals/runtime/tests/system/core_object_test.js | @@ -6,35 +6,31 @@ import { moduleFor, AbstractTestCase, buildOwner } from 'internal-test-helpers';
moduleFor(
'Ember.CoreObject',
class extends AbstractTestCase {
- ['@test works with new (one arg)'](assert) {
- let obj = new CoreObject({
- firstName: 'Stef',
- lastName: 'Penner',
- })... | true |
Other | emberjs | ember.js | 9a817d4de69e8b57ce9b85bf496ab5d6919353a0.json | remove new usage from tests | packages/@ember/-internals/runtime/tests/system/object/computed_test.js | @@ -31,7 +31,7 @@ moduleFor(
}),
});
- testWithDefault(assert, 'FOO', new MyClass(), 'foo');
+ testWithDefault(assert, 'FOO', MyClass.create(), 'foo');
}
['@test computed property on subclass'](assert) {
@@ -47,7 +47,7 @@ moduleFor(
}),
});
- testWithDefaul... | true |
Other | emberjs | ember.js | 9a817d4de69e8b57ce9b85bf496ab5d6919353a0.json | remove new usage from tests | packages/@ember/-internals/runtime/tests/system/object/destroy_test.js | @@ -130,13 +130,13 @@ moduleFor(
}),
});
- objs.a = new A();
+ objs.a = A.create();
- objs.b = new B();
+ objs.b = B.create();
- objs.c = new C();
+ objs.c = C.create();
- new LongLivedObject();
+ LongLivedObject.create();
run(() => {
let... | true |
Other | emberjs | ember.js | 9a817d4de69e8b57ce9b85bf496ab5d6919353a0.json | remove new usage from tests | packages/@ember/-internals/runtime/tests/system/object/es-compatibility-test.js | @@ -47,25 +47,6 @@ moduleFor(
'passed-property',
'passed property available on instance (create)'
);
- calls = [];
- myObject = new MyObject({ passedProperty: 'passed-property' });
-
- assert.deepEqual(calls, ['constructor', 'init'], 'constructor then init called (new)');
- ... | true |
Other | emberjs | ember.js | 9a817d4de69e8b57ce9b85bf496ab5d6919353a0.json | remove new usage from tests | packages/@ember/-internals/runtime/tests/system/object/extend_test.js | @@ -8,14 +8,14 @@ moduleFor(
['@test Basic extend'](assert) {
let SomeClass = EmberObject.extend({ foo: 'BAR' });
assert.ok(SomeClass.isClass, 'A class has isClass of true');
- let obj = new SomeClass();
+ let obj = SomeClass.create();
assert.equal(obj.foo, 'BAR');
}
['@t... | true |
Other | emberjs | ember.js | 9a817d4de69e8b57ce9b85bf496ab5d6919353a0.json | remove new usage from tests | packages/@ember/-internals/runtime/tests/system/object/observer_test.js | @@ -15,7 +15,7 @@ moduleFor(
}),
});
- let obj = new MyClass();
+ let obj = MyClass.create();
assert.equal(get(obj, 'count'), 0, 'should not invoke observer immediately');
set(obj, 'bar', 'BAZ');
@@ -37,7 +37,7 @@ moduleFor(
}),
});
- let obj = new Subc... | true |
Other | emberjs | ember.js | 9a817d4de69e8b57ce9b85bf496ab5d6919353a0.json | remove new usage from tests | packages/@ember/-internals/runtime/tests/system/object/reopen_test.js | @@ -14,8 +14,8 @@ moduleFor(
bar: 'BAR',
});
- assert.equal(new Subclass().foo(), 'FOO', 'Adds method');
- assert.equal(get(new Subclass(), 'bar'), 'BAR', 'Adds property');
+ assert.equal(Subclass.create().foo(), 'FOO', 'Adds method');
+ assert.equal(get(Subclass.create(), 'bar'), ... | true |
Other | emberjs | ember.js | 9a817d4de69e8b57ce9b85bf496ab5d6919353a0.json | remove new usage from tests | packages/ember-testing/lib/setup_for_testing.js | @@ -29,7 +29,7 @@ export default function setupForTesting() {
let adapter = getAdapter();
// if adapter is not manually set default to QUnit
if (!adapter) {
- setAdapter(typeof self.QUnit === 'undefined' ? new Adapter() : new QUnitAdapter());
+ setAdapter(typeof self.QUnit === 'undefined' ? Adapter.creat... | true |
Other | emberjs | ember.js | 9a817d4de69e8b57ce9b85bf496ab5d6919353a0.json | remove new usage from tests | packages/ember-testing/tests/adapters/adapter_test.js | @@ -9,7 +9,7 @@ moduleFor(
class extends AbstractTestCase {
constructor() {
super();
- adapter = new Adapter();
+ adapter = Adapter.create();
}
teardown() { | true |
Other | emberjs | ember.js | 9a817d4de69e8b57ce9b85bf496ab5d6919353a0.json | remove new usage from tests | packages/ember-testing/tests/adapters/qunit_test.js | @@ -15,7 +15,7 @@ moduleFor(
delete QUnit.start;
delete QUnit.stop;
- adapter = new QUnitAdapter();
+ adapter = QUnitAdapter.create();
}
teardown() { | true |
Other | emberjs | ember.js | 9a817d4de69e8b57ce9b85bf496ab5d6919353a0.json | remove new usage from tests | packages/internal-test-helpers/lib/build-owner.js | @@ -25,7 +25,7 @@ export default function buildOwner(options = {}) {
let Owner = EmberObject.extend(RegistryProxyMixin, ContainerProxyMixin);
- let namespace = new EmberObject({
+ let namespace = EmberObject.create({
Resolver: new ResolverWrapper(resolver),
});
| true |
Other | emberjs | ember.js | 246435e7260f45d9e5cc35a4a8b4de4f011f3625.json | avoid double define for native descriptors | packages/@ember/-internals/metal/lib/alias.ts | @@ -31,6 +31,7 @@ export class AliasedProperty extends Descriptor implements DescriptorWithDepende
setup(obj: object, keyName: string): void {
assert(`Setting alias '${keyName}' on self`, this.altKey !== keyName);
+ super.setup(obj, keyName);
let meta = metaFor(obj);
if (meta.peekWatching(keyName... | true |
Other | emberjs | ember.js | 246435e7260f45d9e5cc35a4a8b4de4f011f3625.json | avoid double define for native descriptors | packages/@ember/-internals/metal/lib/descriptor.ts | @@ -1,25 +1,25 @@
-import { Descriptor as EmberDescriptor } from './properties';
+import { Descriptor } from './properties';
export default function descriptor(desc: PropertyDescriptor) {
- return new Descriptor(desc);
+ return new NativeDescriptor(desc);
}
/**
A wrapper for a native ES5 descriptor. In an i... | true |
Other | emberjs | ember.js | 246435e7260f45d9e5cc35a4a8b4de4f011f3625.json | avoid double define for native descriptors | packages/@ember/-internals/metal/lib/properties.ts | @@ -27,14 +27,18 @@ export type InheritingGetterFunction = ((this: object) => void) & {
@private
*/
export abstract class Descriptor {
- isDescriptor: boolean;
- enumerable: boolean;
- constructor() {
- this.isDescriptor = true;
- this.enumerable = true;
+ isDescriptor = true;
+ enumerable = true;
+ co... | true |
Other | emberjs | ember.js | 246435e7260f45d9e5cc35a4a8b4de4f011f3625.json | avoid double define for native descriptors | packages/@ember/-internals/metal/lib/property_get.ts | @@ -131,14 +131,6 @@ export function get(obj: object, keyName: string): any {
}
);
- Object.defineProperty(obj, keyName, {
- configurable: true,
- enumerable: value.enumerable === false,
- get() {
- return value.get(this, keyName);
- },
- });
-
met... | true |
Other | emberjs | ember.js | 246435e7260f45d9e5cc35a4a8b4de4f011f3625.json | avoid double define for native descriptors | packages/@ember/-internals/metal/lib/property_set.ts | @@ -108,14 +108,6 @@ export function set(obj: object, keyName: string, value: any, tolerant?: boolean
let cv: Descriptor = currentValue;
- Object.defineProperty(obj, keyName, {
- configurable: true,
- enumerable: cv.enumerable === false,
- get() {
- return cv.get(this, keyName);
- ... | true |
Other | emberjs | ember.js | 246435e7260f45d9e5cc35a4a8b4de4f011f3625.json | avoid double define for native descriptors | packages/@ember/-internals/metal/tests/descriptor_test.js | @@ -1,6 +1,7 @@
import { Object as EmberObject } from '@ember/-internals/runtime';
import { Mixin, defineProperty, descriptor } from '..';
import { moduleFor, AbstractTestCase } from 'internal-test-helpers';
+import { isEdge } from 'internal-test-helpers';
let classes = [
class {
@@ -148,7 +149,7 @@ let classe... | true |
Other | emberjs | ember.js | 246435e7260f45d9e5cc35a4a8b4de4f011f3625.json | avoid double define for native descriptors | packages/internal-test-helpers/index.js | @@ -27,5 +27,5 @@ export {
ModuleBasedResolver as ModuleBasedTestResolver,
} from './lib/test-resolver';
-export { isIE11 } from './lib/browser-detect';
+export { isIE11, isEdge } from './lib/browser-detect';
export { verifyInjection, verifyRegistration } from './lib/registry-check'; | true |
Other | emberjs | ember.js | 246435e7260f45d9e5cc35a4a8b4de4f011f3625.json | avoid double define for native descriptors | packages/internal-test-helpers/lib/browser-detect.ts | @@ -8,3 +8,4 @@ declare global {
}
}
export const isIE11 = !window.ActiveXObject && 'ActiveXObject' in window;
+export const isEdge = /Edge/.test(navigator.userAgent); | true |
Other | emberjs | ember.js | a34fb0e3db9a62776e9034eadb89fac1393415a8.json | Replace Slack badge with Discord | README.md | @@ -5,7 +5,7 @@
<p align="center">
<a href="http://travis-ci.org/emberjs/ember.js"><img src="https://secure.travis-ci.org/emberjs/ember.js.svg?branch=master" alt="Build Status"></a>
<a href="https://codeclimate.com/github/emberjs/ember.js"><img src="https://codeclimate.com/github/emberjs/ember.js.svg" alt="Code ... | false |
Other | emberjs | ember.js | ddc2ae169f3e77575853f9f1086a05b1dac0a2b0.json | Add v3.5.0-beta.2 to CHANGELOG
[ci skip]
(cherry picked from commit 9ed7321a3bdf5d5ec4f16ac294224bf8c8760665) | CHANGELOG.md | @@ -1,5 +1,10 @@
# Ember Changelog
+### v3.5.0-beta.2 (September 10, 2018)
+
+- [#16933](https://github.com/emberjs/ember.js/pull/16933) [BUGFIX] Update glimmer-vm packages to 0.38.8
+- [#16860](https://github.com/emberjs/ember.js/pull/16860) [BUGFIX] Clear chains in ProxyMixin when destroyed
+
### v3.5.0-beta.1 (A... | false |
Other | emberjs | ember.js | 9930a8b390158fc335990e28382213c4969c2307.json | Add v3.4.1 to CHANGELOG
[ci skip]
(cherry picked from commit e0317d4aa9b506a552d4610034bd9fa644bd47ed) | CHANGELOG.md | @@ -5,6 +5,9 @@
- [#16877](https://github.com/emberjs/ember.js/pull/16877) [CLEANUP] Allow routes to be named "array" and "object"
- [#16907](https://github.com/emberjs/ember.js/pull/16907) Upgrade to TypeScript 3.0
+### v3.4.1 (September 10, 2018)
+- [#16933](https://github.com/emberjs/ember.js/pull/16933) [BUGFIX... | false |
Other | emberjs | ember.js | 6d2e29bbe7dd760235ae8f95e790d2de3cd99654.json | fix: forbid throwing of literals | .eslintrc.js | @@ -15,6 +15,7 @@ module.exports = {
rules: {
'semi': 'error',
'no-unused-vars': 'error',
+ 'no-throw-literal': 'error',
'no-useless-escape': 'off', // TODO: bring this back
'prettier/prettier': 'error',
},
@@ -79,6 +80,7 @@ module.exports = {
'semi': 'error',
'no-unused... | true |
Other | emberjs | ember.js | 6d2e29bbe7dd760235ae8f95e790d2de3cd99654.json | fix: forbid throwing of literals | blueprints/component-test/index.js | @@ -39,14 +39,14 @@ module.exports = useTestFrameworkDetector({
},
__testType__(options) {
if (options.locals.testType === 'unit') {
- throw "The --unit flag isn't supported within a module unification app";
+ throw new Error("The --unit flag isn't supported within a m... | true |
Other | emberjs | ember.js | 6d2e29bbe7dd760235ae8f95e790d2de3cd99654.json | fix: forbid throwing of literals | blueprints/controller-test/index.js | @@ -28,7 +28,7 @@ module.exports = useTestFrameworkDetector({
},
__root__(options) {
if (options.pod) {
- throw "Pods aren't supported within a module unification app";
+ throw new Error("Pods aren't supported within a module unification app");
}
... | true |
Other | emberjs | ember.js | 6d2e29bbe7dd760235ae8f95e790d2de3cd99654.json | fix: forbid throwing of literals | blueprints/controller/index.js | @@ -10,7 +10,7 @@ module.exports = {
return {
__root__(options) {
if (options.pod) {
- throw "Pods aren't supported within a module unification app";
+ throw new Error("Pods aren't supported within a module unification app");
}
if (options.inDummy) ... | true |
Other | emberjs | ember.js | 6d2e29bbe7dd760235ae8f95e790d2de3cd99654.json | fix: forbid throwing of literals | blueprints/initializer-test/index.js | @@ -15,7 +15,7 @@ module.exports = useTestFrameworkDetector({
return {
__root__(options) {
if (options.pod) {
- throw 'Pods arenʼt supported within a module unification app';
+ throw new Error('Pods arenʼt supported within a module unification app');
} else if... | true |
Other | emberjs | ember.js | 6d2e29bbe7dd760235ae8f95e790d2de3cd99654.json | fix: forbid throwing of literals | blueprints/initializer/index.js | @@ -11,7 +11,7 @@ module.exports = {
return {
__root__(options) {
if (options.pod) {
- throw 'Pods arenʼt supported within a module unification app';
+ throw new Error('Pods arenʼt supported within a module unification app');
} else if (options.inDummy) {
... | true |
Other | emberjs | ember.js | 6d2e29bbe7dd760235ae8f95e790d2de3cd99654.json | fix: forbid throwing of literals | blueprints/mixin-test/index.js | @@ -13,7 +13,7 @@ module.exports = useTestFrameworkDetector({
return {
__root__(options) {
if (options.pod) {
- throw "Pods aren't supported within a module unification app";
+ throw new Error("Pods aren't supported within a module unification app");
}
... | true |
Other | emberjs | ember.js | 6d2e29bbe7dd760235ae8f95e790d2de3cd99654.json | fix: forbid throwing of literals | blueprints/mixin/index.js | @@ -10,7 +10,7 @@ module.exports = {
return {
__root__(options) {
if (options.pod) {
- throw "Pods aren't supported within a module unification app";
+ throw new Error("Pods aren't supported within a module unification app");
}
return 'src'; | true |
Other | emberjs | ember.js | 6d2e29bbe7dd760235ae8f95e790d2de3cd99654.json | fix: forbid throwing of literals | blueprints/route/index.js | @@ -32,7 +32,7 @@ module.exports = {
return {
__root__(options) {
if (options.pod) {
- throw "Pods aren't supported within a module unification app";
+ throw new Error("Pods aren't supported within a module unification app");
}
if (options.inDummy) ... | true |
Other | emberjs | ember.js | 6d2e29bbe7dd760235ae8f95e790d2de3cd99654.json | fix: forbid throwing of literals | blueprints/service-test/index.js | @@ -11,7 +11,7 @@ module.exports = useTestFrameworkDetector({
return {
__root__(options) {
if (options.pod) {
- throw "Pods aren't supported within a module unification app";
+ throw new Error("Pods aren't supported within a module unification app");
}
... | true |
Other | emberjs | ember.js | 6d2e29bbe7dd760235ae8f95e790d2de3cd99654.json | fix: forbid throwing of literals | blueprints/service/index.js | @@ -10,7 +10,7 @@ module.exports = {
return {
__root__(options) {
if (options.pod) {
- throw "Pods aren't supported within a module unification app";
+ throw new Error("Pods aren't supported within a module unification app");
}
return 'src'; | true |
Other | emberjs | ember.js | 6d2e29bbe7dd760235ae8f95e790d2de3cd99654.json | fix: forbid throwing of literals | blueprints/template/index.js | @@ -10,7 +10,7 @@ module.exports = {
return {
__root__(options) {
if (options.pod) {
- throw "Pods aren't supported within a module unification app";
+ throw new Error("Pods aren't supported within a module unification app");
} else if (options.inDummy) {
... | true |
Other | emberjs | ember.js | 6d2e29bbe7dd760235ae8f95e790d2de3cd99654.json | fix: forbid throwing of literals | blueprints/util-test/index.js | @@ -14,7 +14,7 @@ module.exports = useTestFrameworkDetector({
return {
__root__(options) {
if (options.pod) {
- throw "Pods aren't supported within a module unification app";
+ throw new Error("Pods aren't supported within a module unification app");
}
... | true |
Other | emberjs | ember.js | 6d2e29bbe7dd760235ae8f95e790d2de3cd99654.json | fix: forbid throwing of literals | blueprints/util/index.js | @@ -10,7 +10,7 @@ module.exports = {
return {
__root__(options) {
if (options.pod) {
- throw "Pods aren't supported within a module unification app";
+ throw new Error("Pods aren't supported within a module unification app");
}
return 'src'; | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.