language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | a4e4033d7ec4db777bac463efa9b7e3e6e7da53e.json | Change default template context to controller | packages/ember-handlebars/tests/handlebars_test.js | @@ -1954,6 +1954,7 @@ test("bindings should respect keywords", function() {
museumOpen: true,
controller: {
+ museumOpen: true,
museumDetails: Ember.Object.create({
name: "SFMoMA",
price: 20
@@ -1964,7 +1965,7 @@ test("bindings should respect keywords", function() {
temp... | true |
Other | emberjs | ember.js | a4e4033d7ec4db777bac463efa9b7e3e6e7da53e.json | Change default template context to controller | packages/ember-views/lib/views/view.js | @@ -557,13 +557,17 @@ Ember.View = Ember.Object.extend(Ember.Evented,
to be re-rendered.
*/
_templateContext: Ember.computed(function(key, value) {
- var parentView;
+ var parentView, controller;
if (arguments.length === 2) {
return value;
}
if (VIEW_PRESERVES_CONTEXT) {
+ ... | true |
Other | emberjs | ember.js | a4e4033d7ec4db777bac463efa9b7e3e6e7da53e.json | Change default template context to controller | packages/ember-views/tests/views/view/template_test.js | @@ -25,7 +25,7 @@ test("should call the function of the associated template", function() {
Ember.run(function(){
view.createElement();
});
-
+
ok(view.$('#twas-called').length, "the named template was called");
});
@@ -48,7 +48,7 @@ test("should call the function of the associated template with itsel... | true |
Other | emberjs | ember.js | d86253456eedebe238a07da1914b9e11b867e835.json | Remove unused variable | packages/ember-views/lib/views/view.js | @@ -1768,7 +1768,7 @@ Ember.View = Ember.Object.extend(Ember.Evented,
@test in createChildViews
*/
createChildView: function(view, attrs) {
- var coreAttrs, templateData;
+ var coreAttrs;
if (Ember.View.detect(view)) {
coreAttrs = { _parentView: this, templateData: get(this, 'templateData... | false |
Other | emberjs | ember.js | 87245ceb5b9871c6d93a9461bbcc28e43e5ac7c4.json | QUnit test runner: Run all packages by default
The test `if (!packages.length)` didn't actually do anything before,
because split always returns at least ['']. But it's more convenient
anyway to just run everything by default, rather than displaying an
error message. This way people can open the test runner without
pa... | tests/index.html | @@ -153,64 +153,59 @@ <h2 id="qunit-userAgent"></h2>
// Load Tests and Depenencies
- var packages = (QUnit.urlParams.package || "").split(","),
+ var packages = (QUnit.urlParams.package || "all").split(","),
packageName, el, idx, len, re, match, moduleName;
- if (!packages.length) {
- ... | false |
Other | emberjs | ember.js | bbe1038a37ddf505d0f15d792a026fdeb66c39ae.json | Use @type instead of @property to make JsDoc happy | packages/ember-metal/lib/run_loop.js | @@ -272,7 +272,7 @@ Ember.run.end = function() {
simply adding the queue name to this array. Normally you should not need
to inspect or modify this property.
- @property {String}
+ @type Array
@default ['sync', 'actions', 'destroy', 'timers']
*/
Ember.run.queues = ['sync', 'actions', 'destroy', 'timers'... | true |
Other | emberjs | ember.js | bbe1038a37ddf505d0f15d792a026fdeb66c39ae.json | Use @type instead of @property to make JsDoc happy | packages/ember-metal/lib/utils.js | @@ -138,7 +138,7 @@ var META_KEY = Ember.GUID_KEY+'_meta';
The key used to store meta information on object for property observing.
@static
- @property
+ @type String
*/
Ember.META_KEY = META_KEY;
| true |
Other | emberjs | ember.js | bbe1038a37ddf505d0f15d792a026fdeb66c39ae.json | Use @type instead of @property to make JsDoc happy | packages/ember-runtime/lib/mixins/array.js | @@ -284,7 +284,7 @@ Ember.Array = Ember.Mixin.create(Ember.Enumerable, /** @scope Ember.Array.protot
Becomes true whenever the array currently has observers watching changes
on the array.
- @property {Boolean}
+ @type Boolean
*/
hasArrayObservers: Ember.computed(function() {
return Ember.ha... | true |
Other | emberjs | ember.js | bbe1038a37ddf505d0f15d792a026fdeb66c39ae.json | Use @type instead of @property to make JsDoc happy | packages/ember-runtime/lib/mixins/enumerable.js | @@ -621,7 +621,7 @@ Ember.Enumerable = Ember.Mixin.create( /** @lends Ember.Enumerable */ {
For plain enumerables, this property is read only. Ember.Array overrides
this method.
- @property {Ember.Array}
+ @type Ember.Array
*/
'[]': Ember.computed(function(key, value) {
return this;
@@ -66... | true |
Other | emberjs | ember.js | bbe1038a37ddf505d0f15d792a026fdeb66c39ae.json | Use @type instead of @property to make JsDoc happy | packages/ember-runtime/lib/mixins/freezable.js | @@ -74,7 +74,7 @@ Ember.Freezable = Ember.Mixin.create(
Set to true when the object is frozen. Use this property to detect whether
your object is frozen or not.
- @property {Boolean}
+ @type Boolean
*/
isFrozen: false,
| true |
Other | emberjs | ember.js | bbe1038a37ddf505d0f15d792a026fdeb66c39ae.json | Use @type instead of @property to make JsDoc happy | packages/ember-runtime/lib/system/array_proxy.js | @@ -52,7 +52,7 @@ Ember.ArrayProxy = Ember.Object.extend(Ember.MutableArray,
The content array. Must be an object that implements Ember.Array and/or
Ember.MutableArray.
- @property {Ember.Array}
+ @type Ember.Array
*/
content: null,
| true |
Other | emberjs | ember.js | bbe1038a37ddf505d0f15d792a026fdeb66c39ae.json | Use @type instead of @property to make JsDoc happy | packages/ember-runtime/lib/system/set.js | @@ -119,7 +119,7 @@ Ember.Set = Ember.CoreObject.extend(Ember.MutableEnumerable, Ember.Copyable, Emb
/**
This property will change as the number of objects in the set changes.
- @property Number
+ @type number
@default 0
*/
length: 0, | true |
Other | emberjs | ember.js | bbe1038a37ddf505d0f15d792a026fdeb66c39ae.json | Use @type instead of @property to make JsDoc happy | packages/ember-runtime/lib/system/string.js | @@ -17,7 +17,7 @@ var STRING_UNDERSCORE_REGEXP_2 = (/\-|\s+/g);
the `Ember.String.loc()` helper. To localize, add string values to this
hash.
- @property {String}
+ @type Hash
*/
Ember.STRINGS = {};
| true |
Other | emberjs | ember.js | bbe1038a37ddf505d0f15d792a026fdeb66c39ae.json | Use @type instead of @property to make JsDoc happy | packages/ember-runtime/tests/suites/copyable.js | @@ -35,7 +35,7 @@ Ember.CopyableTests = Ember.Suite.extend({
you say you can't test freezable it will verify that your objects really
aren't freezable.)
- @property {Boolean}
+ @type Boolean
*/
shouldBeFreezable: false
| true |
Other | emberjs | ember.js | bbe1038a37ddf505d0f15d792a026fdeb66c39ae.json | Use @type instead of @property to make JsDoc happy | packages/ember-runtime/tests/suites/enumerable.js | @@ -129,7 +129,7 @@ var EnumerableTests = Ember.Object.extend({
/**
Define a name for these tests - all modules are prefixed w/ it.
- @property {String}
+ @type String
*/
name: Ember.required(String),
@@ -193,7 +193,7 @@ var EnumerableTests = Ember.Object.extend({
Becomes true when you defi... | true |
Other | emberjs | ember.js | bbe1038a37ddf505d0f15d792a026fdeb66c39ae.json | Use @type instead of @property to make JsDoc happy | packages/ember-runtime/tests/suites/suite.js | @@ -42,7 +42,7 @@ Ember.Suite = Ember.Object.extend(
/**
Define a name for these tests - all modules are prefixed w/ it.
- @property {String}
+ @type String
*/
name: Ember.required(String),
| true |
Other | emberjs | ember.js | bbe1038a37ddf505d0f15d792a026fdeb66c39ae.json | Use @type instead of @property to make JsDoc happy | packages/ember-states/lib/state.js | @@ -82,7 +82,7 @@ Ember.State = Ember.Object.extend(Ember.Evented, {
in the state hierarchy. This is false if the state has child
states; otherwise it is true.
- @property {Boolean}
+ @type Boolean
*/
isLeaf: Ember.computed(function() {
return !get(this, 'childStates').length; | true |
Other | emberjs | ember.js | bbe1038a37ddf505d0f15d792a026fdeb66c39ae.json | Use @type instead of @property to make JsDoc happy | packages/ember-states/lib/state_manager.js | @@ -389,7 +389,8 @@ Ember.StateManager = Ember.State.extend(
raised if you attempt to send an event to a state manager that is not
handled by the current state or any of its parent states.
- @property {Boolean}
+ @type Boolean
+ @default true
*/
errorOnUnhandledEvent: true,
| true |
Other | emberjs | ember.js | bbe1038a37ddf505d0f15d792a026fdeb66c39ae.json | Use @type instead of @property to make JsDoc happy | packages/ember-viewstates/lib/state_manager.js | @@ -8,7 +8,7 @@ Ember.StateManager.reopen(
this property will be the view associated with it. If there is no
view state active in this state manager, this value will be null.
- @property
+ @type Ember.View
*/
currentView: Ember.computed(function() {
var currentState = get(this, 'currentStat... | true |
Other | emberjs | ember.js | eaaa0927943dc2ecca30ae5415ab8b6ba653ad88.json | update String#objectAt documentation | packages/ember-runtime/lib/mixins/array.js | @@ -4,11 +4,8 @@
// License: Licensed under MIT license (see license.js)
// ==========================================================================
-
require('ember-runtime/mixins/enumerable');
-
-
// ..........................................................
// HELPERS
//
@@ -66,20 +63,29 @@ Ember.Array... | false |
Other | emberjs | ember.js | df91fd23b505b2eda250e0d91697aef31c8faaa4.json | Add triageMustache as a known helper | packages/ember-handlebars/lib/ext.js | @@ -106,7 +106,8 @@ Ember.Handlebars.precompile = function(string) {
unbound: true,
bindAttr: true,
template: true,
- view: true
+ view: true,
+ _triageMustache: true
},
data: true,
stringParams: true | false |
Other | emberjs | ember.js | e880673950810a06c25b3cb9d763cc7513927285.json | Improve output for more common case
Since escaped is more common, don't generate
extra code for that case. | packages/ember-handlebars/lib/ext.js | @@ -82,9 +82,9 @@ Ember.Handlebars.Compiler.prototype.mustache = function(mustache) {
// Update the mustache node to include a hash value indicating whether the original node
// was escaped. This will allow us to properly escape values when the underlying value
// changes and we need to re-render the val... | true |
Other | emberjs | ember.js | e880673950810a06c25b3cb9d763cc7513927285.json | Improve output for more common case
Since escaped is more common, don't generate
extra code for that case. | packages/ember-handlebars/lib/helpers/binding.js | @@ -44,7 +44,7 @@ var bind = function(property, options, preserveContext, shouldDisplay, valueNorm
path: path,
pathRoot: pathRoot,
previousContext: currentContext,
- isEscaped: options.hash.escaped,
+ isEscaped: !options.hash.unescaped,
templateData: options.data
});
| true |
Other | emberjs | ember.js | 9fce04129121884c522a887dc57fe0c6d5bbb2c2.json | Reduce need for runtime template compilation | packages/ember-handlebars/lib/controls/checkbox.js | @@ -81,16 +81,5 @@ Ember.Checkbox = Ember.View.extend({
_updateElementValue: function() {
var input = get(this, 'title') ? this.$('input:checkbox') : this.$();
set(this, 'checked', input.prop('checked'));
- },
-
- init: function() {
- if (get(this, 'title') || get(this, 'titleBinding')) {
- Ember... | true |
Other | emberjs | ember.js | 9fce04129121884c522a887dc57fe0c6d5bbb2c2.json | Reduce need for runtime template compilation | packages/ember-handlebars/lib/controls/select.js | @@ -179,9 +179,13 @@ Ember.Select = Ember.View.extend(
Ember.SelectOption = Ember.View.extend({
tagName: 'option',
- defaultTemplate: Ember.Handlebars.compile("{{view.label}}"),
attributeBindings: ['value', 'selected'],
+ defaultTemplate: function(context, options) {
+ options = { data: options.data, ha... | true |
Other | emberjs | ember.js | 9fce04129121884c522a887dc57fe0c6d5bbb2c2.json | Reduce need for runtime template compilation | packages/ember-handlebars/tests/controls/checkbox_test.js | @@ -96,19 +96,6 @@ test("checking the checkbox updates the value", function() {
equal(get(checkboxView, 'checked'), false, "changing the checkbox causes the view's value to get updated");
});
-// deprecated behaviors
-test("wraps the checkbox in a label if a title attribute is provided", function(){
- Ember.TEST... | true |
Other | emberjs | ember.js | 7f1e74b95820d5698a1e9564e40bdbc394f89aca.json | Add known helpers to precompilation | packages/ember-handlebars/lib/ext.js | @@ -99,7 +99,19 @@ Ember.Handlebars.Compiler.prototype.mustache = function(mustache) {
*/
Ember.Handlebars.precompile = function(string) {
var ast = Handlebars.parse(string);
- var options = { data: true, stringParams: true };
+
+ var options = {
+ knownHelpers: {
+ action: true,
+ unbound: true,
+ ... | false |
Other | emberjs | ember.js | 7349345dee477bba864854454c948b0ff6dccc30.json | Use Ember.Logger instead of console.log | packages/ember-views/lib/views/states.js | @@ -40,7 +40,7 @@ Ember.View.RenderStateManager = Ember.StateManager.extend({
// and we should still raise an exception in that
// case.
if (typeof action === 'function') {
- if (log) { console.log(fmt("STATEMANAGER: Sending event '%@' to state %@.", [event, get(currentState, 'path')])); }
+ if... | false |
Other | emberjs | ember.js | 2ec0dfa472b854932061b65ca347cc636a144ba7.json | Fix application tests | packages/ember-application/tests/system/application_test.js | @@ -131,15 +131,15 @@ test('initialized application go to initial route', function() {
onUpdateURL: function() {}
},
- start: Ember.State.extend({
+ root: Ember.State.extend({
index: Ember.State.extend({
route: '/'
})
})
});
});
- equal(app.getP... | true |
Other | emberjs | ember.js | 2ec0dfa472b854932061b65ca347cc636a144ba7.json | Fix application tests | packages/ember-states/lib/routable.js | @@ -176,7 +176,9 @@ Ember.Routable = Ember.Mixin.create({
var object = state.deserialize(manager, match.hash) || {};
manager.transitionTo(get(state, 'path'), object);
manager.send('routePath', match.remaining);
- }
+ },
+
+ connectOutlets: Ember.K
});
Ember.State.reopen(Ember.Routable); | true |
Other | emberjs | ember.js | c01c19f023efa4279a4d9465c8aaa951e05a847b.json | Add urlFor to Router
Note: In general, you will not want to use
urlFor outside of the Router. Instead you will
either set the appropriate URL on a controller to
be used in a view, or use a feature we will write
next to allow a URL to be extracted from an event
that triggers a transition. | packages/ember-states/lib/routable.js | @@ -17,6 +17,13 @@ var paramForClass = function(classObject) {
return Ember.String.underscore(last) + "_id";
};
+var merge = function(original, hash) {
+ for (var prop in hash) {
+ if (!hash.hasOwnProperty(prop)) { continue; }
+ original[prop] = hash[prop];
+ }
+};
+
Ember.Routable = Ember.Mixin.create({... | true |
Other | emberjs | ember.js | c01c19f023efa4279a4d9465c8aaa951e05a847b.json | Add urlFor to Router
Note: In general, you will not want to use
urlFor outside of the Router. Instead you will
either set the appropriate URL on a controller to
be used in a view, or use a feature we will write
next to allow a URL to be extracted from an event
that triggers a transition. | packages/ember-states/lib/state_manager.js | @@ -421,6 +421,35 @@ Ember.StateManager = Ember.State.extend(
}
},
+ /**
+ Finds a state by its state path.
+
+ Example:
+
+ manager = Ember.StateManager.create({
+ root: Ember.State.create({
+ dashboard: Ember.State.create()
+ })
+ });
+
+ manager.find... | true |
Other | emberjs | ember.js | c01c19f023efa4279a4d9465c8aaa951e05a847b.json | Add urlFor to Router
Note: In general, you will not want to use
urlFor outside of the Router. Instead you will
either set the appropriate URL on a controller to
be used in a view, or use a feature we will write
next to allow a URL to be extracted from an event
that triggers a transition. | packages/ember-states/tests/routable_test.js | @@ -453,3 +453,115 @@ test("you cannot have a redirectsTo in a non-leaf state", function () {
});
});
});
+
+module("urlFor", {
+
+});
+
+test("urlFor returns an absolute route", function() {
+ var router = Ember.Router.create({
+ root: Ember.State.create({
+ dashboard: Ember.State.create({
+ r... | true |
Other | emberjs | ember.js | ee1d2d55bb66cc8bb82c8ca1e535995c37221a53.json | make transitionEvent on state manager configurable | packages/ember-states/lib/router.js | @@ -21,8 +21,16 @@ require('ember-states/routable');
*/
Ember.Router = Ember.StateManager.extend(
/** @scope Ember.Router.prototype */ {
+
initialState: 'root',
+ /**
+ On router, transitionEvent should be called connectOutlets
+
+ @property {String}
+ */
+ transitionEvent: 'connectOutlets',
+
route... | true |
Other | emberjs | ember.js | ee1d2d55bb66cc8bb82c8ca1e535995c37221a53.json | make transitionEvent on state manager configurable | packages/ember-states/lib/state.js | @@ -88,7 +88,7 @@ Ember.State = Ember.Object.extend(Ember.Evented, {
return !get(this, 'childStates').length;
}).cacheable(),
- connectOutlets: Ember.K,
+ setup: Ember.K,
enter: Ember.K,
exit: Ember.K
}); | true |
Other | emberjs | ember.js | ee1d2d55bb66cc8bb82c8ca1e535995c37221a53.json | make transitionEvent on state manager configurable | packages/ember-states/lib/state_manager.js | @@ -377,6 +377,13 @@ Ember.StateManager = Ember.State.extend(
currentState: null,
+ /**
+ The name of transitionEvent that this stateManager will dispatch
+
+ @property {String}
+ */
+ transitionEvent: 'setup',
+
/**
If set to true, `errorOnUnhandledEvents` will cause an exception to be
rai... | true |
Other | emberjs | ember.js | ee1d2d55bb66cc8bb82c8ca1e535995c37221a53.json | make transitionEvent on state manager configurable | packages/ember-states/tests/state_manager_test.js | @@ -456,7 +456,7 @@ test("goToState with current state does not trigger enter or exit", function() {
module("Transition contexts");
-test("if a context is passed to a transition, the state's connectOutlets event is triggered after the transition has completed", function() {
+test("if a context is passed to a trans... | true |
Other | emberjs | ember.js | 91a8975b8d3a0b873b421f1dbc4ea41f92c92bc2.json | Add redirectsTo in routes | packages/ember-states/lib/routable.js | @@ -19,9 +19,20 @@ var paramForClass = function(classObject) {
Ember.Routable = Ember.Mixin.create({
init: function() {
+ var redirection;
this.on('connectOutlets', this, this.stashContext);
+ if (redirection = get(this, 'redirectsTo')) {
+ Ember.assert("You cannot use `redirectsTo` if you alrea... | true |
Other | emberjs | ember.js | 91a8975b8d3a0b873b421f1dbc4ea41f92c92bc2.json | Add redirectsTo in routes | packages/ember-states/tests/routable_test.js | @@ -405,3 +405,56 @@ test("should use a specified String `modelType` in the default `deserialize`", f
router.route("/posts/1");
});
+
+module("redirectsTo");
+
+test("if a leaf state has a redirectsTo, it automatically transitions into that state", function() {
+ var router = Ember.Router.create({
+ initial... | true |
Other | emberjs | ember.js | 3fa1ed671ceb774a956fc1bd9ba2a8c5611c073a.json | Add documentation stub for Ember.Router | packages/ember-states/lib/router.js | @@ -2,7 +2,25 @@ require('ember-states/state');
require('ember-states/route_matcher');
require('ember-states/routable');
-Ember.Router = Ember.StateManager.extend({
+/**
+ @class
+
+ `Ember.Router` is a state manager used for routing.
+
+ A special `Router` property name is recognized on applications:
+
+ v... | false |
Other | emberjs | ember.js | 1bff946579a832526349ac3f70ce032c6eb95d2c.json | Add TODO note about Ember.Location documentation | packages/ember-application/lib/system/location.js | @@ -10,6 +10,9 @@ var get = Ember.get, set = Ember.set;
onUpdateURL(callback): triggers the callback when the URL changes
Calling setURL will not trigger onUpdateURL callbacks.
+
+ TODO: This, as well as the Ember.Location documentation below, should
+ perhaps be moved so that it's visible in the JsDoc output... | false |
Other | emberjs | ember.js | bc75b1ac96b5c675aa27397250c5c02b1e0e46a7.json | Add @scope so properties are picked up by JsDoc | packages/ember-viewstates/lib/view_state.js | @@ -243,7 +243,8 @@ var get = Ember.get, set = Ember.set;
`view` that references the `Ember.View` object that was interacted with.
**/
-Ember.ViewState = Ember.State.extend({
+Ember.ViewState = Ember.State.extend(
+/** @scope Ember.ViewState.prototype */ {
isViewState: true,
enter: function(stateManager... | false |
Other | emberjs | ember.js | 483c4555bf41042cfd3e1ab513823d80788f5a47.json | add missing require | packages/ember-runtime/lib/controllers.js | @@ -1 +1,2 @@
require('ember-runtime/controllers/array_controller');
+require('ember-runtime/controllers/object_controller'); | false |
Other | emberjs | ember.js | 7830f434af827923e1c3cdeee4103f5535047183.json | Fix doc api | packages/ember-runtime/lib/system/array_proxy.js | @@ -22,7 +22,7 @@ var get = Ember.get, set = Ember.set;
A simple example of usage:
var pets = ['dog', 'cat', 'fish'];
- var arrayProxy = Ember.ArrayProxy.create({ content: Ember.A(pets) });
+ var ap = Ember.ArrayProxy.create({ content: Ember.A(pets) });
ap.get('firstObject'); // => 'dog'
... | false |
Other | emberjs | ember.js | 4fba5a1e6c8016c74649224280318d43074d8983.json | Fix parentView and nearestChildOf documentation
If the parentView documentation comes before _parentView, it won't show
up in JsDoc. | packages/ember-views/lib/views/view.js | @@ -590,8 +590,6 @@ Ember.View = Ember.Object.extend(Ember.Evented,
@type Ember.View
@default null
*/
- _parentView: null,
-
parentView: Ember.computed(function() {
var parent = get(this, '_parentView');
@@ -602,6 +600,8 @@ Ember.View = Ember.Object.extend(Ember.Evented,
}
}).property('_... | false |
Other | emberjs | ember.js | d1848b4f26766701693fcfd1a1e1e85341d53e97.json | Fix doc api | packages/ember-runtime/lib/system/array_proxy.js | @@ -22,7 +22,7 @@ var get = Ember.get, set = Ember.set;
A simple example of usage:
var pets = ['dog', 'cat', 'fish'];
- var arrayProxy = Ember.ArrayProxy.create({ content: Ember.A(pets) });
+ var ap = Ember.ArrayProxy.create({ content: Ember.A(pets) });
ap.get('firstObject'); // => 'dog'
... | false |
Other | emberjs | ember.js | 1a60eccb6ca96f4503a48bb502bfa16af74d8205.json | Fix parentView and nearestChildOf documentation
If the parentView documentation comes before _parentView, it won't show
up in JsDoc. | packages/ember-views/lib/views/view.js | @@ -590,8 +590,6 @@ Ember.View = Ember.Object.extend(Ember.Evented,
@type Ember.View
@default null
*/
- _parentView: null,
-
parentView: Ember.computed(function() {
var parent = get(this, '_parentView');
@@ -602,6 +600,8 @@ Ember.View = Ember.Object.extend(Ember.Evented,
}
}).property('_... | false |
Other | emberjs | ember.js | 640f00cacabddcbc6881ed4770fa500534ecbf70.json | Fix initialization with non routable stateManager | packages/ember-application/lib/system/application.js | @@ -125,7 +125,7 @@ Ember.Application = Ember.Namespace.extend(
this.ready();
- if (stateManager) {
+ if (stateManager && stateManager instanceof Ember.Router) {
this.setupStateManager(stateManager);
}
}, | true |
Other | emberjs | ember.js | 640f00cacabddcbc6881ed4770fa500534ecbf70.json | Fix initialization with non routable stateManager | packages/ember-application/tests/system/application_test.js | @@ -116,17 +116,19 @@ test("initialize controllers into a state manager", function() {
equal(getPath(stateManager, 'barController.target'), stateManager, "the state manager is assigned");
});
-module("Ember.Application initial route", function() {
+test('initialized application go to initial route', function() {
... | true |
Other | emberjs | ember.js | 2d876a6d1b4309a004246d7ec616a5faf93cfb05.json | Fix initialization with non routable stateManager | packages/ember-application/lib/system/application.js | @@ -125,7 +125,7 @@ Ember.Application = Ember.Namespace.extend(
this.ready();
- if (stateManager) {
+ if (stateManager && stateManager instanceof Ember.Router) {
this.setupStateManager(stateManager);
}
}, | true |
Other | emberjs | ember.js | 2d876a6d1b4309a004246d7ec616a5faf93cfb05.json | Fix initialization with non routable stateManager | packages/ember-application/tests/system/application_test.js | @@ -116,17 +116,19 @@ test("initialize controllers into a state manager", function() {
equal(getPath(stateManager, 'barController.target'), stateManager, "the state manager is assigned");
});
-module("Ember.Application initial route", function() {
+test('initialized application go to initial route', function() {
... | true |
Other | emberjs | ember.js | 1f540aed8ef00684ea170d5f4576c014bfbd4ad5.json | Upload starter-kit to the correct location | Rakefile | @@ -10,19 +10,23 @@ def pipeline
Rake::Pipeline::Project.new("Assetfile")
end
-def setup_uploader
+def setup_uploader(root=Dir.pwd)
require './lib/github_uploader'
- # get the github user name
- login = `git config github.user`.chomp
+ login = origin = nil
- # get repo from git config's origin url
- o... | false |
Other | emberjs | ember.js | e432e7cf585a07166f7a8ff769a80194c72b801c.json | Run tests for when running all | tests/index.html | @@ -141,7 +141,8 @@ <h2 id="qunit-userAgent"></h2>
'ember-runtime',
'ember-states',
'ember-views',
- 'ember-viewstates'
+ 'ember-viewstates',
+ 'ember-application'
];
}
| false |
Other | emberjs | ember.js | 5a4917b9aaee4f53c8196f9b3349ff775774dae2.json | Add Ember.Controller and `connectOutlet`
The goal of `connectOutlet` is to make it easy to
fill in a Handlebars-specified outlet with a new
view.
It also connects the view's associated controller
to the view's `controller` property, if an
associated controller can be found using
conventional naming. | packages/ember-application/lib/system/application.js | @@ -179,12 +179,14 @@ Ember.Application.reopenClass({
}
});
-Ember.Application.registerInjection(function(app, stateManager, property) {
+Ember.Application.registerInjection(function(app, router, property) {
if (!/^[A-Z].*Controller$/.test(property)) { return; }
var name = property[0].toLowerCase() + prop... | true |
Other | emberjs | ember.js | 5a4917b9aaee4f53c8196f9b3349ff775774dae2.json | Add Ember.Controller and `connectOutlet`
The goal of `connectOutlet` is to make it easy to
fill in a Handlebars-specified outlet with a new
view.
It also connects the view's associated controller
to the view's `controller` property, if an
associated controller can be found using
conventional naming. | packages/ember-metal/lib/mixin.js | @@ -358,6 +358,8 @@ Mixin.prototype.reopen = function() {
mixin.properties = this.properties;
delete this.properties;
this.mixins = [mixin];
+ } else if (!this.mixins) {
+ this.mixins = [];
}
var len = arguments.length, mixins = this.mixins, idx; | true |
Other | emberjs | ember.js | 5a4917b9aaee4f53c8196f9b3349ff775774dae2.json | Add Ember.Controller and `connectOutlet`
The goal of `connectOutlet` is to make it easy to
fill in a Handlebars-specified outlet with a new
view.
It also connects the view's associated controller
to the view's `controller` property, if an
associated controller can be found using
conventional naming. | packages/ember-runtime/lib/controllers.js | @@ -1 +1,2 @@
require('ember-runtime/controllers/array_controller');
+require('ember-runtime/controllers/controller'); | true |
Other | emberjs | ember.js | 5a4917b9aaee4f53c8196f9b3349ff775774dae2.json | Add Ember.Controller and `connectOutlet`
The goal of `connectOutlet` is to make it easy to
fill in a Handlebars-specified outlet with a new
view.
It also connects the view's associated controller
to the view's `controller` property, if an
associated controller can be found using
conventional naming. | packages/ember-runtime/lib/controllers/array_controller.js | @@ -5,6 +5,7 @@
// ==========================================================================
require('ember-runtime/system/array_proxy');
+require('ember-runtime/controllers/controller');
/**
@class
@@ -45,4 +46,4 @@ require('ember-runtime/system/array_proxy');
@extends Ember.ArrayProxy
*/
-Ember.Array... | true |
Other | emberjs | ember.js | 5a4917b9aaee4f53c8196f9b3349ff775774dae2.json | Add Ember.Controller and `connectOutlet`
The goal of `connectOutlet` is to make it easy to
fill in a Handlebars-specified outlet with a new
view.
It also connects the view's associated controller
to the view's `controller` property, if an
associated controller can be found using
conventional naming. | packages/ember-runtime/lib/controllers/controller.js | @@ -0,0 +1,6 @@
+require('ember-runtime/system/object');
+require('ember-runtime/system/string');
+
+Ember.ControllerMixin = Ember.Mixin.create();
+
+Ember.Controller = Ember.Object.extend(Ember.ControllerMixin); | true |
Other | emberjs | ember.js | 5a4917b9aaee4f53c8196f9b3349ff775774dae2.json | Add Ember.Controller and `connectOutlet`
The goal of `connectOutlet` is to make it easy to
fill in a Handlebars-specified outlet with a new
view.
It also connects the view's associated controller
to the view's `controller` property, if an
associated controller can be found using
conventional naming. | packages/ember-views/lib/system.js | @@ -8,3 +8,4 @@
require("ember-views/system/render_buffer");
require("ember-views/system/event_dispatcher");
require("ember-views/system/ext");
+require("ember-views/system/controller"); | true |
Other | emberjs | ember.js | 5a4917b9aaee4f53c8196f9b3349ff775774dae2.json | Add Ember.Controller and `connectOutlet`
The goal of `connectOutlet` is to make it easy to
fill in a Handlebars-specified outlet with a new
view.
It also connects the view's associated controller
to the view's `controller` property, if an
associated controller can be found using
conventional naming. | packages/ember-views/lib/system/controller.js | @@ -0,0 +1,106 @@
+var get = Ember.get, set = Ember.set;
+
+Ember.ControllerMixin.reopen({
+ /**
+ `connectOutlet` creates a new instance of a provided view
+ class, wires it up to its associated controller, and
+ assigns the new view to a property on the current controller.
+
+ The purpose of this method ... | true |
Other | emberjs | ember.js | 5a4917b9aaee4f53c8196f9b3349ff775774dae2.json | Add Ember.Controller and `connectOutlet`
The goal of `connectOutlet` is to make it easy to
fill in a Handlebars-specified outlet with a new
view.
It also connects the view's associated controller
to the view's `controller` property, if an
associated controller can be found using
conventional naming. | packages/ember-views/tests/system/controller_test.js | @@ -0,0 +1,74 @@
+/*globals TestApp*/
+
+module("Ember.Controller#connectOutlet", {
+ setup: function() {
+ window.TestApp = Ember.Application.create();
+
+ TestApp.ApplicationController = Ember.Controller.extend();
+
+ TestApp.PostController = Ember.Controller.extend();
+ TestApp.PostView = Ember.Controll... | true |
Other | emberjs | ember.js | 7050fae731d96fddbe2ab3640e0786f4d8928bd4.json | Implement modelType guessing.
The way it works is:
if you have a single dynamic segment in your
state (e.g. your route is `/posts/:post_id`),
the router will remove the `_id` part off the
end and convert the remainder into class form.
in this case, that would be `Post`. It will then
look up the class on ... | packages/ember-application/lib/system/application.js | @@ -94,23 +94,31 @@ Ember.Application = Ember.Namespace.extend(
...
});
- App.initialize(stateManager);
+ App.initialize(router);
- stateManager.get('postsController') // <App.PostsController:ember1234>
- stateManager.get('commentsController') // <App.CommentsController:embe... | true |
Other | emberjs | ember.js | 7050fae731d96fddbe2ab3640e0786f4d8928bd4.json | Implement modelType guessing.
The way it works is:
if you have a single dynamic segment in your
state (e.g. your route is `/posts/:post_id`),
the router will remove the `_id` part off the
end and convert the remainder into class form.
in this case, that would be `Post`. It will then
look up the class on ... | packages/ember-runtime/lib/system/string.js | @@ -171,6 +171,19 @@ Ember.String = {
});
},
+ /**
+ Returns the UpperCamelCase form of a string.
+
+ 'innerHTML'.classify() => 'InnerHTML'
+ 'action_name'.classify() => 'ActionName'
+ 'css-class-name'.classify() => 'CssClassName'
+ 'my favorite items'.classift... | true |
Other | emberjs | ember.js | 7050fae731d96fddbe2ab3640e0786f4d8928bd4.json | Implement modelType guessing.
The way it works is:
if you have a single dynamic segment in your
state (e.g. your route is `/posts/:post_id`),
the router will remove the `_id` part off the
end and convert the remainder into class form.
in this case, that would be `Post`. It will then
look up the class on ... | packages/ember-states/lib/routable.js | @@ -19,7 +19,7 @@ var paramForClass = function(classObject) {
Ember.Routable = Ember.Mixin.create({
init: function() {
- this.on('setupControllers', this, this.stashContext);
+ this.on('connectOutlets', this, this.stashContext);
this._super();
},
@@ -67,7 +67,9 @@ Ember.Routable = Ember.Mixin.crea... | true |
Other | emberjs | ember.js | 7050fae731d96fddbe2ab3640e0786f4d8928bd4.json | Implement modelType guessing.
The way it works is:
if you have a single dynamic segment in your
state (e.g. your route is `/posts/:post_id`),
the router will remove the `_id` part off the
end and convert the remainder into class form.
in this case, that would be `Post`. It will then
look up the class on ... | packages/ember-states/lib/state.js | @@ -88,7 +88,7 @@ Ember.State = Ember.Object.extend(Ember.Evented, {
return !get(this, 'childStates').length;
}).cacheable(),
- setupControllers: Ember.K,
+ connectOutlets: Ember.K,
enter: Ember.K,
exit: Ember.K
}); | true |
Other | emberjs | ember.js | 7050fae731d96fddbe2ab3640e0786f4d8928bd4.json | Implement modelType guessing.
The way it works is:
if you have a single dynamic segment in your
state (e.g. your route is `/posts/:post_id`),
the router will remove the `_id` part off the
end and convert the remainder into class form.
in this case, that would be `Post`. It will then
look up the class on ... | packages/ember-states/lib/state_manager.js | @@ -449,7 +449,7 @@ Ember.StateManager = Ember.State.extend(
// 1. Normalize arguments
// 2. Ensure that we are in the correct state
// 3. Map provided path to context objects and send
- // appropriate setupControllers events
+ // appropriate connectOutlets events
if (Ember.empty(name)... | true |
Other | emberjs | ember.js | 7050fae731d96fddbe2ab3640e0786f4d8928bd4.json | Implement modelType guessing.
The way it works is:
if you have a single dynamic segment in your
state (e.g. your route is `/posts/:post_id`),
the router will remove the `_id` part off the
end and convert the remainder into class form.
in this case, that would be `Post`. It will then
look up the class on ... | packages/ember-states/tests/routable_test.js | @@ -229,7 +229,7 @@ module("Routing Serialization and Deserialization", {
show: Ember.State.create({
route: "/:post_id",
- setupControllers: function(manager, context) {
+ connectOutlets: function(manager, context) {
equal(context.post.id, 2, "should be the... | true |
Other | emberjs | ember.js | 7050fae731d96fddbe2ab3640e0786f4d8928bd4.json | Implement modelType guessing.
The way it works is:
if you have a single dynamic segment in your
state (e.g. your route is `/posts/:post_id`),
the router will remove the `_id` part off the
end and convert the remainder into class form.
in this case, that would be `Post`. It will then
look up the class on ... | packages/ember-states/tests/state_manager_test.js | @@ -456,7 +456,7 @@ test("goToState with current state does not trigger enter or exit", function() {
module("Transition contexts");
-test("if a context is passed to a transition, the state's setupControllers event is triggered after the transition has completed", function() {
+test("if a context is passed to a tra... | true |
Other | emberjs | ember.js | 0ecc1d799950eb29b6d672f3c1702bdd8f2e5e53.json | Add support for modelType in the router
If a `modelType` is specified in the router, the
router will automatically convert routes to
objects and vice versa.
For example, if the modelType is `App.Post` and
the state's route is `/posts/:post_id`:
* if the user navigates to `/posts/1`, the router
will automatically l... | packages/ember-states/lib/routable.js | @@ -9,6 +9,14 @@ var get = Ember.get, getPath = Ember.getPath;
// * .onURLChange(callback) - this happens when the user presses
// the back or forward button
+var paramForClass = function(classObject) {
+ var className = classObject.toString(),
+ parts = className.split("."),
+ last = parts[parts.lengt... | true |
Other | emberjs | ember.js | 0ecc1d799950eb29b6d672f3c1702bdd8f2e5e53.json | Add support for modelType in the router
If a `modelType` is specified in the router, the
router will automatically convert routes to
objects and vice versa.
For example, if the modelType is `App.Post` and
the state's route is `/posts/:post_id`:
* if the user navigates to `/posts/1`, the router
will automatically l... | packages/ember-states/tests/routable_test.js | @@ -277,3 +277,78 @@ test("should invoke the serialize method on a state when it is entered programma
equal(setURL, '/posts/2');
});
+var url, firstPost, firstUser;
+
+module("default serialize and deserialize", {
+ setup: function() {
+ window.TestApp = Ember.Namespace.create();
+ window.TestApp.Post = Em... | true |
Other | emberjs | ember.js | 0f649992a5fe915137ef4915aff30492649d995a.json | Change default test params | Rakefile | @@ -118,7 +118,7 @@ task :test, [:suite] => :dist do |t, args|
"package=all&extendprototypes=true&nojshint=true",
"package=all&extendprototypes=true&jquery=1.6.4&nojshint=true",
"package=all&extendprototypes=true&jquery=git&nojshint=true",
- "package=all&cpdefau... | true |
Other | emberjs | ember.js | 0f649992a5fe915137ef4915aff30492649d995a.json | Change default test params | tests/index.html | @@ -41,10 +41,10 @@
ENV['EXTEND_PROTOTYPES'] = !!extendPrototypes;
// Handle CP cacheable by default
- QUnit.config.urlConfig.push('cpdefaultcacheable');
+ QUnit.config.urlConfig.push('nocpdefaultcacheable');
- var cpDefaultCacheable = QUnit.urlParams.cpdefaultcacheable;
- ENV['CP_DEFAULT_CACH... | true |
Other | emberjs | ember.js | 3631ff0f1ba73a193da653935ca27bdff1552929.json | remove reschedule fixes #742 | packages/ember-metal/lib/watching.js | @@ -120,16 +120,15 @@ var pendingQueue = [];
// back in the queue and reschedule is true, schedules a timeout to try
// again.
/** @private */
-function flushPendingChains(reschedule) {
+function flushPendingChains() {
if (pendingQueue.length===0) return ; // nothing to do
var queue = pendingQueue;
pendin... | false |
Other | emberjs | ember.js | 8118866ef1c6838a5c08ac3b1a9d092fd023f835.json | Fix failing unit tests due to deferred teardown
Object destruction is deferred until the end of
the run loop. This was causing failing unit
tests in some cases where the old event dispatcher
was not being torn down before a new test started.
This ensures that application creation and
teardown happen inside run loops.... | packages/ember-application/tests/system/application_test.js | @@ -80,7 +80,9 @@ test("acts like a namespace", function() {
});
app.Foo = Ember.Object.extend();
equal(app.Foo.toString(), "TestApp.Foo", "Classes pick up their parent namespace");
- app.destroy();
+ Ember.run(function() {
+ app.destroy();
+ });
window.TestApp = undefined;
});
@@ -93,7 +95,9 @@ mo... | true |
Other | emberjs | ember.js | 8118866ef1c6838a5c08ac3b1a9d092fd023f835.json | Fix failing unit tests due to deferred teardown
Object destruction is deferred until the end of
the run loop. This was causing failing unit
tests in some cases where the old event dispatcher
was not being torn down before a new test started.
This ensures that application creation and
teardown happen inside run loops.... | packages/ember-handlebars/tests/controls/select_test.js | @@ -10,8 +10,10 @@ module("Ember.Select", {
},
teardown: function() {
- dispatcher.destroy();
- select.destroy();
+ Ember.run(function() {
+ dispatcher.destroy();
+ select.destroy();
+ });
}
});
@@ -228,7 +230,9 @@ module("Ember.Select - usage inside templates", {
},
teardown... | true |
Other | emberjs | ember.js | 8118866ef1c6838a5c08ac3b1a9d092fd023f835.json | Fix failing unit tests due to deferred teardown
Object destruction is deferred until the end of
the run loop. This was causing failing unit
tests in some cases where the old event dispatcher
was not being torn down before a new test started.
This ensures that application creation and
teardown happen inside run loops.... | packages/ember-handlebars/tests/controls/text_area_test.js | @@ -18,7 +18,9 @@ module("Ember.TextArea", {
},
teardown: function() {
- textArea.destroy();
+ Ember.run(function() {
+ textArea.destroy();
+ });
TestObject = textArea = null;
}
}); | true |
Other | emberjs | ember.js | 8118866ef1c6838a5c08ac3b1a9d092fd023f835.json | Fix failing unit tests due to deferred teardown
Object destruction is deferred until the end of
the run loop. This was causing failing unit
tests in some cases where the old event dispatcher
was not being torn down before a new test started.
This ensures that application creation and
teardown happen inside run loops.... | packages/ember-handlebars/tests/controls/text_field_test.js | @@ -18,7 +18,9 @@ module("Ember.TextField", {
},
teardown: function() {
- textField.destroy();
+ Ember.run(function() {
+ textField.destroy();
+ });
TestObject = textField = null;
}
}); | true |
Other | emberjs | ember.js | 8118866ef1c6838a5c08ac3b1a9d092fd023f835.json | Fix failing unit tests due to deferred teardown
Object destruction is deferred until the end of
the run loop. This was causing failing unit
tests in some cases where the old event dispatcher
was not being torn down before a new test started.
This ensures that application creation and
teardown happen inside run loops.... | packages/ember-handlebars/tests/handlebars_test.js | @@ -80,7 +80,9 @@ module("Ember.View - handlebars integration", {
teardown: function() {
if (view) {
- view.destroy();
+ Ember.run(function() {
+ view.destroy();
+ });
view = null;
}
window.TemplateTests = undefined;
@@ -515,7 +517,9 @@ test("Handlebars templates update ... | true |
Other | emberjs | ember.js | 8118866ef1c6838a5c08ac3b1a9d092fd023f835.json | Fix failing unit tests due to deferred teardown
Object destruction is deferred until the end of
the run loop. This was causing failing unit
tests in some cases where the old event dispatcher
was not being torn down before a new test started.
This ensures that application creation and
teardown happen inside run loops.... | packages/ember-handlebars/tests/views/collection_view_test.js | @@ -65,7 +65,9 @@ test("collection helper should accept relative paths", function() {
});
test("empty views should be removed when content is added to the collection (regression, ht: msofaer)", function() {
- window.App = Ember.Application.create();
+ Ember.run(function() {
+ window.App = Ember.Application.cre... | true |
Other | emberjs | ember.js | 8118866ef1c6838a5c08ac3b1a9d092fd023f835.json | Fix failing unit tests due to deferred teardown
Object destruction is deferred until the end of
the run loop. This was causing failing unit
tests in some cases where the old event dispatcher
was not being torn down before a new test started.
This ensures that application creation and
teardown happen inside run loops.... | packages/ember-states/tests/state_manager_test.js | @@ -31,9 +31,11 @@ module("Ember.StateManager", {
},
teardown: function() {
- if (stateManager) {
- stateManager.destroy();
- }
+ Ember.run(function() {
+ if (stateManager) {
+ stateManager.destroy();
+ }
+ });
}
});
| true |
Other | emberjs | ember.js | 8118866ef1c6838a5c08ac3b1a9d092fd023f835.json | Fix failing unit tests due to deferred teardown
Object destruction is deferred until the end of
the run loop. This was causing failing unit
tests in some cases where the old event dispatcher
was not being torn down before a new test started.
This ensures that application creation and
teardown happen inside run loops.... | packages/ember-views/tests/system/event_dispatcher_test.js | @@ -11,13 +11,17 @@ var set = Ember.set, get = Ember.get;
module("Ember.EventDispatcher", {
setup: function() {
- dispatcher = Ember.EventDispatcher.create();
- dispatcher.setup();
+ Ember.run(function() {
+ dispatcher = Ember.EventDispatcher.create();
+ dispatcher.setup();
+ });
},
... | true |
Other | emberjs | ember.js | 27eca01d12ee22de0997be117158699678b40ca9.json | Fix bindAttr with keywords - Fixed #798
bindAttr was not properly setting up observers when keywords were used
so changes weren't properly propagated. | packages/ember-handlebars/lib/helpers/binding.js | @@ -8,7 +8,8 @@ require('ember-handlebars/ext');
require('ember-handlebars/views/handlebars_bound_view');
require('ember-handlebars/views/metamorph_view');
-var get = Ember.get, getPath = Ember.Handlebars.getPath, set = Ember.set, fmt = Ember.String.fmt;
+var get = Ember.get, getPath = Ember.getPath, set = Ember.se... | true |
Other | emberjs | ember.js | 27eca01d12ee22de0997be117158699678b40ca9.json | Fix bindAttr with keywords - Fixed #798
bindAttr was not properly setting up observers when keywords were used
so changes weren't properly propagated. | packages/ember-handlebars/tests/handlebars_test.js | @@ -1235,6 +1235,23 @@ test("should be able to bind element attributes using {{bindAttr}}", function()
equal(view.$('img').attr('alt'), "Nanananana Ember!", "updates alt attribute when title property is computed");
});
+test("should be able to bind to view attributes with {{bindAttr}}", function() {
+ view = Emb... | true |
Other | emberjs | ember.js | 4435dc7b79efd950e3c47bcfcf9796d6462a7b03.json | Fix example to reflect classes not instances. | packages/ember-views/lib/system/application.js | @@ -89,8 +89,8 @@ Ember.Application = Ember.Namespace.extend(
Example:
- App.PostsController = Ember.ArrayController.create();
- App.CommentsController = Ember.ArrayController.create();
+ App.PostsController = Ember.ArrayController.extend();
+ App.CommentsController = Ember.ArrayController.... | false |
Other | emberjs | ember.js | 455b2ecbcd3e4fe72a9eec9ed9ddb1d52ba92ee7.json | Defer readiness to the end of the run loop
Currently, the application "becomes ready"
immediately upon being notified by jQuery that
the DOM is ready.
However, in cases where the Ember app loads after
the DOM ready event, this doesn't give your
classes a chance to load before the app is
initialized.
This change defe... | packages/ember-application/lib/system/application.js | @@ -72,11 +72,11 @@ Ember.Application = Ember.Namespace.extend(
// jQuery 1.7 doesn't call the ready callback if already ready
if (Ember.$.isReady) {
- this.didBecomeReady();
+ Ember.run.once(this, this.didBecomeReady);
} else {
var self = this;
Ember.$(document).ready(function(... | true |
Other | emberjs | ember.js | 455b2ecbcd3e4fe72a9eec9ed9ddb1d52ba92ee7.json | Defer readiness to the end of the run loop
Currently, the application "becomes ready"
immediately upon being notified by jQuery that
the DOM is ready.
However, in cases where the Ember app loads after
the DOM ready event, this doesn't give your
classes a chance to load before the app is
initialized.
This change defe... | packages/ember-application/tests/system/application_test.js | @@ -12,7 +12,9 @@ var set = Ember.set, get = Ember.get, getPath = Ember.getPath;
module("Ember.Application", {
setup: function() {
Ember.$("#qunit-fixture").html("<div id='one'><div id='one-child'>HI</div></div><div id='two'>HI</div>");
- application = Ember.Application.create({ rootElement: '#one' });
+ ... | true |
Other | emberjs | ember.js | b6978aadc1d0af5c02b5e8ee022d15b1cf6297d3.json | Update execjs to avoid deprecation warnings | Gemfile.lock | @@ -35,7 +35,7 @@ GEM
specs:
addressable (2.2.7)
colored (1.2)
- execjs (1.3.0)
+ execjs (1.3.2)
multi_json (~> 1.0)
faraday (0.7.6)
addressable (~> 2.2)
@@ -51,7 +51,7 @@ GEM
kicker (2.5.0)
rb-fsevent
mime-types (1.18)
- multi_json (1.3.2)
+ multi_json (1.3.... | false |
Other | emberjs | ember.js | dfad0c557334b651db5419cd94e5f50034d0671e.json | Improve view documentation | packages/ember-views/lib/views/view.js | @@ -232,7 +232,7 @@ var invokeForState = {
firstName: 'Barry'
})
excitedGreeting: function(){
- return this.getPath("contnet.firstName") + "!!!"
+ return this.getPath("content.firstName") + "!!!"
}
})
@@ -1098,10 +1098,9 @@ Ember.View = Ember.Object.exten... | false |
Other | emberjs | ember.js | a4e9d88d1ffac8fb86cebe8362d3c55be4dc9fb6.json | Add support for "input" event handlers
This is an HTML standard event, like "change".
https://developer.mozilla.org/en/DOM/window.oninput
http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#event-input-input | packages/ember-views/lib/system/event_dispatcher.js | @@ -63,6 +63,7 @@ Ember.EventDispatcher = Ember.Object.extend(
mouseenter : 'mouseEnter',
mouseleave : 'mouseLeave',
submit : 'submit',
+ input : 'input',
change : 'change',
dragstart : 'dragStart',
drag : 'drag', | false |
Other | emberjs | ember.js | d67634349c8500b2ce7e08e3f1c3355004565881.json | Update ExecJS to avoid deprecation warnings | Gemfile.lock | @@ -35,7 +35,7 @@ GEM
specs:
addressable (2.2.7)
colored (1.2)
- execjs (1.3.0)
+ execjs (1.3.2)
multi_json (~> 1.0)
faraday (0.7.6)
addressable (~> 2.2)
@@ -51,7 +51,7 @@ GEM
kicker (2.5.0)
rb-fsevent
mime-types (1.18)
- multi_json (1.3.2)
+ multi_json (1.3.... | false |
Other | emberjs | ember.js | 6a6db5b383d41d33c3c0c978f773122bf1007bc8.json | Fix JsDoc tags | packages/ember-states/lib/state_manager.js | @@ -353,7 +353,7 @@ require('ember-states/state');
**/
Ember.StateManager = Ember.State.extend(
-/** @scope Ember.State.prototype */ {
+/** @scope Ember.StateManager.prototype */ {
/**
When creating a new statemanager, look for a default state to transition
@@ -377,11 +377,11 @@ Ember.StateManager = Ember... | true |
Other | emberjs | ember.js | 6a6db5b383d41d33c3c0c978f773122bf1007bc8.json | Fix JsDoc tags | packages/ember-viewstates/lib/state_manager.js | @@ -239,15 +239,15 @@ var get = Ember.get, set = Ember.set, getPath = Ember.getPath, fmt = Ember.Strin
`view` that references the `Ember.View` object that was interacted with.
**/
-
-Ember.StateManager.reopen({
+Ember.StateManager.reopen(
+/** @scope Ember.StateManager.prototype */ {
/**
- @property
-
... | true |
Other | emberjs | ember.js | f32a10660a5571875a59d46e7144a3de8a7a8c0b.json | Fix issue with "/" route alongside "/*" | packages/ember-states/lib/routable.js | @@ -19,10 +19,17 @@ Ember._RouteMatcher = Ember.Object.extend({
state: null,
init: function() {
- var route = get(this, 'route'),
- escaped = escapeForRegex(route),
+ var route = this.route,
identifiers = [],
- count = 1;
+ count = 1,
+ escaped;
+
+ // Strip off lea... | true |
Other | emberjs | ember.js | f32a10660a5571875a59d46e7144a3de8a7a8c0b.json | Fix issue with "/" route alongside "/*" | packages/ember-states/tests/routable_test.js | @@ -208,23 +208,43 @@ module("Routing Serialization and Deserialization", {
location: locationMock,
start: Ember.State.create({
ready: function(manager, post) {
- manager.transitionTo('post', { post: post });
+ manager.transitionTo('post.show', { post: post });
+ },
+
+ ... | true |
Other | emberjs | ember.js | 4d3091c95dc3c3df07aaf19d12f5f87f901f18bf.json | Remove stray references to IndexSet | packages/ember-runtime/lib/mixins/mutable_array.js | @@ -106,7 +106,7 @@ Ember.MutableArray = Ember.Mixin.create(Ember.Array, Ember.MutableEnumerable,
colors.removeAt(2, 2); => ["green", "blue"]
colors.removeAt(4, 2); => Error: Index out of range
- @param {Number|Ember.IndexSet} start index, start of range, or index set
+ @param {Number} start i... | true |
Other | emberjs | ember.js | 4d3091c95dc3c3df07aaf19d12f5f87f901f18bf.json | Remove stray references to IndexSet | packages/ember-runtime/tests/suites/mutable_array/removeAt.js | @@ -126,5 +126,3 @@ suite.test("[A,B,C,D].removeAt(1,2) => [A,D] + notify", function() {
equal(observer.validate('firstObject'), false, 'should NOT have notified firstObject once');
equal(observer.validate('lastObject'), false, 'should NOT have notified lastObject once');
});
-
-suite.notest("[A,B,C,D].removeAt(... | true |
Other | emberjs | ember.js | 23dc092684edaba57ad2eeb2c5a75f7a2b570c03.json | Correct Enumerable documentation | packages/ember-runtime/lib/mixins/enumerable.js | @@ -727,15 +727,13 @@ Ember.Enumerable = Ember.Mixin.create( /** @lends Ember.Enumerable */ {
optional start offset for the content change. For unordered
enumerables, you should always pass -1.
- @param {Enumerable} added
- optional enumerable containing items that were added to the set. For
-... | false |
Other | emberjs | ember.js | 5dde927641c9152c53624a3ffaaa99d5c1777c9f.json | Add explicit value field (for documentation later) | packages/ember-handlebars/lib/controls/text_field.js | @@ -18,9 +18,10 @@ Ember.TextField = Ember.View.extend(Ember.TextSupport,
/** @scope Ember.TextField.prototype */ {
classNames: ['ember-text-field'],
-
tagName: "input",
attributeBindings: ['type', 'value', 'size'],
+
+ value: '',
type: "text",
size: null
}); | false |
Other | emberjs | ember.js | dd1851eea9fc6979570ba761cd1931c3a1ee7e57.json | Add support for #each foo in bar
This implementation takes on some new technical
debt, mostly caused by existing technical debt.
Because this is a very bad thing, we plan to work
on refactoring and paying down as much of the
templateData technical debt as possible tomorrow. | packages/ember-handlebars/lib/helpers/collection.js | @@ -172,24 +172,19 @@ Ember.Handlebars.registerHelper('collection', function(path, options) {
}
if (inverse && inverse !== Handlebars.VM.noop) {
- var emptyViewClass = Ember.View;
-
- if (hash.emptyViewClass) {
- emptyViewClass = Ember.View.detect(hash.emptyViewClass) ?
- has... | true |
Other | emberjs | ember.js | dd1851eea9fc6979570ba761cd1931c3a1ee7e57.json | Add support for #each foo in bar
This implementation takes on some new technical
debt, mostly caused by existing technical debt.
Because this is a very bad thing, we plan to work
on refactoring and paying down as much of the
templateData technical debt as possible tomorrow. | packages/ember-handlebars/lib/helpers/each.js | @@ -2,17 +2,57 @@ require("ember-handlebars/ext");
require("ember-views/views/collection_view");
require("ember-handlebars/views/metamorph_view");
+var get = Ember.get, set = Ember.set;
+
Ember.Handlebars.EachView = Ember.CollectionView.extend(Ember._Metamorph, {
- itemViewClass: Ember._MetamorphView
+ itemViewC... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.