language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | b5a5c115a83db849eb1a6bb4f022e45767ed4ab5.json | Fix Handlebars in builds | Assetfile | @@ -85,7 +85,7 @@ end
distros = {
:runtime => %w(ember-metal ember-runtime),
- :full => %w(handlebars ember-metal ember-runtime ember-application ember-views ember-states ember-routing ember-viewstates metamorph ember-handlebars)
+ :full => %w(ember-metal ember-runtime ember-application ember-views ember-... | true |
Other | emberjs | ember.js | b5a5c115a83db849eb1a6bb4f022e45767ed4ab5.json | Fix Handlebars in builds | Rakefile | @@ -67,12 +67,12 @@ end
desc "Clean build artifacts from previous builds"
task :clean do
puts "Cleaning build..."
- pipeline.clean
+ rm_rf "dist" # Make sure even things RakeP doesn't know about are cleaned
puts "Done"
end
desc "Upload latest Ember.js build to GitHub repository"
-task :upload_latest => :d... | true |
Other | emberjs | ember.js | 8fd57b354c0e46f2f732a1ff1d75a078200a6fb1.json | Support basic States inside of Routes | packages/ember-routing/lib/routable.js | @@ -78,7 +78,7 @@ Ember.Routable = Ember.Mixin.create({
In general, this will update the browser's URL.
*/
updateRoute: function(manager, location) {
- if (get(this, 'isLeaf')) {
+ if (get(this, 'isLeafRoute')) {
var path = this.absoluteRoute(manager);
location.setURL(path);
}
@@ -13... | true |
Other | emberjs | ember.js | 8fd57b354c0e46f2f732a1ff1d75a078200a6fb1.json | Support basic States inside of Routes | packages/ember-routing/lib/router.js | @@ -389,21 +389,34 @@ Ember.Router = Ember.StateManager.extend(
route: function(path) {
set(this, 'isRouting', true);
+ var routableState;
+
try {
path = path.replace(/^(?=[^\/])/, "/");
this.send('navigateAway');
this.send('unroutePath', path);
- var currentURL = get(thi... | true |
Other | emberjs | ember.js | 8fd57b354c0e46f2f732a1ff1d75a078200a6fb1.json | Support basic States inside of Routes | packages/ember-routing/tests/routable_test.js | @@ -142,6 +142,46 @@ test("when you descend into a state, the route is set", function() {
router.send('ready');
});
+test("when you descend into a state, the route is set even when child states (not routes) are present", function() {
+ var state = Ember.Route.create({
+ ready: function(manager) {
+ manag... | true |
Other | emberjs | ember.js | 8fd57b354c0e46f2f732a1ff1d75a078200a6fb1.json | Support basic States inside of Routes | packages/ember-routing/tests/router_test.js | @@ -334,7 +334,32 @@ test("should update route for redirections", function() {
})
});
- router.route('/');
+ Ember.run(function() {
+ router.route('/');
+ });
equal(location.url, '/login');
});
+
+test("respects initialState if leafRoute with child states", function() {
+ var router = Ember.Route... | true |
Other | emberjs | ember.js | 00c92ef2852abcc037091d5b03701586df121b59.json | Fix typos in docs. | packages/ember-routing/lib/router.js | @@ -154,12 +154,12 @@ var get = Ember.get, getPath = Ember.getPath, set = Ember.set;
}
Within `deserialize` you should use this information to retrieve or create an appropriate context
- object for the given url (e.g. by loading from a remote API or accessing the browser's
- `localStorage`). This object m... | false |
Other | emberjs | ember.js | 857a614babd82f3cbf03fefc0b336a44918f5b0e.json | Make Map copyable | packages/ember-metal/lib/map.js | @@ -20,11 +20,32 @@
require('ember-metal/array');
require('ember-metal/utils');
+require('ember-metal/core');
/** @private */
var guidFor = Ember.guidFor,
indexOf = Ember.ArrayPolyfills.indexOf;
+var copy = function(obj) {
+ var output = {};
+
+ for (var prop in obj) {
+ if (obj.hasOwnProperty(prop)... | true |
Other | emberjs | ember.js | 857a614babd82f3cbf03fefc0b336a44918f5b0e.json | Make Map copyable | packages/ember-metal/tests/map_test.js | @@ -13,22 +13,26 @@ function testMap(variety) {
}
});
- var mapHasLength = function(expected) {
+ var mapHasLength = function(expected, theMap) {
+ theMap = theMap || map;
+
var length = 0;
- map.forEach(function() {
+ theMap.forEach(function() {
length++;
});
equal(length, ... | true |
Other | emberjs | ember.js | 2bce92383aecf5405119e1377c02b36c14268292.json | use method name instead of method | packages/ember-metal/lib/mixin.js | @@ -194,7 +194,7 @@ function applyBeforeObservers(obj, m) {
method = beforeObservers[methodName];
paths = method.__ember_observesBefore__;
for (i=0, l=paths.length; i<l; i++) {
- addBeforeObserver(obj, paths[i], obj, method);
+ addBeforeObserver(obj, paths[i], null, methodName);
}
}
@... | true |
Other | emberjs | ember.js | 2bce92383aecf5405119e1377c02b36c14268292.json | use method name instead of method | packages/ember-metal/tests/observer_test.js | @@ -333,7 +333,7 @@ testBoth('local observers can be removed', function(get, set) {
set(obj, 'bar', 'HI!');
equal(barObserved, 2, 'precond - observers should be fired');
- Ember.removeObserver(obj, 'bar', obj, obj.foo1);
+ Ember.removeObserver(obj, 'bar', null, 'foo1');
barObserved = 0;
set(obj, 'bar'... | true |
Other | emberjs | ember.js | 3c348928abc44e91ca1c6f51b539b337fbcb1265.json | Fix failing tests | packages/ember-routing/lib/routable.js | @@ -59,7 +59,7 @@ Ember.Routable = Ember.Mixin.create({
*/
stashContext: function(manager, context) {
var serialized = this.serialize(manager, context);
- Ember.assert('serialize must return a hash', typeof serialized === 'object');
+ Ember.assert('serialize must return a hash', !serialized || typeof s... | false |
Other | emberjs | ember.js | bf5f24cc9ab8c5e6817e970114124e7a78467fd1.json | add hook for desc for willWatch and didUnwatch | packages/ember-metal/lib/watching.js | @@ -430,6 +430,9 @@ Ember.watch = function(obj, keyName) {
if (!watching[keyName]) {
watching[keyName] = 1;
if (isKeyName(keyName)) {
+ desc = m.descs[keyName];
+ if (desc && desc.willWatch) { desc.willWatch(obj, keyName); }
+
if ('function' === typeof obj.willWatchProperty) {
obj... | false |
Other | emberjs | ember.js | 84e9626522a686c29e6d6f2127d35c2dc9698d80.json | remove unused lastSetValues from meta | packages/ember-metal/lib/utils.js | @@ -173,7 +173,6 @@ Ember.meta = function meta(obj, writable) {
descs: {},
watching: {},
values: {},
- lastSetValues: {},
cache: {},
source: obj
});
@@ -186,7 +185,6 @@ Ember.meta = function meta(obj, writable) {
ret.descs = o_create(ret.descs);
ret.values = ... | false |
Other | emberjs | ember.js | 5f9bbadd713cbaca569fac413c45caa40399c836.json | Add hooks for tests to override core behavior
We are experimenting with an approach for the
ember-data tests that overrides the entry points
into the framework with synchronous versions.
These hooks make those experiments possible.
Please do not use these hooks in app code :) | packages/ember-metal/lib/accessors.js | @@ -131,6 +131,12 @@ Ember.get = get;
*/
Ember.set = set;
+if (Ember.config.overrideAccessors) {
+ Ember.config.overrideAccessors();
+ get = Ember.get;
+ set = Ember.set;
+}
+
// ..........................................................
// PATHS
// | true |
Other | emberjs | ember.js | 5f9bbadd713cbaca569fac413c45caa40399c836.json | Add hooks for tests to override core behavior
We are experimenting with an approach for the
ember-data tests that overrides the entry points
into the framework with synchronous versions.
These hooks make those experiments possible.
Please do not use these hooks in app code :) | packages/ember-metal/lib/core.js | @@ -6,10 +6,15 @@
/*globals Em:true ENV */
if ('undefined' === typeof Ember) {
+ // Create core object. Make it act like an instance of Ember.Namespace so that
+ // objects assigned to it are given a sane string representation.
+ Ember = {};
+}
+
/**
@namespace
@name Ember
- @version 0.9.8.1
+ @version ... | true |
Other | emberjs | ember.js | 5f9bbadd713cbaca569fac413c45caa40399c836.json | Add hooks for tests to override core behavior
We are experimenting with an approach for the
ember-data tests that overrides the entry points
into the framework with synchronous versions.
These hooks make those experiments possible.
Please do not use these hooks in app code :) | packages/ember-runtime/lib/system/core_object.js | @@ -151,6 +151,10 @@ CoreObject.PrototypeMixin = Ember.Mixin.create(
}
});
+if (Ember.config.overridePrototypeMixin) {
+ Ember.config.overridePrototypeMixin(CoreObject.PrototypeMixin);
+}
+
CoreObject.__super__ = null;
var ClassMixin = Ember.Mixin.create(
@@ -268,6 +272,10 @@ var ClassMixin = Ember.Mixin.cre... | true |
Other | emberjs | ember.js | b296e2e276df7531165fd8bea5b2313000a824f4.json | serialize route states recursively | packages/ember-routing/lib/router.js | @@ -92,11 +92,23 @@ Ember.Router = Ember.StateManager.extend(
var targetState = this.findStateByPath(currentState, targetStateName);
Ember.assert("Your target state name " + targetStateName + " for event " + eventName + " did not resolve to a state", !!targetState);
- var hash = targetState.serialize(thi... | false |
Other | emberjs | ember.js | 083d80ba00c0012a3d36e932c2ccca1f24bdbfeb.json | Update documentation of ObjectProxy | packages/ember-runtime/lib/system/object_proxy.js | @@ -80,8 +80,8 @@ delegateDesc = Ember.computed(delegate).volatile();
/**
@class
- `Ember.ObjectProxy` forwards all properties to a proxied `content`
- object.
+ `Ember.ObjectProxy` forwards all properties not defined by the proxy itself
+ to a proxied `content` object.
object = Ember.Object.create({... | false |
Other | emberjs | ember.js | d23ea3ab501fc0e8f591a793b927f572436647a1.json | Change app.stateManager to app.router | packages/ember-application/lib/system/application.js | @@ -112,7 +112,7 @@ Ember.Application = Ember.Namespace.extend(
}
if (router) {
- set(this, 'stateManager', router);
+ set(this, 'router', router);
}
// By default, the router's namespace is the current application. | true |
Other | emberjs | ember.js | d23ea3ab501fc0e8f591a793b927f572436647a1.json | Change app.stateManager to app.router | packages/ember-application/tests/system/application_test.js | @@ -142,21 +142,7 @@ test('initialized application go to initial route', function() {
});
app.initialize(app.stateManager);
- equal(app.getPath('stateManager.currentState.path'), 'root.index', "The router moved the state into the right place");
-});
-
-test("initialize application with non routable stateManage... | true |
Other | emberjs | ember.js | 946cefdc2ec93a36205fa8f32a1e1644bd61451f.json | Avoid deprecation warning for ViewState tests | packages/ember-viewstates/tests/view_state_test.js | @@ -1,6 +1,14 @@
var get = Ember.get, set = Ember.set, getPath = Ember.getPath, setPath = Ember.setPath;
-module("Ember.ViewState");
+module("Ember.ViewState", {
+ setup: function() {
+ Ember.TESTING_DEPRECATION = true;
+ },
+
+ teardown: function() {
+ Ember.TESTING_DEPRECATION = false;
+ }
+});
test("... | false |
Other | emberjs | ember.js | ac64f2320445f75710a81c3616a0d6bdf1b034d5.json | unify xform observer edition | packages/ember-metal/lib/observer.js | @@ -44,7 +44,7 @@ var DeferredEventQueue = function() {
this.queue = [];
};
-DeferredEventQueue.prototype.push = function(target, eventName) {
+DeferredEventQueue.prototype.push = function(target, eventName, keyName) {
var targetSet = this.targetSet,
queue = this.queue,
targetGuid = Ember.guidFor(tar... | false |
Other | emberjs | ember.js | d1b5d49ef8aecc3967fdbaff3156221fa48d061a.json | remove obscure feature of addObserver | packages/ember-metal/lib/observer.js | @@ -153,20 +153,14 @@ function beforeKey(eventName) {
}
/** @private */
-function xformForArgs(args) {
- return function (target, method, params) {
- var obj = params[0], keyName = changeKey(params[1]), val;
- var copy_args = args.slice();
- if (method.length>2) {
- val = Ember.getPath(Ember.isGlobal... | true |
Other | emberjs | ember.js | d1b5d49ef8aecc3967fdbaff3156221fa48d061a.json | remove obscure feature of addObserver | packages/ember-metal/tests/observer_test.js | @@ -267,30 +267,6 @@ testBoth('addObserver should respect targets with methods', function(get,set){
});
-testBoth('addObserver should preserve additional context passed when firing the observer', function(get, set) {
- var observed = { foo: 'foo' };
-
- var target1 = {
- count: 0,
-
- didChange: function(o... | true |
Other | emberjs | ember.js | ced3ad465c50f0448427587403b6418a3f378299.json | unify xform @enumerable edition | packages/ember-runtime/lib/mixins/enumerable.js | @@ -41,7 +41,8 @@ function iter(key, value) {
/** @private */
function xform(target, method, params) {
- method.call(target, params[0], params[2], params[3]);
+ var args = [].slice.call(params, 2);
+ method.apply(target, args);
}
/**
@@ -707,7 +708,7 @@ Ember.Enumerable = Ember.Mixin.create( /** @lends Ember... | false |
Other | emberjs | ember.js | 5769c87030d257cd33faba9070bc58f1fed344ac.json | unify xform @array edition | packages/ember-runtime/lib/mixins/array.js | @@ -17,7 +17,8 @@ function none(obj) { return obj===null || obj===undefined; }
/** @private */
function xform(target, method, params) {
- method.call(target, params[0], params[2], params[3], params[4]);
+ var args = [].slice.call(params, 2);
+ method.apply(target, args);
}
// ................................... | false |
Other | emberjs | ember.js | 5ac298f764f417d64bfd8e7b85322bfcdcd7940e.json | remove unused var | packages/ember-runtime/lib/system/core_object.js | @@ -32,7 +32,7 @@ function makeCtor() {
// method a lot faster. This is glue code so we want it to be as fast as
// possible.
- var wasApplied = false, initMixins, init = false;
+ var wasApplied = false, initMixins;
var Class = function() {
if (!wasApplied) { | false |
Other | emberjs | ember.js | fd4e1067999e6d9428ff86e8941863102ed57819.json | remove memory leak of anonymous subclasses | packages/ember-runtime/lib/system/core_object.js | @@ -183,10 +183,6 @@ var ClassMixin = Ember.Mixin.create(
Ember.generateGuid(proto, 'ember');
meta(proto).proto = proto; // this will disable observers on prototype
-
- Class.subclasses = Ember.Set ? new Ember.Set() : null;
- if (this.subclasses) { this.subclasses.add(Class); }
-
Class.ClassMixin... | true |
Other | emberjs | ember.js | fd4e1067999e6d9428ff86e8941863102ed57819.json | remove memory leak of anonymous subclasses | packages/ember-runtime/lib/system/object.js | @@ -8,8 +8,6 @@ require('ember-runtime/mixins/observable');
require('ember-runtime/system/core_object');
require('ember-runtime/system/set');
-Ember.CoreObject.subclasses = new Ember.Set();
-
/**
@class
@@ -21,6 +19,3 @@ Ember.CoreObject.subclasses = new Ember.Set();
@extends Ember.Observable
*/
Ember.Ob... | true |
Other | emberjs | ember.js | fd4e1067999e6d9428ff86e8941863102ed57819.json | remove memory leak of anonymous subclasses | packages/ember-runtime/tests/legacy_1x/system/object/base_test.js | @@ -157,12 +157,3 @@ test("Checking the detectInstance() function on an object and its subclass", fun
ok(Ember.Object.detectInstance(obj.create()));
ok(obj.detectInstance(obj.create()));
});
-
-test("subclasses should contain defined subclasses", function() {
- ok(inArray(obj1, obj.subclasses) > -1, 'obj.subcla... | true |
Other | emberjs | ember.js | fd4e1067999e6d9428ff86e8941863102ed57819.json | remove memory leak of anonymous subclasses | packages/ember-runtime/tests/system/object/subclasses_test.js | @@ -6,23 +6,6 @@
module('system/object/subclasses');
-test('Ember.Object should have a subclass set', function() {
- ok(Ember.Object.subclasses instanceof Ember.Set);
-});
-
-test('defining a new subclass should add it to set of parent', function() {
- var Subclass = Ember.Object.extend();
- ok(Ember.Object.sub... | true |
Other | emberjs | ember.js | 2d26a36f4119ffa0f8b41157dbb2856f27a33420.json | Improve the sorting algorithm for routing
If one route is an explicit substring of another,
prefer the longer one.
Otherwise, if one of the routes has a dynamic
segment, prefer the route without the dynamic
segment.
Otherwise, prefer the longer one.
This fixes posts/:post_id being preferred over
posts/new.
Eventua... | packages/ember-routing/lib/routable.js | @@ -260,6 +260,21 @@ Ember.Routable = Ember.Mixin.create({
var childStates = get(this, 'childStates'), match;
childStates = childStates.sort(function(a, b) {
+ var aDynamicSegments = getPath(a, 'routeMatcher.identifiers.length'),
+ bDynamicSegments = getPath(b, 'routeMatcher.identifiers.length... | false |
Other | emberjs | ember.js | 6c428ec4a890d8e2e58e545d503995b46c327f5f.json | Move initial observer setup to finishPartial | packages/ember-metal/lib/mixin.js | @@ -191,6 +191,31 @@ function connectBindings(obj, m) {
}
}
+function applyObservers(obj) {
+ var meta = Ember.meta(obj),
+ observers = meta.observers,
+ beforeObservers = meta.beforeObservers,
+ methodName, method, observerPaths, i, l;
+
+ for (methodName in observers) {
+ method = observers[... | true |
Other | emberjs | ember.js | 6c428ec4a890d8e2e58e545d503995b46c327f5f.json | Move initial observer setup to finishPartial | packages/ember-metal/lib/utils.js | @@ -174,6 +174,8 @@ Ember.meta = function meta(obj, writable) {
ret = obj[META_KEY] = createMeta({
descs: {},
watching: {},
+ observers: {},
+ beforeObservers: {},
values: {},
lastSetValues: {},
cache: {},
@@ -188,6 +190,8 @@ Ember.meta = function meta(obj, writable) {... | true |
Other | emberjs | ember.js | ce3eb53997ce3f451d2a29989d06775e7ba4cdff.json | add observers wiring to finishPartial | packages/ember-metal/lib/mixin.js | @@ -144,21 +144,10 @@ function writableReq(obj) {
return req;
}
-/** @private */
-function getObserverPaths(value) {
- return 'function' === typeof value && value.__ember_observes__;
-}
-
-/** @private */
-function getBeforeObserverPaths(value) {
- return 'function' === typeof value && value.__ember_observesBef... | true |
Other | emberjs | ember.js | ce3eb53997ce3f451d2a29989d06775e7ba4cdff.json | add observers wiring to finishPartial | packages/ember-metal/lib/utils.js | @@ -175,6 +175,8 @@ Ember.meta = function meta(obj, writable) {
descs: {},
watching: {},
values: {},
+ observers: {},
+ beforeObservers: {},
lastSetValues: {},
cache: {},
source: obj
@@ -188,6 +190,8 @@ Ember.meta = function meta(obj, writable) {
ret.descs = ... | true |
Other | emberjs | ember.js | ce3eb53997ce3f451d2a29989d06775e7ba4cdff.json | add observers wiring to finishPartial | packages/ember-metal/tests/observer_test.js | @@ -355,7 +355,7 @@ testBoth('local observers can be removed', function(get, set) {
set(obj, 'bar', 'HI!');
equal(barObserved, 2, 'precond - observers should be fired');
- Ember.removeObserver(obj, 'bar', null, 'foo1');
+ Ember.removeObserver(obj, 'bar', obj, obj.foo1);
barObserved = 0;
set(obj, 'bar'... | true |
Other | emberjs | ember.js | ce3eb53997ce3f451d2a29989d06775e7ba4cdff.json | add observers wiring to finishPartial | packages/ember-metal/tests/watching/isWatching_test.js | @@ -22,7 +22,7 @@ test("isWatching is true for regular local observers", function() {
didChange: Ember.observer(fn, key)
}).apply(obj);
}, function(obj, key, fn) {
- Ember.removeObserver(obj, key, null, fn);
+ Ember.removeObserver(obj, key, obj, fn);
});
});
| true |
Other | emberjs | ember.js | ce3eb53997ce3f451d2a29989d06775e7ba4cdff.json | add observers wiring to finishPartial | packages/ember-runtime/tests/ext/mixin_test.js | @@ -8,7 +8,6 @@
module('system/mixin/binding_test');
test('Defining a property ending in Binding should setup binding when applied', function() {
-
var MyMixin = Ember.Mixin.create({
fooBinding: 'bar.baz'
}); | true |
Other | emberjs | ember.js | 5de4da062376ef955677d435d721cbeb8712e9eb.json | Improve some assertion messages | packages/ember-handlebars/lib/helpers/collection.js | @@ -135,7 +135,7 @@ Ember.Handlebars.registerHelper('collection', function(path, options) {
// Otherwise, just default to the standard class.
var collectionClass;
collectionClass = path ? getPath(this, path, options) : Ember.CollectionView;
- Ember.assert(fmt("%@ #collection: Could not find %@", data.view, pa... | true |
Other | emberjs | ember.js | 5de4da062376ef955677d435d721cbeb8712e9eb.json | Improve some assertion messages | packages/ember-views/lib/views/view.js | @@ -794,7 +794,7 @@ Ember.View = Ember.Object.extend(Ember.Evented,
// is the view by default. A hash of data is also passed that provides
// the template with access to the view and render buffer.
- Ember.assert('template must be a function. Did you mean to specify templateName instead?', typeof t... | true |
Other | emberjs | ember.js | e945b9ebde480f642017e4ecea6c545014f68741.json | Update location documentation | packages/ember-application/lib/system/location.js | @@ -8,6 +8,7 @@ var get = Ember.get, set = Ember.set;
getURL: returns the current URL
setURL(path): sets the current URL
onUpdateURL(callback): triggers the callback when the URL changes
+ formatURL(url): formats `url` to be placed into `href` attribute
Calling setURL will not trigger onUpdateURL callbac... | false |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/lib/controls.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/lib/controls/button.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/lib/controls/checkbox.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/lib/controls/text_area.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/lib/controls/text_field.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/lib/controls/text_support.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/lib/ext.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/lib/helpers.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/lib/helpers/binding.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/lib/helpers/collection.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/lib/helpers/debug.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/lib/helpers/unbound.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/lib/helpers/view.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/lib/loader.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/lib/main.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/lib/views.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/lib/views/handlebars_bound_view.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/tests/controls/button_test.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/tests/controls/checkbox_test.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/tests/controls/text_area_test.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/tests/controls/text_field_test.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/tests/handlebars_test.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/tests/helpers/yield_test.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 11211994fe735900b4d6ccbfed9eacf528fd3f8b.json | Fix spelling of Handlebars | packages/ember-handlebars/tests/views/collection_view_test.js | @@ -1,5 +1,5 @@
// ==========================================================================
-// Project: Ember Handlebar Views
+// Project: Ember Handlebars Views
// Copyright: ©2011 Strobe Inc. and contributors.
// License: Licensed under MIT license (see license.js)
// ====================================... | true |
Other | emberjs | ember.js | 960bbe09227e27517ead710dd12bb9136aaa2d66.json | Modify run loop behavior.
We want to restart the run loop to flush prior queues before moving on
to the next queue. | packages/ember-metal/lib/run_loop.js | @@ -85,9 +85,9 @@ RunLoop.prototype = {
},
flush: function(queueName) {
- var queues = this._queues, queueNames, idx, len, queue, log;
+ var queueNames, idx, len, queue, log;
- if (!queues) { return this; } // nothing to do
+ if (!this._queues) { return this; } // nothing to do
function ite... | true |
Other | emberjs | ember.js | 960bbe09227e27517ead710dd12bb9136aaa2d66.json | Modify run loop behavior.
We want to restart the run loop to flush prior queues before moving on
to the next queue. | packages/ember-metal/tests/run_loop/schedule_test.js | @@ -36,3 +36,27 @@ test('nested runs should queue each phase independently', function() {
equal(cnt, 2, 'should flush actions now');
});
+
+test('prior queues should be flushed before moving on to next queue', function() {
+ var order = [];
+
+ Ember.run(function() {
+ Ember.run.schedule('sync', function() {... | true |
Other | emberjs | ember.js | d6ef3990289357f26132418cf25b1ec4898814e7.json | Modify run loop behavior.
We want to restart the run loop to flush prior queues before moving on
to the next queue. | packages/ember-metal/lib/run_loop.js | @@ -86,9 +86,9 @@ RunLoop.prototype = {
},
flush: function(queueName) {
- var queues = this._queues, queueNames, idx, len, queue, log;
+ var queueNames, idx, len, queue, log;
- if (!queues) { return this; } // nothing to do
+ if (!this._queues) { return this; } // nothing to do
function ite... | true |
Other | emberjs | ember.js | d6ef3990289357f26132418cf25b1ec4898814e7.json | Modify run loop behavior.
We want to restart the run loop to flush prior queues before moving on
to the next queue. | packages/ember-metal/tests/run_loop/schedule_test.js | @@ -36,3 +36,27 @@ test('nested runs should queue each phase independently', function() {
equal(cnt, 2, 'should flush actions now');
});
+
+test('prior queues should be flushed before moving on to next queue', function() {
+ var order = [];
+
+ Ember.run(function() {
+ Ember.run.schedule('sync', function() {... | true |
Other | emberjs | ember.js | 79d6cbb214b98ac3faf39a373873dc40d6468806.json | Normalize path for binding {{#with as}}. Ref #980 | packages/ember-handlebars/lib/helpers/binding.js | @@ -158,7 +158,7 @@ EmberHandlebars.registerHelper('boundIf', function(property, fn) {
*/
EmberHandlebars.registerHelper('with', function(context, options) {
if (arguments.length === 4) {
- var keywordName, path;
+ var keywordName, path, rootPath, normalized;
Ember.assert("If you pass more than one ar... | false |
Other | emberjs | ember.js | c6a8f46f3e9337ccfa962f6a86ee3204758210e8.json | add test for `#with view as foo` | packages/ember-handlebars/tests/helpers/with_test.js | @@ -82,6 +82,24 @@ test("it should support #with Foo.bar as qux", function() {
equal(view.$().text(), "updated", "should update");
});
+module("Handlebars {{#with keyword as foo}}");
+
+test("it should support #with view as foo", function() {
+ var view = Ember.View.create({
+ template: Ember.Handlebars.compi... | false |
Other | emberjs | ember.js | 8c22290e33814c9e1d509b6fb358263e26023a3e.json | Use reopenClass to add methods to the State class | packages/ember-states/lib/state.js | @@ -161,16 +161,18 @@ Ember.State = Ember.Object.extend(Ember.Evented,
var Event = Ember.$ && Ember.$.Event;
-Ember.State.transitionTo = function(target) {
- var event = function(router, context) {
- if (Event && context instanceof Event) {
- context = context.context;
- }
+Ember.State.reopenClass({
+ ... | false |
Other | emberjs | ember.js | 7019de15f7f5e2183ea12ecbe2337bd7bc6c4f98.json | Remove unused variable and improve argument name | packages/ember-metal/lib/array.js | @@ -71,9 +71,6 @@ var arrayIndexOf = Ember.arrayIndexOf = isNativeFunc(Array.prototype.indexOf) ?
return -1;
};
-
-var slice = [].slice;
-
Ember.ArrayUtils = {
map: function(obj, callback, thisArg) {
return obj.map ? obj.map.call(obj, callback, thisArg) : arrayMap.call(obj, callback, thisArg);
@@ -87,8 +... | false |
Other | emberjs | ember.js | bde32ee1de36c01551c13a5669b16a6e9a98f4b8.json | Improve ArrayUtils by removing unnecessary slices | packages/ember-metal/lib/array.js | @@ -75,23 +75,20 @@ var arrayIndexOf = Ember.arrayIndexOf = isNativeFunc(Array.prototype.indexOf) ?
var slice = [].slice;
Ember.ArrayUtils = {
- map: function(obj) {
- var args = slice.call(arguments, 1);
- return obj.map ? obj.map.apply(obj, args) : arrayMap.apply(obj, args);
+ map: function(obj, callback,... | false |
Other | emberjs | ember.js | 871042a0d7083c9f5c5b6258fb0a84af814c34dd.json | Use evented system for dom events on views
Now we are using real events for all dom events on views. We check if
the callback is defined or if listeners are set. If you use callbacks,
you can return `false` in order to prevent default
In order to achive it goal, this commit adds `has` method to Evented
mixin. | packages/ember-handlebars/lib/controls/checkbox.js | @@ -48,9 +48,9 @@ Ember.Checkbox = Ember.View.extend({
checked: false,
disabled: false,
- change: function() {
- Ember.run.once(this, this._updateElementValue);
- // returning false will cause IE to not change checkbox state
+ init: function() {
+ this._super();
+ this.on("change", this, this._upd... | true |
Other | emberjs | ember.js | 871042a0d7083c9f5c5b6258fb0a84af814c34dd.json | Use evented system for dom events on views
Now we are using real events for all dom events on views. We check if
the callback is defined or if listeners are set. If you use callbacks,
you can return `false` in order to prevent default
In order to achive it goal, this commit adds `has` method to Evented
mixin. | packages/ember-handlebars/lib/controls/select.js | @@ -102,7 +102,7 @@ Ember.Select = Ember.View.extend(
*/
optionValuePath: 'content',
- change: function() {
+ _change: function() {
if (get(this, 'multiple')) {
this._changeMultiple();
} else {
@@ -146,7 +146,7 @@ Ember.Select = Ember.View.extend(
if (selection) { this.selectionDidChan... | true |
Other | emberjs | ember.js | 871042a0d7083c9f5c5b6258fb0a84af814c34dd.json | Use evented system for dom events on views
Now we are using real events for all dom events on views. We check if
the callback is defined or if listeners are set. If you use callbacks,
you can return `false` in order to prevent default
In order to achive it goal, this commit adds `has` method to Evented
mixin. | packages/ember-handlebars/lib/controls/text_support.js | @@ -23,16 +23,11 @@ Ember.TextSupport = Ember.Mixin.create(
insertNewline: Ember.K,
cancel: Ember.K,
- focusOut: function(event) {
- this._elementValueDidChange();
- },
-
- change: function(event) {
- this._elementValueDidChange();
- },
-
- keyUp: function(event) {
- this.interpretKeyEvents(event)... | true |
Other | emberjs | ember.js | 871042a0d7083c9f5c5b6258fb0a84af814c34dd.json | Use evented system for dom events on views
Now we are using real events for all dom events on views. We check if
the callback is defined or if listeners are set. If you use callbacks,
you can return `false` in order to prevent default
In order to achive it goal, this commit adds `has` method to Evented
mixin. | packages/ember-handlebars/tests/controls/text_area_test.js | @@ -147,7 +147,7 @@ test("should call the insertNewline method when return key is pressed", function
wasCalled = true;
};
- textArea.keyUp(event);
+ textArea.fire('keyUp', event);
ok(wasCalled, "invokes insertNewline method");
});
@@ -161,7 +161,7 @@ test("should call the cancel method when escape key... | true |
Other | emberjs | ember.js | 871042a0d7083c9f5c5b6258fb0a84af814c34dd.json | Use evented system for dom events on views
Now we are using real events for all dom events on views. We check if
the callback is defined or if listeners are set. If you use callbacks,
you can return `false` in order to prevent default
In order to achive it goal, this commit adds `has` method to Evented
mixin. | packages/ember-handlebars/tests/controls/text_field_test.js | @@ -143,7 +143,7 @@ test("should call the insertNewline method when return key is pressed", function
wasCalled = true;
};
- textField.keyUp(event);
+ textField.fire('keyUp', event);
ok(wasCalled, "invokes insertNewline method");
});
@@ -157,7 +157,7 @@ test("should call the cancel method when escape k... | true |
Other | emberjs | ember.js | 871042a0d7083c9f5c5b6258fb0a84af814c34dd.json | Use evented system for dom events on views
Now we are using real events for all dom events on views. We check if
the callback is defined or if listeners are set. If you use callbacks,
you can return `false` in order to prevent default
In order to achive it goal, this commit adds `has` method to Evented
mixin. | packages/ember-handlebars/tests/handlebars_test.js | @@ -1362,7 +1362,7 @@ test("should not reset cursor position when text field receives keyUp event", fu
view.$().setCaretPosition(5);
Ember.run(function() {
- view.keyUp({});
+ view.fire('keyUp', {});
});
equal(view.$().caretPosition(), 5, "The keyUp event should not result in the cursor being rese... | true |
Other | emberjs | ember.js | 871042a0d7083c9f5c5b6258fb0a84af814c34dd.json | Use evented system for dom events on views
Now we are using real events for all dom events on views. We check if
the callback is defined or if listeners are set. If you use callbacks,
you can return `false` in order to prevent default
In order to achive it goal, this commit adds `has` method to Evented
mixin. | packages/ember-runtime/lib/mixins/evented.js | @@ -22,5 +22,9 @@ Ember.Evented = Ember.Mixin.create({
off: function(name, target, method) {
Ember.removeListener(this, name, target, method);
+ },
+
+ has: function(name) {
+ return Ember.hasListeners(this, name);
}
}); | true |
Other | emberjs | ember.js | 871042a0d7083c9f5c5b6258fb0a84af814c34dd.json | Use evented system for dom events on views
Now we are using real events for all dom events on views. We check if
the callback is defined or if listeners are set. If you use callbacks,
you can return `false` in order to prevent default
In order to achive it goal, this commit adds `has` method to Evented
mixin. | packages/ember-views/lib/views/states/in_dom.js | @@ -43,7 +43,7 @@ Ember.View.states.HasElementState = Ember.State.extend({
// deferred to allow bindings to synchronize.
rerender: function(manager) {
var view = get(manager, 'view');
-
+
view._notifyWillRerender();
view.clearRenderedChildren();
@@ -58,15 +58,15 @@ Ember.View.states.HasElemen... | true |
Other | emberjs | ember.js | 871042a0d7083c9f5c5b6258fb0a84af814c34dd.json | Use evented system for dom events on views
Now we are using real events for all dom events on views. We check if
the callback is defined or if listeners are set. If you use callbacks,
you can return `false` in order to prevent default
In order to achive it goal, this commit adds `has` method to Evented
mixin. | packages/ember-views/lib/views/view.js | @@ -1859,10 +1859,14 @@ Ember.View = Ember.Object.extend(Ember.Evented,
also call methods with the given name.
*/
fire: function(name) {
+ this._super.apply(this, arguments);
if (this[name]) {
- this[name].apply(this, [].slice.call(arguments, 1));
+ return this[name].apply(this, [].slice.ca... | true |
Other | emberjs | ember.js | f2a3bd739e9e9ab9ef118599a9a215f766e0882b.json | Remove function names | packages/ember-metal/lib/accessors.js | @@ -26,7 +26,7 @@ var meta = Ember.meta;
var get, set;
/** @private */
-var basicGet = function get(obj, keyName) {
+var basicGet = function(obj, keyName) {
var meta = obj[META_KEY],
watching = meta && meta.watching[keyName],
ret;
@@ -59,7 +59,7 @@ if (!Ember.platform.hasPropertyAccessors) {
}
... | false |
Other | emberjs | ember.js | eb7a1ac16015c73cf152b61aad825e473aea1c00.json | Fix @each for changes in defineProperty | packages/ember-runtime/lib/system/each_proxy.js | @@ -105,7 +105,7 @@ Ember.EachProxy = Ember.Object.extend({
unknownProperty: function(keyName, value) {
var ret;
ret = new EachArray(this._content, keyName, this);
- new Ember.Descriptor().setup(this, keyName, ret);
+ Ember.defineProperty(this, keyName, null, ret);
this.beginObservingContentKey(... | false |
Other | emberjs | ember.js | 64ef59005be9902815005846e641a5253ff58c59.json | Fix required descriptor | packages/ember-metal/lib/mixin.js | @@ -117,6 +117,7 @@ function mergeMixins(mixins, m, descs, values, base) {
value = baseValue ? baseValue.concat(value) : Ember.makeArray(value);
}
+ descs[key] = undefined;
values[key] = value;
}
} | false |
Other | emberjs | ember.js | 7ed1ed7dd1f2bb00a350cb78e3d590167816cee7.json | Use a fresh meta to get the current value | packages/ember-metal/lib/watching.js | @@ -437,7 +437,7 @@ var switchToWatched = function(obj, keyName, meta) {
enumerable: true,
set: mandatorySetter,
get: function(key) {
- return meta.values[keyName];
+ return metaFor(this).values[keyName];
}
};
| false |
Other | emberjs | ember.js | 149fe898645e45e499b2b1acf31095b9c859599a.json | Fix one last alias case | packages/ember-metal/lib/mixin.js | @@ -226,7 +226,7 @@ function applyMixin(obj, mixins, partial) {
} else {
while (desc && desc instanceof Alias) {
var altKey = desc.methodName;
- if (descs[altKey]) {
+ if (descs[altKey] || values[altKey]) {
value = values[altKey];
desc = descs[altKey];
... | false |
Other | emberjs | ember.js | 76c313fc998b70328204d720a05892df81e4a423.json | Make a null desc work for defineProperty | packages/ember-metal/lib/properties.js | @@ -125,7 +125,7 @@ Ember.defineProperty = function(obj, keyName, desc, val) {
} else {
if (descs[keyName]) { metaFor(obj).descs[keyName] = null; }
- if (desc === undefined) {
+ if (desc == null) {
if (existingDesc) {
objectDefineProperty(obj, keyName, {
enumerable: true, | false |
Other | emberjs | ember.js | 49bd20f915892c3e6d002a4794eaacba7112b7e9.json | Remove references to SIMPLE_PROPERTY | packages/ember-metal/lib/mixin.js | @@ -103,7 +103,7 @@ function mergeMixins(mixins, m, descs, values, base) {
} else {
// impl super if needed...
if (isMethod(value)) {
- ovalue = descs[key] === Ember.SIMPLE_PROPERTY && values[key];
+ ovalue = descs[key] === undefined && values[key];
if (... | true |
Other | emberjs | ember.js | 49bd20f915892c3e6d002a4794eaacba7112b7e9.json | Remove references to SIMPLE_PROPERTY | packages/ember-metal/lib/properties.js | @@ -88,7 +88,7 @@ var extractValue = function(obj, keyName, watching) {
});
// define a simple property
- Ember.defineProperty(contact, 'lastName', Ember.SIMPLE_PROPERTY, 'Jolley');
+ Ember.defineProperty(contact, 'lastName', undefined, 'Jolley');
// define a computed property
... | true |
Other | emberjs | ember.js | 49bd20f915892c3e6d002a4794eaacba7112b7e9.json | Remove references to SIMPLE_PROPERTY | packages/ember-metal/lib/watching.js | @@ -17,7 +17,6 @@ var guidFor = Ember.guidFor,
get = Ember.get,
set = Ember.set,
normalizeTuple = Ember.normalizeTuple.primitive,
- SIMPLE_PROPERTY = Ember.SIMPLE_PROPERTY,
GUID_KEY = Ember.GUID_KEY,
META_KEY = Ember.META_KEY,
notifyObservers = Ember.notifyObservers, | true |
Other | emberjs | ember.js | 49bd20f915892c3e6d002a4794eaacba7112b7e9.json | Remove references to SIMPLE_PROPERTY | packages/ember-metal/tests/binding/connect_test.js | @@ -69,7 +69,7 @@ testBoth('Connecting a binding between two objects through property defined afte
performTest(binding, a, b, get, set, function () {
binding.connect(a);
- Ember.defineProperty(a, 'b', Ember.SIMPLE_PROPERTY, b);
+ Ember.defineProperty(a, 'b', undefined, b);
});
});
| true |
Other | emberjs | ember.js | 49bd20f915892c3e6d002a4794eaacba7112b7e9.json | Remove references to SIMPLE_PROPERTY | packages/ember-metal/tests/properties_test.js | @@ -9,6 +9,6 @@ module('Ember.defineProperty');
test('toString', function() {
var obj = {};
- Ember.defineProperty(obj, 'toString', Ember.SIMPLE_PROPERTY, function() { return 'FOO'; });
+ Ember.defineProperty(obj, 'toString', undefined, function() { return 'FOO'; });
equal(obj.toString(), 'FOO', 'should repl... | true |
Other | emberjs | ember.js | 49bd20f915892c3e6d002a4794eaacba7112b7e9.json | Remove references to SIMPLE_PROPERTY | packages/ember-metal/tests/watching/watch_test.js | @@ -95,7 +95,7 @@ test("watching a chain then defining the property", function () {
var foo = {bar: 'bar'};
Ember.watch(obj, 'foo.bar');
- Ember.defineProperty(obj, 'foo', Ember.SIMPLE_PROPERTY, foo);
+ Ember.defineProperty(obj, 'foo', undefined, foo);
Ember.set(foo, 'bar', 'baz');
deepEqual(willKeys,... | true |
Other | emberjs | ember.js | 664c34812b4f31b84dc67e186741b60813f6926e.json | Fix action tests for IE | packages/ember-application/tests/system/action_url_test.js | @@ -58,7 +58,7 @@ test("it does not generate the URL when href property is not specified", functio
ok(!view.$().html().match(/href=['"]\/foo\/bar['"]/), "The html (" + view.$().html() + ") has the href /foo/bar in it");
});
-test("it sets a URL with a context", function() {
+test("it sets an URL with a context", ... | false |
Other | emberjs | ember.js | 6155d7898eed50cc7bc88fe9b6d06d73c5981411.json | Fix unsupported method errors in older browsers | packages/ember-application/lib/system/hash_location.js | @@ -52,7 +52,11 @@ Ember.HashLocation = Ember.Object.extend({
};
get(this, 'callbacks').pushObject(hashchange);
- window.addEventListener('hashchange', hashchange);
+
+ // This won't work on old browsers anyway, but this check prevents errors
+ if (window.addEventListener) {
+ window.addEventL... | true |
Other | emberjs | ember.js | 6155d7898eed50cc7bc88fe9b6d06d73c5981411.json | Fix unsupported method errors in older browsers | packages/ember-application/lib/system/history_location.js | @@ -49,7 +49,11 @@ Ember.HistoryLocation = Ember.Object.extend({
};
get(this, 'callbacks').pushObject(popstate);
- window.addEventListener('popstate', popstate);
+
+ // This won't work on old browsers anyway, but this check prevents errors
+ if (window.addEventListener) {
+ window.addEventList... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.