language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | 6155d7898eed50cc7bc88fe9b6d06d73c5981411.json | Fix unsupported method errors in older browsers | packages/ember-runtime/lib/mixins/sortable.js | @@ -108,7 +108,7 @@ Ember.SortableMixin = Ember.Mixin.create(Ember.MutableEnumerable, {
var removedObjects = array.slice(idx, idx+removedCount);
var sortProperties = get(this, 'sortProperties');
- removedObjects.forEach(function(item) {
+ forEach(removedObjects, function(item) {
arran... | true |
Other | emberjs | ember.js | 6155d7898eed50cc7bc88fe9b6d06d73c5981411.json | Fix unsupported method errors in older browsers | packages/ember-states/lib/state_manager.js | @@ -1,4 +1,5 @@
var get = Ember.get, set = Ember.set, getPath = Ember.getPath, fmt = Ember.String.fmt;
+var arrayForEach = Ember.ArrayUtils.forEach;
require('ember-states/state');
@@ -602,7 +603,7 @@ Ember.StateManager = Ember.State.extend(
triggerSetupContext: function(root, segments) {
var state = root;... | true |
Other | emberjs | ember.js | a065d17ff04fc25e90927c3134a2a28cf32bbcfe.json | Remove unused variable | packages/ember-metal/lib/properties.js | @@ -13,7 +13,6 @@ var USE_ACCESSORS = Ember.USE_ACCESSORS,
GUID_KEY = Ember.GUID_KEY,
META_KEY = Ember.META_KEY,
meta = Ember.meta,
- o_create = Ember.create,
objectDefineProperty = Ember.platform.defineProperty,
SIMPLE_PROPERTY, WATCHED_PROPERTY;
| false |
Other | emberjs | ember.js | 25b38af12370c8be97cb75d19cb244ebaee0df85.json | Add Handlebars to benchmark runner | benchmarks/runner.js | @@ -15,6 +15,7 @@ function makeiframe(emberPath, suitePath, profile, callback) {
write("<title>" + name + "</title>");
write("<script src='../lib/jquery-1.7.2.js'></script>");
write("<script>ENV = {VIEW_PRESERVES_CONTEXT: true};</script>");
+ write("<script src='../lib/handlebars-1.0.0.beta.6.js'></script>");... | false |
Other | emberjs | ember.js | b2188911dafa60dabb6ba534acc5e044821a1bf5.json | Update each view benchmark | benchmarks/runner.js | @@ -14,6 +14,7 @@ function makeiframe(emberPath, suitePath, profile, callback) {
write("<title>" + name + "</title>");
write("<script src='../lib/jquery-1.7.2.js'></script>");
+ write("<script>ENV = {VIEW_PRESERVES_CONTEXT: true};</script>");
write("<script src='" + emberPath + "'></script>");
write("<sc... | true |
Other | emberjs | ember.js | b2188911dafa60dabb6ba534acc5e044821a1bf5.json | Update each view benchmark | benchmarks/suites/views/each_view.js | @@ -18,12 +18,12 @@ before(function() {
" </thead>" +
" <tbody>" +
" {{#each App.list}}" +
- ' {{#view Em.View contentBinding="this" tagName="tr"}}' +
- " <td>{{content.id}}</td>" +
- " <td>{{content.dateIn}}</td>" +
- " <td>{{content.tag}}</td>" +
- " ... | true |
Other | emberjs | ember.js | 4f63e8d127ccbb2bda86a5cba7726218961097f6.json | Add options hash syntax to connectOutlet.
Also, if you explicitly set the `controller`
of the options hash to `null`, it will not set
a controller on the view, and it will be
inherited from the parent view. | packages/ember-views/lib/system/controller.js | @@ -75,15 +75,34 @@ Ember.ControllerMixin.reopen({
// outletName, viewClass
// viewClass, context
// outletName, viewClass, context
+ //
+ // Alternatively, an options hash may be passed:
+ //
+ // {
+ // name: 'outletName',
+ // view: App.ViewClass,
+ // context: {}
+ /... | true |
Other | emberjs | ember.js | 4f63e8d127ccbb2bda86a5cba7726218961097f6.json | Add options hash syntax to connectOutlet.
Also, if you explicitly set the `controller`
of the options hash to `null`, it will not set
a controller on the view, and it will be
inherited from the parent view. | packages/ember-views/tests/system/controller_test.js | @@ -10,7 +10,7 @@ module("Ember.Controller#connectOutlet", {
TestApp.ApplicationController = Ember.Controller.extend();
TestApp.PostController = Ember.Controller.extend();
- TestApp.PostView = Ember.Controller.extend();
+ TestApp.PostView = Ember.View.extend();
},
teardown: function() {
@@ -77... | true |
Other | emberjs | ember.js | 7049d29b8abab8f72117e6b99739cda97f7d59fb.json | Fix Ember.setPath when used on Ember.Namespaces | packages/ember-metal/lib/accessors.js | @@ -248,7 +248,7 @@ Ember.getPath = function(root, path) {
Ember.setPath = function(root, path, value, tolerant) {
var keyName;
- if (IS_GLOBAL.test(root)) {
+ if (typeof root === 'string' && IS_GLOBAL.test(root)) {
value = path;
path = root;
root = null; | true |
Other | emberjs | ember.js | 7049d29b8abab8f72117e6b99739cda97f7d59fb.json | Fix Ember.setPath when used on Ember.Namespaces | packages/ember-metal/tests/accessors/setPath_test.js | @@ -38,6 +38,13 @@ var obj, moduleOpts = {
module('Ember.setPath', moduleOpts);
+test('[Foo, bar] -> Foo.bar', function() {
+ window.Foo = {toString: function() { return 'Foo'; }}; // Behave like an Ember.Namespace
+ Ember.setPath(Foo, 'bar', 'baz');
+ equal(Ember.getPath(Foo, 'bar'), 'baz');
+ delete window.F... | true |
Other | emberjs | ember.js | 2ae680f7fc4ccb16478811c91d2eefabaa89b18e.json | Remove async transition docs. | packages/ember-states/lib/state.js | @@ -147,9 +147,6 @@ Ember.State = Ember.Object.extend(Ember.Evented,
@event
@param {Ember.StateManager} manager
- @param {Object} transition
- @param {Function} transition.async
- @param {Function} transition.resume
*/
enter: Ember.K,
@@ -158,9 +155,6 @@ Ember.State = Ember.Object.extend(Em... | true |
Other | emberjs | ember.js | 2ae680f7fc4ccb16478811c91d2eefabaa89b18e.json | Remove async transition docs. | packages/ember-states/lib/state_manager.js | @@ -101,12 +101,12 @@ require('ember-states/state');
robotManager = Ember.StateManager.create({
initialState: 'poweredDown',
poweredDown: Ember.State.create({
- exit: function(stateManager, transition){
+ exit: function(stateManager){
console.log("exiting the powe... | true |
Other | emberjs | ember.js | 2ae680f7fc4ccb16478811c91d2eefabaa89b18e.json | Remove async transition docs. | packages/ember-viewstates/lib/view_state.js | @@ -137,10 +137,10 @@ var get = Ember.get, set = Ember.set;
viewStates = Ember.StateManager.create({
aState: Ember.ViewState.create({
view: Ember.View.extend({}),
- enter: function(manager, transition){
+ enter: function(manager){
// calling _super ensures this ... | true |
Other | emberjs | ember.js | b5ff0edb41f50e1f55446c14605fb566aa419ed4.json | Remove async transitions.
We suggest using transitional states instead. | packages/ember-states/lib/state_manager.js | @@ -350,24 +350,6 @@ require('ember-states/state');
robotManager.send('beginExtermination', allHumans)
robotManager.getPath('currentState.name') // 'rampaging'
- ## Async transitions
- When a state's `enter` and `exit` methods are called they passed a argument representing
- the transition. By callin... | true |
Other | emberjs | ember.js | b5ff0edb41f50e1f55446c14605fb566aa419ed4.json | Remove async transitions.
We suggest using transitional states instead. | packages/ember-states/tests/state_manager_test.js | @@ -105,44 +105,6 @@ test("it sends enter and exit events during state transitions", function() {
equal(loadedState.exited, 1, "sibling state should receive one exit event");
});
-test("a transition can be asynchronous", function() {
- expect(1);
-
- var counter = 0;
- var stateManager = Ember.StateManager.cre... | true |
Other | emberjs | ember.js | b26ae897b4f8465171582807232f8113f458ecd6.json | Enumerate all properties per injection. | packages/ember-application/lib/system/application.js | @@ -125,8 +125,8 @@ Ember.Application = Ember.Namespace.extend(
Ember.runLoadHooks('application', this);
- properties.forEach(function(property) {
- injections.forEach(function(injection) {
+ injections.forEach(function(injection) {
+ properties.forEach(function(property) {
injection[1... | true |
Other | emberjs | ember.js | b26ae897b4f8465171582807232f8113f458ecd6.json | Enumerate all properties per injection. | packages/ember-application/tests/system/application_test.js | @@ -205,22 +205,25 @@ test("initialize application with stateManager via initialize call from Router c
});
test("injections can be registered in a specified order", function() {
+
var oldInjections = Ember.Application.injections;
- var firstInjectionCalled;
+ var firstInjectionCalled = 0,
+ secondInjectio... | true |
Other | emberjs | ember.js | 627d214428191b7bcd2a8ad23aa5d048d9e6734c.json | Improve invalidation of view's controller prop
A view's controller is inherited from its parent
unless specifically overridden. This commit
improves the invalidation of the cached
computed property when:
a) the parent view changes, or
b) the controller of the parent changes. | packages/ember-views/lib/views/view.js | @@ -501,7 +501,6 @@ Ember.View = Ember.Object.extend(Ember.Evented,
return value;
} else {
parentView = get(this, 'parentView');
-
return parentView ? get(parentView, 'controller') : null;
}
}).property().cacheable(),
@@ -756,8 +755,20 @@ Ember.View = Ember.Object.extend(Ember.Evented,... | true |
Other | emberjs | ember.js | 627d214428191b7bcd2a8ad23aa5d048d9e6734c.json | Improve invalidation of view's controller prop
A view's controller is inherited from its parent
unless specifically overridden. This commit
improves the invalidation of the cached
computed property when:
a) the parent view changes, or
b) the controller of the parent changes. | packages/ember-views/tests/views/view/controller_test.js | @@ -0,0 +1,33 @@
+module("Ember.View - controller property");
+
+test("controller property should be inherited from nearest ancestor with controller", function() {
+ var grandparent = Ember.ContainerView.create();
+ var parent = Ember.ContainerView.create();
+ var child = Ember.ContainerView.create();
+ var grandch... | true |
Other | emberjs | ember.js | 96791e2173b12b5730d1840b5946d09a5558da8a.json | Fix failing test | packages/ember-handlebars/tests/helpers/with_test.js | @@ -82,21 +82,22 @@ test("it should support #with Foo.bar as qux", function() {
equal(view.$().text(), "updated", "should update");
});
-module("Handlebars {{#with this as foo}}");
+if (Ember.VIEW_PRESERVES_CONTEXT) {
+ module("Handlebars {{#with this as foo}}");
-test("it should support #with this as qux", fu... | false |
Other | emberjs | ember.js | 7a65598b71b66bf430d5f9937e8e1d80089ae449.json | Fix documentation for adding view to ContainerView
View B will still exist in container view after pushObject. | packages/ember-views/lib/views/container_view.js | @@ -122,12 +122,13 @@ var childViewsProperty = Ember.computed(function() {
aContainer.get('childViews') // [aContainer.aView, aContainer.bView]
aContainer.get('childViews').pushObject(AnotherViewClass.create())
- aContainer.get('childViews') // [aContainer.aView, <AnotherViewClass instance>]
... | false |
Other | emberjs | ember.js | 9ef59af7269fdea81be06eb51fbf2e640a39e67c.json | Use accessors for eventTransitions | packages/ember-states/lib/state.js | @@ -55,7 +55,7 @@ Ember.State = Ember.Object.extend(Ember.Evented,
init: function() {
var states = get(this, 'states'), foundStates;
set(this, 'childStates', Ember.A());
- this.eventTransitions = this.eventTransitions || {};
+ set(this, 'eventTransitions', get(this, 'eventTransitions') || {});
... | false |
Other | emberjs | ember.js | 136455596cd02a2b543732f620302cbfd7ee3117.json | Finish implementation of Sortable mixin
This borrows heavily from tchak's implementation
;) | packages/ember-runtime/lib/mixins/sortable.js | @@ -1,79 +1,180 @@
-var get = Ember.get;
+var get = Ember.get, set = Ember.set, forEach = Ember.ArrayUtils.forEach;
-Ember.SortableMixin = Ember.Mixin.create({
- arrangedContent: Ember.computed('content', 'orderBy', function(key, value) {
+Ember.SortableMixin = Ember.Mixin.create(Ember.MutableEnumerable, {
+ sortPr... | false |
Other | emberjs | ember.js | a2ec6252434c16599407ac91311611b8ee7a1e4f.json | Remove trailing whitespace | lib/github_uploader.rb | @@ -16,7 +16,7 @@ def authorized?
end
def token_path
- File.expand_path(".github-upload-token", @root)
+ File.expand_path(".github-upload-token", @root)
end
def check_token | false |
Other | emberjs | ember.js | d6ee63b3af87e10b56d88c28ed82a1f64f58cd56.json | Remove unused code. | packages/ember-handlebars/tests/views/collection_view_test.js | @@ -105,7 +105,6 @@ test("should be able to specify which class should be used for the empty view",
window.App = Ember.Application.create();
});
- App.ListView = Ember.CollectionView.extend();
App.EmptyView = Ember.View.extend({
template: Ember.Handlebars.compile('This is an empty view')
}); | false |
Other | emberjs | ember.js | 96768564fcd17e36d367a79e9f2eca076a4d37eb.json | Support #each foo in this and #with this as bar | packages/ember-handlebars/lib/helpers/binding.js | @@ -174,7 +174,10 @@ EmberHandlebars.registerHelper('with', function(context, options) {
// together. When we implement that functionality, we should use it here.
var contextKey = Ember.$.expando + Ember.guidFor(this);
options.data.keywords[contextKey] = this;
- Ember.bind(options.data.keyword... | true |
Other | emberjs | ember.js | 96768564fcd17e36d367a79e9f2eca076a4d37eb.json | Support #each foo in this and #with this as bar | packages/ember-handlebars/lib/helpers/each.js | @@ -42,6 +42,7 @@ Ember.Handlebars.registerHelper('each', function(path, options) {
options = arguments[3];
path = arguments[2];
+ if (path === '') { path = "this"; }
options.hash.keyword = keywordName;
} else { | true |
Other | emberjs | ember.js | 96768564fcd17e36d367a79e9f2eca076a4d37eb.json | Support #each foo in this and #with this as bar | packages/ember-handlebars/tests/helpers/each_test.js | @@ -179,4 +179,16 @@ if (Ember.VIEW_PRESERVES_CONTEXT) {
equal(view.$().text(), "My Cool Each Test 1My Cool Each Test 2");
});
+ test("#each accepts 'this' as the right hand side", function() {
+ view = Ember.View.create({
+ template: templateFor("{{#each item in this}}{{view.title}} {{item.name}}{{/... | true |
Other | emberjs | ember.js | 96768564fcd17e36d367a79e9f2eca076a4d37eb.json | Support #each foo in this and #with this as bar | packages/ember-handlebars/tests/helpers/with_test.js | @@ -81,3 +81,22 @@ test("it should support #with Foo.bar as qux", function() {
equal(view.$().text(), "updated", "should update");
});
+
+module("Handlebars {{#with this as foo}}");
+
+test("it should support #with this as qux", function() {
+ var view = Ember.View.create({
+ template: Ember.Handlebars.compil... | true |
Other | emberjs | ember.js | 03c94f8278d8cbdb6621051f2ac2e9f61e2eb36f.json | Replace occurances of goToState with transitionTo. | packages/ember-states/lib/state_manager.js | @@ -149,7 +149,7 @@ require('ember-states/state');
Each state property may itself contain properties that are instances of Ember.State.
- The StateManager can transition to specific sub-states in a series of goToState method calls or
+ The StateManager can transition to specific sub-states in a series of trans... | true |
Other | emberjs | ember.js | 03c94f8278d8cbdb6621051f2ac2e9f61e2eb36f.json | Replace occurances of goToState with transitionTo. | packages/ember-states/tests/routable_test.js | @@ -18,7 +18,7 @@ test("it should have its updateRoute method called when it is entered", function
location: locationStub,
root: Ember.State.create({
ready: function(manager) {
- manager.goToState('initial');
+ manager.transitionTo('initial');
},
initial: state
@@ -41,7 +4... | true |
Other | emberjs | ember.js | 03c94f8278d8cbdb6621051f2ac2e9f61e2eb36f.json | Replace occurances of goToState with transitionTo. | packages/ember-states/tests/state_manager_test.js | @@ -70,15 +70,15 @@ test("it discovers states that are properties of the state manager", function()
test("it reports its current state", function() {
ok(get(stateManager, 'currentState') === null, "currentState defaults to null if no state is specified");
- stateManager.goToState('loadingState');
- ok(get(state... | true |
Other | emberjs | ember.js | 03c94f8278d8cbdb6621051f2ac2e9f61e2eb36f.json | Replace occurances of goToState with transitionTo. | packages/ember-states/tests/state_test.js | @@ -133,10 +133,10 @@ test("states set up proper names on their children", function() {
}
});
- manager.goToState('first');
+ manager.transitionTo('first');
equal(getPath(manager, 'currentState.path'), 'first');
- manager.goToState('first.insideFirst');
+ manager.transitionTo('first.insideFirst');
... | true |
Other | emberjs | ember.js | 03c94f8278d8cbdb6621051f2ac2e9f61e2eb36f.json | Replace occurances of goToState with transitionTo. | packages/ember-viewstates/lib/view_state.js | @@ -61,7 +61,7 @@ var get = Ember.get, set = Ember.set;
})
})
- viewStates.goToState('showingPeople')
+ viewStates.transitionTo('showingPeople')
The above code will change the rendered HTML from
@@ -75,10 +75,10 @@ var get = Ember.get, set = Ember.set;
</div>
</body>
... | true |
Other | emberjs | ember.js | 03c94f8278d8cbdb6621051f2ac2e9f61e2eb36f.json | Replace occurances of goToState with transitionTo. | packages/ember-viewstates/tests/view_state_test.js | @@ -87,7 +87,7 @@ test("it appends and removes a view when it is entered and exited", function() {
equal(Ember.$('#test-view').length, 1, "found view with custom id in DOM");
Ember.run(function() {
- stateManager.goToState('other');
+ stateManager.transitionTo('other');
});
equal(Ember.$('#test-vi... | true |
Other | emberjs | ember.js | b6c1c2fffa2e535da8e1eb7babaa6119ff58b731.json | Use Ember.assert instead of throw | packages/ember-metal/lib/mixin.js | @@ -76,7 +76,7 @@ function mergeMixins(mixins, m, descs, values, base) {
for(idx=0;idx<len;idx++) {
mixin = mixins[idx];
- if (!mixin) throw new Error('Null value found in Ember.mixin()');
+ Ember.assert('Null value found in Ember.mixin()', !!mixin);
if (mixin instanceof Mixin) {
guid = Em... | false |
Other | emberjs | ember.js | c5e39622b5799d03b5ae8e7a73415e1210d920eb.json | Remove unused local variables | packages/ember-metal/lib/computed.js | @@ -127,7 +127,7 @@ function mkCpSetter(keyName, desc) {
return function(value) {
var m = meta(this, cacheable),
watched = (m.source===this) && m.watching[keyName]>0,
- ret, oldSuspended, lastSetValues;
+ ret, oldSuspended;
oldSuspended = desc._suspended;
desc._suspended = thi... | false |
Other | emberjs | ember.js | 7d15e7d99cab555bf6c86d56b6bb30f5c57280e7.json | Remove unused argument to oneWay | packages/ember-metal/lib/binding.js | @@ -106,13 +106,9 @@ Binding.prototype = /** @scope Ember.Binding.prototype */ {
means that if you change the "to" side directly, the "from" side may have
a different value.
- @param {Boolean} flag
- (Optional) passing nothing here will make the binding oneWay. You can
- instead pass false to ... | false |
Other | emberjs | ember.js | 705638d9f9fdf59d4f43121ba8e1a0fd65fe53ba.json | Remove unnecessary variant of create | Rakefile | @@ -116,6 +116,7 @@ task :test, [:suite] => :dist do |t, args|
suites = {
:default => packages.map{|p| "package=#{p}" },
+ :runtime => [ "package=ember-metal,ember-runtime" ],
# testing older jQuery 1.6.4 for compatibility
:all => packages.map{|p| "package=#{p}" } +
["package=all&jqu... | true |
Other | emberjs | ember.js | 705638d9f9fdf59d4f43121ba8e1a0fd65fe53ba.json | Remove unnecessary variant of create | packages/ember-handlebars/lib/ext.js | @@ -7,6 +7,8 @@
require("ember-views/system/render_buffer");
+var objectCreate = Ember.create;
+
/**
@namespace
@name Handlebars
@@ -34,19 +36,19 @@ Ember.assert("Ember Handlebars requires Handlebars 1.0.beta.5 or greater", windo
To create an Ember.Handlebars template, call Ember.Handlebars.compile(). T... | true |
Other | emberjs | ember.js | 705638d9f9fdf59d4f43121ba8e1a0fd65fe53ba.json | Remove unnecessary variant of create | packages/ember-metal/lib/computed.js | @@ -17,7 +17,7 @@ var meta = Ember.meta;
var guidFor = Ember.guidFor;
var USE_ACCESSORS = Ember.USE_ACCESSORS;
var a_slice = Array.prototype.slice;
-var o_create = Ember.platform.create;
+var o_create = Ember.create;
var o_defineProperty = Ember.platform.defineProperty;
// .......................................... | true |
Other | emberjs | ember.js | 705638d9f9fdf59d4f43121ba8e1a0fd65fe53ba.json | Remove unnecessary variant of create | packages/ember-metal/lib/events.js | @@ -8,7 +8,7 @@ require('ember-metal/core');
require('ember-metal/platform');
require('ember-metal/utils');
-var o_create = Ember.platform.create;
+var o_create = Ember.create;
var meta = Ember.meta;
var guidFor = Ember.guidFor;
var a_slice = Array.prototype.slice;
@@ -261,4 +261,4 @@ Ember.sendEvent = sendEvent... | true |
Other | emberjs | ember.js | 705638d9f9fdf59d4f43121ba8e1a0fd65fe53ba.json | Remove unnecessary variant of create | packages/ember-metal/lib/mixin.js | @@ -23,7 +23,7 @@ var a_slice = Array.prototype.slice;
var EMPTY_META = {}; // dummy for non-writable meta
var META_SKIP = { __emberproto__: true, __ember_count__: true };
-var o_create = Ember.platform.create;
+var o_create = Ember.create;
/** @private */
function meta(obj, writable) { | true |
Other | emberjs | ember.js | 705638d9f9fdf59d4f43121ba8e1a0fd65fe53ba.json | Remove unnecessary variant of create | packages/ember-metal/lib/platform.js | @@ -21,29 +21,21 @@ var platform = Ember.platform = {} ;
@memberOf Ember.platform
@name create
*/
-platform.create = Object.create;
+Ember.create = Object.create;
-if (!platform.create) {
+if (!Ember.create) {
/** @private */
- var O_ctor = function() {},
- O_proto = O_ctor.prototype;
-
- platform.cr... | true |
Other | emberjs | ember.js | 705638d9f9fdf59d4f43121ba8e1a0fd65fe53ba.json | Remove unnecessary variant of create | packages/ember-metal/lib/properties.js | @@ -13,7 +13,7 @@ var USE_ACCESSORS = Ember.USE_ACCESSORS;
var GUID_KEY = Ember.GUID_KEY;
var META_KEY = Ember.META_KEY;
var meta = Ember.meta;
-var o_create = Ember.platform.create;
+var o_create = Ember.create;
var objectDefineProperty = Ember.platform.defineProperty;
var SIMPLE_PROPERTY, WATCHED_PROPERTY;
@@ ... | true |
Other | emberjs | ember.js | 705638d9f9fdf59d4f43121ba8e1a0fd65fe53ba.json | Remove unnecessary variant of create | packages/ember-metal/lib/utils.js | @@ -20,7 +20,7 @@ numberCache = [];
stringCache = {};
var o_defineProperty = Ember.platform.defineProperty;
-var o_create = Ember.platform.create;
+var o_create = Ember.create;
/**
@private | true |
Other | emberjs | ember.js | 705638d9f9fdf59d4f43121ba8e1a0fd65fe53ba.json | Remove unnecessary variant of create | packages/ember-metal/tests/binding/connect_test.js | @@ -138,6 +138,7 @@ testBoth('Bindings should be inherited', function(get, set) {
binding.connect(a);
a2 = Ember.create(a);
+ Ember.rewatch(a2);
});
equal(get(a2, 'foo'), "BAR", "Should have synced binding on child"); | true |
Other | emberjs | ember.js | 705638d9f9fdf59d4f43121ba8e1a0fd65fe53ba.json | Remove unnecessary variant of create | packages/ember-metal/tests/binding/sync_test.js | @@ -112,6 +112,8 @@ testBoth("bindings should do the right thing when binding is in prototype", func
a = Ember.create(proto);
b = Ember.create(proto);
+ Ember.rewatch(a);
+ Ember.rewatch(b);
});
Ember.run(function () { | true |
Other | emberjs | ember.js | 705638d9f9fdf59d4f43121ba8e1a0fd65fe53ba.json | Remove unnecessary variant of create | packages/ember-metal/tests/platform/create_test.js | @@ -4,11 +4,11 @@
// License: Licensed under MIT license (see license.js)
// ==========================================================================
-module("Ember.platform.create()");
+module("Ember.create()");
test("should inherit the properties from the parent object", function() {
var obj = { foo: 'F... | true |
Other | emberjs | ember.js | 705638d9f9fdf59d4f43121ba8e1a0fd65fe53ba.json | Remove unnecessary variant of create | packages/ember-runtime/lib/system/core_object.js | @@ -14,7 +14,7 @@
var rewatch = Ember.rewatch;
var classToString = Ember.Mixin.prototype.toString;
var set = Ember.set, get = Ember.get;
-var o_create = Ember.platform.create,
+var o_create = Ember.create,
o_defineProperty = Ember.platform.defineProperty,
a_slice = Array.prototype.slice,
meta = Ember.... | true |
Other | emberjs | ember.js | 58580a70282b78d24b78c7fc39d86cd90565c41e.json | Unify some of the getter/no-getter logic | packages/ember-metal/lib/platform.js | @@ -46,6 +46,7 @@ if (!platform.create) {
platform.create.isSimulated = true;
}
+Object.defineProperty = null;
/** @private */
var defineProperty = Object.defineProperty;
var canRedefineProperties, canDefinePropertyOnDOM;
@@ -145,8 +146,7 @@ if (!platform.defineProperty) {
platform.hasPropertyAccessors = fa... | true |
Other | emberjs | ember.js | 58580a70282b78d24b78c7fc39d86cd90565c41e.json | Unify some of the getter/no-getter logic | packages/ember-metal/lib/properties.js | @@ -14,7 +14,7 @@ var GUID_KEY = Ember.GUID_KEY;
var META_KEY = Ember.META_KEY;
var meta = Ember.meta;
var o_create = Ember.platform.create;
-var o_defineProperty = Ember.platform.defineProperty;
+var objectDefineProperty = Ember.platform.defineProperty;
var SIMPLE_PROPERTY, WATCHED_PROPERTY;
// ................... | true |
Other | emberjs | ember.js | 58580a70282b78d24b78c7fc39d86cd90565c41e.json | Unify some of the getter/no-getter logic | packages/ember-metal/tests/performance_test.js | @@ -62,7 +62,7 @@ test("computed properties are not executed if they are the last segment of an ob
Ember.addObserver(foo, 'bar.baz.bam', function() {});
- Ember.propertyDidChange(foo.bar.baz, 'bam');
+ Ember.propertyDidChange(Ember.getPath(foo, 'bar.baz'), 'bam');
equal(count, 0, "should not have recomput... | true |
Other | emberjs | ember.js | 58580a70282b78d24b78c7fc39d86cd90565c41e.json | Unify some of the getter/no-getter logic | packages/ember-metal/tests/platform/defineProperty_test.js | @@ -63,52 +63,52 @@ test('defining a non enumerable property', function() {
}
});
-test('defining a getter/setter', function() {
- var obj = {}, getCnt = 0, setCnt = 0, v = 'FOO';
+// If accessors don't exist, behavior that relies on getters
+// and setters don't do anything
+if (Ember.platform.hasPropertyAccess... | true |
Other | emberjs | ember.js | ad85ad9b04c4b65496e221af1ee234605904df32.json | Add rake test per package | Rakefile | @@ -128,6 +128,10 @@ task :test, [:suite] => :dist do |t, args|
"package=all&dist=build&nojshint=true"]
}
+ packages.each do |package|
+ suites[package.to_sym] = ["package=#{package}"]
+ end
+
if ENV['TEST']
opts = [ENV['TEST']]
else | false |
Other | emberjs | ember.js | ff17ce1e9ccb3b611f78a0e3dd212cd10b46a710.json | Move the binding system to Ember.Map | packages/ember-metal/lib/binding.js | @@ -9,6 +9,7 @@ require('ember-metal/accessors'); // get, getPath, setPath, trySetPath
require('ember-metal/utils'); // guidFor, isArray, meta
require('ember-metal/observer'); // addObserver, removeObserver
require('ember-metal/run_loop'); // Ember.run.schedule
+require('ember-metal/map');
// ....................... | true |
Other | emberjs | ember.js | ff17ce1e9ccb3b611f78a0e3dd212cd10b46a710.json | Move the binding system to Ember.Map | packages/ember-metal/lib/main.js | @@ -5,6 +5,7 @@
// ==========================================================================
require('ember-metal/core');
+require('ember-metal/map');
require('ember-metal/platform');
require('ember-metal/utils');
require('ember-metal/accessors'); | true |
Other | emberjs | ember.js | ff17ce1e9ccb3b611f78a0e3dd212cd10b46a710.json | Move the binding system to Ember.Map | packages/ember-runtime/lib/system.js | @@ -15,6 +15,5 @@ require('ember-runtime/system/native_array');
require('ember-runtime/system/object');
require('ember-runtime/system/set');
require('ember-runtime/system/string');
-require('ember-runtime/system/map');
require('ember-runtime/system/lazy_load'); | true |
Other | emberjs | ember.js | ff17ce1e9ccb3b611f78a0e3dd212cd10b46a710.json | Move the binding system to Ember.Map | packages/ember-runtime/lib/system/map.js | @@ -1,197 +0,0 @@
-/**
- JavaScript (before ES6) does not have a Map implementation. Objects,
- which are often used as dictionaries, may only have Strings as keys.
-
- Because Ember has a way to get a unique identifier for every object
- via `Ember.guidFor`, we can implement a performant Map with arbitrary
- keys... | true |
Other | emberjs | ember.js | 7ae011753e595086287f06733028b260e0526847.json | Remove binding transforms
I'm willing to bring them back if there is a
very compelling use-case vs. computed properties. | .jshintrc | @@ -48,5 +48,6 @@
"undef": true,
"sub": true,
"strict": false,
- "white": false
+ "white": false,
+ "eqnull": true
} | true |
Other | emberjs | ember.js | 7ae011753e595086287f06733028b260e0526847.json | Remove binding transforms
I'm willing to bring them back if there is a
very compelling use-case vs. computed properties. | packages/ember-metal/lib/binding.js | @@ -27,111 +27,18 @@ require('ember-metal/run_loop'); // Ember.run.schedule
*/
Ember.LOG_BINDINGS = false || !!Ember.ENV.LOG_BINDINGS;
-// ..........................................................
-// TYPE COERCION HELPERS
-//
-
-// Coerces a non-array value into an array.
-/** @private */
-function MULTIPLE(val) ... | true |
Other | emberjs | ember.js | 7ae011753e595086287f06733028b260e0526847.json | Remove binding transforms
I'm willing to bring them back if there is a
very compelling use-case vs. computed properties. | packages/ember-metal/tests/binding/and_test.js | @@ -1,58 +0,0 @@
-// ==========================================================================
-// Project: Ember Runtime
-// Copyright: ©2011 Strobe Inc. and contributors.
-// License: Licensed under MIT license (see license.js)
-// ==========================================================================
-
-var ... | true |
Other | emberjs | ember.js | 7ae011753e595086287f06733028b260e0526847.json | Remove binding transforms
I'm willing to bring them back if there is a
very compelling use-case vs. computed properties. | packages/ember-metal/tests/binding/bool_not_test.js | @@ -1,79 +0,0 @@
-// ==========================================================================
-// Project: Ember Runtime
-// Copyright: ©2011 Strobe Inc. and contributors.
-// License: Licensed under MIT license (see license.js)
-// ==========================================================================
-/*glob... | true |
Other | emberjs | ember.js | 7ae011753e595086287f06733028b260e0526847.json | Remove binding transforms
I'm willing to bring them back if there is a
very compelling use-case vs. computed properties. | packages/ember-metal/tests/binding/multiple_test.js | @@ -1,49 +0,0 @@
-// ==========================================================================
-// Project: Ember Runtime
-// Copyright: ©2011 Strobe Inc. and contributors.
-// License: Licensed under MIT license (see license.js)
-// ==========================================================================
-/*glob... | true |
Other | emberjs | ember.js | 7ae011753e595086287f06733028b260e0526847.json | Remove binding transforms
I'm willing to bring them back if there is a
very compelling use-case vs. computed properties. | packages/ember-metal/tests/binding/notEmpty_test.js | @@ -1,41 +0,0 @@
-// ==========================================================================
-// Project: Ember Runtime
-// Copyright: ©2011 Strobe Inc. and contributors.
-// License: Licensed under MIT license (see license.js)
-// ==========================================================================
-/*glob... | true |
Other | emberjs | ember.js | 7ae011753e595086287f06733028b260e0526847.json | Remove binding transforms
I'm willing to bring them back if there is a
very compelling use-case vs. computed properties. | packages/ember-metal/tests/binding/notNull_test.js | @@ -1,36 +0,0 @@
-// ==========================================================================
-// Project: Ember Runtime
-// Copyright: ©2011 Strobe Inc. and contributors.
-// License: Licensed under MIT license (see license.js)
-// ==========================================================================
-/*glob... | true |
Other | emberjs | ember.js | 7ae011753e595086287f06733028b260e0526847.json | Remove binding transforms
I'm willing to bring them back if there is a
very compelling use-case vs. computed properties. | packages/ember-metal/tests/binding/or_test.js | @@ -1,60 +0,0 @@
-// ==========================================================================
-// Project: Ember Runtime
-// Copyright: ©2011 Strobe Inc. and contributors.
-// License: Licensed under MIT license (see license.js)
-// ==========================================================================
-
-var ... | true |
Other | emberjs | ember.js | 7ae011753e595086287f06733028b260e0526847.json | Remove binding transforms
I'm willing to bring them back if there is a
very compelling use-case vs. computed properties. | packages/ember-metal/tests/binding/registerTransform_test.js | @@ -1,65 +0,0 @@
-// ==========================================================================
-// Project: Ember Metal
-// Copyright: ©2012 Strobe Inc. and contributors.
-// License: Licensed under MIT license (see license.js)
-// ==========================================================================
-/*global... | true |
Other | emberjs | ember.js | 7ae011753e595086287f06733028b260e0526847.json | Remove binding transforms
I'm willing to bring them back if there is a
very compelling use-case vs. computed properties. | packages/ember-metal/tests/binding/single_test.js | @@ -1,69 +0,0 @@
-// Project: Ember Runtime
-// Copyright: ©2011 Strobe Inc. and contributors.
-// License: Licensed under MIT license (see license.js)
-// ==========================================================================
-/*globals MyApp:true */
-
-var get = Ember.get, set = Ember.set;
-
-module('system/bi... | true |
Other | emberjs | ember.js | 7ae011753e595086287f06733028b260e0526847.json | Remove binding transforms
I'm willing to bring them back if there is a
very compelling use-case vs. computed properties. | packages/ember-metal/tests/binding/sync_test.js | @@ -130,52 +130,6 @@ testBoth("bindings should do the right thing when binding is in prototype", func
equal(get(obj, 'selection'), 'a');
});
-testBoth("binding with transform should only fire one change when set", function (get, set) {
- var a, b, changed, transform;
-
- Ember.run(function() {
- a = {array: ... | true |
Other | emberjs | ember.js | 7ae011753e595086287f06733028b260e0526847.json | Remove binding transforms
I'm willing to bring them back if there is a
very compelling use-case vs. computed properties. | packages/ember-metal/tests/binding/transform_test.js | @@ -1,157 +0,0 @@
-// ==========================================================================
-// Project: Ember Runtime
-// Copyright: ©2011 Strobe Inc. and contributors.
-// License: Licensed under MIT license (see license.js)
-// ==========================================================================
-/*glo... | true |
Other | emberjs | ember.js | 7ae011753e595086287f06733028b260e0526847.json | Remove binding transforms
I'm willing to bring them back if there is a
very compelling use-case vs. computed properties. | packages/ember-runtime/tests/legacy_1x/system/binding_test.js | @@ -231,38 +231,6 @@ module("Custom Binding", {
}
});
-test("Binding value1 such that it will recieve only single values", function() {
- var bon1 = Bon1.create({
- value1Binding: Ember.Binding.single("TestNamespace.bon2.val1"),
- array1Binding: Ember.Binding.single("TestNamespace.bon2.arr")
- });
- Ember.run.s... | true |
Other | emberjs | ember.js | 7ae011753e595086287f06733028b260e0526847.json | Remove binding transforms
I'm willing to bring them back if there is a
very compelling use-case vs. computed properties. | packages/ember-runtime/tests/legacy_1x/system/object/bindings_test.js | @@ -84,26 +84,6 @@ test("bind(.bar) should bind to relative path", function() {
equal("changedValue", get(testObject, "foo"), "testObject.foo");
});
-test("Ember.Binding.bool(TestNamespace.fromObject.bar)) should create binding with bool transform", function() {
- Ember.run(function(){
- // create binding
- ... | true |
Other | emberjs | ember.js | 495002207212709f47af6612a5ec3467ddba45ac.json | Simplify accessor code a bit | packages/ember-metal/lib/accessors.js | @@ -248,27 +248,31 @@ Ember.getPath = function(root, path) {
Ember.setPath = function(root, path, value, tolerant) {
var keyName;
- if (arguments.length===2 && 'string' === typeof root) {
+ if (IS_GLOBAL.test(root)) {
value = path;
path = root;
root = null;
}
-
if (path.indexOf('.') > 0) ... | true |
Other | emberjs | ember.js | 495002207212709f47af6612a5ec3467ddba45ac.json | Simplify accessor code a bit | packages/ember-metal/tests/accessors/setPath_test.js | @@ -47,12 +47,6 @@ test('[obj, foo] -> obj.foo', function() {
equal(Ember.getPath(obj, 'foo'), "BAM");
});
-test('[obj, *] -> EXCEPTION [cannot set *]', function() {
- raises(function() {
- Ember.setPath(obj, '*', "BAM");
- }, Error);
-});
-
test('[obj, foo.bar] -> obj.foo.bar', function() {
Ember.setPat... | true |
Other | emberjs | ember.js | 8b4d82b2ceda5d5b09f5f25a4af366e757481b82.json | Add brief documentation for Ember.Object | packages/ember-runtime/lib/system/object.js | @@ -12,6 +12,11 @@ Ember.CoreObject.subclasses = new Ember.Set();
/**
@class
+
+ `Ember.Object` is the main base class for all Ember objects. It is a subclass
+ of `Ember.CoreObject` with the `Ember.Observable` mixin applied. For details,
+ see the documentation for each of these.
+
@extends Ember.CoreObjec... | false |
Other | emberjs | ember.js | a73ba1c2e222f477eb49f33b80203ea776970584.json | Add documentation for Ember.Mixin | packages/ember-metal/lib/mixin.js | @@ -323,7 +323,30 @@ Ember.mixin = function(obj) {
/**
- @constructor
+ @class
+
+ The `Ember.Mixin` class allows you to create mixins, whose properties can be
+ added to other classes. For instance,
+
+ App.Editable = Ember.Mixin.create({
+ edit: function() {
+ console.log('starting to ed... | false |
Other | emberjs | ember.js | 0dddf2d70cf7bff3dffbd9b0ae9be3af2220e798.json | add examples to Array#objectsAt | packages/ember-runtime/lib/mixins/array.js | @@ -93,7 +93,11 @@ Ember.Array = Ember.Mixin.create(Ember.Enumerable, /** @scope Ember.Array.protot
},
/**
- This returns the objects at the specified indexes, using objectAt.
+ This returns the objects at the specified indexes, using `objectAt`.
+
+ var arr = ['a', 'b', 'c', 'd'];
+ arr.obj... | false |
Other | emberjs | ember.js | eb62b083150d3777ba11c0efbbacc64052d98457.json | Fix bug where the wrong context was being passed | packages/ember-states/lib/state.js | @@ -102,8 +102,8 @@ Ember.State = Ember.Object.extend(Ember.Evented, {
});
Ember.State.transitionTo = function(target) {
- var event = function(router, context) {
- router.transitionTo(target, context);
+ var event = function(router, event) {
+ router.transitionTo(target, event.context);
};
event.tr... | false |
Other | emberjs | ember.js | 059ceb0f72ad0f54a022f61d621d73b9470f1b16.json | Allow Handlebars rc1 | packages/ember-handlebars/lib/ext.js | @@ -19,7 +19,7 @@ require("ember-views/system/render_buffer");
@description Helpers for Handlebars templates
*/
-Ember.assert("Ember Handlebars requires Handlebars 1.0.beta.5 or greater", window.Handlebars && window.Handlebars.VERSION.match(/^1\.0\.beta\.[56789]$/));
+Ember.assert("Ember Handlebars requires Handl... | false |
Other | emberjs | ember.js | d1d4a47d1d6291ad596a2b8c1d4a6f18f7a5191d.json | Fix syntax error in action_url_test | packages/ember-application/tests/system/action_url_test.js | @@ -1,7 +1,7 @@
// FIXME: Move this to an integration test pacakge with proper requires
try {
require('ember-handlebars');
-} catch() { }
+} catch(e) { }
module("the {{action}} helper with href attribute");
| false |
Other | emberjs | ember.js | bf9400510f00a2962bb36162eae642c56731a34a.json | Fix paths with leading periods | packages/ember-handlebars/lib/ext.js | @@ -161,7 +161,7 @@ var normalizePath = Ember.Handlebars.normalizePath = function(root, path, data)
} else {
// Strip the keyword from the path and look up
// the remainder from the newly found root.
- path = path.substr(keyword.length);
+ path = path.substr(keyword.length+1);
}
}
| true |
Other | emberjs | ember.js | bf9400510f00a2962bb36162eae642c56731a34a.json | Fix paths with leading periods | packages/ember-handlebars/tests/handlebars_test.js | @@ -245,7 +245,7 @@ test("child views can be inserted using the {{view}} Handlebars helper", functio
test("should accept relative paths to views", function() {
view = Ember.View.create({
- template: Ember.Handlebars.compile('Hey look, at {{view ".myCool.view"}}'),
+ template: Ember.Handlebars.compile('Hey l... | true |
Other | emberjs | ember.js | 0b8cd8dbe42da615d965ae29ac29011600ead61a.json | Simplify getPath code to use split(".") | packages/ember-metal/lib/accessors.js | @@ -135,23 +135,14 @@ Ember.set = set;
// PATHS
//
-// assumes normalized input; no *, normalized path, always a target...
/** @private */
function getPath(target, path) {
- var len = path.length, idx, next, key;
-
- idx = 0;
- while(target && idx<len) {
- next = path.indexOf('.', idx);
- if (next<0) nex... | false |
Other | emberjs | ember.js | 6a1cc57e9380fedb9b3b9eadd37ac06cfb5267c2.json | Remove deprecated functionality
* Ember.get("foo") is now an error
* * paths inside of a path are now an error | packages/ember-metal/lib/accessors.js | @@ -23,7 +23,7 @@ var meta = Ember.meta;
var get, set;
/** @private */
-get = function get(obj, keyName) {
+var basicGet = function get(obj, keyName) {
var ret = obj[keyName];
if (ret !== undefined) { return ret; }
@@ -35,7 +35,7 @@ get = function get(obj, keyName) {
};
/** @private */
-set = function s... | true |
Other | emberjs | ember.js | 6a1cc57e9380fedb9b3b9eadd37ac06cfb5267c2.json | Remove deprecated functionality
* Ember.get("foo") is now an error
* * paths inside of a path are now an error | packages/ember-metal/tests/accessors/getPath_test.js | @@ -90,57 +90,3 @@ test('[null, Foo.bar] -> Foo.bar', function() {
deepEqual(Ember.getPath('Foo.bar'), Foo.bar);
});
-// ..........................................................
-// DEPRECATED
-//
-
-module('Ember.getPath - deprecated', {
- setup: function() {
- Ember.TESTING_DEPRECATION = true;
- module... | true |
Other | emberjs | ember.js | 6a1cc57e9380fedb9b3b9eadd37ac06cfb5267c2.json | Remove deprecated functionality
* Ember.get("foo") is now an error
* * paths inside of a path are now an error | packages/ember-metal/tests/accessors/normalizePath_test.js | @@ -22,12 +22,3 @@ test('.foo.bar -> this.foo.bar', function() {
equal(Ember.normalizePath('.foo.bar'), 'this.foo.bar');
});
-test('*foo.bar -> this.foo.bar', function() {
- Ember.TESTING_DEPRECATION = true;
- try {
- equal(Ember.normalizePath('*foo.bar'), 'this.foo.bar');
- } finally {
- Ember.TESTING_D... | true |
Other | emberjs | ember.js | 6a1cc57e9380fedb9b3b9eadd37ac06cfb5267c2.json | Remove deprecated functionality
* Ember.get("foo") is now an error
* * paths inside of a path are now an error | packages/ember-metal/tests/accessors/normalizeTuple_test.js | @@ -105,70 +105,3 @@ test('[null, Foo] -> EXCEPTION', function() {
test('[null, Foo.bar] -> [Foo, bar]', function() {
deepEqual(Ember.normalizeTuple(null, 'Foo.bar'), [Foo, 'bar']);
});
-
-// ..........................................................
-// DEPRECATED
-//
-//
-module('Ember.normalizeTuple - deprecate... | true |
Other | emberjs | ember.js | 6a1cc57e9380fedb9b3b9eadd37ac06cfb5267c2.json | Remove deprecated functionality
* Ember.get("foo") is now an error
* * paths inside of a path are now an error | packages/ember-metal/tests/accessors/setPath_test.js | @@ -108,52 +108,6 @@ module("Ember.setPath - deprecated", {
}
});
-test('[obj, foo*bar] -> obj.foo.bar', function() {
- Ember.setPath(obj, 'foo*bar', "BAM");
- equal(Ember.getPath(obj, 'foo.bar'), "BAM");
-});
-
-test('[obj, foo*bar.*] -> EXCEPTION', function() {
- raises(function() {
- Ember.setPath(obj, '... | true |
Other | emberjs | ember.js | 6a1cc57e9380fedb9b3b9eadd37ac06cfb5267c2.json | Remove deprecated functionality
* Ember.get("foo") is now an error
* * paths inside of a path are now an error | packages/ember-runtime/tests/legacy_1x/mixins/observable/observable_test.js | @@ -169,7 +169,6 @@ test("raise if the provided object is undefined", function() {
test("should work when object is Ember (used in Ember.getPath)", function() {
equal(Ember.getPath('Ember.RunLoop'), Ember.RunLoop, 'Ember.getPath');
- equal(Ember.get('RunLoop'), Ember.RunLoop, 'Ember.get(RunLoop)');
equal(Embe... | true |
Other | emberjs | ember.js | 6a1cc57e9380fedb9b3b9eadd37ac06cfb5267c2.json | Remove deprecated functionality
* Ember.get("foo") is now an error
* * paths inside of a path are now an error | packages/ember-runtime/tests/legacy_1x/system/object/bindings_test.js | @@ -104,55 +104,6 @@ test("Ember.Binding.bool(TestNamespace.fromObject.bar)) should create binding wi
equal(false, get(testObject, "foo"), "testObject.foo == false");
});
-
-module("bind() method - deprecated", {
- setup: function() {
- Ember.TESTING_DEPRECATION = true;
- bindModuleOpts.setup();
- },
- t... | true |
Other | emberjs | ember.js | f3d80406a69dd98dd4465e30de0d6b37633821e7.json | Remove legacy support for set via unknownProperty
If you want setUnknownProperty, implement
setUnknownProperty. | packages/ember-metal/lib/accessors.js | @@ -39,12 +39,16 @@ get = function get(obj, keyName) {
/** @private */
set = function set(obj, keyName, value) {
- if (('object'===typeof obj) && !(keyName in obj)) {
- if ('function' === typeof obj.setUnknownProperty) {
- obj.setUnknownProperty(keyName, value);
- } else if ('function' === typeof obj.un... | true |
Other | emberjs | ember.js | f3d80406a69dd98dd4465e30de0d6b37633821e7.json | Remove legacy support for set via unknownProperty
If you want setUnknownProperty, implement
setUnknownProperty. | packages/ember-metal/tests/accessors/set_test.js | @@ -26,22 +26,6 @@ test('should set arbitrary properties on an object', function() {
});
-test('should call unknownProperty if defined and value is undefined', function() {
-
- var obj = {
- count: 0,
- unknownProperty: function(key, value) {
- equal(key, 'foo', 'should pass key');
- equal(value, ... | true |
Other | emberjs | ember.js | b456370644ba1472544389a2bf7f4d2bce6fc287.json | Remove unused code | tests/index.html | @@ -76,8 +76,6 @@
var noViewPreservesContext = QUnit.urlParams.noviewpreservescontext;
ENV['VIEW_PRESERVES_CONTEXT'] = !noViewPreservesContext;
- ENV['PREVENT_AUTOMATIC_RUNLOOP_CREATION'] = true;
-
// Don't worry about jQuery version
ENV['FORCE_JQUERY'] = true;
</script> | false |
Other | emberjs | ember.js | 3ff2d411108a8f893c2c5d0eb9c886a233a542e0.json | fix build by checking VIEW_PRESERVES_CONTEXT | packages/ember-views/tests/views/view/template_test.js | @@ -7,6 +7,8 @@
var set = Ember.set, get = Ember.get;
+var VIEW_PRESERVES_CONTEXT = Ember.VIEW_PRESERVES_CONTEXT;
+
module("Ember.View - Template Functionality");
test("should call the function of the associated template", function() {
@@ -26,7 +28,6 @@ test("should call the function of the associated template... | false |
Other | emberjs | ember.js | 9b09cf37d0e8908ee8cd8a41920596a1f6509324.json | Improve error when creating URLs from action | packages/ember-states/lib/router.js | @@ -45,7 +45,7 @@ Ember.Router = Ember.StateManager.extend(
var currentState = get(this, 'currentState');
var targetStateName = currentState.eventTransitions[eventName];
- Ember.assert("You must specify a target state for an event in order to get links for an event", !!targetStateName);
+ Ember.assert... | false |
Other | emberjs | ember.js | a1f9a1f085ec2e6c7d16aedd992f76882791c5ce.json | update String#objectAt documentation | packages/ember-runtime/lib/mixins/array.js | @@ -4,11 +4,8 @@
// License: Licensed under MIT license (see license.js)
// ==========================================================================
-
require('ember-runtime/mixins/enumerable');
-
-
// ..........................................................
// HELPERS
//
@@ -66,20 +63,29 @@ Ember.Array... | false |
Other | emberjs | ember.js | 3b277ec1f34da51c3ed4f7aa2da52c2ac70a9734.json | Fix references to _BindableSpan | packages/ember-handlebars/lib/helpers/binding.js | @@ -56,7 +56,7 @@ var bind = function(property, options, preserveContext, shouldDisplay, valueNorm
};
// Observes the given property on the context and
- // tells the Ember._BindableSpan to re-render. If property
+ // tells the Ember._HandlebarsBoundView to re-render. If property
// is an empty s... | true |
Other | emberjs | ember.js | 3b277ec1f34da51c3ed4f7aa2da52c2ac70a9734.json | Fix references to _BindableSpan | packages/ember-handlebars/lib/views/handlebars_bound_view.js | @@ -134,7 +134,7 @@ Ember._HandlebarsBoundView = Ember._MetamorphView.extend({
true, the `displayTemplate` function will be rendered to DOM. Otherwise,
`inverseTemplate`, if specified, will be rendered.
- For example, if this Ember._BindableSpan represented the {{#with foo}}
+ For example, if this Emb... | true |
Other | emberjs | ember.js | 37fbe405e2bb5fe7b10a96713148771edaff1919.json | Fix misuse of setProperties | packages/ember-views/lib/system/render_buffer.js | @@ -225,7 +225,7 @@ Ember._RenderBuffer.prototype =
var buffer = new Ember._RenderBuffer(tagName);
buffer.parentBuffer = parent;
- if (other) { buffer.setProperties(other); }
+ if (other) { Ember.$.extend(buffer, other); }
if (fn) { fn.call(this, buffer); }
return buffer; | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.