language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
emberjs
ember.js
606d65ab2805ef0a60f3c1e8dae0c3f6c3d802c9.json
Fix more jshint warnings
.jshintrc
@@ -21,7 +21,8 @@ "ok", "strictEqual", "module", - "expect" + "expect", + "minispade" ], "node" : false,
true
Other
emberjs
ember.js
606d65ab2805ef0a60f3c1e8dae0c3f6c3d802c9.json
Fix more jshint warnings
packages/ember-handlebars/lib/helpers/binding.js
@@ -12,7 +12,6 @@ var get = Ember.get, getPath = Ember.Handlebars.getPath, set = Ember.set, fmt = var forEach = Ember.ArrayUtils.forEach; var EmberHandlebars = Ember.Handlebars, helpers = EmberHandlebars.helpers; -var helpers = EmberHandlebars.helpers; (function() { // Binds a property into the DOM. This will...
true
Other
emberjs
ember.js
a948bc3e29643eaf01ba4a58eb932aa5605fed37.json
Install jshint on travis
.travis.yml
@@ -3,4 +3,5 @@ rvm: before_script: - "export DISPLAY=:99.0" - "sh -e /etc/init.d/xvfb start" + - "npm install -g jshint" script: "rake test[all] && rake jshint"
false
Other
emberjs
ember.js
fb1476913e9e45634dc1d2efd9aa8cb3ae3db318.json
Check jshint on travis
.travis.yml
@@ -3,4 +3,4 @@ rvm: before_script: - "export DISPLAY=:99.0" - "sh -e /etc/init.d/xvfb start" -script: rake test +script: "rake test && rake jshint"
false
Other
emberjs
ember.js
49ef31403da93b08f88ee47f1eff3f1cd5017d5f.json
add test for issue #460
packages/ember-metal/tests/binding/sync_test.js
@@ -130,6 +130,52 @@ testBoth("bindings should do the right thing when binding is in prototype", func equal(get(obj, 'selection'), 'a'); }); +testBoth("binding with transform should only fire one change when set", function (get, set) { + var a, b, changed, transform; + + Ember.run(function() { + a = {array: ...
false
Other
emberjs
ember.js
e35332611f8bedbb3ab2ce51c8f8969fa6547072.json
Fix merge error
packages/ember-handlebars/tests/views/collection_view_test.js
@@ -285,8 +285,8 @@ test("should give its item views the property specified by itemPropertyBinding", equal(view.$('ul li').length, 3, "adds 3 itemView"); view.$('ul li').each(function(i, li){ - equals($(li).text(), "baz", "creates the li with the property = baz"); - }) + equal(Ember.$(li).text(), "baz", ...
false
Other
emberjs
ember.js
9cff1d89f610b41d1f51de49892bbbb8d8e6ae2a.json
Use rake-pipeline to build
.gitignore
@@ -26,7 +26,7 @@ spec/reports test/tmp test/version_tmp test_*.html -/tests/source +/tests/ember-tests.js tmp tmp*.gem tmp.bpm
true
Other
emberjs
ember.js
9cff1d89f610b41d1f51de49892bbbb8d8e6ae2a.json
Use rake-pipeline to build
Assetfile
@@ -1,37 +1,54 @@ require "rake-pipeline-web-filters" require "json" +require "uglifier" +require "./neuter" -output "tests/source" +output "tests" input "packages" do - match "*/{lib,tests}/**/*.js" do + match "*/tests/**/*.js" do minispade :rewrite_requires => true, :string => true, :module_id_generator...
true
Other
emberjs
ember.js
9cff1d89f610b41d1f51de49892bbbb8d8e6ae2a.json
Use rake-pipeline to build
Gemfile
@@ -1,6 +1,5 @@ source "http://rubygems.org" -gem "sproutcore", :git => "https://github.com/wycats/abbot-from-scratch.git" gem "uglifier", "~> 1.0.3" gem "execjs", "~> 1.2.6" gem "rack"
true
Other
emberjs
ember.js
9cff1d89f610b41d1f51de49892bbbb8d8e6ae2a.json
Use rake-pipeline to build
Gemfile.lock
@@ -14,12 +14,6 @@ GIT rack thor -GIT - remote: https://github.com/wycats/abbot-from-scratch.git - revision: 47662bbbb25afc213318051676cd31375d1d1f59 - specs: - sproutcore (0.0.1) - GIT remote: https://github.com/wycats/rake-pipeline-web-filters.git revision: fe752a8cfdbb318b746fd76fd3c10dd...
true
Other
emberjs
ember.js
9cff1d89f610b41d1f51de49892bbbb8d8e6ae2a.json
Use rake-pipeline to build
Rakefile
@@ -5,7 +5,7 @@ require "net/github-upload" require "bundler/setup" require "erb" -require "uglifier" +require 'rake-pipeline' require "ember_docs/cli" desc "Strip trailing whitespace for JavaScript files in packages" @@ -18,134 +18,22 @@ task :strip_whitespace do end end -# for now, the SproutCore compil...
true
Other
emberjs
ember.js
9cff1d89f610b41d1f51de49892bbbb8d8e6ae2a.json
Use rake-pipeline to build
config.ru
@@ -1,3 +1,9 @@ +begin + require 'bundler' + Bundler.setup :default +rescue LoadError +end + require 'rake-pipeline' require 'rake-pipeline/middleware'
true
Other
emberjs
ember.js
9cff1d89f610b41d1f51de49892bbbb8d8e6ae2a.json
Use rake-pipeline to build
neuter.rb
@@ -0,0 +1,114 @@ +require 'rake-pipeline' + +module Neuter + + DEBUG = false + + class SpadeWrapper < Rake::Pipeline::FileWrapper + + REQUIRE_RE = %r{^\s*require\(['"]([^'"]*)['"]\);?\s*} + + # Keep track of required files + @@required = [] + + # Yes, it's called package because module is a reserved ...
true
Other
emberjs
ember.js
9cff1d89f610b41d1f51de49892bbbb8d8e6ae2a.json
Use rake-pipeline to build
tests/index.html
@@ -32,18 +32,27 @@ <h2 id="qunit-userAgent"></h2> } </script> - <script type="text/javascript" src="minispade.js"></script> - <script type="text/javascript" src="source/ember.js"></script> - <script type="text/javascript" src="source/ember-tests.js"></script> - <script type="text/javascript"> // H...
true
Other
emberjs
ember.js
7f21439ec0f765ee0b8186fb347c0a569cc1656d.json
Fix some jshint errors
.jshintrc
@@ -13,13 +13,15 @@ "equal", "test", "testBoth", + "testWithDefault", "raises", "deepEqual", "start", "stop", "ok", "strictEqual", - "module" + "module", + "expect" ], "node" : false,
true
Other
emberjs
ember.js
7f21439ec0f765ee0b8186fb347c0a569cc1656d.json
Fix some jshint errors
packages/ember-handlebars/lib/controls/select.js
@@ -1,3 +1,5 @@ +/*jshint eqeqeq:false */ + var set = Ember.set, get = Ember.get, getPath = Ember.getPath; var indexOf = Ember.ArrayUtils.indexOf;
true
Other
emberjs
ember.js
7f21439ec0f765ee0b8186fb347c0a569cc1656d.json
Fix some jshint errors
packages/ember-handlebars/lib/views/metamorph_view.js
@@ -24,7 +24,7 @@ var DOMManager = { nextView._insertElementLater(function() { var morph = view.morph; morph.after(nextView.outerHTML); - nextView,outerHTML = null; + nextView.outerHTML = null; }); },
true
Other
emberjs
ember.js
7f21439ec0f765ee0b8186fb347c0a569cc1656d.json
Fix some jshint errors
packages/ember-metal/lib/array.js
@@ -83,7 +83,7 @@ Ember.ArrayUtils = { var args = Array.prototype.slice.call(arguments, 1); return obj.indexOf ? obj.indexOf.apply(obj, args) : arrayIndexOf.apply(obj, args); } -} +}; if (Ember.SHIM_ES5) {
true
Other
emberjs
ember.js
7f21439ec0f765ee0b8186fb347c0a569cc1656d.json
Fix some jshint errors
packages/ember-metal/tests/accessors/get_test.js
@@ -94,7 +94,7 @@ test('should get arbitrary properties on an object', function() { obj = { undef: undefined - } + }; equal(Ember.getWithDefault(obj, "undef", "default"), "default", "explicit undefined retrieves the default"); equal(Ember.getWithDefault(obj, "not-present", "default"), "default", "no...
true
Other
emberjs
ember.js
7f21439ec0f765ee0b8186fb347c0a569cc1656d.json
Fix some jshint errors
packages/ember-runtime/tests/system/object/computed_test.js
@@ -3,7 +3,6 @@ // Copyright: ©2011 Strobe Inc. and contributors. // License: Licensed under MIT license (see license.js) // ========================================================================== -/*globals testBoth */ require('ember-runtime/~tests/props_helper');
true
Other
emberjs
ember.js
7f21439ec0f765ee0b8186fb347c0a569cc1656d.json
Fix some jshint errors
packages/ember-states/tests/state_manager_test.js
@@ -345,7 +345,7 @@ test("it sends exit events in the correct order when changing to a state multipl stateManager.goToState('start.outer.inner'); stateManager.goToState('start'); stateManager.goToState('start.outer.inner'); - exitOrder = [] + exitOrder = []; stateManager.goToState('start'); equal(exitO...
true
Other
emberjs
ember.js
7f21439ec0f765ee0b8186fb347c0a569cc1656d.json
Fix some jshint errors
packages/ember-views/lib/core.js
@@ -5,5 +5,5 @@ // License: Licensed under MIT license (see license.js) // ========================================================================== -ember_assert("Ember requires jQuery 1.6 or 1.7", window.jQuery && jQuery().jquery.match(/^1\.[67](.\d+)?$/)); +ember_assert("Ember requires jQuery 1.6 or 1.7", win...
true
Other
emberjs
ember.js
7f21439ec0f765ee0b8186fb347c0a569cc1656d.json
Fix some jshint errors
packages/ember-views/lib/system/event_dispatcher.js
@@ -133,7 +133,7 @@ Ember.EventDispatcher = Ember.Object.extend( }); rootElement.delegate('[data-ember-action]', event + '.ember', function(evt) { - var actionId = $(evt.currentTarget).attr('data-ember-action'), + var actionId = Ember.$(evt.currentTarget).attr('data-ember-action'), acti...
true
Other
emberjs
ember.js
7f21439ec0f765ee0b8186fb347c0a569cc1656d.json
Fix some jshint errors
packages/ember-views/lib/system/render_buffer.js
@@ -25,7 +25,7 @@ ClassSet.prototype = { toDOM: function() { return this.list.join(" "); } -} +}; /** @class @@ -43,7 +43,7 @@ Ember.RenderBuffer = function(tagName) { Ember._RenderBuffer = function(tagName) { this.elementTag = tagName; this.childBuffers = []; -} +}; Ember._RenderBuffer.proto...
true
Other
emberjs
ember.js
7f21439ec0f765ee0b8186fb347c0a569cc1656d.json
Fix some jshint errors
packages/ember-views/lib/views/view.js
@@ -346,7 +346,7 @@ Ember.View = Ember.Object.extend(Ember.Evented, // try to find the function for the state in the cache if (fn = invokeForState[stateName][name]) { - args = a_slice.call(arguments) + args = a_slice.call(arguments); args[0] = this; return fn.apply(this, args); @@ ...
true
Other
emberjs
ember.js
7f21439ec0f765ee0b8186fb347c0a569cc1656d.json
Fix some jshint errors
packages/ember-views/tests/views/view/element_test.js
@@ -69,7 +69,7 @@ test("discovers element if has no element but parent view does have element", fu }); test("should not allow the elementId to be changed", function() { - view = Ember.View.create({ + var view = Ember.View.create({ elementId: 'one' });
true
Other
emberjs
ember.js
c7925ed13317be0df893094db2c7a56db01d47b9.json
Upgrade QUnit and fix warnings/errors
packages/ember-handlebars/tests/handlebars_test.js
@@ -1542,6 +1542,8 @@ test("bindings can be 'this', in which case they *are* the current context", fun // https://github.com/emberjs/ember.js/issues/120 test("should not enter an infinite loop when binding an attribute in Handlebars", function() { + expect(0); + App = Ember.Application.create(); App.test = E...
true
Other
emberjs
ember.js
c7925ed13317be0df893094db2c7a56db01d47b9.json
Upgrade QUnit and fix warnings/errors
packages/ember-handlebars/tests/views/collection_view_test.js
@@ -115,7 +115,7 @@ test("collection helper should accept emptyViewClass attribute", function() { view.appendTo('#qunit-fixture'); }); - equals(view.$('tr').length, 0, 'emptyViewClass has no effect without inverse'); + equal(view.$('tr').length, 0, 'emptyViewClass has no effect without inverse'); view.re...
true
Other
emberjs
ember.js
c7925ed13317be0df893094db2c7a56db01d47b9.json
Upgrade QUnit and fix warnings/errors
packages/ember-metal/tests/accessors/setPath_test.js
@@ -133,7 +133,7 @@ test('[obj, foo.baz.bat] -> EXCEPTION', function() { test('[obj, foo.baz.bat] -> EXCEPTION', function() { Ember.trySetPath(obj, 'foo.baz.bat', "BAM"); - // does not raise + ok(true, "does not raise"); }); test('[obj, Foo.bar] -> Foo.bar', function() {
true
Other
emberjs
ember.js
c7925ed13317be0df893094db2c7a56db01d47b9.json
Upgrade QUnit and fix warnings/errors
packages/ember-metal/tests/binding/sync_test.js
@@ -103,7 +103,7 @@ testBoth("bindings should not try to sync destroyed objects", function(get, set) Ember.run(function() { set(a, 'foo', 'trollface'); set(b, 'isDestroyed', true); - // should not raise + ok(true, "should not raise"); }); Ember.run(function() { @@ -120,6 +120,6 @@ testBoth("b...
true
Other
emberjs
ember.js
c7925ed13317be0df893094db2c7a56db01d47b9.json
Upgrade QUnit and fix warnings/errors
packages/ember-metal/tests/mixin/required_test.js
@@ -56,6 +56,7 @@ test('combined mixins to meet requirement', function() { test('merged mixin', function() { Ember.Mixin.create(PartialMixin, { foo: 'FOO' }).apply(obj); + equal(Ember.get(obj, 'foo'), 'FOO', 'should now be defined'); }); test('define property on source object', function() {
true
Other
emberjs
ember.js
c7925ed13317be0df893094db2c7a56db01d47b9.json
Upgrade QUnit and fix warnings/errors
packages/ember-metal/tests/utils/meta_test.js
@@ -4,6 +4,8 @@ // License: Licensed under MIT license (see license.js) // ========================================================================== +/*global jQuery*/ + module("Ember.meta"); test("should return the same hash for an object", function() { @@ -58,6 +60,6 @@ if (window.jQuery) { jQuery.e...
true
Other
emberjs
ember.js
c7925ed13317be0df893094db2c7a56db01d47b9.json
Upgrade QUnit and fix warnings/errors
packages/ember-runtime/tests/suites/enumerable/forEach.js
@@ -21,7 +21,10 @@ suite.test('forEach should iterate over list', function() { suite.test('forEach should iterate over list after mutation', function() { - if (Ember.get(this, 'canTestMutation')) return ; + if (Ember.get(this, 'canTestMutation')) { + expect(0); + return ; + } var obj = this.newObject...
true
Other
emberjs
ember.js
c7925ed13317be0df893094db2c7a56db01d47b9.json
Upgrade QUnit and fix warnings/errors
packages/ember-runtime/tests/suites/enumerable/map.js
@@ -23,7 +23,10 @@ suite.test('map should iterate over list', function() { suite.test('map should iterate over list after mutation', function() { - if (Ember.get(this, 'canTestMutation')) return ; + if (Ember.get(this, 'canTestMutation')) { + expect(0); + return ; + } var obj = this.newObject(), ...
true
Other
emberjs
ember.js
c7925ed13317be0df893094db2c7a56db01d47b9.json
Upgrade QUnit and fix warnings/errors
packages/ember-runtime/tests/system/object/destroy_test.js
@@ -34,5 +34,7 @@ test("should raise an exception when modifying watched properties on a destroyed raises(function() { Ember.set(obj, 'foo', 'baz'); }, Error, "raises an exception"); + } else { + expect(0); } });
true
Other
emberjs
ember.js
c7925ed13317be0df893094db2c7a56db01d47b9.json
Upgrade QUnit and fix warnings/errors
packages/ember-runtime/tests/system/string/dasherize.js
@@ -35,12 +35,20 @@ test("dasherize camelcased string", function() { } }); -test("after call with the same passed value take object from cashe", function() { +test("after call with the same passed value take object from cache", function() { var res = Ember.String.dasherize('innerHTML'); + + var callCount = 0;...
true
Other
emberjs
ember.js
c7925ed13317be0df893094db2c7a56db01d47b9.json
Upgrade QUnit and fix warnings/errors
packages/ember-states/tests/state_manager_test.js
@@ -463,9 +463,9 @@ test("goToState triggers all enter states", function() { test("goToState with current state does not trigger enter or exit", function() { stateManager.goToState('grandparent.parent.child'); stateManager.goToState('grandparent.parent.child'); - equals(stateManager.grandparent.entered, 1, "the...
true
Other
emberjs
ember.js
c7925ed13317be0df893094db2c7a56db01d47b9.json
Upgrade QUnit and fix warnings/errors
packages/ember-views/tests/system/application_test.js
@@ -23,6 +23,7 @@ module("Ember.Application", { test("you can make a new application in a non-overlapping element", function() { var app = Ember.Application.create({ rootElement: '#two' }); app.destroy(); + ok(true, "should not raise"); }); test("you cannot make a new application that is a parent of an exis...
true
Other
emberjs
ember.js
c7925ed13317be0df893094db2c7a56db01d47b9.json
Upgrade QUnit and fix warnings/errors
packages/ember-views/tests/views/view/attribute_bindings_test.js
@@ -37,7 +37,7 @@ test("should render attribute bindings", function() { view.createElement(); - equals(view.$().attr('type'), 'submit', "updates type attribute"); + equal(view.$().attr('type'), 'submit', "updates type attribute"); ok(view.$().attr('disabled'), "supports customizing attribute name for Boolea...
true
Other
emberjs
ember.js
c7925ed13317be0df893094db2c7a56db01d47b9.json
Upgrade QUnit and fix warnings/errors
tests/qunit/qunit.css
@@ -1,13 +1,11 @@ /** - * QUnit v1.3.0pre - A JavaScript Unit Testing Framework + * QUnit v1.4.0pre - A JavaScript Unit Testing Framework * * http://docs.jquery.com/QUnit * - * Copyright (c) 2011 John Resig, Jörn Zaefferer + * Copyright (c) 2012 John Resig, Jörn Zaefferer * Dual licensed under the MIT (MIT-LIC...
true
Other
emberjs
ember.js
c7925ed13317be0df893094db2c7a56db01d47b9.json
Upgrade QUnit and fix warnings/errors
tests/qunit/qunit.js
@@ -1,22 +1,23 @@ /** - * QUnit v1.3.0pre - A JavaScript Unit Testing Framework + * QUnit v1.4.0pre - A JavaScript Unit Testing Framework * * http://docs.jquery.com/QUnit * - * Copyright (c) 2011 John Resig, Jörn Zaefferer + * Copyright (c) 2012 John Resig, Jörn Zaefferer * Dual licensed under the MIT (MIT-LIC...
true
Other
emberjs
ember.js
8f2dfc4dd0fe3a02ac0a49cd28397110400f4cdd.json
Hide some private methods from docs
packages/ember-metal/lib/array.js
@@ -2,6 +2,7 @@ // Testing this is not ideal, but we want ArrayUtils to use native functions // if available, but not to use versions created by libraries like Prototype +/** @private */ var isNativeFunc = function(func) { // This should probably work in all browsers likely to have ES5 array methods return f...
true
Other
emberjs
ember.js
8f2dfc4dd0fe3a02ac0a49cd28397110400f4cdd.json
Hide some private methods from docs
packages/ember-metal/lib/utils.js
@@ -150,7 +150,7 @@ var EMPTY_META = { if (Object.freeze) Object.freeze(EMPTY_META); -var createMeta = Ember.platform.defineProperty.isSimulated ? o_create : function(meta) { return meta; }; +var createMeta = Ember.platform.defineProperty.isSimulated ? o_create : (function(meta) { return meta; }); /** @priva...
true
Other
emberjs
ember.js
8f2dfc4dd0fe3a02ac0a49cd28397110400f4cdd.json
Hide some private methods from docs
packages/ember-runtime/lib/mixins/array.js
@@ -15,8 +15,10 @@ require('ember-runtime/mixins/enumerable'); var get = Ember.get, set = Ember.set, meta = Ember.meta; +/** @private */ function none(obj) { return obj===null || obj===undefined; } +/** @private */ function xform(target, method, params) { method.call(target, params[0], params[2], params[3],...
true
Other
emberjs
ember.js
8f2dfc4dd0fe3a02ac0a49cd28397110400f4cdd.json
Hide some private methods from docs
packages/ember-runtime/lib/mixins/evented.js
@@ -1,5 +1,6 @@ var get = Ember.get, set = Ember.set; +/** @private */ function xform(target, method, params) { var args = [].slice.call(params, 2); method.apply(target, args);
true
Other
emberjs
ember.js
8f2dfc4dd0fe3a02ac0a49cd28397110400f4cdd.json
Hide some private methods from docs
packages/ember-runtime/lib/system/map.js
@@ -18,6 +18,7 @@ `Ember.Map.create()` for symmetry with other Ember classes. */ +/** @private */ var guidFor = Ember.guidFor; var indexOf = Ember.ArrayUtils.indexOf; @@ -97,6 +98,7 @@ OrderedSet.prototype = { we delete its entry in `keys` and `values`. */ +/** @private */ var Map = Ember.Map = functio...
true
Other
emberjs
ember.js
8f2dfc4dd0fe3a02ac0a49cd28397110400f4cdd.json
Hide some private methods from docs
packages/ember-views/lib/views/view.js
@@ -1428,6 +1428,7 @@ Ember.View = Ember.Object.extend(Ember.Evented, // once the view has been inserted into the DOM, legal manipulations // are done on the DOM element. +/** @private */ DOMManager = { prepend: function(view, childView) { childView._insertElementLater(function() {
true
Other
emberjs
ember.js
9050fabac7f7b3e302893ce3312d241805514ee0.json
Add a cache for invokeForState in Ember.View
packages/ember-views/lib/views/view.js
@@ -39,6 +39,14 @@ var childViewsProperty = Ember.computed(function() { */ Ember.TEMPLATES = {}; +var invokeForState = { + preRender: {}, + inBuffer: {}, + hasElement: {}, + inDOM: {}, + destroyed: {} +}; + /** @class @since Ember 0.9 @@ -334,8 +342,18 @@ Ember.View = Ember.Object.extend(Ember.Evented, ...
false
Other
emberjs
ember.js
f44c29a8f62eb548a3ae402f5efbf2310c469d3a.json
Update API docs for ArrayController and ArrayProxy
packages/ember-runtime/lib/controllers/array_controller.js
@@ -9,11 +9,13 @@ require('ember-runtime/system/array_proxy'); /** @class - Ember.ArrayController provides a way for you to publish an array of objects for - Ember.CollectionView or other controllers to work with. To work with an - ArrayController, set the content property to the array you want the controller...
true
Other
emberjs
ember.js
f44c29a8f62eb548a3ae402f5efbf2310c469d3a.json
Update API docs for ArrayController and ArrayProxy
packages/ember-runtime/lib/system/array_proxy.js
@@ -15,9 +15,31 @@ var get = Ember.get, set = Ember.set; @class An ArrayProxy wraps any other object that implements Ember.Array and/or - Ember.MutableArray, forwarding all requests. ArrayProxy isn't useful by itself - but you can extend it to do specialized things like transforming values, - etc. + Ember....
true
Other
emberjs
ember.js
02ac26d7805a5a3848def089506bd1f1e45ecc8c.json
Make the RenderBuffer lazier and more efficient Don't bother setting up structures that will never be used and use regular accessors. We don't need the RenderBuffer to be observable.
packages/ember-views/lib/system/render_buffer.js
@@ -100,11 +100,7 @@ Ember._RenderBuffer = Ember.Object.extend( init: function() { this._super(); - set(this ,'elementClasses', Ember.A()); - set(this, 'elementAttributes', {}); - set(this, 'elementStyle', {}); - set(this, 'childBuffers', []); - set(this, 'elements', {}); + this.childBuffers...
false
Other
emberjs
ember.js
caa4c9cd21b43c6f2f827e307f5486785d9b0174.json
Make DOMManager stateless for performance
packages/ember-handlebars/lib/views/metamorph_view.js
@@ -5,75 +5,73 @@ require("ember-views/views/view"); var set = Ember.set, get = Ember.get, getPath = Ember.getPath; +var DOMManager = { + remove: function(view) { + var morph = view.morph; + if (morph.isRemoved()) { return; } + morph.remove(); + }, + + prepend: function(view, childView) { + childVie...
true
Other
emberjs
ember.js
caa4c9cd21b43c6f2f827e307f5486785d9b0174.json
Make DOMManager stateless for performance
packages/ember-views/lib/views/container_view.js
@@ -139,9 +139,9 @@ Ember.ContainerView = Ember.View.extend({ */ _scheduleInsertion: function(view, prev) { if (prev) { - prev.get('domManager').after(view); + prev.domManager.after(prev, view); } else { - this.get('domManager').prepend(view); + this.domManager.prepend(this, view); ...
true
Other
emberjs
ember.js
caa4c9cd21b43c6f2f827e307f5486785d9b0174.json
Make DOMManager stateless for performance
packages/ember-views/lib/views/states/in_dom.js
@@ -42,7 +42,7 @@ Ember.View.states.hasElement = { view.clearRenderedChildren(); - get(view, 'domManager').replace(); + view.domManager.replace(view); return view; }, @@ -52,7 +52,7 @@ Ember.View.states.hasElement = { destroyElement: function(view) { view._notifyWillDestroyElement(); ...
true
Other
emberjs
ember.js
caa4c9cd21b43c6f2f827e307f5486785d9b0174.json
Make DOMManager stateless for performance
packages/ember-views/lib/views/view.js
@@ -1117,6 +1117,8 @@ Ember.View = Ember.Object.extend(Ember.Evented, */ attributeBindings: [], + state: 'preRender', + // ....................................................... // CORE DISPLAY METHODS // @@ -1130,8 +1132,6 @@ Ember.View = Ember.Object.extend(Ember.Evented, dispatch */ i...
true
Other
emberjs
ember.js
ce385e3294be019215c555511c7f393aebc02e41.json
Allow static classes in bindAttr
packages/ember-handlebars/lib/helpers/binding.js
@@ -321,7 +321,7 @@ EmberHandlebars.bindClasses = function(context, classBindings, view, bindAttrId) property = split[0]; - var val = getPath(context, property); + var val = property !== '' ? getPath(context, property) : true; // If value is a Boolean and true, return the dasherized property ...
true
Other
emberjs
ember.js
ce385e3294be019215c555511c7f393aebc02e41.json
Allow static classes in bindAttr
packages/ember-handlebars/tests/handlebars_test.js
@@ -1234,7 +1234,7 @@ test("should be able to bind boolean element attributes using {{bindAttr}}", fun }); test("should be able to add multiple classes using {{bindAttr class}}", function() { - var template = Ember.Handlebars.compile('<div {{bindAttr class="content.isAwesomeSauce content.isAlsoCool content.isAmazi...
true
Other
emberjs
ember.js
71769f2ae255290f4d4a93fd8fef53fa243124c9.json
add test for issue #546
packages/ember-metal/tests/binding/sync_test.js
@@ -89,6 +89,47 @@ testBoth("bindings should do the right thing when observers trigger bindings in equal(get(a, 'foo'), "what is going on"); }); +testBoth("bindings should do the right thing when binding is in prototype", function(get, set) { + var obj, proto, a, b, selectionChanged; + Ember.run(function() { + ...
false
Other
emberjs
ember.js
d9e44a37a01132ecba52d3415b13ff70eafe09d4.json
Fix jQuery.extend for older browsers - fixes #344
packages/ember-metal/lib/utils.js
@@ -150,6 +150,8 @@ var EMPTY_META = { if (Object.freeze) Object.freeze(EMPTY_META); +var createMeta = Ember.platform.defineProperty.isSimulated ? o_create : function(meta) { return meta; }; + /** @private @function @@ -178,26 +180,27 @@ Ember.meta = function meta(obj, writable) { if (!ret) { o_de...
true
Other
emberjs
ember.js
d9e44a37a01132ecba52d3415b13ff70eafe09d4.json
Fix jQuery.extend for older browsers - fixes #344
packages/ember-metal/tests/utils/meta_test.js
@@ -40,3 +40,18 @@ test("getMeta and setMeta", function() { Ember.setMeta(obj, 'foo', "bar"); equal(Ember.getMeta(obj, 'foo'), "bar", "foo property on meta now exists"); }); + +if (window.jQuery) { + // Tests fix for https://github.com/emberjs/ember.js/issues/344 + // This is primarily for older browsers such ...
true
Other
emberjs
ember.js
2326580cda4383ee732e84a28407728fe4231bfb.json
Add an evented mixin for Ember objects In general, we should be using events more extensively that happen to trigger callbacks as a side effect. This makes it possible for other objects to register for notifications that would normally be provided via callbacks, such as when a single object manages a number of views.
packages/ember-runtime/lib/mixins.js
@@ -13,3 +13,4 @@ require('ember-runtime/mixins/mutable_array'); require('ember-runtime/mixins/mutable_enumerable'); require('ember-runtime/mixins/observable'); require('ember-runtime/mixins/target_action_support'); +require('ember-runtime/mixins/evented');
true
Other
emberjs
ember.js
2326580cda4383ee732e84a28407728fe4231bfb.json
Add an evented mixin for Ember objects In general, we should be using events more extensively that happen to trigger callbacks as a side effect. This makes it possible for other objects to register for notifications that would normally be provided via callbacks, such as when a single object manages a number of views.
packages/ember-runtime/lib/mixins/evented.js
@@ -0,0 +1,25 @@ +var get = Ember.get, set = Ember.set; + +function xform(target, method, params) { + var args = [].slice.call(params, 2); + method.apply(target, args); +} + +Ember.Evented = Ember.Mixin.create({ + bindEvent: function(name, target, method) { + if (!method) { + method = target; + target =...
true
Other
emberjs
ember.js
2326580cda4383ee732e84a28407728fe4231bfb.json
Add an evented mixin for Ember objects In general, we should be using events more extensively that happen to trigger callbacks as a side effect. This makes it possible for other objects to register for notifications that would normally be provided via callbacks, such as when a single object manages a number of views.
packages/ember-runtime/tests/system/object/events_test.js
@@ -0,0 +1,51 @@ +module("Object events"); + +test("a listener can be added to an object", function() { + var count = 0; + var F = function() { count++; }; + + var obj = Ember.Object.create(Ember.Evented); + + obj.bindEvent('event!', F); + obj.triggerEvent('event!'); + + equal(count, 1, "the event was triggered")...
true
Other
emberjs
ember.js
8a09430363e01c6121fdeff1e7111360151fd555.json
Expose OrderedSet for Ember Data
packages/ember-runtime/lib/system/map.js
@@ -20,7 +20,10 @@ var guidFor = Ember.guidFor; -var OrderedSet = function() { +// This class is used internally by Ember.js and Ember Data. +// Please do not use it at this time. We plan to clean it up +// and add many tests soon. +var OrderedSet = Ember.OrderedSet = function() { this.clear(); };
false
Other
emberjs
ember.js
3d2ba75dc7d381b63347e44934457f1a36669300.json
Remove more mentions of IndexSet
packages/ember-runtime/lib/mixins/mutable_array.js
@@ -74,13 +74,12 @@ Ember.MutableArray = Ember.Mixin.create(Ember.Array, Ember.MutableEnumerable, /** Remove an object at the specified index using the replace() primitive - method. You can pass either a single index, a start and a length or an - index set. + method. You can pass either a single in...
true
Other
emberjs
ember.js
3d2ba75dc7d381b63347e44934457f1a36669300.json
Remove more mentions of IndexSet
packages/ember-runtime/lib/mixins/mutable_enumerable.js
@@ -55,9 +55,8 @@ Ember.MutableEnumerable = Ember.Mixin.create(Ember.Enumerable, already present in the collection. If the object is present, this method has no effect. - If the passed object is of a type not supported by the receiver (for - example if you pass an object to an IndexSet) then this meth...
true
Other
emberjs
ember.js
2bdc696ab6f16977336785ed4cae865263ad0423.json
Add an eachComputedProperty iterator
packages/ember-runtime/lib/system/core_object.js
@@ -213,6 +213,25 @@ var ClassMixin = Ember.Mixin.create({ ember_assert("metaForProperty() could not find a computed property with key '"+key+"'.", !!desc && desc instanceof Ember.ComputedProperty); return desc._meta || {}; + }, + + /** + Iterate over each computed property for the class, passing its n...
true
Other
emberjs
ember.js
2bdc696ab6f16977336785ed4cae865263ad0423.json
Add an eachComputedProperty iterator
packages/ember-runtime/tests/system/object/computed_test.js
@@ -159,3 +159,53 @@ test("can retrieve metadata for a computed property", function() { ClassWithNoMetadata.metaForProperty('staticProperty'); }, Error, "throws an error if metadata for a non-computed property is requested"); }); + +testBoth("can iterate over a list of computed properties for a class", functio...
true
Other
emberjs
ember.js
6e3489e3d29b0bcc5841d6613c2c58f5fb2c53a2.json
use html entity to avoid doc breakage in parsing
packages/ember-handlebars/lib/helpers/template.js
@@ -17,7 +17,7 @@ require('ember-handlebars/ext'); </script> This helper looks for templates in the global Ember.TEMPLATES hash. If you - add <script> tags to your page with the `data-template-name` attribute set, + add &lt;script&gt; tags to your page with the `data-template-name` attribute set, they ...
false
Other
emberjs
ember.js
b2c61125feb1a3778ebc8d9e8dd9bf9556926cf2.json
fix typo in Ember.Set docs
packages/ember-runtime/lib/system/set.js
@@ -22,7 +22,7 @@ var get = Ember.get, set = Ember.set, guidFor = Ember.guidFor, none = Ember.none A Set works a bit like an array except that its items are not ordered. You can create a set to efficiently test for membership for an object. You can also iterate through a set just like an array, even accessing ...
false
Other
emberjs
ember.js
12b8f02e324ff6a6bc3fbcb80e45d09afbfab56d.json
Add a strip_whitespace task to the Rakefile
Rakefile
@@ -7,6 +7,16 @@ require "bundler/setup" require "erb" require "uglifier" +desc "Strip trailing whitespace for JavaScript files in packages" +task :strip_whitespace do + Dir["packages/**/*.js"].each do |name| + body = File.read(name) + File.open(name, "w") do |file| + file.write body.gsub(/ +\n/, "\n") ...
false
Other
emberjs
ember.js
fcfe4fd2e146c24d7ed4426d63ded907137bce9d.json
Fix jshint complaint about negation
packages/ember-metal/lib/watching.js
@@ -180,7 +180,7 @@ Wp.copy = function(obj) { var ret = new ChainNode(null, null, obj, this._separator); var paths = this._paths, path; for(path in paths) { - if (!(paths[path] > 0)) continue; // this check will also catch non-number vals. + if (paths[path] <= 0) continue; // this check will also catch n...
true
Other
emberjs
ember.js
fcfe4fd2e146c24d7ed4426d63ded907137bce9d.json
Fix jshint complaint about negation
packages/ember-runtime/tests/suites/enumerable/find.js
@@ -32,7 +32,7 @@ suite.test('every should stop invoking when you return true', function() { exp = cnt, found = [], result; - result = obj.find(function(i) { found.push(i); return !(--cnt>0); }); + result = obj.find(function(i) { found.push(i); return --cnt >= 0; }); equal(result, ary[exp-1], 'retu...
true
Other
emberjs
ember.js
fcfe4fd2e146c24d7ed4426d63ded907137bce9d.json
Fix jshint complaint about negation
packages/ember-runtime/tests/suites/enumerable/some.js
@@ -31,7 +31,7 @@ suite.test('every should stop invoking when you return true', function() { exp = cnt, found = [], result; - result = obj.some(function(i) { found.push(i); return !(--cnt>0); }); + result = obj.some(function(i) { found.push(i); return --cnt <= 0; }); equal(result, true, 'return val...
true
Other
emberjs
ember.js
625e38267861b3e6e3281808c833ef7f668d543a.json
Fix boolean logic error in view helper assert
packages/ember-handlebars/lib/helpers/view.js
@@ -92,7 +92,7 @@ Ember.Handlebars.ViewHelper = Ember.Object.create({ var viewOptions = {}; if (fn) { - ember_assert("You cannot provide a template block if you also specified a templateName", !(get(viewOptions, 'templateName')) && !(newView.PrototypeMixin.keys().indexOf('templateName') >= 0)); + ...
false
Other
emberjs
ember.js
02cd42b89f76bf4565f9b8aade2996af0b625d61.json
Remove test for deprecation warning
packages/ember-runtime/tests/legacy_1x/system/binding_test.js
@@ -236,16 +236,6 @@ test("Binding value1 such that it will recieve only single values", function() { equal("@@MULT@@",get(bon1, "array1")); }); -test("Single binding using notEmpty function.", function() { - // This should raise an exception for Ember 1.x developers who are using - // the old syntax. - raises(...
false
Other
emberjs
ember.js
dc40aa710789e5789802a9d5045ff5787fc75da4.json
Eliminate vestigial YES and NO
packages/ember-handlebars/lib/helpers/binding.js
@@ -287,7 +287,7 @@ EmberHandlebars.registerHelper('bindAttr', function(options) { change, the correct class name will be reapplied to the DOM element. For example, if you pass the string "fooBar", it will first look up the - "fooBar" value of the context. If that value is YES, it will add the + "fooBar" valu...
true
Other
emberjs
ember.js
dc40aa710789e5789802a9d5045ff5787fc75da4.json
Eliminate vestigial YES and NO
packages/ember-handlebars/lib/views/bindable_span.js
@@ -43,7 +43,7 @@ Ember._BindableSpanView = Ember.View.extend(Ember.Metamorph, For example, this is true when using the `{{#if}}` helper, because the template inside the helper should look up properties relative to the same - object as outside the block. This would be NO when used with `{{#with + obje...
true
Other
emberjs
ember.js
dc40aa710789e5789802a9d5045ff5787fc75da4.json
Eliminate vestigial YES and NO
packages/ember-handlebars/tests/controls/text_area_test.js
@@ -150,11 +150,11 @@ test("should call the cancel method when escape key is pressed", function() { // textArea.insertNewline = function() { // insertNewlineCalled++; -// return YES; +// return true; // }; // textArea.cancel = function() { // cancelCalled++; -// return YES; +// retu...
true
Other
emberjs
ember.js
dc40aa710789e5789802a9d5045ff5787fc75da4.json
Eliminate vestigial YES and NO
packages/ember-handlebars/tests/controls/text_field_test.js
@@ -159,11 +159,11 @@ test("should call the cancel method when escape key is pressed", function() { // textField.insertNewline = function() { // insertNewlineCalled++; -// return YES; +// return true; // }; // textField.cancel = function() { // cancelCalled++; -// return YES; +// re...
true
Other
emberjs
ember.js
dc40aa710789e5789802a9d5045ff5787fc75da4.json
Eliminate vestigial YES and NO
packages/ember-metal/lib/binding.js
@@ -240,7 +240,7 @@ Binding.prototype = /** @scope Ember.Binding.prototype */ { @param {Boolean} flag (Optional) passing nothing here will make the binding oneWay. You can - instead pass NO to disable oneWay, making the binding two way again. + instead pass false to disable oneWay, making the b...
true
Other
emberjs
ember.js
dc40aa710789e5789802a9d5045ff5787fc75da4.json
Eliminate vestigial YES and NO
packages/ember-metal/lib/utils.js
@@ -299,7 +299,7 @@ Ember.wrap = function(func, superFunc) { /** @function - Returns YES if the passed object is an array or Array-like. + Returns true if the passed object is an array or Array-like. Ember Array Protocol:
true
Other
emberjs
ember.js
dc40aa710789e5789802a9d5045ff5787fc75da4.json
Eliminate vestigial YES and NO
packages/ember-runtime/lib/core.js
@@ -11,24 +11,6 @@ require('ember-metal'); // GLOBAL CONSTANTS // -/** - @name YES - @static - @type Boolean - @default true - @constant -*/ -YES = true; - -/** - @name NO - @static - @type Boolean - @default NO - @constant -*/ -NO = false; - // ensure no undefined errors in browsers where console doesn'...
true
Other
emberjs
ember.js
dc40aa710789e5789802a9d5045ff5787fc75da4.json
Eliminate vestigial YES and NO
packages/ember-runtime/lib/mixins/comparable.js
@@ -24,7 +24,7 @@ Ember.Comparable = Ember.Mixin.create( /** @scope Ember.Comparable.prototype */{ walk like a duck. Indicates that the object can be compared. @type Boolean - @default YES + @default true @constant */ isComparable: true,
true
Other
emberjs
ember.js
dc40aa710789e5789802a9d5045ff5787fc75da4.json
Eliminate vestigial YES and NO
packages/ember-runtime/lib/mixins/enumerable.js
@@ -298,7 +298,7 @@ Ember.Enumerable = Ember.Mixin.create( /** @lends Ember.Enumerable */ { /** Returns an array with all of the items in the enumeration that the passed - function returns YES for. This method corresponds to filter() defined in + function returns true for. This method corresponds to fil...
true
Other
emberjs
ember.js
dc40aa710789e5789802a9d5045ff5787fc75da4.json
Eliminate vestigial YES and NO
packages/ember-runtime/lib/mixins/freezable.js
@@ -71,7 +71,7 @@ Ember.Freezable = Ember.Mixin.create( /** @scope Ember.Freezable.prototype */ { /** - Set to YES when the object is frozen. Use this property to detect whether + Set to true when the object is frozen. Use this property to detect whether your object is frozen or not. @property...
true
Other
emberjs
ember.js
dc40aa710789e5789802a9d5045ff5787fc75da4.json
Eliminate vestigial YES and NO
packages/ember-runtime/lib/mixins/observable.js
@@ -297,7 +297,7 @@ Ember.Observable = Ember.Mixin.create(/** @scope Ember.Observable.prototype */ { }, /** - Returns YES if the object currently has observers registered for a + Returns true if the object currently has observers registered for a particular key. You can use this method to potentially...
true
Other
emberjs
ember.js
dc40aa710789e5789802a9d5045ff5787fc75da4.json
Eliminate vestigial YES and NO
packages/ember-runtime/tests/legacy_1x/mixins/observable/observable_test.js
@@ -513,13 +513,13 @@ test("change dependent should clear cache when observers of dependent are called test('setting one of two computed properties that depend on a third property should clear the kvo cache', function() { // we have to call set twice to fill up the cache - object.set('isOff', YES); - object.set...
true
Other
emberjs
ember.js
dc40aa710789e5789802a9d5045ff5787fc75da4.json
Eliminate vestigial YES and NO
packages/ember-runtime/tests/legacy_1x/mixins/observable/propertyChanges_test.js
@@ -27,7 +27,7 @@ var ObservableObject = Ember.Object.extend(Ember.Observable); -var revMatches = NO , ObjectA; +var revMatches = false , ObjectA; module("object.propertyChanges", { setup: function() {
true
Other
emberjs
ember.js
dc40aa710789e5789802a9d5045ff5787fc75da4.json
Eliminate vestigial YES and NO
packages/ember-runtime/tests/legacy_1x/system/binding_test.js
@@ -182,7 +182,7 @@ test("changing first output should propograte to third after flush", function() equal("change", get(first, "output"), "first.output") ; ok("change" !== get(third, "input"), "third.input") ; - var didChange = YES; + var didChange = true; while(didChange) didChange = Ember.run.sync() ; ...
true
Other
emberjs
ember.js
dc40aa710789e5789802a9d5045ff5787fc75da4.json
Eliminate vestigial YES and NO
packages/ember-runtime/tests/legacy_1x/system/object/base_test.js
@@ -49,7 +49,7 @@ module("A new Ember.Object instance", { aMethodThatExists: function() {}, aMethodThatReturnsTrue: function() { return true; }, aMethodThatReturnsFoobar: function() { return "Foobar"; }, - aMethodThatReturnsFalse: function() { return NO; } + aMethodThatReturnsFalse: funct...
true
Other
emberjs
ember.js
dc40aa710789e5789802a9d5045ff5787fc75da4.json
Eliminate vestigial YES and NO
packages/ember-runtime/tests/legacy_1x/system/object/bindings_test.js
@@ -91,12 +91,12 @@ test("Ember.Binding.bool(TestNamespace.fromObject.bar)) should create binding wi set(fromObject, "bar", 1) ; Ember.run.sync(); - equal(YES, get(testObject, "foo"), "testObject.foo == YES"); + equal(true, get(testObject, "foo"), "testObject.foo == true"); set(fromObject, "bar", 0) ; ...
true
Other
emberjs
ember.js
dc40aa710789e5789802a9d5045ff5787fc75da4.json
Eliminate vestigial YES and NO
packages/ember-runtime/tests/legacy_1x/system/set_test.js
@@ -43,9 +43,9 @@ test("Ember.Set.create() should create empty set", function() { test("Ember.Set.create([1,2,3]) should create set with three items in them", function() { var set = Ember.Set.create(Ember.A([a,b,c])) ; equal(set.length, 3) ; - equal(set.contains(a), YES) ; - equal(set.contains(b), YES) ; - eq...
true
Other
emberjs
ember.js
dc40aa710789e5789802a9d5045ff5787fc75da4.json
Eliminate vestigial YES and NO
packages/ember-views/lib/views/view.js
@@ -51,10 +51,10 @@ Ember.View = Ember.Object.extend( /** @type Boolean - @default YES + @default true @constant */ - isView: YES, + isView: true, // .......................................................... // TEMPLATE SUPPORT @@ -513,7 +513,7 @@ Ember.View = Ember.Object.extend( ...
true
Other
emberjs
ember.js
dc40aa710789e5789802a9d5045ff5787fc75da4.json
Eliminate vestigial YES and NO
packages/ember-views/tests/views/view/create_child_view_test.js
@@ -11,7 +11,7 @@ var view, myViewClass ; module("Ember.View#createChildView", { setup: function() { view = Ember.View.create(); - myViewClass = Ember.View.extend({ isMyView: YES, foo: 'bar' }); + myViewClass = Ember.View.extend({ isMyView: true, foo: 'bar' }); } });
true
Other
emberjs
ember.js
672e25b8d901a9973fce139fcf687b94382e16ab.json
Add Handlebars helper for {{yield}}
packages/ember-handlebars/lib/helpers.js
@@ -11,4 +11,5 @@ require("ember-handlebars/helpers/unbound"); require("ember-handlebars/helpers/debug"); require("ember-handlebars/helpers/each"); require("ember-handlebars/helpers/template"); -require("ember-handlebars/helpers/action"); \ No newline at end of file +require("ember-handlebars/helpers/action"); +requ...
true
Other
emberjs
ember.js
672e25b8d901a9973fce139fcf687b94382e16ab.json
Add Handlebars helper for {{yield}}
packages/ember-handlebars/lib/helpers/yield.js
@@ -0,0 +1,16 @@ +var get = Ember.get, set = Ember.set; + +Ember.Handlebars.registerHelper('yield', function(options) { + var view = options.data.view, template; + + while (view && !get(view, 'layout')) { + view = get(view, 'parentView'); + } + + ember_assert("You called yield in a template that was not a layout...
true
Other
emberjs
ember.js
672e25b8d901a9973fce139fcf687b94382e16ab.json
Add Handlebars helper for {{yield}}
packages/ember-handlebars/tests/helpers/yield_test.js
@@ -0,0 +1,104 @@ +// ========================================================================== +// Project: Ember Handlebar Views +// Copyright: ©2011 Strobe Inc. and contributors. +// License: Licensed under MIT license (see license.js) +// ========================================================================...
true
Other
emberjs
ember.js
ee81cf79c6cac90e2ef60936c7ea6c5f1ba20466.json
Add a .jshintrc
.jshintrc
@@ -0,0 +1,52 @@ +{ + "predef": [ + "jasmine", + "spyOn", + "it", + "console", + "describe", + "expect", + "beforeEach", + "waits", + "waitsFor", + "runs", + "Ember", + "DS", + "ember_assert", + "require", + "equ...
false
Other
emberjs
ember.js
4331b5365034565ae1fadffb0a824c9e4967a00d.json
Add layout support to Ember.View
packages/ember-views/lib/views/view.js
@@ -72,6 +72,18 @@ Ember.View = Ember.Object.extend( */ templateName: null, + /** + The name of the layout to lookup if no layout is provided. + + Ember.View will look for a template with this name in this view's + `templates` object. By default, this will be a global object + shared in `Ember.TEMP...
true