language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | 1fa9fa630fc31a7310fd838c2ee51ac940464a9d.json | Fix EXTEND_PROTOTYPES for sproutcore-runtime | packages/sproutcore-runtime/tests/legacy_1x/system/binding_test.js | @@ -404,7 +404,7 @@ test("toObject.value should be second value if first is falsy", function() {
module("Binding with '[]'", {
setup: function() {
- fromObject = SC.Object.create({ value: [] });
+ fromObject = SC.Object.create({ value: SC.NativeArray.apply([]) });
toObject = SC.Object.create({ value: '... | true |
Other | emberjs | ember.js | 1fa9fa630fc31a7310fd838c2ee51ac940464a9d.json | Fix EXTEND_PROTOTYPES for sproutcore-runtime | packages/sproutcore-runtime/tests/legacy_1x/system/object/base_test.js | @@ -151,10 +151,10 @@ test("Checking the detectInstance() function on an object and its subclass", fun
});
test("subclasses should contain defined subclasses", function() {
- ok(obj.subclasses.contains(obj1), 'obj.subclasses should contain obj1');
+ ok(jQuery.inArray(obj1, obj.subclasses) > -1, 'obj.subclasses sh... | true |
Other | emberjs | ember.js | 1fa9fa630fc31a7310fd838c2ee51ac940464a9d.json | Fix EXTEND_PROTOTYPES for sproutcore-runtime | packages/sproutcore-runtime/tests/legacy_1x/system/object/concatenated_test.js | @@ -37,7 +37,7 @@
var values = get(obj, 'values'),
expected = ['a', 'b', 'c', 'd', 'e', 'f'];
- same(values, expected, "should concatenate values property (expected: %@, got: %@)".fmt(expected, values));
+ same(values, expected, SC.String.fmt("should concatenate values property (expected: %@, got:... | true |
Other | emberjs | ember.js | 1fa9fa630fc31a7310fd838c2ee51ac940464a9d.json | Fix EXTEND_PROTOTYPES for sproutcore-runtime | packages/sproutcore-runtime/tests/legacy_1x/system/set_test.js | @@ -41,7 +41,7 @@ test("SC.Set.create() should create empty set", function() {
});
test("SC.Set.create([1,2,3]) should create set with three items in them", function() {
- var set = SC.Set.create([a,b,c]) ;
+ var set = SC.Set.create(SC.NativeArray.apply([a,b,c])) ;
equals(set.length, 3) ;
equals(set.contain... | true |
Other | emberjs | ember.js | 1fa9fa630fc31a7310fd838c2ee51ac940464a9d.json | Fix EXTEND_PROTOTYPES for sproutcore-runtime | packages/sproutcore-runtime/tests/mixins/array_test.js | @@ -520,7 +520,7 @@ test('modifying the array should also indicate the isDone prop itself has change
testBoth("should be clear caches for computed properties that have dependent keys on arrays that are changed after object initialization", function(get, set) {
var obj = SC.Object.create({
init: function() {
- ... | true |
Other | emberjs | ember.js | 1fa9fa630fc31a7310fd838c2ee51ac940464a9d.json | Fix EXTEND_PROTOTYPES for sproutcore-runtime | packages/sproutcore-runtime/tests/mixins/mutable_array_test.js | @@ -15,7 +15,7 @@ var TestMutableArray = SC.Object.extend(SC.MutableArray, {
_content: null,
init: function(ary) {
- this._content = ary || [];
+ this._content = SC.NativeArray.apply(ary || []);
},
replace: function(idx, amt, objects) { | true |
Other | emberjs | ember.js | 1fa9fa630fc31a7310fd838c2ee51ac940464a9d.json | Fix EXTEND_PROTOTYPES for sproutcore-runtime | packages/sproutcore-runtime/tests/suites/array/indexOf.js | @@ -17,7 +17,7 @@ suite.test("should return index of object", function() {
idx;
for(idx=0;idx<len;idx++) {
- equals(obj.indexOf(expected[idx]), idx, 'obj.indexOf(%@) should match idx'.fmt(expected[idx]));
+ equals(obj.indexOf(expected[idx]), idx, SC.String.fmt('obj.indexOf(%@) should match idx',... | true |
Other | emberjs | ember.js | 1fa9fa630fc31a7310fd838c2ee51ac940464a9d.json | Fix EXTEND_PROTOTYPES for sproutcore-runtime | packages/sproutcore-runtime/tests/suites/array/objectAt.js | @@ -17,7 +17,7 @@ suite.test("should return object at specified index", function() {
idx;
for(idx=0;idx<len;idx++) {
- equals(obj.objectAt(idx), expected[idx], 'obj.objectAt(%@) should match'.fmt(idx));
+ equals(obj.objectAt(idx), expected[idx], SC.String.fmt('obj.objectAt(%@) should match', idx... | true |
Other | emberjs | ember.js | 1fa9fa630fc31a7310fd838c2ee51ac940464a9d.json | Fix EXTEND_PROTOTYPES for sproutcore-runtime | packages/sproutcore-runtime/tests/system/array_proxy/suite_test.js | @@ -10,7 +10,7 @@ SC.MutableArrayTests.extend({
newObject: function(ary) {
var ret = ary ? ary.slice() : this.newFixture(3);
- return new SC.ArrayProxy(ret);
+ return new SC.ArrayProxy(SC.NativeArray.apply(ret));
},
mutate: function(obj) { | true |
Other | emberjs | ember.js | 1fa9fa630fc31a7310fd838c2ee51ac940464a9d.json | Fix EXTEND_PROTOTYPES for sproutcore-runtime | packages/sproutcore-runtime/tests/system/native_array/copyable_suite_test.js | @@ -11,7 +11,7 @@ SC.CopyableTests.extend({
name: 'NativeArray Copyable',
newObject: function() {
- return [SC.generateGuid()];
+ return SC.NativeArray.apply([SC.generateGuid()]);
},
isEqual: function(a,b) { | true |
Other | emberjs | ember.js | 1fa9fa630fc31a7310fd838c2ee51ac940464a9d.json | Fix EXTEND_PROTOTYPES for sproutcore-runtime | packages/sproutcore-runtime/tests/system/native_array/suite_test.js | @@ -9,7 +9,7 @@ SC.MutableArrayTests.extend({
name: 'Native Array',
newObject: function(ary) {
- return ary ? ary.slice() : this.newFixture(3);
+ return SC.NativeArray.apply(ary ? ary.slice() : this.newFixture(3));
},
mutate: function(obj) { | true |
Other | emberjs | ember.js | 2885a044938380e1e0ed78534f76a830297df1e1.json | Fix EXTEND_PROTOTYPES for sproutcore-datetime | packages/sproutcore-datetime/lib/datetime.js | @@ -1013,7 +1013,7 @@ SC.DateTime.reopenClass(SC.Comparable,
if ( opts.month === 2 && opts.day > 29 ){
return null;
}
- if ([4,6,9,11].contains(opts.month) && opts.day > 30) {
+ if (jQuery.inArray(opts.month, [4,6,9,11]) > -1 && opts.day > 30) {
return null;
}
... | true |
Other | emberjs | ember.js | 2885a044938380e1e0ed78534f76a830297df1e1.json | Fix EXTEND_PROTOTYPES for sproutcore-datetime | packages/sproutcore-datetime/tests/datetime_test.js | @@ -33,14 +33,14 @@ function timeShouldBeEqualToHash(t, h, message) {
return;
}
- equals(get(t, 'year'), h.year , message.fmt('year'));
- equals(get(t, 'month'), h.month, message.fmt('month'));
- equals(get(t, 'day'), h.day, message.fmt('day'));
- equals(get(t, 'hour'), h.hour, message.fmt('hour'));
-... | true |
Other | emberjs | ember.js | d7a0fa8c76e0ef0b84dcfccf0df973f6bbd92092.json | Fix documentation for template helper | packages/sproutcore-handlebars/lib/helpers/template.js | @@ -24,10 +24,10 @@ require('sproutcore-handlebars/ext');
SC.TEMPLATES["my_cool_template"] = SC.Handlebars.compile('<b>{{user}}</b>');
- @name Handlebars.helpers.unbound
- @param {String} property
- @returns {String} HTML string
+ @name Handlebars.helpers.template
+ @param {String} templateName the temp... | false |
Other | emberjs | ember.js | e57f0c04219f86683bbe32a2a1d802caec98809c.json | Allow binding to this | packages/sproutcore-handlebars/lib/helpers/view.js | @@ -62,7 +62,11 @@ SC.Handlebars.ViewHelper = SC.Object.create({
if (PARENT_VIEW_PATH.test(path)) {
SC.Logger.warn("As of SproutCore 2.0 beta 3, it is no longer necessary to bind to parentViews. Instead, please provide binding paths relative to the current Handlebars context.");
} els... | true |
Other | emberjs | ember.js | e57f0c04219f86683bbe32a2a1d802caec98809c.json | Allow binding to this | packages/sproutcore-handlebars/tests/handlebars_test.js | @@ -1302,6 +1302,28 @@ test("bindings should be relative to the current context", function() {
equals($.trim(view.$().text()), "Name: SFMoMA Price: $20", "should print baz twice");
});
+test("bindings can be 'this', in which case they *are* the current context", function() {
+ view = SC.View.create({
+ museum... | true |
Other | emberjs | ember.js | 3e525e29c0b1f906186f202fe95a9246401d7de3.json | Add detectInstance to classes | packages/sproutcore-runtime/lib/system/core_object.js | @@ -181,6 +181,10 @@ var ClassMixin = SC.Mixin.create({
obj = obj.superclass;
}
return false;
+ },
+
+ detectInstance: function(obj) {
+ return this.PrototypeMixin.detect(obj);
}
}); | true |
Other | emberjs | ember.js | 3e525e29c0b1f906186f202fe95a9246401d7de3.json | Add detectInstance to classes | packages/sproutcore-runtime/tests/legacy_1x/system/object/base_test.js | @@ -145,6 +145,11 @@ test("Checking the detect() function on an object and its subclass", function(){
equals(obj1.detect(obj), NO);
});
+test("Checking the detectInstance() function on an object and its subclass", function() {
+ ok(SC.Object.detectInstance(obj.create()));
+ ok(obj.detectInstance(obj.create()));
... | true |
Other | emberjs | ember.js | 4532f0a3afeab665f244acef9139f99de477b93d.json | Add disabled binding to all controls | packages/sproutcore-handlebars/lib/controls/button.js | @@ -11,9 +11,10 @@ SC.Button = SC.View.extend({
classNameBindings: ['isActive'],
tagName: 'button',
- attributeBindings: ['type'],
+ attributeBindings: ['type', 'disabled'],
type: 'button',
-
+ disabled: false,
+
targetObject: function() {
var target = get(this, 'target');
| true |
Other | emberjs | ember.js | 4532f0a3afeab665f244acef9139f99de477b93d.json | Add disabled binding to all controls | packages/sproutcore-handlebars/lib/controls/checkbox.js | @@ -17,10 +17,11 @@ var set = SC.set, get = SC.get;
SC.Checkbox = SC.View.extend({
title: null,
value: false,
+ disabled: false,
classNames: ['sc-checkbox'],
- defaultTemplate: SC.Handlebars.compile('<label><input type="checkbox" {{bindAttr checked="value"}}>{{title}}</label>'),
+ defaultTemplate: SC.H... | true |
Other | emberjs | ember.js | 4532f0a3afeab665f244acef9139f99de477b93d.json | Add disabled binding to all controls | packages/sproutcore-handlebars/lib/controls/text_area.js | @@ -16,8 +16,9 @@ SC.TextArea = SC.View.extend({
tagName: "textarea",
value: "",
- attributeBindings: ['placeholder'],
+ attributeBindings: ['placeholder', 'disabled'],
placeholder: null,
+ disabled: false,
insertNewline: SC.K,
cancel: SC.K, | true |
Other | emberjs | ember.js | 4532f0a3afeab665f244acef9139f99de477b93d.json | Add disabled binding to all controls | packages/sproutcore-handlebars/lib/controls/text_field.js | @@ -19,10 +19,11 @@ SC.TextField = SC.View.extend(
cancel: SC.K,
tagName: "input",
- attributeBindings: ['type', 'placeholder', 'value'],
+ attributeBindings: ['type', 'placeholder', 'value', 'disabled'],
type: "text",
value: "",
placeholder: null,
+ disabled: false,
focusOut: function(event) {... | true |
Other | emberjs | ember.js | 4532f0a3afeab665f244acef9139f99de477b93d.json | Add disabled binding to all controls | packages/sproutcore-handlebars/lib/views/metamorph_view.js | @@ -31,6 +31,7 @@ SC.Metamorph = SC.Mixin.create({
domManagerClass: SC.Object.extend({
remove: function(view) {
var morph = getPath(this, 'view.morph');
+ if (morph.isRemoved()) { return; }
getPath(this, 'view.morph').remove();
},
| true |
Other | emberjs | ember.js | 4532f0a3afeab665f244acef9139f99de477b93d.json | Add disabled binding to all controls | packages/sproutcore-handlebars/tests/controls/button_test.js | @@ -24,6 +24,30 @@ function synthesizeEvent(type, view) {
view.$().trigger(type);
}
+function append() {
+ SC.run(function() {
+ button.appendTo('#qunit-fixture');
+ });
+}
+
+test("should become disabled if the disabled attribute is true", function() {
+ button.set('disabled', true);
+ append();
+
+ ok(b... | true |
Other | emberjs | ember.js | 4532f0a3afeab665f244acef9139f99de477b93d.json | Add disabled binding to all controls | packages/sproutcore-handlebars/tests/controls/checkbox_test.js | @@ -22,6 +22,34 @@ function setAndFlush(view, key, value) {
});
}
+function append() {
+ SC.run(function() {
+ checkboxView.appendTo('#qunit-fixture');
+ });
+}
+
+test("should become disabled if the disabled attribute is true", function() {
+ checkboxView = SC.Checkbox.create({});
+
+ checkboxView.set('di... | true |
Other | emberjs | ember.js | 4532f0a3afeab665f244acef9139f99de477b93d.json | Add disabled binding to all controls | packages/sproutcore-handlebars/tests/controls/text_area_test.js | @@ -23,6 +23,30 @@ module("SC.TextArea", {
}
});
+function append() {
+ SC.run(function() {
+ textArea.appendTo('#qunit-fixture');
+ });
+}
+
+test("should become disabled if the disabled attribute is true", function() {
+ textArea.set('disabled', true);
+ append();
+
+ ok(textArea.$().is(":disabled"));
+... | true |
Other | emberjs | ember.js | 4532f0a3afeab665f244acef9139f99de477b93d.json | Add disabled binding to all controls | packages/sproutcore-handlebars/tests/controls/text_field_test.js | @@ -23,6 +23,30 @@ module("SC.TextField", {
}
});
+function append() {
+ SC.run(function() {
+ textField.appendTo('#qunit-fixture');
+ });
+}
+
+test("should become disabled if the disabled attribute is true", function() {
+ textField.set('disabled', true);
+ append();
+
+ ok(textField.$().is(":disabled")... | true |
Other | emberjs | ember.js | e27f9fe458ad798bacd545c10ba3b53104b5bc9c.json | Use arguments rather than an array of keys | packages/sproutcore-runtime/lib/mixins/observable.js | @@ -67,17 +67,17 @@ SC.Observable = SC.Mixin.create(/** @scope SC.Observable.prototype */ {
/**
To get multiple properties at once, call getProperties
- with an Array:
+ with a list of strings:
- record.getProperties(['firstName', 'lastName', 'zipCode']);
+ record.getProperties('firs... | true |
Other | emberjs | ember.js | e27f9fe458ad798bacd545c10ba3b53104b5bc9c.json | Use arguments rather than an array of keys | packages/sproutcore-runtime/tests/mixins/observable_test.js | @@ -10,10 +10,10 @@ test('should be able to use getProperties to get a POJO of provided keys', funct
var obj = SC.Object.create({
firstName: "Steve",
lastName: "Jobs",
- zipCode: 94301
+ companyName: "Apple, Inc."
});
- var pojo = obj.getProperties("firstName lastName".w());
+ var pojo = obj... | true |
Other | emberjs | ember.js | 770452df78031bd6a42f28879259bec160abe523.json | Allow use of {{this}} inside {{#each}} | packages/sproutcore-handlebars/lib/helpers/binding.js | @@ -47,8 +47,12 @@ var get = SC.get, getPath = SC.getPath, set = SC.set, fmt = SC.String.fmt;
});
// Observes the given property on the context and
- // tells the SC._BindableSpan to re-render.
- SC.addObserver(ctx, property, observer);
+ // tells the SC._BindableSpan to re-render. If pro... | true |
Other | emberjs | ember.js | 770452df78031bd6a42f28879259bec160abe523.json | Allow use of {{this}} inside {{#each}} | packages/sproutcore-handlebars/lib/views/bindable_span.js | @@ -109,7 +109,16 @@ SC._BindableSpanView = SC.View.extend(SC.Metamorph,
var inverseTemplate = get(this, 'inverseTemplate'),
displayTemplate = get(this, 'displayTemplate');
- var result = getPath(context, property);
+ var result;
+
+
+ // Use the current context as the result if no
+ // prop... | true |
Other | emberjs | ember.js | 770452df78031bd6a42f28879259bec160abe523.json | Allow use of {{this}} inside {{#each}} | packages/sproutcore-handlebars/tests/each_test.js | @@ -41,5 +41,16 @@ test("it updates the view if an item is added", function() {
people.pushObject({ name: "Tom Dale" });
});
- assertHTML(view, "Steve HoltAnnabelleTom Dale")
+ assertHTML(view, "Steve HoltAnnabelleTom Dale");
+});
+
+test("it allows you to access the current context using {{this}}", functio... | true |
Other | emberjs | ember.js | 68e5dadca88bb0b4cf9bcdd00d3ac970ea28be39.json | Add getProperties method to SC.Observable | packages/sproutcore-runtime/lib/mixins/observable.js | @@ -64,6 +64,23 @@ SC.Observable = SC.Mixin.create(/** @scope SC.Observable.prototype */ {
get: function(keyName) {
return get(this, keyName);
},
+
+ /**
+ To get multiple properties at once, call getProperties
+ with an Array:
+
+ record.getProperties(['firstName', 'lastName', 'zipCode']);
+... | true |
Other | emberjs | ember.js | 68e5dadca88bb0b4cf9bcdd00d3ac970ea28be39.json | Add getProperties method to SC.Observable | packages/sproutcore-runtime/tests/mixins/observable_test.js | @@ -0,0 +1,19 @@
+// ==========================================================================
+// Project: SproutCore Runtime
+// Copyright: ©2011 Strobe Inc. and contributors.
+// License: Licensed under MIT license (see license.js)
+// ==========================================================================
+
... | true |
Other | emberjs | ember.js | d191f7bf142c54d29ab25e3389f0f0e8a964efcf.json | Fix binding tests to not use SC.Object | packages/sproutcore-metal/tests/binding/and_test.js | @@ -8,11 +8,11 @@ var MyApp, set = SC.set, get = SC.get;
module('binding/and', {
setup: function() {
- MyApp = SC.Object.create({
+ MyApp = {
foo: false,
- bar: false,
- bazBinding: SC.Binding.and('foo', 'bar')
- });
+ bar: false
+ };
+ SC.Binding.and("foo", "bar").to("baz").c... | true |
Other | emberjs | ember.js | d191f7bf142c54d29ab25e3389f0f0e8a964efcf.json | Fix binding tests to not use SC.Object | packages/sproutcore-metal/tests/binding/bool_not_test.js | @@ -15,10 +15,10 @@ function testBool(val, expected) {
module('system/binding/bool', {
setup: function() {
- MyApp = SC.Object.create({
- foo: SC.Object.create({ value: 'FOO' }),
- bar: SC.Object.create({ value: 'BAR' })
- });
+ MyApp = {
+ foo: { value: 'FOO' },
+ bar: { value: 'BAR'... | true |
Other | emberjs | ember.js | d191f7bf142c54d29ab25e3389f0f0e8a964efcf.json | Fix binding tests to not use SC.Object | packages/sproutcore-metal/tests/binding/connect_test.js | @@ -36,7 +36,7 @@ function performTest(binding, a, b, get, set, skipFirst) {
}
testBoth('Connecting a binding between two properties', function(get, set) {
- var a = SC.Object.create({ foo: 'FOO', bar: 'BAR' });
+ var a = { foo: 'FOO', bar: 'BAR' };
// a.bar -> a.foo
var binding = new SC.Binding('foo', ... | true |
Other | emberjs | ember.js | d191f7bf142c54d29ab25e3389f0f0e8a964efcf.json | Fix binding tests to not use SC.Object | packages/sproutcore-metal/tests/binding/multiple_test.js | @@ -7,10 +7,10 @@
module('system/binding/multiple', {
setup: function() {
- MyApp = SC.Object.create({
- foo: SC.Object.create({ value: 'FOO' }),
- bar: SC.Object.create({ value: 'BAR' })
- });
+ MyApp = {
+ foo: { value: 'FOO' },
+ bar: { value: 'BAR' }
+ };
},
teardown: f... | true |
Other | emberjs | ember.js | d191f7bf142c54d29ab25e3389f0f0e8a964efcf.json | Fix binding tests to not use SC.Object | packages/sproutcore-metal/tests/binding/notEmpty_test.js | @@ -7,10 +7,10 @@
module('system/binding/notEmpty', {
setup: function() {
- MyApp = SC.Object.create({
- foo: SC.Object.create({ value: 'FOO' }),
- bar: SC.Object.create({ value: 'BAR' })
- });
+ MyApp = {
+ foo: { value: 'FOO' },
+ bar: { value: 'BAR' }
+ };
},
teardown: f... | true |
Other | emberjs | ember.js | d191f7bf142c54d29ab25e3389f0f0e8a964efcf.json | Fix binding tests to not use SC.Object | packages/sproutcore-metal/tests/binding/notNull_test.js | @@ -7,10 +7,10 @@
module('system/binding/notNull', {
setup: function() {
- MyApp = SC.Object.create({
- foo: SC.Object.create({ value: 'FOO' }),
- bar: SC.Object.create({ value: 'BAR' })
- });
+ MyApp = {
+ foo: { value: 'FOO' },
+ bar: { value: 'BAR' }
+ };
},
teardown: fu... | true |
Other | emberjs | ember.js | d191f7bf142c54d29ab25e3389f0f0e8a964efcf.json | Fix binding tests to not use SC.Object | packages/sproutcore-metal/tests/binding/oneWay_test.js | @@ -7,9 +7,9 @@
module('system/mixin/binding/oneWay_test', {
setup: function() {
- MyApp = SC.Object.create({
- foo: SC.Object.create({ value: 'FOO' }),
- bar: SC.Object.create({ value: 'BAR' })
+ MyApp = {
+ foo: { value: 'FOO' },
+ bar: { value: 'BAR' }
});
},
| true |
Other | emberjs | ember.js | d191f7bf142c54d29ab25e3389f0f0e8a964efcf.json | Fix binding tests to not use SC.Object | packages/sproutcore-metal/tests/binding/single_test.js | @@ -7,10 +7,10 @@
module('system/binding/single', {
setup: function() {
- MyApp = SC.Object.create({
- foo: SC.Object.create({ value: 'FOO' }),
- bar: SC.Object.create({ value: 'BAR' })
- });
+ MyApp = {
+ foo: { value: 'FOO' },
+ bar: { value: 'BAR' }
+ };
},
teardown: fun... | true |
Other | emberjs | ember.js | 13260bf514863b5453ee5bd5073c1dabd16d94c9.json | Improve mixin function, remove object require. | packages/sproutcore-runtime/lib/system/binding.js | @@ -5,7 +5,6 @@
// ==========================================================================
/*globals sc_assert */
-require('sproutcore-runtime/system/object');
require('sproutcore-runtime/system/run_loop');
// ..........................................................
@@ -692,15 +691,15 @@ Binding.prototype ... | false |
Other | emberjs | ember.js | 94d0bb71aa1fa8bc82a902aa608ea4b29d043aac.json | Fix comment typo in SC.inspect | packages/sproutcore-runtime/lib/core.js | @@ -292,7 +292,7 @@ SC.copy = function(obj, deep) {
Convenience method to inspect an object. This method will attempt to
convert the object into a useful string description.
- @param {Object} obj The object you want to inspec.
+ @param {Object} obj The object you want to inspect.
@returns {String} A descri... | false |
Other | emberjs | ember.js | 817a8c840c83aa90aa084dbab1182bd7e712bb83.json | Add helper for exception-safe beginPropertyChanges
I found myself using this pattern enough that I think it belongs in
the library. This is a safer way to use beginPropertyChanges. It's
analogous to using the block form of Ruby's "open", or using Python's
"with" statement. | packages/sproutcore-metal/lib/observer.js | @@ -84,6 +84,15 @@ SC.endPropertyChanges = function() {
if (suspended<=0) flushObserverQueue();
};
+SC.batchPropertyChanges = function(cb){
+ SC.beginPropertyChanges();
+ try {
+ cb()
+ } finally {
+ SC.endPropertyChanges();
+ }
+}
+
function changeEvent(keyName) {
return keyName+AFTER_OBSERVERS;
} | true |
Other | emberjs | ember.js | 817a8c840c83aa90aa084dbab1182bd7e712bb83.json | Add helper for exception-safe beginPropertyChanges
I found myself using this pattern enough that I think it belongs in
the library. This is a safer way to use beginPropertyChanges. It's
analogous to using the block form of Ruby's "open", or using Python's
"with" statement. | packages/sproutcore-metal/tests/observer_test.js | @@ -74,6 +74,35 @@ testBoth('suspending property changes will defer', function(get,set) {
equals(fooCount, 1, 'foo should have fired once');
});
+testBoth('suspending property changes safely despite exceptions', function(get,set) {
+ var obj = { foo: 'foo' };
+ var fooCount = 0;
+ var exc = new Error("Somethin... | true |
Other | emberjs | ember.js | aba456d48fb58d1ece980a542abb5e38476930ac.json | remove debugging cruft | packages/sproutcore-touch/tests/gesture_recognizers/pan_test.js | @@ -135,9 +135,7 @@ test("If the touches move, the translation should reflect the change", function(
}]
};
- window.foo=true;
view.$().trigger(touchEvent);
- window.foo=false;
equals(get(get(get(view, 'eventManager'), 'gestures')[0], 'state'),SC.Gesture.BEGAN, "gesture should be BEGAN");
| false |
Other | emberjs | ember.js | ce52f618113242a8464e38eac94c984ddac1c72c.json | Extract SC.TouchList into its own file | packages/sproutcore-touch/lib/system/gesture.js | @@ -12,77 +12,6 @@ var set = SC.set;
var sigFigs = 100;
-SC.TouchList = SC.Object.extend({
- touches: null,
-
- timestamp: null,
-
- init: function() {
- this._super();
-
- set(this, 'touches', []);
- },
-
- addTouch: function(touch) {
- var touches = get(this, 'touches');
- touches.push(touch);
-... | true |
Other | emberjs | ember.js | ce52f618113242a8464e38eac94c984ddac1c72c.json | Extract SC.TouchList into its own file | packages/sproutcore-touch/lib/system/touch_list.js | @@ -0,0 +1,86 @@
+// ==========================================================================
+// Project: SproutCore Touch
+// Copyright: ©2011 Strobe Inc. and contributors.
+// License: Licensed under MIT license (see license.js)
+// ==========================================================================
+
+v... | true |
Other | emberjs | ember.js | b03a2da383f375ee6766df46900dd440a83165ce.json | Fix typo in enumerable docs | packages/sproutcore-runtime/lib/mixins/enumerable.js | @@ -91,7 +91,7 @@ SC.Enumerable = SC.Mixin.create( /** @lends SC.Enumerable */ {
to nextObject for the current iteration. This is a useful way to
manage iteration if you are tracing a linked list, for example.
- Finally the context paramter will always contain a hash you can use as
+ Finally the cont... | false |
Other | emberjs | ember.js | 20b6082b02a16dc6bc720bfebb6a404743435667.json | Fix math bug in pinch | packages/sproutcore-touch/lib/gesture_recognizers/pinch.js | @@ -118,7 +118,7 @@ SC.PinchGestureRecognizer = SC.Gesture.extend({
var distanceDifference = (currentDistanceBetweenTouches - this._previousDistance);
set(this, 'velocity', distanceDifference / timeDifference);
- set(this, 'scale', distanceDifference / this._previousDistance);
+ set(this, 'scale', cur... | false |
Other | emberjs | ember.js | a1131aa5fe698167043240e40893f71d7bb2ceaf.json | Fix bugs with pan since changing API for cssHooks | packages/sproutcore-touch/lib/gesture_recognizers/pan.js | @@ -87,11 +87,11 @@ SC.PanGestureRecognizer = SC.Gesture.extend({
},
shouldBegin: function() {
- var previous = this._previousLocation;
- var current = this.centerPointForTouches(get(this.touches,'touches'));
+ var previousLocation = this._previousLocation;
+ var currentLocation = this.centerPointFo... | false |
Other | emberjs | ember.js | 5b89dfdb7db918e839c61e2f99c77a76c63dd3e5.json | Fix package.jsons for subprojects | packages/handlebars/package.json | @@ -4,7 +4,7 @@
"description": "A semantic templating language for JavaScript",
"homepage": "http://www.handlebarsjs.com",
"author": "Yehuda Katz",
- "version": "1.0.0.beta.2",
+ "version": "1.0.0.beta.3",
"directories": {
"lib": "lib" | true |
Other | emberjs | ember.js | 5b89dfdb7db918e839c61e2f99c77a76c63dd3e5.json | Fix package.jsons for subprojects | packages/sproutcore-handlebars-format/package.json | @@ -1,8 +1,9 @@
{
"name": "sproutcore-handlebars-format",
- "version": "2.0.beta.3",
+ "version": "1.0.1",
"description": "Adds format support for handlebars templates",
"homepage": "http://www.sproutcore.com",
+ "author": "Charles Jolley",
"bpm:build": {
"bpm_libs.js": { | true |
Other | emberjs | ember.js | 5b89dfdb7db918e839c61e2f99c77a76c63dd3e5.json | Fix package.jsons for subprojects | packages/sproutcore-handlebars/package.json | @@ -7,11 +7,10 @@
"version": "2.0.beta.3",
"dependencies": {
"spade": "~> 1.0.0",
- "handlebars": "~> 1.0.0.beta.2",
+ "handlebars": "~> 1.0.0.beta.3",
"sproutcore-views": "2.0.beta.3",
- "sproutcore-runtime": "2.0.beta.3",
- "sproutcore-handlebars-format": "~> 2... | true |
Other | emberjs | ember.js | 5b89dfdb7db918e839c61e2f99c77a76c63dd3e5.json | Fix package.jsons for subprojects | packages/sproutcore/package.json | @@ -11,7 +11,7 @@
"sproutcore-runtime": "2.0.beta.3",
"sproutcore-views": "2.0.beta.3",
"sproutcore-handlebars": "2.0.beta.3",
- "sproutcore-handlebars-format": "2.0.beta.3"
+ "sproutcore-handlebars-format": "~> 1.0.0"
},
"directories": {
@@ -31,5 +31,4 @@
"main": "sproutcore-handleb... | true |
Other | emberjs | ember.js | 525345a968eb2e523e192c7f74c5e8117bbe2f08.json | Fix broken package dependencies. Fixed #126 | packages/sproutcore-handlebars/package.json | @@ -10,7 +10,7 @@
"handlebars": "~> 1.0.0.beta.2",
"sproutcore-views": "2.0.beta.3",
"sproutcore-runtime": "2.0.beta.3",
- "sproutcore-handlebars-format": "~> 1.0.0"
+ "sproutcore-handlebars-format": "~> 2.0.beta.3"
},
"directories": { | true |
Other | emberjs | ember.js | 525345a968eb2e523e192c7f74c5e8117bbe2f08.json | Fix broken package dependencies. Fixed #126 | packages/sproutcore-touch/package.json | @@ -13,7 +13,7 @@
"dependencies": {
"spade" : "~> 1.0",
"jquery" : "~> 1.6",
- "sproutcore-views" : "2.0.beta.2"
+ "sproutcore-views" : "2.0.beta.3"
},
"dependencies:development": { | true |
Other | emberjs | ember.js | 525345a968eb2e523e192c7f74c5e8117bbe2f08.json | Fix broken package dependencies. Fixed #126 | packages/sproutcore/package.json | @@ -8,10 +8,10 @@
"dependencies": {
"spade": "~> 1.0.0",
- "sproutcore-runtime": "2.0.beta.3"
- "sproutcore-views": "2.0.beta.3"
- "sproutcore-handlebars": "2.0.beta.3"
- "sproutcore-handlebars-format": "~> 1.0.0"
+ "sproutcore-runtime": "2.0.beta.3",
+ "sproutcore-views": "2... | true |
Other | emberjs | ember.js | cdace7e3957374f2dcb02e89eebf05dacfa1b66a.json | Remove references to spaderun from readme | README.md | @@ -119,7 +119,4 @@ example, to run all of the unit tests together:
# Adding New Packages
-Be sure you include the new package as a dependency in the global `package.json` and run `spaderun update`.
-
-Note that unless you are adding new __tests__ or adding a new package you should not need to run `spaderun update... | false |
Other | emberjs | ember.js | 87aac6902b8113179ffb2e731850d2706370baba.json | Add support for two-way binding transforms | packages/sproutcore-runtime/lib/system/binding.js | @@ -8,8 +8,6 @@
require('sproutcore-runtime/system/object');
require('sproutcore-runtime/system/run_loop');
-
-
// ..........................................................
// CONSTANTS
//
@@ -125,7 +123,10 @@ function getTransformedValue(binding, val, obj, dir) {
len = transforms ? transforms.len... | true |
Other | emberjs | ember.js | 87aac6902b8113179ffb2e731850d2706370baba.json | Add support for two-way binding transforms | packages/sproutcore-runtime/tests/system/binding/transform_test.js | @@ -5,7 +5,7 @@
// ==========================================================================
/*globals MyApp */
-var foo, bar;
+var foo, bar, binding, set = SC.set, get = SC.get, setPath = SC.setPath;
var CountObject = SC.Object.extend({
value: null,
@@ -34,20 +34,21 @@ module('system/mixin/binding/transform... | true |
Other | emberjs | ember.js | 0ffa758cd39fbc11c38fe00011457c218feb39f3.json | Remove debugger statement from unit test | packages/sproutcore-handlebars/tests/handlebars_test.js | @@ -1204,10 +1204,8 @@ test("should not enter an infinite loop when binding an attribute in Handlebars"
classNames: ['app-link'],
tagName: 'a',
attributeBindings: ['href'],
- // href: '#none',
- href: function(key, value) {
- debugger;
- }.property(),
+ href: '#none',
+
click: funct... | false |
Other | emberjs | ember.js | bc03cd87d3ed927468702b6bf3fe130a06c317eb.json | Add unit test for GH Issue #120 | packages/sproutcore-handlebars/tests/handlebars_test.js | @@ -1193,3 +1193,38 @@ test("bindings should be relative to the current context", function() {
equals($.trim(view.$().text()), "Name: SFMoMA Price: $20", "should print baz twice");
});
+
+
+// https://github.com/sproutcore/sproutcore20/issues/120
+
+test("should not enter an infinite loop when binding an attribut... | true |
Other | emberjs | ember.js | bc03cd87d3ed927468702b6bf3fe130a06c317eb.json | Add unit test for GH Issue #120 | packages/sproutcore-views/tests/views/view/attribute_bindings_test.js | @@ -78,10 +78,9 @@ test("should allow attributes to be set in the inBuffer state", function() {
parentView.append();
});
- window.billy = true;
equals(parentView.get('childViews')[0].$().attr('foo'), 'baz');
- window.billy = false;
parentView.destroy();
});
+ | true |
Other | emberjs | ember.js | df1726a0295ce33d1cd1d5540f7f4ebdfd47b07f.json | Add some better errors for set | packages/sproutcore-metal/lib/accessors.js | @@ -55,19 +55,21 @@ if (!USE_ACCESSORS) {
var o_get = get, o_set = set;
get = function(obj, keyName) {
-
if (keyName === undefined && 'string' === typeof obj) {
keyName = obj;
obj = SC;
}
+ sc_assert("You need to provide an object and key to `get`.", obj && keyName);
+
if (!o... | true |
Other | emberjs | ember.js | df1726a0295ce33d1cd1d5540f7f4ebdfd47b07f.json | Add some better errors for set | packages/sproutcore-metal/lib/utils.js | @@ -172,6 +172,8 @@ if (Object.freeze) Object.freeze(EMPTY_META);
@returns {Hash}
*/
SC.meta = function meta(obj, writable) {
+ sc_assert("You must pass an object to SC.meta. This was probably called from SproutCore internals, so you probably called a SproutCore method with undefined that was expecting an object"... | true |
Other | emberjs | ember.js | 8282f906e183143095f6fcbf2aa991089dd4b216.json | Add ability to unregister gestures from the system | packages/sproutcore-touch/lib/system/gestures.js | @@ -45,6 +45,14 @@ SC.Gestures = SC.Object.create(
registeredGestures[name] = recognizer;
},
+ unregister: function(name) {
+ var registeredGestures = this._registeredGestures;
+
+ if (registeredGestures[name] !== undefined) {
+ registeredGestures[name] = undefined;
+ }
+ },
+
/**
Regi... | true |
Other | emberjs | ember.js | 8282f906e183143095f6fcbf2aa991089dd4b216.json | Add ability to unregister gestures from the system | packages/sproutcore-touch/tests/system/gestures_test.js | @@ -40,3 +40,20 @@ test("register new gestures", function() {
ok(caught);
});
+test("unregister a gesture", function() {
+ var myGesture = SC.Gesture.create({
+ isMyGesture: true
+ });
+
+ SC.Gestures.register('myGesture2',myGesture);
+
+ var newGestures = SC.Gestures.knownGestures();
+
+ equals(newGestur... | true |
Other | emberjs | ember.js | 274a545562554f631eb85a99874a26f433d97f3a.json | Fix failing unit tests in tap gesture recognizer | packages/sproutcore-touch/lib/gesture_recognizers/tap.js | @@ -47,13 +47,21 @@ SC.TapGestureRecognizer = SC.Gesture.extend({
didBegin: function() {
this._initialLocation = this.centerPointForTouches(this._touches);
- this._waitingForMoreTouches = true;
- this._waitingInterval = window.setInterval(this._intervalFired,this.MULTITAP_DELAY);
+ if (this._numActiv... | true |
Other | emberjs | ember.js | 274a545562554f631eb85a99874a26f433d97f3a.json | Fix failing unit tests in tap gesture recognizer | packages/sproutcore-touch/lib/system/gesture.js | @@ -129,6 +129,7 @@ SC.Gesture = SC.Object.extend(
if (get(this, 'gestureIsDiscrete') && this.shouldBegin()) {
set(this, 'state', SC.Gesture.BEGAN);
this.didBegin();
+ this.attemptGestureEventDelivery(evt, view, get(this, 'name')+'Start');
} else {
set(this, 'state', SC.G... | true |
Other | emberjs | ember.js | 274a545562554f631eb85a99874a26f433d97f3a.json | Fix failing unit tests in tap gesture recognizer | packages/sproutcore-touch/tests/gesture_recognizers/tap_test.js | @@ -53,7 +53,7 @@ module("Tap Test",{
}
});
-test("one start event should put it in possible state", function() {
+test("one start event should put it in began state", function() {
var numStart = 0;
var touchEvent = jQuery.Event('touchstart');
touchEvent['originalEvent'] = {
@@ -69,7 +69,7 @@ test("one s... | true |
Other | emberjs | ember.js | 4487868a59e62df945b98ab90280888b3534b480.json | Fix required file in ArrayController. | packages/sproutcore-runtime/lib/controllers/array_controller.js | @@ -4,6 +4,8 @@
// License: Licensed under MIT license (see license.js)
// ==========================================================================
+require('sproutcore-runtime/system/array_proxy');
+
/**
@class
| false |
Other | emberjs | ember.js | 69d1e7f5aab8afecd10500c158a9f954cb5e8065.json | Add stubs for methods that may not be implemented | packages/sproutcore-touch/lib/system/gesture.js | @@ -175,14 +175,17 @@ SC.Gesture = SC.Object.extend(
touchEnd: function(evt, view, manager) {
if (get(this, 'gestureIsDiscrete')) {
+
if (this.state === SC.Gesture.BEGAN && this.gestureShouldEnd()) {
set(this, 'state', SC.Gesture.ENDED);
this.attemptGestureEventDelivery(evt, view, get... | false |
Other | emberjs | ember.js | f5dd39206f9727952b7a583ac60ba7630c2305b1.json | Preserve old behavior for special '@each' keys.
While it would be better to rewrite EachProxy, that would be a much
bigger change. | packages/sproutcore-metal/lib/watching.js | @@ -136,6 +136,11 @@ var ChainNode = function(parent, key, value, separator) {
this._object = parent.value();
if (this._object) addChainWatcher(this._object, this._key, this);
}
+
+ // Special-case: the EachProxy relies on immediate evaluation to
+ // establish its observers.
+ if (this._parent && this.... | false |
Other | emberjs | ember.js | 576b3b3a5cdeb70bb1796b252c9b421827c17e09.json | remove magictouch require | packages/sproutcore-touch/lib/system.js | @@ -1,5 +1,4 @@
require('sproutcore-touch/system/gesture');
require('sproutcore-touch/system/view');
-require('sproutcore-touch/system/magictouch');
require('sproutcore-touch/system/gesture_manager');
require('sproutcore-touch/system/gestures'); | false |
Other | emberjs | ember.js | 0b3739b559f206de25befdbbabf212ac8843a240.json | Fix bugs in pinch behavior | packages/sproutcore-touch/lib/gesture_recognizers/pinch.js | @@ -100,14 +100,18 @@ SC.PinchGestureRecognizer = SC.Gesture.extend({
},
touchMove: function(evt, view, manager) {
+ if (this.state === SC.Gesture.ENDED || this.state === SC.Gesture.CANCELLED) {
+ manager.redispatchEventToView(view,'touchmove', evt);
+ return;
+ }
var changedTouches = evt.o... | false |
Other | emberjs | ember.js | 0bb1a5a1ab73c89faee1ae27be978399ad18a534.json | Add statechart building to Rakefile | Rakefile | @@ -53,7 +53,7 @@ end
# Create sproutcore:package tasks for each of the SproutCore packages
namespace :sproutcore do
- %w(metal indexset runtime handlebars views datastore).each do |package|
+ %w(metal indexset runtime handlebars views datastore statechart).each do |package|
task package => compile_package_t... | false |
Other | emberjs | ember.js | c013c8899bceb52a500431cbd28272716d45a98a.json | Remove unneeded variables. | packages/sproutcore-handlebars/lib/helpers/debug.js | @@ -7,7 +7,7 @@
require('sproutcore-handlebars/ext');
-var get = SC.get, getPath = SC.getPath;
+var getPath = SC.getPath;
/**
`log` allows you to output the value of a value in the current rendering | true |
Other | emberjs | ember.js | c013c8899bceb52a500431cbd28272716d45a98a.json | Remove unneeded variables. | packages/sproutcore-handlebars/lib/helpers/unbound.js | @@ -7,7 +7,7 @@
require('sproutcore-handlebars/ext');
-var get = SC.get, getPath = SC.getPath;
+var getPath = SC.getPath;
/**
`unbound` allows you to output a property without binding. *Important:* The | true |
Other | emberjs | ember.js | 7e85b964408e75678fd74d447007a1bdb9d50ed0.json | Add a couple of debugging Handlebars extensions | packages/sproutcore-handlebars/lib/helpers.js | @@ -8,3 +8,4 @@ require("sproutcore-handlebars/helpers/binding");
require("sproutcore-handlebars/helpers/collection");
require("sproutcore-handlebars/helpers/view");
require("sproutcore-handlebars/helpers/unbound");
+require("sproutcore-handlebars/helpers/debug"); | true |
Other | emberjs | ember.js | 7e85b964408e75678fd74d447007a1bdb9d50ed0.json | Add a couple of debugging Handlebars extensions | packages/sproutcore-handlebars/lib/helpers/debug.js | @@ -0,0 +1,36 @@
+// ==========================================================================
+// Project: SproutCore Handlebar Views
+// Copyright: ©2011 Strobe Inc. and contributors.
+// License: Licensed under MIT license (see license.js)
+// ====================================================================... | true |
Other | emberjs | ember.js | 4d492e426b3c92b432babedb770d8b74aef6317d.json | add KEY_EVENTS support to TextArea | packages/sproutcore-handlebars/lib/controls/text_area.js | @@ -18,6 +18,9 @@ SC.TextArea = SC.View.extend({
value: "",
attributeBindings: ['placeholder'],
placeholder: null,
+
+ insertNewline: SC.K,
+ cancel: SC.K,
focusOut: function(event) {
this._elementValueDidChange();
@@ -30,7 +33,7 @@ SC.TextArea = SC.View.extend({
},
keyUp: function(event)... | true |
Other | emberjs | ember.js | 4d492e426b3c92b432babedb770d8b74aef6317d.json | add KEY_EVENTS support to TextArea | packages/sproutcore-handlebars/tests/controls/text_area_test.js | @@ -72,6 +72,34 @@ test("value binding works properly for inputs that haven't been created", functi
equals(textArea.$().val(), 'ohai', "value is reflected in the input element once it is created");
});
+test("should call the insertNewline method when return key is pressed", function() {
+ var wasCalled;
+ var e... | true |
Other | emberjs | ember.js | c2e621384c1b72ee4dc22b8f09c4ab2bcf2e222b.json | Destroy App created in handlebars test | packages/sproutcore-handlebars/tests/views/collection_view_test.js | @@ -84,7 +84,7 @@ test("empty views should be removed when content is added to the collection (reg
equals(view.$('tr').length, 1, 'has one row');
- window.App = undefined;
+ window.App.destroy();
});
test("if no content is passed, and no 'else' is specified, nothing is rendered", function() { | false |
Other | emberjs | ember.js | 17a06e487e23cacc890b9c9a8177f97e4fb9acf5.json | Add unit test for nested event managers | packages/sproutcore-touch/tests/system/nested_event_managers.js | @@ -0,0 +1,80 @@
+// ==========================================================================
+// Project: SproutCore Runtime
+// Copyright: ©2011 Strobe Inc. and contributors.
+// License: Licensed under MIT license (see license.js)
+// ==========================================================================
+
... | false |
Other | emberjs | ember.js | 98fe46e280893efc9a5dfd6b6c9815fc007a4fe7.json | Move object destruction to the end of the run loop. | packages/sproutcore-runtime/lib/system/core_object.js | @@ -75,12 +75,34 @@ CoreObject.PrototypeMixin = SC.Mixin.create({
isDestroyed: false,
+ /**
+ Destroys an object by setting the isDestroyed flag and removing its
+ metadata, which effectively destroys observers and bindings.
+
+ If you try to set a property on a destroyed object, an exception will be
+... | true |
Other | emberjs | ember.js | 98fe46e280893efc9a5dfd6b6c9815fc007a4fe7.json | Move object destruction to the end of the run loop. | packages/sproutcore-runtime/lib/system/run_loop.js | @@ -206,7 +206,7 @@ SC.run.end = function() {
@property {String}
*/
-SC.run.queues = ['sync', 'actions', 'timers'];
+SC.run.queues = ['sync', 'actions', 'destroy', 'timers'];
/**
Adds the passed target/method and any optional arguments to the named | true |
Other | emberjs | ember.js | 98fe46e280893efc9a5dfd6b6c9815fc007a4fe7.json | Move object destruction to the end of the run loop. | packages/sproutcore-runtime/tests/system/object/destroy_test.js | @@ -0,0 +1,36 @@
+// ==========================================================================
+// Project: SproutCore Runtime
+// Copyright: ©2011 Strobe Inc. and contributors.
+// License: Licensed under MIT license (see license.js)
+// ==========================================================================
+/... | true |
Other | emberjs | ember.js | 98fe46e280893efc9a5dfd6b6c9815fc007a4fe7.json | Move object destruction to the end of the run loop. | packages/sproutcore-runtime/tests/system/object/observer_test.js | @@ -116,7 +116,7 @@ testBoth('observer should not fire after being destroyed', function(get, set) {
equals(get(obj, 'count'), 0, 'precond - should not invoke observer immediately');
- obj.destroy();
+ SC.run(function() { obj.destroy(); });
raises(function() {
set(obj, 'bar', "BAZ"); | true |
Other | emberjs | ember.js | 98fe46e280893efc9a5dfd6b6c9815fc007a4fe7.json | Move object destruction to the end of the run loop. | packages/sproutcore-views/lib/system/event_dispatcher.js | @@ -105,14 +105,15 @@ SC.EventDispatcher = SC.Object.extend(
result = true, manager = null;
if (!handled) {
- manager = self._findNearestEventManager(view,eventName);
+ manager = self._findNearestEventManager(view, eventName);
}
if (manager) {
result = self._di... | true |
Other | emberjs | ember.js | 98fe46e280893efc9a5dfd6b6c9815fc007a4fe7.json | Move object destruction to the end of the run loop. | packages/sproutcore-views/lib/views/view.js | @@ -395,7 +395,7 @@ SC.View = SC.Object.extend(
$: function(sel) {
var elem = get(this, 'element');
- if (!elem) {
+ if (!elem && !get(this, 'isDestroyed')) {
// if we don't have an element yet, someone calling this.$() is
// trying to update an element that isn't in the DOM. Instead,
... | true |
Other | emberjs | ember.js | 98fe46e280893efc9a5dfd6b6c9815fc007a4fe7.json | Move object destruction to the end of the run loop. | packages/sproutcore-views/tests/system/event_dispatcher_test.js | @@ -79,7 +79,6 @@ test("should dispatch events to views", function() {
equals(parentKeyDownCalled, 0, "does not call keyDown on parent if child handles event");
});
-
test("should send change events up view hierarchy if view contains form elements", function() {
var receivedEvent;
view = SC.View.create({
@... | true |
Other | emberjs | ember.js | f2e0cdcaefd1eed03474de518e414e9a2fb413b3.json | Remove sproutcore-touch from default dependencies | packages/sproutcore-touch/package.json | @@ -4,7 +4,7 @@
"description": "The SproutCore touch system",
"homepage": "http://sproutcore.com",
"author": "Majd Taby",
- "version": "2.0.beta.2.pre",
+ "version": "2.0.beta.2.1.pre",
"dependencies": {
"spade" : "~> 1.0",
"jquery" : "~> 1.6", | true |
Other | emberjs | ember.js | f2e0cdcaefd1eed03474de518e414e9a2fb413b3.json | Remove sproutcore-touch from default dependencies | packages/sproutcore/package.json | @@ -4,15 +4,14 @@
"summary": "SproutCore - JavaScript Application Framework",
"homepage": "http://github.com/sproutcore/sproutcore20",
"author": "Charles Jolley",
- "version": "2.0.beta.2.pre",
+ "version": "2.0.beta.2.1.pre",
"dependencies": {
"spade": "~> 1.0.0",
"sproutcore-... | true |
Other | emberjs | ember.js | bf04b895f6ea812a6c2748266d9691cb9b9164c2.json | Add spade dependency to sproutcore-touch | packages/sproutcore-touch/package.json | @@ -6,8 +6,9 @@
"author": "Majd Taby",
"version": "2.0.beta.2.pre",
"dependencies": {
- "jquery": "~> 1.6",
- "sproutcore-views": "2.0.beta.2.pre"
+ "spade" : "~> 1.0",
+ "jquery" : "~> 1.6",
+ "sproutcore-views" : "2.0.beta.2.pre"
},
"directories": {
"lib" ... | true |
Other | emberjs | ember.js | bf04b895f6ea812a6c2748266d9691cb9b9164c2.json | Add spade dependency to sproutcore-touch | packages/sproutcore/package.json | @@ -12,7 +12,7 @@
"sproutcore-views": "2.0.beta.2.pre",
"sproutcore-datastore": "2.0.beta.2.pre",
"sproutcore-handlebars": "2.0.beta.2.pre",
- "sproutcore-touch": "2.0.beta.2.pre"
+ "sproutcore-touch": "2.0.beta.2.pre"
},
"bpm:build": { | true |
Other | emberjs | ember.js | e5b8957890820f2bac7b8cb551d6cd90207cd278.json | Resolve merge conflict in Handlebars unit tests | packages/sproutcore-handlebars/lib/helpers/binding.js | @@ -32,7 +32,8 @@ var get = SC.get, getPath = SC.getPath, fmt = SC.String.fmt;
inverseTemplate: inverse,
property: property,
previousContext: ctx,
- isEscaped: options.hash.escaped
+ isEscaped: options.hash.escaped,
+ tagName: options.hash.tagName || 'span'
});
v... | true |
Other | emberjs | ember.js | e5b8957890820f2bac7b8cb551d6cd90207cd278.json | Resolve merge conflict in Handlebars unit tests | packages/sproutcore-handlebars/tests/handlebars_test.js | @@ -1092,14 +1092,47 @@ test("should be able to output a property without binding", function(){
equals(view.$('div').html(), "No spans here, son.");
});
+test("should be able to choose a tagName other than span", function(){
+ var template = SC.Handlebars.compile('{{#if content.underwater tagName="abbr"}}Hold yo... | true |
Other | emberjs | ember.js | 8a9c1a68188af818a3874a7ecba7a7683c5d0389.json | Add note about SproutCore Guides to the README. | README.md | @@ -83,6 +83,8 @@ For new users, we recommend downloading the [SproutCore Starter Kit](https://git
We also recommend that you check out the [annotated Todos example](http://annotated-todos.strobeapp.com/), which shows you the best practices for architecting an MVC-based web application.
+The [SproutCore Guides are... | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.