language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | 6aed41af0f3dca539f77c9c9c27f37482a417699.json | Update isVisible observer. | lib/sproutcore-views/lib/views/view.js | @@ -674,7 +674,11 @@ SC.View = SC.Object.extend(
return view ;
},
- _sccv_isVisibleDidChange: function() {
+ /** @private
+ When the view's `isVisible` property changes, toggle the visibility element
+ of the actual DOM element.
+ */
+ _isVisibleDidChange: function() {
this.$().toggle(this.get('i... | false |
Other | Homebrew | brew | d8c2e311ab03eb43dee91240aaea9eb09faa3b14.json | Use odie instead of bare exception
The reason that odie works well here
is that it doesn't print a stacktrace
or get caught and print the help page. | Library/Homebrew/extend/os/linux/parser.rb | @@ -15,9 +15,9 @@ def validate_options
return unless @args.respond_to?(:cask?)
return unless @args.cask?
- # NOTE: We don't raise a UsageError here because
- # we don't want to print the help page.
- raise "Invalid usage: Casks are not supported on Linux"
+ # NOTE: We don... | true |
Other | Homebrew | brew | d8c2e311ab03eb43dee91240aaea9eb09faa3b14.json | Use odie instead of bare exception
The reason that odie works well here
is that it doesn't print a stacktrace
or get caught and print the help page. | Library/Homebrew/test/cli/parser_spec.rb | @@ -573,7 +573,9 @@
it "throws an error when defined" do
expect { parser.parse(["--cask"]) }
- .to raise_error RuntimeError, "Invalid usage: Casks are not supported on Linux"
+ .to output("Error: Invalid `--cask` usage: Casks do not work on Linux\n").to_stderr
+ .and not_to_... | true |
Other | Homebrew | brew | c7fed619ec479bd8dbc19aeb59114d656d12d1d3.json | Update RBI files for parlour.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/parlour@8.1.0.rbi | @@ -4,10 +4,6 @@
# This is an autogenerated file for types exported from the `parlour` gem.
# Please instead update this file by running `bin/tapioca gem parlour`.
-module Kernel
- extend ::Forwardable
-end
-
module Parlour; end
class Parlour::ConflictResolver | false |
Other | Homebrew | brew | 941b500b9550c4fde356b66650d5171dffba93f7.json | Update RBI files for minitest.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/minitest@5.17.0.rbi | @@ -277,10 +277,6 @@ class Minitest::SummaryReporter < ::Minitest::StatisticsReporter
def sync; end
def sync=(_arg0); end
def to_s; end
-
- private
-
- def binary_string; end
end
class Minitest::Test < ::Minitest::Runnable
@@ -319,6 +315,7 @@ module Minitest::Test::LifecycleHooks
end
Minitest::Test::... | false |
Other | Homebrew | brew | d318c5601328b3d2a4fab212895f3e91c07d5685.json | Add integration tests for profiler | .gitignore | @@ -11,6 +11,7 @@
/Library/Homebrew/.npmignore
/Library/Homebrew/bin
/Library/Homebrew/doc
+/Library/Homebrew/prof
/Library/Homebrew/test/.gem
/Library/Homebrew/test/.subversion
/Library/Homebrew/test/coverage | true |
Other | Homebrew | brew | d318c5601328b3d2a4fab212895f3e91c07d5685.json | Add integration tests for profiler | Library/Homebrew/test/dev-cmd/prof_spec.rb | @@ -5,4 +5,24 @@
describe "brew prof" do
it_behaves_like "parseable arguments"
+
+ describe "integration tests", :integration_test do
+ after do
+ FileUtils.rm_rf HOMEBREW_LIBRARY_PATH/"prof"
+ end
+
+ it "works using ruby-prof (the default)" do
+ expect { brew "prof", "help", "HOMEBREW_BROWSE... | true |
Other | Homebrew | brew | 55c82749ad8343541d15f91227478035363bff12.json | SystemConfig: show WSL version if available on Linux | Library/Homebrew/extend/os/linux/system_config.rb | @@ -40,10 +40,20 @@ def host_ruby_version
out
end
+ def wsl_version(kernel)
+ return "no" unless /-microsoft/i.match?(kernel)
+
+ return "2 (store)" if Version.new kernel[/Linux ([0-9.]*)-.*/, 1] > Version.new("5.15")
+ return "2" if /-microsoft/.match?(kernel)
+ return "1" if /-Mic... | false |
Other | Homebrew | brew | 42e91e8668434cfea738c3f15cb4645c0fdd41ac.json | docs: add Table of Contents to selected pages | docs/Acceptable-Casks.md | @@ -2,23 +2,26 @@
Some casks should not go in [homebrew/cask](https://github.com/Homebrew/homebrew-cask). But there are additional [Interesting Taps and Forks](Interesting-Taps-and-Forks.md) and anyone can [start their own](How-to-Create-and-Maintain-a-Tap.md)!
+* Table of Contents
+{:toc}
+
## Finding a Home For... | true |
Other | Homebrew | brew | 42e91e8668434cfea738c3f15cb4645c0fdd41ac.json | docs: add Table of Contents to selected pages | docs/Acceptable-Formulae.md | @@ -2,6 +2,9 @@
Some formulae should not go in [homebrew/core](https://github.com/Homebrew/homebrew-core). But there are additional [Interesting Taps and Forks](Interesting-Taps-and-Forks.md) and anyone can [start their own](How-to-Create-and-Maintain-a-Tap.md)!
+* Table of Contents
+{:toc}
+
## Requirements for ... | true |
Other | Homebrew | brew | 42e91e8668434cfea738c3f15cb4645c0fdd41ac.json | docs: add Table of Contents to selected pages | docs/Cask-Cookbook.md | @@ -17,6 +17,9 @@ cask "alfred" do
end
```
+* Table of Contents
+{:toc}
+
## The Cask Language Is Declarative
Each cask contains a series of stanzas (or “fields”) which *declare* how the software is to be obtained and installed. In a declarative language, the author does not need to worry about **order**. As lo... | true |
Other | Homebrew | brew | 42e91e8668434cfea738c3f15cb4645c0fdd41ac.json | docs: add Table of Contents to selected pages | docs/Common-Issues.md | @@ -2,6 +2,9 @@
This is a list of commonly encountered problems, known issues, and their solutions.
+* Table of Contents
+{:toc}
+
## Running `brew`
### `brew` complains about absence of "Command Line Tools"
@@ -120,8 +123,8 @@ This is an issue in the connection between your machine and GitHub, rather than
... | true |
Other | Homebrew | brew | 42e91e8668434cfea738c3f15cb4645c0fdd41ac.json | docs: add Table of Contents to selected pages | docs/FAQ.md | @@ -1,5 +1,8 @@
# FAQ (Frequently Asked Questions)
+* Table of Contents
+{:toc}
+
## Is there a glossary of terms around?
The Formula Cookbook has a list of [Homebrew terminology](Formula-Cookbook.md#homebrew-terminology). | true |
Other | Homebrew | brew | 42e91e8668434cfea738c3f15cb4645c0fdd41ac.json | docs: add Table of Contents to selected pages | docs/Formula-Cookbook.md | @@ -2,6 +2,9 @@
A *formula* is a package definition written in Ruby. It can be created with `brew create <URL>` where `<URL>` is a zip or tarball, installed with `brew install <formula>`, and debugged with `brew install --debug --verbose <formula>`. Formulae use the [Formula API](https://rubydoc.brew.sh/Formula) whi... | true |
Other | Homebrew | brew | 42e91e8668434cfea738c3f15cb4645c0fdd41ac.json | docs: add Table of Contents to selected pages | docs/_config.yml | @@ -31,6 +31,9 @@ defaults:
values:
category: governance-archives
+kramdown:
+ toc_levels: 2..3
+
logo: /assets/img/homebrew-256x256.png
twitter: | true |
Other | Homebrew | brew | 09ff92707cd858e2c0c049a7eba7b6078a38dd77.json | Update RBI files for rubocop-ast.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/rubocop-ast@1.24.1.rbi | @@ -297,6 +297,10 @@ class RuboCop::AST::ConstNode < ::RuboCop::AST::Node
def short_name; end
end
+class RuboCop::AST::CsendNode < ::RuboCop::AST::SendNode
+ def send_type?; end
+end
+
class RuboCop::AST::DefNode < ::RuboCop::AST::Node
include ::RuboCop::AST::ParameterizedNode
include ::RuboCop::AST::Meth... | true |
Other | Homebrew | brew | 09ff92707cd858e2c0c049a7eba7b6078a38dd77.json | Update RBI files for rubocop-ast.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi | @@ -6767,19 +6767,15 @@ class RuboCop::AST::NodePattern::Parser
end
module RuboCop::AST::NodePattern::Sets
- SET_ANY_EMPTY = ::T.let(nil, ::T.untyped)
SET_ARM_INTEL = ::T.let(nil, ::T.untyped)
SET_BASH_COMPLETION_ZSH_COMPLETION_FISH_COMPLETION = ::T.let(nil, ::T.untyped)
SET_BUILD_RECOMMENDED_TEST_OPTIONA... | true |
Other | Homebrew | brew | 3bdab156c298572cd540f81e4b2efad1dbcdbdd2.json | add additional test | Library/Homebrew/test/cask/artifact/shared_examples/uninstall_zap.rb | @@ -79,6 +79,15 @@
};
EOS
end
+ let(:launchctl_list) do
+ <<~EOS
+ PID Status Label
+ 1111 0 my.fancy.package.service.12345
+ - 0 com.apple.SafariHistoryServiceAgent
+ - 0 com.apple.progressd
+ 555 0 my.fancy... | false |
Other | Homebrew | brew | 3556e756fcb9d1fd88be7416e14b624c25b737f8.json | Check casks for macOS version conditionals | Library/Homebrew/rubocops/cask/on_system_conditionals.rb | @@ -41,6 +41,7 @@ def on_cask(cask_block)
end
audit_arch_conditionals(cask_body)
+ audit_macos_version_conditionals(cask_body)
simplify_sha256_stanzas
end
| false |
Other | Homebrew | brew | b6f9b7d3e05ebf983df6f6a190ca3e594d3fbbb3.json | Remove bitdefender diagnostic check
This shows up in `brew doctor` but hasn't been
reported as a problem by users in 3+ years. | Library/Homebrew/extend/os/mac/diagnostic.rb | @@ -364,19 +364,6 @@ def check_for_iconv
end
end
- def check_for_bitdefender
- if !Pathname("/Library/Bitdefender/AVP/EndpointSecurityforMac.app").exist? &&
- !Pathname("/Library/Bitdefender/AVP/BDLDaemon").exist?
- return
- end
-
- <<~EOS
- You ha... | false |
Other | Homebrew | brew | f55d819f39b06271ad602c0dca97f10447c97ccf.json | Update RBI files for rubocop-performance.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/rubocop-performance@1.15.2.rbi | @@ -807,6 +807,7 @@ RuboCop::Cop::Performance::StringReplacement::TR = T.let(T.unsafe(nil), String)
class RuboCop::Cop::Performance::Sum < ::RuboCop::Cop::Base
include ::RuboCop::Cop::RangeHelp
extend ::RuboCop::Cop::AutoCorrector
+ extend ::RuboCop::Cop::TargetRubyVersion
def acc_plus_elem?(param0 = T.uns... | true |
Other | Homebrew | brew | f55d819f39b06271ad602c0dca97f10447c97ccf.json | Update RBI files for rubocop-performance.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi | @@ -6774,6 +6774,7 @@ module RuboCop::AST::NodePattern::Sets
SET_DEPENDS_ON_USES_FROM_MACOS = ::T.let(nil, ::T.untyped)
SET_INCLUDE_WITH_WITHOUT = ::T.let(nil, ::T.untyped)
SET_MAC_LINUX = ::T.let(nil, ::T.untyped)
+ SET_MATCH___MATCH = ::T.let(nil, ::T.untyped)
SET_ON_INTEL_ON_ARM = ::T.let(nil, ::T.untyp... | true |
Other | Homebrew | brew | 09a2ccdf24d717650751368e5665107e2af8169f.json | Improve minimum macOS version audit for casks | Library/Homebrew/cask/audit.rb | @@ -567,6 +567,7 @@ def check_livecheck_min_os
return if item.blank?
min_os = item.elements["sparkle:minimumSystemVersion"]&.text
+ min_os = "11" if min_os == "10.16"
return if min_os.blank?
begin
@@ -581,7 +582,8 @@ def check_livecheck_min_os
return if cask_min_os == min_o... | false |
Other | Homebrew | brew | f6a8df1ce19695226155cdf17df659932348daa5.json | Update RBI files for rubocop-rails.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/rubocop-rails@2.17.4.rbi | @@ -1787,9 +1787,11 @@ class RuboCop::Cop::Rails::RootPathnameMethods < ::RuboCop::Cop::Base
def build_path_glob_replacement(path, method); end
def build_path_replacement(path, method, args); end
+ def enforce_double_quotes?; end
def evidence(node); end
def include_interpolation?(arguments); end
def j... | false |
Other | Homebrew | brew | 915a6e53a45b344f46d9e478bfb32aa702ea46c7.json | Update RBI files for simplecov.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/simplecov@0.22.0.rbi | @@ -153,9 +153,12 @@ module SimpleCov::Configuration
def coverage_criterion(criterion = T.unsafe(nil)); end
def coverage_criterion_enabled?(criterion); end
def coverage_dir(dir = T.unsafe(nil)); end
+ def coverage_for_eval_enabled?; end
+ def coverage_for_eval_supported?; end
def coverage_path; end
def... | false |
Other | Homebrew | brew | 213679f19c825cea41c439766a7c80d3539a713f.json | Update RBI files for rubocop.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/rubocop@1.41.1.rbi | @@ -298,6 +298,7 @@ class RuboCop::Config
def base_dir_for_path_parameters; end
def bundler_lock_file_path; end
def check; end
+ def clusivity_config_for_badge?(badge); end
def delete(*args, &block); end
def deprecation_check; end
def dig(*args, &block); end
@@ -412,6 +413,7 @@ class RuboCop::ConfigL... | false |
Other | Homebrew | brew | 8c160639b06646631039098e5fbec171b076a99e.json | ISSUE_TEMPLATE/bug: nudge people to discussions.
This probably won't work but gives us a stronger reason to ignore this. | .github/ISSUE_TEMPLATE/bug.yml | @@ -14,7 +14,7 @@ body:
- type: checkboxes
attributes:
label: Verification
- description: Please verify that you've followed these steps.
+ description: Please verify that you've followed these steps. If you cannot truthfully check these boxes, open a discussion at https://github.com/orgs/Homeb... | false |
Other | Homebrew | brew | f70b0bf8f2cc2df6b22f98a1d3c22ab92d21f1e1.json | sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow. | Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi | @@ -3030,10 +3030,6 @@ class Cask::CaskUnspecifiedError
extend ::T::Private::Methods::SingletonMethodHooks
end
-class Cask::Cmd::AbstractCommand
- include ::Homebrew::Search::Extension
-end
-
class Cask::Config
def appdir(); end
@@ -3327,10 +3323,6 @@ class Dependencies
extend ::T::Private::Methods::Sin... | false |
Other | Homebrew | brew | 768ebe575002075cd9f2952e5db41c72fbbac88e.json | Fix access to `livecheck` constants in formulae | Library/Homebrew/formula.rb | @@ -65,6 +65,7 @@ class Formula
include Utils::Shell
include Context
include OnSystem::MacOSAndLinux
+ include Homebrew::Livecheck::Constants
extend Forwardable
extend Cachable
extend Predicable
@@ -3278,7 +3279,6 @@ def test(&block)
def livecheck(&block)
return @livecheck unless block
... | false |
Other | Homebrew | brew | 1209fc046f9669a9b418b7dd759caf4224ab2098.json | formula: show stderr by default when generating completions | Library/Homebrew/formula.rb | @@ -1781,8 +1781,11 @@ def generate_completions_from_executable(*commands,
popen_read_args << shell_parameter if shell_parameter.present?
popen_read_args.flatten!
+ popen_read_options = {}
+ popen_read_options[:err] = :err unless ENV["HOMEBREW_STDERR"]
+
script_path.dirname.mkpath
- ... | false |
Other | Homebrew | brew | f41089fff497a30e15998e8a3e0269511441f763.json | Use module_function in search.rb | Library/Homebrew/search.rb | @@ -9,7 +9,9 @@ module Homebrew
#
# @api private
module Search
- def self.query_regexp(query)
+ module_function
+
+ def query_regexp(query)
if (m = query.match(%r{^/(.*)/$}))
Regexp.new(m[1])
else
@@ -19,7 +21,7 @@ def self.query_regexp(query)
raise "#{query} is not a val... | false |
Other | Homebrew | brew | f03a400e28f82813e65b02948a61c8b6f74a1d77.json | Extract latest_version string to a constant | Library/Homebrew/formula.rb | @@ -3278,6 +3278,7 @@ def test(&block)
def livecheck(&block)
return @livecheck unless block
+ include Homebrew::Livecheck::Constants
@livecheckable = true
@livecheck.instance_eval(&block)
end | true |
Other | Homebrew | brew | f03a400e28f82813e65b02948a61c8b6f74a1d77.json | Extract latest_version string to a constant | Library/Homebrew/livecheck.rb | @@ -1,6 +1,8 @@
# typed: true
# frozen_string_literal: true
+require "livecheck/constants"
+
# The {Livecheck} class implements the DSL methods used in a formula's, cask's
# or resource's `livecheck` block and stores related instance variables. Most
# of these methods also return the related instance variable wh... | true |
Other | Homebrew | brew | f03a400e28f82813e65b02948a61c8b6f74a1d77.json | Extract latest_version string to a constant | Library/Homebrew/livecheck/constants.rb | @@ -0,0 +1,14 @@
+# typed: true
+# frozen_string_literal: true
+
+module Homebrew
+ module Livecheck
+ # The {Constants} module provides constants that are intended to be used
+ # in `livecheck` block values (e.g. `url`, `regex`).
+ module Constants
+ # A placeholder string used in resource `livecheck` b... | true |
Other | Homebrew | brew | f03a400e28f82813e65b02948a61c8b6f74a1d77.json | Extract latest_version string to a constant | Library/Homebrew/livecheck/livecheck.rb | @@ -1,6 +1,7 @@
# typed: true
# frozen_string_literal: true
+require "livecheck/constants"
require "livecheck/error"
require "livecheck/livecheck_version"
require "livecheck/skip_conditions"
@@ -877,7 +878,7 @@ def resource_version(
checked_urls = []
# rubocop:disable Metrics/BlockLength
url... | true |
Other | Homebrew | brew | 5e9223d0592734e9c2f1a071511a4911dfc63842.json | add explicit version for GitHub API | Library/Homebrew/utils/github/api.rb | @@ -192,6 +192,7 @@ def open_rest(url, data: nil, data_binary_path: nil, request_method: nil, scopes
token = credentials
args += ["--header", "Authorization: token #{token}"] unless credentials_type == :none
+ args += ["--header", "X-GitHub-Api-Version:2022-11-28"]
data_tmpfile = nil
... | false |
Other | Homebrew | brew | ba664fa1b4c8f13284c8e5517ec278d456c58bf3.json | Move Search#search_casks out of extend/os
This doesn't need to be isolated anymore because
there is a check for the formula and cask args
and formula is passed by default on Linux now. | Library/Homebrew/search.rb | @@ -111,8 +111,33 @@ def search_formulae(string_or_regex)
end.compact
end
- def search_casks(_string_or_regex)
- []
+ def search_casks(string_or_regex)
+ if string_or_regex.is_a?(String) && string_or_regex.match?(HOMEBREW_TAP_CASK_REGEX)
+ return begin
+ [Cask::CaskLoader.l... | false |
Other | Homebrew | brew | 77726d19137d344540a4a0df965f64f0aec2bd21.json | docs: Change comma style in Acceptable-Casks
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com> | docs/Acceptable-Casks.md | @@ -118,7 +118,7 @@ Common reasons to reject a cask entirely:
+ The author has [specifically asked us not to include it](https://github.com/Homebrew/homebrew-cask/pull/5342).
+ App requires [SIP to be disabled](https://github.com/Homebrew/homebrew-cask/pull/41890) to be installed and/or used.
+ App installer is a `p... | false |
Other | Homebrew | brew | f8797e88b91f8fc712190073360561ff4ba38f71.json | Update RBI files for rspec-expectations.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/rspec-expectations@3.12.1.rbi | @@ -230,6 +230,13 @@ class RSpec::Expectations::FailureAggregator
def notify_aggregated_failures; end
end
+RSpec::Expectations::FailureAggregator::AGGREGATED_FAILURE = T.let(T.unsafe(nil), RSpec::Expectations::FailureAggregator::AggregatedFailure)
+
+class RSpec::Expectations::FailureAggregator::AggregatedFailure... | false |
Other | Homebrew | brew | 45cb6753b536aa54383836201cdd74fe63937c12.json | docs: Fix wrong condition for an app rejection
Swapped logic of rejection from work to failure and added an example | docs/Acceptable-Casks.md | @@ -118,7 +118,7 @@ Common reasons to reject a cask entirely:
+ The author has [specifically asked us not to include it](https://github.com/Homebrew/homebrew-cask/pull/5342).
+ App requires [SIP to be disabled](https://github.com/Homebrew/homebrew-cask/pull/41890) to be installed and/or used.
+ App installer is a `p... | false |
Other | Homebrew | brew | 3aac0fef7eaeff3cc50b873c921d80dca0ba6810.json | Simplify cask search
The cask_tokens and cask_names arrays here
were almost identical so we'll just use
cask_tokens for both. | Library/Homebrew/cask/cask.rb | @@ -38,16 +38,6 @@ def self.all
end.compact
end
- def self.full_names
- Tap.flat_map do |tap|
- next tap.cask_tokens.blank?
- next tap.cask_tokens if tap.user == "Homebrew"
-
- name = tap.name
- tap.cask_tokens.map { |tok| "#{name}/#{tok}" }
- end.flatten
- end
... | true |
Other | Homebrew | brew | 3aac0fef7eaeff3cc50b873c921d80dca0ba6810.json | Simplify cask search
The cask_tokens and cask_names arrays here
were almost identical so we'll just use
cask_tokens for both. | Library/Homebrew/extend/os/mac/search.rb | @@ -37,8 +37,7 @@ def search_casks(string_or_regex)
results = cask_tokens.extend(Searchable)
.search(string_or_regex)
- cask_names = Cask::Cask.full_names
- results += DidYouMean::SpellChecker.new(dictionary: cask_names)
+ results += DidYouMean::SpellChecker... | true |
Other | Homebrew | brew | 0afc41ceefcf2b69443287f12a45bb7d2c2c35e3.json | Explain edge case in install/cmd
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com> | Library/Homebrew/cmd/install.rb | @@ -295,6 +295,8 @@ def install
return
end
+ # We don't seem to get good search results when the tap is specified
+ # so we might as well return early.
return if name.include?("/")
ohai "Searching for similarly named formulae and casks..." | false |
Other | Homebrew | brew | cd21875929bcd1b545842bd042aba9882b44fed0.json | Update RBI files for rubocop.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/rubocop@1.40.0.rbi | @@ -6,6 +6,18 @@
module RuboCop; end
+class RuboCop::ArgumentsEnv
+ class << self
+ def read_as_arguments; end
+ end
+end
+
+class RuboCop::ArgumentsFile
+ class << self
+ def read_as_arguments; end
+ end
+end
+
class RuboCop::CLI
def initialize; end
@@ -194,13 +206,17 @@ class RuboCop::CachedData
... | true |
Other | Homebrew | brew | cd21875929bcd1b545842bd042aba9882b44fed0.json | Update RBI files for rubocop.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi | @@ -3287,9 +3287,13 @@ module CopHelper
def autocorrect_source_file(source); end
+ def configuration(); end
+
def inspect_source(source, file=T.unsafe(nil)); end
def parse_source(source, file=T.unsafe(nil)); end
+
+ def registry(); end
end
module CopHelper
@@ -6776,6 +6780,7 @@ class RuboCop::AST::... | true |
Other | Homebrew | brew | 79267e1e7634208a085ac0f7dc8292af2a4b6bda.json | rubocop_rspec: fix incorrect failures. | Library/.rubocop_rspec.yml | @@ -37,3 +37,10 @@ RSpec/MultipleMemoizedHelpers:
# Annoying to have these autoremoved.
RSpec/Focus:
AutoCorrect: false
+
+# Gets confused on these tests for a `skip` DSL
+RSpec/PendingWithoutReason:
+ Exclude:
+ - "**/dependency_expansion_spec.rb"
+ - "**/livecheck/skip_conditions_spec.rb"
+ - "**/livec... | false |
Other | Homebrew | brew | 77e374b3056f84886548e0f85bcb5763dafe7860.json | Update RBI files for rubocop-rspec.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/rubocop-rspec@2.16.0.rbi | @@ -83,6 +83,7 @@ class RuboCop::Cop::RSpec::Be < ::RuboCop::Cop::RSpec::Base
end
RuboCop::Cop::RSpec::Be::MSG = T.let(T.unsafe(nil), String)
+RuboCop::Cop::RSpec::Be::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array)
class RuboCop::Cop::RSpec::BeEq < ::RuboCop::Cop::RSpec::Base
extend ::RuboCop::Cop::AutoCorrec... | true |
Other | Homebrew | brew | 77e374b3056f84886548e0f85bcb5763dafe7860.json | Update RBI files for rubocop-rspec.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi | @@ -6785,6 +6785,7 @@ module RuboCop::AST::NodePattern::Sets
SET_ON_INTEL_ON_ARM = ::T.let(nil, ::T.untyped)
SET_OR_NEWER_OR_OLDER = ::T.let(nil, ::T.untyped)
SET_SYSTEM_SHELL_OUTPUT_PIPE_OUTPUT = ::T.let(nil, ::T.untyped)
+ SET_TO_TO_NOT_NOT_TO = ::T.let(nil, ::T.untyped)
SET_WITH_WITHOUT = ::T.let(nil, :... | true |
Other | Homebrew | brew | daa87fa10f1c6fda9c4b48509f72fac19b44f878.json | Add specific examples to install cmd
- provide specific install instructions
when a cask/formula doesn't exist
and we search for similar ones
- print and exit early if a named formula that
was removed recently has the same name
- exit early if the tap is specified because
we don't get good search results | Library/Homebrew/cmd/install.rb | @@ -288,16 +288,47 @@ def install
end
opoo e
+
+ reason = MissingFormula.reason(name, silent: true)
+ if !args.cask? && reason
+ $stderr.puts reason
+ return
+ end
+
+ return if name.include?("/")
+
ohai "Searching for similarly named formulae and casks..."
# Don't treat fo... | true |
Other | Homebrew | brew | daa87fa10f1c6fda9c4b48509f72fac19b44f878.json | Add specific examples to install cmd
- provide specific install instructions
when a cask/formula doesn't exist
and we search for similar ones
- print and exit early if a named formula that
was removed recently has the same name
- exit early if the tap is specified because
we don't get good search results | Library/Homebrew/cmd/search.rb | @@ -86,7 +86,8 @@ def search
elsif args.pull_request?
search_pull_requests(query, args)
else
- search_names(query, string_or_regex, args)
+ formulae, casks = search_names(query, string_or_regex)
+ print_results(formulae, casks, query, args)
end
puts "Use `brew desc` to list p... | true |
Other | Homebrew | brew | daa87fa10f1c6fda9c4b48509f72fac19b44f878.json | Add specific examples to install cmd
- provide specific install instructions
when a cask/formula doesn't exist
and we search for similar ones
- print and exit early if a named formula that
was removed recently has the same name
- exit early if the tap is specified because
we don't get good search results | Library/Homebrew/search.rb | @@ -115,7 +115,7 @@ def search_casks(_string_or_regex)
[]
end
- def search_names(query, string_or_regex, args)
+ def search_names(query, string_or_regex)
remote_results = search_taps(query, silent: true)
local_formulae = search_formulae(string_or_regex)
@@ -126,48 +126,7 @@ def searc... | true |
Other | Homebrew | brew | 96a93b342ef15a3f86b0f5680996688bf429ccd9.json | Update RBI files for rspec-mocks.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/rspec-mocks@3.12.1.rbi | @@ -752,8 +752,8 @@ class RSpec::Mocks::Matchers::HaveReceived
def exactly(*args); end
def failure_message; end
def failure_message_when_negated; end
+ def matcher_name; end
def matches?(subject, &block); end
- def name; end
def once(*args); end
def ordered(*args); end
def setup_allowance(_subjec... | false |
Other | Homebrew | brew | e8e6ee30b48a7f9df0bda5adc959fb0eaaaae13a.json | add initial tests | Library/Homebrew/cask/artifact/abstract_uninstall.rb | @@ -95,7 +95,7 @@ def uninstall_launchctl(*services, command: nil, **_)
# if launchctl item contains a wildcard, find matching process(es)
services.each do |service|
- all_services << service
+ all_services << service unless service.include?("*")
next unless service.incl... | true |
Other | Homebrew | brew | e8e6ee30b48a7f9df0bda5adc959fb0eaaaae13a.json | add initial tests | Library/Homebrew/test/cask/artifact/shared_examples/uninstall_zap.rb | @@ -61,6 +61,19 @@
end
end
+ context "using launchctl with regex" do
+ let(:cask) { Cask::CaskLoader.load(cask_path("with-#{artifact_dsl_key}-launchctl-wildcard")) }
+ let(:launchctl_list_cmd) { %w[/bin/launchctl list] }
+
+ it "searches running launchctl items" do
+ allow(fake_system_command).... | true |
Other | Homebrew | brew | e8e6ee30b48a7f9df0bda5adc959fb0eaaaae13a.json | add initial tests | Library/Homebrew/test/support/fixtures/cask/Casks/with-uninstall-launchctl-wildcard.rb | @@ -0,0 +1,11 @@
+cask "with-uninstall-launchctl-wildcard" do
+ version "1.2.3"
+ sha256 "8c62a2b791cf5f0da6066a0a4b6e85f62949cd60975da062df44adf887f4370b"
+
+ url "file://#{TEST_FIXTURE_DIR}/cask/MyFancyApp.zip"
+ homepage "https://brew.sh/fancy"
+
+ app "Fancy.app"
+
+ uninstall launchctl: "my.fancy.package.ser... | true |
Other | Homebrew | brew | e8e6ee30b48a7f9df0bda5adc959fb0eaaaae13a.json | add initial tests | Library/Homebrew/test/support/fixtures/cask/Casks/with-zap-launchctl-wildcard.rb | @@ -0,0 +1,11 @@
+cask "with-zap-launchctl-wildcard" do
+ version "1.2.3"
+ sha256 "8c62a2b791cf5f0da6066a0a4b6e85f62949cd60975da062df44adf887f4370b"
+
+ url "file://#{TEST_FIXTURE_DIR}/cask/MyFancyApp.zip"
+ homepage "https://brew.sh/fancy"
+
+ app "Fancy.app"
+
+ zap launchctl: "my.fancy.package.service.*"
+end | true |
Other | Homebrew | brew | a481729ade5f3c2be9980a3b4259bdc61d37e275.json | Show casks in install not found output
- Move `search_names` and `print_missing_formula_help` out of `cmd/search.rb` to `search.rb`
- Change to using those functions in `cmd/install.rb` when a formula or cask doesn't exist | Library/Homebrew/cmd/install.rb | @@ -278,48 +278,26 @@ def install
# formula was found, but there's a problem with its implementation).
$stderr.puts e.backtrace if Homebrew::EnvConfig.developer?
ofail e.message
- rescue FormulaOrCaskUnavailableError => e
- if e.name == "updog"
+ rescue FormulaOrCaskUnavailableError, Cask::CaskUnava... | true |
Other | Homebrew | brew | a481729ade5f3c2be9980a3b4259bdc61d37e275.json | Show casks in install not found output
- Move `search_names` and `print_missing_formula_help` out of `cmd/search.rb` to `search.rb`
- Change to using those functions in `cmd/install.rb` when a formula or cask doesn't exist | Library/Homebrew/cmd/search.rb | @@ -128,57 +128,4 @@ def search_pull_requests(query, args)
GitHub.print_pull_requests_matching(query, only)
end
-
- def search_names(query, string_or_regex, args)
- remote_results = search_taps(query, silent: true)
-
- local_formulae = search_formulae(string_or_regex)
- remote_formulae = remote_resu... | true |
Other | Homebrew | brew | a481729ade5f3c2be9980a3b4259bdc61d37e275.json | Show casks in install not found output
- Move `search_names` and `print_missing_formula_help` out of `cmd/search.rb` to `search.rb`
- Change to using those functions in `cmd/install.rb` when a formula or cask doesn't exist | Library/Homebrew/search.rb | @@ -114,6 +114,61 @@ def search_formulae(string_or_regex)
def search_casks(_string_or_regex)
[]
end
+
+ def search_names(query, string_or_regex, args)
+ remote_results = search_taps(query, silent: true)
+
+ local_formulae = search_formulae(string_or_regex)
+ remote_formulae = remote_r... | true |
Other | Homebrew | brew | 07ff122c8d131ba56a677ecddb121ef4eeec75c6.json | Ignore os cop in tap Formula/Cask folders | Library/.rubocop.yml | @@ -55,16 +55,14 @@ FormulaAudit:
FormulaAuditStrict:
Enabled: true
-Homebrew/MoveToExtendOS:
- Exclude:
- - "Homebrew/{extend,test,requirements}/**/*"
- - "Taps/**/*"
- - "Homebrew/os.rb"
-
# enable all Homebrew custom cops
Homebrew:
Enabled: true
+# only used internally
+Homebrew/MoveToExtendOS... | true |
Other | Homebrew | brew | 07ff122c8d131ba56a677ecddb121ef4eeec75c6.json | Ignore os cop in tap Formula/Cask folders | Library/Homebrew/.rubocop.yml | @@ -2,6 +2,12 @@ inherit_from:
- ../.rubocop_rspec.yml
- .rubocop_todo.yml
+Homebrew/MoveToExtendOS:
+ Enabled: true
+ Exclude:
+ - "{extend,test,requirements}/**/*"
+ - "os.rb"
+
# make rspec formatting more flexible
Layout/MultilineMethodCallIndentation:
Exclude: | true |
Other | Homebrew | brew | f623a44061fbce885ab290eb37631fcf73a8ee93.json | Update RBI files for json_schemer.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/json_schemer@0.2.24.rbi | @@ -82,6 +82,7 @@ class JSONSchemer::Schema::Base
def child(schema); end
def custom_format?(format); end
def error(instance, type, details = T.unsafe(nil)); end
+ def escape_json_pointer_token(token); end
def format?; end
def formats; end
def id_keyword; end
@@ -141,6 +142,8 @@ class JSONSchemer::Sch... | false |
Other | Homebrew | brew | 5c7d53476eed5ad93287292e3b7c588d21dbb31d.json | formula: add support for generating click shell completions | Library/Homebrew/formula.rb | @@ -1689,7 +1689,7 @@ def extract_macho_slice_from(file, arch = Hardware::CPU.arch)
# @param base_name [String] the base name of the generated completion script. Defaults to the formula name.
# @param shells [Array<Symbol>] the shells to generate completion scripts for. Defaults to `[:bash, :zsh, :fish]`.
# @p... | false |
Other | Homebrew | brew | 04f61a940e34f01f9aecaec55092ed2f9827afa9.json | sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow. | Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi | @@ -4595,6 +4595,18 @@ class Homebrew::FormulaCreator
extend ::T::Private::Methods::SingletonMethodHooks
end
+class Homebrew::Livecheck::Strategy::ExtractPlist::Item
+ def short_version(*args, &block); end
+
+ def version(*args, &block); end
+end
+
+class Homebrew::Livecheck::Strategy::ExtractPlist::Item
+ def... | false |
Other | Homebrew | brew | 43070d73a1913691e401cece5d604b2fbc037c45.json | Maintainers docs: adjust line breaks | docs/Homebrew-brew-Maintainer-Guide.md | @@ -1,7 +1,6 @@
# Homebrew/brew Maintainer Guide
-This document describes a few components of the `Homebrew/brew` repository that are useful for maintainers to
-be aware of, but don't necessarily need to appear in documentation for most users and contributors.
+This document describes a few components of the `Homebr... | true |
Other | Homebrew | brew | 43070d73a1913691e401cece5d604b2fbc037c45.json | Maintainers docs: adjust line breaks | docs/Homebrew-homebrew-cask-Maintainer-Guide.md | @@ -1,50 +1,36 @@
# Homebrew/homebrew-cask Maintainer Guide
-This guide is intended to help maintainers effectively maintain the cask repositories.
-It is meant to be used in conjunction with the more generic [Maintainer Guidelines](Maintainer-Guidelines.md).
+This guide is intended to help maintainers effectively m... | true |
Other | Homebrew | brew | 43070d73a1913691e401cece5d604b2fbc037c45.json | Maintainers docs: adjust line breaks | docs/Homebrew-homebrew-core-Maintainer-Guide.md | @@ -7,50 +7,33 @@ A detailed checklist can be found [below](#detailed-merge-checklist). This is al
- Ensure the name seems reasonable.
- Add aliases.
- Ensure it uses `keg_only :provided_by_macos` if it already comes with macOS.
-- Ensure it is not a library that can be installed with
- [gem](https://en.wikipedia.o... | true |
Other | Homebrew | brew | 43070d73a1913691e401cece5d604b2fbc037c45.json | Maintainers docs: adjust line breaks | docs/Maintainer-Guidelines.md | @@ -1,35 +1,19 @@
# Maintainer Guidelines
-**This guide is for maintainers.** These special people have **write
-access** to Homebrew’s repository and help merge the contributions of
-others. You may find what is written here interesting, but it’s
-definitely not a beginner’s guide.
+**This guide is for maintainers.... | true |
Other | Homebrew | brew | 43070d73a1913691e401cece5d604b2fbc037c45.json | Maintainers docs: adjust line breaks | docs/Releases.md | @@ -1,48 +1,19 @@
# Releases
-Since Homebrew 1.0.0 most Homebrew users (those who haven't run a `dev-cmd` or
-set `HOMEBREW_DEVELOPER=1` which is ~99.9% based on analytics data) require tags
-on the [Homebrew/brew repository](https://github.com/homebrew/brew)
-in order to get new versions of Homebrew. There are a fe... | true |
Other | Homebrew | brew | 674f8dbd56001a03e83f174337b20463eb4b412e.json | Update RBI files for racc.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/racc@1.6.1.rbi | @@ -4,7 +4,10 @@
# This is an autogenerated file for types exported from the `racc` gem.
# Please instead update this file by running `bin/tapioca gem racc`.
+::APPLE_GEM_HOME = T.let(T.unsafe(nil), String)
::RUBY19 = T.let(T.unsafe(nil), TrueClass)
+::RUBY_FRAMEWORK = T.let(T.unsafe(nil), TrueClass)
+::RUBY_FRAME... | false |
Other | Homebrew | brew | d14e5e089918a701e707de56567d4fc64d4e5daf.json | Update RBI files for rack.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/rack@3.0.2.rbi | @@ -1087,6 +1087,7 @@ class Rack::Response
def headers; end
def length; end
def length=(_arg0); end
+ def no_entity_body?; end
def redirect(target, status = T.unsafe(nil)); end
def set_header(key, value); end
def status; end | false |
Other | Homebrew | brew | 35500130c4ccf7886848cb5073ae9d63e91d253a.json | Update parser tests
- Remove named_args linux specs now that that
logic has been moved to the parser | Library/Homebrew/cli/args.rb | @@ -135,7 +135,7 @@ def spec(default = :stable)
end
def respond_to_missing?(method_name, *)
- !frozen? || @table.key?(method_name)
+ @table.key?(method_name)
end
def method_missing(method_name, *args) | true |
Other | Homebrew | brew | 35500130c4ccf7886848cb5073ae9d63e91d253a.json | Update parser tests
- Remove named_args linux specs now that that
logic has been moved to the parser | Library/Homebrew/test/cli/named_args_spec.rb | @@ -118,12 +118,6 @@ def setup_unredable_cask(name)
expect { described_class.new("foo").to_formulae_and_casks }.to raise_error(FormulaOrCaskUnavailableError)
end
- it "raises an error when formula is absent and cask is available on linux", :needs_linux do
- stub_cask_loader foo_cask
-
- expec... | true |
Other | Homebrew | brew | 35500130c4ccf7886848cb5073ae9d63e91d253a.json | Update parser tests
- Remove named_args linux specs now that that
logic has been moved to the parser | Library/Homebrew/test/cli/parser_spec.rb | @@ -570,12 +570,24 @@
end
end
- it "throws an error by default" do
+ it "throws an error when defined" do
expect { parser.parse(["--cask"]) }.to raise_error UsageError, /Casks are not supported on Linux/
end
+ end
+
+ describe "--formula on linux", :needs_linux do
+ it "doesn't set ... | true |
Other | Homebrew | brew | 836efe621fc842ee5b7ff1a42f9b8bcba5020a86.json | cask/artifiact/abstract_uninstall: allow wildcard entries for launchctl | Library/Homebrew/cask/artifact/abstract_uninstall.rb | @@ -95,14 +95,10 @@ def uninstall_launchctl(*services, command: nil, **_)
# if launchctl item contains a wildcard, find matching process(es)
services.each do |service|
- all_services.push(service)
- next unless /\*/.match?(service)
+ all_services << service
+ next... | false |
Other | Homebrew | brew | 867a39f3e56382621bf025d87cf8d4007a8040d4.json | Update RBI files for rubocop-ast.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/rubocop-ast@1.24.0.rbi | @@ -659,6 +659,8 @@ class RuboCop::AST::Node < ::Parser::AST::Node
def forward_arg_type?; end
def forward_args_type?; end
def forwarded_args_type?; end
+ def forwarded_kwrestarg_type?; end
+ def forwarded_restarg_type?; end
def global_const?(param0 = T.unsafe(nil), param1); end
def guard_clause?; end
... | true |
Other | Homebrew | brew | 867a39f3e56382621bf025d87cf8d4007a8040d4.json | Update RBI files for rubocop-ast.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi | @@ -6723,10 +6723,6 @@ class RuboCop::AST::Node
def cask_block?(param0=T.unsafe(nil)); end
- def forwarded_kwrestarg_type?(); end
-
- def forwarded_restarg_type?(); end
-
def key_node(param0=T.unsafe(nil)); end
def method_node(param0=T.unsafe(nil)); end
@@ -6747,18 +6743,11 @@ module RuboCop::AST::Node... | true |
Other | Homebrew | brew | d4ab8497211d737dd18c0ebbbc8af22f82a17d27.json | sorbet: Update RBI files.
Autogenerated by the [sorbet](https://github.com/Homebrew/brew/blob/master/.github/workflows/sorbet.yml) workflow. | Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi | @@ -6744,6 +6744,7 @@ module RuboCop::AST::NodePattern::Sets
SET_BUILD_RECOMMENDED_TEST_OPTIONAL = ::T.let(nil, ::T.untyped)
SET_DEPENDS_ON_USES_FROM_MACOS = ::T.let(nil, ::T.untyped)
SET_INCLUDE_WITH_WITHOUT = ::T.let(nil, ::T.untyped)
+ SET_MAC_LINUX = ::T.let(nil, ::T.untyped)
SET_ON_INTEL_ON_ARM = ::T.... | false |
Other | Homebrew | brew | 7bc427405a475e8aabb4fbd31367f375a88ed6ab.json | governance: update membership procedures | docs/Homebrew-Leadership-Responsibilities.md | @@ -29,11 +29,12 @@
- Book a group dinner (which Homebrew pays for) and check for any dietary requirements
- Ask someone to bring a conference/table microphone for people to be able to remotely participate in AGM
- February after the AGM:
- - Add the minutes of the AGM to <https://github.com/Homebrew/brew/tree/... | true |
Other | Homebrew | brew | 7bc427405a475e8aabb4fbd31367f375a88ed6ab.json | governance: update membership procedures | docs/New-Maintainer-Checklist.md | @@ -85,4 +85,4 @@ When admitted as members:
- Invite them to the [**@Homebrew/members** team](https://github.com/orgs/Homebrew/teams/members), to give them access to the private governance repository.
- Invite them as a single-channel guest to the #members channel on the [`machomebrew` private maintainers Slack](ht... | true |
Other | Homebrew | brew | be73fc19dd19819fca0ede70f28b3964b348e4e5.json | Update RBI files for parser.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/parser@3.1.3.0.rbi | @@ -59,6 +59,8 @@ class Parser::AST::Processor < ::AST::Processor
def on_find_pattern(node); end
def on_for(node); end
def on_forward_arg(node); end
+ def on_forwarded_kwrestarg(node); end
+ def on_forwarded_restarg(node); end
def on_gvar(node); end
def on_gvasgn(node); end
def on_hash(node); end
@@... | true |
Other | Homebrew | brew | be73fc19dd19819fca0ede70f28b3964b348e4e5.json | Update RBI files for parser.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi | @@ -6723,6 +6723,10 @@ class RuboCop::AST::Node
def cask_block?(param0=T.unsafe(nil)); end
+ def forwarded_kwrestarg_type?(); end
+
+ def forwarded_restarg_type?(); end
+
def key_node(param0=T.unsafe(nil)); end
def method_node(param0=T.unsafe(nil)); end
@@ -6748,6 +6752,12 @@ module RuboCop::AST::NodeP... | true |
Other | Homebrew | brew | 23ef33c3b1e25384c999135383fdd7f199fc693b.json | Update RBI files for bootsnap.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/bootsnap@1.15.0.rbi | @@ -18,15 +18,15 @@ module Bootsnap
def logger; end
def logger=(logger); end
def rb_get_path(fname); end
- def setup(cache_dir:, development_mode: T.unsafe(nil), load_path_cache: T.unsafe(nil), ignore_directories: T.unsafe(nil), compile_cache_iseq: T.unsafe(nil), compile_cache_yaml: T.unsafe(nil), com... | false |
Other | Homebrew | brew | 49bacd681eb77958da75897ec7bef1ac7f480653.json | diagnostic: remove some checks.
- Some of these are currently failing globally on GitHub Actions.
- Some(/all?) of these predate our use of the macOS sandbox,
environment filtering, PATH filtering and pushing users much harder to
use bottles instead of building from source
- I haven't seen a case for a long time w... | Library/Homebrew/diagnostic.rb | @@ -181,32 +181,6 @@ def check_for_installed_developer_tools
EOS
end
- # Anaconda installs multiple system & brew dupes, including OpenSSL, Python,
- # sqlite, libpng, Qt, etc. Regularly breaks compile on Vim, MacVim and others.
- # Is flagged as part of the *-config script checks below... | true |
Other | Homebrew | brew | 49bacd681eb77958da75897ec7bef1ac7f480653.json | diagnostic: remove some checks.
- Some of these are currently failing globally on GitHub Actions.
- Some(/all?) of these predate our use of the macOS sandbox,
environment filtering, PATH filtering and pushing users much harder to
use bottles instead of building from source
- I haven't seen a case for a long time w... | Library/Homebrew/test/diagnostic_checks_spec.rb | @@ -11,21 +11,6 @@
expect(checks.inject_file_list(%w[/a /b], "foo:\n")).to eq("foo:\n /a\n /b\n")
end
- specify "#check_for_anaconda" do
- mktmpdir do |path|
- anaconda = "#{path}/anaconda"
- python = "#{path}/python"
- FileUtils.touch anaconda
- File.write(python, "#! #{`which bash`... | true |
Other | Homebrew | brew | 43c3c59ca471af5c9a524e5eaf0ade1fad6ba4d6.json | fix one more | bin/brew | @@ -105,7 +105,7 @@ export HOMEBREW_LIBRARY
# set from user environment
# shellcheck disable=SC2154
# Use VISUAL if HOMEBREW_EDITOR and EDITOR are unset.
-if [[ -z "${HOMEBREW_EDITOR}" && -n "${VISUAL}" ]]
+if [[ -z "${HOMEBREW_EDITOR:-}" && -n "${VISUAL}" ]]
then
export HOMEBREW_EDITOR="${VISUAL}"
fi | false |
Other | Homebrew | brew | 08e81aaf7ab52c0a02b849571ac6266eb0e17d0c.json | Apply suggestions from code review
Co-authored-by: Bo Anderson <mail@boanderson.me> | .github/workflows/doctor.yml | @@ -18,13 +18,13 @@ jobs:
tests:
strategy:
matrix:
- include:
- - runner: "13-arm64-${{github.run_id}}-${{github.run_attempt}}"
- - runner: "12-arm64"
- - runner: "12-${{github.run_id}}-${{github.run_attempt}}"
- - runner: "11-arm64"
- - runner: "11-${{... | false |
Other | Homebrew | brew | 2f28b280589bdc447e8ac5bb577ecc4e33a85163.json | workflows/doctor: use ephemeral runners
This workflow hasn't been set up to run on our ephemeral runners. Let's
fix that. | .github/workflows/doctor.yml | @@ -18,9 +18,15 @@ jobs:
tests:
strategy:
matrix:
- version: ["12-arm64", "12", "11-arm64", "11", "10.15"]
+ include:
+ - runner: "13-arm64-${{github.run_id}}-${{github.run_attempt}}"
+ - runner: "12-arm64"
+ - runner: "12-${{github.run_id}}-${{github.run_attempt}... | false |
Other | Homebrew | brew | 9c2293a08e00e8c417df7a173b0aa13322352a59.json | Move Sandbox check to extend/os | Library/Homebrew/extend/os/mac/sandbox.rb | @@ -0,0 +1,9 @@
+# typed: strict
+# frozen_string_literal: true
+
+class Sandbox
+ sig { returns(T::Boolean) }
+ def self.available?
+ File.executable?(SANDBOX_EXEC)
+ end
+end | true |
Other | Homebrew | brew | 9c2293a08e00e8c417df7a173b0aa13322352a59.json | Move Sandbox check to extend/os | Library/Homebrew/extend/os/sandbox.rb | @@ -0,0 +1,4 @@
+# typed: strict
+# frozen_string_literal: true
+
+require "extend/os/mac/sandbox" if OS.mac? | true |
Other | Homebrew | brew | 9c2293a08e00e8c417df7a173b0aa13322352a59.json | Move Sandbox check to extend/os | Library/Homebrew/sandbox.rb | @@ -17,7 +17,7 @@ class Sandbox
sig { returns(T::Boolean) }
def self.available?
- OS.mac? && File.executable?(SANDBOX_EXEC)
+ false
end
sig { void }
@@ -256,3 +256,5 @@ def dump
end
private_constant :SandboxProfile
end
+
+require "extend/os/sandbox" | true |
Other | Homebrew | brew | 260fc858dfc538aaa3de3d82e3c5aaaf5301ae3d.json | Fix rubocop errors | Library/Homebrew/extend/os/linux/cleanup.rb | @@ -15,7 +15,7 @@ def use_system_ruby?
check_ruby_version = HOMEBREW_LIBRARY_PATH/"utils/ruby_check_version_script.rb"
rubies.uniq.any? do |ruby|
quiet_system ruby, "--enable-frozen-string-literal", "--disable=gems,did_you_mean,rubyopt",
- check_ruby_version, HOMEBREW_REQUIRE... | false |
Other | Homebrew | brew | 5ad0cd406ad71fc38944f67ec85c0776fc439b6e.json | Update RBI files for rack.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/rack@3.0.1.rbi | @@ -496,10 +496,13 @@ class Rack::Lint::Wrapper
def respond_to?(name, *_arg1); end
def response; end
def to_ary; end
+ def to_path; end
def verify_content_length(size); end
def verify_to_path; end
end
+Rack::Lint::Wrapper::BODY_METHODS = T.let(T.unsafe(nil), Hash)
+
class Rack::Lint::Wrapper::ErrorW... | false |
Other | Homebrew | brew | 6e215ecabafb958028d25795871b84f0f0faa2e5.json | Update RBI files for rubocop-rails.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/rack@3.0.1.rbi | @@ -496,10 +496,13 @@ class Rack::Lint::Wrapper
def respond_to?(name, *_arg1); end
def response; end
def to_ary; end
+ def to_path; end
def verify_content_length(size); end
def verify_to_path; end
end
+Rack::Lint::Wrapper::BODY_METHODS = T.let(T.unsafe(nil), Hash)
+
class Rack::Lint::Wrapper::ErrorW... | true |
Other | Homebrew | brew | 6e215ecabafb958028d25795871b84f0f0faa2e5.json | Update RBI files for rubocop-rails.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/gems/rubocop-rails@2.17.3.rbi | @@ -178,6 +178,7 @@ RuboCop::Cop::Rails::ActionFilter::RESTRICT_ON_SEND = T.let(T.unsafe(nil), Array
class RuboCop::Cop::Rails::ActionOrder < ::RuboCop::Cop::Base
include ::RuboCop::Cop::VisibilityHelp
include ::RuboCop::Cop::DefNode
+ include ::RuboCop::Cop::RangeHelp
extend ::RuboCop::Cop::AutoCorrector
... | true |
Other | Homebrew | brew | 6e215ecabafb958028d25795871b84f0f0faa2e5.json | Update RBI files for rubocop-rails.
Autogenerated by the [vendor-gems](https://github.com/Homebrew/brew/blob/HEAD/.github/workflows/vendor-gemss.yml) workflow. | Library/Homebrew/sorbet/rbi/hidden-definitions/hidden.rbi | @@ -6742,6 +6742,7 @@ module RuboCop::AST::NodePattern::Sets
SET_INCLUDE_WITH_WITHOUT = ::T.let(nil, ::T.untyped)
SET_ON_INTEL_ON_ARM = ::T.let(nil, ::T.untyped)
SET_OR_NEWER_OR_OLDER = ::T.let(nil, ::T.untyped)
+ SET_STDOUT_STDERR = ::T.let(nil, ::T.untyped)
SET_SYSTEM_SHELL_OUTPUT_PIPE_OUTPUT = ::T.let(n... | true |
Other | Homebrew | brew | c7d53a2d9c6aee0222392cd180e96b51cee83522.json | Add cop to police os checks
The methods `OS.linux?` and `OS.mac?` should only be used
in `extend/os` and this cop makes sure of that. | Library/.rubocop.yml | @@ -55,6 +55,11 @@ FormulaAudit:
FormulaAuditStrict:
Enabled: true
+Homebrew/MoveToExtendOS:
+ Exclude:
+ - "Homebrew/{extend,test}/**/*"
+ - "Taps/**/*"
+
# enable all Homebrew custom cops
Homebrew:
Enabled: true | true |
Other | Homebrew | brew | c7d53a2d9c6aee0222392cd180e96b51cee83522.json | Add cop to police os checks
The methods `OS.linux?` and `OS.mac?` should only be used
in `extend/os` and this cop makes sure of that. | Library/Homebrew/rubocops/all.rb | @@ -14,6 +14,7 @@
require_relative "io_read"
require_relative "shell_commands"
+require_relative "platform"
require_relative "formula_desc"
require_relative "components_order" | true |
Other | Homebrew | brew | c7d53a2d9c6aee0222392cd180e96b51cee83522.json | Add cop to police os checks
The methods `OS.linux?` and `OS.mac?` should only be used
in `extend/os` and this cop makes sure of that. | Library/Homebrew/rubocops/platform.rb | @@ -0,0 +1,25 @@
+# typed: false
+# frozen_string_literal: true
+
+module RuboCop
+ module Cop
+ module Homebrew
+ # This cop ensures that platform specific code ends up in `extend/os`.
+ #
+ # @api private
+ class MoveToExtendOS < Base
+ MSG = "Move calls to `OS.linux?` and `OS.mac?` to ... | true |
Other | Homebrew | brew | c7d53a2d9c6aee0222392cd180e96b51cee83522.json | Add cop to police os checks
The methods `OS.linux?` and `OS.mac?` should only be used
in `extend/os` and this cop makes sure of that. | Library/Homebrew/test/rubocops/platform_spec.rb | @@ -0,0 +1,22 @@
+# typed: false
+# frozen_string_literal: true
+
+require "rubocops/platform"
+
+describe RuboCop::Cop::Homebrew::MoveToExtendOS do
+ subject(:cop) { described_class.new }
+
+ it "registers an offense when using `OS.linux?`" do
+ expect_offense(<<~RUBY)
+ OS.linux?
+ ^^^^^^^^^ Move calls... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.