language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/lib/mixins/view_target_action_support.js | @@ -14,7 +14,7 @@ For example:
```javascript
App.SaveButtonView = Ember.View.extend(Ember.ViewTargetActionSupport, {
action: 'save',
- click: function(){
+ click: function() {
this.triggerAction(); // Sends the `save` action, along with the current context
// to the current contro... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/lib/system/render_buffer.js | @@ -455,7 +455,7 @@ Ember._RenderBuffer.prototype =
if (this._hasElement && this._element) {
// Firefox versions < 11 do not have support for element.outerHTML.
var thisElement = this.element(), outerHTML = thisElement.outerHTML;
- if (typeof outerHTML === 'undefined'){
+ if (typeof outerHT... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/lib/system/utils.js | @@ -9,7 +9,7 @@
// is a "zero-scope" element. This problem can be worked around by making
// the first node an invisible text node. We, like Modernizr, use ­
-var needsShy = this.document && (function(){
+var needsShy = this.document && (function() {
var testEl = document.createElement('div');
testEl.inne... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/lib/views/view.js | @@ -18,7 +18,7 @@ var childViewsProperty = Ember.computed(function() {
a_forEach(childViews, function(view) {
var currentChildViews;
if (view.isVirtual) {
- if(currentChildViews = get(view, 'childViews')) {
+ if (currentChildViews = get(view, 'childViews')) {
ret.pushObjects(currentChild... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/tests/system/ext_test.js | @@ -7,7 +7,7 @@ test("View hierarchy is done rendering to DOM when functions queued in afterRend
render: function(buffer) {
buffer.push('child');
},
- didInsertElement: function(){
+ didInsertElement: function() {
this.$().addClass('extra-class');
}
});
@@ -19,7 +19,7 @@ test("View... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/tests/system/render_buffer_test.js | @@ -88,12 +88,12 @@ test("handles null props - Issue #2019", function() {
equal('<span></span><div>', buffer.string());
});
-test("handles browsers like Firefox < 11 that don't support outerHTML Issue #1952", function(){
+test("handles browsers like Firefox < 11 that don't support outerHTML Issue #1952", function... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/tests/views/collection_test.js | @@ -8,7 +8,7 @@ module("Ember.CollectionView", {
},
teardown: function() {
delete Ember.CollectionView.CONTAINER_MAP.del;
- Ember.run(function(){
+ Ember.run(function() {
if (view) { view.destroy(); }
});
}
@@ -543,7 +543,7 @@ test("a array_proxy that backs an sorted array_controller tha... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/tests/views/container_view_test.js | @@ -34,7 +34,7 @@ test("should be able to insert views after the DOM representation is created", f
equal(view._parentView, container, 'view\'s _parentView is the container');
equal(Ember.$.trim(container.$().text()), "This is my moment");
- Ember.run(function(){
+ Ember.run(function() {
container.destroy... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/tests/views/view/append_to_test.js | @@ -8,7 +8,7 @@ module("Ember.View - append() and appendTo()", {
},
teardown: function() {
- Ember.run(function(){
+ Ember.run(function() {
if (!view.isDestroyed) { view.destroy(); }
});
}
@@ -46,16 +46,16 @@ test("should be added to the document body when calling append()", function() {
... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/tests/views/view/attribute_bindings_test.js | @@ -13,7 +13,7 @@ module("Ember.View - Attribute Bindings", {
},
teardown: function() {
if (view) {
- Ember.run(function(){
+ Ember.run(function() {
view.destroy();
});
view = null;
@@ -37,7 +37,7 @@ test("should render attribute bindings", function() {
notNumber: NaN
... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/tests/views/view/child_views_test.js | @@ -17,7 +17,7 @@
},
teardown: function() {
- Ember.run(function(){
+ Ember.run(function() {
parentView.destroy();
childView.destroy();
}); | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/tests/views/view/class_name_bindings_test.js | @@ -30,7 +30,7 @@ test("should apply bound class names to the element", function() {
}
});
- Ember.run(function(){
+ Ember.run(function() {
view.createElement();
});
@@ -66,7 +66,7 @@ test("should add, remove, or change class names if changed after element is crea
})
});
- Ember.run(fun... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/tests/views/view/create_element_test.js | @@ -13,7 +13,7 @@ test("returns the receiver", function() {
view = Ember.View.create();
- Ember.run(function(){
+ Ember.run(function() {
ret = view.createElement();
});
@@ -30,7 +30,7 @@ test("calls render and turns resultant string into element", function() {
});
equal(get(view, 'element'), ... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/tests/views/view/destroy_element_test.js | @@ -36,7 +36,7 @@ test("if it has a element, calls willDestroyElement on receiver and child views
})]
});
- Ember.run(function(){
+ Ember.run(function() {
view.createElement();
});
@@ -56,7 +56,7 @@ test("returns receiver", function() {
var ret;
view = Ember.View.create();
- Ember.run(fun... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/tests/views/view/destroy_test.js | @@ -9,7 +9,7 @@ test("should teardown viewName on parentView when childView is destroyed", funct
equal(get(parentView, viewName), childView, "Precond - child view was registered on parent");
- Ember.run(function(){
+ Ember.run(function() {
childView.destroy();
});
| true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/tests/views/view/is_visible_test.js | @@ -33,7 +33,7 @@ module("Ember.View#isVisible", {
teardown: function() {
if (view) {
- Ember.run(function(){ view.destroy(); });
+ Ember.run(function() { view.destroy(); });
}
}
});
@@ -89,7 +89,7 @@ test("should hide element if isVisible is false before element is created", func
});
t... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/tests/views/view/jquery_test.js | @@ -15,7 +15,7 @@ module("Ember.View#$", {
},
teardown: function() {
- Ember.run(function(){
+ Ember.run(function() {
view.destroy();
});
} | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/tests/views/view/layout_test.js | @@ -24,7 +24,7 @@ test("should call the function of the associated layout", function() {
templateName: 'template'
});
- Ember.run(function(){
+ Ember.run(function() {
view.createElement();
});
@@ -46,7 +46,7 @@ test("should call the function of the associated template with itself as the con
}... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/tests/views/view/nearest_of_type_test.js | @@ -41,7 +41,7 @@ module("Ember.View#nearest*", {
equal(child.nearestOfType(Mixin), parentView, "finds closest view in the hierarchy by class");
});
-test("nearestWithProperty should search immediate parent", function(){
+test("nearestWithProperty should search immediate parent", function() {
var childView... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/tests/views/view/remove_test.js | @@ -48,7 +48,7 @@ module("Ember.View#removeAllChildren", {
},
teardown: function() {
Ember.run(function() {
- childViews.forEach(function(v){ v.destroy(); });
+ childViews.forEach(function(v) { v.destroy(); });
view.destroy();
});
}
@@ -83,7 +83,7 @@ test("removes view from parent vi... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/tests/views/view/render_test.js | @@ -32,7 +32,7 @@ test("default implementation does not render child views", function() {
})
});
- Ember.run(function(){
+ Ember.run(function() {
view.createElement();
});
equal(rendered, 1, 'rendered the child once');
@@ -76,7 +76,7 @@ test("should invoke renderChildViews if layer is destroyed t... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/tests/views/view/replace_in_test.js | @@ -8,7 +8,7 @@ module("Ember.View - replaceIn()", {
},
teardown: function() {
- Ember.run(function(){
+ Ember.run(function() {
view.destroy();
});
}
@@ -56,7 +56,7 @@ module("Ember.View - replaceIn() in a view hierarchy", {
},
teardown: function() {
- Ember.run(function(){
+ ... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/tests/views/view/template_test.js | @@ -22,7 +22,7 @@ test("should call the function of the associated template", function() {
templateName: 'testTemplate'
});
- Ember.run(function(){
+ Ember.run(function() {
view.createElement();
});
@@ -43,7 +43,7 @@ test("should call the function of the associated template with itself as the con
... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-views/tests/views/view/view_lifecycle_test.js | @@ -9,7 +9,7 @@ module("views/view/view_lifecycle_test - pre-render", {
teardown: function() {
if (view) {
- Ember.run(function(){
+ Ember.run(function() {
view.destroy();
});
}
@@ -92,7 +92,7 @@ module("views/view/view_lifecycle_test - in render", {
teardown: function() {
... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember/tests/helpers/link_to_test.js | @@ -124,7 +124,7 @@ test("The {{linkTo}} helper supports URL replacement", function() {
equal(replaceCount, 1, 'replaceURL should be called once');
});
-test("the {{linkTo}} helper doesn't add an href when the tagName isn't 'a'", function(){
+test("the {{linkTo}} helper doesn't add an href when the tagName isn't ... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember/tests/routing/basic_test.js | @@ -400,7 +400,7 @@ test("The Homepage with a computed context that does not get overridden", functi
});
App.HomeController = Ember.ArrayController.extend({
- content: Ember.computed(function(){
+ content: Ember.computed(function() {
return Ember.A([
"Monday through Friday: 9am to 5pm",
... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/metamorph/lib/main.js | @@ -7,7 +7,7 @@ define("metamorph",
// Copyright: ©2011 My Company Inc. All rights reserved.
// ==========================================================================
- var K = function(){},
+ var K = function() {},
guid = 0,
document = this.document,
@@ -17,7 +17,7 @@ define("... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/rsvp/lib/main.js | @@ -74,7 +74,7 @@ define("rsvp/async",
observer.observe(element, { attributes: true });
// Chrome Memory Leak: https://bugs.webkit.org/show_bug.cgi?id=93661
- window.addEventListener('unload', function(){
+ window.addEventListener('unload', function() {
observer.disconnect();
... | true |
Other | emberjs | ember.js | 9a86b20c98fab82b8b6c583f0ae077bc4e7184ed.json | Fix typos in the inline testing package docs | packages/ember-testing/lib/helpers.js | @@ -189,7 +189,7 @@ helper('visit', visit);
* ```
*
* @method click
-* @param {String} selcetor jQuery selector for finding element on the DOM
+* @param {String} selector jQuery selector for finding element on the DOM
* @returns {RSVP.Promise}
*/
helper('click', click);
@@ -205,8 +205,8 @@ helper('click', click);... | true |
Other | emberjs | ember.js | 9a86b20c98fab82b8b6c583f0ae077bc4e7184ed.json | Fix typos in the inline testing package docs | packages/ember-testing/lib/test.js | @@ -22,9 +22,9 @@ Ember.Test = {
For example:
```javascript
- Ember.Test.registerHelper('boot', function(app)) {
+ Ember.Test.registerHelper('boot', function(app) {
Ember.run(app, app.deferReadiness);
- }
+ });
```
This helper can later be called without arguments | true |
Other | emberjs | ember.js | 687ef9e408b73eb0b414262ed0d8c6b2f3557484.json | update jshint to include QUnit | .jshintrc | @@ -1,5 +1,6 @@
{
"predef": [
+ "QUnit",
"define",
"console",
"Ember", | false |
Other | emberjs | ember.js | 0b966fd1628f107f24cf7b545568e309c0caf346.json | remove un-needed context preservation | packages/ember-routing/lib/system/router.js | @@ -86,11 +86,7 @@ Ember.Router = Ember.Object.extend({
handleURL: function(url) {
scheduleLoadingStateEntry(this);
- var self = this;
-
- return this.router.handleURL(url).then(function() {
- transitionCompleted(self);
- });
+ return this.router.handleURL(url).then(transitionCompleted);
}... | false |
Other | emberjs | ember.js | 1122abef59a1f957ab5f838029b5731a869b5a99.json | update basic tests
- add handleURL helper
- handleURL helper brings its own runloop
- assert handleURL is either fulfilled or rejected
- handle previously un-handled handleURL promise rejections | packages/ember-application/tests/system/logging_test.js | @@ -42,14 +42,20 @@ module("Ember.Application – logging of generated classes", {
function visit(path) {
stop();
- var promise = new Ember.RSVP.Promise(function(resolve, reject){
- var router = App.__container__.lookup('router:main');
-
- Ember.run(App, 'handleURL', path);
- Ember.run(router, router.loca... | true |
Other | emberjs | ember.js | 1122abef59a1f957ab5f838029b5731a869b5a99.json | update basic tests
- add handleURL helper
- handleURL helper brings its own runloop
- assert handleURL is either fulfilled or rejected
- handle previously un-handled handleURL promise rejections | packages/ember/tests/routing/basic_test.js | @@ -10,6 +10,40 @@ function compile(string) {
return Ember.Handlebars.compile(string);
}
+function handleURL(path) {
+ return Ember.run(function() {
+ return router.handleURL(path).then(function(value) {
+ ok(true, 'url: `' + path + '` was handled');
+ return value;
+ }, function(reason) {
+ ... | true |
Other | emberjs | ember.js | 1629e12a0c30ba11b4bdeb3280cd36698e9caf6b.json | Fix typo in core_object.js | packages/ember-runtime/lib/system/core_object.js | @@ -6,8 +6,8 @@ require('ember-runtime/system/namespace');
*/
-// NOTE: this object should never be included directly. Instead use Ember.
-// Ember.Object. We only define this separately so that Ember.Set can depend on it
+// NOTE: this object should never be included directly. Instead use `Ember.Object`.
+// We o... | false |
Other | emberjs | ember.js | f20bf0599d8185aaa7d154081d0b41336d7d85e2.json | Improve Ember.Logger setup - Fixes #2962 | packages/ember-metal/lib/core.js | @@ -152,16 +152,19 @@ Ember.uuid = 0;
//
function consoleMethod(name) {
- if (imports.console && imports.console[name]) {
+ var console = imports.console,
+ method = typeof console === 'object' ? console[name] : null;
+
+ if (method) {
// Older IE doesn't support apply, but Chrome needs it
- if (imp... | false |
Other | emberjs | ember.js | e08d638d4033457d3c21f2458ff64e7714bd9dbd.json | add resolveModel to the default resolver | packages/ember-application/lib/system/resolver.js | @@ -71,6 +71,7 @@ var get = Ember.get,
'view:blog/post' //=> Blog.PostView
'view:basic' //=> Ember.View
'foo:post' //=> App.PostFoo
+ 'model:post' //=> App.Post
```
@class DefaultResolver
@@ -191,6 +192,17 @@ Ember.DefaultResolver = Ember.Object.extend({
this.useRouterNaming(parsedName);
ret... | true |
Other | emberjs | ember.js | e08d638d4033457d3c21f2458ff64e7714bd9dbd.json | add resolveModel to the default resolver | packages/ember-application/tests/system/dependency_injection/default_resolver_test.js | @@ -46,3 +46,7 @@ test('the default resolver looks up arbitrary types on the namespace', function(
equal(locator.resolve('manager:foo'), application.FooManager, "looks up FooManager on application");
});
+test("the default resolver resolves models on the namespace", function() {
+ application.Post = Ember.Object... | true |
Other | emberjs | ember.js | ba042244de33a172e4d7bf2a3f486f5746bc8475.json | fix deprecation warning | packages/ember-handlebars/tests/handlebars_test.js | @@ -712,7 +712,8 @@ test("edge case: child conditional should not render children if parent conditio
test("Template views return throw if their template cannot be found", function() {
view = Ember.View.create({
- templateName: 'cantBeFound'
+ templateName: 'cantBeFound',
+ container: { lookup: function()... | false |
Other | emberjs | ember.js | 1af8c0771a3ed3df1dfea428bdc132ac64bf5c79.json | Specify controller of a route via controllerName
This commit adds the possibility to specify the controller a route shall
use via a `controllerName` property.
Given the following app:
```
App.Router.map(function() {
this.resource('team', function() {
this.route('overview');
this.route('detail');
});
});
... | packages/ember-routing/lib/system/route.js | @@ -214,7 +214,7 @@ Ember.Route = Ember.Object.extend({
@method setup
*/
setup: function(context) {
- var controller = this.controllerFor(this.routeName, context);
+ var controller = this.controllerFor(this.controllerName || this.routeName, context);
// Assign the route's controller so that it c... | true |
Other | emberjs | ember.js | 1af8c0771a3ed3df1dfea428bdc132ac64bf5c79.json | Specify controller of a route via controllerName
This commit adds the possibility to specify the controller a route shall
use via a `controllerName` property.
Given the following app:
```
App.Router.map(function() {
this.resource('team', function() {
this.route('overview');
this.route('detail');
});
});
... | packages/ember/tests/routing/basic_test.js | @@ -341,6 +341,22 @@ test("The route controller is still set when overriding the setupController hook
deepEqual(container.lookup('route:home').controller, container.lookup('controller:home'), "route controller is the home controller");
});
+test("The route controller can be specified via controllerName", function... | true |
Other | emberjs | ember.js | 0a7420c63b59d22f6a89c5f3967fac106f743a78.json | Remove property for compatibility
This is the compatibility for SproutCore.
But now it seems no longer needed. | packages/ember-runtime/lib/mixins/enumerable.js | @@ -72,9 +72,6 @@ function iter(key, value) {
*/
Ember.Enumerable = Ember.Mixin.create({
- // compatibility
- isEnumerable: true,
-
/**
Implement this method to make your class enumerable.
| false |
Other | emberjs | ember.js | 000f47f75c14aed055f5c2e1b5ccecfa37d43755.json | Fix failing test in IE | packages/ember-testing/tests/helpers_test.js | @@ -178,6 +178,8 @@ test("`click` triggers appropriate events in order", function() {
['mousedown', 'focusin', 'mouseup', 'click'],
'fires focus events on textareas');
}).then(function() {
+ // In IE (< 8), the change event only fires when the value changes before element focused.
+ Ember.$('.ind... | false |
Other | emberjs | ember.js | a050008557631dce1049636f957abff7005d0542.json | Remove unnecessary array
To save code size and improve performance. | packages/ember-handlebars/lib/controls/select.js | @@ -441,15 +441,15 @@ Ember.Select = Ember.View.extend(
groupedContent: Ember.computed(function() {
var groupPath = get(this, 'optionGroupPath');
- var groupedContent = Ember.A([]);
+ var groupedContent = Ember.A();
forEach(get(this, 'content'), function(item) {
var label = get(item, group... | true |
Other | emberjs | ember.js | a050008557631dce1049636f957abff7005d0542.json | Remove unnecessary array
To save code size and improve performance. | packages/ember-handlebars/tests/controls/select_test.js | @@ -725,7 +725,7 @@ test("upon content change with Array-like content, the DOM should reflect the se
sylvain = {id: 5, name: 'Sylvain'};
var proxy = Ember.ArrayProxy.create({
- content: Ember.A([]),
+ content: Ember.A(),
selectedOption: sylvain
});
| true |
Other | emberjs | ember.js | a050008557631dce1049636f957abff7005d0542.json | Remove unnecessary array
To save code size and improve performance. | packages/ember-handlebars/tests/helpers/each_test.js | @@ -370,7 +370,7 @@ test("it supports {{else}}", function() {
assertHTML(view, "onetwo");
Ember.run(function() {
- view.set('items', Ember.A([]));
+ view.set('items', Ember.A());
});
assertHTML(view, "Nothing"); | true |
Other | emberjs | ember.js | a050008557631dce1049636f957abff7005d0542.json | Remove unnecessary array
To save code size and improve performance. | packages/ember-handlebars/tests/helpers/if_unless_test.js | @@ -80,7 +80,7 @@ test("The `if` helper updates if an object proxy gains or loses context", functi
test("The `if` helper updates if an array is empty or not", function() {
view = Ember.View.create({
- array: Ember.A([]),
+ array: Ember.A(),
template: compile('{{#if view.array}}Yep{{/if}}')
}); | true |
Other | emberjs | ember.js | a050008557631dce1049636f957abff7005d0542.json | Remove unnecessary array
To save code size and improve performance. | packages/ember-handlebars/tests/helpers/yield_test.js | @@ -65,7 +65,7 @@ test("templates should yield to block, when the yield is embedded in a hierarchy
layout: Ember.Handlebars.compile('<div class="times">{{#each view.index}}{{yield}}{{/each}}</div>'),
n: null,
index: Ember.computed(function() {
- var n = Ember.get(this, 'n'), indexArray = Ember.A([])... | true |
Other | emberjs | ember.js | a050008557631dce1049636f957abff7005d0542.json | Remove unnecessary array
To save code size and improve performance. | packages/ember-runtime/lib/mixins/array.js | @@ -154,7 +154,7 @@ Ember.Array = Ember.Mixin.create(Ember.Enumerable, /** @scope Ember.Array.protot
@return {Array} New array with specified slice
*/
slice: function(beginIndex, endIndex) {
- var ret = Ember.A([]);
+ var ret = Ember.A();
var length = get(this, 'length') ;
if (isNone(beginInd... | true |
Other | emberjs | ember.js | a050008557631dce1049636f957abff7005d0542.json | Remove unnecessary array
To save code size and improve performance. | packages/ember-runtime/lib/mixins/enumerable.js | @@ -284,7 +284,7 @@ Ember.Enumerable = Ember.Mixin.create({
@return {Array} The mapped array.
*/
map: function(callback, target) {
- var ret = Ember.A([]);
+ var ret = Ember.A();
this.forEach(function(x, idx, i) {
ret[idx] = callback.call(target, x, idx,i);
});
@@ -334,7 +334,7 @@ Embe... | true |
Other | emberjs | ember.js | a050008557631dce1049636f957abff7005d0542.json | Remove unnecessary array
To save code size and improve performance. | packages/ember-runtime/tests/core/is_array_test.js | @@ -1,7 +1,7 @@
module("Ember Type Checking");
test("Ember.isArray" ,function(){
- var arrayProxy = Ember.ArrayProxy.create({ content: Ember.A([]) });
+ var arrayProxy = Ember.ArrayProxy.create({ content: Ember.A() });
equal(Ember.isArray(arrayProxy), true, "[]");
}); | true |
Other | emberjs | ember.js | a050008557631dce1049636f957abff7005d0542.json | Remove unnecessary array
To save code size and improve performance. | packages/ember-runtime/tests/core/is_empty_test.js | @@ -1,7 +1,7 @@
module("Ember.isEmpty");
test("Ember.isEmpty", function() {
- var arrayProxy = Ember.ArrayProxy.create({ content: Ember.A([]) });
+ var arrayProxy = Ember.ArrayProxy.create({ content: Ember.A() });
equal(true, Ember.isEmpty(arrayProxy), "for an ArrayProxy that has empty content");
}); | true |
Other | emberjs | ember.js | a050008557631dce1049636f957abff7005d0542.json | Remove unnecessary array
To save code size and improve performance. | packages/ember-runtime/tests/system/array_proxy/content_update_test.js | @@ -11,7 +11,7 @@ test("The `contentArrayDidChange` method is invoked after `content` is updated."
var proxy, observerCalled = false;
proxy = Ember.ArrayProxy.createWithMixins({
- content: Ember.A([]),
+ content: Ember.A(),
arrangedContent: Ember.computed('content', function(key, value) {
//... | true |
Other | emberjs | ember.js | c2794b681e9daf504b56f5c53ac7e6679986c37b.json | Fix example code indent | packages/ember-states/lib/state_manager.js | @@ -565,10 +565,10 @@ var sendEvent = function(eventName, sendRecursiveArguments, isUnhandledPass) {
})
}),
stateTwo: Ember.State.create({
- anAction: function(manager, context){
- // will not be called below because it is
- // not a parent of the current state
- }
+ anAction: ... | false |
Other | emberjs | ember.js | 58fd8c71ea677cd4e1e97de5d50b105e9ec0d92d.json | Document the container | packages/container/lib/main.js | @@ -2,12 +2,43 @@ define("container",
[],
function() {
+ /**
+ A safe and simple inheriting object.
+
+ @class InheritingDict
+ */
function InheritingDict(parent) {
this.parent = parent;
this.dict = {};
}
InheritingDict.prototype = {
+
+ /**
+ @property par... | true |
Other | emberjs | ember.js | 58fd8c71ea677cd4e1e97de5d50b105e9ec0d92d.json | Document the container | packages/container/tests/container_test.js | @@ -183,6 +183,19 @@ test("A failed lookup returns undefined", function() {
equal(container.lookup("doesnot:exist"), undefined);
});
+test("Injecting a failed lookup raises an error", function(){
+ var container = new Container();
+ var Foo = { create: function(){ }};
+
+ container.register('model:foo', Foo);
... | true |
Other | emberjs | ember.js | 0ccf084c62367ad725b286e6be1526d07d88e8ee.json | Use Ember.isNone instead of Ember.none | packages/ember-views/lib/views/view.js | @@ -2455,7 +2455,7 @@ Ember.View.applyAttributeBindings = function(elem, name, value) {
}
} else if (name === 'value' || type === 'boolean') {
// We can't set properties to undefined or null
- if (Ember.none(value)) { value = ''; }
+ if (Ember.isNone(value)) { value = ''; }
if (value !== elem.... | false |
Other | emberjs | ember.js | f6e85ce7aeb4ba2bcff9d3faf0df5fffa60d1f37.json | Update router.js. Fixes #2897. | packages/ember-routing/lib/vendor/router.js | @@ -343,15 +343,16 @@ define("router",
*/
function getMatchPoint(router, handlers, objects, inputParams) {
- var objectsToMatch = objects.length,
- matchPoint = handlers.length,
+ var matchPoint = handlers.length,
providedModels = {}, i,
currentHandlerInfos = rou... | false |
Other | emberjs | ember.js | 331d0c1d036274a00fc2d72dcb3c4783b7249949.json | Polyfill history.state for non-supporting browsers | packages/ember-routing/lib/location/history_location.js | @@ -5,6 +5,9 @@
var get = Ember.get, set = Ember.set;
var popstateFired = false;
+var supportsHistoryState = (function(){
+ return !!(window.history && history.hasOwnProperty('state'));
+})();
/**
Ember.HistoryLocation implements the location API using the browser's
@@ -67,9 +70,10 @@ Ember.HistoryLocation =... | false |
Other | emberjs | ember.js | 4023186ea157a8687ac611181e2ca49e5fc891d5.json | Update Handlebars version. | Gemfile | @@ -2,6 +2,7 @@ source "https://rubygems.org"
gem "rake-pipeline", :git => "https://github.com/livingsocial/rake-pipeline.git"
gem "ember-dev", :git => "https://github.com/emberjs/ember-dev.git", :branch => "master"
+gem "handlebars-source", :git => "https://github.com/wycats/handlebars.js.git", :tag => "v1.0.12"
... | true |
Other | emberjs | ember.js | 4023186ea157a8687ac611181e2ca49e5fc891d5.json | Update Handlebars version. | Gemfile.lock | @@ -23,11 +23,18 @@ GIT
rake (~> 10.0.0)
thor
+GIT
+ remote: https://github.com/wycats/handlebars.js.git
+ revision: 1585f917498f47263f3cd6dc4343ac377e93ad22
+ tag: v1.0.12
+ specs:
+ handlebars-source (1.0.12)
+
PATH
remote: .
specs:
ember-source (1.0.0.rc6)
- handlebars-source ... | true |
Other | emberjs | ember.js | 4023186ea157a8687ac611181e2ca49e5fc891d5.json | Update Handlebars version. | ember-source.gemspec | @@ -12,9 +12,7 @@ Gem::Specification.new do |gem|
gem.version = Ember.rubygems_version_string
- # Note: can't use the squiggly ~> operator the way we'd expect
- # so long as we're referencing pre-release versions.
- gem.add_dependency "handlebars-source", ["1.0.0.rc4"]
+ gem.add_dependency "handlebars-... | true |
Other | emberjs | ember.js | 4023186ea157a8687ac611181e2ca49e5fc891d5.json | Update Handlebars version. | packages/ember-handlebars-compiler/lib/main.js | @@ -15,8 +15,8 @@ if(!Handlebars && typeof require === 'function') {
Handlebars = require('handlebars');
}
-Ember.assert("Ember Handlebars requires Handlebars version 1.0.0-rc.4. Include a SCRIPT tag in the HTML HEAD linking to the Handlebars file before you link to Ember.", Handlebars)
-Ember.assert("Ember Handl... | true |
Other | emberjs | ember.js | 4023186ea157a8687ac611181e2ca49e5fc891d5.json | Update Handlebars version. | packages/ember-handlebars/tests/helpers/partial_test.js | @@ -49,7 +49,7 @@ test("should render other slash-separated templates registered with the containe
});
test("should use the current view's context", function(){
- container.register('template:_person_name', Ember.Handlebars.compile("{{{firstName}} {{lastName}}"));
+ container.register('template:_person_name', Emb... | true |
Other | emberjs | ember.js | 4023186ea157a8687ac611181e2ca49e5fc891d5.json | Update Handlebars version. | packages/ember-handlebars/tests/helpers/template_test.js | @@ -34,7 +34,7 @@ test("should render other templates via the container", function() {
});
test("should use the current view's context", function(){
- container.register('template:person_name', Ember.Handlebars.compile("{{{firstName}} {{lastName}}"));
+ container.register('template:person_name', Ember.Handlebars.... | true |
Other | emberjs | ember.js | 21cd24adc3dd3a12c4a90c830ebabc595287c3d0.json | fix some consistencies mistakes
I don't know if the remainings `control` terms are legits or not, so I didn't touch them. Please let me now if all `control` should be renamed to `component`. cc/ @wycats | packages/ember-views/lib/views/component.js | @@ -15,7 +15,7 @@ require("ember-views/views/view");
The easiest way to create an `Ember.Component` is via
a template. If you name a template
- `controls/my-foo`, you will be able to use
+ `components/my-foo`, you will be able to use
`{{my-foo}}` in other templates, which will make
an instance of the is... | false |
Other | emberjs | ember.js | 42f0c68a6f88c5bfd4c6420bcb8706a009f5f277.json | update lock file | Gemfile.lock | @@ -26,7 +26,7 @@ GIT
PATH
remote: .
specs:
- ember-source (1.0.0.rc5)
+ ember-source (1.0.0.rc6)
handlebars-source (= 1.0.0.rc4)
GEM | false |
Other | emberjs | ember.js | 344390e20e1133c7726f20f71fb0b7854b82f153.json | Add code comment | packages/ember-runtime/lib/system/string.js | @@ -239,8 +239,8 @@ Ember.String = {
```
@method capitalize
- @param {String} str
- @return {String}
+ @param {String} str The string to capitalize.
+ @return {String} The capitalized string.
*/
capitalize: function(str) {
return str.charAt(0).toUpperCase() + str.substr(1); | false |
Other | emberjs | ember.js | a24529e4742d45ffee624f2b6ddf2937c512b228.json | Remove unnecessary existing check for `Ember`
Now `Ember` is exist when `Ember.deprecate` is called. | packages/ember-debug/lib/main.js | @@ -95,12 +95,12 @@ Ember.debug = function(message) {
will be displayed.
*/
Ember.deprecate = function(message, test) {
- if (Ember && Ember.TESTING_DEPRECATION) { return; }
+ if (Ember.TESTING_DEPRECATION) { return; }
if (arguments.length === 1) { test = false; }
if (test) { return; }
- if (Ember &... | false |
Other | emberjs | ember.js | 854a460682b1c15ba28f7e3e7519952c70249754.json | Add test for parentViewDidChange event. | packages/ember-views/tests/views/container_view_test.js | @@ -111,6 +111,29 @@ test("should set the parentView property on views that are added to the child vi
});
});
+test("should trigger parentViewDidChange when parentView is changed", function() {
+ container = Ember.ContainerView.create();
+
+ var secondContainer = Ember.ContainerView.create();
+ var parentViewC... | false |
Other | emberjs | ember.js | 2ec3b2120ee1c6cfeee1a400d5cbae1c7d3bf781.json | Fix wrong example
An empty '<option>' is not render until `prompt` is set. | packages/ember-handlebars/lib/controls/select.js | @@ -158,7 +158,6 @@ Ember.SelectOption = Ember.View.extend({
```html
<select class="ember-select">
- <option value>Please Select</option>
<option value="1">Yehuda</option>
<option value="2">Tom</option>
</select>
@@ -191,7 +190,6 @@ Ember.SelectOption = Ember.View.extend({
```html
<selec... | false |
Other | emberjs | ember.js | a7ab858f9ef8496c8940cf8acc98d6f4ddff2dc1.json | add test for user provided template on a view | packages/ember/tests/routing/basic_test.js | @@ -244,6 +244,26 @@ test('render does not replace templateName if user provided', function() {
equal(Ember.$('p', '#qunit-fixture').text(), "THIS IS THE REAL HOME", "The homepage template was rendered");
});
+test('render does not replace template if user provided', function () {
+ Router.map(function () {
+ ... | false |
Other | emberjs | ember.js | 574c10b8a99a38c0b13fd0dc42c138a07ff629ea.json | Add tests for #1866 - loc helper | packages/ember-handlebars/lib/helpers/loc.js | @@ -15,6 +15,9 @@ require('ember-handlebars/ext');
</script>
```
+ Take note that `welcome` is a string and not an object
+ reference.
+
@method loc
@for Ember.Handlebars.helpers
@param {String} str The string to format | true |
Other | emberjs | ember.js | 574c10b8a99a38c0b13fd0dc42c138a07ff629ea.json | Add tests for #1866 - loc helper | packages/ember-handlebars/tests/helpers/loc_test.js | @@ -0,0 +1,51 @@
+var buildView = function(template, context) {
+ return Ember.View.create({
+ template: Ember.Handlebars.compile(template),
+ context: (context || {})
+ });
+};
+
+var appendView = function(view) {
+ Ember.run(function() {
+ view.appendTo('#qunit-fixture');
+ });
+};
+
+var destroyView = f... | true |
Other | emberjs | ember.js | 0e919f5e99c3615759a11e9bf8832434e8711ee8.json | add loc helper | packages/ember-handlebars/lib/helpers.js | @@ -8,3 +8,4 @@ require("ember-handlebars/helpers/each");
require("ember-handlebars/helpers/template");
require("ember-handlebars/helpers/partial");
require("ember-handlebars/helpers/yield");
+require("ember-handlebars/helpers/loc"); | true |
Other | emberjs | ember.js | 0e919f5e99c3615759a11e9bf8832434e8711ee8.json | add loc helper | packages/ember-handlebars/lib/helpers/loc.js | @@ -0,0 +1,25 @@
+require('ember-handlebars/ext');
+
+/**
+@module ember
+@submodule ember-handlebars
+*/
+
+/**
+ `loc` looks up the string in the localized strings hash.
+ This is a convenient way to localize text. For example:
+
+ ```html
+ <script type="text/x-handlebars" data-template-name="home">
+ {{loc w... | true |
Other | emberjs | ember.js | b71a406d25679acbc154bd75c8feab9fc4047569.json | Fix code comment | packages/ember-metal/lib/set_properties.js | @@ -10,9 +10,9 @@ var changeProperties = Ember.changeProperties,
observers will be buffered.
@method setProperties
- @param target
- @param {Hash} properties
- @return target
+ @param self
+ @param {Object} hash
+ @return self
*/
Ember.setProperties = function(self, hash) {
changeProperties(function(... | false |
Other | emberjs | ember.js | 6f6e7103d174be95cc62e87f28bcc753d6045062.json | Expand helper function | packages/ember-metal/lib/property_get.js | @@ -89,10 +89,6 @@ if (Ember.config.overrideAccessors) {
get = Ember.get;
}
-function firstKey(path) {
- return path.match(FIRST_KEY)[0];
-}
-
/**
@private
@@ -116,7 +112,7 @@ var normalizeTuple = Ember.normalizeTuple = function(target, path) {
if (hasThis) path = path.slice(5);
if (target === Embe... | false |
Other | emberjs | ember.js | 5079d4efc5eb694354c3afb89f5af30aafb2fb54.json | Improve docs for event names | packages/ember-views/lib/views/view.js | @@ -759,8 +759,10 @@ class:
### Event Names
- Possible events names for any of the responding approaches described above
- are:
+ All of the event handling approaches described above respond to the same set
+ of events. The names of the built-in events are listed below. (The hash of
+ built-in events exists... | false |
Other | emberjs | ember.js | 7138bbbf22aaafb0791023b5f45b2bd5c719a08e.json | Remove expectAssertion in favor of ember-dev | Gemfile.lock | @@ -1,6 +1,6 @@
GIT
remote: https://github.com/emberjs/ember-dev.git
- revision: 104afee9ca7bf406af545126f377f696c0c10581
+ revision: d064bd6c33e87979aa5b852f8eb853c39b190e87
branch: master
specs:
ember-dev (0.1) | true |
Other | emberjs | ember.js | 7138bbbf22aaafb0791023b5f45b2bd5c719a08e.json | Remove expectAssertion in favor of ember-dev | tests/ember_configuration.js | @@ -41,57 +41,5 @@
runtime: 'ember-runtime.js'
};
- function expectAssertion(fn, expectedMessage) {
- var originalAssert = Ember.assert,
- actualMessage, actualTest,
- arity, sawAssertion;
- var AssertionFailedError = new Error('AssertionFailed');
-
- try {
- Ember.assert = function... | true |
Other | emberjs | ember.js | 6867a0b14a1bbee72e81b4245628f0a5f78803df.json | Fix failing tests for non-blocking assertions | packages/ember-handlebars/lib/main.js | @@ -1,5 +1,5 @@
-require("ember-handlebars-compiler");
require("ember-runtime");
+require("ember-handlebars-compiler");
require("ember-views");
require("ember-handlebars/ext");
require("ember-handlebars/string"); | true |
Other | emberjs | ember.js | 6867a0b14a1bbee72e81b4245628f0a5f78803df.json | Fix failing tests for non-blocking assertions | packages/ember-old-router/tests/routable_test.js | @@ -670,7 +670,7 @@ test("if a leaf state has a redirectsTo, it automatically transitions into that
});
test("you cannot define connectOutlets AND redirectsTo", function() {
- raises(function() {
+ expectAssertion(function() {
Ember.Router.create({
location: 'none',
root: Ember.Route.create({
@... | true |
Other | emberjs | ember.js | f872a78760d5111b0e468a06389d549cb8832ab2.json | Utilize the browser console.assert when possible
Currently our asserts are catchable by try/catches.
This can occur accidentally, hiding real issues in
both user code, framework code, and explicitly in
promises.
Chrome's currently implementation of console.assert
is not catchable, and does not interfere with the
pro... | .jshintrc | @@ -25,7 +25,8 @@
"strictEqual",
"module",
"expect",
- "minispade"
+ "minispade",
+ "expectAssertion"
],
"node" : false, | true |
Other | emberjs | ember.js | f872a78760d5111b0e468a06389d549cb8832ab2.json | Utilize the browser console.assert when possible
Currently our asserts are catchable by try/catches.
This can occur accidentally, hiding real issues in
both user code, framework code, and explicitly in
promises.
Chrome's currently implementation of console.assert
is not catchable, and does not interfere with the
pro... | packages/ember-debug/lib/main.js | @@ -44,7 +44,7 @@ if (!('MANDATORY_SETTER' in Ember.ENV)) {
falsy, an exception will be thrown.
*/
Ember.assert = function(desc, test) {
- if (!test) throw new Error("assertion failed: "+desc);
+ Ember.Logger.assert(test, desc);
};
| true |
Other | emberjs | ember.js | f872a78760d5111b0e468a06389d549cb8832ab2.json | Utilize the browser console.assert when possible
Currently our asserts are catchable by try/catches.
This can occur accidentally, hiding real issues in
both user code, framework code, and explicitly in
promises.
Chrome's currently implementation of console.assert
is not catchable, and does not interfere with the
pro... | packages/ember-metal/lib/core.js | @@ -167,6 +167,19 @@ function consoleMethod(name) {
}
}
+function assertPolyfill(test, message) {
+ if (!test) {
+ try {
+ // attempt to preserve the stack
+ throw new Error("assertion failed: " + message);
+ } catch(error) {
+ setTimeout(function(){
+ throw error;
+ }, 0);
+ ... | true |
Other | emberjs | ember.js | f872a78760d5111b0e468a06389d549cb8832ab2.json | Utilize the browser console.assert when possible
Currently our asserts are catchable by try/catches.
This can occur accidentally, hiding real issues in
both user code, framework code, and explicitly in
promises.
Chrome's currently implementation of console.assert
is not catchable, and does not interfere with the
pro... | tests/ember_configuration.js | @@ -40,4 +40,59 @@
prod: 'ember.prod.js',
runtime: 'ember-runtime.js'
};
+
+ function expectAssertion(fn, expectedMessage) {
+ var originalAssert = Ember.assert,
+ actualMessage, actualTest,
+ arity, sawAssertion;
+
+ var AssertionFailedError = new Error('AssertionFailed');
+
+ try {... | true |
Other | emberjs | ember.js | a8384b2aeee841bcfa6c400d538dee03c27a12ba.json | Fix typo in array mixin docs | packages/ember-runtime/lib/mixins/array.js | @@ -242,15 +242,15 @@ Ember.Array = Ember.Mixin.create(Ember.Enumerable, /** @scope Ember.Array.protot
Adds an array observer to the receiving array. The array observer object
normally must implement two methods:
- * `arrayWillChange(start, removeCount, addCount)` - This method will be
+ * `arrayWillC... | false |
Other | emberjs | ember.js | 07ed2e2bedba5a9b584800d4d84517fd03a28c78.json | Clarify subclasses of Ember.CoreView #2556 | packages/ember-handlebars/lib/views/metamorph_view.js | @@ -124,7 +124,7 @@ Ember._MetamorphView = Ember.View.extend(Ember._Metamorph);
/**
@class _SimpleMetamorphView
@namespace Ember
- @extends Ember.View
+ @extends Ember.CoreView
@uses Ember._Metamorph
@private
*/ | true |
Other | emberjs | ember.js | 07ed2e2bedba5a9b584800d4d84517fd03a28c78.json | Clarify subclasses of Ember.CoreView #2556 | packages/ember-views/lib/views/view.js | @@ -47,6 +47,15 @@ Ember.warn("The VIEW_PRESERVES_CONTEXT flag has been removed and the functionali
*/
Ember.TEMPLATES = {};
+/**
+ `Ember.CoreView` is
+
+ @class CoreView
+ @namespace Ember
+ @extends Ember.Object
+ @uses Ember.Evented
+*/
+
Ember.CoreView = Ember.Object.extend(Ember.Evented, {
isView: tr... | true |
Other | emberjs | ember.js | 7cc5db0544053b0d40f2f78f7f765ef98ff4f1fe.json | Remove unnecessary comment | packages/ember-views/lib/main.js | @@ -1,5 +1,3 @@
-/*globals jQuery*/
-
require("ember-runtime");
require("container");
| false |
Other | emberjs | ember.js | ef6b83956d5869b1a6b076b60f13940138ac8358.json | Remove unused variables | packages/ember-testing/lib/helpers.js | @@ -55,7 +55,7 @@ function find(app, selector, context) {
}
function wait(app, value) {
- var promise, obj = {}, helperName;
+ var promise;
promise = Ember.Test.promise(function(resolve) {
if (++countAsync === 1) { | true |
Other | emberjs | ember.js | ef6b83956d5869b1a6b076b60f13940138ac8358.json | Remove unused variables | packages/ember-testing/lib/test.js | @@ -103,7 +103,7 @@ Ember.Test = {
chained: false
};
thenable.then = function(onSuccess, onFailure) {
- var self = this, thenPromise, nextPromise;
+ var thenPromise, nextPromise;
thenable.chained = true;
thenPromise = promise.then(onSuccess, onFailure);
// this is to ensu... | true |
Other | emberjs | ember.js | b1e4fe508b1544a6a1525a4045c671e4fc5477b0.json | Remove unnecessary require | ember-source.gemspec | @@ -1,5 +1,4 @@
# -*- encoding: utf-8 -*-
-require 'json'
require "./lib/ember/version"
Gem::Specification.new do |gem| | false |
Other | emberjs | ember.js | 24aff50818c1f28c1c0b1690cd379091f6c99d15.json | Remove ember-testing from production build | Assetfile | @@ -4,7 +4,7 @@ distros = {
"runtime" => %w(ember-metal rsvp container ember-runtime),
"template-compiler" => %w(ember-handlebars-compiler),
"data-deps" => %w(ember-metal rsvp container ember-runtime ember-states),
- "full" => %w(ember-metal rsvp container ember-runtime ember-vi... | false |
Other | emberjs | ember.js | 8267e07a7b054421122f34a73c68c43c8e33204a.json | Fix failing tests in IE7 by normalizing URL
IE7 includes host hame in href attribute. | packages/ember/tests/helpers/link_to_test.js | @@ -247,7 +247,7 @@ test("The {{linkTo}} helper supports leaving off .index for nested routes", func
router.handleURL("/about/item");
});
- equal(Ember.$('#item a', '#qunit-fixture').attr('href'), '/about');
+ equal(normalizeUrl(Ember.$('#item a', '#qunit-fixture').attr('href')), '/about');
});
test("Th... | false |
Other | emberjs | ember.js | 9e75b058a240af6d9681ddeda1260b027c5c1172.json | Update backburner to fix IE8 failing test | packages/ember-metal/lib/vendor/backburner.js | @@ -165,7 +165,7 @@ define("backburner",
clearTimeout(laterTimer);
laterTimer = null;
}
- laterTimer = setTimeout(function() {
+ laterTimer = window.setTimeout(function() {
executeTimers(self);
laterTimer = null;
laterTimerExpiresAt = null;
@... | false |
Other | emberjs | ember.js | 6c53d40d7bba3cd23edb7e86ef145386df64d86a.json | maintain ruby'esq version string for gems | ember-source.gemspec | @@ -10,7 +10,8 @@ Gem::Specification.new do |gem|
gem.summary = %q{Ember.js source code wrapper.}
gem.description = %q{Ember.js source code wrapper for use with Ruby libs.}
gem.homepage = "https://github.com/emberjs/ember.js"
- gem.version = Ember::VERSION.gsub('-','.')
+
+ gem.version ... | true |
Other | emberjs | ember.js | 6c53d40d7bba3cd23edb7e86ef145386df64d86a.json | maintain ruby'esq version string for gems | lib/ember/version.rb | @@ -1,3 +1,13 @@
module Ember
+ extend self
+
VERSION = File.read(File.expand_path('../../../VERSION', __FILE__)).strip
+
+ # we might want to unify this with the ember version string,
+ # but consistency?
+ def rubygems_version_string
+ major, rc = VERSION.sub('-','.').scan(/(\d+\.\d+\.\d+\.rc)\.(\d+)/).fir... | true |
Other | emberjs | ember.js | c71352f70a4f19fb70ebe1dfcd2bc20878731f62.json | remove starter_kit upload task
(we just use the github tarbals) | Rakefile | @@ -86,19 +86,14 @@ namespace :release do
end
end
- desc "Upload release"
- task :upload do
- puts 'upload the starter kit manually'
- end
-
desc "Build the Ember.js starter kit"
task :build => "dist/starter-kit.#{Ember::VERSION}.zip"
desc "Prepare starter-kit for release"
... | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.