language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | 047b869f46ab17b2184c550e3b262e019a3da749.json | Remove unused local variable
`value` is assigned but not referenced anywhere. | packages/ember-metal/lib/map.js | @@ -247,12 +247,10 @@ Map.prototype = {
// to use in browsers that are not ES6 friendly;
var keys = this.keys,
values = this.values,
- guid = guidFor(key),
- value;
+ guid = guidFor(key);
if (values.hasOwnProperty(guid)) {
keys.remove(key);
- value = values[gui... | false |
Other | emberjs | ember.js | 6c6b6445aa38c58ba7a10133e2d30a3b4dd65ed3.json | Allow option view for Ember.Select overwritable | packages/ember-handlebars/lib/controls/select.js | @@ -13,6 +13,55 @@ var set = Ember.set,
isArray = Ember.isArray,
precompileTemplate = Ember.Handlebars.compile;
+Ember.SelectOption = Ember.View.extend({
+ tagName: 'option',
+ attributeBindings: ['value', 'selected'],
+
+ defaultTemplate: function(context, options) {
+ options = { data: options.data,... | false |
Other | emberjs | ember.js | f31afaea169d6645ff9c7786cdecf30b788dd5a1.json | Add routeNames to rendering assertion warning msg
The current message tells you that there may be an issue but doesn't clearly tell you in which routes the issue occurred. This adds the route & parent route ``routeName`` into the warning message | packages/ember-routing/lib/system/route.js | @@ -471,7 +471,7 @@ function parentTemplate(route, isRecursive) {
if (!parent) { return; }
- Ember.warn("The immediate parent route did not render into the main outlet and the default 'into' option may not be expected", !isRecursive);
+ Ember.warn("The immediate parent route ('%@') did not render into the main... | false |
Other | emberjs | ember.js | 4e55ea5acce9798d9fc7d4f54bb6c1746be4e693.json | remove uneeded closures | packages/ember-handlebars/lib/helpers/binding.js | @@ -13,6 +13,10 @@ var forEach = Ember.ArrayPolyfills.forEach;
var EmberHandlebars = Ember.Handlebars, helpers = EmberHandlebars.helpers;
+function exists(value){
+ return !Ember.isNone(value);
+}
+
// Binds a property into the DOM. This will create a hook in DOM that the
// KVO system will look for and update ... | false |
Other | emberjs | ember.js | 79fbf54d903d266abcb771ac63971ccb68479158.json | Remove unused valiables | packages/ember-application/lib/system/application.js | @@ -3,10 +3,7 @@
@submodule ember-application
*/
-var get = Ember.get, set = Ember.set,
- classify = Ember.String.classify,
- capitalize = Ember.String.capitalize,
- decamelize = Ember.String.decamelize;
+var get = Ember.get, set = Ember.set;
/**
An instance of `Ember.Application` is the starting poi... | false |
Other | emberjs | ember.js | 4cffb68da64abf56bbf34f6e3d5144a13b321287.json | Fix typo in {{partial}} docs. | packages/ember-handlebars/lib/helpers/partial.js | @@ -15,6 +15,7 @@ require('ember-handlebars/ext');
{{partial user_info}}
{{/with}}
</script>
+ ```
The `data-template-name` attribute of a partial template
is prefixed with an underscore. | false |
Other | emberjs | ember.js | 93ccb694a2668fbcc0e82e5cc398cc7975612763.json | Move Ember.typeOf to metal
*sigh* it's been a long day... | packages/ember-metal/lib/utils.js | @@ -1,5 +1,6 @@
require('ember-metal/core');
require('ember-metal/platform');
+require('ember-metal/array');
/**
@module ember-metal
@@ -527,3 +528,76 @@ if (needsFinallyFix) {
return (finalResult === undefined) ? result : finalResult;
};
}
+
+// ........................................
+// TYPING & ARRA... | true |
Other | emberjs | ember.js | 93ccb694a2668fbcc0e82e5cc398cc7975612763.json | Move Ember.typeOf to metal
*sigh* it's been a long day... | packages/ember-metal/lib/watch_key.js | @@ -2,7 +2,7 @@ require('ember-metal/utils');
require('ember-metal/platform');
var metaFor = Ember.meta, // utils.js
- typeOf = Ember.typeOf, // FIXME: defined in runtime
+ typeOf = Ember.typeOf, // utils.js
MANDATORY_SETTER = Ember.ENV.MANDATORY_SETTER,
o_defineProperty = Ember.platform.definePrope... | true |
Other | emberjs | ember.js | 93ccb694a2668fbcc0e82e5cc398cc7975612763.json | Move Ember.typeOf to metal
*sigh* it's been a long day... | packages/ember-metal/lib/watch_path.js | @@ -1,8 +1,8 @@
require('ember-metal/utils');
require('ember-metal/chains');
-var metaFor = Ember.meta,
- typeOf = Ember.typeOf, // FIXME: defined in runtime
+var metaFor = Ember.meta, // utils.js
+ typeOf = Ember.typeOf, // utils.js
ChainNode = Ember._ChainNode; // chains.js
// get the chains for the... | true |
Other | emberjs | ember.js | 93ccb694a2668fbcc0e82e5cc398cc7975612763.json | Move Ember.typeOf to metal
*sigh* it's been a long day... | packages/ember-metal/lib/watching.js | @@ -18,7 +18,7 @@ var metaFor = Ember.meta, // utils.js
unwatchKey = Ember.unwatchKey,
watchPath = Ember.watchPath, // watch_path.js
unwatchPath = Ember.unwatchPath,
- typeOf = Ember.typeOf, // FIXME: defined in runtime
+ typeOf = Ember.typeOf, // utils.js
generateGuid = Ember.generateGuid,
... | true |
Other | emberjs | ember.js | 93ccb694a2668fbcc0e82e5cc398cc7975612763.json | Move Ember.typeOf to metal
*sigh* it's been a long day... | packages/ember-runtime/lib/core.js | @@ -9,79 +9,6 @@ require('ember-metal');
var indexOf = Ember.EnumerableUtils.indexOf;
-// ........................................
-// TYPING & ARRAY MESSAGING
-//
-
-var TYPE_MAP = {};
-var t = "Boolean Number String Function Array Date RegExp Object".split(" ");
-Ember.ArrayPolyfills.forEach.call(t, function(nam... | true |
Other | emberjs | ember.js | da77c583999a93abb3f53eef07d0a90fd51d6113.json | Use a string instead of an array in RenderBuffer | packages/ember-views/lib/system/render_buffer.js | @@ -38,7 +38,7 @@ Ember.RenderBuffer = function(tagName) {
Ember._RenderBuffer = function(tagName) {
this.tagNames = [tagName || null];
- this.buffer = [];
+ this.buffer = "";
};
Ember._RenderBuffer.prototype =
@@ -164,7 +164,7 @@ Ember._RenderBuffer.prototype =
@chainable
*/
push: function(strin... | false |
Other | emberjs | ember.js | 0fa2b3032398a168c7f0569d9b3c949a78e42155.json | Convert a for in loop to a plain for loop | packages/ember-metal/lib/mixin.js | @@ -165,7 +165,7 @@ function addNormalizedProperty(base, key, value, meta, descs, values, concats) {
}
}
-function mergeMixins(mixins, m, descs, values, base) {
+function mergeMixins(mixins, m, descs, values, base, keys) {
var mixin, props, key, concats, meta;
function removeKeys(keyName) {
@@ -186,13 +18... | false |
Other | emberjs | ember.js | b23292fff540ca74967139c81530b6f18fc7030b.json | remove unneeded asynchrony from routing tests | packages/ember/tests/routing/basic_test.js | @@ -456,8 +456,6 @@ test("The Specials Page defaults to looking models up via `find`", function() {
});
test("The Special Page returning a promise puts the app into a loading state until the promise is resolved", function() {
- stop();
-
Router.map(function() {
this.route("home", { path: "/" });
this.... | false |
Other | emberjs | ember.js | c48b843265c849e0add3085ea57b97741c60ad64.json | Add {{input action="foo" on="keyPress"}} | packages/ember-handlebars/lib/controls.js | @@ -18,15 +18,20 @@ Ember.Handlebars.registerHelper('input', function(options) {
var hash = options.hash,
types = options.hashTypes,
- inputType = hash.type;
+ inputType = hash.type,
+ onEvent = hash.on;
delete hash.type;
+ delete hash.on;
+
+ hash.onEvent = onEvent;
normalizeHash... | true |
Other | emberjs | ember.js | c48b843265c849e0add3085ea57b97741c60ad64.json | Add {{input action="foo" on="keyPress"}} | packages/ember-handlebars/lib/controls/text_field.js | @@ -105,6 +105,20 @@ Ember.TextField = Ember.View.extend(Ember.TextSupport,
*/
action: null,
+ /**
+ The event that should send the action.
+
+ Options are:
+
+ * `enter`: the user pressed enter
+ * `keypress`: the user pressed a key
+
+ @property on
+ @type String
+ @default enter
+ */
+... | true |
Other | emberjs | ember.js | c48b843265c849e0add3085ea57b97741c60ad64.json | Add {{input action="foo" on="keyPress"}} | packages/ember-handlebars/tests/controls/text_field_test.js | @@ -377,6 +377,33 @@ test("should send an action if one is defined when the return key is pressed", f
textField.trigger('keyUp', event);
});
+test("should send an action on keyPress if one is defined with onEvent=keyPress", function() {
+ expect(3);
+
+ var StubController = Ember.Object.extend({
+ send: func... | true |
Other | emberjs | ember.js | 434cb04c5612bf8b1fa1fda075e6a25acab1f130.json | remove sync from render to buffer | packages/ember-views/lib/views/view.js | @@ -121,8 +121,6 @@ Ember.CoreView = Ember.Object.extend(Ember.Evented, {
},
_renderToBuffer: function(parentBuffer, bufferOperation) {
- Ember.run.sync();
-
// If this is the top-most view, start a new buffer. Otherwise,
// create a new buffer relative to the original using the
// provided bu... | false |
Other | emberjs | ember.js | 1912279ca03767ac7def4ce2dc1428fcc888ff94.json | Define Mixin properties in prototype | packages/ember-metal/lib/mixin.js | @@ -372,6 +372,12 @@ Ember.Mixin = function() { return initMixin(this, arguments); };
Mixin = Ember.Mixin;
+Mixin.prototype = {
+ properties: null,
+ mixins: null,
+ ownerConstructor: null
+};
+
Mixin._apply = applyMixin;
Mixin.applyPartial = function(obj) { | false |
Other | emberjs | ember.js | 711740794ec5cebd20f3783f723ba5ce4d30570a.json | Define Ember.CoreObject#willDestroy. Fixes #1438. | packages/ember-runtime/lib/system/core_object.js | @@ -305,6 +305,8 @@ CoreObject.PrototypeMixin = Mixin.create({
return this;
},
+ willDestroy: Ember.K,
+
/**
@private
| false |
Other | emberjs | ember.js | 6217aff4445e16885e5e05debc19e8bd298a82b2.json | remove duplicate test | packages/ember-metal/tests/performance_test.js | @@ -7,25 +7,6 @@
module("Computed Properties - Number of times evaluated");
-test("computed properties that depend on multiple properties should run only once per run loop", function() {
- var obj = {a: 'a', b: 'b', c: 'c'};
- var count = 0;
- Ember.defineProperty(obj, 'abc', Ember.computed(function(key) {
- ... | false |
Other | emberjs | ember.js | 8e8a7b950198c1407ab8f78bb34671eb8ed6dd2c.json | Match the transitionTo APIs.
When we know we have the full hierarchy, pass false. | packages/ember-views/lib/views/states/in_buffer.js | @@ -47,7 +47,7 @@ Ember.merge(inBuffer, {
destroyElement: function(view) {
view.clearBuffer();
var viewCollection = view._notifyWillDestroyElement();
- viewCollection.transitionTo('preRender');
+ viewCollection.transitionTo('preRender', false);
return view;
}, | true |
Other | emberjs | ember.js | 8e8a7b950198c1407ab8f78bb34671eb8ed6dd2c.json | Match the transitionTo APIs.
When we know we have the full hierarchy, pass false. | packages/ember-views/lib/views/states/pre_render.js | @@ -17,7 +17,7 @@ Ember.merge(preRender, {
viewCollection.trigger('willInsertElement');
// after createElement, the view will be in the hasElement state.
fn.call(view);
- viewCollection.transitionTo('inDOM');
+ viewCollection.transitionTo('inDOM', false);
viewCollection.trigger('didInsertEleme... | true |
Other | emberjs | ember.js | 8e8a7b950198c1407ab8f78bb34671eb8ed6dd2c.json | Match the transitionTo APIs.
When we know we have the full hierarchy, pass false. | packages/ember-views/lib/views/view.js | @@ -228,10 +228,10 @@ ViewCollection.prototype = {
}
},
- transitionTo: function(state) {
+ transitionTo: function(state, children) {
var views = this.views;
for (var i = 0, l = views.length; i < l; i++) {
- views[i].transitionTo(state, false);
+ views[i].transitionTo(state, children);
... | true |
Other | emberjs | ember.js | 280db3c69eafdafb69b67fe05751629e8dd2ae4a.json | Extract a private ViewCollection class to aid in
manipulating several views at once. | packages/ember-views/lib/views/container_view.js | @@ -11,6 +11,7 @@ var states = Ember.View.cloneStates(Ember.View.states);
var get = Ember.get, set = Ember.set;
var forEach = Ember.EnumerableUtils.forEach;
+var ViewCollection = Ember._ViewCollection;
/**
A `ContainerView` is an `Ember.View` subclass that implements `Ember.MutableArray`
@@ -373,27 +374,21 @@... | true |
Other | emberjs | ember.js | 280db3c69eafdafb69b67fe05751629e8dd2ae4a.json | Extract a private ViewCollection class to aid in
manipulating several views at once. | packages/ember-views/lib/views/view.js | @@ -205,6 +205,43 @@ Ember.CoreView = Ember.Object.extend(Ember.Evented, {
destroyElement: Ember.K
});
+var ViewCollection = Ember._ViewCollection = function(views) {
+ this.views = views || [];
+};
+
+ViewCollection.prototype = {
+ length: 0,
+
+ triggerRecursively: function(eventName) {
+ var views = this... | true |
Other | emberjs | ember.js | cb648d37cce2efeda180e08b374a0d2eaadd226c.json | Add support for {{input type="checkbox"}} | packages/ember-handlebars/lib/controls.js | @@ -24,5 +24,9 @@ Ember.Handlebars.registerHelper('input', function(options) {
normalizeHash(hash, types);
- return Ember.Handlebars.helpers.view.call(this, Ember.TextField, options);
+ if (inputType === 'checkbox') {
+ return Ember.Handlebars.helpers.view.call(this, Ember.Checkbox, options);
+ } else {
+ ... | true |
Other | emberjs | ember.js | cb648d37cce2efeda180e08b374a0d2eaadd226c.json | Add support for {{input type="checkbox"}} | packages/ember-handlebars/tests/controls/checkbox_test.js | @@ -1,12 +1,111 @@
-var get = Ember.get, set = Ember.set,
- isInternetExplorer = window.navigator.userAgent.match(/msie/i),
- checkboxView, dispatcher;
+var get = Ember.get, set = function(obj, key, value) {
+ Ember.run(function() { Ember.set(obj, key, value); });
+};
+
+var isInternetExplorer = window.navigator... | true |
Other | emberjs | ember.js | 7e012d9e7f4c5e5b7ce6e60307aac7cd653df5b9.json | Fix Ember.TextField typo in CHANGELOG | CHANGELOG | @@ -11,7 +11,7 @@
* Support browsers (FF 10 or less) that don't support domElement.outerHTML
* Made it easier to augment the Application's container's resolver
* Support tag as an alias for tagName in the {{view}} helper
-* Add 'name' to attributeBinding for Ember.textField and Ember.Select
+* Add 'name' to attribut... | false |
Other | emberjs | ember.js | d4318b7e1090301fa75cbfc05378afd8c33e3091.json | Fix deprecation warnings in tests | packages/ember-routing/tests/helpers/render_test.js | @@ -176,7 +176,7 @@ test("{{render}} helper should render templates with models multiple times", fun
});
var PostController = Ember.ObjectController.extend();
- container.register('controller', 'post', PostController, {singleton: false});
+ container.register('controller:post', PostController, {singleton: fal... | false |
Other | emberjs | ember.js | 3f87bb809dedba617489e85482615ba79cdcc3c2.json | remove self.isIinitialized check
We where actually initializing multiple times in our tests
and this check was hiding that.
isDestroy check can remain. | packages/ember-application/lib/system/application.js | @@ -305,14 +305,17 @@ var Application = Ember.Application = Ember.Namespace.extend({
@method scheduleInitialize
*/
scheduleInitialize: function() {
+ var self = this;
+
+ function initialize(){
+ if (self.isDestroyed) { return; }
+ Ember.run.schedule('actions', self, 'initialize');
+ }
+
... | true |
Other | emberjs | ember.js | 3f87bb809dedba617489e85482615ba79cdcc3c2.json | remove self.isIinitialized check
We where actually initializing multiple times in our tests
and this check was hiding that.
isDestroy check can remain. | packages/ember-application/tests/system/readiness_test.js | @@ -106,12 +106,7 @@ test("Ember.Application's ready event is called after the document becomes ready
test("Ember.Application's ready event can be deferred by other components", function() {
Ember.run(function() {
application = Application.create({ router: false });
- });
-
- application.deferReadiness();
-
... | true |
Other | emberjs | ember.js | 908981282ed8a3ad9ea388b51dd60cada92cdd47.json | Add note about view rerender to didInsertElement | packages/ember-views/lib/views/view.js | @@ -1556,9 +1556,9 @@ Ember.View = Ember.CoreView.extend(
willInsertElement: Ember.K,
/**
- Called when the element of the view has been inserted into the DOM.
- Override this function to do any set up that requires an element in the
- document body.
+ Called when the element of the view has been in... | false |
Other | emberjs | ember.js | 59342302433fa7e73652bdfaae8b999e56643bbe.json | Add support for jQuery 2.0 | ember-dev.yml | @@ -18,8 +18,10 @@ testing_suites:
- "package=all&jquery=1.7.2&nojshint=true"
- "package=all&jquery=1.8.3&nojshint=true"
- "package=all&jquery=git&nojshint=true"
+ - "package=all&jquery=git2&nojshint=true"
- "package=all&extendprototypes=true&nojshint=true"
- "package=all&extendprototypes=tr... | true |
Other | emberjs | ember.js | 59342302433fa7e73652bdfaae8b999e56643bbe.json | Add support for jQuery 2.0 | packages/ember-views/lib/core.js | @@ -4,7 +4,7 @@
*/
var jQuery = Ember.imports.jQuery;
-Ember.assert("Ember Views require jQuery 1.8 or 1.9", jQuery && (jQuery().jquery.match(/^1\.(8|9)(\.\d+)?(pre|rc\d?)?/) || Ember.ENV.FORCE_JQUERY));
+Ember.assert("Ember Views require jQuery 1.8, 1.9 or 2.0", jQuery && (jQuery().jquery.match(/^((1\.(8|9))|2.0)(... | true |
Other | emberjs | ember.js | a310f8ccc287026017b491d6101d68587cf9af82.json | Fix deprecation warnings 3d3327c brought to light. | packages/container/tests/sub_container_test.js | @@ -16,7 +16,7 @@ module("Container (sub-containers)", {
container = new Container();
var PostController = factory();
- container.register('controller', 'post', PostController);
+ container.register('controller:post', PostController);
},
teardown: function() { | true |
Other | emberjs | ember.js | a310f8ccc287026017b491d6101d68587cf9af82.json | Fix deprecation warnings 3d3327c brought to light. | packages/ember-application/lib/system/application.js | @@ -110,7 +110,7 @@ var get = Ember.get, set = Ember.set,
name: "store",
initialize: function(container, application) {
- container.register('store', 'main', application.Store);
+ container.register('store:main', application.Store);
}
});
```
@@ -417,7 +417,7 @@ var Application = Ember.... | true |
Other | emberjs | ember.js | a310f8ccc287026017b491d6101d68587cf9af82.json | Fix deprecation warnings 3d3327c brought to light. | packages/ember-application/tests/system/application_test.js | @@ -109,7 +109,7 @@ test('initialized application go to initial route', function() {
location: 'none'
});
- app.register('template', 'application',
+ app.register('template:application',
Ember.Handlebars.compile("{{outlet}}")
);
@@ -157,7 +157,7 @@ test("initialize application with sta... | true |
Other | emberjs | ember.js | a310f8ccc287026017b491d6101d68587cf9af82.json | Fix deprecation warnings 3d3327c brought to light. | packages/ember-application/tests/system/controller_test.js | @@ -3,11 +3,11 @@ module("Controller dependencies");
test("If a controller specifies a dependency, it is accessible", function() {
var container = new Ember.Container();
- container.register('controller', 'post', Ember.Controller.extend({
+ container.register('controller:post', Ember.Controller.extend({
ne... | true |
Other | emberjs | ember.js | a310f8ccc287026017b491d6101d68587cf9af82.json | Fix deprecation warnings 3d3327c brought to light. | packages/ember-handlebars/tests/handlebars_test.js | @@ -94,7 +94,7 @@ module("Ember.View - handlebars integration", {
});
test("template view should call the function of the associated template", function() {
- container.register('template', 'testTemplate', Ember.Handlebars.compile("<h1 id='twas-called'>template was called</h1>"));
+ container.register('template:t... | true |
Other | emberjs | ember.js | a310f8ccc287026017b491d6101d68587cf9af82.json | Fix deprecation warnings 3d3327c brought to light. | packages/ember-handlebars/tests/helpers/each_test.js | @@ -213,7 +213,7 @@ test("it supports itemController", function() {
controller: parentController
});
- container.register('controller', 'person', Controller);
+ container.register('controller:person', Controller);
append(view);
@@ -259,7 +259,7 @@ test("it supports itemController when using a custom ... | true |
Other | emberjs | ember.js | a310f8ccc287026017b491d6101d68587cf9af82.json | Fix deprecation warnings 3d3327c brought to light. | packages/ember-handlebars/tests/helpers/yield_test.js | @@ -39,8 +39,8 @@ test("a view with a layout set renders its template where the {{yield}} helper a
});
test("block should work properly even when templates are not hard-coded", function() {
- container.register('template', 'nester', Ember.Handlebars.compile('<div class="wrapper"><h1>{{title}}</h1>{{yield}}</div>')... | true |
Other | emberjs | ember.js | a310f8ccc287026017b491d6101d68587cf9af82.json | Fix deprecation warnings 3d3327c brought to light. | packages/ember-routing/lib/system/controller_for.js | @@ -14,7 +14,7 @@ Ember.controllerFor = function(container, controllerName, context, lookupOptions
`App.ObjectController` and `App.ArrayController`
*/
Ember.generateController = function(container, controllerName, context) {
- var controller, DefaultController;
+ var controller, DefaultController, fullName;
... | true |
Other | emberjs | ember.js | a310f8ccc287026017b491d6101d68587cf9af82.json | Fix deprecation warnings 3d3327c brought to light. | packages/ember-routing/lib/system/router.js | @@ -56,8 +56,8 @@ Ember.Router = Ember.Object.extend({
setupRouter(this, router, location);
- container.register('view', 'default', DefaultView);
- container.register('view', 'toplevel', Ember.View.extend());
+ container.register('view:default', DefaultView);
+ container.register('view:toplevel', E... | true |
Other | emberjs | ember.js | a310f8ccc287026017b491d6101d68587cf9af82.json | Fix deprecation warnings 3d3327c brought to light. | packages/ember-routing/tests/helpers/render_test.js | @@ -17,7 +17,7 @@ var buildContainer = function(namespace) {
container.resolver = resolverFor(namespace);
container.optionsForType('view', { singleton: false });
container.optionsForType('template', { instantiate: false });
- container.register('application', 'main', namespace, { instantiate: false });
+ con... | true |
Other | emberjs | ember.js | a310f8ccc287026017b491d6101d68587cf9af82.json | Fix deprecation warnings 3d3327c brought to light. | packages/ember-routing/tests/system/controller_for_test.js | @@ -5,7 +5,7 @@ var buildContainer = function(namespace) {
container.resolver = resolverFor(namespace);
container.optionsForType('view', { singleton: false });
- container.register('application', 'main', namespace, { instantiate: false });
+ container.register('application:main', namespace, { instantiate: fal... | true |
Other | emberjs | ember.js | a310f8ccc287026017b491d6101d68587cf9af82.json | Fix deprecation warnings 3d3327c brought to light. | packages/ember-runtime/tests/controllers/item_controller_class_test.js | @@ -30,8 +30,8 @@ module("Ember.ArrayController - itemController", {
}
});
- container.register("controller", "Item", controllerClass);
- container.register("controller", "OtherItem", otherControllerClass);
+ container.register("controller:Item", controllerClass);
+ container.register("control... | true |
Other | emberjs | ember.js | a310f8ccc287026017b491d6101d68587cf9af82.json | Fix deprecation warnings 3d3327c brought to light. | packages/ember-views/tests/views/view/layout_test.js | @@ -15,8 +15,8 @@ module("Ember.View - Layout Functionality", {
test("should call the function of the associated layout", function() {
var templateCalled = 0, layoutCalled = 0;
- container.register('template', 'template', function() { templateCalled++; });
- container.register('template', 'layout', function() {... | true |
Other | emberjs | ember.js | a310f8ccc287026017b491d6101d68587cf9af82.json | Fix deprecation warnings 3d3327c brought to light. | packages/ember-views/tests/views/view/template_test.js | @@ -13,7 +13,7 @@ module("Ember.View - Template Functionality", {
});
test("should call the function of the associated template", function() {
- container.register('template', 'testTemplate', function() {
+ container.register('template:testTemplate', function() {
return "<h1 id='twas-called'>template was cal... | true |
Other | emberjs | ember.js | a310f8ccc287026017b491d6101d68587cf9af82.json | Fix deprecation warnings 3d3327c brought to light. | packages/ember/tests/helpers/link_to_test.js | @@ -42,8 +42,8 @@ module("The {{linkTo}} helper", {
container = App.__container__;
- container.register('view', 'app');
- container.register('router', 'main', Router);
+ container.register('view:app');
+ container.register('router:main', Router);
});
},
| true |
Other | emberjs | ember.js | a310f8ccc287026017b491d6101d68587cf9af82.json | Fix deprecation warnings 3d3327c brought to light. | packages/ember/tests/routing/basic_test.js | @@ -265,7 +265,7 @@ test("The Homepage with a `setupController` hook", function() {
bootApplication();
- container.register('controller', 'home', Ember.Controller.extend());
+ container.register('controller:home', Ember.Controller.extend());
Ember.run(function() {
router.handleURL("/");
@@ -286,7 +28... | true |
Other | emberjs | ember.js | 9d33dfe86293c82db51aa280cc042f8393e6986f.json | Remove unused variable | packages/ember-handlebars/lib/ext.js | @@ -326,7 +326,6 @@ Ember.Handlebars.registerBoundHelper = function(name, fn) {
*/
function evaluateMultiPropertyBoundHelper(context, fn, normalizedProperties, options) {
var numProperties = normalizedProperties.length,
- self = this,
data = options.data,
view = data.view,
hash = options.... | true |
Other | emberjs | ember.js | 9d33dfe86293c82db51aa280cc042f8393e6986f.json | Remove unused variable | packages/ember-handlebars/lib/helpers/view.js | @@ -9,7 +9,6 @@ require("ember-handlebars");
*/
var get = Ember.get, set = Ember.set;
-var PARENT_VIEW_PATH = /^parentView\./;
var EmberHandlebars = Ember.Handlebars;
EmberHandlebars.ViewHelper = Ember.Object.create({ | true |
Other | emberjs | ember.js | 3fec7df524c79dc13b36485f23acf62ef1ff07b1.json | Fix document indent | packages/ember-handlebars/lib/controls/text_field.js | @@ -99,9 +99,9 @@ Ember.TextField = Ember.View.extend(Ember.TextSupport,
the user presses the return key when editing a text field, and sends
the value of the field as the context.
- @property action
- @type String
- @default null
+ @property action
+ @type String
+ @default null
*/
act... | false |
Other | emberjs | ember.js | 4fdee7b4e81c8c3ce3d0c986f037b92705265c94.json | Return merged object from Ember.merge | packages/ember-metal/lib/core.js | @@ -227,6 +227,7 @@ Ember.merge = function(original, updates) {
if (!updates.hasOwnProperty(prop)) { continue; }
original[prop] = updates[prop];
}
+ return original;
};
/** | false |
Other | emberjs | ember.js | 99a1c6e95d47f106de896522689ec99e65fc27c4.json | Remove special case readOnly for computed.alias.
Prefer the computed property wide readOnly method. | packages/ember-metal/lib/computed.js | @@ -488,22 +488,13 @@ Ember.computed.bool = function(dependentKey) {
@method computed.alias
@for Ember
- Available options:
-
- * `readOnly`: `true`
-
@param {String} dependentKey
- @param {Object} options
*/
-Ember.computed.alias = function(dependentKey, options) {
+Ember.computed.alias = function(depen... | true |
Other | emberjs | ember.js | 99a1c6e95d47f106de896522689ec99e65fc27c4.json | Remove special case readOnly for computed.alias.
Prefer the computed property wide readOnly method. | packages/ember-metal/tests/computed_test.js | @@ -769,40 +769,3 @@ testBoth('Ember.computed.alias', function(get, set) {
equal(get(obj, 'baz'), 'newBaz');
equal(get(obj, 'quz'), null);
});
-
-testBoth('Ember.computed.alias readOnly: true', function(get, set) {
- var obj = { bar: 'asdf', baz: null, quz: false};
- Ember.defineProperty(obj, 'bay', Ember.comp... | true |
Other | emberjs | ember.js | da51cfdcce465dfd3224ca4c471bb9cb96026664.json | Fix typo and remove unused variables | packages/ember-application/lib/system/application.js | @@ -450,7 +450,7 @@ var Application = Ember.Application = Ember.Namespace.extend({
container = this.__container__,
graph = new Ember.DAG(),
namespace = this,
- properties, i, initializer;
+ i, initializer;
for (i=0; i<initializers.length; i++) {
initializer = initi... | true |
Other | emberjs | ember.js | da51cfdcce465dfd3224ca4c471bb9cb96026664.json | Fix typo and remove unused variables | packages/ember-routing/lib/helpers/action.js | @@ -64,9 +64,7 @@ Ember.onLoad('Ember.Handlebars', function(Handlebars) {
event.stopPropagation();
}
- var view = options.view,
- contexts = options.contexts,
- target = options.target;
+ var target = options.target;
if (target.target) {
ta... | true |
Other | emberjs | ember.js | da51cfdcce465dfd3224ca4c471bb9cb96026664.json | Fix typo and remove unused variables | packages/ember-runtime/lib/controllers/array_controller.js | @@ -7,8 +7,8 @@ require('ember-runtime/mixins/sortable');
@submodule ember-runtime
*/
-var get = Ember.get, set = Ember.set, isGlobalPath = Ember.isGlobalPath,
- forEach = Ember.EnumerableUtils.forEach, replace = Ember.EnumerableUtils.replace;
+var get = Ember.get, set = Ember.set, forEach = Ember.EnumerableUtil... | true |
Other | emberjs | ember.js | da51cfdcce465dfd3224ca4c471bb9cb96026664.json | Fix typo and remove unused variables | packages/ember-runtime/lib/mixins/deferred.js | @@ -9,8 +9,7 @@ RSVP.async = function(callback, binding) {
@submodule ember-runtime
*/
-var get = Ember.get,
- slice = Array.prototype.slice;
+var get = Ember.get;
/**
@class Deferred | true |
Other | emberjs | ember.js | da51cfdcce465dfd3224ca4c471bb9cb96026664.json | Fix typo and remove unused variables | packages/ember-runtime/lib/mixins/enumerable.js | @@ -828,7 +828,7 @@ Ember.Enumerable = Ember.Mixin.create({
@chainable
*/
enumerableContentDidChange: function(removing, adding) {
- var notify = this.propertyDidChange, removeCnt, addCnt, hasDelta;
+ var removeCnt, addCnt, hasDelta;
if ('number' === typeof removing) removeCnt = removing;
e... | true |
Other | emberjs | ember.js | da51cfdcce465dfd3224ca4c471bb9cb96026664.json | Fix typo and remove unused variables | packages/ember-runtime/lib/mixins/mutable_array.js | @@ -18,7 +18,7 @@ var EMPTY = [];
// HELPERS
//
-var get = Ember.get, set = Ember.set, forEach = Ember.EnumerableUtils.forEach;
+var get = Ember.get, set = Ember.set;
/**
This mixin defines the API for modifying array-like objects. These methods | true |
Other | emberjs | ember.js | da51cfdcce465dfd3224ca4c471bb9cb96026664.json | Fix typo and remove unused variables | packages/ember-runtime/lib/mixins/sortable.js | @@ -161,7 +161,6 @@ Ember.SortableMixin = Ember.Mixin.create(Ember.MutableEnumerable, {
if (isSorted) {
var addedObjects = array.slice(idx, idx+addedCount);
- var arrangedContent = get(this, 'arrangedContent');
forEach(addedObjects, function(item) {
this.insertItemSorted(item); | true |
Other | emberjs | ember.js | da51cfdcce465dfd3224ca4c471bb9cb96026664.json | Fix typo and remove unused variables | packages/ember-runtime/lib/system/array_proxy.js | @@ -229,7 +229,6 @@ Ember.ArrayProxy = Ember.Object.extend(Ember.MutableArray,
},
_insertAt: function(idx, object) {
- var content = this.get('content');
if (idx > get(this, 'content.length')) throw new Error(OUT_OF_RANGE_EXCEPTION);
this._replace(idx, 0, [object]);
return this; | true |
Other | emberjs | ember.js | da51cfdcce465dfd3224ca4c471bb9cb96026664.json | Fix typo and remove unused variables | packages/ember-runtime/lib/system/core_object.js | @@ -13,7 +13,6 @@ require('ember-runtime/system/namespace');
var set = Ember.set, get = Ember.get,
o_create = Ember.create,
o_defineProperty = Ember.platform.defineProperty,
- a_slice = Array.prototype.slice,
GUID_KEY = Ember.GUID_KEY,
guidFor = Ember.guidFor,
generateGuid = Ember.generateG... | true |
Other | emberjs | ember.js | da51cfdcce465dfd3224ca4c471bb9cb96026664.json | Fix typo and remove unused variables | packages/ember-runtime/lib/system/each_proxy.js | @@ -43,7 +43,7 @@ function addObserverForContentKey(content, keyName, proxy, idx, loc) {
Ember.addBeforeObserver(item, keyName, proxy, 'contentKeyWillChange');
Ember.addObserver(item, keyName, proxy, 'contentKeyDidChange');
- // keep track of the indicies each item was found at so we can map
+ ... | true |
Other | emberjs | ember.js | da51cfdcce465dfd3224ca4c471bb9cb96026664.json | Fix typo and remove unused variables | packages/ember-states/lib/state.js | @@ -66,7 +66,7 @@ Ember.State = Ember.Object.extend(Ember.Evented,
},
init: function() {
- var states = get(this, 'states'), foundStates;
+ var states = get(this, 'states');
set(this, 'childStates', Ember.A());
set(this, 'eventTransitions', get(this, 'eventTransitions') || {});
@@ -216,7 +216,... | true |
Other | emberjs | ember.js | da51cfdcce465dfd3224ca4c471bb9cb96026664.json | Fix typo and remove unused variables | packages/ember-views/lib/system/controller.js | @@ -27,8 +27,7 @@ Ember.ControllerMixin.reopen({
},
_modelDidChange: Ember.observer(function() {
- var containers = get(this, '_childContainers'),
- container;
+ var containers = get(this, '_childContainers');
for (var prop in containers) {
if (!containers.hasOwnProperty(prop)) { cont... | true |
Other | emberjs | ember.js | da51cfdcce465dfd3224ca4c471bb9cb96026664.json | Fix typo and remove unused variables | packages/ember-views/lib/system/render_buffer.js | @@ -175,7 +175,7 @@ Ember._RenderBuffer.prototype =
*/
addClass: function(className) {
// lazily create elementClasses
- var elementClasses = this.elementClasses = (this.elementClasses || new ClassSet());
+ this.elementClasses = (this.elementClasses || new ClassSet());
this.elementClasses.add(clas... | true |
Other | emberjs | ember.js | da51cfdcce465dfd3224ca4c471bb9cb96026664.json | Fix typo and remove unused variables | packages/ember-views/lib/views/collection_view.js | @@ -290,7 +290,7 @@ Ember.CollectionView = Ember.ContainerView.extend(
*/
arrayDidChange: function(content, start, removed, added) {
var itemViewClass = get(this, 'itemViewClass'),
- addedViews = [], view, item, idx, len, itemTagName;
+ addedViews = [], view, item, idx, len;
if ('string'... | true |
Other | emberjs | ember.js | da51cfdcce465dfd3224ca4c471bb9cb96026664.json | Fix typo and remove unused variables | packages/ember-views/lib/views/states.js | @@ -14,8 +14,6 @@ Ember.View.cloneStates = function(from) {
into.hasElement = Ember.create(into._default);
into.inDOM = Ember.create(into.hasElement);
- var viewState;
-
for (var stateName in from) {
if (!from.hasOwnProperty(stateName)) { continue; }
Ember.merge(into[stateName], from[stateName]); | true |
Other | emberjs | ember.js | b22618f9135cf08825b78bdabd83d89110061ba7.json | allow tag for tagName in the view helper | packages/ember-handlebars/lib/helpers/view.js | @@ -25,6 +25,11 @@ EmberHandlebars.ViewHelper = Ember.Object.create({
dup = true;
}
+ if (hash.tag) {
+ extensions.tagName = hash.tag;
+ dup = true;
+ }
+
if (classes) {
classes = classes.split(' ');
extensions.classNames = classes;
@@ -51,6 +56,7 @@ EmberHandlebars.View... | true |
Other | emberjs | ember.js | b22618f9135cf08825b78bdabd83d89110061ba7.json | allow tag for tagName in the view helper | packages/ember-handlebars/tests/handlebars_test.js | @@ -1103,6 +1103,22 @@ test("{{view}} id attribute should set id on layer", function() {
equal(view.$('#bar').text(), 'baz', "emits content");
});
+test("{{view}} tag attribute should set tagName of the view", function() {
+ container.register('template', 'foo', Ember.Handlebars.compile('{{#view "TemplateTests.T... | true |
Other | emberjs | ember.js | b22afef0eb0358bf1ccac34db26bf28dfd69e70a.json | Fix deprecation warning in tests | packages/ember-handlebars/tests/helpers/each_test.js | @@ -286,24 +286,29 @@ test("it supports {{itemViewClass=}}", function() {
});
test("it supports {{itemViewClass=}} with tagName", function() {
- Ember.run(function() { view.destroy(); }); // destroy existing view
- view = Ember.View.create({
- template: templateFor('{{each view.people itemViewClass="MyView" ... | false |
Other | emberjs | ember.js | 8779648aa8d3a3f8c123e327593c8663b0d148f4.json | Remove unused variables | packages/ember-metal/lib/run_loop.js | @@ -212,8 +212,7 @@ Ember.RunLoop = RunLoop;
@return {Object} return value from invoking the passed function.
*/
Ember.run = function(target, method) {
- var loop,
- args = arguments;
+ var args = arguments;
run.begin();
function tryable() { | true |
Other | emberjs | ember.js | 8779648aa8d3a3f8c123e327593c8663b0d148f4.json | Remove unused variables | packages/ember-routing/lib/system/route.js | @@ -4,8 +4,7 @@
*/
var get = Ember.get, set = Ember.set,
- classify = Ember.String.classify,
- decamelize = Ember.String.decamelize;
+ classify = Ember.String.classify;
/**
The `Ember.Route` class is used to define individual routes. Refer to | true |
Other | emberjs | ember.js | 8779648aa8d3a3f8c123e327593c8663b0d148f4.json | Remove unused variables | packages/ember-routing/lib/system/router.js | @@ -4,7 +4,7 @@
*/
var Router = requireModule("router");
-var get = Ember.get, set = Ember.set, classify = Ember.String.classify;
+var get = Ember.get, set = Ember.set;
var DefaultView = Ember._MetamorphView;
| true |
Other | emberjs | ember.js | 8779648aa8d3a3f8c123e327593c8663b0d148f4.json | Remove unused variables | packages/ember-views/lib/system/render_buffer.js | @@ -4,11 +4,6 @@
*/
var get = Ember.get, set = Ember.set;
-var indexOf = Ember.ArrayPolyfills.indexOf;
-
-
-
-
var ClassSet = function() {
this.seen = {}; | true |
Other | emberjs | ember.js | 8779648aa8d3a3f8c123e327593c8663b0d148f4.json | Remove unused variables | packages/ember-views/lib/views/container_view.js | @@ -9,7 +9,7 @@ var states = Ember.View.cloneStates(Ember.View.states);
@submodule ember-views
*/
-var get = Ember.get, set = Ember.set, meta = Ember.meta;
+var get = Ember.get, set = Ember.set;
var forEach = Ember.EnumerableUtils.forEach;
/** | true |
Other | emberjs | ember.js | 8779648aa8d3a3f8c123e327593c8663b0d148f4.json | Remove unused variables | packages/ember-views/lib/views/states/in_buffer.js | @@ -5,7 +5,7 @@ require('ember-views/views/states/default');
@submodule ember-views
*/
-var get = Ember.get, set = Ember.set, meta = Ember.meta;
+var get = Ember.get, set = Ember.set;
var inBuffer = Ember.View.states.inBuffer = Ember.create(Ember.View.states._default);
| true |
Other | emberjs | ember.js | 8779648aa8d3a3f8c123e327593c8663b0d148f4.json | Remove unused variables | packages/ember-views/lib/views/states/in_dom.js | @@ -5,7 +5,7 @@ require('ember-views/views/states/default');
@submodule ember-views
*/
-var get = Ember.get, set = Ember.set, meta = Ember.meta;
+var get = Ember.get, set = Ember.set;
var hasElement = Ember.View.states.hasElement = Ember.create(Ember.View.states._default);
| true |
Other | emberjs | ember.js | 8779648aa8d3a3f8c123e327593c8663b0d148f4.json | Remove unused variables | packages/ember-views/lib/views/view.js | @@ -7,9 +7,8 @@ var states = {};
@submodule ember-views
*/
-var get = Ember.get, set = Ember.set, addObserver = Ember.addObserver, removeObserver = Ember.removeObserver;
-var meta = Ember.meta, guidFor = Ember.guidFor, fmt = Ember.String.fmt;
-var a_slice = [].slice;
+var get = Ember.get, set = Ember.set;
+var guid... | true |
Other | emberjs | ember.js | f092c6a8df521e08b94c65d8e4e5cf0af20e81b0.json | Remove old comment
Now it is wrong. | packages/ember-metal/lib/computed.js | @@ -50,7 +50,6 @@ function keysForDep(obj, depsMeta, depKey) {
return keys;
}
-/* return obj[META_KEY].deps */
function metaForDeps(obj, meta) {
return keysForDep(obj, meta, 'deps');
} | false |
Other | emberjs | ember.js | 8bad49801c34a0791a8beea3eccbaf0e4fe6d589.json | Remove unused argument | packages/ember-metal/lib/watching.js | @@ -559,7 +559,7 @@ Ember.finishChains = function(obj) {
@param {String} keyName The property key (or path) that will change.
@return {void}
*/
-function propertyWillChange(obj, keyName, value) {
+function propertyWillChange(obj, keyName) {
var m = metaFor(obj, false),
watching = m.watching[keyName] > ... | false |
Other | emberjs | ember.js | 2f143e0ff0e292261915cff52a4350ba1bb4a46f.json | Use defined function to remove duplicates | packages/ember-metal/lib/computed.js | @@ -52,18 +52,7 @@ function keysForDep(obj, depsMeta, depKey) {
/* return obj[META_KEY].deps */
function metaForDeps(obj, meta) {
- var deps = meta.deps;
- // If the current object has no dependencies...
- if (!deps) {
- // initialize the dependencies with a pointer back to
- // the current object
- dep... | false |
Other | emberjs | ember.js | 47cdef2b6b872a3ab894895e3f471824a18c84da.json | Remove unused variables | packages/ember-metal/lib/computed.js | @@ -14,7 +14,6 @@ Ember.warn("The CP_DEFAULT_CACHEABLE flag has been removed and computed properti
var get = Ember.get,
set = Ember.set,
metaFor = Ember.meta,
- guidFor = Ember.guidFor,
a_slice = [].slice,
o_create = Ember.create,
META_KEY = Ember.META_KEY, | true |
Other | emberjs | ember.js | 47cdef2b6b872a3ab894895e3f471824a18c84da.json | Remove unused variables | packages/ember-metal/lib/events.js | @@ -8,7 +8,6 @@ require('ember-metal/utils');
var o_create = Ember.create,
metaFor = Ember.meta,
- metaPath = Ember.metaPath,
META_KEY = Ember.META_KEY;
/* | true |
Other | emberjs | ember.js | 47cdef2b6b872a3ab894895e3f471824a18c84da.json | Remove unused variables | packages/ember-metal/lib/mixin.js | @@ -16,7 +16,6 @@ var Mixin, REQUIRED, Alias,
a_indexOf = Ember.ArrayPolyfills.indexOf,
a_forEach = Ember.ArrayPolyfills.forEach,
a_slice = [].slice,
- EMPTY_META = {}, // dummy for non-writable meta
o_create = Ember.create,
defineProperty = Ember.defineProperty,
guidFor = Ember.guidFor... | true |
Other | emberjs | ember.js | 47cdef2b6b872a3ab894895e3f471824a18c84da.json | Remove unused variables | packages/ember-metal/lib/properties.js | @@ -7,11 +7,8 @@ require('ember-metal/accessors');
@module ember-metal
*/
-var GUID_KEY = Ember.GUID_KEY,
- META_KEY = Ember.META_KEY,
- EMPTY_META = Ember.EMPTY_META,
+var META_KEY = Ember.META_KEY,
metaFor = Ember.meta,
- o_create = Ember.create,
objectDefineProperty = Ember.platform.defineProp... | true |
Other | emberjs | ember.js | 47cdef2b6b872a3ab894895e3f471824a18c84da.json | Remove unused variables | packages/ember-metal/lib/watching.js | @@ -19,7 +19,6 @@ var guidFor = Ember.guidFor, // utils.js
META_KEY = Ember.META_KEY, // utils.js
// circular reference observer depends on Ember.watch
// we should move change events to this file or its own property_events.js
- notifyObservers = Ember.notifyObservers, // observer.js
forEach = Em... | true |
Other | emberjs | ember.js | 7ba9475a3a364a4083928ca4ac29859c73130cf5.json | Remove trailing whitespace | packages/ember-handlebars/lib/ext.js | @@ -184,7 +184,7 @@ Ember.Handlebars.registerHelper('helperMissing', function(path, options) {
## Example with bound options
- Bound hash options are also supported. Example:
+ Bound hash options are also supported. Example:
```handlebars
{{repeat text countBinding="numRepeats"}}
@@ -222,15 +222,15 @@... | true |
Other | emberjs | ember.js | 7ba9475a3a364a4083928ca4ac29859c73130cf5.json | Remove trailing whitespace | packages/ember-handlebars/lib/helpers/binding.js | @@ -375,14 +375,14 @@ EmberHandlebars.registerHelper('unless', function(context, options) {
Result in the following rendered output:
- ```html
+ ```html
<img class="aValue">
```
A boolean return value will insert a specified class name if the property
returns `true` and remove the class name if ... | true |
Other | emberjs | ember.js | 7ba9475a3a364a4083928ca4ac29859c73130cf5.json | Remove trailing whitespace | packages/ember-handlebars/lib/helpers/unbound.js | @@ -36,7 +36,7 @@ Ember.Handlebars.registerHelper('unbound', function(property, fn) {
// Unbound helper call.
options.data.isUnbound = true;
helper = Ember.Handlebars.helpers[arguments[0]] || Ember.Handlebars.helperMissing;
- out = helper.apply(this, Array.prototype.slice.call(arguments, 1));
+ ou... | true |
Other | emberjs | ember.js | 7ba9475a3a364a4083928ca4ac29859c73130cf5.json | Remove trailing whitespace | packages/ember-handlebars/tests/helpers/bound_helper_test.js | @@ -37,28 +37,28 @@ test("should update bound helpers when properties change", function() {
Ember.Handlebars.registerBoundHelper('capitalize', function(value) {
return value.toUpperCase();
});
-
+
view = Ember.View.create({
controller: Ember.Object.create({name: "Brogrammer"}),
template: Ember... | true |
Other | emberjs | ember.js | 7ba9475a3a364a4083928ca4ac29859c73130cf5.json | Remove trailing whitespace | packages/ember-metal/lib/accessors.js | @@ -29,7 +29,7 @@ var FIRST_KEY = /^([^\.\*]+)/;
If you plan to run on IE8 and older browsers then you should use this
method anytime you want to retrieve a property on an object that you don't
- know for sure is private. (Properties beginning with an underscore '_'
+ know for sure is private. (Properties be... | true |
Other | emberjs | ember.js | 7ba9475a3a364a4083928ca4ac29859c73130cf5.json | Remove trailing whitespace | packages/ember-metal/lib/map.js | @@ -323,7 +323,7 @@ var MapWithDefault = Ember.MapWithDefault = function(options) {
@static
@param [options]
@param {anything} [options.defaultValue]
- @return {Ember.MapWithDefault|Ember.Map} If options are passed, returns
+ @return {Ember.MapWithDefault|Ember.Map} If options are passed, returns
`Em... | true |
Other | emberjs | ember.js | 7ba9475a3a364a4083928ca4ac29859c73130cf5.json | Remove trailing whitespace | packages/ember-metal/lib/mixin.js | @@ -387,7 +387,7 @@ Ember.anyUnprocessedMixins = false;
/**
Creates an instance of a class. Accepts either no arguments, or an object
containing values to initialize the newly instantiated object with.
-
+
```javascript
App.Person = Ember.Object.extend({
helloWorld: function() { | true |
Other | emberjs | ember.js | 7ba9475a3a364a4083928ca4ac29859c73130cf5.json | Remove trailing whitespace | packages/ember-metal/lib/run_loop.js | @@ -196,7 +196,7 @@ Ember.RunLoop = RunLoop;
```javascript
Ember.run(function(){
- // code to be execute within a RunLoop
+ // code to be execute within a RunLoop
});
```
@@ -235,7 +235,7 @@ var run = Ember.run;
```javascript
Ember.run.begin();
- // code to be execute within a RunLoop
+... | true |
Other | emberjs | ember.js | 7ba9475a3a364a4083928ca4ac29859c73130cf5.json | Remove trailing whitespace | packages/ember-metal/tests/run_loop/later_test.js | @@ -60,19 +60,19 @@ asyncTest('should always invoke within a separate runloop', function() {
var obj = { invoked: 0 }, firstRunLoop, secondRunLoop;
Ember.run(function() {
- firstRunLoop = Ember.run.currentRunLoop;
+ firstRunLoop = Ember.run.currentRunLoop;
- Ember.run.later(obj, function(amt) {
- ... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.