language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | a1aded50cdaa46fdd46df010320e1a5ee0457f83.json | Fix inconsistent version number | CHANGELOG | @@ -1,4 +1,5 @@
-*Ember 1.0.0-rc4 (May 27, 2013)*
+*Ember 1.0.0-rc.4 (May 27, 2013)*
+
* Loader: improve missing module error message
* Fix click test helper selector context
* fixes #2737: 'In the Router, if ApplicationController is an ObjectController, currentPath is proxied to the content.' | true |
Other | emberjs | ember.js | a1aded50cdaa46fdd46df010320e1a5ee0457f83.json | Fix inconsistent version number | VERSION | @@ -1 +1 @@
-1.0.0-rc4
+1.0.0-rc.4 | true |
Other | emberjs | ember.js | a1aded50cdaa46fdd46df010320e1a5ee0457f83.json | Fix inconsistent version number | ember.json | @@ -2,7 +2,7 @@
"name": "ember",
"bpm": "1.0.0",
"dependencies": {
- "ember": "1.0.0-rc4"
+ "ember": "1.0.0-rc.4"
},
"dependencies:development": {
"spade-qunit": "~> 1.0.0" | true |
Other | emberjs | ember.js | a1aded50cdaa46fdd46df010320e1a5ee0457f83.json | Fix inconsistent version number | packages/ember-application/package.json | @@ -4,11 +4,11 @@
"description": "Namespacing, event delegation, and structure for applications.",
"homepage": "http://emberjs.com",
"author": "Yehuda Katz",
- "version": "1.0.0-rc4",
+ "version": "1.0.0-rc.4",
"dependencies": {
- "ember-views": "1.0.0-rc4",
- "ember-states": "1.0.0-rc4",
- "embe... | true |
Other | emberjs | ember.js | a1aded50cdaa46fdd46df010320e1a5ee0457f83.json | Fix inconsistent version number | packages/ember-debug/package.json | @@ -4,7 +4,7 @@
"description": "Debugging helpers for Ember",
"homepage": "http://www.emberjs.com",
"author": "Peter Wagenet",
- "version": "1.0.0-rc4",
+ "version": "1.0.0-rc.4",
"directories": {
"lib": "lib" | true |
Other | emberjs | ember.js | a1aded50cdaa46fdd46df010320e1a5ee0457f83.json | Fix inconsistent version number | packages/ember-handlebars-compiler/package.json | @@ -4,7 +4,7 @@
"description": "A programmatic compiler for Handlebars with the few syntax extensions supported by Ember with minimal dependencies",
"homepage": "http://emberjs.com",
"author": "Yehuda Katz",
- "version": "1.0.0-rc4",
+ "version": "1.0.0-rc.4",
"dependencies": {
"spade": ... | true |
Other | emberjs | ember.js | a1aded50cdaa46fdd46df010320e1a5ee0457f83.json | Fix inconsistent version number | packages/ember-handlebars/package.json | @@ -4,11 +4,11 @@
"description": "Extensions to the Handlebars templating engine for use with Ember. These extensions make Handlebars aware of property observing, which allows it to automatically update the DOM when the referenced properties change. It also provides Handlebars helpers for creating Ember views and wo... | true |
Other | emberjs | ember.js | a1aded50cdaa46fdd46df010320e1a5ee0457f83.json | Fix inconsistent version number | packages/ember-metal/lib/core.js | @@ -22,7 +22,7 @@
@class Ember
@static
- @version 1.0.0-rc4
+ @version 1.0.0-rc.4
*/
if ('undefined' === typeof Ember) {
@@ -49,10 +49,10 @@ Ember.toString = function() { return "Ember"; };
/**
@property VERSION
@type String
- @default '1.0.0-rc4'
+ @default '1.0.0-rc.4'
@final
*/
-Ember.VERS... | true |
Other | emberjs | ember.js | a1aded50cdaa46fdd46df010320e1a5ee0457f83.json | Fix inconsistent version number | packages/ember-metal/package.json | @@ -4,7 +4,7 @@
"summary": "JavaScript on Steroids",
"homepage": "http://github.com/emberjs/ember.js",
"author": "Charles Jolley",
- "version": "1.0.0-rc4",
+ "version": "1.0.0-rc.4",
"dependencies": {
"spade": "~> 1.0.0" | true |
Other | emberjs | ember.js | a1aded50cdaa46fdd46df010320e1a5ee0457f83.json | Fix inconsistent version number | packages/ember-old-router/package.json | @@ -4,16 +4,16 @@
"description": "The Ember routing system",
"homepage": "http://emberjs.com",
"author": "Yehuda Katz",
- "version": "1.0.0-rc4",
+ "version": "1.0.0-rc.4",
"directories": {
"lib": "lib"
},
"dependencies": {
"spade": "~> 1.0",
- "ember-views": "1.0.0-rc4"... | true |
Other | emberjs | ember.js | a1aded50cdaa46fdd46df010320e1a5ee0457f83.json | Fix inconsistent version number | packages/ember-routing/package.json | @@ -4,15 +4,15 @@
"description": "The Ember routing system",
"homepage": "http://emberjs.com",
"author": "Yehuda Katz",
- "version": "1.0.0-rc4",
+ "version": "1.0.0-rc.4",
"directories": {
"lib": "lib"
},
"dependencies": {
"spade": "~> 1.0",
- "ember-views": "1.0.0-rc4"... | true |
Other | emberjs | ember.js | a1aded50cdaa46fdd46df010320e1a5ee0457f83.json | Fix inconsistent version number | packages/ember-runtime/package.json | @@ -5,15 +5,15 @@
"homepage": "http://emberjs.com",
"author": "Charles Jolley",
- "version": "1.0.0-rc4",
+ "version": "1.0.0-rc.4",
"directories": {
"lib": "lib"
},
"dependencies": {
"spade": "~> 1.0",
- "ember-metal": "1.0.0-rc4",
+ "ember-metal": "1.0.0-rc.4",
"... | true |
Other | emberjs | ember.js | a1aded50cdaa46fdd46df010320e1a5ee0457f83.json | Fix inconsistent version number | packages/ember-states/package.json | @@ -4,15 +4,15 @@
"description": "The Ember state management system",
"homepage": "http://emberjs.com",
"author": "Yehuda Katz",
- "version": "1.0.0-rc4",
+ "version": "1.0.0-rc.4",
"directories": {
"lib": "lib"
},
"dependencies": {
"spade": "~> 1.0",
- "ember-runtime": "1.0... | true |
Other | emberjs | ember.js | a1aded50cdaa46fdd46df010320e1a5ee0457f83.json | Fix inconsistent version number | packages/ember-testing/package.json | @@ -4,7 +4,7 @@
"description": "A lightweight library that provides tools for testing Ember applications",
"homepage": "https://github.com/emberjs/ember.js",
"authors": ["Erik Bryn"],
- "version": "1.0.0-rc4",
+ "version": "1.0.0-rc.4",
"dependencies": {
"spade": "~> 1.0.0" | true |
Other | emberjs | ember.js | a1aded50cdaa46fdd46df010320e1a5ee0457f83.json | Fix inconsistent version number | packages/ember-views/package.json | @@ -4,7 +4,7 @@
"description": "The Ember view system",
"homepage": "http://emberjs.com",
"author": "Yehuda Katz",
- "version": "1.0.0-rc4",
+ "version": "1.0.0-rc.4",
"directories": {
"lib": "lib"
@@ -13,7 +13,7 @@
"dependencies": {
"spade": "~> 1.0",
"jquery": ... | true |
Other | emberjs | ember.js | a1aded50cdaa46fdd46df010320e1a5ee0457f83.json | Fix inconsistent version number | packages/ember/package.json | @@ -4,15 +4,15 @@
"summary": "Ember - JavaScript Application Framework",
"homepage": "http://github.com/emberjs/ember.js",
"author": "Charles Jolley",
- "version": "1.0.0-rc4",
+ "version": "1.0.0-rc.4",
"dependencies": {
"spade": "~> 1.0.0",
- "ember-runtime": "1.0.0-rc4",
- ... | true |
Other | emberjs | ember.js | 83141df210fa420d5bf0470d46acdecd5b777ff8.json | remove non-latest builds | CONTRIBUTING.md | @@ -25,7 +25,6 @@ this bug already.
demo should be fully operational with the exception of the bug you want to
demonstrate. The more pared down, the better.
Preconfigured starting points for the latest Ember: [JSFiddle](http://jsfiddle.net/DCrHG/) | [JSBin](http://jsbin.com/ucanam/54/edit) (may not work with older I... | false |
Other | emberjs | ember.js | ce2e5b3469560d0b1eccab9ce28ef6c6c57ada12.json | Fix typo in code comment
`OuterView` is defined as example not `OutsideView`. | packages/ember-views/lib/views/view.js | @@ -725,7 +725,7 @@ class:
eventManager: Ember.Object.create({
mouseEnter: function(event, view){
// view might be instance of either
- // OutsideView or InnerView depending on
+ // OuterView or InnerView depending on
// where on the page the user interaction occured
}... | false |
Other | emberjs | ember.js | beb4267bdabab179f3a360541c3b614012261bc9.json | add Ember.shallowSet which avoids unknownProperty
thus it doesn't proxy | packages/ember-metal/lib/shallow_set.js | @@ -0,0 +1,39 @@
+require('ember-metal/property_set');
+require('ember-metal/properties');
+
+var set = Ember.set,
+ defineProperty = Ember.defineProperty;
+
+/**
+ Sets the value of a property on an object avoiding the `unknownProperty` hook,
+ instead, if the value is an unknown property, the property is defined... | true |
Other | emberjs | ember.js | beb4267bdabab179f3a360541c3b614012261bc9.json | add Ember.shallowSet which avoids unknownProperty
thus it doesn't proxy | packages/ember-metal/tests/shallow_set_test.js | @@ -0,0 +1,45 @@
+require('ember-metal/shallow_set');
+require('ember-metal/computed');
+require('ember-metal/observer');
+
+module('Ember.shallowSet');
+
+test('shallowSet avoids unknownProperty', function() {
+ var target = {};
+ var proxy = {
+ target: target,
+ unknownProperty: function (key) {
+ retur... | true |
Other | emberjs | ember.js | 9c83112d9698823e4b9f540891a1f083d17d9503.json | use Ember.run.join internally for App#reset | packages/ember-application/lib/system/application.js | @@ -521,6 +521,8 @@ var Application = Ember.Application = Ember.Namespace.extend(Ember.DeferredMixin
@method reset
**/
reset: function() {
+ this._readinessDeferrals = 1;
+
function handleReset() {
var router = this.__container__.lookup('router:main');
router.reset();
@@ -529,19 +531,13... | false |
Other | emberjs | ember.js | 4a48656fbf11b985ae8943ce75c631413cb23485.json | Fix failing test in older IE
In older IE, `for` enumerate internal properties. | packages/ember-runtime/tests/system/object/destroy_test.js | @@ -122,9 +122,9 @@ test("destroyed objects should not see each others changes during teardown but a
var longLivedObject = new LongLivedObject();
Ember.run(function () {
- for (var key in objs) {
- if (!objs.hasOwnProperty(key)) continue;
- objs[key].destroy();
+ var keys = Ember.keys(objs);
+ ... | false |
Other | emberjs | ember.js | 39e9ef7923a549a617854268d7286173e2d0c8e4.json | fix misleading docs [fixes
https://github.com/emberjs/website/issues/485] | packages/ember-application/lib/system/application.js | @@ -152,17 +152,6 @@ DeprecatedContainer.prototype = {
If there is any setup required before routing begins, you can implement a
`ready()` method on your app that will be invoked immediately before routing
begins.
-
- To begin routing, you must have at a minimum a top-level controller and view.
- You define ... | false |
Other | emberjs | ember.js | a6ad8eace3e2211bce100f153082397baf023c6f.json | Remove unused variable | packages/ember-handlebars/tests/handlebars_test.js | @@ -56,7 +56,6 @@ var appendView = function() {
Ember.run(function() { view.appendTo('#qunit-fixture'); });
};
-var additionalTeardown;
var originalLookup = Ember.lookup, lookup;
var TemplateTests, container;
| false |
Other | emberjs | ember.js | ef9db4b6a81fbc289ada8783f6ee9155db2bd9ce.json | Use helper function to remove duplication | packages/ember-handlebars/tests/handlebars_test.js | @@ -151,7 +151,7 @@ test("should escape HTML in normal mustaches", function() {
output: "you need to be more <b>bold</b>"
});
- Ember.run(function() { view.appendTo('#qunit-fixture'); });
+ appendView();
equal(view.$('b').length, 0, "does not create an element");
equal(view.$().text(), 'you need to be... | false |
Other | emberjs | ember.js | 3d87f631e2b3924b584a6b4ceb2a1a02b4142908.json | update doc example to current router | packages/ember-application/lib/system/application.js | @@ -284,10 +284,10 @@ var Application = Ember.Application = Ember.Namespace.extend(Ember.DeferredMixin
This allows application developers to do:
```javascript
- App = Ember.Application.create();
+ var App = Ember.Application.create();
- App.Router.map(function(match) {
- match("/").to("index... | false |
Other | emberjs | ember.js | 84858a10e0090bd708284921d2e6673f4778f73e.json | Fix downloads link for starter-kit
The link to downloads is deprecated.
* https://github.com/blog/1302-goodbye-uploads
Now, we can download tagged version from '/tags'. | README.md | @@ -115,7 +115,7 @@ developers struggle with every day.
# Getting Started
For new users, we recommend downloading the [Ember.js Starter
-Kit](https://github.com/emberjs/starter-kit/downloads), which includes
+Kit](https://github.com/emberjs/starter-kit/tags), which includes
everything you need to get started.
#... | false |
Other | emberjs | ember.js | 018661de496991d9b7d8e1eadcbbf4e7973bbd1e.json | Documentation: fix code block of Ember.String.capitalize
Code examples were not displayed in block code. | packages/ember-runtime/lib/system/string.js | @@ -231,10 +231,12 @@ Ember.String = {
/**
Returns the Capitalized form of a string
- 'innerHTML'.capitalize() // 'InnerHTML'
- 'action_name'.capitalize() // 'Action_name'
- 'css-class-name'.capitalize() // 'Css-class-name'
- 'my favorite items'.capitalize() // 'My fav... | false |
Other | emberjs | ember.js | 3173a49a82a7d80d189c03a257196c834959d0e5.json | Remove unnecessary yuidoc markup
The comments begining with `/**` is parsed as yuidoc.
These comments has no yuidoc markup. | packages/ember-routing/lib/system/transition_event.js | @@ -4,7 +4,7 @@
*/
-/**
+/*
A TransitionEvent is passed as the argument for `transitionTo`
events and contains information about an attempted transition
that can be modified or decorated by leafier `transitionTo` event
@@ -16,7 +16,7 @@
*/
Ember.TransitionEvent = Ember.Object.extend({
- /**
+ /*
... | true |
Other | emberjs | ember.js | 3173a49a82a7d80d189c03a257196c834959d0e5.json | Remove unnecessary yuidoc markup
The comments begining with `/**` is parsed as yuidoc.
These comments has no yuidoc markup. | packages/ember-views/lib/system/utils.js | @@ -3,7 +3,7 @@
@submodule ember-views
*/
-/*** BEGIN METAMORPH HELPERS ***/
+/* BEGIN METAMORPH HELPERS */
// Internet Explorer prior to 9 does not allow setting innerHTML if the first element
// is a "zero-scope" element. This problem can be worked around by making
@@ -76,7 +76,7 @@ var setInnerHTMLWithoutFix... | true |
Other | emberjs | ember.js | ea7e746d13f7c9173d2b3f3a4b66d1228aeb60c2.json | Remove unnecessary reference
`Error.prototype.constructor` returns `Error`. | packages/ember-runtime/lib/core.js | @@ -288,7 +288,7 @@ var errorProps = ['description', 'fileName', 'lineNumber', 'message', 'name', 'n
@constructor
*/
Ember.Error = function() {
- var tmp = Error.prototype.constructor.apply(this, arguments);
+ var tmp = Error.apply(this, arguments);
// Unfortunately errors are not enumerable in Chrome (at l... | false |
Other | emberjs | ember.js | 2e85b0e67f5f077b57c56c7232fee43a7b4710b9.json | Remove SC compatibility in Ember.Array
I think `Ember.Array#isSCArray` is no longer necessary. | packages/ember-runtime/lib/mixins/array.js | @@ -49,9 +49,6 @@ var get = Ember.get, set = Ember.set, isNone = Ember.isNone, map = Ember.Enumera
*/
Ember.Array = Ember.Mixin.create(Ember.Enumerable, /** @scope Ember.Array.prototype */ {
- // compatibility
- isSCArray: true,
-
/**
Your array must support the `length` property. Your replace methods sho... | false |
Other | emberjs | ember.js | 4fffc17412c126590d1bc4cce8a0620af5d3a419.json | Remove unused variables and helper function | packages/ember-metal/lib/events.js | @@ -10,7 +10,7 @@ var o_create = Ember.create,
metaFor = Ember.meta,
META_KEY = Ember.META_KEY,
/* listener flags */
- ONCE = 1, SUSPENDED = 2, IMMEDIATE = 4;
+ ONCE = 1, SUSPENDED = 2;
/*
The event system uses a series of nested hashes to store listeners on an | true |
Other | emberjs | ember.js | 4fffc17412c126590d1bc4cce8a0620af5d3a419.json | Remove unused variables and helper function | packages/ember-metal/lib/mixin.js | @@ -199,14 +199,6 @@ function mergeMixins(mixins, m, descs, values, base, keys) {
}
}
-function writableReq(obj) {
- var m = Ember.meta(obj), req = m.required;
- if (!req || !m.hasOwnProperty('required')) {
- req = m.required = req ? o_create(req) : {};
- }
- return req;
-}
-
var IS_BINDING = Ember.IS_BIN... | true |
Other | emberjs | ember.js | 4fffc17412c126590d1bc4cce8a0620af5d3a419.json | Remove unused variables and helper function | packages/ember-metal/lib/observer.js | @@ -11,8 +11,6 @@ require('ember-metal/array');
var AFTER_OBSERVERS = ':change';
var BEFORE_OBSERVERS = ':before';
-var guidFor = Ember.guidFor;
-
function changeEvent(keyName) {
return keyName+AFTER_OBSERVERS;
} | true |
Other | emberjs | ember.js | 4fffc17412c126590d1bc4cce8a0620af5d3a419.json | Remove unused variables and helper function | packages/ember-metal/lib/properties.js | @@ -28,7 +28,7 @@ var MANDATORY_SETTER = Ember.ENV.MANDATORY_SETTER;
@private
@constructor
*/
-var Descriptor = Ember.Descriptor = function() {};
+Ember.Descriptor = function() {};
// ..........................................................
// DEFINING PROPERTIES API | true |
Other | emberjs | ember.js | 4fffc17412c126590d1bc4cce8a0620af5d3a419.json | Remove unused variables and helper function | packages/ember-metal/lib/property_events.js | @@ -182,7 +182,7 @@ var endPropertyChanges = Ember.endPropertyChanges = function() {
@param {Function} callback
@param [binding]
*/
-var changeProperties = Ember.changeProperties = function(cb, binding){
+Ember.changeProperties = function(cb, binding){
beginPropertyChanges();
tryFinally(cb, endPropertyChan... | true |
Other | emberjs | ember.js | 4fffc17412c126590d1bc4cce8a0620af5d3a419.json | Remove unused variables and helper function | packages/ember-metal/lib/utils.js | @@ -90,7 +90,7 @@ Ember.guidFor = function guidFor(obj) {
if (obj === undefined) return "(undefined)";
if (obj === null) return "(null)";
- var cache, ret;
+ var ret;
var type = typeof obj;
// Don't allow prototype changes to String etc. to change the guidFor
@@ -491,7 +491,7 @@ if (needsFinallyFix) {... | true |
Other | emberjs | ember.js | 4fffc17412c126590d1bc4cce8a0620af5d3a419.json | Remove unused variables and helper function | packages/ember-metal/lib/watch_path.js | @@ -33,7 +33,7 @@ Ember.watchPath = function(obj, keyPath) {
};
Ember.unwatchPath = function(obj, keyPath) {
- var m = metaFor(obj), watching = m.watching, desc;
+ var m = metaFor(obj), watching = m.watching;
if (watching[keyPath] === 1) {
watching[keyPath] = 0; | true |
Other | emberjs | ember.js | a8b6e3042244af1dd315e94c9349722450bca301.json | Replace Ember.RunLoop with Backburner.js | packages/ember-application/lib/system/application.js | @@ -463,7 +463,7 @@ var Application = Ember.Application = Ember.Namespace.extend(Ember.DeferredMixin
},
reset: function() {
- Ember.assert('App#reset no longer needs to be wrapped in a run-loop', !Ember.run.currentRunLoop);
+ Ember.assert('App#reset no longer needs to be wrapped in a run-loop', !Ember.run... | true |
Other | emberjs | ember.js | a8b6e3042244af1dd315e94c9349722450bca301.json | Replace Ember.RunLoop with Backburner.js | packages/ember-metal/lib/main.js | @@ -24,4 +24,4 @@ require('ember-metal/events');
require('ember-metal/observer');
require('ember-metal/mixin');
require('ember-metal/binding');
-require('ember-metal/run_loop');
+require('ember-metal/run_loop');
\ No newline at end of file | true |
Other | emberjs | ember.js | a8b6e3042244af1dd315e94c9349722450bca301.json | Replace Ember.RunLoop with Backburner.js | packages/ember-metal/lib/run_loop.js | @@ -1,180 +1,13 @@
-require('ember-metal/core'); // Ember.Logger
-require('ember-metal/watching'); // Ember.watch.flushPending
-require('ember-metal/observer'); // Ember.beginPropertyChanges, Ember.endPropertyChanges
-require('ember-metal/utils'); // Ember.guidFor, Ember.tryFinally
+require('ember-metal/vendor/backburn... | true |
Other | emberjs | ember.js | a8b6e3042244af1dd315e94c9349722450bca301.json | Replace Ember.RunLoop with Backburner.js | packages/ember-metal/lib/vendor/backburner.js | @@ -0,0 +1,443 @@
+define("backburner",
+ ["backburner/deferred_action_queues","exports"],
+ function(__dependency1__, __exports__) {
+ "use strict";
+ var DeferredActionQueues = __dependency1__.DeferredActionQueues;
+
+ var slice = [].slice,
+ pop = [].pop,
+ debouncees = [],
+ timers =... | true |
Other | emberjs | ember.js | a8b6e3042244af1dd315e94c9349722450bca301.json | Replace Ember.RunLoop with Backburner.js | packages/ember-metal/tests/binding/connect_test.js | @@ -5,7 +5,7 @@ require('ember-metal/~tests/props_helper');
function performTest(binding, a, b, get, set, connect) {
if (connect === undefined) connect = function(){binding.connect(a);};
- ok(!Ember.run.currentRunLoop, 'performTest should not have a currentRunLoop');
+ ok(!Ember.run.backburner.currentInstance, ... | true |
Other | emberjs | ember.js | a8b6e3042244af1dd315e94c9349722450bca301.json | Replace Ember.RunLoop with Backburner.js | packages/ember-metal/tests/run_loop/later_test.js | @@ -69,11 +69,11 @@ asyncTest('should always invoke within a separate runloop', function() {
var obj = { invoked: 0 }, firstRunLoop, secondRunLoop;
Ember.run(function() {
- firstRunLoop = Ember.run.currentRunLoop;
+ firstRunLoop = Ember.run.backburner.currentInstance;
Ember.run.later(obj, function(... | true |
Other | emberjs | ember.js | a8b6e3042244af1dd315e94c9349722450bca301.json | Replace Ember.RunLoop with Backburner.js | packages/ember-metal/tests/run_loop/next_test.js | @@ -21,8 +21,8 @@ asyncTest('should invoke immediately on next timeout', function() {
asyncTest('callback should be called from within separate loop', function() {
var firstRunLoop, secondRunLoop;
Ember.run(function() {
- firstRunLoop = Ember.run.currentRunLoop;
- Ember.run.next(function() { secondRunLoop ... | true |
Other | emberjs | ember.js | a8b6e3042244af1dd315e94c9349722450bca301.json | Replace Ember.RunLoop with Backburner.js | packages/ember-metal/tests/run_loop/once_test.js | @@ -48,7 +48,7 @@ test('should be inside of a runloop when running', function() {
Ember.run(function() {
Ember.run.once(function() {
- ok(!!Ember.run.currentRunLoop, 'should have a runloop');
+ ok(!!Ember.run.backburner.currentInstance, 'should have a runloop');
});
});
}); | true |
Other | emberjs | ember.js | a8b6e3042244af1dd315e94c9349722450bca301.json | Replace Ember.RunLoop with Backburner.js | packages/ember-metal/tests/run_loop/schedule_test.js | @@ -35,30 +35,30 @@ test('prior queues should be flushed before moving on to next queue', function()
var order = [];
Ember.run(function() {
- var runLoop = Ember.run.currentRunLoop;
+ var runLoop = Ember.run.backburner.currentInstance;
ok(runLoop, 'run loop present');
Ember.run.schedule('sync'... | true |
Other | emberjs | ember.js | a8b6e3042244af1dd315e94c9349722450bca301.json | Replace Ember.RunLoop with Backburner.js | packages/ember-metal/tests/run_loop/unwind_test.js | @@ -1,7 +1,7 @@
module('system/run_loop/unwind_test');
test('RunLoop unwinds despite unhandled exception', function() {
- var initialRunLoop = Ember.run.currentRunLoop;
+ var initialRunLoop = Ember.run.backburner.currentInstance;
raises(function(){
Ember.run(function() {
@@ -13,26 +13,26 @@ test('RunLoo... | true |
Other | emberjs | ember.js | a8b6e3042244af1dd315e94c9349722450bca301.json | Replace Ember.RunLoop with Backburner.js | packages/ember-testing/lib/helpers.js | @@ -49,7 +49,7 @@ function wait(app, value) {
var routerIsLoading = app.__container__.lookup('router:main').router.isLoading;
if (routerIsLoading) { return; }
if (pendingAjaxRequests) { return; }
- if (Ember.run.hasScheduledTimers() || Ember.run.currentRunLoop) { return; }
+ if (Ember.run... | true |
Other | emberjs | ember.js | a8b6e3042244af1dd315e94c9349722450bca301.json | Replace Ember.RunLoop with Backburner.js | packages/ember-views/lib/system/ext.js | @@ -6,6 +6,6 @@
// Add a new named queue for rendering views that happens
// after bindings have synced, and a queue for scheduling actions
// that that should occur after view rendering.
-var queues = Ember.run.queues,
+var queues = Ember.run.backburner.queueNames,
indexOf = Ember.ArrayPolyfills.indexOf;
queu... | true |
Other | emberjs | ember.js | 4ab23f79393ed6a143074676e8a79ed5ccea7491.json | Fix Ember.Test.registerHelper test | packages/ember-testing/tests/helpers_test.js | @@ -52,7 +52,7 @@ test("Ember.Application#setupForTesting", function() {
});
test("Ember.Test.registerHelper/unregisterHelper", function() {
- expect(3);
+ expect(5);
var appBooted = false;
Ember.Test.registerHelper('boot', function(app) {
@@ -67,14 +67,17 @@ test("Ember.Test.registerHelper/unregisterHelp... | false |
Other | emberjs | ember.js | ef48e0fbcad620406bd5201cc6381332ff985ec8.json | Fix code comment at `Ember.TextField`
This property is `onEvent`. | packages/ember-handlebars/lib/controls/text_field.js | @@ -113,7 +113,7 @@ Ember.TextField = Ember.View.extend(Ember.TextSupport,
* `enter`: the user pressed enter
* `keypress`: the user pressed a key
- @property on
+ @property onEvent
@type String
@default enter
*/ | false |
Other | emberjs | ember.js | 816350374b203f24d47b87b98285a243c810a603.json | Fix language type | packages/ember-handlebars/lib/controls/checkbox.js | @@ -23,7 +23,7 @@ var set = Ember.set, get = Ember.get;
You can add a `label` tag yourself in the template where the `Ember.Checkbox`
is being used.
- ```html
+ ```handlebars
<label>
{{view Ember.Checkbox classNames="applicaton-specific-checkbox"}}
Some Title | false |
Other | emberjs | ember.js | c0f74e2614841a75d03a795dd72dd9fadeb9d393.json | Fix warning message
The argument of `Ember.String.fmt` should be an array. | packages/ember-routing/lib/system/route.js | @@ -548,7 +548,7 @@ function parentTemplate(route, isRecursive) {
if (!parent) { return; }
- Ember.warn(fmt("The immediate parent route ('%@') did not render into the main outlet and the default 'into' option ('%@') may not be expected", get(parent, 'routeName'), get(route, 'routeName')), !isRecursive);
+ Embe... | false |
Other | emberjs | ember.js | 3a55a881c6a911a6ab1d100a0bbfa5d6c482afe1.json | Stop unnecessary `jQuery.fn` extension
I replaced jQeury methods to helper functions. | packages/ember-handlebars/tests/handlebars_test.js | @@ -14,47 +14,41 @@ var firstChild = nthChild;
var originalLog, logCalls;
-(function() {
+var caretPosition = function (element) {
+ var ctrl = element[0];
+ var caretPos = 0;
- Ember.$.fn.caretPosition = function() {
- var ctrl = this[0];
+ // IE Support
+ if (document.selection) {
+ ctrl.focus();
... | false |
Other | emberjs | ember.js | 933fd07cdefa6f997061061a9943b83436c71e3b.json | Use helper function
`append` is defined for append `checkboxView` to '#qunit-fixture'. | packages/ember-handlebars/tests/controls/checkbox_test.js | @@ -190,7 +190,7 @@ test("checked property mirrors input value", function() {
test("checking the checkbox updates the value", function() {
checkboxView = Ember.Checkbox.create({ checked: true });
- Ember.run(function() { checkboxView.appendTo('#qunit-fixture'); });
+ append();
equal(get(checkboxView, 'chec... | false |
Other | emberjs | ember.js | 1e86986a930c61c912effe0a62fa659f7ada15f7.json | Add onInjectHelpers method | packages/ember-testing/lib/helpers.js | @@ -2,7 +2,20 @@ require('ember-testing/test');
var Promise = Ember.RSVP.Promise,
get = Ember.get,
- helper = Ember.Test.registerHelper;
+ helper = Ember.Test.registerHelper,
+ pendingAjaxRequests = 0;
+
+
+Ember.Test.onInjectHelpers(function() {
+ Ember.$(document).ajaxStart(function() {
+ pending... | true |
Other | emberjs | ember.js | 1e86986a930c61c912effe0a62fa659f7ada15f7.json | Add onInjectHelpers method | packages/ember-testing/lib/test.js | @@ -1,6 +1,7 @@
var slice = [].slice,
helpers = {},
- originalMethods = {};
+ originalMethods = {},
+ injectHelpersCallbacks = [];
/**
@class Test
@@ -53,6 +54,7 @@ Ember.Test = {
helpers[name] = helperMethod;
},
/**
+ @public
@method unregisterHelper
@param name {String}
... | true |
Other | emberjs | ember.js | 79aefff9b875026e3925a8a4a2a7b9dfe07a4f0f.json | Create Ember.Test with registerHelper method | packages/ember-testing/lib/helpers.js | @@ -1,10 +1,8 @@
-/*globals EMBER_APP_BEING_TESTED */
+require('ember-testing/test');
var Promise = Ember.RSVP.Promise,
- pendingAjaxRequests = 0,
- originalFind,
- slice = [].slice,
- get = Ember.get;
+ get = Ember.get,
+ helper = Ember.Test.registerHelper;
function visit(app, url) {
Ember.r... | true |
Other | emberjs | ember.js | 79aefff9b875026e3925a8a4a2a7b9dfe07a4f0f.json | Create Ember.Test with registerHelper method | packages/ember-testing/lib/main.js | @@ -1,2 +1,3 @@
require('ember-application');
+require('ember-testing/test');
require('ember-testing/helpers');
\ No newline at end of file | true |
Other | emberjs | ember.js | 79aefff9b875026e3925a8a4a2a7b9dfe07a4f0f.json | Create Ember.Test with registerHelper method | packages/ember-testing/lib/test.js | @@ -0,0 +1,115 @@
+var slice = [].slice,
+ helpers = {},
+ originalMethods = {};
+
+/**
+ @class Test
+ @namespace Ember
+*/
+Ember.Test = {
+
+ /**
+ @public
+
+ `registerHelper` is used to register a
+ test helper that will be injected when
+ `App.injectTestHelpers` is called.
+
+ The helper m... | true |
Other | emberjs | ember.js | 79aefff9b875026e3925a8a4a2a7b9dfe07a4f0f.json | Create Ember.Test with registerHelper method | packages/ember-testing/tests/helpers_test.js | @@ -11,24 +11,35 @@ module("ember-testing", {
test("Ember.Application#injectTestHelpers/#removeTestHelpers", function() {
App = Ember.run(Ember.Application, Ember.Application.create);
ok(!window.visit);
+ ok(!App.testHelpers.visit);
ok(!window.click);
+ ok(!App.testHelpers.click);
ok(!window.fillIn);
+ ... | true |
Other | emberjs | ember.js | f7245ee05c288dbce94a6540af6222baa4a3f674.json | Remove duplicated test. | packages/ember-handlebars/tests/helpers/each_test.js | @@ -416,17 +416,6 @@ test("#each accepts a name binding and can display child properties", function()
equal(view.$().text(), "My Cool Each Test 1My Cool Each Test 2");
});
-test("#each accepts 'this' as the right hand side", function() {
- view = Ember.View.create({
- template: templateFor("{{#each item in th... | false |
Other | emberjs | ember.js | bc47ba53b499a968db1c7eae019b36769fa5e922.json | Remove unused helper function
`setAndFlush` is defined but not used. | packages/ember-handlebars/tests/controls/select_test.js | @@ -18,12 +18,6 @@ module("Ember.Select", {
}
});
-function setAndFlush(view, key, value) {
- Ember.run(function() {
- Ember.set(view, key, value);
- });
-}
-
function append() {
Ember.run(function() {
select.appendTo('#qunit-fixture'); | false |
Other | emberjs | ember.js | d7bcbf0628d6b177ea854ba7a9b274b4295caff1.json | Fix CollectionView.arrayDidChange documentation
CollectionView.arrayDidChange arguments have changed wihout
documentation changes. This commit fixes this method documentation. | packages/ember-views/lib/views/collection_view.js | @@ -288,9 +288,10 @@ Ember.CollectionView = Ember.ContainerView.extend(
This array observer is added in `contentDidChange`.
@method arrayDidChange
- @param {Array} addedObjects the objects that were added to the content
- @param {Array} removedObjects the objects that were removed from the content
- ... | false |
Other | emberjs | ember.js | 3c6dd5271cd4380a515c714edfbf7ca60f652445.json | Add test for visit helper in ember testing | packages/ember-testing/tests/helpers_test.js | @@ -37,4 +37,48 @@ test("Ember.Application#setupForTesting", function() {
equal(App.__container__.lookup('router:main').location.implementation, 'none');
equal(window.EMBER_APP_BEING_TESTED, App);
-});
\ No newline at end of file
+});
+
+test("visit transitions to the correct route", function() {
+ expect(2);
... | false |
Other | emberjs | ember.js | 849e6e5248a91f96c95b6242fd1ef1ea16d9e625.json | Update route-recognizer - Fixes #2559 | packages/ember-routing/lib/vendor/route-recognizer.js | @@ -373,14 +373,14 @@ define("route-recognizer",
},
recognize: function(path) {
- var states = [ this.rootState ], i, l;
+ var states = [ this.rootState ],
+ pathLen, i, l;
// DEBUG GROUP path
- var pathLen = path.length;
-
if (path.charAt(0) !== "/"... | false |
Other | emberjs | ember.js | 0e4873d1710a0546711c7b052027cbe417fd8ebb.json | prevent exception on empty Em.Select content | packages/ember-handlebars/lib/controls/select.js | @@ -472,7 +472,7 @@ Ember.Select = Ember.View.extend(
content = get(this, 'content'),
prompt = get(this, 'prompt');
- if (!get(content, 'length')) { return; }
+ if (!content || !get(content, 'length')) { return; }
if (prompt && selectedIndex === 0) { set(this, 'selection', null); return; ... | false |
Other | emberjs | ember.js | 05bcbd58e72921d3f944a3f7ffc30f60f082ce46.json | fix some typos in the test names | packages/ember-views/tests/views/view/append_to_test.js | @@ -14,7 +14,7 @@ module("Ember.View - append() and appendTo()", {
}
});
-test("should be added to the specified element when calling append()", function() {
+test("should be added to the specified element when calling appendTo()", function() {
Ember.$("#qunit-fixture").html('<div id="menu"></div>');
view... | false |
Other | emberjs | ember.js | 7be8024dcd65c3c8a49f06df0a6452c1641a4d14.json | Add tests to deferred mixin | packages/ember-runtime/tests/mixins/deferred_test.js | @@ -12,7 +12,7 @@ test("can resolve deferred", function() {
});
Ember.run(function() {
- deferred.resolve();
+ deferred.resolve(deferred);
});
equal(count, 1, "was fulfilled");
@@ -52,7 +52,7 @@ test("can resolve with then", function() {
});
Ember.run(function() {
- deferred.resolve();
... | false |
Other | emberjs | ember.js | 24e00ebd62535f638d4d8533d03f2c7a7d6445ba.json | Normalize Ember.Handlebars.helper hashes | packages/ember-handlebars-compiler/lib/main.js | @@ -37,6 +37,7 @@ Ember.Handlebars.helper = function(name, value) {
if (Ember.View.detect(value)) {
Ember.Handlebars.registerHelper(name, function(options) {
Ember.assert("You can only pass attributes as parameters to a application-defined helper", arguments.length < 3);
+ options.hash = Ember.Handl... | false |
Other | emberjs | ember.js | a035ae76d303fad9747a16f747f2e51f2e327935.json | Fix bug with Ember.Handlebars.helper
When used to create a dyanmic tag | packages/ember-handlebars-compiler/lib/main.js | @@ -35,7 +35,7 @@ Ember.Handlebars = objectCreate(Handlebars);
Ember.Handlebars.helper = function(name, value) {
if (Ember.View.detect(value)) {
- Ember.Handlebars.registerHelper(name, function(name, options) {
+ Ember.Handlebars.registerHelper(name, function(options) {
Ember.assert("You can only pas... | false |
Other | emberjs | ember.js | 3f8bc3245cb07f49223111b6c33c6241014a23bd.json | clarify input documentation | packages/ember-handlebars/lib/controls.js | @@ -15,7 +15,7 @@ function normalizeHash(hash, hashTypes) {
/**
* `{{input}}` inserts a new instance of either Ember.TextField or
- * Ember.Checkbox, depending on the `inputType` passed in. If no `inputType`
+ * Ember.Checkbox, depending on the `type` option passed in. If no `type`
* is supplied it defaults to E... | false |
Other | emberjs | ember.js | 174bc158d79148dea5445db75c7ca785fd2cca6b.json | Move linkTo docs to helper instead of LinkView | packages/ember-routing/lib/helpers/link_to.js | @@ -38,6 +38,66 @@ Ember.onLoad('Ember.Handlebars', function(Handlebars) {
return ret.concat(resolvedPaths(linkView.parameters));
}
+ /**
+ @class LinkView
+ @namespace Ember
+ @extends Ember.View
+ **/
+ var LinkView = Ember.LinkView = Ember.View.extend({
+ tagName: 'a',
+ namedRoute: null,... | false |
Other | emberjs | ember.js | fa627f4421e8b665fc32dca8350a2649103a94eb.json | Switch assertion for simulated Ember.create
The object created by simulated `Ember.create` has many property.
So `deepEqual` couldn't be used for its' assertion. | packages/ember-routing/tests/helpers/control_test.js | @@ -215,7 +215,12 @@ if (Ember.ENV.EXPERIMENTAL_CONTROL_HELPER) {
var childController = view.get('childViews').objectAt(0).get('controller');
ok(view.$().text().match(/^.*Tom Dale.*$/), "The view rendered");
- deepEqual(childController.get('model'), { name: "Tom Dale" });
+
+ if (Ember.create.isSimula... | true |
Other | emberjs | ember.js | fa627f4421e8b665fc32dca8350a2649103a94eb.json | Switch assertion for simulated Ember.create
The object created by simulated `Ember.create` has many property.
So `deepEqual` couldn't be used for its' assertion. | packages/ember-routing/tests/helpers/render_test.js | @@ -118,7 +118,11 @@ test("{{render}} helper should render given template with a supplied model", fun
set(controller, 'post', { title: "Rails is unagi" });
equal(view.$().text(), 'HIRails is unagi');
- deepEqual(postController.get('model'), { title: "Rails is unagi" });
+ if (Ember.create.isSimulated) {
+ ... | true |
Other | emberjs | ember.js | 1b06211af6ed18c0ea4582c77902d9ad68fb62d0.json | Use stub `Object.create` for IE8
It couldn't treat property descripters. | packages/ember-metal/lib/platform.js | @@ -24,6 +24,13 @@ var platform = Ember.platform = {};
*/
Ember.create = Object.create;
+// IE8 has Object.create but it couldn't treat property descripters.
+if (Ember.create) {
+ if (Ember.create({a: 1}, {a: {value: 2}}).a !== 2) {
+ Ember.create = null;
+ }
+}
+
// STUB_OBJECT_CREATE allows us to override ... | false |
Other | emberjs | ember.js | 9ba85b860c2ec691891bdc6b61b8d205d699c646.json | Include ember-testing in full build | Assetfile | @@ -4,8 +4,8 @@ distros = {
"runtime" => %w(ember-metal rsvp container ember-runtime),
"template-compiler" => %w(ember-handlebars-compiler),
"data-deps" => %w(ember-metal rsvp container ember-runtime ember-states),
- "full" => %w(ember-metal rsvp container ember-runtime ember-vi... | false |
Other | emberjs | ember.js | f870e8e98d3c09297388fd7e7e5424456e20cd22.json | fix failing tests for outerHTML fallback | packages/ember-views/lib/system/render_buffer.js | @@ -454,8 +454,11 @@ Ember._RenderBuffer.prototype =
string: function() {
if (this._hasElement && this._element) {
// Firefox versions < 11 do not have support for element.outerHTML.
- return this.element().outerHTML ||
- new XMLSerializer().serializeToString(this.element());
+ var thisE... | true |
Other | emberjs | ember.js | f870e8e98d3c09297388fd7e7e5424456e20cd22.json | fix failing tests for outerHTML fallback | packages/ember-views/tests/system/render_buffer_test.js | @@ -93,7 +93,7 @@ test("handles browsers like Firefox < 11 that don't support outerHTML Issue #195
// Make sure element.outerHTML is falsy to trigger the fallback.
var elementStub = '<div></div>';
buffer.element = function(){ return elementStub; };
- equal(new XMLSerializer().serializeToString(elementStub), b... | true |
Other | emberjs | ember.js | 2b389b43fb792cea18249f6598f4bcb81181767a.json | Fix method comments | packages/ember-runtime/lib/controllers/array_controller.js | @@ -126,9 +126,9 @@ Ember.ArrayController = Ember.ArrayProxy.extend(Ember.ControllerMixin,
});
```
- @method
- @type String
- @default null
+ @method lookupItemController
+ @param {Object} object
+ @return {String}
*/
lookupItemController: function(object) {
return get(this, 'it... | true |
Other | emberjs | ember.js | 2b389b43fb792cea18249f6598f4bcb81181767a.json | Fix method comments | packages/ember-runtime/lib/system/native_array.js | @@ -117,9 +117,8 @@ if (ignore.length>0) {
@namespace Ember
@extends Ember.Mixin
@uses Ember.MutableArray
- @uses Ember.MutableEnumerable
+ @uses Ember.Observable
@uses Ember.Copyable
- @uses Ember.Freezable
*/
Ember.NativeArray = NativeArray;
| true |
Other | emberjs | ember.js | 81f55a1045800fd37a3249b3b6d95b6b7d02e9bb.json | Eliminate unused variables
I used jshint with '"unused": true' option. | packages/container/lib/main.js | @@ -238,7 +238,7 @@ define("container",
var factory = factoryFor(container, fullName);
var splitName = fullName.split(":"),
- type = splitName[0], name = splitName[1],
+ type = splitName[0],
value;
if (option(container, fullName, 'instantiate') === false) { | true |
Other | emberjs | ember.js | 81f55a1045800fd37a3249b3b6d95b6b7d02e9bb.json | Eliminate unused variables
I used jshint with '"unused": true' option. | packages/ember-handlebars/lib/ext.js | @@ -336,7 +336,7 @@ function evaluateMultiPropertyBoundHelper(context, fn, normalizedProperties, opt
bindView = new Ember._SimpleHandlebarsView(null, null, !hash.unescaped, data);
bindView.normalizedValue = function() {
- var args = [], value, boundOption;
+ var args = [], boundOption;
// Copy over... | true |
Other | emberjs | ember.js | 81f55a1045800fd37a3249b3b6d95b6b7d02e9bb.json | Eliminate unused variables
I used jshint with '"unused": true' option. | packages/ember-handlebars/lib/helpers/collection.js | @@ -181,8 +181,6 @@ Ember.Handlebars.registerHelper('collection', function(path, options) {
}
}
- var tagName = hash.tagName || collectionPrototype.tagName;
-
if (fn) {
itemHash.template = fn;
delete options.fn;
@@ -204,8 +202,6 @@ Ember.Handlebars.registerHelper('collection', function(path, opt... | true |
Other | emberjs | ember.js | 81f55a1045800fd37a3249b3b6d95b6b7d02e9bb.json | Eliminate unused variables
I used jshint with '"unused": true' option. | packages/ember-handlebars/lib/helpers/view.js | @@ -116,11 +116,8 @@ EmberHandlebars.ViewHelper = Ember.Object.create({
},
helper: function(thisContext, path, options) {
- var inverse = options.inverse,
- data = options.data,
- view = data.view,
+ var data = options.data,
fn = options.fn,
- hash = options.hash,
ne... | true |
Other | emberjs | ember.js | 81f55a1045800fd37a3249b3b6d95b6b7d02e9bb.json | Eliminate unused variables
I used jshint with '"unused": true' option. | packages/ember-metal/lib/chains.js | @@ -75,7 +75,6 @@ function isProto(pvalue) {
// value for the key then the node won't actually watch it. For a root node
// pass null for parent and key and object for value.
var ChainNode = Ember._ChainNode = function(parent, key, value) {
- var obj;
this._parent = parent;
this._key = key;
| true |
Other | emberjs | ember.js | 81f55a1045800fd37a3249b3b6d95b6b7d02e9bb.json | Eliminate unused variables
I used jshint with '"unused": true' option. | packages/ember-metal/lib/computed.js | @@ -699,7 +699,6 @@ Ember.computed.alias = function(dependentKey) {
*/
Ember.computed.defaultTo = function(defaultPath) {
return Ember.computed(function(key, newValue, cachedValue) {
- var result;
if (arguments.length === 1) {
return cachedValue != null ? cachedValue : get(this, defaultPath);
} | true |
Other | emberjs | ember.js | 81f55a1045800fd37a3249b3b6d95b6b7d02e9bb.json | Eliminate unused variables
I used jshint with '"unused": true' option. | packages/ember-metal/lib/property_set.js | @@ -5,8 +5,6 @@ require('ember-metal/property_events'); // propertyWillChange, propertyDidChange
var META_KEY = Ember.META_KEY,
MANDATORY_SETTER = Ember.ENV.MANDATORY_SETTER,
IS_GLOBAL = /^([A-Z$]|([0-9][A-Z$]))/,
- propertyWillChange = Ember.propertyWillChange,
- propertyDidChange = Ember.propertyDidC... | true |
Other | emberjs | ember.js | 81f55a1045800fd37a3249b3b6d95b6b7d02e9bb.json | Eliminate unused variables
I used jshint with '"unused": true' option. | packages/ember-old-router/lib/router.js | @@ -10,15 +10,6 @@ require('ember-metal/utils'); // Ember.tryFinally
var get = Ember.get, set = Ember.set;
-var merge = function(original, hash) {
- for (var prop in hash) {
- if (!hash.hasOwnProperty(prop)) { continue; }
- if (original.hasOwnProperty(prop)) { continue; }
-
- original[prop] = hash[prop];... | true |
Other | emberjs | ember.js | 81f55a1045800fd37a3249b3b6d95b6b7d02e9bb.json | Eliminate unused variables
I used jshint with '"unused": true' option. | packages/ember-routing/lib/vendor/router.js | @@ -68,8 +68,7 @@ define("router",
@return {Array} an Array of `[handler, parameter]` tuples
*/
handleURL: function(url) {
- var results = this.recognizer.recognize(url),
- objects = [];
+ var results = this.recognizer.recognize(url);
if (!results) {
... | true |
Other | emberjs | ember.js | 81f55a1045800fd37a3249b3b6d95b6b7d02e9bb.json | Eliminate unused variables
I used jshint with '"unused": true' option. | packages/ember-views/lib/views/view.js | @@ -1309,7 +1309,7 @@ Ember.View = Ember.CoreView.extend(
@param {Ember.RenderBuffer} buffer
*/
_applyAttributeBindings: function(buffer, attributeBindings) {
- var attributeValue, elem, type;
+ var attributeValue, elem;
a_forEach(attributeBindings, function(binding) {
var split = binding... | true |
Other | emberjs | ember.js | 7bb81ad97fdb0904373e43148d52abe53ccaa8cb.json | Add missing item type
YUIDoc shows the some warnings for `Missing item type`. | packages/ember-application/lib/system/application.js | @@ -656,6 +656,7 @@ Ember.Application.reopenClass({
This allows the application to register default injections in the container
that could be overridden by the normal naming convention.
+ @method resolverFor
@param {Ember.Namespace} namespace the namespace to look for classes
@return {*} the resolved val... | true |
Other | emberjs | ember.js | 7bb81ad97fdb0904373e43148d52abe53ccaa8cb.json | Add missing item type
YUIDoc shows the some warnings for `Missing item type`. | packages/ember-handlebars/lib/ext.js | @@ -319,6 +319,7 @@ Ember.Handlebars.registerBoundHelper = function(name, fn) {
Renders the unbound form of an otherwise bound helper function.
+ @method evaluateMultiPropertyBoundHelper
@param {Function} fn
@param {Object} context
@param {Array} normalizedProperties
@@ -380,6 +381,7 @@ function evalua... | true |
Other | emberjs | ember.js | 7bb81ad97fdb0904373e43148d52abe53ccaa8cb.json | Add missing item type
YUIDoc shows the some warnings for `Missing item type`. | packages/ember-routing/lib/system/route.js | @@ -172,6 +172,8 @@ Ember.Route = Ember.Object.extend({
@private
Called when the context is changed by router.js.
+
+ @method contextDidChange
*/
contextDidChange: function() {
this.currentModel = this.context; | true |
Other | emberjs | ember.js | 7993f8cdbee02eabd55328c8d1cef29a0a5aa2e5.json | Fix method comment about arguments | packages/ember-runtime/lib/system/string.js | @@ -48,7 +48,8 @@ Ember.String = {
```
@method fmt
- @param {Object...} [args]
+ @param {String} str The string to format
+ @param {Array} formats An array of parameters to interpolate into string.
@return {String} formatted string
*/
fmt: function(str, formats) { | false |
Other | emberjs | ember.js | 06bae5ad65bfcbf1c375bb79f40307bd55536b0e.json | fix a typo in {{bindAttr}} doc | packages/ember-handlebars/lib/helpers/binding.js | @@ -419,7 +419,7 @@ EmberHandlebars.registerHelper('unless', function(context, options) {
Results in the following rendered output:
```html
- <img class=":class-name-to-always-apply">
+ <img class="class-name-to-always-apply">
```
All three strategies - string return value, boolean return value, and | false |
Other | emberjs | ember.js | b86b0a23467158850c97f6bd04f2a9e990de647a.json | Remove unused argument from helper functions | packages/ember-metal/lib/computed.js | @@ -38,7 +38,7 @@ var get = Ember.get,
This function returns a map of unique dependencies for a
given object and key.
*/
-function keysForDep(obj, depsMeta, depKey) {
+function keysForDep(depsMeta, depKey) {
var keys = depsMeta[depKey];
if (!keys) {
// if there are no dependencies yet for a the given ... | false |
Other | emberjs | ember.js | 6c446205090966f6838cdd1576e677aadf64411f.json | Use isNone to check tag name | packages/ember-views/lib/views/view.js | @@ -127,7 +127,7 @@ Ember.CoreView = Ember.Object.extend(Ember.Evented, {
// insert a new buffer after the "parent buffer").
var tagName = this.tagName;
- if (tagName === null || tagName === undefined) {
+ if (Ember.isNone(tagName)) {
tagName = 'div';
}
| false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.