language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | 7f2fa488945b3dfb8ebc91560ca6137cee22def0.json | fix nested yield | packages/ember-views/lib/views/component.js | @@ -112,6 +112,7 @@ Ember.Component = Ember.View.extend(Ember.TargetActionSupport, {
view.appendChild(Ember.View, {
isVirtual: true,
tagName: '',
+ _contextView: parentView,
template: get(this, 'template'),
context: get(parentView, 'context'),
controller: get(p... | true |
Other | emberjs | ember.js | 7f2fa488945b3dfb8ebc91560ca6137cee22def0.json | fix nested yield | packages/ember-views/tests/views/component_test.js | @@ -101,4 +101,4 @@ test("Calling sendAction on a component with a context", function() {
component.sendAction('playing', testContext);
strictEqual(actionContext, testContext, "context was sent with the action");
-});
\ No newline at end of file
+}); | true |
Other | emberjs | ember.js | 7c1054cd099831c5806f2e330441664a8f403def.json | Remove stupid suggestion in TODO.
Removing items during willChange prevents run-time coalescing. | packages/ember-runtime/lib/computed/reduce_computed.js | @@ -278,8 +278,6 @@ DependentArraysObserver.prototype = {
Ember.run.once(this, 'flushChanges');
},
- // TODO: it probably makes more sense to remove the item during `willChange`
- // and add it back (with the new value) during `didChange`
flushChanges: function() {
var changedItems = this.changedIte... | false |
Other | emberjs | ember.js | 9cebfdb39d54963a985b0b42d7ee1c8d794daee8.json | Add route name in Route#model hook assertion | packages/ember-routing/lib/system/route.js | @@ -558,7 +558,7 @@ Ember.Route = Ember.Object.extend(Ember.ActionHandler, {
var modelClass = this.container.lookupFactory('model:' + name);
var namespace = get(this, 'router.namespace');
- Ember.assert("You used the dynamic segment " + name + "_id in your route, but " + namespace + "." + classify(name) ... | false |
Other | emberjs | ember.js | a91ecaa646bffa9390f17a9687e9e12a7b27b5c5.json | Add examples for an Ember.Route action handler
- add example for `this` inside action handler
- add example for _super inside action handler
- add example for bubbling action handling via returning true | packages/ember-routing/lib/system/route.js | @@ -76,18 +76,81 @@ Ember.Route = Ember.Object.extend(Ember.ActionHandler, {
this.send('playMusic');
```
+ Within a route's action handler, the value of the `this` context
+ is the Route object:
+
+ ```js
+ App.SongRoute = Ember.Route.extend({
+ actions: {
+ myAction: function() {
+ ... | false |
Other | emberjs | ember.js | ecc80519ed8f7e758d0e91ba8804c08060858e35.json | Update Gemfile.lock for latest ember-dev | Gemfile.lock | @@ -1,6 +1,6 @@
GIT
remote: https://github.com/emberjs/ember-dev.git
- revision: 8ba4efd40d6524d3bd99b662043ac298b27178ea
+ revision: e847d56ee6aa86076471bce65b3505f72682013c
branch: master
specs:
ember-dev (0.1) | false |
Other | emberjs | ember.js | 64cf3a5f18788805c5329e1241bc2648de99cecc.json | Update Gemfile.lock for latest ember-dev | Gemfile.lock | @@ -1,6 +1,6 @@
GIT
remote: https://github.com/emberjs/ember-dev.git
- revision: 8ba4efd40d6524d3bd99b662043ac298b27178ea
+ revision: e847d56ee6aa86076471bce65b3505f72682013c
branch: master
specs:
ember-dev (0.1) | false |
Other | emberjs | ember.js | ba554752ffb83fc21bc8ecb66ac593fcdf6f7a43.json | remove deprecated function (prepare 1.0) | packages/ember-runtime/lib/mixins/evented.js | @@ -116,11 +116,6 @@ Ember.Evented = Ember.Mixin.create({
Ember.sendEvent(this, name, args);
},
- fire: function(name) {
- Ember.deprecate("Ember.Evented#fire() has been deprecated in favor of trigger() for compatibility with jQuery. It will be removed in 1.0. Please update your code to call trigger() ins... | false |
Other | emberjs | ember.js | f0c90f83c5f1da1541e0516331a64ae0b96f76d5.json | Run dist before publishing builds | Rakefile | @@ -156,7 +156,7 @@ namespace :release do
task :deploy => ['ember:release:deploy', 'starter_kit:deploy', 'website:deploy']
end
-task :publish_build do
+task :publish_build => :dist do
root = File.dirname(__FILE__) + '/dist/'
EmberDev::Publish.to_s3({
:access_key_id => ENV['S3_ACCESS_KEY_ID'], | false |
Other | emberjs | ember.js | e1d9534a6440310b3c18d824573e2a2a894b388d.json | Update api docs for {{textarea}}
- make them similar to {{input}}
- provide extended example to show how easy implementing a one way and
two way binding on a textarea can be | packages/ember-handlebars/lib/controls.js | @@ -28,7 +28,7 @@ function normalizeHash(hash, hashTypes) {
## Use as text field
An `{{input}}` with no `type` or a `type` of `text` will render an HTML text input.
The following HTML attributes can be set via the helper:
-
+
* `value`
* `size`
* `name`
@@ -41,7 +41,7 @@ function normalizeHa... | true |
Other | emberjs | ember.js | e1d9534a6440310b3c18d824573e2a2a894b388d.json | Update api docs for {{textarea}}
- make them similar to {{input}}
- provide extended example to show how easy implementing a one way and
two way binding on a textarea can be | packages/ember-handlebars/lib/controls/text_area.js | @@ -10,51 +10,17 @@ require("ember-handlebars/controls/text_support");
var get = Ember.get, set = Ember.set;
/**
- The `Ember.TextArea` view class renders a
- [textarea](https://developer.mozilla.org/en/HTML/Element/textarea) element.
- It allows for binding Ember properties to the text area contents (`value`),
... | true |
Other | emberjs | ember.js | ba1c747b668e23c2fca0e19970f3a042a375a399.json | Use factory superclass in Route#model hook | packages/ember-routing/lib/system/route.js | @@ -547,7 +547,7 @@ Ember.Route = Ember.Object.extend({
if (!name && sawParams) { return params; }
else if (!name) { return; }
- var modelClass = this.container.lookupFactory('model:' + name);
+ var modelClass = this.container.lookupFactory('model:' + name).superclass;
var namespace = get(this, '... | true |
Other | emberjs | ember.js | ba1c747b668e23c2fca0e19970f3a042a375a399.json | Use factory superclass in Route#model hook | packages/ember-routing/tests/system/route_test.js | @@ -17,11 +17,12 @@ test("default model utilizes the container to acquire the model factory", functi
post = {};
- Post = {
+ Post = Ember.Object.extend();
+ Post.reopenClass({
find: function(id) {
return post;
}
- };
+ });
container = {
lookupFactory: lookupFactory
@@ -34,7 +35,7 ... | true |
Other | emberjs | ember.js | ba1c747b668e23c2fca0e19970f3a042a375a399.json | Use factory superclass in Route#model hook | packages/ember/tests/routing/basic_test.js | @@ -2293,3 +2293,23 @@ test("currentRouteName is a property installed on ApplicationController that can
transitionAndCheck('each.other', 'be.excellent.to.each.other', 'each.other');
});
+test("Route model hook finds the same model as a manual find", function() {
+ var Post;
+ App.Post = Ember.Object.extend();
+... | true |
Other | emberjs | ember.js | 447b29466ef7bd0692627340b52ffbb565813040.json | add regression coverage for #3221 [closes #3223] | packages/ember-handlebars/tests/loader_test.js | @@ -1,4 +1,4 @@
-var originalLookup = Ember.lookup, lookup, Tobias;
+var originalLookup = Ember.lookup, lookup, Tobias, App, view;
module("test Ember.Handlebars.bootstrap", {
setup: function() {
@@ -7,6 +7,8 @@ module("test Ember.Handlebars.bootstrap", {
teardown: function() {
Ember.TEMPLATES = {};
E... | false |
Other | emberjs | ember.js | ef955e7a9c9c7dee6de37029aac83901e69e0888.json | Remove some commented test code. | packages/ember-handlebars/tests/controls/text_area_test.js | @@ -252,47 +252,3 @@ test("should call the cancel method when escape key is pressed", function() {
textArea.trigger('keyUp', event);
ok(wasCalled, "invokes cancel method");
});
-
-// test("listens for focus and blur events", function() {
-// var focusCalled = 0;
-// var blurCalled = 0;
-
-// textArea.focus... | true |
Other | emberjs | ember.js | ef955e7a9c9c7dee6de37029aac83901e69e0888.json | Remove some commented test code. | packages/ember-handlebars/tests/controls/text_field_test.js | @@ -450,47 +450,3 @@ test("bubbling of handled actions can be enabled via bubbles property", function
textField.trigger('keyUp', event);
equal(stopPropagationCount, 1, "propagation was prevented if bubbles is false");
});
-
-// test("listens for focus and blur events", function() {
-// var focusCalled = 0;
-//... | true |
Other | emberjs | ember.js | ef955e7a9c9c7dee6de37029aac83901e69e0888.json | Remove some commented test code. | packages/ember-handlebars/tests/handlebars_test.js | @@ -529,41 +529,40 @@ test("Template updates correctly if a path is passed to the bind helper", functi
equal(view.$('h1').text(), "$6", "updates when parent property changes");
});
-// test("Template updates correctly if a path is passed to the bind helper and the context object is an Ember.ObjectController", fun... | true |
Other | emberjs | ember.js | ef955e7a9c9c7dee6de37029aac83901e69e0888.json | Remove some commented test code. | packages/ember-runtime/tests/legacy_1x/mixins/observable/observable_test.js | @@ -273,10 +273,6 @@ test("should change normal properties and return this", function() {
test("should call computed properties passing value and return this", function() {
var ret = object.set("computed", "changed") ;
equal(object._computed, "changed") ;
-
- // DISABLED: this is no longer true with accessors
-... | true |
Other | emberjs | ember.js | ef955e7a9c9c7dee6de37029aac83901e69e0888.json | Remove some commented test code. | packages/ember/tests/routing/basic_test.js | @@ -946,9 +946,6 @@ asyncTest("Events are triggered on the current state", function() {
container.register('controller:home', Ember.Controller.extend());
- //var controller = router._container.controller.home = Ember.Controller.create();
- //controller.target = router;
-
handleURL('/');
var actionId = ... | true |
Other | emberjs | ember.js | 30a6eae2518f7e0181d2705d44a02deaa5bad281.json | Change docs to mention `setUnknownProperty`
The docs incorrectly said that `unknownProperty` would be called when setting an unknown property. | packages/ember-metal/lib/property_set.js | @@ -10,7 +10,7 @@ var META_KEY = Ember.META_KEY,
/**
Sets the value of a property on an object, respecting computed properties
and notifying observers and other listeners of the change. If the
- property is not defined but the object implements the `unknownProperty`
+ property is not defined but the object imp... | true |
Other | emberjs | ember.js | 30a6eae2518f7e0181d2705d44a02deaa5bad281.json | Change docs to mention `setUnknownProperty`
The docs incorrectly said that `unknownProperty` would be called when setting an unknown property. | packages/ember-metal/tests/accessors/set_test.js | @@ -25,7 +25,7 @@ test('should call setUnknownProperty if defined and value is undefined', functio
count: 0,
unknownProperty: function(key, value) {
- ok(false, 'should not invoke unknownProperty is setUnknownProperty is defined');
+ ok(false, 'should not invoke unknownProperty if setUnknownProper... | true |
Other | emberjs | ember.js | 30a6eae2518f7e0181d2705d44a02deaa5bad281.json | Change docs to mention `setUnknownProperty`
The docs incorrectly said that `unknownProperty` would be called when setting an unknown property. | packages/ember-runtime/lib/mixins/observable.js | @@ -149,7 +149,7 @@ Ember.Observable = Ember.Mixin.create({
This method is generally very similar to calling `object[key] = value` or
`object.key = value`, except that it provides support for computed
- properties, the `unknownProperty()` method and property observers.
+ properties, the `setUnknownPro... | true |
Other | emberjs | ember.js | 7fb13eb533bec382278b4a3e665dfe6af6bc386e.json | Remove Ember.Button from YUIDoc output. | packages/ember-handlebars/lib/controls/button.js | @@ -1,13 +1,13 @@
require('ember-runtime/mixins/target_action_support');
-/**
+/*
@module ember
@submodule ember-handlebars
*/
var get = Ember.get, set = Ember.set;
-/**
+/*
@class Button
@namespace Ember
@extends Ember.View
@@ -24,7 +24,7 @@ Ember.Button = Ember.View.extend(Ember.TargetActionSuppor... | false |
Other | emberjs | ember.js | faed7a64417f5712ad356289a3c0b2068c50bf4e.json | simplify emptyView and itemViewClass lookups. | packages/ember-views/lib/views/collection_view.js | @@ -301,16 +301,13 @@ Ember.CollectionView = Ember.ContainerView.extend(/** @scope Ember.CollectionVie
addedViews = [], view, item, idx, len;
if ('string' === typeof itemViewClass) {
- var newItemViewClass = get(itemViewClass);
- if (!newItemViewClass) {
- newItemViewClass = this.contai... | false |
Other | emberjs | ember.js | 4ce4b1fc613db57740bcf0e3c8fbde358f784757.json | Sync router.js - Closes #3153 | packages/ember-routing/lib/vendor/router.js | @@ -937,8 +937,8 @@ define("router",
.then(handleAbort)
.then(afterModel)
.then(handleAbort)
- .then(proceed)
- .then(null, handleError);
+ .then(null, handle... | false |
Other | emberjs | ember.js | 58adbb5c504f8abe8ae5a7fe293cd97ee749cda6.json | Add currentRouteName to ApplicationController
`currentRouteName`, unlike `currentPath`, can always be used as a target route
name within `linkTo` and `transitionTo` even for nested routes.
Closes #2812 | packages/ember-routing/lib/system/router.js | @@ -56,10 +56,12 @@ Ember.Router = Ember.Object.extend({
var appController = this.container.lookup('controller:application'),
path = Ember.Router._routePath(infos);
- if (!('currentPath' in appController)) {
- defineProperty(appController, 'currentPath');
- }
+ if (!('currentPath' in appCo... | true |
Other | emberjs | ember.js | 58adbb5c504f8abe8ae5a7fe293cd97ee749cda6.json | Add currentRouteName to ApplicationController
`currentRouteName`, unlike `currentPath`, can always be used as a target route
name within `linkTo` and `transitionTo` even for nested routes.
Closes #2812 | packages/ember/tests/routing/basic_test.js | @@ -2252,3 +2252,44 @@ test("Events can be handled by inherited event handlers", function() {
router.send("baz");
});
+test("currentRouteName is a property installed on ApplicationController that can be used in transitionTo", function() {
+
+ expect(24);
+
+ Router.map(function() {
+ this.resource("be", func... | true |
Other | emberjs | ember.js | 366e995e930713d96f6df508affc35f6db277d2d.json | Fix typos in Ember.Enumerable deprecations | packages/ember-runtime/lib/mixins/enumerable.js | @@ -308,7 +308,7 @@ Ember.Enumerable = Ember.Mixin.create({
@method mapProperty
@param {String} key name of the property
@return {Array} The mapped array.
- @deprecated User `filterBy` instead Use `mapBy` instead
+ @deprecated Use `mapBy` instead
*/
mapProperty: Ember.aliasMethod('mapBy'),
... | false |
Other | emberjs | ember.js | 39d6bd88ae6ad0d465aec6dd6636ffd07d32a3c2.json | Change didInit event to just init | packages/ember-runtime/lib/system/core_object.js | @@ -123,7 +123,7 @@ function makeCtor() {
m.proto = proto;
finishChains(this);
this.init.apply(this, arguments);
- sendEvent(this, "didInit");
+ sendEvent(this, "init");
};
Class.toString = Mixin.prototype.toString; | true |
Other | emberjs | ember.js | 39d6bd88ae6ad0d465aec6dd6636ffd07d32a3c2.json | Change didInit event to just init | packages/ember-runtime/tests/system/object/create_test.js | @@ -167,15 +167,15 @@ test("Calls all mixin inits if defined", function() {
equal(completed, 2, 'should have called init for both mixins.');
});
-test("Triggers didInit", function() {
+test("Triggers init", function() {
var completed = false;
var obj = Ember.Object.createWithMixins({
- markAsCompleted: E... | true |
Other | emberjs | ember.js | d47b71885effb93a4a78a4024cea22de40875b72.json | Use a single array for actions.
Eliminate array creation for each listener added. | packages/ember-metal/lib/events.js | @@ -24,7 +24,7 @@ var o_create = Ember.create,
{
listeners: { // variable name: `listenerSet`
"foo:changed": [ // variable name: `actions`
- [target, method, flags]
+ target, method, flags
]
}
}
@@ -33,8 +33,8 @@ var o_create = Ember.crea... | true |
Other | emberjs | ember.js | d47b71885effb93a4a78a4024cea22de40875b72.json | Use a single array for actions.
Eliminate array creation for each listener added. | packages/ember-metal/tests/events_test.js | @@ -200,7 +200,7 @@ test('while suspended, it should not be possible to add a duplicate listener', f
Ember._suspendListener(obj, 'event!', target, target.method, callback);
equal(target.count, 1, 'should invoke');
- equal(Ember.meta(obj).listeners['event!'].length, 1, "a duplicate listener wasn't added");
+ e... | true |
Other | emberjs | ember.js | 0d62733f3089fe35ecbfb497320116d2372e9ef6.json | Fix crazy grammar. | packages/ember-application/lib/system/resolver.js | @@ -243,9 +243,10 @@ Ember.DefaultResolver = Ember.Object.extend({
factory = get(parsedName.root, className);
if (factory) { return factory; }
},
+
/**
Returns a human-readable description for a fullName. Used by the
- Application namespace in assertions to assertions to describe the
+ Ap... | false |
Other | emberjs | ember.js | 9b442d5205913ef3e58d4c653950bbdf03e60453.json | Add examples to the Ember.NativeArray docs | packages/ember-runtime/lib/system/native_array.js | @@ -123,7 +123,26 @@ Ember.NativeArray = NativeArray;
/**
Creates an `Ember.NativeArray` from an Array like object.
- Does not modify the original object.
+ Does not modify the original object. Ember.A is not needed if
+ `Ember.EXTEND_PROTOTYPES` is `true` (the default value). However,
+ it is recommended tha... | false |
Other | emberjs | ember.js | 8008c82cae5910586f2c5747ae79ea6152dcd05e.json | Add example to the View#disconnectOutlet docs | packages/ember-routing/lib/ext/view.js | @@ -21,10 +21,24 @@ Ember.View.reopen({
Allows you to connect a unique view as the parent
view's `{{outlet}}`.
+ Example
+
```javascript
+ var MyView = Ember.View.extend({
+ template: Ember.Handlebars.compile('Child view: {{outlet "main"}} ')
+ });
+ var myView = MyView.create(... | false |
Other | emberjs | ember.js | b0c6394ac68035298dd437a8d97387e034776d5d.json | Add examples to the Ember.computed docs | packages/ember-metal/lib/computed.js | @@ -467,6 +467,25 @@ function registerComputedWithProperties(name, macro) {
}
/**
+ A computed property that returns true of the value of the dependent
+ property is null, an empty string, empty array, or empty function.
+
+ Note: When using `Ember.computed.empty` to watch an array make sure to
+ use the `array... | false |
Other | emberjs | ember.js | 9ebb56e43184eed021a2059be08b58d9f8431e0e.json | Add examples to the Ember.Route docs | packages/ember-routing/lib/system/route.js | @@ -212,9 +212,30 @@ Ember.Route = Ember.Object.extend({
route in question. The model will be serialized into the URL
using the `serialize` hook.
+ Example
+
+ ```javascript
+ App.Router.map(function() {
+ this.route("index");
+ this.route("secret");
+ this.route("fourOhFour", { path... | false |
Other | emberjs | ember.js | a1080d93578b6cae80819fd96f3429536c542e18.json | Fix YUIDoc warning: ignore private function. | packages/ember-testing/lib/support.js | @@ -23,7 +23,7 @@ function testCheckboxClick(handler) {
}
$(function() {
- /**
+ /*
Determine whether a checkbox checked using jQuery's "click" method will have
the correct value for its checked property.
| false |
Other | emberjs | ember.js | e05c26b6f889bcee5c20115ad31dcaad163f1027.json | Add additional packages to doc generation. | docs/yuidoc.json | @@ -13,7 +13,9 @@
"../packages/ember-views/lib",
"../packages/ember-handlebars/lib",
"../packages/ember-routing/lib",
- "../packages/ember-application/lib"
+ "../packages/ember-application/lib",
+ "../packages/ember-testing/lib",
+ "../packages/ember-handlebars-compiler/lib"
... | false |
Other | emberjs | ember.js | 1745e57010f3807c2aec8cab43c280fe28723237.json | Add example for setProperties | packages/ember-metal/lib/set_properties.js | @@ -9,6 +9,14 @@ var changeProperties = Ember.changeProperties,
a single `beginPropertyChanges` and `endPropertyChanges` batch, so
observers will be buffered.
+ ```javascript
+ anObject.setProperties({
+ firstName: "Stanley",
+ lastName: "Stuart",
+ age: "21"
+ })
+ ```
+
@method setProperties
... | false |
Other | emberjs | ember.js | 3ef443b42171ddad81829032caa9bd733729f3ae.json | Improve example for {{loc}} | packages/ember-handlebars/lib/helpers/loc.js | @@ -8,15 +8,24 @@ require('ember-handlebars/ext');
/**
`loc` looks up the string in the localized strings hash.
This is a convenient way to localize text. For example:
+
+ ```javascript
+ App.ApplicationController = Ember.Controller.extend({
+ welcomeMessage: '_Hello World'
+ });
- ```html
- <script ... | false |
Other | emberjs | ember.js | a13e9894a027b28b9ad05bde62d103acb881532f.json | Remove globals from Ember.Select documentation | packages/ember-handlebars/lib/controls/select.js | @@ -94,11 +94,13 @@ Ember.SelectOptgroup = Ember.CollectionView.extend({
Example:
```javascript
- App.names = ["Yehuda", "Tom"];
+ App.ApplicationController = Ember.Controller.extend({
+ names: ["Yehuda", "Tom"]
+ });
```
```handlebars
- {{view Ember.Select contentBinding="App.names"}}
+ {{view ... | false |
Other | emberjs | ember.js | ca04bee6c8c43140d5cad2307ce6fbafeb5d9488.json | Add Ember.on, Function.prototype.on, didInit event
This commit adds `Ember.on(eventName, func)` and `Function.prototype.on`
as cousins to `Ember.observes` and `Function.prototype.observes`. This
provides a declarative form of marking methods to execute when an event
fires.
This is useful for mixins which need to do t... | packages/ember-metal/lib/events.js | @@ -9,6 +9,7 @@ require('ember-metal/utils');
var o_create = Ember.create,
metaFor = Ember.meta,
META_KEY = Ember.META_KEY,
+ a_slice = [].slice,
/* listener flags */
ONCE = 1, SUSPENDED = 2;
@@ -368,6 +369,31 @@ function listenersFor(obj, eventName) {
return ret;
}
+/**
+ Define a prop... | true |
Other | emberjs | ember.js | ca04bee6c8c43140d5cad2307ce6fbafeb5d9488.json | Add Ember.on, Function.prototype.on, didInit event
This commit adds `Ember.on(eventName, func)` and `Function.prototype.on`
as cousins to `Ember.observes` and `Function.prototype.observes`. This
provides a declarative form of marking methods to execute when an event
fires.
This is useful for mixins which need to do t... | packages/ember-metal/lib/mixin.js | @@ -178,7 +178,7 @@ function addNormalizedProperty(base, key, value, meta, descs, values, concats, m
// impl super if needed...
if (isMethod(value)) {
value = giveMethodSuper(base, key, value, values, descs);
- } else if ((concats && a_indexOf.call(concats, key) >= 0) ||
+ } else if ((concats &&... | true |
Other | emberjs | ember.js | ca04bee6c8c43140d5cad2307ce6fbafeb5d9488.json | Add Ember.on, Function.prototype.on, didInit event
This commit adds `Ember.on(eventName, func)` and `Function.prototype.on`
as cousins to `Ember.observes` and `Function.prototype.observes`. This
provides a declarative form of marking methods to execute when an event
fires.
This is useful for mixins which need to do t... | packages/ember-metal/lib/utils.js | @@ -321,6 +321,7 @@ Ember.wrap = function(func, superFunc) {
superWrapper.wrappedFunction = func;
superWrapper.__ember_observes__ = func.__ember_observes__;
superWrapper.__ember_observesBefore__ = func.__ember_observesBefore__;
+ superWrapper.__ember_listens__ = func.__ember_listens__;
return superWrappe... | true |
Other | emberjs | ember.js | ca04bee6c8c43140d5cad2307ce6fbafeb5d9488.json | Add Ember.on, Function.prototype.on, didInit event
This commit adds `Ember.on(eventName, func)` and `Function.prototype.on`
as cousins to `Ember.observes` and `Function.prototype.observes`. This
provides a declarative form of marking methods to execute when an event
fires.
This is useful for mixins which need to do t... | packages/ember-metal/tests/events_test.js | @@ -211,3 +211,47 @@ test('while suspended, it should not be possible to add a duplicate listener', f
equal(target.count, 2, 'should have invoked again');
equal(Ember.meta(obj).listeners['event!'].length, 1, "a duplicate listener wasn't added");
});
+
+test('a listener can be added as part of a mixin', function(... | true |
Other | emberjs | ember.js | ca04bee6c8c43140d5cad2307ce6fbafeb5d9488.json | Add Ember.on, Function.prototype.on, didInit event
This commit adds `Ember.on(eventName, func)` and `Function.prototype.on`
as cousins to `Ember.observes` and `Function.prototype.observes`. This
provides a declarative form of marking methods to execute when an event
fires.
This is useful for mixins which need to do t... | packages/ember-runtime/lib/ext/function.js | @@ -86,7 +86,7 @@ if (Ember.EXTEND_PROTOTYPES === true || Ember.EXTEND_PROTOTYPES.Function) {
});
```
- See `Ember.Observable.observes`.
+ See `Ember.observes`.
@method observes
@for Function
@@ -113,7 +113,7 @@ if (Ember.EXTEND_PROTOTYPES === true || Ember.EXTEND_PROTOTYPES.Function) {
... | true |
Other | emberjs | ember.js | ca04bee6c8c43140d5cad2307ce6fbafeb5d9488.json | Add Ember.on, Function.prototype.on, didInit event
This commit adds `Ember.on(eventName, func)` and `Function.prototype.on`
as cousins to `Ember.observes` and `Function.prototype.observes`. This
provides a declarative form of marking methods to execute when an event
fires.
This is useful for mixins which need to do t... | packages/ember-runtime/lib/system/core_object.js | @@ -19,6 +19,7 @@ var set = Ember.set, get = Ember.get,
meta = Ember.meta,
rewatch = Ember.rewatch,
finishChains = Ember.finishChains,
+ sendEvent = Ember.sendEvent,
destroy = Ember.destroy,
schedule = Ember.run.schedule,
Mixin = Ember.Mixin,
@@ -122,6 +123,7 @@ function makeCtor() {
... | true |
Other | emberjs | ember.js | ca04bee6c8c43140d5cad2307ce6fbafeb5d9488.json | Add Ember.on, Function.prototype.on, didInit event
This commit adds `Ember.on(eventName, func)` and `Function.prototype.on`
as cousins to `Ember.observes` and `Function.prototype.observes`. This
provides a declarative form of marking methods to execute when an event
fires.
This is useful for mixins which need to do t... | packages/ember-runtime/tests/ext/function_test.js | @@ -29,3 +29,53 @@ testBoth('global observer helper takes multiple params', function(get, set) {
equal(get(obj, 'count'), 2, 'should invoke observer after change');
});
+module('Function.prototype.on() helper');
+
+testBoth('sets up an event listener, and can trigger the function on multiple events', function(get... | true |
Other | emberjs | ember.js | ca04bee6c8c43140d5cad2307ce6fbafeb5d9488.json | Add Ember.on, Function.prototype.on, didInit event
This commit adds `Ember.on(eventName, func)` and `Function.prototype.on`
as cousins to `Ember.observes` and `Function.prototype.observes`. This
provides a declarative form of marking methods to execute when an event
fires.
This is useful for mixins which need to do t... | packages/ember-runtime/tests/system/object/create_test.js | @@ -167,6 +167,17 @@ test("Calls all mixin inits if defined", function() {
equal(completed, 2, 'should have called init for both mixins.');
});
+test("Triggers didInit", function() {
+ var completed = false;
+ var obj = Ember.Object.createWithMixins({
+ markAsCompleted: Ember.on("didInit", function(){
+ ... | true |
Other | emberjs | ember.js | a5ee696e1f8ba277483c2e0ada3799ec880051ed.json | Explain groupedRows option in #each helper | packages/ember-handlebars/lib/helpers/each.js | @@ -308,13 +308,57 @@ GroupedEach.prototype = {
Each itemController will receive a reference to the current controller as
a `parentController` property.
+ ### (Experimental) Grouped Each
+
+ When used in conjunction with the experimental [group helper](https://github.com/emberjs/group-helper),
+ you can info... | false |
Other | emberjs | ember.js | 988b7aed307399358d762468b13ea3ce07ccf53b.json | remove unnecessary code in loader.js | packages/loader/lib/main.js | @@ -22,7 +22,6 @@ var define, requireModule;
deps = mod.deps;
callback = mod.callback;
reified = [];
- exports;
for (var i=0, l=deps.length; i<l; i++) {
if (deps[i] === 'exports') { | false |
Other | emberjs | ember.js | 268705d6f0769e8b578e0e9f5052f78a6623d07d.json | Remove dead method `Route#deserialize`
`Ember.Route#deserialize` is not called anywhere. | packages/ember/tests/helpers/link_to_test.js | @@ -375,10 +375,6 @@ test("The {{linkTo}} helper moves into the named route with context", function()
App.ItemRoute = Ember.Route.extend({
serialize: function(object) {
return { id: object.id };
- },
-
- deserialize: function(params) {
- return { id: params.id, name: people[params.id] };
... | false |
Other | emberjs | ember.js | 9c1a911eac841296fc483f8a26114c19f0151ae5.json | Fix RC7 version number. | packages/ember-metal/lib/core.js | @@ -49,10 +49,10 @@ Ember.toString = function() { return "Ember"; };
/**
@property VERSION
@type String
- @default '1.0.0-rc.7.1'
+ @default '1.0.0-rc.7'
@final
*/
-Ember.VERSION = '1.0.0-rc.7.1';
+Ember.VERSION = '1.0.0-rc.7';
/**
Standard environmental variables. You can define these in a global `E... | false |
Other | emberjs | ember.js | a6d5f9574d32f3920f4dd738b8b90ca1667d9d58.json | Add rel attribute binding to linkTo helper | packages/ember-routing/lib/helpers/link_to.js | @@ -62,6 +62,14 @@ Ember.onLoad('Ember.Handlebars', function(Handlebars) {
**/
title: null,
+ /**
+ Sets the `rel` attribute of the `LinkView`'s HTML element.
+
+ @property rel
+ @default null
+ **/
+ rel: null,
+
/**
The CSS class to apply to `LinkView`'s element when it... | true |
Other | emberjs | ember.js | a6d5f9574d32f3920f4dd738b8b90ca1667d9d58.json | Add rel attribute binding to linkTo helper | packages/ember/tests/helpers/link_to_test.js | @@ -414,14 +414,16 @@ test("The {{linkTo}} helper moves into the named route with context", function()
});
test("The {{linkTo}} helper binds some anchor html tag common attributes", function() {
- Ember.TEMPLATES.index = Ember.Handlebars.compile("<h3>Home</h3>{{#linkTo 'index' id='self-link' title='title-attr'}}Se... | true |
Other | emberjs | ember.js | 11cfa1f8f664197531758d1849557b4522dd0771.json | Add Ember.DataAdapter in ember-extension-support | Assetfile | @@ -4,7 +4,7 @@ distros = {
"runtime" => %w(ember-metal rsvp container ember-runtime),
"template-compiler" => %w(ember-handlebars-compiler),
"data-deps" => %w(ember-metal rsvp container ember-runtime ember-states),
- "full" => %w(ember-metal rsvp container ember-runtime ember-vi... | true |
Other | emberjs | ember.js | 11cfa1f8f664197531758d1849557b4522dd0771.json | Add Ember.DataAdapter in ember-extension-support | ember-dev.yml | @@ -34,6 +34,7 @@ testing_packages:
- ember-routing
- ember-application
- ember
+ - ember-extension-support
- ember-testing
testing_additional_requires:
- ember-debug | true |
Other | emberjs | ember.js | 11cfa1f8f664197531758d1849557b4522dd0771.json | Add Ember.DataAdapter in ember-extension-support | packages/ember-extension-support/lib/data_adapter.js | @@ -0,0 +1,424 @@
+/**
+@module ember
+@submodule ember-extension-support
+*/
+
+require('ember-application');
+
+/**
+ The `DataAdapter` helps a data persistence library
+ interface with tools that debug Ember such
+ as the Chrome Ember Extension.
+
+ This class will be extended by a persistence library
+ which w... | true |
Other | emberjs | ember.js | 11cfa1f8f664197531758d1849557b4522dd0771.json | Add Ember.DataAdapter in ember-extension-support | packages/ember-extension-support/lib/main.js | @@ -0,0 +1,9 @@
+/**
+Ember Extension Support
+
+@module ember
+@submodule ember-extension-support
+@requires ember-application
+*/
+
+require('ember-extension-support/data_adapter'); | true |
Other | emberjs | ember.js | 11cfa1f8f664197531758d1849557b4522dd0771.json | Add Ember.DataAdapter in ember-extension-support | packages/ember-extension-support/package.json | @@ -0,0 +1,28 @@
+{
+ "name": "ember-extension-support",
+ "summary": "Ember Extension Support",
+ "description": "API for external tools such as the Chrome Ember Extension",
+ "homepage": "http://emberjs.com",
+ "authors": ["Teddy Zeenny"],
+ "version": "1.0.0-rc.6",
+ "dependencies": {
+ "ember-application"... | true |
Other | emberjs | ember.js | 11cfa1f8f664197531758d1849557b4522dd0771.json | Add Ember.DataAdapter in ember-extension-support | packages/ember-extension-support/tests/data_adapter_test.js | @@ -0,0 +1,161 @@
+var adapter, App, get = Ember.get,
+ set = Ember.set, Model = Ember.Object.extend();
+
+var DataAdapter = Ember.DataAdapter.extend({
+ detect: function(klass) {
+ return klass !== Model && Model.detect(klass);
+ }
+});
+
+module("Data Adapter", {
+ setup:function() {
+ Ember.run(function(... | true |
Other | emberjs | ember.js | 2cb3f3fed24ba32e906a54568ecd7f9bedafadf5.json | Remove unused property
`Ember.CoreObject#isInstance` is referenced from only test code. | packages/ember-runtime/lib/system/core_object.js | @@ -165,8 +165,6 @@ CoreObject.PrototypeMixin = Mixin.create({
return this;
},
- isInstance: true,
-
/**
An overridable method called when objects are instantiated. By default,
does nothing unless it is overridden during class definition. | true |
Other | emberjs | ember.js | 2cb3f3fed24ba32e906a54568ecd7f9bedafadf5.json | Remove unused property
`Ember.CoreObject#isInstance` is referenced from only test code. | packages/ember-runtime/tests/system/object/extend_test.js | @@ -5,7 +5,6 @@ test('Basic extend', function() {
ok(SomeClass.isClass, "A class has isClass of true");
var obj = new SomeClass();
equal(obj.foo, 'BAR');
- ok(obj.isInstance, "An instance of a class has isInstance of true");
});
test('Sub-subclass', function() { | true |
Other | emberjs | ember.js | 5f014971b1c92894b67a0456828f688861ac430c.json | Fix some docs | packages/ember-runtime/lib/system/core_object.js | @@ -309,6 +309,8 @@ CoreObject.PrototypeMixin = Mixin.create({
/**
Override to implement teardown.
+
+ @method willDestroy
*/
willDestroy: Ember.K,
| true |
Other | emberjs | ember.js | 5f014971b1c92894b67a0456828f688861ac430c.json | Fix some docs | packages/ember-views/lib/views/component.js | @@ -99,32 +99,33 @@ Ember.Component = Ember.View.extend(Ember.TargetActionSupport, {
}).property('_parentView'),
/**
- Sends an action to component's controller. A component inherits its
- controller from the context in which it is used.
+ Sends an action to component's controller. A component inherits i... | true |
Other | emberjs | ember.js | 5f014971b1c92894b67a0456828f688861ac430c.json | Fix some docs | packages/ember-views/lib/views/view.js | @@ -961,6 +961,9 @@ Ember.View = Ember.CoreView.extend(
/**
The parent context for this template.
+
+ @method parentContext
+ @return {Ember.View}
*/
parentContext: function() {
var parentView = get(this, '_parentView'); | true |
Other | emberjs | ember.js | 9d051c2a1b751494575fa06b9ebc73af8ed59ac3.json | Add sendAction() to Ember.Component | packages/ember-views/lib/views/component.js | @@ -1,6 +1,6 @@
require("ember-views/views/view");
-var set = Ember.set;
+var get = Ember.get, set = Ember.set, isNone = Ember.isNone;
/**
@module ember
@@ -85,11 +85,65 @@ var set = Ember.set;
@namespace Ember
@extends Ember.View
*/
-Ember.Component = Ember.View.extend({
+Ember.Component = Ember.View.ext... | true |
Other | emberjs | ember.js | 9d051c2a1b751494575fa06b9ebc73af8ed59ac3.json | Add sendAction() to Ember.Component | packages/ember-views/tests/views/component_test.js | @@ -1,3 +1,5 @@
+var get = Ember.get, set = Ember.set;
+
module("Ember.Component");
var Component = Ember.Component.extend();
@@ -11,3 +13,80 @@ test("The controller (target of `action`) of an Ember.Component is itself", func
var control = Component.create();
strictEqual(control, control.get('controller'), "A... | true |
Other | emberjs | ember.js | 56583406394d44c8f9e0c1ac2c9a8a227852c26c.json | fix missed VERSION bump | packages/ember-metal/lib/core.js | @@ -49,10 +49,10 @@ Ember.toString = function() { return "Ember"; };
/**
@property VERSION
@type String
- @default '1.0.0-rc.6'
+ @default '1.0.0-rc.6.1'
@final
*/
-Ember.VERSION = '1.0.0-rc.6';
+Ember.VERSION = '1.0.0-rc.6.1';
/**
Standard environmental variables. You can define these in a global `E... | false |
Other | emberjs | ember.js | 2c9d53c1678ca0a024731265cba34a27ca1ad29b.json | improve readability of some exceptions caught b | packages/ember-testing/lib/adapters.js | @@ -72,6 +72,6 @@ Test.QUnitAdapter = Test.Adapter.extend({
start();
},
exception: function(error) {
- ok(false, error);
+ ok(false, Ember.inspect(error));
}
}); | false |
Other | emberjs | ember.js | 6b6f739ed9df057a62401429167dd14691cdfee5.json | Remove unnecessary assertion for `Ember.inspect`
The assertion for `Ember.inspect` with error object depends on
`Error#toString`.
It returns the value that provided by each environments. | packages/ember-runtime/tests/core/inspect_test.js | @@ -46,7 +46,3 @@ test("date", function() {
ok(inspected.match(/2011/), "The inspected date has its year");
ok(inspected.match(/13:24:11/), "The inspected date has its time");
});
-
-test("error", function() {
- equal(inspect(new Error("Oops")), "Error: Oops");
-}); | false |
Other | emberjs | ember.js | 1af8166a2e53287426aeb06a1cc922a30a58f2f1.json | Improve error message for missing itemView
This commit adds infrastructure for a container to return a
human-readable description for a fullName.
For example, Ember's default container will return App.FooController for
the fullName "controller:foo" (where App is the name of the namespaces).
This paves the way for im... | packages/container/lib/main.js | @@ -318,6 +318,20 @@ define("container",
return this.resolver(fullName) || this.registry.get(fullName);
},
+ /**
+ A hook that can be used to describe how the resolver will
+ attempt to find the factory.
+
+ For example, the default Ember `.describe` returns the full
+ ... | true |
Other | emberjs | ember.js | 1af8166a2e53287426aeb06a1cc922a30a58f2f1.json | Improve error message for missing itemView
This commit adds infrastructure for a container to return a
human-readable description for a fullName.
For example, Ember's default container will return App.FooController for
the fullName "controller:foo" (where App is the name of the namespaces).
This paves the way for im... | packages/ember-application/lib/system/application.js | @@ -696,6 +696,7 @@ Ember.Application.reopenClass({
container.set = Ember.set;
container.normalize = normalize;
container.resolver = resolverFor(namespace);
+ container.describe = container.resolver.describe;
container.optionsForType('view', { singleton: false });
container.optionsForType('t... | true |
Other | emberjs | ember.js | 1af8166a2e53287426aeb06a1cc922a30a58f2f1.json | Improve error message for missing itemView
This commit adds infrastructure for a container to return a
human-readable description for a fullName.
For example, Ember's default container will return App.FooController for
the fullName "controller:foo" (where App is the name of the namespaces).
This paves the way for im... | packages/ember-application/lib/system/resolver.js | @@ -219,5 +219,18 @@ Ember.DefaultResolver = Ember.Object.extend({
var className = classify(parsedName.name) + classify(parsedName.type),
factory = get(parsedName.root, className);
if (factory) { return factory; }
+ },
+
+ lookupDescription: function(name) {
+ var parsedName = this.parseName(nam... | true |
Other | emberjs | ember.js | 1af8166a2e53287426aeb06a1cc922a30a58f2f1.json | Improve error message for missing itemView
This commit adds infrastructure for a container to return a
human-readable description for a fullName.
For example, Ember's default container will return App.FooController for
the fullName "controller:foo" (where App is the name of the namespaces).
This paves the way for im... | packages/ember-handlebars-compiler/lib/main.js | @@ -115,7 +115,7 @@ Ember.Handlebars.helper = function(name, value) {
if (Ember.View.detect(value)) {
Ember.Handlebars.registerHelper(name, function(options) {
- Ember.assert("You can only pass attributes as parameters (not values) to a application-defined helper", arguments.length < 2);
+ Ember.ass... | true |
Other | emberjs | ember.js | 1af8166a2e53287426aeb06a1cc922a30a58f2f1.json | Improve error message for missing itemView
This commit adds infrastructure for a container to return a
human-readable description for a fullName.
For example, Ember's default container will return App.FooController for
the fullName "controller:foo" (where App is the name of the namespaces).
This paves the way for im... | packages/ember-handlebars/lib/helpers/binding.js | @@ -466,7 +466,7 @@ EmberHandlebars.registerHelper('bindAttr', function(options) {
var path = attrs[attr],
normalized;
- Ember.assert(fmt("You must provide a String for a bound attribute, not %@", [path]), typeof path === 'string');
+ Ember.assert(fmt("You must provide an expression as the value o... | true |
Other | emberjs | ember.js | 1af8166a2e53287426aeb06a1cc922a30a58f2f1.json | Improve error message for missing itemView
This commit adds infrastructure for a container to return a
human-readable description for a fullName.
For example, Ember's default container will return App.FooController for
the fullName "controller:foo" (where App is the name of the namespaces).
This paves the way for im... | packages/ember-handlebars/lib/helpers/collection.js | @@ -164,10 +164,10 @@ Ember.Handlebars.registerHelper('collection', function(path, options) {
if (hash.itemView) {
var controller = data.keywords.controller;
- Ember.assert('itemView given, but no container is available', controller && controller.container);
+ Ember.assert('You specified an itemView, bu... | true |
Other | emberjs | ember.js | bfdbf858e25af9bcda3cdc888798532af336eeac.json | Improve assertion for non-Array passed to #each | packages/ember-handlebars/lib/helpers/each.js | @@ -39,6 +39,11 @@ Ember.Handlebars.EachView = Ember.CollectionView.extend(Ember._Metamorph, {
return this._super();
},
+ _assertArrayLike: function(content) {
+ Ember.assert("The value that #each loops over must be an Array. You passed " + content.constructor + ", but it should have been an ArrayControll... | true |
Other | emberjs | ember.js | bfdbf858e25af9bcda3cdc888798532af336eeac.json | Improve assertion for non-Array passed to #each | packages/ember-routing/lib/system/controller_for.js | @@ -21,22 +21,28 @@ Ember.generateController = function(container, controllerName, context) {
if (context && Ember.isArray(context)) {
DefaultController = container.resolve('controller:array');
controller = DefaultController.extend({
+ isGenerated: true,
content: context
});
} else if (... | true |
Other | emberjs | ember.js | bfdbf858e25af9bcda3cdc888798532af336eeac.json | Improve assertion for non-Array passed to #each | packages/ember-views/lib/views/collection_view.js | @@ -227,14 +227,18 @@ Ember.CollectionView = Ember.ContainerView.extend(/** @scope Ember.CollectionVie
var content = get(this, 'content');
if (content) {
- Ember.assert(fmt("an Ember.CollectionView's content must implement Ember.Array. You passed %@", [content]), Ember.Array.detect(content));
+ th... | true |
Other | emberjs | ember.js | 4e380be3ec3b9645b2cafb6152d420dceddf41d2.json | Fix code comment
`Ember.OUT_OF_RANGE_EXCEPTION` is not defined.
It is exist as a private property `OUT_OF_RANGE_EXCEPTION`. | packages/ember-runtime/lib/mixins/mutable_array.js | @@ -100,7 +100,7 @@ Ember.MutableArray = Ember.Mixin.create(Ember.Array, Ember.MutableEnumerable,/**
method. You can pass either a single index, or a start and a length.
If you pass a start and length that is beyond the
- length this method will throw an `Ember.OUT_OF_RANGE_EXCEPTION`
+ length this me... | false |
Other | emberjs | ember.js | b5053d509da397588807c82c5abceeb3629ac19f.json | Remove unused argument for `Ember.Array#objectAt`
`Ember.Array#objectAt` accepts single argument. | packages/ember-runtime/lib/mixins/array.js | @@ -196,7 +196,7 @@ Ember.Array = Ember.Mixin.create(Ember.Enumerable, /** @scope Ember.Array.protot
if (startAt < 0) startAt += len;
for(idx=startAt;idx<len;idx++) {
- if (this.objectAt(idx, true) === object) return idx ;
+ if (this.objectAt(idx) === object) return idx ;
}
return -1;
... | false |
Other | emberjs | ember.js | 9bdd766f9ebbe0c20b4fa7a41dc930f1d821a2b3.json | Add jQuery 1.9 to testing rake task | Gemfile.lock | @@ -1,6 +1,6 @@
GIT
remote: https://github.com/emberjs/ember-dev.git
- revision: b385cc1f6ef56ff5a120b5768a0e3a1259a94cf1
+ revision: 6ed6c8ed4c1d77f053b0e751c9e0259d65465e14
branch: master
specs:
ember-dev (0.1)
@@ -32,7 +32,7 @@ PATH
GEM
remote: https://rubygems.org/
specs:
- aws-sdk (1.11.... | true |
Other | emberjs | ember.js | 9bdd766f9ebbe0c20b4fa7a41dc930f1d821a2b3.json | Add jQuery 1.9 to testing rake task | ember-dev.yml | @@ -17,6 +17,7 @@ testing_suites:
- "EACH_PACKAGE"
- "package=all&jquery=1.7.2&nojshint=true"
- "package=all&jquery=1.8.3&nojshint=true"
+ - "package=all&jquery=1.9.1&nojshint=true"
- "package=all&jquery=git&nojshint=true"
- "package=all&jquery=git2&nojshint=true"
- "package=all&extendp... | true |
Other | emberjs | ember.js | 78f93856c9513edcc9d40e801c1f863d8e536a0c.json | Expose `options` arg in `debugger` HB helper
Without this, you can't look up template data and other important pieces of data. (`arguments` is optimized away in Chrome since the function makes no other reference to it) | packages/ember-handlebars/lib/helpers/debug.js | @@ -41,6 +41,6 @@ Ember.Handlebars.registerHelper('log', function(property, options) {
@for Ember.Handlebars.helpers
@param {String} property
*/
-Ember.Handlebars.registerHelper('debugger', function() {
+Ember.Handlebars.registerHelper('debugger', function(options) {
debugger;
}); | false |
Other | emberjs | ember.js | 4584fafdaf2747c8fb1b92fe2f936cba1051e2c9.json | use Ember.K for consistency
Unless there's a reason behind using just `function() {}`, it seems more reasonable to use Ember.K for consistency | packages/ember-views/lib/views/view.js | @@ -1712,7 +1712,7 @@ Ember.View = Ember.CoreView.extend(
@event willDestroyElement
*/
- willDestroyElement: function() {},
+ willDestroyElement: Ember.K,
/**
@private | false |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/container/lib/main.js | @@ -244,7 +244,7 @@ define("container",
register: function(type, name, factory, options) {
var fullName;
- if (type.indexOf(':') !== -1){
+ if (type.indexOf(':') !== -1) {
options = factory;
factory = name;
fullName = type; | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/container/tests/container_test.js | @@ -89,7 +89,7 @@ test("A registered factory returns true for `has` if an item is registered", fun
equal(container.has('controller:posts'), false, "The `has` method returned false for unregistered factories");
});
-test("A Registered factory can be unregistered, and all cached instances are removed", function(){
... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-application/lib/ext/controller.js | @@ -77,7 +77,7 @@ Ember.ControllerMixin.reopen({
this._super.apply(this, arguments);
// Structure asserts to still do verification but not string concat in production
- if(!verifyDependencies(this)) {
+ if (!verifyDependencies(this)) {
Ember.assert("Missing dependencies", false);
}
}, | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-application/lib/system/application.js | @@ -239,7 +239,7 @@ var Application = Ember.Application = Ember.Namespace.extend(Ember.DeferredMixin
this.scheduleInitialize();
- if ( Ember.LOG_VERSION ) {
+ if (Ember.LOG_VERSION) {
Ember.LOG_VERSION = false; // we only need to see this once per Application#init
Ember.debug('-------------... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-application/lib/system/resolver.js | @@ -202,7 +202,7 @@ Ember.DefaultResolver = Ember.Object.extend({
@protected
@method resolveModel
*/
- resolveModel: function(parsedName){
+ resolveModel: function(parsedName) {
var className = classify(parsedName.name),
factory = get(parsedName.root, className);
| true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-application/tests/system/dependency_injection/custom_resolver_test.js | @@ -1,8 +1,8 @@
var application;
module("Ember.Application Depedency Injection – customResolver",{
- setup: function(){
- function fallbackTemplate(){ return "<h1>Fallback</h1>"; }
+ setup: function() {
+ function fallbackTemplate() { return "<h1>Fallback</h1>"; }
var resolver = Ember.DefaultResolver... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-application/tests/system/dependency_injection/default_resolver_test.js | @@ -1,14 +1,14 @@
var locator, application, lookup, originalLookup;
module("Ember.Application Depedency Injection", {
- setup: function(){
+ setup: function() {
originalLookup = Ember.lookup;
application = Ember.run(Ember.Application, 'create');
locator = application.__container__;
},
- tea... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-application/tests/system/dependency_injection_test.js | @@ -3,7 +3,7 @@ var locator, originalLookup = Ember.lookup, lookup,
forEach = Ember.ArrayPolyfills.forEach;
module("Ember.Application Depedency Injection", {
- setup: function(){
+ setup: function() {
application = Ember.run(Ember.Application, 'create');
application.Person = Ember.Obj... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-application/tests/system/logging_test.js | @@ -1,19 +1,19 @@
var App, logs, originalLogger;
module("Ember.Application – logging of generated classes", {
- setup: function(){
+ setup: function() {
logs = {};
originalLogger = Ember.Logger.info;
- Ember.Logger.info = function(){
+ Ember.Logger.info = function() {
var fullName = arg... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-application/tests/system/readiness_test.js | @@ -61,7 +61,7 @@ test("Ember.Application's ready event is called right away if jQuery is already
Ember.run(function() {
application = Application.create({ router: false });
- application.then(function(){
+ application.then(function() {
wasResolved++;
});
@@ -82,7 +82,7 @@ test("Ember.Appl... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-application/tests/system/reset_test.js | @@ -23,7 +23,7 @@ test("Brings it's own run-loop if not provided", function() {
application.reset();
- Ember.run(application,'then', function(){
+ Ember.run(application,'then', function() {
ok(true, 'app booted');
});
});
@@ -35,9 +35,9 @@ test("does not bring it's own run loop if one is already provi... | true |
Other | emberjs | ember.js | 239f120583ddc5c30ee96ccb38f6ba7e74f5f9d8.json | fix code styling for consistency | packages/ember-handlebars-compiler/lib/main.js | @@ -11,7 +11,7 @@ var objectCreate = Object.create || function(parent) {
};
var Handlebars = this.Handlebars || (Ember.imports && Ember.imports.Handlebars);
-if(!Handlebars && typeof require === 'function') {
+if (!Handlebars && typeof require === 'function') {
Handlebars = require('handlebars');
}
@@ -208,7 ... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.