language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
emberjs
ember.js
a7bee11b5e358548d20bf842589e8515fea96b71.json
Send custom events in Ember.runLoadHooks.
packages/ember-runtime/lib/system/lazy_load.js
@@ -1,3 +1,5 @@ +/*globals CustomEvent */ + var forEach = Ember.ArrayPolyfills.forEach; /** @@ -49,6 +51,11 @@ Ember.onLoad = function(name, callback) { Ember.runLoadHooks = function(name, object) { loaded[name] = object; + if (typeof window === 'object' && typeof window.dispatchEvent === 'function' && typeo...
true
Other
emberjs
ember.js
a7bee11b5e358548d20bf842589e8515fea96b71.json
Send custom events in Ember.runLoadHooks.
packages/ember-runtime/tests/system/lazy_load_test.js
@@ -1,3 +1,5 @@ +/* globals CustomEvent */ + module("Lazy Loading"); test("if a load hook is registered, it is executed when runLoadHooks are exected", function() { @@ -49,3 +51,18 @@ test("hooks in ENV.EMBER_LOAD_HOOKS['hookName'] get executed", function() { equal(window.ENV.__test_hook_count__, 1, "the objec...
true
Other
emberjs
ember.js
3bcd9bdca42b1398322a9f14588248ff7b870a2b.json
Update CHANGELOG for 1.5.0-beta.2.
CHANGELOG.md
@@ -1,5 +1,13 @@ # Ember Changelog + +### Ember 1.5.0-beta.2 (February 23, 2014) + +* [SECURITY] Ensure that `ember-routing-auto-location` cannot be forced to redirect to another domain. +* [BUGFIX beta] Handle ES6 transpiler errors. +* [BUGFIX beta] Ensure namespaces are cleaned up. +* Many documentation updates. +...
false
Other
emberjs
ember.js
4a250b3b7062e531955bcad3d017f998e60fe75f.json
Remove old reference to RootResponder
packages/ember-handlebars/tests/handlebars_test.js
@@ -876,12 +876,12 @@ test("Child views created using the view helper should have their IDs registered var childView = firstChild(view); var id = childView.$()[0].id; - equal(Ember.View.views[id], childView, 'childView without passed ID is registered with Ember.View.views so that it can properly receive events...
false
Other
emberjs
ember.js
52be8919216abc125d59df0a96c3f51695d1253e.json
Update CHANGELOG for 1.4.0 and 1.5.0-beta.1.
CHANGELOG.md
@@ -1,43 +1,42 @@ # Ember Changelog +### Ember 1.5.0-beta.1 (February 14, 2014) + +* [FEATURE ember-handlebars-log-primitives] +* [FEATURE ember-testing-routing-helpers] +* [FEATURE ember-testing-triggerEvent-helper] +* [FEATURE computed-read-only] +* [FEATURE ember-metal-is-blank] +* [FEATURE ember-eager-url-update...
false
Other
emberjs
ember.js
723495850ba64236f9259d8b3cd3d5e61afbe0cd.json
Fix minor typo: use `packageName` instead of hardcoding it
bin/transpile-packages.js
@@ -95,6 +95,6 @@ ES6Package.prototype = { ['container'].forEach(function(packageName) { - pkg = new ES6Package('container'); + pkg = new ES6Package(packageName); pkg.process(); });
false
Other
emberjs
ember.js
a542ca8a699419247f3c7106278aa53673fccf49.json
prevent ComputedProperty shape from changing
packages/ember-metal/lib/computed.js
@@ -207,6 +207,7 @@ ComputedProperty.prototype = new Ember.Descriptor(); var ComputedPropertyPrototype = ComputedProperty.prototype; ComputedPropertyPrototype._dependentKeys = undefined; ComputedPropertyPrototype._suspended = undefined; +ComputedPropertyPrototype._meta = undefined; if (Ember.FEATURES.isEnabled('c...
false
Other
emberjs
ember.js
690dfdf06f621619540cee333dd3557dfbbc8ac9.json
remove un-needed toString
packages/ember-routing/lib/helpers/action.js
@@ -61,7 +61,7 @@ Ember.onLoad('Ember.Handlebars', function(Handlebars) { }; ActionHelper.registerAction = function(actionNameOrPath, options, allowedKeys) { - var actionId = (++Ember.uuid).toString(); + var actionId = ++Ember.uuid; ActionHelper.registeredActions[actionId] = { eventName: opt...
false
Other
emberjs
ember.js
b6c0341a863a820daac534b4a0c1dbc44e741a10.json
Add 1.4.0-beta.5 to CHANGELOG.md.
CHANGELOG.md
@@ -3,6 +3,13 @@ * [BREAKING CHANGE] `Ember.run.throttle` now supports leading edge execution. To follow industry standard leading edge is the default. * [BUGFIX] Fixed how parentController property of an itemController when nested. Breaking for apps that rely on previous broken behavior of an itemController's `paren...
false
Other
emberjs
ember.js
3dbf2e46d97d71d39cdbda20e19096e7f214fcc4.json
Add automated testing for prod/min builds.
.jshintrc
@@ -31,6 +31,7 @@ "expectDeprecation", "expectNoDeprecation", "ignoreAssertion", + "ignoreDeprecation", // A safe subset of "browser:true": "window", "location", "document", "XMLSerializer",
true
Other
emberjs
ember.js
3dbf2e46d97d71d39cdbda20e19096e7f214fcc4.json
Add automated testing for prod/min builds.
Gemfile.lock
@@ -1,6 +1,6 @@ GIT remote: https://github.com/emberjs/ember-dev.git - revision: 257349f0f123528f558757de1222828540353c24 + revision: afead0cde6fad34b2313f4d4299c040eef5198ed branch: master specs: ember-dev (0.1) @@ -33,7 +33,7 @@ PATH GEM remote: https://rubygems.org/ specs: - aws-sdk (1.32....
true
Other
emberjs
ember.js
3dbf2e46d97d71d39cdbda20e19096e7f214fcc4.json
Add automated testing for prod/min builds.
ember-dev.yml
@@ -12,6 +12,8 @@ testing_suites: - "package=all&extendprototypes=true&nojshint=true&enableoptionalfeatures=true" built: - "package=all&skipPackage=container&dist=build&nojshint=true" # container isn't publicly available in the built version + - "skipPackage=container,ember-testing&dist=min&prod=true" ...
true
Other
emberjs
ember.js
3dbf2e46d97d71d39cdbda20e19096e7f214fcc4.json
Add automated testing for prod/min builds.
packages/ember-application/tests/system/application_test.js
@@ -1,3 +1,5 @@ +/*globals EmberDev */ + var view; var app; var application; @@ -89,7 +91,9 @@ test("acts like a namespace", function() { module("Ember.Application initialization", { teardown: function() { - Ember.run(app, 'destroy'); + if (app) { + Ember.run(app, 'destroy'); + } Ember.TEMPL...
true
Other
emberjs
ember.js
3dbf2e46d97d71d39cdbda20e19096e7f214fcc4.json
Add automated testing for prod/min builds.
packages/ember-application/tests/system/logging_test.js
@@ -1,3 +1,5 @@ +/*globals EmberDev */ + var App, logs, originalLogger; module("Ember.Application – logging of generated classes", { @@ -66,6 +68,11 @@ function visit(path) { } test("log class generation if logging enabled", function() { + if (EmberDev && EmberDev.runningProdBuild){ + ok(true, 'Logging does...
true
Other
emberjs
ember.js
3dbf2e46d97d71d39cdbda20e19096e7f214fcc4.json
Add automated testing for prod/min builds.
packages/ember-handlebars/tests/helpers/view_test.js
@@ -1,3 +1,5 @@ +/*globals EmberDev */ + var view, originalLookup; var container = { @@ -17,7 +19,10 @@ module("Handlebars {{#view}} helper", { teardown: function() { Ember.lookup = originalLookup; - Ember.run(view, 'destroy'); + + if (view) { + Ember.run(view, 'destroy'); + } } }); @@...
true
Other
emberjs
ember.js
3dbf2e46d97d71d39cdbda20e19096e7f214fcc4.json
Add automated testing for prod/min builds.
packages/ember-runtime/tests/system/object/create_test.js
@@ -19,29 +19,32 @@ test("calls computed property setters", function() { equal(o.get('foo'), 'bar'); }); -test("sets up mandatory setters for watched simple properties", function() { - var MyClass = Ember.Object.extend({ - foo: null, - bar: null, - fooDidChange: Ember.observer('foo', function() {}) - }...
true
Other
emberjs
ember.js
3dbf2e46d97d71d39cdbda20e19096e7f214fcc4.json
Add automated testing for prod/min builds.
packages/ember/tests/states_removal_test.js
@@ -1,6 +1,13 @@ +/*globals EmberDev */ + module("ember-states removal"); test("errors occur when attempting to use Ember.StateManager or Ember.State", function() { + if (EmberDev && EmberDev.runningProdBuild){ + ok(true, 'Ember.State & Ember.StateManager are not added to production builds'); + return; + } ...
true
Other
emberjs
ember.js
3dbf2e46d97d71d39cdbda20e19096e7f214fcc4.json
Add automated testing for prod/min builds.
tests/ember_configuration.js
@@ -31,7 +31,8 @@ spade: 'ember-spade.js', build: 'ember.js', prod: 'ember.prod.js', - runtime: 'ember-runtime.js' + runtime: 'ember-runtime.js', + min: 'ember.min.js' };
true
Other
emberjs
ember.js
d45ad5a3dd5cce1b6bdcf9cca863f95bbed17c4e.json
Remove controlID inclusion from mustache
packages/ember-handlebars-compiler/lib/main.js
@@ -215,8 +215,6 @@ Ember.Handlebars.JavaScriptCompiler.prototype.ambiguousBlockValue = function() { stringifyBlockHelperMissing(this.source); }; -var prefix = "ember" + (+new Date()), incr = 1; - /** Rewrite simple mustaches from `{{foo}}` to `{{bind "foo"}}`. This means that all simple mustaches in Ember...
false
Other
emberjs
ember.js
fdfe8495f738c460b0f1595bc8a37a67e568ff0f.json
Define HTML5 fields on input fields. Previously, binding to this many attributes unnecessarily added a significant performance penalty. Now these bindings are setup lazily for values that were not previously defined on the instance.
packages/ember-handlebars/lib/controls/text_area.js
@@ -30,7 +30,7 @@ Ember.TextArea = Ember.Component.extend(Ember.TextSupport, { classNames: ['ember-text-area'], tagName: "textarea", - attributeBindings: ['rows', 'cols', 'name'], + attributeBindings: ['rows', 'cols', 'name', 'selectionEnd', 'selectionStart', 'wrap'], rows: null, cols: null,
true
Other
emberjs
ember.js
fdfe8495f738c460b0f1595bc8a37a67e568ff0f.json
Define HTML5 fields on input fields. Previously, binding to this many attributes unnecessarily added a significant performance penalty. Now these bindings are setup lazily for values that were not previously defined on the instance.
packages/ember-handlebars/lib/controls/text_field.js
@@ -31,7 +31,11 @@ Ember.TextField = Ember.Component.extend(Ember.TextSupport, { classNames: ['ember-text-field'], tagName: "input", - attributeBindings: ['type', 'value', 'size', 'pattern', 'name', 'min', 'max'], + attributeBindings: ['type', 'value', 'size', 'pattern', 'name', 'min', 'max', + ...
true
Other
emberjs
ember.js
fdfe8495f738c460b0f1595bc8a37a67e568ff0f.json
Define HTML5 fields on input fields. Previously, binding to this many attributes unnecessarily added a significant performance penalty. Now these bindings are setup lazily for values that were not previously defined on the instance.
packages/ember-handlebars/lib/controls/text_support.js
@@ -20,7 +20,8 @@ var get = Ember.get, set = Ember.set; Ember.TextSupport = Ember.Mixin.create(Ember.TargetActionSupport, { value: "", - attributeBindings: ['placeholder', 'disabled', 'maxlength', 'tabindex', 'readonly'], + attributeBindings: ['placeholder', 'disabled', 'maxlength', 'tabindex', 'readonly', + ...
true
Other
emberjs
ember.js
46b309c94013e7b04f007652627bdb9bd0841cd7.json
Add templateName documentation for Ember.Route Fixes #4234
packages/ember-routing/lib/system/route.js
@@ -70,6 +70,28 @@ Ember.Route = Ember.Object.extend(Ember.ActionHandler, { */ viewName: null, + /** + The name of the template to use by default when rendering this routes + template. + + This is similar with `viewName`, but is useful when you just want a custom + template without a view. + + `...
false
Other
emberjs
ember.js
e238f68b4f09d06b7b832c6361fba563d74f2c3c.json
upgrade QUnit -> 1.13.0
Gemfile.lock
@@ -1,6 +1,6 @@ GIT remote: https://github.com/emberjs/ember-dev.git - revision: d99ab73e754317fde34b82139edd8c433a845aad + revision: 605e4c54fc6695d9061bc597d5abc9cf8d1de259 branch: master specs: ember-dev (0.1)
false
Other
emberjs
ember.js
4bed6d0e6bdae99574b2af1efb1b86b05f18ec95.json
Simplify code for action helper Functionality remains exactly the same.
packages/ember-routing/lib/helpers/action.js
@@ -275,36 +275,30 @@ Ember.onLoad('Ember.Handlebars', function(Handlebars) { contexts = a_slice.call(arguments, 1, -1); var hash = options.hash, - controller; + controller = options.data.keywords.controller; // create a hash to pass along to registerAction var action = { - ...
false
Other
emberjs
ember.js
d1e07d57ad1bd42d28eeb37b2499b15f4f6eb737.json
Add Array.prototype.filter polyfill. This is currently required (and only used by) the composable-computed-properties feature. If that feature is enabled it will not work in non-ES5 browsers (specifically it is not available in IE8 and lower).
packages/ember-metal/lib/array.js
@@ -70,6 +70,23 @@ var arrayIndexOf = isNativeFunc(Array.prototype.indexOf) ? Array.prototype.index return -1; }; +var arrayFilter = isNativeFunc(Array.prototype.filter) ? Array.prototype.filter : function (fn, context) { + var i, + value, + result = [], + length = this.length; + + for (i = 0; i < length; i+...
false
Other
emberjs
ember.js
91e4ad0b5b4dc2e78898d36aef5381c951d74a10.json
Use an apostrophe to indicate ownership.
packages/ember-views/lib/views/component.js
@@ -43,7 +43,7 @@ var get = Ember.get, set = Ember.set, isNone = Ember.isNone, ```handlebars {{#app-profile person=currentUser}} <p>Admin mode</p> - {{! Executed in the controllers context. }} + {{! Executed in the controller's context. }} {{/app-profile}} ```
false
Other
emberjs
ember.js
a29ee8b87dab1b13024ce5fc8d48d6ced1344f31.json
Update CHANGELOG.md for 1.4.0-beta.3.
CHANGELOG.md
@@ -1,5 +1,11 @@ # Ember Changelog +### Ember 1.4.0-beta.3 (January 20, 2014) + +* Document the send method on Ember.ActionHandler. +* Document Ember.Route #controllerName and #viewName properties. +* Allow jQuery version 1.11 and 2.1. + ### Ember 1.4.0-beta.2 (January 14, 2014) * [BUGFIX] Fix stripping trailing...
false
Other
emberjs
ember.js
b7faf658b4fe136d522ddf2138bf09be6021fe72.json
Fix a couple of document typos in enumerable
packages/ember-runtime/lib/mixins/enumerable.js
@@ -47,13 +47,13 @@ function iter(key, value) { To make your own custom class enumerable, you need two items: 1. You must have a length property. This property should change whenever - the number of items in your enumerable object changes. If you using this + the number of items in your enumerable objec...
false
Other
emberjs
ember.js
a816a017861473d6f19223a2d311f7fe25cc12d8.json
Fix slight documentation typo
packages/ember-routing/lib/system/route.js
@@ -47,7 +47,7 @@ Ember.Route = Ember.Object.extend(Ember.ActionHandler, { /** The name of the view to use by default when rendering this routes template. - When a rendering a template, the route will, by default, determine the + When rendering a template, the route will, by default, determine the ...
false
Other
emberjs
ember.js
6c09effa13fe9aaf0fdc9e7b092a054761cec9a6.json
Allow jQuery version 1.11 and 2.1 Both RC1's of jQuery 1.11 and 2.1 have just been released. (I screwed up last PR)
packages/ember-views/lib/core.js
@@ -8,7 +8,7 @@ if (!jQuery && typeof require === 'function') { jQuery = require('jquery'); } -Ember.assert("Ember Views require jQuery 1.7, 1.8, 1.9, 1.10, or 2.0", jQuery && (jQuery().jquery.match(/^((1\.(7|8|9|10))|2.0)(\.\d+)?(pre|rc\d?)?/) || Ember.ENV.FORCE_JQUERY)); +Ember.assert("Ember Views require jQuer...
false
Other
emberjs
ember.js
a46539776feb938c03407be89ace1b3742fd0379.json
Enable features given a 'go' status. New features as of 2014/01/17: * `ember-testing-routing-helpers` * `ember-testing-triggerEvent-helper` * `computed-read-only` * `ember-metal-is-blank` * `ember-eager-url-update` Also, removed `composable-computed-properties` as it was accidentally commited in another unrelated PR...
features.json
@@ -9,13 +9,13 @@ "ember-routing-named-substates": null, "ember-handlebars-caps-lookup": null, "ember-testing-simple-setup": null, - "ember-testing-routing-helpers": null, - "ember-testing-triggerEvent-helper": null, - "computed-read-only": null, - "composable-computed-properties": true, + ...
false
Other
emberjs
ember.js
bdd9c62b0cf8b2be62291203bd16f2f191f7f00f.json
avoid exception due to console miss on IE 8
packages/ember-metal/lib/logger.js
@@ -13,7 +13,7 @@ function consoleMethod(name) { if (method) { // Older IE doesn't support apply, but Chrome needs it - if (method.apply) { + if (typeof method.apply === 'function') { logToConsole = function() { method.apply(consoleObj, arguments); };
false
Other
emberjs
ember.js
efafb6cdb34d82a6bb65ad21179065d8c06b3a8c.json
Add link to string-parameterize feature.
FEATURES.md
@@ -23,6 +23,8 @@ for a detailed explanation. Transforms a string so that it may be used as part of a 'pretty' / SEO friendly URL. (E.g. `'100 ways Ember.js is better than Angular.'.parameterize(); // '100-ways-emberjs-is-better-than-angular'`) + Added in [#3953](https://github.com/emberjs/ember.js/pull/3953)....
false
Other
emberjs
ember.js
62076a4bc8c2cc257336331289443b9dbd5cb850.json
Add missing links to FEATURES.md.
FEATURES.md
@@ -105,6 +105,8 @@ for a detailed explanation. Enables `Ember.run.bind` which is ember run-loop aware variation of jQuery.proxy. Useful for integrating with 3rd party callbacks. + Added in [161113](https://github.com/emberjs/ember.js/commit/161113a9e5fad7f6dfde09a053166a05660a0051). + * `ember-metal-is-blan...
false
Other
emberjs
ember.js
34d8830064d1ffc731eeb80fdabd25b82b69500e.json
Remove unused variable
packages/ember-runtime/lib/controllers/array_controller.js
@@ -194,7 +194,7 @@ Ember.ArrayController = Ember.ArrayProxy.extend(Ember.ControllerMixin, var container = get(this, 'container'), subControllers = get(this, '_subControllers'), subController = subControllers[idx], - factory, fullName; + fullName; if (subController) { return ...
false
Other
emberjs
ember.js
543dcf910913bebd2b5963593d536573728fc4f1.json
Add missing entries to CHANGELOG.
CHANGELOG.md
@@ -71,6 +71,11 @@ * Components are lazily looked up. * Renaming everyBy and anyBy to isEvery and isAny. +###Ember 1.2.1 _(January 14, 2014)_ + +* [SECURITY] Ensure primitive value contexts are escaped. +* [SECURITY] Ensure {{group}} helper escapes properly. + ###Ember 1.2.0 _(November 22, 2013)_ * [BUGFIX] Pub...
false
Other
emberjs
ember.js
55a30aabc15c92d376d3208d029132740b7a56a9.json
remove unneeded get
packages/ember-handlebars/lib/helpers/each.js
@@ -86,7 +86,7 @@ Ember.Handlebars.EachView = Ember.CollectionView.extend(Ember._Metamorph, { // If {{#each}} is looping over an array of controllers, // point each child view at their respective controller. - if (content && get(content, 'isController')) { + if (content && content.isController) { ...
false
Other
emberjs
ember.js
33c89fc3ff143820cfb0b5629080817c6cb62bd6.json
Add documentation for Ember.EnumerableUtils.
packages/ember-metal/lib/enumerable_utils.js
@@ -7,34 +7,123 @@ indexOf = Array.prototype.indexOf || Ember.ArrayPolyfills.indexOf; filter = Array.prototype.filter || Ember.ArrayPolyfills.filter; splice = Array.prototype.splice; +/** + * Defines some convenience methods for working with Enumerables. + * `Ember.EnumerableUtils` uses `Ember.ArrayPolyfills` when ...
false
Other
emberjs
ember.js
c2afc59bc90844ab6d6367e78523b058b904ef20.json
Update VERSION post-release.
CHANGELOG.md
@@ -1,14 +1,62 @@ # Ember Changelog - -### Ember 1.4.0 _(TBD)_ - -* In canary -* {{#with}} can take a controller= option for wrapping the context. Must be an `Ember.ObjectController` - -### Ember 1.3.0 _(TBD)_ - -* In beta +### Ember 1.4.0-beta.1 (January 6, 2014) + +* Unbound helper supports bound helper static str...
true
Other
emberjs
ember.js
c2afc59bc90844ab6d6367e78523b058b904ef20.json
Update VERSION post-release.
Gemfile.lock
@@ -27,7 +27,7 @@ GIT PATH remote: . specs: - ember-source (1.4.0.beta.1.canary) + ember-source (1.5.0.beta.1.canary) handlebars-source (~> 1.3.0) GEM
true
Other
emberjs
ember.js
c2afc59bc90844ab6d6367e78523b058b904ef20.json
Update VERSION post-release.
VERSION
@@ -1 +1 @@ -1.4.0-beta.1+canary +1.5.0-beta.1+canary
true
Other
emberjs
ember.js
df45fdb43fdf0af775a8f9403c8e718434ca2cdd.json
Remove garbage file
hangover.md
@@ -1,30 +0,0 @@ - - test("routeless transitionTo in mid-transition uses transition's destination route for query params, not the router's current route", function() { - expect(2); - Router.map(function() { - this.resource('woot', { path: '/woot' }, function() { - this.route('yeah'); - }); - ...
false
Other
emberjs
ember.js
147fb6f637dcf788249f622df6f38b591dc81b4d.json
Fix property name in code comment The property name of `Ember.Array#hasArrayObservers` is incorrect.
packages/ember-runtime/lib/mixins/array.js
@@ -300,7 +300,7 @@ Ember.Array = Ember.Mixin.create(Ember.Enumerable, /** @scope Ember.Array.protot Becomes true whenever the array currently has observers watching changes on the array. - @property Boolean + @property {Boolean} hasArrayObservers */ hasArrayObservers: Ember.computed(function() ...
false
Other
emberjs
ember.js
149af8a3f37e1f21929f1365525f1508fb9cf022.json
Remove Vagrant references from CONTRIBUTING.md.
CONTRIBUTING.md
@@ -71,34 +71,6 @@ npm install rake ``` -For those having issues with some of the build tool dependencies, an optional VagrantFile is provided. - -Using Vagrant to build latest version of Ember.js is quite simple. Just -follow these 4 steps: - -1. Install Virtual Box - [Download](https://www.virtualbox.org/wiki/Dow...
false
Other
emberjs
ember.js
d77268b9866f6aff77484c9630b099840000acf4.json
remove cookbooks because we don't have vagrant
cookbooks/build-essential
@@ -1 +0,0 @@ -Subproject commit 0c636536fb1236f792974f3af38f2950a03ed4b2
true
Other
emberjs
ember.js
d77268b9866f6aff77484c9630b099840000acf4.json
remove cookbooks because we don't have vagrant
cookbooks/nodejs
@@ -1 +0,0 @@ -Subproject commit 9e39a20f5c9a08542fc21915aa357672634ce589
true
Other
emberjs
ember.js
d77268b9866f6aff77484c9630b099840000acf4.json
remove cookbooks because we don't have vagrant
cookbooks/phantomjs
@@ -1 +0,0 @@ -Subproject commit b8c40cb48770941f7b09ef11eab0a329db0c7162
true
Other
emberjs
ember.js
ddef9c960a943f3ac81481caf45595a2977f331a.json
Fix typo in `unordered list`
packages/ember-views/lib/views/collection_view.js
@@ -68,15 +68,15 @@ var get = Ember.get, set = Ember.set, fmt = Ember.String.fmt; Given an empty `<body>` and the following code: ```javascript - anUndorderedListView = Ember.CollectionView.create({ + anUnorderedListView = Ember.CollectionView.create({ tagName: 'ul', content: ['A','B','C'], ite...
false
Other
emberjs
ember.js
559fda6d93927b103a6dd02b411b8db5d5125c46.json
Use imported handlebars before global Handlebars Prioritizing the global Handlebars causes problems in environments with multiple versions of Handlebars. One should be able to import a desired version.
packages/ember-handlebars-compiler/lib/main.js
@@ -10,7 +10,7 @@ var objectCreate = Object.create || function(parent) { return new F(); }; -var Handlebars = (this && this.Handlebars) || (Ember.imports && Ember.imports.Handlebars); +var Handlebars = (Ember.imports && Ember.imports.Handlebars) || (this && this.Handlebars); if (!Handlebars && typeof require ===...
false
Other
emberjs
ember.js
8eb4e53a478c086d93d2414114e0bd8704237ecc.json
Add support for min & max on HTML 5 inputs This will allow support of the min & max attributes on the `number` and `range` input types from HTML5.
packages/ember-handlebars/lib/controls/text_field.js
@@ -32,7 +32,7 @@ Ember.TextField = Ember.Component.extend(Ember.TextSupport, classNames: ['ember-text-field'], tagName: "input", - attributeBindings: ['type', 'value', 'size', 'pattern', 'name'], + attributeBindings: ['type', 'value', 'size', 'pattern', 'name', 'min', 'max'], /** The `value` attrib...
false
Other
emberjs
ember.js
2632209ad66c52adbc0f85f6b189382ee53ca83c.json
move Ember.inspect to ember-metal
packages/ember-metal/lib/utils.js
@@ -666,3 +666,38 @@ Ember.typeOf = function(item) { return ret; }; + +/** + Convenience method to inspect an object. This method will attempt to + convert the object into a useful string description. + + It is a pretty simple implementation. If you want something more robust, + use something like JSDump: htt...
true
Other
emberjs
ember.js
2632209ad66c52adbc0f85f6b189382ee53ca83c.json
move Ember.inspect to ember-metal
packages/ember-runtime/lib/core.js
@@ -184,39 +184,6 @@ Ember.copy = function(obj, deep) { return _copy(obj, deep, deep ? [] : null, deep ? [] : null); }; -/** - Convenience method to inspect an object. This method will attempt to - convert the object into a useful string description. - - It is a pretty simple implementation. If you want someth...
true
Other
emberjs
ember.js
2632209ad66c52adbc0f85f6b189382ee53ca83c.json
move Ember.inspect to ember-metal
packages/ember-runtime/tests/core/inspect_test.js
@@ -1,48 +0,0 @@ -module("Ember.inspect"); - -var inspect = Ember.inspect; - -test("strings", function() { - equal(inspect("foo"), "foo"); -}); - -test("numbers", function() { - equal(inspect(2.6), "2.6"); -}); - -test("null", function() { - equal(inspect(null), "null"); -}); - -test("undefined", function() { - equ...
true
Other
emberjs
ember.js
c3c283b6c031031cb7778a48ab88622365b52c59.json
fix emberjs/website#1027 with unique header title
packages/ember-handlebars/lib/helpers/collection.js
@@ -51,7 +51,7 @@ var get = Ember.get, handlebarsGet = Ember.Handlebars.get, fmt = Ember.String.fm </div> ``` - ### Blockless Use + ### Blockless use in a collection If you provide an `itemViewClass` option that has its own `template` you can omit the block.
false
Other
emberjs
ember.js
b18bf88e1e2b16dc7750de3b8d7397c2ada6bf6e.json
remove unnecessary uses of `call` / `apply`
packages/ember-runtime/lib/computed/reduce_computed.js
@@ -731,7 +731,7 @@ ReduceComputedProperty.prototype.property = function () { ```javascript Ember.computed.max = function (dependentKey) { - return Ember.reduceComputed.call(null, dependentKey, { + return Ember.reduceComputed(dependentKey, { initialValue: -Infinity, addedItem: function (ac...
true
Other
emberjs
ember.js
b18bf88e1e2b16dc7750de3b8d7397c2ada6bf6e.json
remove unnecessary uses of `call` / `apply`
packages/ember-runtime/lib/computed/reduce_computed_macros.js
@@ -44,7 +44,7 @@ var get = Ember.get, @return {Ember.ComputedProperty} computes the largest value in the dependentKey's array */ Ember.computed.max = function (dependentKey) { - return Ember.reduceComputed.call(null, dependentKey, { + return Ember.reduceComputed(dependentKey, { initialValue: -Infinity, ...
true
Other
emberjs
ember.js
b18bf88e1e2b16dc7750de3b8d7397c2ada6bf6e.json
remove unnecessary uses of `call` / `apply`
packages/ember-runtime/lib/mixins/enumerable.js
@@ -728,7 +728,7 @@ Ember.Enumerable = Ember.Mixin.create({ var ret = initialValue; this.forEach(function(item, i) { - ret = callback.call(null, ret, item, i, this, reducerProperty); + ret = callback(ret, item, i, this, reducerProperty); }, this); return ret; @@ -751,7 +751,7 @@ Ember....
true
Other
emberjs
ember.js
b18bf88e1e2b16dc7750de3b8d7397c2ada6bf6e.json
remove unnecessary uses of `call` / `apply`
packages/ember-testing/lib/helpers.js
@@ -159,7 +159,7 @@ function wait(app, value) { if (Test.waiters && Test.waiters.any(function(waiter) { var context = waiter[0]; var callback = waiter[1]; - return !callback.apply(context); + return !callback.call(context); })) { return; } } // Sto...
true
Other
emberjs
ember.js
b18bf88e1e2b16dc7750de3b8d7397c2ada6bf6e.json
remove unnecessary uses of `call` / `apply`
packages/ember-testing/lib/test.js
@@ -484,7 +484,7 @@ function isolate(fn, val) { // Reset lastPromise for nested helpers Ember.Test.lastPromise = null; - value = fn.call(null, val); + value = fn(val); lastPromise = Ember.Test.lastPromise;
true
Other
emberjs
ember.js
4d5d0f62c64abb8d47a975035ccfd62cf1b1c86a.json
Remove another duplicate changelog entry.
CHANGELOG.md
@@ -31,7 +31,6 @@ * [BUGFIX] Bubble `loading` action above pivot route * [BUGFIX] reduceComputed ignore changes during reset. * [BUGFIX] reduceComputed handle out-of-range index. -* [BUGFIX] Allow Ember.Object.create to accept an Ember.Object. * [FEATURE] Add support for nested loading/error substates. A loading su...
false
Other
emberjs
ember.js
c2a83893f5df634c0037b8a194c78734ba21ef5f.json
Add a helpful warning Because almost every property on a class definition is a function, it's easy to accidentally say this out of habit: ````javascript App.MyController = Ember.Controller.extend({ actions: function() { doThing: function() { ... } } }); ```` When you meant to say this: ````javascript App...
packages/ember-runtime/lib/mixins/action_handler.js
@@ -32,6 +32,8 @@ Ember.ActionHandler = Ember.Mixin.create({ var hashName; if (!props._actions) { + Ember.assert(this + " 'actions' should not be a function", typeof(props.actions) !== 'function'); + if (typeOf(props.actions) === 'object') { hashName = 'actions'; } else if (typeO...
true
Other
emberjs
ember.js
c2a83893f5df634c0037b8a194c78734ba21ef5f.json
Add a helpful warning Because almost every property on a class definition is a function, it's easy to accidentally say this out of habit: ````javascript App.MyController = Ember.Controller.extend({ actions: function() { doThing: function() { ... } } }); ```` When you meant to say this: ````javascript App...
packages/ember-runtime/tests/mixins/action_handler_test.js
@@ -0,0 +1,13 @@ +test("passing a function for the actions hash triggers an assertion", function() { + expect(1); + + var controller = Ember.Controller.extend({ + actions: function(){} + }); + + expectAssertion(function(){ + Ember.run(function(){ + controller.create(); + }); + }); +});
true
Other
emberjs
ember.js
7b2d76400591a1f2ed066dfe16b97631ff97d6b0.json
Remove duplicate changelog entry.
CHANGELOG.md
@@ -36,7 +36,6 @@ * [FEATURE] Components and helpers registered on the container can be rendered in templates via their dasherized names. E.g. {{helper-name}} or {{component-name}} * [FEATURE] Add a `didTransition` hook to the router. * [FEATURE] Add a non-block form link-to helper. E.g {{link-to "About us" "about"}...
false
Other
emberjs
ember.js
29d75c984fbee48fa93133856ecb3962d1b02963.json
Remove accepted features from FEATURES.md
FEATURES.md
@@ -21,12 +21,6 @@ for a detailed explanation. Added in [#3614](https://github.com/emberjs/ember.js/pull/3614). -* `container-renderables` - - Components and helpers registered on the container can be rendered in templates - via their dasherized names. (E.g. {{helper-name}} or {{component-name}}) - - Added in...
false
Other
emberjs
ember.js
69a7acb83eb60eac6803f8dc96dfa41258a6e473.json
Remove feature flags for 'reduceComputedSelf'.
features.json
@@ -1,5 +1,4 @@ { - "reduceComputedSelf": true, "reduceComputed-non-array-dependencies": null, "ember-testing-wait-hooks": null, "query-params": null,
true
Other
emberjs
ember.js
69a7acb83eb60eac6803f8dc96dfa41258a6e473.json
Remove feature flags for 'reduceComputedSelf'.
packages/ember-runtime/lib/computed/reduce_computed.js
@@ -22,10 +22,8 @@ var e_get = Ember.get, arrayBracketPattern = /\.\[\]$/; function get(obj, key) { - if (Ember.FEATURES.isEnabled('reduceComputedSelf')) { - if (key === '@this') { - return obj; - } + if (key === '@this') { + return obj; } return e_get(obj, key);
true
Other
emberjs
ember.js
69a7acb83eb60eac6803f8dc96dfa41258a6e473.json
Remove feature flags for 'reduceComputedSelf'.
packages/ember-runtime/tests/computed/reduce_computed_test.js
@@ -494,53 +494,51 @@ test("removedItem is not erroneously called for dependent arrays during a recomp }); -if (Ember.FEATURES.isEnabled('reduceComputedSelf')) { - module('Ember.arryComputed - self chains', { - setup: function() { - var a = Ember.Object.create({ name: 'a' }), - b = Ember.Object.c...
true
Other
emberjs
ember.js
69a7acb83eb60eac6803f8dc96dfa41258a6e473.json
Remove feature flags for 'reduceComputedSelf'.
packages/ember-runtime/tests/controllers/item_controller_class_test.js
@@ -280,47 +280,45 @@ test("array observers can invoke `objectAt` without overwriting existing item co equal(tywinController.get('name'), "Tywin", "Array observers calling `objectAt` does not overwrite existing controllers' content"); }); -if (Ember.FEATURES.isEnabled('reduceComputedSelf')) { - module('Ember.Arr...
true
Other
emberjs
ember.js
ba5fc1c24b9e95d3bdf421e173819e6366a31080.json
Remove feature flags for 'link-to-non-block'.
features.json
@@ -1,5 +1,4 @@ { - "link-to-non-block": true, "reduceComputedSelf": true, "reduceComputed-non-array-dependencies": null, "ember-testing-wait-hooks": null,
true
Other
emberjs
ember.js
ba5fc1c24b9e95d3bdf421e173819e6366a31080.json
Remove feature flags for 'link-to-non-block'.
packages/ember-routing/lib/helpers/link_to.js
@@ -186,12 +186,10 @@ Ember.onLoad('Ember.Handlebars', function(Handlebars) { length = paths.length, path, i, normalizedPath; - if (Ember.FEATURES.isEnabled('link-to-non-block')) { - var linkTextPath = helperParameters.options.linkTextPath; - if (linkTextPath) { - nor...
true
Other
emberjs
ember.js
ba5fc1c24b9e95d3bdf421e173819e6366a31080.json
Remove feature flags for 'link-to-non-block'.
packages/ember/tests/helpers/link_to_test.js
@@ -990,147 +990,145 @@ test("The {{link-to}} helper works in an #each'd array of string route names", f linksEqual(Ember.$('a', '#qunit-fixture'), ["/bar", "/rar", "/bar", "/rar", "/rar", "/foo"]); }); -if (Ember.FEATURES.isEnabled('link-to-non-block')) { - test("The non-block form {{link-to}} helper moves into...
true
Other
emberjs
ember.js
5ac30881521199f8886f2fb2f839d019e80e124b.json
Remove feature flags for 'container-renderables'.
features.json
@@ -1,5 +1,4 @@ { - "container-renderables": true, "link-to-non-block": true, "reduceComputedSelf": true, "reduceComputed-non-array-dependencies": null,
true
Other
emberjs
ember.js
5ac30881521199f8886f2fb2f839d019e80e124b.json
Remove feature flags for 'container-renderables'.
packages/ember-application/lib/system/application.js
@@ -736,10 +736,7 @@ Ember.Application.reopenClass({ container.optionsForType('component', { singleton: false }); container.optionsForType('view', { singleton: false }); container.optionsForType('template', { instantiate: false }); - - if (Ember.FEATURES.isEnabled('container-renderables')) { - co...
true
Other
emberjs
ember.js
5ac30881521199f8886f2fb2f839d019e80e124b.json
Remove feature flags for 'container-renderables'.
packages/ember-application/tests/system/dependency_injection/default_resolver_test.js
@@ -58,25 +58,23 @@ test("the default resolver resolves models on the namespace", function() { detectEqual(application.Post, locator.lookupFactory('model:post'), "looks up Post model on application"); }); -if (Ember.FEATURES.isEnabled('container-renderables')) { - test("the default resolver resolves helpers from...
true
Other
emberjs
ember.js
5ac30881521199f8886f2fb2f839d019e80e124b.json
Remove feature flags for 'container-renderables'.
packages/ember-handlebars/lib/ext.js
@@ -145,13 +145,10 @@ Ember.Handlebars.registerHelper('helperMissing', function(path) { var options = arguments[arguments.length - 1]; - if (Ember.FEATURES.isEnabled('container-renderables')) { + var helper = Ember.Handlebars.resolveHelper(options.data.view.container, path); - var helper = Ember.Handlebar...
true
Other
emberjs
ember.js
5ac30881521199f8886f2fb2f839d019e80e124b.json
Remove feature flags for 'container-renderables'.
packages/ember-handlebars/lib/helpers/binding.js
@@ -162,12 +162,9 @@ EmberHandlebars.registerHelper('_triageMustache', function(property, options) { return helpers[property].call(this, options); } - if (Ember.FEATURES.isEnabled('container-renderables')) { - - var helper = Ember.Handlebars.resolveHelper(options.data.view.container, property); - if (h...
true
Other
emberjs
ember.js
5ac30881521199f8886f2fb2f839d019e80e124b.json
Remove feature flags for 'container-renderables'.
packages/ember-handlebars/lib/loader.js
@@ -59,35 +59,6 @@ function bootstrap() { Ember.Handlebars.bootstrap( Ember.$(document) ); } -function registerComponents(container) { - var templates = Ember.TEMPLATES, match; - if (!templates) { return; } - - for (var prop in templates) { - if (match = prop.match(/^components\/(.*)$/)) { - registerCo...
true
Other
emberjs
ember.js
5ac30881521199f8886f2fb2f839d019e80e124b.json
Remove feature flags for 'container-renderables'.
packages/ember/tests/component_registration_test.js
@@ -42,12 +42,10 @@ function boot(callback) { }); } -if (!Ember.FEATURES.isEnabled('container-renderables')) { - test("A helper is registered for templates under the components/ directory", function() { - boot(); - ok(Ember.Handlebars.helpers['expand-it'], "The helper is registered"); - }); -} +test("A he...
true
Other
emberjs
ember.js
5ac30881521199f8886f2fb2f839d019e80e124b.json
Remove feature flags for 'container-renderables'.
packages/ember/tests/helpers/helper_registration_test.js
@@ -5,97 +5,95 @@ function reverseHelper(value) { return arguments.length > 1 ? value.split('').reverse().join('') : "--"; } -if (Ember.FEATURES.isEnabled('container-renderables')) { - - module("Application Lifecycle - Helper Registration", { - teardown: function() { - Ember.run(function() { - App...
true
Other
emberjs
ember.js
f68410e8a0de7033c142c373f9fbfc07fd30a542.json
Remove feature flags for 'ember-runtime-sortBy'.
features.json
@@ -1,5 +1,4 @@ { - "ember-runtime-sortBy": true, "container-renderables": true, "link-to-non-block": true, "reduceComputedSelf": true,
true
Other
emberjs
ember.js
f68410e8a0de7033c142c373f9fbfc07fd30a542.json
Remove feature flags for 'ember-runtime-sortBy'.
packages/ember-runtime/lib/mixins/enumerable.js
@@ -975,35 +975,30 @@ Ember.Enumerable = Ember.Mixin.create({ Ember.propertyDidChange(this, '[]'); return this ; - } - -}); + }, -if (Ember.FEATURES.isEnabled("ember-runtime-sortBy")) { - Ember.Enumerable.reopen({ - /** - Converts the enumerable into an array and sorts by the keys - specif...
true
Other
emberjs
ember.js
f68410e8a0de7033c142c373f9fbfc07fd30a542.json
Remove feature flags for 'ember-runtime-sortBy'.
packages/ember-runtime/tests/suites/enumerable/sortBy.js
@@ -3,20 +3,18 @@ var get = Ember.get; var suite = Ember.EnumerableTests; -if (Ember.FEATURES.isEnabled("ember-runtime-sortBy")) { - suite.module('sortBy'); +suite.module('sortBy'); - suite.test('sort by value of property', function() { - var obj = this.newObject([{a: 2},{a: 1}]), - sorted = obj.sort...
true
Other
emberjs
ember.js
dc3f9d9c68c60cbbfd8abd8c0b2f439eb36aa4c7.json
Fix documentation error Was `Context` and should be `Contact`
packages/ember-runtime/lib/mixins/freezable.js
@@ -46,7 +46,7 @@ var get = Ember.get, set = Ember.set; }); - c = Context.create({ firstName: "John", lastName: "Doe" }); + c = Contact.create({ firstName: "John", lastName: "Doe" }); c.swapNames(); // returns c c.freeze(); c.swapNames(); // EXCEPTION
false
Other
emberjs
ember.js
cf2cd8310084155379dd74b4278b7df472e59bae.json
Remove unused local var from link_to test
packages/ember/tests/helpers/link_to_test.js
@@ -362,12 +362,6 @@ test("The {{link-to}} helper moves into the named route with context", function( Ember.TEMPLATES.about = Ember.Handlebars.compile("<h3>List</h3><ul>{{#each controller}}<li>{{#link-to 'item' this}}{{name}}{{/link-to}}<li>{{/each}}</ul>{{#link-to 'index' id='home-link'}}Home{{/link-to}}"); - ...
false
Other
emberjs
ember.js
3daf93c371f6c3e3ff0838494307071413df8b0b.json
Support HANDLEBARS_PATH for Gemfile This makes it easier for Ember's tests to be run against a development version of Handlebars.
Gemfile
@@ -1,5 +1,9 @@ source "https://rubygems.org" +if ENV['HANDLEBARS_PATH'] + gem "handlebars-source", :path => File.join(ENV['HANDLEBARS_PATH'], "dist", "components") +end + gem "rake-pipeline", :git => "https://github.com/livingsocial/rake-pipeline.git" gem "ember-dev", :git => "https://github.com/emberjs/ember-de...
false
Other
emberjs
ember.js
61c79eae54e3bbc95397f4c1e755493e3933d059.json
Add tests to ensure EXTEND_PROTOYPES is honored.
packages/ember-runtime/tests/system/string/camelize.js
@@ -1,5 +1,11 @@ module('Ember.String.camelize'); +if (!Ember.EXTEND_PROTOTYPES && !Ember.EXTEND_PROTOTYPES.String) { + test("String.prototype.camelize is not modified without EXTEND_PROTOTYPES", function() { + ok("undefined" === typeof String.prototype.camelize, 'String.prototype helper disabled'); + }); +} + ...
true
Other
emberjs
ember.js
61c79eae54e3bbc95397f4c1e755493e3933d059.json
Add tests to ensure EXTEND_PROTOYPES is honored.
packages/ember-runtime/tests/system/string/capitalize.js
@@ -7,6 +7,12 @@ module('Ember.String.capitalize'); +if (!Ember.EXTEND_PROTOTYPES && !Ember.EXTEND_PROTOTYPES.String) { + test("String.prototype.capitalize is not modified without EXTEND_PROTOTYPES", function() { + ok("undefined" === typeof String.prototype.capitalize, 'String.prototype helper disabled'); + }...
true
Other
emberjs
ember.js
61c79eae54e3bbc95397f4c1e755493e3933d059.json
Add tests to ensure EXTEND_PROTOYPES is honored.
packages/ember-runtime/tests/system/string/classify.js
@@ -1,5 +1,11 @@ module('Ember.String.classify'); +if (!Ember.EXTEND_PROTOTYPES && !Ember.EXTEND_PROTOTYPES.String) { + test("String.prototype.classify is not modified without EXTEND_PROTOTYPES", function() { + ok("undefined" === typeof String.prototype.classify, 'String.prototype helper disabled'); + }); +} + ...
true
Other
emberjs
ember.js
61c79eae54e3bbc95397f4c1e755493e3933d059.json
Add tests to ensure EXTEND_PROTOYPES is honored.
packages/ember-runtime/tests/system/string/dasherize.js
@@ -1,5 +1,11 @@ module('Ember.String.dasherize'); +if (!Ember.EXTEND_PROTOTYPES && !Ember.EXTEND_PROTOTYPES.String) { + test("String.prototype.dasherize is not modified without EXTEND_PROTOTYPES", function() { + ok("undefined" === typeof String.prototype.dasherize, 'String.prototype helper disabled'); + }); +}...
true
Other
emberjs
ember.js
61c79eae54e3bbc95397f4c1e755493e3933d059.json
Add tests to ensure EXTEND_PROTOYPES is honored.
packages/ember-runtime/tests/system/string/decamelize.js
@@ -1,5 +1,11 @@ module('Ember.String.decamelize'); +if (!Ember.EXTEND_PROTOTYPES && !Ember.EXTEND_PROTOTYPES.String) { + test("String.prototype.decamelize is not modified without EXTEND_PROTOTYPES", function() { + ok("undefined" === typeof String.prototype.decamelize, 'String.prototype helper disabled'); + });...
true
Other
emberjs
ember.js
61c79eae54e3bbc95397f4c1e755493e3933d059.json
Add tests to ensure EXTEND_PROTOYPES is honored.
packages/ember-runtime/tests/system/string/fmt_string.js
@@ -1,5 +1,11 @@ module('Ember.String.fmt'); +if (!Ember.EXTEND_PROTOTYPES && !Ember.EXTEND_PROTOTYPES.String) { + test("String.prototype.fmt is not modified without EXTEND_PROTOTYPES", function() { + ok("undefined" === typeof String.prototype.fmt, 'String.prototype helper disabled'); + }); +} + test("'Hello %...
true
Other
emberjs
ember.js
61c79eae54e3bbc95397f4c1e755493e3933d059.json
Add tests to ensure EXTEND_PROTOYPES is honored.
packages/ember-runtime/tests/system/string/humanize.js
@@ -1,6 +1,12 @@ if (Ember.FEATURES.isEnabled("string-humanize")) { module('Ember.String.humanize'); + if (!Ember.EXTEND_PROTOTYPES && !Ember.EXTEND_PROTOTYPES.String) { + test("String.prototype.humanize is not modified without EXTEND_PROTOTYPES", function() { + ok("undefined" === typeof String.prototype...
true
Other
emberjs
ember.js
61c79eae54e3bbc95397f4c1e755493e3933d059.json
Add tests to ensure EXTEND_PROTOYPES is honored.
packages/ember-runtime/tests/system/string/loc_test.js
@@ -15,6 +15,12 @@ module('Ember.String.loc', { } }); +if (!Ember.EXTEND_PROTOTYPES && !Ember.EXTEND_PROTOTYPES.String) { + test("String.prototype.loc is not available without EXTEND_PROTOTYPES", function() { + ok("undefined" === typeof String.prototype.loc, 'String.prototype helper disabled'); + }); +} + t...
true
Other
emberjs
ember.js
61c79eae54e3bbc95397f4c1e755493e3933d059.json
Add tests to ensure EXTEND_PROTOYPES is honored.
packages/ember-runtime/tests/system/string/underscore.js
@@ -1,5 +1,11 @@ module('Ember.String.underscore'); +if (!Ember.EXTEND_PROTOTYPES && !Ember.EXTEND_PROTOTYPES.String) { + test("String.prototype.underscore is not available without EXTEND_PROTOTYPES", function() { + ok("undefined" === typeof String.prototype.underscore, 'String.prototype helper disabled'); + })...
true
Other
emberjs
ember.js
61c79eae54e3bbc95397f4c1e755493e3933d059.json
Add tests to ensure EXTEND_PROTOYPES is honored.
packages/ember-runtime/tests/system/string/w_test.js
@@ -1,5 +1,11 @@ module('Ember.String.w'); +if (!Ember.EXTEND_PROTOTYPES && !Ember.EXTEND_PROTOTYPES.String) { + test("String.prototype.w is not available without EXTEND_PROTOTYPES", function() { + ok("undefined" === typeof String.prototype.w, 'String.prototype helper disabled'); + }); +} + test("'one two thre...
true
Other
emberjs
ember.js
43d342e794d2c5bcd7e6a0b2e0c1cb252b752261.json
Use local npm packages for defeatureify. Update to the latest `ember-dev` which requires `defeatureify` and `yuidocjs` to be installed locally (previously these were required to be global). Also, adds a `package.json` to make installing as simple as `npm install`.
.travis.yml
@@ -4,8 +4,7 @@ rvm: node_js: - "0.10" install: -- "npm install -g defeatureify" -- "npm install -g yuidocjs" +- "npm install" - "bundle install --deployment" after_success: bundle exec rake publish_build script: rake test\[$TEST_SUITE]
true
Other
emberjs
ember.js
43d342e794d2c5bcd7e6a0b2e0c1cb252b752261.json
Use local npm packages for defeatureify. Update to the latest `ember-dev` which requires `defeatureify` and `yuidocjs` to be installed locally (previously these were required to be global). Also, adds a `package.json` to make installing as simple as `npm install`.
CONTRIBUTING.md
@@ -67,7 +67,7 @@ building Ember is quite simple. ```sh cd ember.js bundle install -npm install -g defeatureify +npm install rake ```
true
Other
emberjs
ember.js
43d342e794d2c5bcd7e6a0b2e0c1cb252b752261.json
Use local npm packages for defeatureify. Update to the latest `ember-dev` which requires `defeatureify` and `yuidocjs` to be installed locally (previously these were required to be global). Also, adds a `package.json` to make installing as simple as `npm install`.
Gemfile.lock
@@ -1,6 +1,6 @@ GIT remote: https://github.com/emberjs/ember-dev.git - revision: 353847a384c64ed7662419136a7aaaf39e9e7aa5 + revision: 81d5486f625051710682711de177056885e64fce branch: master specs: ember-dev (0.1) @@ -33,7 +33,7 @@ PATH GEM remote: https://rubygems.org/ specs: - aws-sdk (1.22....
true
Other
emberjs
ember.js
43d342e794d2c5bcd7e6a0b2e0c1cb252b752261.json
Use local npm packages for defeatureify. Update to the latest `ember-dev` which requires `defeatureify` and `yuidocjs` to be installed locally (previously these were required to be global). Also, adds a `package.json` to make installing as simple as `npm install`.
README.md
@@ -125,7 +125,7 @@ everything you need to get started. 2. Ensure that [Bundler](http://bundler.io/) is installed (`gem install bundler`). 3. Ensure that [Node.js](http://nodejs.org/) is installed. 4. Run `bundle install` to install the necessary ruby gems. -5. Run `npm install -g defeatureify`. +5. Run `npm install...
true