language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-htmlbars/lib/system/render-view.js | @@ -1,6 +1,7 @@
import Ember from "ember-metal/core";
import defaultEnv from "ember-htmlbars/env";
import { get } from "ember-metal/property_get";
+import ComponentNode from "ember-htmlbars/system/component-node";
export default function renderView(view, buffer, template) {
if (!template) {
@@ -9,13 +10,8 @@ e... | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-htmlbars/lib/templates/link-to.hbs | @@ -1 +1 @@
-<a class="ember-view {{classes}}" href={{href}}>{{yield}}</a>
+{{#if linkTitle}}{{#if attrs.escaped}}{{linkTitle}}{{else}}{{{linkTitle}}}{{/if}}{{else}}{{yield}}{{/if}}
\ No newline at end of file | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-htmlbars/tests/integration/component_lifecycle_test.js | @@ -117,10 +117,12 @@ QUnit.test('lifecycle hooks are invoked in a predictable order', function() {
deepEqual(hooks, [
hook('middle', 'willUpdate'), hook('middle', 'willRender'),
- hook('bottom', 'willUpdate'), hook('bottom', 'willRender'),
+ hook('bottom', 'willUpdate'),
hook('bottom', 'willRece... | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-metal-views/lib/renderer.js | @@ -1,13 +1,13 @@
import DOMHelper from "dom-helper";
import environment from "ember-metal/environment";
-import RenderBuffer from "ember-views/system/render_buffer";
import run from "ember-metal/run_loop";
import { get } from "ember-metal/property_get";
import { set } from "ember-metal/property_set";
import {
... | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-metal/lib/streams/utils.js | @@ -200,14 +200,16 @@ export function or(first, second) {
}
export function addDependency(stream, dependency) {
- if (dependency) {
+ Ember.assert("Cannot add a stream as a dependency to a non-stream", isStream(stream) || !isStream(dependency));
+ if (isStream(stream)) {
stream.addDependency(dependency);
... | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-metal/tests/streams/key-stream-test.js | @@ -86,7 +86,7 @@ QUnit.test("is notified when setSource is called with a new stream whose value i
nameStream.value(); // Prime the stream to notify subscribers
nameStream.setSource(new Stream(function() {
- return { name: "wycats" };
+ return { name: "wycats" };
}));
equal(count, 1, "Subscriber... | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-routing-htmlbars/lib/keywords/link-to.js | @@ -0,0 +1,30 @@
+import { readArray, readHash } from "ember-metal/streams/utils";
+//import ControllerMixin from "ember-runtime/mixins/controller";
+import Ember from "ember-metal/core"; // assert
+import merge from "ember-metal/merge";
+
+export default {
+ link: function(state, params, hash) {
+ Ember.assert("Yo... | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-routing-htmlbars/lib/main.js | @@ -9,19 +9,18 @@ Ember Routing HTMLBars Helpers
import Ember from "ember-metal/core";
import { registerHelper } from "ember-htmlbars/helpers";
+import { registerKeyword } from "ember-htmlbars/keywords";
import { renderHelper } from "ember-routing-htmlbars/helpers/render";
-import {
- linkToHelper,
- deprecate... | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-routing-htmlbars/tests/helpers/link-to_test.js | @@ -7,6 +7,8 @@ import Controller from "ember-runtime/controllers/controller";
import { Registry } from "ember-runtime/system/container";
import { runAppend, runDestroy } from "ember-runtime/tests/utils";
import EmberObject from "ember-runtime/system/object";
+import ComponentLookup from "ember-views/component_looku... | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-routing-views/lib/initializers/link-to-component.js | @@ -0,0 +1,12 @@
+import { onLoad } from "ember-runtime/system/lazy_load";
+import linkToComponent from "ember-routing-views/views/link";
+
+onLoad('Ember.Application', function(Application) {
+ Application.initializer({
+ name: 'link-to-component',
+ initialize: function(registry) {
+ registry.register('co... | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-routing-views/lib/main.js | @@ -7,6 +7,7 @@ Ember Routing Views
*/
import Ember from "ember-metal/core";
+import "ember-routing-views/initializers/link-to-component";
import { LinkView } from "ember-routing-views/views/link";
import { | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-routing-views/lib/views/link.js | @@ -7,11 +7,13 @@ import Ember from "ember-metal/core"; // FEATURES, Logger, assert
import { get } from "ember-metal/property_get";
import { computed } from "ember-metal/computed";
-import { fmt } from "ember-runtime/system/string";
import { isSimpleClick } from "ember-views/system/utils";
import EmberComponent f... | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-routing-views/lib/views/outlet.js | @@ -28,6 +28,8 @@ export var CoreOutletView = View.extend({
this.dirtyOutlets();
this._outlets = [];
+ this._outlets = [];
+
this.scheduleRevalidate();
}
}, | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-routing/lib/services/routing.js | @@ -61,9 +61,8 @@ var RoutingService = Service.extend({
return router.generate.apply(router, args);
},
- isActiveForRoute: function(params, routeName, routerState, isCurrentWhenSpecified) {
+ isActiveForRoute: function(contexts, queryParams, routeName, routerState, isCurrentWhenSpecified) {
var router ... | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-views/lib/mixins/template_rendering_support.js | @@ -28,12 +28,12 @@ var TemplateRenderingSupport = Mixin.create({
// TODO: Legacy string render function support
},
- renderTemplate() {
+ renderBlock(block, renderNode) {
if (_renderView === undefined) {
_renderView = require('ember-htmlbars/system/render-view');
}
- return _renderVie... | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-views/lib/system/build-component-template.js | @@ -0,0 +1,286 @@
+import { internal, render } from "htmlbars-runtime";
+import { read } from "ember-metal/streams/utils";
+import { get } from "ember-metal/property_get";
+
+export default function buildComponentTemplate(componentInfo, attrs, content) {
+ var component, layoutTemplate, contentBlock, blockToRender;
+ ... | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember/tests/helpers/link_to_test.js | @@ -193,10 +193,7 @@ QUnit.test("the {{link-to}} doesn't apply a 'disabled' class if disabledWhen is
});
QUnit.test("the {{link-to}} helper supports a custom disabledClass", function () {
- Ember.TEMPLATES.index = compile('{{#link-to "about" id="about-link" disabledWhen="shouldDisable" disabledClass="do-not-want"}... | true |
Other | emberjs | ember.js | 7cff945c04bf66b0c621b6b70042c51d8a5b2cdf.json | Introduce routing service
This commit introduces a new routing service, so that we can decouple
`LinkView` from knowing about the actual router’s internals.
Before this commit, LinkView tried to find the router off of its
controller, and looked up the application controller to get current
router state. This commit cr... | packages/ember-routing-htmlbars/tests/helpers/link-to_test.js | @@ -4,11 +4,32 @@ import EmberView from "ember-views/views/view";
import compile from "ember-template-compiler/system/compile";
import { set } from "ember-metal/property_set";
import Controller from "ember-runtime/controllers/controller";
+import { Registry } from "ember-runtime/system/container";
import { runAppen... | true |
Other | emberjs | ember.js | 7cff945c04bf66b0c621b6b70042c51d8a5b2cdf.json | Introduce routing service
This commit introduces a new routing service, so that we can decouple
`LinkView` from knowing about the actual router’s internals.
Before this commit, LinkView tried to find the router off of its
controller, and looked up the application controller to get current
router state. This commit cr... | packages/ember-routing-views/lib/views/link.js | @@ -6,27 +6,12 @@
import Ember from "ember-metal/core"; // FEATURES, Logger, assert
import { get } from "ember-metal/property_get";
-import merge from "ember-metal/merge";
-import run from "ember-metal/run_loop";
import { computed } from "ember-metal/computed";
import { fmt } from "ember-runtime/system/string";
-... | true |
Other | emberjs | ember.js | 7cff945c04bf66b0c621b6b70042c51d8a5b2cdf.json | Introduce routing service
This commit introduces a new routing service, so that we can decouple
`LinkView` from knowing about the actual router’s internals.
Before this commit, LinkView tried to find the router off of its
controller, and looked up the application controller to get current
router state. This commit cr... | packages/ember-routing/lib/initializers/routing-service.js | @@ -0,0 +1,14 @@
+import { onLoad } from "ember-runtime/system/lazy_load";
+import RoutingService from "ember-routing/services/routing";
+
+onLoad('Ember.Application', function(Application) {
+ Application.initializer({
+ name: 'routing-service',
+ initialize: function(registry) {
+ // Register the routing ... | true |
Other | emberjs | ember.js | 7cff945c04bf66b0c621b6b70042c51d8a5b2cdf.json | Introduce routing service
This commit introduces a new routing service, so that we can decouple
`LinkView` from knowing about the actual router’s internals.
Before this commit, LinkView tried to find the router off of its
controller, and looked up the application controller to get current
router state. This commit cr... | packages/ember-routing/lib/main.js | @@ -27,6 +27,8 @@ import RouterDSL from "ember-routing/system/dsl";
import Router from "ember-routing/system/router";
import Route from "ember-routing/system/route";
+import "ember-routing/initializers/routing-service";
+
Ember.Location = EmberLocation;
Ember.AutoLocation = AutoLocation;
Ember.HashLocation = Has... | true |
Other | emberjs | ember.js | 7cff945c04bf66b0c621b6b70042c51d8a5b2cdf.json | Introduce routing service
This commit introduces a new routing service, so that we can decouple
`LinkView` from knowing about the actual router’s internals.
Before this commit, LinkView tried to find the router off of its
controller, and looked up the application controller to get current
router state. This commit cr... | packages/ember-routing/lib/services/routing.js | @@ -0,0 +1,102 @@
+/**
+@module ember
+@submodule ember-routing
+*/
+
+import Service from "ember-runtime/system/service";
+
+import { get } from "ember-metal/property_get";
+import { readOnly } from "ember-metal/computed_macros";
+import { routeArgs } from "ember-routing/utils";
+import keys from "ember-metal/keys";
+... | true |
Other | emberjs | ember.js | 7cff945c04bf66b0c621b6b70042c51d8a5b2cdf.json | Introduce routing service
This commit introduces a new routing service, so that we can decouple
`LinkView` from knowing about the actual router’s internals.
Before this commit, LinkView tried to find the router off of its
controller, and looked up the application controller to get current
router state. This commit cr... | packages/ember-routing/lib/system/router.js | @@ -875,12 +875,14 @@ function updatePaths(router) {
}
set(appController, 'currentPath', path);
+ set(router, 'currentPath', path);
if (!('currentRouteName' in appController)) {
defineProperty(appController, 'currentRouteName');
}
set(appController, 'currentRouteName', infos[infos.length - 1]... | true |
Other | emberjs | ember.js | 93d42e327425a9ae776fe200469b3048d47ef63d.json | Update linkRenderNode signature | packages/ember-htmlbars/lib/hooks/link-render-node.js | @@ -7,7 +7,7 @@ import subscribe from "ember-htmlbars/utils/subscribe";
import shouldDisplay from "ember-views/streams/should_display";
import { chain, read } from "ember-metal/streams/utils";
-export default function linkRenderNode(renderNode, scope, path, params, hash) {
+export default function linkRenderNode(re... | false |
Other | emberjs | ember.js | 7bb4a5bb8339c0aa0db9afe707989a6fd4aecef7.json | Fix some bugs in KeyStream | packages/ember-metal/lib/streams/key-stream.js | @@ -18,33 +18,39 @@ function KeyStream(source, key) {
this.init();
this.source = source;
- this.obj = undefined;
+ this.dependency = this.addDependency(source);
+ this.observedObject = undefined;
this.key = key;
}
KeyStream.prototype = create(Stream.prototype);
merge(KeyStream.prototype, {
compu... | false |
Other | emberjs | ember.js | b3f592aa6c605d7e12f2f009eb3bdb1aaae8b36d.json | Add KeyStream tests | packages/ember-metal/tests/streams/key-stream-test.js | @@ -1,33 +1,109 @@
import Stream from "ember-metal/streams/stream";
import KeyStream from "ember-metal/streams/key-stream";
+import { set } from "ember-metal/property_set";
-var source, value;
+var source, object, count;
+
+function incrementCount() {
+ count++;
+}
QUnit.module('KeyStream', {
setup: function... | false |
Other | emberjs | ember.js | ee865c24317d2f48b4ae8fa0d01a9c476801d5dd.json | Remove rebase error | packages/ember-htmlbars/lib/main.js | @@ -13,7 +13,6 @@ import makeBoundHelper from "ember-htmlbars/system/make_bound_helper";
import {
registerHelper
} from "ember-htmlbars/helpers";
-import viewHelper from "ember-htmlbars/helpers/view";
import {
ifHelper,
unlessHelper
@@ -30,7 +29,6 @@ import "ember-htmlbars/system/bootstrap";
// Ember.Handl... | false |
Other | emberjs | ember.js | 180856b5b6836f5cf95862ba02272722b064fc49.json | Add an #each test | packages/ember-htmlbars/tests/helpers/each_test.js | @@ -1001,6 +1001,34 @@ function testEachWithItem(moduleName, useBlockParams) {
equal(view.$().text(), "controller:people - controller:Steve Holt of Yapp - controller:people - controller:Annabelle of Yapp - ");
});
+
+ QUnit.test("locals in stable loops update when the list is updated", function() {
+ expe... | false |
Other | emberjs | ember.js | c4bccc80450462cbf6c03f7a93ebe218ad72aee2.json | Utilize better host hooks in HTMLBars
This also clarifies the responsibilities of ShadowRoot, extracting any
notion of “components” into the parent ComponentNode and outlet keyword.
Lastly, this commit greatly cleans up the passing of scope into shadow
roots. In particular, the “hack” of using symbols to thread state... | packages/ember-htmlbars/lib/env.js | @@ -9,15 +9,14 @@ import subexpr from "ember-htmlbars/hooks/subexpr";
import concat from "ember-htmlbars/hooks/concat";
import linkRenderNode from "ember-htmlbars/hooks/link-render-node";
import createFreshScope from "ember-htmlbars/hooks/create-fresh-scope";
+import createShadowScope from "ember-htmlbars/hooks/crea... | true |
Other | emberjs | ember.js | c4bccc80450462cbf6c03f7a93ebe218ad72aee2.json | Utilize better host hooks in HTMLBars
This also clarifies the responsibilities of ShadowRoot, extracting any
notion of “components” into the parent ComponentNode and outlet keyword.
Lastly, this commit greatly cleans up the passing of scope into shadow
roots. In particular, the “hack” of using symbols to thread state... | packages/ember-htmlbars/lib/helpers/each.js | @@ -1,10 +1,14 @@
import { guidFor } from "ember-metal/utils";
+import { get } from "ember-metal/property_get";
export default function eachHelper(params, hash, blocks) {
var list = params[0];
+ var keyPath = hash.key;
for (var i=0, l=list.length; i<l; i++) {
var item = list[i];
- this.yieldItem(gu... | true |
Other | emberjs | ember.js | c4bccc80450462cbf6c03f7a93ebe218ad72aee2.json | Utilize better host hooks in HTMLBars
This also clarifies the responsibilities of ShadowRoot, extracting any
notion of “components” into the parent ComponentNode and outlet keyword.
Lastly, this commit greatly cleans up the passing of scope into shadow
roots. In particular, the “hack” of using symbols to thread state... | packages/ember-htmlbars/lib/hooks/bind-self.js | @@ -5,30 +5,25 @@
import SimpleStream from "ember-metal/streams/simple";
import { readHash } from "ember-metal/streams/utils";
-import { selfSymbol, componentSymbol } from "ember-htmlbars/system/symbols";
import { get } from "ember-metal/property_get";
import subscribe from "ember-htmlbars/utils/subscribe";
ex... | true |
Other | emberjs | ember.js | c4bccc80450462cbf6c03f7a93ebe218ad72aee2.json | Utilize better host hooks in HTMLBars
This also clarifies the responsibilities of ShadowRoot, extracting any
notion of “components” into the parent ComponentNode and outlet keyword.
Lastly, this commit greatly cleans up the passing of scope into shadow
roots. In particular, the “hack” of using symbols to thread state... | packages/ember-htmlbars/lib/hooks/block.js | @@ -1,10 +0,0 @@
-import { hooks as htmlbarsHooks } from "htmlbars-runtime";
-import isComponent from "ember-htmlbars/utils/is-component";
-
-export default function block(morph, env, scope, path, params, hash, template, inverse, visitor) {
- if (isComponent(env, scope, path)) {
- return env.hooks.component(morph, ... | true |
Other | emberjs | ember.js | c4bccc80450462cbf6c03f7a93ebe218ad72aee2.json | Utilize better host hooks in HTMLBars
This also clarifies the responsibilities of ShadowRoot, extracting any
notion of “components” into the parent ComponentNode and outlet keyword.
Lastly, this commit greatly cleans up the passing of scope into shadow
roots. In particular, the “hack” of using symbols to thread state... | packages/ember-htmlbars/lib/hooks/classify.js | @@ -0,0 +1,14 @@
+/**
+@module ember
+@submodule ember-htmlbars
+*/
+
+import isComponent from "ember-htmlbars/utils/is-component";
+
+export default function classify(env, scope, path) {
+ if (isComponent(env, scope, path)) {
+ return 'component';
+ }
+
+ return null;
+} | true |
Other | emberjs | ember.js | c4bccc80450462cbf6c03f7a93ebe218ad72aee2.json | Utilize better host hooks in HTMLBars
This also clarifies the responsibilities of ShadowRoot, extracting any
notion of “components” into the parent ComponentNode and outlet keyword.
Lastly, this commit greatly cleans up the passing of scope into shadow
roots. In particular, the “hack” of using symbols to thread state... | packages/ember-htmlbars/lib/hooks/content.js | @@ -1,10 +0,0 @@
-import { hooks as htmlbarsHooks } from "htmlbars-runtime";
-import isComponent from "ember-htmlbars/utils/is-component";
-
-export default function content(morph, env, scope, path, visitor) {
- if (isComponent(env, scope, path)) {
- return env.hooks.component(morph, env, scope, path, {}, null, nul... | true |
Other | emberjs | ember.js | c4bccc80450462cbf6c03f7a93ebe218ad72aee2.json | Utilize better host hooks in HTMLBars
This also clarifies the responsibilities of ShadowRoot, extracting any
notion of “components” into the parent ComponentNode and outlet keyword.
Lastly, this commit greatly cleans up the passing of scope into shadow
roots. In particular, the “hack” of using symbols to thread state... | packages/ember-htmlbars/lib/hooks/create-shadow-scope.js | @@ -0,0 +1,24 @@
+/**
+@module ember
+@submodule ember-htmlbars
+*/
+
+export default function createShadowScope(env, parentScope, options) {
+ var shadowScope = env.hooks.createFreshScope();
+
+ if (options.view) {
+ shadowScope.renderNode = options.renderNode;
+ shadowScope.view = options.view;
+ } else if (... | true |
Other | emberjs | ember.js | c4bccc80450462cbf6c03f7a93ebe218ad72aee2.json | Utilize better host hooks in HTMLBars
This also clarifies the responsibilities of ShadowRoot, extracting any
notion of “components” into the parent ComponentNode and outlet keyword.
Lastly, this commit greatly cleans up the passing of scope into shadow
roots. In particular, the “hack” of using symbols to thread state... | packages/ember-htmlbars/lib/hooks/get-root.js | @@ -21,14 +21,13 @@ export default function getRoot(scope, key) {
}
function getKey(scope, key) {
- if (key === 'attrs' && scope.attrs) {
- return scope.attrs;
+ if (key === 'attrs' && scope.attrsStream) {
+ return scope.attrsStream;
}
- var component = scope.component;
var self = scope.self;
- ... | true |
Other | emberjs | ember.js | c4bccc80450462cbf6c03f7a93ebe218ad72aee2.json | Utilize better host hooks in HTMLBars
This also clarifies the responsibilities of ShadowRoot, extracting any
notion of “components” into the parent ComponentNode and outlet keyword.
Lastly, this commit greatly cleans up the passing of scope into shadow
roots. In particular, the “hack” of using symbols to thread state... | packages/ember-htmlbars/lib/hooks/inline.js | @@ -1,10 +0,0 @@
-import { hooks as htmlbarsHooks } from "htmlbars-runtime";
-import isComponent from "ember-htmlbars/utils/is-component";
-
-export default function inline(morph, env, scope, path, params, hash, visitor) {
- if (isComponent(env, scope, path)) {
- return env.hooks.component(morph, env, scope, path, ... | true |
Other | emberjs | ember.js | c4bccc80450462cbf6c03f7a93ebe218ad72aee2.json | Utilize better host hooks in HTMLBars
This also clarifies the responsibilities of ShadowRoot, extracting any
notion of “components” into the parent ComponentNode and outlet keyword.
Lastly, this commit greatly cleans up the passing of scope into shadow
roots. In particular, the “hack” of using symbols to thread state... | packages/ember-htmlbars/lib/keywords/outlet.js | @@ -39,7 +39,11 @@ export default {
},
rerender: function(morph, env, scope, params, hash, template, inverse, visitor) {
- return morph.state.shadowRoot.rerender(env);
+ var newEnv = env;
+ if (morph.state.view) {
+ newEnv = merge({}, env);
+ newEnv.view = morph.state.view;
+ }
},
... | true |
Other | emberjs | ember.js | c4bccc80450462cbf6c03f7a93ebe218ad72aee2.json | Utilize better host hooks in HTMLBars
This also clarifies the responsibilities of ShadowRoot, extracting any
notion of “components” into the parent ComponentNode and outlet keyword.
Lastly, this commit greatly cleans up the passing of scope into shadow
roots. In particular, the “hack” of using symbols to thread state... | packages/ember-htmlbars/lib/keywords/unbound.js | @@ -8,14 +8,14 @@ export default function unbound(morph, env, scope, originalParams, hash, templat
// the first param instead of (incorrectly) trying to read from it. If this was a call
// to `{{unbound foo.bar}}`, then we pass along the original stream to `hooks.range`.
var params = originalParams.slice();
- ... | true |
Other | emberjs | ember.js | c4bccc80450462cbf6c03f7a93ebe218ad72aee2.json | Utilize better host hooks in HTMLBars
This also clarifies the responsibilities of ShadowRoot, extracting any
notion of “components” into the parent ComponentNode and outlet keyword.
Lastly, this commit greatly cleans up the passing of scope into shadow
roots. In particular, the “hack” of using symbols to thread state... | packages/ember-htmlbars/lib/system/component-node.js | @@ -1,4 +1,5 @@
import { get } from "ember-metal/property_get";
+import merge from "ember-metal/merge";
import Ember from "ember-metal/core";
import { validateChildMorphs } from "htmlbars-util";
import { readHash } from "ember-metal/streams/utils";
@@ -21,16 +22,15 @@ ComponentNode.create = function(renderNode, env... | true |
Other | emberjs | ember.js | c4bccc80450462cbf6c03f7a93ebe218ad72aee2.json | Utilize better host hooks in HTMLBars
This also clarifies the responsibilities of ShadowRoot, extracting any
notion of “components” into the parent ComponentNode and outlet keyword.
Lastly, this commit greatly cleans up the passing of scope into shadow
roots. In particular, the “hack” of using symbols to thread state... | packages/ember-htmlbars/lib/system/shadow-root.js | @@ -1,58 +1,33 @@
-import merge from "ember-metal/merge";
-import { hooks as htmlbarsHooks } from "htmlbars-runtime";
+import { internal } from "htmlbars-runtime";
/** @private
A ShadowRoot represents a new root scope. However, it
is not a render tree root.
*/
-import { componentSymbol, selfSymbol } from "e... | true |
Other | emberjs | ember.js | c4bccc80450462cbf6c03f7a93ebe218ad72aee2.json | Utilize better host hooks in HTMLBars
This also clarifies the responsibilities of ShadowRoot, extracting any
notion of “components” into the parent ComponentNode and outlet keyword.
Lastly, this commit greatly cleans up the passing of scope into shadow
roots. In particular, the “hack” of using symbols to thread state... | packages/ember-htmlbars/lib/system/symbols.js | @@ -1,6 +0,0 @@
-import { symbol } from "ember-metal/utils";
-
-export var selfSymbol = symbol("self");
-export var componentClassSymbol = symbol("componentClass");
-export var componentLayoutSymbol = symbol("componentLayout");
-export var componentSymbol = symbol("component"); | true |
Other | emberjs | ember.js | c4bccc80450462cbf6c03f7a93ebe218ad72aee2.json | Utilize better host hooks in HTMLBars
This also clarifies the responsibilities of ShadowRoot, extracting any
notion of “components” into the parent ComponentNode and outlet keyword.
Lastly, this commit greatly cleans up the passing of scope into shadow
roots. In particular, the “hack” of using symbols to thread state... | packages/ember-views/lib/views/states/has_element.js | @@ -9,7 +9,7 @@ import jQuery from "ember-views/system/jquery";
*/
import { get } from "ember-metal/property_get";
-import { visitChildren } from "htmlbars-runtime";
+import { internal } from "htmlbars-runtime";
var hasElement = create(_default);
@@ -32,7 +32,7 @@ merge(hasElement, {
var renderNode = view... | true |
Other | emberjs | ember.js | b3d529e855f30298776d54ff5069482871c73da2.json | Remove Safari from Sauce Labs runs.
It has provent to be unstable. Specifically, the `unsafe:` protocol
prefixes that we add for JS attribute sanitization cause the tests to
restart from the beginning (not really sure why). You can see this in
action in the following video:
https://assets.saucelabs.com/jobs/8e88992e... | testem.json | @@ -41,7 +41,6 @@
"launch_in_ci": [
"SL_Chrome_Current",
"SL_IE_11",
- "SL_IE_10",
- "SL_Safari_Current"
+ "SL_IE_10"
]
} | false |
Other | emberjs | ember.js | d596adc5669be4872f291be5dbde857a2f256d1a.json | Use testem directly for sauce tests.
Avoids a double build. | bin/run-sauce-tests.js | @@ -38,8 +38,14 @@ RSVP.resolve()
return run('./node_modules/.bin/ember', [ 'start-sauce-connect' ]);
})
.then(function() {
- return run('./node_modules/.bin/ember', [ 'test' ]);
+ // calling testem directly here instead of `ember test` so that
+ // we do not have to do a double build (by the time t... | true |
Other | emberjs | ember.js | d596adc5669be4872f291be5dbde857a2f256d1a.json | Use testem directly for sauce tests.
Avoids a double build. | package.json | @@ -29,6 +29,7 @@
"qunitjs": "^1.16.0",
"route-recognizer": "0.1.5",
"rsvp": "~3.0.6",
- "simple-dom": "^0.1.1"
+ "simple-dom": "^0.1.1",
+ "testem": "^0.7.6"
}
} | true |
Other | emberjs | ember.js | d596adc5669be4872f291be5dbde857a2f256d1a.json | Use testem directly for sauce tests.
Avoids a double build. | testem.json | @@ -1,8 +1,8 @@
{
"framework": "qunit",
- "test_page": "tests/index.html?hidepassed",
+ "test_page": "dist/tests/index.html?hidepassed",
"timeout": 540,
- "parallel": 2,
+ "parallel": 4,
"launchers": {
"SL_Chrome_Current": {
"command": "./node_modules/.bin/ember-cli-sauce -b chrome --no-ct -u ... | true |
Other | emberjs | ember.js | bd37fe7e6c9f19bca43e75da78cc85fc09b25dda.json | Add cross browser tests. | .travis.yml | @@ -10,6 +10,11 @@ cache:
- node_modules
- bower_components
+before_install:
+ - "npm config set spin false"
+ - "npm install -g npm@^2"
+ - "npm --version"
+
install:
- "npm install"
@@ -19,8 +24,13 @@ after_success:
script:
- npm test
+after_script:
+ - ember stop-sauce-connect
+
env:
... | true |
Other | emberjs | ember.js | bd37fe7e6c9f19bca43e75da78cc85fc09b25dda.json | Add cross browser tests. | bin/run-sauce-tests.js | @@ -0,0 +1,49 @@
+#!/usr/bin/env node
+
+var RSVP = require('rsvp');
+var spawn = require('child_process').spawn;
+
+function run(command, _args) {
+ var args = _args || [];
+
+ return new RSVP.Promise(function(resolve, reject) {
+ console.log('Running: ' + command + ' ' + args.join(' '));
+
+ var child = spaw... | true |
Other | emberjs | ember.js | bd37fe7e6c9f19bca43e75da78cc85fc09b25dda.json | Add cross browser tests. | bin/run-tests.js | @@ -138,6 +138,9 @@ switch (process.env.TEST_SUITE) {
case 'node':
require('./run-node-tests');
return;
+ case 'sauce':
+ require('./run-sauce-tests');
+ return;
default:
generateEachPackageTests();
} | true |
Other | emberjs | ember.js | bd37fe7e6c9f19bca43e75da78cc85fc09b25dda.json | Add cross browser tests. | package.json | @@ -16,6 +16,7 @@
"chalk": "^0.5.1",
"ember-cli": "^0.2.0",
"ember-cli-dependency-checker": "0.0.7",
+ "ember-cli-sauce": "^1.0.0",
"ember-cli-yuidoc": "^0.4.0",
"ember-publisher": "0.0.7",
"emberjs-build": "0.0.43",
@@ -28,6 +29,8 @@
"qunitjs": "^1.16.0",
"route-recognizer": ... | true |
Other | emberjs | ember.js | bd37fe7e6c9f19bca43e75da78cc85fc09b25dda.json | Add cross browser tests. | testem.json | @@ -0,0 +1,48 @@
+{
+ "framework": "qunit",
+ "test_page": "dist/tests/index.html?hidepassed",
+ "timeout": 60,
+ "parallel": 2,
+ "launchers":
+ {
+ "SL_Chrome_Current": {
+ "command": "./node_modules/.bin/saucie -tg ember -b chrome -v 39 --no-ct -u <url>",
+ "protocol": "tap",
+ "hid... | true |
Other | emberjs | ember.js | bd37fe7e6c9f19bca43e75da78cc85fc09b25dda.json | Add cross browser tests. | tests/index.html | @@ -5,6 +5,7 @@
<title>Ember</title>
<link rel="stylesheet" href="../qunit/qunit.css">
<script src="../qunit/qunit.js"></script>
+ <script src="/testem.js"></script>
<script type="text/javascript">
window.loadScript = function(url) { | true |
Other | emberjs | ember.js | 9030e3f01d09bb8c54c18b89841cdab9c8e01477.json | Add livereload to test suite.
We will now optionally inject the livereload script if the `Live Reload`
checkbox is checked. | tests/index.html | @@ -116,6 +116,8 @@
QUnit.config.urlConfig.push({ id: 'enableoptionalfeatures', label: "Enable Opt Features"});
// Handle extending prototypes
QUnit.config.urlConfig.push({ id: 'extendprototypes', label: 'Extend Prototypes'});
+ // Enable/disable livereload
+ QUnit.config.urlCon... | false |
Other | emberjs | ember.js | 7303bd61ceba33ae403565520233d60bf04bafda.json | Add 1.11.0 changelog. | CHANGELOG.md | @@ -4,8 +4,38 @@
- [#3852](https://github.com/emberjs/ember.js/pull/3852) [BREAKING BUGFIX] Do not assume null Ember.get targets always refer to a global
-### 1.11.0-beta.1 (February 06, 2015)
-
+### 1.11.0 (March 28, 2015)
+
+- [#10736](https://github.com/emberjs/ember.js/pull/10736) [BUGFIX] Fix issue with Query... | false |
Other | emberjs | ember.js | f3aeaf7727eda467b30a5f338824db2fd7baf42a.json | Fix more recent JSCS failures. | packages/ember-views/lib/views/view.js | @@ -667,6 +667,7 @@ var EMPTY_ARRAY = [];
@namespace Ember
@extends Ember.CoreView
*/
+// jscs:disable validateIndentation
var View = CoreView.extend(
ViewStreamSupport,
ViewKeywordSupport,
@@ -1435,6 +1436,7 @@ var View = CoreView.extend(
return scheduledFn;
}
});
+// jscs:enable validateIndenta... | true |
Other | emberjs | ember.js | f3aeaf7727eda467b30a5f338824db2fd7baf42a.json | Fix more recent JSCS failures. | packages/ember-views/tests/views/collection_test.js | @@ -608,10 +608,10 @@ QUnit.test("should render the emptyView if content array is empty and emptyView
Ember.lookup = {
App: {
EmptyView: View.extend({
- tagName: 'kbd',
- render(buf) {
- buf.push("THIS IS AN EMPTY VIEW");
- }
+ tagName: 'kbd',
+ render(buf) {
+ ... | true |
Other | emberjs | ember.js | cfe40f8dd8012e7d51bb2061a539c2410c6f3ca1.json | Lock esperanto down to 0.6.17. | package.json | @@ -19,6 +19,7 @@
"ember-cli-yuidoc": "^0.4.0",
"ember-publisher": "0.0.7",
"emberjs-build": "0.0.43",
+ "esperanto": "0.6.17",
"express": "^4.5.0",
"github": "^0.2.3",
"glob": "~4.3.2", | false |
Other | emberjs | ember.js | c98aced52fcfceee6ea8aca7329b90a7f7a3ec92.json | Remove unused variables in custom JSCS rule. | lib/jscs-rules/require-spaces-after-closing-parenthesis-in-function-declaration.js | @@ -25,15 +25,8 @@ module.exports.prototype = {
check: function(file, errors) {
var beforeOpeningRoundBrace = this._beforeOpeningRoundBrace;
var beforeOpeningCurlyBrace = this._beforeOpeningCurlyBrace;
- var tokens = file.getTokens();
file.iterateNodesByType(['FunctionDeclaration'], function(node... | false |
Other | emberjs | ember.js | 9acdd097555d566382f626bd2ee4f6ce9e2bc7fb.json | Add link to the guides in deprecation warning | packages/ember-metal/lib/computed.js | @@ -117,7 +117,9 @@ function ComputedProperty(config, opts) {
config.__ember_arity = config.length;
this._getter = config;
if (config.__ember_arity > 1) {
- Ember.deprecate("Using the same function as getter and setter is deprecated");
+ Ember.deprecate("Using the same function as get... | false |
Other | emberjs | ember.js | 1b02939a7a095c883de55be9f4f09419b50c4a69.json | Exclude debug only tests in production builds. | packages/ember-views/tests/views/view/element_test.js | @@ -1,3 +1,5 @@
+/*globals EmberDev */
+
import { get } from "ember-metal/property_get";
import { set } from "ember-metal/property_set";
import run from "ember-metal/run_loop";
@@ -45,7 +47,7 @@ QUnit.test("returns element if you set the value", function() {
equal(get(view, 'element'), dom, 'now has set element')... | false |
Other | emberjs | ember.js | 7003f2bd5f3827b01f97fd04c17c8ef77b429bf1.json | Update emberjs-build to 0.0.43.
Compare view:
https://github.com/emberjs/emberjs-build/compare/v0.0.39...v0.0.43
Major changes:
* Update JSCS to latest version
* Allow template compilation to use `Ember.deprecate`.
* Add `ember-metal` to `ember-template-compiler.js`
* Add `ember-debug` into `ember-template-com... | package.json | @@ -18,7 +18,7 @@
"ember-cli-dependency-checker": "0.0.7",
"ember-cli-yuidoc": "^0.4.0",
"ember-publisher": "0.0.7",
- "emberjs-build": "0.0.39",
+ "emberjs-build": "0.0.43",
"express": "^4.5.0",
"github": "^0.2.3",
"glob": "~4.3.2", | false |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-metal/lib/computed.js | @@ -117,6 +117,7 @@ function ComputedProperty(config, opts) {
config.__ember_arity = config.length;
this._getter = config;
if (config.__ember_arity > 1) {
+ Ember.deprecate("Using the same function as getter and setter is deprecated");
this._setter = config;
}
} else { | true |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-metal/lib/computed_macros.js | @@ -674,13 +674,16 @@ export function readOnly(dependentKey) {
@deprecated Use `Ember.computed.oneWay` or custom CP with default instead.
*/
export function defaultTo(defaultPath) {
- return computed(function(key, newValue, cachedValue) {
- Ember.deprecate('Usage of Ember.computed.defaultTo is deprecated, use ... | true |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-metal/tests/binding/sync_test.js | @@ -17,14 +17,15 @@ testBoth("bindings should not sync twice in a single run loop", function(get, se
run(function() {
a = {};
- defineProperty(a, 'foo', computed(function(key, value) {
- if (arguments.length === 2) {
+ defineProperty(a, 'foo', computed({
+ get: function(key) {
+ getCall... | true |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-metal/tests/computed_test.js | @@ -65,15 +65,15 @@ QUnit.test('defining computed property should invoke property on get', function(
});
QUnit.test('defining computed property should invoke property on set', function() {
-
var obj = {};
var count = 0;
- defineProperty(obj, 'foo', computed(function(key, value) {
- if (value !== undefined... | true |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-metal/tests/mixin/computed_test.js | @@ -51,7 +51,7 @@ QUnit.test('overriding computed properties', function() {
equal(get(obj, 'aProp'), 'AD', "should define super for D");
obj = { };
- defineProperty(obj, 'aProp', computed(function(key, value) {
+ defineProperty(obj, 'aProp', computed(function(key) {
return 'obj';
}));
MixinD.apply(... | true |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-metal/tests/observer_test.js | @@ -1028,9 +1028,9 @@ testBoth('setting simple prop should not trigger', function(get, set) {
testBoth('setting a cached computed property whose value has changed should trigger', function(get, set) {
var obj = {};
- defineProperty(obj, 'foo', computed(function(key, value) {
- if (arguments.length === 2) { re... | true |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-metal/tests/watching/unwatch_test.js | @@ -28,12 +28,14 @@ function addListeners(obj, keyPath) {
testBoth('unwatching a computed property - regular get/set', function(get, set) {
var obj = {};
- defineProperty(obj, 'foo', computed(function(keyName, value) {
- if (value !== undefined) {
+ defineProperty(obj, 'foo', computed({
+ get: function() ... | true |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-metal/tests/watching/watch_test.js | @@ -40,12 +40,16 @@ function addListeners(obj, keyPath) {
testBoth('watching a computed property', function(get, set) {
var obj = {};
- Ember.defineProperty(obj, 'foo', Ember.computed(function(keyName, value) {
- if (value !== undefined) {
- this.__foo = value;
+ Ember.defineProperty(obj, 'foo', Ember.c... | true |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-routing-views/lib/views/link.js | @@ -270,10 +270,15 @@ var LinkView = EmberComponent.extend({
When `true` interactions with the element will not trigger route changes.
@property disabled
*/
- disabled: computed(function computeLinkViewDisabled(key, value) {
- if (value !== undefined) { this.set('_isDisabled', value); }
+ disabled: co... | true |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-runtime/lib/controllers/array_controller.js | @@ -204,8 +204,11 @@ export default ArrayProxy.extend(ControllerMixin, SortableMixin, {
this._subControllers = [];
},
- model: computed(function (key, value) {
- if (arguments.length > 1) {
+ model: computed({
+ get: function(key) {
+ return Ember.A();
+ },
+ set: function(key, value) {
... | true |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-runtime/lib/ext/rsvp.js | @@ -25,7 +25,7 @@ RSVP.configure('async', function(callback, promise) {
if (Ember.testing && async) { asyncStart(); }
- run.backburner.schedule('actions', function(){
+ run.backburner.schedule('actions', function() {
if (Ember.testing && async) { asyncEnd(); }
callback(promise);
}); | true |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-runtime/lib/mixins/array.js | @@ -167,12 +167,14 @@ export default Mixin.create(Enumerable, {
@property []
@return this
*/
- '[]': computed(function(key, value) {
- if (value !== undefined) {
+ '[]': computed({
+ get: function(key) {
+ return this;
+ },
+ set: function(key, value) {
this.replace(0, get(this, '... | true |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-runtime/lib/mixins/enumerable.js | @@ -956,8 +956,8 @@ export default Mixin.create({
@type Array
@return this
*/
- '[]': computed(function(key, value) {
- return this;
+ '[]': computed({
+ get: function(key) { return this; }
}),
// .......................................................... | true |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-runtime/lib/mixins/promise_proxy.js | @@ -156,11 +156,12 @@ export default Mixin.create({
@property promise
*/
- promise: computed(function(key, promise) {
- if (arguments.length === 2) {
- return tap(this, promise);
- } else {
+ promise: computed({
+ get: function() {
throw new EmberError("PromiseProxy's promise must be se... | true |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-runtime/lib/mixins/sortable.js | @@ -161,26 +161,28 @@ export default Mixin.create(MutableEnumerable, {
@property arrangedContent
*/
- arrangedContent: computed('content', 'sortProperties.@each', function(key, value) {
- var content = get(this, 'content');
- var isSorted = get(this, 'isSorted');
- var sortProperties = get(this, 'so... | true |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-runtime/tests/legacy_1x/mixins/observable/observable_test.js | @@ -238,11 +238,14 @@ QUnit.module("object.set()", {
// computed property
_computed: "computed",
- computed: computed(function(key, value) {
- if (value !== undefined) {
+ computed: computed({
+ get: function(key) {
+ return this._computed;
+ },
+ set: func... | true |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-runtime/tests/legacy_1x/mixins/observable/propertyChanges_test.js | @@ -123,12 +123,12 @@ QUnit.test("should invalidate function property cache when notifyPropertyChange
var a = ObservableObject.createWithMixins({
_b: null,
- b: computed(function(key, value) {
- if (value !== undefined) {
+ b: computed({
+ get: function() { return this._b; },
+ set: funct... | true |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-runtime/tests/mixins/observable_test.js | @@ -46,11 +46,9 @@ testBoth('calling setProperties completes safely despite exceptions', function(g
var obj = EmberObject.createWithMixins({
firstName: "Steve",
lastName: "Jobs",
- companyName: computed(function(key, value) {
- if (value !== undefined) {
- throw exc;
- }
- return "... | true |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-runtime/tests/system/object/create_test.js | @@ -31,9 +31,13 @@ QUnit.test("simple properties are set", function() {
QUnit.test("calls computed property setters", function() {
var MyClass = EmberObject.extend({
- foo: computed(function(key, val) {
- if (arguments.length === 2) { return val; }
- return "this is not the value you're looking for";... | true |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-runtime/tests/system/object_proxy_test.js | @@ -8,11 +8,12 @@ QUnit.module("ObjectProxy");
testBoth("should not proxy properties passed to create", function (get, set) {
var Proxy = ObjectProxy.extend({
- cp: computed(function (key, value) {
- if (value) {
+ cp: computed({
+ get: function(key) { return this._cp; },
+ set: function(key,... | true |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-views/lib/mixins/view_context_support.js | @@ -16,12 +16,13 @@ var ViewContextSupport = Mixin.create({
@property context
@type Object
*/
- context: computed(function(key, value) {
- if (arguments.length === 2) {
+ context: computed({
+ get: function() {
+ return get(this, '_context');
+ },
+ set: function(key, value) {
set... | true |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-views/lib/views/component.js | @@ -145,15 +145,18 @@ var Component = View.extend(TargetActionSupport, ComponentTemplateDeprecation, {
@deprecated
@property template
*/
- template: computed(function(key, value) {
- if (value !== undefined) { return value; }
+ template: computed({
+ get: function() {
+ var templateName = get(this... | true |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-views/lib/views/select.js | @@ -430,11 +430,15 @@ var Select = View.extend({
@type String
@default null
*/
- value: computed('_valuePath', 'selection', function(key, value) {
- if (arguments.length === 2) { return value; }
- var valuePath = get(this, '_valuePath');
- return valuePath ? get(this, 'selection.' + valuePath) : ... | true |
Other | emberjs | ember.js | f3d645dccd9464a20fdb82d59b12ebded131596e.json | Use new cps (get/set) internally | packages/ember-views/lib/views/view.js | @@ -727,15 +727,18 @@ var View = CoreView.extend(
@property template
@type Function
*/
- template: computed('templateName', function(key, value) {
- if (value !== undefined) { return value; }
- var templateName = get(this, 'templateName');
- var template = this.templateForName(templateName, 'te... | true |
Other | emberjs | ember.js | 3a25949b2c0f2e50e348c601185dc2eee043a423.json | Add KeyStream tests | packages/ember-views/tests/streams/key_stream_test.js | @@ -0,0 +1,131 @@
+import { set } from "ember-metal/property_set";
+import Stream from "ember-metal/streams/stream";
+import KeyStream from "ember-views/streams/key_stream";
+
+var source, object, count;
+
+function incrementCount() {
+ count++;
+}
+
+QUnit.module('KeyStream', {
+ setup: function() {
+ count = 0;
... | false |
Other | emberjs | ember.js | 306f75cd555336302c3e5295cba141e92cca2f5f.json | Fix bad syntax in docs. | packages/ember-routing/lib/system/router.js | @@ -894,10 +894,10 @@ EmberRouter.reopenClass({
supplied callback function using `this.resource` and `this.route`.
```javascript
- App.Router.map(function({
+ App.Router.map(function(){
this.route('about');
this.resource('article');
- }));
+ });
```
For more detailed ex... | false |
Other | emberjs | ember.js | 4a82e7287f2a00d13690aefd1b04c9d223116889.json | Update HTMLBars version to 0.11.2. | package.json | @@ -22,7 +22,7 @@
"express": "^4.5.0",
"github": "^0.2.3",
"glob": "~4.3.2",
- "htmlbars": "git+https://github.com/stefanpenner/htmlbars-private.git",
+ "htmlbars": "0.11.2",
"qunit-extras": "^1.3.0",
"qunitjs": "^1.16.0",
"route-recognizer": "0.1.5", | false |
Other | emberjs | ember.js | b339c671df7bcbdfdd9381ede4faf56f5f405b36.json | Remove Ember.Descriptor from exports | packages/ember-metal/lib/computed.js | @@ -108,7 +108,6 @@ function UNDEFINED() { }
@class ComputedProperty
@namespace Ember
- @extends Ember.Descriptor
@constructor
*/
function ComputedProperty(config, opts) { | true |
Other | emberjs | ember.js | b339c671df7bcbdfdd9381ede4faf56f5f405b36.json | Remove Ember.Descriptor from exports | packages/ember-metal/lib/injected_property.js | @@ -9,7 +9,6 @@ import create from "ember-metal/platform/create";
@class InjectedProperty
@namespace Ember
- @extends Ember.Descriptor
@constructor
@param {String} type The container type the property will lookup
@param {String} name (optional) The name the property will lookup, defaults | true |
Other | emberjs | ember.js | b339c671df7bcbdfdd9381ede4faf56f5f405b36.json | Remove Ember.Descriptor from exports | packages/ember-metal/lib/main.js | @@ -303,7 +303,6 @@ Ember.beginPropertyChanges = beginPropertyChanges;
Ember.endPropertyChanges = endPropertyChanges;
Ember.changeProperties = changeProperties;
-Ember.Descriptor = Descriptor;
Ember.defineProperty = defineProperty;
Ember.set = set; | true |
Other | emberjs | ember.js | b339c671df7bcbdfdd9381ede4faf56f5f405b36.json | Remove Ember.Descriptor from exports | packages/ember-metal/lib/mixin.js | @@ -770,7 +770,6 @@ Alias.prototype = new Descriptor();
@method aliasMethod
@for Ember
@param {String} methodName name of the method to alias
- @return {Ember.Descriptor}
*/
export function aliasMethod(methodName) {
return new Alias(methodName); | true |
Other | emberjs | ember.js | b339c671df7bcbdfdd9381ede4faf56f5f405b36.json | Remove Ember.Descriptor from exports | packages/ember-metal/lib/properties.js | @@ -16,13 +16,6 @@ import { overrideChains } from "ember-metal/property_events";
/**
Objects of this type can implement an interface to respond to requests to
get and set. The default implementation handles simple properties.
-
- You generally won't need to create or subclass this directly.
-
- @class Descript... | true |
Other | emberjs | ember.js | 8ebca79ae105752cfd8452a8b2f41aeb1aedb54a.json | Update mutable_array example
Change quotes to single, and add some line breaks | packages/ember-runtime/lib/mixins/mutable_array.js | @@ -72,7 +72,8 @@ export default Mixin.create(EmberArray, MutableEnumerable, {
want to reuse an existing array without having to recreate it.
```javascript
- var colors = ["red", "green", "blue"];
+ var colors = ['red', 'green', 'blue'];
+
color.length(); // 3
colors.clear(); // []
... | false |
Other | emberjs | ember.js | 6a71ff26042f2e6f9516f9616d88159a2acd8bec.json | Use less container trickery
thanks @igorT | packages/ember-application/lib/system/application.js | @@ -333,10 +333,7 @@ var Application = Namespace.extend(DeferredMixin, {
// For the default instance only, set the view registry to the global
// Ember.View.views hash for backwards-compatibility.
- var registry = instance.applicationRegistry;
- registry.unregister('-view-registry:main');
- registr... | false |
Other | emberjs | ember.js | c6747547f5c1f73c64167c443e633c31867b2172.json | Deprecate direct use of CoreView | packages/ember-views/lib/main.js | @@ -24,7 +24,7 @@ import {
states
} from "ember-views/views/states";
-import CoreView from "ember-views/views/core_view";
+import { DeprecatedCoreView } from "ember-views/views/core_view";
import View from "ember-views/views/view";
import ContainerView from "ember-views/views/container_view";
import Collection... | true |
Other | emberjs | ember.js | c6747547f5c1f73c64167c443e633c31867b2172.json | Deprecate direct use of CoreView | packages/ember-views/lib/views/core_view.js | @@ -34,6 +34,7 @@ var renderer;
@class CoreView
@namespace Ember
@extends Ember.Object
+ @deprecated Use `Ember.View` instead.
@uses Ember.Evented
@uses Ember.ActionHandler
*/
@@ -153,4 +154,11 @@ CoreView.reopenClass({
isViewClass: true
});
+export var DeprecatedCoreView = CoreView.extend({
+ i... | true |
Other | emberjs | ember.js | c6747547f5c1f73c64167c443e633c31867b2172.json | Deprecate direct use of CoreView | packages/ember-views/tests/views/exports_test.js | @@ -0,0 +1,9 @@
+import Ember from "ember-views";
+
+QUnit.module("ember-view exports");
+
+QUnit.test("should export a disabled CoreView", function() {
+ expectDeprecation(function() {
+ Ember.CoreView.create();
+ }, 'Ember.CoreView is deprecated. Please use Ember.View.');
+}); | true |
Other | emberjs | ember.js | ad79c1e075987bea64d3a73e703363d07284338a.json | Enable sourcemap support for Ember development.
This is useful while developing on Ember, and we may possibly publish
the maps to `bower`, S3, etc in the future, but we need to be careful to
not cause many errors/warnings while building Ember CLI (if the `.map`
file is referenced but not present it causes a console wa... | .travis.yml | @@ -20,6 +20,7 @@ script:
env:
global:
+ - DISABLE_SOURCE_MAPS=true
- BROCCOLI_ENV=production
- S3_BUILD_CACHE_BUCKET=emberjs-build-cache
- S3_BUCKET_NAME=builds.emberjs.com | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.