language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | 890ef0335c0941c94697f58b6b1f10463f1e7a64.json | Remove unneeded code
As part of our “Project Svelte” initiative, this commit takes a
machete to code that is no longer needed after the Glimmer integration. | packages/ember-htmlbars/tests/compat/make_bound_helper_test.js | @@ -3,7 +3,6 @@ import EmberView from "ember-views/views/view";
import run from "ember-metal/run_loop";
import EmberObject from "ember-runtime/system/object";
import { A } from "ember-runtime/system/native_array";
-import SimpleBoundView from "ember-views/views/simple_bound_view";
// import {expectAssertion} from... | true |
Other | emberjs | ember.js | 890ef0335c0941c94697f58b6b1f10463f1e7a64.json | Remove unneeded code
As part of our “Project Svelte” initiative, this commit takes a
machete to code that is no longer needed after the Glimmer integration. | packages/ember-htmlbars/tests/system/make_bound_helper_test.js | @@ -7,8 +7,6 @@ import { runAppend, runDestroy } from "ember-runtime/tests/utils";
import {
dasherize
} from 'ember-runtime/system/string';
-import SimpleBoundView from "ember-views/views/simple_bound_view";
-import EmberObject from "ember-runtime/system/object";
var view, registry, container;
@@ -226,52 +224... | true |
Other | emberjs | ember.js | 890ef0335c0941c94697f58b6b1f10463f1e7a64.json | Remove unneeded code
As part of our “Project Svelte” initiative, this commit takes a
machete to code that is no longer needed after the Glimmer integration. | packages/ember-views/lib/main.js | @@ -36,7 +36,6 @@ import TextSupport from "ember-views/mixins/text_support";
import TextField from "ember-views/views/text_field";
import TextArea from "ember-views/views/text_area";
-import SimpleBoundView from "ember-views/views/simple_bound_view";
import _MetamorphView from "ember-views/views/metamorph_view";
... | true |
Other | emberjs | ember.js | 890ef0335c0941c94697f58b6b1f10463f1e7a64.json | Remove unneeded code
As part of our “Project Svelte” initiative, this commit takes a
machete to code that is no longer needed after the Glimmer integration. | packages/ember-views/lib/views/bound_component_view.js | @@ -1,50 +0,0 @@
-/**
-@module ember
-@submodule ember-views
-*/
-
-import { _Metamorph } from "ember-views/views/metamorph_view";
-import { read, chain, subscribe, unsubscribe } from "ember-metal/streams/utils";
-import { readComponentFactory } from "ember-views/streams/utils";
-import mergeViewBindings from "ember-ht... | true |
Other | emberjs | ember.js | 890ef0335c0941c94697f58b6b1f10463f1e7a64.json | Remove unneeded code
As part of our “Project Svelte” initiative, this commit takes a
machete to code that is no longer needed after the Glimmer integration. | packages/ember-views/lib/views/bound_if_view.js | @@ -1,28 +0,0 @@
-import run from 'ember-metal/run_loop';
-import _MetamorphView from "ember-views/views/metamorph_view";
-import NormalizedRerenderIfNeededSupport from "ember-views/mixins/normalized_rerender_if_needed";
-import renderView from "ember-htmlbars/system/render-view";
-
-export default _MetamorphView.exten... | true |
Other | emberjs | ember.js | 890ef0335c0941c94697f58b6b1f10463f1e7a64.json | Remove unneeded code
As part of our “Project Svelte” initiative, this commit takes a
machete to code that is no longer needed after the Glimmer integration. | packages/ember-views/lib/views/bound_partial_view.js | @@ -1,39 +0,0 @@
-/**
-@module ember
-@submodule ember-views
-*/
-
-import _MetamorphView from "ember-views/views/metamorph_view";
-import NormalizedRerenderIfNeededSupport from "ember-views/mixins/normalized_rerender_if_needed";
-import lookupPartial from "ember-views/system/lookup_partial";
-import run from 'ember-me... | true |
Other | emberjs | ember.js | 890ef0335c0941c94697f58b6b1f10463f1e7a64.json | Remove unneeded code
As part of our “Project Svelte” initiative, this commit takes a
machete to code that is no longer needed after the Glimmer integration. | packages/ember-views/lib/views/simple_bound_view.js | @@ -1,108 +0,0 @@
-/**
-@module ember
-@submodule ember-views
-*/
-
-import EmberError from "ember-metal/error";
-import run from "ember-metal/run_loop";
-import {
- GUID_KEY,
- uuid
-} from "ember-metal/utils";
-
-function K() { return this; }
-
-function SimpleBoundView(parentView, renderer, morph, stream) {
- thi... | true |
Other | emberjs | ember.js | 890ef0335c0941c94697f58b6b1f10463f1e7a64.json | Remove unneeded code
As part of our “Project Svelte” initiative, this commit takes a
machete to code that is no longer needed after the Glimmer integration. | packages/ember-views/lib/views/with_view.js | @@ -1,72 +0,0 @@
-/**
-@module ember
-@submodule ember-views
-*/
-
-import { set } from "ember-metal/property_set";
-import _MetamorphView from "ember-views/views/metamorph_view";
-import NormalizedRerenderIfNeededSupport from "ember-views/mixins/normalized_rerender_if_needed";
-import run from 'ember-metal/run_loop';
... | true |
Other | emberjs | ember.js | 890ef0335c0941c94697f58b6b1f10463f1e7a64.json | Remove unneeded code
As part of our “Project Svelte” initiative, this commit takes a
machete to code that is no longer needed after the Glimmer integration. | packages/ember-views/tests/views/simple_bound_view_test.js | @@ -1,36 +0,0 @@
-import Stream from "ember-metal/streams/stream";
-import SimpleBoundView from "ember-views/views/simple_bound_view";
-
-QUnit.module('SimpleBoundView');
-
-QUnit.test('does not render if update is triggered by normalizedValue is the same as the previous normalizedValue', function() {
- var value = nu... | true |
Other | emberjs | ember.js | 88c93e3c08e8bb8aca8517813fbd21045dd5b4b8.json | Skip new failing tests after rebase | packages/ember-htmlbars/tests/helpers/view_test.js | @@ -423,7 +423,7 @@ QUnit.test("Should apply classes when bound property specified", function() {
ok(jQuery('#foo').hasClass('foo'), "Always applies classbinding without condition");
});
-QUnit.test("Should apply a class from a sub expression", function() {
+QUnit.skip("Should apply a class from a sub expression"... | true |
Other | emberjs | ember.js | 88c93e3c08e8bb8aca8517813fbd21045dd5b4b8.json | Skip new failing tests after rebase | packages/ember-htmlbars/tests/integration/select_in_template_test.js | @@ -89,7 +89,7 @@ QUnit.skip("works from a template with bindings [DEPRECATED]", function() {
equal(select.get('selection'), erik, "Selection was maintained after new option was added");
});
-QUnit.test("works from a template", function() {
+QUnit.skip("works from a template", function() {
var Person = EmberOb... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/lib/hooks/get-root.js | @@ -35,7 +35,7 @@ function getKey(scope, key) {
}
function getGlobal(name) {
- Ember.deprecate("Global lookup of " + name + " from a Handlebars template is deprecated");
+ Ember.deprecate("Global lookup of " + name + " from a Handlebars template is deprecated.");
// This stream should be memoized, but this p... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/lib/keywords/input.js | @@ -5,7 +5,7 @@ export default {
var type = env.hooks.getValue(hash.type) || 'text';
Ember.assert("{{input type='checkbox'}} does not support setting `value=someBooleanValue`;" +
- " you must use `checked=someBooleanValue` instead.", !(type === 'checked' && hash.hasOwnProperty('value')));
+ ... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/attr_nodes/data_test.js | @@ -180,8 +180,7 @@ if (Ember.FEATURES.isEnabled('ember-htmlbars-attribute-syntax')) {
equalInnerHTML(view.element, '<div data-name="mmun">Hi!</div>', "attribute is updated output");
});
- QUnit.test("updates fail silently after an element is destroyed", function() {
-
+ QUnit.skip("updates fail silently af... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/compat/make_bound_helper_test.js | @@ -114,7 +114,7 @@ QUnit.test("should update bound helpers in a subexpression when properties chang
equal(view.$('div[data-foo="not-thing"]').text(), 'notThing', "helper output is correct");
});
-QUnit.test("should allow for computed properties with dependencies", function() {
+QUnit.skip("should allow for compu... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/helpers/bind_attr_test.js | @@ -431,8 +431,7 @@ QUnit.test("should be able to bind classes to globals with {{bind-attr class}}",
ok(view.$('img').hasClass('is-open'), "sets classname to the dasherized value of the global property");
});
-QUnit.test("should be able to bind-attr to 'this' in an {{#each}} block", function() {
-
+QUnit.skip("sh... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/helpers/collection_test.js | @@ -55,7 +55,7 @@ QUnit.module("collection helper", {
}
});
-QUnit.test("Collection views that specify an example view class have their children be of that class", function() {
+QUnit.skip("Collection views that specify an example view class have their children be of that class", function() {
var ExampleViewCo... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/helpers/component_test.js | @@ -46,7 +46,7 @@ if (Ember.FEATURES.isEnabled('ember-htmlbars-component-helper')) {
equal(view.$().text(), 'yummy Loisaida arepas!', 'component was updated and re-rendered');
});
- QUnit.test("component helper with actions", function() {
+ QUnit.skip("component helper with actions", function() {
regis... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/helpers/each_test.js | @@ -18,6 +18,7 @@ import { runAppend, runDestroy } from "ember-runtime/tests/utils";
import compile from "ember-template-compiler/system/compile";
import { deprecation as eachDeprecation } from "ember-htmlbars/helpers/each";
+
var people, view, registry, container;
var template, templateMyView, MyView, MyEmptyVie... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/helpers/if_unless_test.js | @@ -209,7 +209,7 @@ QUnit.test("The `unbound if` helper should work when its inverse is not present"
equal(view.$().text(), '');
});
-QUnit.test('should not rerender if truthiness does not change', function() {
+QUnit.skip('should not rerender if truthiness does not change', function() {
view = EmberView.creat... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/helpers/input_test.js | @@ -14,7 +14,7 @@ var controller, registry, container;
function commonSetup() {
registry = new Registry();
registry.register('component:-text-field', TextField);
- registry.register('component:-check-box', Checkbox);
+ registry.register('component:-checkbox', Checkbox);
registry.register('component-lookup:m... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/helpers/new_each_helper_test.js | @@ -1,334 +0,0 @@
-/*jshint newcap:false*/
-import Ember from "ember-metal/core"; // Ember.lookup;
-import EmberObject from "ember-runtime/system/object";
-import run from "ember-metal/run_loop";
-import EmberView from "ember-views/views/view";
-import _MetamorphView from "ember-views/views/metamorph_view";
-import { c... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/helpers/template_test.js | @@ -26,7 +26,7 @@ QUnit.module("Support for {{template}} helper", {
}
});
-QUnit.test("should render other templates via the container (DEPRECATED)", function() {
+QUnit.skip("should render other templates via the container (DEPRECATED)", function() {
registry.register('template:sub_template_from_container', c... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/helpers/text_area_test.js | @@ -29,17 +29,17 @@ QUnit.module("{{textarea}}", {
}
});
-QUnit.test("Should insert a textarea", function() {
+QUnit.skip("Should insert a textarea", function() {
equal(textArea.$('textarea').length, 1, "There is a single textarea");
});
-QUnit.test("Should become disabled when the controller changes", func... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/helpers/unbound_test.js | @@ -57,7 +57,7 @@ QUnit.test('it should not re-render if the property changes', function() {
equal(view.$().text(), 'BORK BORK', 'should not re-render if the property changes');
});
-QUnit.test('it should throw the helper missing error if multiple properties are provided', function() {
+QUnit.skip('it should thro... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/helpers/view_test.js | @@ -92,7 +92,7 @@ QUnit.test("should not enter an infinite loop when binding an attribute in Handl
runDestroy(parentView);
});
-QUnit.test("By default view:toplevel is used", function() {
+QUnit.skip("By default view:toplevel is used", function() {
var DefaultView = viewClass({
elementId: 'toplevel-view',... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/helpers/with_test.js | @@ -43,7 +43,7 @@ function testWithAs(moduleName, templateString) {
equal(view.$().text(), "Señor Engineer: Tom Dale", "should be properly scoped");
});
- QUnit.test("updating the context should update the alias", function() {
+ QUnit.skip("updating the context should update the alias", function() {
ru... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/helpers/yield_test.js | @@ -37,7 +37,7 @@ QUnit.module("ember-htmlbars: Support for {{yield}} helper", {
QUnit.test("a view with a layout set renders its template where the {{yield}} helper appears", function() {
var ViewWithLayout = EmberView.extend({
- layout: compile('<div class="wrapper"><h1>{{title}}</h1>{{yield}}</div>')
+ l... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/hooks/element_test.js | @@ -15,7 +15,7 @@ QUnit.module('ember-htmlbars: element hook', {
}
});
-QUnit.test('allows unbound usage within an element', function() {
+QUnit.skip('allows unbound usage within an element', function() {
expect(4);
function someHelper(params, hash, options, env) {
@@ -41,7 +41,7 @@ QUnit.test('allows unb... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/integration/binding_integration_test.js | @@ -87,7 +87,7 @@ QUnit.test("should be able to update when bound property updates", function() {
equal(view.$('i').text(), 'second, second - computed', "view rerenders when bound properties change");
});
-QUnit.test('should cleanup bound properties on rerender', function() {
+QUnit.skip('should cleanup bound pro... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/integration/block_params_test.js | @@ -43,7 +43,7 @@ QUnit.module("ember-htmlbars: block params", {
}
});
-QUnit.test("should raise error if helper not available", function() {
+QUnit.skip("should raise error if helper not available", function() {
view = View.create({
template: compile('{{#shouldfail}}{{/shouldfail}}')
});
@@ -54,7 +54,... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/integration/escape_integration_test.js | @@ -81,7 +81,7 @@ QUnit.test('should read from an Object.create(null)', function() {
equal(view.$().text(), 'baz');
});
-QUnit.test('should escape HTML in primitive value contexts when using normal mustaches', function() {
+QUnit.skip('should escape HTML in primitive value contexts when using normal mustaches', f... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/integration/select_in_template_test.js | @@ -25,7 +25,7 @@ QUnit.module("ember-htmlbars: Ember.Select - usage inside templates", {
}
});
-QUnit.test("works from a template with bindings [DEPRECATED]", function() {
+QUnit.skip("works from a template with bindings [DEPRECATED]", function() {
var Person = EmberObject.extend({
id: null,
firstNa... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/integration/with_view_test.js | @@ -28,7 +28,7 @@ QUnit.module('ember-htmlbars: {{#with}} and {{#view}} integration', {
}
});
-QUnit.test('View should update when the property used with the #with helper changes [DEPRECATED]', function() {
+QUnit.skip('View should update when the property used with the #with helper changes [DEPRECATED]', functio... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/system/append-templated-view-test.js | @@ -10,7 +10,7 @@ QUnit.module('ember-htmlbars: appendTemplatedView', {
}
});
-QUnit.test('can accept a view instance', function() {
+QUnit.skip('can accept a view instance', function() {
var controller = {
someProp: 'controller context',
someView: EmberView.create({
@@ -28,7 +28,7 @@ QUnit.test('can... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/system/lookup-helper_test.js | @@ -55,7 +55,7 @@ QUnit.test('does not lookup in the container if the name does not contain a dash
equal(actual, undefined, 'does not blow up if view does not have a container');
});
-QUnit.test('does a lookup in the container if the name contains a dash (and helper is not found in env)', function() {
+QUnit.skip... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/system/make_bound_helper_test.js | @@ -33,7 +33,7 @@ QUnit.module("ember-htmlbars: makeBoundHelper", {
}
});
-QUnit.test("should update bound helpers in a subexpression when properties change", function() {
+QUnit.skip("should update bound helpers in a subexpression when properties change", function() {
registry.register('helper:x-dasherize', m... | true |
Other | emberjs | ember.js | 3a90910e7ffe5ca80d6d36837801fb41eddacb09.json | Skip all failing tests
In order to ensure that we do not cause regressions as we continue to
work, we have marked all existing failing tests with `QUnit.skip`. | packages/ember-htmlbars/tests/system/make_view_helper_test.js | @@ -2,7 +2,7 @@ import makeViewHelper from "ember-htmlbars/system/make-view-helper";
QUnit.module("ember-htmlbars: makeViewHelper");
-QUnit.test("makes helpful assertion when called with invalid arguments", function() {
+QUnit.skip("makes helpful assertion when called with invalid arguments", function() {
var v... | true |
Other | emberjs | ember.js | a0e85833a7438279ccd1a99dea3e8d6f78440d06.json | Make better use of the built-in stability check | packages/ember-htmlbars/lib/keywords/component.js | @@ -1,11 +1,9 @@
export default {
- setupState: function(state, env, scope, params, hash) {
- state.lastComponentPath = state.componentPath;
- state.componentPath = env.hooks.getValue(params[0]);
- },
-
- isStable: function(state, env, scope, params, hash) {
- return state.componentPath === state.lastCompo... | true |
Other | emberjs | ember.js | a0e85833a7438279ccd1a99dea3e8d6f78440d06.json | Make better use of the built-in stability check | packages/ember-htmlbars/lib/keywords/outlet.js | @@ -26,8 +26,7 @@ export default {
toRender.template = topLevelViewTemplate;
}
- state.lastOutletState = state.outletState;
- state.outletState = selectedOutletState;
+ return { outletState: selectedOutletState };
},
updateEnv: function(state, env) { | true |
Other | emberjs | ember.js | a0e85833a7438279ccd1a99dea3e8d6f78440d06.json | Make better use of the built-in stability check | packages/ember-htmlbars/lib/keywords/partial.js | @@ -8,12 +8,7 @@ import { internal } from "htmlbars-runtime";
export default {
setupState: function(state, env, scope, params, hash) {
- state.lastPartialName = state.partialName;
- state.partialName = env.hooks.getValue(params[0]);
- },
-
- isStable: function(state, env) {
- return state.lastPartialNa... | true |
Other | emberjs | ember.js | a0e85833a7438279ccd1a99dea3e8d6f78440d06.json | Make better use of the built-in stability check | packages/ember-htmlbars/lib/keywords/view.js | @@ -10,14 +10,11 @@ import ComponentNode from "ember-htmlbars/system/component-node";
export default {
setupState: function(state, env, scope, params, hash) {
var read = env.hooks.getValue;
- state.parentView = read(scope.locals.view);
- state.lastViewClassOrInstance = state.viewClassOrInstance;
- s... | true |
Other | emberjs | ember.js | a0e85833a7438279ccd1a99dea3e8d6f78440d06.json | Make better use of the built-in stability check | packages/ember-htmlbars/lib/keywords/with.js | @@ -17,8 +17,10 @@ export default {
});
params[0] = controllerInstance;
- state.controller = controllerInstance;
+ return { controller: controllerInstance };
}
+
+ return { controller: null };
},
isStable: function() { | true |
Other | emberjs | ember.js | 13ff979099826cf89838776b4fd110559609e6c3.json | Create an Ember subclass of Morph
This allows us to store general-purpose internal needs of Ember on the
morph itself, leaving the remaining morph's state available to be diffed
for `isStable` checks. | packages/ember-application/lib/system/application.js | @@ -20,7 +20,7 @@ import EnumerableUtils from "ember-metal/enumerable_utils";
import ObjectController from "ember-runtime/controllers/object_controller";
import ArrayController from "ember-runtime/controllers/array_controller";
import Renderer from "ember-metal-views/renderer";
-import DOMHelper from "dom-helper";
+... | true |
Other | emberjs | ember.js | 13ff979099826cf89838776b4fd110559609e6c3.json | Create an Ember subclass of Morph
This allows us to store general-purpose internal needs of Ember on the
morph itself, leaving the remaining morph's state available to be diffed
for `isStable` checks. | packages/ember-htmlbars/lib/env.js | @@ -1,7 +1,5 @@
import environment from "ember-metal/environment";
-import DOMHelper from "dom-helper";
-
import { hooks } from "htmlbars-runtime";
import merge from "ember-metal/merge";
@@ -28,6 +26,8 @@ import invokeHelper from "ember-htmlbars/hooks/invoke-helper";
import helpers from "ember-htmlbars/helpers"... | true |
Other | emberjs | ember.js | 13ff979099826cf89838776b4fd110559609e6c3.json | Create an Ember subclass of Morph
This allows us to store general-purpose internal needs of Ember on the
morph itself, leaving the remaining morph's state available to be diffed
for `isStable` checks. | packages/ember-htmlbars/lib/hooks/cleanup-render-node.js | @@ -4,21 +4,5 @@
*/
export default function cleanupRenderNode(renderNode) {
- var state = renderNode.state;
- if (!state) { return; }
-
- if (state.view) {
- var view = state.view;
- view.destroy();
- }
-
- if (state.toDestroy) {
- var toDestroy = state.toDestroy;
-
- for (var i=0, l=toDestroy.leng... | true |
Other | emberjs | ember.js | 13ff979099826cf89838776b4fd110559609e6c3.json | Create an Ember subclass of Morph
This allows us to store general-purpose internal needs of Ember on the
morph itself, leaving the remaining morph's state available to be diffed
for `isStable` checks. | packages/ember-htmlbars/lib/hooks/link-render-node.js | @@ -8,7 +8,7 @@ import { isArray } from "ember-metal/utils";
import { chain, read, isStream, addDependency } from "ember-metal/streams/utils";
export default function linkRenderNode(renderNode, env, scope, path, params, hash) {
- if (renderNode.state.unsubscribers) {
+ if (renderNode.streamUnsubscribers) {
r... | true |
Other | emberjs | ember.js | 13ff979099826cf89838776b4fd110559609e6c3.json | Create an Ember subclass of Morph
This allows us to store general-purpose internal needs of Ember on the
morph itself, leaving the remaining morph's state available to be diffed
for `isStable` checks. | packages/ember-htmlbars/lib/keywords/outlet.js | @@ -48,9 +48,9 @@ export default {
rerender: function(morph, env, scope, params, hash, template, inverse, visitor) {
var newEnv = env;
- if (morph.state.view) {
+ if (morph.emberView) {
newEnv = merge({}, env);
- newEnv.view = morph.state.view;
+ newEnv.view = morph.emberView;
}
... | true |
Other | emberjs | ember.js | 13ff979099826cf89838776b4fd110559609e6c3.json | Create an Ember subclass of Morph
This allows us to store general-purpose internal needs of Ember on the
morph itself, leaving the remaining morph's state available to be diffed
for `isStable` checks. | packages/ember-htmlbars/lib/keywords/view.js | @@ -31,7 +31,7 @@ export default {
var view = hash.view = viewInstance(node.state.viewClassOrInstance);
parentView.linkChild(view);
- state.view = view;
+ node.emberView = view;
var options = { component: view, layout: null };
var componentNode = ComponentNode.create(node, env, hash, optio... | true |
Other | emberjs | ember.js | 13ff979099826cf89838776b4fd110559609e6c3.json | Create an Ember subclass of Morph
This allows us to store general-purpose internal needs of Ember on the
morph itself, leaving the remaining morph's state available to be diffed
for `isStable` checks. | packages/ember-htmlbars/lib/keywords/with.js | @@ -18,8 +18,6 @@ export default {
params[0] = controllerInstance;
state.controller = controllerInstance;
- state.toDestroy = [state.controller];
-
}
},
@@ -32,6 +30,8 @@ export default {
},
render: function(morph, env, scope, params, hash, template, inverse, visitor) {
+ if (m... | true |
Other | emberjs | ember.js | 13ff979099826cf89838776b4fd110559609e6c3.json | Create an Ember subclass of Morph
This allows us to store general-purpose internal needs of Ember on the
morph itself, leaving the remaining morph's state available to be diffed
for `isStable` checks. | packages/ember-htmlbars/lib/morphs/morph.js | @@ -0,0 +1,39 @@
+import DOMHelper from "dom-helper";
+import o_create from 'ember-metal/platform/create';
+
+var HTMLBarsMorph = DOMHelper.prototype.MorphClass;
+
+function EmberMorph(DOMHelper, contextualElement) {
+ this.HTMLBarsMorph$constructor(DOMHelper, contextualElement);
+
+ this.emberView = null;
+ this.em... | true |
Other | emberjs | ember.js | 13ff979099826cf89838776b4fd110559609e6c3.json | Create an Ember subclass of Morph
This allows us to store general-purpose internal needs of Ember on the
morph itself, leaving the remaining morph's state available to be diffed
for `isStable` checks. | packages/ember-htmlbars/lib/system/component-node.js | @@ -83,9 +83,9 @@ ComponentNode.prototype.rerender = function(env, attrs, visitor) {
// Notify component that it has become dirty and is about to change.
env.renderer.willUpdate(component, snapshot);
- if (component.renderNode.state.shouldReceiveAttrs) {
+ if (component.renderNode.shouldReceiveAttrs) ... | true |
Other | emberjs | ember.js | 13ff979099826cf89838776b4fd110559609e6c3.json | Create an Ember subclass of Morph
This allows us to store general-purpose internal needs of Ember on the
morph itself, leaving the remaining morph's state available to be diffed
for `isStable` checks. | packages/ember-htmlbars/lib/system/dom-helper.js | @@ -0,0 +1,12 @@
+import DOMHelper from "dom-helper";
+import EmberMorph from "ember-htmlbars/morphs/morph";
+import o_create from 'ember-metal/platform/create';
+
+function EmberDOMHelper(_document) {
+ DOMHelper.call(this, _document);
+}
+
+var proto = EmberDOMHelper.prototype = o_create(DOMHelper.prototype);
+proto... | true |
Other | emberjs | ember.js | 13ff979099826cf89838776b4fd110559609e6c3.json | Create an Ember subclass of Morph
This allows us to store general-purpose internal needs of Ember on the
morph itself, leaving the remaining morph's state available to be diffed
for `isStable` checks. | packages/ember-htmlbars/lib/utils/subscribe.js | @@ -3,7 +3,7 @@ import { isStream } from "ember-metal/streams/utils";
export default function subscribe(node, scope, stream) {
if (!isStream(stream)) { return; }
var component = scope.component;
- var unsubscribers = node.state.unsubscribers = node.state.unsubscribers || [];
+ var unsubscribers = node.streamUn... | true |
Other | emberjs | ember.js | 13ff979099826cf89838776b4fd110559609e6c3.json | Create an Ember subclass of Morph
This allows us to store general-purpose internal needs of Ember on the
morph itself, leaving the remaining morph's state available to be diffed
for `isStable` checks. | packages/ember-metal-views/lib/renderer.js | @@ -1,5 +1,3 @@
-import DOMHelper from "dom-helper";
-import environment from "ember-metal/environment";
import run from "ember-metal/run_loop";
import { get } from "ember-metal/property_get";
import { set } from "ember-metal/property_set";
@@ -9,15 +7,13 @@ import {
} from "ember-metal/instrumentation";
import bu... | true |
Other | emberjs | ember.js | 13ff979099826cf89838776b4fd110559609e6c3.json | Create an Ember subclass of Morph
This allows us to store general-purpose internal needs of Ember on the
morph itself, leaving the remaining morph's state available to be diffed
for `isStable` checks. | packages/ember-views/lib/main.js | @@ -16,7 +16,6 @@ import {
getViewBoundingClientRect
} from "ember-views/system/utils";
import RenderBuffer from "ember-views/system/render_buffer";
-import DOMHelper from "dom-helper";
import "ember-views/system/ext"; // for the side effect of extending Ember.run.queues
import {
cloneStates,
@@ -71,7 +70,6 ... | true |
Other | emberjs | ember.js | 13ff979099826cf89838776b4fd110559609e6c3.json | Create an Ember subclass of Morph
This allows us to store general-purpose internal needs of Ember on the
morph itself, leaving the remaining morph's state available to be diffed
for `isStable` checks. | packages/ember-views/lib/views/core_view.js | @@ -1,5 +1,4 @@
import Renderer from "ember-metal-views/renderer";
-import DOMHelper from "dom-helper";
import {
cloneStates,
@@ -53,6 +52,7 @@ var CoreView = EmberObject.extend(Evented, ActionHandler, {
// Fallback for legacy cases where the view was created directly
// via `create()` instead of going... | true |
Other | emberjs | ember.js | 13ff979099826cf89838776b4fd110559609e6c3.json | Create an Ember subclass of Morph
This allows us to store general-purpose internal needs of Ember on the
morph itself, leaving the remaining morph's state available to be diffed
for `isStable` checks. | packages/ember-views/lib/views/states/has_element.js | @@ -34,11 +34,11 @@ merge(hasElement, {
renderNode.isDirty = true;
internal.visitChildren(renderNode.childNodes, function(node) {
if (node.state.componentNode) {
- node.state.shouldReceiveAttrs = true;
+ node.shouldReceiveAttrs = true;
}
node.isDirty = true;
});
- re... | true |
Other | emberjs | ember.js | 8eebe7435d1f2edbd252686d34617773cbf3954c.json | Fix style errors | packages/ember-htmlbars/lib/helpers/bind-attr-class.js | @@ -3,6 +3,7 @@
@submodule ember-htmlbars
*/
+import { get } from 'ember-metal/property_get';
import { isArray } from "ember-metal/utils";
export default function bindAttrClassHelper(params) { | true |
Other | emberjs | ember.js | 8eebe7435d1f2edbd252686d34617773cbf3954c.json | Fix style errors | packages/ember-htmlbars/lib/helpers/loc.js | @@ -1,4 +1,3 @@
-import Ember from 'ember-metal/core';
import { loc } from 'ember-runtime/system/string';
/**
@@ -34,4 +33,4 @@ import { loc } from 'ember-runtime/system/string';
*/
export default function locHelper(params) {
return loc.apply(null, params);
-}
\ No newline at end of file
+} | true |
Other | emberjs | ember.js | 8eebe7435d1f2edbd252686d34617773cbf3954c.json | Fix style errors | packages/ember-htmlbars/lib/hooks/get-root.js | @@ -35,7 +35,7 @@ function getKey(scope, key) {
}
function getGlobal(name) {
- Ember.deprecate("Global lookup of " + name + " from a Handlebars template is deprecated")
+ Ember.deprecate("Global lookup of " + name + " from a Handlebars template is deprecated");
// This stream should be memoized, but this pat... | true |
Other | emberjs | ember.js | 8eebe7435d1f2edbd252686d34617773cbf3954c.json | Fix style errors | packages/ember-metal/tests/streams/key-stream-test.js | @@ -96,7 +96,7 @@ QUnit.test("is notified when setSource is called with a new stream whose value i
equal(count, 0, "Subscribers called correct number of times");
equal(nameStream.value(), "mmun", "Stream value is correct");
- object = { name: "wycats" }
+ object = { name: "wycats" };
nameStream.setSource(n... | true |
Other | emberjs | ember.js | 8eebe7435d1f2edbd252686d34617773cbf3954c.json | Fix style errors | packages/ember-template-compiler/lib/plugins/transform-bind-attr-to-attributes.js | @@ -142,6 +142,7 @@ TransformBindAttrToAttributes.prototype.parseClass = function parseClass(value)
b.string('')
]);
}
+ break;
case 3:
// Before: {{bind-attr class="some.path:foo:bar ..."}}
// After: class="{{if some.path "foo" "bar"}} ..."
@@ -166,7 +167,7 @@ functio... | true |
Other | emberjs | ember.js | 8eebe7435d1f2edbd252686d34617773cbf3954c.json | Fix style errors | packages/ember-template-compiler/lib/plugins/transform-each-in-to-block-params.js | @@ -47,7 +47,7 @@ TransformEachInToBlockParams.prototype.transform = function TransformEachInToBlo
throw new Error('You cannot use keyword (`{{each foo in bar}}`) and block params (`{{each bar as |foo|}}`) at the same time.');
}
- node.program.blockParams = [ keyword ];
+ node.progra... | true |
Other | emberjs | ember.js | 8eebe7435d1f2edbd252686d34617773cbf3954c.json | Fix style errors | packages/ember-views/lib/system/build-component-template.js | @@ -163,7 +163,7 @@ function normalizeClass(component, classAttr) {
var prop = 'view.' + microsyntax[0];
var activeClass, inactiveClass;
- if (microsyntax.length === 1) {
+ if (microsyntax.length === 1) {
activeClass = prop;
} else if (microsyntax.length === 2) {
acti... | true |
Other | emberjs | ember.js | f529ab6b85fc279cfd3eb54c31b5686c96494304.json | Implement bound partial semantics
Included in this commit: a change that differentiates between a render
node that is being cleared and one that is being destroyed. A render
node being cleared will want to tear down any associated components,
while a node being destroyed will also want to unsubscribe from linked
param... | packages/ember-htmlbars/lib/env.js | @@ -17,7 +17,8 @@ import updateSelf from "ember-htmlbars/hooks/update-self";
import getRoot from "ember-htmlbars/hooks/get-root";
import getChild from "ember-htmlbars/hooks/get-child";
import getValue from "ember-htmlbars/hooks/get-value";
-import cleanup from "ember-htmlbars/hooks/cleanup";
+import cleanupRenderNod... | true |
Other | emberjs | ember.js | f529ab6b85fc279cfd3eb54c31b5686c96494304.json | Implement bound partial semantics
Included in this commit: a change that differentiates between a render
node that is being cleared and one that is being destroyed. A render
node being cleared will want to tear down any associated components,
while a node being destroyed will also want to unsubscribe from linked
param... | packages/ember-htmlbars/lib/hooks/cleanup-render-node.js | @@ -0,0 +1,24 @@
+/**
+@module ember
+@submodule ember-htmlbars
+*/
+
+export default function cleanupRenderNode(renderNode) {
+ var state = renderNode.state;
+ if (!state) { return; }
+
+ if (state.view) {
+ var view = state.view;
+ view.destroy();
+ }
+
+ if (state.toDestroy) {
+ var toDestroy = state.t... | true |
Other | emberjs | ember.js | f529ab6b85fc279cfd3eb54c31b5686c96494304.json | Implement bound partial semantics
Included in this commit: a change that differentiates between a render
node that is being cleared and one that is being destroyed. A render
node being cleared will want to tear down any associated components,
while a node being destroyed will also want to unsubscribe from linked
param... | packages/ember-htmlbars/lib/hooks/cleanup.js | @@ -1,33 +0,0 @@
-/**
-@module ember
-@submodule ember-htmlbars
-*/
-
-export default function cleanup(renderNode) {
- var state = renderNode.state;
- if (!state) { return; }
-
- if (state.view) {
- var view = state.view;
- view.destroy();
- }
-
- var i, l;
-
- if (state.toDestroy) {
- var toDestroy = st... | true |
Other | emberjs | ember.js | f529ab6b85fc279cfd3eb54c31b5686c96494304.json | Implement bound partial semantics
Included in this commit: a change that differentiates between a render
node that is being cleared and one that is being destroyed. A render
node being cleared will want to tear down any associated components,
while a node being destroyed will also want to unsubscribe from linked
param... | packages/ember-htmlbars/lib/hooks/destroy-render-node.js | @@ -0,0 +1,16 @@
+/**
+@module ember
+@submodule ember-htmlbars
+*/
+
+export default function destroyRenderNode(renderNode) {
+ var state = renderNode.state;
+ if (!state) { return; }
+
+ var unsubscribers = state.unsubscribers;
+ if (!unsubscribers) { return; }
+
+ for (var i=0, l=unsubscribers.length; i<l; i++)... | true |
Other | emberjs | ember.js | f529ab6b85fc279cfd3eb54c31b5686c96494304.json | Implement bound partial semantics
Included in this commit: a change that differentiates between a render
node that is being cleared and one that is being destroyed. A render
node being cleared will want to tear down any associated components,
while a node being destroyed will also want to unsubscribe from linked
param... | packages/ember-htmlbars/lib/keywords/partial.js | @@ -6,12 +6,24 @@
import lookupPartial from "ember-views/system/lookup_partial";
import { internal } from "htmlbars-runtime";
-export default function partialKeyword(morph, env, scope, params, hash, template, inverse, visitor) {
- var found = lookupPartial(env, env.hooks.getValue(params[0])).raw;
+export default {... | true |
Other | emberjs | ember.js | f529ab6b85fc279cfd3eb54c31b5686c96494304.json | Implement bound partial semantics
Included in this commit: a change that differentiates between a render
node that is being cleared and one that is being destroyed. A render
node being cleared will want to tear down any associated components,
while a node being destroyed will also want to unsubscribe from linked
param... | packages/ember-htmlbars/tests/compat/make_bound_helper_test.js | @@ -15,6 +15,7 @@ import {
} from 'ember-runtime/system/string';
import EmberHandlebars from "ember-htmlbars/compat";
+import { deprecation as eachDeprecation } from "ember-htmlbars/helpers/each";
var compile, helpers, helper;
compile = EmberHandlebars.compile;
@@ -53,7 +54,7 @@ QUnit.module("ember-htmlbars: co... | true |
Other | emberjs | ember.js | f529ab6b85fc279cfd3eb54c31b5686c96494304.json | Implement bound partial semantics
Included in this commit: a change that differentiates between a render
node that is being cleared and one that is being destroyed. A render
node being cleared will want to tear down any associated components,
while a node being destroyed will also want to unsubscribe from linked
param... | packages/ember-views/lib/system/lookup_partial.js | @@ -2,6 +2,8 @@ import Ember from "ember-metal/core"; // Ember.assert
import EmberError from "ember-metal/error";
export default function lookupPartial(env, templateName) {
+ if (templateName == null) { return; }
+
var nameParts = templateName.split("/");
var lastPart = nameParts[nameParts.length - 1];
| true |
Other | emberjs | ember.js | a82291a8b484236215623b6ecd77b50494184e1f.json | Fix context-switching #each | packages/ember-htmlbars/lib/env.js | @@ -13,6 +13,7 @@ import bindShadowScope from "ember-htmlbars/hooks/bind-shadow-scope";
import bindSelf from "ember-htmlbars/hooks/bind-self";
import bindScope from "ember-htmlbars/hooks/bind-scope";
import bindLocal from "ember-htmlbars/hooks/bind-local";
+import updateSelf from "ember-htmlbars/hooks/update-self";
... | true |
Other | emberjs | ember.js | a82291a8b484236215623b6ecd77b50494184e1f.json | Fix context-switching #each | packages/ember-htmlbars/lib/helpers/each.js | @@ -12,7 +12,15 @@ export default function eachHelper(params, hash, blocks) {
}
forEach(list, function(item, i) {
+ var self;
+ if (blocks.template.arity === 0) {
+ Ember.deprecate(deprecation);
+ self = item;
+ }
+
var key = keyPath ? get(item, keyPath) : String(i);
- blocks.template... | true |
Other | emberjs | ember.js | a82291a8b484236215623b6ecd77b50494184e1f.json | Fix context-switching #each | packages/ember-htmlbars/lib/hooks/bind-self.js | @@ -4,17 +4,24 @@
*/
import { get } from "ember-metal/property_get";
-import updateScope from "ember-htmlbars/utils/update-scope";
+import SimpleStream from "ember-metal/streams/simple-stream";
+import subscribe from "ember-htmlbars/utils/subscribe";
export default function bindSelf(env, scope, self) {
Ember.... | true |
Other | emberjs | ember.js | a82291a8b484236215623b6ecd77b50494184e1f.json | Fix context-switching #each | packages/ember-htmlbars/lib/hooks/update-self.js | @@ -0,0 +1,20 @@
+/**
+@module ember
+@submodule ember-htmlbars
+*/
+
+import { get } from "ember-metal/property_get";
+import updateScope from "ember-htmlbars/utils/update-scope";
+
+export default function bindSelf(env, scope, self) {
+ Ember.assert("BUG: scope.attrs and self.isView should not both be true", !(scope... | true |
Other | emberjs | ember.js | a82291a8b484236215623b6ecd77b50494184e1f.json | Fix context-switching #each | packages/ember-htmlbars/tests/helpers/each_test.js | @@ -16,6 +16,7 @@ import { set } from "ember-metal/property_set";
import { runAppend, runDestroy } from "ember-runtime/tests/utils";
import compile from "ember-template-compiler/system/compile";
+import { deprecation as eachDeprecation } from "ember-htmlbars/helpers/each";
var people, view, registry, container;
... | true |
Other | emberjs | ember.js | 0f09b6d79e4a387cc600dac8e82db5061c86da87.json | Add support for binding to global paths | packages/ember-htmlbars/lib/hooks/get-root.js | @@ -4,13 +4,15 @@
*/
import Ember from "ember-metal/core";
+import { isGlobal } from "ember-metal/path_cache";
+import SimpleStream from "ember-metal/streams/simple-stream";
export default function getRoot(scope, key) {
if (key === 'this') {
return [scope.self];
- }
-
- if (scope.locals[key]) {
+ } el... | true |
Other | emberjs | ember.js | 0f09b6d79e4a387cc600dac8e82db5061c86da87.json | Add support for binding to global paths | packages/ember-htmlbars/tests/helpers/bind_attr_test.js | @@ -142,7 +142,7 @@ QUnit.test("should be able to bind to globals with {{bind-attr}}", function() {
expectDeprecation(function() {
runAppend(view);
- }, /Global lookup of TemplateTests.value from a Handlebars template is deprecated/);
+ }, /Global lookup of TemplateTests from a Handlebars template is deprec... | true |
Other | emberjs | ember.js | 0f09b6d79e4a387cc600dac8e82db5061c86da87.json | Add support for binding to global paths | packages/ember-htmlbars/tests/helpers/collection_test.js | @@ -86,7 +86,7 @@ QUnit.test("itemViewClass works in the #collection helper with a global (DEPRECA
template: compile('{{#collection content=view.exampleController itemViewClass=TemplateTests.ExampleItemView}}beta{{/collection}}')
});
- var deprecation = /Global lookup of TemplateTests.ExampleItemView from a ... | true |
Other | emberjs | ember.js | 0f09b6d79e4a387cc600dac8e82db5061c86da87.json | Add support for binding to global paths | packages/ember-htmlbars/tests/helpers/view_test.js | @@ -144,7 +144,7 @@ QUnit.test("View lookup - App.FuView (DEPRECATED)", function() {
expectDeprecation(function() {
runAppend(view);
- }, /Global lookup of App.FuView from a Handlebars template is deprecated./);
+ }, /Global lookup of App from a Handlebars template is deprecated./);
equal(jQuery('#fu')... | true |
Other | emberjs | ember.js | 0f09b6d79e4a387cc600dac8e82db5061c86da87.json | Add support for binding to global paths | packages/ember-htmlbars/tests/helpers/with_test.js | @@ -144,7 +144,7 @@ QUnit.module("Handlebars {{#with}} globals helper [DEPRECATED]", {
QUnit.test("it should support #with Foo.bar as qux [DEPRECATED]", function() {
expectDeprecation(function() {
runAppend(view);
- }, /Global lookup of Foo.bar from a Handlebars template is deprecated/);
+ }, /Global lookup ... | true |
Other | emberjs | ember.js | 0f09b6d79e4a387cc600dac8e82db5061c86da87.json | Add support for binding to global paths | packages/ember-htmlbars/tests/integration/globals_integration_test.js | @@ -41,7 +41,7 @@ QUnit.test('should read from globals with a path (DEPRECATED)', function() {
expectDeprecation(function() {
runAppend(view);
- }, 'Global lookup of Global.Space from a Handlebars template is deprecated.');
+ }, 'Global lookup of Global from a Handlebars template is deprecated.');
equal(... | true |
Other | emberjs | ember.js | 0f09b6d79e4a387cc600dac8e82db5061c86da87.json | Add support for binding to global paths | packages/ember-metal/lib/streams/stream.js | @@ -360,16 +360,6 @@ Stream.prototype = {
this.dependencies = null;
return true;
}
- },
-
- isGlobal() {
- var stream = this;
- while (stream !== undefined) {
- if (stream._isRoot) {
- return stream._isGlobal;
- }
- stream = stream.source;
- }
}
};
| true |
Other | emberjs | ember.js | f7513aff1c72ad03c1d2d411cf4f06a00d450eeb.json | Implement more functionality
* view.createElement
* view.replaceIn
* deprecated {{linkTo}}
* fix active state when route transitions | packages/ember-metal-views/lib/renderer.js | @@ -25,7 +25,7 @@ Renderer.prototype.renderTopLevelView =
var block = buildComponentTemplate(componentInfo, {}, {
self: view,
- template: template.raw
+ template: template && template.raw
}).block;
view.renderBlock(block, renderNode);
@@ -67,6 +67,20 @@ Renderer.prototype.appendTo =
... | true |
Other | emberjs | ember.js | f7513aff1c72ad03c1d2d411cf4f06a00d450eeb.json | Implement more functionality
* view.createElement
* view.replaceIn
* deprecated {{linkTo}}
* fix active state when route transitions | packages/ember-routing-htmlbars/lib/main.js | @@ -7,6 +7,7 @@ Ember Routing HTMLBars Helpers
*/
import Ember from "ember-metal/core";
+import merge from "ember-metal/merge";
import { registerHelper } from "ember-htmlbars/helpers";
import { registerKeyword } from "ember-htmlbars/keywords";
@@ -21,6 +22,16 @@ registerHelper('action', actionHelper);
register... | true |
Other | emberjs | ember.js | f7513aff1c72ad03c1d2d411cf4f06a00d450eeb.json | Implement more functionality
* view.createElement
* view.replaceIn
* deprecated {{linkTo}}
* fix active state when route transitions | packages/ember-routing-views/lib/views/link.js | @@ -239,7 +239,7 @@ var LinkComponent = EmberComponent.extend({
@property active
**/
- active: computed('attrs.params', function computeLinkViewActive() {
+ active: computed('attrs.params', '_routing.currentState', function computeLinkViewActive() {
var currentState = get(this, '_routing.currentState')... | true |
Other | emberjs | ember.js | f7513aff1c72ad03c1d2d411cf4f06a00d450eeb.json | Implement more functionality
* view.createElement
* view.replaceIn
* deprecated {{linkTo}}
* fix active state when route transitions | packages/ember-views/lib/views/view.js | @@ -1130,8 +1130,7 @@ var View = CoreView.extend(
createElement() {
if (this.element) { return this; }
- this._didCreateElementWithoutMorph = true;
- this.renderer.renderTree(this);
+ this.renderer.createElement(this);
return this;
}, | true |
Other | emberjs | ember.js | ae87fc90ca0b925e0ec3260466aeb71fc5850b08.json | Implement loading states for LinkView | packages/ember-htmlbars/lib/hooks/get-root.js | @@ -24,13 +24,11 @@ function getKey(scope, key) {
var self = scope.self;
- if (!scope.attrs) {
- return self.getKey(key);
- }
-
- if (key in scope.attrs) {
+ if (scope.attrs && key in scope.attrs) {
Ember.deprecate("You accessed the `" + key + "` attribute directly. Please use `attrs." + key + "` ins... | true |
Other | emberjs | ember.js | ae87fc90ca0b925e0ec3260466aeb71fc5850b08.json | Implement loading states for LinkView | packages/ember-htmlbars/lib/keywords/outlet.js | @@ -68,7 +68,7 @@ export default {
self: toRender.controller
};
- var componentNode = ComponentNode.create(renderNode, env, null, options, parentView, null, null, template);
+ var componentNode = ComponentNode.create(renderNode, env, {}, options, parentView, null, null, template);
state.compone... | true |
Other | emberjs | ember.js | ae87fc90ca0b925e0ec3260466aeb71fc5850b08.json | Implement loading states for LinkView | packages/ember-routing-views/lib/views/link.js | @@ -6,6 +6,7 @@
import Ember from "ember-metal/core"; // FEATURES, Logger, assert
import { get } from "ember-metal/property_get";
+import { set } from "ember-metal/property_set";
import { computed } from "ember-metal/computed";
import { isSimpleClick } from "ember-views/system/utils";
import EmberComponent from ... | true |
Other | emberjs | ember.js | ae87fc90ca0b925e0ec3260466aeb71fc5850b08.json | Implement loading states for LinkView | packages/ember/tests/helpers/link_to_test.js | @@ -928,12 +928,10 @@ QUnit.test("The {{link-to}} helper works in an #each'd array of string route nam
});
Ember.TEMPLATES = {
- index: compile('{{#each routeName in routeNames}}{{#link-to routeName}}{{routeName}}{{/link-to}}{{/each}}{{#each routeNames}}{{#link-to this}}{{this}}{{/link-to}}{{/each}}{{#link-t... | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-htmlbars/lib/env.js | @@ -23,8 +23,10 @@ import lookupHelper from "ember-htmlbars/hooks/lookup-helper";
import hasHelper from "ember-htmlbars/hooks/has-helper";
import helpers from "ember-htmlbars/helpers";
+import keywords, { registerKeyword } from "ember-htmlbars/keywords";
var emberHooks = merge({}, hooks);
+emberHooks.keywords = ... | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-htmlbars/lib/helpers/-normalize-class.js | @@ -0,0 +1,18 @@
+/** @private
+ This private helper is used by ComponentNode to convert the classNameBindings
+ microsyntax into a class name.
+
+ When a component or view is created, we normalize class name bindings into a
+ series of attribute nodes that use this helper.
+*/
+export default function normalizeCla... | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-htmlbars/lib/hooks/link-render-node.js | @@ -4,18 +4,23 @@
*/
import subscribe from "ember-htmlbars/utils/subscribe";
-import shouldDisplay from "ember-views/streams/should_display";
-import { chain, read } from "ember-metal/streams/utils";
+import { isArray } from "ember-metal/utils";
+import { chain, read, isStream, addDependency } from "ember-metal/str... | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-htmlbars/lib/keywords.js | @@ -0,0 +1,31 @@
+/**
+@module ember
+@submodule ember-htmlbars
+*/
+
+import { hooks } from "htmlbars-runtime";
+import o_create from "ember-metal/platform/create";
+
+/**
+ @private
+ @property helpers
+*/
+var keywords = o_create(hooks.keywords);
+
+/**
+@module ember
+@submodule ember-htmlbars
+*/
+
+/**
+ @privat... | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-htmlbars/lib/keywords/outlet.js | @@ -4,7 +4,7 @@
*/
import merge from "ember-metal/merge";
-import ShadowRoot from "ember-htmlbars/system/shadow-root";
+import ComponentNode from "ember-htmlbars/system/component-node";
import topLevelViewTemplate from "ember-htmlbars/templates/top-level-view";
topLevelViewTemplate.revision = 'Ember@VERSION_STR... | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-htmlbars/lib/keywords/view.js | @@ -37,7 +37,7 @@ export default {
var componentNode = ComponentNode.create(node, env, hash, options, parentView, null, scope, template);
state.componentNode = componentNode;
- componentNode.render(env, hash, visitor, parentView._state === 'inDOM');
+ componentNode.render(env, hash, visitor);
}
};... | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-htmlbars/lib/main.js | @@ -21,6 +21,7 @@ import withHelper from "ember-htmlbars/helpers/with";
import logHelper from "ember-htmlbars/helpers/log";
import eachHelper from "ember-htmlbars/helpers/each";
import bindAttrClassHelper from "ember-htmlbars/helpers/bind-attr-class";
+import normalizeClassHelper from "ember-htmlbars/helpers/-normal... | true |
Other | emberjs | ember.js | f75b2e11955e0eb84af08039d90cdf1203465494.json | Unify component creation
Previously, we had in place three different methods for inserting views
or components into the render hierarchy. Top-level views went through
a legacy path that used RenderBuffer. Outlet’s went through our
abandoned ShadowRoot abstraction. The `{{view}}` helper and non-top-
level components we... | packages/ember-htmlbars/lib/system/component-node.js | @@ -1,8 +1,7 @@
-import { get } from "ember-metal/property_get";
import merge from "ember-metal/merge";
import Ember from "ember-metal/core";
+import buildComponentTemplate from "ember-views/system/build-component-template";
import { readHash } from "ember-metal/streams/utils";
-import { internal, render } from "htm... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.