language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | d31876afb241986978d7c4472fc12ddfc195f9c7.json | Resolve master merge conflicts | packages/ember-views/lib/views/view.js | @@ -730,13 +730,13 @@ var View = CoreView.extend(
*/
template: computed('templateName', {
- get: function() {
+ get() {
var templateName = get(this, 'templateName');
var template = this.templateForName(templateName, 'template');
Ember.assert("You specified the templateName " + templat... | true |
Other | emberjs | ember.js | d31876afb241986978d7c4472fc12ddfc195f9c7.json | Resolve master merge conflicts | packages/ember-views/tests/views/select_test.js | @@ -4,6 +4,7 @@ import run from "ember-metal/run_loop";
import jQuery from "ember-views/system/jquery";
import { map } from "ember-metal/enumerable_utils";
import EventDispatcher from "ember-views/system/event_dispatcher";
+import SafeString from 'htmlbars-util/safe-string';
var trim = jQuery.trim;
@@ -133,6 +1... | true |
Other | emberjs | ember.js | d31876afb241986978d7c4472fc12ddfc195f9c7.json | Resolve master merge conflicts | packages/ember-views/tests/views/view/replace_in_test.js | @@ -45,18 +45,26 @@ QUnit.test("raises an assert when a target does not exist in the DOM", function(
QUnit.test("should remove previous elements when calling replaceIn()", function() {
- jQuery("#qunit-fixture").html('<div id="menu"><p>Foo</p></div>');
- var viewElem = jQuery('#menu').children();
+ jQuery("#qun... | true |
Other | emberjs | ember.js | d31876afb241986978d7c4472fc12ddfc195f9c7.json | Resolve master merge conflicts | tests/node/app-boot-test.js | @@ -29,7 +29,8 @@ global.EmberENV = {
FEATURES: features
};
-var Ember, compile, domHelper, run;
+var Ember, compile, domHelper, run, DOMHelper, app;
+
var SimpleDOM = require('simple-dom');
var URL = require('url');
@@ -84,17 +85,18 @@ function registerTemplates(app, templates) {
function renderToElement(... | true |
Other | emberjs | ember.js | 97c10391c8d3a98c5ffba3a940f2b3dcf73485e2.json | Get remainder of query_params_test.js passing
And a link-to test | packages/ember-htmlbars/tests/system/make_view_helper_test.js | @@ -2,6 +2,7 @@ import makeViewHelper from "ember-htmlbars/system/make-view-helper";
QUnit.module("ember-htmlbars: makeViewHelper");
+// note: fixing this probably means breaking link-to component, which accepts params
QUnit.skip("makes helpful assertion when called with invalid arguments", function() {
var vi... | true |
Other | emberjs | ember.js | 97c10391c8d3a98c5ffba3a940f2b3dcf73485e2.json | Get remainder of query_params_test.js passing
And a link-to test | packages/ember-routing-htmlbars/lib/helpers/link-to.js | @@ -287,6 +287,7 @@ import 'ember-htmlbars';
@return {String} HTML string
@see {Ember.LinkView}
*/
+// this has been replaced by link-to component
function linkToHelper(params, hash) {
// TODO: Implement more than just stub functionality here
this.yieldIn(linkToTemplate, { href: "#", classes: hash.class }... | true |
Other | emberjs | ember.js | 97c10391c8d3a98c5ffba3a940f2b3dcf73485e2.json | Get remainder of query_params_test.js passing
And a link-to test | packages/ember-routing-views/lib/views/link.js | @@ -283,7 +283,7 @@ var LinkComponent = EmberComponent.extend({
}
}
- if (this.bubbles === false) { event.stopPropagation(); }
+ if (this.attrs.bubbles === false) { event.stopPropagation(); }
if (get(this, '_isDisabled')) { return false; }
@@ -297,7 +297,7 @@ var LinkComponent = EmberCompon... | true |
Other | emberjs | ember.js | 97c10391c8d3a98c5ffba3a940f2b3dcf73485e2.json | Get remainder of query_params_test.js passing
And a link-to test | packages/ember/tests/helpers/link_to_test.js | @@ -402,7 +402,7 @@ QUnit.test("The {{link-to}} helper defaults to bubbling", function() {
equal(hidden, 1, "The link bubbles");
});
-QUnit.skip("The {{link-to}} helper supports bubbles=false", function() {
+QUnit.test("The {{link-to}} helper supports bubbles=false", function() {
Ember.TEMPLATES.about = compil... | true |
Other | emberjs | ember.js | 97c10391c8d3a98c5ffba3a940f2b3dcf73485e2.json | Get remainder of query_params_test.js passing
And a link-to test | packages/ember/tests/routing/query_params_test.js | @@ -261,7 +261,7 @@ QUnit.test("model hooks receives query params", function() {
equal(router.get('location.path'), "");
});
-QUnit.skip("controllers won't be eagerly instantiated by internal query params logic", function() {
+QUnit.test("controllers won't be eagerly instantiated by internal query params logic", ... | true |
Other | emberjs | ember.js | 0f66c76d5c2453a06f001c1089510de8da8d22ae.json | Use nicer ES6 syntax for get/set on CPs | packages/ember-metal/lib/computed_macros.js | @@ -675,12 +675,12 @@ export function readOnly(dependentKey) {
*/
export function defaultTo(defaultPath) {
return computed({
- get: function(key) {
+ get(key) {
Ember.deprecate('Usage of Ember.computed.defaultTo is deprecated, use `Ember.computed.oneWay` instead.');
return get(this, defaultPath... | true |
Other | emberjs | ember.js | 0f66c76d5c2453a06f001c1089510de8da8d22ae.json | Use nicer ES6 syntax for get/set on CPs | packages/ember-routing-views/lib/views/link.js | @@ -271,10 +271,10 @@ var LinkView = EmberComponent.extend({
@property disabled
*/
disabled: computed({
- get: function(key, value) {
+ get(key, value) {
return false;
},
- set: function(key, value) {
+ set(key, value) {
if (value !== undefined) { this.set('_isDisabled', value)... | true |
Other | emberjs | ember.js | 0f66c76d5c2453a06f001c1089510de8da8d22ae.json | Use nicer ES6 syntax for get/set on CPs | packages/ember-runtime/lib/controllers/array_controller.js | @@ -205,10 +205,10 @@ export default ArrayProxy.extend(ControllerMixin, SortableMixin, {
},
model: computed({
- get: function(key) {
+ get(key) {
return Ember.A();
},
- set: function(key, value) {
+ set(key, value) {
Ember.assert(
'ArrayController expects `model` to imple... | true |
Other | emberjs | ember.js | 0f66c76d5c2453a06f001c1089510de8da8d22ae.json | Use nicer ES6 syntax for get/set on CPs | packages/ember-runtime/lib/mixins/array.js | @@ -168,10 +168,10 @@ export default Mixin.create(Enumerable, {
@return this
*/
'[]': computed({
- get: function(key) {
+ get(key) {
return this;
},
- set: function(key, value) {
+ set(key, value) {
this.replace(0, get(this, 'length'), value);
return this;
} | true |
Other | emberjs | ember.js | 0f66c76d5c2453a06f001c1089510de8da8d22ae.json | Use nicer ES6 syntax for get/set on CPs | packages/ember-runtime/lib/mixins/enumerable.js | @@ -957,7 +957,7 @@ export default Mixin.create({
@return this
*/
'[]': computed({
- get: function(key) { return this; }
+ get(key) { return this; }
}),
// .......................................................... | true |
Other | emberjs | ember.js | 0f66c76d5c2453a06f001c1089510de8da8d22ae.json | Use nicer ES6 syntax for get/set on CPs | packages/ember-runtime/lib/mixins/promise_proxy.js | @@ -157,10 +157,10 @@ export default Mixin.create({
@property promise
*/
promise: computed({
- get: function() {
+ get() {
throw new EmberError("PromiseProxy's promise must be set");
},
- set: function(key, promise) {
+ set(key, promise) {
return tap(this, promise);
}
}... | true |
Other | emberjs | ember.js | 0f66c76d5c2453a06f001c1089510de8da8d22ae.json | Use nicer ES6 syntax for get/set on CPs | packages/ember-runtime/lib/mixins/sortable.js | @@ -162,7 +162,7 @@ export default Mixin.create(MutableEnumerable, {
@property arrangedContent
*/
arrangedContent: computed('content', 'sortProperties.@each', {
- get: function(key) {
+ get(key) {
var content = get(this, 'content');
var isSorted = get(this, 'isSorted');
var sortPro... | true |
Other | emberjs | ember.js | 0f66c76d5c2453a06f001c1089510de8da8d22ae.json | Use nicer ES6 syntax for get/set on CPs | packages/ember-views/lib/mixins/view_context_support.js | @@ -25,10 +25,10 @@ var ViewContextSupport = Mixin.create({
@type Object
*/
context: computed({
- get: function() {
+ get() {
return get(this, '_context');
},
- set: function(key, value) {
+ set(key, value) {
set(this, '_context', value);
return value;
}
@@ -53,7 +5... | true |
Other | emberjs | ember.js | 0f66c76d5c2453a06f001c1089510de8da8d22ae.json | Use nicer ES6 syntax for get/set on CPs | packages/ember-views/lib/views/select.js | @@ -417,11 +417,11 @@ var Select = View.extend({
@default null
*/
value: computed({
- get: function(key) {
+ get(key) {
var valuePath = get(this, '_valuePath');
return valuePath ? get(this, 'selection.' + valuePath) : get(this, 'selection');
},
- set: function(key, value) {
+ s... | true |
Other | emberjs | ember.js | 0f66c76d5c2453a06f001c1089510de8da8d22ae.json | Use nicer ES6 syntax for get/set on CPs | packages/ember-views/lib/views/text_field.js | @@ -38,11 +38,11 @@ function canSetTypeOfInput(type) {
function getTypeComputed() {
if (Ember.FEATURES.isEnabled('new-computed-syntax')) {
return computed({
- get: function() {
+ get() {
return 'text';
},
- set: function(key, value) {
+ set(key, value) {
var type ... | true |
Other | emberjs | ember.js | 210a47c1118ddf293ddc2720c4335443ae9f5fc0.json | Update HTMLBars to 0.13.8. | package.json | @@ -23,7 +23,7 @@
"express": "^4.5.0",
"github": "^0.2.3",
"glob": "~4.3.2",
- "htmlbars": "0.13.6",
+ "htmlbars": "0.13.8",
"qunit-extras": "^1.3.0",
"qunitjs": "^1.16.0",
"route-recognizer": "0.1.5", | false |
Other | emberjs | ember.js | 8578ade9755a3ddf4e9436e89e09502f1bae9d83.json | Fix layout tests | packages/ember-views/tests/views/view/layout_test.js | @@ -2,6 +2,8 @@ import Registry from "container/registry";
import { get } from "ember-metal/property_get";
import run from "ember-metal/run_loop";
import EmberView from "ember-views/views/view";
+import { compile } from "ember-template-compiler";
+import { registerHelper } from "ember-htmlbars/helpers";
var regis... | false |
Other | emberjs | ember.js | e5d76eec9e857f3eabe47ccbeac7768ba61f6916.json | Add assertion on 'class' for attributeBindings | packages/ember-views/lib/system/build-component-template.js | @@ -104,19 +104,26 @@ function normalizeComponentAttributes(component, attrs) {
var attr = attributeBindings[i];
var colonIndex = attr.indexOf(':');
+ var attrName, expression;
if (colonIndex !== -1) {
var attrProperty = attr.substring(0, colonIndex);
- var attrName = attr.su... | true |
Other | emberjs | ember.js | e5d76eec9e857f3eabe47ccbeac7768ba61f6916.json | Add assertion on 'class' for attributeBindings | packages/ember-views/tests/views/view/attribute_bindings_test.js | @@ -397,14 +397,18 @@ QUnit.test("attributeBindings should not fail if view has been destroyed", funct
ok(!error, error);
});
-QUnit.skip("asserts if an attributeBinding is setup on class", function() {
+QUnit.test("asserts if an attributeBinding is setup on class", function() {
view = EmberView.create({
... | true |
Other | emberjs | ember.js | 97fa5ea1e36bbb9fece7dc13e9706ba82d8e6d50.json | Use unbound to assert dom rerender | packages/ember-views/tests/views/view/view_lifecycle_test.js | @@ -197,32 +197,34 @@ QUnit.test("should throw an exception when calling appendChild when DOM element
}, null, "throws an exception when calling appendChild after element is created");
});
-QUnit.skip("should replace DOM representation if rerender() is called after element is created", function() {
+QUnit.test("s... | false |
Other | emberjs | ember.js | 4181cc962399cbce4d4b36a2f95bd6c696f168b1.json | Remove unnnecessary test | packages/ember-views/tests/views/view/view_lifecycle_test.js | @@ -98,29 +98,6 @@ QUnit.module("views/view/view_lifecycle_test - in render", {
}
});
-QUnit.skip("appendChild should work inside a template", function() {
- run(function() {
- view = EmberView.create({
- template(context, options) {
- var buffer = options.data.buffer;
-
- buffer.push("<h1>... | false |
Other | emberjs | ember.js | 32d625b9ca0860bb29bb0bf425e9549449f814ad.json | Destroy ember views in destroy-render-node hook
The way `clearRender` works, it won’t call destroy on the top level
view if given `destroySelf` flag set to false. By moving the
`view.destroy` call into this hook, we can avoid destroying the top
level view when it is being cleared by `clearRender`.
The `view.lastResul... | packages/ember-htmlbars/lib/hooks/destroy-render-node.js | @@ -4,6 +4,10 @@
*/
export default function destroyRenderNode(renderNode) {
+ if (renderNode.emberView) {
+ renderNode.emberView.destroy();
+ }
+
var state = renderNode.state;
if (!state) { return; }
| true |
Other | emberjs | ember.js | 32d625b9ca0860bb29bb0bf425e9549449f814ad.json | Destroy ember views in destroy-render-node hook
The way `clearRender` works, it won’t call destroy on the top level
view if given `destroySelf` flag set to false. By moving the
`view.destroy` call into this hook, we can avoid destroying the top
level view when it is being cleared by `clearRender`.
The `view.lastResul... | packages/ember-htmlbars/lib/hooks/will-cleanup-tree.js | @@ -1,6 +1,6 @@
-export default function willCleanupTree(env, morph) {
+export default function willCleanupTree(env, morph, destroySelf) {
var view = morph.emberView;
- if (view && view.parentView) {
+ if (destroySelf && view && view.parentView) {
view.parentView.removeChild(view);
}
| true |
Other | emberjs | ember.js | 32d625b9ca0860bb29bb0bf425e9549449f814ad.json | Destroy ember views in destroy-render-node hook
The way `clearRender` works, it won’t call destroy on the top level
view if given `destroySelf` flag set to false. By moving the
`view.destroy` call into this hook, we can avoid destroying the top
level view when it is being cleared by `clearRender`.
The `view.lastResul... | packages/ember-htmlbars/lib/morphs/morph.js | @@ -30,8 +30,6 @@ proto.cleanup = function() {
view.ownerView.isDestroyingSubtree = true;
if (view.parentView) { view.parentView.removeChild(view); }
}
-
- view.destroy();
}
var toDestroy = this.emberToDestroy; | true |
Other | emberjs | ember.js | 32d625b9ca0860bb29bb0bf425e9549449f814ad.json | Destroy ember views in destroy-render-node hook
The way `clearRender` works, it won’t call destroy on the top level
view if given `destroySelf` flag set to false. By moving the
`view.destroy` call into this hook, we can avoid destroying the top
level view when it is being cleared by `clearRender`.
The `view.lastResul... | packages/ember-metal-views/lib/renderer.js | @@ -189,7 +189,7 @@ Renderer.prototype.renderElementRemoval =
if (view._willRemoveElement) {
view._willRemoveElement = false;
- if (view.lastResult) {
+ if (view.renderNode) {
view.renderNode.clear();
}
this.didDestroyElement(view); | true |
Other | emberjs | ember.js | 32d625b9ca0860bb29bb0bf425e9549449f814ad.json | Destroy ember views in destroy-render-node hook
The way `clearRender` works, it won’t call destroy on the top level
view if given `destroySelf` flag set to false. By moving the
`view.destroy` call into this hook, we can avoid destroying the top
level view when it is being cleared by `clearRender`.
The `view.lastResul... | packages/ember-views/tests/views/view/destroy_element_test.js | @@ -28,7 +28,7 @@ QUnit.test("if it has no element, does nothing", function() {
equal(callCount, 0, 'did not invoke callback');
});
-QUnit.skip("if it has a element, calls willDestroyElement on receiver and child views then deletes the element", function() {
+QUnit.test("if it has a element, calls willDestroyElem... | true |
Other | emberjs | ember.js | 32d625b9ca0860bb29bb0bf425e9549449f814ad.json | Destroy ember views in destroy-render-node hook
The way `clearRender` works, it won’t call destroy on the top level
view if given `destroySelf` flag set to false. By moving the
`view.destroy` call into this hook, we can avoid destroying the top
level view when it is being cleared by `clearRender`.
The `view.lastResul... | packages/ember-views/tests/views/view/remove_test.js | @@ -86,7 +86,7 @@ QUnit.module("View#removeFromParent", {
}
});
-QUnit.skip("removes view from parent view", function() {
+QUnit.test("removes view from parent view", function() {
expectDeprecation("Setting `childViews` on a Container is deprecated.");
parentView = ContainerView.create({ childViews: [View... | true |
Other | emberjs | ember.js | 32d625b9ca0860bb29bb0bf425e9549449f814ad.json | Destroy ember views in destroy-render-node hook
The way `clearRender` works, it won’t call destroy on the top level
view if given `destroySelf` flag set to false. By moving the
`view.destroy` call into this hook, we can avoid destroying the top
level view when it is being cleared by `clearRender`.
The `view.lastResul... | packages/ember-views/tests/views/view/view_lifecycle_test.js | @@ -248,7 +248,7 @@ QUnit.skip("should replace DOM representation if rerender() is called after elem
equal(view.$().text(), "Do not taunt happy fun ball", "rerenders DOM element when rerender() is called");
});
-QUnit.skip("should destroy DOM representation when destroyElement is called", function() {
+QUnit.test... | true |
Other | emberjs | ember.js | 54ed612c6b214861e480308b4201c1deab04e09e.json | Get more tests with view#remove working | packages/ember-metal-views/lib/renderer.js | @@ -170,9 +170,26 @@ Renderer.prototype.willRender = function (view) {
Renderer.prototype.remove = function (view, shouldDestroy) {
this.willDestroyElement(view);
- view._transitionTo('destroying', false);
+
+ view._willRemoveElement = true;
+ run.schedule('render', this, this.renderElementRemoval, view);
};
... | true |
Other | emberjs | ember.js | 54ed612c6b214861e480308b4201c1deab04e09e.json | Get more tests with view#remove working | packages/ember-views/tests/system/event_dispatcher_test.js | @@ -98,9 +98,11 @@ QUnit.test("should not dispatch events to views not inDOM", function() {
var $element = view.$();
- // TODO change this test not to use private API
- // Force into preRender
- view.renderer.remove(view, false, true);
+ run(function() {
+ // TODO change this test not to use private API
+... | true |
Other | emberjs | ember.js | 54ed612c6b214861e480308b4201c1deab04e09e.json | Get more tests with view#remove working | packages/ember-views/tests/views/view/append_to_test.js | @@ -186,7 +186,7 @@ QUnit.test("trigger rerender of parent and SimpleBoundView", function () {
});
});
-QUnit.skip("remove removes an element from the DOM", function() {
+QUnit.test("remove removes an element from the DOM", function() {
willDestroyCalled = 0;
view = View.create({
@@ -213,7 +213,7 @@ QUnit... | true |
Other | emberjs | ember.js | 54ed612c6b214861e480308b4201c1deab04e09e.json | Get more tests with view#remove working | packages/ember-views/tests/views/view/remove_test.js | @@ -134,7 +134,7 @@ QUnit.test("does nothing if not in parentView", function() {
});
-QUnit.skip("the DOM element is gone after doing append and remove in two separate runloops", function() {
+QUnit.test("the DOM element is gone after doing append and remove in two separate runloops", function() {
view = View.c... | true |
Other | emberjs | ember.js | f11e02afce4056734ec7ebb994a8860200cb384c.json | Use template instead of render buffer | packages/ember-views/tests/system/ext_test.js | @@ -1,9 +1,10 @@
import run from "ember-metal/run_loop";
import View from "ember-views/views/view";
+import { compile } from "ember-template-compiler";
QUnit.module("Ember.View additions to run queue");
-QUnit.skip("View hierarchy is done rendering to DOM when functions queued in afterRender execute", function()... | false |
Other | emberjs | ember.js | 1d55056cd4a0966aa577d1fa355e11627a62f462.json | prefer promises to semaphores
* test now correctly fail, not just hang | tests/node/app-boot-test.js | @@ -186,8 +186,6 @@ if (canUseInstanceInitializers && canUseApplicationVisit) {
});
QUnit.test("It is possible to render a view with {{link-to}} in Node", function() {
- QUnit.stop();
-
var app;
run(function() {
@@ -203,19 +201,14 @@ if (canUseInstanceInitializers && canUseApplicationVisit) {
... | false |
Other | emberjs | ember.js | b325125a1f54c2e4a6e034da5ebfb55b15c8db2f.json | fix action targeting when there is no view | packages/ember-routing-htmlbars/lib/keywords/action.js | @@ -36,7 +36,7 @@ export default {
target = read(hash.target);
}
} else {
- target = get(env.view, 'controller');
+ target = get(env.view, 'controller') || read(scope.self);
}
return { actionName, actionArgs, target }; | true |
Other | emberjs | ember.js | b325125a1f54c2e4a6e034da5ebfb55b15c8db2f.json | fix action targeting when there is no view | packages/ember-routing-htmlbars/tests/helpers/action_test.js | @@ -99,7 +99,7 @@ QUnit.test("should by default target the view's controller", function() {
equal(registeredTarget, controller, "The controller was registered as the target");
});
-QUnit.skip("Inside a yield, the target points at the original target", function() {
+QUnit.test("Inside a yield, the target points at... | true |
Other | emberjs | ember.js | b325125a1f54c2e4a6e034da5ebfb55b15c8db2f.json | fix action targeting when there is no view | packages/ember/tests/component_registration_test.js | @@ -283,7 +283,7 @@ QUnit.skip("properties of a component without a template should not collide wit
equal(Ember.$('#wrapper').text(), "Some text inserted by jQuery", "The component is composed correctly");
});
-QUnit.skip("Components trigger actions in the parents context when called from within a block", functi... | true |
Other | emberjs | ember.js | b325125a1f54c2e4a6e034da5ebfb55b15c8db2f.json | fix action targeting when there is no view | packages/ember/tests/helpers/link_to_test.js | @@ -367,7 +367,7 @@ QUnit.test("The {{link-to}} helper supports multiple current-when routes", funct
equal(Ember.$('#link3.active', '#qunit-fixture').length, 0, "The link is not active since current-when does not contain the active route");
});
-QUnit.skip("The {{link-to}} helper defaults to bubbling", function()... | true |
Other | emberjs | ember.js | b325125a1f54c2e4a6e034da5ebfb55b15c8db2f.json | fix action targeting when there is no view | packages/ember/tests/routing/basic_test.js | @@ -1126,8 +1126,7 @@ asyncTest("Nested callbacks are not exited when moving to siblings", function()
});
});
-// Revert QUnit.skip to QUnit.asyncTest
-QUnit.skip("Events are triggered on the controller if a matching action name is implemented", function() {
+QUnit.asyncTest("Events are triggered on the controlle... | true |
Other | emberjs | ember.js | fda788458e8d40454c343a3ccf34f05e7a98bf69.json | drop dead code
this argument was used by the pre-glimmer OutletView only | packages/ember-routing/lib/system/router.js | @@ -214,7 +214,7 @@ var EmberRouter = EmberObject.extend(Evented, {
}
if (!this._toplevelView) {
var OutletView = this.container.lookupFactory('view:-outlet');
- this._toplevelView = OutletView.create({ _isTopLevel: true });
+ this._toplevelView = OutletView.create();
var instance = th... | false |
Other | emberjs | ember.js | bbc901d90dc1aca1f926579deecbcca05b930214.json | fix tests that don't cleanup Application instances | packages/ember-application/tests/system/application_test.js | @@ -86,7 +86,6 @@ QUnit.test("you cannot make two default applications without a rootElement error
QUnit.test("acts like a namespace", function() {
var lookup = Ember.lookup = {};
- var app;
run(function() {
app = lookup.TestApp = Application.create({ rootElement: '#two', router: false }); | true |
Other | emberjs | ember.js | bbc901d90dc1aca1f926579deecbcca05b930214.json | fix tests that don't cleanup Application instances | packages/ember-application/tests/system/initializers_test.js | @@ -237,6 +237,7 @@ QUnit.test("initializers set on Application subclasses should not be shared betw
var firstInitializerRunCount = 0;
var secondInitializerRunCount = 0;
var FirstApp = Application.extend();
+ var firstApp, secondApp;
FirstApp.initializer({
name: 'first',
initialize(registry) {
@@... | true |
Other | emberjs | ember.js | bbc901d90dc1aca1f926579deecbcca05b930214.json | fix tests that don't cleanup Application instances | packages/ember-application/tests/system/instance_initializers_test.js | @@ -241,6 +241,8 @@ if (Ember.FEATURES.isEnabled('ember-application-instance-initializers')) {
var firstInitializerRunCount = 0;
var secondInitializerRunCount = 0;
var FirstApp = Application.extend();
+ var firstApp, secondApp;
+
FirstApp.instanceInitializer({
name: 'first',
initial... | true |
Other | emberjs | ember.js | 06aab7c7f986540a5446cc903d6303ade58d5129.json | Reimplement hasBlock and hasBlockParams | package.json | @@ -23,7 +23,7 @@
"express": "^4.5.0",
"github": "^0.2.3",
"glob": "~4.3.2",
- "htmlbars": "0.13.4",
+ "htmlbars": "0.13.5",
"qunit-extras": "^1.3.0",
"qunitjs": "^1.16.0",
"route-recognizer": "0.1.5", | true |
Other | emberjs | ember.js | 06aab7c7f986540a5446cc903d6303ade58d5129.json | Reimplement hasBlock and hasBlockParams | packages/ember-htmlbars/lib/hooks/get-root.js | @@ -10,6 +10,10 @@ import SimpleStream from "ember-metal/streams/simple-stream";
export default function getRoot(scope, key) {
if (key === 'this') {
return [scope.self];
+ } else if (key === 'hasBlock') {
+ return [!!scope.block];
+ } else if (key === 'hasBlockParams') {
+ return [!!(scope.block && sco... | true |
Other | emberjs | ember.js | 06aab7c7f986540a5446cc903d6303ade58d5129.json | Reimplement hasBlock and hasBlockParams | packages/ember-htmlbars/lib/system/component-node.js | @@ -91,7 +91,9 @@ ComponentNode.prototype.render = function(env, attrs, visitor) {
env.renderer.willRender(component);
}
- this.block(newEnv, [], undefined, this.renderNode, this.scope, visitor);
+ if (this.block) {
+ this.block(newEnv, [], undefined, this.renderNode, this.scope, visitor);
+ }
if (... | true |
Other | emberjs | ember.js | 06aab7c7f986540a5446cc903d6303ade58d5129.json | Reimplement hasBlock and hasBlockParams | packages/ember-htmlbars/tests/integration/component_invocation_test.js | @@ -173,7 +173,7 @@ QUnit.test('[DEPRECATED] block with properties on self', function() {
});
if (Ember.FEATURES.isEnabled('ember-views-component-block-info')) {
- QUnit.skip('`Component.prototype.hasBlock` when block supplied', function() {
+ QUnit.test('hasBlock is true when block supplied', function() {
e... | true |
Other | emberjs | ember.js | 06aab7c7f986540a5446cc903d6303ade58d5129.json | Reimplement hasBlock and hasBlockParams | packages/ember-views/lib/system/build-component-template.js | @@ -9,8 +9,6 @@ export default function buildComponentTemplate(componentInfo, attrs, content) {
component = componentInfo.component;
- blockToRender = function() {};
-
if (content.template) {
blockToRender = createContentBlock(content.template, content.scope, content.self, component || null);
} | true |
Other | emberjs | ember.js | f892dc8390f40ba84e825e946dea131afbaa01c1.json | Use templates to test View.nearestTypeOf. | packages/ember-views/tests/views/view/nearest_of_type_test.js | @@ -1,6 +1,7 @@
import run from "ember-metal/run_loop";
import { Mixin as EmberMixin } from "ember-metal/mixin";
import View from "ember-views/views/view";
+import compile from "ember-template-compiler/system/compile";
var parentView, view;
@@ -16,12 +17,10 @@ QUnit.module("View#nearest*", {
(function() {
v... | false |
Other | emberjs | ember.js | f34d66901205b8088821c14e1c78a77a6edd0a82.json | Remove prototype extensions example. | packages/ember-metal/lib/run_loop.js | @@ -126,12 +126,12 @@ run.join = function() {
```javascript
App.RichTextEditorComponent = Ember.Component.extend({
- initializeTinyMCE: function() {
+ initializeTinyMCE: Ember.on('didInsertElement', function() {
tinymce.init({
selector: '#' + this.$().prop('id'),
setup: Ember.run.... | false |
Other | emberjs | ember.js | ffedc10ea3c11ff17040175b28d3bbe3bfda24a3.json | Fix invalid assertion. | packages/ember-views/tests/views/select_test.js | @@ -146,7 +146,7 @@ QUnit.test("XSS: does not escape label value when it is a SafeString", function(
append();
equal(select.$('option').length, 2, "Should have two options");
- equal(select.$('option[value=1] b').length, 1, "Should have child elements");
+ equal(select.$('option[value=1] p').length, 1, "Shoul... | false |
Other | emberjs | ember.js | 7d342b6682b95692d2d93e7a8a787dc3d6a1d655.json | Remove unused AttrNode. | packages/ember-views/lib/attr_nodes/attr_node.js | @@ -1,123 +0,0 @@
-/**
-@module ember
-@submodule ember-htmlbars
-*/
-
-import Ember from 'ember-metal/core';
-import {
- read,
- subscribe,
- unsubscribe
-} from "ember-metal/streams/utils";
-import run from "ember-metal/run_loop";
-
-export default function AttrNode(attrName, attrValue) {
- this.init(attrName, at... | false |
Other | emberjs | ember.js | f73264d685fda7e9b9d9d17bc7d39f9477ed225c.json | Fix a test using an undefined context
Context-changing helpers no longer allow an undefined context. Instead,
null is substituted for the context. | packages/ember-htmlbars/lib/helpers/each.js | @@ -1,5 +1,6 @@
import { get } from "ember-metal/property_get";
import { forEach } from "ember-metal/enumerable_utils";
+import normalizeSelf from "ember-htmlbars/utils/normalize-self";
export default function eachHelper(params, hash, blocks) {
var list = params[0];
@@ -15,7 +16,7 @@ export default function eac... | true |
Other | emberjs | ember.js | f73264d685fda7e9b9d9d17bc7d39f9477ed225c.json | Fix a test using an undefined context
Context-changing helpers no longer allow an undefined context. Instead,
null is substituted for the context. | packages/ember-htmlbars/lib/helpers/with.js | @@ -3,6 +3,8 @@
@submodule ember-htmlbars
*/
+import normalizeSelf from "ember-htmlbars/utils/normalize-self";
+
/**
Use the `{{with}}` helper when you want to aliases the to a new name. It's helpful
for semantic clarity and to retain default scope or to reference from another
@@ -51,6 +53,6 @@ export defaul... | true |
Other | emberjs | ember.js | f73264d685fda7e9b9d9d17bc7d39f9477ed225c.json | Fix a test using an undefined context
Context-changing helpers no longer allow an undefined context. Instead,
null is substituted for the context. | packages/ember-htmlbars/lib/utils/normalize-self.js | @@ -0,0 +1,7 @@
+export default function normalizeSelf(self) {
+ if (self === undefined) {
+ return null;
+ } else {
+ return self;
+ }
+} | true |
Other | emberjs | ember.js | f73264d685fda7e9b9d9d17bc7d39f9477ed225c.json | Fix a test using an undefined context
Context-changing helpers no longer allow an undefined context. Instead,
null is substituted for the context. | packages/ember-htmlbars/tests/compat/make_bound_helper_test.js | @@ -471,7 +471,7 @@ QUnit.test("shouldn't treat quoted strings as bound paths", function() {
equal(helperCount, 5, "changing controller property with same name as quoted string doesn't re-render helper");
});
-QUnit.skip("bound helpers can handle nulls in array (with primitives) [DEPRECATED]", function() {
+QUnit... | true |
Other | emberjs | ember.js | c0561486baf574ffdcb07daa2159d88d5695abd2.json | Remove invalid test | packages/ember-htmlbars/tests/helpers/collection_test.js | @@ -407,38 +407,6 @@ QUnit.test("should give its item views the property specified by itemProperty",
equal(view.$('ul li:first').text(), "yobaz", "change property of sub view");
});
-QUnit.skip("should unsubscribe stream bindings", function() {
- view = EmberView.create({
- baz: "baz",
- content: A([EmberO... | false |
Other | emberjs | ember.js | 85ff4278f0c8f252cd35a1a9ef967aadc01412fc.json | fix use of template & layout together | packages/ember-htmlbars/lib/system/component-node.js | @@ -41,7 +41,19 @@ ComponentNode.create = function(renderNode, env, attrs, found, parentView, path,
if (attrs && attrs.viewName) { options.viewName = read(attrs.viewName); }
component = componentInfo.component = createOrUpdateComponent(found.component, options, renderNode);
- componentInfo.layout = get(c... | true |
Other | emberjs | ember.js | 85ff4278f0c8f252cd35a1a9ef967aadc01412fc.json | fix use of template & layout together | packages/ember-routing-htmlbars/tests/helpers/outlet_test.js | @@ -199,7 +199,7 @@ QUnit.test("Outlets bind to the current template's view, not inner contexts [DEP
equal(output, "BOTTOM", "all templates were rendered");
});
-QUnit.skip("should support layouts", function() {
+QUnit.test("should support layouts", function() {
var template = "{{outlet}}";
var layout = "<h... | true |
Other | emberjs | ember.js | 85ff4278f0c8f252cd35a1a9ef967aadc01412fc.json | fix use of template & layout together | packages/ember/tests/component_registration_test.js | @@ -160,7 +160,7 @@ QUnit.test("Assigning templateName to a component should setup the template as a
equal(Ember.$('#wrapper').text(), "inner-outer", "The component is composed correctly");
});
-QUnit.skip("Assigning templateName and layoutName should use the templates specified", function() {
+QUnit.test("Assign... | true |
Other | emberjs | ember.js | 85ff4278f0c8f252cd35a1a9ef967aadc01412fc.json | fix use of template & layout together | packages/ember/tests/routing/basic_test.js | @@ -442,7 +442,7 @@ QUnit.test('defining templateName allows other templates to be rendered', functi
});
-QUnit.skip('Specifying a name to render should have precedence over everything else', function() {
+QUnit.test('Specifying a name to render should have precedence over everything else', function() {
Router.... | true |
Other | emberjs | ember.js | c7f67e8806354e36497f68ec5644405c4d2b5e1f.json | Fix inverse block in compat helpers | packages/ember-htmlbars/lib/compat/helper.js | @@ -47,6 +47,12 @@ function HandlebarsCompatibleHelper(fn) {
handlebarsOptions.fn = function() {
options.template.yield();
};
+
+ if (options.inverse) {
+ handlebarsOptions.inverse = function() {
+ options.inverse.yield();
+ };
+ }
}
for (var prop in h... | true |
Other | emberjs | ember.js | c7f67e8806354e36497f68ec5644405c4d2b5e1f.json | Fix inverse block in compat helpers | packages/ember-htmlbars/tests/compat/helper_test.js | @@ -225,7 +225,7 @@ QUnit.test('allows usage of the template fn', function() {
equal(view.$().text(), 'foo');
});
-QUnit.skip('allows usage of the template inverse', function() {
+QUnit.test('allows usage of the template inverse', function() {
expect(1);
function someHelper(options) { | true |
Other | emberjs | ember.js | db465aefdbe4472dc90bfdd481b7cdedd1095bda.json | Add fix for overwriting style attribute bindings | packages/ember-views/lib/system/build-component-template.js | @@ -140,7 +140,14 @@ function normalizeComponentAttributes(component, attrs) {
}
if (component.isVisible === false) {
- normalized.style = ['value', "display: none;"];
+ var hiddenStyle = ['value', "display: none;"];
+ var existingStyle = normalized.style;
+
+ if (existingStyle) {
+ normalized.... | true |
Other | emberjs | ember.js | db465aefdbe4472dc90bfdd481b7cdedd1095bda.json | Add fix for overwriting style attribute bindings | packages/ember-views/tests/views/view/is_visible_test.js | @@ -71,6 +71,20 @@ QUnit.test("should hide element if isVisible is false before element is created"
});
});
+QUnit.test("doesn't overwrite existing style attribute bindings", function() {
+ view = EmberView.create({
+ isVisible: false,
+ attributeBindings: ['style'],
+ style: 'color: blue;'
+ });
+
+ ... | true |
Other | emberjs | ember.js | c43cb492c073b079a6a69fc71a2c1e42ff837d83.json | Enable tests that are now passing. | packages/ember-htmlbars/tests/helpers/input_test.js | @@ -108,7 +108,6 @@ QUnit.test("cursor position is not lost when updating content", function() {
input.selectionStart = 3;
input.selectionEnd = 3;
});
-
run(null, set, controller, 'val', 'derp');
equal(view.$('input').val(), "derp", "updates text field after value changes");
@@ -407,7 +406,7 @@ QUn... | true |
Other | emberjs | ember.js | c43cb492c073b079a6a69fc71a2c1e42ff837d83.json | Enable tests that are now passing. | packages/ember-template-compiler/tests/system/compile_test.js | @@ -40,7 +40,7 @@ QUnit.test('the template revision is different than the HTMLBars default revisio
ok(actual.revision !== expected.revision, 'revision differs from default');
});
-QUnit.skip('{{with}} template deprecation includes moduleName if provided', function() {
+QUnit.test('{{with}} template deprecation in... | true |
Other | emberjs | ember.js | 9efd004ca7e7bd76e4451ebffaa31093c5c78557.json | Update HTMLBars to 0.13.1.
Updates HTMLBars to ensure that initially undefined/null
`attributeBindings` are not set on the views element. | package.json | @@ -23,7 +23,7 @@
"express": "^4.5.0",
"github": "^0.2.3",
"glob": "~4.3.2",
- "htmlbars": "0.13.0",
+ "htmlbars": "0.13.1",
"qunit-extras": "^1.3.0",
"qunitjs": "^1.16.0",
"route-recognizer": "0.1.5", | true |
Other | emberjs | ember.js | 9efd004ca7e7bd76e4451ebffaa31093c5c78557.json | Update HTMLBars to 0.13.1.
Updates HTMLBars to ensure that initially undefined/null
`attributeBindings` are not set on the views element. | packages/ember-htmlbars/tests/helpers/bind_attr_test.js | @@ -589,7 +589,7 @@ QUnit.test("src attribute bound to undefined is empty", function() {
runAppend(view);
- equal(view.element.firstChild.getAttribute('src'), '', "src attribute is empty");
+ ok(!view.element.firstChild.hasAttribute('src'), "src attribute is empty");
});
QUnit.test("src attribute bound to ... | true |
Other | emberjs | ember.js | 47ddf42b2c10324d9e8d35397db8195c9108a465.json | Unify legacy class binding into AST preprocessor
There are several paths and microsyntaxes for creating class name
bindings for a component’s element via Handlebars. For example:
`{{view ‘my-view’ class=“hello” classBindings=“:foo isApp:is-an-app”}}`
With HTMLbars, these have been deprecated in favor of a single API... | packages/ember-htmlbars/lib/helpers/-concat.js | @@ -0,0 +1,7 @@
+/** @private
+ This private helper is used by the legacy class bindings AST transformer
+ to concatenate class names together.
+*/
+export default function concat(params, hash) {
+ return params.join(hash.separator);
+} | true |
Other | emberjs | ember.js | 47ddf42b2c10324d9e8d35397db8195c9108a465.json | Unify legacy class binding into AST preprocessor
There are several paths and microsyntaxes for creating class name
bindings for a component’s element via Handlebars. For example:
`{{view ‘my-view’ class=“hello” classBindings=“:foo isApp:is-an-app”}}`
With HTMLbars, these have been deprecated in favor of a single API... | packages/ember-htmlbars/lib/helpers/-normalize-class.js | @@ -1,4 +1,5 @@
import { dasherize } from "ember-runtime/system/string";
+import { isPath } from "ember-metal/path_cache";
/** @private
This private helper is used by ComponentNode to convert the classNameBindings
@@ -23,6 +24,12 @@ export default function normalizeClass(params, hash) {
// If value is a Boole... | true |
Other | emberjs | ember.js | 47ddf42b2c10324d9e8d35397db8195c9108a465.json | Unify legacy class binding into AST preprocessor
There are several paths and microsyntaxes for creating class name
bindings for a component’s element via Handlebars. For example:
`{{view ‘my-view’ class=“hello” classBindings=“:foo isApp:is-an-app”}}`
With HTMLbars, these have been deprecated in favor of a single API... | packages/ember-htmlbars/lib/main.js | @@ -23,6 +23,7 @@ import logHelper from "ember-htmlbars/helpers/log";
import eachHelper from "ember-htmlbars/helpers/each";
import bindAttrClassHelper from "ember-htmlbars/helpers/bind-attr-class";
import normalizeClassHelper from "ember-htmlbars/helpers/-normalize-class";
+import concatHelper from "ember-htmlbars/h... | true |
Other | emberjs | ember.js | 47ddf42b2c10324d9e8d35397db8195c9108a465.json | Unify legacy class binding into AST preprocessor
There are several paths and microsyntaxes for creating class name
bindings for a component’s element via Handlebars. For example:
`{{view ‘my-view’ class=“hello” classBindings=“:foo isApp:is-an-app”}}`
With HTMLbars, these have been deprecated in favor of a single API... | packages/ember-htmlbars/tests/helpers/view_test.js | @@ -366,11 +366,13 @@ QUnit.test("allows you to pass attributes that will be assigned to the class ins
equal(jQuery('#bar').text(), 'Bar');
});
-QUnit.skip("Should apply class without condition always", function() {
- view = EmberView.create({
- controller: Ember.Object.create(),
- template: compile('{{#vi... | true |
Other | emberjs | ember.js | 47ddf42b2c10324d9e8d35397db8195c9108a465.json | Unify legacy class binding into AST preprocessor
There are several paths and microsyntaxes for creating class name
bindings for a component’s element via Handlebars. For example:
`{{view ‘my-view’ class=“hello” classBindings=“:foo isApp:is-an-app”}}`
With HTMLbars, these have been deprecated in favor of a single API... | packages/ember-template-compiler/lib/main.js | @@ -10,6 +10,7 @@ import TransformBindAttrToAttributes from "ember-template-compiler/plugins/trans
import TransformEachIntoCollection from "ember-template-compiler/plugins/transform-each-into-collection";
import TransformSingleArgEach from "ember-template-compiler/plugins/transform-single-arg-each";
import Transform... | true |
Other | emberjs | ember.js | 47ddf42b2c10324d9e8d35397db8195c9108a465.json | Unify legacy class binding into AST preprocessor
There are several paths and microsyntaxes for creating class name
bindings for a component’s element via Handlebars. For example:
`{{view ‘my-view’ class=“hello” classBindings=“:foo isApp:is-an-app”}}`
With HTMLbars, these have been deprecated in favor of a single API... | packages/ember-template-compiler/lib/plugins/transform-old-class-binding-syntax.js | @@ -0,0 +1,138 @@
+import Ember from 'ember-metal/core';
+
+export default function TransformOldClassBindingSyntax() {
+ this.syntax = null;
+}
+
+TransformOldClassBindingSyntax.prototype.transform = function TransformOldClassBindingSyntax_transform(ast) {
+ var b = this.syntax.builders;
+ var walker = new this.synt... | true |
Other | emberjs | ember.js | 47ddf42b2c10324d9e8d35397db8195c9108a465.json | Unify legacy class binding into AST preprocessor
There are several paths and microsyntaxes for creating class name
bindings for a component’s element via Handlebars. For example:
`{{view ‘my-view’ class=“hello” classBindings=“:foo isApp:is-an-app”}}`
With HTMLbars, these have been deprecated in favor of a single API... | packages/ember-views/lib/system/build-component-template.js | @@ -1,6 +1,7 @@
import { internal, render } from "htmlbars-runtime";
import { read } from "ember-metal/streams/utils";
import { get } from "ember-metal/property_get";
+import { isGlobal } from "ember-metal/path_cache";
export default function buildComponentTemplate(componentInfo, attrs, content) {
var componen... | true |
Other | emberjs | ember.js | 6153cd8b2f93a90f2862de7ce7aabad978c146a7.json | Add note on Checkbox inheriting from Component | packages/ember-views/lib/views/checkbox.js | @@ -31,6 +31,7 @@ import View from "ember-views/views/view";
@namespace Ember
@extends Ember.View
*/
+// 2.0TODO: Subclass Component rather than View
export default View.extend({
instrumentDisplay: '{{input type="checkbox"}}',
| false |
Other | emberjs | ember.js | c692bd0464f393cb334fb8110e2c3c297df42931.json | Fix current node tests. | tests/node/app-boot-test.js | @@ -29,10 +29,7 @@ global.EmberENV = {
FEATURES: features
};
-var Ember = require(path.join(distPath, 'ember.debug.cjs'));
-var compile = require(path.join(distPath, 'ember-template-compiler')).compile;
-Ember.testing = true;
-var DOMHelper = Ember.HTMLBars.DOMHelper;
+var Ember, compile, domHelper, run;
var Sim... | true |
Other | emberjs | ember.js | c692bd0464f393cb334fb8110e2c3c297df42931.json | Fix current node tests. | tests/node/template-compiler-test.js | @@ -53,7 +53,7 @@ test('allows enabling of features', function() {
templateCompiler._Ember.FEATURES['ember-htmlbars-component-generation'] = true;
templateOutput = templateCompiler.precompile('<some-thing></some-thing>');
- ok(templateOutput.match(/component\(env, morph0, context, "some-thing"/), 'compon... | true |
Other | emberjs | ember.js | 66acf7fcbcb721ffb332dd48d3cad2b305ab327b.json | Update Ember.Select to use HTMLbars templates | packages/ember-htmlbars/lib/templates/select-option.hbs | @@ -0,0 +1 @@
+{{view.label}}
\ No newline at end of file | true |
Other | emberjs | ember.js | 66acf7fcbcb721ffb332dd48d3cad2b305ab327b.json | Update Ember.Select to use HTMLbars templates | packages/ember-htmlbars/lib/templates/select.hbs | @@ -1 +1 @@
-{{#if view.prompt}}<option value="">{{view.prompt}}</option>{{/if}}{{#if view.optionGroupPath}}{{#each view.groupedContent keyword="group"}}{{view view.groupView content=group.content label=group.label}}{{/each}}{{else}}{{#each view.content keyword="item"}}{{view view.optionView content=item}}{{/each}}{{/i... | true |
Other | emberjs | ember.js | 66acf7fcbcb721ffb332dd48d3cad2b305ab327b.json | Update Ember.Select to use HTMLbars templates | packages/ember-htmlbars/tests/integration/select_in_template_test.js | @@ -68,7 +68,7 @@ QUnit.skip("works from a template with bindings [DEPRECATED]", function() {
expectDeprecation(function() {
runAppend(view);
- }, /You're attempting to render a view by passing .+Binding to a view helper, but this syntax is deprecated/);
+ }, /You tried to look up an attribute directly on t... | true |
Other | emberjs | ember.js | 66acf7fcbcb721ffb332dd48d3cad2b305ab327b.json | Update Ember.Select to use HTMLbars templates | packages/ember-views/lib/views/select.js | @@ -21,33 +21,21 @@ import { computed } from "ember-metal/computed";
import { A as emberA } from "ember-runtime/system/native_array";
import { observer } from "ember-metal/mixin";
import { defineProperty } from "ember-metal/properties";
-import run from "ember-metal/run_loop";
import htmlbarsTemplate from "ember-... | true |
Other | emberjs | ember.js | 36225a2df71bdfab5de9580a332963793a294ee1.json | Add skipped test for compat mode attrs-proxy. | packages/ember-views/tests/compat/attrs_proxy_test.js | @@ -0,0 +1,34 @@
+import View from "ember-views/views/view";
+import { runAppend, runDestroy } from "ember-runtime/tests/utils";
+import compile from "ember-template-compiler/system/compile";
+import Registry from "container/registry";
+
+var view, registry, container;
+
+QUnit.module("ember-views: attrs-proxy", {
+ s... | false |
Other | emberjs | ember.js | 508d9de45bd6d729c8cb0954f97fd7ed83531276.json | Fix unbound keyword
This commit also adds several tests for the path and helper usages of
the subexpression form, e.g.
```hbs
{{capitalize (unbound foo)}}
```
and
```hbs
{{capitalize (unbound if foo bar baz)}}
``` | packages/ember-htmlbars/lib/hooks/subexpr.js | @@ -10,6 +10,13 @@ import create from "ember-metal/platform/create";
import { subscribe, addDependency, read, labelsFor, labelFor } from "ember-metal/streams/utils";
export default function subexpr(env, scope, helperName, params, hash) {
+ // TODO: Keywords and helper invocation should be integrated into
+ // the... | true |
Other | emberjs | ember.js | 508d9de45bd6d729c8cb0954f97fd7ed83531276.json | Fix unbound keyword
This commit also adds several tests for the path and helper usages of
the subexpression form, e.g.
```hbs
{{capitalize (unbound foo)}}
```
and
```hbs
{{capitalize (unbound if foo bar baz)}}
``` | packages/ember-htmlbars/lib/keywords/unbound.js | @@ -10,6 +10,15 @@ export default function unbound(morph, env, scope, originalParams, hash, templat
var params = originalParams.slice();
var valueStream = params.shift();
+ // If `morph` is `null` the keyword is being invoked as a subexpression.
+ if (morph === null) {
+ if (originalParams.length > 1) {
+ ... | true |
Other | emberjs | ember.js | 508d9de45bd6d729c8cb0954f97fd7ed83531276.json | Fix unbound keyword
This commit also adds several tests for the path and helper usages of
the subexpression form, e.g.
```hbs
{{capitalize (unbound foo)}}
```
and
```hbs
{{capitalize (unbound if foo bar baz)}}
``` | packages/ember-htmlbars/tests/helpers/unbound_test.js | @@ -56,6 +56,14 @@ QUnit.test('it should not re-render if the property changes', function() {
equal(view.$().text(), 'BORK BORK', 'should not re-render if the property changes');
});
+QUnit.test('it should re-render if the parent view rerenders', function() {
+ run(function() {
+ view.set('context.foo', 'OOF'... | true |
Other | emberjs | ember.js | 793613059d3e029e17b38a89c67d592b4f535164.json | fix another outlet assertion | packages/ember-htmlbars/lib/keywords/real_outlet.js | @@ -6,6 +6,7 @@
import merge from "ember-metal/merge";
import { get } from "ember-metal/property_get";
import ComponentNode from "ember-htmlbars/system/component-node";
+import { isStream } from "ember-metal/streams/utils";
import topLevelViewTemplate from "ember-htmlbars/templates/top-level-view";
topLevelViewTem... | true |
Other | emberjs | ember.js | 793613059d3e029e17b38a89c67d592b4f535164.json | fix another outlet assertion | packages/ember-routing-htmlbars/tests/helpers/outlet_test.js | @@ -234,7 +234,7 @@ QUnit.test("should not throw deprecations if {{outlet}} is used with a quoted na
runAppend(top);
});
-QUnit.skip("should throw an assertion if {{outlet}} used with unquoted name", function() {
+QUnit.test("should throw an assertion if {{outlet}} used with unquoted name", function() {
top.se... | true |
Other | emberjs | ember.js | 2cb9069bd09ed9b4754eabb3f2edb02604676c91.json | drop unused code | packages/ember-htmlbars/lib/keywords/customized_outlet.js | @@ -10,8 +10,7 @@ export default {
setupState(state, env, scope, params, hash) {
var read = env.hooks.getValue;
var viewClass = readViewFactory(read(hash.view), env.container);
- var outletName = read(params[0]) || 'main';
- return { viewClass, outletName };
+ return { viewClass };
},
render... | false |
Other | emberjs | ember.js | 51a560a3cf5254eecc3f3b6466a1ac3205d17264.json | drop unused argument | packages/ember-htmlbars/lib/system/component-node.js | @@ -15,7 +15,7 @@ function ComponentNode(component, scope, renderNode, block, expectElement) {
export default ComponentNode;
-ComponentNode.create = function(renderNode, env, attrs, found, parentView, path, contentScope, contentTemplate, visitor) {
+ComponentNode.create = function(renderNode, env, attrs, found, pa... | false |
Other | emberjs | ember.js | 5d95e7b739dd40a91925625adf449ed1b785db98.json | implement textarea keyword
Three more passing tests | packages/ember-htmlbars/lib/env.js | @@ -65,6 +65,7 @@ import view from "ember-htmlbars/keywords/view";
import componentKeyword from "ember-htmlbars/keywords/component";
import partial from "ember-htmlbars/keywords/partial";
import input from "ember-htmlbars/keywords/input";
+import textarea from "ember-htmlbars/keywords/textarea";
import collection f... | true |
Other | emberjs | ember.js | 5d95e7b739dd40a91925625adf449ed1b785db98.json | implement textarea keyword
Three more passing tests | packages/ember-htmlbars/lib/keywords/textarea.js | @@ -0,0 +1,6 @@
+export default {
+
+ render(morph, env, scope, params, hash, template, inverse, visitor) {
+ env.hooks.component(morph, env, scope, '-text-area', hash, template, visitor);
+ }
+}; | true |
Other | emberjs | ember.js | 5d95e7b739dd40a91925625adf449ed1b785db98.json | implement textarea keyword
Three more passing tests | packages/ember-htmlbars/tests/helpers/text_area_test.js | @@ -3,6 +3,9 @@ import View from "ember-views/views/view";
import compile from "ember-template-compiler/system/compile";
import { set as o_set } from "ember-metal/property_set";
import { runAppend, runDestroy } from "ember-runtime/tests/utils";
+import TextArea from "ember-views/views/text_area";
+import Registry fr... | true |
Other | emberjs | ember.js | 5d95e7b739dd40a91925625adf449ed1b785db98.json | implement textarea keyword
Three more passing tests | packages/ember-testing/tests/helpers_test.js | @@ -316,7 +316,7 @@ QUnit.test("`wait` helper can be passed a resolution value", function() {
});
-QUnit.skip("`click` triggers appropriate events in order", function() {
+QUnit.test("`click` triggers appropriate events in order", function() {
expect(5);
var click, wait, events; | true |
Other | emberjs | ember.js | 5d95e7b739dd40a91925625adf449ed1b785db98.json | implement textarea keyword
Three more passing tests | packages/ember-views/lib/initializers/components.js | @@ -1,14 +1,15 @@
import { onLoad } from "ember-runtime/system/lazy_load";
import TextField from "ember-views/views/text_field";
+import TextArea from "ember-views/views/text_area";
import Checkbox from "ember-views/views/checkbox";
onLoad('Ember.Application', function(Application) {
Application.initializer({
... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.