language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | 545a3518af18424cf4e1b4d3d197685315e74258.json | Add test for outlet inside nested render helper
(cherry picked from commit 20926c4b48cc53c8ea624daf5c871b8c7bcfa30d) | packages/ember/tests/routing/basic_test.js | @@ -3849,3 +3849,57 @@ QUnit.test("Can disconnect from the render helper's children", function() {
Ember.run(router, 'send', 'disconnect');
equal(Ember.$('#qunit-fixture .foo .index').text(), '');
});
+
+QUnit.test("Can render({into:...}) nested render helpers", function() {
+ Ember.TEMPLATES.application = comp... | false |
Other | emberjs | ember.js | 89cf0a916c8cd436c5370392d8890130d712a97a.json | Enable LOG_VIEW_LOOKUPS for {{outlet}} keyword.
Note: that {{outlet}} templates without a view instance do not get a
default view any longer (the template is just rendered). | packages/ember-application/tests/system/logging_test.js | @@ -205,7 +205,7 @@ QUnit.test("do not log when template and view are missing when flag is not true"
});
});
-QUnit.skip("log which view is used with a template", function() {
+QUnit.test("log which view is used with a template", function() {
if (EmberDev && EmberDev.runningProdBuild) {
ok(true, 'Logging ... | true |
Other | emberjs | ember.js | 89cf0a916c8cd436c5370392d8890130d712a97a.json | Enable LOG_VIEW_LOOKUPS for {{outlet}} keyword.
Note: that {{outlet}} templates without a view instance do not get a
default view any longer (the template is just rendered). | packages/ember-htmlbars/lib/keywords/outlet.js | @@ -4,6 +4,7 @@
*/
import merge from "ember-metal/merge";
+import { get } from "ember-metal/property_get";
import ComponentNode from "ember-htmlbars/system/component-node";
import topLevelViewTemplate from "ember-htmlbars/templates/top-level-view";
@@ -54,6 +55,8 @@ export default {
var parentView = env.vi... | true |
Other | emberjs | ember.js | 5669af58bf0fd1514bea9bfd58924eac0c9e12aa.json | Remove unused import.
Fixes JSHint error. | packages/ember-htmlbars/tests/helpers/unbound_test.js | @@ -8,7 +8,6 @@ import { get } from 'ember-metal/property_get';
import { set } from 'ember-metal/property_set';
import run from 'ember-metal/run_loop';
import compile from "ember-template-compiler/system/compile";
-import EmberError from 'ember-metal/error';
import helpers from "ember-htmlbars/helpers";
import reg... | false |
Other | emberjs | ember.js | 47d218eaeae799b36b6b3f4ff48d808cc477eac0.json | Update emberjs-build to enable es6.blockScoping. | package.json | @@ -19,7 +19,7 @@
"ember-cli-sauce": "^1.0.0",
"ember-cli-yuidoc": "^0.4.0",
"ember-publisher": "0.0.7",
- "emberjs-build": "0.0.45",
+ "emberjs-build": "0.0.46",
"express": "^4.5.0",
"github": "^0.2.3",
"glob": "~4.3.2", | false |
Other | emberjs | ember.js | b120eb1240905251fec9eb50292fd7cb607f9fa9.json | Fix Ember.LinkView export test. | packages/ember-routing-views/lib/main.js | @@ -9,7 +9,7 @@ Ember Routing Views
import Ember from "ember-metal/core";
import "ember-routing-views/initializers/link-to-component";
-import { LinkView } from "ember-routing-views/views/link";
+import LinkView from "ember-routing-views/views/link";
import {
OutletView,
CoreOutletView | true |
Other | emberjs | ember.js | b120eb1240905251fec9eb50292fd7cb607f9fa9.json | Fix Ember.LinkView export test. | packages/ember-routing-views/tests/main_test.js | @@ -1,8 +1,8 @@
-import Ember from 'ember-metal/core';
+import Ember from 'ember-routing-views';
QUnit.module("ember-routing-views");
-QUnit.skip("exports correctly", function() {
+QUnit.test("exports correctly", function() {
ok(Ember.LinkView, "LinkView is exported correctly");
ok(Ember.OutletView, "OutletV... | true |
Other | emberjs | ember.js | 5e19bfa7e3b739e8913631cfb2e075a23bc65233.json | Fix debugger keyword | packages/ember-htmlbars/lib/keywords/debugger.js | @@ -39,16 +39,13 @@ import Logger from "ember-metal/logger";
@param {String} property
*/
export default function debuggerKeyword(morph, env, scope) {
+ /* jshint unused: false, debug: true */
- /* jshint unused: false */
- var view = scope.locals.view;
+ var view = env.hooks.getValue(scope.locals.view);
+ v... | false |
Other | emberjs | ember.js | 34e28a248cf3a9e03ad1d94e430dfc376bc29b67.json | Use `isStream` helper to check for streamness. | packages/ember-metal/lib/streams/stream.js | @@ -4,6 +4,9 @@ import {
getTailPath
} from "ember-metal/path_cache";
import Ember from "ember-metal/core";
+import {
+ isStream
+} from 'ember-metal/streams/utils';
/**
@module ember-metal
@@ -76,7 +79,7 @@ Dependency.prototype.removeFrom = function(stream) {
};
Dependency.prototype.replace = function(st... | false |
Other | emberjs | ember.js | 99854697b6e88f58bf85e1acc5e5f8a80b3ecd1a.json | Deprecate the non-block params {{with}} syntax | packages/ember-htmlbars/lib/helpers/with.js | @@ -28,7 +28,7 @@ import WithView from "ember-views/views/with_view";
NOTE: The alias should not reuse a name from the bound property path.
For example: `{{#with foo as |foo.bar|}}` is not supported because it attempts to alias using
- the first part of the property path, `foo`. Instead, use `{{#with foo.bar a... | true |
Other | emberjs | ember.js | 99854697b6e88f58bf85e1acc5e5f8a80b3ecd1a.json | Deprecate the non-block params {{with}} syntax | packages/ember-htmlbars/tests/compat/handlebars_get_test.js | @@ -71,7 +71,7 @@ QUnit.test('it can lookup a path from the current keywords', function() {
controller: {
foo: 'bar'
},
- template: compile('{{#with foo as bar}}{{handlebars-get "bar"}}{{/with}}')
+ template: compile('{{#with foo as |bar|}}{{handlebars-get "bar"}}{{/with}}')
});
runAppend... | true |
Other | emberjs | ember.js | 99854697b6e88f58bf85e1acc5e5f8a80b3ecd1a.json | Deprecate the non-block params {{with}} syntax | packages/ember-htmlbars/tests/helpers/bind_attr_test.js | @@ -259,7 +259,7 @@ QUnit.test("{{bindAttr}} can be used to bind attributes [DEPRECATED]", function(
});
QUnit.test("should be able to bind element attributes using {{bind-attr}} inside a block", function() {
- var template = compile('{{#with view.content as image}}<img {{bind-attr src=image.url alt=image.title}}>... | true |
Other | emberjs | ember.js | 99854697b6e88f58bf85e1acc5e5f8a80b3ecd1a.json | Deprecate the non-block params {{with}} syntax | packages/ember-htmlbars/tests/helpers/with_test.js | @@ -17,13 +17,23 @@ import { runAppend, runDestroy } from "ember-runtime/tests/utils";
var view, lookup;
var originalLookup = Ember.lookup;
-function testWithAs(moduleName, templateString) {
+function testWithAs(moduleName, templateString, deprecated) {
QUnit.module(moduleName, {
setup() {
Ember.look... | true |
Other | emberjs | ember.js | 99854697b6e88f58bf85e1acc5e5f8a80b3ecd1a.json | Deprecate the non-block params {{with}} syntax | packages/ember-htmlbars/tests/helpers/yield_test.js | @@ -169,7 +169,7 @@ QUnit.test("outer keyword doesn't mask inner component property", function () {
view = EmberView.create({
controller: { boundText: "outer", component: component },
- template: compile('{{#with boundText as item}}{{#view component}}{{item}}{{/view}}{{/with}}')
+ template: compile('{{#... | true |
Other | emberjs | ember.js | 99854697b6e88f58bf85e1acc5e5f8a80b3ecd1a.json | Deprecate the non-block params {{with}} syntax | packages/ember-htmlbars/tests/integration/with_view_test.js | @@ -104,7 +104,7 @@ QUnit.test('bindings can be `this`, in which case they *are* the current context
QUnit.test('child views can be inserted inside a bind block', function() {
registry.register('template:nester', compile('<h1 id="hello-world">Hello {{world}}</h1>{{view view.bqView}}'));
- registry.register('temp... | true |
Other | emberjs | ember.js | 99854697b6e88f58bf85e1acc5e5f8a80b3ecd1a.json | Deprecate the non-block params {{with}} syntax | packages/ember-routing-htmlbars/tests/helpers/action_test.js | @@ -473,7 +473,7 @@ QUnit.test("should work properly in an #each block", function() {
ok(eventHandlerWasCalled, "The event handler was called");
});
-QUnit.test("should work properly in a {{#with foo as bar}} block", function() {
+QUnit.test("should work properly in a {{#with foo as |bar|}} block", function() {
... | true |
Other | emberjs | ember.js | 99854697b6e88f58bf85e1acc5e5f8a80b3ecd1a.json | Deprecate the non-block params {{with}} syntax | packages/ember-template-compiler/lib/plugins/transform-with-as-to-hash.js | @@ -42,6 +42,13 @@ TransformWithAsToHash.prototype.transform = function TransformWithAsToHash_trans
throw new Error('You cannot use keyword (`{{with foo as bar}}`) and block params (`{{with foo as |bar|}}`) at the same time.');
}
+ Ember.deprecate(
+ "Using {{with}} without block syntax is... | true |
Other | emberjs | ember.js | 445ce4780e56d3787a507219e0ba3e8533c0d201.json | Enable IE9 in cross-browser tests. | testem.json | @@ -41,6 +41,7 @@
"launch_in_ci": [
"SL_Chrome_Current",
"SL_IE_11",
- "SL_IE_10"
+ "SL_IE_10",
+ "SL_IE_9"
]
} | false |
Other | emberjs | ember.js | a1bff0683604ee321f5acc10ea03d9d05ded0645.json | Drop tests for removed isVirtual behaviors | packages/ember-views/tests/views/view/virtual_views_test.js | @@ -1,97 +0,0 @@
-import { get } from "ember-metal/property_get";
-import run from "ember-metal/run_loop";
-import jQuery from "ember-views/system/jquery";
-import EmberView from "ember-views/views/view";
-
-var rootView, childView;
-
-QUnit.module("virtual views", {
- teardown() {
- run(function() {
- rootVie... | false |
Other | emberjs | ember.js | 2dd00930d3e7b64346a18f7b11939bda72646578.json | Fix rebase conflicts and get tests passing | packages/ember-htmlbars/tests/attr_nodes/style_test.js | @@ -5,7 +5,6 @@ import EmberView from "ember-views/views/view";
import compile from "ember-template-compiler/system/compile";
import { SafeString } from "ember-htmlbars/utils/string";
import { runAppend, runDestroy } from "ember-runtime/tests/utils";
-import { styleWarning } from "ember-views/attr_nodes/attr_node";
... | true |
Other | emberjs | ember.js | 2dd00930d3e7b64346a18f7b11939bda72646578.json | Fix rebase conflicts and get tests passing | packages/ember-htmlbars/tests/helpers/bind_attr_test.js | @@ -13,7 +13,6 @@ import { observersFor } from "ember-metal/observer";
import { Registry } from "ember-runtime/system/container";
import { set } from "ember-metal/property_set";
import { runAppend, runDestroy } from "ember-runtime/tests/utils";
-import { styleWarning } from "ember-views/attr_nodes/attr_node";
impor... | true |
Other | emberjs | ember.js | 2dd00930d3e7b64346a18f7b11939bda72646578.json | Fix rebase conflicts and get tests passing | packages/ember-htmlbars/tests/helpers/each_test.js | @@ -529,10 +529,6 @@ QUnit.test("it defers all normalization of itemView names to the resolver", func
});
registry.register('view:an-item-view', itemView);
- //registry.resolve = function(fullname) {
- //equal(fullname, "view:an-item-view", "leaves fullname untouched");
- //return Registry.prototype.reso... | true |
Other | emberjs | ember.js | 2dd00930d3e7b64346a18f7b11939bda72646578.json | Fix rebase conflicts and get tests passing | packages/ember-htmlbars/tests/helpers/input_test.js | @@ -398,13 +398,18 @@ QUnit.test("checkbox checked property is updated", function() {
});
QUnit.module("{{input type='text'}} - null/undefined values", {
+ setup() {
+ commonSetup();
+ },
+
teardown() {
runDestroy(view);
}
});
-QUnit.test("placeholder attribute bound to undefined is not present",... | true |
Other | emberjs | ember.js | 2dd00930d3e7b64346a18f7b11939bda72646578.json | Fix rebase conflicts and get tests passing | packages/ember-metal/lib/streams/key-stream.js | @@ -46,6 +46,7 @@ merge(KeyStream.prototype, {
addObserver(object, this.key, this, this.notify);
this.observedObject = object;
}
+ },
becameInactive() {
if (this.observedObject) { | true |
Other | emberjs | ember.js | 2dd00930d3e7b64346a18f7b11939bda72646578.json | Fix rebase conflicts and get tests passing | packages/ember-metal/lib/streams/simple-stream.js | @@ -45,9 +45,6 @@ merge(SimpleStream.prototype, {
destroy() {
if (this._super$destroy()) {
- if (isStream(this.source)) {
- this.source.unsubscribe(this._didChange, this);
- }
this.source = undefined;
return true;
} | true |
Other | emberjs | ember.js | 2dd00930d3e7b64346a18f7b11939bda72646578.json | Fix rebase conflicts and get tests passing | packages/ember-metal/lib/streams/stream.js | @@ -119,6 +119,9 @@ Stream.prototype = {
this.cache = undefined;
this.subscriberHead = null;
this.subscriberTail = null;
+ this.dependencyHead = null;
+ this.dependencyTail = null;
+ this.dependency = null;
this.children = undefined;
this.dependencies = undefined;
this.label = lab... | true |
Other | emberjs | ember.js | 2dd00930d3e7b64346a18f7b11939bda72646578.json | Fix rebase conflicts and get tests passing | packages/ember-routing-htmlbars/tests/helpers/render_test.js | @@ -529,7 +529,7 @@ QUnit.skip("throws an assertion if {{render}} is called with a literal for a mod
}, "The second argument of {{render}} must be a path, e.g. {{render \"post\" post}}.");
});
-QUnit.test("{{render}} helper should let view provide its own template", function() {
+QUnit.skip("{{render}} helper sho... | true |
Other | emberjs | ember.js | 2dd00930d3e7b64346a18f7b11939bda72646578.json | Fix rebase conflicts and get tests passing | packages/ember-views/lib/streams/should_display.js | @@ -55,6 +55,7 @@ ShouldDisplayStream.prototype.valueFn = function() {
}
this.oldPredicate = newPredicate;
}
+};
ShouldDisplayStream.prototype.compute = function() {
var truthy = read(this.isTruthyStream);
@@ -67,7 +68,7 @@ ShouldDisplayStream.prototype.compute = function() {
return length !== 0... | true |
Other | emberjs | ember.js | 2dd00930d3e7b64346a18f7b11939bda72646578.json | Fix rebase conflicts and get tests passing | packages/ember-views/tests/streams/key_stream_test.js | @@ -1,131 +0,0 @@
-import { set } from "ember-metal/property_set";
-import Stream from "ember-metal/streams/stream";
-import KeyStream from "ember-views/streams/key_stream";
-
-var source, object, count;
-
-function incrementCount() {
- count++;
-}
-
-QUnit.module('KeyStream', {
- setup: function() {
- count = 0;
... | true |
Other | emberjs | ember.js | 2dd00930d3e7b64346a18f7b11939bda72646578.json | Fix rebase conflicts and get tests passing | packages/ember-views/tests/views/view/is_visible_test.js | @@ -3,7 +3,7 @@ import { set } from "ember-metal/property_set";
import run from "ember-metal/run_loop";
import EmberView from "ember-views/views/view";
import ContainerView from "ember-views/views/container_view";
-import compile from "ember-template-compiler/system/compile";
+//import compile from "ember-template-c... | true |
Other | emberjs | ember.js | 2dd00930d3e7b64346a18f7b11939bda72646578.json | Fix rebase conflicts and get tests passing | packages/ember/tests/routing/basic_test.js | @@ -3747,7 +3747,7 @@ QUnit.test("Allows any route to disconnectOutlet another route's templates", fun
equal(trim(Ember.$('#qunit-fixture').text()), 'hi');
});
-QUnit.test("Can render({into:...}) the render helper", function() {
+QUnit.skip("Can render({into:...}) the render helper", function() {
Ember.TEMPLAT... | true |
Other | emberjs | ember.js | f6640d7da59bc234617b233886de6783ab0b1228.json | Update HTMLBars to v0.12.0.
No longer requires `npm link` for HTMLBars. | package.json | @@ -24,7 +24,7 @@
"express": "^4.5.0",
"github": "^0.2.3",
"glob": "~4.3.2",
- "htmlbars": "0.11.2",
+ "htmlbars": "0.12.0",
"qunit-extras": "^1.3.0",
"qunitjs": "^1.16.0",
"route-recognizer": "0.1.5", | false |
Other | emberjs | ember.js | 0346b9bfe8b5a94480f0027eddf7887f8896b8fb.json | Mark 3 regressions as skipped | packages/ember-views/tests/views/collection_test.js | @@ -45,7 +45,7 @@ QUnit.test("should render a view for each item in its content array", function()
equal(view.$('div').length, 4);
});
-QUnit.test("should render the emptyView if content array is empty (view class)", function() {
+QUnit.skip("should render the emptyView if content array is empty (view class)", fu... | false |
Other | emberjs | ember.js | 3e61a6ac9750cdc428f57b6dafb4277533a4f41a.json | Fix style errors | packages/ember-htmlbars/lib/keywords/view.js | @@ -64,8 +64,11 @@ function swapKey(hash, original, update) {
var newHash = {};
for (var prop in hash) {
- if (prop === original) { newHash[update] = hash[prop]; }
- else { newHash[prop] = hash[prop]; }
+ if (prop === original) {
+ newHash[update] = hash[prop];
+ } else {
+ newHash[prop] =... | true |
Other | emberjs | ember.js | 3e61a6ac9750cdc428f57b6dafb4277533a4f41a.json | Fix style errors | packages/ember-htmlbars/tests/helpers/view_test.js | @@ -153,7 +153,7 @@ QUnit.test("View lookup - 'fu'", function() {
view = EmberView.extend({
template: compile("{{view 'fu'}}"),
- container: container,
+ container: container
}).create();
runAppend(view); | true |
Other | emberjs | ember.js | 3e61a6ac9750cdc428f57b6dafb4277533a4f41a.json | Fix style errors | packages/ember-htmlbars/tests/helpers/yield_test.js | @@ -322,7 +322,7 @@ QUnit.module("ember-htmlbars: Component {{yield}}", {
QUnit.skip("yield with nested components (#3220)", function() {
var InnerComponent = Component.extend({
- layout: compile("{{yield}}"),
+ layout: compile("{{yield}}")
});
registerHelper('inner-component', makeViewHelper(InnerC... | true |
Other | emberjs | ember.js | 3e61a6ac9750cdc428f57b6dafb4277533a4f41a.json | Fix style errors | packages/ember-template-compiler/lib/plugins/transform-each-into-collection.js | @@ -22,13 +22,14 @@ function validate(node) {
return (node.type === 'BlockStatement' || node.type === 'MustacheStatement') &&
node.sexpr.path.original === 'each' &&
any(node.sexpr.hash.pairs, pair => {
- return pair.key === 'itemController' ||
- pair.key === 'itemView' ||
- pair.key ... | true |
Other | emberjs | ember.js | 907910fb29ea62b87adc2055e09df93691b853fd.json | Take machete to inBuffer state | packages/ember-views/lib/views/states.js | @@ -2,7 +2,6 @@ import create from 'ember-metal/platform/create';
import merge from "ember-metal/merge";
import _default from "ember-views/views/states/default";
import preRender from "ember-views/views/states/pre_render";
-import inBuffer from "ember-views/views/states/in_buffer";
import hasElement from "ember-vie... | true |
Other | emberjs | ember.js | 907910fb29ea62b87adc2055e09df93691b853fd.json | Take machete to inBuffer state | packages/ember-views/lib/views/states/in_buffer.js | @@ -1,71 +0,0 @@
-import _default from "ember-views/views/states/default";
-import EmberError from "ember-metal/error";
-
-import jQuery from "ember-views/system/jquery";
-import create from 'ember-metal/platform/create';
-import merge from "ember-metal/merge";
-
-/**
-@module ember
-@submodule ember-views
-*/
-
-var i... | true |
Other | emberjs | ember.js | 5b395543ae0047adc809b49ac3a6ae5cf7e241d1.json | Implement ContainerView and CollectionView
The majority of this commit removes very legacy code from the
CollectionView tests, which was all that was needed to get most of them
working. Because CollectionView is a thin layer on top of ContainerView,
once ContainerView was passing, CollectionView came with it.
The onl... | packages/ember-htmlbars/lib/env.js | @@ -17,6 +17,8 @@ import getChild from "ember-htmlbars/hooks/get-child";
import getValue from "ember-htmlbars/hooks/get-value";
import cleanupRenderNode from "ember-htmlbars/hooks/cleanup-render-node";
import destroyRenderNode from "ember-htmlbars/hooks/destroy-render-node";
+import willCleanupTree from "ember-htmlb... | true |
Other | emberjs | ember.js | 5b395543ae0047adc809b49ac3a6ae5cf7e241d1.json | Implement ContainerView and CollectionView
The majority of this commit removes very legacy code from the
CollectionView tests, which was all that was needed to get most of them
working. Because CollectionView is a thin layer on top of ContainerView,
once ContainerView was passing, CollectionView came with it.
The onl... | packages/ember-htmlbars/lib/helpers/each.js | @@ -6,7 +6,7 @@ export default function eachHelper(params, hash, blocks) {
var keyPath = hash.key;
// TODO: Correct falsy semantics
- if (!list) {
+ if (!list || get(list, 'length') === 0) {
if (blocks.inverse.yield) { blocks.inverse.yield(); }
return;
} | true |
Other | emberjs | ember.js | 5b395543ae0047adc809b49ac3a6ae5cf7e241d1.json | Implement ContainerView and CollectionView
The majority of this commit removes very legacy code from the
CollectionView tests, which was all that was needed to get most of them
working. Because CollectionView is a thin layer on top of ContainerView,
once ContainerView was passing, CollectionView came with it.
The onl... | packages/ember-htmlbars/lib/hooks/did-cleanup-tree.js | @@ -0,0 +1,6 @@
+export default function didCleanupTree(env) {
+ var view;
+ if (view = env.view) {
+ view.ownerView.isDestroyingSubtree = false;
+ }
+} | true |
Other | emberjs | ember.js | 5b395543ae0047adc809b49ac3a6ae5cf7e241d1.json | Implement ContainerView and CollectionView
The majority of this commit removes very legacy code from the
CollectionView tests, which was all that was needed to get most of them
working. Because CollectionView is a thin layer on top of ContainerView,
once ContainerView was passing, CollectionView came with it.
The onl... | packages/ember-htmlbars/lib/hooks/will-cleanup-tree.js | @@ -0,0 +1,10 @@
+export default function willCleanupTree(env, morph) {
+ var view = morph.emberView;
+ if (view && view.parentView) {
+ view.parentView.removeChild(view);
+ }
+
+ if (view = env.view) {
+ view.ownerView.isDestroyingSubtree = true;
+ }
+} | true |
Other | emberjs | ember.js | 5b395543ae0047adc809b49ac3a6ae5cf7e241d1.json | Implement ContainerView and CollectionView
The majority of this commit removes very legacy code from the
CollectionView tests, which was all that was needed to get most of them
working. Because CollectionView is a thin layer on top of ContainerView,
once ContainerView was passing, CollectionView came with it.
The onl... | packages/ember-htmlbars/lib/morphs/morph.js | @@ -24,7 +24,13 @@ proto.addDestruction = function(toDestroy) {
proto.cleanup = function() {
var view;
+
if (view = this.emberView) {
+ if (!view.ownerView.isDestroyingSubtree) {
+ view.ownerView.isDestroyingSubtree = true;
+ if (view.parentView) { view.parentView.removeChild(view); }
+ }
+
... | true |
Other | emberjs | ember.js | 5b395543ae0047adc809b49ac3a6ae5cf7e241d1.json | Implement ContainerView and CollectionView
The majority of this commit removes very legacy code from the
CollectionView tests, which was all that was needed to get most of them
working. Because CollectionView is a thin layer on top of ContainerView,
once ContainerView was passing, CollectionView came with it.
The onl... | packages/ember-htmlbars/lib/templates/container-view.hbs | @@ -1 +1 @@
-{{#each childViews key='elementId' as |childView|}}{{view childView}}{{/each}}
\ No newline at end of file
+{{#each childViews key='elementId' as |childView|}}{{view childView}}{{else if emptyView}}{{view emptyView}}{{/each}}
\ No newline at end of file | true |
Other | emberjs | ember.js | 5b395543ae0047adc809b49ac3a6ae5cf7e241d1.json | Implement ContainerView and CollectionView
The majority of this commit removes very legacy code from the
CollectionView tests, which was all that was needed to get most of them
working. Because CollectionView is a thin layer on top of ContainerView,
once ContainerView was passing, CollectionView came with it.
The onl... | packages/ember-htmlbars/tests/helpers/each_test.js | @@ -719,7 +719,7 @@ QUnit.skip("it supports {{emptyViewClass=}} with in format", function() {
assertText(view, "I'm empty");
});
-QUnit.skip("it supports {{else}}", function() {
+QUnit.test("it supports {{else}}", function() {
runDestroy(view);
view = EmberView.create({
template: templateFor("{{#each v... | true |
Other | emberjs | ember.js | 5b395543ae0047adc809b49ac3a6ae5cf7e241d1.json | Implement ContainerView and CollectionView
The majority of this commit removes very legacy code from the
CollectionView tests, which was all that was needed to get most of them
working. Because CollectionView is a thin layer on top of ContainerView,
once ContainerView was passing, CollectionView came with it.
The onl... | packages/ember-htmlbars/tests/helpers/view_test.js | @@ -672,7 +672,7 @@ QUnit.skip('{{view}} should not override class bindings defined on a child view'
ok(view.$('.visible').length > 0, 'class bindings are not overriden');
});
-QUnit.skip('child views can be inserted using the {{view}} helper', function() {
+QUnit.test('child views can be inserted using the {{vie... | true |
Other | emberjs | ember.js | 5b395543ae0047adc809b49ac3a6ae5cf7e241d1.json | Implement ContainerView and CollectionView
The majority of this commit removes very legacy code from the
CollectionView tests, which was all that was needed to get most of them
working. Because CollectionView is a thin layer on top of ContainerView,
once ContainerView was passing, CollectionView came with it.
The onl... | packages/ember-htmlbars/tests/integration/binding_integration_test.js | @@ -102,7 +102,7 @@ QUnit.skip('should cleanup bound properties on rerender', function() {
equal(view.childViews.length, 1);
});
-QUnit.skip("should update bound values after view's parent is removed and then re-appended", function() {
+QUnit.test("should update bound values after view's parent is removed and the... | true |
Other | emberjs | ember.js | 5b395543ae0047adc809b49ac3a6ae5cf7e241d1.json | Implement ContainerView and CollectionView
The majority of this commit removes very legacy code from the
CollectionView tests, which was all that was needed to get most of them
working. Because CollectionView is a thin layer on top of ContainerView,
once ContainerView was passing, CollectionView came with it.
The onl... | packages/ember-htmlbars/tests/integration/with_view_test.js | @@ -102,7 +102,7 @@ QUnit.skip('bindings can be `this`, in which case they *are* the current context
equal(trim(view.$().text()), 'Name: SFMoMA Price: $20', 'should print baz twice');
});
-QUnit.skip('child views can be inserted inside a bind block', function() {
+QUnit.test('child views can be inserted inside a ... | true |
Other | emberjs | ember.js | 5b395543ae0047adc809b49ac3a6ae5cf7e241d1.json | Implement ContainerView and CollectionView
The majority of this commit removes very legacy code from the
CollectionView tests, which was all that was needed to get most of them
working. Because CollectionView is a thin layer on top of ContainerView,
once ContainerView was passing, CollectionView came with it.
The onl... | packages/ember-htmlbars/tests/system/append-templated-view-test.js | @@ -10,7 +10,7 @@ QUnit.module('ember-htmlbars: appendTemplatedView', {
}
});
-QUnit.skip('can accept a view instance', function() {
+QUnit.test('can accept a view instance', function() {
var controller = {
someProp: 'controller context',
someView: EmberView.create({
@@ -28,7 +28,7 @@ QUnit.skip('can... | true |
Other | emberjs | ember.js | 5b395543ae0047adc809b49ac3a6ae5cf7e241d1.json | Implement ContainerView and CollectionView
The majority of this commit removes very legacy code from the
CollectionView tests, which was all that was needed to get most of them
working. Because CollectionView is a thin layer on top of ContainerView,
once ContainerView was passing, CollectionView came with it.
The onl... | packages/ember-views/lib/views/collection_view.js | @@ -5,12 +5,10 @@
*/
import Ember from "ember-metal/core"; // Ember.assert
-import { isGlobalPath } from "ember-metal/binding";
import { get } from "ember-metal/property_get";
import { set } from "ember-metal/property_set";
import { fmt } from "ember-runtime/system/string";
import ContainerView from "ember-view... | true |
Other | emberjs | ember.js | 5b395543ae0047adc809b49ac3a6ae5cf7e241d1.json | Implement ContainerView and CollectionView
The majority of this commit removes very legacy code from the
CollectionView tests, which was all that was needed to get most of them
working. Because CollectionView is a thin layer on top of ContainerView,
once ContainerView was passing, CollectionView came with it.
The onl... | packages/ember-views/lib/views/states/in_dom.js | @@ -27,9 +27,8 @@ merge(inDOM, {
},
exit(view) {
- if (!this.isVirtual) {
- view._unregister();
- }
+ view._unregister();
+ view.renderer.willDestroyElement(view);
},
appendAttr(view, attrNode) { | true |
Other | emberjs | ember.js | 5b395543ae0047adc809b49ac3a6ae5cf7e241d1.json | Implement ContainerView and CollectionView
The majority of this commit removes very legacy code from the
CollectionView tests, which was all that was needed to get most of them
working. Because CollectionView is a thin layer on top of ContainerView,
once ContainerView was passing, CollectionView came with it.
The onl... | packages/ember-views/tests/views/collection_test.js | @@ -1,6 +1,5 @@
import Ember from "ember-metal/core"; // Ember.A
import { set } from "ember-metal/property_set";
-import { get } from "ember-metal/property_get";
import run from "ember-metal/run_loop";
import { forEach } from "ember-metal/enumerable_utils";
import { Mixin } from "ember-metal/mixin";
@@ -10,8 +9,11... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-application/tests/system/logging_test.js | @@ -205,7 +205,7 @@ QUnit.test("do not log when template and view are missing when flag is not true"
});
});
-QUnit.test("log which view is used with a template", function() {
+QUnit.skip("log which view is used with a template", function() {
if (EmberDev && EmberDev.runningProdBuild) {
ok(true, 'Logging ... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-metal-views/tests/attributes_test.js | @@ -6,7 +6,7 @@ import {
testsFor("ember-metal-views - attributes");
-QUnit.test('aliased attributeBindings', function() {
+QUnit.skip('aliased attributeBindings', function() {
var view = {
isView: true,
attributeBindings: ['isDisabled:disabled'], | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-metal-views/tests/children_test.js | @@ -7,7 +7,7 @@ import {
testsFor("ember-metal-views - children");
-QUnit.test("a view can have child views", function() {
+QUnit.skip("a view can have child views", function() {
var view = {
isView: true,
tagName: 'ul',
@@ -20,7 +20,7 @@ QUnit.test("a view can have child views", function() {
equal... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-metal-views/tests/main_test.js | @@ -15,15 +15,15 @@ testsFor("ember-metal-views", {
});
// Test the behavior of the helper createElement stub
-QUnit.test("by default, view renders as a div", function() {
+QUnit.skip("by default, view renders as a div", function() {
view = { isView: true };
appendTo(view);
equalHTML('qunit-fixture', "<d... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-metal/tests/streams/key-stream-test.js | @@ -29,17 +29,17 @@ QUnit.module('KeyStream', {
}
});
-QUnit.test("can be instantiated manually", function() {
+QUnit.skip("can be instantiated manually", function() {
var nameStream = new KeyStream(source, 'name');
equal(nameStream.value(), "mmun", "Stream value is correct");
});
-QUnit.test("can be ins... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-metal/tests/streams/simple-stream-test.js | @@ -22,15 +22,15 @@ QUnit.module('SimpleStream', {
}
});
-QUnit.test('supports a stream argument', function() {
+QUnit.skip('supports a stream argument', function() {
var stream = new SimpleStream(source);
equal(stream.value(), "zlurp");
stream.setValue("blorg");
equal(stream.value(), "blorg");
});... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-routing-htmlbars/tests/helpers/action_test.js | @@ -52,7 +52,7 @@ QUnit.module("ember-routing-htmlbars: action helper", {
}
});
-QUnit.test("should output a data attribute with a guid", function() {
+QUnit.skip("should output a data attribute with a guid", function() {
view = EmberView.create({
template: compile('<a href="#" {{action "edit"}}>edit</a>'... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-routing-htmlbars/tests/helpers/outlet_test.js | @@ -76,7 +76,7 @@ QUnit.test("outlet should support an optional name", function() {
});
-QUnit.test("outlet should correctly lookup a view", function() {
+QUnit.skip("outlet should correctly lookup a view", function() {
var CoreOutlet = container.lookupFactory('view:core-outlet');
var SpecialOutlet = CoreOut... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-routing-htmlbars/tests/helpers/render_test.js | @@ -59,7 +59,7 @@ QUnit.module("ember-routing-htmlbars: {{render}} helper", {
}
});
-QUnit.test("{{render}} helper should render given template", function() {
+QUnit.skip("{{render}} helper should render given template", function() {
var template = "<h1>HI</h1>{{render 'home'}}";
var controller = EmberContr... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-routing-views/tests/main_test.js | @@ -2,7 +2,7 @@ import Ember from 'ember-metal/core';
QUnit.module("ember-routing-views");
-QUnit.test("exports correctly", function() {
+QUnit.skip("exports correctly", function() {
ok(Ember.LinkView, "LinkView is exported correctly");
ok(Ember.OutletView, "OutletView is exported correctly");
}); | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-testing/tests/helpers_test.js | @@ -316,7 +316,7 @@ QUnit.test("`wait` helper can be passed a resolution value", function() {
});
-QUnit.test("`click` triggers appropriate events in order", function() {
+QUnit.skip("`click` triggers appropriate events in order", function() {
expect(5);
var click, wait, events;
@@ -551,7 +551,7 @@ QUnit.t... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-testing/tests/integration_test.js | @@ -85,7 +85,7 @@ QUnit.test("template is bound to empty array of people", function() {
});
});
-QUnit.test("template is bound to array of 2 people", function() {
+QUnit.skip("template is bound to array of 2 people", function() {
App.Person.find = function() {
var people = Ember.A();
var first = App.... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/system/event_dispatcher_test.js | @@ -27,7 +27,7 @@ QUnit.module("EventDispatcher", {
}
});
-QUnit.test("should dispatch events to views", function() {
+QUnit.skip("should dispatch events to views", function() {
var receivedEvent;
var parentMouseDownCalled = 0;
var childKeyDownCalled = 0;
@@ -84,7 +84,7 @@ QUnit.test("should dispatch eve... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/system/ext_test.js | @@ -3,7 +3,7 @@ import View from "ember-views/views/view";
QUnit.module("Ember.View additions to run queue");
-QUnit.test("View hierarchy is done rendering to DOM when functions queued in afterRender execute", function() {
+QUnit.skip("View hierarchy is done rendering to DOM when functions queued in afterRender ex... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/system/view_utils_test.js | @@ -33,7 +33,7 @@ QUnit.module("ViewUtils", {
});
-QUnit.test("getViewClientRects", function() {
+QUnit.skip("getViewClientRects", function() {
if (!hasGetClientRects || !ClientRectListCtor) {
ok(true, "The test environment does not support the DOM API required to run this test.");
return;
@@ -50,7 +5... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/collection_test.js | @@ -42,7 +42,7 @@ QUnit.test("should render a view for each item in its content array", function()
equal(view.$('div').length, 4);
});
-QUnit.test("should render the emptyView if content array is empty (view class)", function() {
+QUnit.skip("should render the emptyView if content array is empty (view class)", fu... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/component_test.js | @@ -29,7 +29,7 @@ QUnit.test("The context of an Ember.Component is itself", function() {
strictEqual(component, component.get('context'), "A component's context is itself");
});
-QUnit.test("The controller (target of `action`) of an Ember.Component is itself", function() {
+QUnit.skip("The controller (target of `... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/instrumentation_test.js | @@ -51,7 +51,7 @@ QUnit.test("generates the proper instrumentation details when called directly",
confirmPayload(payload, view);
});
-QUnit.test("should add ember-view to views", function() {
+QUnit.skip("should add ember-view to views", function() {
run(view, 'createElement');
confirmPayload(beforeCalls[... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/metamorph_view_test.js | @@ -32,7 +32,7 @@ QUnit.module("Metamorph views", {
}
});
-QUnit.test("a Metamorph view is not a view's parentView", function() {
+QUnit.skip("a Metamorph view is not a view's parentView", function() {
childView = EmberView.create({
render(buffer) {
buffer.push("<p>Bye bros</p>");
@@ -90,7 +90,7 @@... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/select_test.js | @@ -83,7 +83,7 @@ QUnit.test("should become disabled if the disabled attribute is changed", functi
ok(!select.element.disabled, 'disabled property is falsy');
});
-QUnit.test("can have options", function() {
+QUnit.skip("can have options", function() {
select.set('content', Ember.A([1, 2, 3]));
append();
... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/view/append_to_test.js | @@ -34,7 +34,7 @@ QUnit.test("should be added to the specified element when calling appendTo()", f
ok(viewElem.length > 0, "creates and appends the view's element");
});
-QUnit.test("should be added to the document body when calling append()", function() {
+QUnit.skip("should be added to the document body when ca... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/view/attribute_bindings_test.js | @@ -193,7 +193,7 @@ QUnit.test("should update attribute bindings with micro syntax", function() {
ok(!view.$().prop('disabled'), "updates disabled property when false");
});
-QUnit.test("should allow namespaced attributes in micro syntax", function () {
+QUnit.skip("should allow namespaced attributes in micro syn... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/view/child_views_test.js | @@ -30,15 +30,15 @@ QUnit.module('tests/views/view/child_views_tests.js', {
// parent element
// no parent element, no buffer, no element
-QUnit.test("should render an inserted child view when the child is inserted before a DOM element is created", function() {
+QUnit.skip("should render an inserted child view when... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/view/class_name_bindings_test.js | @@ -15,7 +15,7 @@ QUnit.module("EmberView - Class Name Bindings", {
}
});
-QUnit.test("should apply bound class names to the element", function() {
+QUnit.skip("should apply bound class names to the element", function() {
view = EmberView.create({
classNameBindings: ['priority', 'isUrgent', 'isClassified:... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/view/context_test.js | @@ -5,7 +5,7 @@ import ContainerView from "ember-views/views/container_view";
QUnit.module("EmberView - context property");
-QUnit.test("setting a controller on an inner view should change it context", function() {
+QUnit.skip("setting a controller on an inner view should change it context", function() {
var Ap... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/view/controller_test.js | @@ -4,7 +4,7 @@ import ContainerView from "ember-views/views/container_view";
QUnit.module("Ember.View - controller property");
-QUnit.test("controller property should be inherited from nearest ancestor with controller", function() {
+QUnit.skip("controller property should be inherited from nearest ancestor with c... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/view/create_child_view_test.js | @@ -23,7 +23,7 @@ QUnit.module("EmberView#createChildView", {
}
});
-QUnit.test("should create view from class with any passed attributes", function() {
+QUnit.skip("should create view from class with any passed attributes", function() {
var attrs = {
foo: "baz"
};
@@ -54,7 +54,7 @@ QUnit.test("should ... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/view/create_element_test.js | @@ -26,7 +26,7 @@ QUnit.test("returns the receiver", function() {
equal(ret, view, 'returns receiver');
});
-QUnit.test('should assert if `tagName` is an empty string and `classNameBindings` are specified', function() {
+QUnit.skip('should assert if `tagName` is an empty string and `classNameBindings` are specifi... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/view/destroy_element_test.js | @@ -28,7 +28,7 @@ QUnit.test("if it has no element, does nothing", function() {
equal(callCount, 0, 'did not invoke callback');
});
-QUnit.test("if it has a element, calls willDestroyElement on receiver and child views then deletes the element", function() {
+QUnit.skip("if it has a element, calls willDestroyElem... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/view/element_test.js | @@ -24,7 +24,7 @@ QUnit.test("returns null if the view has no element and no parent view", functio
equal(get(view, 'element'), null, 'has no element');
});
-QUnit.test("returns null if the view has no element and parent view has no element", function() {
+QUnit.skip("returns null if the view has no element and pa... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/view/is_visible_test.js | @@ -16,7 +16,7 @@ QUnit.module("EmberView#isVisible", {
}
});
-QUnit.test("should hide views when isVisible is false", function() {
+QUnit.skip("should hide views when isVisible is false", function() {
view = EmberView.create({
isVisible: false
});
@@ -37,7 +37,7 @@ QUnit.test("should hide views when i... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/view/jquery_test.js | @@ -36,7 +36,7 @@ QUnit.test("returns jQuery object selecting element if provided", function() {
equal(jquery[0], get(view, 'element'), 'element should be element');
});
-QUnit.test("returns jQuery object selecting element inside element if provided", function() {
+QUnit.skip("returns jQuery object selecting elem... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/view/layout_test.js | @@ -32,7 +32,7 @@ QUnit.test("Layout views return throw if their layout cannot be found", function
}, /cantBeFound/);
});
-QUnit.test("should call the function of the associated layout", function() {
+QUnit.skip("should call the function of the associated layout", function() {
var templateCalled = 0;
var la... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/view/nearest_of_type_test.js | @@ -21,7 +21,7 @@ QUnit.module("View#nearest*", {
}
});
- QUnit.test("nearestOfType should find the closest view by view class", function() {
+ QUnit.skip("nearestOfType should find the closest view by view class", function() {
var child;
run(function() {
@@ -33,7 +33,7 @@ QUnit.module("View#nea... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/view/remove_test.js | @@ -25,17 +25,17 @@ QUnit.module("View#removeChild", {
}
});
-QUnit.test("returns receiver", function() {
+QUnit.skip("returns receiver", function() {
equal(parentView.removeChild(child), parentView, 'receiver');
});
-QUnit.test("removes child from parent.childViews array", function() {
+QUnit.skip("removes... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/view/render_test.js | @@ -20,7 +20,7 @@ QUnit.module("EmberView#render", {
}
});
-QUnit.test("default implementation does not render child views", function() {
+QUnit.skip("default implementation does not render child views", function() {
expectDeprecation("Setting `childViews` on a Container is deprecated.");
var rendered = 0... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/view/template_test.js | @@ -21,7 +21,7 @@ QUnit.module("EmberView - Template Functionality", {
}
});
-QUnit.test("Template views return throw if their template cannot be found", function() {
+QUnit.skip("Template views return throw if their template cannot be found", function() {
view = EmberView.create({
templateName: 'cantBeFo... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/view/view_lifecycle_test.js | @@ -28,7 +28,7 @@ function tmpl(str) {
};
}
-QUnit.test("should create and append a DOM element after bindings have synced", function() {
+QUnit.skip("should create and append a DOM element after bindings have synced", function() {
var ViewTest;
lookup.ViewTest = ViewTest = {};
@@ -64,7 +64,7 @@ QUnit.tes... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember-views/tests/views/view/virtual_views_test.js | @@ -14,7 +14,7 @@ QUnit.module("virtual views", {
}
});
-QUnit.test("a virtual view does not appear as a view's parentView", function() {
+QUnit.skip("a virtual view does not appear as a view's parentView", function() {
rootView = EmberView.create({
elementId: 'root-view',
@@ -54,7 +54,7 @@ QUnit.test("... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember/tests/component_registration_test.js | @@ -67,7 +67,7 @@ function boot(callback) {
});
}
-QUnit.test("The helper becomes the body of the component", function() {
+QUnit.skip("The helper becomes the body of the component", function() {
boot();
equal(Ember.$('div.ember-view > div.ember-view', '#qunit-fixture').text(), "hello world", "The component... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember/tests/helpers/helper_registration_test.js | @@ -54,7 +54,7 @@ var boot = function(callback) {
});
};
-QUnit.test("Unbound dashed helpers registered on the container can be late-invoked", function() {
+QUnit.skip("Unbound dashed helpers registered on the container can be late-invoked", function() {
Ember.TEMPLATES.application = compile("<div id='wrappe... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember/tests/helpers/link_to_test.js | @@ -367,7 +367,7 @@ QUnit.test("The {{link-to}} helper supports multiple current-when routes", funct
equal(Ember.$('#link3.active', '#qunit-fixture').length, 0, "The link is not active since current-when does not contain the active route");
});
-QUnit.test("The {{link-to}} helper defaults to bubbling", function()... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember/tests/homepage_example_test.js | @@ -70,7 +70,7 @@ QUnit.module("Homepage Example", {
});
-QUnit.test("The example renders correctly", function() {
+QUnit.skip("The example renders correctly", function() {
Ember.run(App, 'advanceReadiness');
equal($fixture.find('h1:contains(People)').length, 1); | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember/tests/routing/basic_test.js | @@ -185,7 +185,7 @@ QUnit.test("The Homepage with explicit template name in renderTemplate", functio
equal(Ember.$('h3:contains(Megatroll)', '#qunit-fixture').length, 1, "The homepage template was rendered");
});
-QUnit.test("An alternate template will pull in an alternate controller", function() {
+QUnit.skip("A... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember/tests/routing/query_params_test.js | @@ -261,7 +261,7 @@ QUnit.test("model hooks receives query params", function() {
equal(router.get('location.path'), "");
});
-QUnit.test("controllers won't be eagerly instantiated by internal query params logic", function() {
+QUnit.skip("controllers won't be eagerly instantiated by internal query params logic", ... | true |
Other | emberjs | ember.js | 586f56bc0a6c5f94cc8885b4343acd98ed3dfe61.json | Skip remaining failing tests | packages/ember/tests/routing/substates_test.js | @@ -373,7 +373,7 @@ QUnit.test("Loading actions bubble to root, but don't enter substates above pivo
equal(appController.get('currentPath'), "grandma.smells", "Finished transition");
});
-QUnit.test("Default error event moves into nested route", function() {
+QUnit.skip("Default error event moves into nested rout... | true |
Other | emberjs | ember.js | b1470249b4eaf257fa074f0d4fa052f980653ca4.json | Fix style errors | packages/ember-metal/lib/streams/utils.js | @@ -191,7 +191,7 @@ export function concat(array, separator) {
}
}
-export function labelsFor(streams) {
+export function labelsFor(streams) {
var labels = [];
for (var i=0, l=streams.length; i<l; i++) {
@@ -202,7 +202,7 @@ export function labelsFor(streams) {
return labels;
}
-export function la... | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.