language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/tests/compat/handlebars_get_test.js | @@ -3,6 +3,7 @@ import EmberView from "ember-views/views/view";
import handlebarsGet from "ember-htmlbars/compat/handlebars-get";
import { Registry } from "ember-runtime/system/container";
import { runAppend, runDestroy } from "ember-runtime/tests/utils";
+import HandlebarsCompatibleHelper from "ember-htmlbars/compa... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/tests/compat/helper_test.js | @@ -11,6 +11,7 @@ import compile from "ember-template-compiler/system/compile";
import { runAppend, runDestroy } from "ember-runtime/tests/utils";
import Registry from "container/registry";
import ComponentLookup from 'ember-views/component_lookup';
+import HandlebarsCompatibleHelper from "ember-htmlbars/compat/help... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/tests/compat/make-view-helper_test.js | @@ -11,7 +11,6 @@ QUnit.module('ember-htmlbars: compat - makeViewHelper compat', {
setup() {
registry = new Registry();
container = registry.container();
- registry.optionsForType('helper', { instantiate: false });
},
teardown() { | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/tests/helpers/custom_helper_test.js | @@ -0,0 +1,360 @@
+import Component from "ember-views/views/component";
+import Helper from "ember-htmlbars/helper";
+import compile from "ember-template-compiler/system/compile";
+import { runAppend, runDestroy } from "ember-runtime/tests/utils";
+import Registry from "container/registry";
+import run from "ember-meta... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/tests/helpers/unbound_test.js | @@ -482,7 +482,6 @@ QUnit.module("ember-htmlbars: {{#unbound}} helper -- Container Lookup", {
Ember.lookup = lookup = { Ember: Ember };
registry = new Registry();
container = registry.container();
- registry.optionsForType('helper', { instantiate: false });
},
teardown() { | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/tests/helpers/view_test.js | @@ -49,7 +49,6 @@ QUnit.module("ember-htmlbars: {{#view}} helper", {
registry = new Registry();
container = registry.container();
registry.optionsForType('template', { instantiate: false });
- registry.optionsForType('helper', { instantiate: false });
registry.register('view:toplevel', EmberView.... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/tests/integration/block_params_test.js | @@ -22,7 +22,6 @@ QUnit.module("ember-htmlbars: block params", {
registry.optionsForType('component', { singleton: false });
registry.optionsForType('view', { singleton: false });
registry.optionsForType('template', { instantiate: false });
- registry.optionsForType('helper', { instantiate: false });
... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/tests/integration/component_element_id_test.js | @@ -14,7 +14,6 @@ QUnit.module('ember-htmlbars: component elementId', {
registry.optionsForType('component', { singleton: false });
registry.optionsForType('view', { singleton: false });
registry.optionsForType('template', { instantiate: false });
- registry.optionsForType('helper', { instantiate: fal... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/tests/integration/component_invocation_test.js | @@ -17,7 +17,6 @@ function commonSetup() {
registry.optionsForType('component', { singleton: false });
registry.optionsForType('view', { singleton: false });
registry.optionsForType('template', { instantiate: false });
- registry.optionsForType('helper', { instantiate: false });
registry.register('componen... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/tests/integration/component_lifecycle_test.js | @@ -17,7 +17,6 @@ QUnit.module('component - lifecycle hooks', {
registry.optionsForType('component', { singleton: false });
registry.optionsForType('view', { singleton: false });
registry.optionsForType('template', { instantiate: false });
- registry.optionsForType('helper', { instantiate: false });
... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/tests/integration/mutable_binding_test.js | @@ -17,7 +17,6 @@ QUnit.module('component - mutable bindings', {
registry.optionsForType('component', { singleton: false });
registry.optionsForType('view', { singleton: false });
registry.optionsForType('template', { instantiate: false });
- registry.optionsForType('helper', { instantiate: false });
... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/tests/integration/void-element-component-test.js | @@ -14,7 +14,6 @@ QUnit.module('ember-htmlbars: components for void elements', {
registry.optionsForType('component', { singleton: false });
registry.optionsForType('view', { singleton: false });
registry.optionsForType('template', { instantiate: false });
- registry.optionsForType('helper', { instant... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/tests/system/lookup-helper_test.js | @@ -1,7 +1,7 @@
import lookupHelper, { findHelper } from "ember-htmlbars/system/lookup-helper";
import ComponentLookup from "ember-views/component_lookup";
import Registry from "container/registry";
-import Component from "ember-views/views/component";
+import Helper from "ember-htmlbars/helper";
function generat... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/tests/system/make_bound_helper_test.js | @@ -21,7 +21,6 @@ QUnit.module("ember-htmlbars: makeBoundHelper", {
setup() {
registry = new Registry();
container = registry.container();
- registry.optionsForType('helper', { instantiate: false });
},
teardown() {
@@ -192,7 +191,7 @@ QUnit.test("bound helpers should not be invoked with blocks"... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/tests/system/make_view_helper_test.js | @@ -10,7 +10,6 @@ QUnit.module("ember-htmlbars: makeViewHelper", {
setup() {
registry = new Registry();
container = registry.container();
- registry.optionsForType('helper', { instantiate: false });
},
teardown() {
runDestroy(view); | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-views/lib/component_lookup.js | @@ -1,13 +1,12 @@
import Ember from 'ember-metal/core';
import EmberObject from "ember-runtime/system/object";
-import { ISNT_HELPER_CACHE } from "ember-htmlbars/system/lookup-helper";
+import { CONTAINS_DASH_CACHE } from "ember-htmlbars/system/lookup-helper";
export default EmberObject.extend({
invalidName(nam... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember/tests/helpers/helper_registration_test.js | @@ -1,6 +1,7 @@
import "ember";
import EmberHandlebars from "ember-htmlbars/compat";
+import HandlebarsCompatibleHelper from "ember-htmlbars/compat/helper";
var compile, helpers, makeBoundHelper;
compile = EmberHandlebars.compile;
@@ -56,13 +57,13 @@ var boot = function(callback) {
};
QUnit.test("Unbound da... | true |
Other | emberjs | ember.js | 930513b5c86007baa3e81c4d94f6ea8715a17880.json | Add special values to legacy `{{each}}`s' keyPath | packages/ember-htmlbars/lib/helpers/-legacy-each-with-controller.js | @@ -1,6 +1,7 @@
import { get } from "ember-metal/property_get";
import { forEach } from "ember-metal/enumerable_utils";
import normalizeSelf from "ember-htmlbars/utils/normalize-self";
+import decodeEachKey from "ember-htmlbars/utils/decode-each-key";
export default function legacyEachWithControllerHelper(params,... | true |
Other | emberjs | ember.js | 930513b5c86007baa3e81c4d94f6ea8715a17880.json | Add special values to legacy `{{each}}`s' keyPath | packages/ember-htmlbars/lib/helpers/-legacy-each-with-keyword.js | @@ -1,6 +1,6 @@
-import { get } from "ember-metal/property_get";
import { forEach } from "ember-metal/enumerable_utils";
import shouldDisplay from "ember-views/streams/should_display";
+import decodeEachKey from "ember-htmlbars/utils/decode-each-key";
export default function legacyEachWithKeywordHelper(params, has... | true |
Other | emberjs | ember.js | 930513b5c86007baa3e81c4d94f6ea8715a17880.json | Add special values to legacy `{{each}}`s' keyPath | packages/ember-htmlbars/lib/helpers/each.js | @@ -1,8 +1,7 @@
-import { get } from "ember-metal/property_get";
import { forEach } from "ember-metal/enumerable_utils";
-import { guidFor } from "ember-metal/utils";
import normalizeSelf from "ember-htmlbars/utils/normalize-self";
import shouldDisplay from "ember-views/streams/should_display";
+import decodeEachKey... | true |
Other | emberjs | ember.js | 930513b5c86007baa3e81c4d94f6ea8715a17880.json | Add special values to legacy `{{each}}`s' keyPath | packages/ember-htmlbars/lib/utils/decode-each-key.js | @@ -0,0 +1,26 @@
+import { get } from "ember-metal/property_get";
+import { guidFor } from "ember-metal/utils";
+
+export default function decodeEachKey(item, keyPath, index) {
+ var key;
+
+ switch (keyPath) {
+ case '@index':
+ key = index;
+ break;
+ case '@guid':
+ key = guidFor(item);
+ break;
+ c... | true |
Other | emberjs | ember.js | c963eed9ebebbc2075029348075e36f3cc6ba04a.json | Use model name instead of factory in data adapter | packages/ember-extension-support/lib/data_adapter.js | @@ -92,6 +92,20 @@ export default EmberObject.extend({
*/
attributeLimit: 3,
+ /**
+ * Ember Data > v1.0.0-beta.18
+ * requires string model names to be passed
+ * around instead of the actual factories.
+ *
+ * This is a stamp for the Ember Inspector
+ * to differentiate between the versions
+ *... | true |
Other | emberjs | ember.js | c963eed9ebebbc2075029348075e36f3cc6ba04a.json | Use model name instead of factory in data adapter | packages/ember-extension-support/tests/data_adapter_test.js | @@ -65,6 +65,20 @@ QUnit.test("Model types added with DefaultResolver", function() {
adapter.watchModelTypes(modelTypesAdded);
});
+QUnit.test("getRecords gets a model name as second argument", function() {
+ App.Post = Model.extend();
+
+ adapter = App.__container__.lookup('data-adapter:main');
+ adapter.reop... | true |
Other | emberjs | ember.js | f1df1d43d449b9aecb6c0585520cb10602ca9dd8.json | JSDoc: Replace "Integer" type with "Number"
"Integer" is not a valid type | packages/ember-runtime/lib/mixins/array.js | @@ -205,8 +205,8 @@ export default Mixin.create(Enumerable, {
```
@method slice
- @param {Integer} beginIndex (Optional) index to begin slicing from.
- @param {Integer} endIndex (Optional) index to end the slice at (but not included).
+ @param {Number} beginIndex (Optional) index to begin slicing f... | true |
Other | emberjs | ember.js | f1df1d43d449b9aecb6c0585520cb10602ca9dd8.json | JSDoc: Replace "Integer" type with "Number"
"Integer" is not a valid type | packages/ember-runtime/lib/mixins/comparable.js | @@ -32,7 +32,7 @@ export default Mixin.create({
@method compare
@param a {Object} the first object to compare
@param b {Object} the second object to compare
- @return {Integer} the result of the comparison
+ @return {Number} the result of the comparison
*/
compare: null
}); | true |
Other | emberjs | ember.js | da3003c547a09132f5744c3325804e6dae7407ef.json | JSDoc: Replace "Hash" type with "Object"
"Hash" is not a valid type | packages/ember-htmlbars/lib/helpers/bind-attr.js | @@ -124,7 +124,7 @@
@method bind-attr
@for Ember.Handlebars.helpers
@deprecated
- @param {Hash} options
+ @param {Object} options
@return {String} HTML string
*/
@@ -135,6 +135,6 @@
@for Ember.Handlebars.helpers
@deprecated
@param {Function} context
- @param {Hash} options
+ @param {Object} ... | true |
Other | emberjs | ember.js | da3003c547a09132f5744c3325804e6dae7407ef.json | JSDoc: Replace "Hash" type with "Object"
"Hash" is not a valid type | packages/ember-htmlbars/lib/helpers/with.js | @@ -34,7 +34,7 @@ import shouldDisplay from "ember-views/streams/should_display";
@method with
@for Ember.Handlebars.helpers
- @param {Hash} options
+ @param {Object} options
@return {String} HTML string
*/
| true |
Other | emberjs | ember.js | da3003c547a09132f5744c3325804e6dae7407ef.json | JSDoc: Replace "Hash" type with "Object"
"Hash" is not a valid type | packages/ember-metal/lib/computed.js | @@ -278,7 +278,7 @@ ComputedPropertyPrototype.property = function() {
via the `metaForProperty()` function.
@method meta
- @param {Hash} meta
+ @param {Object} meta
@chainable
*/
| true |
Other | emberjs | ember.js | da3003c547a09132f5744c3325804e6dae7407ef.json | JSDoc: Replace "Hash" type with "Object"
"Hash" is not a valid type | packages/ember-metal/lib/core.js | @@ -63,7 +63,7 @@ Ember.VERSION = 'VERSION_STRING_PLACEHOLDER';
hash must be created before loading Ember.
@property ENV
- @type Hash
+ @type Object
*/
if (Ember.ENV) { | true |
Other | emberjs | ember.js | da3003c547a09132f5744c3325804e6dae7407ef.json | JSDoc: Replace "Hash" type with "Object"
"Hash" is not a valid type | packages/ember-routing/lib/system/route.js | @@ -82,7 +82,7 @@ var Route = EmberObject.extend(ActionHandler, Evented, {
@property queryParams
@for Ember.Route
- @type Hash
+ @type Object
*/
queryParams: {},
| true |
Other | emberjs | ember.js | da3003c547a09132f5744c3325804e6dae7407ef.json | JSDoc: Replace "Hash" type with "Object"
"Hash" is not a valid type | packages/ember-runtime/lib/mixins/action_handler.js | @@ -140,7 +140,7 @@ var ActionHandler = Mixin.create({
```
@property actions
- @type Hash
+ @type Object
@default null
*/
| true |
Other | emberjs | ember.js | da3003c547a09132f5744c3325804e6dae7407ef.json | JSDoc: Replace "Hash" type with "Object"
"Hash" is not a valid type | packages/ember-runtime/lib/mixins/array.js | @@ -346,7 +346,7 @@ export default Mixin.create(Enumerable, {
@method addArrayObserver
@param {Object} target The observer object.
- @param {Hash} opts Optional hash of configuration options including
+ @param {Object} opts Optional hash of configuration options including
`willChange` and `didC... | true |
Other | emberjs | ember.js | da3003c547a09132f5744c3325804e6dae7407ef.json | JSDoc: Replace "Hash" type with "Object"
"Hash" is not a valid type | packages/ember-runtime/lib/mixins/enumerable.js | @@ -970,7 +970,7 @@ export default Mixin.create({
@method addEnumerableObserver
@param {Object} target
- @param {Hash} [opts]
+ @param {Object} [opts]
@return this
*/
addEnumerableObserver(target, opts) {
@@ -997,7 +997,7 @@ export default Mixin.create({
@method removeEnumerableObser... | true |
Other | emberjs | ember.js | da3003c547a09132f5744c3325804e6dae7407ef.json | JSDoc: Replace "Hash" type with "Object"
"Hash" is not a valid type | packages/ember-runtime/lib/mixins/observable.js | @@ -155,7 +155,7 @@ export default Mixin.create({
@method getProperties
@param {String...|Array} list of keys to get
- @return {Hash}
+ @return {Object}
*/
getProperties(...args) {
return getProperties.apply(null, [this].concat(args));
@@ -225,7 +225,7 @@ export default Mixin.create({
... | true |
Other | emberjs | ember.js | da3003c547a09132f5744c3325804e6dae7407ef.json | JSDoc: Replace "Hash" type with "Object"
"Hash" is not a valid type | packages/ember-runtime/lib/mixins/target_action_support.js | @@ -107,7 +107,7 @@ var TargetActionSupport = Mixin.create({
```
@method triggerAction
- @param opts {Hash} (optional, with the optional keys action, target and/or actionContext)
+ @param opts {Object} (optional, with the optional keys action, target and/or actionContext)
@return {Boolean} true if the acti... | true |
Other | emberjs | ember.js | da3003c547a09132f5744c3325804e6dae7407ef.json | JSDoc: Replace "Hash" type with "Object"
"Hash" is not a valid type | packages/ember-runtime/lib/system/string.js | @@ -124,7 +124,7 @@ function capitalize(str) {
@property STRINGS
@for Ember
- @type Hash
+ @type Object
*/
Ember.STRINGS = {};
| true |
Other | emberjs | ember.js | da3003c547a09132f5744c3325804e6dae7407ef.json | JSDoc: Replace "Hash" type with "Object"
"Hash" is not a valid type | packages/ember-views/lib/mixins/view_child_views_support.js | @@ -74,7 +74,7 @@ var ViewChildViewsSupport = Mixin.create({
@method createChildView
@param {Class|String} viewClass
- @param {Hash} [attrs] Attributes to add
+ @param {Object} [attrs] Attributes to add
@return {Ember.View} new instance
*/
createChildView(maybeViewClass, _attrs) { | true |
Other | emberjs | ember.js | da3003c547a09132f5744c3325804e6dae7407ef.json | JSDoc: Replace "Hash" type with "Object"
"Hash" is not a valid type | packages/ember-views/lib/system/event_dispatcher.js | @@ -124,7 +124,7 @@ export default EmberObject.extend({
@private
@method setup
- @param addedEvents {Hash}
+ @param addedEvents {Object}
*/
setup(addedEvents, rootElement) {
var event; | true |
Other | emberjs | ember.js | da3003c547a09132f5744c3325804e6dae7407ef.json | JSDoc: Replace "Hash" type with "Object"
"Hash" is not a valid type | packages/ember-views/lib/views/collection_view.js | @@ -345,7 +345,7 @@ var CollectionView = ContainerView.extend(EmptyViewSupport, {
@method createChildView
@param {Class} viewClass
- @param {Hash} [attrs] Attributes to add
+ @param {Object} [attrs] Attributes to add
@return {Ember.View} new instance
*/
createChildView(_view, attrs) {
@@ -3... | true |
Other | emberjs | ember.js | da3003c547a09132f5744c3325804e6dae7407ef.json | JSDoc: Replace "Hash" type with "Object"
"Hash" is not a valid type | packages/ember-views/lib/views/view.js | @@ -52,7 +52,7 @@ Ember.warn("The VIEW_PRESERVES_CONTEXT flag has been removed and the functionali
@property TEMPLATES
@for Ember
- @type Hash
+ @type Object
*/
Ember.TEMPLATES = {};
@@ -1499,7 +1499,7 @@ View.notifyMutationListeners = function() {
@property views
@static
- @type Hash
+ @type Ob... | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-htmlbars/lib/compat/make-bound-helper.js | @@ -32,7 +32,7 @@ import {
@method makeBoundHelper
@for Ember.Handlebars
- @param {Function} function
+ @param {Function} fn
@param {String} dependentKeys*
@since 1.2.0
@deprecated | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-htmlbars/lib/compat/register-bound-helper.js | @@ -114,7 +114,7 @@ var slice = [].slice;
@method registerBoundHelper
@for Ember.Handlebars
@param {String} name
- @param {Function} function
+ @param {Function} fn
@param {String} dependentKeys*
*/
export default function registerBoundHelper(name, fn) { | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-htmlbars/lib/helpers/each.js | @@ -73,9 +73,6 @@ import shouldDisplay from "ember-views/streams/should_display";
@method each
@for Ember.Handlebars.helpers
- @param [name] {String} name for item (used with `as`)
- @param [path] {String} path
- @param [options] {Object} Handlebars key/value pairs of options
*/
export default function eac... | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-htmlbars/lib/helpers/log.js | @@ -13,7 +13,7 @@ import Logger from "ember-metal/logger";
```
@method log
@for Ember.Handlebars.helpers
- @param {String} property
+ @param {*} values
*/
export default function logHelper(values) {
Logger.log.apply(null, values); | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-htmlbars/lib/helpers/with.js | @@ -34,7 +34,6 @@ import shouldDisplay from "ember-views/streams/should_display";
@method with
@for Ember.Handlebars.helpers
- @param {Function} context
@param {Hash} options
@return {String} HTML string
*/ | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-htmlbars/lib/keywords.js | @@ -22,7 +22,7 @@ var keywords = o_create(hooks.keywords);
@method _registerHelper
@for Ember.HTMLBars
@param {String} name
- @param {Object|Function} helperFunc the helper function to add
+ @param {Object|Function} keyword the keyword to add
*/
export function registerKeyword(name, keyword) {
keywords[... | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-htmlbars/lib/keywords/debugger.js | @@ -36,7 +36,6 @@ import Logger from "ember-metal/logger";
```
@method debugger
@for Ember.Handlebars.helpers
- @param {String} property
*/
export default function debuggerKeyword(morph, env, scope) {
/* jshint unused: false, debug: true */ | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-htmlbars/lib/system/lookup-helper.js | @@ -23,7 +23,6 @@ export var ISNT_HELPER_CACHE = new Cache(1000, function(key) {
@private
@method resolveHelper
- @param {Container} container
@param {String} name the name of the helper to lookup
@return {Handlebars Helper}
*/ | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-htmlbars/lib/system/make_bound_helper.js | @@ -46,7 +46,7 @@ import { readHash, readArray } from "ember-metal/streams/utils";
@private
@method makeBoundHelper
@for Ember.HTMLBars
- @param {Function} function
+ @param {Function} fn
@since 1.10.0
*/
export default function makeBoundHelper(fn) { | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-metal/lib/enumerable_utils.js | @@ -76,7 +76,6 @@ var deprecatedFilter = Ember.deprecateFunc('Ember.EnumberableUtils.filter is dep
* @method indexOf
* @deprecated Use ES5's Array.prototype.indexOf instead.
* @param {Object} obj The object to call indexOn on
- * @param {Function} callback The callback to execute
* @param {Object} index The ind... | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-metal/lib/instrumentation.js | @@ -81,7 +81,7 @@ var time = (function() {
@namespace Ember.Instrumentation
@param {String} [name] Namespaced event name.
- @param {Object} payload
+ @param {Object} _payload
@param {Function} callback Function that you're instrumenting.
@param {Object} binding Context that instrument function is called... | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-metal/lib/observer.js | @@ -29,8 +29,8 @@ function beforeEvent(keyName) {
@method addObserver
@for Ember
@param obj
- @param {String} path
- @param {Object|Function} targetOrMethod
+ @param {String} _path
+ @param {Object|Function} target
@param {Function|String} [method]
*/
export function addObserver(obj, _path, target, me... | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-metal/lib/property_set.js | @@ -164,7 +164,7 @@ function setPath(root, path, value, tolerant) {
@method trySet
@for Ember
- @param {Object} obj The object to modify.
+ @param {Object} root The object to modify.
@param {String} path The property path to set
@param {Object} value The value to set
*/ | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-metal/lib/utils.js | @@ -830,9 +830,9 @@ export function inspect(obj) {
// The following functions are intentionally minified to keep the functions
// below Chrome's function body size inlining limit of 600 chars.
/**
- @param {Object} target
- @param {Function} method
- @param {Array} args
+ @param {Object} t target
+ @param {Func... | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-metal/lib/watching.js | @@ -33,7 +33,7 @@ import {
@method watch
@for Ember
@param obj
- @param {String} keyName
+ @param {String} _keyPath
*/
function watch(obj, _keyPath, m) {
// can't watch length on Array - it is special... | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-routing-htmlbars/lib/keywords/action.js | @@ -165,9 +165,6 @@ import closureAction from "ember-routing-htmlbars/keywords/closure-action";
@method action
@for Ember.Handlebars.helpers
- @param {String} actionName
- @param {Object} [context]*
- @param {Hash} options
*/
export default function(morph, env, scope, params, hash, template, inverse, visit... | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-runtime/lib/computed/reduce_computed_macros.js | @@ -681,7 +681,7 @@ function binarySearch(array, item, low, high) {
@method sort
@for Ember.computed
- @param {String} dependentKey
+ @param {String} itemsKey
@param {String or Function} sortDefinition a dependent key to an
array of sort properties (add `:desc` to the arrays sort properties to sort desc... | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-runtime/lib/system/tracked_array.js | @@ -292,7 +292,7 @@ TrackedArray.prototype = {
@method ArrayOperation
@private
- @param {String} type The type of the operation. One of
+ @param {String} operation The type of the operation. One of
`Ember.TrackedArray.{RETAIN, INSERT, DELETE}`
@param {Number} count The number of items in this operatio... | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-template-compiler/lib/plugins/transform-angle-bracket-components.js | @@ -6,7 +6,7 @@ function TransformAngleBracketComponents() {
/**
@private
@method transform
- @param {AST} The AST to be transformed.
+ @param {AST} ast The AST to be transformed.
*/
TransformAngleBracketComponents.prototype.transform = function TransformBindAttrToAttributes_transform(ast) {
var walker = ... | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-template-compiler/lib/plugins/transform-bind-attr-to-attributes.js | @@ -34,7 +34,7 @@ function TransformBindAttrToAttributes(options) {
/**
@private
@method transform
- @param {AST} The AST to be transformed.
+ @param {AST} ast The AST to be transformed.
*/
TransformBindAttrToAttributes.prototype.transform = function TransformBindAttrToAttributes_transform(ast) {
var plug... | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-template-compiler/lib/plugins/transform-component-attrs-into-mut.js | @@ -6,7 +6,7 @@ function TransformComponentAttrsIntoMut() {
/**
@private
@method transform
- @param {AST} The AST to be transformed.
+ @param {AST} ast The AST to be transformed.
*/
TransformComponentAttrsIntoMut.prototype.transform = function TransformBindAttrToAttributes_transform(ast) {
var b = this.sy... | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-template-compiler/lib/plugins/transform-component-curly-to-readonly.js | @@ -6,7 +6,7 @@ function TransformComponentCurlyToReadonly() {
/**
@private
@method transform
- @param {AST} The AST to be transformed.
+ @param {AST} ast The AST to be transformed.
*/
TransformComponentCurlyToReadonly.prototype.transform = function TransformComponetnCurlyToReadonly_transform(ast) {
var b... | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-template-compiler/lib/plugins/transform-each-in-to-block-params.js | @@ -33,7 +33,7 @@ function TransformEachInToBlockParams(options) {
/**
@private
@method transform
- @param {AST} The AST to be transformed.
+ @param {AST} ast The AST to be transformed.
*/
TransformEachInToBlockParams.prototype.transform = function TransformEachInToBlockParams_transform(ast) {
var b = thi... | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-template-compiler/lib/plugins/transform-each-in-to-hash.js | @@ -31,7 +31,7 @@ function TransformEachInToHash(options) {
/**
@private
@method transform
- @param {AST} The AST to be transformed.
+ @param {AST} ast The AST to be transformed.
*/
TransformEachInToHash.prototype.transform = function TransformEachInToHash_transform(ast) {
var pluginContext = this; | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-template-compiler/lib/plugins/transform-input-on-to-onEvent.js | @@ -33,7 +33,7 @@ function TransformInputOnToOnEvent(options) {
/**
@private
@method transform
- @param {AST} The AST to be transformed.
+ @param {AST} ast The AST to be transformed.
*/
TransformInputOnToOnEvent.prototype.transform = function TransformInputOnToOnEvent_transform(ast) {
const pluginContext ... | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-template-compiler/lib/plugins/transform-with-as-to-hash.js | @@ -32,7 +32,7 @@ function TransformWithAsToHash(options) {
/**
@private
@method transform
- @param {AST} The AST to be transformed.
+ @param {AST} ast The AST to be transformed.
*/
TransformWithAsToHash.prototype.transform = function TransformWithAsToHash_transform(ast) {
var pluginContext = this; | true |
Other | emberjs | ember.js | 6f769aab58d9cad6195859d8ec1b6f66ab134fb3.json | Fix broken JSDoc references | packages/ember-views/lib/compat/render_buffer.js | @@ -127,7 +127,6 @@ export function renderComponentWithBuffer(component, contextualElement, dom) {
@method renderBuffer
@namespace Ember
- @param {String} tagName tag name (such as 'div' or 'p') used for the buffer
*/
var RenderBuffer = function(domHelper) { | true |
Other | emberjs | ember.js | 9b70eed5f9a97cb3ba80b9343b263955b6641703.json | Add .watchmanconfig to ignore `tmp`. | .watchmanconfig | @@ -0,0 +1,3 @@
+{
+ "ignore_dirs": ["tmp"]
+} | false |
Other | emberjs | ember.js | b9020834ad51cd414678c8b3101c92907b539f2e.json | Fix a case where AttrMorph was being extended | packages/ember-htmlbars/lib/morphs/attr-morph.js | @@ -12,6 +12,8 @@ export var styleWarning = '' +
function EmberAttrMorph(element, attrName, domHelper, namespace) {
HTMLBarsAttrMorph.call(this, element, attrName, domHelper, namespace);
+
+ this.streamUnsubscribers = null;
}
var proto = EmberAttrMorph.prototype = o_create(HTMLBarsAttrMorph.prototype); | false |
Other | emberjs | ember.js | 25507d3b223e19b6ff0163c8d8ba4ea12465499f.json | Fix bug where parent/ownerView was incorrect
Previously, `parentView` and `ownerView` were set based on `scope`,
which is the “owner tree”. However, it should be based on the
component tree instead.
This commit properly wires up `parentView` and `ownerView`, while
maintaining the correct semantics for the `{{view.foo... | packages/ember-htmlbars/lib/hooks/component.js | @@ -17,8 +17,7 @@ export default function componentHook(renderNode, env, scope, _tagName, params,
isAngleBracket = true;
}
- var read = env.hooks.getValue;
- var parentView = read(scope.view);
+ var parentView = env.view;
var manager = ComponentNodeManager.create(renderNode, env, {
tagName, | true |
Other | emberjs | ember.js | 25507d3b223e19b6ff0163c8d8ba4ea12465499f.json | Fix bug where parent/ownerView was incorrect
Previously, `parentView` and `ownerView` were set based on `scope`,
which is the “owner tree”. However, it should be based on the
component tree instead.
This commit properly wires up `parentView` and `ownerView`, while
maintaining the correct semantics for the `{{view.foo... | packages/ember/tests/component_registration_test.js | @@ -2,6 +2,7 @@ import "ember";
import compile from "ember-template-compiler/system/compile";
import helpers from "ember-htmlbars/helpers";
+import { OutletView } from "ember-routing-views/views/outlet";
var App, registry, container;
var originalHelpers;
@@ -40,7 +41,7 @@ QUnit.module("Application Lifecycle - C... | true |
Other | emberjs | ember.js | 8ba5e69dfd61ecab92cc6868f91f3dc445aa0fd4.json | Fix canary build publishing.
ember-cli-yuidoc was updated, but the docs script was not updated to the
new command name. This caused the publishing of builds to fail. | package.json | @@ -8,7 +8,7 @@
"pretest": "ember build",
"test": "bin/run-tests.js",
"start": "ember serve",
- "docs": "ember yuidoc"
+ "docs": "ember ember-cli-yuidoc"
},
"devDependencies": {
"aws-sdk": "~2.1.5", | false |
Other | emberjs | ember.js | 23c36f5181ed00611692003f1fd57cfc1475f0bc.json | Fix deprecation test messages to {{#each ...}} | packages/ember-template-compiler/tests/plugins/transform-each-in-to-block-params-test.js | @@ -7,21 +7,21 @@ QUnit.test('cannot use block params and keyword syntax together', function() {
throws(function() {
compile('{{#each thing in controller as |other-thing|}}{{thing}}-{{other-thing}}{{/each}}', true);
- }, /You cannot use keyword \(`{{each foo in bar}}`\) and block params \(`{{each bar as \|fo... | false |
Other | emberjs | ember.js | 0738330bc1575b2515bdee1c9721e49b93c57cf5.json | Move query parameter cofiguration into the Route | packages/ember-routing-views/lib/views/link.js | @@ -297,7 +297,13 @@ var LinkComponent = EmberComponent.extend({
return false;
}
- get(this, '_routing').transitionTo(get(this, 'targetRouteName'), get(this, 'models'), get(this, 'queryParams.values'), get(this, 'attrs.replace'));
+ var routing = get(this, '_routing');
+ var targetRouteName = get... | true |
Other | emberjs | ember.js | 0738330bc1575b2515bdee1c9721e49b93c57cf5.json | Move query parameter cofiguration into the Route | packages/ember-routing/lib/ext/controller.js | @@ -1,10 +1,5 @@
import Ember from "ember-metal/core"; // FEATURES, deprecate
import { get } from "ember-metal/property_get";
-import { set } from "ember-metal/property_set";
-import { computed } from "ember-metal/computed";
-import { meta } from "ember-metal/utils";
-import merge from "ember-metal/merge";
-
import ... | true |
Other | emberjs | ember.js | 0738330bc1575b2515bdee1c9721e49b93c57cf5.json | Move query parameter cofiguration into the Route | packages/ember-routing/lib/services/routing.js | @@ -46,7 +46,8 @@ var RoutingService = Service.extend({
},
normalizeQueryParams(routeName, models, queryParams) {
- get(this, 'router')._prepareQueryParams(routeName, models, queryParams);
+ var router = get(this, 'router');
+ router._prepareQueryParams(routeName, models, queryParams);
},
gener... | true |
Other | emberjs | ember.js | 0738330bc1575b2515bdee1c9721e49b93c57cf5.json | Move query parameter cofiguration into the Route | packages/ember-routing/lib/system/generate_controller.js | @@ -65,6 +65,7 @@ export function generateControllerFactory(container, controllerName, context) {
*/
export default function generateController(container, controllerName, context) {
generateControllerFactory(container, controllerName, context);
+
var fullName = `controller:${controllerName}`;
var instance = ... | true |
Other | emberjs | ember.js | 0738330bc1575b2515bdee1c9721e49b93c57cf5.json | Move query parameter cofiguration into the Route | packages/ember-routing/lib/system/route.js | @@ -21,7 +21,14 @@ import EmberObject from "ember-runtime/system/object";
import Evented from "ember-runtime/mixins/evented";
import ActionHandler from "ember-runtime/mixins/action_handler";
import generateController from "ember-routing/system/generate_controller";
-import { stashParamNames } from "ember-routing/uti... | true |
Other | emberjs | ember.js | 0738330bc1575b2515bdee1c9721e49b93c57cf5.json | Move query parameter cofiguration into the Route | packages/ember-routing/lib/system/router.js | @@ -6,7 +6,6 @@ import { defineProperty } from "ember-metal/properties";
import { computed } from "ember-metal/computed";
import merge from "ember-metal/merge";
import run from "ember-metal/run_loop";
-
import { fmt } from "ember-runtime/system/string";
import EmberObject from "ember-runtime/system/object";
impor... | true |
Other | emberjs | ember.js | 0738330bc1575b2515bdee1c9721e49b93c57cf5.json | Move query parameter cofiguration into the Route | packages/ember-routing/lib/utils.js | @@ -1,3 +1,6 @@
+import merge from "ember-metal/merge";
+import { get } from "ember-metal/property_get";
+
export function routeArgs(targetRouteName, models, queryParams) {
var args = [];
if (typeof targetRouteName === 'string') {
@@ -42,3 +45,89 @@ export function stashParamNames(router, handlerInfos) {
ha... | true |
Other | emberjs | ember.js | 0738330bc1575b2515bdee1c9721e49b93c57cf5.json | Move query parameter cofiguration into the Route | packages/ember-routing/tests/utils_test.js | @@ -0,0 +1,45 @@
+import {
+ normalizeControllerQueryParams
+} from "ember-routing/utils";
+
+
+QUnit.module("Routing query parameter utils - normalizeControllerQueryParams");
+
+QUnit.test("returns the cached value if that has been previously set", function(assert) {
+ var cached = {};
+ var params = ['foo'];
+ pa... | true |
Other | emberjs | ember.js | 0738330bc1575b2515bdee1c9721e49b93c57cf5.json | Move query parameter cofiguration into the Route | packages/ember/tests/helpers/link_to_test.js | @@ -1404,11 +1404,364 @@ QUnit.test("supplied QP properties can be bound (booleans)", function() {
});
QUnit.test("href updates when unsupplied controller QP props change", function() {
+ Ember.TEMPLATES.index = compile("{{#link-to (query-params foo='lol') id='the-link'}}Index{{/link-to}}");
+
+ bootApplication()... | true |
Other | emberjs | ember.js | 0738330bc1575b2515bdee1c9721e49b93c57cf5.json | Move query parameter cofiguration into the Route | packages/ember/tests/routing/query_params_test.js | @@ -120,6 +120,29 @@ QUnit.module("Routing w/ Query Params", {
}
});
+QUnit.test("a query param can have define a `type` for type casting", function() {
+ Router.map(function() {
+ this.route("home", { path: '/' });
+ });
+
+ App.HomeRoute = Ember.Route.extend({
+ queryParams: {
+ page: {
+ d... | true |
Other | emberjs | ember.js | 28504216e0cd9b8de8ee4bbb67da6f749addec44.json | Change assertion to deprecation | packages/ember-application/lib/utils/validate-type.js | @@ -17,6 +17,18 @@ export default function validateType(resolvedType, parsedName) {
return;
}
+ // 2.0TODO: Remove this deprecation warning
+ if (parsedName.type === 'service') {
+ Ember.deprecate(
+ "In Ember 2.0 service factories must have an `isServiceFactory` " +
+ `property set to true. Yo... | true |
Other | emberjs | ember.js | 28504216e0cd9b8de8ee4bbb67da6f749addec44.json | Change assertion to deprecation | packages/ember-application/tests/system/dependency_injection/default_resolver_test.js | @@ -178,7 +178,8 @@ QUnit.test("lookup description", function() {
});
QUnit.test("validating resolved objects", function() {
- let types = ['route', 'component', 'view', 'service'];
+ // 2.0TODO: Add service to this list
+ let types = ['route', 'component', 'view'];
// Valid setup
application.FooRoute = ... | true |
Other | emberjs | ember.js | aa4e4d20a4ce1cd0f58560acffcb2f9f40e6ed47.json | Consolidate duplicated method | packages/ember-metal/lib/chains.js | @@ -288,35 +288,17 @@ ChainNode.prototype = {
}
if (this._parent) {
- this._parent.chainWillChange(this, this._key, 1, events);
+ this._parent.notifyChainChange(this, this._key, 1, events);
}
},
- chainWillChange(chain, path, depth, events) {
+ notifyChainChange(chain, path, depth, eve... | false |
Other | emberjs | ember.js | 2a726161dd80b3cfd5172922106037bbcc3e4d68.json | Fix basic Fastboot usage. | package.json | @@ -28,7 +28,7 @@
"qunitjs": "^1.16.0",
"route-recognizer": "0.1.5",
"rsvp": "~3.0.6",
- "simple-dom": "^0.1.1",
+ "simple-dom": "^0.2.3",
"testem": "^0.8.0-0"
}
} | true |
Other | emberjs | ember.js | 2a726161dd80b3cfd5172922106037bbcc3e4d68.json | Fix basic Fastboot usage. | packages/ember-htmlbars/lib/node-managers/component-node-manager.js | @@ -252,6 +252,7 @@ export function createComponent(_component, isAngleBracket, _props, renderNode,
props._isAngleBracket = true;
}
+ props.renderer = props.parentView ? props.parentView.renderer : env.container.lookup('renderer:-dom');
let component = _component.create(props);
// for the fallback ca... | true |
Other | emberjs | ember.js | 2a726161dd80b3cfd5172922106037bbcc3e4d68.json | Fix basic Fastboot usage. | packages/ember-htmlbars/lib/node-managers/view-node-manager.js | @@ -171,6 +171,7 @@ export function createOrUpdateComponent(component, options, createOptions, rende
mergeBindings(props, shadowedAttrs(proto, snapshot));
props.container = options.parentView ? options.parentView.container : env.container;
+ props.renderer = options.parentView ? options.parentView.render... | true |
Other | emberjs | ember.js | 2a726161dd80b3cfd5172922106037bbcc3e4d68.json | Fix basic Fastboot usage. | packages/ember-htmlbars/lib/system/bootstrap.js | @@ -74,8 +74,8 @@ function _bootstrap() {
bootstrap(jQuery(document));
}
-function registerComponentLookup(registry) {
- registry.register('component-lookup:main', ComponentLookup);
+function registerComponentLookup(app) {
+ app.registry.register('component-lookup:main', ComponentLookup);
}
/*
@@ -95,9 +95,... | true |
Other | emberjs | ember.js | 2a726161dd80b3cfd5172922106037bbcc3e4d68.json | Fix basic Fastboot usage. | tests/node/app-boot-test.js | @@ -167,7 +167,7 @@ if (canUseInstanceInitializers && canUseApplicationVisit) {
assert.ok(serializer.serialize(view.element).match(/<h1>Hello World<\/h1>/));
});
- QUnit.skip("It is possible to render a view with a nested {{view}} helper in Node", function(assert) {
+ QUnit.test("It is possible to render a ... | true |
Other | emberjs | ember.js | 834382ae778be7c1bb24136bc699d2dc90ca2744.json | Add support for inspecting symbols
True Symbols cannot be coerced to a string, and typeof returns
'symbol'. This caused the inspect function treat it as a non-object
(which is technically correct, since it's a new primitive type).
Adds an additional check to ensure the inspected value is not a
Symbol before attemptin... | packages/ember-metal/lib/utils.js | @@ -799,7 +799,8 @@ export function inspect(obj) {
return '[' + obj + ']';
}
// for non objects
- if (typeof obj !== 'object') {
+ var type = typeof obj;
+ if (type !== 'object' && type !== 'symbol') {
return ''+obj;
}
// overridden toString | true |
Other | emberjs | ember.js | 834382ae778be7c1bb24136bc699d2dc90ca2744.json | Add support for inspecting symbols
True Symbols cannot be coerced to a string, and typeof returns
'symbol'. This caused the inspect function treat it as a non-object
(which is technically correct, since it's a new primitive type).
Adds an additional check to ensure the inspected value is not a
Symbol before attemptin... | packages/ember-metal/tests/utils_test.js | @@ -0,0 +1,16 @@
+import { inspect } from 'ember-metal/utils';
+
+QUnit.module("Ember Metal Utils");
+
+QUnit.test("inspect outputs the toString() representation of Symbols", function() {
+ // Symbol is not defined on pre-ES2015 runtimes, so this let's us safely test
+ // for it's existence (where a simple `if (Symbo... | true |
Other | emberjs | ember.js | aa1607b33c5fa56f566f346bb94480437bc0183a.json | Remove unused _yield and _blockArguments | packages/ember-views/lib/views/collection_view.js | @@ -344,32 +344,10 @@ var CollectionView = ContainerView.extend({
view = this.createChildView(itemViewClass, itemViewProps);
- if (Ember.FEATURES.isEnabled('ember-htmlbars-each-with-index')) {
- if (this.blockParams > 1) {
- view._blockArguments = [item, view.getStream('_view.con... | true |
Other | emberjs | ember.js | aa1607b33c5fa56f566f346bb94480437bc0183a.json | Remove unused _yield and _blockArguments | packages/ember-views/lib/views/view.js | @@ -55,8 +55,6 @@ Ember.warn("The VIEW_PRESERVES_CONTEXT flag has been removed and the functionali
*/
Ember.TEMPLATES = {};
-var EMPTY_ARRAY = [];
-
/**
`Ember.View` is the class in Ember responsible for encapsulating templates of
HTML content, combining templates with data to render as sections of a page's
... | true |
Other | emberjs | ember.js | 82843abdb5820378fec5501dee280b4d4d0554ea.json | Fix typo in component lookup assert
“canot” => “cannot” | packages/ember-htmlbars/tests/integration/component_lookup_test.js | @@ -36,5 +36,5 @@ QUnit.test('dashless components should not be found', function() {
expectAssertion(function() {
runAppend(view);
- }, /You canot use 'dashless' as a component name. Component names must contain a hyphen./);
+ }, /You cannot use 'dashless' as a component name. Component names must contain a... | true |
Other | emberjs | ember.js | 82843abdb5820378fec5501dee280b4d4d0554ea.json | Fix typo in component lookup assert
“canot” => “cannot” | packages/ember-views/lib/component_lookup.js | @@ -7,7 +7,7 @@ export default EmberObject.extend({
var invalidName = ISNT_HELPER_CACHE.get(name);
if (invalidName) {
- Ember.assert(`You canot use '${name}' as a component name. Component names must contain a hyphen.`);
+ Ember.assert(`You cannot use '${name}' as a component name. Component names... | true |
Other | emberjs | ember.js | 0a7c0fce26f11f14f66493758d568c00815569f4.json | Update CHANGELOG for 1.12.0. | CHANGELOG.md | @@ -1,8 +1,32 @@
# Ember Changelog
-### Canary
-
+### 1.12.0 (May 13, 2015)
+
+- [#10874](https://github.com/emberjs/ember.js/pull/10874) Include all files in jspm package.
+- [#10876](https://github.com/emberjs/ember.js/pull/10876) [BUGFIX] Make the `{{component}}` helper deal with dynamically set falsey values.
+-... | false |
Other | emberjs | ember.js | bfc5431e664986f8fb2871a066e50d5de4727f74.json | Fix JSHint error. | packages/ember-views/lib/views/component.js | @@ -9,7 +9,6 @@ import { set } from "ember-metal/property_set";
import isNone from 'ember-metal/is_none';
import { computed } from "ember-metal/computed";
-import { bool } from "ember-metal/computed_macros";
/**
@module ember | false |
Other | emberjs | ember.js | 59011e87a9e1d1b54a4255980f95123d9b6183e4.json | Fix failing node test | tests/node/template-compiler-test.js | @@ -53,7 +53,7 @@ test('allows enabling of features', function() {
templateCompiler._Ember.FEATURES['ember-htmlbars-component-generation'] = true;
templateOutput = templateCompiler.precompile('<some-thing></some-thing>');
- ok(templateOutput.indexOf('["component","some-thing",[],0]') > -1, 'component gen... | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.