language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | 1d08c84e5d8cada2a324a595e6159e57ddd0a6f1.json | Add feature flag for visit API | packages/ember-application/lib/system/application.js | @@ -284,7 +284,7 @@ var Application = Namespace.extend(DeferredMixin, {
// decremented by the Application's own `initialize` method.
this._readinessDeferrals = 1;
- if (this.autoboot) {
+ if (!Ember.FEATURES.isEnabled('ember-application-visit') || this.autoboot) {
// Create subclass of Ember.Ro... | true |
Other | emberjs | ember.js | be6a683242662eb9cc2e8af8b8e829465b7c0dd4.json | Use imported `run` | packages/ember-application/lib/system/application.js | @@ -354,7 +354,7 @@ var Application = Namespace.extend(DeferredMixin, {
if (!this.$ || this.$.isReady) {
run.schedule('actions', this, 'domReady', _instance);
} else {
- this.$().ready(Ember.run.bind(this, 'domReady', _instance));
+ this.$().ready(run.bind(this, 'domReady', _instance));
... | false |
Other | emberjs | ember.js | f0aa38781b835e3463fe251f875452ba7a292113.json | Create a registry per ApplicationInstance
The instance's registry sets its fallback to the corresponding
application's registry. | packages/ember-application/lib/system/application-instance.js | @@ -7,6 +7,7 @@
import { set } from "ember-metal/property_set";
import EmberObject from "ember-runtime/system/object";
import run from "ember-metal/run_loop";
+import Registry from 'container/registry';
/**
The `ApplicationInstance` encapsulates all of the stateful aspects of a
@@ -44,6 +45,14 @@ export defaul... | true |
Other | emberjs | ember.js | f0aa38781b835e3463fe251f875452ba7a292113.json | Create a registry per ApplicationInstance
The instance's registry sets its fallback to the corresponding
application's registry. | packages/ember-application/lib/system/application.js | @@ -318,7 +318,7 @@ var Application = Namespace.extend(DeferredMixin, {
return ApplicationInstance.create({
customEvents: get(this, 'customEvents'),
rootElement: get(this, 'rootElement'),
- registry: this.registry
+ applicationRegistry: this.registry
});
},
| true |
Other | emberjs | ember.js | ebfa23d2ab6812e08decada806ce10381aac7a81.json | Introduce fallback registry.
A registry's fallback registry resolves registrations and injections
when no matches can be found. | packages/container/lib/container.js | @@ -270,8 +270,8 @@ function injectionsFor(container, fullName) {
var type = splitName[0];
var injections = buildInjections(container,
- registry.typeInjections[type],
- registry.injections[fullName]);
+ regist... | true |
Other | emberjs | ember.js | ebfa23d2ab6812e08decada806ce10381aac7a81.json | Introduce fallback registry.
A registry's fallback registry resolves registrations and injections
when no matches can be found. | packages/container/lib/registry.js | @@ -18,22 +18,33 @@ var VALID_FULL_NAME_REGEXP = /^[^:]+.+:[^:]+$/;
@class Registry
*/
function Registry(options) {
+ this.fallback = options && options.fallback ? options.fallback : null;
+
this.resolver = options && options.resolver ? options.resolver : function() {};
this.registrations = dictionary(opt... | true |
Other | emberjs | ember.js | ebfa23d2ab6812e08decada806ce10381aac7a81.json | Introduce fallback registry.
A registry's fallback registry resolves registrations and injections
when no matches can be found. | packages/container/tests/registry_test.js | @@ -72,7 +72,7 @@ test("The registry can take a hook to resolve factories lazily", function() {
strictEqual(registry.resolve('controller:post'), PostController, "The correct factory was provided");
});
-test("The registry respect the resolver hook for `has`", function() {
+test("The registry respects the resolver... | true |
Other | emberjs | ember.js | 3bb454762ce7d62f03bb6f778f9a3831829b72fa.json | Allow deps to be empty in loader. | packages/loader/lib/main.js | @@ -12,7 +12,17 @@ var mainContext = this;
var seen = {};
define = function(name, deps, callback) {
- registry[name] = { deps: deps, callback: callback };
+ var value = { };
+
+ if (!callback) {
+ value.deps = [];
+ value.callback = deps;
+ } else {
+ value.deps = de... | false |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-application/lib/system/application.js | @@ -12,7 +12,7 @@ import { runLoadHooks } from "ember-runtime/system/lazy_load";
import Namespace from "ember-runtime/system/namespace";
import DeferredMixin from "ember-runtime/mixins/deferred";
import DefaultResolver from "ember-application/system/resolver";
-import { create } from "ember-metal/platform";
+import ... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-htmlbars/lib/helpers.js | @@ -3,7 +3,7 @@
@submodule ember-htmlbars
*/
-import { create as o_create } from "ember-metal/platform";
+import o_create from "ember-metal/platform/create";
/**
@private | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-htmlbars/tests/integration/escape_integration_test.js | @@ -3,7 +3,7 @@ import EmberView from 'ember-views/views/view';
import compile from 'ember-template-compiler/system/compile';
import { set } from 'ember-metal/property_set';
-import { create as o_create } from 'ember-metal/platform';
+import o_create from 'ember-metal/platform/create';
import { runAppend, runDestr... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal-views/tests/test_helpers.js | @@ -1,4 +1,4 @@
-import { create } from "ember-metal/platform";
+import create from 'ember-metal/platform/create';
import { Renderer } from "ember-metal-views";
var renderer; | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/lib/alias.js | @@ -7,7 +7,7 @@ import {
defineProperty
} from "ember-metal/properties";
import { ComputedProperty } from "ember-metal/computed";
-import { create } from "ember-metal/platform";
+import create from "ember-metal/platform/create";
import {
meta,
inspect | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/lib/dependent_keys.js | @@ -3,9 +3,7 @@
//
// REMOVE_USE_STRICT: true
-import {
- create as o_create
-} from "ember-metal/platform";
+import o_create from "ember-metal/platform/create";
import {
watch,
unwatch | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/lib/deprecate_property.js | @@ -3,7 +3,7 @@
*/
import Ember from "ember-metal/core";
-import { hasPropertyAccessors } from "ember-metal/platform";
+import { hasPropertyAccessors } from "ember-metal/platform/define_property";
import { defineProperty } from "ember-metal/properties";
import { get } from "ember-metal/property_get";
import { se... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/lib/dictionary.js | @@ -1,4 +1,4 @@
-import { create } from "ember-metal/platform";
+import create from "ember-metal/platform/create";
// the delete is meant to hint at runtimes that this object should remain in
// dictionary mode. This is clearly a runtime specific hack, but currently it | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/lib/error.js | @@ -1,4 +1,4 @@
-import { create } from "ember-metal/platform";
+import create from "ember-metal/platform/create";
var errorProps = [
'description', | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/lib/events.js | @@ -13,7 +13,7 @@ import {
apply,
applyStr
} from "ember-metal/utils";
-import { create } from "ember-metal/platform";
+import create from "ember-metal/platform/create";
var a_slice = [].slice;
| true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/lib/injected_property.js | @@ -2,7 +2,7 @@ import Ember from "ember-metal/core"; // Ember.assert
import { ComputedProperty } from "ember-metal/computed";
import { AliasedProperty } from "ember-metal/alias";
import { Descriptor } from "ember-metal/properties";
-import { create } from "ember-metal/platform";
+import create from "ember-metal/pla... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/lib/keys.js | @@ -1,4 +1,4 @@
-import { canDefineNonEnumerableProperties } from 'ember-metal/platform';
+import { canDefineNonEnumerableProperties } from 'ember-metal/platform/define_property';
/**
Returns all of the keys defined on an object or hash. This is useful | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/lib/main.js | @@ -41,9 +41,9 @@ import EmberError from "ember-metal/error";
import EnumerableUtils from "ember-metal/enumerable_utils";
import Cache from "ember-metal/cache";
import {
- create,
hasPropertyAccessors
-} from "ember-metal/platform";
+} from 'ember-metal/platform/define_property';
+import create from 'ember-metal... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/lib/map.js | @@ -22,7 +22,7 @@
import { guidFor } from "ember-metal/utils";
import { indexOf } from "ember-metal/array";
-import { create } from "ember-metal/platform";
+import create from "ember-metal/platform/create";
import { deprecateProperty } from "ember-metal/deprecate_property";
function missingFunction(fn) { | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/lib/mixin.js | @@ -14,9 +14,7 @@ import {
indexOf as a_indexOf,
forEach as a_forEach
} from "ember-metal/array";
-import {
- create as o_create
-} from "ember-metal/platform";
+import o_create from "ember-metal/platform/create";
import { get } from "ember-metal/property_get";
import { set, trySet } from "ember-metal/propert... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/lib/platform.js | @@ -1,30 +0,0 @@
-import {
- hasES5CompliantDefineProperty,
- defineProperty
-} from 'ember-metal/platform/define_property';
-import defineProperties from 'ember-metal/platform/define_properties';
-import create from 'ember-metal/platform/create';
-
-/**
-@module ember-metal
-*/
-
-var hasPropertyAccessors = hasES5Co... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/lib/platform/define_property.js | @@ -121,12 +121,17 @@ if (hasES5CompliantDefineProperty && typeof document !== 'undefined') {
}
if (!hasES5CompliantDefineProperty) {
- defineProperty = function defineProperty(obj, keyName, desc) {
+ defineProperty = function definePropertyPolyfill(obj, keyName, desc) {
if (!desc.get) { obj[keyName] = desc.... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/lib/properties.js | @@ -7,7 +7,7 @@ import { meta as metaFor } from "ember-metal/utils";
import {
defineProperty as objectDefineProperty,
hasPropertyAccessors
-} from "ember-metal/platform";
+} from 'ember-metal/platform/define_property';
import { overrideChains } from "ember-metal/property_events";
// .............................. | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/lib/property_get.js | @@ -9,7 +9,7 @@ import {
isPath,
hasThis as pathHasThis
} from "ember-metal/path_cache";
-import { hasPropertyAccessors } from "ember-metal/platform";
+import { hasPropertyAccessors } from "ember-metal/platform/define_property";
var FIRST_KEY = /^([^\.]+)/;
| true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/lib/property_set.js | @@ -9,7 +9,7 @@ import EmberError from "ember-metal/error";
import {
isPath
} from "ember-metal/path_cache";
-import { hasPropertyAccessors } from "ember-metal/platform";
+import { hasPropertyAccessors } from "ember-metal/platform/define_property";
var IS_GLOBAL = /^([A-Z$]|([0-9][A-Z$]))/;
| true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/lib/streams/conditional.js | @@ -5,7 +5,7 @@ import {
unsubscribe,
isStream
} from "ember-metal/streams/utils";
-import { create } from "ember-metal/platform";
+import create from "ember-metal/platform/create";
export default function conditional(test, consequent, alternate) {
if (isStream(test)) { | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/lib/streams/simple.js | @@ -1,6 +1,6 @@
import merge from "ember-metal/merge";
import Stream from "ember-metal/streams/stream";
-import { create } from "ember-metal/platform";
+import create from "ember-metal/platform/create";
import { read, isStream } from "ember-metal/streams/utils";
function SimpleStream(source) { | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/lib/streams/stream.js | @@ -1,4 +1,4 @@
-import { create } from "ember-metal/platform";
+import create from "ember-metal/platform/create";
import {
getFirstKey,
getTailPath | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/lib/streams/stream_binding.js | @@ -1,4 +1,4 @@
-import { create } from "ember-metal/platform";
+import create from "ember-metal/platform/create";
import merge from "ember-metal/merge";
import run from "ember-metal/run_loop";
import Stream from "ember-metal/streams/stream"; | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/lib/utils.js | @@ -4,12 +4,12 @@
// REMOVE_USE_STRICT: true
import Ember from "ember-metal/core";
+import o_create from 'ember-metal/platform/create';
import {
- defineProperty as o_defineProperty,
- canDefineNonEnumerableProperties,
hasPropertyAccessors,
- create as o_create
-} from "ember-metal/platform";
+ defineProper... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/lib/watch_key.js | @@ -6,7 +6,7 @@ import {
import {
defineProperty as o_defineProperty,
hasPropertyAccessors
-} from "ember-metal/platform";
+} from "ember-metal/platform/define_property";
import {
MANDATORY_SETTER_FUNCTION,
DEFAULT_GETTER_FUNCTION | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/tests/accessors/get_path_test.js | @@ -3,9 +3,10 @@
import { get } from 'ember-metal/property_get';
function expectGlobalContextDeprecation(assertion) {
- expectDeprecation(function() {
- assertion();
- }, "Ember.get fetched 'localPathGlobal' from the global context. This behavior will change in the future (issue #3852)");
+ expectDeprecation(... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/tests/accessors/get_test.js | @@ -8,7 +8,7 @@ import {
observer
} from 'ember-metal/mixin';
import { addObserver } from "ember-metal/observer";
-import { create } from 'ember-metal/platform';
+import create from 'ember-metal/platform/create';
QUnit.module('Ember.get');
| true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/tests/accessors/mandatory_setters_test.js | @@ -3,9 +3,9 @@ import { set } from "ember-metal/property_set";
import { watch } from "ember-metal/watching";
import {
hasPropertyAccessors,
- defineProperty,
- create
-} from "ember-metal/platform";
+ defineProperty
+} from "ember-metal/platform/define_property";
+import create from 'ember-metal/platform/creat... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/tests/chains_test.js | @@ -1,6 +1,6 @@
import { addObserver } from "ember-metal/observer";
import { finishChains } from "ember-metal/chains";
-import { create } from 'ember-metal/platform';
+import create from 'ember-metal/platform/create';
QUnit.module("Chains");
| true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/tests/computed_test.js | @@ -1,6 +1,6 @@
import Ember from 'ember-metal/core';
import { testBoth } from 'ember-metal/tests/props_helper';
-import { create } from 'ember-metal/platform';
+import create from 'ember-metal/platform/create';
import {
ComputedProperty,
computed, | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/tests/core/inspect_test.js | @@ -1,5 +1,5 @@
import { inspect } from "ember-metal/utils";
-import { create } from "ember-metal/platform";
+import create from 'ember-metal/platform/create';
QUnit.module("Ember.inspect");
| true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/tests/events_test.js | @@ -1,5 +1,5 @@
import { Mixin } from 'ember-metal/mixin';
-import { create } from 'ember-metal/platform';
+import create from 'ember-metal/platform/create';
import { meta } from 'ember-metal/utils';
import { | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/tests/map_test.js | @@ -6,7 +6,7 @@ import {
import {
hasPropertyAccessors
-} from "ember-metal/platform";
+} from "ember-metal/platform/define_property";
var object, number, string, map, variety;
var varieties = [['Map', Map], ['MapWithDefault', MapWithDefault]]; | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/tests/mixin/method_test.js | @@ -1,4 +1,4 @@
-import { create } from 'ember-metal/platform';
+import create from 'ember-metal/platform/create';
import {
mixin,
Mixin | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/tests/observer_test.js | @@ -12,7 +12,7 @@ import {
propertyWillChange,
propertyDidChange
} from 'ember-metal/property_events';
-import { create } from 'ember-metal/platform';
+import create from 'ember-metal/platform/create';
import { defineProperty } from 'ember-metal/properties';
import {
computed, | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/tests/platform/create_test.js | @@ -1,4 +1,4 @@
-import { create } from "ember-metal/platform";
+import create from 'ember-metal/platform/create';
QUnit.module("Ember.create()");
| true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/tests/platform/define_property_test.js | @@ -1,4 +1,8 @@
-import { defineProperty, hasPropertyAccessors, canDefineNonEnumerableProperties } from 'ember-metal/platform';
+import {
+ defineProperty,
+ hasPropertyAccessors,
+ canDefineNonEnumerableProperties
+} from 'ember-metal/platform/define_property';
import EnumerableUtils from 'ember-metal/enumerable_u... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/tests/properties_test.js | @@ -1,4 +1,4 @@
-import { hasPropertyAccessors } from "ember-metal/platform";
+import { hasPropertyAccessors } from "ember-metal/platform/define_property";
import { computed } from 'ember-metal/computed';
import { defineProperty } from "ember-metal/properties";
import { deprecateProperty } from "ember-metal/deprecat... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-metal/tests/utils/meta_test.js | @@ -1,9 +1,9 @@
/*global jQuery*/
import Ember from 'ember-metal/core';
import {
- create,
canDefineNonEnumerableProperties
-} from 'ember-metal/platform';
+} from 'ember-metal/platform/define_property';
+import create from 'ember-metal/platform/create';
import {
getMeta,
setMeta, | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-routing-htmlbars/tests/helpers/render_test.js | @@ -1,7 +1,7 @@
import Ember from 'ember-metal/core'; // TEMPLATES
import { set } from "ember-metal/property_set";
import run from "ember-metal/run_loop";
-import { canDefineNonEnumerableProperties } from 'ember-metal/platform';
+import { canDefineNonEnumerableProperties } from 'ember-metal/platform/define_property'... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-routing/lib/system/router.js | @@ -19,7 +19,7 @@ import {
getActiveTargetName,
stashParamNames
} from "ember-routing/utils";
-import { create } from "ember-metal/platform";
+import create from 'ember-metal/platform/create';
import RouterState from "./router_state";
| true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-runtime/lib/computed/array_computed.js | @@ -3,7 +3,7 @@ import {
ReduceComputedProperty
} from 'ember-runtime/computed/reduce_computed';
import { forEach } from 'ember-metal/enumerable_utils';
-import { create as o_create } from 'ember-metal/platform';
+import o_create from 'ember-metal/platform/create';
import { addObserver } from 'ember-metal/observe... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-runtime/lib/computed/reduce_computed.js | @@ -21,7 +21,7 @@ import {
ComputedProperty,
cacheFor
} from 'ember-metal/computed';
-import { create as o_create } from 'ember-metal/platform';
+import o_create from 'ember-metal/platform/create';
import { forEach } from 'ember-metal/enumerable_utils';
import TrackedArray from 'ember-runtime/system/tracked_ar... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-runtime/lib/system/core_object.js | @@ -21,7 +21,7 @@ import {
guidFor,
apply
} from "ember-metal/utils";
-import { create as o_create } from "ember-metal/platform";
+import o_create from 'ember-metal/platform/create';
import {
generateGuid,
GUID_KEY_PROPERTY,
@@ -38,7 +38,7 @@ import {
} from "ember-metal/mixin";
import { indexOf } from ... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-runtime/tests/core/copy_test.js | @@ -1,4 +1,4 @@
-import { create } from "ember-metal/platform";
+import create from 'ember-metal/platform/create';
import copy from "ember-runtime/copy";
QUnit.module("Ember Copy Method"); | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-runtime/tests/ext/mixin_test.js | @@ -1,7 +1,7 @@
import {set} from "ember-metal/property_set";
import {get} from "ember-metal/property_get";
import {Mixin} from "ember-metal/mixin";
-import { create } from "ember-metal/platform";
+import create from 'ember-metal/platform/create';
import { Binding } from "ember-metal/binding";
import run from "emb... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-runtime/tests/mixins/promise_proxy_test.js | @@ -1,4 +1,4 @@
-import {create} from "ember-metal/platform";
+import create from 'ember-metal/platform/create';
import {get} from "ember-metal/property_get";
import run from "ember-metal/run_loop";
import ObjectProxy from "ember-runtime/system/object_proxy"; | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-runtime/tests/system/object/destroy_test.js | @@ -1,5 +1,5 @@
import run from "ember-metal/run_loop";
-import { hasPropertyAccessors } from "ember-metal/platform";
+import { hasPropertyAccessors } from "ember-metal/platform/define_property";
import { observer } from "ember-metal/mixin";
import { set } from "ember-metal/property_set";
import { bind } from "embe... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-testing/lib/test.js | @@ -1,6 +1,6 @@
import Ember from "ember-metal/core";
import emberRun from "ember-metal/run_loop";
-import { create } from "ember-metal/platform";
+import create from 'ember-metal/platform/create';
import RSVP from "ember-runtime/ext/rsvp";
import setupForTesting from "ember-testing/setup_for_testing";
import Embe... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-views/lib/streams/context_stream.js | @@ -1,7 +1,7 @@
import Ember from 'ember-metal/core';
import merge from "ember-metal/merge";
-import { create } from "ember-metal/platform";
+import create from 'ember-metal/platform/create';
import { isGlobal } from "ember-metal/path_cache";
import Stream from "ember-metal/streams/stream";
import SimpleStream f... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-views/lib/streams/key_stream.js | @@ -1,7 +1,7 @@
import Ember from 'ember-metal/core';
import merge from "ember-metal/merge";
-import { create } from "ember-metal/platform";
+import create from 'ember-metal/platform/create';
import { get } from "ember-metal/property_get";
import { set } from "ember-metal/property_set";
import { | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-views/lib/streams/should_display.js | @@ -5,7 +5,7 @@ import {
unsubscribe,
isStream
} from "ember-metal/streams/utils";
-import { create } from "ember-metal/platform";
+import create from 'ember-metal/platform/create';
import { get } from "ember-metal/property_get";
import { isArray } from "ember-metal/utils";
| true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-views/lib/system/render_buffer.js | @@ -5,7 +5,7 @@
import jQuery from "ember-views/system/jquery";
import Ember from "ember-metal/core";
-import { create } from "ember-metal/platform";
+import create from 'ember-metal/platform/create';
import environment from "ember-metal/environment";
import { normalizeProperty } from "morph/dom-helper/prop";
| true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-views/lib/system/renderer.js | @@ -1,6 +1,6 @@
import Ember from "ember-metal/core";
import Renderer from 'ember-metal-views/renderer';
-import { create } from 'ember-metal/platform';
+import create from 'ember-metal/platform/create';
import RenderBuffer from "ember-views/system/render_buffer";
import run from "ember-metal/run_loop";
import { s... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-views/lib/views/states.js | @@ -1,4 +1,4 @@
-import { create } from "ember-metal/platform";
+import create from 'ember-metal/platform/create';
import merge from "ember-metal/merge";
import _default from "ember-views/views/states/default";
import preRender from "ember-views/views/states/pre_render"; | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-views/lib/views/states/destroying.js | @@ -1,5 +1,5 @@
import merge from "ember-metal/merge";
-import {create} from "ember-metal/platform";
+import create from 'ember-metal/platform/create';
import {fmt} from "ember-runtime/system/string";
import _default from "ember-views/views/states/default";
import EmberError from "ember-metal/error"; | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-views/lib/views/states/has_element.js | @@ -1,7 +1,7 @@
import _default from "ember-views/views/states/default";
import run from "ember-metal/run_loop";
import merge from "ember-metal/merge";
-import { create } from "ember-metal/platform";
+import create from 'ember-metal/platform/create';
import jQuery from "ember-views/system/jquery";
import EmberErro... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-views/lib/views/states/in_buffer.js | @@ -2,7 +2,7 @@ import _default from "ember-views/views/states/default";
import EmberError from "ember-metal/error";
import jQuery from "ember-views/system/jquery";
-import { create } from "ember-metal/platform";
+import create from 'ember-metal/platform/create';
import merge from "ember-metal/merge";
/** | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-views/lib/views/states/in_dom.js | @@ -1,5 +1,5 @@
import Ember from "ember-metal/core"; // Ember.assert
-import { create } from "ember-metal/platform";
+import create from 'ember-metal/platform/create';
import merge from "ember-metal/merge";
import EmberError from "ember-metal/error";
import { addBeforeObserver } from 'ember-metal/observer'; | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-views/lib/views/states/pre_render.js | @@ -1,5 +1,5 @@
import _default from "ember-views/views/states/default";
-import { create } from "ember-metal/platform";
+import create from 'ember-metal/platform/create';
/**
@module ember | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-views/lib/views/view.js | @@ -3,7 +3,7 @@
// Ember.ContainerView circular dependency
// Ember.ENV
import Ember from 'ember-metal/core';
-import { create } from 'ember-metal/platform';
+import create from 'ember-metal/platform/create';
import Evented from "ember-runtime/mixins/evented";
import EmberObject from "ember-runtime/system/object... | true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember-views/tests/views/view/state_deprecation_test.js | @@ -1,4 +1,4 @@
-import { hasPropertyAccessors } from "ember-metal/platform";
+import { hasPropertyAccessors } from "ember-metal/platform/define_property";
import run from "ember-metal/run_loop";
import EmberView from "ember-views/views/view";
| true |
Other | emberjs | ember.js | a5d91490cd1ef0e99da06ee61fbb7e1c423b14b8.json | Avoid re-exports from ember-metal/platform. | packages/ember/tests/routing/query_params_test.js | @@ -1,6 +1,6 @@
import "ember";
import { computed } from "ember-metal/computed";
-import { canDefineNonEnumerableProperties } from 'ember-metal/platform';
+import { canDefineNonEnumerableProperties } from 'ember-metal/platform/define_property';
import { capitalize } from "ember-runtime/system/string";
import Embe... | true |
Other | emberjs | ember.js | d422f83bc054cc39b9ceb009a08ac1ff2aecbe4a.json | Use imports instead of globals. | packages/ember-metal/lib/expand_properties.js | @@ -1,6 +1,6 @@
-import Ember from "ember-metal/core";
import EmberError from 'ember-metal/error';
import { forEach } from 'ember-metal/enumerable_utils';
+import { typeOf } from 'ember-metal/utils';
/**
@module ember-metal
@@ -40,7 +40,7 @@ export default function expandProperties(pattern, callback) {
'... | true |
Other | emberjs | ember.js | d422f83bc054cc39b9ceb009a08ac1ff2aecbe4a.json | Use imports instead of globals. | packages/ember-runtime/lib/mixins/controller.js | @@ -1,5 +1,5 @@
import { Mixin } from "ember-metal/mixin";
-import { computed } from "ember-metal/computed";
+import alias from 'ember-metal/alias';
import ActionHandler from "ember-runtime/mixins/action_handler";
import ControllerContentModelAliasDeprecation from "ember-runtime/mixins/controller_content_model_alias... | true |
Other | emberjs | ember.js | d422f83bc054cc39b9ceb009a08ac1ff2aecbe4a.json | Use imports instead of globals. | packages/ember-runtime/lib/system/core_object.js | @@ -8,7 +8,9 @@
@submodule ember-runtime
*/
-import Ember from "ember-metal/core";
+// using ember-metal/lib/main here to ensure that ember-debug is setup
+// if present
+import Ember from "ember-metal";
import merge from "ember-metal/merge";
// Ember.assert, Ember.config
| true |
Other | emberjs | ember.js | d422f83bc054cc39b9ceb009a08ac1ff2aecbe4a.json | Use imports instead of globals. | packages/ember-views/lib/views/bound_component_view.js | @@ -8,8 +8,9 @@ import { read, chain, subscribe, unsubscribe } from "ember-metal/streams/utils";
import { readComponentFactory } from "ember-views/streams/utils";
import mergeViewBindings from "ember-htmlbars/system/merge-view-bindings";
import EmberError from "ember-metal/error";
+import ContainerView from "ember-v... | true |
Other | emberjs | ember.js | e626f4a7e8d7f662f229c0a42794b3cba4f60d59.json | Remove trailing spaces | packages/ember-runtime/lib/system/core_object.js | @@ -795,7 +795,7 @@ var ClassMixinProps = {
```
This will return the original hash that was passed to `meta()`.
-
+
@static
@method metaForProperty
@param key {String} property name
@@ -831,7 +831,7 @@ var ClassMixinProps = {
/**
Iterate over each computed property for the class, ... | false |
Other | emberjs | ember.js | dd9a0a4e0b68e36b1bac39ca3b98f29f2d6b7c0a.json | Fix accidental overriding of imports. | packages/ember-htmlbars/tests/helpers/log_test.js | @@ -3,7 +3,7 @@ import EmberView from 'ember-views/views/view';
import compile from 'ember-template-compiler/system/compile';
import { runAppend, runDestroy } from "ember-runtime/tests/utils";
-var originalLookup, originalLog, logCalls, lookup, view, compile;
+var originalLookup, originalLog, logCalls, lookup, view... | true |
Other | emberjs | ember.js | dd9a0a4e0b68e36b1bac39ca3b98f29f2d6b7c0a.json | Fix accidental overriding of imports. | packages/ember-htmlbars/tests/integration/binding_integration_test.js | @@ -11,7 +11,7 @@ import { registerHelper } from "ember-htmlbars/helpers";
import { set } from 'ember-metal/property_set';
-var compile, view, MyApp, originalLookup, lookup;
+var view, MyApp, originalLookup, lookup;
var trim = jQuery.trim;
| true |
Other | emberjs | ember.js | dd9a0a4e0b68e36b1bac39ca3b98f29f2d6b7c0a.json | Fix accidental overriding of imports. | packages/ember-htmlbars/tests/integration/escape_integration_test.js | @@ -6,7 +6,7 @@ import { set } from 'ember-metal/property_set';
import { create as o_create } from 'ember-metal/platform';
import { runAppend, runDestroy } from "ember-runtime/tests/utils";
-var compile, view;
+var view;
QUnit.module('ember-htmlbars: Integration with Globals', {
teardown: function() { | true |
Other | emberjs | ember.js | dd9a0a4e0b68e36b1bac39ca3b98f29f2d6b7c0a.json | Fix accidental overriding of imports. | packages/ember-htmlbars/tests/integration/globals_integration_test.js | @@ -3,7 +3,7 @@ import EmberView from 'ember-views/views/view';
import compile from 'ember-template-compiler/system/compile';
import { runAppend, runDestroy } from "ember-runtime/tests/utils";
-var compile, view, originalLookup, lookup;
+var view, originalLookup, lookup;
var originalLookup = Ember.lookup;
| true |
Other | emberjs | ember.js | e929b74d2c0768c8d1842bd0d31cf21ebad604b1.json | Pass arguments to _super | packages/ember-application/lib/system/application-instance.js | @@ -69,7 +69,7 @@ export default EmberObject.extend({
rootElement: null,
init: function() {
- this._super();
+ this._super.apply(this, arguments);
this.container = this.registry.container();
},
| false |
Other | emberjs | ember.js | a16adec23db8fcde1d8240815159f5609594512d.json | Add documentation to ApplicationInstance props
Thanks @stefanpenner! | packages/ember-application/lib/system/application-instance.js | @@ -29,28 +29,72 @@ import run from "ember-metal/run_loop";
*/
export default EmberObject.extend({
+ /**
+ The application instance's container. The container stores all of the
+ instance-specific state for this application run.
+
+ @property {Ember.Container} container
+ */
+ container: null,
+
+ /**
... | false |
Other | emberjs | ember.js | 496dfe7e92d7696d60594b077088232486fe3be8.json | Add tests for arrays of `before` and `after` | packages/ember-application/tests/system/initializers_test.js | @@ -114,6 +114,69 @@ test("initializers can be registered in a specified order", function() {
deepEqual(order, ['first', 'second', 'third', 'fourth', 'fifth', 'sixth']);
});
+test("initializers can be registered in a specified order as an array", function() {
+ var order = [];
+ var MyApplication = Application.... | true |
Other | emberjs | ember.js | 496dfe7e92d7696d60594b077088232486fe3be8.json | Add tests for arrays of `before` and `after` | packages/ember-application/tests/system/instance_initializers_test.js | @@ -114,6 +114,69 @@ if (Ember.FEATURES.isEnabled('ember-application-instance-initializers')) {
deepEqual(order, ['first', 'second', 'third', 'fourth', 'fifth', 'sixth']);
});
+ test("initializers can be registered in a specified order as an array", function() {
+ var order = [];
+ var MyApplication = ... | true |
Other | emberjs | ember.js | cf55da239ada16d04dd9d6e3e4a6391b6ff1f365.json | Introduce instance initializers
This commit introduces a new (feature flagged) API for adding
instance initializers.
Instance initializers differ from normal initializers in that they are
passed the app instance rather than a registry, and therefore can access
instances from the container in a safe way.
This design ... | FEATURES.md | @@ -5,6 +5,27 @@ for a detailed explanation.
## Feature Flags
+* `ember-application-instance-initializers`
+
+ Splits apart initializers into two phases:
+
+ * Boot-time Initializers that receive a registry, and use it to set up
+ code structures
+ * Instance Initializers that receive an application instance... | true |
Other | emberjs | ember.js | cf55da239ada16d04dd9d6e3e4a6391b6ff1f365.json | Introduce instance initializers
This commit introduces a new (feature flagged) API for adding
instance initializers.
Instance initializers differ from normal initializers in that they are
passed the app instance rather than a registry, and therefore can access
instances from the container in a safe way.
This design ... | features.json | @@ -15,6 +15,7 @@
"ember-testing-checkbox-helpers": null,
"ember-metal-stream": null,
"ember-htmlbars-each-with-index": true,
+ "ember-application-instance-initializers": null,
"ember-application-initializer-context": null
},
"debugStatements": [ | true |
Other | emberjs | ember.js | cf55da239ada16d04dd9d6e3e4a6391b6ff1f365.json | Introduce instance initializers
This commit introduces a new (feature flagged) API for adding
instance initializers.
Instance initializers differ from normal initializers in that they are
passed the app instance rather than a registry, and therefore can access
instances from the container in a safe way.
This design ... | packages/container/lib/registry.js | @@ -136,13 +136,21 @@ Registry.prototype = {
lookup: function(fullName, options) {
Ember.assert('Create a container on the registry (with `registry.container()`) before calling `lookup`.', this._defaultContainer);
- Ember.deprecate('`lookup` should not be called on a Registry. Call `lookup` directly on an ... | true |
Other | emberjs | ember.js | cf55da239ada16d04dd9d6e3e4a6391b6ff1f365.json | Introduce instance initializers
This commit introduces a new (feature flagged) API for adding
instance initializers.
Instance initializers differ from normal initializers in that they are
passed the app instance rather than a registry, and therefore can access
instances from the container in a safe way.
This design ... | packages/ember-application/lib/system/application.js | @@ -528,7 +528,9 @@ var Application = Namespace.extend(DeferredMixin, {
_initialize: function() {
if (this.isDestroyed) { return; }
- this.runInitializers();
+ this.runInitializers(this.__registry__);
+ this.runInstanceInitializers(this.__instance__);
+
runLoadHooks('application', this);
... | true |
Other | emberjs | ember.js | cf55da239ada16d04dd9d6e3e4a6391b6ff1f365.json | Introduce instance initializers
This commit introduces a new (feature flagged) API for adding
instance initializers.
Instance initializers differ from normal initializers in that they are
passed the app instance rather than a registry, and therefore can access
instances from the container in a safe way.
This design ... | packages/ember-application/tests/system/initializers_test.js | @@ -2,6 +2,7 @@ import run from "ember-metal/run_loop";
import Application from "ember-application/system/application";
import { indexOf } from "ember-metal/array";
import jQuery from "ember-views/system/jquery";
+import Registry from "container/registry";
var app;
@@ -33,6 +34,25 @@ test("initializers require ... | true |
Other | emberjs | ember.js | cf55da239ada16d04dd9d6e3e4a6391b6ff1f365.json | Introduce instance initializers
This commit introduces a new (feature flagged) API for adding
instance initializers.
Instance initializers differ from normal initializers in that they are
passed the app instance rather than a registry, and therefore can access
instances from the container in a safe way.
This design ... | packages/ember-application/tests/system/instance_initializers_test.js | @@ -0,0 +1,284 @@
+import run from "ember-metal/run_loop";
+import Application from "ember-application/system/application";
+import ApplicationInstance from "ember-application/system/application-instance";
+import { indexOf } from "ember-metal/array";
+import jQuery from "ember-views/system/jquery";
+
+var app;
+
+if (... | true |
Other | emberjs | ember.js | 9c2b8d4166d67774d5565834cd2622dd6d2b0b95.json | Extract ApplicationInstance to separate file | packages/ember-application/lib/system/application-instance.js | @@ -0,0 +1,38 @@
+/**
+@module ember
+@submodule ember-application
+*/
+
+import EmberObject from "ember-runtime/system/object";
+import run from "ember-metal/run_loop";
+
+export default EmberObject.extend({
+ container: null,
+ customEvents: null,
+ rootElement: null,
+
+ startRouting: function(isModuleBasedResol... | true |
Other | emberjs | ember.js | 9c2b8d4166d67774d5565834cd2622dd6d2b0b95.json | Extract ApplicationInstance to separate file | packages/ember-application/lib/system/application.js | @@ -31,6 +31,7 @@ import HistoryLocation from "ember-routing/location/history_location";
import AutoLocation from "ember-routing/location/auto_location";
import NoneLocation from "ember-routing/location/none_location";
import BucketCache from "ember-routing/system/cache";
+import ApplicationInstance from "ember-appl... | true |
Other | emberjs | ember.js | 0941344b7cdc87046551b48be758d4aa1a6f7239.json | Store an ApplicationInstance on the Application
Instead of storing a `__container__` on the Application, this commit
stores an ApplicationInstance, which manages the per-instance lifecycle.
The next step will be allowing multiple `ApplicationInstance`s to exist
at once, enabling a single app to serve multiple FastBoo... | packages/ember-application/lib/system/application.js | @@ -270,7 +270,7 @@ var Application = Namespace.extend(DeferredMixin, {
this.buildRegistry();
// TODO:(tomdale+wycats) Move to session creation phase
- this.buildContainer();
+ this.buildInstance();
registerLibraries();
logLibraryVersions();
@@ -295,13 +295,19 @@ var Application = Namespac... | true |
Other | emberjs | ember.js | 0941344b7cdc87046551b48be758d4aa1a6f7239.json | Store an ApplicationInstance on the Application
Instead of storing a `__container__` on the Application, this commit
stores an ApplicationInstance, which manages the per-instance lifecycle.
The next step will be allowing multiple `ApplicationInstance`s to exist
at once, enabling a single app to serve multiple FastBoo... | packages/ember-routing/lib/system/router.js | @@ -297,6 +297,10 @@ var EmberRouter = EmberObject.extend(Evented, {
}
},
+ willDestroy: function() {
+ this.reset();
+ },
+
_lookupActiveView: function(templateName) {
var active = this._activeViews[templateName];
return active && active[0]; | true |
Other | emberjs | ember.js | e4392eb84f87504bf5748277dcc13c925ccd8ba1.json | Deprecate computed.any in favor of computed.or | packages/ember-metal/lib/computed_macros.js | @@ -478,6 +478,7 @@ registerComputedWithProperties('or', function(properties) {
@param {String} dependentKey*
@return {Ember.ComputedProperty} computed property which returns
the first truthy value of given list of properties.
+ @deprecated Use `Ember.computed.or` instead.
*/
registerComputedWithProperties(... | false |
Other | emberjs | ember.js | 9d4e51af4e13325eea9ba15c2b173bf0ac7f4b47.json | Add example of new CP syntax in features.md
I've just wanted to enable the new CP syntax and when I looked the exact
FF name, I realized that a small code example would make the feature
much easier to understand. | FEATURES.md | @@ -142,6 +142,20 @@ for a detailed explanation.
Enables the new computed property syntax. In this new syntax, instead of passing
a function that acts both as getter and setter for the property, `Ember.computed`
receives an object with `get` and `set` keys, each one containing a function.
+
+ For example,
+
+... | false |
Other | emberjs | ember.js | b556fd7fbe2a6839cd3b7798654713b4036c48a1.json | Remove duplicate imports. | packages/ember-application/lib/ext/controller.js | @@ -6,10 +6,9 @@
import Ember from "ember-metal/core"; // Ember.assert
import { get } from "ember-metal/property_get";
import EmberError from "ember-metal/error";
-import { inspect } from "ember-metal/utils";
+import { inspect, meta } from "ember-metal/utils";
import { computed } from "ember-metal/computed";
impor... | true |
Other | emberjs | ember.js | b556fd7fbe2a6839cd3b7798654713b4036c48a1.json | Remove duplicate imports. | packages/ember-metal/lib/environment.js | @@ -1,3 +1,4 @@
+import Ember from 'ember-metal/core';
/*
Ember can run in many different environments, including environments like | true |
Other | emberjs | ember.js | b556fd7fbe2a6839cd3b7798654713b4036c48a1.json | Remove duplicate imports. | packages/ember-routing/lib/ext/controller.js | @@ -2,8 +2,7 @@ import Ember from "ember-metal/core"; // FEATURES, deprecate
import { get } from "ember-metal/property_get";
import { set } from "ember-metal/property_set";
import { computed } from "ember-metal/computed";
-import { typeOf } from "ember-metal/utils";
-import { meta } from "ember-metal/utils";
+import... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.