language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | b556fd7fbe2a6839cd3b7798654713b4036c48a1.json | Remove duplicate imports. | packages/ember-runtime/lib/computed/reduce_computed.js | @@ -2,7 +2,8 @@ import Ember from 'ember-metal/core'; // Ember.assert
import { get as e_get } from 'ember-metal/property_get';
import {
guidFor,
- meta as metaFor
+ meta as metaFor,
+ isArray
} from 'ember-metal/utils';
import EmberError from 'ember-metal/error';
import {
@@ -25,7 +26,6 @@ import { forEach }... | true |
Other | emberjs | ember.js | b556fd7fbe2a6839cd3b7798654713b4036c48a1.json | Remove duplicate imports. | packages/ember-runtime/lib/mixins/copyable.js | @@ -5,9 +5,8 @@
import { get } from "ember-metal/property_get";
-import { required } from "ember-metal/mixin";
+import { required, Mixin } from "ember-metal/mixin";
import { Freezable } from "ember-runtime/mixins/freezable";
-import { Mixin } from 'ember-metal/mixin';
import { fmt } from "ember-runtime/system/st... | true |
Other | emberjs | ember.js | b556fd7fbe2a6839cd3b7798654713b4036c48a1.json | Remove duplicate imports. | packages/ember-runtime/lib/mixins/sortable.js | @@ -7,7 +7,6 @@ import Ember from "ember-metal/core"; // Ember.assert, Ember.A
import { get } from "ember-metal/property_get";
import { forEach } from "ember-metal/enumerable_utils";
-import { Mixin } from "ember-metal/mixin";
import MutableEnumerable from "ember-runtime/mixins/mutable_enumerable";
import compare... | true |
Other | emberjs | ember.js | b556fd7fbe2a6839cd3b7798654713b4036c48a1.json | Remove duplicate imports. | packages/ember-runtime/lib/system/each_proxy.js | @@ -6,7 +6,10 @@
import Ember from "ember-metal/core"; // Ember.assert
import { get } from "ember-metal/property_get";
-import { guidFor } from "ember-metal/utils";
+import {
+ guidFor,
+ typeOf
+} from "ember-metal/utils";
import { forEach } from "ember-metal/enumerable_utils";
import { indexOf } from "ember-m... | true |
Other | emberjs | ember.js | b556fd7fbe2a6839cd3b7798654713b4036c48a1.json | Remove duplicate imports. | packages/ember-views/lib/main.js | @@ -39,8 +39,10 @@ import TextField from "ember-views/views/text_field";
import TextArea from "ember-views/views/text_area";
import SimpleBoundView from "ember-views/views/simple_bound_view";
-import _MetamorphView from "ember-views/views/metamorph_view";
-import { _Metamorph } from "ember-views/views/metamorph_vie... | true |
Other | emberjs | ember.js | b556fd7fbe2a6839cd3b7798654713b4036c48a1.json | Remove duplicate imports. | packages/ember-views/lib/views/bound_partial_view.js | @@ -3,7 +3,6 @@
@submodule ember-views
*/
-import run from 'ember-metal/run_loop';
import _MetamorphView from "ember-views/views/metamorph_view";
import NormalizedRerenderIfNeededSupport from "ember-views/mixins/normalized_rerender_if_needed";
import lookupPartial from "ember-views/system/lookup_partial"; | true |
Other | emberjs | ember.js | b556fd7fbe2a6839cd3b7798654713b4036c48a1.json | Remove duplicate imports. | packages/ember-views/lib/views/each.js | @@ -15,8 +15,10 @@ import {
removeBeforeObserver
} from "ember-metal/observer";
-import _MetamorphView from "ember-views/views/metamorph_view";
-import { _Metamorph } from "ember-views/views/metamorph_view";
+import {
+ default as _MetamorphView,
+ _Metamorph
+} from "ember-views/views/metamorph_view";
expor... | true |
Other | emberjs | ember.js | b556fd7fbe2a6839cd3b7798654713b4036c48a1.json | Remove duplicate imports. | packages/ember-views/lib/views/select.js | @@ -7,7 +7,8 @@ import {
forEach,
indexOf,
indexesOf,
- replace
+ replace,
+ map
} from "ember-metal/enumerable_utils";
import { get } from "ember-metal/property_get";
@@ -21,7 +22,6 @@ import { A as emberA } from "ember-runtime/system/native_array";
import { observer } from "ember-metal/mixin";
impor... | true |
Other | emberjs | ember.js | b556fd7fbe2a6839cd3b7798654713b4036c48a1.json | Remove duplicate imports. | packages/ember-views/lib/views/view.js | @@ -14,17 +14,22 @@ import setProperties from "ember-metal/set_properties";
import run from "ember-metal/run_loop";
import { addObserver, removeObserver } from "ember-metal/observer";
import { defineProperty } from "ember-metal/properties";
-import { guidFor } from "ember-metal/utils";
+import {
+ guidFor,
+ typeO... | true |
Other | emberjs | ember.js | b556fd7fbe2a6839cd3b7798654713b4036c48a1.json | Remove duplicate imports. | packages/ember-views/lib/views/with_view.js | @@ -4,7 +4,6 @@
*/
import { set } from "ember-metal/property_set";
-import run from 'ember-metal/run_loop';
import _MetamorphView from "ember-views/views/metamorph_view";
import NormalizedRerenderIfNeededSupport from "ember-views/mixins/normalized_rerender_if_needed";
import run from 'ember-metal/run_loop'; | true |
Other | emberjs | ember.js | 80fcde8763928b73a4d7bea8c5f56889a6efec10.json | Support basic Node.js rendering
This commit makes some small cleanup changes across the framework that
ensure that views’ renderers are consistently inherited from their
parents (so that, e.g., if you render a view using a Node renderer, all
subviews will use that same renderer).
It also changes one instance where DO... | package.json | @@ -23,6 +23,7 @@
"htmlbars": "0.8.1",
"qunit-extras": "^1.3.0",
"qunitjs": "^1.16.0",
- "rsvp": "~3.0.6"
+ "rsvp": "~3.0.6",
+ "simple-dom": "^0.1.1"
}
} | true |
Other | emberjs | ember.js | 80fcde8763928b73a4d7bea8c5f56889a6efec10.json | Support basic Node.js rendering
This commit makes some small cleanup changes across the framework that
ensure that views’ renderers are consistently inherited from their
parents (so that, e.g., if you render a view using a Node renderer, all
subviews will use that same renderer).
It also changes one instance where DO... | packages/ember-views/lib/main.js | @@ -16,6 +16,8 @@ import {
getViewBoundingClientRect
} from "ember-views/system/utils";
import RenderBuffer from "ember-views/system/render_buffer";
+import Renderer from "ember-views/system/renderer";
+import { DOMHelper } from "morph";
import "ember-views/system/ext"; // for the side effect of extending Ember.... | true |
Other | emberjs | ember.js | 80fcde8763928b73a4d7bea8c5f56889a6efec10.json | Support basic Node.js rendering
This commit makes some small cleanup changes across the framework that
ensure that views’ renderers are consistently inherited from their
parents (so that, e.g., if you render a view using a Node renderer, all
subviews will use that same renderer).
It also changes one instance where DO... | packages/ember-views/lib/system/render_buffer.js | @@ -520,7 +520,7 @@ RenderBuffer.prototype = {
this.dom.detectNamespace(contextualElement);
if (!this._element) {
- this._element = document.createDocumentFragment();
+ this._element = this.dom.createDocumentFragment();
}
if (content.nodeType) { | true |
Other | emberjs | ember.js | 80fcde8763928b73a4d7bea8c5f56889a6efec10.json | Support basic Node.js rendering
This commit makes some small cleanup changes across the framework that
ensure that views’ renderers are consistently inherited from their
parents (so that, e.g., if you render a view using a Node renderer, all
subviews will use that same renderer).
It also changes one instance where DO... | packages/ember-views/lib/views/view.js | @@ -1878,9 +1878,11 @@ var View = CoreView.extend({
var attrs = _attrs || {};
var view;
attrs._parentView = this;
+ attrs.renderer = this.renderer;
if (CoreView.detect(maybeViewClass)) {
attrs.container = this.container;
+
view = maybeViewClass.create(attrs);
// don't set... | true |
Other | emberjs | ember.js | 80fcde8763928b73a4d7bea8c5f56889a6efec10.json | Support basic Node.js rendering
This commit makes some small cleanup changes across the framework that
ensure that views’ renderers are consistently inherited from their
parents (so that, e.g., if you render a view using a Node renderer, all
subviews will use that same renderer).
It also changes one instance where DO... | tests/node/app-boot-test.js | @@ -3,19 +3,116 @@
var path = require('path');
var distPath = path.join(__dirname, '../../dist');
+/*jshint -W079 */
+var Ember = require(path.join(distPath, 'ember.debug.cjs'));
+Ember.testing = true;
+var DOMHelper = Ember.View.DOMHelper;
+var SimpleDOM = require('simple-dom');
+
QUnit.module("App boot");
QUn... | true |
Other | emberjs | ember.js | db3d53eb3aa694fabcc3875d5ba53e226ab5a6cb.json | Update CHANGELOG.md insert comma
My file change inserts a missing comma into the change log. | CHANGELOG.md | @@ -28,8 +28,7 @@
{{some-other-component action="saveMe"}}
```
-Clearly, `component-a` has subscribed to `some-other-component`'s `action`. Previously, if `component-a` did not handle the action
-it would silently continue. Now, an assertion would be triggered.
+Clearly, `component-a` has subscribed to `some-other... | false |
Other | emberjs | ember.js | 98b4246aabfd2e2d26b413f02ee61bd9920406ec.json | Fix tiny typo in deprecation notice. | packages/ember-runtime/lib/controllers/object_controller.js | @@ -2,7 +2,7 @@ import Ember from 'ember-metal/core';
import ControllerMixin from 'ember-runtime/mixins/controller';
import ObjectProxy from 'ember-runtime/system/object_proxy';
-export var objectControllerDeprecation = 'Ember.ObjectController is deprected, ' +
+export var objectControllerDeprecation = 'Ember.Objec... | false |
Other | emberjs | ember.js | 0c0df5990bf6939c775cd4e82e1a59fde103b710.json | Unify DOM helper across HTMLbars and Ember views
Previously, both HTMLbars and the Ember view layer had their own
instance of the DOM helper, which was hardcoded to a global singleton.
This made it difficult to swap out for a “virtual DOM” when running in
Node.js.
This change refactors internals so that a single DOM ... | packages/ember-application/lib/system/application.js | @@ -20,6 +20,7 @@ import EnumerableUtils from "ember-metal/enumerable_utils";
import ObjectController from "ember-runtime/controllers/object_controller";
import ArrayController from "ember-runtime/controllers/array_controller";
import Renderer from "ember-views/system/renderer";
+import { DOMHelper } from "morph";
... | true |
Other | emberjs | ember.js | 0c0df5990bf6939c775cd4e82e1a59fde103b710.json | Unify DOM helper across HTMLbars and Ember views
Previously, both HTMLbars and the Ember view layer had their own
instance of the DOM helper, which was hardcoded to a global singleton.
This made it difficult to swap out for a “virtual DOM” when running in
Node.js.
This change refactors internals so that a single DOM ... | packages/ember-htmlbars/lib/env.js | @@ -15,11 +15,7 @@ import set from "ember-htmlbars/hooks/set";
import helpers from "ember-htmlbars/helpers";
-var domHelper = environment.hasDOM ? new DOMHelper() : null;
-
export default {
- dom: domHelper,
-
hooks: {
get: get,
set: set,
@@ -35,3 +31,7 @@ export default {
helpers: helpers
};
... | true |
Other | emberjs | ember.js | 0c0df5990bf6939c775cd4e82e1a59fde103b710.json | Unify DOM helper across HTMLbars and Ember views
Previously, both HTMLbars and the Ember view layer had their own
instance of the DOM helper, which was hardcoded to a global singleton.
This made it difficult to swap out for a “virtual DOM” when running in
Node.js.
This change refactors internals so that a single DOM ... | packages/ember-htmlbars/lib/system/render-view.js | @@ -27,7 +27,7 @@ function renderHTMLBarsTemplate(view, buffer, template) {
var args = view._blockArguments;
var env = {
view: this,
- dom: defaultEnv.dom,
+ dom: view.renderer._dom,
hooks: defaultEnv.hooks,
helpers: defaultEnv.helpers,
data: { | true |
Other | emberjs | ember.js | 0c0df5990bf6939c775cd4e82e1a59fde103b710.json | Unify DOM helper across HTMLbars and Ember views
Previously, both HTMLbars and the Ember view layer had their own
instance of the DOM helper, which was hardcoded to a global singleton.
This made it difficult to swap out for a “virtual DOM” when running in
Node.js.
This change refactors internals so that a single DOM ... | packages/ember-htmlbars/tests/attr_nodes/data_test.js | @@ -2,12 +2,12 @@ import EmberView from "ember-views/views/view";
import run from "ember-metal/run_loop";
import EmberObject from "ember-runtime/system/object";
import compile from "ember-template-compiler/system/compile";
+import Renderer from "ember-views/system/renderer";
import { equalInnerHTML } from "htmlbars... | true |
Other | emberjs | ember.js | 0c0df5990bf6939c775cd4e82e1a59fde103b710.json | Unify DOM helper across HTMLbars and Ember views
Previously, both HTMLbars and the Ember view layer had their own
instance of the DOM helper, which was hardcoded to a global singleton.
This made it difficult to swap out for a “virtual DOM” when running in
Node.js.
This change refactors internals so that a single DOM ... | packages/ember-htmlbars/tests/htmlbars_test.js | @@ -1,14 +1,19 @@
import compile from "ember-template-compiler/system/compile";
import defaultEnv from "ember-htmlbars/env";
+import { domHelper } from "ember-htmlbars/env";
import { equalHTML } from "htmlbars-test-helpers";
+import merge from "ember-metal/merge";
if (Ember.FEATURES.isEnabled('ember-htmlbars')) {... | true |
Other | emberjs | ember.js | 0c0df5990bf6939c775cd4e82e1a59fde103b710.json | Unify DOM helper across HTMLbars and Ember views
Previously, both HTMLbars and the Ember view layer had their own
instance of the DOM helper, which was hardcoded to a global singleton.
This made it difficult to swap out for a “virtual DOM” when running in
Node.js.
This change refactors internals so that a single DOM ... | packages/ember-metal-views/lib/renderer.js | @@ -3,7 +3,7 @@ import environment from "ember-metal/environment";
var domHelper = environment.hasDOM ? new DOMHelper() : null;
-function Renderer() {
+function Renderer(_helper) {
this._uuid = 0;
// These sizes and values are somewhat arbitrary (but sensible)
@@ -13,7 +13,7 @@ function Renderer() {
thi... | true |
Other | emberjs | ember.js | 0c0df5990bf6939c775cd4e82e1a59fde103b710.json | Unify DOM helper across HTMLbars and Ember views
Previously, both HTMLbars and the Ember view layer had their own
instance of the DOM helper, which was hardcoded to a global singleton.
This made it difficult to swap out for a “virtual DOM” when running in
Node.js.
This change refactors internals so that a single DOM ... | packages/ember-views/lib/system/render_buffer.js | @@ -4,7 +4,6 @@
*/
import jQuery from "ember-views/system/jquery";
-import { DOMHelper } from "morph";
import Ember from "ember-metal/core";
import { create } from "ember-metal/platform";
import environment from "ember-metal/environment";
@@ -39,10 +38,10 @@ import environment from "ember-metal/environment";
va... | true |
Other | emberjs | ember.js | 0c0df5990bf6939c775cd4e82e1a59fde103b710.json | Unify DOM helper across HTMLbars and Ember views
Previously, both HTMLbars and the Ember view layer had their own
instance of the DOM helper, which was hardcoded to a global singleton.
This made it difficult to swap out for a “virtual DOM” when running in
Node.js.
This change refactors internals so that a single DOM ... | packages/ember-views/lib/system/renderer.js | @@ -1,7 +1,7 @@
import Ember from "ember-metal/core";
import Renderer from 'ember-metal-views/renderer';
import { create } from 'ember-metal/platform';
-import renderBuffer from "ember-views/system/render_buffer";
+import RenderBuffer from "ember-views/system/render_buffer";
import run from "ember-metal/run_loop";
... | true |
Other | emberjs | ember.js | 0c0df5990bf6939c775cd4e82e1a59fde103b710.json | Unify DOM helper across HTMLbars and Ember views
Previously, both HTMLbars and the Ember view layer had their own
instance of the DOM helper, which was hardcoded to a global singleton.
This made it difficult to swap out for a “virtual DOM” when running in
Node.js.
This change refactors internals so that a single DOM ... | packages/ember-views/lib/views/core_view.js | @@ -1,4 +1,5 @@
import Renderer from "ember-views/system/renderer";
+import { DOMHelper } from "morph";
import {
cloneStates,
@@ -48,8 +49,10 @@ var CoreView = EmberObject.extend(Evented, ActionHandler, {
this.currentState = this._states.preRender;
this._isVisible = get(this, 'isVisible');
+ // Fa... | true |
Other | emberjs | ember.js | 0c0df5990bf6939c775cd4e82e1a59fde103b710.json | Unify DOM helper across HTMLbars and Ember views
Previously, both HTMLbars and the Ember view layer had their own
instance of the DOM helper, which was hardcoded to a global singleton.
This made it difficult to swap out for a “virtual DOM” when running in
Node.js.
This change refactors internals so that a single DOM ... | packages/ember-views/tests/system/render_buffer_test.js | @@ -1,5 +1,6 @@
import jQuery from "ember-views/system/jquery";
import RenderBuffer from "ember-views/system/render_buffer";
+import { DOMHelper } from "morph";
var svgNamespace = "http://www.w3.org/2000/svg";
var xhtmlNamespace = "http://www.w3.org/1999/xhtml";
@@ -10,8 +11,17 @@ var trim = jQuery.trim;
//
QUn... | true |
Other | emberjs | ember.js | 685d9e36fee7a8d99f3811a9f99758a1231ffaa7.json | Make Ember.Map keys and values private. | packages/ember-metal/lib/map.js | @@ -45,11 +45,11 @@ function copyNull(obj) {
}
function copyMap(original, newObject) {
- var keys = original.keys.copy();
- var values = copyNull(original.values);
+ var keys = original._keys.copy();
+ var values = copyNull(original._values);
- newObject.keys = keys;
- newObject.values = values;
+ newObjec... | false |
Other | emberjs | ember.js | 7cbdc3354c99faf103f8c3f19645c7b795d26131.json | Disallow empty blocks. | .jscsrc | @@ -13,6 +13,7 @@
"beforeAlternate": true
},
"disallowSpacesInCallExpression": true,
+ "disallowEmptyBlocks": true,
"requireCurlyBraces": [
"if",
"else", | true |
Other | emberjs | ember.js | 7cbdc3354c99faf103f8c3f19645c7b795d26131.json | Disallow empty blocks. | packages/ember-metal/lib/core.js | @@ -67,6 +67,7 @@ Ember.VERSION = 'VERSION_STRING_PLACEHOLDER';
if (Ember.ENV) {
// do nothing if Ember.ENV is already setup
+ Ember.assert('Ember.ENV should be an object.', 'object' !== typeof Ember.ENV);
} else if ('undefined' !== typeof EmberENV) {
Ember.ENV = EmberENV;
} else if ('undefined' !== typeof ... | true |
Other | emberjs | ember.js | 7cbdc3354c99faf103f8c3f19645c7b795d26131.json | Disallow empty blocks. | packages/ember-metal/lib/utils.js | @@ -642,11 +642,13 @@ export function tryInvoke(obj, methodName, args) {
var needsFinallyFix = (function() {
var count = 0;
try {
+ // jscs:disable
try {
} finally {
count++;
throw new Error('needsFinallyFixTest');
}
+ // jscs:enable
} catch (e) {}
return count !== 1; | true |
Other | emberjs | ember.js | 7cbdc3354c99faf103f8c3f19645c7b795d26131.json | Disallow empty blocks. | packages/ember-metal/tests/run_loop/later_test.js | @@ -18,6 +18,19 @@ function wait(callback, maxWaitCount) {
}, 10);
}
+// Synchronous "sleep". This simulates work being done
+// after run.later was called but before the run loop
+// has flushed. In previous versions, this would have
+// caused the run.later callback to have run from
+// within the run loop flus... | true |
Other | emberjs | ember.js | 7cbdc3354c99faf103f8c3f19645c7b795d26131.json | Disallow empty blocks. | packages/ember-runtime/lib/mixins/action_handler.js | @@ -209,11 +209,8 @@ var ActionHandler = Mixin.create({
var target;
if (this._actions && this._actions[actionName]) {
- if (this._actions[actionName].apply(this, args) === true) {
- // handler returned true, so this action will bubble
- } else {
- return;
- }
+ var shouldBu... | true |
Other | emberjs | ember.js | 7cbdc3354c99faf103f8c3f19645c7b795d26131.json | Disallow empty blocks. | packages/ember-views/lib/views/component.js | @@ -309,11 +309,8 @@ var Component = View.extend(TargetActionSupport, ComponentTemplateDeprecation, {
var hasAction = this._actions && this._actions[actionName];
if (hasAction) {
- if (this._actions[actionName].apply(this, args) === true) {
- // handler returned true, so this action will bubble
... | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | .jscsrc | @@ -4,6 +4,7 @@
"additionalRules": [ "lib/jscs-rules/*.js" ],
"disallowMultipleVarDeclWithAssignment": true,
"requireSpaceBeforeObjectValues": true,
+ "requireBlocksOnNewline": 1,
"disallowSpacesBeforeSemicolons": true,
"requireSpacesInConditionalExpression": {
"afterTest": true, | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-metal/lib/deprecate_property.js | @@ -30,8 +30,14 @@ export function deprecateProperty(object, deprecatedKey, newKey) {
defineProperty(object, deprecatedKey, {
configurable: true,
enumerable: false,
- set: function(value) { deprecate(); set(this, newKey, value); },
- get: function() { deprecate(); return get(this, n... | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-metal/tests/mixin/method_test.js | @@ -70,7 +70,10 @@ test('overriding inherited objects', function() {
});
var MixinB = Mixin.create({
- foo: function() { this._super(); cnt++; }
+ foo: function() {
+ this._super();
+ cnt++;
+ }
});
var objA = {};
@@ -189,11 +192,17 @@ test('applying several mixins at once with sup al... | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-metal/tests/observer_test.js | @@ -562,7 +562,8 @@ testBoth('addObserver should respect targets with methods', function(get, set) {
});
-testBoth('addObserver should allow multiple objects to observe a property', function(get, set) { var observed = { foo: 'foo' };
+testBoth('addObserver should allow multiple objects to observe a property', func... | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-metal/tests/platform/defineProperty_test.js | @@ -79,8 +79,14 @@ if (hasPropertyAccessors) {
var desc = {
enumerable: true,
- get: function() { getCnt++; return v; },
- set: function(val) { setCnt++; v = val; }
+ get: function() {
+ getCnt++;
+ return v;
+ },
+ set: function(val) {
+ setCnt++;
+ v ... | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-metal/tests/utils/try_catch_finally_test.js | @@ -13,9 +13,18 @@ QUnit.module("Ember.tryFinally", {
catchableResult = 'catchable return value';
finalizerResult = undefined;
- tryable = function() { tryCount++; return tryableResult; };
- catchable = function() { catchCount++; return catchableResult; };
- finalizer = function() { fin... | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-metal/tests/utils/try_finally_test.js | @@ -10,8 +10,14 @@ QUnit.module("Ember.tryFinally", {
tryableResult = 'tryable return value';
finalizerResult = undefined;
- tryable = function() { tryCount++; return tryableResult; };
- finalizer = function() { finalizeCount++; return finalizerResult; };
+ tryable = function() {
+ ... | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-runtime/tests/computed/reduce_computed_test.js | @@ -180,8 +180,14 @@ test("multiple dependent keys can be specified via brace expansion", function()
baz: Ember.A(),
foo: reduceComputed({
initialValue: Ember.A(),
- addedItem: function(array, item) { array.pushObject('a:' + item); return array; },
- removedItem: function(array, item) { array... | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-runtime/tests/suites/enumerable/any.js | @@ -15,7 +15,10 @@ suite.test('any should should invoke callback on each item as long as you return
var found = [];
var result;
- result = obj.any(function(i) { found.push(i); return false; });
+ result = obj.any(function(i) {
+ found.push(i);
+ return false;
+ });
equal(result, false, 'return value... | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-runtime/tests/suites/enumerable/every.js | @@ -15,7 +15,10 @@ suite.test('every should should invoke callback on each item as long as you retu
var found = [];
var result;
- result = obj.every(function(i) { found.push(i); return true; });
+ result = obj.every(function(i) {
+ found.push(i);
+ return true;
+ });
equal(result, true, 'return valu... | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-runtime/tests/suites/enumerable/filter.js | @@ -17,7 +17,10 @@ suite.test('filter should invoke on each item', function() {
var result;
// return true on all but the last two
- result = obj.filter(function(i) { found.push(i); return --cnt>=0; });
+ result = obj.filter(function(i) {
+ found.push(i);
+ return --cnt>=0;
+ });
deepEqual(found, ar... | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-runtime/tests/suites/enumerable/find.js | @@ -14,7 +14,10 @@ suite.test('find should invoke callback on each item as long as you return false
var found = [];
var result;
- result = obj.find(function(i) { found.push(i); return false; });
+ result = obj.find(function(i) {
+ found.push(i);
+ return false;
+ });
equal(result, undefined, 'return... | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-runtime/tests/system/object/create_test.js | @@ -215,11 +215,17 @@ test("Calls init if defined", function() {
test("Calls all mixin inits if defined", function() {
var completed = 0;
var Mixin1 = Mixin.create({
- init: function() { this._super(); completed++; }
+ init: function() {
+ this._super();
+ completed++;
+ }
});
var Mixi... | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-runtime/tests/system/object/extend_test.js | @@ -29,12 +29,18 @@ test('Overriding a method several layers deep', function() {
var AnotherClass = SomeClass.extend({
barCnt: 0,
- bar: function() { this.barCnt++; this._super(); }
+ bar: function() {
+ this.barCnt++;
+ this._super();
+ }
});
var FinalClass = AnotherClass.extend({
... | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-views/lib/views/select.js | @@ -557,7 +557,10 @@ var Select = View.extend({
var prompt = get(this, 'prompt');
if (!content || !get(content, 'length')) { return; }
- if (prompt && selectedIndex === 0) { set(this, 'selection', null); return; }
+ if (prompt && selectedIndex === 0) {
+ set(this, 'selection', null);
+ retur... | true |
Other | emberjs | ember.js | c7f95894c4b74cda41b5971d875dd7c6050ae8e7.json | Require blocks to begin and end with a newline. | packages/ember-views/tests/views/container_view_test.js | @@ -543,7 +543,10 @@ test("should be able to modify childViews then remove the ContainerView in same
var count = 0;
var child = View.create({
- template: function () { count++; return 'child'; }
+ template: function () {
+ count++;
+ return 'child';
+ }
});
run(function() {
@@ -563,7 ... | true |
Other | emberjs | ember.js | 6fb0f61316b70e918fc3fe107a15ea8451fc2bd6.json | Add comment for future intrepid travelers | packages/ember-metal-views/lib/renderer.js | @@ -5,6 +5,9 @@ var domHelper = environment.hasDOM ? new DOMHelper() : null;
function Renderer() {
this._uuid = 0;
+
+ // These sizes and values are somewhat arbitrary (but sensible)
+ // pre-allocation defaults.
this._views = new Array(2000);
this._queue = [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0];
this._pa... | false |
Other | emberjs | ember.js | de62f49683c2c9d683ee69e9f0bf2b78e150c798.json | Require space after object keys. | .jscsrc | @@ -3,6 +3,7 @@
"excludeFiles": ["ember-runtime/ext/rsvp.js"],
"additionalRules": [ "lib/jscs-rules/*.js" ],
"disallowMultipleVarDeclWithAssignment": true,
+ "requireSpaceBeforeObjectValues": true,
"requireCurlyBraces": [
"if",
"else", | true |
Other | emberjs | ember.js | de62f49683c2c9d683ee69e9f0bf2b78e150c798.json | Require space after object keys. | packages/ember-application/tests/system/initializers_test.js | @@ -21,13 +21,13 @@ test("initializers require proper 'name' and 'initialize' properties", function(
expectAssertion(function() {
run(function() {
- MyApplication.initializer({name:'initializer'});
+ MyApplication.initializer({name: 'initializer'});
});
});
expectAssertion(function() {
... | true |
Other | emberjs | ember.js | de62f49683c2c9d683ee69e9f0bf2b78e150c798.json | Require space after object keys. | packages/ember-extension-support/tests/container_debug_adapter_test.js | @@ -11,7 +11,7 @@ function boot() {
}
QUnit.module("Container Debug Adapter", {
- setup:function() {
+ setup: function() {
run(function() {
App = Application.create(); // ES6TODO: this comes from the ember-application package NOT ember-runtime
App.toString = function() { return 'App'; }; | true |
Other | emberjs | ember.js | de62f49683c2c9d683ee69e9f0bf2b78e150c798.json | Require space after object keys. | packages/ember-extension-support/tests/data_adapter_test.js | @@ -21,7 +21,7 @@ var DataAdapter = EmberDataAdapter.extend({
});
QUnit.module("Data Adapter", {
- setup:function() {
+ setup: function() {
run(function() {
App = EmberApplication.create();
App.toString = function() { return 'App'; }; | true |
Other | emberjs | ember.js | de62f49683c2c9d683ee69e9f0bf2b78e150c798.json | Require space after object keys. | packages/ember-metal/lib/platform/create.js | @@ -22,7 +22,7 @@ if (!(Object.create && !Object.create(null).hasOwnProperty)) {
/* jshint scripturl:true, proto:true */
// Contributed by Brandon Benvie, October, 2012
var createEmpty;
- var supportsProto = !({'__proto__':null} instanceof Object);
+ var supportsProto = !({'__proto__': null} instanceof Objec... | true |
Other | emberjs | ember.js | de62f49683c2c9d683ee69e9f0bf2b78e150c798.json | Require space after object keys. | packages/ember-metal/tests/set_properties_test.js | @@ -14,7 +14,7 @@ test("supports setting multiple attributes at once", function() {
deepEqual(setProperties({}, {foo: 1}), {foo: 1}, 'Set a single property');
- deepEqual(setProperties({}, {foo:1, bar: 1}), {foo: 1, bar: 1}, 'Set multiple properties');
+ deepEqual(setProperties({}, {foo: 1, bar: 1}), {foo: 1,... | true |
Other | emberjs | ember.js | de62f49683c2c9d683ee69e9f0bf2b78e150c798.json | Require space after object keys. | packages/ember-runtime/tests/computed/reduce_computed_macros_test.js | @@ -372,10 +372,10 @@ QUnit.module('computedFilterBy', {
setup: function() {
obj = EmberObject.createWithMixins({
array: Ember.A([
- {name: "one", a:1, b:false},
- {name: "two", a:2, b:false},
- {name: "three", a:1, b:true},
- {name: "four", b:true}
+ {name: "one", a: 1... | true |
Other | emberjs | ember.js | de62f49683c2c9d683ee69e9f0bf2b78e150c798.json | Require space after object keys. | packages/ember-runtime/tests/legacy_1x/mixins/observable/observable_test.js | @@ -669,7 +669,7 @@ QUnit.module("Observable objects & object properties ", {
return ret ;
},
- newObserver:function() {
+ newObserver: function() {
this.abnormal = 'changedValueObserved';
},
@@ -758,8 +758,8 @@ QUnit.module("object.addObserver()", {
ObjectC = Observ... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | .jscsrc | @@ -31,5 +31,6 @@
"while",
"with",
"return"
- ]
+ ],
+ "requireSpaceBetweenArguments": true
} | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-application/tests/system/dependency_injection/custom_resolver_test.js | @@ -5,7 +5,7 @@ import DefaultResolver from "ember-application/system/resolver";
var application;
-QUnit.module("Ember.Application Depedency Injection – customResolver",{
+QUnit.module("Ember.Application Depedency Injection – customResolver", {
setup: function() {
function fallbackTemplate() { return "<h1>... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-application/tests/system/dependency_injection/to_string_test.js | @@ -7,7 +7,7 @@ import { guidFor } from "ember-metal/utils";
var originalLookup, App, originalModelInjections;
-QUnit.module("Ember.Application Dependency Injection – toString",{
+QUnit.module("Ember.Application Dependency Injection – toString", {
setup: function() {
originalModelInjections = Ember.MODEL_F... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-htmlbars/tests/helpers/collection_test.js | @@ -641,14 +641,14 @@ test("should allow view objects to be swapped out without throwing an error (#78
ready: true,
items: A([1,2,3])
});
- TemplateTests.datasetController.set('dataset',dataset);
+ TemplateTests.datasetController.set('dataset', dataset);
});
equal(view.$('ul > li').leng... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-metal/lib/keys.js | @@ -39,7 +39,7 @@ if (!keys || !canDefineNonEnumerableProperties) {
for (prop in obj) {
if (prop !== '_super' &&
- prop.lastIndexOf('__',0) !== 0 &&
+ prop.lastIndexOf('__', 0) !== 0 &&
hasOwnProperty.call(obj, prop)) {
result.push(prop);
} | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-metal/tests/computed_test.js | @@ -623,7 +623,7 @@ testBoth('chained dependent keys should evaluate computed properties lazily', fu
QUnit.module('computed edge cases');
-test('adding a computed property should show up in key iteration',function() {
+test('adding a computed property should show up in key iteration', function() {
var obj = {... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-metal/tests/observer_test.js | @@ -55,7 +55,7 @@ testBoth('observer should fire when property is modified', function(get,set) {
testBoth('observer should fire when dependent property is modified', function(get, set) {
var obj = { bar: 'bar' };
defineProperty(obj, 'foo', computed(function() {
- return get(this,'bar').toUpperCase();
+ ret... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-metal/tests/props_helper.js | @@ -5,8 +5,8 @@ import {set as setFromEmberMetal} from 'ember-metal/property_set';
// used by unit tests to test both accessor mode and non-accessor mode
var testBoth = function(testname, callback) {
- function emberget(x,y) { return getFromEmberMetal(x,y); }
- function emberset(x,y,z) { return setFromEmberMetal(... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-metal/tests/run_loop/add_queue_test.js | @@ -4,7 +4,7 @@ import { indexOf } from "ember-metal/array";
var originalQueues = run.queues;
var queues;
-QUnit.module('system/run_loop/add_queue_test',{
+QUnit.module('system/run_loop/add_queue_test', {
setup: function(){
run.queues = queues = ['blork', 'bleep'];
}, | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-metal/tests/run_loop/debounce_test.js | @@ -2,7 +2,7 @@ import run from 'ember-metal/run_loop';
var originalDebounce = run.backburner.debounce;
var wasCalled = false;
-QUnit.module('Ember.run.debounce',{
+QUnit.module('Ember.run.debounce', {
setup: function() {
run.backburner.debounce = function() { wasCalled = true; };
}, | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-metal/tests/utils/is_array_test.js | @@ -3,7 +3,7 @@ QUnit.module("Ember Type Checking");
var global = this;
-test("Ember.isArray" ,function() {
+test("Ember.isArray", function() {
var numarray = [1,2,3];
var number = 23;
var strarray = ["Hello", "Hi"]; | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/lib/compare.js | @@ -74,7 +74,7 @@ export default function compare(v, w) {
switch (type1) {
case 'boolean':
case 'number':
- return spaceship(v,w);
+ return spaceship(v, w);
case 'string':
return spaceship(v.localeCompare(w), 0); | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/lib/mixins/enumerable.js | @@ -333,7 +333,7 @@ export default Mixin.create({
var ret = Ember.A();
this.forEach(function(x, idx, i) {
- ret[idx] = callback.call(target, x, idx,i);
+ ret[idx] = callback.call(target, x, idx, i);
});
return ret ;
@@ -1066,7 +1066,7 @@ export default Mixin.create({
if ('number' ... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/computed/reduce_computed_macros_test.js | @@ -1036,7 +1036,7 @@ function sortByLnameFname(a, b) {
return lna > lnb ? 1 : -1;
}
- return sortByFnameAsc(a,b);
+ return sortByFnameAsc(a, b);
}
function sortByFnameAsc(a, b) { | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/computed/reduce_computed_test.js | @@ -316,7 +316,7 @@ test("modifying properties on dependent array items triggers observers exactly o
equal(removeCalls, 0, 'precond - removed has not been called');
run(function() {
- numbers.replace(0,2,[7,8,9,10]);
+ numbers.replace(0, 2, [7,8,9,10]);
});
equal(addCalls, 10, 'add is called for e... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/core/isEqual_test.js | @@ -9,22 +9,22 @@ test("undefined and null", function() {
ok( !isEqual(null, undefined), "null is not equal to undefined" );
});
-test("strings should be equal",function() {
+test("strings should be equal", function() {
ok( !isEqual("Hello", "Hi"), "different Strings are unequal" );
ok( isEqual("He... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/core/is_array_test.js | @@ -4,7 +4,7 @@ import ArrayProxy from "ember-runtime/system/array_proxy";
QUnit.module("Ember Type Checking");
-test("Ember.isArray" ,function() {
+test("Ember.isArray", function() {
var arrayProxy = ArrayProxy.create({ content: Ember.A() });
equal(isArray(arrayProxy), true, "[]"); | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/legacy_1x/mixins/observable/observable_test.js | @@ -686,22 +686,22 @@ QUnit.module("Observable objects & object properties ", {
});
-test('incrementProperty and decrementProperty',function() {
+test('incrementProperty and decrementProperty', function() {
var newValue = object.incrementProperty('numberVal');
- equal(25,newValue,'numerical value incremented... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/legacy_1x/mixins/observable/propertyChanges_test.js | @@ -106,17 +106,17 @@ test("should indicate that the property of an object has just changed", function
ObjectA.propertyDidChange('foo', null) ;
// Values of prop has just changed
- equal(ObjectA.prop,'changedPropValue') ;
+ equal(ObjectA.prop, 'changedPropValue') ;
});
test("should notify that the propert... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/legacy_1x/system/binding_test.js | @@ -199,7 +199,7 @@ test("changing first output should propograte to third after flush", function()
equal("change", get(first, "output"), "first.output") ;
equal("change", get(second, "input"), "second.input") ;
equal("change", get(second, "output"), "second.output") ;
- equal("change", get(third,"input"), "t... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/legacy_1x/system/object/base_test.js | @@ -54,7 +54,7 @@ test("Should return its properties when requested using EmberObject#get", functi
});
test("Should allow changing of those properties by calling EmberObject#set", function() {
- equal(get(obj,'foo'), 'bar') ;
+ equal(get(obj, 'foo'), 'bar') ;
equal(get(obj, 'total'), 12345) ;
set(obj, 'f... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/legacy_1x/system/set_test.js | @@ -330,7 +330,7 @@ test("the copy() should return an identical set", function() {
obj = set.copy();
});
- equal(oldLength,obj.length,'length of the clone should be same');
+ equal(oldLength, obj.length, 'length of the clone should be same');
equal(obj.contains(set[0]), true);
equal(obj.contains(set[1... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/mixins/comparable_test.js | @@ -8,7 +8,7 @@ var Rectangle = EmberObject.extend(Comparable, {
width: 0,
area: function() {
- return get(this,'length') * get(this, 'width');
+ return get(this, 'length') * get(this, 'width');
},
compare: function(a, b) { | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/mixins/copyable_test.js | @@ -34,6 +34,6 @@ CopyableTests.extend({
return false;
}
- return get(a, 'id') === get(b,'id');
+ return get(a, 'id') === get(b, 'id');
}
}).run(); | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/mixins/target_action_support_test.js | @@ -76,7 +76,7 @@ test("it should find targets specified using a property path", function() {
test("it should use an actionContext object specified as a property on the object", function() {
expect(2);
- var obj = EmberObject.createWithMixins(TargetActionSupport,{
+ var obj = EmberObject.createWithMixins(Target... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/suites/enumerable/any.js | @@ -31,7 +31,7 @@ suite.test('any should stop invoking when you return true', function() {
result = obj.any(function(i) { found.push(i); return --cnt <= 0; });
equal(result, true, 'return value of obj.any');
equal(found.length, exp, 'should invoke proper number of times');
- deepEqual(found, ary.slice(0,-2), ... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/suites/enumerable/every.js | @@ -31,7 +31,7 @@ suite.test('every should stop invoking when you return false', function() {
result = obj.every(function(i) { found.push(i); return --cnt>0; });
equal(result, false, 'return value of obj.every');
equal(found.length, exp, 'should invoke proper number of times');
- deepEqual(found, ary.slice(0,... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/suites/enumerable/filter.js | @@ -19,7 +19,7 @@ suite.test('filter should invoke on each item', function() {
// return true on all but the last two
result = obj.filter(function(i) { found.push(i); return --cnt>=0; });
deepEqual(found, ary, 'should have invoked on each item');
- deepEqual(result, ary.slice(0,-2), 'filtered array should exc... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/suites/enumerable/find.js | @@ -30,7 +30,7 @@ suite.test('every should stop invoking when you return true', function() {
result = obj.find(function(i) { found.push(i); return --cnt >= 0; });
equal(result, ary[exp-1], 'return value of obj.find');
equal(found.length, exp, 'should invoke proper number of times');
- deepEqual(found, ary.sli... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/suites/mutable_array/removeAt.js | @@ -108,7 +108,7 @@ suite.test("[A,B,C,D].removeAt(1,2) => [A,D] + notify", function() {
observer = this.newObserver(obj, '[]', '@each', 'length', 'firstObject', 'lastObject');
obj.getProperties('firstObject', 'lastObject'); /* Prime the cache */
- equal(obj.removeAt(1,2), obj, 'return self');
+ equal(obj.rem... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/suites/mutable_array/replace.js | @@ -12,7 +12,7 @@ suite.test("[].replace(0,0,'X') => ['X'] + notify", function() {
observer = this.newObserver(obj, '[]', '@each', 'length', 'firstObject', 'lastObject');
obj.getProperties('firstObject', 'lastObject'); /* Prime the cache */
- obj.replace(0,0,exp) ;
+ obj.replace(0, 0, exp) ;
deepEqual(th... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/system/array_proxy/arranged_content_test.js | @@ -54,7 +54,7 @@ test("indexOf - returns index of object in arrangedContent", function() {
test("insertAt - raises, indeterminate behavior", function() {
raises(function() {
- run(function() { array.insertAt(2,3); });
+ run(function() { array.insertAt(2, 3); });
});
});
@@ -98,7 +98,7 @@ test("pushOb... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/system/namespace/base_test.js | @@ -114,7 +114,7 @@ test("A nested namespace can be looked up by its name", function() {
test("Destroying a namespace before caching lookup removes it from the list of namespaces", function(){
var CF = lookup.CF = Namespace.create();
- run(CF,'destroy');
+ run(CF, 'destroy');
equal(Namespace.byName('CF'), un... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-runtime/tests/system/object/create_test.js | @@ -243,7 +243,7 @@ test('creating an object with required properties', function() {
});
var obj = ClassA.createWithMixins({ foo: 'FOO' }); // should not throw
- equal(get(obj,'foo'), 'FOO');
+ equal(get(obj, 'foo'), 'FOO');
});
| true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-views/tests/system/event_dispatcher_test.js | @@ -243,7 +243,7 @@ test("event manager should be able to re-dispatch events to view", function() {
// multiple eventManagers in a single view
// hierarchy would break, but it shows that
// re-dispatching works
- view.$().trigger('mousedown',this);
+ view.$().trigger('mousedown'... | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember-views/tests/views/text_field_test.js | @@ -43,7 +43,7 @@ var setCaretPosition = function(element, pos) {
if (ctrl.setSelectionRange) {
ctrl.focus();
- ctrl.setSelectionRange(pos,pos);
+ ctrl.setSelectionRange(pos, pos);
} else if (ctrl.createTextRange) {
var range = ctrl.createTextRange();
range.collapse(true); | true |
Other | emberjs | ember.js | ac8f4340cfe0051f10ed4e16a5f79ba6050015c2.json | Require space between arguments. | packages/ember/tests/helpers/link_to_test.js | @@ -320,7 +320,7 @@ test("The {{link-to}} helper does not disregard current-when when it is given ex
this.route("about");
});
- this.resource("items",function(){
+ this.resource("items", function(){
this.route('item');
});
}); | true |
Other | emberjs | ember.js | 6218a65476ac4a8fb5906ae9d3a0c2be18a6d0a8.json | Update HTMLBars to 0.7.1. | package.json | @@ -20,7 +20,7 @@
"emberjs-build": "0.0.10",
"express": "^4.5.0",
"glob": "~3.2.8",
- "htmlbars": "0.7.0",
+ "htmlbars": "0.7.1",
"qunit-extras": "^1.3.0",
"qunitjs": "^1.16.0",
"rsvp": "~3.0.6" | false |
Other | emberjs | ember.js | 5849897a343c30169b83004b18a4e1c475a68c1e.json | Disallow trailing commas with JSCS. | .jscsrc | @@ -11,5 +11,6 @@
"do",
"try",
"catch"
- ]
+ ],
+ "disallowTrailingComma": true
} | false |
Other | emberjs | ember.js | 14be80cc6af1ed4cc203cb8b1f6a200f7cf3e400.json | expose Registry as Ember.Registry | packages/ember-runtime/lib/main.js | @@ -17,7 +17,7 @@ import Namespace from 'ember-runtime/system/namespace';
import EmberObject from 'ember-runtime/system/object';
import TrackedArray from 'ember-runtime/system/tracked_array';
import SubArray from 'ember-runtime/system/subarray';
-import { Container } from "ember-runtime/system/container";
+import { ... | false |
Other | emberjs | ember.js | 374ff0a33709fd284c3f988cc4c32b0dcddde6b8.json | Require curly brackets. | .jscsrc | @@ -2,5 +2,14 @@
"esnext": true,
"excludeFiles": ["ember-runtime/ext/rsvp.js"],
"additionalRules": [ "lib/jscs-rules/*.js" ],
- "disallowMultipleVarDeclWithAssignment": true
+ "disallowMultipleVarDeclWithAssignment": true,
+ "requireCurlyBraces": [
+ "if",
+ "else",
+ "for",
+ "while",
+ "do"... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.