language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | c4b3bceaf6d94a73d1c251bbacc5682474ec989c.json | point everything at the new meta module | packages/ember-runtime/lib/system/core_object.js | @@ -26,9 +26,9 @@ import {
generateGuid,
GUID_KEY_PROPERTY,
NEXT_SUPER_PROPERTY,
- meta,
makeArray
} from 'ember-metal/utils';
+import { meta } from 'ember-metal/meta';
import { finishChains } from 'ember-metal/chains';
import { sendEvent } from 'ember-metal/events';
import { | true |
Other | emberjs | ember.js | 93743c1de5324d2dc5c7ad9e82a75c9adc7ef908.json | break the meta prototype chain! | packages/ember-metal/lib/meta.js | @@ -285,17 +285,7 @@ export function meta(obj, writable) {
ret.getOrCreateValues();
}
} else if (ret.source !== obj) {
- // temporary dance until I can eliminate remaining uses of
- // prototype chain
- let newRet = Object.create(ret);
- newRet.parent = ret;
- for (let i = 0; i < memberNam... | false |
Other | emberjs | ember.js | 31c16f0fffdb1caebd8ae86c5dd05db5ef1e58b2.json | generalize upgrade support | packages/ember-metal/lib/meta.js | @@ -160,7 +160,10 @@ export function meta(obj, writable) {
let newRet = Object.create(ret);
newRet.parentMeta = ret;
ret = newRet;
- ret._cache = undefined;
+ for (let i = 0; i < memberNames.length; i++) {
+ let name = memberNames[i];
+ ret['_' + name] = undefined;
+ }
// end temp... | false |
Other | emberjs | ember.js | 149c4f41ee5c0cfc9143b5bfcf966109ddab94f8.json | Make `isEqual` its own module. | packages/ember-runtime/lib/core.js | @@ -2,34 +2,3 @@
@module ember
@submodule ember-runtime
*/
-
-/**
- Compares two objects, returning true if they are logically equal. This is
- a deeper comparison than a simple triple equal. For sets it will compare the
- internal objects. For any other object that implements `isEqual()` it will
- respect that ... | true |
Other | emberjs | ember.js | 149c4f41ee5c0cfc9143b5bfcf966109ddab94f8.json | Make `isEqual` its own module. | packages/ember-runtime/lib/is-equal.js | @@ -0,0 +1,31 @@
+/**
+ Compares two objects, returning true if they are logically equal. This is
+ a deeper comparison than a simple triple equal. For sets it will compare the
+ internal objects. For any other object that implements `isEqual()` it will
+ respect that method.
+
+ ```javascript
+ Ember.isEqual('he... | true |
Other | emberjs | ember.js | 149c4f41ee5c0cfc9143b5bfcf966109ddab94f8.json | Make `isEqual` its own module. | packages/ember-runtime/lib/main.js | @@ -5,7 +5,7 @@
// BEGIN IMPORTS
import Ember from 'ember-metal';
-import { isEqual } from 'ember-runtime/core';
+import isEqual from 'ember-runtime/is-equal';
import compare from 'ember-runtime/compare';
import copy from 'ember-runtime/copy';
import inject from 'ember-runtime/inject'; | true |
Other | emberjs | ember.js | 149c4f41ee5c0cfc9143b5bfcf966109ddab94f8.json | Make `isEqual` its own module. | packages/ember-runtime/tests/core/isEqual_test.js | @@ -1,4 +1,4 @@
-import {isEqual} from 'ember-runtime/core';
+import isEqual from 'ember-runtime/is-equal';
QUnit.module('isEqual');
| true |
Other | emberjs | ember.js | 91804148f5c2653fc75246d1d620993f170e73f4.json | Fix optional feature tests. | package.json | @@ -27,7 +27,7 @@
"ember-cli-sauce": "^1.3.0",
"ember-cli-yuidoc": "0.7.0",
"ember-publisher": "0.0.7",
- "emberjs-build": "0.2.2",
+ "emberjs-build": "0.2.4",
"express": "^4.5.0",
"finalhandler": "^0.4.0",
"github": "^0.2.3", | true |
Other | emberjs | ember.js | 91804148f5c2653fc75246d1d620993f170e73f4.json | Fix optional feature tests. | packages/ember-metal/lib/features.js | @@ -1,4 +1,6 @@
import Ember from 'ember-metal/core';
+import assign from 'ember-metal/assign';
+
/**
The hash of enabled Canary features. Add to this, any canary features
before creating your application.
@@ -12,7 +14,7 @@ import Ember from 'ember-metal/core';
@since 1.1.0
@public
*/
-export var FEATURE... | true |
Other | emberjs | ember.js | 0be28eb608971605ae2f041940ffc2d98a8ffe27.json | Fix typo in query param test description | packages/ember/tests/routing/query_params_test.js | @@ -3080,7 +3080,7 @@ QUnit.test('warn user that routes query params configuration must be an Object,
}, 'You passed in `[{"commitBy":{"replace":true}}]` as the value for `queryParams` but `queryParams` cannot be an Array');
});
-QUnit.test('handle routes names that class with Object.prototype properties', functi... | false |
Other | emberjs | ember.js | 0d7b8f6989a9208c2151edfa8f7352453fd8f90a.json | Remove unnecessary property access with `get`.
Cleans up proxy methods in ContainerProxy and RegistryProxy. | packages/ember-runtime/lib/mixins/container_proxy.js | @@ -1,5 +1,4 @@
import run from 'ember-metal/run_loop';
-import { get } from 'ember-metal/property_get';
import { Mixin } from 'ember-metal/mixin';
export default Mixin.create({
@@ -81,7 +80,6 @@ export default Mixin.create({
function containerAlias(name) {
return function () {
- var container = get(this,... | true |
Other | emberjs | ember.js | 0d7b8f6989a9208c2151edfa8f7352453fd8f90a.json | Remove unnecessary property access with `get`.
Cleans up proxy methods in ContainerProxy and RegistryProxy. | packages/ember-runtime/lib/mixins/registry_proxy.js | @@ -1,4 +1,3 @@
-import { get } from 'ember-metal/property_get';
import { Mixin } from 'ember-metal/mixin';
export default Mixin.create({
@@ -244,7 +243,6 @@ export default Mixin.create({
function registryAlias(name) {
return function () {
- var registry = get(this, '__registry__');
- return registry[na... | true |
Other | emberjs | ember.js | e64c9ba077a13a5e493543a7041a090960528595.json | Replace double quotes with single quotes. | packages/ember-application/lib/system/application.js | @@ -38,7 +38,7 @@ import LinkToComponent from 'ember-routing-views/views/link';
import RoutingService from 'ember-routing/services/routing';
import ContainerDebugAdapter from 'ember-extension-support/container_debug_adapter';
import { _loaded } from 'ember-runtime/system/lazy_load';
-import RegistryProxy from "ember... | true |
Other | emberjs | ember.js | e64c9ba077a13a5e493543a7041a090960528595.json | Replace double quotes with single quotes. | packages/ember-application/tests/system/initializers_test.js | @@ -32,13 +32,13 @@ QUnit.test('initializers require proper \'name\' and \'initialize\' properties',
});
});
-QUnit.test("initializers are passed an App", function() {
+QUnit.test('initializers are passed an App', function() {
var MyApplication = Application.extend();
MyApplication.initializer({
name... | true |
Other | emberjs | ember.js | e64c9ba077a13a5e493543a7041a090960528595.json | Replace double quotes with single quotes. | packages/ember-application/tests/system/reset_test.js | @@ -241,7 +241,7 @@ QUnit.test('With ember-data like initializer and constant', function() {
};
Application.initializer({
- name: "store",
+ name: 'store',
initialize(application) {
application.unregister('store:main');
application.register('store:main', application.Store); | true |
Other | emberjs | ember.js | e64c9ba077a13a5e493543a7041a090960528595.json | Replace double quotes with single quotes. | packages/ember/tests/default_initializers_test.js | @@ -26,8 +26,8 @@ QUnit.test('Default objects are registered', function(assert) {
App.instanceInitializer({
name: 'test',
initialize(instance) {
- assert.strictEqual(instance.resolveRegistration("component:-text-field"), TextField, "TextField was registered");
- assert.strictEqual(instance.resolv... | true |
Other | emberjs | ember.js | 93a95c6bd7533664116e17cc922fda3c2aecd20e.json | Introduce ContainerProxy mixin.
Mix in to `ApplicationInstance` class to provide public access to
a few select methods on the encapsulated container. | packages/ember-application/lib/system/application-instance.js | @@ -10,7 +10,8 @@ import EmberObject from 'ember-runtime/system/object';
import run from 'ember-metal/run_loop';
import { computed } from 'ember-metal/computed';
import Registry from 'container/registry';
-import RegistryProxy from "ember-runtime/mixins/registry_proxy";
+import RegistryProxy from 'ember-runtime/mixi... | true |
Other | emberjs | ember.js | 93a95c6bd7533664116e17cc922fda3c2aecd20e.json | Introduce ContainerProxy mixin.
Mix in to `ApplicationInstance` class to provide public access to
a few select methods on the encapsulated container. | packages/ember-application/lib/system/application.js | @@ -338,13 +338,13 @@ var Application = Namespace.extend(RegistryProxy, {
// For the default instance only, set the view registry to the global
// Ember.View.views hash for backwards-compatibility.
- EmberView.views = instance.container.lookup('-view-registry:main');
+ EmberView.views = instance.looku... | true |
Other | emberjs | ember.js | 93a95c6bd7533664116e17cc922fda3c2aecd20e.json | Introduce ContainerProxy mixin.
Mix in to `ApplicationInstance` class to provide public access to
a few select methods on the encapsulated container. | packages/ember-runtime/lib/mixins/container_proxy.js | @@ -0,0 +1,87 @@
+import run from 'ember-metal/run_loop';
+import { get } from 'ember-metal/property_get';
+import { Mixin } from 'ember-metal/mixin';
+
+export default Mixin.create({
+ /**
+ The container stores state.
+
+ @private
+ @property {Ember.Container} __container__
+ */
+ __container__: null,
+
+ ... | true |
Other | emberjs | ember.js | b06bd88352228cbc826b3a0e033936b50506260e.json | Simplify ApplicationInstance creation.
Pass the related Application, which the instance can inspect to obtain
the initialization data that it needs.
This eliminates the need to set `applicationRegistry` on the instance,
which was always an anti-pattern. | packages/ember-application/lib/system/application-instance.js | @@ -46,13 +46,12 @@ export default EmberObject.extend(RegistryProxy, {
container: null,
/**
- The application's registry. The registry contains the classes, templates,
- and other code that makes up the application.
+ The `Application` for which this is an instance.
- @property {Ember.Registry} re... | true |
Other | emberjs | ember.js | b06bd88352228cbc826b3a0e033936b50506260e.json | Simplify ApplicationInstance creation.
Pass the related Application, which the instance can inspect to obtain
the initialization data that it needs.
This eliminates the need to set `applicationRegistry` on the instance,
which was always an anti-pattern. | packages/ember-application/lib/system/application.js | @@ -329,9 +329,7 @@ var Application = Namespace.extend(RegistryProxy, {
*/
buildInstance() {
return ApplicationInstance.create({
- customEvents: get(this, 'customEvents'),
- rootElement: get(this, 'rootElement'),
- applicationRegistry: this.registry
+ application: this
});
},
| true |
Other | emberjs | ember.js | ca6179249a62943fa84b26e39f1b848e1690dcb8.json | Introduce RegistryProxy mixin.
Mix in to both `Application` and `ApplicationInstance` classes to
provide consistent public access to their internally maintained
registries. | packages/ember-application/lib/system/application-instance.js | @@ -10,6 +10,7 @@ import EmberObject from 'ember-runtime/system/object';
import run from 'ember-metal/run_loop';
import { computed } from 'ember-metal/computed';
import Registry from 'container/registry';
+import RegistryProxy from "ember-runtime/mixins/registry_proxy";
/**
The `ApplicationInstance` encapsulat... | true |
Other | emberjs | ember.js | ca6179249a62943fa84b26e39f1b848e1690dcb8.json | Introduce RegistryProxy mixin.
Mix in to both `Application` and `ApplicationInstance` classes to
provide consistent public access to their internally maintained
registries. | packages/ember-application/lib/system/application.js | @@ -38,6 +38,7 @@ import LinkToComponent from 'ember-routing-views/views/link';
import RoutingService from 'ember-routing/services/routing';
import ContainerDebugAdapter from 'ember-extension-support/container_debug_adapter';
import { _loaded } from 'ember-runtime/system/lazy_load';
+import RegistryProxy from "ember... | true |
Other | emberjs | ember.js | ca6179249a62943fa84b26e39f1b848e1690dcb8.json | Introduce RegistryProxy mixin.
Mix in to both `Application` and `ApplicationInstance` classes to
provide consistent public access to their internally maintained
registries. | packages/ember-runtime/lib/mixins/registry_proxy.js | @@ -0,0 +1,250 @@
+import { get } from 'ember-metal/property_get';
+import { Mixin } from 'ember-metal/mixin';
+
+export default Mixin.create({
+ registry: null,
+
+ /**
+ Given a fullName return the corresponding factory.
+
+ @public
+ @method resolveRegistration
+ @param {String} fullName
+ @return {Funct... | true |
Other | emberjs | ember.js | 12bca9f7fcdc7701e61f1f84af50919c0065e7af.json | Fix JSHint error in ember-debug/main. | packages/ember-debug/lib/main.js | @@ -1,5 +1,3 @@
-/*global __fail__*/
-
import Ember from 'ember-metal/core';
import { registerDebugFunction } from 'ember-metal/assert';
import isEnabled, { FEATURES } from 'ember-metal/features'; | false |
Other | emberjs | ember.js | f137f831e3c5d9ef0faf1f83a3dca7cbc7bfffe1.json | Update deprecations in ember-views package | packages/ember-views/lib/compat/attrs-proxy.js | @@ -94,7 +94,7 @@ let AttrsProxyMixin = {
if (attrs && key in attrs) {
// do not deprecate accessing `this[key]` at this time.
// add this back when we have a proper migration path
- // Ember.deprecate(deprecation(key));
+ // Ember.deprecate(deprecation(key), { id: 'ember-views.', until: '3... | true |
Other | emberjs | ember.js | f137f831e3c5d9ef0faf1f83a3dca7cbc7bfffe1.json | Update deprecations in ember-views package | packages/ember-views/lib/compat/metamorph_view.js | @@ -26,9 +26,12 @@ export var _Metamorph = Mixin.create({
init() {
this._super.apply(this, arguments);
Ember.deprecate('Supplying a tagName to Metamorph views is unreliable and is deprecated.' +
- ' You may be setting the tagName on a Handlebars helper that creates a Metamorph.', !this.t... | true |
Other | emberjs | ember.js | f137f831e3c5d9ef0faf1f83a3dca7cbc7bfffe1.json | Update deprecations in ember-views package | packages/ember-views/lib/compat/render_buffer.js | @@ -131,7 +131,8 @@ export function renderComponentWithBuffer(component, contextualElement, dom) {
*/
export default function RenderBuffer(domHelper) {
- Ember.deprecate('`Ember.RenderBuffer` is deprecated.');
+ Ember.deprecate('`Ember.RenderBuffer` is deprecated.', false,
+ { id: 'ember-views.re... | true |
Other | emberjs | ember.js | f137f831e3c5d9ef0faf1f83a3dca7cbc7bfffe1.json | Update deprecations in ember-views package | packages/ember-views/lib/mixins/component_template_deprecation.js | @@ -51,6 +51,8 @@ export default Mixin.create({
delete props['template'];
}
- Ember.deprecate('Do not specify ' + deprecatedProperty + ' on a Component, use ' + replacementProperty + ' instead.', !deprecatedProperty);
+ Ember.deprecate('Do not specify ' + deprecatedProperty + ' on a Component, use '... | true |
Other | emberjs | ember.js | f137f831e3c5d9ef0faf1f83a3dca7cbc7bfffe1.json | Update deprecations in ember-views package | packages/ember-views/lib/mixins/legacy_view_support.js | @@ -69,7 +69,8 @@ var LegacyViewSupport = Mixin.create({
@private
*/
nearestChildOf(klass) {
- Ember.deprecate('nearestChildOf has been deprecated.');
+ Ember.deprecate('nearestChildOf has been deprecated.', false,
+ { id: 'ember-views.nearest-child-of', until: '3.0.0' });
var ... | true |
Other | emberjs | ember.js | f137f831e3c5d9ef0faf1f83a3dca7cbc7bfffe1.json | Update deprecations in ember-views package | packages/ember-views/lib/mixins/view_state_support.js | @@ -3,7 +3,9 @@ import { Mixin } from 'ember-metal/mixin';
var ViewStateSupport = Mixin.create({
transitionTo(state) {
- Ember.deprecate('Ember.View#transitionTo has been deprecated, it is for internal use only');
+ Ember.deprecate('Ember.View#transitionTo has been deprecated, it is for internal use only',
... | true |
Other | emberjs | ember.js | f137f831e3c5d9ef0faf1f83a3dca7cbc7bfffe1.json | Update deprecations in ember-views package | packages/ember-views/lib/system/build-component-template.js | @@ -120,7 +120,9 @@ function tagNameFor(view) {
if (tagName !== null && typeof tagName === 'object' && tagName.isDescriptor) {
tagName = get(view, 'tagName');
- Ember.deprecate('In the future using a computed property to define tagName will not be permitted. That value will be respected, but changing it wi... | true |
Other | emberjs | ember.js | f137f831e3c5d9ef0faf1f83a3dca7cbc7bfffe1.json | Update deprecations in ember-views package | packages/ember-views/lib/views/component.js | @@ -157,7 +157,9 @@ var Component = View.extend(TargetActionSupport, ComponentTemplateDeprecation, {
*/
template: computed('_template', {
get() {
- Ember.deprecate(`Accessing 'template' in ${this} is deprecated. To determine if a block was specified to ${this} please use '{{#if hasBlock}}' in the compon... | true |
Other | emberjs | ember.js | f137f831e3c5d9ef0faf1f83a3dca7cbc7bfffe1.json | Update deprecations in ember-views package | packages/ember-views/lib/views/container_view.js | @@ -174,15 +174,18 @@ var ContainerView = View.extend(MutableArray, {
willWatchProperty(prop) {
Ember.deprecate(
'ContainerViews should not be observed as arrays. This behavior will change in future implementations of ContainerView.',
- !prop.match(/\[]/) && prop.indexOf('@') !== 0
+ !prop.matc... | true |
Other | emberjs | ember.js | f137f831e3c5d9ef0faf1f83a3dca7cbc7bfffe1.json | Update deprecations in ember-views package | packages/ember-views/lib/views/core_view.js | @@ -135,7 +135,9 @@ CoreView.reopenClass({
export var DeprecatedCoreView = CoreView.extend({
init() {
- Ember.deprecate('Ember.CoreView is deprecated. Please use Ember.View.', false);
+ Ember.deprecate('Ember.CoreView is deprecated. Please use Ember.View.',
+ false,
+ {... | true |
Other | emberjs | ember.js | f137f831e3c5d9ef0faf1f83a3dca7cbc7bfffe1.json | Update deprecations in ember-views package | packages/ember-views/lib/views/select.js | @@ -672,7 +672,13 @@ var Select = View.extend({
var DeprecatedSelect = Select.extend({
init() {
this._super(...arguments);
- Ember.deprecate(`Ember.Select is deprecated. Consult the Deprecations Guide for a migration strategy.`, !!Ember.ENV._ENABLE_LEGACY_VIEW_SUPPORT, { url: 'http://emberjs.com/deprecation... | true |
Other | emberjs | ember.js | f137f831e3c5d9ef0faf1f83a3dca7cbc7bfffe1.json | Update deprecations in ember-views package | packages/ember-views/lib/views/view.js | @@ -40,7 +40,9 @@ function K() { return this; }
@submodule ember-views
*/
-Ember.warn('The VIEW_PRESERVES_CONTEXT flag has been removed and the functionality can no longer be disabled.', Ember.ENV.VIEW_PRESERVES_CONTEXT !== false);
+Ember.warn('The VIEW_PRESERVES_CONTEXT flag has been removed and the functionality ... | true |
Other | emberjs | ember.js | 0425ad642a10545865ed6aa1a70c8cb072b7297f.json | Update Ember.deprecate in ember-template-compiler
In some cases, ids have three level due to them being all in the same
method. Some deprecations are marked `until` 2.0 since they are already listed
in the deprecation page. | packages/ember-template-compiler/lib/plugins/deprecate-view-and-controller-paths.js | @@ -62,7 +62,7 @@ function deprecatePath(moduleName, node, path) {
}
return noDeprecate;
- }, { url: 'http://emberjs.com/deprecations/v1.x#toc_view-and-controller-template-keywords', id: (path.parts && path.parts[0] === 'view' ? 'view.keyword.view' : 'view.keyword.controller') });
+ }, { url: 'http://embe... | true |
Other | emberjs | ember.js | 0425ad642a10545865ed6aa1a70c8cb072b7297f.json | Update Ember.deprecate in ember-template-compiler
In some cases, ids have three level due to them being all in the same
method. Some deprecations are marked `until` 2.0 since they are already listed
in the deprecation page. | packages/ember-template-compiler/lib/plugins/deprecate-view-helper.js | @@ -36,12 +36,16 @@ function deprecateHelper(moduleName, node) {
} else if (paramValue === 'select') {
deprecateSelect(moduleName, node);
} else {
- Ember.deprecate(`Using the \`{{view "string"}}\` helper is deprecated. ${calculateLocationDisplay(moduleName, node.loc)}`, false, { url: 'http://emberjs.com/... | true |
Other | emberjs | ember.js | 0425ad642a10545865ed6aa1a70c8cb072b7297f.json | Update Ember.deprecate in ember-template-compiler
In some cases, ids have three level due to them being all in the same
method. Some deprecations are marked `until` 2.0 since they are already listed
in the deprecation page. | packages/ember-template-compiler/lib/plugins/transform-each-into-collection.js | @@ -18,7 +18,9 @@ TransformEachIntoCollection.prototype.transform = function TransformEachIntoColl
let moduleInfo = calculateLocationDisplay(moduleName, legacyHashKey.loc);
Ember.deprecate(
- `Using '${legacyHashKey.key}' with '{{each}}' ${moduleInfo}is deprecated. Please refactor to a component.`
+ ... | true |
Other | emberjs | ember.js | 0425ad642a10545865ed6aa1a70c8cb072b7297f.json | Update Ember.deprecate in ember-template-compiler
In some cases, ids have three level due to them being all in the same
method. Some deprecations are marked `until` 2.0 since they are already listed
in the deprecation page. | packages/ember-template-compiler/lib/plugins/transform-input-on-to-onEvent.js | @@ -51,7 +51,9 @@ TransformInputOnToOnEvent.prototype.transform = function TransformInputOnToOnEve
if (normalizedOn && normalizedOn.value.type !== 'StringLiteral') {
Ember.deprecate(
- `Using a dynamic value for '#{normalizedOn.key}=' with the '{{input}}' helper ${moduleInfo}is deprecated.`
+... | true |
Other | emberjs | ember.js | 0425ad642a10545865ed6aa1a70c8cb072b7297f.json | Update Ember.deprecate in ember-template-compiler
In some cases, ids have three level due to them being all in the same
method. Some deprecations are marked `until` 2.0 since they are already listed
in the deprecation page. | packages/ember-template-compiler/lib/plugins/transform-old-binding-syntax.js | @@ -26,7 +26,11 @@ TransformOldBindingSyntax.prototype.transform = function TransformOldBindingSynt
if (key.substr(-7) === 'Binding') {
let newKey = key.slice(0, -7);
- Ember.deprecate(`You're using legacy binding syntax: ${key}=${exprToString(value)} ${sourceInformation}. Please replace with $... | true |
Other | emberjs | ember.js | 78b790f08c9c4a7797d595314d4226803f3d1e4b.json | Add Descriptors to eachComputedProperty | packages/ember-runtime/lib/system/core_object.js | @@ -794,7 +794,7 @@ var ClassMixinProps = {
for (var name in proto) {
property = proto[name];
- if (property instanceof ComputedProperty) {
+ if (property && property.isDescriptor) {
properties.push({
name: name,
meta: property._meta | true |
Other | emberjs | ember.js | 78b790f08c9c4a7797d595314d4226803f3d1e4b.json | Add Descriptors to eachComputedProperty | packages/ember-runtime/tests/system/object/computed_test.js | @@ -1,3 +1,4 @@
+import alias from 'ember-metal/alias';
import { computed } from 'ember-metal/computed';
import { get as emberGet } from 'ember-metal/property_get';
import { observer } from 'ember-metal/mixin';
@@ -152,7 +153,9 @@ QUnit.test('can iterate over a list of computed properties for a class', functio
... | true |
Other | emberjs | ember.js | 013f797d22d9ac71bbb01d71bacbcc5ab681ca02.json | Add test for frozenCopy deprecation | packages/ember-runtime/lib/mixins/copyable.js | @@ -57,7 +57,7 @@ export default Mixin.create({
@private
*/
frozenCopy() {
- Ember.deprecate('`frozenCopy` is deprecated, use Object.freeze instead.');
+ Ember.deprecate('`frozenCopy` is deprecated, use `Object.freeze` instead.');
if (Freezable && Freezable.detect(this)) {
return get(this, ... | true |
Other | emberjs | ember.js | 013f797d22d9ac71bbb01d71bacbcc5ab681ca02.json | Add test for frozenCopy deprecation | packages/ember-runtime/tests/mixins/copyable_test.js | @@ -1,10 +1,25 @@
import CopyableTests from 'ember-runtime/tests/suites/copyable';
import Copyable from 'ember-runtime/mixins/copyable';
+import {Freezable} from 'ember-runtime/mixins/freezable';
import EmberObject from 'ember-runtime/system/object';
import {generateGuid} from 'ember-metal/utils';
import {set} fro... | true |
Other | emberjs | ember.js | 35edaf26cbc6edafc7bbef063db01c17cac5a3e2.json | Remove space before parens in anon-func | STYLEGUIDE.md | @@ -127,7 +127,7 @@ if (foo === 'bara') {
}
// parameters
-function (test, foo) {
+function(test, foo) {
}
```
| false |
Other | emberjs | ember.js | f4affcdd959af057b98a1e6e7ee4e326bebc8bc7.json | JSCS: Require spaces around operators
Except for before a `,`. | .jscsrc | @@ -54,6 +54,29 @@
"with",
"return"
],
+ "requireSpaceBeforeBinaryOperators": [
+ "=",
+ "+",
+ "-",
+ "/",
+ "*",
+ "==",
+ "===",
+ "!=",
+ "!=="
+ ],
+ "requireSpaceAfterBinaryOperators": [
+ "=",
+ ",",
+ "+",
+ "-",
+ "/",
+ "*",
+ "==",
+ "===",
+... | false |
Other | emberjs | ember.js | e49113cb2c83880fb3656ebb306a4ec22e0e2d53.json | Update action docs.
Action documentation contains a event camelize instead of dasherize. This causes some problems when people read the guides.
See [guides#83](https://github.com/emberjs/guides/pull/83). | packages/ember-routing-htmlbars/lib/keywords/action.js | @@ -90,7 +90,7 @@ import closureAction from 'ember-routing-htmlbars/keywords/closure-action';
supply an `on` option to the helper to specify a different DOM event name:
```handlebars
- <div {{action "anActionName" on="doubleClick"}}>
+ <div {{action "anActionName" on="double-click"}}>
click me
</div>
... | false |
Other | emberjs | ember.js | a00c953c5518e4b5857f200baae5840eaf761942.json | Add repository to bower.json | bower.json | @@ -1,5 +1,9 @@
{
"name": "ember",
+ "repository": {
+ "type": "git",
+ "url": "https://github.com/emberjs/ember.js.git"
+ },
"dependencies": {
"jquery": "~1.11.1",
"qunit": "~1.17.1", | false |
Other | emberjs | ember.js | b25aa411dfeb3c3e747034b46fe4e0087bc00200.json | Add repository to config bower.json | config/package_manager_files/bower.json | @@ -5,7 +5,11 @@
"./ember.debug.js",
"./ember-template-compiler.js"
],
+ "repository": {
+ "type": "git",
+ "url": "https://github.com/emberjs/ember.js.git"
+ },
"dependencies": {
"jquery": ">= 1.7.0 < 2.2.0"
}
-}
\ No newline at end of file
+} | false |
Other | emberjs | ember.js | ebebab8fbf5740ca25315777a541d79b602bdb46.json | Add repository field to package.json | package.json | @@ -13,6 +13,10 @@
"docs": "ember ember-cli-yuidoc",
"sauce:launch": "ember sauce:launch"
},
+ "repository": {
+ "type": "git",
+ "url": "https://github.com/emberjs/ember.js.git"
+ },
"devDependencies": {
"aws-sdk": "~2.1.5",
"babel-plugin-feature-flags": "~0.2.0", | false |
Other | emberjs | ember.js | 8574876d9ffca952102e4e2a33f31f6aa57dbe1c.json | Eliminate redundant willCleanupNode hook
This commit resolves a memory leak (#11501) in apps running Glimmer. The
root cause of the issue was that a flag governing whether
components/views remove themselves from their parent was being set
incorrectly, so that when the code to cleanup a destroyed view ran, it
was not r... | packages/ember-views/tests/views/view/child_views_test.js | @@ -77,11 +77,11 @@ QUnit.test('should remove childViews on destroy', function() {
container: {
lookup() {
return {
- componentFor(tagName, container) {
+ componentFor() {
return Component.extend();
},
- layoutFor(tagName, container) {
+ ... | false |
Other | emberjs | ember.js | 0d43d24bc27db5b6267753c93868e8565f61f670.json | Eliminate redundant willCleanupNode hook
This commit resolves a memory leak (#11501) in apps running Glimmer. The
root cause of the issue was that a flag governing whether
components/views remove themselves from their parent was being set
incorrectly, so that when the code to cleanup a destroyed view ran, it
was not r... | packages/ember-htmlbars/lib/env.js | @@ -20,7 +20,6 @@ import getCellOrValue from 'ember-htmlbars/hooks/get-cell-or-value';
import cleanupRenderNode from 'ember-htmlbars/hooks/cleanup-render-node';
import destroyRenderNode from 'ember-htmlbars/hooks/destroy-render-node';
import didRenderNode from 'ember-htmlbars/hooks/did-render-node';
-import willClea... | true |
Other | emberjs | ember.js | 0d43d24bc27db5b6267753c93868e8565f61f670.json | Eliminate redundant willCleanupNode hook
This commit resolves a memory leak (#11501) in apps running Glimmer. The
root cause of the issue was that a flag governing whether
components/views remove themselves from their parent was being set
incorrectly, so that when the code to cleanup a destroyed view ran, it
was not r... | packages/ember-htmlbars/lib/hooks/will-cleanup-tree.js | @@ -1,10 +0,0 @@
-export default function willCleanupTree(env, morph, destroySelf) {
- var view = morph.emberView;
- if (destroySelf && view && view.parentView) {
- view.parentView.removeChild(view);
- }
-
- if (view = env.view) {
- view.ownerView.isDestroyingSubtree = true;
- }
-} | true |
Other | emberjs | ember.js | 0d43d24bc27db5b6267753c93868e8565f61f670.json | Eliminate redundant willCleanupNode hook
This commit resolves a memory leak (#11501) in apps running Glimmer. The
root cause of the issue was that a flag governing whether
components/views remove themselves from their parent was being set
incorrectly, so that when the code to cleanup a destroyed view ran, it
was not r... | packages/ember-views/tests/views/view/child_views_test.js | @@ -1,5 +1,6 @@
import run from 'ember-metal/run_loop';
import EmberView from 'ember-views/views/view';
+import Component from 'ember-views/views/component';
import { compile } from 'ember-template-compiler';
var parentView, childView;
@@ -77,16 +78,11 @@ QUnit.test('should remove childViews on destroy', function... | true |
Other | emberjs | ember.js | 09d41a474b9e3a85976b5e00362f6072c0b24fd6.json | add readme entry | README.md | @@ -52,3 +52,9 @@ versions of jQuery.
2. Run `npm test` to run a basic test suite or run `TEST_SUITE=all npm test` to
run a more comprehensive suite.
+## From ember-cli
+
+1. ember test --server
+2. connect the browsers you want
+3. if phantom didn't connect automatically, you can run `./bin/connect-phantom-to <... | false |
Other | emberjs | ember.js | 04163354e29d59b00d86315fbedc5e0b9d75dae0.json | prefer template string | packages/ember-views/lib/compat/render_buffer.js | @@ -478,7 +478,7 @@ RenderBuffer.prototype = {
if (!canSetNameOnInputs && attrs && attrs.name) {
// IE allows passing a tag to createElement. See note on `canSetNameOnInputs` above as well.
- tagString = '<'+stripTagName(tagName)+' name="'+escapeAttribute(attrs.name)+'">';
+ tagString = `<${stri... | false |
Other | emberjs | ember.js | 377b36b263ed2e82b6ce4d8fa9bd0bafbbf7a71a.json | Fix tests that got broken by a spelling change | packages/ember-metal/tests/main_test.js | @@ -35,11 +35,11 @@ QUnit.test('SEMVER_REGEX properly validates and invalidates version numbers', fu
QUnit.test('Ember.keys is deprecated', function() {
expectDeprecation(function() {
Ember.keys({});
- }, 'Ember.keys is deprecated in-favour of Object.keys');
+ }, 'Ember.keys is deprecated in favor of Object.... | false |
Other | emberjs | ember.js | 1fc7811a45dfb6184667364067203db4e2ff45dc.json | Fix view destruction inside outlets
This solution feels hacky and we need to discuss what code is really
responsible for view destruction. The htmlbars code that clears the DOM
does not do view destruction, which leaves us in an awkward situation
where the DOM is already removed but we need to destroy the view. | packages/ember-htmlbars/lib/keywords/real_outlet.js | @@ -25,7 +25,11 @@ export default {
toRender.template = topLevelViewTemplate;
}
- return { outletState: selectedOutletState, hasParentOutlet: env.hasParentOutlet };
+ return {
+ outletState: selectedOutletState,
+ hasParentOutlet: env.hasParentOutlet,
+ manager: state.manager
+ };
... | true |
Other | emberjs | ember.js | 1fc7811a45dfb6184667364067203db4e2ff45dc.json | Fix view destruction inside outlets
This solution feels hacky and we need to discuss what code is really
responsible for view destruction. The htmlbars code that clears the DOM
does not do view destruction, which leaves us in an awkward situation
where the DOM is already removed but we need to destroy the view. | packages/ember-htmlbars/lib/node-managers/view-node-manager.js | @@ -150,7 +150,10 @@ ViewNodeManager.prototype.rerender = function(env, attrs, visitor) {
};
ViewNodeManager.prototype.destroy = function() {
- this.component.destroy();
+ if (this.component) {
+ this.component.destroy();
+ this.component = null;
+ }
};
function getTemplate(componentOrView) { | true |
Other | emberjs | ember.js | 1fc7811a45dfb6184667364067203db4e2ff45dc.json | Fix view destruction inside outlets
This solution feels hacky and we need to discuss what code is really
responsible for view destruction. The htmlbars code that clears the DOM
does not do view destruction, which leaves us in an awkward situation
where the DOM is already removed but we need to destroy the view. | packages/ember-metal-views/lib/renderer.js | @@ -210,7 +210,7 @@ Renderer.prototype.renderElementRemoval =
if (view._willRemoveElement) {
view._willRemoveElement = false;
- if (view._renderNode) {
+ if (view._renderNode && view.element && view.element.parentNode) {
view._renderNode.clear();
}
this.didDestroyElement(v... | true |
Other | emberjs | ember.js | 7ffe8f70ee2b8a5c46e61c8e257e4157d141cc09.json | Remove unused import to fix jshint
This error sneaked into the repo due to #11574. | packages/ember-metal/lib/main.js | @@ -29,7 +29,6 @@ import {
metaPath,
setMeta,
deprecatedTryCatchFinally,
- deprecatedTryFinally,
tryInvoke,
uuid,
wrap | false |
Other | emberjs | ember.js | e189688d40c738ce3ccbdde39f336d50e6909432.json | Rerender link on routing state change.
Test link-to with only query params provided | packages/ember-routing-views/lib/views/link.js | @@ -349,6 +349,8 @@ var LinkComponent = EmberComponent.extend({
if (get(this, 'loading')) { return get(this, 'loadingHref'); }
+ targetRouteName = this._handleOnlyQueryParamsSupplied(targetRouteName);
+
var routing = get(this, '_routing');
var queryParams = get(this, 'queryParams.values');
re... | true |
Other | emberjs | ember.js | e189688d40c738ce3ccbdde39f336d50e6909432.json | Rerender link on routing state change.
Test link-to with only query params provided | packages/ember/tests/helpers/link_to_test.js | @@ -1378,3 +1378,37 @@ QUnit.test('{{link-to}} populates href with fully supplied query param values',
bootApplication();
equal(Ember.$('#the-link').attr('href'), '/?bar=NAW&foo=456', 'link has right href');
});
+
+QUnit.test('{{link-to}} with only query-params updates when route changes', function() {
+ Router... | true |
Other | emberjs | ember.js | b758625a2d3a1bc383a4d97895f0a67411a903ee.json | Enable features for 2.0.0. | features.json | @@ -6,7 +6,7 @@
"ember-htmlbars-component-helper": true,
"ember-htmlbars-inline-if-helper": true,
"ember-htmlbars-attribute-syntax": true,
- "ember-htmlbars-each-in": null,
+ "ember-htmlbars-each-in": true,
"ember-routing-transitioning-classes": true,
"ember-testing-checkbox-helpers": nul... | false |
Other | emberjs | ember.js | 4a2f37a500b2e8047e5af80f57419105f65dea0c.json | Add Ember 1.13.0 to CHANGELOG. | CHANGELOG.md | @@ -1,5 +1,65 @@
# Ember Changelog
+### 1.13.0 (June 12, 2015)
+
+- [#11270](https://github.com/emberjs/ember.js/pull/11270) [BUGFIX] Ensure view registry is propagated to components.
+- [#11273](https://github.com/emberjs/ember.js/pull/11273) [BUGFIX] Downgrade Ember.Service without proper inheritance to a deprecat... | false |
Other | emberjs | ember.js | 177733b42d7aef11a7b63f684d3194ddeb6e1447.json | Remove invalid usage of run.later. | packages/ember-htmlbars/tests/integration/will-destroy-element-hook-test.js | @@ -14,7 +14,6 @@ QUnit.module('ember-htmlbars: destroy-element-hook tests', {
});
QUnit.test('willDestroyElement is only called once when a component leaves scope', function(assert) {
- var done = assert.async();
var innerChild, innerChildDestroyed;
component = Component.create({
@@ -47,14 +46,12 @@ QUnit... | false |
Other | emberjs | ember.js | 5eae4d03254f3fb6871cd40a5360381520b77495.json | Remove extra space | packages/ember-views/lib/views/text_field.js | @@ -2,7 +2,7 @@
@module ember
@submodule ember-views
*/
-import { computed } from "ember-metal/computed";
+import { computed } from "ember-metal/computed";
import environment from "ember-metal/environment";
import create from "ember-metal/platform/create";
import Component from "ember-views/views/component"; | false |
Other | emberjs | ember.js | ac846c375b44089c6e0d9d6c3cb953ced5c30d7d.json | Destroy components when changed on re-render
Most of the infrastructure around components assumes they are static
(e.g. <my-component> cannot become a <foo-component> after it is
rendered). As such, there were some holes in destruction for the one
dynamic case (the {{component}} helper).
This commit detects when the ... | packages/ember-htmlbars/lib/keywords/component.js | @@ -7,6 +7,10 @@ export default {
},
render(morph, ...rest) {
+ if (morph.state.manager) {
+ morph.state.manager.destroy();
+ }
+
// Force the component hook to treat this as a first-time render,
// because normal components (`<foo-bar>`) cannot change at runtime,
// but the `{{compone... | true |
Other | emberjs | ember.js | ac846c375b44089c6e0d9d6c3cb953ced5c30d7d.json | Destroy components when changed on re-render
Most of the infrastructure around components assumes they are static
(e.g. <my-component> cannot become a <foo-component> after it is
rendered). As such, there were some holes in destruction for the one
dynamic case (the {{component}} helper).
This commit detects when the ... | packages/ember-htmlbars/lib/keywords/view.js | @@ -70,6 +70,11 @@ export default {
options.createOptions._targetObject = node.state.targetObject;
}
+ if (state.manager) {
+ state.manager.destroy();
+ state.manager = null;
+ }
+
var nodeManager = ViewNodeManager.create(node, env, hash, options, parentView, null, scope, template);
... | true |
Other | emberjs | ember.js | ac846c375b44089c6e0d9d6c3cb953ced5c30d7d.json | Destroy components when changed on re-render
Most of the infrastructure around components assumes they are static
(e.g. <my-component> cannot become a <foo-component> after it is
rendered). As such, there were some holes in destruction for the one
dynamic case (the {{component}} helper).
This commit detects when the ... | packages/ember-htmlbars/lib/node-managers/component-node-manager.js | @@ -264,6 +264,15 @@ ComponentNodeManager.prototype.rerender = function(_env, attrs, visitor) {
}, this);
};
+ComponentNodeManager.prototype.destroy = function() {
+ let component = this.component;
+
+ // Clear component's render node. Normally this gets cleared
+ // during view destruction, but in this case w... | true |
Other | emberjs | ember.js | ac846c375b44089c6e0d9d6c3cb953ced5c30d7d.json | Destroy components when changed on re-render
Most of the infrastructure around components assumes they are static
(e.g. <my-component> cannot become a <foo-component> after it is
rendered). As such, there were some holes in destruction for the one
dynamic case (the {{component}} helper).
This commit detects when the ... | packages/ember-htmlbars/lib/node-managers/view-node-manager.js | @@ -149,6 +149,10 @@ ViewNodeManager.prototype.rerender = function(env, attrs, visitor) {
}, this);
};
+ViewNodeManager.prototype.destroy = function() {
+ this.component.destroy();
+};
+
function getTemplate(componentOrView) {
return componentOrView.isComponent ? get(componentOrView, '_template') : get(compo... | true |
Other | emberjs | ember.js | e271685e96f0137e3042a480c33c23896b483acc.json | Make Ember.Checkbox extend from Ember.Component | packages/ember-views/lib/views/checkbox.js | @@ -1,6 +1,6 @@
import { get } from "ember-metal/property_get";
import { set } from "ember-metal/property_set";
-import View from "ember-views/views/view";
+import EmberComponent from "ember-views/views/component";
/**
@module ember
@@ -29,11 +29,10 @@ import View from "ember-views/views/view";
@class Checkb... | true |
Other | emberjs | ember.js | e271685e96f0137e3042a480c33c23896b483acc.json | Make Ember.Checkbox extend from Ember.Component | packages/ember-views/tests/views/checkbox_test.js | @@ -11,12 +11,11 @@ function set(obj, key, value) {
function append() {
run(function() {
- checkboxView.appendTo('#qunit-fixture');
+ checkboxComponent.appendTo('#qunit-fixture');
});
}
-
-var checkboxView, dispatcher;
+var checkboxComponent, dispatcher;
QUnit.module("Ember.Checkbox", {
setup() ... | true |
Other | emberjs | ember.js | 1c10d2fb0bfe4a0e9918fb597acf95fe620156ed.json | Add test for deprecation message | packages/ember-routing-views/lib/views/link.js | @@ -33,7 +33,7 @@ if (isEnabled('ember-routing-transitioning-classes')) {
@class LinkComponent
@namespace Ember
- @extends Ember.View
+ @extends Ember.Component
@see {Handlebars.helpers.link-to}
@private
**/ | true |
Other | emberjs | ember.js | 1c10d2fb0bfe4a0e9918fb597acf95fe620156ed.json | Add test for deprecation message | packages/ember-routing-views/tests/main_test.js | @@ -6,3 +6,8 @@ QUnit.test("exports correctly", function() {
ok(Ember.LinkComponent, "LinkComponent is exported correctly");
ok(Ember.OutletView, "OutletView is exported correctly");
});
+
+QUnit.test("Ember.LinkView is deprecated", function() {
+ expectDeprecation(/Ember.LinkView is deprecated. Please use Embe... | true |
Other | emberjs | ember.js | 796aff2146d0573f4240bec294201b33ab9a9ad9.json | Return the setter values instead of this | packages/ember-metal/lib/set_properties.js | @@ -20,11 +20,11 @@ import keys from "ember-metal/keys";
@method setProperties
@param obj
@param {Object} properties
- @return obj
+ @return properties
@public
*/
export default function setProperties(obj, properties) {
- if (!properties || typeof properties !== "object") { return obj; }
+ if (!proper... | true |
Other | emberjs | ember.js | 796aff2146d0573f4240bec294201b33ab9a9ad9.json | Return the setter values instead of this | packages/ember-runtime/lib/mixins/observable.js | @@ -460,8 +460,7 @@ export default Mixin.create({
incrementProperty(keyName, increment) {
if (isNone(increment)) { increment = 1; }
Ember.assert("Must pass a numeric value to incrementProperty", (!isNaN(parseFloat(increment)) && isFinite(increment)));
- set(this, keyName, (parseFloat(get(this, keyName))... | true |
Other | emberjs | ember.js | a5e5ad6917ee2f091f826aa5996be1c4d0c10db7.json | Fix helper export, add test | packages/ember-htmlbars/lib/main.js | @@ -72,7 +72,7 @@ Ember.HTMLBars = {
DOMHelper
};
-if (Ember.FEATURES.isEnabled('ember-htmlbars-helpers')) {
+if (Ember.FEATURES.isEnabled('ember-htmlbars-helper')) {
Helper.helper = makeHelper;
Ember.Helper = Helper;
} | true |
Other | emberjs | ember.js | a5e5ad6917ee2f091f826aa5996be1c4d0c10db7.json | Fix helper export, add test | packages/ember/tests/global-api-test.js | @@ -10,3 +10,7 @@ function confirmExport(property) {
confirmExport('Ember.DefaultResolver');
confirmExport('Ember.generateController');
+if (Ember.FEATURES.isEnabled('ember-htmlbars-helper')) {
+ confirmExport('Ember.Helper');
+ confirmExport('Ember.Helper.helper');
+} | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | package.json | @@ -23,7 +23,7 @@
"express": "^4.5.0",
"github": "^0.2.3",
"glob": "~4.3.2",
- "htmlbars": "0.13.25",
+ "htmlbars": "0.13.28",
"qunit-extras": "^1.3.0",
"qunitjs": "^1.16.0",
"route-recognizer": "0.1.5", | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-application/lib/system/application.js | @@ -1016,7 +1016,6 @@ Application.reopenClass({
registry.optionsForType('component', { singleton: false });
registry.optionsForType('view', { singleton: false });
registry.optionsForType('template', { instantiate: false });
- registry.optionsForType('helper', { instantiate: false });
registry.r... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-application/lib/system/resolver.js | @@ -15,6 +15,7 @@ import EmberObject from 'ember-runtime/system/object';
import Namespace from 'ember-runtime/system/namespace';
import helpers from 'ember-htmlbars/helpers';
import validateType from 'ember-application/utils/validate-type';
+import HandlebarsCompatibleHelper from "ember-htmlbars/compat/helper";
e... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-application/tests/system/dependency_injection/default_resolver_test.js | @@ -9,6 +9,11 @@ import Service from "ember-runtime/system/service";
import EmberObject from "ember-runtime/system/object";
import Namespace from "ember-runtime/system/namespace";
import Application from "ember-application/system/application";
+import Helper from "ember-htmlbars/helper";
+import HandlebarsCompatible... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/lib/helper.js | @@ -0,0 +1,25 @@
+import Object from "ember-runtime/system/object";
+
+// Ember.Helper.extend({ compute(params, hash) {} });
+var Helper = Object.extend({
+ isHelper: true,
+ recompute() {
+ this._stream.notify();
+ }
+});
+
+Helper.reopenClass({
+ isHelperFactory: true
+});
+
+// Ember.Helper.helper(function(pa... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/lib/hooks/element.js | @@ -5,6 +5,7 @@
import { findHelper } from "ember-htmlbars/system/lookup-helper";
import { handleRedirect } from "htmlbars-runtime/hooks";
+import { buildHelperStream } from "ember-htmlbars/system/invoke-helper";
var fakeElement;
@@ -32,7 +33,8 @@ export default function emberElement(morph, env, scope, path, p... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/lib/hooks/has-helper.js | @@ -1,5 +1,17 @@
-import { findHelper } from "ember-htmlbars/system/lookup-helper";
+import { validateLazyHelperName } from "ember-htmlbars/system/lookup-helper";
export default function hasHelperHook(env, scope, helperName) {
- return !!findHelper(helperName, scope.self, env);
+ if (env.helpers[helperName]) {
+ ... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/lib/hooks/invoke-helper.js | @@ -1,43 +1,24 @@
import Ember from 'ember-metal/core'; // Ember.assert
-import getValue from "ember-htmlbars/hooks/get-value";
+import { buildHelperStream } from "ember-htmlbars/system/invoke-helper";
+export default function invokeHelper(morph, env, scope, visitor, params, hash, helper, templates, context) {
-
-... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/lib/hooks/subexpr.js | @@ -4,12 +4,8 @@
*/
import lookupHelper from "ember-htmlbars/system/lookup-helper";
-import merge from "ember-metal/merge";
-import Stream from "ember-metal/streams/stream";
-import create from "ember-metal/platform/create";
+import { buildHelperStream } from "ember-htmlbars/system/invoke-helper";
import {
- read... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/lib/main.js | @@ -31,6 +31,7 @@ import legacyEachWithKeywordHelper from "ember-htmlbars/helpers/-legacy-each-wit
import getHelper from "ember-htmlbars/helpers/-get";
import htmlSafeHelper from "ember-htmlbars/helpers/-html-safe";
import DOMHelper from "ember-htmlbars/system/dom-helper";
+import Helper from "ember-htmlbars/helper"... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/lib/streams/built-in-helper.js | @@ -0,0 +1,27 @@
+import Stream from "ember-metal/streams/stream";
+import create from "ember-metal/platform/create";
+import merge from "ember-metal/merge";
+import {
+ getArrayValues,
+ getHashValues
+} from "ember-htmlbars/streams/utils";
+
+export default function BuiltInHelperStream(helper, params, hash, templat... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/lib/streams/compat-helper.js | @@ -0,0 +1,22 @@
+import Stream from "ember-metal/streams/stream";
+import create from "ember-metal/platform/create";
+import merge from "ember-metal/merge";
+
+export default function CompatHelperStream(helper, params, hash, templates, env, scope, label) {
+ this.init(label);
+ this.helper = helper.helperFunction;
+... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/lib/streams/helper-factory.js | @@ -0,0 +1,35 @@
+import Stream from "ember-metal/streams/stream";
+import create from "ember-metal/platform/create";
+import merge from "ember-metal/merge";
+import {
+ getArrayValues,
+ getHashValues
+} from "ember-htmlbars/streams/utils";
+
+export default function HelperFactoryStream(helperFactory, params, hash, ... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/lib/streams/helper-instance.js | @@ -0,0 +1,23 @@
+import Stream from "ember-metal/streams/stream";
+import create from "ember-metal/platform/create";
+import merge from "ember-metal/merge";
+import {
+ getArrayValues,
+ getHashValues
+} from "ember-htmlbars/streams/utils";
+
+export default function HelperInstanceStream(helper, params, hash, label)... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/lib/streams/utils.js | @@ -0,0 +1,21 @@
+import getValue from "ember-htmlbars/hooks/get-value";
+
+// We don't want to leak mutable cells into helpers, which
+// are pure functions that can only work with values.
+export function getArrayValues(params) {
+ let out = [];
+ for (let i=0, l=params.length; i<l; i++) {
+ out.push(getValue(pa... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/lib/system/invoke-helper.js | @@ -0,0 +1,17 @@
+import HelperInstanceStream from "ember-htmlbars/streams/helper-instance";
+import HelperFactoryStream from "ember-htmlbars/streams/helper-factory";
+import BuiltInHelperStream from "ember-htmlbars/streams/built-in-helper";
+import CompatHelperStream from "ember-htmlbars/streams/compat-helper";
+
+exp... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/lib/system/lookup-helper.js | @@ -5,13 +5,15 @@
import Ember from "ember-metal/core";
import Cache from "ember-metal/cache";
-import makeViewHelper from "ember-htmlbars/system/make-view-helper";
-import HandlebarsCompatibleHelper from "ember-htmlbars/compat/helper";
-export var ISNT_HELPER_CACHE = new Cache(1000, function(key) {
- return key... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/lib/system/make_bound_helper.js | @@ -3,8 +3,7 @@
@submodule ember-htmlbars
*/
-import Helper from "ember-htmlbars/system/helper";
-import { readHash, readArray } from "ember-metal/streams/utils";
+import Helper from "ember-htmlbars/helper";
/**
Create a bound helper. Accepts a function that receives the ordered and hash parameters
@@ -50,8 +... | true |
Other | emberjs | ember.js | 334b3df0aff2038ceda0293fecebc1ee16cc8d54.json | Implement Ember.Helper API | packages/ember-htmlbars/lib/utils/is-component.js | @@ -3,7 +3,7 @@
@submodule ember-htmlbars
*/
-import { ISNT_HELPER_CACHE } from "ember-htmlbars/system/lookup-helper";
+import { CONTAINS_DASH_CACHE } from "ember-htmlbars/system/lookup-helper";
/*
Given a path name, returns whether or not a component with that
@@ -12,7 +12,7 @@ import { ISNT_HELPER_CACHE } fr... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.