language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | e46e056f1d5ed3136efbdf2136febebacd0461c6.json | use peekMeta + deleteMeta is isolate the code-base. | packages/ember-metal/lib/property_get.js | @@ -11,6 +11,9 @@ import {
isPath,
hasThis as pathHasThis
} from 'ember-metal/path_cache';
+import {
+ peekMeta
+} from 'ember-metal/meta';
var FIRST_KEY = /^([^\.]+)/;
@@ -57,7 +60,7 @@ export function get(obj, keyName) {
return obj;
}
- var meta = obj['__ember_meta__'];
+ var meta = peekMeta(... | true |
Other | emberjs | ember.js | e46e056f1d5ed3136efbdf2136febebacd0461c6.json | use peekMeta + deleteMeta is isolate the code-base. | packages/ember-metal/lib/property_set.js | @@ -12,6 +12,9 @@ import {
isPath,
hasThis as pathHasThis
} from 'ember-metal/path_cache';
+import {
+ peekMeta
+} from 'ember-metal/meta';
/**
Sets the value of a property on an object, respecting computed properties
@@ -38,7 +41,7 @@ export function set(obj, keyName, value, tolerant) {
var meta, po... | true |
Other | emberjs | ember.js | e46e056f1d5ed3136efbdf2136febebacd0461c6.json | use peekMeta + deleteMeta is isolate the code-base. | packages/ember-metal/lib/watching.js | @@ -17,6 +17,10 @@ import {
import {
isPath
} from 'ember-metal/path_cache';
+import {
+ peekMeta,
+ deleteMeta
+} from 'ember-metal/meta';
/**
Starts watching a property on an object. Whenever the property changes,
@@ -45,7 +49,7 @@ function watch(obj, _keyPath, m) {
export { watch };
export function ... | true |
Other | emberjs | ember.js | e46e056f1d5ed3136efbdf2136febebacd0461c6.json | use peekMeta + deleteMeta is isolate the code-base. | packages/ember-metal/tests/chains_test.js | @@ -4,6 +4,8 @@ import { finishChains } from 'ember-metal/chains';
import { defineProperty } from 'ember-metal/properties';
import computed from 'ember-metal/computed';
import { propertyDidChange } from 'ember-metal/property_events';
+import { peekMeta } from 'ember-metal/meta';
+
QUnit.module('Chains');
QUnit.t... | true |
Other | emberjs | ember.js | e46e056f1d5ed3136efbdf2136febebacd0461c6.json | use peekMeta + deleteMeta is isolate the code-base. | packages/ember-runtime/tests/system/object/destroy_test.js | @@ -9,7 +9,7 @@ import {
} from 'ember-metal/property_events';
import { testBoth } from 'ember-metal/tests/props_helper';
import EmberObject from 'ember-runtime/system/object';
-
+import { peekMeta } from 'ember-metal/meta';
QUnit.module('ember-runtime/system/object/destroy_test');
testBoth('should schedule obje... | true |
Other | emberjs | ember.js | 9851decd9919e2a3371eeaf4b65e8995980c5c2b.json | remove extra call to metaFor | packages/ember-metal/lib/mixin.js | @@ -378,7 +378,7 @@ function applyMixin(obj, mixins, partial) {
// * Set up _super wrapping if necessary
// * Set up computed property descriptors
// * Copying `toString` in broken browsers
- mergeMixins(mixins, metaFor(obj), descs, values, obj, keys);
+ mergeMixins(mixins, m, descs, values, obj, keys);
... | false |
Other | emberjs | ember.js | 6a6824860686ec8f18adc0fa739258f92df14cec.json | Add test for view controller changes | packages/ember-views/tests/views/view/controller_test.js | @@ -48,3 +48,45 @@ QUnit.test('controller property should be inherited from nearest ancestor with c
grandchild.destroy();
});
});
+
+QUnit.test('controller changes are passed to descendants', function() {
+ var grandparent = ContainerView.create();
+ var parent = ContainerView.create();
+ var child = Contai... | false |
Other | emberjs | ember.js | 5fca89003b46eba529cc7d9e05cf8cb32451309e.json | Fix node tests to use new APIs | tests/node/helpers/app-module.js | @@ -87,11 +87,10 @@ module.exports = function(moduleName) {
QUnit.module(moduleName, {
beforeEach: function() {
var Ember = this.Ember = require(emberPath);
- var DOMHelper = Ember.HTMLBars.DOMHelper;
+
Ember.testing = true;
this.compile = require(templateCompilerPath).compile;
- ... | false |
Other | emberjs | ember.js | 20df8632b4361cb1b1d552e067084bbb9746888e.json | Avoid timing brittleness in Ember.Select test.
The goal of this test is to ensure that the following scenario:
1. `selection` is set to a slow resolving promise
2. `selection` is set to another value (a promise that resolves before
the "slow resolving" promise above)
Results in the newest assigned selection (2. fr... | packages/ember-views/tests/views/select_test.js | @@ -257,37 +257,36 @@ QUnit.test('selection can be set from a Promise when multiple=false', function()
equal(select.$()[0].selectedIndex, 1, 'Should select from Promise content');
});
-QUnit.test('selection from a Promise don\'t overwrite newer selection once resolved, when multiple=false', function() {
- expect... | false |
Other | emberjs | ember.js | b0b4a1a96fe512c339d76082a181f2907012792f.json | Use promises for async tests | packages/ember-application/tests/system/visit_test.js | @@ -3,6 +3,7 @@ import EmberObject from 'ember-runtime/system/object';
import isEnabled from 'ember-metal/features';
import inject from 'ember-runtime/inject';
import run from 'ember-metal/run_loop';
+import { onerrorDefault } from 'ember-runtime/ext/rsvp';
import Application from 'ember-application/system/applicat... | false |
Other | emberjs | ember.js | 01fc2a683a92ddf5d069a33eb92f6af2c37582c2.json | Prefix boolean flags w/Java conventions | packages/ember-application/lib/system/application-instance.js | @@ -167,7 +167,7 @@ let ApplicationInstance = EmberObject.extend(RegistryProxy, ContainerProxy, {
registry.register('renderer:-dom', {
create() {
- return new Renderer(new DOMHelper(options.document), options.interactive);
+ return new Renderer(new DOMHelper(options.document), option... | true |
Other | emberjs | ember.js | 01fc2a683a92ddf5d069a33eb92f6af2c37582c2.json | Prefix boolean flags w/Java conventions | packages/ember-application/lib/system/application.js | @@ -373,8 +373,7 @@ var Application = Namespace.extend(RegistryProxy, {
} else {
// Force-assign these flags to their default values when the feature is
// disabled, this ensures we can rely on their values in other paths.
- this.autoboot = true;
- this._globalsMode = true;
+ this.auto... | true |
Other | emberjs | ember.js | 01fc2a683a92ddf5d069a33eb92f6af2c37582c2.json | Prefix boolean flags w/Java conventions | packages/ember-application/tests/system/visit_test.js | @@ -520,7 +520,7 @@ if (isEnabled('ember-application-visit')) {
let a = run(function() {
let dom = makeFakeDom();
- return App.visit('/a', { browser: false, document: dom, rootElement: dom.body }).then(instance => {
+ return App.visit('/a', { isBrowser: false, document: dom, rootElement: dom.bod... | true |
Other | emberjs | ember.js | 01fc2a683a92ddf5d069a33eb92f6af2c37582c2.json | Prefix boolean flags w/Java conventions | packages/ember-routing/lib/system/route.js | @@ -1214,7 +1214,7 @@ var Route = EmberObject.extend(ActionHandler, Evented, {
this.setupController(controller, context, transition);
if (isEnabled('ember-application-visit')) {
- if (!this._environment || this._environment.options.render) {
+ if (!this._environment || this._environment.options.sh... | true |
Other | emberjs | ember.js | 551d6fc1dd983594831bdf8d716291ac4a86255c.json | Fix all the typos | packages/ember-application/lib/system/application-instance.js | @@ -150,7 +150,7 @@ let ApplicationInstance = EmberObject.extend(RegistryProxy, ContainerProxy, {
We would like new code (like the `visit` API) to stop making this assumption,
so we created the asynchronous version above that returns a promise. But until
we have migrated all the code, we would have to ex... | true |
Other | emberjs | ember.js | 551d6fc1dd983594831bdf8d716291ac4a86255c.json | Fix all the typos | packages/ember-application/lib/system/application.js | @@ -308,7 +308,7 @@ var Application = Namespace.extend(RegistryProxy, {
/**
Whether the application should be configured for the legacy "globals mode".
- Under this mode, the Application object serves as a gobal namespace for all
+ Under this mode, the Application object serves as a global namespace for... | true |
Other | emberjs | ember.js | 008f1dcd1605cfe925f9b754316e0d4d5036a1a2.json | Use ES6 default parameters | packages/ember-application/lib/system/application-instance.js | @@ -372,9 +372,7 @@ if (isEnabled('ember-application-visit')) {
@namespace @Ember.ApplicationInstance
@public
*/
- BootOptions = function BootOptions(options) {
- options = options || {};
-
+ BootOptions = function BootOptions(options = {}) {
/**
Provide a specific instance of jQuery. This... | true |
Other | emberjs | ember.js | 008f1dcd1605cfe925f9b754316e0d4d5036a1a2.json | Use ES6 default parameters | packages/ember-application/lib/system/application.js | @@ -406,10 +406,8 @@ var Application = Namespace.extend(RegistryProxy, {
@method buildInstance
@return {Ember.ApplicationInstance} the application instance
*/
- buildInstance(options) {
- options = options || {};
+ buildInstance(options = {}) {
options.application = this;
-
return Applicatio... | true |
Other | emberjs | ember.js | 7329fe9fac2644d4ecbde69e76ec0351f551820d.json | Ensure test waits properly for async test helper.
Without this, the test will timeout after 1s (regardless of
`QUnit.config.testTimeout` setting which is not used unless
you are using `QUnit.asyncTest`, `assert.async`, or
`QUnit.stop`). | packages/ember-testing/tests/helper_registration_test.js | @@ -53,15 +53,18 @@ QUnit.test('Helper gets registered', function() {
ok(helperContainer.boot);
});
-QUnit.test('Helper is ran when called', function() {
- expect(1);
+QUnit.test('Helper is ran when called', function(assert) {
+ let done = assert.async();
+ assert.expect(1);
registerHelper();
setupApp(... | false |
Other | emberjs | ember.js | bfe3908b2be9ceab76918d68a50f6c521a25e939.json | Update QUnit test timeout to 15 seconds.
We have an annoying intermitent test failure that occurs when running
tests on older browsers in Sauce Labs. The failure is generally
occurring when the VM itself is slower than normal, and will pass after
a restart.
This increases the timeout to allow more time (from 7 second... | tests/index.html | @@ -143,8 +143,8 @@
});
setupQUnit(testHelpers);
- // Tests should time out after 5 seconds
- QUnit.config.testTimeout = 7500;
+ // Tests should time out after 15 seconds
+ QUnit.config.testTimeout = 15000;
// Handle testing feature flags
QUnit.config.ur... | false |
Other | emberjs | ember.js | 104e2c6593bf5ba81da0a39bad74f8ab40912e2d.json | Add a FastBoot test to help design the API | packages/ember-application/lib/system/application-instance.js | @@ -11,12 +11,15 @@ import { set } from 'ember-metal/property_set';
import EmberObject from 'ember-runtime/system/object';
import run from 'ember-metal/run_loop';
import { computed } from 'ember-metal/computed';
+import ContainerProxy from 'ember-runtime/mixins/container_proxy';
+import DOMHelper from 'ember-htmlbar... | true |
Other | emberjs | ember.js | 104e2c6593bf5ba81da0a39bad74f8ab40912e2d.json | Add a FastBoot test to help design the API | packages/ember-application/lib/system/application.js | @@ -992,21 +992,35 @@ if (isEnabled('ember-application-visit')) {
@method visit
@private
*/
- visit(url) {
+ visit(url, options) {
return this.boot().then(() => {
- let defer = new Ember.RSVP.defer();
-
- return this.buildInstance().boot({
- location: 'none',
- ... | true |
Other | emberjs | ember.js | 104e2c6593bf5ba81da0a39bad74f8ab40912e2d.json | Add a FastBoot test to help design the API | packages/ember-application/tests/system/visit_test.js | @@ -6,31 +6,43 @@ import ApplicationInstance from 'ember-application/system/application-instance';
import Route from 'ember-routing/system/route';
import Router from 'ember-routing/system/router';
import View from 'ember-views/views/view';
+import Component from 'ember-views/components/component';
import compile fr... | true |
Other | emberjs | ember.js | e8e3e1d341402c5ceb587bcf8a291ca1089464b2.json | Finalize namespace before booting instances | packages/ember-application/lib/system/application.js | @@ -721,9 +721,16 @@ var Application = Namespace.extend(RegistryProxy, {
*/
didBecomeReady() {
try {
- let instance;
+ // TODO: Is this needed for globalsMode = false?
+ if (!Ember.testing) {
+ // Eagerly name all classes that are already loaded
+ Ember.Namespace.processAll();
+ ... | false |
Other | emberjs | ember.js | 5b8651097efc014a7da0a0d3e5eb1a3edf34c0b4.json | Fix a string (remove superfluous space) | packages/ember-routing/lib/system/router.js | @@ -268,7 +268,7 @@ var EmberRouter = EmberObject.extend(Evented, {
run.once(this, this.trigger, 'willTransition', transition);
if (get(this, 'namespace').LOG_TRANSITIONS) {
- Ember.Logger.log(`Preparing to transition from '${EmberRouter._routePath(oldInfos)}' to ' ${EmberRouter._routePath(newInfos)}'`... | false |
Other | emberjs | ember.js | b60e201209cb0e60939457ad0062376dfaacaa32.json | Remove unsupported global check for class bindings. | packages/ember-views/lib/system/build-component-template.js | @@ -1,7 +1,6 @@
import { assert, deprecate } from 'ember-metal/debug';
import { get } from 'ember-metal/property_get';
import assign from 'ember-metal/assign';
-import { isGlobal } from 'ember-metal/path_cache';
import { internal, render } from 'htmlbars-runtime';
import getValue from 'ember-htmlbars/hooks/get-val... | false |
Other | emberjs | ember.js | da7f6d5b2f5767e682b289997be3c2f4005ea3f3.json | update API docs for `computed`
This example was showing the old-style computed property arguments,
which were deprecated before 2.0. | packages/ember-metal/lib/computed.js | @@ -526,7 +526,7 @@ ComputedPropertyPrototype.teardown = function(obj, keyName) {
firstName: 'Betty',
lastName: 'Jones',
- fullName: Ember.computed('firstName', 'lastName', function(key, value) {
+ fullName: Ember.computed('firstName', 'lastName', function() {
return this.get('firstName') + ' '... | false |
Other | emberjs | ember.js | cdc496a0fcc9a7cafc01eca7943b59ab59a42081.json | Add names to anon functions in node managers.
This makes debugging and profiling a little bit easier (removing some
"anonymous functions" and replacing with useful names). | packages/ember-htmlbars/lib/node-managers/component-node-manager.js | @@ -33,7 +33,7 @@ function ComponentNodeManager(component, isAngleBracket, scope, renderNode, attr
export default ComponentNodeManager;
-ComponentNodeManager.create = function(renderNode, env, options) {
+ComponentNodeManager.create = function ComponentNodeManager_create(renderNode, env, options) {
let { tagNam... | true |
Other | emberjs | ember.js | cdc496a0fcc9a7cafc01eca7943b59ab59a42081.json | Add names to anon functions in node managers.
This makes debugging and profiling a little bit easier (removing some
"anonymous functions" and replacing with useful names). | packages/ember-htmlbars/lib/node-managers/view-node-manager.js | @@ -26,7 +26,7 @@ function ViewNodeManager(component, scope, renderNode, block, expectElement) {
export default ViewNodeManager;
-ViewNodeManager.create = function(renderNode, env, attrs, found, parentView, path, contentScope, contentTemplate) {
+ViewNodeManager.create = function ViewNodeManager_create(renderNode,... | true |
Other | emberjs | ember.js | d15e699c6da8db3fdbd78a7c1fcf7c1cfbdc029a.json | Update HTMLBars version.
https://github.com/tildeio/htmlbars/compare/v0.14.4...v0.14.5 | package.json | @@ -33,7 +33,7 @@
"finalhandler": "^0.4.0",
"github": "^0.2.3",
"glob": "~4.3.2",
- "htmlbars": "0.14.4",
+ "htmlbars": "0.14.5",
"qunit-extras": "^1.3.0",
"qunitjs": "^1.16.0",
"route-recognizer": "0.1.5", | false |
Other | emberjs | ember.js | 87190229e133deab859fbc935e8241f8c667936d.json | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for us... | packages/ember-htmlbars/lib/env.js | @@ -7,14 +7,16 @@ import merge from 'ember-metal/merge';
import subexpr from 'ember-htmlbars/hooks/subexpr';
import concat from 'ember-htmlbars/hooks/concat';
import linkRenderNode from 'ember-htmlbars/hooks/link-render-node';
-import createFreshScope from 'ember-htmlbars/hooks/create-fresh-scope';
+import createFre... | true |
Other | emberjs | ember.js | 87190229e133deab859fbc935e8241f8c667936d.json | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for us... | packages/ember-htmlbars/lib/hooks/bind-block.js | @@ -0,0 +1,3 @@
+export default function bindBlock(env, scope, block, name='default') {
+ scope.bindBlock(name, block);
+} | true |
Other | emberjs | ember.js | 87190229e133deab859fbc935e8241f8c667936d.json | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for us... | packages/ember-htmlbars/lib/hooks/bind-local.js | @@ -7,15 +7,14 @@ import Stream from 'ember-metal/streams/stream';
import ProxyStream from 'ember-metal/streams/proxy-stream';
export default function bindLocal(env, scope, key, value) {
- var isExisting = scope.locals.hasOwnProperty(key);
- if (isExisting) {
- var existing = scope.locals[key];
-
+ // TODO: W... | true |
Other | emberjs | ember.js | 87190229e133deab859fbc935e8241f8c667936d.json | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for us... | packages/ember-htmlbars/lib/hooks/bind-self.js | @@ -3,7 +3,7 @@
@submodule ember-htmlbars
*/
-import newStream from 'ember-htmlbars/utils/new-stream';
+import ProxyStream from 'ember-metal/streams/proxy-stream';
export default function bindSelf(env, scope, _self) {
let self = _self;
@@ -12,25 +12,32 @@ export default function bindSelf(env, scope, _self) {
... | true |
Other | emberjs | ember.js | 87190229e133deab859fbc935e8241f8c667936d.json | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for us... | packages/ember-htmlbars/lib/hooks/bind-shadow-scope.js | @@ -3,7 +3,7 @@
@submodule ember-htmlbars
*/
-import newStream from 'ember-htmlbars/utils/new-stream';
+import ProxyStream from 'ember-metal/streams/proxy-stream';
export default function bindShadowScope(env, parentScope, shadowScope, options) {
if (!options) { return; }
@@ -12,31 +12,35 @@ export default fun... | true |
Other | emberjs | ember.js | 87190229e133deab859fbc935e8241f8c667936d.json | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for us... | packages/ember-htmlbars/lib/hooks/component.js | @@ -77,7 +77,7 @@ export default function componentHook(renderNode, env, scope, _tagName, params,
tagName,
isAngleBracket: true,
isComponentElement: true,
- outerAttrs: scope.attrs,
+ outerAttrs: scope.getAttrs(),
parentScope: scope
};
| true |
Other | emberjs | ember.js | 87190229e133deab859fbc935e8241f8c667936d.json | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for us... | packages/ember-htmlbars/lib/hooks/create-fresh-scope.js | @@ -1,3 +1,5 @@
+import ProxyStream from 'ember-metal/streams/proxy-stream';
+
/*
Ember's implementation of HTMLBars creates an enriched scope.
@@ -46,13 +48,114 @@
the current view's `controller`.
*/
+function Scope(parent) {
+ this._self = null;
+ this._blocks = {};
+ this._component = null;
+ this._v... | true |
Other | emberjs | ember.js | 87190229e133deab859fbc935e8241f8c667936d.json | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for us... | packages/ember-htmlbars/lib/hooks/element.js | @@ -13,7 +13,7 @@ export default function emberElement(morph, env, scope, path, params, hash, visi
}
var result;
- var helper = findHelper(path, scope.self, env);
+ var helper = findHelper(path, scope.getSelf(), env);
if (helper) {
var helperStream = buildHelperStream(helper, params, hash, { element: ... | true |
Other | emberjs | ember.js | 87190229e133deab859fbc935e8241f8c667936d.json | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for us... | packages/ember-htmlbars/lib/hooks/get-block.js | @@ -0,0 +1,3 @@
+export default function getBlock(scope, key) {
+ return scope.getBlock(key);
+} | true |
Other | emberjs | ember.js | 87190229e133deab859fbc935e8241f8c667936d.json | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for us... | packages/ember-htmlbars/lib/hooks/get-root.js | @@ -5,30 +5,35 @@
export default function getRoot(scope, key) {
if (key === 'this') {
- return [scope.self];
+ return [scope.getSelf()];
} else if (key === 'hasBlock') {
- return [!!scope.blocks.default];
+ return [!!scope.hasBlock('default')];
} else if (key === 'hasBlockParams') {
- return ... | true |
Other | emberjs | ember.js | 87190229e133deab859fbc935e8241f8c667936d.json | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for us... | packages/ember-htmlbars/lib/hooks/lookup-helper.js | @@ -1,5 +1,5 @@
import lookupHelper from 'ember-htmlbars/system/lookup-helper';
export default function lookupHelperHook(env, scope, helperName) {
- return lookupHelper(helperName, scope.self, env);
+ return lookupHelper(helperName, scope.getSelf(), env);
} | true |
Other | emberjs | ember.js | 87190229e133deab859fbc935e8241f8c667936d.json | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for us... | packages/ember-htmlbars/lib/hooks/subexpr.js | @@ -19,7 +19,7 @@ export default function subexpr(env, scope, helperName, params, hash) {
}
var label = labelForSubexpr(params, hash, helperName);
- var helper = lookupHelper(helperName, scope.self, env);
+ var helper = lookupHelper(helperName, scope.getSelf(), env);
var helperStream = buildHelperStream(... | true |
Other | emberjs | ember.js | 87190229e133deab859fbc935e8241f8c667936d.json | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for us... | packages/ember-htmlbars/lib/hooks/update-self.js | @@ -5,7 +5,6 @@
import { assert } from 'ember-metal/debug';
import { get } from 'ember-metal/property_get';
-import updateScope from 'ember-htmlbars/utils/update-scope';
export default function updateSelf(env, scope, _self) {
let self = _self;
@@ -14,16 +13,16 @@ export default function updateSelf(env, scope,... | true |
Other | emberjs | ember.js | 87190229e133deab859fbc935e8241f8c667936d.json | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for us... | packages/ember-htmlbars/lib/keywords/debugger.js | @@ -52,8 +52,8 @@ import { info } from 'ember-metal/debug';
export default function debuggerKeyword(morph, env, scope) {
/* jshint unused: false, debug: true */
- var view = env.hooks.getValue(scope.locals.view);
- var context = env.hooks.getValue(scope.self);
+ var view = env.hooks.getValue(scope.getLocal('vi... | true |
Other | emberjs | ember.js | 87190229e133deab859fbc935e8241f8c667936d.json | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for us... | packages/ember-htmlbars/lib/keywords/legacy-yield.js | @@ -2,21 +2,22 @@ import ProxyStream from 'ember-metal/streams/proxy-stream';
export default function legacyYield(morph, env, _scope, params, hash, template, inverse, visitor) {
let scope = _scope;
+ let block = scope.getBlock('default');
- if (scope.blocks.default.arity === 0) {
+ if (block.arity === 0) {
... | true |
Other | emberjs | ember.js | 87190229e133deab859fbc935e8241f8c667936d.json | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for us... | packages/ember-htmlbars/lib/keywords/view.js | @@ -188,15 +188,15 @@ import ViewNodeManager from 'ember-htmlbars/node-managers/view-node-manager';
export default {
setupState(state, env, scope, params, hash) {
var read = env.hooks.getValue;
- var targetObject = read(scope.self);
+ var targetObject = read(scope.getSelf());
var viewClassOrInstance... | true |
Other | emberjs | ember.js | 87190229e133deab859fbc935e8241f8c667936d.json | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for us... | packages/ember-htmlbars/lib/keywords/yield.js | @@ -0,0 +1,10 @@
+export default function yieldKeyword(morph, env, scope, params, hash, template, inverse, visitor) {
+ let to = env.hooks.getValue(hash.to) || 'default';
+ let block = scope.getBlock(to);
+
+ if (block) {
+ block.invoke(env, params, hash.self, morph, scope, visitor);
+ }
+
+ return true;
+} | true |
Other | emberjs | ember.js | 87190229e133deab859fbc935e8241f8c667936d.json | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for us... | packages/ember-htmlbars/lib/node-managers/component-node-manager.js | @@ -62,8 +62,8 @@ ComponentNodeManager.create = function(renderNode, env, options) {
// If there is a controller on the scope, pluck it off and save it on the
// component. This allows the component to target actions sent via
// `sendAction` correctly.
- if (parentScope.locals.controller) {
- createOptions... | true |
Other | emberjs | ember.js | 87190229e133deab859fbc935e8241f8c667936d.json | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for us... | packages/ember-htmlbars/lib/node-managers/view-node-manager.js | @@ -46,8 +46,11 @@ ViewNodeManager.create = function(renderNode, env, attrs, found, parentView, pat
if (attrs && attrs._defaultTagName) { options._defaultTagName = getValue(attrs._defaultTagName); }
if (attrs && attrs.viewName) { options.viewName = getValue(attrs.viewName); }
- if (found.component.create... | true |
Other | emberjs | ember.js | 87190229e133deab859fbc935e8241f8c667936d.json | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for us... | packages/ember-htmlbars/lib/utils/subscribe.js | @@ -2,7 +2,7 @@ import { isStream, labelFor } from 'ember-metal/streams/utils';
export default function subscribe(node, env, scope, stream) {
if (!isStream(stream)) { return; }
- var component = scope.component;
+ var component = scope.getComponent();
var unsubscribers = node.streamUnsubscribers = node.strea... | true |
Other | emberjs | ember.js | 87190229e133deab859fbc935e8241f8c667936d.json | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for us... | packages/ember-routing-htmlbars/lib/keywords/closure-action.js | @@ -25,7 +25,7 @@ export default function closureAction(morph, env, scope, params, hash, template,
// on-change={{action setName}}
// element-space actions look to "controller" then target. Here we only
// look to "target".
- target = read(scope.self);
+ target = read(scope.getSelf());
... | true |
Other | emberjs | ember.js | 87190229e133deab859fbc935e8241f8c667936d.json | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for us... | packages/ember-routing-htmlbars/lib/keywords/element-action.js | @@ -32,7 +32,7 @@ export default {
target = read(hash.target);
}
} else {
- target = read(scope.locals.controller) || read(scope.self);
+ target = read(scope.getLocal('controller')) || read(scope.getSelf());
}
return { actionName, actionArgs, target }; | true |
Other | emberjs | ember.js | 87190229e133deab859fbc935e8241f8c667936d.json | Implement Template scopes as classes
Similar to `meta`, this commit restructures the scope away from
pervasive use of `Object.create` into a custom JavaScript object.
This has two benefits:
1. We only need a single parent pointer, rather than having every map
inherit from its parent map.
2. v8 penalizes us for us... | packages/ember-routing-htmlbars/lib/keywords/render.js | @@ -185,7 +185,7 @@ export default {
controllerFullName = 'controller:' + controllerName;
}
- var parentController = read(scope.locals.controller);
+ var parentController = read(scope.getLocal('controller'));
var controller;
// choose name | true |
Other | emberjs | ember.js | 87694af87d7decf2fcbc52d646138a2f7cfe4cdb.json | Remove most of AttrsProxy
Previously, we tried to restrict which attributes we set eagerly, and
clean up the rest using unknownProperty. However, over time, making that
work correctly has gotten more and more complicated, and the cost of the
laziness is more than the benefits.
This commit goes back to an eager settin... | packages/ember-htmlbars/lib/node-managers/component-node-manager.js | @@ -221,6 +221,10 @@ ComponentNodeManager.prototype.rerender = function(_env, attrs, visitor) {
var snapshot = takeSnapshot(attrs);
if (component._renderNode.shouldReceiveAttrs) {
+ if (component.propagateAttrsToThis) {
+ component.propagateAttrsToThis(takeLegacySnapshot(attrs));
+ }
+
... | true |
Other | emberjs | ember.js | 87694af87d7decf2fcbc52d646138a2f7cfe4cdb.json | Remove most of AttrsProxy
Previously, we tried to restrict which attributes we set eagerly, and
clean up the rest using unknownProperty. However, over time, making that
work correctly has gotten more and more complicated, and the cost of the
laziness is more than the benefits.
This commit goes back to an eager settin... | packages/ember-htmlbars/lib/node-managers/view-node-manager.js | @@ -8,6 +8,7 @@ import View from 'ember-views/views/view';
import { MUTABLE_CELL } from 'ember-views/compat/attrs-proxy';
import getCellOrValue from 'ember-htmlbars/hooks/get-cell-or-value';
import { instrument } from 'ember-htmlbars/system/instrumentation-support';
+import { takeLegacySnapshot } from 'ember-htmlbar... | true |
Other | emberjs | ember.js | 87694af87d7decf2fcbc52d646138a2f7cfe4cdb.json | Remove most of AttrsProxy
Previously, we tried to restrict which attributes we set eagerly, and
clean up the rest using unknownProperty. However, over time, making that
work correctly has gotten more and more complicated, and the cost of the
laziness is more than the benefits.
This commit goes back to an eager settin... | packages/ember-metal-views/lib/renderer.js | @@ -147,8 +147,6 @@ Renderer.prototype.setAttrs = function (view, attrs) {
}; // set attrs the first time
Renderer.prototype.componentInitAttrs = function (component, attrs) {
- // for attrs-proxy support
- component.trigger('_internalDidReceiveAttrs');
component.trigger('didInitAttrs', { attrs });
componen... | true |
Other | emberjs | ember.js | 87694af87d7decf2fcbc52d646138a2f7cfe4cdb.json | Remove most of AttrsProxy
Previously, we tried to restrict which attributes we set eagerly, and
clean up the rest using unknownProperty. However, over time, making that
work correctly has gotten more and more complicated, and the cost of the
laziness is more than the benefits.
This commit goes back to an eager settin... | packages/ember-views/lib/compat/attrs-proxy.js | @@ -1,8 +1,6 @@
import { Mixin } from 'ember-metal/mixin';
import { symbol } from 'ember-metal/utils';
import { PROPERTY_DID_CHANGE } from 'ember-metal/property_events';
-import { on } from 'ember-metal/events';
-import EmptyObject from 'ember-metal/empty_object';
export function deprecation(key) {
return `You... | true |
Other | emberjs | ember.js | 41d0162fdca4d71212977b0337f47ac8afab5464.json | fix hasDeps inheritance | packages/ember-metal/lib/meta.js | @@ -194,8 +194,14 @@ function inheritedMapOfMaps(name, Meta) {
};
Meta.prototype['has' + capitalized] = function(subkey) {
- let map = this._getInherited(key);
- return map && !!map[subkey];
+ let pointer = this;
+ while (pointer !== undefined) {
+ if (pointer[key] && pointer[key][subkey]) {
+ ... | false |
Other | emberjs | ember.js | c3dd592c27ab4769be6b7a1f06d75b81b72296eb.json | Remove work around for babel bug. | packages/ember-metal/lib/watch_key.js | @@ -58,10 +58,6 @@ if (isEnabled('mandatory-setter')) {
};
}
-// This is super annoying, but required until
-// https://github.com/babel/babel/issues/906 is resolved
-; // jshint ignore:line
-
export function unwatchKey(obj, keyName, meta) {
var m = meta || metaFor(obj);
let count = m.peekWatching(keyName)... | false |
Other | emberjs | ember.js | 2a44c09675932f2fc12152db3973e5b6ab1f29d3.json | Update HTMLBars to v0.14.4. | package.json | @@ -33,7 +33,7 @@
"finalhandler": "^0.4.0",
"github": "^0.2.3",
"glob": "~4.3.2",
- "htmlbars": "0.14.3",
+ "htmlbars": "0.14.4",
"qunit-extras": "^1.3.0",
"qunitjs": "^1.16.0",
"route-recognizer": "0.1.5", | false |
Other | emberjs | ember.js | 3439ccd2bfbe76cbddfd1416afbbec791f920a52.json | Remove unused conditional stream. | packages/ember-metal/lib/streams/conditional.js | @@ -1,52 +0,0 @@
-import Stream from 'ember-metal/streams/stream';
-import {
- read,
- subscribe,
- unsubscribe,
- isStream
-} from 'ember-metal/streams/utils';
-
-export default function conditional(test, consequent, alternate) {
- if (isStream(test)) {
- return new ConditionalStream(test, consequent, alternat... | false |
Other | emberjs | ember.js | c8c0fc88e9b04065addfcd45919867b7fcf99725.json | Add new-stream util
Use new-stream util to remove duplication | packages/ember-htmlbars/lib/hooks/bind-self.js | @@ -3,8 +3,7 @@
@submodule ember-htmlbars
*/
-import ProxyStream from 'ember-metal/streams/proxy-stream';
-import subscribe from 'ember-htmlbars/utils/subscribe';
+import newStream from 'ember-htmlbars/utils/new-stream';
export default function bindSelf(env, scope, _self) {
let self = _self;
@@ -35,9 +34,3 @@... | true |
Other | emberjs | ember.js | c8c0fc88e9b04065addfcd45919867b7fcf99725.json | Add new-stream util
Use new-stream util to remove duplication | packages/ember-htmlbars/lib/hooks/bind-shadow-scope.js | @@ -3,6 +3,8 @@
@submodule ember-htmlbars
*/
+import newStream from 'ember-htmlbars/utils/new-stream';
+
export default function bindShadowScope(env, parentScope, shadowScope, options) {
if (!options) { return; }
@@ -38,12 +40,3 @@ export default function bindShadowScope(env, parentScope, shadowScope, options... | true |
Other | emberjs | ember.js | c8c0fc88e9b04065addfcd45919867b7fcf99725.json | Add new-stream util
Use new-stream util to remove duplication | packages/ember-htmlbars/lib/utils/new-stream.js | @@ -0,0 +1,8 @@
+import ProxyStream from 'ember-metal/streams/proxy-stream';
+import subscribe from 'ember-htmlbars/utils/subscribe';
+
+export default function newStream(scope, key, newValue, renderNode, isSelf) {
+ var stream = new ProxyStream(newValue, isSelf ? '' : key);
+ if (renderNode) { subscribe(renderNode, ... | true |
Other | emberjs | ember.js | 23888dac5efdb7fb043d9a1ee6560495d74ecef4.json | Remove knownForType usage for dashless helpers.
`container.registry.has` is a fast check, and allows us to make this
PAYGO much better than iterating all modules up front. | packages/ember-htmlbars/lib/hooks/has-helper.js | @@ -6,7 +6,7 @@ export default function hasHelperHook(env, scope, helperName) {
}
var container = env.container;
- if (validateLazyHelperName(helperName, container, env.hooks.keywords, env.knownHelpers)) {
+ if (validateLazyHelperName(helperName, container, env.hooks.keywords)) {
var containerName = 'hel... | true |
Other | emberjs | ember.js | 23888dac5efdb7fb043d9a1ee6560495d74ecef4.json | Remove knownForType usage for dashless helpers.
`container.registry.has` is a fast check, and allows us to make this
PAYGO much better than iterating all modules up front. | packages/ember-htmlbars/lib/system/discover-known-helpers.js | @@ -1,22 +0,0 @@
-import dictionary from 'ember-metal/dictionary';
-
-export default function discoverKnownHelpers(container) {
- let registry = container && container.registry;
- let helpers = dictionary(null);
-
- if (!registry) {
- return helpers;
- }
-
- let known = registry.knownForType('helper');
- let k... | true |
Other | emberjs | ember.js | 23888dac5efdb7fb043d9a1ee6560495d74ecef4.json | Remove knownForType usage for dashless helpers.
`container.registry.has` is a fast check, and allows us to make this
PAYGO much better than iterating all modules up front. | packages/ember-htmlbars/lib/system/lookup-helper.js | @@ -10,14 +10,8 @@ export var CONTAINS_DASH_CACHE = new Cache(1000, function(key) {
return key.indexOf('-') !== -1;
});
-export function validateLazyHelperName(helperName, container, keywords, knownHelpers) {
- if (!container || (helperName in keywords)) {
- return false;
- }
-
- if (knownHelpers[helperName... | true |
Other | emberjs | ember.js | 23888dac5efdb7fb043d9a1ee6560495d74ecef4.json | Remove knownForType usage for dashless helpers.
`container.registry.has` is a fast check, and allows us to make this
PAYGO much better than iterating all modules up front. | packages/ember-htmlbars/lib/system/render-env.js | @@ -1,5 +1,4 @@
import defaultEnv from 'ember-htmlbars/env';
-import discoverKnownHelpers from 'ember-htmlbars/system/discover-known-helpers';
export default function RenderEnv(options) {
this.lifecycleHooks = options.lifecycleHooks || [];
@@ -12,7 +11,6 @@ export default function RenderEnv(options) {
this.co... | true |
Other | emberjs | ember.js | 23888dac5efdb7fb043d9a1ee6560495d74ecef4.json | Remove knownForType usage for dashless helpers.
`container.registry.has` is a fast check, and allows us to make this
PAYGO much better than iterating all modules up front. | packages/ember-htmlbars/tests/system/discover-known-helpers-test.js | @@ -1,48 +0,0 @@
-import Registry from 'container/registry';
-import Helper from 'ember-htmlbars/helper';
-import { runDestroy } from 'ember-runtime/tests/utils';
-import discoverKnownHelpers from 'ember-htmlbars/system/discover-known-helpers';
-
-var resolver, registry, container;
-
-QUnit.module('ember-htmlbars: disc... | true |
Other | emberjs | ember.js | 0192fdb93500ef6b80ea8b8a11c818e9a6136525.json | Update emberjs-build to remove need for derequire.
emberjs-build now uses a babel plugin to transform top level `define`
calls into `enifed` calls. This allows us to:
* keep dev builds closer to prod builds (by removing this specific
difference)
* shave another 3-5 seconds off of production builds.
```
% ember s -... | package.json | @@ -28,7 +28,7 @@
"ember-cli-sauce": "^1.3.0",
"ember-cli-yuidoc": "0.7.0",
"ember-publisher": "0.0.7",
- "emberjs-build": "0.3.5",
+ "emberjs-build": "0.4.0",
"express": "^4.5.0",
"finalhandler": "^0.4.0",
"github": "^0.2.3", | true |
Other | emberjs | ember.js | 0192fdb93500ef6b80ea8b8a11c818e9a6136525.json | Update emberjs-build to remove need for derequire.
emberjs-build now uses a babel plugin to transform top level `define`
calls into `enifed` calls. This allows us to:
* keep dev builds closer to prod builds (by removing this specific
difference)
* shave another 3-5 seconds off of production builds.
```
% ember s -... | packages/loader/lib/main.js | @@ -1,4 +1,4 @@
-var define, requireModule, require, requirejs, Ember;
+var enifed, requireModule, require, requirejs, Ember;
var mainContext = this;
(function() {
@@ -15,7 +15,7 @@ var mainContext = this;
var registry = {};
var seen = {};
- define = function(name, deps, callback) {
+ enifed = fun... | true |
Other | emberjs | ember.js | 9869cc29c1e01b01a22f115fd1939e6ef18e7d67.json | Update emberjs-build to remove use-strict-remover.
This has been implemented upstream as a custom babel plugin. | package.json | @@ -28,7 +28,7 @@
"ember-cli-sauce": "^1.3.0",
"ember-cli-yuidoc": "0.7.0",
"ember-publisher": "0.0.7",
- "emberjs-build": "0.3.3",
+ "emberjs-build": "0.3.5",
"express": "^4.5.0",
"finalhandler": "^0.4.0",
"github": "^0.2.3", | true |
Other | emberjs | ember.js | 9869cc29c1e01b01a22f115fd1939e6ef18e7d67.json | Update emberjs-build to remove use-strict-remover.
This has been implemented upstream as a custom babel plugin. | packages/ember-metal/lib/dependent_keys.js | @@ -1,7 +1,6 @@
+'no use strict';
// Remove "use strict"; from transpiled module until
// https://bugs.webkit.org/show_bug.cgi?id=138038 is fixed
-//
-'REMOVE_USE_STRICT: true';
import {
watch, | true |
Other | emberjs | ember.js | 9869cc29c1e01b01a22f115fd1939e6ef18e7d67.json | Update emberjs-build to remove use-strict-remover.
This has been implemented upstream as a custom babel plugin. | packages/ember-metal/lib/events.js | @@ -1,7 +1,6 @@
+'no use strict';
// Remove "use strict"; from transpiled module until
// https://bugs.webkit.org/show_bug.cgi?id=138038 is fixed
-//
-'REMOVE_USE_STRICT: true';
/**
@module ember | true |
Other | emberjs | ember.js | 9869cc29c1e01b01a22f115fd1939e6ef18e7d67.json | Update emberjs-build to remove use-strict-remover.
This has been implemented upstream as a custom babel plugin. | packages/ember-metal/lib/meta.js | @@ -1,7 +1,6 @@
+'no use strict';
// Remove "use strict"; from transpiled module until
// https://bugs.webkit.org/show_bug.cgi?id=138038 is fixed
-//
-'REMOVE_USE_STRICT: true';
import { protoMethods as listenerMethods } from 'ember-metal/meta_listeners';
import EmptyObject from 'ember-metal/empty_object'; | true |
Other | emberjs | ember.js | 9869cc29c1e01b01a22f115fd1939e6ef18e7d67.json | Update emberjs-build to remove use-strict-remover.
This has been implemented upstream as a custom babel plugin. | packages/ember-metal/lib/mixin.js | @@ -1,7 +1,6 @@
+'no use strict';
// Remove "use strict"; from transpiled module until
// https://bugs.webkit.org/show_bug.cgi?id=138038 is fixed
-//
-'REMOVE_USE_STRICT: true';
/**
@module ember | true |
Other | emberjs | ember.js | 9869cc29c1e01b01a22f115fd1939e6ef18e7d67.json | Update emberjs-build to remove use-strict-remover.
This has been implemented upstream as a custom babel plugin. | packages/ember-metal/lib/utils.js | @@ -1,7 +1,6 @@
+'no use strict';
// Remove "use strict"; from transpiled module until
// https://bugs.webkit.org/show_bug.cgi?id=138038 is fixed
-//
-'REMOVE_USE_STRICT: true';
/**
@module ember-metal | true |
Other | emberjs | ember.js | 9869cc29c1e01b01a22f115fd1939e6ef18e7d67.json | Update emberjs-build to remove use-strict-remover.
This has been implemented upstream as a custom babel plugin. | packages/ember-runtime/lib/system/core_object.js | @@ -1,7 +1,6 @@
+'no use strict';
// Remove "use strict"; from transpiled module until
// https://bugs.webkit.org/show_bug.cgi?id=138038 is fixed
-//
-'REMOVE_USE_STRICT: true';
/**
@module ember | true |
Other | emberjs | ember.js | ab3159a8359b2b703395436000424e269d5bded4.json | Update emberjs-build to remove loader recursion.
Should help initial boot a tiny bit, but is less bytes either way
:smiley:. | package.json | @@ -28,7 +28,7 @@
"ember-cli-sauce": "^1.3.0",
"ember-cli-yuidoc": "0.7.0",
"ember-publisher": "0.0.7",
- "emberjs-build": "0.3.2",
+ "emberjs-build": "0.3.3",
"express": "^4.5.0",
"finalhandler": "^0.4.0",
"github": "^0.2.3", | true |
Other | emberjs | ember.js | ab3159a8359b2b703395436000424e269d5bded4.json | Update emberjs-build to remove loader recursion.
Should help initial boot a tiny bit, but is less bytes either way
:smiley:. | packages/loader/lib/main.js | @@ -60,7 +60,7 @@ var mainContext = this;
if (deps[i] === 'exports') {
reified.push(exports);
} else {
- reified.push(internalRequire(resolve(deps[i], name), name));
+ reified.push(internalRequire(deps[i], name));
}
}
@@ -69,28 +69,6 @@ var mainContext = ... | true |
Other | emberjs | ember.js | def813cd5f8d7d73f62f054305dcfe7135b4a2c4.json | Add info to debug functions | Brocfile.js | @@ -35,7 +35,7 @@ function babelConfigFor(environment) {
if (isProduction) {
plugins.push(filterImports({
- 'ember-metal/debug': ['assert','debug','deprecate','runInDebug','warn']
+ 'ember-metal/debug': ['assert','debug','deprecate','info','runInDebug','warn']
}));
}
| true |
Other | emberjs | ember.js | def813cd5f8d7d73f62f054305dcfe7135b4a2c4.json | Add info to debug functions | features.json | @@ -10,8 +10,5 @@
"ember-registry-container-reform": true,
"ember-routing-routable-components": null
},
- "debugStatements": [
- "Ember.Logger.info",
- "Ember.default.Logger.info"
- ]
+ "debugStatements": []
} | true |
Other | emberjs | ember.js | def813cd5f8d7d73f62f054305dcfe7135b4a2c4.json | Add info to debug functions | packages/ember-application/lib/system/resolver.js | @@ -4,9 +4,8 @@
*/
import Ember from 'ember-metal/core';
-import { assert } from 'ember-metal/debug';
+import { assert, info } from 'ember-metal/debug';
import { get } from 'ember-metal/property_get';
-import Logger from 'ember-metal/logger';
import {
classify,
capitalize,
@@ -431,7 +430,7 @@ export default... | true |
Other | emberjs | ember.js | def813cd5f8d7d73f62f054305dcfe7135b4a2c4.json | Add info to debug functions | packages/ember-application/tests/system/dependency_injection/default_resolver_test.js | @@ -1,6 +1,7 @@
+/* globals EmberDev */
import Ember from 'ember-metal/core'; // Ember.TEMPLATES
+import { getDebugFunction, setDebugFunction } from 'ember-metal/debug';
import run from 'ember-metal/run_loop';
-import Logger from 'ember-metal/logger';
import Controller from 'ember-runtime/controllers/controller';
i... | true |
Other | emberjs | ember.js | def813cd5f8d7d73f62f054305dcfe7135b4a2c4.json | Add info to debug functions | packages/ember-debug/lib/main.js | @@ -79,6 +79,16 @@ setDebugFunction('debug', function debug(message) {
Logger.debug('DEBUG: ' + message);
});
+/**
+ Display an info notice.
+
+ @method info
+ @private
+*/
+setDebugFunction('info', function info() {
+ Logger.info.apply(undefined, arguments);
+});
+
/**
Alias an old, deprecated method wit... | true |
Other | emberjs | ember.js | def813cd5f8d7d73f62f054305dcfe7135b4a2c4.json | Add info to debug functions | packages/ember-htmlbars/lib/keywords/debugger.js | @@ -4,7 +4,8 @@
@module ember
@submodule ember-htmlbars
*/
-import Logger from 'ember-metal/logger';
+
+import { info } from 'ember-metal/debug';
/**
Execute the `debugger` statement in the current template's context.
@@ -58,7 +59,7 @@ export default function debuggerKeyword(morph, env, scope) {
return en... | true |
Other | emberjs | ember.js | def813cd5f8d7d73f62f054305dcfe7135b4a2c4.json | Add info to debug functions | packages/ember-htmlbars/lib/keywords/outlet.js | @@ -3,7 +3,7 @@
@submodule ember-templates
*/
-import Ember from 'ember-metal/core';
+import { info } from 'ember-metal/debug';
import { get } from 'ember-metal/property_get';
import ViewNodeManager from 'ember-htmlbars/node-managers/view-node-manager';
import topLevelViewTemplate from 'ember-htmlbars/templates/... | true |
Other | emberjs | ember.js | def813cd5f8d7d73f62f054305dcfe7135b4a2c4.json | Add info to debug functions | packages/ember-metal/lib/debug.js | @@ -1,5 +1,6 @@
export let debugFunctions = {
assert() {},
+ info() {},
warn() {},
debug() {},
deprecate() {},
@@ -19,6 +20,10 @@ export function assert() {
return debugFunctions.assert.apply(undefined, arguments);
}
+export function info() {
+ return debugFunctions.info.apply(undefined, arguments)... | true |
Other | emberjs | ember.js | def813cd5f8d7d73f62f054305dcfe7135b4a2c4.json | Add info to debug functions | packages/ember-routing/lib/system/generate_controller.js | @@ -1,4 +1,4 @@
-import Ember from 'ember-metal/core'; // Logger
+import { info } from 'ember-metal/debug';
import { get } from 'ember-metal/property_get';
/**
@@ -51,7 +51,7 @@ export default function generateController(container, controllerName, context) {
var instance = container.lookup(fullName);
if (ge... | true |
Other | emberjs | ember.js | def813cd5f8d7d73f62f054305dcfe7135b4a2c4.json | Add info to debug functions | packages/ember-routing/lib/system/route.js | @@ -1,5 +1,5 @@
import Ember from 'ember-metal/core'; // FEATURES, A, deprecate, assert, Logger
-import { assert, deprecate } from 'ember-metal/debug';
+import { assert, deprecate, info } from 'ember-metal/debug';
import isEnabled from 'ember-metal/features';
import EmberError from 'ember-metal/error';
import { get... | true |
Other | emberjs | ember.js | def813cd5f8d7d73f62f054305dcfe7135b4a2c4.json | Add info to debug functions | packages/ember-routing/lib/system/router.js | @@ -1,5 +1,5 @@
import Ember from 'ember-metal/core';
-import { assert } from 'ember-metal/debug';
+import { assert, info } from 'ember-metal/debug';
import EmberError from 'ember-metal/error';
import { get } from 'ember-metal/property_get';
import { set } from 'ember-metal/property_set';
@@ -503,7 +503,7 @@ var Em... | true |
Other | emberjs | ember.js | 824ec132a7cd4e8cd600a85f477244bb3042648e.json | Update router.js in bower.json | bower.json | @@ -12,7 +12,7 @@
"devDependencies": {
"backburner": "https://github.com/ebryn/backburner.js.git#ea82b6d703a7b65b4c4c65671843edb8d67f2a6c",
"rsvp": "https://github.com/tildeio/rsvp.js.git#3.0.20",
- "router.js": "https://github.com/tildeio/router.js.git#ed45bc5c5e055af0ab875ef2c52feda792ee23e4",
+ "r... | false |
Other | emberjs | ember.js | 341d25e81532a21e267d86b585aae4dc49ffb1e7.json | Add router.js to yuidoc.json | yuidoc.json | @@ -16,7 +16,8 @@
"packages/ember-application/lib",
"packages/ember-testing/lib",
"packages/ember-extension-support/lib",
- "bower_components/rsvp/lib"
+ "bower_components/rsvp/lib",
+ "bower_components/router.js/lib"
],
"exclude": "vendor",
"outdir": "docs" | false |
Other | emberjs | ember.js | 847a7869f552ac480a09530b892b71f40450ec74.json | Replace usage of debug statements in ember-debug. | packages/ember-debug/lib/deprecate.js | @@ -3,6 +3,7 @@
import Ember from 'ember-metal/core';
import EmberError from 'ember-metal/error';
import Logger from 'ember-metal/logger';
+
import { registerHandler as genericRegisterHandler, invoke } from 'ember-debug/handlers';
export function registerHandler(handler) { | true |
Other | emberjs | ember.js | 847a7869f552ac480a09530b892b71f40450ec74.json | Replace usage of debug statements in ember-debug. | packages/ember-debug/lib/main.js | @@ -1,13 +1,18 @@
import Ember from 'ember-metal/core';
-import { setDebugFunction } from 'ember-metal/debug';
+import {
+ warn,
+ deprecate,
+ debug,
+ setDebugFunction
+} from 'ember-metal/debug';
import isEnabled, { FEATURES } from 'ember-metal/features';
import EmberError from 'ember-metal/error';
import Lo... | true |
Other | emberjs | ember.js | 847a7869f552ac480a09530b892b71f40450ec74.json | Replace usage of debug statements in ember-debug. | packages/ember-debug/lib/warn.js | @@ -1,5 +1,5 @@
-import Ember from 'ember-metal/core';
import Logger from 'ember-metal/logger';
+import { deprecate } from 'ember-metal/debug';
import { registerHandler as genericRegisterHandler, invoke } from 'ember-debug/handlers';
export function registerHandler(handler) {
@@ -30,15 +30,15 @@ export let missing... | true |
Other | emberjs | ember.js | 847a7869f552ac480a09530b892b71f40450ec74.json | Replace usage of debug statements in ember-debug. | packages/ember-debug/tests/warn_if_using_stripped_feature_flags_test.js | @@ -1,4 +1,5 @@
import Ember from 'ember-metal/core';
+import { getDebugFunction, setDebugFunction } from 'ember-metal/debug';
import { _warnIfUsingStrippedFeatureFlags } from 'ember-debug';
var oldWarn, oldRunInDebug, origEnvFeatures, origEnableAll, origEnableOptional;
@@ -7,15 +8,15 @@ function confirmWarns(expe... | true |
Other | emberjs | ember.js | 505031063e8c4ba096c359506dc979fa2ccfc96a.json | Extract root element class into variable | packages/ember-views/lib/system/event_dispatcher.js | @@ -14,6 +14,9 @@ import ActionManager from 'ember-views/system/action_manager';
import View from 'ember-views/views/view';
import assign from 'ember-metal/assign';
+let ROOT_ELEMENT_CLASS = 'ember-application';
+let ROOT_ELEMENT_SELECTOR = '.' + ROOT_ELEMENT_CLASS;
+
/**
`Ember.EventDispatcher` handles delegat... | false |
Other | emberjs | ember.js | 998eaa68defd4ec62ad4f371026a4bbe55145ac5.json | Remove leftover {{debugger}} | packages/ember-htmlbars/tests/integration/component_lifecycle_test.js | @@ -365,7 +365,7 @@ styles.forEach(style => {
QUnit.test('changing a component\'s displayed properties inside didInsertElement() is deprecated', function(assert) {
let component = style.class.extend({
- layout: compile('<div>{{debugger}}{{handle}}</div>'),
+ layout: compile('<div>{{handle}}</div>'),... | false |
Other | emberjs | ember.js | 24c6a1ec09c34a6ecfea4aee18ebd805961bdc4a.json | Add missing semicolon | STYLEGUIDE.md | @@ -376,15 +376,14 @@ var [
var person = {
firstName: 'Stefan',
lastName: 'Penner'
-}
+};
var {
firstName,
lastName
} = person;
```
-
## Comments
+ Use [YUIDoc](http://yui.github.io/yuidoc/syntax/index.html) comments for | false |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.