language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | emberjs | ember.js | c959fc5cc68b83621371f713b4926ec09f7b5abd.json | Use module alias, don't break module bindings. | packages/ember-metal/lib/computed.js | @@ -1,7 +1,7 @@
import Ember from 'ember-metal/core';
import { set } from 'ember-metal/property_set';
import { inspect } from 'ember-metal/utils';
-import { meta } from 'ember-metal/meta';
+import { meta as metaFor } from 'ember-metal/meta';
import expandProperties from 'ember-metal/expand_properties';
import Embe... | false |
Other | emberjs | ember.js | 647b84dc3819f4b1e48f1fa8b668a529992f9c4a.json | Add 2.1.0-beta.1 to CHANGELOG.
[ci skip] | CHANGELOG.md | @@ -1,5 +1,20 @@
# Ember Changelog
+### 2.1.0-beta.1 (August 16, 2015)
+
+- [#10173](https://github.com/emberjs/ember.js/pull/10173) [BUGFIX] Ensure non-singleton injections are not cached incorrectly.
+- [#11966](https://github.com/emberjs/ember.js/pull/11966) [PERF] Refactor Meta.
+- [#12057](https://github.com/em... | false |
Other | emberjs | ember.js | d34aaed42c7471744254eafdedeb5c8e3e077d2b.json | Add 1.13.0 - 1.13.8 + 2.0.0 to CHANGELOG.md.
[ci skip] | CHANGELOG.md | @@ -1,5 +1,233 @@
# Ember Changelog
+### 2.0.0 (August 13, 2015)
+
+- [#12036](https://github.com/emberjs/ember.js/pull/12036) Cleanup CP Set and Volatile
+- [#11993](https://github.com/emberjs/ember.js/pull/11993) [CLEANUP] Remove `Ember.TrackedArray` and `Ember.SubArray`.
+- [#11550](https://github.com/emberjs/em... | false |
Other | emberjs | ember.js | 16eb4f803ca751c1f869f2c1e7e2c9b7ae79a7e6.json | Seperate instanceInitializer into its own section.
(cherry picked from commit f38acb3b339d3009acc7e9518e52f3b56d8f6724)
(cherry picked from commit 7fc8118eb89277411f72148b6735ea254b3fcd47) | packages/ember-application/lib/system/application.js | @@ -712,6 +712,69 @@ var Application = Namespace.extend(RegistryProxy, {
});
Application.reopenClass({
+ /**
+ Instance initializers run after all initializers have run. Because
+ instance initializers run after the app is fully set up. We have access
+ to the store, container, and other items. However, t... | false |
Other | emberjs | ember.js | 0c1e11dc9229d3760803641e1c171e75a6122342.json | Collapse two Travis builds into one.
The build setup takes longer than actually running these. This updates
Travis config to run one less build, but the same actual tests. | .travis.yml | @@ -54,7 +54,6 @@ env:
matrix:
- TEST_SUITE=each-package-tests
- TEST_SUITE=built-tests EMBER_ENV=production DISABLE_JSCS=true DISABLE_JSHINT=true
- - TEST_SUITE=old-jquery
- - TEST_SUITE=extend-prototypes
+ - TEST_SUITE=old-jquery-and-extend-prototypes
- TEST_SUITE=node DISABLE_JSCS=true DIS... | true |
Other | emberjs | ember.js | 0c1e11dc9229d3760803641e1c171e75a6122342.json | Collapse two Travis builds into one.
The build setup takes longer than actually running these. This updates
Travis config to run one less build, but the same actual tests. | bin/run-tests.js | @@ -141,12 +141,9 @@ switch (process.env.TEST_SUITE) {
console.log('suite: built-tests');
generateBuiltTests();
break;
- case 'old-jquery':
- console.log('suite: old-jquery');
+ case 'old-jquery-and-extend-prototypes':
+ console.log('suite: old-jquery-and-extend-prototypes');
generateOldJQue... | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-htmlbars/lib/env.js | @@ -1,5 +1,4 @@
import _Ember from 'ember-metal';
-import isEnabled from 'ember-metal/features';
import environment from 'ember-metal/environment';
import { hooks } from 'htmlbars-runtime'; | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-htmlbars/lib/helpers/each-in.js | @@ -3,7 +3,6 @@
@submodule ember-templates
*/
-import isEnabled from 'ember-metal/features';
import shouldDisplay from 'ember-views/streams/should_display';
/** | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-htmlbars/lib/keywords/get.js | @@ -4,7 +4,6 @@
*/
import Ember from 'ember-metal/core';
-import isEnabled from 'ember-metal/features';
import Stream from 'ember-metal/streams/stream';
import KeyStream from 'ember-metal/streams/key-stream';
import { isStream } from 'ember-metal/streams/utils'; | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-htmlbars/tests/attr_nodes/boolean_test.js | @@ -1,4 +1,3 @@
-import isEnabled from 'ember-metal/features';
import EmberView from 'ember-views/views/view';
import run from 'ember-metal/run_loop';
import compile from 'ember-template-compiler/system/compile'; | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-htmlbars/tests/attr_nodes/class_test.js | @@ -1,4 +1,3 @@
-import isEnabled from 'ember-metal/features';
import EmberView from 'ember-views/views/view';
import run from 'ember-metal/run_loop';
import compile from 'ember-template-compiler/system/compile'; | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-htmlbars/tests/attr_nodes/data_test.js | @@ -1,4 +1,3 @@
-import isEnabled from 'ember-metal/features';
import EmberView from 'ember-views/views/view';
import run from 'ember-metal/run_loop';
import EmberObject from 'ember-runtime/system/object'; | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-htmlbars/tests/attr_nodes/href_test.js | @@ -1,4 +1,3 @@
-import isEnabled from 'ember-metal/features';
import EmberView from 'ember-views/views/view';
import run from 'ember-metal/run_loop';
import compile from 'ember-template-compiler/system/compile'; | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-htmlbars/tests/attr_nodes/property_test.js | @@ -1,5 +1,4 @@
import Ember from 'ember-metal/core';
-import isEnabled from 'ember-metal/features';
import EmberView from 'ember-views/views/view';
import run from 'ember-metal/run_loop';
import compile from 'ember-template-compiler/system/compile'; | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-htmlbars/tests/attr_nodes/sanitized_test.js | @@ -1,6 +1,5 @@
/* jshint scripturl:true */
-import isEnabled from 'ember-metal/features';
import EmberView from 'ember-views/views/view';
import compile from 'ember-template-compiler/system/compile';
import { SafeString } from 'ember-htmlbars/utils/string'; | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-htmlbars/tests/attr_nodes/style_test.js | @@ -1,7 +1,6 @@
/* globals EmberDev */
import Ember from 'ember-metal/core';
-import isEnabled from 'ember-metal/features';
import EmberView from 'ember-views/views/view';
import compile from 'ember-template-compiler/system/compile';
import { SafeString } from 'ember-htmlbars/utils/string'; | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-htmlbars/tests/attr_nodes/svg_test.js | @@ -1,5 +1,4 @@
import Ember from 'ember-metal/core';
-import isEnabled from 'ember-metal/features';
import EmberView from 'ember-views/views/view';
import run from 'ember-metal/run_loop';
import compile from 'ember-template-compiler/system/compile'; | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-htmlbars/tests/attr_nodes/value_test.js | @@ -1,4 +1,3 @@
-import isEnabled from 'ember-metal/features';
import EmberView from 'ember-views/views/view';
import run from 'ember-metal/run_loop';
import compile from 'ember-template-compiler/system/compile'; | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-htmlbars/tests/helpers/component_test.js | @@ -1,5 +1,4 @@
import Ember from 'ember-metal/core';
-import isEnabled from 'ember-metal/features';
import { set } from 'ember-metal/property_set';
import { get } from 'ember-metal/property_get';
import run from 'ember-metal/run_loop'; | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-htmlbars/tests/helpers/each_in_test.js | @@ -1,4 +1,3 @@
-import isEnabled from 'ember-metal/features';
import Component from 'ember-views/views/component';
import compile from 'ember-template-compiler/system/compile';
import run from 'ember-metal/run_loop'; | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-htmlbars/tests/helpers/get_test.js | @@ -1,5 +1,4 @@
import Ember from 'ember-metal/core';
-import isEnabled from 'ember-metal/features';
import run from 'ember-metal/run_loop';
import { Registry } from 'ember-runtime/system/container';
import compile from 'ember-template-compiler/system/compile'; | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-htmlbars/tests/helpers/if_unless_test.js | @@ -1,5 +1,4 @@
import Ember from 'ember-metal/core';
-import isEnabled from 'ember-metal/features';
import run from 'ember-metal/run_loop';
import Namespace from 'ember-runtime/system/namespace';
import { Registry } from 'ember-runtime/system/container'; | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-htmlbars/tests/integration/helper-lookup-test.js | @@ -1,4 +1,3 @@
-import isEnabled from 'ember-metal/features';
import Registry from 'container/registry';
import compile from 'ember-template-compiler/system/compile';
import ComponentLookup from 'ember-views/component_lookup'; | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-htmlbars/tests/system/discover-known-helpers-test.js | @@ -1,4 +1,3 @@
-import isEnabled from 'ember-metal/features';
import Registry from 'container/registry';
import Helper from 'ember-htmlbars/helper';
import { runDestroy } from 'ember-runtime/tests/utils'; | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-routing-htmlbars/lib/keywords/action.js | @@ -3,7 +3,6 @@
@submodule ember-templates
*/
-import isEnabled from 'ember-metal/features';
import { keyword } from 'htmlbars-runtime/hooks';
import closureAction from 'ember-routing-htmlbars/keywords/closure-action';
| true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-routing-htmlbars/lib/keywords/element-action.js | @@ -1,5 +1,4 @@
import Ember from 'ember-metal/core'; // assert
-import isEnabled from 'ember-metal/features';
import { uuid } from 'ember-metal/utils';
import run from 'ember-metal/run_loop';
import { readUnwrappedModel } from 'ember-views/streams/utils'; | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-routing-htmlbars/tests/helpers/closure_action_test.js | @@ -1,4 +1,3 @@
-import isEnabled from 'ember-metal/features';
import run from 'ember-metal/run_loop';
import compile from 'ember-template-compiler/system/compile';
import EmberComponent from 'ember-views/views/component'; | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-routing-htmlbars/tests/helpers/element_action_test.js | @@ -1,5 +1,4 @@
import Ember from 'ember-metal/core'; // A, FEATURES, assert
-import isEnabled from 'ember-metal/features';
import { set } from 'ember-metal/property_set';
import run from 'ember-metal/run_loop';
import EventDispatcher from 'ember-views/system/event_dispatcher'; | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-routing-views/lib/views/link.js | @@ -4,7 +4,6 @@
*/
import Ember from 'ember-metal/core'; // FEATURES, Logger, assert
-import isEnabled from 'ember-metal/features';
import { get } from 'ember-metal/property_get';
import { set } from 'ember-metal/property_set'; | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-routing/lib/system/dsl.js | @@ -1,5 +1,4 @@
import Ember from 'ember-metal/core'; // FEATURES, assert
-import isEnabled from 'ember-metal/features';
/**
@module ember | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-routing/lib/system/router.js | @@ -1,5 +1,4 @@
import Ember from 'ember-metal/core'; // FEATURES, Logger, assert
-import isEnabled from 'ember-metal/features';
import EmberError from 'ember-metal/error';
import { get } from 'ember-metal/property_get';
import { set } from 'ember-metal/property_set'; | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember-routing/tests/system/dsl_test.js | @@ -1,5 +1,4 @@
/* globals EmberDev */
-import isEnabled from 'ember-metal/features';
import EmberRouter from 'ember-routing/system/router';
import { HANDLERS } from 'ember-debug/handlers';
import {
@@ -128,7 +127,7 @@ QUnit.test('should add loading and error routes if _isRouterMapResult is true',
ok(router.rout... | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember/tests/global-api-test.js | @@ -1,6 +1,5 @@
/*globals Ember */
import 'ember';
-import isEnabled from 'ember-metal/features';
QUnit.module('Global API Tests');
| true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember/tests/helpers/helper_registration_test.js | @@ -1,6 +1,5 @@
import 'ember';
import Ember from 'ember-metal/core';
-import isEnabled from 'ember-metal/features';
import helpers from 'ember-htmlbars/helpers';
import { compile } from 'ember-template-compiler';
import Helper, { helper } from 'ember-htmlbars/helper'; | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember/tests/helpers/link_to_test/link_to_transitioning_classes_test.js | @@ -1,37 +1,12 @@
import 'ember';
import Ember from 'ember-metal/core';
-import isEnabled from 'ember-metal/features';
import { compile } from 'ember-template-compiler';
var Router, App, router, registry, container;
var set = Ember.set;
var aboutDefer, otherDefer;
-function basicEagerURLUpdateTest(setTagNam... | true |
Other | emberjs | ember.js | c021a5ae2a6a60245ce45d680c5b1e0d79efc097.json | Remove feature flagging import. | packages/ember/tests/routing/substates_test.js | @@ -1,6 +1,5 @@
import 'ember';
import Ember from 'ember-metal/core';
-import isEnabled from 'ember-metal/features';
import { compile } from 'ember-template-compiler';
import EmberView from 'ember-views/views/view';
| true |
Other | emberjs | ember.js | 0fbdf32544bb29db2a718ccee9245eb60604ebb1.json | Remove feature flags for ember-htmlbars-each-in. | FEATURES.md | @@ -90,33 +90,6 @@ for a detailed explanation.
Enables HTMLBars compiler to interpret `<x-foo></x-foo>` as a component
invocation (instead of a standard HTML5 style element).
-* `ember-htmlbars-each-in`
-
- Adds a helper for enumerating over the properties of an object in a
- Handlebars templates. For example... | true |
Other | emberjs | ember.js | 0fbdf32544bb29db2a718ccee9245eb60604ebb1.json | Remove feature flags for ember-htmlbars-each-in. | features.json | @@ -2,7 +2,6 @@
"features": {
"features-stripped-test": null,
"ember-htmlbars-component-generation": null,
- "ember-htmlbars-each-in": true,
"ember-routing-transitioning-classes": true,
"ember-testing-checkbox-helpers": null,
"ember-metal-stream": null, | true |
Other | emberjs | ember.js | 0fbdf32544bb29db2a718ccee9245eb60604ebb1.json | Remove feature flags for ember-htmlbars-each-in. | packages/ember-htmlbars/lib/helpers/each-in.js | @@ -6,50 +6,48 @@
import isEnabled from 'ember-metal/features';
import shouldDisplay from 'ember-views/streams/should_display';
-if (isEnabled('ember-htmlbars-each-in')) {
- /**
- The `{{each-in}}` helper loops over properties on an object. It is unbound,
- in that new (or removed) properties added to the ta... | true |
Other | emberjs | ember.js | 0fbdf32544bb29db2a718ccee9245eb60604ebb1.json | Remove feature flags for ember-htmlbars-each-in. | packages/ember-htmlbars/lib/main.js | @@ -141,9 +141,7 @@ registerHelper('with', withHelper);
registerHelper('loc', locHelper);
registerHelper('log', logHelper);
registerHelper('each', eachHelper);
-if (isEnabled('ember-htmlbars-each-in')) {
- registerHelper('each-in', eachInHelper);
-}
+registerHelper('each-in', eachInHelper);
registerHelper('-normal... | true |
Other | emberjs | ember.js | 0fbdf32544bb29db2a718ccee9245eb60604ebb1.json | Remove feature flags for ember-htmlbars-each-in. | packages/ember-htmlbars/tests/helpers/each_in_test.js | @@ -23,118 +23,117 @@ function renderTemplate(_template, props) {
runAppend(component);
}
-if (isEnabled('ember-htmlbars-each-in')) {
- QUnit.test('it renders the template for each item in a hash', function(assert) {
- let categories = {
- 'Smartphones': 8203,
- 'JavaScript Frameworks': Infinity
- ... | true |
Other | emberjs | ember.js | 0604db16ea85496b294d31f4289fbf1687924e89.json | Add failing test for top-level {{partial}}
Currently a top-level partial that happens to have a single top-level
element confuses the heuristics in the component hook. | packages/ember-htmlbars/tests/integration/component_invocation_test.js | @@ -1004,11 +1004,25 @@ if (isEnabled('ember-htmlbars-component-generation')) {
});
let el = view.$(style.tagName);
- ok(el, 'precond - the view was rendered');
+ equal(el.length, 1, 'precond - the view was rendered');
+ equal(el.text(), 'In layout');
equal(el.attr('static-prop'), ... | false |
Other | emberjs | ember.js | 92d4854ca35b010541730053eae5810c8fe0a0eb.json | Test all styles of top-level element in <GC>
Previously, we had hardcoded tests for two styles of top-level element
in a GlimmerComponent. For the layout of `<foo-bar>`, we had tests for
the top-level element being `<foo-bar>` itself and being a `<div>`.
A recent commit allowed the top-level element to also be any da... | packages/ember-htmlbars/tests/integration/component_invocation_test.js | @@ -840,250 +840,175 @@ if (isEnabled('ember-htmlbars-component-generation')) {
}, `You cannot use triple curlies (e.g. style={{{ ... }}}) in the top-level element of the <non-block> template because it is a GlimmerComponent.`);
});
- QUnit.test('non-block without properties replaced with a div', function() ... | false |
Other | emberjs | ember.js | 29af9007c04887e0931e96926340a67dd86d1c69.json | Update HTMLBars to 0.14.3. | package.json | @@ -32,7 +32,7 @@
"finalhandler": "^0.4.0",
"github": "^0.2.3",
"glob": "~4.3.2",
- "htmlbars": "0.14.2",
+ "htmlbars": "0.14.3",
"qunit-extras": "^1.3.0",
"qunitjs": "^1.16.0",
"route-recognizer": "0.1.5", | false |
Other | emberjs | ember.js | 64247979b8d112de7a89c259ca3e6edc9061abca.json | Optimize the AST transform for top-level elements
Don’t bother to convert top-level elements into dynamic calls if they
aren’t the top-level element *of a template*.
Consider a template like this:
```
{{#each posts as |post|}}
<div>hello</div>
{{/each}}
```
The previous version of the transform would convert the ne... | packages/ember-template-compiler/lib/plugins/transform-top-level-components.js | @@ -13,7 +13,7 @@ function TransformTopLevelComponents() {
TransformTopLevelComponents.prototype.transform = function TransformTopLevelComponents_transform(ast) {
let b = this.syntax.builders;
- hasSingleComponentNode(ast.body, component => {
+ hasSingleComponentNode(ast, component => {
if (component.type ... | false |
Other | emberjs | ember.js | 87e021a83559001dec692e6872a69ce2752f8f59.json | Make regular elements like identity elements
In Ember 1.x components, the top-level element was configured in
JavaScript using APIs like `classNames`, `attributeBindings`, `tagName`
etc.
Glimmer components move that configuration into a top-level element in
the template. However, the template compiler does not know h... | packages/ember-htmlbars/lib/hooks/component.js | @@ -1,5 +1,5 @@
import ComponentNodeManager from 'ember-htmlbars/node-managers/component-node-manager';
-import buildComponentTemplate from 'ember-views/system/build-component-template';
+import buildComponentTemplate, { buildHTMLTemplate } from 'ember-views/system/build-component-template';
export default function... | true |
Other | emberjs | ember.js | 87e021a83559001dec692e6872a69ce2752f8f59.json | Make regular elements like identity elements
In Ember 1.x components, the top-level element was configured in
JavaScript using APIs like `classNames`, `attributeBindings`, `tagName`
etc.
Glimmer components move that configuration into a top-level element in
the template. However, the template compiler does not know h... | packages/ember-template-compiler/lib/plugins/transform-top-level-components.js | @@ -16,11 +16,20 @@ TransformTopLevelComponents.prototype.transform = function TransformTopLevelComp
hasSingleComponentNode(ast.body, component => {
if (component.type === 'ComponentNode') {
component.tag = `@${component.tag}`;
+ component.isStatic = true;
}
}, element => {
- // TODO: Pro... | true |
Other | emberjs | ember.js | 87e021a83559001dec692e6872a69ce2752f8f59.json | Make regular elements like identity elements
In Ember 1.x components, the top-level element was configured in
JavaScript using APIs like `classNames`, `attributeBindings`, `tagName`
etc.
Glimmer components move that configuration into a top-level element in
the template. However, the template compiler does not know h... | packages/ember-views/lib/system/build-component-template.js | @@ -47,6 +47,30 @@ export default function buildComponentTemplate({ component, tagName, layout, isA
return { createdElement: !!tagName, block: blockToRender };
}
+export function buildHTMLTemplate(tagName, _attrs, content) {
+ let attrs = {};
+
+ for (let prop in _attrs) {
+ let val = _attrs[prop];
+
+ if... | true |
Other | emberjs | ember.js | fc20f0a5205359ca1b01a8403002724dc79af046.json | FIx typo in docs for `mut` helper | packages/ember-htmlbars/lib/keywords/mut.js | @@ -16,7 +16,7 @@ export let MUTABLE_REFERENCE = symbol('MUTABLE_REFERENCE');
/**
The `mut` helper lets you __clearly specify__ that a child `Component` can update the
- (mutable) value passed to it, which will __change the value of the parent compnent__.
+ (mutable) value passed to it, which will __change the ... | false |
Other | emberjs | ember.js | ca436a2b1d4d488a6aeadd9ba7e6ab170e3a5e49.json | WIP: make regular elements like identity elements | packages/ember-htmlbars/lib/hooks/component.js | @@ -12,7 +12,8 @@ export default function componentHook(renderNode, env, scope, _tagName, params,
let tagName = _tagName;
let isAngleBracket = false;
- let isTopLevel;
+ let isTopLevel = false;
+ let isDasherized = false;
let angles = tagName.match(/^(@?)<(.*)>$/);
@@ -22,12 +23,17 @@ export default f... | true |
Other | emberjs | ember.js | ca436a2b1d4d488a6aeadd9ba7e6ab170e3a5e49.json | WIP: make regular elements like identity elements | packages/ember-htmlbars/tests/integration/component_invocation_test.js | @@ -1043,7 +1043,7 @@ if (isEnabled('ember-htmlbars-component-generation')) {
equal(view.$().html(), '<div>This is a</div><div>fragment</div>', 'Just the fragment was used');
});
- QUnit.skip('non-block without properties replaced with a div', function() {
+ QUnit.test('non-block without properties replaced... | true |
Other | emberjs | ember.js | ca436a2b1d4d488a6aeadd9ba7e6ab170e3a5e49.json | WIP: make regular elements like identity elements | packages/ember-template-compiler/lib/plugins/transform-top-level-components.js | @@ -9,14 +9,22 @@ function TransformTopLevelComponents() {
@param {AST} The AST to be transformed.
*/
TransformTopLevelComponents.prototype.transform = function TransformTopLevelComponents_transform(ast) {
+ let b = this.syntax.builders;
+
hasSingleComponentNode(ast.body, component => {
- component.tag = `@... | true |
Other | emberjs | ember.js | ca436a2b1d4d488a6aeadd9ba7e6ab170e3a5e49.json | WIP: make regular elements like identity elements | packages/ember-views/lib/system/build-component-template.js | @@ -6,8 +6,8 @@ import { internal, render } from 'htmlbars-runtime';
import getValue from 'ember-htmlbars/hooks/get-value';
import { isStream } from 'ember-metal/streams/utils';
-export default function buildComponentTemplate({ component, layout, isAngleBracket, isComponentElement, outerAttrs }, attrs, content) {
-... | true |
Other | emberjs | ember.js | f2f09e8d12cc2c8e440eca0582cefd507c5a05a9.json | Skip failing tests for now
Also re-enabling a test that was actually fixed in the previous commit. | packages/ember-htmlbars/tests/integration/component_invocation_test.js | @@ -1043,7 +1043,7 @@ if (isEnabled('ember-htmlbars-component-generation')) {
equal(view.$().html(), '<div>This is a</div><div>fragment</div>', 'Just the fragment was used');
});
- QUnit.test('non-block without properties replaced with a div', function() {
+ QUnit.skip('non-block without properties replaced... | false |
Other | emberjs | ember.js | d280c5353c3031272a3fda59e619e1d8f6fc6e02.json | Remove post-processing ("attributes") hook
This was previously used for attaching outer attributes as well as
system attributes (e.g. class="ember-view" id="ember123") onto regular
HTML elements at the root, once they have been rendered.
This results in multiple AttrNodes for a single attribute, which means
that ther... | packages/ember-htmlbars/lib/env.js | @@ -29,7 +29,6 @@ import lookupHelper from 'ember-htmlbars/hooks/lookup-helper';
import hasHelper from 'ember-htmlbars/hooks/has-helper';
import invokeHelper from 'ember-htmlbars/hooks/invoke-helper';
import element from 'ember-htmlbars/hooks/element';
-import attributes from 'ember-htmlbars/hooks/attributes';
im... | true |
Other | emberjs | ember.js | d280c5353c3031272a3fda59e619e1d8f6fc6e02.json | Remove post-processing ("attributes") hook
This was previously used for attaching outer attributes as well as
system attributes (e.g. class="ember-view" id="ember123") onto regular
HTML elements at the root, once they have been rendered.
This results in multiple AttrNodes for a single attribute, which means
that ther... | packages/ember-htmlbars/lib/hooks/attributes.js | @@ -1,50 +0,0 @@
-import { render, internal } from 'htmlbars-runtime';
-
-export default function attributes(morph, env, scope, template, parentNode, visitor) {
- let state = morph.state;
- let block = state.block;
-
- if (!block) {
- let element = findRootElement(parentNode);
- if (!element) { return; }
-
- ... | true |
Other | emberjs | ember.js | d280c5353c3031272a3fda59e619e1d8f6fc6e02.json | Remove post-processing ("attributes") hook
This was previously used for attaching outer attributes as well as
system attributes (e.g. class="ember-view" id="ember123") onto regular
HTML elements at the root, once they have been rendered.
This results in multiple AttrNodes for a single attribute, which means
that ther... | packages/ember-views/lib/system/build-component-template.js | @@ -1,5 +1,6 @@
import Ember from 'ember-metal/core';
import { get } from 'ember-metal/property_get';
+import assign from 'ember-metal/assign';
import { isGlobal } from 'ember-metal/path_cache';
import { internal, render } from 'htmlbars-runtime';
import getValue from 'ember-htmlbars/hooks/get-value';
@@ -13,10 +1... | true |
Other | emberjs | ember.js | 205a393af9b669e78e3ca196515a453c3d0cdaf0.json | Update QUnit to 1.18.0.
Also includes an update to emberjs-build to ensure the static test page
that is generated contains the correct QUnit version. | bower.json | @@ -6,7 +6,7 @@
},
"dependencies": {
"jquery": "~1.11.1",
- "qunit": "~1.17.1",
+ "qunit": "~1.18.0",
"qunit-phantom-runner": "jonkemp/qunit-phantomjs-runner#1.2.0"
},
"devDependencies": { | true |
Other | emberjs | ember.js | 205a393af9b669e78e3ca196515a453c3d0cdaf0.json | Update QUnit to 1.18.0.
Also includes an update to emberjs-build to ensure the static test page
that is generated contains the correct QUnit version. | package.json | @@ -27,7 +27,7 @@
"ember-cli-sauce": "^1.3.0",
"ember-cli-yuidoc": "0.7.0",
"ember-publisher": "0.0.7",
- "emberjs-build": "0.2.5",
+ "emberjs-build": "0.2.6",
"express": "^4.5.0",
"finalhandler": "^0.4.0",
"github": "^0.2.3", | true |
Other | emberjs | ember.js | a668299bc8dcc922617718d9dc4b63152413cef2.json | Add some new (failing) tests for component bugs | packages/ember-htmlbars/tests/integration/component_invocation_test.js | @@ -1113,7 +1113,7 @@ if (isEnabled('ember-htmlbars-component-generation')) {
equal(view.$('div').attr('class'), 'inner-class new-outer ember-view', 'the classes are merged');
});
- QUnit.test('non-block with class replaced with a identity element merges classes', function() {
+ QUnit.test('non-block with c... | false |
Other | emberjs | ember.js | 361990401342186150f43004eb35f2a83dfc3789.json | Remove incorrect attributes
This code was previously telling HTMLBars to post-process content
templates to add top-level attributes. That is not correct (it only
makes sense to post-process layouts). | packages/ember-views/lib/system/build-component-template.js | @@ -20,8 +20,7 @@ export default function buildComponentTemplate({ component, layout, isAngleBrack
blockToRender = createLayoutBlock(layout.raw, yieldTo, content.self, component, attrs, attributes);
meta = layout.raw.meta;
} else if (content.templates && content.templates.default) {
- let attributes = (... | false |
Other | emberjs | ember.js | 912392ea5d7d5bb607c0914c40b5810dbef3d4bd.json | Show error for component class/invocation mismatch
1. {{my-component ...}} curly braces can only be used on legacy Component
2. <my-component ...> angle brackets can only be used on GlimmerComponent
TBD: rule number 2 might be loosened with an explicit opt-in later,
depending on how painful this transition turns out ... | packages/ember-htmlbars/lib/node-managers/component-node-manager.js | @@ -9,7 +9,8 @@ import setProperties from 'ember-metal/set_properties';
import { MUTABLE_CELL } from 'ember-views/compat/attrs-proxy';
import SafeString from 'htmlbars-util/safe-string';
import { instrument } from 'ember-htmlbars/system/instrumentation-support';
-import EmberComponent from 'ember-views/components/co... | true |
Other | emberjs | ember.js | 912392ea5d7d5bb607c0914c40b5810dbef3d4bd.json | Show error for component class/invocation mismatch
1. {{my-component ...}} curly braces can only be used on legacy Component
2. <my-component ...> angle brackets can only be used on GlimmerComponent
TBD: rule number 2 might be loosened with an explicit opt-in later,
depending on how painful this transition turns out ... | packages/ember-htmlbars/tests/integration/component_invocation_test.js | @@ -65,6 +65,15 @@ QUnit.test('non-block without properties', function() {
equal(jQuery('#qunit-fixture').text(), 'In layout');
});
+QUnit.test('GlimmerComponent cannot be invoked with curly braces', function() {
+ registry.register('template:components/non-block', compile('In layout'));
+ registry.register('co... | true |
Other | emberjs | ember.js | 8dc7d58cd4c0f45cc5aaf79c3ccf03d10dd7445f.json | Fix attr setting in Glimmer Components
Previously, Glimmer components got their attrs set after positional
attrs were applied. The `didInitAttrs` hook was used to indicate that
the full set of attributes were applied.
Recently, positional attrs were changed to ensure that the full set of
attrs are always applied befo... | packages/ember-htmlbars/lib/node-managers/component-node-manager.js | @@ -301,13 +301,13 @@ ComponentNodeManager.prototype.destroy = function() {
export function createComponent(_component, isAngleBracket, _props, renderNode, env, attrs = {}, proto = _component.proto()) {
let props = assign({}, _props);
+ let snapshot = takeSnapshot(attrs);
+ props.attrs = snapshot;
+
if (!isA... | false |
Other | emberjs | ember.js | a6856fdaf25afa4fbdf971a54084874eeece896b.json | Create GlimmerComponent subclass | packages/ember-htmlbars/lib/glimmer-component.js | @@ -1,5 +1,25 @@
-import EmberObject from "ember-runtime/system/object";
+import CoreView from 'ember-views/views/core_view';
+import ViewChildViewsSupport from 'ember-views/mixins/view_child_views_support';
+import ViewStateSupport from 'ember-views/mixins/view_state_support';
+import TemplateRenderingSupport from 'em... | true |
Other | emberjs | ember.js | a6856fdaf25afa4fbdf971a54084874eeece896b.json | Create GlimmerComponent subclass | packages/ember-htmlbars/lib/hooks/bind-self.js | @@ -19,7 +19,13 @@ export default function bindSelf(env, scope, _self) {
if (self && self.isView) {
newStream(scope.locals, 'view', self, null);
newStream(scope.locals, 'controller', scope.locals.view.getKey('controller'));
- newStream(scope, 'self', scope.locals.view.getKey('context'), null, true);
+
+... | true |
Other | emberjs | ember.js | a6856fdaf25afa4fbdf971a54084874eeece896b.json | Create GlimmerComponent subclass | packages/ember-htmlbars/lib/main.js | @@ -54,6 +54,7 @@ import legacyEachWithKeywordHelper from 'ember-htmlbars/helpers/-legacy-each-wit
import htmlSafeHelper from 'ember-htmlbars/helpers/-html-safe';
import DOMHelper from 'ember-htmlbars/system/dom-helper';
import Helper, { helper as makeHelper } from 'ember-htmlbars/helper';
+import GlimmerComponent f... | true |
Other | emberjs | ember.js | a6856fdaf25afa4fbdf971a54084874eeece896b.json | Create GlimmerComponent subclass | packages/ember-htmlbars/tests/glimmer-component/render-test.js | @@ -1,32 +1,34 @@
-import Registry from "container/registry";
-import View from "ember-views/views/view";
-import GlimmerComponent from "ember-htmlbars/glimmer-component";
+import Registry from 'container/registry';
+import View from 'ember-views/views/view';
+import GlimmerComponent from 'ember-htmlbars/glimmer-compon... | true |
Other | emberjs | ember.js | a6856fdaf25afa4fbdf971a54084874eeece896b.json | Create GlimmerComponent subclass | packages/ember-htmlbars/tests/glimmer-component/test-helpers.js | @@ -1,11 +1,9 @@
export function moduleForGlimmerComponent(name, options) {
- let beforeEach = () => {
-
- };
+ function beforeEach() {
+ }
- let afterEach = () => {
-
- };
+ function afterEach() {
+ }
QUnit.module(`Glimmer Component - ${name}`, { beforeEach, afterEach });
} | true |
Other | emberjs | ember.js | a6856fdaf25afa4fbdf971a54084874eeece896b.json | Create GlimmerComponent subclass | packages/ember-htmlbars/tests/integration/component_invocation_test.js | @@ -6,6 +6,7 @@ import jQuery from 'ember-views/system/jquery';
import compile from 'ember-template-compiler/system/compile';
import ComponentLookup from 'ember-views/component_lookup';
import Component from 'ember-views/components/component';
+import GlimmerComponent from 'ember-htmlbars/glimmer-component';
import... | true |
Other | emberjs | ember.js | a6856fdaf25afa4fbdf971a54084874eeece896b.json | Create GlimmerComponent subclass | packages/ember-htmlbars/tests/integration/component_lifecycle_test.js | @@ -3,344 +3,381 @@ import jQuery from 'ember-views/system/jquery';
import compile from 'ember-template-compiler/system/compile';
import ComponentLookup from 'ember-views/component_lookup';
import Component from 'ember-views/components/component';
+import GlimmerComponent from 'ember-htmlbars/glimmer-component';
im... | true |
Other | emberjs | ember.js | a6856fdaf25afa4fbdf971a54084874eeece896b.json | Create GlimmerComponent subclass | packages/ember-views/lib/main.js | @@ -67,7 +67,7 @@ if (Ember.ENV._ENABLE_LEGACY_VIEW_SUPPORT) {
Ember.View.cloneStates = cloneStates;
Ember.View._Renderer = Renderer;
Ember.ContainerView = DeprecatedContainerView;
- Ember.CollectionView = DeprecatedCollectionView;
+ Ember.CollectionView = CollectionView;
}
Ember._Renderer = Renderer; | true |
Other | emberjs | ember.js | a6856fdaf25afa4fbdf971a54084874eeece896b.json | Create GlimmerComponent subclass | packages/ember-views/lib/mixins/legacy_child_views_support.js | @@ -0,0 +1,20 @@
+import { Mixin } from 'ember-metal/mixin';
+import { get } from 'ember-metal/property_get';
+import { set } from 'ember-metal/property_set';
+
+export default Mixin.create({
+ linkChild(instance) {
+ instance.container = this.container;
+ if (get(instance, 'parentView') !== this) {
+ // li... | true |
Other | emberjs | ember.js | a6856fdaf25afa4fbdf971a54084874eeece896b.json | Create GlimmerComponent subclass | packages/ember-views/lib/mixins/legacy_view_support.js | @@ -3,7 +3,7 @@
@submodule ember-views
*/
import Ember from 'ember-metal/core';
-import { Mixin } from 'ember-metal/mixin';
+import { Mixin, observer } from 'ember-metal/mixin';
import { get } from 'ember-metal/property_get';
/**
@@ -100,7 +100,19 @@ var LegacyViewSupport = Mixin.create({
if (view instanc... | true |
Other | emberjs | ember.js | a6856fdaf25afa4fbdf971a54084874eeece896b.json | Create GlimmerComponent subclass | packages/ember-views/lib/mixins/view_child_views_support.js | @@ -125,16 +125,11 @@ export default Mixin.create({
linkChild(instance) {
instance.container = this.container;
- if (get(instance, 'parentView') !== this) {
- // linkChild should be idempotentj
- set(instance, 'parentView', this);
- instance.trigger('parentViewDidChange');
- }
+ instan... | true |
Other | emberjs | ember.js | a6856fdaf25afa4fbdf971a54084874eeece896b.json | Create GlimmerComponent subclass | packages/ember-views/lib/mixins/view_support.js | @@ -0,0 +1,770 @@
+import Ember from 'ember-metal/core';
+import EmberError from 'ember-metal/error';
+import { get } from 'ember-metal/property_get';
+import run from 'ember-metal/run_loop';
+import { addObserver, removeObserver } from 'ember-metal/observer';
+import { guidFor } from 'ember-metal/utils';
+import { com... | true |
Other | emberjs | ember.js | a6856fdaf25afa4fbdf971a54084874eeece896b.json | Create GlimmerComponent subclass | packages/ember-views/lib/views/view.js | @@ -4,23 +4,12 @@
// Ember.ENV
import Ember from 'ember-metal/core';
-import EmberError from 'ember-metal/error';
-import { get } from 'ember-metal/property_get';
-import run from 'ember-metal/run_loop';
-import { addObserver, removeObserver } from 'ember-metal/observer';
-import { guidFor } from 'ember-metal/utils... | true |
Other | emberjs | ember.js | c8f6ecd52885dd4865d9cc3c105da111bd88cd37.json | Remove internal uses of beforeObservers
This refactors array_proxy, collection_view, and container_view to not
depend on beforeObservers. The motivation here is to get us closer to
the point where an app that doesn't use any beforeObservers doesn't need
to pay the performance cost of supporting them. | packages/ember-runtime/lib/system/array_proxy.js | @@ -4,10 +4,7 @@ import {
isArray
} from 'ember-runtime/utils';
import { computed } from 'ember-metal/computed';
-import {
- _beforeObserver,
- observer
-} from 'ember-metal/mixin';
+import { observer } from 'ember-metal/mixin';
import {
beginPropertyChanges,
endPropertyChanges
@@ -77,7 +74,23 @@ var Arra... | true |
Other | emberjs | ember.js | c8f6ecd52885dd4865d9cc3c105da111bd88cd37.json | Remove internal uses of beforeObservers
This refactors array_proxy, collection_view, and container_view to not
depend on beforeObservers. The motivation here is to get us closer to
the point where an app that doesn't use any beforeObservers doesn't need
to pay the performance cost of supporting them. | packages/ember-runtime/tests/system/array_proxy/content_change_test.js | @@ -22,13 +22,11 @@ QUnit.test('The `arrangedContentWillChange` method is invoked before `content` i
var expectedLength;
var proxy = ArrayProxy.extend({
- content: Ember.A([1, 2, 3]),
-
arrangedContentWillChange() {
equal(this.get('arrangedContent.length'), expectedLength, 'hook should be invoked... | true |
Other | emberjs | ember.js | c8f6ecd52885dd4865d9cc3c105da111bd88cd37.json | Remove internal uses of beforeObservers
This refactors array_proxy, collection_view, and container_view to not
depend on beforeObservers. The motivation here is to get us closer to
the point where an app that doesn't use any beforeObservers doesn't need
to pay the performance cost of supporting them. | packages/ember-views/lib/views/collection_view.js | @@ -10,10 +10,7 @@ import EmberArray from 'ember-runtime/mixins/array';
import { get } from 'ember-metal/property_get';
import { set } from 'ember-metal/property_set';
import { computed } from 'ember-metal/computed';
-import {
- observer,
- _beforeObserver
-} from 'ember-metal/mixin';
+import { observer } from 'em... | true |
Other | emberjs | ember.js | c8f6ecd52885dd4865d9cc3c105da111bd88cd37.json | Remove internal uses of beforeObservers
This refactors array_proxy, collection_view, and container_view to not
depend on beforeObservers. The motivation here is to get us closer to
the point where an app that doesn't use any beforeObservers doesn't need
to pay the performance cost of supporting them. | packages/ember-views/lib/views/container_view.js | @@ -4,10 +4,7 @@ import View from 'ember-views/views/view';
import { get } from 'ember-metal/property_get';
import { set } from 'ember-metal/property_set';
-import {
- observer,
- _beforeObserver
-} from 'ember-metal/mixin';
+import { observer } from 'ember-metal/mixin';
import { on } from 'ember-metal/events';
... | true |
Other | emberjs | ember.js | 1e5d5850ded0dc791bb7e960d36df078a28b205a.json | remove duplicate test
Lines 15-34 in the same file already define exactly the same test.
I'm guessing it was just a forgotten copy and paste. | packages/ember-metal/tests/meta_test.js | @@ -33,27 +33,6 @@ QUnit.test('meta is not enumerable', function () {
}
});
-QUnit.test('meta is not enumerable', function () {
- var proto, obj, props, prop;
- proto = { foo: 'bar' };
- meta(proto);
- obj = Object.create(proto);
- meta(obj);
- obj.bar = 'baz';
- props = [];
- for (prop in obj) {
- pro... | false |
Other | emberjs | ember.js | 714f0b8b7d4c95d18b561845493cc031d182eec7.json | use empty object | packages/ember-metal/lib/meta.js | @@ -5,6 +5,7 @@
import isEnabled from 'ember-metal/features';
import { protoMethods as listenerMethods } from 'ember-metal/meta_listeners';
+import EmptyObject from 'ember-metal/empty_object';
/**
@module ember-metal
@@ -84,7 +85,7 @@ function ownMap(name, Meta) {
Meta.prototype._getOrCreateOwnMap = function(k... | false |
Other | emberjs | ember.js | c64b3166dc1d2855266ec2b86a03ec2d786398f1.json | fix silly unnecessary defProp | packages/ember-metal/lib/meta.js | @@ -268,20 +268,25 @@ export function meta(obj, writable) {
return ret || EMPTY_META;
}
- if (obj.__defineNonEnumerable) {
- obj.__defineNonEnumerable(EMBER_META_PROPERTY);
- } else {
- Object.defineProperty(obj, '__ember_meta__', META_DESC);
+ if (ret && ret.source === obj) {
+ return ret;
}
... | false |
Other | emberjs | ember.js | 84a0a50b618da480588cf0c9e60e0fcd9785fdc3.json | remove outdated comment | packages/ember-metal/lib/meta.js | @@ -99,8 +99,7 @@ function getOrCreateOwnMap(key) {
}
// Implements a member that is a lazily created POJO with inheritable
-// values. For member `thing` you get methods `getThing`,
-// `getOrCreateThing`, and `peekThing`.
+// values.
function inheritedMap(name, Meta) {
let key = memberProperty(name);
let c... | false |
Other | emberjs | ember.js | c4b3bceaf6d94a73d1c251bbacc5682474ec989c.json | point everything at the new meta module | packages/ember-metal/lib/alias.js | @@ -7,10 +7,8 @@ import {
defineProperty
} from 'ember-metal/properties';
import { ComputedProperty } from 'ember-metal/computed';
-import {
- meta,
- inspect
-} from 'ember-metal/utils';
+import { inspect } from 'ember-metal/utils';
+import { meta } from 'ember-metal/meta';
import {
addDependentKeys,
rem... | true |
Other | emberjs | ember.js | c4b3bceaf6d94a73d1c251bbacc5682474ec989c.json | point everything at the new meta module | packages/ember-metal/lib/chains.js | @@ -1,6 +1,6 @@
import Ember from 'ember-metal/core'; // warn, assert, etc;
import { get, normalizeTuple } from 'ember-metal/property_get';
-import { meta as metaFor } from 'ember-metal/utils';
+import { meta as metaFor } from 'ember-metal/meta';
import { watchKey, unwatchKey } from 'ember-metal/watch_key';
var F... | true |
Other | emberjs | ember.js | c4b3bceaf6d94a73d1c251bbacc5682474ec989c.json | point everything at the new meta module | packages/ember-metal/lib/computed.js | @@ -1,9 +1,7 @@
import Ember from 'ember-metal/core';
import { set } from 'ember-metal/property_set';
-import {
- meta,
- inspect
-} from 'ember-metal/utils';
+import { inspect } from 'ember-metal/utils';
+import { meta } from 'ember-metal/meta';
import expandProperties from 'ember-metal/expand_properties';
impor... | true |
Other | emberjs | ember.js | c4b3bceaf6d94a73d1c251bbacc5682474ec989c.json | point everything at the new meta module | packages/ember-metal/lib/events.js | @@ -9,10 +9,10 @@
*/
import Ember from 'ember-metal/core';
import {
- meta as metaFor,
apply,
applyStr
} from 'ember-metal/utils';
+import { meta as metaFor } from 'ember-metal/meta';
/* listener flags */
var ONCE = 1; | true |
Other | emberjs | ember.js | c4b3bceaf6d94a73d1c251bbacc5682474ec989c.json | point everything at the new meta module | packages/ember-metal/lib/meta.js | @@ -18,17 +18,29 @@ import isEnabled from 'ember-metal/features';
`writable` variants will give you a mutable object, and they will
create it if it didn't already exist.
+ The following methods will get generated metaprogrammatically, and
+ I'm including them here for greppability:
+
+ writableCache, readableCach... | true |
Other | emberjs | ember.js | c4b3bceaf6d94a73d1c251bbacc5682474ec989c.json | point everything at the new meta module | packages/ember-metal/lib/mixin.js | @@ -14,10 +14,10 @@ import { get } from 'ember-metal/property_get';
import { set, trySet } from 'ember-metal/property_set';
import {
guidFor,
- meta as metaFor,
wrap,
makeArray
} from 'ember-metal/utils';
+import { meta as metaFor } from 'ember-metal/meta';
import expandProperties from 'ember-metal/expand... | true |
Other | emberjs | ember.js | c4b3bceaf6d94a73d1c251bbacc5682474ec989c.json | point everything at the new meta module | packages/ember-metal/lib/properties.js | @@ -4,7 +4,7 @@
import Ember from 'ember-metal/core';
import isEnabled from 'ember-metal/features';
-import { meta as metaFor } from 'ember-metal/utils';
+import { meta as metaFor } from 'ember-metal/meta';
import { overrideChains } from 'ember-metal/property_events';
// ............................................. | true |
Other | emberjs | ember.js | c4b3bceaf6d94a73d1c251bbacc5682474ec989c.json | point everything at the new meta module | packages/ember-metal/lib/utils.js | @@ -3,8 +3,6 @@
//
'REMOVE_USE_STRICT: true';
-import { meta } from 'ember-metal/meta';
-
/**
@module ember-metal
*/
@@ -500,6 +498,5 @@ export function applyStr(t, m, a) {
export {
GUID_KEY,
makeArray,
- canInvoke,
- meta // this is temporary until I can refactor all the import sites
+ canInvoke
}; | true |
Other | emberjs | ember.js | c4b3bceaf6d94a73d1c251bbacc5682474ec989c.json | point everything at the new meta module | packages/ember-metal/lib/watch_key.js | @@ -1,7 +1,7 @@
import isEnabled from 'ember-metal/features';
import {
meta as metaFor
-} from 'ember-metal/utils';
+} from 'ember-metal/meta';
import {
MANDATORY_SETTER_FUNCTION,
DEFAULT_GETTER_FUNCTION | true |
Other | emberjs | ember.js | c4b3bceaf6d94a73d1c251bbacc5682474ec989c.json | point everything at the new meta module | packages/ember-metal/lib/watch_path.js | @@ -1,6 +1,6 @@
import {
meta as metaFor
-} from 'ember-metal/utils';
+} from 'ember-metal/meta';
import { ChainNode } from 'ember-metal/chains';
// get the chains for the current object. If the current object has | true |
Other | emberjs | ember.js | c4b3bceaf6d94a73d1c251bbacc5682474ec989c.json | point everything at the new meta module | packages/ember-metal/tests/accessors/mandatory_setters_test.js | @@ -2,7 +2,7 @@ import isEnabled from 'ember-metal/features';
import { get } from 'ember-metal/property_get';
import { set } from 'ember-metal/property_set';
import { watch } from 'ember-metal/watching';
-import { meta as metaFor } from 'ember-metal/utils';
+import { meta as metaFor } from 'ember-metal/meta';
QUn... | true |
Other | emberjs | ember.js | c4b3bceaf6d94a73d1c251bbacc5682474ec989c.json | point everything at the new meta module | packages/ember-metal/tests/alias_test.js | @@ -2,7 +2,7 @@ import alias from 'ember-metal/alias';
import { defineProperty } from 'ember-metal/properties';
import { get } from 'ember-metal/property_get';
import { set } from 'ember-metal/property_set';
-import { meta } from 'ember-metal/utils';
+import { meta } from 'ember-metal/meta';
import { isWatching } f... | true |
Other | emberjs | ember.js | c4b3bceaf6d94a73d1c251bbacc5682474ec989c.json | point everything at the new meta module | packages/ember-metal/tests/events_test.js | @@ -1,5 +1,5 @@
import { Mixin } from 'ember-metal/mixin';
-import { meta } from 'ember-metal/utils';
+import { meta } from 'ember-metal/meta';
import {
on, | true |
Other | emberjs | ember.js | c4b3bceaf6d94a73d1c251bbacc5682474ec989c.json | point everything at the new meta module | packages/ember-metal/tests/meta_test.js | @@ -61,7 +61,7 @@ QUnit.skip('meta.listeners basics', function(assert) {
let matching = m.matchingListeners(e => e.eventName === 'hello');
assert.equal(matching.length, 1);
assert.equal(matching[0].target, t);
- m.removeFromListeners({ eventName: 'hello', target: t, method: 'm'});
+ m.removeFromListeners({ e... | true |
Other | emberjs | ember.js | c4b3bceaf6d94a73d1c251bbacc5682474ec989c.json | point everything at the new meta module | packages/ember-runtime/lib/mixins/-proxy.js | @@ -6,7 +6,7 @@
import Ember from 'ember-metal/core'; // Ember.assert
import { get } from 'ember-metal/property_get';
import { set } from 'ember-metal/property_set';
-import { meta } from 'ember-metal/utils';
+import { meta } from 'ember-metal/meta';
import {
addObserver,
removeObserver, | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.