language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | videojs | video.js | 61e20786a975f0555829635fcfb591794cc8cdef.json | docs: fix links in generated docs (#4200) | docs/guides/setup.md | @@ -82,7 +82,7 @@ videojs(document.querySelector('.video-js'));
## Options
-> **Note:** This guide only covers how to pass options during player setup. For a complete reference on _all_ available options, see the [options guide](options.md).
+> **Note:** This guide only covers how to pass options during player set... | true |
Other | videojs | video.js | 61e20786a975f0555829635fcfb591794cc8cdef.json | docs: fix links in generated docs (#4200) | docs/guides/text-tracks.md | @@ -91,7 +91,7 @@ The boolean `default` attribute can be used to indicate that a track's mode shou
The valid [BCP 47](https://tools.ietf.org/html/bcp47) code for the language of the text track, e.g. `"en"` for English or `"es"` for Spanish.
-For supported language translations, please see the [languages folder (/l... | true |
Other | videojs | video.js | 61e20786a975f0555829635fcfb591794cc8cdef.json | docs: fix links in generated docs (#4200) | docs/guides/tracks.md | @@ -8,14 +8,14 @@ There are currently three types of tracks:
* [Video Tracks](#video-tracks)
* [Text Tracks](#text-tracks)
-## [Audio Tracks](./audio-tracks.md)
+## [Audio Tracks](/docs/guides/audio-tracks.md)
Audio tracks allow the selection of alternate audio for a video.
-## [Video Tracks](./video-tracks.md... | true |
Other | videojs | video.js | 61e20786a975f0555829635fcfb591794cc8cdef.json | docs: fix links in generated docs (#4200) | docs/guides/troubleshooting.md | @@ -91,7 +91,7 @@ To fix this issue please make sure that all event listeners are cleaned up on di
[hosting-media]: #problems-when-hosting-media
-[text-tracks]: text-tracks.md
+[text-tracks]: /docs/guides/text-tracks.md
[hls]: https://github.com/videojs/videojs-contrib-hls
| true |
Other | videojs | video.js | 61e20786a975f0555829635fcfb591794cc8cdef.json | docs: fix links in generated docs (#4200) | docs/guides/video-tracks.md | @@ -83,7 +83,7 @@ player.videoTracks().removeTrack(track);
## API
-For more complete information, refer to the [Video.js API docs](http://docs.videojs.com/docs/api/index.html), specifically:
+For more complete information, refer to the [Video.js API docs](http://docs.videojs.com/), specifically:
* `Player#video... | true |
Other | videojs | video.js | 61e20786a975f0555829635fcfb591794cc8cdef.json | docs: fix links in generated docs (#4200) | docs/guides/videojs.md | @@ -128,7 +128,7 @@ videojs.bind(someObj, function() {
## `plugin()`
-**See the [plugin guide](plugins.md) in the docs for a more detailed example**
+**See the [plugin guide](/docs/guides/plugins.md) in the docs for a more detailed example**
```js
// Make a plugin that alerts when the player plays | true |
Other | videojs | video.js | 61e20786a975f0555829635fcfb591794cc8cdef.json | docs: fix links in generated docs (#4200) | docs/index.md | @@ -1,6 +1,6 @@
# [Video.js][vjs-website] Documentation
-There are two categories of docs: [Guides](guides) and [API docs][api].
+There are two categories of docs: [Guides](/docs/guides/) and [API docs][api].
Guides explain general topics and use cases (e.g. setup). API docs are automatically generated from the c... | true |
Other | videojs | video.js | 61e20786a975f0555829635fcfb591794cc8cdef.json | docs: fix links in generated docs (#4200) | docs/translations-needed.md | @@ -5,13 +5,15 @@ The currently available translations are in the lang dir. This table shows the c
If you add or update a translation run `grunt check-translations` to update the list and include this modified doc in the pull request.
## Progress Bar Translations
+
The progress bar as a translation with a few toke... | true |
Other | videojs | video.js | 61e20786a975f0555829635fcfb591794cc8cdef.json | docs: fix links in generated docs (#4200) | package.json | @@ -26,7 +26,9 @@
"test": "grunt test",
"docs": "npm run docs:lint && npm run docs:api",
"jsdoc": "jsdoc",
+ "predocs:api": "node -e \"var s=require('shelljs'),d=['docs/api'];s.rm('-rf',d);\"",
"docs:api": "jsdoc -c .jsdoc.json",
+ "postdocs:api": "node ./build/fix-api-docs.js",
"docs:lin... | true |
Other | videojs | video.js | 61e20786a975f0555829635fcfb591794cc8cdef.json | docs: fix links in generated docs (#4200) | src/js/player.js | @@ -2957,9 +2957,9 @@ class Player extends Component {
*
* @param {boolean} [manualCleanup=true] if set to false, the TextTrack will be
*
- * @return {HTMLTrackElement}
+ * @return {HtmlTrackElement}
* the HTMLTrackElement that was created and added
- * to the HTMLTrackElementList ... | true |
Other | videojs | video.js | 61e20786a975f0555829635fcfb591794cc8cdef.json | docs: fix links in generated docs (#4200) | src/js/setup.js | @@ -88,7 +88,7 @@ const autoSetup = function() {
* @param {number} wait
* How long to wait in ms
*
- * @param {videojs} [vjs]
+ * @param {module:videojs} [vjs]
* The videojs library function
*/
function autoSetupTimeout(wait, vjs) { | true |
Other | videojs | video.js | 61e20786a975f0555829635fcfb591794cc8cdef.json | docs: fix links in generated docs (#4200) | src/js/tech/tech.js | @@ -879,9 +879,9 @@ class Tech extends Component {
*/
/**
- * Get the remote element {@link HTMLTrackElementList}
+ * Get the remote element {@link HtmlTrackElementList}
*
- * @returns {HTMLTrackElementList}
+ * @returns {HtmlTrackElementList}
* @method Tech.prototype.remoteTextTrackEls
*/
| true |
Other | videojs | video.js | 61e20786a975f0555829635fcfb591794cc8cdef.json | docs: fix links in generated docs (#4200) | src/js/tracks/html-track-element-list.js | @@ -32,7 +32,7 @@ class HtmlTrackElementList {
list.trackElements_ = [];
/**
- * @memberof HTMLTrackElementList
+ * @memberof HtmlTrackElementList
* @member {number} length
* The current number of `Track`s in the this Trackist.
* @instance | true |
Other | videojs | video.js | 61e20786a975f0555829635fcfb591794cc8cdef.json | docs: fix links in generated docs (#4200) | src/js/tracks/track-types.js | @@ -1,7 +1,7 @@
import AudioTrackList from './audio-track-list';
import VideoTrackList from './video-track-list';
import TextTrackList from './text-track-list';
-import HTMLTrackElementList from './html-track-element-list';
+import HtmlTrackElementList from './html-track-element-list';
import TextTrack from './te... | true |
Other | videojs | video.js | 61e20786a975f0555829635fcfb591794cc8cdef.json | docs: fix links in generated docs (#4200) | src/js/utils/dom.js | @@ -509,7 +509,7 @@ export function getBoundingClientRect(el) {
/**
* The postion of a DOM element on the page.
*
- * @typedef {Object} Dom~Position
+ * @typedef {Object} module:dom~Position
*
* @property {number} left
* Pixels to the left
@@ -528,7 +528,7 @@ export function getBoundingClientRect(e... | true |
Other | videojs | video.js | 61e20786a975f0555829635fcfb591794cc8cdef.json | docs: fix links in generated docs (#4200) | src/js/video.js | @@ -55,8 +55,6 @@ if (typeof HTMLVideoElement === 'undefined' && Dom.isReal()) {
*
* @return {Player}
* A player instance
- *
- * @mixes videojs
*/
function videojs(id, options, ready) {
let tag;
@@ -136,6 +134,7 @@ videojs.hooks_ = {};
/**
* Get a list of hooks for a specific lifecycle
+ * @fu... | true |
Other | videojs | video.js | 88ee6af4310c93e73950a2b0fd8c105678bda338.json | fix(subs-caps-button): add hide threshold to subs-caps button (#4171)
This is a followup from #4157 but for the subs-caps button. | src/js/control-bar/text-track-controls/subs-caps-button.js | @@ -40,33 +40,6 @@ class SubsCapsButton extends TextTrackButton {
return `vjs-subs-caps-button ${super.buildWrapperCSSClass()}`;
}
- /**
- * Update caption menu items
- *
- * @param {EventTarget~Event} [event]
- * The `addtrack` or `removetrack` event that caused this function to be
- * ... | false |
Other | videojs | video.js | c611f9f3585c6023819e7174b2251c2a6800309f.json | fix(MenuButton): Unify behavior of showing/hiding (#4157)
Implement a `hideThreshold` property that defaults to 1 so
descendants can override it if necessary. Right now the only
descendant that will override will be `CaptionsButton` because
video.js adds a "captions settings" for emulated text tracks. | src/js/control-bar/text-track-controls/captions-button.js | @@ -42,33 +42,6 @@ class CaptionsButton extends TextTrackButton {
return `vjs-captions-button ${super.buildWrapperCSSClass()}`;
}
- /**
- * Update caption menu items
- *
- * @param {EventTarget~Event} [event]
- * The `addtrack` or `removetrack` event that caused this function to be
- * ... | true |
Other | videojs | video.js | c611f9f3585c6023819e7174b2251c2a6800309f.json | fix(MenuButton): Unify behavior of showing/hiding (#4157)
Implement a `hideThreshold` property that defaults to 1 so
descendants can override it if necessary. Right now the only
descendant that will override will be `CaptionsButton` because
video.js adds a "captions settings" for emulated text tracks. | src/js/control-bar/text-track-controls/text-track-button.js | @@ -57,6 +57,8 @@ class TextTrackButton extends TrackButton {
label
}));
+ this.hideThreshold_ += 1;
+
const tracks = this.player_.textTracks();
for (let i = 0; i < tracks.length; i++) { | true |
Other | videojs | video.js | c611f9f3585c6023819e7174b2251c2a6800309f.json | fix(MenuButton): Unify behavior of showing/hiding (#4157)
Implement a `hideThreshold` property that defaults to 1 so
descendants can override it if necessary. Right now the only
descendant that will override will be `CaptionsButton` because
video.js adds a "captions settings" for emulated text tracks. | src/js/menu/menu-button.js | @@ -75,9 +75,9 @@ class MenuButton extends Component {
this.buttonPressed_ = false;
this.menuButton_.el_.setAttribute('aria-expanded', 'false');
- if (this.items && this.items.length === 0) {
+ if (this.items && this.items.length <= this.hideThreshold_) {
this.hide();
- } else if (this.items... | true |
Other | videojs | video.js | e5af0a5e21575323fe93ce849caf09a7c5e1a38b.json | fix(subs-caps-button): add wrapper CSS builder to subs caps button (#4156) | src/js/control-bar/text-track-controls/subs-caps-button.js | @@ -35,6 +35,10 @@ class SubsCapsButton extends TextTrackButton {
return `vjs-subs-caps-button ${super.buildCSSClass()}`;
}
+ buildWrapperCSSClass() {
+ return `vjs-subs-caps-button ${super.buildWrapperCSSClass()}`;
+ }
+
/**
* Update caption menu items
* | false |
Other | videojs | video.js | 74eb5d4772ff6d7a98d7ecaf84f595d6870fe303.json | feat: Combine captions and subtitles tracks control (#4028) | sandbox/combined-tracks.html.example | @@ -0,0 +1,68 @@
+<!DOCTYPE html>
+<html lang="en-GB">
+<head>
+ <meta charset="utf-8" />
+ <title>Video.js Sandbox</title>
+
+ <!-- Add ES5 shim and sham for IE8 -->
+ <script src="../build/temp/ie8/videojs-ie8.js"></script>
+
+ <!-- Load the source files -->
+ <link href="../build/temp/video-js.css" rel="styles... | true |
Other | videojs | video.js | 74eb5d4772ff6d7a98d7ecaf84f595d6870fe303.json | feat: Combine captions and subtitles tracks control (#4028) | src/css/components/_subs-caps.scss | @@ -0,0 +1,22 @@
+// North America uses 'CC' icon
+.video-js:lang(en) .vjs-subs-caps-button .vjs-icon-placeholder,
+.video-js:lang(fr-CA) .vjs-subs-caps-button .vjs-icon-placeholder {
+ @extend .vjs-icon-captions;
+}
+
+// ROW uses 'subtitles'
+// Double selector because @extend puts these rules above the captions ico... | true |
Other | videojs | video.js | 74eb5d4772ff6d7a98d7ecaf84f595d6870fe303.json | feat: Combine captions and subtitles tracks control (#4028) | src/css/video-js.scss | @@ -36,6 +36,7 @@
@import "components/chapters";
@import "components/descriptions";
@import "components/subtitles";
+@import "components/subs-caps";
@import "components/audio";
@import "components/adaptive";
@import "components/captions-settings"; | true |
Other | videojs | video.js | 74eb5d4772ff6d7a98d7ecaf84f595d6870fe303.json | feat: Combine captions and subtitles tracks control (#4028) | src/js/control-bar/control-bar.js | @@ -17,6 +17,7 @@ import './text-track-controls/chapters-button.js';
import './text-track-controls/descriptions-button.js';
import './text-track-controls/subtitles-button.js';
import './text-track-controls/captions-button.js';
+import './text-track-controls/subs-caps-button.js';
import './audio-track-controls/audio... | true |
Other | videojs | video.js | 74eb5d4772ff6d7a98d7ecaf84f595d6870fe303.json | feat: Combine captions and subtitles tracks control (#4028) | src/js/control-bar/text-track-controls/off-text-track-menu-item.js | @@ -26,11 +26,21 @@ class OffTextTrackMenuItem extends TextTrackMenuItem {
options.track = {
player,
kind: options.kind,
- label: options.kind + ' off',
+ kinds: options.kinds,
default: false,
mode: 'disabled'
};
+ if (!options.kinds) {
+ options.kinds = [option... | true |
Other | videojs | video.js | 74eb5d4772ff6d7a98d7ecaf84f595d6870fe303.json | feat: Combine captions and subtitles tracks control (#4028) | src/js/control-bar/text-track-controls/subs-caps-button.js | @@ -0,0 +1,102 @@
+/**
+ * @file sub-caps-button.js
+ */
+import TextTrackButton from './text-track-button.js';
+import Component from '../../component.js';
+import CaptionSettingsMenuItem from './caption-settings-menu-item.js';
+import toTitleCase from '../../utils/to-title-case.js';
+/**
+ * The button component for ... | true |
Other | videojs | video.js | 74eb5d4772ff6d7a98d7ecaf84f595d6870fe303.json | feat: Combine captions and subtitles tracks control (#4028) | src/js/control-bar/text-track-controls/text-track-button.js | @@ -26,6 +26,10 @@ class TextTrackButton extends TrackButton {
options.tracks = player.textTracks();
super(player, options);
+
+ if (!Array.isArray(this.kinds_)) {
+ this.kinds_ = [this.kind_];
+ }
}
/**
@@ -38,21 +42,36 @@ class TextTrackButton extends TrackButton {
* Array o... | true |
Other | videojs | video.js | 74eb5d4772ff6d7a98d7ecaf84f595d6870fe303.json | feat: Combine captions and subtitles tracks control (#4028) | src/js/control-bar/text-track-controls/text-track-menu-item.js | @@ -83,8 +83,13 @@ class TextTrackMenuItem extends MenuItem {
*/
handleClick(event) {
const kind = this.track.kind;
+ let kinds = this.track.kinds;
const tracks = this.player_.textTracks();
+ if (!kinds) {
+ kinds = [kind];
+ }
+
super.handleClick(event);
if (!tracks) {
@@ -... | true |
Other | videojs | video.js | 74eb5d4772ff6d7a98d7ecaf84f595d6870fe303.json | feat: Combine captions and subtitles tracks control (#4028) | test/unit/tracks/text-track-controls.test.js | @@ -25,7 +25,7 @@ QUnit.test('should be displayed when text tracks list is not empty', function(as
this.clock.tick(1000);
- assert.ok(!player.controlBar.captionsButton.hasClass('vjs-hidden'),
+ assert.ok(!player.controlBar.subsCapsButton.hasClass('vjs-hidden'),
'control is displayed');
assert.eq... | true |
Other | videojs | video.js | 74eb5d4772ff6d7a98d7ecaf84f595d6870fe303.json | feat: Combine captions and subtitles tracks control (#4028) | test/unit/tracks/text-tracks.test.js | @@ -3,6 +3,7 @@ import ChaptersButton from '../../../src/js/control-bar/text-track-controls/chap
import DescriptionsButton from '../../../src/js/control-bar/text-track-controls/descriptions-button.js';
import SubtitlesButton from '../../../src/js/control-bar/text-track-controls/subtitles-button.js';
import CaptionsB... | true |
Other | videojs | video.js | 4388beae910013f98e0647891df695d0a0a48270.json | feat: add a controlText function to MenuButton (#4125) | src/js/menu/menu-button.js | @@ -176,6 +176,24 @@ class MenuButton extends Component {
return `vjs-menu-button ${menuButtonClass} ${super.buildCSSClass()}`;
}
+ /**
+ * Get or set the localized control text that will be used for accessibility.
+ *
+ * > NOTE: This will come from the internal `menuButton_` element.
+ *
+ * @par... | false |
Other | videojs | video.js | 0d0dea4da820a75f7e8190d99b7838c250bb3a9d.json | feat: fix accessibility of the captions setting dialog (#4050)
This fixes a lot of the issues from #2746 by making the dialog inherit from our actual ModalDialog which now has tab focus trapping.
The Captions Settings dialog has some accessibility issues:
- Field labels and fields are not explicitly associated
- ... | docs/translations-needed.md | @@ -9,7 +9,7 @@ If you add or update a translation run `grunt check-translations` to update the
<!-- START langtable -->
| Language file | Missing translations |
| ----------------------- | ------------------------------------------------------... | true |
Other | videojs | video.js | 0d0dea4da820a75f7e8190d99b7838c250bb3a9d.json | feat: fix accessibility of the captions setting dialog (#4050)
This fixes a lot of the issues from #2746 by making the dialog inherit from our actual ModalDialog which now has tab focus trapping.
The Captions Settings dialog has some accessibility issues:
- Field labels and fields are not explicitly associated
- ... | lang/de.json | @@ -70,7 +70,6 @@
"Casual": "Zwanglos",
"Script": "Schreibeschrift",
"Small Caps": "Small-Caps",
- "Defaults": "Standardeinstellungen",
"Done": "Fertig",
"Caption Settings Dialog": "Einstellungsdialog für Untertitel",
"Beginning of dialog window. Escape will cancel and close the window.": "Anfang des... | true |
Other | videojs | video.js | 0d0dea4da820a75f7e8190d99b7838c250bb3a9d.json | feat: fix accessibility of the captions setting dialog (#4050)
This fixes a lot of the issues from #2746 by making the dialog inherit from our actual ModalDialog which now has tab focus trapping.
The Captions Settings dialog has some accessibility issues:
- Field labels and fields are not explicitly associated
- ... | lang/en.json | @@ -74,8 +74,10 @@
"Casual": "Casual",
"Script": "Script",
"Small Caps": "Small Caps",
- "Defaults": "Defaults",
+ "Reset": "Reset",
+ "all settings to the default values": "all settings to the default values",
"Done": "Done",
"Caption Settings Dialog": "Caption Settings Dialog",
- "Beginning of dial... | true |
Other | videojs | video.js | 0d0dea4da820a75f7e8190d99b7838c250bb3a9d.json | feat: fix accessibility of the captions setting dialog (#4050)
This fixes a lot of the issues from #2746 by making the dialog inherit from our actual ModalDialog which now has tab focus trapping.
The Captions Settings dialog has some accessibility issues:
- Field labels and fields are not explicitly associated
- ... | lang/fr.json | @@ -75,7 +75,6 @@
"Casual": "Manuscrite",
"Script": "Scripte",
"Small Caps": "Petites capitales",
- "Defaults": "Valeurs par défaut",
"Done": "Terminé",
"Caption Settings Dialog": "Boîte de dialogue des paramètres des sous-titres transcrits",
"Beginning of dialog window. Escape will cancel and close ... | true |
Other | videojs | video.js | 0d0dea4da820a75f7e8190d99b7838c250bb3a9d.json | feat: fix accessibility of the captions setting dialog (#4050)
This fixes a lot of the issues from #2746 by making the dialog inherit from our actual ModalDialog which now has tab focus trapping.
The Captions Settings dialog has some accessibility issues:
- Field labels and fields are not explicitly associated
- ... | lang/tr.json | @@ -70,7 +70,6 @@
"Casual": "Gündelik",
"Script": "El Yazısı",
"Small Caps": "Küçük Boyutlu Büyük Harfli",
- "Defaults": "Varsayılan Ayarlar",
"Done": "Tamam",
"Caption Settings Dialog": "Altyazı Ayarları Menüsü",
"Beginning of dialog window. Escape will cancel and close the window.": "Diyalog pencer... | true |
Other | videojs | video.js | 0d0dea4da820a75f7e8190d99b7838c250bb3a9d.json | feat: fix accessibility of the captions setting dialog (#4050)
This fixes a lot of the issues from #2746 by making the dialog inherit from our actual ModalDialog which now has tab focus trapping.
The Captions Settings dialog has some accessibility issues:
- Field labels and fields are not explicitly associated
- ... | src/css/components/_captions-settings.scss | @@ -1,19 +1,18 @@
-.vjs-caption-settings {
+.vjs-modal-dialog.vjs-text-track-settings {
position: relative;
top: 1em;
background-color: $primary-background-color;
background-color: rgba($primary-background-color, 0.75);
color: $primary-foreground-color;
margin: 0 auto;
padding: 0.5em;
- height: 16... | true |
Other | videojs | video.js | 0d0dea4da820a75f7e8190d99b7838c250bb3a9d.json | feat: fix accessibility of the captions setting dialog (#4050)
This fixes a lot of the issues from #2746 by making the dialog inherit from our actual ModalDialog which now has tab focus trapping.
The Captions Settings dialog has some accessibility issues:
- Field labels and fields are not explicitly associated
- ... | src/css/video-js.scss | @@ -8,6 +8,7 @@
@import "components/big-play";
@import "components/button";
@import "components/close-button";
+@import "components/modal-dialog";
@import "components/menu/menu";
@import "components/menu/menu-popup";
@@ -38,6 +39,5 @@
@import "components/audio";
@import "components/adaptive";
@import "compone... | true |
Other | videojs | video.js | 0d0dea4da820a75f7e8190d99b7838c250bb3a9d.json | feat: fix accessibility of the captions setting dialog (#4050)
This fixes a lot of the issues from #2746 by making the dialog inherit from our actual ModalDialog which now has tab focus trapping.
The Captions Settings dialog has some accessibility issues:
- Field labels and fields are not explicitly associated
- ... | src/js/control-bar/text-track-controls/caption-settings-menu-item.js | @@ -50,8 +50,7 @@ class CaptionSettingsMenuItem extends TextTrackMenuItem {
* @listens click
*/
handleClick(event) {
- this.player().getChild('textTrackSettings').show();
- this.player().getChild('textTrackSettings').el_.focus();
+ this.player().getChild('textTrackSettings').open();
}
} | true |
Other | videojs | video.js | 0d0dea4da820a75f7e8190d99b7838c250bb3a9d.json | feat: fix accessibility of the captions setting dialog (#4050)
This fixes a lot of the issues from #2746 by making the dialog inherit from our actual ModalDialog which now has tab focus trapping.
The Captions Settings dialog has some accessibility issues:
- Field labels and fields are not explicitly associated
- ... | src/js/modal-dialog.js | @@ -70,7 +70,7 @@ class ModalDialog extends Component {
});
this.descEl_ = Dom.createEl('p', {
- className: `${MODAL_CLASS_NAME}-description vjs-offscreen`,
+ className: `${MODAL_CLASS_NAME}-description vjs-control-text`,
id: this.el().getAttribute('aria-describedby')
});
| true |
Other | videojs | video.js | 0d0dea4da820a75f7e8190d99b7838c250bb3a9d.json | feat: fix accessibility of the captions setting dialog (#4050)
This fixes a lot of the issues from #2746 by making the dialog inherit from our actual ModalDialog which now has tab focus trapping.
The Captions Settings dialog has some accessibility issues:
- Field labels and fields are not explicitly associated
- ... | src/js/tracks/text-track-settings.js | @@ -2,7 +2,9 @@
* @file text-track-settings.js
*/
import window from 'global/window';
+import document from 'global/document';
import Component from '../component';
+import ModalDialog from '../modal-dialog';
import {createEl} from '../utils/dom';
import * as Fn from '../utils/fn';
import * as Obj from '../uti... | true |
Other | videojs | video.js | 0d0dea4da820a75f7e8190d99b7838c250bb3a9d.json | feat: fix accessibility of the captions setting dialog (#4050)
This fixes a lot of the issues from #2746 by making the dialog inherit from our actual ModalDialog which now has tab focus trapping.
The Captions Settings dialog has some accessibility issues:
- Field labels and fields are not explicitly associated
- ... | test/unit/modal-dialog.test.js | @@ -126,7 +126,7 @@ QUnit.test('should create the expected description element', function(assert) {
innerHTML: this.modal.description(),
classes: [
'vjs-modal-dialog-description',
- 'vjs-offscreen'
+ 'vjs-control-text'
],
attrs: {
id: this.el.getAttribute('aria-describedby') | true |
Other | videojs | video.js | 127cd7827eeed8e3a9b46613cf50dc8f16517bcd.json | fix: copy basic plugin properties onto the wrapper (#4100)
Copy basic plugin properties to prevent breaking older basic plugins. | src/js/plugin.js | @@ -88,17 +88,25 @@ const markPluginAsActive = (player, name) => {
* @returns {Function}
* A wrapper function for the given plugin.
*/
-const createBasicPlugin = (name, plugin) => function() {
- const instance = plugin.apply(this, arguments);
+const createBasicPlugin = function(name, plugin) {
+ const ... | true |
Other | videojs | video.js | 127cd7827eeed8e3a9b46613cf50dc8f16517bcd.json | fix: copy basic plugin properties onto the wrapper (#4100)
Copy basic plugin properties to prevent breaking older basic plugins. | test/unit/plugin-basic.test.js | @@ -38,6 +38,13 @@ QUnit.test('setup', function(assert) {
assert.deepEqual(this.basic.firstCall.args, [{foo: 'bar'}, 123], 'the plugin had the correct arguments');
assert.ok(this.player.usingPlugin('basic'), 'the player now recognizes that the plugin was set up');
assert.ok(this.player.hasPlugin('basic'), 'pla... | true |
Other | videojs | video.js | 405b29b8f194c4d5d29534eaf7ebd872486451cb.json | fix: remove redundant Html5#play()
play() is defined twice in Html5. The promise handling in the earlier one was moved into Player#play(). | src/js/tech/html5.js | @@ -341,19 +341,6 @@ class Html5 extends Tech {
});
}
- /**
- * Called by {@link Player#play} to play using the `Html5` `Tech`.
- */
- play() {
- const playPromise = this.el_.play();
-
- // Catch/silence error when a pause interrupts a play request
- // on browsers which return a promise
- i... | true |
Other | videojs | video.js | 405b29b8f194c4d5d29534eaf7ebd872486451cb.json | fix: remove redundant Html5#play()
play() is defined twice in Html5. The promise handling in the earlier one was moved into Player#play(). | test/unit/tech/html5.test.js | @@ -647,23 +647,6 @@ QUnit.test('Html5#reset calls Html5.resetMediaElement when called', function(ass
Html5.resetMediaElement = oldResetMedia;
});
-QUnit.test('Exception in play promise should be caught', function() {
- const oldEl = tech.el_;
-
- tech.el_ = {
- play: () => {
- return new Promise(functi... | true |
Other | videojs | video.js | 65dc81a4e1b94e28b4e64ece66a51e447a6d18a7.json | docs: Add MediaLoader to components list (#4070) | docs/guides/components.md | @@ -285,6 +285,7 @@ The default component structure of the Video.js player looks something like this
```tree
Player
+├── MediaLoader (has no UI)
├── PosterImage
├── TextTrackDisplay
├── LoadingSpinner | false |
Other | videojs | video.js | 55408683fb375c1855eb251b68c446049c805f82.json | fix: Solve a typo in translation files (#4063)
"subititles settings" ->"subtitles settings" | lang/de.json | @@ -33,7 +33,7 @@
", opens subtitles settings dialog": ", öffnet Einstellungen für Untertitel",
", selected": ", ausgewählt",
"captions settings": "Untertiteleinstellungen",
- "subititles settings": "Untertiteleinstellungen",
+ "subtitles settings": "Untertiteleinstellungen",
"descriptions settings": "Ein... | true |
Other | videojs | video.js | 55408683fb375c1855eb251b68c446049c805f82.json | fix: Solve a typo in translation files (#4063)
"subititles settings" ->"subtitles settings" | lang/en.json | @@ -43,7 +43,7 @@
", opens descriptions settings dialog": ", opens descriptions settings dialog",
", selected": ", selected",
"captions settings": "captions settings",
- "subititles settings": "subititles settings",
+ "subtitles settings": "subititles settings",
"descriptions settings": "descriptions sett... | true |
Other | videojs | video.js | 55408683fb375c1855eb251b68c446049c805f82.json | fix: Solve a typo in translation files (#4063)
"subititles settings" ->"subtitles settings" | lang/tr.json | @@ -39,7 +39,7 @@
", opens descriptions settings dialog": ", açıklama ayarları menüsünü açar",
", selected": ", seçildi",
"captions settings": "altyazı ayarları",
- "subititles settings": "altyazı ayarları",
+ "subtitles settings": "altyazı ayarları",
"descriptions settings": "açıklama ayarları",
"Text... | true |
Other | videojs | video.js | dc4c1eb88b68006d564446c16a6bb5ddcbad424a.json | fix: improve French translation (#4062)
Improved translation of "Casual" | docs/translations-needed.md | @@ -540,46 +540,7 @@ If you add or update a translation run `grunt check-translations` to update the
| | Done |
| | Caption Settings Dialog ... | true |
Other | videojs | video.js | dc4c1eb88b68006d564446c16a6bb5ddcbad424a.json | fix: improve French translation (#4062)
Improved translation of "Casual" | lang/fr.json | @@ -1,4 +1,6 @@
{
+ "Audio Player": "Lecteur audio",
+ "Video Player": "Lecteur vidéo",
"Play": "Lecture",
"Pause": "Pause",
"Replay": "Revoir",
@@ -9,6 +11,7 @@
"LIVE": "EN DIRECT",
"Loaded": "Chargé",
"Progress": "Progression",
+ "Progress Bar": "Barre de progression",
"Fullscreen": "Plein éc... | true |
Other | videojs | video.js | 7ab52d1a59f088a31dc7c145931594c43f5fb913.json | docs: replace 'autoPlay' by 'autoplay' (#4080)
Fix #3995 | docs/guides/react.md | @@ -41,7 +41,7 @@ You can then use it like this:
```jsx
// see https://github.com/videojs/video.js/blob/master/docs/guides/options.md
const videoJsOptions = {
- autoPlay: true,
+ autoplay: true,
controls: true,
sources: [{
src: '/path/to/video.mp4', | false |
Other | videojs | video.js | 2433915c64bacc87262450e66969e7fd6da00b18.json | docs(guides): fix typos in faq guide (#4067)
offical > official | docs/guides/faq.md | @@ -237,7 +237,7 @@ project which adds support.
## Q: Does video.js support MPEG Dash video?
-video.js itself does not support MPEG DASH, however an offical project called [videojs-contrib-dash][dash]
+video.js itself does not support MPEG DASH, however an official project called [videojs-contrib-dash][dash]
adds... | false |
Other | videojs | video.js | 6541467ad8e3ce11ace391e36253b269a47b61ff.json | fix: support empty src in `Player#src` (#4030)
Remove some unnecessary code. Filter the input to remove empty objects and what not. | src/js/player.js | @@ -28,6 +28,7 @@ import ModalDialog from './modal-dialog';
import Tech from './tech/tech.js';
import * as middleware from './tech/middleware.js';
import {ALL as TRACK_TYPES} from './tracks/track-types';
+import filterSource from './utils/filter-source';
// The following imports are used only to ensure that the c... | true |
Other | videojs | video.js | 6541467ad8e3ce11ace391e36253b269a47b61ff.json | fix: support empty src in `Player#src` (#4030)
Remove some unnecessary code. Filter the input to remove empty objects and what not. | src/js/utils/filter-source.js | @@ -0,0 +1,49 @@
+/**
+ * @module filter-source
+ */
+import {isObject} from './obj';
+
+/**
+ * Filter out single bad source objects or multiple source objects in an
+ * array. Also flattens nested source object arrays into a 1 dimensional
+ * array of source objects.
+ *
+ * @param {Tech~SourceObject|Tech~SourceObjec... | true |
Other | videojs | video.js | 6541467ad8e3ce11ace391e36253b269a47b61ff.json | fix: support empty src in `Player#src` (#4030)
Remove some unnecessary code. Filter the input to remove empty objects and what not. | test/unit/utils/filter-source.test.js | @@ -0,0 +1,124 @@
+/* eslint-env qunit */
+import filterSource from '../../../src/js/utils/filter-source';
+
+QUnit.module('utils/filter-source');
+
+QUnit.test('invalid sources', function(assert) {
+ assert.deepEqual(filterSource(null), [], 'null source is filtered to []');
+ assert.deepEqual(filterSource(undefined)... | true |
Other | videojs | video.js | 0fc2c1c7a45137c23bfb0443cdee1a5b0be14967.json | docs(guides): fix typos in functions guide (#4035) | docs/guides/videojs.md | @@ -43,9 +43,9 @@ var VjsButton = videojs.getComponent('Button');
// Subclass the component (see 'extend' doc for more info)
var MySpecialButton = videojs.extend(VjsButton, {});
// Register the new component
-VjsButton.registerComponent('MySepcialButton', MySepcialButton);
+videojs.registerComponent('MySpecialButton... | false |
Other | videojs | video.js | e176b56843b2084c8b0c985d9ea491b5de1da113.json | feat: Expose Tech#resize event as Player#resize (#3979)
Rename Component's resize event to `componentresize` and trigger the Html5 specced resize event on the player. | src/js/component.js | @@ -790,7 +790,7 @@ class Component {
* The width that you want to set postfixed with '%', 'px' or nothing.
*
* @param {boolean} [skipListeners]
- * Skip the resize event trigger
+ * Skip the componentresize event trigger
*
* @return {number|string}
* The width w... | true |
Other | videojs | video.js | e176b56843b2084c8b0c985d9ea491b5de1da113.json | feat: Expose Tech#resize event as Player#resize (#3979)
Rename Component's resize event to `componentresize` and trigger the Html5 specced resize event on the player. | src/js/player.js | @@ -191,6 +191,22 @@ const TECH_EVENTS_RETRIGGER = [
*/
'ratechange',
+ /**
+ * Fires when the video's intrinsic dimensions change
+ *
+ * @event Player#resize
+ * @type {event}
+ */
+ /**
+ * Retrigger the `resize` event that was triggered by the {@link Tech}.
+ *
+ * @private
+ * @method ... | true |
Other | videojs | video.js | e176b56843b2084c8b0c985d9ea491b5de1da113.json | feat: Expose Tech#resize event as Player#resize (#3979)
Rename Component's resize event to `componentresize` and trigger the Html5 specced resize event on the player. | src/js/tech/html5.js | @@ -848,6 +848,7 @@ Html5.Events = [
'play',
'pause',
'ratechange',
+ 'resize',
'volumechange'
];
| true |
Other | videojs | video.js | fcb5aa83833829826b81d66f80620ee98c03f863.json | test: add tests for obj.assign util (#4014) | test/unit/utils/obj.test.js | @@ -105,3 +105,117 @@ QUnit.test('isPlain', function(assert) {
'string': 'xyz'
});
});
+
+QUnit.module('utils/obj.assign', function() {
+ const assignTests = ['mocked'];
+
+ // we only run "normal" tests where Object.assign is used when
+ // Object.assign is supported
+ if (Object.assign) {
+ assignTest... | false |
Other | videojs | video.js | 2da4e76ef01723172d10fcc078fb6399b76c9ee4.json | docs: Expand testing info in `CONTRIBUTING.md` (#4020) | CONTRIBUTING.md | @@ -140,13 +140,17 @@ npm install
#### Running tests
-To run the tests all you need to do is run
+Tests can be run either from the shell or from the browser.
+
+To run the tests from the shell, just run
```sh
npm test
```
-This will build video.js locally and run the tests using [Karma](https://karma-runner... | false |
Other | videojs | video.js | 49496195edb570fb8ee19240de77cc1b265f9f01.json | chore: Add flash as a dev dependency for testing (#4016)
Add videojs-flash to devDependencies and update sandbox examples to use flash | package.json | @@ -121,7 +121,8 @@
"uglify-js": "~2.7.3",
"videojs-doc-generator": "0.0.1",
"videojs-standard": "^6.0.1",
- "webpack": "^1.13.2"
+ "webpack": "^1.13.2",
+ "videojs-flash": "^1.0.0-RC.0"
},
"vjsstandard": {
"ignore": [ | true |
Other | videojs | video.js | 49496195edb570fb8ee19240de77cc1b265f9f01.json | chore: Add flash as a dev dependency for testing (#4016)
Add videojs-flash to devDependencies and update sandbox examples to use flash | sandbox/flash.html.example | @@ -0,0 +1,45 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+ <meta charset="utf-8" />
+ <title>Video.js Sandbox</title>
+
+ <!-- Add ES5 shim and sham for IE8 -->
+ <script src="../build/temp/ie8/videojs-ie8.js"></script>
+
+ <!-- Load the source files -->
+ <link href="../build/temp/video-js.css" rel="styleshee... | true |
Other | videojs | video.js | 49496195edb570fb8ee19240de77cc1b265f9f01.json | chore: Add flash as a dev dependency for testing (#4016)
Add videojs-flash to devDependencies and update sandbox examples to use flash | sandbox/index.html.example | @@ -10,6 +10,7 @@
<!-- Load the source files -->
<link href="../build/temp/video-js.css" rel="stylesheet" type="text/css">
<script src="../build/temp/video.js"></script>
+ <script src="../node_modules/videojs-flash/dist/videojs-flash.js"></script>
<!-- Set the location of the flash SWF -->
<script>
@@... | true |
Other | videojs | video.js | 24d2e7ba33a385f1bf1dcacdbbfeb1f87489e512.json | fix: hide font-icons from assitive technology (#4006)
Wrap font-icons in a span with aria-hidden=true on it.
Fixes #3982. | src/css/components/_audio.scss | @@ -1,3 +1,3 @@
-.video-js .vjs-audio-button {
+.video-js .vjs-audio-button .vjs-icon-placeholder {
@extend .vjs-icon-audio;
} | true |
Other | videojs | video.js | 24d2e7ba33a385f1bf1dcacdbbfeb1f87489e512.json | fix: hide font-icons from assitive technology (#4006)
Wrap font-icons in a span with aria-hidden=true on it.
Fixes #3982. | src/css/components/_big-play.scss | @@ -17,11 +17,11 @@
@include border-radius(0.3em);
@include transition(all 0.4s);
- @extend .vjs-icon-play;
-
// Since the big play button doesn't inherit from vjs-control, we need to specify a bit more than
// other buttons for the icon.
- &:before {
+ & .vjs-icon-placeholder:before {
+ @extend .vj... | true |
Other | videojs | video.js | 24d2e7ba33a385f1bf1dcacdbbfeb1f87489e512.json | fix: hide font-icons from assitive technology (#4006)
Wrap font-icons in a span with aria-hidden=true on it.
Fixes #3982. | src/css/components/_captions.scss | @@ -1,3 +1,3 @@
-.video-js .vjs-captions-button {
+.video-js .vjs-captions-button .vjs-icon-placeholder {
@extend .vjs-icon-captions;
} | true |
Other | videojs | video.js | 24d2e7ba33a385f1bf1dcacdbbfeb1f87489e512.json | fix: hide font-icons from assitive technology (#4006)
Wrap font-icons in a span with aria-hidden=true on it.
Fixes #3982. | src/css/components/_chapters.scss | @@ -1,4 +1,4 @@
-.video-js .vjs-chapters-button {
+.video-js .vjs-chapters-button .vjs-icon-placeholder {
@extend .vjs-icon-chapters;
}
| true |
Other | videojs | video.js | 24d2e7ba33a385f1bf1dcacdbbfeb1f87489e512.json | fix: hide font-icons from assitive technology (#4006)
Wrap font-icons in a span with aria-hidden=true on it.
Fixes #3982. | src/css/components/_close-button.scss | @@ -1,5 +1,8 @@
.video-js .vjs-control.vjs-close-button {
- @extend .vjs-icon-cancel;
+ & .vjs-icon-placeholder {
+ @extend .vjs-icon-cancel;
+ }
+
cursor: pointer;
height: 3em;
position: absolute; | true |
Other | videojs | video.js | 24d2e7ba33a385f1bf1dcacdbbfeb1f87489e512.json | fix: hide font-icons from assitive technology (#4006)
Wrap font-icons in a span with aria-hidden=true on it.
Fixes #3982. | src/css/components/_control.scss | @@ -10,7 +10,7 @@
width: 4em;
@include flex(none);
- &:before {
+ & .vjs-icon-placeholder:before {
font-size: 1.8em;
line-height: 1.67;
| true |
Other | videojs | video.js | 24d2e7ba33a385f1bf1dcacdbbfeb1f87489e512.json | fix: hide font-icons from assitive technology (#4006)
Wrap font-icons in a span with aria-hidden=true on it.
Fixes #3982. | src/css/components/_descriptions.scss | @@ -1,3 +1,3 @@
-.video-js .vjs-descriptions-button {
+.video-js .vjs-descriptions-button .vjs-icon-placeholder {
@extend .vjs-icon-audio-description;
} | true |
Other | videojs | video.js | 24d2e7ba33a385f1bf1dcacdbbfeb1f87489e512.json | fix: hide font-icons from assitive technology (#4006)
Wrap font-icons in a span with aria-hidden=true on it.
Fixes #3982. | src/css/components/_fullscreen.scss | @@ -1,9 +1,12 @@
.video-js .vjs-fullscreen-control {
cursor: pointer;
@include flex(none);
- @extend .vjs-icon-fullscreen-enter;
+
+ & .vjs-icon-placeholder {
+ @extend .vjs-icon-fullscreen-enter;
+ }
}
// Switch to the exit icon when the player is in fullscreen
-.video-js.vjs-fullscreen .vjs-fullscreen-... | true |
Other | videojs | video.js | 24d2e7ba33a385f1bf1dcacdbbfeb1f87489e512.json | fix: hide font-icons from assitive technology (#4006)
Wrap font-icons in a span with aria-hidden=true on it.
Fixes #3982. | src/css/components/_play-pause.scss | @@ -1,11 +1,11 @@
-.video-js .vjs-play-control {
+.video-js .vjs-play-control .vjs-icon-placeholder {
cursor: pointer;
@include flex(none);
@extend .vjs-icon-play;
}
-.video-js .vjs-play-control.vjs-playing {
+.video-js .vjs-play-control.vjs-playing .vjs-icon-placeholder {
@extend .vjs-icon-pause;
}
-.vid... | true |
Other | videojs | video.js | 24d2e7ba33a385f1bf1dcacdbbfeb1f87489e512.json | fix: hide font-icons from assitive technology (#4006)
Wrap font-icons in a span with aria-hidden=true on it.
Fixes #3982. | src/css/components/_subtitles.scss | @@ -1,3 +1,3 @@
-.video-js .vjs-subtitles-button {
+.video-js .vjs-subtitles-button .vjs-icon-placeholder {
@extend .vjs-icon-subtitles;
} | true |
Other | videojs | video.js | 24d2e7ba33a385f1bf1dcacdbbfeb1f87489e512.json | fix: hide font-icons from assitive technology (#4006)
Wrap font-icons in a span with aria-hidden=true on it.
Fixes #3982. | src/css/components/_volume.scss | @@ -1,21 +1,24 @@
.video-js .vjs-mute-control {
cursor: pointer;
@include flex(none);
- @extend .vjs-icon-volume-high;
// padding here is for IE < 9, it doesn't do width: auto from
// another style correctly
padding-left: 2em;
padding-right: 2em;
padding-bottom: 3em;
+
+ & .vjs-icon-placeholder ... | true |
Other | videojs | video.js | 24d2e7ba33a385f1bf1dcacdbbfeb1f87489e512.json | fix: hide font-icons from assitive technology (#4006)
Wrap font-icons in a span with aria-hidden=true on it.
Fixes #3982. | src/js/button.js | @@ -33,6 +33,7 @@ class Button extends ClickableComponent {
tag = 'button';
props = assign({
+ innerHTML: '<span aria-hidden="true" class="vjs-icon-placeholder"></span>',
className: this.buildCSSClass()
}, props);
| true |
Other | videojs | video.js | 24d2e7ba33a385f1bf1dcacdbbfeb1f87489e512.json | fix: hide font-icons from assitive technology (#4006)
Wrap font-icons in a span with aria-hidden=true on it.
Fixes #3982. | src/js/clickable-component.js | @@ -51,6 +51,7 @@ class ClickableComponent extends Component {
*/
createEl(tag = 'div', props = {}, attributes = {}) {
props = assign({
+ innerHTML: '<span aria-hidden="true" class="vjs-icon-placeholder"></span>',
className: this.buildCSSClass(),
tabIndex: 0
}, props); | true |
Other | videojs | video.js | 05b39fe281c4b299207334dd1da3cdbcbbc36c78.json | docs(guides): Add a basic ReactJS guide and update the FAQ (#3972) | docs/guides/faq.md | @@ -38,6 +38,7 @@
* [Q: Does video.js have any support for advertisement integrations?](#q-does-videojs-have-any-support-for-advertisement-integrations)
* [Q: Can video.js be required in node.js?](#q-can-videojs-be-required-in-nodejs)
* [Q: Does video.js work with webpack?](#q-does-videojs-work-with-webpack)
+* [Q: ... | true |
Other | videojs | video.js | 05b39fe281c4b299207334dd1da3cdbcbbc36c78.json | docs(guides): Add a basic ReactJS guide and update the FAQ (#3972) | docs/guides/player-workflows.md | @@ -367,6 +367,8 @@ Coming soon...
### React
+See [ReactJS integration example](./react.md)
+
### Ember
### Angular | true |
Other | videojs | video.js | 05b39fe281c4b299207334dd1da3cdbcbbc36c78.json | docs(guides): Add a basic ReactJS guide and update the FAQ (#3972) | docs/guides/react.md | @@ -0,0 +1,55 @@
+# video.js and ReactJS integration
+
+Here's a basic ReactJS player implementation.
+
+It just instantiates the video.js player on `componentDidMount` and destroys it on `componentWillUnmount`.
+
+```jsx
+import React from 'react';
+import videojs from 'video.js'
+
+export default class VideoPlayer ex... | true |
Other | videojs | video.js | 7b0d738e8f8d8eefbd68d155f4ad082315ff5dfb.json | docs(guide): Add a `ModalDialog` guide (#3961) | docs/guides/modal-dialog.md | @@ -0,0 +1,78 @@
+# Using the Modal Dialog Component
+
+The `ModalDialog` component is part of Video.js core and provides a baked-in UI for full-player overlays.
+
+## Table of Contents
+
+* [Creating the ModalDialog](#creating-the-modaldialog)
+ * [Example Using createModal()](#example-using-createmodal)
+ * [Exampl... | false |
Other | videojs | video.js | 8888e2b5b542ea20887b4b7513ccc7f7bdd380e1.json | feat(lang): add European Portuguese translation (#3955) | docs/translations-needed.md | @@ -271,6 +271,7 @@ If you add or update a translation run `grunt check-translations` to update the
| | , opens subtitles settings dialog |
| | , opens descriptions settings dialog ... | true |
Other | videojs | video.js | 8888e2b5b542ea20887b4b7513ccc7f7bdd380e1.json | feat(lang): add European Portuguese translation (#3955) | lang/pt-PT.json | @@ -0,0 +1,41 @@
+{
+ "Play": "Reproduzir",
+ "Pause": "Parar",
+ "Replay": "Reiniciar",
+ "Current Time": "Tempo Atual",
+ "Duration Time": "Duração",
+ "Remaining Time": "Tempo Restante",
+ "Stream Type": "Tipo de Stream",
+ "LIVE": "EM DIRETO",
+ "Loaded": "Carregado",
+ "Progress": "Progresso",
+ "Fullsc... | true |
Other | videojs | video.js | 1463e50f7b4a68f8af10cafced64250202b9920b.json | feat(lang): update Vietnamese lang file (#3964) | docs/translations-needed.md | @@ -310,21 +310,7 @@ If you add or update a translation run `grunt check-translations` to update the
| | The media is encrypted and we do not have the keys to decrypt it. |
| | , opens descriptions settings dialog ... | true |
Other | videojs | video.js | 1463e50f7b4a68f8af10cafced64250202b9920b.json | feat(lang): update Vietnamese lang file (#3964) | lang/vi.json | @@ -1,6 +1,7 @@
{
"Play": "Phát",
"Pause": "Tạm dừng",
+ "Replay": "Phát lại",
"Current Time": "Thời gian hiện tại",
"Duration Time": "Độ dài",
"Remaining Time": "Thời gian còn lại",
@@ -12,15 +13,29 @@
"Non-Fullscreen": "Thoát toàn màn hình",
"Mute": "Tắt tiếng",
"Unmute": "Bật âm thanh",
- ... | true |
Other | videojs | video.js | 58f23493025f3490257655919c91d0442a39d338.json | docs: fix broken links to guides in the faq (#3973) | docs/faq.md | @@ -269,17 +269,17 @@ Yes! Please [submit an issue or open a pull request][pr-issue-question] if this
Yes! Please [submit an issue or open a pull request][pr-issue-question] if this does not work.
-[plugin-guide]: plugins.md
+[plugin-guide]: ./guides/plugins.md
[install-guide]: http://videojs.com/getting-starte... | false |
Other | videojs | video.js | b387437aedc83e362740a42f92b1245ee91b8ec2.json | feat: remove flash tech (#3956)
Remove Flash Tech from core. Use videojs-flash if flash is needed.
Also, update DOM method names.
BREAKING CHANGE: remove flash tech from core. | package.json | @@ -41,7 +41,6 @@
"tsml": "1.0.1",
"videojs-font": "2.0.0",
"videojs-ie8": "1.1.2",
- "videojs-swf": "5.1.0",
"videojs-vtt.js": "0.12.1",
"xhr": "2.2.2"
}, | true |
Other | videojs | video.js | b387437aedc83e362740a42f92b1245ee91b8ec2.json | feat: remove flash tech (#3956)
Remove Flash Tech from core. Use videojs-flash if flash is needed.
Also, update DOM method names.
BREAKING CHANGE: remove flash tech from core. | src/js/component.js | @@ -5,6 +5,7 @@
*/
import window from 'global/window';
import * as Dom from './utils/dom.js';
+import * as DomData from './utils/dom-data';
import * as Fn from './utils/fn.js';
import * as Guid from './utils/guid.js';
import * as Events from './utils/events.js';
@@ -141,7 +142,7 @@ class Component {
this.... | true |
Other | videojs | video.js | b387437aedc83e362740a42f92b1245ee91b8ec2.json | feat: remove flash tech (#3956)
Remove Flash Tech from core. Use videojs-flash if flash is needed.
Also, update DOM method names.
BREAKING CHANGE: remove flash tech from core. | src/js/control-bar/mute-toggle.js | @@ -88,9 +88,9 @@ class MuteToggle extends Button {
// TODO improve muted icon classes
for (let i = 0; i < 4; i++) {
- Dom.removeElClass(this.el_, `vjs-vol-${i}`);
+ Dom.removeClass(this.el_, `vjs-vol-${i}`);
}
- Dom.addElClass(this.el_, `vjs-vol-${level}`);
+ Dom.addClass(this.el_, `vj... | true |
Other | videojs | video.js | b387437aedc83e362740a42f92b1245ee91b8ec2.json | feat: remove flash tech (#3956)
Remove Flash Tech from core. Use videojs-flash if flash is needed.
Also, update DOM method names.
BREAKING CHANGE: remove flash tech from core. | src/js/menu/menu-button.js | @@ -83,7 +83,7 @@ class MenuButton extends ClickableComponent {
});
menu.children_.unshift(title);
- Dom.insertElFirst(title, menu.contentEl());
+ Dom.prependTo(title, menu.contentEl());
}
this.items = this.createItems(); | true |
Other | videojs | video.js | b387437aedc83e362740a42f92b1245ee91b8ec2.json | feat: remove flash tech (#3956)
Remove Flash Tech from core. Use videojs-flash if flash is needed.
Also, update DOM method names.
BREAKING CHANGE: remove flash tech from core. | src/js/player.js | @@ -31,7 +31,6 @@ import {ALL as TRACK_TYPES} from './tracks/track-types';
// are always included in the video.js package. Importing the modules will
// execute them and they will register themselves with video.js.
import './tech/loader.js';
-import './tech/flash.js';
import './poster-image.js';
import './tracks/t... | true |
Other | videojs | video.js | b387437aedc83e362740a42f92b1245ee91b8ec2.json | feat: remove flash tech (#3956)
Remove Flash Tech from core. Use videojs-flash if flash is needed.
Also, update DOM method names.
BREAKING CHANGE: remove flash tech from core. | src/js/tech/flash-rtmp.js | @@ -1,199 +0,0 @@
-/**
- * @file flash-rtmp.js
- * @module flash-rtmp
- */
-
-/**
- * Add RTMP properties to the {@link Flash} Tech.
- *
- * @param {Flash} Flash
- * The flash tech class.
- *
- * @mixin FlashRtmpDecorator
- */
-function FlashRtmpDecorator(Flash) {
- Flash.streamingFormats = {
- 'rtmp/mp4': '... | true |
Other | videojs | video.js | b387437aedc83e362740a42f92b1245ee91b8ec2.json | feat: remove flash tech (#3956)
Remove Flash Tech from core. Use videojs-flash if flash is needed.
Also, update DOM method names.
BREAKING CHANGE: remove flash tech from core. | src/js/tech/flash.js | @@ -1,1078 +0,0 @@
-/**
- * @file flash.js
- * VideoJS-SWF - Custom Flash Player with HTML5-ish API
- * https://github.com/zencoder/video-js-swf
- * Not using setupTriggers. Using global onEvent func to distribute events
- */
-
-import Tech from './tech';
-import * as Dom from '../utils/dom.js';
-import * as Url from '... | true |
Other | videojs | video.js | b387437aedc83e362740a42f92b1245ee91b8ec2.json | feat: remove flash tech (#3956)
Remove Flash Tech from core. Use videojs-flash if flash is needed.
Also, update DOM method names.
BREAKING CHANGE: remove flash tech from core. | src/js/tech/html5.js | @@ -214,14 +214,14 @@ class Html5 extends Tech {
el = document.createElement('video');
// determine if native controls should be used
- const tagAttributes = this.options_.tag && Dom.getElAttributes(this.options_.tag);
+ const tagAttributes = this.options_.tag && Dom.getAttributes(this... | true |
Other | videojs | video.js | b387437aedc83e362740a42f92b1245ee91b8ec2.json | feat: remove flash tech (#3956)
Remove Flash Tech from core. Use videojs-flash if flash is needed.
Also, update DOM method names.
BREAKING CHANGE: remove flash tech from core. | src/js/utils/dom-data.js | @@ -0,0 +1,98 @@
+/**
+ * @file dom-data.js
+ * @module dom-data
+ */
+import * as Guid from './guid.js';
+
+/**
+ * Element Data Store.
+ *
+ * Allows for binding data to an element without putting it directly on the
+ * element. Ex. Event listeners are stored here.
+ * (also from jsninja.com, slightly modified and up... | true |
Other | videojs | video.js | b387437aedc83e362740a42f92b1245ee91b8ec2.json | feat: remove flash tech (#3956)
Remove Flash Tech from core. Use videojs-flash if flash is needed.
Also, update DOM method names.
BREAKING CHANGE: remove flash tech from core. | src/js/utils/dom.js | @@ -4,7 +4,6 @@
*/
import document from 'global/document';
import window from 'global/window';
-import * as Guid from './guid.js';
import log from './log.js';
import tsml from 'tsml';
import {isObject} from './obj';
@@ -110,24 +109,6 @@ function createQuerier(method) {
};
}
-/**
- * Shorthand for document.... | true |
Other | videojs | video.js | b387437aedc83e362740a42f92b1245ee91b8ec2.json | feat: remove flash tech (#3956)
Remove Flash Tech from core. Use videojs-flash if flash is needed.
Also, update DOM method names.
BREAKING CHANGE: remove flash tech from core. | src/js/utils/events.js | @@ -7,7 +7,7 @@
* @module events
*/
-import * as Dom from './dom.js';
+import * as DomData from './dom-data';
import * as Guid from './guid.js';
import log from './log.js';
import window from 'global/window';
@@ -23,7 +23,7 @@ import document from 'global/document';
* Type of event to clean up
*/
f... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.