language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
videojs
video.js
ba0f20ec3548a8069e9a9a907978ed50246e8ada.json
feat: add support for debug logging (#4780) Adds support for `debug` as an available logging method under `videojs.log` Changes the default log level from `all` to `info`
test/unit/utils/log.test.js
@@ -18,6 +18,8 @@ QUnit.module('utils/log', { // // Instead we'll temporarily replace them with no-op functions window.console = { + debug: sinon.spy(), + info: sinon.spy(), log: sinon.spy(), warn: sinon.spy(), error: sinon.spy() @@ -47,6 +49,7 @@ QUnit.test('logging functi...
true
Other
videojs
video.js
51ed400d7c034069708fdb604927febd8d639140.json
fix: use correct logic for menu focus (#4823) This was resulting in the menu not being focused for all browsers/devices (if the player was in a frame), but it should target only IOS. Fixes #4821
src/js/menu/menu-button.js
@@ -344,9 +344,12 @@ class MenuButton extends Component { // set the focus into the submenu, except on iOS where it is resulting in // undesired scrolling behavior when the player is in an iframe - if (!IS_IOS && !Dom.isInFrame()) { - this.menu.focus(); + if (IS_IOS && Dom.isInFrame()) ...
false
Other
videojs
video.js
295889b36b15d9f4b296384c347b780bfb8d42e2.json
chore: remove unused popup classes (#4792) In v6, we moved away from popup due to accessibility reasons. It was only used in the old VolumeMenuButton. Fixes #4725.
src/js/popup/popup-button.js
@@ -1,89 +0,0 @@ -/** - * @file popup-button.js - */ -import ClickableComponent from '../clickable-component.js'; -import Component from '../component.js'; - -/** - * A button class for use with {@link Popup} controls - * - * @extends ClickableComponent - */ -class PopupButton extends ClickableComponent { - - /** - ...
true
Other
videojs
video.js
295889b36b15d9f4b296384c347b780bfb8d42e2.json
chore: remove unused popup classes (#4792) In v6, we moved away from popup due to accessibility reasons. It was only used in the old VolumeMenuButton. Fixes #4725.
src/js/popup/popup.js
@@ -1,68 +0,0 @@ -/** - * @file popup.js - */ -import Component from '../component.js'; -import * as Dom from '../utils/dom.js'; -import * as Fn from '../utils/fn.js'; -import * as Events from '../utils/events.js'; - -/** - * The Popup component is used to build pop up controls. - * - * @extends Component - */ -class P...
true
Other
videojs
video.js
95d7832b0e878c2a77470eab8c918469cd96a179.json
chore(lang): update Persian translations (#4741)
lang/fa.json
@@ -1,26 +1,84 @@ { + "Audio Player": "پخش کننده صوتی", + "Video Player": "پخش کننده ویدیو", "Play": "پخش", - "Pause": "وقفه", + "Pause": "مکث", + "Replay": "بازپخش", "Current Time": "زمان کنونی", "Duration Time": "مدت زمان", "Remaining Time": "زمان باقیمانده", "Stream Type": "نوع استریم", "LIVE...
false
Other
videojs
video.js
d8aadd5bee086dacbdc924e0c54c171a2a46fa73.json
feat: allow embeds via <video-js> element (#4640) Add the ability to initialize Video.js with an element named video-js. This is because sometimes, seeing the native element is undesirable, plus, it's cool to have our own element. Can be used just like the video embed. IE9 is supported but only with dynamic sources ...
docs/guides/embeds.md
@@ -0,0 +1,87 @@ +# How to Embed the Video.js player + +Video.js is meant to be an enhacement to the video element in HTML5 so for years, its embed code has been just a `<video>` element. +Video.js then wraps the video element in a div that is used for us to place controls and anything else that's required for the play...
true
Other
videojs
video.js
d8aadd5bee086dacbdc924e0c54c171a2a46fa73.json
feat: allow embeds via <video-js> element (#4640) Add the ability to initialize Video.js with an element named video-js. This is because sometimes, seeing the native element is undesirable, plus, it's cool to have our own element. Can be used just like the video embed. IE9 is supported but only with dynamic sources ...
docs/guides/setup.md
@@ -37,6 +37,8 @@ Video.js supports all attributes of the `<video>` element (such as `controls`, ` </video> ``` +For a high-level overview of all the various embed options, check out the [embeds page](/docs/guides/embeds.md), then follow the rest of this page. + ### Automatic Setup By default, when your web pag...
true
Other
videojs
video.js
d8aadd5bee086dacbdc924e0c54c171a2a46fa73.json
feat: allow embeds via <video-js> element (#4640) Add the ability to initialize Video.js with an element named video-js. This is because sometimes, seeing the native element is undesirable, plus, it's cool to have our own element. Can be used just like the video embed. IE9 is supported but only with dynamic sources ...
sandbox/embeds.html.example
@@ -0,0 +1,165 @@ +<!DOCTYPE html> +<html> +<head> + <meta charset="utf-8" /> + <title>Video.js Sandbox</title> + <script src='../node_modules/es5-shim/es5-shim.js'></script> + <script src='../node_modules/es6-shim/es6-shim.js'></script> + + <link href="../build/temp/video-js.css" rel="stylesheet" type="text/css">...
true
Other
videojs
video.js
d8aadd5bee086dacbdc924e0c54c171a2a46fa73.json
feat: allow embeds via <video-js> element (#4640) Add the ability to initialize Video.js with an element named video-js. This is because sometimes, seeing the native element is undesirable, plus, it's cool to have our own element. Can be used just like the video embed. IE9 is supported but only with dynamic sources ...
src/js/player.js
@@ -366,6 +366,7 @@ class Player extends Component { // now remove immediately so native controls don't flash. // May be turned back on by HTML5 tech if nativeControlsForTouch is true tag.controls = false; + tag.removeAttribute('controls'); /* * Store the internal state of scrubbing @@ -5...
true
Other
videojs
video.js
d8aadd5bee086dacbdc924e0c54c171a2a46fa73.json
feat: allow embeds via <video-js> element (#4640) Add the ability to initialize Video.js with an element named video-js. This is because sometimes, seeing the native element is undesirable, plus, it's cool to have our own element. Can be used just like the video embed. IE9 is supported but only with dynamic sources ...
src/js/setup.js
@@ -31,6 +31,7 @@ const autoSetup = function() { // through each list of elements to build up a new, combined list of elements. const vids = document.getElementsByTagName('video'); const audios = document.getElementsByTagName('audio'); + const divs = document.getElementsByTagName('video-js'); const mediaEl...
true
Other
videojs
video.js
d8aadd5bee086dacbdc924e0c54c171a2a46fa73.json
feat: allow embeds via <video-js> element (#4640) Add the ability to initialize Video.js with an element named video-js. This is because sometimes, seeing the native element is undesirable, plus, it's cool to have our own element. Can be used just like the video embed. IE9 is supported but only with dynamic sources ...
src/js/video.js
@@ -38,6 +38,7 @@ if (typeof HTMLVideoElement === 'undefined' && Dom.isReal()) { document.createElement('video'); document.createElement('audio'); document.createElement('track'); + document.createElement('video-js'); } /**
true
Other
videojs
video.js
d8aadd5bee086dacbdc924e0c54c171a2a46fa73.json
feat: allow embeds via <video-js> element (#4640) Add the ability to initialize Video.js with an element named video-js. This is because sometimes, seeing the native element is undesirable, plus, it's cool to have our own element. Can be used just like the video embed. IE9 is supported but only with dynamic sources ...
test/unit/video.test.js
@@ -1,6 +1,7 @@ /* eslint-env qunit */ import videojs from '../../src/js/video.js'; import * as Dom from '../../src/js/utils/dom.js'; +import * as browser from '../../src/js/utils/browser.js'; import log from '../../src/js/utils/log.js'; import document from 'global/document'; import sinon from 'sinon'; @@ -363,3...
true
Other
videojs
video.js
e2af3223131957e48871b09307c856f717d9d7b5.json
chore: add GA note to primary readme (#4481)
README.md
@@ -25,9 +25,24 @@ Thanks to the awesome folks over at [Fastly][fastly], there's a free, CDN hosted <link href="//vjs.zencdn.net/5.19/video-js.min.css" rel="stylesheet"> <script src="//vjs.zencdn.net/5.19/video.min.js"></script> ``` - > For the latest version of video.js and URLs to use, check out the [Getting Star...
false
Other
videojs
video.js
45a6b3010df2a551146ae534322dec3e1b3714b0.json
test: fix modal dialog test for showing controls (#4707) Also, add a test that verifies the behavior for the PR (#4690). Fixes #4706.
test/unit/modal-dialog.test.js
@@ -310,6 +310,7 @@ QUnit.test('open() does not pause, close() does not play() with pauseOnOpen set }); QUnit.test('open() hides controls, close() shows controls', function(assert) { + this.player.controls(true); this.modal.open(); assert.expect(2); @@ -319,6 +320,17 @@ QUnit.test('open() hides controls, c...
false
Other
videojs
video.js
cb638d0ea7a0f881628f5cab1ece182b96ce33d8.json
chore: add comment about avoiding helvetica font (#4679) See issue #376 for more information.
src/css/_private-variables.scss
@@ -9,6 +9,7 @@ $primary-background-transparency: 0.7 !default; $secondary-background-color: lighten($primary-background-color, 33%) !default; $secondary-background-transparency: 0.5 !default; +// Avoiding helvetica: issue #376 $text-font-family: Arial, Helvetica, sans-serif !default; // Using the '--' naming f...
false
Other
videojs
video.js
32caf3556f85ad47ac02ce246bef1a5725d30a86.json
feat(lang): add Hebrew translation (#4675)
lang/he.json
@@ -0,0 +1,84 @@ +{ + "Audio Player": "נַגָּן שמע", + "Video Player": "נַגָּן וידאו", + "Play": "נַגֵּן", + "Pause": "השהה", + "Replay": "נַגֵּן שוב", + "Current Time": "זמן נוכחי", + "Duration Time": "זמן כולל", + "Remaining Time": "זמן נותר", + "Stream Type": "סוג Stream", + "LIVE": "שידור חי", + "Loaded": "נטען", + ...
false
Other
videojs
video.js
4658c7bad67dc0556b636aed7962d2d85f308fe8.json
fix: Fix a typo in current time display component. (#4647)
src/js/control-bar/time-controls/current-time-display.js
@@ -64,7 +64,7 @@ class CurrentTimeDisplay extends TimeDisplay { if (!this.player_.duration()) { return; } - this.updateFormattedTime_(this.player.duration()); + this.updateFormattedTime_(this.player_.duration()); } }
false
Other
videojs
video.js
445eb267227b1b0ac4f37f124fa4a8811a54752c.json
feat: Add remainingTimeDisplay method to Player (#4620)
src/js/control-bar/time-controls/remaining-time-display.js
@@ -49,7 +49,7 @@ class RemainingTimeDisplay extends TimeDisplay { return; } - this.updateFormattedTime_(this.player_.remainingTime()); + this.updateFormattedTime_(this.player_.remainingTimeDisplay()); } /**
true
Other
videojs
video.js
445eb267227b1b0ac4f37f124fa4a8811a54752c.json
feat: Add remainingTimeDisplay method to Player (#4620)
src/js/player.js
@@ -1787,6 +1787,17 @@ class Player extends Component { return this.duration() - this.currentTime(); } + /** + * A remaining time function that is intented to be used when + * the time is to be displayed directly to the user. + * + * @return {number} + * The rounded time remaining in second...
true
Other
videojs
video.js
fa6f88440934f661db0fa6bb4128e3c916ef37b6.json
refactor: Create a base time display class, and use it (#4633)
src/js/control-bar/time-controls/current-time-display.js
@@ -1,72 +1,24 @@ /** * @file current-time-display.js */ -import document from 'global/document'; +import TimeDisplay from './time-display'; import Component from '../../component.js'; -import * as Dom from '../../utils/dom.js'; -import {bind, throttle} from '../../utils/fn.js'; -import formatTime from '../../uti...
true
Other
videojs
video.js
fa6f88440934f661db0fa6bb4128e3c916ef37b6.json
refactor: Create a base time display class, and use it (#4633)
src/js/control-bar/time-controls/duration-display.js
@@ -1,18 +1,15 @@ /** * @file duration-display.js */ -import document from 'global/document'; +import TimeDisplay from './time-display'; import Component from '../../component.js'; -import * as Dom from '../../utils/dom.js'; -import {bind, throttle} from '../../utils/fn.js'; -import formatTime from '../../utils/f...
true
Other
videojs
video.js
fa6f88440934f661db0fa6bb4128e3c916ef37b6.json
refactor: Create a base time display class, and use it (#4633)
src/js/control-bar/time-controls/remaining-time-display.js
@@ -1,18 +1,14 @@ /** * @file remaining-time-display.js */ -import document from 'global/document'; +import TimeDisplay from './time-display'; import Component from '../../component.js'; -import * as Dom from '../../utils/dom.js'; -import {bind, throttle} from '../../utils/fn.js'; -import formatTime from '../../u...
true
Other
videojs
video.js
fa6f88440934f661db0fa6bb4128e3c916ef37b6.json
refactor: Create a base time display class, and use it (#4633)
src/js/control-bar/time-controls/time-display.js
@@ -0,0 +1,114 @@ +/** + * @file time-display.js + */ +import document from 'global/document'; +import Component from '../../component.js'; +import * as Dom from '../../utils/dom.js'; +import {bind, throttle} from '../../utils/fn.js'; +import formatTime from '../../utils/format-time.js'; + +/** + * Displays the time le...
true
Other
videojs
video.js
fe63992bd1e0d6e4eb7783584bce17c2796c4a2c.json
fix: use typeof for checking preload option (#4574)
src/js/tech/html5.js
@@ -302,7 +302,7 @@ class Html5 extends Tech { el.playerId = this.options_.playerId; } - if (this.options_.preload !== 'undefined') { + if (typeof this.options_.preload !== 'undefined') { Dom.setAttribute(el, 'preload', this.options_.preload); }
false
Other
videojs
video.js
d7f7e05b5cfdafec7ac7e6199b0574a46dd4d7b7.json
chore(package): update rollup to version 0.47.4 (#4570) Closes #4561
package.json
@@ -136,7 +136,7 @@ "remark-toc": "^4.0.0", "remark-validate-links": "^6.0.0", "replace": "^0.3.0", - "rollup": "^0.45.2", + "rollup": "^0.47.4", "rollup-plugin-babel": "^2.7.1", "rollup-plugin-commonjs": "^8.0.2", "rollup-plugin-filesize": "^1.2.1",
false
Other
videojs
video.js
19ebc0dda52ff6b6a6f7e11a3dc181262cddb804.json
chore: improve dev and beginner experience (#4555) Makes the output of dev rollup and babel watch more quiet. Add a task to copy .example files over to non .example files if the non .example files are not present.
build/grunt.js
@@ -466,7 +466,7 @@ module.exports = function(grunt) { } }, babel: { - command: 'npm run babel -- --watch', + command: 'npm run babel -- --watch --quiet', options: { preferLocal: true } @@ -575,7 +575,7 @@ module.exports = function(grunt) { }); /...
true
Other
videojs
video.js
19ebc0dda52ff6b6a6f7e11a3dc181262cddb804.json
chore: improve dev and beginner experience (#4555) Makes the output of dev rollup and babel watch more quiet. Add a task to copy .example files over to non .example files if the non .example files are not present.
build/rollup.js
@@ -26,6 +26,10 @@ const args = minimist(process.argv.slice(2), { } }); +if (args.watch) { + args.progress = false; +} + const compiledLicense = _.template(fs.readFileSync('./build/license-header.txt', 'utf8')); const bannerData = _.pick(pkg, ['version', 'copyright']);
true
Other
videojs
video.js
19ebc0dda52ff6b6a6f7e11a3dc181262cddb804.json
chore: improve dev and beginner experience (#4555) Makes the output of dev rollup and babel watch more quiet. Add a task to copy .example files over to non .example files if the non .example files are not present.
build/tasks/sandbox.js
@@ -0,0 +1,33 @@ +const fs = require('fs'); +const path = require('path'); +const klawSync = require('klaw-sync'); + +module.exports = function(grunt) { + grunt.registerTask('sandbox', 'copy over sandbox example files if necessary', function() { + const files = klawSync('sandbox/').filter((file) => path.extname(fil...
true
Other
videojs
video.js
fe95a7720a754f764b1974c988a6cf71244e3ded.json
chore(greenkeeper): ignore webpack and uglify (#4518)
package.json
@@ -175,7 +175,9 @@ "greenkeeper": { "ignore": [ "qunitjs", - "sinon" + "sinon", + "webpack", + "uglify-js" ] } }
false
Other
videojs
video.js
b1ac2e024914caca1557ccec255db7577a860308.json
chore(gh-release): add prerelease flag and find right zip (#4488) Add a --prerelease flag so we can run gh-release.js manually and mark releases as prerelease. Also, get the correct zip file.
build/gh-release.js
@@ -2,12 +2,23 @@ var ghrelease = require('gh-release'); var currentChangelog = require('./current-changelog.js'); var safeParse = require('safe-json-parse/tuple'); var pkg = require('../package.json') +var minimist = require('minimist'); + +var args = minimist(process.argv.slice(2), { + boolean: ['prerelease'], + ...
false
Other
videojs
video.js
971f633c736698fd3fd7a1ecbc946f6c17a827c5.json
chore(package): update rollup to version 0.45.2 (#4487) Closes #4475
package.json
@@ -136,7 +136,7 @@ "remark-toc": "^4.0.0", "remark-validate-links": "^6.0.0", "replace": "^0.3.0", - "rollup": "^0.42.0", + "rollup": "^0.45.2", "rollup-plugin-babel": "^2.7.1", "rollup-plugin-commonjs": "^8.0.2", "rollup-plugin-filesize": "^1.2.1",
false
Other
videojs
video.js
3a600d0eea54f94df3361b59c06e2cf944e63cd1.json
chore: add automatic github release (#4466) This will automatically do a github release with the correct changelog entry and the built zip file. If a publish is made with `--tag next` it will mark the release as a pre-release. To use, just add `VJS_GITHUB_USER` and `VJS_GITHUB_TOKEN` env variables as part of the p...
build/current-changelog.js
@@ -0,0 +1,33 @@ +var unified = require('unified'); +var markdown = require('remark-parse'); +var stringify = require('remark-stringify'); +var fs = require('fs'); + +module.exports = function() { + var processor = unified() + .use(markdown, {commonmark: true}) + .use(stringify); + + var ast = processor.parse(fs.re...
true
Other
videojs
video.js
3a600d0eea54f94df3361b59c06e2cf944e63cd1.json
chore: add automatic github release (#4466) This will automatically do a github release with the correct changelog entry and the built zip file. If a publish is made with `--tag next` it will mark the release as a pre-release. To use, just add `VJS_GITHUB_USER` and `VJS_GITHUB_TOKEN` env variables as part of the p...
build/gh-release.js
@@ -0,0 +1,33 @@ +var ghrelease = require('gh-release'); +var currentChangelog = require('./current-changelog.js'); +var safeParse = require('safe-json-parse/tuple'); +var pkg = require('../package.json') + +var options = { + owner: 'videojs', + repo: 'video.js', + body: currentChangelog(), + assets: ['./dist/video...
true
Other
videojs
video.js
3a600d0eea54f94df3361b59c06e2cf944e63cd1.json
chore: add automatic github release (#4466) This will automatically do a github release with the correct changelog entry and the built zip file. If a publish is made with `--tag next` it will mark the release as a pre-release. To use, just add `VJS_GITHUB_USER` and `VJS_GITHUB_TOKEN` env variables as part of the p...
package.json
@@ -39,6 +39,7 @@ "docs:fix": "remark --output -- './**/*.md'", "babel": "babel src/js -d es5", "prepublish": "not-in-install && run-p docs:api build || in-install", + "publish": "node build/gh-release.js", "prepush": "npm run lint -- --errors", "version": "node build/version.js && git add C...
true
Other
videojs
video.js
1e80e59614a748d35607dd63ac994ae99eb061e2.json
test: add unit tests for player.duration() (#4459) Unit tests for https://github.com/videojs/video.js/pull/4443
test/unit/player.test.js
@@ -1655,3 +1655,31 @@ QUnit.test('should add a class with major version', function(assert) { player.dispose(); }); + +QUnit.test('player.duration() returns NaN if player.cache_.duration is undefined', function(assert) { + const player = TestHelpers.makePlayer(); + + player.cache_.duration = undefined; + asser...
false
Other
videojs
video.js
6986dbb85138032468b2e4d79eb0d919fb0ff527.json
chore(build): remove unused var in build/version.js (#4458)
build/version.js
@@ -7,7 +7,6 @@ if (tuple[0]) { } var sh = require('shelljs'); -var version = process.env.npm_package_version; var prereleaseType = npm_config_argv['remain'][0]; var approvedTypes = { 'major': 1,
false
Other
videojs
video.js
e0824c8294d063a42244267c07dad2db2902d2d1.json
fix: Update translations to match correct string (#4383) The lang files were translating "all settings to the default values" instead of "restore all settings to the default values".
docs/translations-needed.md
@@ -60,7 +60,7 @@ This default value is hardcoded as a default to the localize method in the SeekB | | Script | | | Small Caps ...
true
Other
videojs
video.js
e0824c8294d063a42244267c07dad2db2902d2d1.json
fix: Update translations to match correct string (#4383) The lang files were translating "all settings to the default values" instead of "restore all settings to the default values".
lang/de.json
@@ -70,7 +70,15 @@ "Casual": "Zwanglos", "Script": "Schreibeschrift", "Small Caps": "Small-Caps", + "Reset": "Zurücksetzen", + "restore all settings to the default values": "Alle Einstellungen auf die Standardwerte zurücksetzen", "Done": "Fertig", "Caption Settings Dialog": "Einstellungsdialog für Unte...
true
Other
videojs
video.js
e0824c8294d063a42244267c07dad2db2902d2d1.json
fix: Update translations to match correct string (#4383) The lang files were translating "all settings to the default values" instead of "restore all settings to the default values".
lang/en.json
@@ -76,7 +76,7 @@ "Script": "Script", "Small Caps": "Small Caps", "Reset": "Reset", - "all settings to the default values": "all settings to the default values", + "restore all settings to the default values": "restore all settings to the default values", "Done": "Done", "Caption Settings Dialog": "Cap...
true
Other
videojs
video.js
e0824c8294d063a42244267c07dad2db2902d2d1.json
fix: Update translations to match correct string (#4383) The lang files were translating "all settings to the default values" instead of "restore all settings to the default values".
lang/fr.json
@@ -76,7 +76,7 @@ "Script": "Scripte", "Small Caps": "Petites capitales", "Reset": "Réinitialiser", - "all settings to the default values": "tous les paramètres aux valeurs par défaut", + "restore all settings to the default values": "Restaurer tous les paramètres aux valeurs par défaut", "Done": "Terminé...
true
Other
videojs
video.js
e0824c8294d063a42244267c07dad2db2902d2d1.json
fix: Update translations to match correct string (#4383) The lang files were translating "all settings to the default values" instead of "restore all settings to the default values".
lang/sk.json
@@ -76,7 +76,7 @@ "Script": "Písané", "Small Caps": "Malé kapitálky", "Reset": "Resetovať", - "all settings to the default values": "všetky nastavenia na základné hodnoty", + "restore all settings to the default values": "všetky nastavenia na základné hodnoty", "Done": "Hotovo", "Caption Settings Dialo...
true
Other
videojs
video.js
cc6e82442fcefb3b62a6e33a588d7f0b7152fd3d.json
docs: Fix links in API docs for several Player events. (#4427)
src/js/player.js
@@ -148,7 +148,7 @@ const TECH_EVENTS_RETRIGGER = [ /** * Fires when the browser has loaded the current frame of the audio/video. * - * @event player#loadeddata + * @event Player#loadeddata * @type {event} */ /** @@ -164,7 +164,7 @@ const TECH_EVENTS_RETRIGGER = [ /** * Fires when the c...
false
Other
videojs
video.js
c4bbe5d1205229200a1b85d2ddf647f3c1ad7edb.json
chore(sandbox): Fix paths in sandbox files. (#4416)
sandbox/combined-tracks.html.example
@@ -5,16 +5,16 @@ <title>Video.js Sandbox</title> <!-- Add ES5 shim and sham for IE8 --> - <script src="../build/temp/ie8/videojs-ie8.js"></script> + <script src="../dist/ie8/videojs-ie8.js"></script> <!-- Load the source files --> <link href="../build/temp/video-js.css" rel="stylesheet" type="text/cs...
true
Other
videojs
video.js
c4bbe5d1205229200a1b85d2ddf647f3c1ad7edb.json
chore(sandbox): Fix paths in sandbox files. (#4416)
sandbox/descriptions.html.example
@@ -5,15 +5,15 @@ <title>Video.js Text Descriptions, Chapters &amp; Captions Example</title> <!-- Add ES5 shim and sham for IE8 --> - <script src="../build/temp/ie8/videojs-ie8.js"></script> + <script src="../dist/ie8/videojs-ie8.js"></script> <!-- Load the source files --> <link href="../build/temp/v...
true
Other
videojs
video.js
c4bbe5d1205229200a1b85d2ddf647f3c1ad7edb.json
chore(sandbox): Fix paths in sandbox files. (#4416)
sandbox/flash.html.example
@@ -5,16 +5,16 @@ <title>Video.js Sandbox</title> <!-- Add ES5 shim and sham for IE8 --> - <script src="../build/temp/ie8/videojs-ie8.js"></script> + <script src="../dist/ie8/videojs-ie8.js"></script> <!-- Load the source files --> <link href="../build/temp/video-js.css" rel="stylesheet" type="text/cs...
true
Other
videojs
video.js
c4bbe5d1205229200a1b85d2ddf647f3c1ad7edb.json
chore(sandbox): Fix paths in sandbox files. (#4416)
sandbox/index.html.example
@@ -5,7 +5,7 @@ <title>Video.js Sandbox</title> <!-- Add ES5 shim and sham for IE8 --> - <script src="../build/temp/ie8/videojs-ie8.js"></script> + <script src="../dist/ie8/videojs-ie8.js"></script> <!-- Load the source files --> <link href="../build/temp/video-js.css" rel="stylesheet" type="text/css"...
true
Other
videojs
video.js
c4bbe5d1205229200a1b85d2ddf647f3c1ad7edb.json
chore(sandbox): Fix paths in sandbox files. (#4416)
sandbox/language.html.example
@@ -6,15 +6,15 @@ <title>VideoJS Languages Demo</title> <!-- Add ES5 shim and sham for IE8 --> - <script src="../build/temp/ie8/videojs-ie8.js"></script> + <script src="../dist/ie8/videojs-ie8.js"></script> <!-- Load the source files --> <link href="../build/temp/video-js.css" rel="stylesheet" type="t...
true
Other
videojs
video.js
c4bbe5d1205229200a1b85d2ddf647f3c1ad7edb.json
chore(sandbox): Fix paths in sandbox files. (#4416)
sandbox/plugin.html.example
@@ -5,15 +5,15 @@ <title>Video.js Plugin Example</title> <!-- Add ES5 shim and sham for IE8 --> - <script src="../build/temp/ie8/videojs-ie8.js"></script> + <script src="../dist/ie8/videojs-ie8.js"></script> <!-- Load the source files --> <link href="../build/temp/video-js.css" rel="stylesheet" type="...
true
Other
videojs
video.js
c31836c30cebe6e117edc341588d39a464570867.json
feat: Use Rollup to generate dist files (#4301)
.babelrc
@@ -1,4 +1,8 @@ { - "presets": [ "es3", ["es2015", {"loose": true}] ], - "plugins": ["inline-json"] + "presets": [ + "es3", + ["es2015", { + "loose": true + }] + ] }
true
Other
videojs
video.js
c31836c30cebe6e117edc341588d39a464570867.json
feat: Use Rollup to generate dist files (#4301)
.travis.yml
@@ -5,6 +5,10 @@ before_install: - export CHROME_BIN=chromium-browser - export DISPLAY=:99.0 - sh -e /etc/init.d/xvfb start +after_failure: + - npm ls --depth=1 +after_success: + - npm run assets notifications: irc: channels:
true
Other
videojs
video.js
c31836c30cebe6e117edc341588d39a464570867.json
feat: Use Rollup to generate dist files (#4301)
build/assets.js
@@ -0,0 +1,65 @@ +const fs = require('fs'); +const zlib = require('zlib'); +const Promise = require('bluebird'); +const klawSync = require('klaw-sync'); +const filesize = require('filesize'); +const Table = require('cli-table'); + +const files = klawSync('dist/', { + ignore: ['examples', 'lang', 'font', 'ie8', '*.zip'...
true
Other
videojs
video.js
c31836c30cebe6e117edc341588d39a464570867.json
feat: Use Rollup to generate dist files (#4301)
build/grunt.js
@@ -408,8 +408,7 @@ module.exports = function(grunt) { ], dev: [ 'shell:babel', - 'browserify:watch', - 'browserify:watchnovtt', + 'shell:rollupwatch', 'browserify:tests', 'watch:skin', 'watch:lang', @@ -448,6 +447,24 @@ module.exports = function(gr...
true
Other
videojs
video.js
c31836c30cebe6e117edc341588d39a464570867.json
feat: Use Rollup to generate dist files (#4301)
build/rollup.js
@@ -0,0 +1,205 @@ +import { rollup } from 'rollup'; +import duration from 'humanize-duration'; +import watch from 'rollup-watch'; +import babel from 'rollup-plugin-babel'; +import resolve from 'rollup-plugin-node-resolve'; +import commonjs from 'rollup-plugin-commonjs'; +import json from 'rollup-plugin-json'; +import f...
true
Other
videojs
video.js
c31836c30cebe6e117edc341588d39a464570867.json
feat: Use Rollup to generate dist files (#4301)
package.json
@@ -2,7 +2,8 @@ "name": "video.js", "description": "An HTML5 and Flash video player with a common API and skin for both.", "version": "6.1.0", - "main": "./es5/video.js", + "main": "./dist/video.cjs.js", + "module": "./dist/video.es.js", "style": "./dist/video-js.css", "copyright": "Copyright Brightco...
true
Other
videojs
video.js
c31836c30cebe6e117edc341588d39a464570867.json
feat: Use Rollup to generate dist files (#4301)
sandbox/index.html.example
@@ -9,7 +9,7 @@ <!-- Load the source files --> <link href="../build/temp/video-js.css" rel="stylesheet" type="text/css"> - <script src="../build/temp/video.js"></script> + <script src="../dist/video.js"></script> <script src="../node_modules/videojs-flash/dist/videojs-flash.js"></script> <!-- Set the ...
true
Other
videojs
video.js
c31836c30cebe6e117edc341588d39a464570867.json
feat: Use Rollup to generate dist files (#4301)
src/js/player.js
@@ -4,6 +4,7 @@ // Subclasses Component import Component from './component.js'; +import {version} from '../../package.json'; import document from 'global/document'; import window from 'global/window'; import tsml from 'tsml'; @@ -443,7 +444,7 @@ class Player extends Component { Player.players[this.id_] = t...
true
Other
videojs
video.js
c31836c30cebe6e117edc341588d39a464570867.json
feat: Use Rollup to generate dist files (#4301)
src/js/tech/tech.js
@@ -14,6 +14,7 @@ import document from 'global/document'; import {isPlain} from '../utils/obj'; import * as TRACK_TYPES from '../tracks/track-types'; import toTitleCase from '../utils/to-title-case'; +import vtt from 'videojs-vtt.js'; /** * An Object containing a structure like: `{src: 'url', type: 'mimetype'}`...
true
Other
videojs
video.js
c31836c30cebe6e117edc341588d39a464570867.json
feat: Use Rollup to generate dist files (#4301)
src/js/video.js
@@ -2,6 +2,7 @@ * @file video.js * @module videojs */ +import {version} from '../../package.json'; import window from 'global/window'; import document from 'global/document'; import * as setup from './setup'; @@ -225,7 +226,7 @@ setup.autoSetupTimeout(1, videojs); * * @type {string} */ -videojs.VERSION =...
true
Other
videojs
video.js
c31836c30cebe6e117edc341588d39a464570867.json
feat: Use Rollup to generate dist files (#4301)
test/karma.conf.js
@@ -10,7 +10,7 @@ module.exports = function(config) { // Compling tests here files: [ '../build/temp/video-js.css', - '../build/temp/ie8/videojs-ie8.min.js', + '../build/temp/ie8/videojs-ie8.js', '../test/globals-shim.js', '../test/unit/**/*.js', '../build/temp/browserify...
true
Other
videojs
video.js
483e5a2ca59d0b660c6142c897a1c14982084093.json
feat: Add getVideoPlaybackQuality API (#4338) Provides a tech getter for getVideoPlaybackQuality as specified by the W3C's Media Playback Quality API: https://wicg.github.io/media-playback-quality/.
package.json
@@ -126,7 +126,7 @@ "tui-jsdoc-template": "^1.1.0", "uglify-js": "~2.8.8", "videojs-doc-generator": "0.0.1", - "videojs-flash": "^1.0.0-RC.0", + "videojs-flash": "^1.1.0", "videojs-standard": "^6.0.1", "webpack": "^2.3.0" },
true
Other
videojs
video.js
483e5a2ca59d0b660c6142c897a1c14982084093.json
feat: Add getVideoPlaybackQuality API (#4338) Provides a tech getter for getVideoPlaybackQuality as specified by the W3C's Media Playback Quality API: https://wicg.github.io/media-playback-quality/.
src/js/player.js
@@ -3000,6 +3000,20 @@ class Player extends Component { } } + /** + * Gets available media playback quality metrics as specified by the W3C's Media + * Playback Quality API. + * + * @see [Spec]{@link https://wicg.github.io/media-playback-quality} + * + * @return {Object|undefined} + * A...
true
Other
videojs
video.js
483e5a2ca59d0b660c6142c897a1c14982084093.json
feat: Add getVideoPlaybackQuality API (#4338) Provides a tech getter for getVideoPlaybackQuality as specified by the W3C's Media Playback Quality API: https://wicg.github.io/media-playback-quality/.
src/js/tech/html5.js
@@ -667,6 +667,40 @@ class Html5 extends Tech { } } } + + /** + * Gets available media playback quality metrics as specified by the W3C's Media + * Playback Quality API. + * + * @see [Spec]{@link https://wicg.github.io/media-playback-quality} + * + * @return {Object} + * An object ...
true
Other
videojs
video.js
483e5a2ca59d0b660c6142c897a1c14982084093.json
feat: Add getVideoPlaybackQuality API (#4338) Provides a tech getter for getVideoPlaybackQuality as specified by the W3C's Media Playback Quality API: https://wicg.github.io/media-playback-quality/.
src/js/tech/tech.js
@@ -721,6 +721,21 @@ class Tech extends Component { this.autoRemoteTextTracks_.removeTrack(track); } + /** + * Gets available media playback quality metrics as specified by the W3C's Media + * Playback Quality API. + * + * @see [Spec]{@link https://wicg.github.io/media-playback-quality} + * + * @...
true
Other
videojs
video.js
483e5a2ca59d0b660c6142c897a1c14982084093.json
feat: Add getVideoPlaybackQuality API (#4338) Provides a tech getter for getVideoPlaybackQuality as specified by the W3C's Media Playback Quality API: https://wicg.github.io/media-playback-quality/.
test/api/api.js
@@ -59,6 +59,7 @@ QUnit.test('should be able to access expected player API methods', function(asse assert.ok(player.userActive, 'userActive exists'); assert.ok(player.usingNativeControls, 'usingNativeControls exists'); assert.ok(player.isFullscreen, 'isFullscreen exists'); + assert.ok(player.getVideoPlaybackQ...
true
Other
videojs
video.js
483e5a2ca59d0b660c6142c897a1c14982084093.json
feat: Add getVideoPlaybackQuality API (#4338) Provides a tech getter for getVideoPlaybackQuality as specified by the W3C's Media Playback Quality API: https://wicg.github.io/media-playback-quality/.
test/unit/tech/html5.test.js
@@ -691,3 +691,83 @@ test('When Android Chrome reports Infinity duration with currentTime 0, return N browser.IS_CHROME = oldIsChrome; tech.el_ = oldEl; }); + +QUnit.test('supports getting available media playback quality metrics', function(assert) { + const origPerformance = window.performance; + const origDa...
true
Other
videojs
video.js
483e5a2ca59d0b660c6142c897a1c14982084093.json
feat: Add getVideoPlaybackQuality API (#4338) Provides a tech getter for getVideoPlaybackQuality as specified by the W3C's Media Playback Quality API: https://wicg.github.io/media-playback-quality/.
test/unit/tech/tech.test.js
@@ -601,3 +601,9 @@ QUnit.test('setSource after previous setSource should dispose source handler onc assert.equal(disposeCount, 2, 'did dispose for third setSource'); }); + +QUnit.test('returns an empty object for getVideoPlaybackQuality', function(assert) { + const tech = new Tech(); + + assert.deepEqual(tech....
true
Other
videojs
video.js
03bab83dde2c4213e7e9cdddb046be4bf92f759b.json
fix: prevent dupe events on enabled ClickableComponents (#4316) Prevent ClickableComponents re-adding event listeners each time enabled() is called. * Keeps track of enabled state (this.enabled_) * enable() doesn't do anything if the component is enabled, so the event handlers are not re-added Fixes #4312
src/js/clickable-component.js
@@ -141,28 +141,30 @@ class ClickableComponent extends Component { * Enable this `Component`s element. */ enable() { - this.removeClass('vjs-disabled'); - this.el_.setAttribute('aria-disabled', 'false'); - if (typeof this.tabIndex_ !== 'undefined') { - this.el_.setAttribute('tabIndex', this.tab...
true
Other
videojs
video.js
03bab83dde2c4213e7e9cdddb046be4bf92f759b.json
fix: prevent dupe events on enabled ClickableComponents (#4316) Prevent ClickableComponents re-adding event listeners each time enabled() is called. * Keeps track of enabled state (this.enabled_) * enable() doesn't do anything if the component is enabled, so the event handlers are not re-added Fixes #4312
test/unit/clickable-component.test.js
@@ -71,3 +71,25 @@ QUnit.test('handleClick should not be triggered when disabled', function() { testClickableComponent.dispose(); player.dispose(); }); + +QUnit.test('handleClick should not be triggered more than once when enabled', function() { + let clicks = 0; + + class TestClickableComponent extends Clicka...
true
Other
videojs
video.js
f773c473f907eed1139749f71a8d089d16f7af58.json
chore: Fix examples and docs and some links (#4279) * Fix the doc/example/elephantsdream/index.html file, add an index of doc/examples, and update CDN links to use video.js v5.19. * Add poster from CDN to Elephants Dream examples.
README.md
@@ -22,11 +22,11 @@ Thanks to the awesome folks over at [Fastly][fastly], there's a free, CDN hosted version of Video.js that anyone can use. Add these tags to your document's `<head>`: ```html -<link href="//vjs.zencdn.net/5.11/video-js.min.css" rel="stylesheet"> -<script src="//vjs.zencdn.net/5.11/video.min.js"><...
true
Other
videojs
video.js
f773c473f907eed1139749f71a8d089d16f7af58.json
chore: Fix examples and docs and some links (#4279) * Fix the doc/example/elephantsdream/index.html file, add an index of doc/examples, and update CDN links to use video.js v5.19. * Add poster from CDN to Elephants Dream examples.
docs/examples/elephantsdream/index.html
@@ -1,32 +1,26 @@ <!DOCTYPE html> <html lang="en"> <head> + <meta charset="utf-8" /> <title>Video.js Text Descriptions, Chapters &amp; Captions Example</title> - <link href="../../video-js.css" rel="stylesheet" type="text/css"> - - <script src="../../video.js"></script> - - <!-- Set the location of the fl...
true
Other
videojs
video.js
f773c473f907eed1139749f71a8d089d16f7af58.json
chore: Fix examples and docs and some links (#4279) * Fix the doc/example/elephantsdream/index.html file, add an index of doc/examples, and update CDN links to use video.js v5.19. * Add poster from CDN to Elephants Dream examples.
docs/examples/index.html
@@ -0,0 +1,18 @@ +<!DOCTYPE html> +<html lang="en"> + +<head> + <meta charset="utf-8" /> + <title>Index of video.js examples</title> +</head> +<body> + + <h1>Index of video.js examples</h1> + <ul> + <li><a href="simple-embed">Video.js HTML5 video player simple example</a></li> + <li><a href="elephantsdream">E...
true
Other
videojs
video.js
f773c473f907eed1139749f71a8d089d16f7af58.json
chore: Fix examples and docs and some links (#4279) * Fix the doc/example/elephantsdream/index.html file, add an index of doc/examples, and update CDN links to use video.js v5.19. * Add poster from CDN to Elephants Dream examples.
docs/examples/simple-embed/index.html
@@ -1,15 +1,13 @@ <!DOCTYPE html> <html lang="en"> - <head> <title>Video.js | HTML5 Video Player</title> - <link href="http://vjs.zencdn.net/5.0.2/video-js.css" rel="stylesheet"> - <script src="http://vjs.zencdn.net/ie8/1.1.0/videojs-ie8.min.js"></script> - <script src="http://vjs.zencdn.net/5.0.2/vi...
true
Other
videojs
video.js
f773c473f907eed1139749f71a8d089d16f7af58.json
chore: Fix examples and docs and some links (#4279) * Fix the doc/example/elephantsdream/index.html file, add an index of doc/examples, and update CDN links to use video.js v5.19. * Add poster from CDN to Elephants Dream examples.
sandbox/descriptions.html.example
@@ -18,12 +18,16 @@ </head> <body> + <!-- NOTE: we have to disable native Text Track support for the HTML5 tech, since even HTML5 video players with native Text Track support don't currently support 'description' text tracks in any - useful way! --> + useful wa...
true
Other
videojs
video.js
ae423df4f56ae15bb105a8016822244d2bb7f9e1.json
feat: Add a version class to the player (#4320) Adds `vjs-v6` class so you can target that version of Video.js.
src/js/player.js
@@ -442,6 +442,11 @@ class Player extends Component { // Make player easily findable by ID Player.players[this.id_] = this; + // Add a major version class to aid css in plugins + const majorVersion = require('../../package.json').version.split('.')[0]; + + this.addClass(`vjs-v${majorVersion}`); + ...
true
Other
videojs
video.js
ae423df4f56ae15bb105a8016822244d2bb7f9e1.json
feat: Add a version class to the player (#4320) Adds `vjs-v6` class so you can target that version of Video.js.
test/unit/player.test.js
@@ -1617,3 +1617,12 @@ QUnit.test('options: plugins', function(assert) { player.dispose(); Plugin.deregisterPlugin('foo'); }); + +QUnit.test('should add a class with major version', function(assert) { + const majorVersion = require('../../package.json').version.split('.')[0]; + const player = TestHelpers.makeP...
true
Other
videojs
video.js
cff2e503ef9088207fcdd541fbe0c45c0c79c1b8.json
docs(react-guide): Use a React component as a VJS component (#4287)
docs/guides/react.md
@@ -54,3 +54,94 @@ return <VideoPlayer { ...videoJsOptions } /> Dont forget to include the video.js CSS, located at `video.js/dist/video-js.css`. [options]: /docs/guides/options.md + + +## Using a React Component as a Video JS Component + +```jsx +/** + * EpisodeList.js + * + * This is just a plain ol' React compon...
false
Other
videojs
video.js
561d5ddf76013aca18882f795d334db56d0002b7.json
fix a comment typo (#4293)
src/js/component.js
@@ -40,7 +40,7 @@ class Component { * * @param {Object} [options] * The key/value store of player options. - # + * * @param {Object[]} [options.children] * An array of children objects to intialize this component with. Children objects have * a name property that will be...
false
Other
videojs
video.js
7490a499ce1d4181feb1a142cac6c8750aa0373f.json
chore: add slack travis notifications (#4282)
.travis.yml
@@ -13,6 +13,8 @@ notifications: on_success: never webhooks: - http://pam.videojs.com/savage/travis + slack: + secure: LrF8K6mCYWlUt6SvdbGHazyQZSk/opKoiB/wgoGYaGc9+3wYXkVexY0WkO1m6wBKhUqXRAMVMFszr1wqKgdcxtItmFMMj8HqTLI1MVqgKqYX4Ux3CnEHJQiwxIk0aVL7lHLsZTXV/2Y0QIOYmAnCrgy46klETrk0ZuXf5okpu2Q= env: gl...
false
Other
videojs
video.js
1ea00419c9c6038529bfa9b0f52a367ca716f909.json
fix: set IE_VERSION correctly for IE11 (#4281) videojs.browser.IE_VERSION is null in IE11 because IE11 uses a different user agent string than other IE versions Fixes #4278
src/js/utils/browser.js
@@ -63,9 +63,17 @@ export const IS_FIREFOX = (/Firefox/i).test(USER_AGENT); export const IS_EDGE = (/Edge/i).test(USER_AGENT); export const IS_CHROME = !IS_EDGE && (/Chrome/i).test(USER_AGENT); export const IS_IE8 = (/MSIE\s8\.0/).test(USER_AGENT); -export const IE_VERSION = (function(result) { - return result && p...
false
Other
videojs
video.js
230743ecb1c79977bfa308ce90c039377dfdf524.json
docs: add a Webpack usage guide (#4261)
docs/guides/faq.md
@@ -268,67 +268,68 @@ Yes! Please [submit an issue or open a pull request][pr-issue-question] if this Yes! Please [submit an issue or open a pull request][pr-issue-question] if this does not work. -Be sure to use `require('!style-loader!css-loader!video.js/dist/video-js.css')` to inject video.js CSS. +We have a sh...
true
Other
videojs
video.js
230743ecb1c79977bfa308ce90c039377dfdf524.json
docs: add a Webpack usage guide (#4261)
docs/guides/webpack.md
@@ -0,0 +1,37 @@ +# Using Webpack with Video.js + +video.js, and the playback technologies such as videojs-contrib-hls all work in a Webpack based build environment. Here are several configuration changes specific to Webpack that will get you up and running. + +## Video.js CSS: +To add the CSS that the player requires,...
true
Other
videojs
video.js
39fd73f781b45836c637a0883f58f4de9484940c.json
docs: remove mentions of bower support (#4274) Since video.js 6 no longer officially supports bower (#4012), remove some old mentions in the docs of bower.
COLLABORATOR_GUIDE.md
@@ -261,7 +261,8 @@ git reset --hard upstream/master Releasing video.js is partially automated through [`conrib.json`](/contrib.json) scripts. To do a release, you need a couple of things: npm access, GitHub personal access token. -Releases in video.js are done on npm and bower and GitHub and eventually posted on ...
true
Other
videojs
video.js
39fd73f781b45836c637a0883f58f4de9484940c.json
docs: remove mentions of bower support (#4274) Since video.js 6 no longer officially supports bower (#4012), remove some old mentions in the docs of bower.
docs/guides/faq.md
@@ -59,13 +59,15 @@ video.js is an extendable framework/library around the native video element. It ## Q: How do I install video.js? -Currently video.js can be installed using bower, npm, serving a release file from +Currently video.js can be installed using npm, serving a release file from a github tag, or even ...
true
Other
videojs
video.js
39fd73f781b45836c637a0883f58f4de9484940c.json
docs: remove mentions of bower support (#4274) Since video.js 6 no longer officially supports bower (#4012), remove some old mentions in the docs of bower.
docs/guides/setup.md
@@ -14,7 +14,7 @@ ## Getting Video.js -Video.js is officially available via CDN, npm, and Bower. +Video.js is officially available via CDN and npm. Video.js works out of the box with not only HTML `<script>` and `<link>` tags, but also all major bundlers/packagers/builders, such as Browserify, Node, WebPack, et...
true
Other
videojs
video.js
c20ca5cc974eefed005361522f511f1a2bd143da.json
chore(changelog): Update CHANGELOG with v5 changes (#4257)
CHANGELOG.md
@@ -183,6 +183,88 @@ * button component will always use a button element. * `play()` no longer returns the player object but instead the native Promise or nothing. +<a name="5.19.1"></a> +## [5.19.1](https://github.com/videojs/video.js/compare/v5.19.0...v5.19.1) (2017-03-27) + +### Bug Fixes + +* not showing defaul...
false
Other
videojs
video.js
e98c65d7a646a0d92b2262c204f94b35e6e16f78.json
fix: remove focus ring from player itself (#4237)
src/css/components/_layout.scss
@@ -33,6 +33,10 @@ } } +.video-js[tabindex="-1"] { + outline: none; +} + // All elements inherit border-box sizing .video-js *, .video-js *:before,
false
Other
videojs
video.js
29d733d0d1c64b9c298856bda062a84c7ea01904.json
chore: ignore qunit and sinon from greenkeeper (#4242)
package.json
@@ -143,5 +143,11 @@ "**/test/coverage/**", "**/test/karma.conf.js" ] + }, + "greenkeeper": { + "ignore": [ + "qunitjs", + "sinon" + ] } }
false
Other
videojs
video.js
16c1e0adc0ba7dc7676b3ae151802fc3ab225f44.json
fix: keep minimum volume after unmuting above 0.1 (#4227) If, when unmuting, the last volume is below 0.1, force it to be 0.1. Fixes #4054.
src/js/control-bar/mute-toggle.js
@@ -57,7 +57,9 @@ class MuteToggle extends Button { const lastVolume = this.player_.lastVolume_(); if (vol === 0) { - this.player_.volume(lastVolume); + const volumeToSet = lastVolume < 0.1 ? 0.1 : lastVolume; + + this.player_.volume(volumeToSet); this.player_.muted(false); } else...
true
Other
videojs
video.js
16c1e0adc0ba7dc7676b3ae151802fc3ab225f44.json
fix: keep minimum volume after unmuting above 0.1 (#4227) If, when unmuting, the last volume is below 0.1, force it to be 0.1. Fixes #4054.
test/unit/controls.test.js
@@ -148,6 +148,20 @@ if (Html5.isSupported()) { assert.equal(player.muted(), false, 'muted is set to false'); }); + QUnit.test('Clicking MuteToggle when volume is 0, lastVolume is less than 0.1, and muted is true sets volume to 0.1 and muted to false', function(assert) { + const player = TestHelpers.makeP...
true
Other
videojs
video.js
61e20786a975f0555829635fcfb591794cc8cdef.json
docs: fix links in generated docs (#4200)
build/fix-api-docs.js
@@ -0,0 +1,20 @@ +var replace = require("replace"); +var path = require('path') +var apiPath = path.join(__dirname, '..', 'docs', 'api'); + +var replacements = [ + {find: /\/docs\/guides\/(.+)\.md/g, replace: 'tutorial-$1.html'}, + {find: /tutorial-tech.html/g, replace: 'tutorial-tech_.html'}, + {find: /\/docs\/guid...
true
Other
videojs
video.js
61e20786a975f0555829635fcfb591794cc8cdef.json
docs: fix links in generated docs (#4200)
docs/guides/audio-tracks.md
@@ -25,7 +25,7 @@ cross-browser implementation of audio tracks. They must be added programmatically. * Video.js only stores track representations. Switching audio tracks for playback is _not handled by Video.js_ and must be handled elsewhere - for example, - [videojs-contrib-hls](http://github.com/videojs/video...
true
Other
videojs
video.js
61e20786a975f0555829635fcfb591794cc8cdef.json
docs: fix links in generated docs (#4200)
docs/guides/components.md
@@ -29,7 +29,7 @@ A component is a JavaScript object that has the following features: * The ability to listen for and trigger events. * A lifecycle of initialization and disposal. -For more specifics on the programmatic interface of a component, see [the component API docs](http://docs.videojs.com/docs/api/componen...
true
Other
videojs
video.js
61e20786a975f0555829635fcfb591794cc8cdef.json
docs: fix links in generated docs (#4200)
docs/guides/debugging.md
@@ -107,6 +107,6 @@ Finally, the history (if enabled) can be cleared at any time via: videojs.log.history.clear(); ``` -[api]: http://docs.videojs.com/docs/api/index.html +[api]: http://docs.videojs.com/ [console]: https://developer.mozilla.org/en-US/docs/Web/API/Console
true
Other
videojs
video.js
61e20786a975f0555829635fcfb591794cc8cdef.json
docs: fix links in generated docs (#4200)
docs/guides/faq.md
@@ -112,7 +112,7 @@ with your issue. A reduced test case is an example of the problem that you are facing in isolation. Think of it as example page that reproduces the issue in the least amount of possible code. We have a [starter example][starter-example] for reduced test cases. To learn more -about reduced test ca...
true
Other
videojs
video.js
61e20786a975f0555829635fcfb591794cc8cdef.json
docs: fix links in generated docs (#4200)
docs/guides/languages.md
@@ -58,12 +58,12 @@ Finally, each file's extension is always `.json`. ### Updating an Existing Translation -If there is a [missing translation](../translations-needed.md), mistake, or room for improvement in an existing translation, don't hesitate to open a pull request! +If there is a [missing translation](/docs/...
true
Other
videojs
video.js
61e20786a975f0555829635fcfb591794cc8cdef.json
docs: fix links in generated docs (#4200)
docs/guides/modal-dialog.md
@@ -4,7 +4,7 @@ The `ModalDialog` component is part of Video.js core and provides a baked-in UI ## Table of Contents -* [Creating the ModalDialog](#creating-the-modaldialog) +* [Creating a ModalDialog](#creating-a-modaldialog) * [Example Using createModal()](#example-using-createmodal) * [Example Using the M...
true
Other
videojs
video.js
61e20786a975f0555829635fcfb591794cc8cdef.json
docs: fix links in generated docs (#4200)
docs/guides/options.md
@@ -1,6 +1,6 @@ # Video.js Options Reference -> **Note:** This document is only a reference for available options. To learn about passing options to Video.js, see [the setup guide](setup.md#options). +> **Note:** This document is only a reference for available options. To learn about passing options to Video.js, see...
true
Other
videojs
video.js
61e20786a975f0555829635fcfb591794cc8cdef.json
docs: fix links in generated docs (#4200)
docs/guides/player-workflows.md
@@ -1,6 +1,6 @@ # Player Workflows -This document outlines many considerations for using Video.js for advanced player workflows. Be sure to read [the setup guide](setup.md) first! +This document outlines many considerations for using Video.js for advanced player workflows. Be sure to read [the setup guide](/docs/gui...
true
Other
videojs
video.js
61e20786a975f0555829635fcfb591794cc8cdef.json
docs: fix links in generated docs (#4200)
docs/guides/plugins.md
@@ -1,6 +1,6 @@ # Video.js Plugins -One of the great strengths of Video.js is its ecosystem of plugins that allow authors from all over the world to share their video player customizations. This includes everything from the simplest UI tweaks to new [playback technologies and source handlers](tech.md)! +One of the g...
true
Other
videojs
video.js
61e20786a975f0555829635fcfb591794cc8cdef.json
docs: fix links in generated docs (#4200)
docs/guides/react.md
@@ -36,10 +36,9 @@ export default class VideoPlayer extends React.Component { } ``` -You can then use it like this: +You can then use it like this: (see [options guide][options] for option information) ```jsx -// see https://github.com/videojs/video.js/blob/master/docs/guides/options.md const videoJsOptions = {...
true