language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/css/components/_layout.scss | @@ -103,8 +103,6 @@ body.vjs-full-window {
padding: 0;
margin: 0;
height: 100%;
- // Fix for IE6 full-window. http://www.cssplay.co.uk/layouts/fixed.html
- overflow-y: auto;
}
.vjs-full-window .video-js.vjs-fullscreen {
position: fixed;
@@ -149,10 +147,8 @@ body.vjs-full-window {
visibility: visible;... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/css/components/_poster.scss | @@ -16,16 +16,6 @@
height: 100%;
}
-// Used for IE8 fallback
-.vjs-poster img {
- display: block;
- vertical-align: middle;
- margin: 0 auto;
- max-height: 100%;
- padding: 0;
- width: 100%;
-}
-
// Hide the poster after the video has started playing
.vjs-has-started .vjs-poster {
display: none; | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/css/components/_progress.scss | @@ -63,9 +63,6 @@
padding: 0;
// updated by javascript during playback
width: 0;
- // Needed for IE6
- left: 0;
- top: 0;
}
.video-js .vjs-play-progress {
@@ -83,18 +80,12 @@
}
.video-js .vjs-load-progress {
- // For IE8, we'll lighten the color
- background: lighten($secondary-background-color, 2... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/css/components/_text-track.scss | @@ -18,8 +18,6 @@
font-size: 1.4em;
text-align: center;
margin-bottom: 0.1em;
- // Transparent black background, or fallback to all black (oldIE)
- @include background-color-with-alpha(#000, 0.5);
}
.vjs-subtitles { color: #fff; } // Subtitles are white | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/css/components/_time.scss | @@ -18,12 +18,6 @@
display: none;
}
-// IE 8 + IE 9 width: auto container fix
-.vjs-no-flex .vjs-remaining-time.vjs-time-control.vjs-control {
- width: 0px !important;
- white-space: nowrap;
-}
-
.video-js .vjs-duration,
.vjs-no-flex .vjs-duration {
display: none; | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/css/components/_volume.scss | @@ -1,11 +1,6 @@
.video-js .vjs-mute-control {
cursor: pointer;
@include flex(none);
- // padding here is for IE < 9, it doesn't do width: auto from
- // another style correctly
- padding-left: 2em;
- padding-right: 2em;
- padding-bottom: 3em;
& .vjs-icon-placeholder {
@extend .vjs-icon-volume-hig... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/css/components/menu/_menu.scss | @@ -20,19 +20,15 @@
// This allows scrolling of content if need be.
overflow: auto;
-
- // When combined with `overflow: auto;`, this fixes gaps left by
- // scrollbars in older IE versions.
- box-sizing: content-box;
}
// Reset box-sizing inside the menu.
.vjs-menu .vjs-menu-content > * {
box-sizing... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/css/ie8.css | @@ -1,11 +0,0 @@
-@media \0screen {
- .vjs-user-inactive.vjs-playing .vjs-control-bar :before {
- content: "";
- }
-}
-
-@media \0screen {
- .vjs-has-started.vjs-user-inactive.vjs-playing .vjs-control-bar {
- visibility: hidden;
- }
-} | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/component.js | @@ -988,7 +988,7 @@ class Component {
// if the computed value is still 0, it's possible that the browser is lying
// and we want to check the offset values.
- // This code also runs on IE8 and wherever getComputedStyle doesn't exist.
+ // This code also runs wherever getComputedStyle doesn't exist.
... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/control-bar/progress-control/play-progress-bar.js | @@ -2,7 +2,7 @@
* @file play-progress-bar.js
*/
import Component from '../../component.js';
-import {IE_VERSION, IS_IOS, IS_ANDROID} from '../../utils/browser.js';
+import {IS_IOS, IS_ANDROID} from '../../utils/browser.js';
import formatTime from '../../utils/format-time.js';
import './time-tooltip';
@@ -71,8 ... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/control-bar/progress-control/seek-bar.js | @@ -3,7 +3,7 @@
*/
import Slider from '../../slider/slider.js';
import Component from '../../component.js';
-import {IE_VERSION, IS_IOS, IS_ANDROID} from '../../utils/browser.js';
+import {IS_IOS, IS_ANDROID} from '../../utils/browser.js';
import * as Dom from '../../utils/dom.js';
import * as Fn from '../../util... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/menu/menu.js | @@ -51,7 +51,7 @@ class Menu extends Component {
this.menuButton_.unpressButton();
// don't focus menu button if item is a caption settings item
- // because focus will move elsewhere and it logs an error on IE8
+ // because focus will move elsewhere
if (component.name() !== '... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/player.js | @@ -578,20 +578,10 @@ class Player extends Component {
tag.removeAttribute('height');
Object.getOwnPropertyNames(attrs).forEach(function(attr) {
- // workaround so we don't totally break IE7
- // http://stackoverflow.com/questions/3653444/css-styles-not-applied-on-dynamic-elements-in-internet-expl... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/poster-image.js | @@ -5,7 +5,6 @@ import ClickableComponent from './clickable-component.js';
import Component from './component.js';
import * as Fn from './utils/fn.js';
import * as Dom from './utils/dom.js';
-import * as browser from './utils/browser.js';
/**
* A `ClickableComponent` that handles showing the poster image for th... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/setup.js | @@ -22,35 +22,10 @@ const autoSetup = function() {
return;
}
- // One day, when we stop supporting IE8, go back to this, but in the meantime...*hack hack hack*
- // var vids = Array.prototype.slice.call(document.getElementsByTagName('video'));
- // var audios = Array.prototype.slice.call(document.getElemen... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/tech/html5.js | @@ -908,7 +908,7 @@ if (Dom.isReal()) {
* - False if HTML5 media is not supported.
*/
Html5.isSupported = function() {
- // IE9 with no Media Player is a LIAR! (#984)
+ // IE with no Media Player is a LIAR! (#984)
try {
Html5.TEST_VID.volume = 0.5;
} catch (e) {
@@ -995,9 +995,6 @@ Html5.canCo... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/tracks/audio-track-list.js | @@ -2,8 +2,6 @@
* @file audio-track-list.js
*/
import TrackList from './track-list';
-import * as browser from '../utils/browser.js';
-import document from 'global/document';
/**
* Anywhere we call this function we diverge from the spec
@@ -42,8 +40,6 @@ class AudioTrackList extends TrackList {
* A... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/tracks/audio-track.js | @@ -1,7 +1,6 @@
import {AudioTrackKind} from './track-enums';
import Track from './track';
import merge from '../utils/merge-options';
-import * as browser from '../utils/browser.js';
/**
* A representation of a single `AudioTrack`. If it is part of an {@link AudioTrackList}
@@ -38,18 +37,11 @@ class AudioTrack... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/tracks/html-track-element-list.js | @@ -2,9 +2,6 @@
* @file html-track-element-list.js
*/
-import * as browser from '../utils/browser.js';
-import document from 'global/document';
-
/**
* The current list of {@link HtmlTrackElement}s.
*/
@@ -17,38 +14,22 @@ class HtmlTrackElementList {
* A list of `HtmlTrackElement` to instantiate t... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/tracks/html-track-element.js | @@ -2,8 +2,6 @@
* @file html-track-element.js
*/
-import * as browser from '../utils/browser.js';
-import document from 'global/document';
import EventTarget from '../event-target';
import TextTrack from '../tracks/text-track';
@@ -63,48 +61,40 @@ class HTMLTrackElement extends EventTarget {
super();
... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/tracks/text-track-cue-list.js | @@ -1,8 +1,6 @@
/**
* @file text-track-cue-list.js
*/
-import * as browser from '../utils/browser.js';
-import document from 'global/document';
/**
* @typedef {Object} TextTrackCueList~TextTrackCue
@@ -36,35 +34,19 @@ class TextTrackCueList {
* A list of cues to be initialized with
*/
constr... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/tracks/text-track-list.js | @@ -3,8 +3,6 @@
*/
import TrackList from './track-list';
import * as Fn from '../utils/fn.js';
-import * as browser from '../utils/browser.js';
-import document from 'global/document';
/**
* The current list of {@link TextTrack} for a media file.
@@ -14,35 +12,6 @@ import document from 'global/document';
*/
... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/tracks/text-track.js | @@ -10,7 +10,6 @@ import Track from './track.js';
import { isCrossOrigin } from '../utils/url.js';
import XHR from 'xhr';
import merge from '../utils/merge-options';
-import * as browser from '../utils/browser.js';
/**
* Takes a webvtt file contents and parses it into cues
@@ -163,27 +162,17 @@ class TextTrack ... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/tracks/track-list.js | @@ -2,8 +2,6 @@
* @file track-list.js
*/
import EventTarget from '../event-target';
-import * as browser from '../utils/browser.js';
-import document from 'global/document';
/**
* Common functionaliy between {@link TextTrackList}, {@link AudioTrackList}, and
@@ -18,46 +16,28 @@ class TrackList extends EventTa... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/tracks/track.js | @@ -1,8 +1,6 @@
/**
* @file track.js
*/
-import * as browser from '../utils/browser.js';
-import document from 'global/document';
import * as Guid from '../utils/guid.js';
import EventTarget from '../event-target';
@@ -41,17 +39,6 @@ class Track extends EventTarget {
constructor(options = {}) {
super()... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/tracks/video-track-list.js | @@ -2,8 +2,6 @@
* @file video-track-list.js
*/
import TrackList from './track-list';
-import * as browser from '../utils/browser.js';
-import document from 'global/document';
/**
* Un-select all other {@link VideoTrack}s that are selected.
@@ -41,8 +39,6 @@ class VideoTrackList extends TrackList {
* ... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/tracks/video-track.js | @@ -1,7 +1,6 @@
import {VideoTrackKind} from './track-enums';
import Track from './track';
import merge from '../utils/merge-options';
-import * as browser from '../utils/browser.js';
/**
* A representation of a single `VideoTrack`.
@@ -37,18 +36,9 @@ class VideoTrack extends Track {
kind: VideoTrackKind... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/utils/browser.js | @@ -55,8 +55,6 @@ export const ANDROID_VERSION = (function() {
return null;
}());
-// Old Android is defined as Version older than 2.3, and requiring a webkit version of the android browser
-export const IS_OLD_ANDROID = IS_ANDROID && (/webkit/i).test(USER_AGENT) && ANDROID_VERSION < 2.3;
export const IS_NATIVE_... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/utils/computed-style.js | @@ -5,7 +5,7 @@
import window from 'global/window';
/**
- * A safe getComputedStyle with an IE8 fallback.
+ * A safe getComputedStyle.
*
* This is needed because in Firefox, if the player is loaded in an iframe with
* `display:none`, then `getComputedStyle` returns `null`, so, we do a null-check to
@@ -33,5 +... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/utils/dom.js | @@ -8,7 +8,6 @@ import log from './log.js';
import tsml from 'tsml';
import {isObject} from './obj';
import computedStyle from './computed-style';
-import * as browser from './browser';
/**
* Detect if a value is a string with any non-whitespace characters.
@@ -62,14 +61,8 @@ function classRegExp(className) {
... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/utils/log.js | @@ -3,8 +3,6 @@
* @module log
*/
import window from 'global/window';
-import {IE_VERSION} from './browser';
-import {isObject} from './obj';
let log;
@@ -23,12 +21,8 @@ let history = [];
*
* @param {Array} args
* The arguments to be passed to the matching console method.
- *
- * @param {boolea... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | src/js/video.js | @@ -33,14 +33,6 @@ import xhr from 'xhr';
import Tech from './tech/tech.js';
import { use as middlewareUse, TERMINATOR } from './tech/middleware.js';
-// HTML5 Element Shim for IE8
-if (typeof HTMLVideoElement === 'undefined' && Dom.isReal()) {
- document.createElement('video');
- document.createElement('audio');... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | test/index.html | @@ -9,7 +9,6 @@
<body>
<div id="qunit"></div>
<script src="../node_modules/qunitjs/qunit/qunit.js"></script>
- <script src="../build/temp/ie8/videojs-ie8.js"></script>
<!-- Execute the bundled tests first -->
<script src="../build/temp/tests.js"></script> | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | test/karma.conf.js | @@ -20,7 +20,6 @@ module.exports = function(config) {
// Compling tests here
files: [
'../build/temp/video-js.css',
- '../build/temp/ie8/videojs-ie8.js',
'../test/globals-shim.js',
'../test/unit/**/*.js',
'../build/temp/browserify.js', | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | test/unit/controls.test.js | @@ -7,7 +7,6 @@ import Slider from '../../src/js/slider/slider.js';
import FullscreenToggle from '../../src/js/control-bar/fullscreen-toggle.js';
import TestHelpers from './test-helpers.js';
import document from 'global/document';
-import Html5 from '../../src/js/tech/html5.js';
import sinon from 'sinon';
QUnit.... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | test/unit/player.test.js | @@ -344,7 +344,7 @@ QUnit.test('should default to 16:9 when fluid', function(assert) {
const player = TestHelpers.makePlayer({fluid: true});
const ratio = player.currentHeight() / player.currentWidth();
- // IE8 rounds 0.5625 up to 0.563
+ // account for some rounding of 0.5625 up to 0.563
assert.ok(((rati... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | test/unit/poster.test.js | @@ -49,25 +49,6 @@ QUnit.test('should create and update a poster image', function(assert) {
posterImage.dispose();
});
-QUnit.test('should create and update a fallback image in older browsers', function(assert) {
- browser.BACKGROUND_SIZE_SUPPORTED = false;
-
- const posterImage = new PosterImage(this.mockPlaye... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | test/unit/resize-manager.test.js | @@ -1,102 +1,97 @@
/* eslint-env qunit */
import ResizeManager from '../../src/js/resize-manager.js';
import TestHelpers from './test-helpers.js';
-import * as browser from '../../src/js/utils/browser.js';
import sinon from 'sinon';
-if (!browser.IS_IE8) {
-
- QUnit.module('ResizeManager', {
- beforeEach() {
... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | test/unit/test-helpers.js | @@ -33,15 +33,7 @@ const TestHelpers = {
return document.defaultView.getComputedStyle(el, null).getPropertyValue(rule);
}
- // IE8
- if (el.currentStyle) {
- if (rule === 'width' || rule === 'height') {
- // return clientWidth or clientHeight instead for better accuracy
- rule = '... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | test/unit/tracks/text-track-controls.test.js | @@ -1,7 +1,6 @@
/* eslint-env qunit */
import TextTrackMenuItem from '../../../src/js/control-bar/text-track-controls/text-track-menu-item.js';
import TestHelpers from '../test-helpers.js';
-import * as browser from '../../../src/js/utils/browser.js';
import sinon from 'sinon';
QUnit.module('Text Track Controls'... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | test/unit/tracks/text-track.test.js | @@ -5,10 +5,8 @@ import TrackBaseline from './track-baseline';
import TechFaker from '../tech/tech-faker';
import TextTrack from '../../../src/js/tracks/text-track.js';
import TestHelpers from '../test-helpers.js';
-import proxyquireify from 'proxyquireify';
import sinon from 'sinon';
-
-const proxyquire = proxyqui... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | test/unit/tracks/track-baseline.js | @@ -1,5 +1,4 @@
/* eslint-env qunit */
-import * as browser from '../../../src/js/utils/browser.js';
/**
* Tests baseline functionality for all tracks
@@ -35,10 +34,6 @@ const TrackBaseline = function(TrackClass, options) {
QUnit.test('returns an instance of itself on non ie8 browsers', function(assert) {
... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | test/unit/utils/dom.test.js | @@ -1,5 +1,4 @@
/* eslint-env qunit */
-import window from 'global/window';
import document from 'global/document';
import sinon from 'sinon';
import * as Dom from '../../../src/js/utils/dom.js';
@@ -546,30 +545,3 @@ QUnit.test('getBoundingClientRect() returns an object for elements that support
assert.strictE... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | test/unit/utils/log.test.js | @@ -92,27 +92,6 @@ QUnit.test('logging functions should work', function(assert) {
'history recorded the correct arguments');
});
-QUnit.test('in IE pre-11 (or when requested) objects and arrays are stringified', function(assert) {
-
- // Need to reset history here because there are extra message... | true |
Other | videojs | video.js | bc2da7c67bfe1be6deb811269ed3b4a438f8c1a6.json | refactor: remove IE8 specific changes (#5041)
BREAKING CHANGE: remove IE8, IE9, and IE10 specific JavaScript and CSS code. Remove Android 2.3 workaround. | test/unit/video.test.js | @@ -15,17 +15,6 @@ QUnit.module('video.js', {
}
});
-QUnit.test('should create a video tag and have access children in old IE', function(assert) {
- const fixture = document.getElementById('qunit-fixture');
-
- fixture.innerHTML += '<video id="test_vid_id"><source type="video/mp4"></video>';
-
- const vid = do... | true |
Other | videojs | video.js | 1b3c827d5e6d125ef918581b289030c9880533cf.json | feat: require enableSourceset option for event (#5031)
While sourceset is experimental, require the option `enableSourceset`.
This can easily be reversed in a minor update. | src/js/player.js | @@ -928,7 +928,8 @@ class Player extends Component {
'language': this.language(),
'playerElIngest': this.playerElIngest_ || false,
'vtt.js': this.options_['vtt.js'],
- 'canOverridePoster': !!this.options_.techCanOverridePoster
+ 'canOverridePoster': !!this.options_.techCanOverridePoster,
... | true |
Other | videojs | video.js | 1b3c827d5e6d125ef918581b289030c9880533cf.json | feat: require enableSourceset option for event (#5031)
While sourceset is experimental, require the option `enableSourceset`.
This can easily be reversed in a minor update. | src/js/tech/html5.js | @@ -34,7 +34,9 @@ class Html5 extends Tech {
constructor(options, ready) {
super(options, ready);
- this.setupSourcesetHandling_();
+ if (options.enableSourceset) {
+ this.setupSourcesetHandling_();
+ }
const source = options.source;
let crossoriginTracks = false; | true |
Other | videojs | video.js | 1b3c827d5e6d125ef918581b289030c9880533cf.json | feat: require enableSourceset option for event (#5031)
While sourceset is experimental, require the option `enableSourceset`.
This can easily be reversed in a minor update. | test/unit/sourceset.test.js | @@ -94,7 +94,9 @@ QUnit[qunitFn]('sourceset', function(hooks) {
const done = assert.async();
this.mediaEl.setAttribute('data-setup', JSON.stringify({sources: [this.testSrc]}));
- this.player = videojs(this.mediaEl);
+ this.player = videojs(this.mediaEl, {
+ enableSourceset: true
+ ... | true |
Other | videojs | video.js | d7f45bab89790fe84f8fcc162df2b9e2ff6d265b.json | docs(time-ranges): fix wrong comment for getRange function (#5026) | src/js/utils/time-ranges.js | @@ -56,7 +56,8 @@ function rangeCheck(fnName, index, maxIndex) {
}
/**
- * Check if any of the time ranges are over the maximum index.
+ * Get the time for the specified index at the start or end
+ * of a TimeRange object.
*
* @param {string} fnName
* The function name to use for logging | false |
Other | videojs | video.js | 46d8b3738567c43a4818dd0abe086fc4bd041dbd.json | fix(sourceset): set evt.src to empty string or src attr from load (#5016)
If .load() is called, we don't know what the new source will be because of the asynchronous nature of the resource selection algorithm. However, we can know if the src attribute is set on the video element because that's what will be chosen. So,... | src/js/player.js | @@ -1186,7 +1186,7 @@ class Player extends Component {
}
/**
- * Fired when the source is set or changed on the {@link Tech}
+ * *EXPERIMENTAL* Fired when the source is set or changed on the {@link Tech}
* causing the media element to reload.
*
* It will fire for the initial source and each subs... | true |
Other | videojs | video.js | 46d8b3738567c43a4818dd0abe086fc4bd041dbd.json | fix(sourceset): set evt.src to empty string or src attr from load (#5016)
If .load() is called, we don't know what the new source will be because of the asynchronous nature of the resource selection algorithm. However, we can know if the src attribute is set on the video element because that's what will be chosen. So,... | src/js/tech/html5.js | @@ -195,7 +195,12 @@ class Html5 extends Tech {
el.load = () => {
const retval = oldLoad.call(el);
- this.triggerSourceset(el.src || el.currentSrc);
+ // if `el.src` is set, that source will be loaded
+ // otherwise, we can't know for sure what source will be set because
+ // source el... | true |
Other | videojs | video.js | 46d8b3738567c43a4818dd0abe086fc4bd041dbd.json | fix(sourceset): set evt.src to empty string or src attr from load (#5016)
If .load() is called, we don't know what the new source will be because of the asynchronous nature of the resource selection algorithm. However, we can know if the src attribute is set on the video element because that's what will be chosen. So,... | test/karma.conf.js | @@ -169,7 +169,7 @@ function getCustomLaunchers(){
base: 'BrowserStack',
browser: 'safari',
os: 'OS X',
- os_version: 'Yosemite'
+ os_version: 'El Capitan'
},
edge_bs: { | true |
Other | videojs | video.js | 46d8b3738567c43a4818dd0abe086fc4bd041dbd.json | fix(sourceset): set evt.src to empty string or src attr from load (#5016)
If .load() is called, we don't know what the new source will be because of the asynchronous nature of the resource selection algorithm. However, we can know if the src attribute is set on the video element because that's what will be chosen. So,... | test/unit/sourceset.test.js | @@ -154,12 +154,12 @@ QUnit[qunitFn]('sourceset', function(hooks) {
const done = assert.async();
this.player = videojs(this.mediaEl);
- this.player.src(this.testSrc);
-
this.player.one('sourceset', () => {
validateSource(assert, this.player, [this.testSrc]);
done();
... | true |
Other | videojs | video.js | 2f96914b8e570fc16d19b546fa0bfe26ab0b727c.json | feat(format time): add setFormatTime for overriding the time format (#4962)
Add setFormatTime for Video.js to allow users to change the time format. Example usage:
```js
videojs.setFormatTime((seconds, guide) => `${seconds}, ${guide}`));
```
Add resetFormatTime to reset the time format to the default.
Fixe... | src/js/utils/format-time.js | @@ -1,9 +1,9 @@
/**
* @file format-time.js
- * @module Format-time
+ * @module format-time
*/
-/**
+ /**
* Format seconds as a time string, H:MM:SS or M:SS. Supplying a guide (in seconds)
* will force a number of leading zeros to cover the length of the guide.
*
@@ -16,7 +16,7 @@
* @return {string}
* ... | true |
Other | videojs | video.js | 2f96914b8e570fc16d19b546fa0bfe26ab0b727c.json | feat(format time): add setFormatTime for overriding the time format (#4962)
Add setFormatTime for Video.js to allow users to change the time format. Example usage:
```js
videojs.setFormatTime((seconds, guide) => `${seconds}, ${guide}`));
```
Add resetFormatTime to reset the time format to the default.
Fixe... | src/js/video.js | @@ -19,7 +19,7 @@ import AudioTrack from './tracks/audio-track.js';
import VideoTrack from './tracks/video-track.js';
import { createTimeRanges } from './utils/time-ranges.js';
-import formatTime from './utils/format-time.js';
+import formatTime, { setFormatTime, resetFormatTime } from './utils/format-time.js';
im... | true |
Other | videojs | video.js | 2f96914b8e570fc16d19b546fa0bfe26ab0b727c.json | feat(format time): add setFormatTime for overriding the time format (#4962)
Add setFormatTime for Video.js to allow users to change the time format. Example usage:
```js
videojs.setFormatTime((seconds, guide) => `${seconds}, ${guide}`));
```
Add resetFormatTime to reset the time format to the default.
Fixe... | test/unit/utils/format-time.test.js | @@ -1,7 +1,9 @@
/* eslint-env qunit */
-import formatTime from '../../../src/js/utils/format-time.js';
+import formatTime, { setFormatTime, resetFormatTime } from '../../../src/js/utils/format-time.js';
-QUnit.module('format-time');
+QUnit.module('format-time standard implementation', {
+ afterEach: resetFormatTime... | true |
Other | videojs | video.js | 62ff3f66a50c0a908188de9c140011e7c5fd44dc.json | feat: add mimetype type to source object when possible (#4469) (#4947)
File mimetype is filled when the file extension is known and type is not provided.
Fixes #4469, improves #4851. | src/js/utils/filter-source.js | @@ -2,6 +2,8 @@
* @module filter-source
*/
import {isObject} from './obj';
+import {MimetypesKind} from './mimetypes';
+import * as Url from '../utils/url.js';
/**
* Filter out single bad source objects or multiple source objects in an
@@ -34,10 +36,10 @@ const filterSource = function(src) {
src = newsrc... | true |
Other | videojs | video.js | 62ff3f66a50c0a908188de9c140011e7c5fd44dc.json | feat: add mimetype type to source object when possible (#4469) (#4947)
File mimetype is filled when the file extension is known and type is not provided.
Fixes #4469, improves #4851. | src/js/utils/mimetypes.js | @@ -0,0 +1,19 @@
+/**
+ * Mimetypes
+ *
+ * @see http://hul.harvard.edu/ois/////systems/wax/wax-public-help/mimetypes.htm
+ * @typedef Mimetypes~Kind
+ * @enum
+ */
+export const MimetypesKind = {
+ opus: 'video/ogg',
+ ogv: 'video/ogg',
+ mp4: 'video/mp4',
+ mov: 'video/mp4',
+ m4v: 'video/mp4',
+ mkv: 'video/x-... | true |
Other | videojs | video.js | 62ff3f66a50c0a908188de9c140011e7c5fd44dc.json | feat: add mimetype type to source object when possible (#4469) (#4947)
File mimetype is filled when the file extension is known and type is not provided.
Fixes #4469, improves #4851. | test/unit/utils/filter-source.test.js | @@ -122,3 +122,69 @@ QUnit.test('Dont filter extra object properties', function(assert) {
);
});
+
+QUnit.test('SourceObject type is filled with default values when extension is known', function(assert) {
+ assert.deepEqual(
+ filterSource('some-url.mp4'),
+ [{src: 'some-url.mp4', type: 'video/mp4'}],
+ ... | true |
Other | videojs | video.js | 50831e3381dfbb1f076a446896a528f9a085fbfe.json | fix: Add alternate text to the loading spinner. (#4916)
This is a first in a few changes related to #4902. This just adds a text alternative to the loading spinner. In future PRs, we would make it alert to screen readers and potentially have a generic alerting mechanism. | docs/translations-needed.md | @@ -15,7 +15,7 @@ This default value is hardcoded as a default to the localize method in the SeekB
<!-- START langtable -->
| Language file | Missing translations |
| ----------------------- | ---------------------------------------------------... | true |
Other | videojs | video.js | 50831e3381dfbb1f076a446896a528f9a085fbfe.json | fix: Add alternate text to the loading spinner. (#4916)
This is a first in a few changes related to #4902. This just adds a text alternative to the loading spinner. In future PRs, we would make it alert to screen readers and potentially have a generic alerting mechanism. | lang/en.json | @@ -80,5 +80,6 @@
"Done": "Done",
"Caption Settings Dialog": "Caption Settings Dialog",
"Beginning of dialog window. Escape will cancel and close the window.": "Beginning of dialog window. Escape will cancel and close the window.",
- "End of dialog window.": "End of dialog window."
+ "End of dialog window.":... | true |
Other | videojs | video.js | 50831e3381dfbb1f076a446896a528f9a085fbfe.json | fix: Add alternate text to the loading spinner. (#4916)
This is a first in a few changes related to #4902. This just adds a text alternative to the loading spinner. In future PRs, we would make it alert to screen readers and potentially have a generic alerting mechanism. | src/js/loading-spinner.js | @@ -2,6 +2,7 @@
* @file loading-spinner.js
*/
import Component from './component';
+import * as dom from './utils/dom';
/**
* A loading spinner for use during waiting/loading events.
@@ -17,10 +18,21 @@ class LoadingSpinner extends Component {
* The dom element that gets created.
*/
createE... | true |
Other | videojs | video.js | 7670db63cd93e52de9d3922097c8294311e54e87.json | fix(middleware): do a null check in mediator methods (#4913) | src/js/tech/middleware.js | @@ -96,7 +96,9 @@ function executeRight(mws, method, value, terminated) {
for (let i = mws.length - 1; i >= 0; i--) {
const mw = mws[i];
- mw[method](terminated, value);
+ if (mw[method]) {
+ mw[method](terminated, value);
+ }
}
}
| true |
Other | videojs | video.js | 7670db63cd93e52de9d3922097c8294311e54e87.json | fix(middleware): do a null check in mediator methods (#4913) | test/unit/tech/middleware.test.js | @@ -394,3 +394,18 @@ QUnit.test('setSource will select all middleware of a given type, until src chan
middleware.getMiddleware('video/foo').pop();
middleware.getMiddleware('video/foo').pop();
});
+
+QUnit.test('a middleware without a mediator method will not throw an error', function(assert) {
+ let pauseCalled... | true |
Other | videojs | video.js | 9ceb4e4fe0053224e7eba29dc7aeb3185b95837d.json | feat: playerresize event in all cases (#4864)
Use ResizeObserver when available for better and more performant resizing information, otherwise, fall back to a throttled resize event on an iframe that's the size of the player.
Allows a video.js user to disable this by setting resizeManager: false as an option since th... | docs/guides/components.md | @@ -18,6 +18,7 @@ The architecture of the Video.js player is centered around components. The `Play
* [Specific Component Details](#specific-component-details)
* [Volume Panel](#volume-panel)
* [Text Track Settings](#text-track-settings)
+ * [Resize Manager](#resize-manager)
## What is a Component?
@@ -312,... | true |
Other | videojs | video.js | 9ceb4e4fe0053224e7eba29dc7aeb3185b95837d.json | feat: playerresize event in all cases (#4864)
Use ResizeObserver when available for better and more performant resizing information, otherwise, fall back to a throttled resize event on an iframe that's the size of the player.
Allows a video.js user to disable this by setting resizeManager: false as an option since th... | package.json | @@ -35,8 +35,8 @@
"docs:api": "jsdoc -c .jsdoc.json",
"postdocs:api": "node ./build/fix-api-docs.js",
"netlify": "babel-node ./build/netlify-docs.js",
- "docs:lint": "remark -- './**/*.md'",
- "docs:fix": "remark --output -- './**/*.md'",
+ "docs:lint": "remark -- './{,!(node_modules)/**/}!(CHAN... | true |
Other | videojs | video.js | 9ceb4e4fe0053224e7eba29dc7aeb3185b95837d.json | feat: playerresize event in all cases (#4864)
Use ResizeObserver when available for better and more performant resizing information, otherwise, fall back to a throttled resize event on an iframe that's the size of the player.
Allows a video.js user to disable this by setting resizeManager: false as an option since th... | src/css/video-js.scss | @@ -42,3 +42,13 @@
@import "components/captions-settings";
@import "print";
+
+.vjs-resize-manager {
+ position: absolute;
+ top: 0;
+ left: 0;
+ width: 100%;
+ height: 100%;
+ border: none;
+ visibility: hidden;
+} | true |
Other | videojs | video.js | 9ceb4e4fe0053224e7eba29dc7aeb3185b95837d.json | feat: playerresize event in all cases (#4864)
Use ResizeObserver when available for better and more performant resizing information, otherwise, fall back to a throttled resize event on an iframe that's the size of the player.
Allows a video.js user to disable this by setting resizeManager: false as an option since th... | src/js/player.js | @@ -44,6 +44,7 @@ import './close-button.js';
import './control-bar/control-bar.js';
import './error-display.js';
import './tracks/text-track-settings.js';
+import './resize-manager.js';
// Import Html5 tech, at least for disposing the original video tag.
import './tech/html5.js';
@@ -661,14 +662,11 @@ class Pla... | true |
Other | videojs | video.js | 9ceb4e4fe0053224e7eba29dc7aeb3185b95837d.json | feat: playerresize event in all cases (#4864)
Use ResizeObserver when available for better and more performant resizing information, otherwise, fall back to a throttled resize event on an iframe that's the size of the player.
Allows a video.js user to disable this by setting resizeManager: false as an option since th... | src/js/resize-manager.js | @@ -0,0 +1,121 @@
+/**
+ * @file resize-manager.js
+ */
+import window from 'global/window';
+import { debounce } from './utils/fn.js';
+import * as Events from './utils/events.js';
+import mergeOptions from './utils/merge-options.js';
+import Component from './component.js';
+
+/**
+ * A Resize Manager. It is in charg... | true |
Other | videojs | video.js | 9ceb4e4fe0053224e7eba29dc7aeb3185b95837d.json | feat: playerresize event in all cases (#4864)
Use ResizeObserver when available for better and more performant resizing information, otherwise, fall back to a throttled resize event on an iframe that's the size of the player.
Allows a video.js user to disable this by setting resizeManager: false as an option since th... | src/js/utils/fn.js | @@ -3,6 +3,7 @@
* @module fn
*/
import { newGUID } from './guid.js';
+import window from 'global/window';
/**
* Bind (a.k.a proxy or Context). A simple method for changing the context of a function
@@ -68,3 +69,54 @@ export const throttle = function(fn, wait) {
return throttled;
};
+
+/**
+ * Creates a ... | true |
Other | videojs | video.js | 9ceb4e4fe0053224e7eba29dc7aeb3185b95837d.json | feat: playerresize event in all cases (#4864)
Use ResizeObserver when available for better and more performant resizing information, otherwise, fall back to a throttled resize event on an iframe that's the size of the player.
Allows a video.js user to disable this by setting resizeManager: false as an option since th... | test/api/api.js | @@ -118,6 +118,8 @@ QUnit.test('should be able to access expected component API methods', function(a
assert.ok(comp.clearInterval, 'clearInterval exists');
assert.ok(comp.setTimeout, 'setTimeout exists');
assert.ok(comp.clearTimeout, 'clearTimeout exists');
+
+ comp.dispose();
});
QUnit.test('should be ab... | true |
Other | videojs | video.js | 9ceb4e4fe0053224e7eba29dc7aeb3185b95837d.json | feat: playerresize event in all cases (#4864)
Use ResizeObserver when available for better and more performant resizing information, otherwise, fall back to a throttled resize event on an iframe that's the size of the player.
Allows a video.js user to disable this by setting resizeManager: false as an option since th... | test/unit/button.test.js | @@ -24,6 +24,7 @@ QUnit.test('should localize its text', function(assert) {
assert.ok(el.nodeName.toLowerCase().match('button'));
assert.ok(el.innerHTML.match(/vjs-control-text"?>Juego/));
assert.equal(el.getAttribute('title'), 'Juego');
- player.dispose();
+ testButton.dispose();
+ player.dispose();
}); | true |
Other | videojs | video.js | 9ceb4e4fe0053224e7eba29dc7aeb3185b95837d.json | feat: playerresize event in all cases (#4864)
Use ResizeObserver when available for better and more performant resizing information, otherwise, fall back to a throttled resize event on an iframe that's the size of the player.
Allows a video.js user to disable this by setting resizeManager: false as an option since th... | test/unit/component.test.js | @@ -86,6 +86,8 @@ QUnit.test('should create an element', function(assert) {
const comp = new Component(getFakePlayer(), {});
assert.ok(comp.el().nodeName);
+
+ comp.dispose();
});
QUnit.test('should add a child component', function(assert) {
@@ -98,6 +100,8 @@ QUnit.test('should add a child component', fun... | true |
Other | videojs | video.js | 9ceb4e4fe0053224e7eba29dc7aeb3185b95837d.json | feat: playerresize event in all cases (#4864)
Use ResizeObserver when available for better and more performant resizing information, otherwise, fall back to a throttled resize event on an iframe that's the size of the player.
Allows a video.js user to disable this by setting resizeManager: false as an option since th... | test/unit/controls.test.js | @@ -31,6 +31,7 @@ QUnit.test('should hide volume control if it\'s not supported', function(assert)
assert.ok(volumeControl.hasClass('vjs-hidden'), 'volumeControl is not hidden');
assert.ok(muteToggle.hasClass('vjs-hidden'), 'muteToggle is not hidden');
+
player.dispose();
});
@@ -56,6 +57,8 @@ QUnit.test(... | true |
Other | videojs | video.js | 9ceb4e4fe0053224e7eba29dc7aeb3185b95837d.json | feat: playerresize event in all cases (#4864)
Use ResizeObserver when available for better and more performant resizing information, otherwise, fall back to a throttled resize event on an iframe that's the size of the player.
Allows a video.js user to disable this by setting resizeManager: false as an option since th... | test/unit/menu.test.js | @@ -33,6 +33,7 @@ QUnit.test('should place title list item into ul', function(assert) {
assert.ok(titleElement.innerHTML === 'TestTitle', 'title element placed in ul');
+ menuButton.dispose();
player.dispose();
});
@@ -71,5 +72,6 @@ QUnit.test('clicking should display the menu', function(assert) {
as... | true |
Other | videojs | video.js | 9ceb4e4fe0053224e7eba29dc7aeb3185b95837d.json | feat: playerresize event in all cases (#4864)
Use ResizeObserver when available for better and more performant resizing information, otherwise, fall back to a throttled resize event on an iframe that's the size of the player.
Allows a video.js user to disable this by setting resizeManager: false as an option since th... | test/unit/player.test.js | @@ -1709,32 +1709,3 @@ QUnit.test('player.duration() sets the value of player.cache_.duration', functio
player.duration(200);
assert.equal(player.duration(), 200, 'duration() set and get integer duration value');
});
-
-QUnit.test('should fire playerresize when player is resized', function(assert) {
- assert.ex... | true |
Other | videojs | video.js | 9ceb4e4fe0053224e7eba29dc7aeb3185b95837d.json | feat: playerresize event in all cases (#4864)
Use ResizeObserver when available for better and more performant resizing information, otherwise, fall back to a throttled resize event on an iframe that's the size of the player.
Allows a video.js user to disable this by setting resizeManager: false as an option since th... | test/unit/poster.test.js | @@ -18,6 +18,7 @@ QUnit.module('PosterImage', {
return this.poster_;
},
handler_: null,
+ off() {},
on(type, handler) {
this.handler_ = handler;
},
@@ -44,6 +45,8 @@ QUnit.test('should create and update a poster image', function(assert) {
this.mockPlayer.trigger('po... | true |
Other | videojs | video.js | 9ceb4e4fe0053224e7eba29dc7aeb3185b95837d.json | feat: playerresize event in all cases (#4864)
Use ResizeObserver when available for better and more performant resizing information, otherwise, fall back to a throttled resize event on an iframe that's the size of the player.
Allows a video.js user to disable this by setting resizeManager: false as an option since th... | test/unit/resize-manager.test.js | @@ -0,0 +1,102 @@
+/* eslint-env qunit */
+import ResizeManager from '../../src/js/resize-manager.js';
+import TestHelpers from './test-helpers.js';
+import * as browser from '../../src/js/utils/browser.js';
+import sinon from 'sinon';
+
+if (!browser.IS_IE8) {
+
+ QUnit.module('ResizeManager', {
+ beforeEach() {
+... | true |
Other | videojs | video.js | 9ceb4e4fe0053224e7eba29dc7aeb3185b95837d.json | feat: playerresize event in all cases (#4864)
Use ResizeObserver when available for better and more performant resizing information, otherwise, fall back to a throttled resize event on an iframe that's the size of the player.
Allows a video.js user to disable this by setting resizeManager: false as an option since th... | test/unit/tracks/audio-tracks.test.js | @@ -33,6 +33,7 @@ QUnit.test('listen to remove and add track events in native audio tracks', funct
Html5.prototype.audioTracks = function() {
return {
+ removeEventListener() {},
addEventListener(type, handler) {
events[type] = true;
}
@@ -72,6 +73,7 @@ QUnit.test('listen to remove... | true |
Other | videojs | video.js | 9ceb4e4fe0053224e7eba29dc7aeb3185b95837d.json | feat: playerresize event in all cases (#4864)
Use ResizeObserver when available for better and more performant resizing information, otherwise, fall back to a throttled resize event on an iframe that's the size of the player.
Allows a video.js user to disable this by setting resizeManager: false as an option since th... | test/unit/tracks/text-tracks.test.js | @@ -82,6 +82,7 @@ QUnit.test('listen to remove and add track events in native text tracks', functi
Html5.prototype.textTracks = function() {
return {
+ removeEventListener() {},
addEventListener(type, handler) {
events[type] = true;
}
@@ -121,6 +122,8 @@ QUnit.test('listen to remov... | true |
Other | videojs | video.js | 9ceb4e4fe0053224e7eba29dc7aeb3185b95837d.json | feat: playerresize event in all cases (#4864)
Use ResizeObserver when available for better and more performant resizing information, otherwise, fall back to a throttled resize event on an iframe that's the size of the player.
Allows a video.js user to disable this by setting resizeManager: false as an option since th... | test/unit/tracks/video-tracks.test.js | @@ -33,6 +33,7 @@ QUnit.test('listen to remove and add track events in native video tracks', funct
Html5.prototype.videoTracks = function() {
return {
+ removeEventListener() {},
addEventListener(type, handler) {
events[type] = true;
} | true |
Other | videojs | video.js | a15e616a453006d2e8038efc98eef71bee268085.json | feat: Add `getPlayer` method to Video.js. (#4836) | docs/guides/setup.md | @@ -82,6 +82,28 @@ However, using an `id` attribute isn't always practical; so, the `videojs` funct
videojs(document.querySelector('.video-js'));
```
+### Getting References to Players
+
+Once players are created, Video.js keeps track of them internally. There are a few ways to get references to pre-existing player... | true |
Other | videojs | video.js | a15e616a453006d2e8038efc98eef71bee268085.json | feat: Add `getPlayer` method to Video.js. (#4836) | src/js/video.js | @@ -41,6 +41,17 @@ if (typeof HTMLVideoElement === 'undefined' && Dom.isReal()) {
document.createElement('video-js');
}
+/**
+ * Normalize an `id` value by trimming off a leading `#`
+ *
+ * @param {string} id
+ * A string, maybe with a leading `#`.
+ *
+ * @returns {string}
+ * The string, wi... | true |
Other | videojs | video.js | a15e616a453006d2e8038efc98eef71bee268085.json | feat: Add `getPlayer` method to Video.js. (#4836) | test/unit/video.test.js | @@ -372,6 +372,23 @@ QUnit.test('should create a new tag for movingMediaElementInDOM', function(asser
Html5.nativeSourceHandler.canPlayType = oldCPT;
});
+QUnit.test('getPlayer', function(assert) {
+ const fixture = document.getElementById('qunit-fixture');
+
+ fixture.innerHTML += '<video-js id="test_vid_id"><... | true |
Other | videojs | video.js | 41fd5cb4e6d7df627a35394eb395b1c2e0f657d9.json | test: add project and build names to browserstack (#4903) | test/karma.conf.js | @@ -1,4 +1,14 @@
module.exports = function(config) {
+ // build out a name for browserstack
+ // {TRAVIS_BUILD_NUMBER} [{TRAVIS_PULL_REQUEST} {PR_BRANCH}] {TRAVIS_BRANCH}
+ var browserstackName = process.env.TRAVIS_BUILD_NUMBER;
+
+ if (process.env.TRAVIS_PULL_REQUEST !== 'false') {
+ browserstackName += ' ' + ... | false |
Other | videojs | video.js | 673c23168492c3a2859ea6aa7184f0a80bdc1d8f.json | docs: add middleware guide (#4877)
* adding guide content
* fix link
* CR comments
* fixing a typo
* fixing example | docs/guides/middleware.md | @@ -0,0 +1,74 @@
+# Middleware
+
+Middleware is a Video.js feature that allows interaction with and modification of how the `Player` and `Tech` talk to each other. For more in-depth information, check out our [feature spotlight](http://blog.videojs.com/feature-spotlight-middleware/).
+
+## Table of Contents
+
+* [Under... | true |
Other | videojs | video.js | 673c23168492c3a2859ea6aa7184f0a80bdc1d8f.json | docs: add middleware guide (#4877)
* adding guide content
* fix link
* CR comments
* fixing a typo
* fixing example | src/js/tech/middleware.js | @@ -76,7 +76,7 @@ function setSourceHelper(src = {}, middleware = [], next, player, acc = [], last
// we've succeeded, now we need to go deeper
acc.push(mw);
- // if it's the same time, continue does the current chain
+ // if it's the same type, continue down the current chain
// otherw... | true |
Other | videojs | video.js | 83880b0f0b26554f321129b834c547b385808c7e.json | docs: fix some typos (#4880) | CHANGELOG.md | @@ -23,7 +23,7 @@
* **lang:** Complete the Simplified Chinese translations (zn-CN.json) ([#4827](https://github.com/videojs/video.js/issues/4827)) ([98773dd](https://github.com/videojs/video.js/commit/98773dd))
* **lang:** Complete the Traditional Chinese translation (zh-CT.json) ([#4828](https://github.com/videojs/v... | true |
Other | videojs | video.js | 83880b0f0b26554f321129b834c547b385808c7e.json | docs: fix some typos (#4880) | docs/guides/embeds.md | @@ -1,9 +1,9 @@
# How to Embed the Video.js player
-Video.js is meant to be an enhacement to the video element in HTML5 so for years, its embed code has been just a `<video>` element.
+Video.js is meant to be an enhancement to the video element in HTML5 and for years, its embed code has been just a `<video>` element... | true |
Other | videojs | video.js | 83880b0f0b26554f321129b834c547b385808c7e.json | docs: fix some typos (#4880) | docs/guides/text-tracks.md | @@ -230,7 +230,7 @@ As mentioned [above](#a-note-on-remote-text-tracks), remote text tracks represen
```js
const trackEl = player.addRemoteTextTrack({src: 'en.vtt'}, false);
trackEl.addEventListener('load', function() {
- // your callback go here
+ // your callback goes here
});
```
| true |
Other | videojs | video.js | 83880b0f0b26554f321129b834c547b385808c7e.json | docs: fix some typos (#4880) | src/js/button.js | @@ -89,7 +89,7 @@ class Button extends ClickableComponent {
}
/**
- * Enable the `Button` element so that it cannot be activated or clicked. Use this with
+ * Disable the `Button` element so that it cannot be activated or clicked. Use this with
* {@link Button#enable}.
*/
disable() { | true |
Other | videojs | video.js | 8f450ea0b4750253a2986fec8c10481b32afeaf3.json | chore(netlify): add some debug info in the netlify command (#4862) | build/netlify-docs.js | @@ -1,9 +1,13 @@
const sh = require('shelljs');
const GIT_CONTAINS = `git tag --contains ${process.env.COMMIT_REF}`;
-
const output = sh.exec(GIT_CONTAINS, {async: false, silent:true}).stdout;
+console.log('CONTAINS command:', GIT_CONTAINS);
+console.log('BRANCH:', process.env.BRANCH);
+console.log('OUTPUT', out... | false |
Other | videojs | video.js | dede592ab71ee9277d864749ef67d9d89efbaced.json | chore: remove unused deps (#4814) | build/grunt.js | @@ -1,5 +1,4 @@
import {gruntCustomizer, gruntOptionsMaker} from './options-customizer.js';
-import chg from 'chg';
import npmRun from 'npm-run';
import isDocsOnly from './docs-only.js';
@@ -28,22 +27,6 @@ module.exports = function(grunt) {
]
};
- const githubReleaseDefaults = {
- options: {
- r... | true |
Other | videojs | video.js | dede592ab71ee9277d864749ef67d9d89efbaced.json | chore: remove unused deps (#4814) | package-lock.json | @@ -454,12 +454,6 @@
}
}
},
- "async": {
- "version": "0.2.10",
- "resolved": "https://registry.npmjs.org/async/-/async-0.2.10.tgz",
- "integrity": "sha1-trvgsGdLnXGXCMo43owjfLUmw9E=",
- "dev": true
- },
"async-each": {
"version": "1.0.1",
"resolved": "h... | true |
Other | videojs | video.js | dede592ab71ee9277d864749ef67d9d89efbaced.json | chore: remove unused deps (#4814) | package.json | @@ -24,7 +24,6 @@
"rollup-dev": "babel-node build/rollup.js --watch",
"watch": "npm run rollup-dev",
"assets": "node build/assets.js",
- "change": "grunt chg-add",
"clean": "grunt clean",
"grunt": "grunt",
"lint": "vjsstandard",
@@ -67,13 +66,10 @@
"babel-preset-es3": "^1.0.1",
... | true |
Other | videojs | video.js | f47a083d709aebf353695731983bf3d4cc10e544.json | feat(css): add a delay before showing loading spinner (#4806) | src/css/components/_loading.scss | @@ -17,11 +17,14 @@
width: 50px;
height: 50px;
border-radius: 25px;
+ visibility: hidden;
}
.vjs-seeking .vjs-loading-spinner,
.vjs-waiting .vjs-loading-spinner {
display: block;
+ // add a delay before actual show the spinner
+ animation: 0s linear 0.3s forwards vjs-spinner-show;
}
.vjs-loading... | false |
Other | videojs | video.js | e0ed0b5cd762f83dc54a7b56e8774718485e924d.json | feat: playerresize event on Player dimension API calls (#4800)
Trigger a `playerresize` event when `width()`, `height()`, or `dimensions()` is called.
First part of #4629. | src/js/player.js | @@ -661,11 +661,14 @@ class Player extends Component {
* @param {number} [value]
* The value to set the `Player`'s width to.
*
+ * @param {boolean} [skipListeners]
+ * Skip the playerresize event trigger
+ *
* @return {number}
* The current width of the `Player` when gett... | true |
Other | videojs | video.js | e0ed0b5cd762f83dc54a7b56e8774718485e924d.json | feat: playerresize event on Player dimension API calls (#4800)
Trigger a `playerresize` event when `width()`, `height()`, or `dimensions()` is called.
First part of #4629. | test/unit/player.test.js | @@ -1709,3 +1709,32 @@ QUnit.test('player.duration() sets the value of player.cache_.duration', functio
player.duration(200);
assert.equal(player.duration(), 200, 'duration() set and get integer duration value');
});
+
+QUnit.test('should fire playerresize when player is resized', function(assert) {
+ assert.ex... | true |
Other | videojs | video.js | ba0f20ec3548a8069e9a9a907978ed50246e8ada.json | feat: add support for debug logging (#4780)
Adds support for `debug` as an available logging method under `videojs.log`
Changes the default log level from `all` to `info` | docs/guides/debugging.md | @@ -12,22 +12,23 @@
## Logging
-Video.js includes `videojs.log`, a lightweight wrapper around a subset of [the `console` API][console]. The available methods are `videojs.log`, `videojs.log.warn`, and `videojs.log.error`.
+Video.js includes `videojs.log`, a lightweight wrapper around a subset of [the `console` API... | true |
Other | videojs | video.js | ba0f20ec3548a8069e9a9a907978ed50246e8ada.json | feat: add support for debug logging (#4780)
Adds support for `debug` as an available logging method under `videojs.log`
Changes the default log level from `all` to `info` | src/js/utils/log.js | @@ -9,7 +9,7 @@ import {isObject} from './obj';
let log;
// This is the private tracking variable for logging level.
-let level = 'all';
+let level = 'info';
// This is the private tracking variable for the logging history.
let history = [];
@@ -48,11 +48,20 @@ export const logByType = (type, args, stringify = ... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.