language stringclasses 1
value | owner stringlengths 2 15 | repo stringlengths 2 21 | sha stringlengths 45 45 | message stringlengths 7 36.3k | path stringlengths 1 199 | patch stringlengths 15 102k | is_multipart bool 2
classes |
|---|---|---|---|---|---|---|---|
Other | videojs | video.js | b4ebd9ba008edf5e1708460398771d0f5c8c84bd.json | test: fix tests on older IE (#3800) | test/unit/tracks/text-track-controls.test.js | @@ -408,7 +408,8 @@ test('chapters menu should use track label as menu title', function() {
player.controlBar.chaptersButton.update();
const menu = player.controlBar.chaptersButton.menu;
- const menuTitle = menu.contentEl().firstChild.textContent;
+ const titleEl = menu.contentEl().firstChild;
+ const menuTi... | true |
Other | videojs | video.js | d69551ac8032bae333a2df07e65ebd0531e75a76.json | refactor(html5): remove confusing references to player in a tech (#3790)
These references to player_ are actually not the player due to techs not having a reference to the player. | src/js/tech/html5.js | @@ -443,11 +443,11 @@ class Html5 extends Tech {
if (this.el_.duration === Infinity) {
this.trigger('durationchange');
}
- this.off(this.player_, 'timeupdate', checkProgress);
+ this.off('timeupdate', checkProgress);
}
};
- this... | false |
Other | videojs | video.js | 72fcb6c65919766c22793e56792b3b3bb5d1ee4a.json | chore(pr_template): add checkbox to verify changes in a browser (#3775) | .github/PULL_REQUEST_TEMPLATE.md | @@ -10,6 +10,7 @@ Please list the specific changes involved in this pull request.
## Requirements Checklist
- [ ] Feature implemented / Bug fixed
- [ ] If necessary, more likely in a feature request than a bug fix
+ - [ ] Change has been verified in an actual browser (Chome, Firefox, IE)
- [ ] Unit Tests updated... | false |
Other | videojs | video.js | 6b477bb737fae1b8c81b6221d8ef537866cc573c.json | chore(package): update karma-detect-browsers to version 2.2.3 (#3770)
https://greenkeeper.io/ | package.json | @@ -92,7 +92,7 @@
"karma-browserstack-launcher": "^1.0.1",
"karma-chrome-launcher": "^2.0.0",
"karma-coverage": "^1.1.1",
- "karma-detect-browsers": "~2.1.0",
+ "karma-detect-browsers": "~2.2.3",
"karma-firefox-launcher": "^1.0.0",
"karma-ie-launcher": "^1.0.0",
"karma-opera-launcher... | false |
Other | videojs | video.js | 996507744f064ac7d7747d5059152c624616cfb1.json | test(dom): fix removeElClass test in Safari 10. (#3768)
Safari 10 automatically dedupes duplicate class names in an element. So,
our test was failing because we had an extra "foo" in the check. This is
an unlikely scenario that has browser variations, so, better to just
remove it. | test/unit/utils/dom.test.js | @@ -105,17 +105,12 @@ QUnit.test('addElClass()', function(assert) {
QUnit.test('removeElClass()', function(assert) {
const el = document.createElement('div');
- el.className = 'test-class foo foo test2_className FOO bar';
+ el.className = 'test-class test2_className FOO bar';
- assert.expect(5);
+ assert.ex... | false |
Other | videojs | video.js | b6d521f472087085f5dd4e31f4237b1f31e34ca1.json | chore(package): update grunt-accessibility to version 5.0.0 (#3747)
https://greenkeeper.io/ | package.json | @@ -66,7 +66,7 @@
"ghooks": "^1.3.2",
"gkatsev-grunt-sass": "^1.1.1",
"grunt": "^0.4.4",
- "grunt-accessibility": "^4.1.0",
+ "grunt-accessibility": "^5.0.0",
"grunt-babel": "^6.0.0",
"grunt-banner": "^0.4.0",
"grunt-browserify": "3.5.1", | false |
Other | videojs | video.js | 8d51235b306af831cca9b71832798e552542a212.json | docs(collaborator_guide): add collaborator guide (#3724)
This adds a collaborator guide that describes how to reply to issues and PRs and how to accept changes to the project. | COLLABORATOR_GUIDE.md | @@ -0,0 +1,318 @@
+# Collaborator Guide
+
+<!-- START doctoc generated TOC please keep comment here to allow auto update -->
+<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
+**Table of Contents**
+
+- [Issues and Pull Requests](#issues-and-pull-requests)
+- [Accepting changes](#accepting-changes)
+ ... | false |
Other | videojs | video.js | 11a096d60f356d273eb2080258c9c43f582c6246.json | docs(contributing.md): update CONTRIBUTING.md with latest info (#3722)
Update CONTRIBUTING.md with inspiration and dev certificate of origin from node's CONTRIBUTING.md.
Add grunt and doctoc npm scripts. | CONTRIBUTING.md | @@ -1,121 +1,125 @@
-CONTRIBUTING
-============
+# CONTRIBUTING
+
So you want to help out? Great! There's a number of ways you can get involved.
- * [File and discuss issues](#filing-issues)
- * [Contribute code](#contributing-code)
- * [Build and share plugins](docs/guides/plugins.md)
- * [Answer questions on S... | true |
Other | videojs | video.js | 11a096d60f356d273eb2080258c9c43f582c6246.json | docs(contributing.md): update CONTRIBUTING.md with latest info (#3722)
Update CONTRIBUTING.md with inspiration and dev certificate of origin from node's CONTRIBUTING.md.
Add grunt and doctoc npm scripts. | package.json | @@ -20,9 +20,11 @@
"build": "grunt dist",
"change": "grunt chg-add",
"clean": "grunt clean",
+ "grunt": "grunt",
"lint": "vjsstandard",
"start": "grunt watchAll",
- "test": "grunt test"
+ "test": "grunt test",
+ "toc": "doctoc"
},
"repository": {
"type": "git",
@@ -58,6 +... | true |
Other | videojs | video.js | 6889e925b4ec361f2cfcac1d9bf8feb66c1fc0ab.json | refactor: remove un-needed contructor and function overrides (#3721) | src/js/big-play-button.js | @@ -15,10 +15,6 @@ import Component from './component.js';
*/
class BigPlayButton extends Button {
- constructor(player, options) {
- super(player, options);
- }
-
/**
* Allow sub components to stack CSS class names
* | true |
Other | videojs | video.js | 6889e925b4ec361f2cfcac1d9bf8feb66c1fc0ab.json | refactor: remove un-needed contructor and function overrides (#3721) | src/js/button.js | @@ -16,10 +16,6 @@ import assign from 'object.assign';
*/
class Button extends ClickableComponent {
- constructor(player, options) {
- super(player, options);
- }
-
/**
* Create the component's DOM element
* | true |
Other | videojs | video.js | 6889e925b4ec361f2cfcac1d9bf8feb66c1fc0ab.json | refactor: remove un-needed contructor and function overrides (#3721) | src/js/clickable-component.js | @@ -116,26 +116,6 @@ class ClickableComponent extends Component {
return `vjs-control vjs-button ${super.buildCSSClass()}`;
}
- /**
- * Adds a child component inside this clickable-component
- *
- * @param {String|Component} child The class name or instance of a child to add
- * @param {Object=} opti... | true |
Other | videojs | video.js | 2e720afb65c0e0522a0192c9afc6cf75e30f689f.json | fix: allow rounded value for fluid player ratio test (#3739) | test/unit/player.test.js | @@ -323,8 +323,10 @@ QUnit.test('should set the width, height, and aspect ratio via a css class', fun
QUnit.test('should default to 16:9 when fluid', function(assert) {
const player = TestHelpers.makePlayer({fluid: true});
+ const ratio = player.currentHeight() / player.currentWidth();
- assert.equal(player.c... | false |
Other | videojs | video.js | 9702618c0238461ec4a7444f52618fc0c29ae4bb.json | feat: add a safe computedStyle to videojs. (#3664)
This is used internally in the seek bar and mouse time display.
In firefox, in an iframe that is hidden with "display: none",
getComputedStyle() returns "null" which can break things.
See https://bugzilla.mozilla.org/show_bug.cgi?id=548397 for more
details. | src/js/control-bar/progress-control/mouse-time-display.js | @@ -1,12 +1,12 @@
/**
* @file mouse-time-display.js
*/
-import window from 'global/window';
import Component from '../../component.js';
import * as Dom from '../../utils/dom.js';
import * as Fn from '../../utils/fn.js';
import formatTime from '../../utils/format-time.js';
import throttle from 'lodash-compat/f... | true |
Other | videojs | video.js | 9702618c0238461ec4a7444f52618fc0c29ae4bb.json | feat: add a safe computedStyle to videojs. (#3664)
This is used internally in the seek bar and mouse time display.
In firefox, in an iframe that is hidden with "display: none",
getComputedStyle() returns "null" which can break things.
See https://bugzilla.mozilla.org/show_bug.cgi?id=548397 for more
details. | src/js/control-bar/progress-control/seek-bar.js | @@ -1,11 +1,11 @@
/**
* @file seek-bar.js
*/
-import window from 'global/window';
import Slider from '../../slider/slider.js';
import Component from '../../component.js';
import * as Fn from '../../utils/fn.js';
import formatTime from '../../utils/format-time.js';
+import computedStyle from '../../utils/comput... | true |
Other | videojs | video.js | 9702618c0238461ec4a7444f52618fc0c29ae4bb.json | feat: add a safe computedStyle to videojs. (#3664)
This is used internally in the seek bar and mouse time display.
In firefox, in an iframe that is hidden with "display: none",
getComputedStyle() returns "null" which can break things.
See https://bugzilla.mozilla.org/show_bug.cgi?id=548397 for more
details. | src/js/utils/computed-style.js | @@ -0,0 +1,27 @@
+import window from 'global/window';
+
+/**
+ * A safe getComputedStyle with an IE8 fallback.
+ *
+ * This is because in Firefox, if the player is loaded in an iframe with `display:none`,
+ * then `getComputedStyle` returns `null`, so, we do a null-check to make sure
+ * that the player doesn't break i... | true |
Other | videojs | video.js | 9702618c0238461ec4a7444f52618fc0c29ae4bb.json | feat: add a safe computedStyle to videojs. (#3664)
This is used internally in the seek bar and mouse time display.
In firefox, in an iframe that is hidden with "display: none",
getComputedStyle() returns "null" which can break things.
See https://bugzilla.mozilla.org/show_bug.cgi?id=548397 for more
details. | src/js/video.js | @@ -25,6 +25,7 @@ import log from './utils/log.js';
import * as Dom from './utils/dom.js';
import * as browser from './utils/browser.js';
import * as Url from './utils/url.js';
+import computedStyle from './utils/computed-style.js';
import extendFn from './extend.js';
import merge from 'lodash-compat/object/merge'... | true |
Other | videojs | video.js | 254683b5cd62832d4764fcd06e4650a1b4ba4c87.json | chore(changelog.md): update 5.12.6 and 5.12.3 (#3715)
5.12.6's changelog accidentally included all the 5.12.x changes and the
link to the comparison was from 5.10.7 to 5.12.6.
The comparison link in 5.12.3 was also updated to properly refer to
5.12.2 as the previous change. | CHANGELOG.md | @@ -1,46 +1,10 @@
<a name="5.12.6"></a>
-## [5.12.6](https://github.com/videojs/video.js/compare/v5.10.7...v5.12.6) (2016-10-25)
-
-### Features
-
-* **lang:** add missing translations in fr.json ([280ecd4](https://github.com/videojs/video.js/commit/280ecd4))
-* **lang:** add missing translations to el.json ([eb0efd4]... | false |
Other | videojs | video.js | fe760a44d7807c6b54377a825ca9f9f0e92848ed.json | fix: remove unnecessary comments from video.min.js (#3709)
This involves updating to latest version of uglify and setting
"screwIE8" to false since that is a default in 2.7. However, this makes
"preserveComments" "some" work as it is supposed to work.
Fixes #3707. This also comes from the stable branch after the 5.11... | CHANGELOG.md | @@ -87,6 +87,11 @@
* @gkatsev added tests for webpack and browserify bundling and node.js requiring ([view](https://github.com/videojs/video.js/pull/3558))
* @rlchung fixed tests that weren't disposing players when they finished ([view](https://github.com/videojs/video.js/pull/3524))
+## 5.11.9 (2016-10-25)
+* gree... | true |
Other | videojs | video.js | fe760a44d7807c6b54377a825ca9f9f0e92848ed.json | fix: remove unnecessary comments from video.min.js (#3709)
This involves updating to latest version of uglify and setting
"screwIE8" to false since that is a default in 2.7. However, this makes
"preserveComments" "some" work as it is supposed to work.
Fixes #3707. This also comes from the stable branch after the 5.11... | build/grunt.js | @@ -105,6 +105,7 @@ module.exports = function(grunt) {
uglify: {
options: {
preserveComments: 'some',
+ screwIE8: false,
mangle: true,
compress: {
sequences: true, | true |
Other | videojs | video.js | fe760a44d7807c6b54377a825ca9f9f0e92848ed.json | fix: remove unnecessary comments from video.min.js (#3709)
This involves updating to latest version of uglify and setting
"screwIE8" to false since that is a default in 2.7. However, this makes
"preserveComments" "some" work as it is supposed to work.
Fixes #3707. This also comes from the stable branch after the 5.11... | package.json | @@ -74,7 +74,7 @@
"grunt-contrib-connect": "~0.7.1",
"grunt-contrib-copy": "^0.8.0",
"grunt-contrib-cssmin": "~1.0.2",
- "grunt-contrib-uglify": "~0.11.0",
+ "grunt-contrib-uglify": "^2.0.0",
"grunt-contrib-watch": "~0.1.4",
"grunt-coveralls": "^1.0.0",
"grunt-fastly": "^0.1.3", | true |
Other | videojs | video.js | 16c855931b9a52d131904eb883ab2b0ef6abd4eb.json | docs(options.md): Remove Bad Apostrophe (#3677)
A possessive belonging to an "it" doesn't need an apostrophe. Don't believe me? Ask [the Oatmeal](http://theoatmeal.com/comics/apostrophe) (look for the velociraptor)! | docs/guides/options.md | @@ -54,7 +54,7 @@ or
### autoplay ###
If autoplay is true, the video will start playing as soon as page is loaded (without any interaction from the user).
-NOT SUPPORTED BY APPLE iOS DEVICES. Apple blocks the autoplay functionality in an effort to protect it's customers from unwillingly using a lot of their (often ... | false |
Other | videojs | video.js | 54e3db5d3423a17abc2f3bf24df7041061f2c102.json | chore(package): update grunt-contrib-cssmin to version 1.0.2 (#3595)
https://greenkeeper.io/ | package.json | @@ -70,7 +70,7 @@
"grunt-contrib-concat": "^0.5.1",
"grunt-contrib-connect": "~0.7.1",
"grunt-contrib-copy": "^0.8.0",
- "grunt-contrib-cssmin": "~0.6.0",
+ "grunt-contrib-cssmin": "~1.0.2",
"grunt-contrib-uglify": "~0.11.0",
"grunt-contrib-watch": "~0.1.4",
"grunt-coveralls": "^1.0.... | false |
Other | videojs | video.js | 2032b17943fe265eb2cfaa2cda1f2ea0f879ad9b.json | chore(package): update grunt-shell to version 2.0.0 (#3642)
https://greenkeeper.io/ | package.json | @@ -77,7 +77,7 @@
"grunt-fastly": "^0.1.3",
"grunt-github-releaser": "^0.1.17",
"grunt-karma": "^2.0.0",
- "grunt-shell": "^1.3.0",
+ "grunt-shell": "^2.0.0",
"grunt-version": "~0.3.0",
"grunt-videojs-languages": "0.0.4",
"grunt-zip": "0.10.2", | false |
Other | videojs | video.js | 4063f96bb5581123959fd17c10f666bf2bf17ebd.json | docs: fix broken links in docs index.md | docs/index.md | @@ -33,5 +33,5 @@ There are two categories of docs: [Guides](./guides/) and [API docs](./api/). Gu
* [Removing Players](./guides/removing-players.md) - Helpful for using VideoJS in single page apps.
## API Docs
-- The most relevant API doc is the [player API doc](./api/vjs.Player.md).
-- [Full list of API Docs](./a... | false |
Other | videojs | video.js | 280ecd49d714d029b1fda2dd0c9840151458dbcf.json | feat(lang): add missing translations in fr.json | docs/translations-needed.md | @@ -129,7 +129,7 @@ If you add or update a translation run `grunt check-translations` to update the
| | , opens subtitles settings dialog |
| | , opens descriptions settings dialog ... | true |
Other | videojs | video.js | 280ecd49d714d029b1fda2dd0c9840151458dbcf.json | feat(lang): add missing translations in fr.json | lang/fr.json | @@ -27,6 +27,7 @@
"The media could not be loaded, either because the server or network failed or because the format is not supported.": "Cette vidéo n'a pas pu être chargée, soit parce que le serveur ou le réseau a échoué ou parce que le format n'est pas reconnu.",
"The media playback was aborted due to a corrupt... | true |
Other | videojs | video.js | eb0efd499c4afd1291614163d3e25e0116a715b2.json | feat(lang): add missing translations to el.json | docs/translations-needed.md | @@ -86,13 +86,7 @@ If you add or update a translation run `grunt check-translations` to update the
| | , opens descriptions settings dialog |
| | , selected ... | true |
Other | videojs | video.js | eb0efd499c4afd1291614163d3e25e0116a715b2.json | feat(lang): add missing translations to el.json | lang/el.json | @@ -18,17 +18,23 @@
"Captions": "Λεζάντες",
"captions off": "απόκρυψη λεζάντων",
"Chapters": "Κεφάλαια",
+ "Close Modal Dialog": "Κλείσιμο παραθύρου",
+ "Descriptions": "Περιγραφές",
+ "descriptions off": "απόκρυψη περιγραφών",
+ "Audio Track": "Ροή ήχου",
"You aborted the media playback": "Ακυρώσατε τη... | true |
Other | videojs | video.js | 08c7f4e1d499b66f2020e32efcf53d217f875a2b.json | chore: update object.assign to ^4.0.4
Updates `object.assign` to the latest, and uses a semver range so that consumers can `npm dedupe`. | package.json | @@ -31,7 +31,7 @@
"babel-runtime": "^6.9.2",
"global": "4.3.0",
"lodash-compat": "3.10.2",
- "object.assign": "4.0.3",
+ "object.assign": "^4.0.4",
"safe-json-parse": "4.0.0",
"tsml": "1.0.1",
"videojs-font": "2.0.0", | false |
Other | videojs | video.js | f787cbad18aac712ede0e560284edec0a691b855.json | Update grunt-concurrent to version 2.3.1 🚀 (#3532)
* chore(package): update grunt-concurrent to version 2.3.1
https://greenkeeper.io/
* update CHANGELOG | CHANGELOG.md | @@ -16,6 +16,7 @@ CHANGELOG
* @gkatsev reverted back to qunitjs 1.x to unbreak IE8. Added es5-shim to tests ([view](https://github.com/videojs/video.js/pull/3533))
* @gkatsev updated build system to open es5 folder for bundles and dist folder other users ([view](https://github.com/videojs/video.js/pull/3445))
* gree... | true |
Other | videojs | video.js | f787cbad18aac712ede0e560284edec0a691b855.json | Update grunt-concurrent to version 2.3.1 🚀 (#3532)
* chore(package): update grunt-concurrent to version 2.3.1
https://greenkeeper.io/
* update CHANGELOG | package.json | @@ -59,7 +59,7 @@
"grunt-banner": "^0.4.0",
"grunt-browserify": "3.5.1",
"grunt-cli": "~0.1.13",
- "grunt-concurrent": "^1.0.0",
+ "grunt-concurrent": "^2.3.1",
"grunt-contrib-clean": "~0.4.0a",
"grunt-contrib-concat": "^0.5.1",
"grunt-contrib-connect": "~0.7.1", | true |
Other | videojs | video.js | db0e821f38af5cb682da2b2f685abc7464595863.json | Add DOMException to jshint to appease it | .jshintrc | @@ -24,6 +24,8 @@
"exports",
"process",
+ "DOMException",
+
"q",
"asyncTest",
"deepEqual", | false |
Other | videojs | video.js | c306e4f7f38447f24f197ec3c4d34661996f9620.json | update CHANGELOG for new patch release | CHANGELOG.md | @@ -2,7 +2,7 @@ CHANGELOG
=========
## HEAD (Unreleased)
-_(none)_
+* @gkatsev re-published to make sure that the audio button has css
--------------------
| false |
Other | videojs | video.js | 4f6cb03adde9ddf800e2ecf6fa87b07d436b74e8.json | Update CHANGELOG for linter changes. Closes #3459 | CHANGELOG.md | @@ -2,7 +2,8 @@ CHANGELOG
=========
## HEAD (Unreleased)
-_(none)_
+* @misteroneill, @BrandonOCasey, and @pagarwal123 updates all the code to pass the linter ([view](https://github.com/videojs/video.js/pull/3459))
+* @misteroneill added ghooks to run linter on git push ([view](https://github.com/videojs/video.js/pu... | false |
Other | videojs | video.js | 3070e738f1c63044eae24d78847466d5ece4010f.json | fix IE8 tests for VIDEOJS_NO_DYNAMIC_STYLE. closes #3215 | CHANGELOG.md | @@ -9,6 +9,7 @@ CHANGELOG
* @ricardosiri68 changed the relative sass paths ([view](https://github.com/videojs/video.js/pull/3147))
* @gkatsev added an option to keep the tooltips inside the player bounds ([view](https://github.com/videojs/video.js/pull/3149))
* @defli added currentWidth and currentHeight methods to ... | false |
Other | videojs | video.js | 4cb14eb420270db1b136e3c85726b2a3376d64ee.json | Update plugin documentation to reflect icon usage | docs/guides/plugins.md | @@ -45,3 +45,7 @@ If you've already initialized your video tag, you can activate a plugin at any t
video.examplePlugin({ exampleOption: true });
That's it. Head on over to the [Video.js wiki](https://github.com/videojs/video.js/wiki/Plugins) and add your plugin to the list so everyone else can check it out.
+
+... | false |
Other | videojs | video.js | 977eedda79c009bbab0b37c6e9c98b237490f8cb.json | Update CHANGELOG for RTMP | CHANGELOG.md | @@ -5,6 +5,8 @@ CHANGELOG
* @gkatsev made initListeners more general and added Tech.isTech. Fixes #2767 ([view](https://github.com/videojs/video.js/pull/2773))
* @dmlap updated swf to 5.0.1 ([view](https://github.com/videojs/video.js/pull/2795))
* @gkatsev added a tech registry. Fixes #2772 ([view](https://github.co... | false |
Other | videojs | video.js | 4e395b6b0261286f23a5cd42724a893071c2f044.json | Add unit test for new rtmp path changes | test/unit/tech/flash-rtmp.test.js | @@ -22,6 +22,10 @@ test('test streamToParts', function() {
ok(parts.connection === 'http://myurl.com/');
ok(parts.stream === 'streaming&/is/fun');
+ parts = Flash.streamToParts('http://myurl.com/really?streaming=fun&really=fun');
+ ok(parts.connection === 'http://myurl.com/');
+ ok(parts.stream === 'really?s... | false |
Other | videojs | video.js | 6beb0eb29930e4b42d84c1663b4434fba525ebb1.json | Update version in readme code | README.md | @@ -9,8 +9,8 @@ Thanks to the awesome folks over at [Fastly](http://www.fastly.com/), there's a
`<head>`:
```html
-<link href="http://vjs.zencdn.net/4.12/video-js.css" rel="stylesheet">
-<script src="http://vjs.zencdn.net/4.12/video.js"></script>
+<link href="http://vjs.zencdn.net/5.0/video-js.min.css" rel="stylesh... | false |
Other | videojs | video.js | 24cdbdefff67d2e9e4b8a6188000b8066ccab13e.json | Use Raynos/xhr for XMLHttpRequests
- Get rid of our custom XHR shim. Export it as videojs.xhr.
- Updated XHR to be stubbed everywhere in tests to prevent errors.
- Added npm install to the review process
closes #2318
closes #2594 | CHANGELOG.md | @@ -134,6 +134,7 @@ CHANGELOG
* @heff added an attributes argument to createEl() ([view](https://github.com/videojs/video.js/pull/2589))
* @heff made tech related functions private in the player ([view](https://github.com/videojs/video.js/pull/2590))
* @heff removed the loadedalldata event ([view](https://github.com... | true |
Other | videojs | video.js | 24cdbdefff67d2e9e4b8a6188000b8066ccab13e.json | Use Raynos/xhr for XMLHttpRequests
- Get rid of our custom XHR shim. Export it as videojs.xhr.
- Updated XHR to be stubbed everywhere in tests to prevent errors.
- Added npm install to the review process
closes #2318
closes #2594 | contrib.json | @@ -330,6 +330,7 @@
[ "git merge-base master FETCH_HEAD", "Get the common ancestor commit", "base" ],
[ "git checkout -b review-{{pr.user.login}}-{{pr.head.ref}} {{base}}", "Create a new local branch for the pull request that has a base of the common commit" ],
[ "git merge ... | true |
Other | videojs | video.js | 24cdbdefff67d2e9e4b8a6188000b8066ccab13e.json | Use Raynos/xhr for XMLHttpRequests
- Get rid of our custom XHR shim. Export it as videojs.xhr.
- Updated XHR to be stubbed everywhere in tests to prevent errors.
- Added npm install to the review process
closes #2318
closes #2594 | package.json | @@ -31,7 +31,8 @@
"videojs-font": "1.3.0",
"videojs-ie8": "1.1.0",
"videojs-swf": "5.0.0-rc1",
- "vtt.js": "git+https://github.com/gkatsev/vtt.js.git#vjs-v0.12.1"
+ "vtt.js": "git+https://github.com/gkatsev/vtt.js.git#vjs-v0.12.1",
+ "xhr": "2.1.0"
},
"devDependencies": {
"babel": "^5... | true |
Other | videojs | video.js | 24cdbdefff67d2e9e4b8a6188000b8066ccab13e.json | Use Raynos/xhr for XMLHttpRequests
- Get rid of our custom XHR shim. Export it as videojs.xhr.
- Updated XHR to be stubbed everywhere in tests to prevent errors.
- Added npm install to the review process
closes #2318
closes #2594 | src/js/tracks/text-track.js | @@ -10,7 +10,7 @@ import log from '../utils/log.js';
import EventTarget from '../event-target';
import document from 'global/document';
import window from 'global/window';
-import XHR from '../xhr.js';
+import XHR from 'xhr';
/*
* https://html.spec.whatwg.org/multipage/embedded-content.html#texttrack
@@ -253,7 ... | true |
Other | videojs | video.js | 24cdbdefff67d2e9e4b8a6188000b8066ccab13e.json | Use Raynos/xhr for XMLHttpRequests
- Get rid of our custom XHR shim. Export it as videojs.xhr.
- Updated XHR to be stubbed everywhere in tests to prevent errors.
- Added npm install to the review process
closes #2318
closes #2594 | src/js/video.js | @@ -16,13 +16,13 @@ import assign from 'object.assign';
import { createTimeRange } from './utils/time-ranges.js';
import formatTime from './utils/format-time.js';
import log from './utils/log.js';
-import xhr from './xhr.js';
import * as Dom from './utils/dom.js';
import * as browser from './utils/browser.js';
im... | true |
Other | videojs | video.js | 24cdbdefff67d2e9e4b8a6188000b8066ccab13e.json | Use Raynos/xhr for XMLHttpRequests
- Get rid of our custom XHR shim. Export it as videojs.xhr.
- Updated XHR to be stubbed everywhere in tests to prevent errors.
- Added npm install to the review process
closes #2318
closes #2594 | src/js/xhr.js | @@ -1,160 +0,0 @@
-/**
- * @file xhr.js
- */
-import * as Url from './utils/url.js';
-import log from './utils/log.js';
-import mergeOptions from './utils/merge-options.js';
-import window from 'global/window';
-
-/*
- * Simple http request for retrieving external files (e.g. text tracks)
- * ##### Example
- * // ... | true |
Other | videojs | video.js | 24cdbdefff67d2e9e4b8a6188000b8066ccab13e.json | Use Raynos/xhr for XMLHttpRequests
- Get rid of our custom XHR shim. Export it as videojs.xhr.
- Updated XHR to be stubbed everywhere in tests to prevent errors.
- Added npm install to the review process
closes #2318
closes #2594 | test/globals-shim.js | @@ -5,6 +5,11 @@ import sinon from 'sinon';
window.q = QUnit;
window.sinon = sinon;
+// There's nowhere we require completing xhr requests
+// and raynos/xhr doesn't want to make stubbing easy (Raynos/xhr#11)
+// so we need to stub XHR before the xhr module is included anywhere else.
+window.xhr = sinon.useFakeXMLH... | true |
Other | videojs | video.js | 24cdbdefff67d2e9e4b8a6188000b8066ccab13e.json | Use Raynos/xhr for XMLHttpRequests
- Get rid of our custom XHR shim. Export it as videojs.xhr.
- Updated XHR to be stubbed everywhere in tests to prevent errors.
- Added npm install to the review process
closes #2318
closes #2594 | test/unit/tracks/text-track-list-converter.test.js | @@ -5,14 +5,7 @@ import Html5 from '../../../src/js/tech/html5.js';
import document from 'global/document';
import window from 'global/window';
-q.module('Text Track List Converter', {
- setup: function() {
- this.xhr = sinon.useFakeXMLHttpRequest();
- },
- teardown: function() {
- this.xhr.restore();
- }... | true |
Other | videojs | video.js | 24cdbdefff67d2e9e4b8a6188000b8066ccab13e.json | Use Raynos/xhr for XMLHttpRequests
- Get rid of our custom XHR shim. Export it as videojs.xhr.
- Updated XHR to be stubbed everywhere in tests to prevent errors.
- Added npm install to the review process
closes #2318
closes #2594 | test/unit/tracks/tracks.test.js | @@ -14,14 +14,7 @@ import document from 'global/document';
import window from 'global/window';
import TechFaker from '../tech/tech-faker.js';
-q.module('Tracks', {
- setup: function() {
- this.xhr = sinon.useFakeXMLHttpRequest();
- },
- teardown: function() {
- this.xhr.restore();
- }
-});
+q.module('Trac... | true |
Other | videojs | video.js | d11add5dc2f5e17409260ef24e37922fd73e4151.json | Send the video.js language to the tech
I want to set the YouTube player (or any other iframe tech)
in the same language than video.js. To do so,
it needs to know the language option.
closes #2342 | CHANGELOG.md | @@ -76,6 +76,7 @@ CHANGELOG
* @misteroneill fixed internal extends usage and added a deprecation warning ([view](https://github.com/videojs/video.js/pull/2390))
* @eXon added the poster to the options the tech receives ([view](https://github.com/videojs/video.js/pull/2338))
* @eXon made sure the volume persists betw... | true |
Other | videojs | video.js | d11add5dc2f5e17409260ef24e37922fd73e4151.json | Send the video.js language to the tech
I want to set the YouTube player (or any other iframe tech)
in the same language than video.js. To do so,
it needs to know the language option.
closes #2342 | src/js/player.js | @@ -503,7 +503,8 @@ class Player extends Component {
'preload': this.options_.preload,
'loop': this.options_.loop,
'muted': this.options_.muted,
- 'poster': this.poster()
+ 'poster': this.poster(),
+ 'language': this.language()
}, this.options_[techName.toLowerCase()]);
i... | true |
Other | videojs | video.js | e0b1008225b56a51572cc7cac2d43887503400ca.json | Fix IE8 tests
- Removed incompatible module
- Added ie8 shim to qunit index.html
- Fixed extends() usage
--skip-ci | test/index.html | @@ -10,6 +10,8 @@
<div id="qunit"></div>
<script src="../node_modules/qunitjs/qunit/qunit.js"></script>
+ <script src="../build/temp/ie8/videojs-ie8.min.js"></script>
+
<!-- Execute the bundled tests first -->
<script src="../build/temp/tests.js"></script>
| true |
Other | videojs | video.js | e0b1008225b56a51572cc7cac2d43887503400ca.json | Fix IE8 tests
- Removed incompatible module
- Added ie8 shim to qunit index.html
- Fixed extends() usage
--skip-ci | test/unit/player.test.js | @@ -8,7 +8,6 @@ import MediaError from '../../src/js/media-error.js';
import Html5 from '../../src/js/tech/html5.js';
import TestHelpers from './test-helpers.js';
import document from 'global/document';
-import css from 'css';
q.module('Player', {
'setup': function() {
@@ -161,57 +160,45 @@ test('should set th... | true |
Other | videojs | video.js | e0b1008225b56a51572cc7cac2d43887503400ca.json | Fix IE8 tests
- Removed incompatible module
- Added ie8 shim to qunit index.html
- Fixed extends() usage
--skip-ci | test/unit/tech/tech.test.js | @@ -1,8 +1,8 @@
var noop = function() {}, clock, oldTextTracks;
-import extendsFn from '../../../src/js/extends.js';
import Tech from '../../../src/js/tech/tech.js';
import { createTimeRange } from '../../../src/js/utils/time-ranges.js';
+import extendsFn from '../../../src/js/extends.js';
q.module('Media Tech'... | true |
Other | videojs | video.js | dbad385157a2a397432b755f3a6f6a3633356e8f.json | Use node.js 0.12 for travis
libsass may be running into issues with bindings and iojs so use a version-pegged node.js for now. | .travis.yml | @@ -1,6 +1,6 @@
language: node_js
node_js:
- - iojs
+ - 0.12
before_script:
- if [ "${TRAVIS_PULL_REQUEST}" = "false" ]; then curl https://gist.githubusercontent.com/santiycr/5139565/raw/sauce_connect_setup.sh | bash; fi
before_install: | false |
Other | videojs | video.js | d5061d769110635fd5f783fcadc0b386ed51bd5d.json | Update vttjs to fix a trailing comma JSON error
closes #2331 | CHANGELOG.md | @@ -61,6 +61,7 @@ CHANGELOG
* @pavelhoral fixed subclassing without a constructor ([view](https://github.com/videojs/video.js/pull/2308))
* @dmlap fixed a vjs_getProperty error caused by a progress check before the swf was ready ([view](https://github.com/videojs/video.js/pull/2316))
* @dmlap exported the videojs.lo... | true |
Other | videojs | video.js | d5061d769110635fd5f783fcadc0b386ed51bd5d.json | Update vttjs to fix a trailing comma JSON error
closes #2331 | package.json | @@ -30,7 +30,7 @@
"videojs-font": "1.3.0",
"videojs-ie8": "1.1.0",
"videojs-swf": "4.7.1",
- "vtt.js": "git+https://github.com/gkatsev/vtt.js.git#shim-build"
+ "vtt.js": "git+https://github.com/gkatsev/vtt.js.git#vjs-v0.12.1"
},
"devDependencies": {
"babel": "^5.2.2", | true |
Other | videojs | video.js | 56be47b80a06a17ec8fabcfff909e931b08fae1e.json | Log an error when a plugin can't be found
closes #1931
closes #1928 | CHANGELOG.md | @@ -53,6 +53,7 @@ CHANGELOG
* @pavelhoral fixed a bug with user activity that caused the control bar to flicker ([view](https://github.com/videojs/video.js/pull/2299))
* @dmlap updated to videojs-swf@4.7.1 to fix a video dimensions issue on subsequent loads ([view](https://github.com/videojs/video.js/pull/2281))
* @... | true |
Other | videojs | video.js | 56be47b80a06a17ec8fabcfff909e931b08fae1e.json | Log an error when a plugin can't be found
closes #1931
closes #1928 | src/js/player.js | @@ -154,7 +154,11 @@ class Player extends Component {
Object.getOwnPropertyNames(plugins).forEach(function(name){
plugins[name].playerOptions = playerOptionsCopy;
- this[name](plugins[name]);
+ if (typeof this[name] === 'function') {
+ this[name](plugins[name]);
+ } else ... | true |
Other | videojs | video.js | 56be47b80a06a17ec8fabcfff909e931b08fae1e.json | Log an error when a plugin can't be found
closes #1931
closes #1928 | test/unit/plugins.test.js | @@ -1,6 +1,7 @@
import Plugin from '../../src/js/plugins.js';
import Player from '../../src/js/player.js';
import TestHelpers from './test-helpers.js';
+import window from 'global/window';
q.module('Plugins');
@@ -166,3 +167,34 @@ test('Plugins should not get events after stopImmediatePropagation is called', f
... | true |
Other | videojs | video.js | 0f1c5f22f06d0ad0b8b34cd683023a63a66bcf0f.json | Add changelog entry for SWF update
Prepend attribution to the previous entry. | CHANGELOG.md | @@ -2,7 +2,8 @@ CHANGELOG
=========
## HEAD (Unreleased)
-* src() should not return blob URLs with MSE source handlers ([view](https://github.com/videojs/video.js/pull/2271))
+* @dmlap update to video-js-swf 4.7.1 ([view](https://github.com/videojs/video.js/pull/2280))
+* @imbcmdth src() should not return blob URLs... | false |
Other | videojs | video.js | 0ad43fd576a945c19d9441c19ce09281e09d1623.json | update the swf to v4.7 | package.json | @@ -28,7 +28,7 @@
"lodash.merge": "^3.2.1",
"object.assign": "^2.0.1",
"safe-json-parse": "^4.0.0",
- "videojs-swf": "4.5.4",
+ "videojs-swf": "4.7.0",
"vtt.js": "git+https://github.com/gkatsev/vtt.js.git#shim-build"
},
"devDependencies": { | false |
Other | videojs | video.js | c74011582104297e992149ca32216a14beb055b4.json | bower.json: Remove font files from `main`
Per https://github.com/bower/bower.json-spec/pull/43 :
> font files [...] are not `main` files as they are not entry-points.
(See also the new example in the spec) | bower.json | @@ -4,11 +4,7 @@
"version": "5.0.0-13",
"main": [
"dist/video-js/video.js",
- "dist/video-js/video-js.css",
- "dist/video-js/font/vjs.eot",
- "dist/video-js/font/vjs.svg",
- "dist/video-js/font/vjs.ttf",
- "dist/video-js/font/vjs.woff"
+ "dist/video-js/video-js.css"
],
"keywords": [
... | false |
Other | videojs | video.js | 44953cf99b4911bfff64e588ce275675e06261be.json | remove minified tests from grunt test task | Gruntfile.js | @@ -364,6 +364,14 @@ module.exports = function(grunt) {
// Development watch task. Doing the minimum required.
grunt.registerTask('dev', ['jshint', 'less', 'browserify', 'karma:chrome']);
+ // Tests.
+ // We want to run things a little differently if it's coming from Travis vs local
+ if (process.env.TRAVIS)... | true |
Other | videojs | video.js | 44953cf99b4911bfff64e588ce275675e06261be.json | remove minified tests from grunt test task | build/tasks/test-local.js | @@ -0,0 +1,28 @@
+module.exports = function(grunt) {
+ // You can specify which browsers to build with by using grunt-style arguments
+ // or separating them with a comma:
+ // grunt test:chrome:firefox # grunt-style
+ // grunt test:chrome,firefox # comma-separated
+ grunt.registerTask('test-local', function... | true |
Other | videojs | video.js | 44953cf99b4911bfff64e588ce275675e06261be.json | remove minified tests from grunt test task | build/tasks/test-travis.js | @@ -0,0 +1,30 @@
+module.exports = function(grunt) {
+ // The test task will run `karma:saucelabs` when running in travis,
+ // when running via a PR from a fork, it'll run qunit tests in phantom using
+ // karma otherwise, it'll run the tests in chrome via karma
+ // You can specify which browsers to build with by... | true |
Other | videojs | video.js | 44953cf99b4911bfff64e588ce275675e06261be.json | remove minified tests from grunt test task | build/tasks/test.js | @@ -1,63 +0,0 @@
-module.exports = function(grunt) {
- // The test task will run `karma:saucelabs` when running in travis,
- // when running via a PR from a fork, it'll run qunit tests in phantom using
- // karma otherwise, it'll run the tests in chrome via karma
- // You can specify which browsers to build with by... | true |
Other | videojs | video.js | dfa791581f71ee236e87d3a73dc88ca6438c0534.json | Check travis env before checking if it's a PR | build/tasks/test.js | @@ -11,9 +11,9 @@ module.exports = function(grunt) {
tasksMinified,
tasksMinifiedApi;
- grunt.task.run(['pretask']);
-
- if (process.env.TRAVIS_PULL_REQUEST !== 'false') {
+ // I believe this was done originally because of security implications around running
+ // Saucelabs automatically on PRs.... | false |
Other | videojs | video.js | 6cc1b5191bf3db67ffd302ba5931d6c1c49461ec.json | Update README to warn about master being for 5.0 | README.md | @@ -1,3 +1,7 @@
+## Please Note!
+The master branch is now the development branch for 5.0 and should be considered unstable until the first 5.0 release. If you're looking for the most recent stable release, please refer to the [stable branch](https://github.com/videojs/video.js/tree/stable).
+
+
)
* @mmcc fixed an issue with text track hiding introduced in #1681 ([view](https://github.com/videojs/video.js/pull/1804))
* Export video.js as a named AMD module ([view](https://githu... | true |
Other | videojs | video.js | f980cdb1fbd6aba9967fb06190a7b2f37882131f.json | Hide the poster when play fires. closes #1834 | src/js/player.js | @@ -400,9 +400,6 @@ vjs.Player.prototype.onLoadStart = function() {
} else {
// reset the hasStarted state
this.hasStarted(false);
- this.one('play', function(){
- this.hasStarted(true);
- });
}
};
@@ -451,6 +448,10 @@ vjs.Player.prototype.onLoadedAllData;
vjs.Player.prototype.onPlay = fu... | true |
Other | videojs | video.js | f980cdb1fbd6aba9967fb06190a7b2f37882131f.json | Hide the poster when play fires. closes #1834 | test/unit/mediafaker.js | @@ -41,6 +41,9 @@ vjs.MediaFaker.prototype.volume = function(){ return 0; };
vjs.MediaFaker.prototype.muted = function(){ return false; };
vjs.MediaFaker.prototype.pause = function(){ return false; };
vjs.MediaFaker.prototype.paused = function(){ return true; };
+vjs.MediaFaker.prototype.play = function() {
+ this.... | true |
Other | videojs | video.js | f980cdb1fbd6aba9967fb06190a7b2f37882131f.json | Hide the poster when play fires. closes #1834 | test/unit/player.js | @@ -212,6 +212,27 @@ test('should set and update the poster value', function(){
player.dispose();
});
+// hasStarted() is equivalent to the "show poster flag" in the
+// standard, for the purpose of displaying the poster image
+// https://html.spec.whatwg.org/multipage/embedded-content.html#dom-media-play
+test('... | true |
Other | videojs | video.js | 3c83fd364dbf2f99ff3d7adaa2494674374fe29d.json | Update swf version to 4.5.3
closes #1823 | CHANGELOG.md | @@ -7,6 +7,7 @@ CHANGELOG
* @carpasse fixed a bug in updating child indexes after removing components ([view](https://github.com/videojs/video.js/pull/1814))
* @dmlap fixed a bug where native controls would show after switching techs ([view](https://github.com/videojs/video.js/pull/1811))
* @H1D fixed an issue with ... | true |
Other | videojs | video.js | 3c83fd364dbf2f99ff3d7adaa2494674374fe29d.json | Update swf version to 4.5.3
closes #1823 | package.json | @@ -21,7 +21,7 @@
},
"main": "./dist/video-js/video.js",
"dependencies": {
- "videojs-swf": "4.5.2"
+ "videojs-swf": "4.5.3"
},
"devDependencies": {
"calcdeps": "~0.1.7", | true |
Other | videojs | video.js | 4e2b4a215c12071bf4efe85f45675dd142c463ea.json | document the error event | src/js/player.js | @@ -588,6 +588,12 @@ vjs.Player.prototype.onFullscreenChange = function() {
}
};
+/**
+ * Fired when an error occurred
+ * @event error
+ */
+vjs.Player.prototype.onError;
+
// /* Player API
// ================================================================================ */
| false |
Other | videojs | video.js | b2c3e2d759a8fe59c59f26470e925eaa84739598.json | Delete the duplicated 'a' | CONTRIBUTING.md | @@ -222,7 +222,7 @@ Make sure your changes are pushed to origin
git push
```
-Use contrib to submit a a pull request (make sure you're in your feature branch)
+Use contrib to submit a pull request (make sure you're in your feature branch)
```bash
contrib feature submit | false |
Other | videojs | video.js | 3780f8dbce845d494201f7cf075a81bd4878c8fc.json | Prevent menus from opening while scrubbing | src/css/video-js.less | @@ -777,6 +777,10 @@ easily in the skin designer. http://designer.videojs.com/
.vjs-default-skin .vjs-control-content .vjs-menu.vjs-lock-showing {
display: block;
}
+/* prevent menus from opening while scrubbing (FF, IE) */
+.vjs-default-skin.vjs-scrubbing .vjs-menu-button:hover .vjs-control-content .vjs-menu {
+ ... | false |
Other | videojs | video.js | 9141a6256f0502fb647ff157936261b3c7d7e6bc.json | add plugin localization doc | docs/guides/languages.md | @@ -122,6 +122,15 @@ During a Video.js player instantiation you can force it to localize to a specifi
</video>
```
+Localization in Plugins
+-----------------------
+
+When you're developing a plugin, you can also introduce new localized strings. Simply wrap the string with the `localize` function:
+
+```javascript... | true |
Other | videojs | video.js | 9141a6256f0502fb647ff157936261b3c7d7e6bc.json | add plugin localization doc | docs/guides/plugins.md | @@ -43,4 +43,4 @@ If you've already initialized your video tag, you can activate a plugin at any t
video.examplePlugin({ exampleOption: true });
-That's it. Head on over to the Video.js wiki and add your plugin to the list so everyone else can check it out.
+That's it. Head on over to the [Video.js wiki](https... | true |
Other | videojs | video.js | c3139dcc1d485bc71bbc10929529dba2ec0a5a3e.json | Use svg instead of png to get better image quality | README.md | @@ -1,6 +1,6 @@
-# [Video.js - HTML5 Video Player](http://videojs.com) [](https://travis-ci.org/videojs/video.js)
+# [Video.js - HTML5 Video Player](http://videojs.com) [ {
},
jshint: {
src: {
- src: ['src/js/*.js', 'Gruntfile.js', 'test/unit/*.js'],
+ src: ['src/js/**/*.js', 'Gruntfile.js', 'test/unit/**/*.js'],
options: {
jshintrc: '.jshintrc'
} | true |
Other | videojs | video.js | 68f32226db03654edf4af5a2a572458c61dc6821.json | Make sure jshint checks all js files
Also, update all the files to pass jshint. | src/js/control-bar/playback-rate-menu-button.js | @@ -44,7 +44,7 @@ vjs.PlaybackRateMenuButton.prototype.createMenu = function(){
menu.addChild(
new vjs.PlaybackRateMenuItem(this.player(), { 'rate': rates[i] + 'x'})
);
- };
+ }
}
return menu;
@@ -66,7 +66,7 @@ vjs.PlaybackRateMenuButton.prototype.onClick = function(){
newR... | true |
Other | videojs | video.js | 68f32226db03654edf4af5a2a572458c61dc6821.json | Make sure jshint checks all js files
Also, update all the files to pass jshint. | src/js/control-bar/progress-control.js | @@ -151,13 +151,13 @@ vjs.LoadProgressBar.prototype.update = function(){
part = children[i];
if (!part) {
- part = this.el_.appendChild(vjs.createEl())
- };
+ part = this.el_.appendChild(vjs.createEl());
+ }
// set the percent based on the width of the progress bar (bufferedEnd)
... | true |
Other | videojs | video.js | 68f32226db03654edf4af5a2a572458c61dc6821.json | Make sure jshint checks all js files
Also, update all the files to pass jshint. | src/js/media/flash.js | @@ -193,10 +193,10 @@ vjs.Flash.prototype.enterFullScreen = function(){
function createSetter(attr){
var attrUpper = attr.charAt(0).toUpperCase() + attr.slice(1);
api['set'+attrUpper] = function(val){ return this.el_.vjs_setProperty(attr, val); };
- };
+ }
function createGetter(attr) {
api[attr] ... | true |
Other | videojs | video.js | 68f32226db03654edf4af5a2a572458c61dc6821.json | Make sure jshint checks all js files
Also, update all the files to pass jshint. | src/js/media/media.js | @@ -310,7 +310,8 @@ vjs.MediaTechController.withSourceHandlers = function(Tech){
* @returns {null} Null if no source handler is found
*/
Tech.selectSourceHandler = function(source){
- var handlers = Tech.sourceHandlers || [];
+ var handlers = Tech.sourceHandlers || [],
+ can;
for ... | true |
Other | videojs | video.js | fc7cebe1550da6ce92de72babdaab2d6ef838c0e.json | Update version numbers in quickstart guide. | README.md | @@ -9,8 +9,8 @@ Thanks to the awesome folks over at [Fastly](http://www.fastly.com/), there's a
`<head>`:
```html
-<link href="http://vjs.zencdn.net/4.9/video-js.css" rel="stylesheet">
-<script src="http://vjs.zencdn.net/4.9/video.js"></script>
+<link href="http://vjs.zencdn.net/4.10/video-js.css" rel="stylesheet">... | false |
Other | videojs | video.js | 48a00493502b41fa1b5a12cfc6f7a6918650fb03.json | Remove extra 10 | docs/guides/setup.md | @@ -20,8 +20,8 @@ You can download the Video.js source and host it on your own servers, or use the
### CDN Version ###
```html
-<link href="//vjs.zencdn.net/4.10.10.0/video-js.css" rel="stylesheet">
-<script src="//vjs.zencdn.net/4.10.10.0/video.js"></script>
+<link href="//vjs.zencdn.net/4.10/video-js.css" rel="st... | false |
Other | videojs | video.js | 25044e34b02a43265c2499de907ad71d2434bbf1.json | Fix broken link in CONTRIBUTING.md
The link titled "Build and share plugins" goes to docs/plugins.md, which
doesn't exist. It should go to docs/guides/plugins.md | CONTRIBUTING.md | @@ -4,7 +4,7 @@ So you want to help out? Great! There's a number of ways you can get involved.
* [File and discuss issues](#filing-issues)
* [Contribute code](#contributing-code)
- * [Build and share plugins](docs/plugins.md)
+ * [Build and share plugins](docs/guides/plugins.md)
* [Answer questions on Stac... | false |
Other | videojs | video.js | eec1fc13fe9822a3aee7284b4580029fadc0b6bf.json | Move language methods into externs
Trying to create a player-like subclass of component requires overriding languages() but that method was being minified. Add it to externs so that it can be overridden after minification. Fixes #1420. | src/js/exports.js | @@ -77,8 +77,6 @@ goog.exportProperty(vjs.Player.prototype, 'preload', vjs.Player.prototype.preloa
goog.exportProperty(vjs.Player.prototype, 'remainingTime', vjs.Player.prototype.remainingTime);
goog.exportProperty(vjs.Player.prototype, 'supportsFullScreen', vjs.Player.prototype.supportsFullScreen);
goog.exportPrope... | true |
Other | videojs | video.js | eec1fc13fe9822a3aee7284b4580029fadc0b6bf.json | Move language methods into externs
Trying to create a player-like subclass of component requires overriding languages() but that method was being minified. Add it to externs so that it can be overridden after minification. Fixes #1420. | src/js/player.externs.js | @@ -62,6 +62,12 @@ videojs.Player.prototype.cancelFullScreen = function(){}; /* deprecated */
*/
videojs.Player.prototype.textTracks = function(){};
+/**
+ * Language support
+ */
+videojs.Player.prototype.language = function(){};
+videojs.Player.prototype.languages = function(){};
+
/**
* Component functions
... | true |
Other | videojs | video.js | eec1fc13fe9822a3aee7284b4580029fadc0b6bf.json | Move language methods into externs
Trying to create a player-like subclass of component requires overriding languages() but that method was being minified. Add it to externs so that it can be overridden after minification. Fixes #1420. | test/unit/api.js | @@ -208,3 +208,16 @@ test('fullscreenToggle does not depend on minified player methods', function(){
ok(exitFullscreen, 'exitFullscreen called');
});
+
+test('component can be subclassed externally', function(){
+ var player = new (videojs.Component.extend({
+ languages: function(){},
+ reportUserActivity:... | true |
Other | videojs | video.js | e60f2eef5ca0b481a65402bafb68c23f4ca954be.json | Update media.js and html5.js feature access.
Due to #1415, various usage of features moved around. This makes sure
that features are now called directly on the tech everywhere. | src/js/media/html5.js | @@ -25,7 +25,7 @@ vjs.Html5 = vjs.MediaTechController.extend({
this['fullscreenResizeFeature'] = true;
// HTML video supports progress events
- this.features['progressEvents'] = true;
+ this['progressEventsFeature'] = true;
vjs.MediaTechController.call(this, player, options, ready);
this.s... | true |
Other | videojs | video.js | e60f2eef5ca0b481a65402bafb68c23f4ca954be.json | Update media.js and html5.js feature access.
Due to #1415, various usage of features moved around. This makes sure
that features are now called directly on the tech everywhere. | src/js/media/media.js | @@ -19,12 +19,12 @@ vjs.MediaTechController = vjs.Component.extend({
vjs.Component.call(this, player, options, ready);
// Manually track progress in cases where the browser/flash player doesn't report it.
- if (!this.features['progressEvents']) {
+ if (!this['progressEventsFeature']) {
this.man... | true |
Other | videojs | video.js | 7caa2fc1a703988532c61ffba17879f5d3d52520.json | Append Feature to 'features'. Update tests. | src/js/control-bar/mute-toggle.js | @@ -13,11 +13,11 @@ vjs.MuteToggle = vjs.Button.extend({
player.on('volumechange', vjs.bind(this, this.update));
// hide mute toggle if the current tech doesn't support volume control
- if (player.tech && player.tech['volumeControl'] === false) {
+ if (player.tech && player.tech['volumeControlFeature'... | true |
Other | videojs | video.js | 7caa2fc1a703988532c61ffba17879f5d3d52520.json | Append Feature to 'features'. Update tests. | src/js/control-bar/playback-rate-menu-button.js | @@ -72,7 +72,7 @@ vjs.PlaybackRateMenuButton.prototype.onClick = function(){
vjs.PlaybackRateMenuButton.prototype.playbackRateSupported = function(){
return this.player().tech
- && this.player().tech['playbackRate']
+ && this.player().tech['playbackRateFeature']
&& this.player().options()['playbackRate... | true |
Other | videojs | video.js | 7caa2fc1a703988532c61ffba17879f5d3d52520.json | Append Feature to 'features'. Update tests. | src/js/control-bar/volume-control.js | @@ -11,11 +11,11 @@ vjs.VolumeControl = vjs.Component.extend({
vjs.Component.call(this, player, options);
// hide volume controls when they're not supported by the current tech
- if (player.tech && player.tech['volumeControl'] === false) {
+ if (player.tech && player.tech['volumeControlFeature'] === f... | true |
Other | videojs | video.js | 7caa2fc1a703988532c61ffba17879f5d3d52520.json | Append Feature to 'features'. Update tests. | src/js/control-bar/volume-menu-button.js | @@ -11,11 +11,11 @@ vjs.VolumeMenuButton = vjs.MenuButton.extend({
player.on('volumechange', vjs.bind(this, this.update));
// hide mute toggle if the current tech doesn't support volume control
- if (player.tech && player.tech.volumeControl === false) {
+ if (player.tech && player.tech['volumeControlF... | true |
Other | videojs | video.js | 7caa2fc1a703988532c61ffba17879f5d3d52520.json | Append Feature to 'features'. Update tests. | src/js/exports.js | @@ -121,10 +121,11 @@ goog.exportSymbol('videojs.CaptionsButton', vjs.CaptionsButton);
goog.exportSymbol('videojs.ChaptersButton', vjs.ChaptersButton);
goog.exportSymbol('videojs.MediaTechController', vjs.MediaTechController);
-goog.exportProperty(vjs.MediaTechController.prototype, 'volumeControl', vjs.MediaTechCon... | true |
Other | videojs | video.js | 7caa2fc1a703988532c61ffba17879f5d3d52520.json | Append Feature to 'features'. Update tests. | src/js/media/html5.js | @@ -13,16 +13,16 @@ vjs.Html5 = vjs.MediaTechController.extend({
/** @constructor */
init: function(player, options, ready){
// volume cannot be changed from 1 on iOS
- this['volumeControl'] = vjs.Html5.canControlVolume();
+ this['volumeControlFeature'] = vjs.Html5.canControlVolume();
// just in... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.