language
stringclasses
1 value
owner
stringlengths
2
15
repo
stringlengths
2
21
sha
stringlengths
45
45
message
stringlengths
7
36.3k
path
stringlengths
1
199
patch
stringlengths
15
102k
is_multipart
bool
2 classes
Other
videojs
video.js
6e5407596e6d98fa408f1e599d15080618c7997f.json
run grunt test only for travis
package.json
@@ -11,7 +11,7 @@ "homepage": "http://videojs.com", "author": "Steve Heffernan", "scripts": { - "test": "grunt default test --verbose" + "test": "grunt test --verbose" }, "repository": { "type": "git",
false
Other
videojs
video.js
2ff8a2bba243f24ae5cf3dab09eeb9939fea9a40.json
minify both source and tests for test grunt task
Gruntfile.js
@@ -64,7 +64,7 @@ module.exports = function(grunt) { grunt.registerTask('default', ['jshint', 'build', 'minify', 'dist']); // Development watch task grunt.registerTask('dev', ['jshint', 'build', 'qunit:source']); - grunt.registerTask('test', ['jshint', 'build', 'minify:tests', 'qunit']); + grunt.registerTask...
false
Other
videojs
video.js
6f5e49fc1603b1793ca73a60468fad57f840849a.json
Use accessors to transfer the poster attribute When transferring the poster attribute from the container to the tech in mediafaker, use the accessor methods instead of directly referencing the private properties.
test/unit/mediafaker.js
@@ -22,9 +22,9 @@ vjs.MediaFaker.prototype.createEl = function(){ var el = goog.base(this, 'createEl', 'div', { className: 'vjs-tech' }); - if (this.player_.poster_) { + if (this.player().poster()) { // transfer the poster image to mimic HTML - el.poster = this.player_.poster_; + el.poster = thi...
false
Other
videojs
video.js
e41472f0e56e1ffd59e55ff30ae2bf7613ebd8c0.json
Remove duplicate code from exports
src/js/exports.js
@@ -52,10 +52,6 @@ goog.exportProperty(vjs.Component.prototype, 'dimensions', vjs.Component.prototy goog.exportSymbol('videojs.Player', vjs.Player); goog.exportSymbol('videojs.MediaLoader', vjs.MediaLoader); -goog.exportSymbol('videojs.PosterImage', vjs.PosterImage); -goog.exportSymbol('videojs.LoadingSpinner', vjs...
false
Other
videojs
video.js
93f8737fc79bb571d1b4595c4f952f078f2458b5.json
Fix ability to add child after closure compiled
src/js/component.js
@@ -288,8 +288,8 @@ vjs.Component.prototype.addChild = function(child, options){ // Add the UI object's element to the container div (box) // Having an element is not required - if (typeof component.el === 'function' && component.el()) { - this.el_.appendChild(component.el()); + if (typeof component['el'] ...
false
Other
videojs
video.js
1bceadf0944c9d91e0de059fd7d08f2a98d17eed.json
expose correct dispose method testcase for correct dispose method
src/js/exports.js
@@ -34,7 +34,7 @@ goog.exportSymbol('videojs.options', vjs.options); goog.exportSymbol('videojs.cache', vjs.cache); goog.exportSymbol('videojs.Component', vjs.Component); -goog.exportProperty(vjs.Component.prototype, 'dispose', vjs.Component.prototype.dispose); +//goog.exportProperty(vjs.Component.prototype, 'dispo...
true
Other
videojs
video.js
1bceadf0944c9d91e0de059fd7d08f2a98d17eed.json
expose correct dispose method testcase for correct dispose method
test/unit/minified.js
@@ -19,3 +19,21 @@ test('should export ready api call to public', function() { ok(player.ready !== undefined, 'ready callback is defined'); player.dispose(); }); + +test('should be able to initialize player twice on the same tag using string reference', function() { + var videoTag = PlayerTest.makeTag(); + var...
true
Other
videojs
video.js
1bceadf0944c9d91e0de059fd7d08f2a98d17eed.json
expose correct dispose method testcase for correct dispose method
test/unit/player.js
@@ -212,3 +212,24 @@ test('should not play if firstplay event prevents default', function(){ player.dispose(); }); + +test('should be able to initialize player twice on the same tag using string reference', function() { + var videoTag = PlayerTest.makeTag(); + var id = videoTag.id; + + var fixture = document.g...
true
Other
videojs
video.js
754f5907780f271381ecc8b4b4fd97773cf54ef8.json
add swp files to gitignore
.gitignore
@@ -10,3 +10,6 @@ node_modules npm-debug.log sandbox/* !sandbox/*.example + +*.swp +*.swo
false
Other
videojs
video.js
b6621397085f0d542d2ee79048978ec014c2a970.json
Remove unused variable Get rid of a variable that was copy-pasted along from a previous incarnation of this fix.
src/js/media.html5.js
@@ -205,9 +205,7 @@ vjs.Html5.canPlaySource = function(srcObj){ }; vjs.Html5.canControlVolume = function(){ - var - volume = vjs.TEST_VID.volume, - volumeOptions = {}; + var volume = vjs.TEST_VID.volume; vjs.TEST_VID.volume = (volume / 2) + 0.1; return volume !== vjs.TEST_VID.volume; };
false
Other
videojs
video.js
60f9b505f178e5fbe49c13871dfb96f7639dc0b0.json
Close GH-346: Remove need for good.require/good.provide.
Gruntfile.js
@@ -5,6 +5,16 @@ module.exports = function(grunt) { pkg: grunt.file.readJSON('package.json'), build: { + src: 'src/js/dependencies.js', + options: { + baseDir: 'src/js/' + } + }, + deps: { + src: 'src/js/dependencies.js', + options: { + baseDir: 'src/js/' + ...
true
Other
videojs
video.js
60f9b505f178e5fbe49c13871dfb96f7639dc0b0.json
Close GH-346: Remove need for good.require/good.provide.
build/source-loader.js
@@ -0,0 +1,59 @@ +// This file is used to load the video.js source files into a page +// in the correct order based on dependencies. +// When you create a new source file you will need to add +// it to the list below to use it in sandbox/index.html and +// test/index.html + +// You can use the projectRoot variable to a...
true
Other
videojs
video.js
60f9b505f178e5fbe49c13871dfb96f7639dc0b0.json
Close GH-346: Remove need for good.require/good.provide.
sandbox/index.html.example
@@ -6,43 +6,8 @@ <link href="../src/css/video-js.css" rel="stylesheet" type="text/css"> - <!--[if IE]> - <script src="https://getfirebug.com/releases/lite/1.4/firebug-lite.js"></script> - <!--<![endif]--> - - <!-- GENERATED LIST OF SOURCE FILES --> - <script src="../build/files/sourcelist.js"></script> - ...
true
Other
videojs
video.js
60f9b505f178e5fbe49c13871dfb96f7639dc0b0.json
Close GH-346: Remove need for good.require/good.provide.
sandbox/plugin.html.example
@@ -6,42 +6,14 @@ <link href="../src/css/video-js.css" rel="stylesheet" type="text/css"> - <!--[if IE]> - <script src="https://getfirebug.com/releases/lite/1.4/firebug-lite.js"></script> - <!--<![endif]--> + <!-- LOAD VIDEO.JS SOURCE FILES IN ORDER --> + <script src="../build/source-loader.js"></script> ...
true
Other
videojs
video.js
60f9b505f178e5fbe49c13871dfb96f7639dc0b0.json
Close GH-346: Remove need for good.require/good.provide.
src/js/component.js
@@ -3,11 +3,6 @@ * */ -goog.provide('vjs.Component'); - -goog.require('vjs.events'); -goog.require('vjs.dom'); - /** * Base UI Component class * @param {Object} player Main Player
true
Other
videojs
video.js
60f9b505f178e5fbe49c13871dfb96f7639dc0b0.json
Close GH-346: Remove need for good.require/good.provide.
src/js/controls.js
@@ -2,12 +2,6 @@ * @fileoverview Controls classes for Video.js buttons, sliders, etc. */ -goog.provide('vjs.Control'); -goog.provide('vjs.Menu'); -goog.provide('vjs.MenuItem'); - -goog.require('vjs.Player'); - /** * Base class for all control elements * @param {vjs.Player|Object} player @@ -531,6 +525,10 @@ ...
true
Other
videojs
video.js
60f9b505f178e5fbe49c13871dfb96f7639dc0b0.json
Close GH-346: Remove need for good.require/good.provide.
src/js/core.js
@@ -2,9 +2,6 @@ * @fileoverview Main function src. */ -goog.provide('vjs'); -goog.provide('videojs'); - // HTML5 Shiv. Must be in <head> to support older browsers. document.createElement('video');document.createElement('audio'); @@ -17,7 +14,7 @@ document.createElement('video');document.createElement('audio')...
true
Other
videojs
video.js
60f9b505f178e5fbe49c13871dfb96f7639dc0b0.json
Close GH-346: Remove need for good.require/good.provide.
src/js/events.js
@@ -5,10 +5,6 @@ * robust as jquery's, so there's probably some differences. */ -goog.provide('vjs.events'); - -goog.require('vjs'); - /** * Add an event listener to element * It stores the handler function in a separate cache object
true
Other
videojs
video.js
60f9b505f178e5fbe49c13871dfb96f7639dc0b0.json
Close GH-346: Remove need for good.require/good.provide.
src/js/exports.js
@@ -5,16 +5,6 @@ * be renamed by closure compiler. */ -goog.require('vjs'); -goog.require('vjs.Component'); -goog.require('vjs.Player'); -goog.require('vjs.Control'); -goog.require('vjs.Html5'); -goog.require('vjs.Flash'); -goog.require('vjs.TextTrack'); -goog.require('vjs.autoSetup'); -goog.require('vjs.plugin')...
true
Other
videojs
video.js
60f9b505f178e5fbe49c13871dfb96f7639dc0b0.json
Close GH-346: Remove need for good.require/good.provide.
src/js/json.js
@@ -4,19 +4,21 @@ * (Compiler doesn't like JSON not being declared) */ -goog.provide('vjs.JSON'); - /** * Javascript JSON implementation * (Parse Method Only) * https://github.com/douglascrockford/JSON-js/blob/master/json2.js * Only using for parse method when parsing data-setup attribute JSON. * @type...
true
Other
videojs
video.js
60f9b505f178e5fbe49c13871dfb96f7639dc0b0.json
Close GH-346: Remove need for good.require/good.provide.
src/js/lib.js
@@ -1,8 +1,3 @@ -goog.provide('vjs.dom'); -goog.provide('vjs.obj'); - -goog.require('vjs'); - /** * Creates an element and applies properties. * @param {String=} tagName Name of tag to be created. @@ -17,13 +12,13 @@ vjs.createEl = function(tagName, properties){ //el[propName] = properties[propName]; ...
true
Other
videojs
video.js
60f9b505f178e5fbe49c13871dfb96f7639dc0b0.json
Close GH-346: Remove need for good.require/good.provide.
src/js/media.flash.js
@@ -4,10 +4,6 @@ * Not using setupTriggers. Using global onEvent func to distribute events */ -goog.provide('vjs.Flash'); - -goog.require('vjs.MediaTechController'); - /** * HTML5 Media Controller - Wrapper for HTML5 Media API * @param {vjs.Player|Object} player
true
Other
videojs
video.js
60f9b505f178e5fbe49c13871dfb96f7639dc0b0.json
Close GH-346: Remove need for good.require/good.provide.
src/js/media.html5.js
@@ -2,10 +2,6 @@ * @fileoverview HTML5 Media Controller - Wrapper for HTML5 Media API */ -goog.provide('vjs.Html5'); - -goog.require('vjs.MediaTechController'); - /** * HTML5 Media Controller - Wrapper for HTML5 Media API * @param {vjs.Player|Object} player
true
Other
videojs
video.js
60f9b505f178e5fbe49c13871dfb96f7639dc0b0.json
Close GH-346: Remove need for good.require/good.provide.
src/js/media.js
@@ -2,10 +2,6 @@ * @fileoverview Media Technology Controller - Base class for media playback technology controllers like Flash and HTML5 */ -goog.provide('vjs.MediaTechController'); - -goog.require('vjs.Component'); - /** * Base class for media (HTML5 Video, Flash) controllers * @param {vjs.Player|Object} pl...
true
Other
videojs
video.js
60f9b505f178e5fbe49c13871dfb96f7639dc0b0.json
Close GH-346: Remove need for good.require/good.provide.
src/js/player.js
@@ -1,7 +1,3 @@ -goog.provide('vjs.Player'); - -goog.require('vjs.Component'); - /** * Main player class. A player instance is returned by _V_(id); * @param {Element} tag The original video tag used for configuring options
true
Other
videojs
video.js
60f9b505f178e5fbe49c13871dfb96f7639dc0b0.json
Close GH-346: Remove need for good.require/good.provide.
src/js/plugins.js
@@ -1,5 +1,3 @@ -goog.provide('vjs.plugin'); - vjs.plugin = function(name, init){ vjs.Player.prototype[name] = init; -}; \ No newline at end of file +};
true
Other
videojs
video.js
60f9b505f178e5fbe49c13871dfb96f7639dc0b0.json
Close GH-346: Remove need for good.require/good.provide.
src/js/setup.js
@@ -3,11 +3,6 @@ * based on the data-setup attribute of the video tag */ -goog.provide('vjs.autoSetup'); - -goog.require('vjs.JSON'); -goog.require('vjs.events'); - // Automatically set up any tags that have a data-setup attribute vjs.autoSetup = function(){ var options, vid, player,
true
Other
videojs
video.js
60f9b505f178e5fbe49c13871dfb96f7639dc0b0.json
Close GH-346: Remove need for good.require/good.provide.
src/js/tracks.js
@@ -7,13 +7,6 @@ * Descriptions (not supported yet) - audio descriptions that are read back to the user by a screen reading device */ -goog.provide('vjs.TextTrack'); - -goog.require('vjs.Menu'); -goog.require('vjs.MenuItem'); -goog.require('vjs.Component'); - - // Player Additions - Functions add to the player o...
true
Other
videojs
video.js
60f9b505f178e5fbe49c13871dfb96f7639dc0b0.json
Close GH-346: Remove need for good.require/good.provide.
test/index.html
@@ -3,19 +3,20 @@ <head> <title>Video.js Test Suite</title> + <!--[if IE]> + <script src="https://getfirebug.com/releases/lite/1.4/firebug-lite.js"></script> + <!--<![endif]--> + <!-- QUnit --> <link rel="stylesheet" href="../test/qunit/qunit/qunit.css" /> <script src="../test/qunit/qunit/qunit.js">...
true
Other
videojs
video.js
eda21b7b2212cf1c9b4d5db10e1ad86a334bb046.json
Fix parentEl tech option. Player cannot find parentEl option after minification, so flash tech fails.
src/js/player.js
@@ -224,7 +224,7 @@ vjs.Player.prototype.loadTech = function(techName, source){ }; // Grab tech-specific options from player options and add source and parent element to use. - var techOptions = vjs.obj.merge({ source: source, parentEl: this.el_ }, this.options_[techName.toLowerCase()]); + var techOptions = v...
false
Other
videojs
video.js
d21df1bc12673e30f7d16e847b6373c56159e77c.json
Remove Extra Flash Switch Get rid of the extra switching logic to force Flash tech. Worth noting: it has to exist as a separate script tag because we're using document.write to insert video.js scripts.
sandbox/plugin.html.example
@@ -2,7 +2,7 @@ <html> <head> <meta charset="utf-8" /> - <title>Video.js Sandbox</title> + <title>Video.js Plugin Example</title> <link href="../src/css/video-js.css" rel="stylesheet" type="text/css"> @@ -26,24 +26,15 @@ document.write( "<script src='" + root + sourcelist[i] + "'><\/script>" );...
false
Other
videojs
video.js
c6d34814704051489d0927c5176e40279d7d784f.json
Remove Extra Flash Switch Get rid of the extra switching logic to force Flash tech. Worth noting: it has to exist as a separate script tag because we're using document.write to insert video.js scripts.
sandbox/plugin.html.example
@@ -2,7 +2,7 @@ <html> <head> <meta charset="utf-8" /> - <title>Video.js Sandbox</title> + <title>Video.js Plugin Example</title> <link href="../src/css/video-js.css" rel="stylesheet" type="text/css"> @@ -26,24 +26,15 @@ document.write( "<script src='" + root + sourcelist[i] + "'><\/script>" );...
false
Other
videojs
video.js
5f2b8fb8313fc9a83221e93e3c8210a5ae2783a8.json
update gruntfile to pass jshint
Gruntfile.js
@@ -14,9 +14,9 @@ module.exports = function(grunt) { // npm install https://github.com/gruntjs/grunt-contrib-jshint/archive/7fd70e86c5a8d489095fa81589d95dccb8eb3a46.tar.gz jshint: { src: { - src: ["src/js/*.js", "Gruntfile.js", "test/unit/*.js"], + src: ['src/js/*.js', 'Gruntfile.js', 'te...
false
Other
videojs
video.js
b8b23d00decf77b6aabec167d36df79eda298705.json
Add a test using stop Propagation
test/unit/plugins.js
@@ -110,7 +110,7 @@ test('Plugins should get events in registration order', function() { (function (name) { vjs.plugin(name, function (opts) { this.on('test', function (event) { - order.push(name) + order.push(name); }); }); player[name]({}); @@ -123,6 +123,...
false
Other
videojs
video.js
c6a855cf744cd2b5f591d9a959eeae5e5c5a15ff.json
add plugin test for event order
test/unit/plugins.js
@@ -95,3 +95,34 @@ test('Plugin should overwrite plugin of same name', function(){ player2.dispose(); }); + +test('Plugins should get events in registration order', function() { + var order = []; + var expectedOrder = []; + var pluginName = 'orderPlugin'; + var i = 0; + var name; + var player = PlayerTest....
false
Other
videojs
video.js
20e9a9feb58097ab91e2ee9ef785128fee43e623.json
Fix bug with getting the ID of the track Signed-off-by: Greg Kraus <gdkraus@ncsu.edu>
src/js/tracks.js
@@ -748,7 +748,7 @@ goog.inherits(vjs.TextTrackMenuItem, vjs.MenuItem); vjs.TextTrackMenuItem.prototype.onClick = function(){ goog.base(this, 'onClick'); - this.player_.showTextTrack(this.track.id(), this.track.kind()); + this.player_.showTextTrack(this.track.id_, this.track.kind()); }; vjs.TextTrackMenuIte...
false
Other
videojs
video.js
3e7289f244ce54efe1f5abc33d805c824db903f1.json
Add HTTPS support for CDN version
src/core.js
@@ -42,6 +42,7 @@ _V_ = VideoJS, // CDN Version. Used to target right flash swf. CDN_VERSION = "GENERATED_CDN_VSN"; +ACCESS_PROTOCOL = ("https:" == document.location.protocol ? "https://" : "http://"); VideoJS.players = {}; @@ -52,7 +53,7 @@ VideoJS.options = { // techOrder: ["flash","html5"], html5: {...
false
Other
videojs
video.js
76740d93f10634237dc1d3cfec9ab9e5f9371f9b.json
api doc code blocks rendering in other markdowns
docs/api.md
@@ -5,6 +5,7 @@ The Video.js API allows you to interact with the video through Javascript, wheth Referencing the Player ---------------------- To use the API functions, you need access to the player object. Luckily this is easy to get. You just need to make sure your video tag has an ID. The example embed code has a...
false
Other
videojs
video.js
c9fa0be0e0a7f0ec1c782a3e98ab9820b3adadf6.json
Adding line to CHANGELOG: Allow disabling of default components
CHANGELOG.md
@@ -1,3 +1,4 @@ +* Allow disabling of default components * Duration is now setable (need ed for HLS m3u8 files) * Event binders (on/off/one) now return the player instance * Stopped player from going back to beginningg on ended event.
false
Other
videojs
video.js
94044afe74b9bbbff930eb3bb0024058423be175.json
Allow disabling of default components.
src/component.js
@@ -77,6 +77,10 @@ _V_.Component = _V_.Class.extend({ // Loop through components and add them to the player this.eachProp(options.components, function(name, opts){ + // Allow for disabling default components + // e.g. _V_.options.components.posterImage = false + if (opts === false) ...
false
Other
videojs
video.js
304921128c1ff2ebd5c5905f7dae5f648d39a41c.json
fix children in ff3 ff3 does not support children, only childNodes
src/player.js
@@ -135,27 +135,29 @@ _V_.Player = _V_.Component.extend({ options.loop = this.tag.getAttribute("loop") !== null; options.muted = this.tag.getAttribute("muted") !== null; - for (var c,i=0,j=this.tag.children;i<j.length;i++) { - c = j[i]; - if (c.nodeName == "SOURCE") { - options.sources.p...
false
Other
videojs
video.js
f4e68d1a47872176a67394c575fe53c2569c7a72.json
Fix flashvar name
compare/compare.js
@@ -1,12 +1,11 @@ -_V_.flash.prototype.swf = "../flash/video-js.swf"; +_V_.options.flash.swf = "../flash/video-js.swf"; $(function(){ var tech, i, tname, player, techList = ["html5","flash"], props = "error,currentSrc,networkState,buffered,readyState,seeking,initialTime,duration,startOffsetTime,paus...
true
Other
videojs
video.js
f4e68d1a47872176a67394c575fe53c2569c7a72.json
Fix flashvar name
src/tech.js
@@ -272,7 +272,7 @@ _V_.flash = _V_.PlaybackTech.extend({ // If source was supplied pass as a flash var. if (source) { - flashvars.src = source.src; + flashVars.src = source.src; } _V_.insertFirst(placeHolder, player.el);
true
Other
videojs
video.js
2ea9c99f3404190a75ae3e17ab02ab5321cd6f2a.json
Drop units from zero values
video-js.css
@@ -223,11 +223,11 @@ so you can upgrade to newer versions easier. You can remove all these styles by margin-top: -0.3em; left: 0; top: 0; /*Needed for IE6*/ - background: url('video-js.png') 0px -50px; + background: url('video-js.png') 0 -50px; /* CSS Curved Corners. Needed to make shadows curved. */ -...
false
Other
ReactiveX
RxJava
5b3510bc925947230f6c1a7e66d30694e0f304b3.json
3.x: Fix experimental, signatures of throttleLast (#7490) * 3.x: Fix experimental, signatures. * Fix Observable.sample overload * Fix validator signature override
src/main/java/io/reactivex/rxjava3/core/Flowable.java
@@ -14729,7 +14729,6 @@ public final Flowable<T> sample(long period, @NonNull TimeUnit unit, @NonNull Sc * <dd>You specify which {@code Scheduler} this operator will use.</dd> * </dl> * - * <p>History: 2.0.5 - experimental * @param period * the sampling rate * @param ...
true
Other
ReactiveX
RxJava
5b3510bc925947230f6c1a7e66d30694e0f304b3.json
3.x: Fix experimental, signatures of throttleLast (#7490) * 3.x: Fix experimental, signatures. * Fix Observable.sample overload * Fix validator signature override
src/main/java/io/reactivex/rxjava3/core/Observable.java
@@ -12133,49 +12133,51 @@ public final Observable<T> sample(long period, @NonNull TimeUnit unit, @NonNull /** * Returns an {@code Observable} that emits the most recently emitted item (if any) emitted by the current {@code Observable} - * within periodic time intervals, where the intervals are defined ...
true
Other
ReactiveX
RxJava
5b3510bc925947230f6c1a7e66d30694e0f304b3.json
3.x: Fix experimental, signatures of throttleLast (#7490) * 3.x: Fix experimental, signatures. * Fix Observable.sample overload * Fix validator signature override
src/main/java/io/reactivex/rxjava3/internal/operators/flowable/FlowableSampleTimed.java
@@ -32,9 +32,9 @@ final TimeUnit unit; final Scheduler scheduler; final boolean emitLast; - final Consumer<T> onDropped; + final Consumer<? super T> onDropped; - public FlowableSampleTimed(Flowable<T> source, long period, TimeUnit unit, Scheduler scheduler, boolean emitLast, Consumer<T> onDrop...
true
Other
ReactiveX
RxJava
5b3510bc925947230f6c1a7e66d30694e0f304b3.json
3.x: Fix experimental, signatures of throttleLast (#7490) * 3.x: Fix experimental, signatures. * Fix Observable.sample overload * Fix validator signature override
src/main/java/io/reactivex/rxjava3/internal/operators/observable/ObservableSampleTimed.java
@@ -22,21 +22,20 @@ import io.reactivex.rxjava3.functions.Consumer; import io.reactivex.rxjava3.internal.disposables.DisposableHelper; import io.reactivex.rxjava3.observers.SerializedObserver; -import io.reactivex.rxjava3.plugins.RxJavaPlugins; public final class ObservableSampleTimed<T> extends AbstractObservabl...
true
Other
ReactiveX
RxJava
5b3510bc925947230f6c1a7e66d30694e0f304b3.json
3.x: Fix experimental, signatures of throttleLast (#7490) * 3.x: Fix experimental, signatures. * Fix Observable.sample overload * Fix validator signature override
src/test/java/io/reactivex/rxjava3/validators/ParamValidationCheckerTest.java
@@ -437,8 +437,8 @@ public void checkParallelFlowable() { addOverride(new ParamOverride(Observable.class, 0, ParamMode.ANY, "sample", Long.TYPE, TimeUnit.class)); addOverride(new ParamOverride(Observable.class, 0, ParamMode.ANY, "sample", Long.TYPE, TimeUnit.class, Boolean.TYPE)); addOverride...
true
Other
ReactiveX
RxJava
d6d8869c9f4d3bf6fb7b4b2126a4ee25cc3d0b49.json
Fix cancellation order in ThrottleFirst (#7484) * Fix cancellation order in ThrottleFirst * Bump vanniktech maven publish * Undo bump, seems to be gradle issue
src/main/java/io/reactivex/rxjava3/internal/operators/flowable/FlowableThrottleFirstTimed.java
@@ -105,9 +105,10 @@ public void onNext(T t) { downstream.onNext(t); BackpressureHelper.produced(this, 1); } else { + upstream.cancel(); done = true; - cancel(); downstream.onError(...
true
Other
ReactiveX
RxJava
d6d8869c9f4d3bf6fb7b4b2126a4ee25cc3d0b49.json
Fix cancellation order in ThrottleFirst (#7484) * Fix cancellation order in ThrottleFirst * Bump vanniktech maven publish * Undo bump, seems to be gradle issue
src/main/java/io/reactivex/rxjava3/internal/operators/observable/ObservableThrottleFirstTimed.java
@@ -32,7 +32,7 @@ public ObservableThrottleFirstTimed( ObservableSource<T> source, - long timeout, + long timeout, TimeUnit unit, Scheduler scheduler, Consumer<? super T> onDropped) { @@ -102,9 +102,9 @@ public void onNext(T t) { ...
true
Other
ReactiveX
RxJava
84736107209babc762ddd4394115afbe65a961c8.json
3.x: fix typo in BehaviorSubject.java (#7452)
src/main/java/io/reactivex/rxjava3/subjects/BehaviorSubject.java
@@ -59,9 +59,9 @@ * * TestObserver&lt;Integer&gt; to1 = observable.test(); * - * observable.onNext(1); + * subject.onNext(1); * // this will "clear" the cache - * observable.onNext(EMPTY); + * subject.onNext(EMPTY); * * TestObserver&lt;Integer&gt; to2 = observable.test(); *
false
Other
ReactiveX
RxJava
73a57dd1064bbfc44a7af7a7461f5613fc52393c.json
3.x: Remove redundant interface declarations (#7438) * 3.x: Remove redundant interface declarations * Fix paramvalidator
src/main/java/io/reactivex/rxjava3/internal/operators/flowable/FlowableBufferExactBoundary.java
@@ -45,7 +45,7 @@ protected void subscribeActual(Subscriber<? super U> s) { } static final class BufferExactBoundarySubscriber<T, U extends Collection<? super T>, B> - extends QueueDrainSubscriber<T, U, U> implements FlowableSubscriber<T>, Subscription, Disposable { + extends QueueDrainSubscriber<T, U...
true
Other
ReactiveX
RxJava
73a57dd1064bbfc44a7af7a7461f5613fc52393c.json
3.x: Remove redundant interface declarations (#7438) * 3.x: Remove redundant interface declarations * Fix paramvalidator
src/main/java/io/reactivex/rxjava3/internal/operators/flowable/FlowableObserveOn.java
@@ -244,8 +244,7 @@ public final boolean isEmpty() { } } - static final class ObserveOnSubscriber<T> extends BaseObserveOnSubscriber<T> - implements FlowableSubscriber<T> { + static final class ObserveOnSubscriber<T> extends BaseObserveOnSubscriber<T> { private static final long seri...
true
Other
ReactiveX
RxJava
73a57dd1064bbfc44a7af7a7461f5613fc52393c.json
3.x: Remove redundant interface declarations (#7438) * 3.x: Remove redundant interface declarations * Fix paramvalidator
src/main/java/io/reactivex/rxjava3/internal/operators/flowable/FlowableToList.java
@@ -46,7 +46,7 @@ protected void subscribeActual(Subscriber<? super U> s) { static final class ToListSubscriber<T, U extends Collection<? super T>> extends DeferredScalarSubscription<U> - implements FlowableSubscriber<T>, Subscription { + implements FlowableSubscriber<T> { private static fi...
true
Other
ReactiveX
RxJava
73a57dd1064bbfc44a7af7a7461f5613fc52393c.json
3.x: Remove redundant interface declarations (#7438) * 3.x: Remove redundant interface declarations * Fix paramvalidator
src/main/java/io/reactivex/rxjava3/internal/operators/observable/ObservableBufferExactBoundary.java
@@ -43,7 +43,7 @@ protected void subscribeActual(Observer<? super U> t) { } static final class BufferExactBoundaryObserver<T, U extends Collection<? super T>, B> - extends QueueDrainObserver<T, U, U> implements Observer<T>, Disposable { + extends QueueDrainObserver<T, U, U> implements Disposable { ...
true
Other
ReactiveX
RxJava
73a57dd1064bbfc44a7af7a7461f5613fc52393c.json
3.x: Remove redundant interface declarations (#7438) * 3.x: Remove redundant interface declarations * Fix paramvalidator
src/main/java/io/reactivex/rxjava3/internal/schedulers/NewThreadWorker.java
@@ -26,7 +26,7 @@ * worker but doesn't perform task-tracking operations. * */ -public class NewThreadWorker extends Scheduler.Worker implements Disposable { +public class NewThreadWorker extends Scheduler.Worker { private final ScheduledExecutorService executor; volatile boolean disposed;
true
Other
ReactiveX
RxJava
73a57dd1064bbfc44a7af7a7461f5613fc52393c.json
3.x: Remove redundant interface declarations (#7438) * 3.x: Remove redundant interface declarations * Fix paramvalidator
src/main/java/io/reactivex/rxjava3/internal/schedulers/TrampolineScheduler.java
@@ -62,7 +62,7 @@ public Disposable scheduleDirect(@NonNull Runnable run, long delay, TimeUnit uni return EmptyDisposable.INSTANCE; } - static final class TrampolineWorker extends Scheduler.Worker implements Disposable { + static final class TrampolineWorker extends Scheduler.Worker { fin...
true
Other
ReactiveX
RxJava
73a57dd1064bbfc44a7af7a7461f5613fc52393c.json
3.x: Remove redundant interface declarations (#7438) * 3.x: Remove redundant interface declarations * Fix paramvalidator
src/test/java/io/reactivex/rxjava3/validators/ParamValidationCheckerTest.java
@@ -560,6 +560,7 @@ public void checkParallelFlowable() { for (Class<?> interfaces : AllFunctionals.class.getInterfaces()) { defaultValues.put(interfaces, af); } + defaultValues.put(Subscriber.class, af); defaultValues.put(TimeUnit.class, TimeUnit.SECONDS); defaul...
true
Other
ReactiveX
RxJava
72f24e2d1603a4b210d3331911b242ce84c5b0a7.json
3.x: Fix marbles of first(T) (#7400)
src/main/java/io/reactivex/rxjava3/core/Flowable.java
@@ -10148,7 +10148,7 @@ public final Maybe<T> firstElement() { * Returns a {@link Single} that emits only the very first item emitted by this {@code Flowable}, or a default * item if this {@code Flowable} completes without emitting anything. * <p> - * <img width="640" height="285" src="https://raw...
true
Other
ReactiveX
RxJava
72f24e2d1603a4b210d3331911b242ce84c5b0a7.json
3.x: Fix marbles of first(T) (#7400)
src/main/java/io/reactivex/rxjava3/core/Observable.java
@@ -8953,7 +8953,7 @@ public final Maybe<T> firstElement() { * Returns a {@link Single} that emits only the very first item emitted by the current {@code Observable}, or a default item * if the current {@code Observable} completes without emitting any items. * <p> - * <img width="640" height="285"...
true
Other
ReactiveX
RxJava
47189ac2ffb71304ca2e44c3d5f51eb9a0ea4e86.json
3.x: Move nullness annotation to use sites of Supplier (#7385)
src/main/java/io/reactivex/rxjava3/core/Completable.java
@@ -479,7 +479,7 @@ public static Completable unsafeCreate(@NonNull CompletableSource onSubscribe) { @CheckReturnValue @NonNull @SchedulerSupport(SchedulerSupport.NONE) - public static Completable defer(@NonNull Supplier<? extends CompletableSource> supplier) { + public static Completable defer(@No...
true
Other
ReactiveX
RxJava
47189ac2ffb71304ca2e44c3d5f51eb9a0ea4e86.json
3.x: Move nullness annotation to use sites of Supplier (#7385)
src/main/java/io/reactivex/rxjava3/core/Flowable.java
@@ -2040,7 +2040,7 @@ public static int bufferSize() { @NonNull @BackpressureSupport(BackpressureKind.PASS_THROUGH) @SchedulerSupport(SchedulerSupport.NONE) - public static <@NonNull T> Flowable<T> defer(@NonNull Supplier<? extends Publisher<? extends T>> supplier) { + public static <@NonNull T> Fl...
true
Other
ReactiveX
RxJava
47189ac2ffb71304ca2e44c3d5f51eb9a0ea4e86.json
3.x: Move nullness annotation to use sites of Supplier (#7385)
src/main/java/io/reactivex/rxjava3/core/Maybe.java
@@ -889,7 +889,7 @@ @CheckReturnValue @NonNull @SchedulerSupport(SchedulerSupport.NONE) - public static <@NonNull T> Maybe<T> defer(@NonNull Supplier<? extends MaybeSource<? extends T>> supplier) { + public static <@NonNull T> Maybe<T> defer(@NonNull Supplier<? extends @NonNull MaybeSource<? extend...
true
Other
ReactiveX
RxJava
47189ac2ffb71304ca2e44c3d5f51eb9a0ea4e86.json
3.x: Move nullness annotation to use sites of Supplier (#7385)
src/main/java/io/reactivex/rxjava3/core/Observable.java
@@ -1790,7 +1790,7 @@ public static int bufferSize() { @CheckReturnValue @NonNull @SchedulerSupport(SchedulerSupport.NONE) - public static <@NonNull T> Observable<T> defer(@NonNull Supplier<? extends ObservableSource<? extends T>> supplier) { + public static <@NonNull T> Observable<T> defer(@NonNul...
true
Other
ReactiveX
RxJava
47189ac2ffb71304ca2e44c3d5f51eb9a0ea4e86.json
3.x: Move nullness annotation to use sites of Supplier (#7385)
src/main/java/io/reactivex/rxjava3/core/Single.java
@@ -895,7 +895,7 @@ @CheckReturnValue @NonNull @SchedulerSupport(SchedulerSupport.NONE) - public static <@NonNull T> Single<T> defer(@NonNull Supplier<? extends SingleSource<? extends T>> supplier) { + public static <@NonNull T> Single<T> defer(@NonNull Supplier<? extends @NonNull SingleSource<? ex...
true
Other
ReactiveX
RxJava
47189ac2ffb71304ca2e44c3d5f51eb9a0ea4e86.json
3.x: Move nullness annotation to use sites of Supplier (#7385)
src/main/java/io/reactivex/rxjava3/functions/Supplier.java
@@ -13,8 +13,6 @@ package io.reactivex.rxjava3.functions; -import io.reactivex.rxjava3.annotations.NonNull; - /** * A functional interface (callback) that provides a single value or * throws an exception. @@ -25,7 +23,7 @@ * @since 3.0.0 */ @FunctionalInterface -public interface Supplier<@NonNull T> { +p...
true
Other
ReactiveX
RxJava
47189ac2ffb71304ca2e44c3d5f51eb9a0ea4e86.json
3.x: Move nullness annotation to use sites of Supplier (#7385)
src/test/java/io/reactivex/rxjava3/validators/NonNullMethodTypeArgumentCheck.java
@@ -57,10 +57,12 @@ static void process(Class<?> clazz) { for (String ta : parseTypeArguments(line)) { if (!ta.startsWith("@NonNull") && !ta.startsWith("@Nullable")) { - result.append("Missing annotation on argument ").ap...
true
Other
ReactiveX
RxJava
30d45272c11ec96b7f0dbe376e4721c7c39ebf77.json
3.x: Add missing exports packages, fix param overrides (#7336)
build.gradle
@@ -31,10 +31,6 @@ if (releaseTag != null && !releaseTag.isEmpty()) { logger.lifecycle("Releasing with version: " + project.version) } -group = "io.reactivex.rxjava3" -version = project.properties["VERSION_NAME"] -description = "RxJava: Reactive Extensions for the JVM – a library for composing asynchronous and ...
true
Other
ReactiveX
RxJava
30d45272c11ec96b7f0dbe376e4721c7c39ebf77.json
3.x: Add missing exports packages, fix param overrides (#7336)
src/main/module/module-info.java
@@ -16,15 +16,17 @@ exports io.reactivex.rxjava3.core; exports io.reactivex.rxjava3.disposables; exports io.reactivex.rxjava3.exceptions; + exports io.reactivex.rxjava3.flowables; exports io.reactivex.rxjava3.functions; exports io.reactivex.rxjava3.observables; exports io.reactivex.rxja...
true
Other
ReactiveX
RxJava
9de33ea8314303d092e70635bbaefcfc6e26639e.json
3.x: Specify proper OSGi unique bundle symbolic name (#7319)
build.gradle
@@ -89,12 +89,13 @@ jar { bnd( "Bundle-Name": "rxjava", "Bundle-Vendor": "RxJava Contributors", - "Bundle-Description": "Reactive Extensions for the JVM – a library for composing asynchronous and event-based programs using observable sequences for the Java VM.", + "B...
false
Other
ReactiveX
RxJava
1d81a9036ffa960df6190fbdfb30a9db88eb3316.json
Update gradle 7.2 (#7314)
gradle/wrapper/gradle-wrapper.properties
@@ -1,5 +1,5 @@ distributionBase=GRADLE_USER_HOME distributionPath=wrapper/dists -distributionUrl=https\://services.gradle.org/distributions/gradle-7.1.1-bin.zip +distributionUrl=https\://services.gradle.org/distributions/gradle-7.2-bin.zip zipStoreBase=GRADLE_USER_HOME zipStorePath=wrapper/dists
true
Other
ReactiveX
RxJava
1d81a9036ffa960df6190fbdfb30a9db88eb3316.json
Update gradle 7.2 (#7314)
gradlew
@@ -1,7 +1,7 @@ -#!/usr/bin/env sh +#!/bin/sh # -# Copyright 2015 the original author or authors. +# Copyright © 2015-2021 the original authors. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. @@ -17,67 +17,101 @@ # #######...
true
Other
ReactiveX
RxJava
94743c1d07d576af87a899a0c0af0cdf036aa26b.json
Add .editorconfig to .gitignore
.gitignore
@@ -76,4 +76,7 @@ bin/ test-output/ # Checkstyle local config -.checkstyle \ No newline at end of file +.checkstyle + +# Some editor's config +.editorconfig
false
Other
ReactiveX
RxJava
66fd701417563fd21c24c177447c332191931dc4.json
3.x: Add subscribe with disposable container (#7298)
src/main/java/io/reactivex/rxjava3/core/Completable.java
@@ -19,7 +19,7 @@ import org.reactivestreams.*; import io.reactivex.rxjava3.annotations.*; -import io.reactivex.rxjava3.disposables.Disposable; +import io.reactivex.rxjava3.disposables.*; import io.reactivex.rxjava3.exceptions.*; import io.reactivex.rxjava3.functions.*; import io.reactivex.rxjava3.internal.funct...
true
Other
ReactiveX
RxJava
66fd701417563fd21c24c177447c332191931dc4.json
3.x: Add subscribe with disposable container (#7298)
src/main/java/io/reactivex/rxjava3/core/Flowable.java
@@ -20,7 +20,7 @@ import org.reactivestreams.*; import io.reactivex.rxjava3.annotations.*; -import io.reactivex.rxjava3.disposables.Disposable; +import io.reactivex.rxjava3.disposables.*; import io.reactivex.rxjava3.exceptions.*; import io.reactivex.rxjava3.flowables.*; import io.reactivex.rxjava3.functions.*; @...
true
Other
ReactiveX
RxJava
66fd701417563fd21c24c177447c332191931dc4.json
3.x: Add subscribe with disposable container (#7298)
src/main/java/io/reactivex/rxjava3/core/Maybe.java
@@ -20,7 +20,7 @@ import org.reactivestreams.*; import io.reactivex.rxjava3.annotations.*; -import io.reactivex.rxjava3.disposables.Disposable; +import io.reactivex.rxjava3.disposables.*; import io.reactivex.rxjava3.exceptions.*; import io.reactivex.rxjava3.functions.*; import io.reactivex.rxjava3.internal.funct...
true
Other
ReactiveX
RxJava
66fd701417563fd21c24c177447c332191931dc4.json
3.x: Add subscribe with disposable container (#7298)
src/main/java/io/reactivex/rxjava3/core/Observable.java
@@ -20,7 +20,7 @@ import org.reactivestreams.Publisher; import io.reactivex.rxjava3.annotations.*; -import io.reactivex.rxjava3.disposables.Disposable; +import io.reactivex.rxjava3.disposables.*; import io.reactivex.rxjava3.exceptions.*; import io.reactivex.rxjava3.functions.*; import io.reactivex.rxjava3.intern...
true
Other
ReactiveX
RxJava
66fd701417563fd21c24c177447c332191931dc4.json
3.x: Add subscribe with disposable container (#7298)
src/main/java/io/reactivex/rxjava3/core/Single.java
@@ -20,7 +20,7 @@ import org.reactivestreams.*; import io.reactivex.rxjava3.annotations.*; -import io.reactivex.rxjava3.disposables.Disposable; +import io.reactivex.rxjava3.disposables.*; import io.reactivex.rxjava3.exceptions.*; import io.reactivex.rxjava3.functions.*; import io.reactivex.rxjava3.internal.funct...
true
Other
ReactiveX
RxJava
66fd701417563fd21c24c177447c332191931dc4.json
3.x: Add subscribe with disposable container (#7298)
src/main/java/io/reactivex/rxjava3/internal/observers/AbstractDisposableAutoRelease.java
@@ -0,0 +1,125 @@ +/* + * Copyright (c) 2016-present, RxJava Contributors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in + * compliance with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unles...
true
Other
ReactiveX
RxJava
66fd701417563fd21c24c177447c332191931dc4.json
3.x: Add subscribe with disposable container (#7298)
src/main/java/io/reactivex/rxjava3/internal/observers/DisposableAutoReleaseMultiObserver.java
@@ -0,0 +1,78 @@ +/* + * Copyright (c) 2016-present, RxJava Contributors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in + * compliance with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless...
true
Other
ReactiveX
RxJava
66fd701417563fd21c24c177447c332191931dc4.json
3.x: Add subscribe with disposable container (#7298)
src/main/java/io/reactivex/rxjava3/internal/observers/DisposableAutoReleaseObserver.java
@@ -0,0 +1,76 @@ +/* + * Copyright (c) 2016-present, RxJava Contributors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in + * compliance with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless...
true
Other
ReactiveX
RxJava
66fd701417563fd21c24c177447c332191931dc4.json
3.x: Add subscribe with disposable container (#7298)
src/main/java/io/reactivex/rxjava3/internal/subscribers/DisposableAutoReleaseSubscriber.java
@@ -0,0 +1,151 @@ +/* + * Copyright (c) 2016-present, RxJava Contributors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in + * compliance with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unles...
true
Other
ReactiveX
RxJava
66fd701417563fd21c24c177447c332191931dc4.json
3.x: Add subscribe with disposable container (#7298)
src/test/java/io/reactivex/rxjava3/internal/observers/CompletableConsumersTest.java
@@ -0,0 +1,221 @@ +/* + * Copyright (c) 2016-present, RxJava Contributors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in + * compliance with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unles...
true
Other
ReactiveX
RxJava
66fd701417563fd21c24c177447c332191931dc4.json
3.x: Add subscribe with disposable container (#7298)
src/test/java/io/reactivex/rxjava3/internal/observers/MaybeConsumersTest.java
@@ -0,0 +1,273 @@ +/* + * Copyright (c) 2016-present, RxJava Contributors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in + * compliance with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unles...
true
Other
ReactiveX
RxJava
66fd701417563fd21c24c177447c332191931dc4.json
3.x: Add subscribe with disposable container (#7298)
src/test/java/io/reactivex/rxjava3/internal/observers/ObservableConsumersTest.java
@@ -0,0 +1,324 @@ +/* + * Copyright (c) 2016-present, RxJava Contributors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in + * compliance with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unles...
true
Other
ReactiveX
RxJava
66fd701417563fd21c24c177447c332191931dc4.json
3.x: Add subscribe with disposable container (#7298)
src/test/java/io/reactivex/rxjava3/internal/observers/SingleConsumersTest.java
@@ -0,0 +1,192 @@ +/* + * Copyright (c) 2016-present, RxJava Contributors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in + * compliance with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unles...
true
Other
ReactiveX
RxJava
66fd701417563fd21c24c177447c332191931dc4.json
3.x: Add subscribe with disposable container (#7298)
src/test/java/io/reactivex/rxjava3/internal/subscribers/FlowableConsumersTest.java
@@ -0,0 +1,328 @@ +/* + * Copyright (c) 2016-present, RxJava Contributors. + * + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in + * compliance with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unles...
true
Other
ReactiveX
RxJava
66fd701417563fd21c24c177447c332191931dc4.json
3.x: Add subscribe with disposable container (#7298)
src/test/java/io/reactivex/rxjava3/validators/BaseTypeAnnotations.java
@@ -22,6 +22,7 @@ import io.reactivex.rxjava3.annotations.*; import io.reactivex.rxjava3.core.*; +import io.reactivex.rxjava3.disposables.DisposableContainer; import io.reactivex.rxjava3.flowables.ConnectableFlowable; import io.reactivex.rxjava3.observables.ConnectableObservable; import io.reactivex.rxjava3.para...
true
Other
ReactiveX
RxJava
66fd701417563fd21c24c177447c332191931dc4.json
3.x: Add subscribe with disposable container (#7298)
src/test/java/io/reactivex/rxjava3/validators/JavadocForAnnotations.java
@@ -95,7 +95,7 @@ static final void scanFor(StringBuilder sourceCode, String annotation, String in ; int lc = lineNumber(sourceCode, idx); - e.append(" at io.reactivex.").append(baseClassName) + e.append(" at io.reactivex.rxjava3.core.")....
true
Other
ReactiveX
RxJava
66fd701417563fd21c24c177447c332191931dc4.json
3.x: Add subscribe with disposable container (#7298)
src/test/java/io/reactivex/rxjava3/validators/JavadocWording.java
@@ -309,6 +309,7 @@ public void flowableDocRefersToFlowableTypes() throws Exception { && !m.signature.contains("Maybe") && !m.signature.contains("MaybeSource") && !m.signature.contains("Disposable") + ...
true
Other
ReactiveX
RxJava
66fd701417563fd21c24c177447c332191931dc4.json
3.x: Add subscribe with disposable container (#7298)
src/test/java/io/reactivex/rxjava3/validators/ParamValidationCheckerTest.java
@@ -25,7 +25,7 @@ import io.reactivex.rxjava3.core.*; import io.reactivex.rxjava3.core.Observable; import io.reactivex.rxjava3.core.Observer; -import io.reactivex.rxjava3.disposables.Disposable; +import io.reactivex.rxjava3.disposables.*; import io.reactivex.rxjava3.exceptions.TestException; import io.reactivex.rx...
true
Other
ReactiveX
RxJava
1d7e8acb3e1fa035a30248a9195a35c7537200b7.json
3.x: fix typo in ObservableRetryTest.java (#7277) seperate -> separate
src/test/java/io/reactivex/rxjava3/internal/operators/observable/ObservableRetryTest.java
@@ -572,7 +572,7 @@ public void run() { } } - /** Observer for listener on seperate thread. */ + /** Observer for listener on separate thread. */ static final class AsyncObserver<T> extends DefaultObserver<T> { protected CountDownLatch latch = new CountDownLatch(1);
false
Other
ReactiveX
RxJava
aeb5e683b6474482ce540f03cea73d22c3af25f8.json
Fix minor formatting issues in build.gradle (#7265)
build.gradle
@@ -74,8 +74,8 @@ javadoc { options.stylesheetFile = project.file("gradle/stylesheet.css") options.links( - "https://docs.oracle.com/javase/8/docs/api/", - "http://www.reactive-streams.org/reactive-streams-${reactiveStreamsVersion}-javadoc/" + "https://docs.oracle.com/javase/8/docs/...
false
Other
ReactiveX
RxJava
a5dad0c66a9fab7685efbcc504d64b3c6d80330f.json
3.x: Consolidate test logging (#7263) * Consolidate test logging Move test logging to consolidated block. Change all 'rootProject' to 'project'. * Only do parallel testing on non-CI machines
build.gradle
@@ -71,7 +71,7 @@ javadoc { options.addStringOption("top").value = "" options.addStringOption("doctitle").value = "" options.addStringOption("header").value = "" - options.stylesheetFile = rootProject.file("gradle/stylesheet.css") + options.stylesheetFile = project.file("gradle/stylesheet.css") ...
false
Other
ReactiveX
RxJava
177256eecde749dbf120a51e19f8af4555cae3f1.json
Remove toolVersion for jacoco and checkstyle (#7261) Remove versioning of Jacoco and Checkstyle. Instead they will be updated by Gradle when it is updated. Dependabot does not update tool versions. If issues come up, they can be corrected when Gradle is updated.
build.gradle
@@ -18,8 +18,6 @@ ext { mockitoVersion = "3.9.0" jmhLibVersion = "1.21" guavaVersion = "30.1.1-jre" - jacocoVersion = "0.8.4" - checkstyleVersion = "8.41" } def releaseTag = System.getenv("BUILD_TAG") @@ -164,10 +162,6 @@ task testng(type: Test) { check.dependsOn testng -jacoco { - too...
false
Other
ReactiveX
RxJava
2f4815d79287d50589a226db5395ab7525bfbcc6.json
3.x: Move Gradle properties into gradle.properties file (#7260) * Move Gradle properties into gradle.properties file Moved version, group, and description into gradle.properties file. Removed POM_ARTIFACT property as the 'name' property in the settings file is used when building the POM. Removed 'release.scope' p...
build.gradle
@@ -27,15 +27,11 @@ if (releaseTag != null && !releaseTag.isEmpty()) { if (releaseTag.startsWith("v")) { releaseTag = releaseTag.substring(1) } - project.setProperty("VERSION_NAME" , releaseTag) + project.version = releaseTag - logger.info("Releasing with version: {}", version) + logger...
true
Other
ReactiveX
RxJava
2f4815d79287d50589a226db5395ab7525bfbcc6.json
3.x: Move Gradle properties into gradle.properties file (#7260) * Move Gradle properties into gradle.properties file Moved version, group, and description into gradle.properties file. Removed POM_ARTIFACT property as the 'name' property in the settings file is used when building the POM. Removed 'release.scope' p...
gradle.properties
@@ -1,7 +1,7 @@ -release.scope=patch -VERSION_NAME=3.0.0-SNAPSHOT +group=io.reactivex.rxjava3 +version=3.0.0-SNAPSHOT +description=RxJava: Reactive Extensions for the JVM – a library for composing asynchronous and event-based programs using observable sequences for the Java VM. -GROUP=io.reactivex.rxjava3 POM_ARTIFA...
true
Other
ReactiveX
RxJava
ac5e569072dee77402f3bb85fa60ce94f5581987.json
Remove Javadoc not failing on error (#7258) The 'javadoc' task should fail when there is an error. The 'javadocCleanup' task failed for PR 7239 due to a plugin issue 242, while it should have been the 'javadoc' task that failed the build. Also, publishing when javadocs fail is not desired.
build.gradle
@@ -66,7 +66,6 @@ tasks.withType(JavaCompile) { apply from: file("gradle/javadoc_cleanup.gradle") javadoc { - failOnError = false exclude "**/internal/**" exclude "**/test/**" exclude "**/perf/**"
false
Other
ReactiveX
RxJava
8fb4640688a1229ed2e09d6618bce10fcb622cf2.json
Remove redundant addition of JMH to classpath (#7257) Remove manual addition of JMH classpath in build file. Gradle adds classpath for all sourceSets to Eclipse by default as fixed in Gradle 6.8 by PR 14534. The JMH sourceSet is added by the JMH Plugin. Tested by running 'eclipse' task in Eclipse 2021-03 (4.19.0)...
build.gradle
@@ -126,10 +126,6 @@ jmh { } } -plugins.withType(EclipsePlugin) { - project.eclipse.classpath.plusConfigurations += [configurations.jmh] -} - test { testLogging { // showing skipped occasionally should prevent CI timeout due to lack of standard output
false