repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
TheCherno/Hazel | 376 | issue_to_patch | Changed std::unique_ptr to Scope in Application.h | The `std::unique_ptr` is changed to `Scope`. Nothing to explain more :)
| 5f9c132a198f2a539129fdc79535bd0295929197 | 2ab55b66489a73593ed7053d7d7b9488a42e083c | diff --git a/Hazel/src/Hazel/Core/Application.h b/Hazel/src/Hazel/Core/Application.h
index fdba1bc73..38ffef558 100644
--- a/Hazel/src/Hazel/Core/Application.h
+++ b/Hazel/src/Hazel/Core/Application.h
@@ -38,7 +38,7 @@ namespace Hazel {
bool OnWindowClose(WindowCloseEvent& e);
bool OnWindowResize(WindowResizeEven... | [
"Hazel/src/Hazel/Core/Application.h"
] | [] | true | ||
TheCherno/Hazel | 374 | issue_to_patch | Make Open and Save file dialogs start from current working directory | #### Describe the issue (if no issue has been made)
This PR doesn't fix any issue.
This PR update `FileDialogs` for better QoL: now Open File and Save File dialogs will start from current working directory (which is the Hazelnut or Sandbox project directory. You don't have to browse your whole computer to go to the `... | 5f9c132a198f2a539129fdc79535bd0295929197 | dab948d42efe6fbbf1159d3d7a95242e05f662ce | diff --git a/Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp b/Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp
index 2511af6f3..f13416bcc 100644
--- a/Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp
+++ b/Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp
@@ -15,11 +15,14 @@ namespace Hazel {
{
OPENFI... | [
"Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp"
] | [] | true | ||
TheCherno/Hazel | 359 | issue_to_patch | Warn if user tries to add a component if already present | #### Describe the issue (if no issue has been made)
The Add Component menu retains the Camera and Sprite Renderer component even if they are already present. If one clicks on them, then the program crashes.
#### PR impact _(Make sure to add [closing keywords](https://help.github.com/en/articles/closing-issues-using... | a014633bb728106b03dce214c765b7e7892f6d70 | 30d03d543570a12d9f3f842e9c556c8494c09763 | diff --git a/Hazelnut/src/Panels/SceneHierarchyPanel.cpp b/Hazelnut/src/Panels/SceneHierarchyPanel.cpp
index 4d07de121..2c183cf8e 100644
--- a/Hazelnut/src/Panels/SceneHierarchyPanel.cpp
+++ b/Hazelnut/src/Panels/SceneHierarchyPanel.cpp
@@ -221,17 +221,23 @@ namespace Hazel {
if (ImGui::BeginPopup("AddComponent"))... | [
"Hazelnut/src/Panels/SceneHierarchyPanel.cpp"
] | [] | true | ||
TheCherno/Hazel | 346 | issue_to_patch | Amended code to conform with C++ standard | The C function `strcpy_s()` was used in a C++ program which is invalid in standard compliant compilers. `strcpy_s()` may even be proprietary to Microsoft. The equivalent C and C++ function `strncpy()` is used in this patch for better compatibility.
This patch was tested under Linux on a Linux branch compiled by GCC ... | 398e41367885ef5697bb0701d0fe1bc798c783dc | 44527c36a26ec5ccdd53ab6570030942f6cbf38e | diff --git a/Hazelnut/src/Panels/SceneHierarchyPanel.cpp b/Hazelnut/src/Panels/SceneHierarchyPanel.cpp
index 53bcb4698..cdf1340a3 100644
--- a/Hazelnut/src/Panels/SceneHierarchyPanel.cpp
+++ b/Hazelnut/src/Panels/SceneHierarchyPanel.cpp
@@ -6,6 +6,14 @@
#include <glm/gtc/type_ptr.hpp>
#include "Hazel/Scene/Componen... | [
"Hazelnut/src/Panels/SceneHierarchyPanel.cpp"
] | [] | true | ||
TheCherno/Hazel | 358 | issue_to_patch | Set vec4 and vec2's encoding style to Flow + use yaml-cpp to load files | I made vec3 and vec4's emitter style to be Flow just like inside `operator <<` which we have `out << YAML::Flow;`
I had this in my own game engine and I think its cool to be also in Hazel.
and use `YAML::LoadFile` to load files. | a014633bb728106b03dce214c765b7e7892f6d70 | 6ad9f22b896d6329b912807ec6b2168310f5c979 | diff --git a/Hazel/src/Hazel/Scene/SceneSerializer.cpp b/Hazel/src/Hazel/Scene/SceneSerializer.cpp
index 0133451d2..0e00bba0c 100644
--- a/Hazel/src/Hazel/Scene/SceneSerializer.cpp
+++ b/Hazel/src/Hazel/Scene/SceneSerializer.cpp
@@ -19,6 +19,7 @@ namespace YAML {
node.push_back(rhs.x);
node.push_back(rhs.y);
... | [
"Hazel/src/Hazel/Scene/SceneSerializer.cpp"
] | [] | true | ||
TheCherno/Hazel | 363 | issue_to_patch | Change to FileDialogs' methods so that they return std::optional. | Not a major change, just personally think we should be using `std::optional` in this instance instead of returning and checking for an empty string.
#### PR impact
Impact | Issue/PR
------------------------ | ------
Issues this solves | None
Other PRs this solves | None
Not sure any... | 62786b8961c90feabe19f8245e3fbaee6ab6a5da | 95f6c2d2f253a2e1a8e45cb447ae4a39b5db1fad | diff --git a/Hazel/src/Hazel/Utils/PlatformUtils.h b/Hazel/src/Hazel/Utils/PlatformUtils.h
index 4ce2a5183..3bcaeb73d 100644
--- a/Hazel/src/Hazel/Utils/PlatformUtils.h
+++ b/Hazel/src/Hazel/Utils/PlatformUtils.h
@@ -1,6 +1,7 @@
#pragma once
#include <string>
+#include <optional>
namespace Hazel {
@@ -8,8 +9,8... | [
"Hazel/src/Hazel/Utils/PlatformUtils.h",
"Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp",
"Hazelnut/src/EditorLayer.cpp"
] | [] | true | ||
TheCherno/Hazel | 343 | issue_to_patch | Fix EventDispatcher::Dispatch() resetting Event::Handled to false | Once an event has been handled, it shouldn't get `Event::Handled` set back to false, but currently `EventDispatcher::Dispatch()` does this.
**Repro**
```
// In a Foo::OnEvent(Hazel::Event& e)
Hazel::EventDispatcher dispatcher(e);
dispatcher.Dispatch<Hazel::KeyPressedEvent>([](Hazel::KeyPressedEvent& e) {
HZ_IN... | c4c66118b26d9a89547fd9230089f6869fc78238 | 21c4264377b874b559974320abefc488a6b4d2fd | diff --git a/Hazel/src/Hazel/Events/Event.h b/Hazel/src/Hazel/Events/Event.h
index 4ff7082ea..e443bbf6f 100644
--- a/Hazel/src/Hazel/Events/Event.h
+++ b/Hazel/src/Hazel/Events/Event.h
@@ -68,7 +68,7 @@ namespace Hazel {
{
if (m_Event.GetEventType() == T::GetStaticType())
{
- m_Event.Handled = func(static... | [
"Hazel/src/Hazel/Events/Event.h"
] | [] | true | ||
TheCherno/Hazel | 322 | issue_to_patch | passing initializer_list by value, it is cheap to copy it, added const qualifiers, VertexArray now using default virtual destructor | - passing initializer_list by value, it is cheap to copy it, added const qualifiers
- added const qualifiers
- VertexArray now using default virtual destructor
| 0090b94af9be167cf5c399d8091c58e78bff41fd | daae14ae74673c2e147489a1272a16064498702e | diff --git a/Hazel/src/Hazel/Renderer/Buffer.h b/Hazel/src/Hazel/Renderer/Buffer.h
index 30a18843c..94ffc68d4 100644
--- a/Hazel/src/Hazel/Renderer/Buffer.h
+++ b/Hazel/src/Hazel/Renderer/Buffer.h
@@ -70,7 +70,7 @@ namespace Hazel {
public:
BufferLayout() {}
- BufferLayout(const std::initializer_list<BufferElem... | [
"Hazel/src/Hazel/Renderer/Buffer.h",
"Hazel/src/Hazel/Renderer/Renderer2D.h",
"Hazel/src/Hazel/Renderer/VertexArray.h"
] | [] | true | ||
TheCherno/Hazel | 306 | issue_to_patch | HZ_ERROR macro not found in places it shouldn't be.
#### Describe the bug
In https://github.com/TheCherno/Hazel/commit/857d8d60e63b23c67edf1bb10e2715fb57089597, cherno had compiler issues that it could not find the HZ_ERROR macro. As a result he had to include `Log.h` where he shouldn't have.
https://github.com/TheC... | Allow assert macro to take no arguments | Changed the HZ_ASSERT and HZ_CORE_ASSERT to allow no additional arguments other than the condition (x)
#### Describe the issue (if no issue has been made)
Saw the TODO note in `Base.h` about enabling the assert macros to allow no arguments other than the condition. Simple fix was to prefix `##` to the `__VA_ARGS__`... | 6a6a925ca7bbab63c908175f900ae41bf9eae18a | 05c552bcb1d68cd6ffbdd6f63973fcfd8a6e408c | diff --git a/Hazel/src/Hazel.h b/Hazel/src/Hazel.h
index 155c104b7..185ab7fca 100644
--- a/Hazel/src/Hazel.h
+++ b/Hazel/src/Hazel.h
@@ -7,6 +7,7 @@
#include "Hazel/Core/Application.h"
#include "Hazel/Core/Layer.h"
#include "Hazel/Core/Log.h"
+#include "Hazel/Core/Assert.h"
#include "Hazel/Core/Timestep.h"
diff... | [
"Hazel/src/Hazel.h",
"Hazel/src/Hazel/Core/Assert.h",
"Hazel/src/Hazel/Core/Base.h",
"Hazelnut/src/Panels/SceneHierarchyPanel.h"
] | [
{
"comment": "- This PR should resolve #326 by including `Log.h`. Also mention this in the initial post then. This PR should also close #327.\r\n- For similar reasons we should include `Base.h` for the `HZ_STRINGIFY_MACRO`\r\n\r\n```suggestion\r\n\r\n#include \"Hazel/Core/Base.h\"\r\n#include \"Hazel/Core/Log.h... | true | |
TheCherno/Hazel | 306 | comment_to_fix | Allow assert macro to take no arguments | - This PR should resolve #326 by including `Log.h`. Also mention this in the initial post then. This PR should also close #327.
- For similar reasons we should include `Base.h` for the `HZ_STRINGIFY_MACRO`
```suggestion
#include "Hazel/Core/Base.h"
#include "Hazel/Core/Log.h"
``` | 6a6a925ca7bbab63c908175f900ae41bf9eae18a | 05c552bcb1d68cd6ffbdd6f63973fcfd8a6e408c | diff --git a/Hazel/src/Hazel/Core/Assert.h b/Hazel/src/Hazel/Core/Assert.h
new file mode 100644
index 000000000..879801e50
--- /dev/null
+++ b/Hazel/src/Hazel/Core/Assert.h
@@ -0,0 +1,39 @@
+#pragma once
+
+#include "Hazel/Core/Base.h"
+#include "Hazel/Core/Log.h"
+
+#ifdef HZ_ENABLE_ASSERTS
+
+ namespace Hazel::Assert... | [
"Hazel/src/Hazel/Core/Assert.h"
] | [
{
"comment": "- This PR should resolve #326 by including `Log.h`. Also mention this in the initial post then. This PR should also close #327.\r\n- For similar reasons we should include `Base.h` for the `HZ_STRINGIFY_MACRO`\r\n\r\n```suggestion\r\n\r\n#include \"Hazel/Core/Base.h\"\r\n#include \"Hazel/Core/Log.h... | true | ||
TheCherno/Hazel | 306 | comment_to_fix | Allow assert macro to take no arguments | Having a closer look, the message should explain the assert, so in this case the check should not be part of the message. It would become too long otherwise...
```suggestion
#define HZ_INTERNAL_ASSERT_WITH_MSG(type, check, ...) HZ_INTERNAL_ASSERT_IMPL(type, check, "Assertion failed: {0}", __VA_ARGS__)
``` | 6a6a925ca7bbab63c908175f900ae41bf9eae18a | 05c552bcb1d68cd6ffbdd6f63973fcfd8a6e408c | diff --git a/Hazel/src/Hazel/Core/Assert.h b/Hazel/src/Hazel/Core/Assert.h
new file mode 100644
index 000000000..879801e50
--- /dev/null
+++ b/Hazel/src/Hazel/Core/Assert.h
@@ -0,0 +1,39 @@
+#pragma once
+
+#include "Hazel/Core/Base.h"
+#include "Hazel/Core/Log.h"
+
+#ifdef HZ_ENABLE_ASSERTS
+
+ namespace Hazel::Assert... | [
"Hazel/src/Hazel/Core/Assert.h"
] | [
{
"comment": "Having a closer look, the message should explain the assert, so in this case the check should not be part of the message. It would become too long otherwise...\r\n```suggestion\r\n\t#define HZ_INTERNAL_ASSERT_WITH_MSG(type, check, ...) HZ_INTERNAL_ASSERT_IMPL(type, check, \"Assertion failed: {0}\"... | true | ||
TheOdinProject/theodinproject | 5,394 | issue_to_patch | Feature: Remove Emmet lesson from curriculum | <!-- Thank you for taking the time to contribute to The Odin Project. In order to get this pull request (PR) merged in a reasonable amount of time, you must complete this entire template. -->
## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it solves or what benefit it provides. -->
... | e87ad3ad38543e8c63e2eb5e4d8dd2465c4bdd26 | ed81364977f75a2eaad71b46ab9bf14beaae2024 | diff --git a/db/fixtures/lessons/html_and_css_lessons.rb b/db/fixtures/lessons/html_and_css_lessons.rb
index fc5132fddf..193718aefd 100644
--- a/db/fixtures/lessons/html_and_css_lessons.rb
+++ b/db/fixtures/lessons/html_and_css_lessons.rb
@@ -65,13 +65,6 @@ def html_and_css_lessons
github_path: '/intermediate_ht... | [
"db/fixtures/lessons/html_and_css_lessons.rb",
"db/fixtures/paths/full_stack_javascript/courses/intermediate_html_css.rb",
"db/fixtures/paths/full_stack_rails/courses/intermediate_html_css.rb"
] | [] | true | ||
TheOdinProject/theodinproject | 5,382 | issue_to_patch | Feature Request: Close sidebar when outside of the sidebar container
### Checks
- [x] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/.github/blob/main/CONTRIBUTING.md)
- [x] The title of this issue follows the `Feature Request: brief description of featur... | Feature: Drawer component closes on outside clicks | <!-- Thank you for taking the time to contribute to The Odin Project. In order to get this pull request (PR) merged in a reasonable amount of time, you must complete this entire template. -->
## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it solves or what benefit it provides. -->
... | 9df861215062c6ecfbe1cef7f14aec064401e344 | 1ee8e82ec613fdedfee54c262e6d5e271d457737 | diff --git a/app/components/overlays/drawer_component.html.erb b/app/components/overlays/drawer_component.html.erb
index 2940de86e3..49f18a9d27 100644
--- a/app/components/overlays/drawer_component.html.erb
+++ b/app/components/overlays/drawer_component.html.erb
@@ -20,9 +20,9 @@
data-transition-leave-end="opacity... | [
"app/components/overlays/drawer_component.html.erb"
] | [
{
"comment": "I was refreshing myself on the structure of this component and noticed we have this. We must have had click outside behaviour on this before, and it either stopped working or never worked to begin with lol.\n\nBut it got me thinking about why it isn't working - I think it's a stacking issue. This ... | true | |
TheOdinProject/theodinproject | 5,383 | issue_to_patch | Fix: Unify margin between list items and paragraphs in lessons | <!-- Thank you for taking the time to contribute to The Odin Project. In order to get this pull request (PR) merged in a reasonable amount of time, you must complete this entire template. -->
## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it solves or what benefit it provides. -->
... | 0af028b6be3cee6c70076779feadb3d1eeb801da | cc4e763f6b00d5e29c2be82f47ae00054a467a38 | diff --git a/app/assets/stylesheets/custom_styles/lesson-content.css b/app/assets/stylesheets/custom_styles/lesson-content.css
index 6436af51d4..6297607dfa 100644
--- a/app/assets/stylesheets/custom_styles/lesson-content.css
+++ b/app/assets/stylesheets/custom_styles/lesson-content.css
@@ -52,6 +52,10 @@
& :is(h3, h... | [
"app/assets/stylesheets/custom_styles/lesson-content.css"
] | [] | true | ||
TheOdinProject/theodinproject | 5,380 | issue_to_patch | Feature Request: Course badge shouldn't be a clickable link on its own course page
### Checks
- [x] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/.github/blob/main/CONTRIBUTING.md)
- [x] The title of this issue follows the `Feature Request: brief descrip... | Feature: Course::BadgeComponent now has a linked parameter | <!-- Thank you for taking the time to contribute to The Odin Project. In order to get this pull request (PR) merged in a reasonable amount of time, you must complete this entire template. -->
## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it solves or what benefit it provides. -->
... | 0af028b6be3cee6c70076779feadb3d1eeb801da | 599d9b02417567ce9a3a8eabe722afcdfcdd0851 | diff --git a/app/components/course/badge_component.html.erb b/app/components/course/badge_component.html.erb
index 06a61d7068..4fdec03e77 100644
--- a/app/components/course/badge_component.html.erb
+++ b/app/components/course/badge_component.html.erb
@@ -1,13 +1,19 @@
-<% if user_signed_in? %>
- <%= link_to path_cours... | [
"app/components/course/badge_component.html.erb",
"app/components/course/badge_component.rb",
"app/views/courses/course/_banner.html.erb",
"spec/components/course/badge_component_spec.rb"
] | [
{
"comment": "Nice call with using the route helpers here instead of creating the route string by hand. If the routes ever change this will correctly break!",
"path": "spec/components/course/badge_component_spec.rb",
"hunk": "@@ -24,4 +26,26 @@\n expect(page).to have_css(\"[data-test-id='default-b... | diff --git a/spec/components/course/badge_component_spec.rb b/spec/components/course/badge_component_spec.rb
index 42af326c42..7e4bb1ab3f 100644
--- a/spec/components/course/badge_component_spec.rb
+++ b/spec/components/course/badge_component_spec.rb
@@ -1,6 +1,8 @@
require 'rails_helper'
RSpec.describe Course::Bad... | true |
TheOdinProject/theodinproject | 5,378 | issue_to_patch | Chore: Replace noticed gem with built-in notifications | ## Because
- The app uses only a sliver of `noticed` (one notifier, database-only, single recipient) β none of its multi-channel fan-out, batching, or events/notifications split. The `params` jsonb column was written but never read.
- Upgrading the gem to stay current (Dependabot #5346: 1.6.3 -> 3.0.0) crosses the 1.x ... | 84941e22834bd3c88a7d0b5101dd487e0ac0e212 | 296bafe6ae749e3ca3ad84619df098f3ae7137b6 | diff --git a/Gemfile b/Gemfile
index 714a9cef9d..cf7dbe12c1 100644
--- a/Gemfile
+++ b/Gemfile
@@ -24,7 +24,6 @@ gem 'jsbundling-rails', '~> 1.3'
gem 'kramdown', '~> 2.5'
gem 'kramdown-parser-gfm'
gem 'newrelic_rpm', '~> 9.23'
-gem 'noticed', '~> 1.6'
gem 'octokit', '~> 10.0'
gem 'omniauth-github', '~> 2.0.1'
gem... | [
"Gemfile",
"Gemfile.lock",
"app/models/flags/actions/notify_user.rb",
"app/models/notification.rb",
"app/models/notifications/dead_link_notification.rb",
"app/models/notifications/flag_notification.rb",
"app/services/messages/dead_link.rb",
"db/migrate/20260605120000_cleanup_notifications_columns.rb",... | [
{
"comment": "`discard_at` is a datetime column (see `db/schema.rb`), but this spec expects it to change to `7.days.from_now.all_day`, which is a Range. This makes the expectation incorrect and likely flaky/always-failing depending on how it's evaluated.\n\nUse a time matcher (or freeze time) and compare to a t... | diff --git a/spec/factories/notifications.rb b/spec/factories/notifications.rb
index ee2c556d7d..7063d2ffb1 100644
--- a/spec/factories/notifications.rb
+++ b/spec/factories/notifications.rb
@@ -1,8 +1,6 @@
FactoryBot.define do
factory :notification do
recipient factory: :user
- type { '' }
- params { ''... | true | |
TheOdinProject/theodinproject | 5,378 | comment_to_fix | Chore: Replace noticed gem with built-in notifications | `discard_at` is a datetime column (see `db/schema.rb`), but this spec expects it to change to `7.days.from_now.all_day`, which is a Range. This makes the expectation incorrect and likely flaky/always-failing depending on how it's evaluated.
Use a time matcher (or freeze time) and compare to a timestamp instead of a Ra... | 84941e22834bd3c88a7d0b5101dd487e0ac0e212 | 296bafe6ae749e3ca3ad84619df098f3ae7137b6 | diff --git a/spec/models/flags/actions/notify_user_spec.rb b/spec/models/flags/actions/notify_user_spec.rb
index 90ff3af1df..b05268f646 100644
--- a/spec/models/flags/actions/notify_user_spec.rb
+++ b/spec/models/flags/actions/notify_user_spec.rb
@@ -11,18 +11,14 @@
.to change { flag.project_submission.reloa... | [
"spec/models/flags/actions/notify_user_spec.rb"
] | [
{
"comment": "`discard_at` is a datetime column (see `db/schema.rb`), but this spec expects it to change to `7.days.from_now.all_day`, which is a Range. This makes the expectation incorrect and likely flaky/always-failing depending on how it's evaluated.\n\nUse a time matcher (or freeze time) and compare to a t... | true | ||
TheOdinProject/theodinproject | 5,378 | comment_to_fix | Chore: Replace noticed gem with built-in notifications | This changes notification delivery from async (`deliver_later`) to synchronous record creation. That can change request latency and also changes failure behavior (an exception from `create!` will now bubble up and prevent returning a `Result`).
If the intent is still βfire-and-forgetβ, consider moving delivery back to... | 84941e22834bd3c88a7d0b5101dd487e0ac0e212 | 296bafe6ae749e3ca3ad84619df098f3ae7137b6 | diff --git a/app/models/flags/actions/notify_user.rb b/app/models/flags/actions/notify_user.rb
index 1a49cb700f..b7dc2f0cf0 100644
--- a/app/models/flags/actions/notify_user.rb
+++ b/app/models/flags/actions/notify_user.rb
@@ -16,15 +16,6 @@ def perform # rubocop:disable Metrics/AbcSize
private
def send_notific... | [
"app/models/flags/actions/notify_user.rb"
] | [
{
"comment": "This changes notification delivery from async (`deliver_later`) to synchronous record creation. That can change request latency and also changes failure behavior (an exception from `create!` will now bubble up and prevent returning a `Result`).\n\nIf the intent is still βfire-and-forgetβ, consider... | true | ||
TheOdinProject/theodinproject | 5,378 | comment_to_fix | Chore: Replace noticed gem with built-in notifications | PR description says the `type` column is being kept (opting out of STI) and only the NOT NULL is relaxed, but this migration drops the `type` column entirely. Please either:
- keep the column and change it to nullable + disable STI via `self.inheritance_column = :_type_disabled`, or
- update the PR description to refle... | 84941e22834bd3c88a7d0b5101dd487e0ac0e212 | 296bafe6ae749e3ca3ad84619df098f3ae7137b6 | diff --git a/db/migrate/20260605120000_cleanup_notifications_columns.rb b/db/migrate/20260605120000_cleanup_notifications_columns.rb
new file mode 100644
index 0000000000..17b866c0fa
--- /dev/null
+++ b/db/migrate/20260605120000_cleanup_notifications_columns.rb
@@ -0,0 +1,8 @@
+class CleanupNotificationsColumns < Activ... | [
"db/migrate/20260605120000_cleanup_notifications_columns.rb"
] | [
{
"comment": "PR description says the `type` column is being kept (opting out of STI) and only the NOT NULL is relaxed, but this migration drops the `type` column entirely. Please either:\n- keep the column and change it to nullable + disable STI via `self.inheritance_column = :_type_disabled`, or\n- update the... | true | ||
TheOdinProject/theodinproject | 5,372 | issue_to_patch | Upgrade: Bump rubocop from 1.81.7 to 1.87.0 | Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.81.7 to 1.87.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/rubocop/rubocop/releases">rubocop's releases</a>.</em></p>
<blockquote>
<h2>RuboCop v1.87.0</h2>
<h3>New features</h3>
<ul>
<li><a href="https://redirect.... | 5163d3a622521ca5ad242180daf1a84469217ecd | bdf5bc5dbbaea79ebca69197862752ba543e561f | diff --git a/Gemfile.lock b/Gemfile.lock
index efbecbd1ac..a3f87eabd5 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -363,7 +363,7 @@ GEM
omniauth (~> 2.0)
orm_adapter (0.5.0)
pagy (9.3.5)
- parallel (1.28.0)
+ parallel (2.1.0)
parallel_tests (5.4.0)
parallel
parser (3.3.11.1)
@... | [
"Gemfile.lock",
"app/models/flag.rb",
"db/migrate/20240726181456_add_reactivated_to_admin_user.rb",
"db/migrate/20250212143446_add_search_ts_vector_column_to_users.rb",
"spec/models/interview_concept_spec.rb",
"spec/models/interview_survey_concept_spec.rb"
] | [] | diff --git a/spec/models/interview_concept_spec.rb b/spec/models/interview_concept_spec.rb
index e3010b412a..55b93077e8 100644
--- a/spec/models/interview_concept_spec.rb
+++ b/spec/models/interview_concept_spec.rb
@@ -3,7 +3,7 @@
RSpec.describe InterviewConcept do
subject(:interview_concept) { create(:interview_co... | true | |
TheOdinProject/theodinproject | 5,377 | issue_to_patch | Chore: Remove obsolete Heroku heroku_ext extension patch | Because:
- Heroku rolled back the heroku_ext schema requirement in 2023 (changelog 2662); extensions install in public by default again.
This PR:
- Removes config/initializers/patch_enable_extension.rb, which is now a no-op and only risked mangling schema-qualified extension names. | 816a8ddd3514d0a40cc93abd0d04b93269fd9da0 | ee7f61ec55beb0acb8a41dd47b9558941e25309a | diff --git a/config/initializers/patch_enable_extension.rb b/config/initializers/patch_enable_extension.rb
deleted file mode 100644
index 32964b4cef..0000000000
--- a/config/initializers/patch_enable_extension.rb
+++ /dev/null
@@ -1,19 +0,0 @@
-require 'active_record/connection_adapters/postgresql_adapter'
-
-# NOTE: p... | [
"config/initializers/patch_enable_extension.rb"
] | [] | true | ||
TheOdinProject/theodinproject | 5,373 | issue_to_patch | Upgrade: Bump tailwindcss from 4.2.2 to 4.3.0 | Bumps [tailwindcss](https://github.com/tailwindlabs/tailwindcss/tree/HEAD/packages/tailwindcss) from 4.2.2 to 4.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/tailwindlabs/tailwindcss/releases">tailwindcss's releases</a>.</em></p>
<blockquote>
<h2>v4.3.0</h2>
<h3>Added</... | 75eca85df423d9a34b0117807f4356973ef9a3c6 | 7a54cb3adab824b81cf37cf63bff5f3a7764ff07 | diff --git a/package.json b/package.json
index c0bbd48a54..a4c82af692 100644
--- a/package.json
+++ b/package.json
@@ -33,7 +33,7 @@
"prismjs": "^1.30.0",
"sortablejs": "^1.15.7",
"stimulus-use": "^0.52.3",
- "tailwindcss": "4.2.2",
+ "tailwindcss": "4.3.0",
"tippy.js": "^6.3.7"
},
"brow... | [
"package.json",
"yarn.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,356 | issue_to_patch | Bug: Sidebar progress bar missing padding on desktop
### Checks
- [x] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/.github/blob/main/CONTRIBUTING.md)
- [x] The title of this issue follows the `Bug: brief description of bug` format, e.g. `Bug: Lesson com... | Fix: Fix desktop sidebar padding |
<!-- Thank you for taking the time to contribute to The Odin Project. In order to get this pull request (PR) merged in a reasonable amount of time, you must complete this entire template. -->
## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it solves or what benefit it provides. -... | 16efbd93fa83da2164886bf4c4a9c8ddd366ce3e | a9ca8dff7f5072e8c1ad576211ec3b4278fc1e08 | diff --git a/app/assets/stylesheets/custom_styles/layout.css b/app/assets/stylesheets/custom_styles/layout.css
index 9c1d5001e6..e55bea1ade 100644
--- a/app/assets/stylesheets/custom_styles/layout.css
+++ b/app/assets/stylesheets/custom_styles/layout.css
@@ -15,7 +15,7 @@ html:has([data-controller~="lessons--sidebar-to... | [
"app/assets/stylesheets/custom_styles/layout.css",
"app/components/lessons/sidebar_component.html.erb",
"app/views/lessons/_sidebar_skeleton.html.erb",
"app/views/lessons/_sub_navbar.html.erb",
"app/views/lessons/show.html.erb"
] | [
{
"comment": "Nit: the alignment with this and the back link + progressbar looks a little off. Could we moving the padding up to the wrapping `<div class=\"mb-4 flex flex-col gap-2\">` so the whole header block aligns with the section/lesson rows?",
"path": "app/components/lessons/sidebar_component.html.erb... | true | |
TheOdinProject/theodinproject | 5,356 | comment_to_fix | Fix: Fix desktop sidebar padding | Nit: Can we move the px-2 to the wrapper here too please? | 16efbd93fa83da2164886bf4c4a9c8ddd366ce3e | a9ca8dff7f5072e8c1ad576211ec3b4278fc1e08 | diff --git a/app/components/lessons/sidebar_component.html.erb b/app/components/lessons/sidebar_component.html.erb
index 7620976897..dc03628420 100644
--- a/app/components/lessons/sidebar_component.html.erb
+++ b/app/components/lessons/sidebar_component.html.erb
@@ -1,6 +1,6 @@
<%= render Overlays::DrawerComponent.new... | [
"app/components/lessons/sidebar_component.html.erb"
] | [
{
"comment": "Nit: Can we move the px-2 to the wrapper here too please?",
"path": "app/components/lessons/sidebar_component.html.erb",
"hunk": "@@ -3,7 +3,7 @@\n <div class=\"flex flex-col gap-2\">\n <%= render Ui::BackLinkComponent.new(path: path_course_path(course.path, course), name: 'Back ... | true | ||
TheOdinProject/theodinproject | 5,356 | comment_to_fix | Fix: Fix desktop sidebar padding | Nit: What do you think of `xl:w-80` here? With the left page padding gone, the overall width of the sidebar has decreased a little, making it look too narrow perhaps?
If changing is more difficult than it looks, or has too many knock on effects. I think we should keep it at 72 though. | 16efbd93fa83da2164886bf4c4a9c8ddd366ce3e | a9ca8dff7f5072e8c1ad576211ec3b4278fc1e08 | diff --git a/app/views/lessons/show.html.erb b/app/views/lessons/show.html.erb
index 72b440e3c8..ba08872c9d 100644
--- a/app/views/lessons/show.html.erb
+++ b/app/views/lessons/show.html.erb
@@ -7,7 +7,7 @@
data-lessons--sidebar-toggle-collapsed-class="sidebar-collapsed"
data-lessons--sidebar-toggle-visibility-ou... | [
"app/views/lessons/show.html.erb"
] | [
{
"comment": "Nit: What do you think of `xl:w-80` here? With the left page padding gone, the overall width of the sidebar has decreased a little, making it look too narrow perhaps?\n\nIf changing is more difficult than it looks, or has too many knock on effects. I think we should keep it at 72 though. ",
"p... | true | ||
TheOdinProject/theodinproject | 5,374 | issue_to_patch | Upgrade: Bump postcss from 8.5.14 to 8.5.15 | Bumps [postcss](https://github.com/postcss/postcss) from 8.5.14 to 8.5.15.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/postcss/postcss/releases">postcss's releases</a>.</em></p>
<blockquote>
<h2>8.5.15</h2>
<ul>
<li>Fixed declaration parsing performance (by <a href="https:... | cda253b16202c32908e9184ce3f582d7d9e9e6b9 | 4e7a7e8e40086fead399d48c736fb06b1750376d | diff --git a/package.json b/package.json
index 3ef9efc0bf..5f256c8efb 100644
--- a/package.json
+++ b/package.json
@@ -29,7 +29,7 @@
"esbuild-rails": "^1.0.7",
"flatpickr": "^4.6.13",
"mermaid": "^11.15.0",
- "postcss": "^8.5.10",
+ "postcss": "^8.5.15",
"prismjs": "^1.30.0",
"sortablejs"... | [
"package.json",
"yarn.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,371 | issue_to_patch | Upgrade: Bump turbo-rails from 2.0.17 to 2.0.23 | Bumps [turbo-rails](https://github.com/hotwired/turbo-rails) from 2.0.17 to 2.0.23.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/hotwired/turbo-rails/releases">turbo-rails's releases</a>.</em></p>
<blockquote>
<h2>v2.0.23</h2>
<p>Updates the bundled JS to freshen stale depe... | cda253b16202c32908e9184ce3f582d7d9e9e6b9 | 8b3c273a74893b5fc02563eb36e5dfdd8837ff85 | diff --git a/Gemfile.lock b/Gemfile.lock
index e34b9babda..efbecbd1ac 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -253,7 +253,7 @@ GEM
reline (>= 0.4.2)
jsbundling-rails (1.3.1)
railties (>= 6.0.0)
- json (2.19.5)
+ json (2.19.7)
jwt (3.2.0)
base64
kramdown (2.5.1)
@@ -592,... | [
"Gemfile.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,375 | issue_to_patch | Upgrade: Bump @sentry/browser from 10.46.0 to 10.55.0 | Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 10.46.0 to 10.55.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/getsentry/sentry-javascript/releases">@βsentry/browser's releases</a>.</em></p>
<blockquote>
<h2>10.55.0</h2>
<h3>Important Changes<... | cda253b16202c32908e9184ce3f582d7d9e9e6b9 | eb297be06e35df503d4fc37dad7096fff78ea998 | diff --git a/package.json b/package.json
index 3ef9efc0bf..51b789c511 100644
--- a/package.json
+++ b/package.json
@@ -12,7 +12,7 @@
"@hotwired/stimulus": "^3.2.2",
"@hotwired/turbo-rails": "^8.0.23",
"@rails/request.js": "^0.0.13",
- "@sentry/browser": "^10.46.0",
+ "@sentry/browser": "^10.55.0",
... | [
"package.json",
"yarn.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,367 | issue_to_patch | Feature Request: Smooth scrolling with heading/ToC links
### Checks
- [x] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/.github/blob/main/CONTRIBUTING.md)
- [x] The title of this issue follows the `Feature Request: brief description of feature request` f... | Feature: Use smooth scrolling for scroll-tos | ## This PR
<!-- A bullet point list of one or more items describing the specific changes. -->
- Applies smooth scrolling to whole page (if not prefers reduced motion)
- Removes now-redundant ScrollTo stimulus controller
## Issue
<!--
If this PR closes an open issue in this repo, replace the XXXXX below with the... | 37c68829e6b445be41c2ec75864af29e26ab52ba | 9be5e051e89043df99eb6e44fb2dec508cadba9d | diff --git a/app/components/team/navigation_component.html.erb b/app/components/team/navigation_component.html.erb
index 10902d46c3..48f786cbdd 100644
--- a/app/components/team/navigation_component.html.erb
+++ b/app/components/team/navigation_component.html.erb
@@ -1,13 +1,13 @@
<div>
<div class="sm:hidden">
... | [
"app/components/team/navigation_component.html.erb",
"app/javascript/controllers/scroll_to_controller.js",
"app/views/layouts/application.html.erb"
] | [] | true | |
TheOdinProject/theodinproject | 5,366 | issue_to_patch | Chore: Remove unused PathPrerequisite model | Because:
The PathPrerequisite feature has been dormant since the All Paths page redesign in 2022 removed the UI that displayed prerequisites. Nothing in the app reads `path.prerequisites` or `path.path_prerequisites` anymore; seed files were still writing join rows that no view, controller or service consults.
This... | 37c68829e6b445be41c2ec75864af29e26ab52ba | 7f059de9d86f3c469cebe10c3eb1657187ca81fb | diff --git a/app/models/path.rb b/app/models/path.rb
index 4a6b4747cb..572fcf6ff0 100644
--- a/app/models/path.rb
+++ b/app/models/path.rb
@@ -6,8 +6,6 @@ class Path < ApplicationRecord
has_many :users, dependent: :nullify
has_many :courses, -> { order(:position) }, dependent: :destroy, inverse_of: :path
has_m... | [
"app/models/path.rb",
"app/models/path_prerequisite.rb",
"db/fixtures/paths/full_stack_javascript/seed.rb",
"db/fixtures/paths/full_stack_rails/seed.rb",
"db/migrate/20260530124754_drop_path_prerequisites_table.rb",
"db/schema.rb",
"spec/factories/path_prerequisites.rb",
"spec/models/path_prerequisite... | [
{
"comment": "Most of these schema changes are included because this is the first time db:migrate was run since the Rails 8.1 bump.",
"path": "db/schema.rb",
"hunk": "@@ -10,25 +10,25 @@\n #\n # It's strongly recommended that you check this file into your version control system.\n \n-ActiveRecord::Schem... | diff --git a/spec/factories/path_prerequisites.rb b/spec/factories/path_prerequisites.rb
deleted file mode 100644
index ddad496efe..0000000000
--- a/spec/factories/path_prerequisites.rb
+++ /dev/null
@@ -1,6 +0,0 @@
-FactoryBot.define do
- factory :path_prerequisite do
- path
- prerequisite factory: :path
- end... | true | |
TheOdinProject/theodinproject | 5,366 | comment_to_fix | Chore: Remove unused PathPrerequisite model | `drop_table` is currently irreversible (hence the RuboCop disable). Since the table definition is known, you can make this migration reversible by providing a block that describes the table; this lets Rails recreate it on rollback and removes the need to disable `Rails/ReversibleMigration`. | 37c68829e6b445be41c2ec75864af29e26ab52ba | 7f059de9d86f3c469cebe10c3eb1657187ca81fb | diff --git a/db/migrate/20260530124754_drop_path_prerequisites_table.rb b/db/migrate/20260530124754_drop_path_prerequisites_table.rb
new file mode 100644
index 0000000000..9a519b02f2
--- /dev/null
+++ b/db/migrate/20260530124754_drop_path_prerequisites_table.rb
@@ -0,0 +1,5 @@
+class DropPathPrerequisitesTable < Active... | [
"db/migrate/20260530124754_drop_path_prerequisites_table.rb"
] | [
{
"comment": "`drop_table` is currently irreversible (hence the RuboCop disable). Since the table definition is known, you can make this migration reversible by providing a block that describes the table; this lets Rails recreate it on rollback and removes the need to disable `Rails/ReversibleMigration`.",
... | true | ||
TheOdinProject/theodinproject | 5,366 | comment_to_fix | Chore: Remove unused PathPrerequisite model | `db/schema.rb` includes a broad schema dump rewrite (e.g., schema version header / extension namespace and many column order changes) in addition to removing `path_prerequisites`. This makes the PR harder to review and increases merge-conflict risk; consider reverting/re-dumping so the schema diff is limited to droppin... | 37c68829e6b445be41c2ec75864af29e26ab52ba | 7f059de9d86f3c469cebe10c3eb1657187ca81fb | diff --git a/db/schema.rb b/db/schema.rb
index 739116c265..b22b7efb7a 100644
--- a/db/schema.rb
+++ b/db/schema.rb
@@ -10,9 +10,9 @@
#
# It's strongly recommended that you check this file into your version control system.
-ActiveRecord::Schema[7.1].define(version: 2025_02_15_230748) do
+ActiveRecord::Schema[8.1].de... | [
"db/schema.rb"
] | [
{
"comment": "`db/schema.rb` includes a broad schema dump rewrite (e.g., schema version header / extension namespace and many column order changes) in addition to removing `path_prerequisites`. This makes the PR harder to review and increases merge-conflict risk; consider reverting/re-dumping so the schema diff... | true | ||
TheOdinProject/theodinproject | 5,368 | issue_to_patch | Feature Request: Project submissions visual styling
### Checks
- [x] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/.github/blob/main/CONTRIBUTING.md)
- [x] The title of this issue follows the `Feature Request: brief description of feature request` format... | Feature: project submission UI changes | <!-- Thank you for taking the time to contribute to The Odin Project. In order to get this pull request (PR) merged in a reasonable amount of time, you must complete this entire template. -->
## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it solves or what benefit it provides. -->
... | 37c68829e6b445be41c2ec75864af29e26ab52ba | 897da5431582c3798f7432bc9906d6180889ffa1 | diff --git a/app/components/project_submissions/item_component.html.erb b/app/components/project_submissions/item_component.html.erb
index 7f42aa0684..008572e853 100644
--- a/app/components/project_submissions/item_component.html.erb
+++ b/app/components/project_submissions/item_component.html.erb
@@ -15,12 +15,12 @@
... | [
"app/components/project_submissions/item_component.html.erb",
"app/components/project_submissions/user_solution_component.html.erb"
] | [] | true | |
TheOdinProject/theodinproject | 5,363 | issue_to_patch | Bug: Performance issues & N+1 queries in User completions methods
### Checks
- [x] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/.github/blob/main/CONTRIBUTING.md)
- [x] The title of this issue follows the `Bug: brief description of bug` format, e.g. `Bu... | Chore: remove unused User completions methods | ## Because
Both `User#completed?` and `User#latest_completed_lesson` are unused in the production codebase (only referenced/called in the test suite). Removing them cleans up dead code.
## This PR
- Deletes `User#completed?` and `User#latest_completed_lesson` from `app/models/user.rb`.
- Removes the corresponding... | 145886bad6eb19f41905dc452a1a5464729c6ce2 | 12ce3865f0d0b8272d66ad28a91c7412b0ea57bd | diff --git a/app/models/user.rb b/app/models/user.rb
index c9c7fdff8d..1de6944c01 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -46,16 +46,6 @@ def progress_for(course)
@progress[course]
end
- def completed?(lesson)
- completed_lessons.pluck(:id).include?(lesson.id)
- end
-
- def latest_co... | [
"app/models/user.rb",
"spec/models/user_spec.rb"
] | [] | diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb
index 20c041013e..df15a10542 100644
--- a/spec/models/user_spec.rb
+++ b/spec/models/user_spec.rb
@@ -83,65 +83,6 @@
end
end
- describe '#completed?' do
- let(:lesson) { create(:lesson) }
-
- context 'when the user has completed the lesso... | true |
TheOdinProject/theodinproject | 5,350 | issue_to_patch | Upgrade: Bump @tailwindcss/cli from 4.2.4 to 4.3.0 | Bumps [@tailwindcss/cli](https://github.com/tailwindlabs/tailwindcss/tree/HEAD/packages/@tailwindcss-cli) from 4.2.4 to 4.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/tailwindlabs/tailwindcss/releases">@βtailwindcss/cli's releases</a>.</em></p>
<blockquote>
<h2>v4.3.0<... | 6de03456ef35ea8bf7f61294345e66a679fd2aa7 | c15d2991e5cfe57bc7ddba75696869637cb97dba | diff --git a/package.json b/package.json
index b32b7b2069..7802579ab1 100644
--- a/package.json
+++ b/package.json
@@ -15,7 +15,7 @@
"@sentry/browser": "^10.46.0",
"@sentry/esbuild-plugin": "^5.3.0",
"@stimulus/polyfills": "^2.0.0",
- "@tailwindcss/cli": "^4.2.4",
+ "@tailwindcss/cli": "^4.3.0",
... | [
"package.json",
"yarn.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,351 | issue_to_patch | Upgrade: Bump stylelint from 17.8.0 to 17.12.0 | Bumps [stylelint](https://github.com/stylelint/stylelint) from 17.8.0 to 17.12.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/stylelint/stylelint/releases">stylelint's releases</a>.</em></p>
<blockquote>
<h2>17.12.0</h2>
<p>It fixes 3 bugs, including a false negative one.<... | de0731a62137e441e3a41e3cc8022fbe759ec1cb | 2bdbb2d8c5e58467de73450a32db0199b4145dda | diff --git a/package.json b/package.json
index 6d9e5a4ff9..11caf9abfe 100644
--- a/package.json
+++ b/package.json
@@ -41,7 +41,7 @@
],
"devDependencies": {
"standard": "^17.1.2",
- "stylelint": "^17.8.0",
+ "stylelint": "^17.12.0",
"stylelint-config-standard": "^40.0.0"
},
"packageManager":... | [
"package.json",
"yarn.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,362 | issue_to_patch | Chore: Update GitHub actions versions
### Checks
- [x] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/.github/blob/main/CONTRIBUTING.md)
- [x] The title of this issue follows the `Chore: brief description of chore` format, e.g. `Chore: Lesson complete but... | Chore: Update actions to Node 24 versions | <!-- Thank you for taking the time to contribute to The Odin Project. In order to get this pull request (PR) merged in a reasonable amount of time, you must complete this entire template. -->
## Because
- Node 20 is getting deprecated
## This PR
- Updates the action version to the latest version. There are no b... | 145886bad6eb19f41905dc452a1a5464729c6ce2 | a159f4eaf1d43209efe702a2854b9a61338894bf | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 489c4eb73f..8f3ec674fb 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
- uses: actions/checkout@v4
+ uses: actions/checko... | [
".github/workflows/ci.yml"
] | [] | true | |
TheOdinProject/theodinproject | 5,361 | issue_to_patch | Fix: Correct a typo in community guide page | <!-- Thank you for taking the time to contribute to The Odin Project. In order to get this pull request (PR) merged in a reasonable amount of time, you must complete this entire template. -->
## Because
"Avoid asking" is redundant under a "Don't" list β "Don't Avoid Asking" reads as a double negative.
<!-- Summari... | b158459e2212deecf72aa3a1efd50c260aab48c0 | 090ce93d0819a5a9a9fdaade09123c763e9d00ce | diff --git a/app/views/guides/community/rules.html.erb b/app/views/guides/community/rules.html.erb
index 17bd1b36c6..1d1167bd39 100644
--- a/app/views/guides/community/rules.html.erb
+++ b/app/views/guides/community/rules.html.erb
@@ -49,7 +49,7 @@
<li>Send direct messages, friend requests, or ping another user ... | [
"app/views/guides/community/rules.html.erb"
] | [] | true | ||
TheOdinProject/theodinproject | 5,355 | issue_to_patch | Feature: Move Lofty to emeritus | <!-- Thank you for taking the time to contribute to The Odin Project. In order to get this pull request (PR) merged in a reasonable amount of time, you must complete this entire template. -->
## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it solves or what benefit it provides. -->
... | de0731a62137e441e3a41e3cc8022fbe759ec1cb | 6186e596e724ddab0724357e74ba05a0fa1f36b8 | diff --git a/config/locales/team.yml b/config/locales/team.yml
index 35f856b0e6..ffdef300ed 100644
--- a/config/locales/team.yml
+++ b/config/locales/team.yml
@@ -212,14 +212,6 @@ en:
- name: "linkedin"
url: "https://www.linkedin.com/in/mclilzee"
- - name: "Lofty"
- image: ... | [
"config/locales/team.yml"
] | [] | true | ||
TheOdinProject/theodinproject | 5,349 | issue_to_patch | Upgrade: Bump @sentry/esbuild-plugin from 5.2.0 to 5.3.0 | Bumps [@sentry/esbuild-plugin](https://github.com/getsentry/sentry-javascript-bundler-plugins) from 5.2.0 to 5.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/getsentry/sentry-javascript-bundler-plugins/releases">@βsentry/esbuild-plugin's releases</a>.</em></p>
<blockquot... | de0731a62137e441e3a41e3cc8022fbe759ec1cb | e00b82a21e35e245fe4baea49eafbdca871fd390 | diff --git a/package.json b/package.json
index 6d9e5a4ff9..b32b7b2069 100644
--- a/package.json
+++ b/package.json
@@ -13,7 +13,7 @@
"@hotwired/turbo-rails": "^8.0.23",
"@rails/request.js": "^0.0.13",
"@sentry/browser": "^10.46.0",
- "@sentry/esbuild-plugin": "^5.2.0",
+ "@sentry/esbuild-plugin": "... | [
"package.json",
"yarn.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,348 | issue_to_patch | Upgrade: Bump rubocop-rspec from 3.6.0 to 3.9.0 | Bumps [rubocop-rspec](https://github.com/rubocop/rubocop-rspec) from 3.6.0 to 3.9.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/rubocop/rubocop-rspec/releases">rubocop-rspec's releases</a>.</em></p>
<blockquote>
<h2>RuboCop RSpec v3.9.0</h2>
<ul>
<li>Fix a false positive ... | de0731a62137e441e3a41e3cc8022fbe759ec1cb | b0fa8c5096a6f01e15eae01b21eb3cb954b05e5d | diff --git a/Gemfile.lock b/Gemfile.lock
index 7858198a63..8d6fdfb2f7 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -363,10 +363,10 @@ GEM
omniauth (~> 2.0)
orm_adapter (0.5.0)
pagy (9.3.5)
- parallel (1.27.0)
+ parallel (1.28.0)
parallel_tests (5.4.0)
parallel
- parser (3.3.10.1... | [
"Gemfile.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,347 | issue_to_patch | Upgrade: Bump public_activity from 3.0.1 to 3.0.2 | Bumps [public_activity](https://github.com/public-activity/public_activity) from 3.0.1 to 3.0.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/public-activity/public_activity/releases">public_activity's releases</a>.</em></p>
<blockquote>
<h2>v3.0.2</h2>
<h2>What's Changed</... | de0731a62137e441e3a41e3cc8022fbe759ec1cb | 28de929fa9587f5e56bd1cfec7c82827e871f7c2 | diff --git a/Gemfile.lock b/Gemfile.lock
index 7858198a63..96511bd339 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -385,11 +385,11 @@ GEM
psych (5.3.1)
date
stringio
- public_activity (3.0.1)
- actionpack (>= 6.1.0)
+ public_activity (3.0.2)
+ actionpack (>= 6.1)
activerecor... | [
"Gemfile.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,354 | issue_to_patch | Feature Request: Make anchor click space larger for Lesson Content list
### Checks
- [x] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/.github/blob/main/CONTRIBUTING.md)
- [x] The title of this issue follows the `Feature Request: brief description of fea... | Feature: Nested lesson_toc anchor elements now inherit the size of their parent li element | <!-- Thank you for taking the time to contribute to The Odin Project. In order to get this pull request (PR) merged in a reasonable amount of time, you must complete this entire template. -->
## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it solves or what benefit it provides. -->
... | de0731a62137e441e3a41e3cc8022fbe759ec1cb | 85c2fb1a1fc1f365ade7cf1bb2af09b50ef68cdd | diff --git a/app/javascript/controllers/lesson_toc_controller.js b/app/javascript/controllers/lesson_toc_controller.js
index d09dc15c4c..3e8eab6b86 100644
--- a/app/javascript/controllers/lesson_toc_controller.js
+++ b/app/javascript/controllers/lesson_toc_controller.js
@@ -57,6 +57,6 @@ export default class LessonTocC... | [
"app/javascript/controllers/lesson_toc_controller.js"
] | [] | true | |
TheOdinProject/theodinproject | 5,340 | issue_to_patch | Feature Request: Previous and Next lesson enhancement
### Checks
- [x] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/.github/blob/main/CONTRIBUTING.md)
- [x] The title of this issue follows the `Feature Request: brief description of feature request` form... | Feature: Previous and Next lesson buttons now share min-width | <!-- Thank you for taking the time to contribute to The Odin Project. In order to get this pull request (PR) merged in a reasonable amount of time, you must complete this entire template. -->
## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it solves or what benefit it provides. -->
... | fbb5d24d285ed2700d566e9167e2c2a51a7a2a52 | 8a90d4eacf9087777fbc10a2e7c6bbceb0da621d | diff --git a/app/views/lessons/_lesson_buttons.html.erb b/app/views/lessons/_lesson_buttons.html.erb
index 7cb880bb2f..4b0b5b1cfa 100644
--- a/app/views/lessons/_lesson_buttons.html.erb
+++ b/app/views/lessons/_lesson_buttons.html.erb
@@ -1,7 +1,7 @@
<div class="flex flex-col gap-y-6 max-w-sm mx-auto md:grid md:grid-c... | [
"app/views/lessons/_lesson_buttons.html.erb"
] | [] | true | |
TheOdinProject/theodinproject | 5,341 | issue_to_patch | Feature: Add Goran to the maintainer team | <!-- Thank you for taking the time to contribute to The Odin Project. In order to get this pull request (PR) merged in a reasonable amount of time, you must complete this entire template. -->
## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it solves or what benefit it provides. -->
... | fbb5d24d285ed2700d566e9167e2c2a51a7a2a52 | e69c405cab09cb249280b96538f3dd6efc7f950f | diff --git a/config/locales/team.yml b/config/locales/team.yml
index 16582a0fd8..35f856b0e6 100644
--- a/config/locales/team.yml
+++ b/config/locales/team.yml
@@ -1,4 +1,3 @@
-
# -- Active team member attributes --
# name - required
# image - required
@@ -180,6 +179,16 @@ en:
- name: "linkedin"
... | [
"config/locales/team.yml"
] | [] | true | ||
TheOdinProject/theodinproject | 5,338 | issue_to_patch | Chore: Refactor BeliefComponent
**Context:**
As part of the contributing page Tailwind update, we re-used the `AboutPage::BeliefComponent` because the cards there shared a very similar structure. However, the specific naming convention no longer makes sense.
**Task**
The component should be refactored to have a... | Chore: Refactor BeliefComponent into MediaCardComponent (#3379) | Because:
AboutPage::BeliefComponent has been reused beyond the About page (it also drives the Contributing page benefits cards), so the Belief naming no longer fits.
Closes: https://github.com/TheOdinProject/theodinproject/issues/3379
This PR:
- Renames AboutPage::BeliefComponent to a top-level MediaCardCompone... | 302305114e4020417fa383759a0c3712e6eaeeb7 | 802c01ebf1c16da6f45b11000193145a899d7ddb | diff --git a/app/components/about_page/belief_component.rb b/app/components/about_page/belief_component.rb
deleted file mode 100644
index 06ab826ff5..0000000000
--- a/app/components/about_page/belief_component.rb
+++ /dev/null
@@ -1,7 +0,0 @@
-class AboutPage::BeliefComponent < ApplicationComponent
- with_collection_p... | [
"app/components/about_page/belief_component.rb",
"app/components/media_card_component.html.erb",
"app/components/media_card_component.rb",
"app/views/static_pages/about.html.erb",
"app/views/static_pages/contributing.html.erb",
"spec/components/media_card_component_spec.rb",
"spec/components/previews/ab... | [] | diff --git a/spec/components/media_card_component_spec.rb b/spec/components/media_card_component_spec.rb
new file mode 100644
index 0000000000..199da103d1
--- /dev/null
+++ b/spec/components/media_card_component_spec.rb
@@ -0,0 +1,47 @@
+require 'rails_helper'
+
+RSpec.describe MediaCardComponent, type: :component do
+... | true |
TheOdinProject/theodinproject | 5,328 | issue_to_patch | Implementation of "Previous Lesson" button
--#### Description
--I believe there should be an implementation of a "Previous Lesson" button on the lesson button group. As I have gone through this curriculum many times have I needed to go back and revisit previous material but to do so I've had to go through "View Cou... | Feature: Replace lesson View Course button with Previous Lesson | Because:
With the new course-contents sidebar on the lesson page providing a "Back to course" link on both mobile and desktop, the View Course button at the bottom of the lesson was redundant. Swapping it for a Previous Lesson button gives users a natural pair with the existing Next Lesson button for sequential naviga... | 1dbcc83cdce7a3a02396a0073f88845a11a1082b | 19663d0593774db2d4d4949cc7219baee2e78f77 | diff --git a/app/models/course.rb b/app/models/course.rb
index 8055816a13..4b8393e9f6 100644
--- a/app/models/course.rb
+++ b/app/models/course.rb
@@ -18,6 +18,10 @@ def progress_for(user)
end
def next_lesson(lesson)
- lessons.where('lessons.position > ?', lesson.position).first
+ lessons.where(lessons: {... | [
"app/models/course.rb",
"app/views/lessons/_lesson_buttons.html.erb",
"spec/models/course_spec.rb",
"spec/system/lesson_navigation_spec.rb"
] | [
{
"comment": "`next_lesson` uses `.first` without an explicit `order`, so the database will return the first matching row by its default ordering (typically primary key), not by `lessons.position`. This can return an incorrect βnextβ lesson if IDs and positions ever diverge. Consider ordering by `position ASC` ... | diff --git a/spec/models/course_spec.rb b/spec/models/course_spec.rb
index 39379b2bed..d6a90510c5 100644
--- a/spec/models/course_spec.rb
+++ b/spec/models/course_spec.rb
@@ -37,10 +37,24 @@
it 'returns the next lesson' do
course = create(:course)
section = create(:section, course:)
- le... | true |
TheOdinProject/theodinproject | 5,328 | comment_to_fix | Feature: Replace lesson View Course button with Previous Lesson | `next_lesson` uses `.first` without an explicit `order`, so the database will return the first matching row by its default ordering (typically primary key), not by `lessons.position`. This can return an incorrect βnextβ lesson if IDs and positions ever diverge. Consider ordering by `position ASC` (and limiting to 1) be... | 1dbcc83cdce7a3a02396a0073f88845a11a1082b | 19663d0593774db2d4d4949cc7219baee2e78f77 | diff --git a/app/models/course.rb b/app/models/course.rb
index 8055816a13..4b8393e9f6 100644
--- a/app/models/course.rb
+++ b/app/models/course.rb
@@ -18,6 +18,10 @@ def progress_for(user)
end
def next_lesson(lesson)
- lessons.where('lessons.position > ?', lesson.position).first
+ lessons.where(lessons: {... | [
"app/models/course.rb"
] | [
{
"comment": "`next_lesson` uses `.first` without an explicit `order`, so the database will return the first matching row by its default ordering (typically primary key), not by `lessons.position`. This can return an incorrect βnextβ lesson if IDs and positions ever diverge. Consider ordering by `position ASC` ... | true | ||
TheOdinProject/theodinproject | 5,328 | comment_to_fix | Feature: Replace lesson View Course button with Previous Lesson | `previous_lesson` uses `.last` without an explicit `order`, which will select the record with the highest primary key among matches rather than the highest `position` below the current lesson. To reliably return the immediately previous lesson, order by `position DESC` and take the first record.
| 1dbcc83cdce7a3a02396a0073f88845a11a1082b | 19663d0593774db2d4d4949cc7219baee2e78f77 | diff --git a/app/models/course.rb b/app/models/course.rb
index 8055816a13..4b8393e9f6 100644
--- a/app/models/course.rb
+++ b/app/models/course.rb
@@ -18,6 +18,10 @@ def progress_for(user)
end
def next_lesson(lesson)
- lessons.where('lessons.position > ?', lesson.position).first
+ lessons.where(lessons: {... | [
"app/models/course.rb"
] | [
{
"comment": "`previous_lesson` uses `.last` without an explicit `order`, which will select the record with the highest primary key among matches rather than the highest `position` below the current lesson. To reliably return the immediately previous lesson, order by `position DESC` and take the first record.\n... | true | ||
TheOdinProject/theodinproject | 5,328 | comment_to_fix | Feature: Replace lesson View Course button with Previous Lesson | `course.previous_lesson(lesson)` is executed twice (once for the presence check and again for the link), which can cause multiple DB queries and potential inconsistencies. Assign it to a local variable (e.g., `previous = ...`) and reuse it for both the conditional and the `lesson_path` call.
| 1dbcc83cdce7a3a02396a0073f88845a11a1082b | 19663d0593774db2d4d4949cc7219baee2e78f77 | diff --git a/app/views/lessons/_lesson_buttons.html.erb b/app/views/lessons/_lesson_buttons.html.erb
index 3c1bb7b570..7cb880bb2f 100644
--- a/app/views/lessons/_lesson_buttons.html.erb
+++ b/app/views/lessons/_lesson_buttons.html.erb
@@ -1,29 +1,43 @@
-<div class="flex flex-col justify-between max-w-sm mx-auto space-y... | [
"app/views/lessons/_lesson_buttons.html.erb"
] | [
{
"comment": "`course.previous_lesson(lesson)` is executed twice (once for the presence check and again for the link), which can cause multiple DB queries and potential inconsistencies. Assign it to a local variable (e.g., `previous = ...`) and reuse it for both the conditional and the `lesson_path` call.\n",
... | true | ||
TheOdinProject/theodinproject | 5,328 | comment_to_fix | Feature: Replace lesson View Course button with Previous Lesson | `course.next_lesson(lesson)` is called multiple times in this block (condition + link), which can trigger duplicate queries. Consider storing it in a local variable and reusing it for the conditional and `lesson_path`. | 1dbcc83cdce7a3a02396a0073f88845a11a1082b | 19663d0593774db2d4d4949cc7219baee2e78f77 | diff --git a/app/views/lessons/_lesson_buttons.html.erb b/app/views/lessons/_lesson_buttons.html.erb
index 3c1bb7b570..7cb880bb2f 100644
--- a/app/views/lessons/_lesson_buttons.html.erb
+++ b/app/views/lessons/_lesson_buttons.html.erb
@@ -1,29 +1,43 @@
-<div class="flex flex-col justify-between max-w-sm mx-auto space-y... | [
"app/views/lessons/_lesson_buttons.html.erb"
] | [
{
"comment": "`course.next_lesson(lesson)` is called multiple times in this block (condition + link), which can trigger duplicate queries. Consider storing it in a local variable and reusing it for the conditional and `lesson_path`.",
"path": "app/views/lessons/_lesson_buttons.html.erb",
"hunk": "@@ -1,... | true | ||
TheOdinProject/theodinproject | 5,328 | comment_to_fix | Feature: Replace lesson View Course button with Previous Lesson | In the βprevious lessonβ spec, `next_lesson` is the lesson being visited (the one after `lesson`), which makes the example harder to read. Renaming this `let!` to something like `current_lesson`/`second_lesson` would better match the behavior under test.
| 1dbcc83cdce7a3a02396a0073f88845a11a1082b | 19663d0593774db2d4d4949cc7219baee2e78f77 | diff --git a/spec/system/lesson_navigation_spec.rb b/spec/system/lesson_navigation_spec.rb
index 5334f30d15..e93191bc1f 100644
--- a/spec/system/lesson_navigation_spec.rb
+++ b/spec/system/lesson_navigation_spec.rb
@@ -23,13 +23,15 @@
context 'when on the last lesson of a section' do
let!(:next_section) {... | [
"spec/system/lesson_navigation_spec.rb"
] | [
{
"comment": "In the βprevious lessonβ spec, `next_lesson` is the lesson being visited (the one after `lesson`), which makes the example harder to read. Renaming this `let!` to something like `current_lesson`/`second_lesson` would better match the behavior under test.\n",
"path": "spec/system/lesson_navigat... | true | ||
TheOdinProject/theodinproject | 5,328 | comment_to_fix | Feature: Replace lesson View Course button with Previous Lesson | The new `#previous_lesson` spec only covers a single-candidate case. Because the implementation currently relies on `.last`/`.first` without an explicit `order`, adding a case with multiple prior lessons (created out of order by ID) would catch regressions and ensure the method returns the immediate neighbor by `positi... | 1dbcc83cdce7a3a02396a0073f88845a11a1082b | 19663d0593774db2d4d4949cc7219baee2e78f77 | diff --git a/spec/models/course_spec.rb b/spec/models/course_spec.rb
index 39379b2bed..d6a90510c5 100644
--- a/spec/models/course_spec.rb
+++ b/spec/models/course_spec.rb
@@ -37,10 +37,24 @@
it 'returns the next lesson' do
course = create(:course)
section = create(:section, course:)
- le... | [
"spec/models/course_spec.rb"
] | [
{
"comment": "The new `#previous_lesson` spec only covers a single-candidate case. Because the implementation currently relies on `.last`/`.first` without an explicit `order`, adding a case with multiple prior lessons (created out of order by ID) would catch regressions and ensure the method returns the immedia... | true | ||
TheOdinProject/theodinproject | 5,328 | comment_to_fix | Feature: Replace lesson View Course button with Previous Lesson | `next_lesson` / `previous_lesson` only order by `position`. Since thereβs no uniqueness constraint on `lessons.position` within a course (see `db/schema.rb`), duplicate positions would make βnext/previousβ navigation nondeterministic. Consider adding a deterministic tie-breaker (e.g., order by `position` then `id`) and... | 1dbcc83cdce7a3a02396a0073f88845a11a1082b | 19663d0593774db2d4d4949cc7219baee2e78f77 | diff --git a/app/models/course.rb b/app/models/course.rb
index 8055816a13..4b8393e9f6 100644
--- a/app/models/course.rb
+++ b/app/models/course.rb
@@ -18,6 +18,10 @@ def progress_for(user)
end
def next_lesson(lesson)
- lessons.where('lessons.position > ?', lesson.position).first
+ lessons.where(lessons: {... | [
"app/models/course.rb"
] | [
{
"comment": "`next_lesson` / `previous_lesson` only order by `position`. Since thereβs no uniqueness constraint on `lessons.position` within a course (see `db/schema.rb`), duplicate positions would make βnext/previousβ navigation nondeterministic. Consider adding a deterministic tie-breaker (e.g., order by `po... | true | ||
TheOdinProject/theodinproject | 5,328 | comment_to_fix | Feature: Replace lesson View Course button with Previous Lesson | Using Tailwindβs `contents` (`display: contents`) for layout can cause accessibility issues in some browser/screen reader combinations (elements can lose semantics / focus order). Since this partial relies on `contents` for multiple slots, consider an alternative layout that doesnβt require `display: contents` (e.g., a... | 1dbcc83cdce7a3a02396a0073f88845a11a1082b | 19663d0593774db2d4d4949cc7219baee2e78f77 | diff --git a/app/views/lessons/_lesson_buttons.html.erb b/app/views/lessons/_lesson_buttons.html.erb
index 3c1bb7b570..7cb880bb2f 100644
--- a/app/views/lessons/_lesson_buttons.html.erb
+++ b/app/views/lessons/_lesson_buttons.html.erb
@@ -1,29 +1,43 @@
-<div class="flex flex-col justify-between max-w-sm mx-auto space-y... | [
"app/views/lessons/_lesson_buttons.html.erb"
] | [
{
"comment": "Using Tailwindβs `contents` (`display: contents`) for layout can cause accessibility issues in some browser/screen reader combinations (elements can lose semantics / focus order). Since this partial relies on `contents` for multiple slots, consider an alternative layout that doesnβt require `displ... | true | ||
TheOdinProject/theodinproject | 5,328 | comment_to_fix | Feature: Replace lesson View Course button with Previous Lesson | This example is intended to verify that, when youβre on the first lesson of a section, the Previous Lesson button goes to the *last* lesson of the previous section. Right now the previous section only has one lesson, so the spec would still pass even if the implementation navigated to the wrong earlier lesson. Consider... | 1dbcc83cdce7a3a02396a0073f88845a11a1082b | 19663d0593774db2d4d4949cc7219baee2e78f77 | diff --git a/spec/system/lesson_navigation_spec.rb b/spec/system/lesson_navigation_spec.rb
index 5334f30d15..e93191bc1f 100644
--- a/spec/system/lesson_navigation_spec.rb
+++ b/spec/system/lesson_navigation_spec.rb
@@ -23,13 +23,15 @@
context 'when on the last lesson of a section' do
let!(:next_section) {... | [
"spec/system/lesson_navigation_spec.rb"
] | [
{
"comment": "This example is intended to verify that, when youβre on the first lesson of a section, the Previous Lesson button goes to the *last* lesson of the previous section. Right now the previous section only has one lesson, so the spec would still pass even if the implementation navigated to the wrong ea... | true | ||
TheOdinProject/theodinproject | 5,335 | issue_to_patch | Upgrade: Bump minimatch from 3.1.4 to 10.2.5 | Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.1.4 to 10.2.5.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/isaacs/minimatch/blob/main/changelog.md">minimatch's changelog</a>.</em></p>
<blockquote>
<h1>change log</h1>
<h2>10.2</h2>
<ul>
<li>Add <code>braceExpandMa... | 4ae01457d4d98d2db75243855689857a6bf0ac39 | 668e214b624ddb9190918a3954882d5425e7421d | diff --git a/yarn.lock b/yarn.lock
index 7926f51364..6fd68d5dec 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -2068,7 +2068,7 @@ __metadata:
languageName: node
linkType: hard
-"brace-expansion@npm:^5.0.2":
+"brace-expansion@npm:^5.0.5":
version: 5.0.6
resolution: "brace-expansion@npm:5.0.6"
dependencies:
@... | [
"yarn.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,334 | issue_to_patch | Upgrade: Bump lodash-es from 4.17.21 to 4.18.1 | Bumps [lodash-es](https://github.com/lodash/lodash) from 4.17.21 to 4.18.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash-es's releases</a>.</em></p>
<blockquote>
<h2>4.18.1</h2>
<h2>Bugs</h2>
<p>Fixes a <code>ReferenceError</code> issue in <co... | 72795da71c1defd37080fc201ba985d0b77b5ec1 | 28bd1a5f70a1dee029e84de36be8e9dbc6a46d88 | diff --git a/yarn.lock b/yarn.lock
index 6f5317045d..3931c36618 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -5056,9 +5056,9 @@ __metadata:
linkType: hard
"lodash-es@npm:^4.17.21":
- version: 4.17.21
- resolution: "lodash-es@npm:4.17.21"
- checksum: 10c0/fb407355f7e6cd523a9383e76e6b455321f0f153a6c9625e21a8827d10c... | [
"yarn.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,327 | issue_to_patch | Upgrade: Bump jwt from 2.10.1 to 3.2.0 | Bumps [jwt](https://github.com/jwt/ruby-jwt) from 2.10.1 to 3.2.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/jwt/ruby-jwt/blob/main/CHANGELOG.md">jwt's changelog</a>.</em></p>
<blockquote>
<h2><a href="https://github.com/jwt/ruby-jwt/tree/v3.2.0">v3.2.0</a> (2026-05-13)</h2>... | a3a27c360ec037b6fdfec2808a47924be37a6559 | c105469eafaf6b4b745d3f73238d1125f4ba7acb | diff --git a/Gemfile.lock b/Gemfile.lock
index 95a1633a02..be4b916067 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -80,6 +80,8 @@ GEM
addressable (2.9.0)
public_suffix (>= 2.0.2, < 8.0)
ast (2.4.3)
+ auth-sanitizer (0.1.2)
+ version_gem (~> 1.1, >= 1.1.9)
awesome_print (1.9.2)
barn... | [
"Gemfile.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,326 | issue_to_patch | Upgrade: Bump brace-expansion from 2.0.1 to 5.0.6 | Bumps [brace-expansion](https://github.com/juliangruber/brace-expansion) from 2.0.1 to 5.0.6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/juliangruber/brace-expansion/releases">brace-expansion's releases</a>.</em></p>
<blockquote>
<h2>v4.0.1</h2>
<ul>
<li>fmt 5a5cc17</li>... | a3a27c360ec037b6fdfec2808a47924be37a6559 | 6ee218b93e6db90252939591e9c5610ebbf834b1 | diff --git a/yarn.lock b/yarn.lock
index 167907f10c..02795a6dcc 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -2100,11 +2100,11 @@ __metadata:
linkType: hard
"brace-expansion@npm:^5.0.2":
- version: 5.0.5
- resolution: "brace-expansion@npm:5.0.5"
+ version: 5.0.6
+ resolution: "brace-expansion@npm:5.0.6"
depen... | [
"yarn.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,312 | issue_to_patch | Chore: Extract off-canvas drawer pattern into Overlays::DrawerComponent | Because the nav, lesson sidebar, and admin sidebar all duplicated the same overlay + slide-in panel + visibility controller wiring, this PR extracts the shared shell into a single reusable ViewComponent. Callers yield their content in and pass a hook class and optional breakpoint.
| 0ce30382a821d175782892c58868c8ef347ebcc9 | 9149d098d9c44fceb92c1c085d7bd28fdfa8aa46 | diff --git a/app/components/lessons/sidebar_component.html.erb b/app/components/lessons/sidebar_component.html.erb
index a8886c72b6..7620976897 100644
--- a/app/components/lessons/sidebar_component.html.erb
+++ b/app/components/lessons/sidebar_component.html.erb
@@ -1,72 +1,22 @@
-<%# Off-canvas drawer β below xl %>
-<... | [
"app/components/lessons/sidebar_component.html.erb",
"app/components/overlays/drawer_component.html.erb",
"app/components/overlays/drawer_component.rb",
"app/views/layouts/admin/_sidebar_nav.html.erb",
"app/views/shared/_off_canvas_menu.html.erb",
"spec/components/overlays/drawer_component_spec.rb"
] | [
{
"comment": "`breakpoint` accepts any value but `breakpoint_class` only distinguishes `:xl` vs βeverything elseβ, silently falling back to `lg:hidden`. This makes typos/unsupported breakpoints hard to detect. Consider validating `breakpoint` against an allowlist (e.g., `:lg`, `:xl`) and raising an `ArgumentErr... | diff --git a/spec/components/overlays/drawer_component_spec.rb b/spec/components/overlays/drawer_component_spec.rb
new file mode 100644
index 0000000000..8d79d335d7
--- /dev/null
+++ b/spec/components/overlays/drawer_component_spec.rb
@@ -0,0 +1,56 @@
+require 'rails_helper'
+
+RSpec.describe Overlays::DrawerComponent,... | true | |
TheOdinProject/theodinproject | 5,312 | comment_to_fix | Chore: Extract off-canvas drawer pattern into Overlays::DrawerComponent | `breakpoint` accepts any value but `breakpoint_class` only distinguishes `:xl` vs βeverything elseβ, silently falling back to `lg:hidden`. This makes typos/unsupported breakpoints hard to detect. Consider validating `breakpoint` against an allowlist (e.g., `:lg`, `:xl`) and raising an `ArgumentError`, or expanding supp... | 0ce30382a821d175782892c58868c8ef347ebcc9 | 9149d098d9c44fceb92c1c085d7bd28fdfa8aa46 | diff --git a/app/components/overlays/drawer_component.rb b/app/components/overlays/drawer_component.rb
new file mode 100644
index 0000000000..5a6ef4dc8b
--- /dev/null
+++ b/app/components/overlays/drawer_component.rb
@@ -0,0 +1,22 @@
+class Overlays::DrawerComponent < ApplicationComponent
+ BREAKPOINT_CLASSES = { lg: ... | [
"app/components/overlays/drawer_component.rb"
] | [
{
"comment": "`breakpoint` accepts any value but `breakpoint_class` only distinguishes `:xl` vs βeverything elseβ, silently falling back to `lg:hidden`. This makes typos/unsupported breakpoints hard to detect. Consider validating `breakpoint` against an allowlist (e.g., `:lg`, `:xl`) and raising an `ArgumentErr... | true | ||
TheOdinProject/theodinproject | 5,312 | comment_to_fix | Chore: Extract off-canvas drawer pattern into Overlays::DrawerComponent | This mobile drawer is rendered with `role="dialog"` but no accessible name (no `aria-label`/`aria-labelledby`). Since `Overlays::DrawerComponent` already supports `aria_label:`, consider passing one here (e.g., "Navigation") so screen readers can identify the dialog.
| 0ce30382a821d175782892c58868c8ef347ebcc9 | 9149d098d9c44fceb92c1c085d7bd28fdfa8aa46 | diff --git a/app/views/shared/_off_canvas_menu.html.erb b/app/views/shared/_off_canvas_menu.html.erb
index 44d1af2c83..ae22bb87aa 100644
--- a/app/views/shared/_off_canvas_menu.html.erb
+++ b/app/views/shared/_off_canvas_menu.html.erb
@@ -1,90 +1,40 @@
-<div
- data-controller="visibility"
- data-visibility-target="co... | [
"app/views/shared/_off_canvas_menu.html.erb"
] | [
{
"comment": "This mobile drawer is rendered with `role=\"dialog\"` but no accessible name (no `aria-label`/`aria-labelledby`). Since `Overlays::DrawerComponent` already supports `aria_label:`, consider passing one here (e.g., \"Navigation\") so screen readers can identify the dialog.\n",
"path": "app/views... | true | ||
TheOdinProject/theodinproject | 5,312 | comment_to_fix | Chore: Extract off-canvas drawer pattern into Overlays::DrawerComponent | This off-canvas drawer uses `role="dialog"` but is missing an accessible name. Since `Overlays::DrawerComponent` supports `aria_label:`, consider providing something like "Admin sidebar"/"Admin navigation" so assistive tech can announce the dialog meaningfully.
| 0ce30382a821d175782892c58868c8ef347ebcc9 | 9149d098d9c44fceb92c1c085d7bd28fdfa8aa46 | diff --git a/app/views/layouts/admin/_sidebar_nav.html.erb b/app/views/layouts/admin/_sidebar_nav.html.erb
index f273166379..00652f1740 100644
--- a/app/views/layouts/admin/_sidebar_nav.html.erb
+++ b/app/views/layouts/admin/_sidebar_nav.html.erb
@@ -20,78 +20,26 @@ nav_links = [
]
%>
-<!-- Off-canvas menu for mobi... | [
"app/views/layouts/admin/_sidebar_nav.html.erb"
] | [
{
"comment": "This off-canvas drawer uses `role=\"dialog\"` but is missing an accessible name. Since `Overlays::DrawerComponent` supports `aria_label:`, consider providing something like \"Admin sidebar\"/\"Admin navigation\" so assistive tech can announce the dialog meaningfully.\n",
"path": "app/views/lay... | true | ||
TheOdinProject/theodinproject | 5,312 | comment_to_fix | Chore: Extract off-canvas drawer pattern into Overlays::DrawerComponent | Indentation is inconsistent on the `turbo_frame_tag 'theme_switcher_mobile'` line (it has an extra leading space compared to surrounding lines). With `SpaceIndentation`/`ClosingErbTagIndent` enabled in erb_lint, this is likely to fail CI; please align indentation with the surrounding ERB block.
| 0ce30382a821d175782892c58868c8ef347ebcc9 | 9149d098d9c44fceb92c1c085d7bd28fdfa8aa46 | diff --git a/app/views/shared/_off_canvas_menu.html.erb b/app/views/shared/_off_canvas_menu.html.erb
index 44d1af2c83..ae22bb87aa 100644
--- a/app/views/shared/_off_canvas_menu.html.erb
+++ b/app/views/shared/_off_canvas_menu.html.erb
@@ -1,90 +1,40 @@
-<div
- data-controller="visibility"
- data-visibility-target="co... | [
"app/views/shared/_off_canvas_menu.html.erb"
] | [
{
"comment": "Indentation is inconsistent on the `turbo_frame_tag 'theme_switcher_mobile'` line (it has an extra leading space compared to surrounding lines). With `SpaceIndentation`/`ClosingErbTagIndent` enabled in erb_lint, this is likely to fail CI; please align indentation with the surrounding ERB block.\n"... | true | ||
TheOdinProject/theodinproject | 5,312 | comment_to_fix | Chore: Extract off-canvas drawer pattern into Overlays::DrawerComponent | `role="dialog"` elements should always have an accessible name (via `aria-label` or `aria-labelledby`). Since this component conditionally omits `aria-label`, itβs possible to render an unlabeled dialog; consider making a label required (or adding an `aria_labelledby:` option) and enforcing it in the initializer.
| 0ce30382a821d175782892c58868c8ef347ebcc9 | 9149d098d9c44fceb92c1c085d7bd28fdfa8aa46 | diff --git a/app/components/overlays/drawer_component.html.erb b/app/components/overlays/drawer_component.html.erb
new file mode 100644
index 0000000000..2940de86e3
--- /dev/null
+++ b/app/components/overlays/drawer_component.html.erb
@@ -0,0 +1,52 @@
+<div
+ class="relative z-50 hidden <%= breakpoint_class %> <%= hoo... | [
"app/components/overlays/drawer_component.html.erb"
] | [
{
"comment": "`role=\"dialog\"` elements should always have an accessible name (via `aria-label` or `aria-labelledby`). Since this component conditionally omits `aria-label`, itβs possible to render an unlabeled dialog; consider making a label required (or adding an `aria_labelledby:` option) and enforcing it i... | true | ||
TheOdinProject/theodinproject | 5,312 | comment_to_fix | Chore: Extract off-canvas drawer pattern into Overlays::DrawerComponent | The drawer close button lost the visible focus styling and larger tap target that existed in some prior implementations (e.g., the mobile nav close button previously had focus ring classes and explicit sizing). For keyboard accessibility and usability, consider adding consistent focus-visible ring/outline classes (and ... | 0ce30382a821d175782892c58868c8ef347ebcc9 | 9149d098d9c44fceb92c1c085d7bd28fdfa8aa46 | diff --git a/app/components/overlays/drawer_component.html.erb b/app/components/overlays/drawer_component.html.erb
new file mode 100644
index 0000000000..2940de86e3
--- /dev/null
+++ b/app/components/overlays/drawer_component.html.erb
@@ -0,0 +1,52 @@
+<div
+ class="relative z-50 hidden <%= breakpoint_class %> <%= hoo... | [
"app/components/overlays/drawer_component.html.erb"
] | [
{
"comment": "The drawer close button lost the visible focus styling and larger tap target that existed in some prior implementations (e.g., the mobile nav close button previously had focus ring classes and explicit sizing). For keyboard accessibility and usability, consider adding consistent focus-visible ring... | true | ||
TheOdinProject/theodinproject | 5,325 | issue_to_patch | Upgrade: Bump faraday from 2.14.1 to 2.14.2 | Bumps [faraday](https://github.com/lostisland/faraday) from 2.14.1 to 2.14.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/lostisland/faraday/releases">faraday's releases</a>.</em></p>
<blockquote>
<h2>v2.14.2</h2>
<h2>Security Note</h2>
<p>This release contains a security ... | a3a27c360ec037b6fdfec2808a47924be37a6559 | d26ac340c522c468e5ef2836ad9422aee8e6bcfd | diff --git a/Gemfile.lock b/Gemfile.lock
index 95a1633a02..80faee5e4d 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -182,7 +182,7 @@ GEM
factory_bot_rails (6.5.1)
factory_bot (~> 6.5)
railties (>= 6.1.0)
- faraday (2.14.1)
+ faraday (2.14.2)
faraday-net_http (>= 2.0, < 3.5)
json... | [
"Gemfile.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,321 | issue_to_patch | Upgrade: Bump mermaid from 11.12.3 to 11.15.0 | Bumps [mermaid](https://github.com/mermaid-js/mermaid) from 11.12.3 to 11.15.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/mermaid-js/mermaid/releases">mermaid's releases</a>.</em></p>
<blockquote>
<h2>mermaid@11.15.0</h2>
<h3>Minor Changes</h3>
<ul>
<li>
<p><a href="http... | 0ce30382a821d175782892c58868c8ef347ebcc9 | 18a2b66d657dcb04a9d9e6bd12591c9148461f22 | diff --git a/package.json b/package.json
index a05e41e43b..6d9e5a4ff9 100644
--- a/package.json
+++ b/package.json
@@ -28,7 +28,7 @@
"esbuild-plugin-prismjs": "^1.0.8",
"esbuild-rails": "^1.0.7",
"flatpickr": "^4.6.13",
- "mermaid": "^11.12.3",
+ "mermaid": "^11.15.0",
"postcss": "^8.5.10",
... | [
"package.json",
"yarn.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,318 | issue_to_patch | Upgrade: Bump fast-uri from 3.0.1 to 3.1.2 | Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.0.1 to 3.1.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/fastify/fast-uri/releases">fast-uri's releases</a>.</em></p>
<blockquote>
<h2>v3.1.2</h2>
<h2>β οΈ Security Release</h2>
<ul>
<li>Fix for <a href="https://g... | 93ea7d5d46efd37c8c6d04deb157376aab9c8cf1 | 213335f29569ad4fefabe193248b944230f495a0 | diff --git a/yarn.lock b/yarn.lock
index 0bbf7f71af..5b9b333794 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -3787,9 +3787,9 @@ __metadata:
linkType: hard
"fast-uri@npm:^3.0.1":
- version: 3.0.1
- resolution: "fast-uri@npm:3.0.1"
- checksum: 10c0/3cd46d6006083b14ca61ffe9a05b8eef75ef87e9574b6f68f2e17ecf4daa7aaadef... | [
"yarn.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,332 | issue_to_patch | Bug: Sidebar on mobile requires extra clicks if needing to re-open the sidebar
### Checks
- [x] I have thoroughly read and understand [The Odin Project Contributing Guide](https://github.com/TheOdinProject/.github/blob/main/CONTRIBUTING.md)
- [x] The title of this issue follows the `Bug: brief description of bug` for... | Fix: Visibility state properly resets to false after disconnect | <!-- Thank you for taking the time to contribute to The Odin Project. In order to get this pull request (PR) merged in a reasonable amount of time, you must complete this entire template. -->
## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it solves or what benefit it provides. -->
... | e20f6655a1259797e1571a25d1450defc04e3f88 | 7f1e4562fc0851cc86b107bcc9a55c6799c43cef | diff --git a/app/javascript/controllers/visibility_controller.js b/app/javascript/controllers/visibility_controller.js
index 359046352f..9af3bd0a74 100644
--- a/app/javascript/controllers/visibility_controller.js
+++ b/app/javascript/controllers/visibility_controller.js
@@ -17,6 +17,7 @@ export default class Visibility... | [
"app/javascript/controllers/visibility_controller.js"
] | [] | true | |
TheOdinProject/theodinproject | 5,329 | issue_to_patch | Feature: Update team alumni | :(
<!-- Thank you for taking the time to contribute to The Odin Project. In order to get this pull request (PR) merged in a reasonable amount of time, you must complete this entire template. -->
## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it solves or what benefit it provides.... | db3d7a1ad54bbcf3c7a56cfc2bcdf20d915e4def | 74664917e7008b7dd458bffea11f9824a6ce30ab | diff --git a/config/locales/team.yml b/config/locales/team.yml
index 53eeeb0950..16582a0fd8 100644
--- a/config/locales/team.yml
+++ b/config/locales/team.yml
@@ -203,24 +203,6 @@ en:
- name: "linkedin"
url: "https://www.linkedin.com/in/mclilzee"
- - name: "Damon Marlow"
- ... | [
"config/locales/team.yml"
] | [
{
"comment": "I think it's just a yaml parse error that's causing it @mao-sz. I found this nestled near the top of the stack trace:\n```\nI18n::InvalidLocaleData:\n can not load translations from /home/runner/work/theodinproject/theodinproject/config/locales/team.yml: #<Psych::SyntaxError: (<unknown>): did no... | true | ||
TheOdinProject/theodinproject | 5,329 | comment_to_fix | Feature: Update team alumni | I think it's just a yaml parse error that's causing it @mao-sz. I found this nestled near the top of the stack trace:
```
I18n::InvalidLocaleData:
can not load translations from /home/runner/work/theodinproject/theodinproject/config/locales/team.yml: #<Psych::SyntaxError: (<unknown>): did not find expected key while... | db3d7a1ad54bbcf3c7a56cfc2bcdf20d915e4def | 74664917e7008b7dd458bffea11f9824a6ce30ab | diff --git a/config/locales/team.yml b/config/locales/team.yml
index 53eeeb0950..16582a0fd8 100644
--- a/config/locales/team.yml
+++ b/config/locales/team.yml
@@ -203,24 +203,6 @@ en:
- name: "linkedin"
url: "https://www.linkedin.com/in/mclilzee"
- - name: "Damon Marlow"
- ... | [
"config/locales/team.yml"
] | [
{
"comment": "I think it's just a yaml parse error that's causing it @mao-sz. I found this nestled near the top of the stack trace:\n```\nI18n::InvalidLocaleData:\n can not load translations from /home/runner/work/theodinproject/theodinproject/config/locales/team.yml: #<Psych::SyntaxError: (<unknown>): did no... | true | ||
TheOdinProject/theodinproject | 5,323 | issue_to_patch | Feature: Create community guide page from "How to Help" blog post | <!-- Thank you for taking the time to contribute to The Odin Project. In order to get this pull request (PR) merged in a reasonable amount of time, you must complete this entire template. -->
## Because
<!-- Summarize the purpose or reasons for this PR, e.g. what problem it solves or what benefit it provides. -->
... | a3a27c360ec037b6fdfec2808a47924be37a6559 | 5ceca3a47da43261f2e0686a69279ae074cac074 | diff --git a/app/controllers/guides/community_controller.rb b/app/controllers/guides/community_controller.rb
index e6baa684b9..6c813b0da2 100644
--- a/app/controllers/guides/community_controller.rb
+++ b/app/controllers/guides/community_controller.rb
@@ -13,7 +13,8 @@ def guides
'Rules' => rules_guides_communi... | [
"app/controllers/guides/community_controller.rb",
"app/views/guides/community/expectations.html.erb",
"app/views/guides/community/how_to_ask.html.erb",
"app/views/guides/community/how_to_help.html.erb",
"app/views/guides/community/rules.html.erb",
"config/routes.rb",
"spec/requests/guides/community_spec... | [
{
"comment": "Nit: just a minor typo:\n\n```suggestion\n <p>If the question needs to have live code to fully understand or debug, ask them to use something like <a href=\"https://codepen.io/\">CodePen</a> to provide it, or link to an up-to-date GitHub repo along with instructions to reproduce the problem. If... | diff --git a/spec/requests/guides/community_spec.rb b/spec/requests/guides/community_spec.rb
index 6259234f67..b4079f6b13 100644
--- a/spec/requests/guides/community_spec.rb
+++ b/spec/requests/guides/community_spec.rb
@@ -40,4 +40,12 @@
expect(response).to have_http_status(:ok)
end
end
+
+ describe 'GE... | true | |
TheOdinProject/theodinproject | 5,323 | comment_to_fix | Feature: Create community guide page from "How to Help" blog post | Nit: just a minor typo:
```suggestion
<p>If the question needs to have live code to fully understand or debug, ask them to use something like <a href="https://codepen.io/">CodePen</a> to provide it, or link to an up-to-date GitHub repo along with instructions to reproduce the problem. If the problem is difficult t... | a3a27c360ec037b6fdfec2808a47924be37a6559 | 5ceca3a47da43261f2e0686a69279ae074cac074 | diff --git a/app/views/guides/community/how_to_help.html.erb b/app/views/guides/community/how_to_help.html.erb
new file mode 100644
index 0000000000..820caf7993
--- /dev/null
+++ b/app/views/guides/community/how_to_help.html.erb
@@ -0,0 +1,63 @@
+<%= title('How to Help Others Solve Coding Problems') %>
+
+<div class="p... | [
"app/views/guides/community/how_to_help.html.erb"
] | [
{
"comment": "Nit: just a minor typo:\n\n```suggestion\n <p>If the question needs to have live code to fully understand or debug, ask them to use something like <a href=\"https://codepen.io/\">CodePen</a> to provide it, or link to an up-to-date GitHub repo along with instructions to reproduce the problem. If... | true | ||
TheOdinProject/theodinproject | 5,323 | comment_to_fix | Feature: Create community guide page from "How to Help" blog post | Nit: Stray curly quotes
```suggestion
<p>Start by asking probing questions, such as "What have you already tried?", βWhat do you expect this function to do?β, or "What do you think that error means?".</p>
``` | a3a27c360ec037b6fdfec2808a47924be37a6559 | 5ceca3a47da43261f2e0686a69279ae074cac074 | diff --git a/app/views/guides/community/how_to_help.html.erb b/app/views/guides/community/how_to_help.html.erb
new file mode 100644
index 0000000000..820caf7993
--- /dev/null
+++ b/app/views/guides/community/how_to_help.html.erb
@@ -0,0 +1,63 @@
+<%= title('How to Help Others Solve Coding Problems') %>
+
+<div class="p... | [
"app/views/guides/community/how_to_help.html.erb"
] | [
{
"comment": "Nit: Stray curly quotes\n\n```suggestion\n <p>Start by asking probing questions, such as \"What have you already tried?\", βWhat do you expect this function to do?β, or \"What do you think that error means?\".</p>\n```",
"path": "app/views/guides/community/how_to_help.html.erb",
"hunk":... | true | ||
TheOdinProject/theodinproject | 5,317 | issue_to_patch | Upgrade: Bump devise from 5.0.3 to 5.0.4 | Bumps [devise](https://github.com/heartcombo/devise) from 5.0.3 to 5.0.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/heartcombo/devise/releases">devise's releases</a>.</em></p>
<blockquote>
<h2>v5.0.4</h2>
<p><a href="https://github.com/heartcombo/devise/blob/v5.0.4/CHANG... | 8c0d64c26458157ff7382c9efa5d9a2d0a9828ea | 9d46d7139dcb585e152af12d133d1b957ed509b3 | diff --git a/Gemfile.lock b/Gemfile.lock
index eeaa87e876..379d42f8ee 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -93,7 +93,7 @@ GEM
erubi (~> 1.4)
parser (>= 2.4)
smart_properties
- bigdecimal (4.1.1)
+ bigdecimal (4.1.2)
bindex (0.8.1)
bootsnap (1.18.4)
msgpack (~> 1.2)... | [
"Gemfile.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,316 | issue_to_patch | Upgrade: Bump css_parser from 1.21.1 to 1.22.0 | Bumps [css_parser](https://github.com/premailer/css_parser) from 1.21.1 to 1.22.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/premailer/css_parser/blob/master/CHANGELOG.md">css_parser's changelog</a>.</em></p>
<blockquote>
<h2>Ruby CSS Parser CHANGELOG</h2>
<h3>Unreleased</h3... | 93ea7d5d46efd37c8c6d04deb157376aab9c8cf1 | 0df9446bac2c1fdcc3aa0eeeef84b302da5da092 | diff --git a/Gemfile.lock b/Gemfile.lock
index 43be321af5..e27c637073 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -128,7 +128,7 @@ GEM
cronex (0.15.0)
tzinfo
unicode (>= 0.4.4.5)
- css_parser (1.21.1)
+ css_parser (1.22.0)
addressable
cssbundling-rails (1.4.3)
railties (>... | [
"Gemfile.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,314 | issue_to_patch | Upgrade: Bump uuid from 11.1.0 to 11.1.1 | Bumps [uuid](https://github.com/uuidjs/uuid) from 11.1.0 to 11.1.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/uuidjs/uuid/releases">uuid's releases</a>.</em></p>
<blockquote>
<h2>v11.1.1</h2>
<h2><a href="https://github.com/uuidjs/uuid/compare/v11.1.0...v11.1.1">11.1.1</... | 93ea7d5d46efd37c8c6d04deb157376aab9c8cf1 | 96f93938b5edfd6cedf2277edd001dcd569bb7e1 | diff --git a/yarn.lock b/yarn.lock
index 0bbf7f71af..985f0e5563 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -7087,11 +7087,11 @@ __metadata:
linkType: hard
"uuid@npm:^11.1.0":
- version: 11.1.0
- resolution: "uuid@npm:11.1.0"
+ version: 11.1.1
+ resolution: "uuid@npm:11.1.1"
bin:
uuid: dist/esm/bin/uuid... | [
"yarn.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,313 | issue_to_patch | Upgrade: Bump net-imap from 0.6.3 to 0.6.4 | Bumps [net-imap](https://github.com/ruby/net-imap) from 0.6.3 to 0.6.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ruby/net-imap/releases">net-imap's releases</a>.</em></p>
<blockquote>
<h2>v0.6.4</h2>
<!-- raw HTML omitted -->
<h2>What's Changed</h2>
<h3>π Security</h3>... | 40d0ccd392ec2f11d700cfb1a7b7f2e8c79f7887 | b941d4fac4fbac690e19ee20736371cef93e6506 | diff --git a/Gemfile.lock b/Gemfile.lock
index 43be321af5..98b479c0f1 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -310,7 +310,7 @@ GEM
bigdecimal (>= 3.1, < 5)
net-http (0.9.1)
uri (>= 0.11.1)
- net-imap (0.6.3)
+ net-imap (0.6.4)
date
net-protocol
net-pop (0.1.2)
@@ -586... | [
"Gemfile.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,307 | issue_to_patch | Upgrade: Bump @tailwindcss/cli from 4.1.17 to 4.2.4 | Bumps [@tailwindcss/cli](https://github.com/tailwindlabs/tailwindcss/tree/HEAD/packages/@tailwindcss-cli) from 4.1.17 to 4.2.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/tailwindlabs/tailwindcss/releases"><code>@βtailwindcss/cli</code>'s releases</a>.</em></p>
<blockquot... | 45c5db693599e240af877fab452816a718982cfe | 03ffc4ec62a6be088566a744c65b686628f63f21 | diff --git a/package.json b/package.json
index ba5a0ae0a1..357e4bd760 100644
--- a/package.json
+++ b/package.json
@@ -15,7 +15,7 @@
"@sentry/browser": "^10.46.0",
"@sentry/esbuild-plugin": "^5.2.0",
"@stimulus/polyfills": "^2.0.0",
- "@tailwindcss/cli": "^4.1.17",
+ "@tailwindcss/cli": "^4.2.4",
... | [
"package.json",
"yarn.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,305 | issue_to_patch | Upgrade: Bump sentry-ruby from 5.25.0 to 5.28.1 | Bumps [sentry-ruby](https://github.com/getsentry/sentry-ruby) from 5.25.0 to 5.28.1.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/getsentry/sentry-ruby/blob/master/CHANGELOG.md">sentry-ruby's changelog</a>.</em></p>
<blockquote>
<h2>5.28.1</h2>
<h3>Bug Fixes</h3>
<ul>
<li>The <... | a3a27c360ec037b6fdfec2808a47924be37a6559 | 8d1796fc1d7589e327d04f945e4bc229decb466e | diff --git a/Gemfile b/Gemfile
index c73eab22ce..714a9cef9d 100644
--- a/Gemfile
+++ b/Gemfile
@@ -42,7 +42,7 @@ gem 'ruby-progressbar', '~> 1.13'
gem 'scenic', '~> 1.9'
gem 'seed-fu', '~> 2.3'
gem 'sentry-rails', '~> 5.22'
-gem 'sentry-ruby', '~> 5.22'
+gem 'sentry-ruby', '~> 5.28'
gem 'sentry-sidekiq', '~> 5.25'
... | [
"Gemfile",
"Gemfile.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,311 | issue_to_patch | Add dropdown menu to navigate to other lessons in a path
<!-- Thank you for taking the time to submit a new feature request to The Odin Project. In order to get issues closed in a reasonable amount of time, you must include a baseline of information about the feature/enhancement you are proposing. Please read this tem... | Feature: Add course contents sidebar to the lesson page | ## Because
The lesson page had no in-page way to navigate between lessons in the same course - learners had to back out to the course page to switch lessons, and the existing header repeated course context (badge, course title link) on every lesson. Adding a persistent course-contents sidebar lets users see where they... | 93ea7d5d46efd37c8c6d04deb157376aab9c8cf1 | 1b836db1a5fcb5910371a218706e5c9b241399a3 | diff --git a/app/assets/images/icons/panel-left.svg b/app/assets/images/icons/panel-left.svg
new file mode 100644
index 0000000000..c89675c6a8
--- /dev/null
+++ b/app/assets/images/icons/panel-left.svg
@@ -0,0 +1,4 @@
+<svg xmlns="http://www.w3.org/2000/svg" fill="none" viewBox="0 0 24 24" stroke-width="1.5" stroke="cu... | [
"app/assets/images/icons/panel-left.svg",
"app/assets/stylesheets/custom_styles/layout.css",
"app/components/lessons/sidebar/completion_icon_component.html.erb",
"app/components/lessons/sidebar/completion_icon_component.rb",
"app/components/lessons/sidebar/lesson_component.html.erb",
"app/components/lesso... | [
{
"comment": "Since this is the third place we use this pattern (we use it on the mobile nav and the admin sidebar as well), I've opened a PR to refactor it into a reusable component: https://github.com/TheOdinProject/theodinproject/pull/5312",
"path": "app/components/lessons/sidebar_component.html.erb",
... | diff --git a/spec/components/lessons/sidebar/completion_icon_component_spec.rb b/spec/components/lessons/sidebar/completion_icon_component_spec.rb
new file mode 100644
index 0000000000..cc4a9b0d41
--- /dev/null
+++ b/spec/components/lessons/sidebar/completion_icon_component_spec.rb
@@ -0,0 +1,41 @@
+require 'rails_help... | true |
TheOdinProject/theodinproject | 5,311 | comment_to_fix | Feature: Add course contents sidebar to the lesson page | Marking this Turbo Frame as permanent means Turbo reuses whatever sidebar was already on the page during lesson-to-lesson visits and ignores the new `src`. If the learner opens a lesson from a different course (or returns to a lesson page after the sidebar was rendered for another course), the sidebar will keep showing... | 93ea7d5d46efd37c8c6d04deb157376aab9c8cf1 | 1b836db1a5fcb5910371a218706e5c9b241399a3 | diff --git a/app/views/lessons/show.html.erb b/app/views/lessons/show.html.erb
index 0afd0198dc..72b440e3c8 100644
--- a/app/views/lessons/show.html.erb
+++ b/app/views/lessons/show.html.erb
@@ -1,68 +1,90 @@
<%= title(@lesson.display_title) %>
-<div class="bg-white dark:bg-gray-900">
- <div class="py-10 px-4 sm:py... | [
"app/views/lessons/show.html.erb"
] | [
{
"comment": "Marking this Turbo Frame as permanent means Turbo reuses whatever sidebar was already on the page during lesson-to-lesson visits and ignores the new `src`. If the learner opens a lesson from a different course (or returns to a lesson page after the sidebar was rendered for another course), the sid... | true | ||
TheOdinProject/theodinproject | 5,311 | comment_to_fix | Feature: Add course contents sidebar to the lesson page | This endpoint now renders user-specific completion icons/progress, but unlike `LessonsController` and `CoursesController` it never sets `Cache-Control: no-store`. That lets browsers cache and reuse a personalized sidebar response after sign-out or another visit, so learners can see stale progress from the wrong session... | 93ea7d5d46efd37c8c6d04deb157376aab9c8cf1 | 1b836db1a5fcb5910371a218706e5c9b241399a3 | diff --git a/app/controllers/lessons/course_contents_controller.rb b/app/controllers/lessons/course_contents_controller.rb
new file mode 100644
index 0000000000..c3a622cb81
--- /dev/null
+++ b/app/controllers/lessons/course_contents_controller.rb
@@ -0,0 +1,18 @@
+module Lessons
+ class CourseContentsController < Appl... | [
"app/controllers/lessons/course_contents_controller.rb"
] | [
{
"comment": "This endpoint now renders user-specific completion icons/progress, but unlike `LessonsController` and `CoursesController` it never sets `Cache-Control: no-store`. That lets browsers cache and reuse a personalized sidebar response after sign-out or another visit, so learners can see stale progress ... | true | ||
TheOdinProject/theodinproject | 5,311 | comment_to_fix | Feature: Add course contents sidebar to the lesson page | Applying `scroll-padding-top` on `html` changes anchor navigation for the entire site, not just lesson pages. We already have non-lesson anchor links like `about#contact-us` and `team#moderators`, so those pages will now stop 3.5rem early even though they do not have the sticky lesson sub-navbar.
| 93ea7d5d46efd37c8c6d04deb157376aab9c8cf1 | 1b836db1a5fcb5910371a218706e5c9b241399a3 | diff --git a/app/assets/stylesheets/custom_styles/layout.css b/app/assets/stylesheets/custom_styles/layout.css
index 9f32dfe445..9c1d5001e6 100644
--- a/app/assets/stylesheets/custom_styles/layout.css
+++ b/app/assets/stylesheets/custom_styles/layout.css
@@ -2,8 +2,40 @@
@apply max-w-7xl mx-auto py-10 px-4 sm:py-14 ... | [
"app/assets/stylesheets/custom_styles/layout.css"
] | [
{
"comment": "Applying `scroll-padding-top` on `html` changes anchor navigation for the entire site, not just lesson pages. We already have non-lesson anchor links like `about#contact-us` and `team#moderators`, so those pages will now stop 3.5rem early even though they do not have the sticky lesson sub-navbar.\... | true | ||
TheOdinProject/theodinproject | 5,311 | comment_to_fix | Feature: Add course contents sidebar to the lesson page | Binding `Cmd/Ctrl+B` at window scope with `:prevent` overrides the browser's built-in bookmark/sidebar shortcut everywhere on lesson pages. That removes a standard keyboard shortcut for keyboard-only users and some assistive-tech workflows, so this accelerator should not use a reserved browser combo.
| 93ea7d5d46efd37c8c6d04deb157376aab9c8cf1 | 1b836db1a5fcb5910371a218706e5c9b241399a3 | diff --git a/app/views/lessons/show.html.erb b/app/views/lessons/show.html.erb
index 0afd0198dc..72b440e3c8 100644
--- a/app/views/lessons/show.html.erb
+++ b/app/views/lessons/show.html.erb
@@ -1,68 +1,90 @@
<%= title(@lesson.display_title) %>
-<div class="bg-white dark:bg-gray-900">
- <div class="py-10 px-4 sm:py... | [
"app/views/lessons/show.html.erb"
] | [
{
"comment": "Binding `Cmd/Ctrl+B` at window scope with `:prevent` overrides the browser's built-in bookmark/sidebar shortcut everywhere on lesson pages. That removes a standard keyboard shortcut for keyboard-only users and some assistive-tech workflows, so this accelerator should not use a reserved browser com... | true | ||
TheOdinProject/theodinproject | 5,311 | comment_to_fix | Feature: Add course contents sidebar to the lesson page | What do you think about having the padding on the anchor itself? Currently it feels awkward clicking the lesson links because sometimes I click the div padding outside of the anchor, despite being within the shaded area.
```suggestion
<div class="flex items-center justify-between gap-2 rounded-md hover:bg-gray-50 dark:... | 93ea7d5d46efd37c8c6d04deb157376aab9c8cf1 | 1b836db1a5fcb5910371a218706e5c9b241399a3 | diff --git a/app/components/lessons/sidebar/lesson_component.html.erb b/app/components/lessons/sidebar/lesson_component.html.erb
new file mode 100644
index 0000000000..c6f4482063
--- /dev/null
+++ b/app/components/lessons/sidebar/lesson_component.html.erb
@@ -0,0 +1,15 @@
+<%= link_to(
+ lesson_path(lesson),
+ ... | [
"app/components/lessons/sidebar/lesson_component.html.erb"
] | [
{
"comment": "What do you think about having the padding on the anchor itself? Currently it feels awkward clicking the lesson links because sometimes I click the div padding outside of the anchor, despite being within the shaded area.\n```suggestion\n<div class=\"flex items-center justify-between gap-2 rounded-... | true | ||
TheOdinProject/theodinproject | 5,311 | comment_to_fix | Feature: Add course contents sidebar to the lesson page | Surprised erb_lint didn't complain at this but still, my eyes found this *immediately* :P Something just felt really off and my spidey senses tingled
```suggestion
</div>
``` | 93ea7d5d46efd37c8c6d04deb157376aab9c8cf1 | 1b836db1a5fcb5910371a218706e5c9b241399a3 | diff --git a/app/components/lessons/sidebar/progress_bar_component.html.erb b/app/components/lessons/sidebar/progress_bar_component.html.erb
new file mode 100644
index 0000000000..459143b9e2
--- /dev/null
+++ b/app/components/lessons/sidebar/progress_bar_component.html.erb
@@ -0,0 +1,16 @@
+<div class="sidebar-progress... | [
"app/components/lessons/sidebar/progress_bar_component.html.erb"
] | [
{
"comment": "Surprised erb_lint didn't complain at this but still, my eyes found this *immediately* :P Something just felt really off and my spidey senses tingled\n```suggestion\n </div>\n```",
"path": "app/components/lessons/sidebar/progress_bar_component.html.erb",
"hunk": "@@ -0,0 +1,16 @@\n+<div... | true | ||
TheOdinProject/theodinproject | 5,311 | comment_to_fix | Feature: Add course contents sidebar to the lesson page | Rogue blank line?
```suggestion
``` | 93ea7d5d46efd37c8c6d04deb157376aab9c8cf1 | 1b836db1a5fcb5910371a218706e5c9b241399a3 | diff --git a/app/views/lessons/_sub_navbar.html.erb b/app/views/lessons/_sub_navbar.html.erb
new file mode 100644
index 0000000000..3868ef4aa0
--- /dev/null
+++ b/app/views/lessons/_sub_navbar.html.erb
@@ -0,0 +1,15 @@
+<div
+ class="sticky -top-px z-20 bg-white dark:bg-gray-900 -mx-4 sm:-mx-6 lg:-mx-8 xl:-mr-4 xl:-ml... | [
"app/views/lessons/_sub_navbar.html.erb"
] | [
{
"comment": "Rogue blank line?\n```suggestion\n```",
"path": "app/views/lessons/_sub_navbar.html.erb",
"hunk": "@@ -0,0 +1,16 @@\n+<div\n+ class=\"sticky -top-px z-20 bg-white dark:bg-gray-900 -mx-4 sm:-mx-6 lg:-mx-8 xl:-mr-4 xl:-ml-10 group-[.sidebar-collapsed]/sidebar-layout:xl:-ml-4\"\n+ data-cont... | true | ||
TheOdinProject/theodinproject | 5,319 | issue_to_patch | Upgrade: Bump view_component from 4.5.0 to 4.9.0 | Bumps [view_component](https://github.com/viewcomponent/view_component) from 4.5.0 to 4.9.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/viewcomponent/view_component/releases">view_component's releases</a>.</em></p>
<blockquote>
<h2>4.9.0</h2>
<ul>
<li>
<p>Fix path travers... | 8c0d64c26458157ff7382c9efa5d9a2d0a9828ea | de9787f347ab589387e6e47b63ca16b034a7fbbb | diff --git a/Gemfile b/Gemfile
index c250d046eb..745cc21150 100644
--- a/Gemfile
+++ b/Gemfile
@@ -49,7 +49,7 @@ gem 'sidekiq-cron', '~> 2.3'
gem 'stackprof', '~> 0.2'
gem 'stimulus-rails', '~> 1.3'
gem 'turbo-rails', '~> 2.0'
-gem 'view_component', '~> 4.5'
+gem 'view_component', '~> 4.9'
# https://github.com/ja... | [
"Gemfile",
"Gemfile.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,322 | issue_to_patch | Upgrade: Bump sidekiq-cron from 2.3.0 to 2.4.0 | Bumps [sidekiq-cron](https://github.com/ondrejbartas/sidekiq-cron) from 2.3.0 to 2.4.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/ondrejbartas/sidekiq-cron/releases">sidekiq-cron's releases</a>.</em></p>
<blockquote>
<h2>v2.4.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Updat... | 8c0d64c26458157ff7382c9efa5d9a2d0a9828ea | 1a4630e8441177062bee465184815b976e6d9f58 | diff --git a/Gemfile b/Gemfile
index c250d046eb..66bf69c260 100644
--- a/Gemfile
+++ b/Gemfile
@@ -45,7 +45,7 @@ gem 'sentry-rails', '~> 5.22'
gem 'sentry-ruby', '~> 5.22'
gem 'sentry-sidekiq', '~> 5.25'
gem 'sidekiq', '8.0.4'
-gem 'sidekiq-cron', '~> 2.3'
+gem 'sidekiq-cron', '~> 2.4'
gem 'stackprof', '~> 0.2'
ge... | [
"Gemfile",
"Gemfile.lock"
] | [] | true | ||
TheOdinProject/theodinproject | 5,324 | issue_to_patch | Upgrade: Bump postcss from 8.5.9 to 8.5.10 | Bumps [postcss](https://github.com/postcss/postcss) from 8.5.9 to 8.5.10.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/postcss/postcss/releases">postcss's releases</a>.</em></p>
<blockquote>
<h2>8.5.10</h2>
<ul>
<li>Fixed XSS via unescaped <code></style></code> in non... | 8c0d64c26458157ff7382c9efa5d9a2d0a9828ea | ddcbd4a27b9c9df0e4acf4dab8f1495704ac5a20 | diff --git a/package.json b/package.json
index adf9c0bd85..31c21e2fcb 100644
--- a/package.json
+++ b/package.json
@@ -29,7 +29,7 @@
"esbuild-rails": "^1.0.7",
"flatpickr": "^4.6.13",
"mermaid": "^11.12.3",
- "postcss": "^8.5.9",
+ "postcss": "^8.5.10",
"prismjs": "^1.30.0",
"sortablejs":... | [
"package.json",
"yarn.lock"
] | [] | true | ||
ThoughtWorksInc/Binding.scala | 563 | issue_to_patch | Update sbt to 1.10.11 | ## About this PR
π¦ Updates [org.scala-sbt:sbt](https://github.com/sbt/sbt) from `1.9.9` to `1.10.11`
π [GitHub Release Notes](https://github.com/sbt/sbt/releases/tag/v1.10.11) - [Version Diff](https://github.com/sbt/sbt/compare/v1.9.9...v1.10.11)
## Usage
β
**Please merge!**
I'll automatically update this PR to re... | a61dd0a2a5ace5d28edf13915377785d313a3291 | 506ee6e180ac445a3200726231dead64f3c71d2b | diff --git a/project/build.properties b/project/build.properties
index 04267b14..cc68b53f 100644
--- a/project/build.properties
+++ b/project/build.properties
@@ -1,1 +1,1 @@
-sbt.version=1.9.9
+sbt.version=1.10.11
| [
"project/build.properties"
] | [] | true | ||
ThoughtWorksInc/Binding.scala | 539 | issue_to_patch | Update sbt to 1.9.9 | ## About this PR
π¦ Updates [org.scala-sbt:sbt](https://github.com/sbt/sbt) from `1.9.2` to `1.9.9`
π [GitHub Release Notes](https://github.com/sbt/sbt/releases/tag/v1.9.9) - [Version Diff](https://github.com/sbt/sbt/compare/v1.9.2...v1.9.9)
## Usage
β
**Please merge!**
I'll automatically update this PR to resolve ... | 4398865ccbc123e822a9c8fe306e14fcbb391908 | 97e0b65247e1ef9f0ff559b44d0027ca369b80de | diff --git a/project/build.properties b/project/build.properties
index 875b706a..04267b14 100644
--- a/project/build.properties
+++ b/project/build.properties
@@ -1,1 +1,1 @@
-sbt.version=1.9.2
+sbt.version=1.9.9
| [
"project/build.properties"
] | [] | true | ||
ThoughtWorksInc/Binding.scala | 518 | issue_to_patch | Update sbt to 1.9.2 | ## About this PR
π¦ Updates [org.scala-sbt:sbt](https://github.com/sbt/sbt) from `1.9.1` to `1.9.2`
π [GitHub Release Notes](https://github.com/sbt/sbt/releases/tag/v1.9.2) - [Version Diff](https://github.com/sbt/sbt/compare/v1.9.1...v1.9.2)
## Usage
β
**Please merge!**
I'll automatically update this PR to resolve ... | 0bdc40baad7a619f6411b932d24274e19e569563 | 15f4b22c530e3e1b161b11de62c992e0751419ef | diff --git a/project/build.properties b/project/build.properties
index 3c0b78a7..875b706a 100644
--- a/project/build.properties
+++ b/project/build.properties
@@ -1,1 +1,1 @@
-sbt.version=1.9.1
+sbt.version=1.9.2
| [
"project/build.properties"
] | [] | true | ||
ThoughtWorksInc/Binding.scala | 510 | issue_to_patch | Update sbt to 1.9.1 | ## About this PR
π¦ Updates [org.scala-sbt:sbt](https://github.com/sbt/sbt) from `1.8.3` to `1.9.1`
π [GitHub Release Notes](https://github.com/sbt/sbt/releases/tag/v1.9.1) - [Version Diff](https://github.com/sbt/sbt/compare/v1.8.3...v1.9.1)
## Usage
β
**Please merge!**
I'll automatically update this PR to resolve ... | b749d9dce7466a1c9f1910183604b829f869af70 | e52389ca23aba8b61588fd1ad3eba11c591ef801 | diff --git a/project/build.properties b/project/build.properties
index 72413de1..3c0b78a7 100644
--- a/project/build.properties
+++ b/project/build.properties
@@ -1,1 +1,1 @@
-sbt.version=1.8.3
+sbt.version=1.9.1
| [
"project/build.properties"
] | [] | true | ||
ThoughtWorksInc/Binding.scala | 500 | issue_to_patch | Update sbt to 1.8.3 | ## About this PR
π¦ Updates [org.scala-sbt:sbt](https://github.com/sbt/sbt) from `1.8.2` to `1.8.3`
π [GitHub Release Notes](https://github.com/sbt/sbt/releases/tag/v1.8.3) - [Version Diff](https://github.com/sbt/sbt/compare/v1.8.2...v1.8.3)
## Usage
β
**Please merge!**
I'll automatically update this PR to resolve ... | b20b56c5bdbc7890a629cc93cb30aacdf86b0915 | 0cfbe88c187e57bb52568415d8dbcb7e375320c3 | diff --git a/project/build.properties b/project/build.properties
index 46e43a97..72413de1 100644
--- a/project/build.properties
+++ b/project/build.properties
@@ -1,1 +1,1 @@
-sbt.version=1.8.2
+sbt.version=1.8.3
| [
"project/build.properties"
] | [] | true | ||
ThoughtWorksInc/Binding.scala | 473 | issue_to_patch | Update sbt to 1.8.2 | Updates [org.scala-sbt:sbt](https://github.com/sbt/sbt) from 1.7.3 to 1.8.2.
[GitHub Release Notes](https://github.com/sbt/sbt/releases/tag/v1.8.2) - [Version Diff](https://github.com/sbt/sbt/compare/v1.7.3...v1.8.2)
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If y... | f15746dd9525aa750b717e222e444aa9dcb9bc41 | cc55f1d0da9f456697fdae03045f026a4008ed16 | diff --git a/project/build.properties b/project/build.properties
index 6a9f0388..46e43a97 100644
--- a/project/build.properties
+++ b/project/build.properties
@@ -1,1 +1,1 @@
-sbt.version=1.7.3
+sbt.version=1.8.2
| [
"project/build.properties"
] | [] | true | ||
ThoughtWorksInc/Binding.scala | 460 | issue_to_patch | Update sbt to 1.7.3 | Updates [org.scala-sbt:sbt](https://github.com/sbt/sbt) from 1.7.1 to 1.7.3.
[GitHub Release Notes](https://github.com/sbt/sbt/releases/tag/v1.7.3) - [Version Diff](https://github.com/sbt/sbt/compare/v1.7.1...v1.7.3)
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If y... | 7ff5c8e31f48961d44bca503b78330441d19cf1d | 40b6747c4428c92993b4e46e4470b01d3a24b94f | diff --git a/project/build.properties b/project/build.properties
index 22af2628..6a9f0388 100644
--- a/project/build.properties
+++ b/project/build.properties
@@ -1,1 +1,1 @@
-sbt.version=1.7.1
+sbt.version=1.7.3
| [
"project/build.properties"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.