repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
ThreeMammals/Ocelot | 1,972 | comment_to_fix | #1971 #928 Avoid content if original request has no content and avoid Transfer-Encoding: chunked if Content-Length is known | Attention!
`GET` was replaced with `POST`!!!
Better to convert to `Theory` | 8845d1b98d2c3b0bd633ebd2b526b923687edd33 | 81e1ca9ca26eaed2e328fdeeea675858a2d78b73 | diff --git a/test/Ocelot.UnitTests/Request/Mapper/RequestMapperTests.cs b/test/Ocelot.UnitTests/Request/Mapper/RequestMapperTests.cs
index 328fee6e5..624dc779e 100644
--- a/test/Ocelot.UnitTests/Request/Mapper/RequestMapperTests.cs
+++ b/test/Ocelot.UnitTests/Request/Mapper/RequestMapperTests.cs
@@ -5,6 +5,7 @@
using ... | [
"test/Ocelot.UnitTests/Request/Mapper/RequestMapperTests.cs"
] | [
{
"comment": "Attention!\r\n`GET` was replaced with `POST`!!!\r\nBetter to convert to `Theory`",
"path": "test/Ocelot.UnitTests/Request/Mapper/RequestMapperTests.cs",
"hunk": "@@ -113,11 +114,51 @@ public void Should_handle_no_headers()\n public void Should_map_content()\n {\n this.Given... | true | ||
ThreeMammals/Ocelot | 2,388 | issue_to_patch | Split the monorepo with the goal of having independent releases of projects
A long time ago, in a distant kingdom, King Tom migrated micro-projects to this repository to adopt feature #734. However, the [Ocelot extension projects'](https://github.com/ThreeMammals/Ocelot/tree/24.1.0/src) releases depend on unpredictabl... | #2378 Deprecate `Ocelot.Provider.Consul` project in favor of a dedicated repository | ## Closes #2378
- #2378
## New dedicated repository
- [Ocelot.Discovery.Consul](https://github.com/ThreeMammals/Ocelot.Discovery.Consul)
## Proposed Changes
- The project has been moved to the new repo
- All tests have been moved out of this repo to the new one
- Refactored "Configuration Repository"... | fe672ec02c2b7c4dc5c5b8167bf5f39d24363d47 | 3f6bdec294ae86cee554d2b78c9cac62ffdabda2 | diff --git a/Ocelot.sln b/Ocelot.sln
index d16da6a5d..45422d944 100644
--- a/Ocelot.sln
+++ b/Ocelot.sln
@@ -29,8 +29,6 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Ocelot.UnitTests", "test\Oc
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Ocelot", "src\Ocelot\Ocelot.csproj", "{AB0A194F-36... | [
"Ocelot.sln",
"Ocelot.slnx",
"README.md",
"docs/features/qualityofservice.rst",
"docs/features/servicediscovery.rst",
"src/Ocelot.Provider.Consul/Consul.cs",
"src/Ocelot.Provider.Consul/ConsulClientFactory.cs",
"src/Ocelot.Provider.Consul/ConsulFileConfigurationRepository.cs",
"src/Ocelot.Provider.C... | [] | diff --git a/test/Ocelot.AcceptanceTests/Administration/OcelotBuilderExtensions.cs b/test/Ocelot.AcceptanceTests/Administration/OcelotBuilderExtensions.cs
index 19a5a4927..811f18b90 100644
--- a/test/Ocelot.AcceptanceTests/Administration/OcelotBuilderExtensions.cs
+++ b/test/Ocelot.AcceptanceTests/Administration/Ocelot... | true |
ThreeMammals/Ocelot | 157 | issue_to_patch | Consider a way to generate route config first time a reroute is requested
we need this to support storing fileconfiguration in consul etc
mroe detail to follow | Feature/hacking consul file config | ## Closes #154
- #154 | d3774820137c00fea50b6d01fff8f4089f6df305 | 52cf4b98f2d3bdbf68e205617848fdd781ba6cf1 | diff --git a/src/Ocelot/Configuration/Provider/FileConfigurationProvider.cs b/src/Ocelot/Configuration/Provider/FileConfigurationProvider.cs
index 5f6dbe083..17f46531c 100644
--- a/src/Ocelot/Configuration/Provider/FileConfigurationProvider.cs
+++ b/src/Ocelot/Configuration/Provider/FileConfigurationProvider.cs
@@ -1,5... | [
"src/Ocelot/Configuration/Provider/FileConfigurationProvider.cs",
"src/Ocelot/Configuration/Provider/IFileConfigurationProvider.cs",
"src/Ocelot/Configuration/Provider/IOcelotConfigurationProvider.cs",
"src/Ocelot/Configuration/Provider/OcelotConfigurationProvider.cs",
"src/Ocelot/Configuration/Repository/C... | [] | diff --git a/test/Ocelot.AcceptanceTests/ConfigurationInConsulTests.cs b/test/Ocelot.AcceptanceTests/ConfigurationInConsulTests.cs
index aca07a3c0..239e1035f 100644
--- a/test/Ocelot.AcceptanceTests/ConfigurationInConsulTests.cs
+++ b/test/Ocelot.AcceptanceTests/ConfigurationInConsulTests.cs
@@ -1,8 +1,10 @@
using Sy... | true |
ThreeMammals/Ocelot | 2,385 | issue_to_patch | Circuit breaker pattern
Ocelot uses and recommends [Polly](https://www.pollydocs.org/) for the [Quality of Service](https://github.com/ThreeMammals/Ocelot/blob/develop/docs/features/qualityofservice.rst) feature.
- Repo: [App-vNext/Polly](https://github.com/App-vNext/Polly)
- Ocelot extension repo: [Ocelot.QualityOfS... | #2384 Built-in Circuit Breaker for Quality of Service (express edition, no Polly required) | ## Closes #2384
- #2384
## Predecessors
- #2380
- #561
## Proposed Changes
Ocelot's QoS feature previously had no built-in circuit breaker implementation — it depended entirely on the external `Ocelot.QualityOfService.Polly` package. This adds a lightweight, built-in circuit breaker so QoS works out of th... | c3720c550899db4aadd77ae77754bd9978101c34 | e892ef804bbe2837bc0f26ff6ba57bb7fe395f26 | diff --git a/docs/features/qualityofservice.rst b/docs/features/qualityofservice.rst
index cb5e9a8dd..1274d2197 100644
--- a/docs/features/qualityofservice.rst
+++ b/docs/features/qualityofservice.rst
@@ -17,21 +17,281 @@ Quality of Service
| Label: |QoS_label|:pdf:`\href{https://github.com/ThreeMammals/Ocelot/label... | [
"docs/features/qualityofservice.rst",
"src/Ocelot/Configuration/QoSOptions.cs",
"src/Ocelot/Configuration/Validator/FileQoSOptionsFluentValidator.cs",
"src/Ocelot/DependencyInjection/Features.cs",
"src/Ocelot/DependencyInjection/IOcelotBuilder.cs",
"src/Ocelot/DependencyInjection/OcelotBuilder.cs",
"src... | [
{
"comment": "Thread.Sleep-based timing assertions can be flaky under CI load and unnecessarily slow the suite. Prefer making CircuitBreaker time-source injectable (e.g., TimeProvider/clock abstraction) so tests can advance time deterministically without sleeping.",
"path": "test/Ocelot.UnitTests/Infrastruc... | diff --git a/test/Ocelot.AcceptanceTests/CannotStartOcelotTests.cs b/test/Ocelot.AcceptanceTests/CannotStartOcelotTests.cs
index 74434bd4e..9fb8234f7 100644
--- a/test/Ocelot.AcceptanceTests/CannotStartOcelotTests.cs
+++ b/test/Ocelot.AcceptanceTests/CannotStartOcelotTests.cs
@@ -84,7 +84,7 @@ public void Should_throw_... | true |
ThreeMammals/Ocelot | 2,385 | comment_to_fix | #2384 Built-in Circuit Breaker for Quality of Service (express edition, no Polly required) | Thread.Sleep-based timing assertions can be flaky under CI load and unnecessarily slow the suite. Prefer making CircuitBreaker time-source injectable (e.g., TimeProvider/clock abstraction) so tests can advance time deterministically without sleeping. | c3720c550899db4aadd77ae77754bd9978101c34 | e892ef804bbe2837bc0f26ff6ba57bb7fe395f26 | diff --git a/test/Ocelot.UnitTests/Infrastructure/DesignPatterns/CircuitBreakerTests.cs b/test/Ocelot.UnitTests/Infrastructure/DesignPatterns/CircuitBreakerTests.cs
new file mode 100644
index 000000000..10c6cbbca
--- /dev/null
+++ b/test/Ocelot.UnitTests/Infrastructure/DesignPatterns/CircuitBreakerTests.cs
@@ -0,0 +1,5... | [
"test/Ocelot.UnitTests/Infrastructure/DesignPatterns/CircuitBreakerTests.cs"
] | [
{
"comment": "Thread.Sleep-based timing assertions can be flaky under CI load and unnecessarily slow the suite. Prefer making CircuitBreaker time-source injectable (e.g., TimeProvider/clock abstraction) so tests can advance time deterministically without sleeping.",
"path": "test/Ocelot.UnitTests/Infrastruc... | true | ||
ThreeMammals/Ocelot | 2,385 | comment_to_fix | #2384 Built-in Circuit Breaker for Quality of Service (express edition, no Polly required) | This comment says "external lib like Polly" which is confusing in a PR aiming to remove the Polly dependency. Consider rewording to something provider-agnostic (e.g., "external QoS implementation") and keep Polly-specific references out of core.
| c3720c550899db4aadd77ae77754bd9978101c34 | e892ef804bbe2837bc0f26ff6ba57bb7fe395f26 | diff --git a/src/Ocelot/QualityOfService/QualityOfServiceFactory.cs b/src/Ocelot/QualityOfService/QualityOfServiceFactory.cs
new file mode 100644
index 000000000..a4d36d192
--- /dev/null
+++ b/src/Ocelot/QualityOfService/QualityOfServiceFactory.cs
@@ -0,0 +1,74 @@
+using Microsoft.AspNetCore.Http;
+using Microsoft.Exte... | [
"src/Ocelot/QualityOfService/QualityOfServiceFactory.cs"
] | [
{
"comment": "This comment says \"external lib like Polly\" which is confusing in a PR aiming to remove the Polly dependency. Consider rewording to something provider-agnostic (e.g., \"external QoS implementation\") and keep Polly-specific references out of core.\n",
"path": "src/Ocelot/QualityOfService/Qua... | true | ||
ThreeMammals/Ocelot | 2,385 | comment_to_fix | #2384 Built-in Circuit Breaker for Quality of Service (express edition, no Polly required) | Timeout-only QoS configurations (QoSOptions.Timeout > 0 with MinimumThroughput unset) currently fall through and return the no-op QosDelegatingHandler, so no per-request timeout is enforced even though QoSOptions.UseQos becomes true. Consider creating CircuitBreakerDelegatingHandler (or a dedicated timeout handler) whe... | c3720c550899db4aadd77ae77754bd9978101c34 | e892ef804bbe2837bc0f26ff6ba57bb7fe395f26 | diff --git a/src/Ocelot/QualityOfService/QualityOfServiceFactory.cs b/src/Ocelot/QualityOfService/QualityOfServiceFactory.cs
new file mode 100644
index 000000000..a4d36d192
--- /dev/null
+++ b/src/Ocelot/QualityOfService/QualityOfServiceFactory.cs
@@ -0,0 +1,74 @@
+using Microsoft.AspNetCore.Http;
+using Microsoft.Exte... | [
"src/Ocelot/QualityOfService/QualityOfServiceFactory.cs"
] | [
{
"comment": "Timeout-only QoS configurations (QoSOptions.Timeout > 0 with MinimumThroughput unset) currently fall through and return the no-op QosDelegatingHandler, so no per-request timeout is enforced even though QoSOptions.UseQos becomes true. Consider creating CircuitBreakerDelegatingHandler (or a dedicate... | true | ||
ThreeMammals/Ocelot | 2,385 | comment_to_fix | #2384 Built-in Circuit Breaker for Quality of Service (express edition, no Polly required) | The remarks say "Counts server-error responses (5xx)" but the implementation only treats a specific subset of 5xx codes as failures via ServerErrorCodes. Either broaden the predicate to include all 5xx or tighten the documentation to match the actual set. | c3720c550899db4aadd77ae77754bd9978101c34 | e892ef804bbe2837bc0f26ff6ba57bb7fe395f26 | diff --git a/src/Ocelot/QualityOfService/CircuitBreakerDelegatingHandler.cs b/src/Ocelot/QualityOfService/CircuitBreakerDelegatingHandler.cs
new file mode 100644
index 000000000..cfa7966cd
--- /dev/null
+++ b/src/Ocelot/QualityOfService/CircuitBreakerDelegatingHandler.cs
@@ -0,0 +1,209 @@
+using Ocelot.Configuration;
+... | [
"src/Ocelot/QualityOfService/CircuitBreakerDelegatingHandler.cs"
] | [
{
"comment": "The remarks say \"Counts server-error responses (5xx)\" but the implementation only treats a specific subset of 5xx codes as failures via ServerErrorCodes. Either broaden the predicate to include all 5xx or tighten the documentation to match the actual set.",
"path": "src/Ocelot/QualityOfServi... | true | ||
ThreeMammals/Ocelot | 2,385 | comment_to_fix | #2384 Built-in Circuit Breaker for Quality of Service (express edition, no Polly required) | QualityOfServiceFactory.Get dereferences _contextAccessor.HttpContext without a null-check. IHttpContextAccessor.HttpContext can be null (e.g., during startup/background work), which would violate the interface remark that this method shouldn't throw; guard for null before writing to HttpContext.Items and fall back to ... | c3720c550899db4aadd77ae77754bd9978101c34 | e892ef804bbe2837bc0f26ff6ba57bb7fe395f26 | diff --git a/src/Ocelot/QualityOfService/QualityOfServiceFactory.cs b/src/Ocelot/QualityOfService/QualityOfServiceFactory.cs
new file mode 100644
index 000000000..a4d36d192
--- /dev/null
+++ b/src/Ocelot/QualityOfService/QualityOfServiceFactory.cs
@@ -0,0 +1,74 @@
+using Microsoft.AspNetCore.Http;
+using Microsoft.Exte... | [
"src/Ocelot/QualityOfService/QualityOfServiceFactory.cs"
] | [
{
"comment": "QualityOfServiceFactory.Get dereferences _contextAccessor.HttpContext without a null-check. IHttpContextAccessor.HttpContext can be null (e.g., during startup/background work), which would violate the interface remark that this method shouldn't throw; guard for null before writing to HttpContext.I... | true | ||
ThreeMammals/Ocelot | 2,385 | comment_to_fix | #2384 Built-in Circuit Breaker for Quality of Service (express edition, no Polly required) | This Information-level log runs for every QoS-enabled route and also fires for the built-in delegate (QosDelegatingHandler), but the message claims an external QoS library. Consider moving this to Debug and/or only logging when the resolved handler is actually from an external implementation to avoid misleading/noisy l... | c3720c550899db4aadd77ae77754bd9978101c34 | e892ef804bbe2837bc0f26ff6ba57bb7fe395f26 | diff --git a/src/Ocelot/QualityOfService/QualityOfServiceFactory.cs b/src/Ocelot/QualityOfService/QualityOfServiceFactory.cs
new file mode 100644
index 000000000..a4d36d192
--- /dev/null
+++ b/src/Ocelot/QualityOfService/QualityOfServiceFactory.cs
@@ -0,0 +1,74 @@
+using Microsoft.AspNetCore.Http;
+using Microsoft.Exte... | [
"src/Ocelot/QualityOfService/QualityOfServiceFactory.cs"
] | [
{
"comment": "This Information-level log runs for every QoS-enabled route and also fires for the built-in delegate (QosDelegatingHandler), but the message claims an external QoS library. Consider moving this to Debug and/or only logging when the resolved handler is actually from an external implementation to av... | true | ||
ThreeMammals/Ocelot | 2,385 | comment_to_fix | #2384 Built-in Circuit Breaker for Quality of Service (express edition, no Polly required) | CircuitState.HalfOpen is documented as allowing a single probe request, but CanExecute() returns true for HalfOpen and therefore allows unlimited concurrent probes. Either implement a one-probe gate (e.g., Interlocked flag) or update the HalfOpen documentation to reflect the actual behavior. | c3720c550899db4aadd77ae77754bd9978101c34 | e892ef804bbe2837bc0f26ff6ba57bb7fe395f26 | diff --git a/src/Ocelot/Infrastructure/DesignPatterns/CircuitBreaker.cs b/src/Ocelot/Infrastructure/DesignPatterns/CircuitBreaker.cs
new file mode 100644
index 000000000..0c74882c4
--- /dev/null
+++ b/src/Ocelot/Infrastructure/DesignPatterns/CircuitBreaker.cs
@@ -0,0 +1,294 @@
+namespace Ocelot.Infrastructure.DesignPat... | [
"src/Ocelot/Infrastructure/DesignPatterns/CircuitBreaker.cs"
] | [
{
"comment": "CircuitState.HalfOpen is documented as allowing a single probe request, but CanExecute() returns true for HalfOpen and therefore allows unlimited concurrent probes. Either implement a one-probe gate (e.g., Interlocked flag) or update the HalfOpen documentation to reflect the actual behavior.",
... | true | ||
ThreeMammals/Ocelot | 2,385 | comment_to_fix | #2384 Built-in Circuit Breaker for Quality of Service (express edition, no Polly required) | BreakDuration defaults to 0ms when QoSOptions.BreakDuration is not set, which makes the circuit transition from Open to HalfOpen immediately (so Open effectively never blocks). Consider requiring/validating a positive BreakDuration when MinimumThroughput is configured, or applying a sensible default break duration to p... | c3720c550899db4aadd77ae77754bd9978101c34 | e892ef804bbe2837bc0f26ff6ba57bb7fe395f26 | diff --git a/src/Ocelot/QualityOfService/CircuitBreakerDelegatingHandler.cs b/src/Ocelot/QualityOfService/CircuitBreakerDelegatingHandler.cs
new file mode 100644
index 000000000..cfa7966cd
--- /dev/null
+++ b/src/Ocelot/QualityOfService/CircuitBreakerDelegatingHandler.cs
@@ -0,0 +1,209 @@
+using Ocelot.Configuration;
+... | [
"src/Ocelot/QualityOfService/CircuitBreakerDelegatingHandler.cs"
] | [
{
"comment": "BreakDuration defaults to 0ms when QoSOptions.BreakDuration is not set, which makes the circuit transition from Open to HalfOpen immediately (so Open effectively never blocks). Consider requiring/validating a positive BreakDuration when MinimumThroughput is configured, or applying a sensible defau... | true | ||
ThreeMammals/Ocelot | 2,385 | comment_to_fix | #2384 Built-in Circuit Breaker for Quality of Service (express edition, no Polly required) | This remark still references Polly's implementation details, which is confusing for a built-in QoS handler. Consider removing the Polly reference and documenting Ocelot's own failure-code policy instead.
| c3720c550899db4aadd77ae77754bd9978101c34 | e892ef804bbe2837bc0f26ff6ba57bb7fe395f26 | diff --git a/src/Ocelot/QualityOfService/CircuitBreakerDelegatingHandler.cs b/src/Ocelot/QualityOfService/CircuitBreakerDelegatingHandler.cs
new file mode 100644
index 000000000..cfa7966cd
--- /dev/null
+++ b/src/Ocelot/QualityOfService/CircuitBreakerDelegatingHandler.cs
@@ -0,0 +1,209 @@
+using Ocelot.Configuration;
+... | [
"src/Ocelot/QualityOfService/CircuitBreakerDelegatingHandler.cs"
] | [
{
"comment": "This remark still references Polly's implementation details, which is confusing for a built-in QoS handler. Consider removing the Polly reference and documenting Ocelot's own failure-code policy instead.\n",
"path": "src/Ocelot/QualityOfService/CircuitBreakerDelegatingHandler.cs",
"hunk": ... | true | ||
ThreeMammals/Ocelot | 2,385 | comment_to_fix | #2384 Built-in Circuit Breaker for Quality of Service (express edition, no Polly required) | Look at this UseQos guard:
https://github.com/ocelotgateway/Ocelot/blob/copilot/implement-circuit-breaker-pattern/src/Ocelot/Configuration/QoSOptions.cs#L64-L66
For Polly implementation it also disables Circuit Breaker due to this line of code:
https://github.com/ThreeMammals/Ocelot.QualityOfService.Polly/blob/main/... | c3720c550899db4aadd77ae77754bd9978101c34 | e892ef804bbe2837bc0f26ff6ba57bb7fe395f26 | diff --git a/docs/features/qualityofservice.rst b/docs/features/qualityofservice.rst
index cb5e9a8dd..1274d2197 100644
--- a/docs/features/qualityofservice.rst
+++ b/docs/features/qualityofservice.rst
@@ -17,21 +17,281 @@ Quality of Service
| Label: |QoS_label|:pdf:`\href{https://github.com/ThreeMammals/Ocelot/label... | [
"docs/features/qualityofservice.rst"
] | [
{
"comment": "Look at this UseQos guard:\r\nhttps://github.com/ocelotgateway/Ocelot/blob/copilot/implement-circuit-breaker-pattern/src/Ocelot/Configuration/QoSOptions.cs#L64-L66\r\nFor Polly implementation it also disables Circuit Breaker due to this line of code:\r\nhttps://github.com/ThreeMammals/Ocelot.Quali... | true | ||
ThreeMammals/Ocelot | 2,385 | comment_to_fix | #2384 Built-in Circuit Breaker for Quality of Service (express edition, no Polly required) | This is wrong! This is design issue.
Timeout value range should be adjusted to Polly's constants: https://github.com/ThreeMammals/Ocelot.QualityOfService.Polly/blob/main/src/TimeoutStrategy.cs
Thus, a default value must be introduced in the `CircuitBreakerDelegatingHandler` constructor. | c3720c550899db4aadd77ae77754bd9978101c34 | e892ef804bbe2837bc0f26ff6ba57bb7fe395f26 | diff --git a/docs/features/qualityofservice.rst b/docs/features/qualityofservice.rst
index cb5e9a8dd..1274d2197 100644
--- a/docs/features/qualityofservice.rst
+++ b/docs/features/qualityofservice.rst
@@ -17,21 +17,281 @@ Quality of Service
| Label: |QoS_label|:pdf:`\href{https://github.com/ThreeMammals/Ocelot/label... | [
"docs/features/qualityofservice.rst"
] | [
{
"comment": "This is wrong! This is design issue.\nTimeout value range should be adjusted to Polly's constants: https://github.com/ThreeMammals/Ocelot.QualityOfService.Polly/blob/main/src/TimeoutStrategy.cs\nThus, a default value must be introduced in the `CircuitBreakerDelegatingHandler` constructor.",
"p... | true | ||
ThreeMammals/Ocelot | 2,385 | comment_to_fix | #2384 Built-in Circuit Breaker for Quality of Service (express edition, no Polly required) | It should be default set of codes, and it should be assigned by default.
Additional protected virtual property `ServerErrorCodes` should be introduced to allow a developer to inherit and override those codes, see Polly's implementation:
https://github.com/ThreeMammals/Ocelot.QualityOfService.Polly/blob/d77e771592e478b... | c3720c550899db4aadd77ae77754bd9978101c34 | e892ef804bbe2837bc0f26ff6ba57bb7fe395f26 | diff --git a/src/Ocelot/QualityOfService/CircuitBreakerDelegatingHandler.cs b/src/Ocelot/QualityOfService/CircuitBreakerDelegatingHandler.cs
new file mode 100644
index 000000000..cfa7966cd
--- /dev/null
+++ b/src/Ocelot/QualityOfService/CircuitBreakerDelegatingHandler.cs
@@ -0,0 +1,209 @@
+using Ocelot.Configuration;
+... | [
"src/Ocelot/QualityOfService/CircuitBreakerDelegatingHandler.cs"
] | [
{
"comment": "It should be default set of codes, and it should be assigned by default.\nAdditional protected virtual property `ServerErrorCodes` should be introduced to allow a developer to inherit and override those codes, see Polly's implementation: \nhttps://github.com/ThreeMammals/Ocelot.QualityOfService.Po... | true | ||
ThreeMammals/Ocelot | 2,385 | comment_to_fix | #2384 Built-in Circuit Breaker for Quality of Service (express edition, no Polly required) | With this option, we set up a timeout which is part of the circuit breaker where the timeout is implemented.
We need to explain to the user that the default values of the built-in implementation are substituted here.
By design, the timeout feature is not independent of the circuit breaker; thus, it is part of it.
There... | c3720c550899db4aadd77ae77754bd9978101c34 | e892ef804bbe2837bc0f26ff6ba57bb7fe395f26 | diff --git a/docs/features/qualityofservice.rst b/docs/features/qualityofservice.rst
index cb5e9a8dd..1274d2197 100644
--- a/docs/features/qualityofservice.rst
+++ b/docs/features/qualityofservice.rst
@@ -17,21 +17,281 @@ Quality of Service
| Label: |QoS_label|:pdf:`\href{https://github.com/ThreeMammals/Ocelot/label... | [
"docs/features/qualityofservice.rst"
] | [
{
"comment": "With this option, we set up a timeout which is part of the circuit breaker where the timeout is implemented.\nWe need to explain to the user that the default values of the built-in implementation are substituted here.\nBy design, the timeout feature is not independent of the circuit breaker; thus,... | true | ||
ThreeMammals/Ocelot | 2,385 | comment_to_fix | #2384 Built-in Circuit Breaker for Quality of Service (express edition, no Polly required) | We have to explain how to override the codes virtually.
Before this doc update, we must introduce a new DI helper in `OcelotBuilder` to inject a descendant class inheriting from `CircuitBreakerDelegatingHandler`. Thus, the descendant handler will override the codes. | c3720c550899db4aadd77ae77754bd9978101c34 | e892ef804bbe2837bc0f26ff6ba57bb7fe395f26 | diff --git a/docs/features/qualityofservice.rst b/docs/features/qualityofservice.rst
index cb5e9a8dd..1274d2197 100644
--- a/docs/features/qualityofservice.rst
+++ b/docs/features/qualityofservice.rst
@@ -17,21 +17,281 @@ Quality of Service
| Label: |QoS_label|:pdf:`\href{https://github.com/ThreeMammals/Ocelot/label... | [
"docs/features/qualityofservice.rst"
] | [
{
"comment": "We have to explain how to override the codes virtually.\n\nBefore this doc update, we must introduce a new DI helper in `OcelotBuilder` to inject a descendant class inheriting from `CircuitBreakerDelegatingHandler`. Thus, the descendant handler will override the codes.",
"path": "docs/features... | true | ||
ThreeMammals/Ocelot | 1,569 | issue_to_patch | Dynamically set/add Configuration for rate limiting
## Expected Behavior / New Feature
For every re-route, we need to add
"RateLimitOptions": {
"ClientWhitelist": [],
"EnableRateLimiting": true,
"Period": "10s",
"PeriodTimespan": 3,
"Limit": 1
}
Now, if I wan... | #1228 #1235 #1247 Overloaded AddOcelot method for dynamic FileConfiguration construction | ## Closes #1228 #1235 #1247
- #1228
- #1235
- #1247
## New Feature
Added an `AddOcelot` overload to load `FileConfiguration` directly from the application, so that all the routes could be made configurable and could be load from anywhere.
## Proposed Changes
- Added a new overload to the `AddOcelot` in... | 5ad807d7342251e1996c189c942a6192dc6e3919 | 737ed2808331fb0e674b738246dae613d52d1900 | diff --git a/src/Ocelot/DependencyInjection/ConfigurationBuilderExtensions.cs b/src/Ocelot/DependencyInjection/ConfigurationBuilderExtensions.cs
index db6f4b1e7..773205462 100644
--- a/src/Ocelot/DependencyInjection/ConfigurationBuilderExtensions.cs
+++ b/src/Ocelot/DependencyInjection/ConfigurationBuilderExtensions.cs... | [
"src/Ocelot/DependencyInjection/ConfigurationBuilderExtensions.cs",
"test/Ocelot.AcceptanceTests/ConfigurationReloadTests.cs",
"test/Ocelot.UnitTests/DependencyInjection/ConfigurationBuilderExtensionsTests.cs"
] | [
{
"comment": "I would recommend to move this string constant declaration to the class level:\r\n```csharp\r\npublic static class ConfigurationBuilderExtensions\r\n{\r\n private const string primaryConfigFile = \"ocelot.json\";\r\n\r\n // usage on the lines 81 and 92.\r\n}\r\n```",
"path": "src/Ocelot/... | diff --git a/test/Ocelot.AcceptanceTests/ConfigurationReloadTests.cs b/test/Ocelot.AcceptanceTests/ConfigurationReloadTests.cs
index 9b673be9d..9e791d4f1 100644
--- a/test/Ocelot.AcceptanceTests/ConfigurationReloadTests.cs
+++ b/test/Ocelot.AcceptanceTests/ConfigurationReloadTests.cs
@@ -88,6 +88,7 @@ public void shoul... | true |
ThreeMammals/Ocelot | 1,569 | comment_to_fix | #1228 #1235 #1247 Overloaded AddOcelot method for dynamic FileConfiguration construction | I would recommend to move this string constant declaration to the class level:
```csharp
public static class ConfigurationBuilderExtensions
{
private const string primaryConfigFile = "ocelot.json";
// usage on the lines 81 and 92.
}
``` | 5ad807d7342251e1996c189c942a6192dc6e3919 | 737ed2808331fb0e674b738246dae613d52d1900 | diff --git a/src/Ocelot/DependencyInjection/ConfigurationBuilderExtensions.cs b/src/Ocelot/DependencyInjection/ConfigurationBuilderExtensions.cs
index db6f4b1e7..773205462 100644
--- a/src/Ocelot/DependencyInjection/ConfigurationBuilderExtensions.cs
+++ b/src/Ocelot/DependencyInjection/ConfigurationBuilderExtensions.cs... | [
"src/Ocelot/DependencyInjection/ConfigurationBuilderExtensions.cs"
] | [
{
"comment": "I would recommend to move this string constant declaration to the class level:\r\n```csharp\r\npublic static class ConfigurationBuilderExtensions\r\n{\r\n private const string primaryConfigFile = \"ocelot.json\";\r\n\r\n // usage on the lines 81 and 92.\r\n}\r\n```",
"path": "src/Ocelot/... | true | ||
ThreeMammals/Ocelot | 1,569 | comment_to_fix | #1228 #1235 #1247 Overloaded AddOcelot method for dynamic FileConfiguration construction | You can reuse new defined method (line 89) in the overloaded `AddOcelot` method (line 40) like this:
```csharp
public static IConfigurationBuilder AddOcelot(this IConfigurationBuilder builder, string folder, IWebHostEnvironment env)
{
// line 78
return AddOcelot(builder, fileConfiguration, env); // merge b... | 5ad807d7342251e1996c189c942a6192dc6e3919 | 737ed2808331fb0e674b738246dae613d52d1900 | diff --git a/src/Ocelot/DependencyInjection/ConfigurationBuilderExtensions.cs b/src/Ocelot/DependencyInjection/ConfigurationBuilderExtensions.cs
index db6f4b1e7..773205462 100644
--- a/src/Ocelot/DependencyInjection/ConfigurationBuilderExtensions.cs
+++ b/src/Ocelot/DependencyInjection/ConfigurationBuilderExtensions.cs... | [
"src/Ocelot/DependencyInjection/ConfigurationBuilderExtensions.cs"
] | [
{
"comment": "You can reuse new defined method (line 89) in the overloaded `AddOcelot` method (line 40) like this:\r\n```csharp\r\npublic static IConfigurationBuilder AddOcelot(this IConfigurationBuilder builder, string folder, IWebHostEnvironment env)\r\n{\r\n // line 78\r\n return AddOcelot(builder, fil... | true | ||
ThreeMammals/Ocelot | 561 | issue_to_patch | Feature/move polly | Fixes / New Feature #
## Proposed Changes
-
-
-
| e909cf9ce7e6b761680e4d3a54f52e114b470f00 | 438992fab2f6958406b267f0884209ecebddfa80 | diff --git a/src/Ocelot/Configuration/QoSOptions.cs b/src/Ocelot/Configuration/QoSOptions.cs
index 3b7733a3a..b0e7df7ae 100644
--- a/src/Ocelot/Configuration/QoSOptions.cs
+++ b/src/Ocelot/Configuration/QoSOptions.cs
@@ -1,32 +1,33 @@
-using Polly.Timeout;
-
-namespace Ocelot.Configuration
-{
- public class QoS... | [
"src/Ocelot/Configuration/QoSOptions.cs",
"src/Ocelot/DependencyInjection/OcelotBuilder.cs",
"src/Ocelot/Ocelot.csproj",
"src/Ocelot/Requester/DelegatingHandlerHandlerFactory.cs",
"src/Ocelot/Requester/HttpClientBuilder.cs",
"src/Ocelot/Requester/HttpClientHttpRequester.cs",
"src/Ocelot/Requester/PollyC... | [] | diff --git a/test/Ocelot.AcceptanceTests/QoSTests.cs b/test/Ocelot.AcceptanceTests/QoSTests.cs
deleted file mode 100644
index e62de7b3c..000000000
--- a/test/Ocelot.AcceptanceTests/QoSTests.cs
+++ /dev/null
@@ -1,272 +0,0 @@
-namespace Ocelot.AcceptanceTests
-{
- using System;
- using System.Collections.Gener... | true | |
ThreeMammals/Ocelot | 2,380 | issue_to_patch | Split the monorepo with the goal of having independent releases of projects
A long time ago, in a distant kingdom, King Tom migrated micro-projects to this repository to adopt feature #734. However, the [Ocelot extension projects'](https://github.com/ThreeMammals/Ocelot/tree/24.1.0/src) releases depend on unpredictabl... | #2378 Deprecate `Ocelot.Provider.Polly` project in favor of a dedicated repository | ## Closes #2378
- #2378
## New dedicated repository
- [Ocelot.QualityOfService.Polly](https://github.com/ThreeMammals/Ocelot.QualityOfService.Polly)
## Proposed Changes
- The project has been moved to the new repo
- All tests have been moved out of this repo to the new one
## Predecessor
- #2372
| 1724c49564e71731533dda4040fb6222cfdc968a | aa8e546c0841f3a407264c95caef09cc7dd6cf42 | diff --git a/.github/workflows/develop.yml b/.github/workflows/develop.yml
index 3823802c2..362052768 100644
--- a/.github/workflows/develop.yml
+++ b/.github/workflows/develop.yml
@@ -7,7 +7,7 @@ on:
jobs:
build:
strategy:
- max-parallel: 2
+ max-parallel: 1
matrix:
os: [ubuntu, maco... | [
".github/workflows/develop.yml",
".github/workflows/pr.yml",
".github/workflows/release.yml",
"Ocelot.sln",
"Ocelot.slnx",
"README.md",
"docs/features/qualityofservice.rst",
"src/Ocelot.Provider.Polly/CircuitBreakerStrategy.cs",
"src/Ocelot.Provider.Polly/Interfaces/IPollyQoSResiliencePipelineProvid... | [] | diff --git a/test/Ocelot.AcceptanceTests/CannotStartOcelotTests.cs b/test/Ocelot.AcceptanceTests/CannotStartOcelotTests.cs
index 96b4b1932..74434bd4e 100644
--- a/test/Ocelot.AcceptanceTests/CannotStartOcelotTests.cs
+++ b/test/Ocelot.AcceptanceTests/CannotStartOcelotTests.cs
@@ -84,7 +84,7 @@ public void Should_throw_... | true |
ThreeMammals/Ocelot | 2,382 | issue_to_patch | Follow up #2379 Review InvalidHeaderValueTests | ## Follow up #2379
- #2379
| e881c97595802c1019b972657dea9885f1b1cc25 | 75a5cc30be1fbc9191c46c02492fb6cadbf5acb6 | diff --git a/.github/steps/check-dotnet.sh b/.github/steps/check-dotnet.sh
index 8898742b9..96ec7d8f1 100644
--- a/.github/steps/check-dotnet.sh
+++ b/.github/steps/check-dotnet.sh
@@ -2,19 +2,24 @@
# First argument: target .NET major version (digit)
# Default to 8 if no argument is provided
+# Target major version... | [
".github/steps/check-dotnet.sh",
".github/steps/prepare-coveralls.sh",
".github/steps/windows.add-dns-records.sh",
".github/steps/windows.install-certificate.sh",
".github/workflows/develop.yml",
".github/workflows/pr.yml",
".github/workflows/release.yml",
"test/Ocelot.AcceptanceTests/Requester/Invali... | [] | diff --git a/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs b/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs
index ca6e0dfe9..626b295d1 100644
--- a/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs
+++ b/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs... | true | |
ThreeMammals/Ocelot | 2,379 | issue_to_patch | Matched requests that contain invalid header values (eg with emoji) return a `502` to the client
The expected behaviour of this should be to return a `4XX` error to the client.
## Reproducing
Reproduced against the `Basic` sample on tag `24.1.0` with:
```sh
curl -X GET -v 'http://localhost:5555/ocelot/posts/askdj' ... | #2375 #2376 Map non-ASCII header `HttpRequestException` to 400 Bad Request according to RFC 7230 | ## Fixes #2376
- #2376
## Discussed in #2375
- #2375
### Changes
- Created a new `BadRequestError` mapped to **HTTP 400 (Bad Request)**.
- Updated `HttpExceptionToErrorMapper` to specifically catch `HttpRequestException` instances complaining about **"only ASCII characters"**.
- Mapped this specific ex... | 5eeb9cccad4b45d8b409310c43582e827de97e06 | 398a0880190cf4f6aa28428ec42fc7639db7d2a0 | diff --git a/docs/features/errorcodes.rst b/docs/features/errorcodes.rst
index deec75e54..3c1a346f4 100644
--- a/docs/features/errorcodes.rst
+++ b/docs/features/errorcodes.rst
@@ -31,12 +31,19 @@ Ocelot returns HTTP status codes based on internal logic in specific cases of :r
Client Error Responses
-------------... | [
"docs/features/errorcodes.rst",
"src/Ocelot/Errors/Error.cs",
"src/Ocelot/Errors/OcelotErrorCode.cs",
"src/Ocelot/Infrastructure/RequestData/CannotAddDataError.cs",
"src/Ocelot/Infrastructure/RequestData/CannotFindDataError.cs",
"src/Ocelot/Infrastructure/RequestData/HttpDataRepository.cs",
"src/Ocelot/... | [
{
"comment": "# 😆 \nAmazing lifehack!",
"path": "src/Ocelot/Requester/HttpExceptionToErrorMapper.cs",
"hunk": "@@ -47,6 +47,14 @@ public Error Map(Exception exception)\n return new PayloadTooLargeError(exception);\n }\n \n+ // Late Catch: Map the HttpRequestExcept... | diff --git a/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs b/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs
new file mode 100644
index 000000000..ca6e0dfe9
--- /dev/null
+++ b/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs
@@ -0,0 +1,78 @@
+
+using Microsoft.Net.Ht... | true |
ThreeMammals/Ocelot | 2,379 | comment_to_fix | #2375 #2376 Map non-ASCII header `HttpRequestException` to 400 Bad Request according to RFC 7230 | # 😆
Amazing lifehack! | 5eeb9cccad4b45d8b409310c43582e827de97e06 | 398a0880190cf4f6aa28428ec42fc7639db7d2a0 | diff --git a/src/Ocelot/Requester/HttpExceptionToErrorMapper.cs b/src/Ocelot/Requester/HttpExceptionToErrorMapper.cs
index 35c6fa7fb..2dd90b376 100644
--- a/src/Ocelot/Requester/HttpExceptionToErrorMapper.cs
+++ b/src/Ocelot/Requester/HttpExceptionToErrorMapper.cs
@@ -30,7 +30,7 @@ public Error Map(Exception exception)... | [
"src/Ocelot/Requester/HttpExceptionToErrorMapper.cs"
] | [
{
"comment": "# 😆 \nAmazing lifehack!",
"path": "src/Ocelot/Requester/HttpExceptionToErrorMapper.cs",
"hunk": "@@ -47,6 +47,14 @@ public Error Map(Exception exception)\n return new PayloadTooLargeError(exception);\n }\n \n+ // Late Catch: Map the HttpRequestExcept... | true | ||
ThreeMammals/Ocelot | 2,379 | comment_to_fix | #2375 #2376 Map non-ASCII header `HttpRequestException` to 400 Bad Request according to RFC 7230 | Last line must be empty! This red circle should be removed. | 5eeb9cccad4b45d8b409310c43582e827de97e06 | 398a0880190cf4f6aa28428ec42fc7639db7d2a0 | diff --git a/src/Ocelot/Requester/BadRequestError.cs b/src/Ocelot/Requester/BadRequestError.cs
new file mode 100644
index 000000000..abf6e8464
--- /dev/null
+++ b/src/Ocelot/Requester/BadRequestError.cs
@@ -0,0 +1,15 @@
+using Microsoft.AspNetCore.Http;
+using Ocelot.Errors;
+
+namespace Ocelot.Requester;
+
+public cla... | [
"src/Ocelot/Requester/BadRequestError.cs"
] | [
{
"comment": "Last line must be empty! This red circle should be removed.",
"path": "src/Ocelot/Requester/BadRequestError.cs",
"hunk": "@@ -0,0 +1,12 @@\n+using System;\n+using Ocelot.Errors;\n+\n+namespace Ocelot.Requester;\n+\n+public class BadRequestError : Error\n+{\n+ public BadRequestError(stri... | true | ||
ThreeMammals/Ocelot | 2,379 | comment_to_fix | #2375 #2376 Map non-ASCII header `HttpRequestException` to 400 Bad Request according to RFC 7230 | ```suggestion
: base(message, OcelotErrorCode.BadRequestError, StatusCodes.Status400BadRequest)
``` | 5eeb9cccad4b45d8b409310c43582e827de97e06 | 398a0880190cf4f6aa28428ec42fc7639db7d2a0 | diff --git a/src/Ocelot/Requester/BadRequestError.cs b/src/Ocelot/Requester/BadRequestError.cs
new file mode 100644
index 000000000..abf6e8464
--- /dev/null
+++ b/src/Ocelot/Requester/BadRequestError.cs
@@ -0,0 +1,15 @@
+using Microsoft.AspNetCore.Http;
+using Ocelot.Errors;
+
+namespace Ocelot.Requester;
+
+public cla... | [
"src/Ocelot/Requester/BadRequestError.cs"
] | [
{
"comment": "```suggestion\n : base(message, OcelotErrorCode.BadRequestError, StatusCodes.Status400BadRequest)\n```",
"path": "src/Ocelot/Requester/BadRequestError.cs",
"hunk": "@@ -0,0 +1,12 @@\n+using System;\n+using Ocelot.Errors;\n+\n+namespace Ocelot.Requester;\n+\n+public class BadRequestE... | true | ||
ThreeMammals/Ocelot | 2,379 | comment_to_fix | #2375 #2376 Map non-ASCII header `HttpRequestException` to 400 Bad Request according to RFC 7230 | ```suggestion
return StatusCodes.Status400BadRequest;
``` | 5eeb9cccad4b45d8b409310c43582e827de97e06 | 398a0880190cf4f6aa28428ec42fc7639db7d2a0 | diff --git a/src/Ocelot/Responder/ErrorsToHttpStatusCodeMapper.cs b/src/Ocelot/Responder/ErrorsToHttpStatusCodeMapper.cs
index c01b0214b..ae7b3298a 100644
--- a/src/Ocelot/Responder/ErrorsToHttpStatusCodeMapper.cs
+++ b/src/Ocelot/Responder/ErrorsToHttpStatusCodeMapper.cs
@@ -9,7 +9,7 @@ public int Map(List<Error> erro... | [
"src/Ocelot/Responder/ErrorsToHttpStatusCodeMapper.cs"
] | [
{
"comment": "```suggestion\n return StatusCodes.Status400BadRequest;\n```",
"path": "src/Ocelot/Responder/ErrorsToHttpStatusCodeMapper.cs",
"hunk": "@@ -61,6 +61,11 @@ public int Map(List<Error> errors)\n return 413;\n }\n \n+ if (errors.Any(e => e.Code == OcelotEr... | true | ||
ThreeMammals/Ocelot | 2,379 | comment_to_fix | #2375 #2376 Map non-ASCII header `HttpRequestException` to 400 Bad Request according to RFC 7230 | What is that? Only one port is required. If you use the same port‑getting expression in another acceptance test, you will get the same port, since `Environment.ProcessId` remains unchanged for the current session process. But the `Thread` ID (aka `Thread.ManagedThreadId`) is unique for every `Task` and its allocated th... | 5eeb9cccad4b45d8b409310c43582e827de97e06 | 398a0880190cf4f6aa28428ec42fc7639db7d2a0 | diff --git a/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs b/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs
new file mode 100644
index 000000000..ca6e0dfe9
--- /dev/null
+++ b/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs
@@ -0,0 +1,78 @@
+
+using Microsoft.Net.Ht... | [
"test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs"
] | [
{
"comment": "What is that? Only one port is required. If you use the same port‑getting expression in another acceptance test, you will get the same port, since `Environment.ProcessId` remains unchanged for the current session process. But the `Thread` ID (aka `Thread.ManagedThreadId`) is unique for every `Task... | true | ||
ThreeMammals/Ocelot | 2,379 | comment_to_fix | #2375 #2376 Map non-ASCII header `HttpRequestException` to 400 Bad Request according to RFC 7230 | Mapping OK/response is not required since it is encapsulated in lots of helpers from the `Ocelot.Testing` namespace.
```suggestion
GivenThereIsAServiceRunningOnPath(downstreamPort, DownstreamRequestPath, DownstreamResponseBody);
``` | 5eeb9cccad4b45d8b409310c43582e827de97e06 | 398a0880190cf4f6aa28428ec42fc7639db7d2a0 | diff --git a/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs b/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs
new file mode 100644
index 000000000..ca6e0dfe9
--- /dev/null
+++ b/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs
@@ -0,0 +1,78 @@
+
+using Microsoft.Net.Ht... | [
"test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs"
] | [
{
"comment": "Mapping OK/response is not required since it is encapsulated in lots of helpers from the `Ocelot.Testing` namespace.\n\n```suggestion\n GivenThereIsAServiceRunningOnPath(downstreamPort, DownstreamRequestPath, DownstreamResponseBody);\n```",
"path": "test/Ocelot.AcceptanceTests/Requester... | true | ||
ThreeMammals/Ocelot | 2,379 | comment_to_fix | #2375 #2376 Map non-ASCII header `HttpRequestException` to 400 Bad Request according to RFC 7230 | Wow! AI is wrong! There is a helper:
```suggestion
int gatewayPort = GivenOcelotIsRunning();
```
Finally, `gatewayPort` is not required because getting the port for the gateway is encapsulated inside the helper, which returns the port value from the method. | 5eeb9cccad4b45d8b409310c43582e827de97e06 | 398a0880190cf4f6aa28428ec42fc7639db7d2a0 | diff --git a/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs b/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs
new file mode 100644
index 000000000..ca6e0dfe9
--- /dev/null
+++ b/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs
@@ -0,0 +1,78 @@
+
+using Microsoft.Net.Ht... | [
"test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs"
] | [
{
"comment": "Wow! AI is wrong! There is a helper:\n\n```suggestion\n int gatewayPort = GivenOcelotIsRunning();\n```\nFinally, `gatewayPort` is not required because getting the port for the gateway is encapsulated inside the helper, which returns the port value from the method.",
"path": "test/Ocelot... | true | ||
ThreeMammals/Ocelot | 2,379 | comment_to_fix | #2375 #2376 Map non-ASCII header `HttpRequestException` to 400 Bad Request according to RFC 7230 | Something interesting and intriguing is inside. 😉 | 5eeb9cccad4b45d8b409310c43582e827de97e06 | 398a0880190cf4f6aa28428ec42fc7639db7d2a0 | diff --git a/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs b/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs
new file mode 100644
index 000000000..ca6e0dfe9
--- /dev/null
+++ b/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs
@@ -0,0 +1,78 @@
+
+using Microsoft.Net.Ht... | [
"test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs"
] | [
{
"comment": "Something interesting and intriguing is inside. 😉 ",
"path": "test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs",
"hunk": "@@ -0,0 +1,86 @@\n+using Microsoft.AspNetCore.Builder;\n+using Microsoft.AspNetCore.Hosting;\n+using Microsoft.AspNetCore.Http;\n+using System.Net.Sock... | true | ||
ThreeMammals/Ocelot | 2,379 | comment_to_fix | #2375 #2376 Map non-ASCII header `HttpRequestException` to 400 Bad Request according to RFC 7230 | Oh my gosh! 🤯
TCP, loopback interface, and plain streams... Why? 🤨
You just need to attach a header with the desired header value to Ocelot client, and no extra streams are required.
| 5eeb9cccad4b45d8b409310c43582e827de97e06 | 398a0880190cf4f6aa28428ec42fc7639db7d2a0 | diff --git a/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs b/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs
new file mode 100644
index 000000000..ca6e0dfe9
--- /dev/null
+++ b/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs
@@ -0,0 +1,78 @@
+
+using Microsoft.Net.Ht... | [
"test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs"
] | [
{
"comment": "Oh my gosh! 🤯 \nTCP, loopback interface, and plain streams... Why? 🤨 \nYou just need to attach a header with the desired header value to Ocelot client, and no extra streams are required.\n",
"path": "test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs",
"hunk": "@@ -0,0 +1,8... | true | ||
ThreeMammals/Ocelot | 2,379 | comment_to_fix | #2375 #2376 Map non-ASCII header `HttpRequestException` to 400 Bad Request according to RFC 7230 | Is that another testing/sending request technique based on client streams? It's not something we use in acceptance testing, but, seems, it calls Ocelot's endpoint.
The code is very hard to read!
You just need to specify a header, attach it, and send the request. | 5eeb9cccad4b45d8b409310c43582e827de97e06 | 398a0880190cf4f6aa28428ec42fc7639db7d2a0 | diff --git a/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs b/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs
new file mode 100644
index 000000000..ca6e0dfe9
--- /dev/null
+++ b/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs
@@ -0,0 +1,78 @@
+
+using Microsoft.Net.Ht... | [
"test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs"
] | [
{
"comment": "Is that another testing/sending request technique based on client streams? It's not something we use in acceptance testing, but, seems, it calls Ocelot's endpoint.\n\nThe code is very hard to read!\nYou just need to specify a header, attach it, and send the request.",
"path": "test/Ocelot.Acce... | true | ||
ThreeMammals/Ocelot | 2,379 | comment_to_fix | #2375 #2376 Map non-ASCII header `HttpRequestException` to 400 Bad Request according to RFC 7230 | AI generated bull shit code | 5eeb9cccad4b45d8b409310c43582e827de97e06 | 398a0880190cf4f6aa28428ec42fc7639db7d2a0 | diff --git a/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs b/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs
new file mode 100644
index 000000000..ca6e0dfe9
--- /dev/null
+++ b/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs
@@ -0,0 +1,78 @@
+
+using Microsoft.Net.Ht... | [
"test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs"
] | [
{
"comment": "AI generated bull shit code",
"path": "test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs",
"hunk": "@@ -0,0 +1,86 @@\n+using Microsoft.AspNetCore.Builder;\n+using Microsoft.AspNetCore.Hosting;\n+using Microsoft.AspNetCore.Http;\n+using System.Net.Sockets;\n+using System.Text... | true | ||
ThreeMammals/Ocelot | 2,379 | comment_to_fix | #2375 #2376 Map non-ASCII header `HttpRequestException` to 400 Bad Request according to RFC 7230 | Fictitious change! It must be reverted! | 5eeb9cccad4b45d8b409310c43582e827de97e06 | 398a0880190cf4f6aa28428ec42fc7639db7d2a0 | diff --git a/test/Ocelot.UnitTests/Responder/ErrorsToHttpStatusCodeMapperTests.cs b/test/Ocelot.UnitTests/Responder/ErrorsToHttpStatusCodeMapperTests.cs
index 444750f13..debb4b156 100644
--- a/test/Ocelot.UnitTests/Responder/ErrorsToHttpStatusCodeMapperTests.cs
+++ b/test/Ocelot.UnitTests/Responder/ErrorsToHttpStatusCo... | [
"test/Ocelot.UnitTests/Responder/ErrorsToHttpStatusCodeMapperTests.cs"
] | [
{
"comment": "Fictitious change! It must be reverted!",
"path": "test/Ocelot.UnitTests/Responder/ErrorsToHttpStatusCodeMapperTests.cs",
"hunk": "@@ -73,15 +80,15 @@ public void Should_return_bad_gateway_error(OcelotErrorCode errorCode)\n public void Should_return_not_found(OcelotErrorCode errorCode)... | true | ||
ThreeMammals/Ocelot | 2,379 | comment_to_fix | #2375 #2376 Map non-ASCII header `HttpRequestException` to 400 Bad Request according to RFC 7230 | Thanks for additional test coverage! | 5eeb9cccad4b45d8b409310c43582e827de97e06 | 398a0880190cf4f6aa28428ec42fc7639db7d2a0 | diff --git a/test/Ocelot.UnitTests/Kubernetes/PollKubeTests.cs b/test/Ocelot.UnitTests/Kubernetes/PollKubeTests.cs
index c9abc4256..98c761104 100644
--- a/test/Ocelot.UnitTests/Kubernetes/PollKubeTests.cs
+++ b/test/Ocelot.UnitTests/Kubernetes/PollKubeTests.cs
@@ -132,4 +132,127 @@ public async Task GetAsync()
... | [
"test/Ocelot.UnitTests/Kubernetes/PollKubeTests.cs"
] | [
{
"comment": "Thanks for additional test coverage!",
"path": "test/Ocelot.UnitTests/Kubernetes/PollKubeTests.cs",
"hunk": "",
"resolving_sha": "398a0880190cf4f6aa28428ec42fc7639db7d2a0",
"resolving_diff": "diff --git a/test/Ocelot.UnitTests/Kubernetes/PollKubeTests.cs b/test/Ocelot.UnitTests/Kub... | true | ||
ThreeMammals/Ocelot | 2,379 | comment_to_fix | #2375 #2376 Map non-ASCII header `HttpRequestException` to 400 Bad Request according to RFC 7230 | It’s hard to judge this solution until a valid acceptance test has been written.
I believe we can improve this area, since the `Message.Contains` method handles a specific user scenario. But what about codes, internal exceptions, and so on? We should inspect the generated exception and reuse its state rather than rely... | 5eeb9cccad4b45d8b409310c43582e827de97e06 | 398a0880190cf4f6aa28428ec42fc7639db7d2a0 | diff --git a/src/Ocelot/Requester/HttpExceptionToErrorMapper.cs b/src/Ocelot/Requester/HttpExceptionToErrorMapper.cs
index 35c6fa7fb..2dd90b376 100644
--- a/src/Ocelot/Requester/HttpExceptionToErrorMapper.cs
+++ b/src/Ocelot/Requester/HttpExceptionToErrorMapper.cs
@@ -30,7 +30,7 @@ public Error Map(Exception exception)... | [
"src/Ocelot/Requester/HttpExceptionToErrorMapper.cs"
] | [
{
"comment": "It’s hard to judge this solution until a valid acceptance test has been written.\n\nI believe we can improve this area, since the `Message.Contains` method handles a specific user scenario. But what about codes, internal exceptions, and so on? We should inspect the generated exception and reuse it... | true | ||
ThreeMammals/Ocelot | 2,379 | comment_to_fix | #2375 #2376 Map non-ASCII header `HttpRequestException` to 400 Bad Request according to RFC 7230 | I suggest adding a second parameter to the theory—a parameter of type `HttpStatusCode`.
The 4th test case could verify the OK status if the header contains only ASCII characters. It’s a trivial test, but intentional. I expect that we haven’t written a separate `Fact`. | 5eeb9cccad4b45d8b409310c43582e827de97e06 | 398a0880190cf4f6aa28428ec42fc7639db7d2a0 | diff --git a/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs b/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs
new file mode 100644
index 000000000..ca6e0dfe9
--- /dev/null
+++ b/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs
@@ -0,0 +1,78 @@
+
+using Microsoft.Net.Ht... | [
"test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs"
] | [
{
"comment": "I suggest adding a second parameter to the theory—a parameter of type `HttpStatusCode`.\n\nThe 4th test case could verify the OK status if the header contains only ASCII characters. It’s a trivial test, but intentional. I expect that we haven’t written a separate `Fact`.",
"path": "test/Ocelot... | true | ||
ThreeMammals/Ocelot | 2,379 | comment_to_fix | #2375 #2376 Map non-ASCII header `HttpRequestException` to 400 Bad Request according to RFC 7230 | Yeah, that is funny.
This life hack — which catches the `HttpClient` exception early by adjusting the response to return a 400 status — actually triggers the exception too early. Here is the call stack it produces:
```
at System.Net.Http.HttpConnection.<WriteString>g__ThrowForInvalidCharEncoding|55_0()
at Sys... | 5eeb9cccad4b45d8b409310c43582e827de97e06 | 398a0880190cf4f6aa28428ec42fc7639db7d2a0 | diff --git a/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs b/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs
new file mode 100644
index 000000000..ca6e0dfe9
--- /dev/null
+++ b/test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs
@@ -0,0 +1,78 @@
+
+using Microsoft.Net.Ht... | [
"test/Ocelot.AcceptanceTests/Requester/InvalidHeaderValueTests.cs"
] | [
{
"comment": "Yeah, that is funny.\r\nThis life hack — which catches the `HttpClient` exception early by adjusting the response to return a 400 status — actually triggers the exception too early. Here is the call stack it produces:\r\n```\r\n at System.Net.Http.HttpConnection.<WriteString>g__ThrowForInvalidCh... | true | ||
ThreeMammals/Ocelot | 2,367 | issue_to_patch | Bump all NuGet packages to the latest versions for .NET SDK 10.0.201 (aka .NET Runtime 10.0.5) | This PR updates the solutions according to the [.NET SDK 10.0.201](https://dotnet.microsoft.com/en-us/download/dotnet/10.0), released on [March 12, 2026](https://github.com/dotnet/core/blob/main/release-notes/10.0/10.0.5/10.0.5.md).
## Proposed Changes
- Bumped `Microsoft.AspNetCore.*` packs
- Bumped non-MS pa... | 02aaa76914caf26392d6e8c8ecb35bc1606e2aa2 | 0338de8096c7365a43f3a96c747eb6c7ff23f035 | diff --git a/samples/Basic/packages.lock.json b/samples/Basic/packages.lock.json
index 8d14d64cf..743adaed6 100644
--- a/samples/Basic/packages.lock.json
+++ b/samples/Basic/packages.lock.json
@@ -14,42 +14,31 @@
},
"Microsoft.AspNetCore.JsonPatch": {
"type": "Transitive",
- "resolved": "1... | [
"samples/Basic/packages.lock.json",
"samples/Configuration/packages.lock.json",
"samples/Eureka/ApiGateway/packages.lock.json",
"samples/Eureka/DownstreamService/Ocelot.Samples.Eureka.DownstreamService.csproj",
"samples/Eureka/DownstreamService/packages.lock.json",
"samples/GraphQL/Ocelot.Samples.GraphQL.... | [] | diff --git a/test/Ocelot.AcceptanceTests/Ocelot.AcceptanceTests.csproj b/test/Ocelot.AcceptanceTests/Ocelot.AcceptanceTests.csproj
index bf673644a..062aefdb0 100644
--- a/test/Ocelot.AcceptanceTests/Ocelot.AcceptanceTests.csproj
+++ b/test/Ocelot.AcceptanceTests/Ocelot.AcceptanceTests.csproj
@@ -50,36 +50,36 @@
... | true | |
ThreeMammals/Ocelot | 2,372 | issue_to_patch | Deprecate Ocelot.Provider.Eureka project
## Ocelot.Provider.Eureka package
[Ocelot.Provider.Eureka](https://github.com/ThreeMammals/Ocelot/tree/25.0.0-beta.2/src/Ocelot.Provider.Eureka) was first introduced in PR #324.
- Repo Search: [Eureka PRs](https://github.com/search?q=repo%3AThreeMammals%2FOcelot+Eureka&type=pul... | #2334 #2371 Deprecate `Ocelot.Provider.Eureka` project in favor of a dedicated repository | ## Closes #2371
- #2371
## New dedicated repository
- [Ocelot.Discovery.Eureka](https://github.com/ThreeMammals/Ocelot.Discovery.Eureka)
## Proposed Changes
- The project has been moved to the new repo
- All tests have been moved out of this repo to the new one
## Related to
- #2334
| 9acc27195c181d2f3ed0029a5a8d3b18323d6079 | 307fe629005d34a843a74c6d12a18d07ee2c70c6 | diff --git a/Ocelot.sln b/Ocelot.sln
index 7e3949079..0e3bd07fc 100644
--- a/Ocelot.sln
+++ b/Ocelot.sln
@@ -31,8 +31,6 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Ocelot", "src\Ocelot\Ocelot
EndProject
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Ocelot.Provider.Consul", "src\Ocelot.Provider.Cons... | [
"Ocelot.sln",
"Ocelot.slnx",
"samples/Eureka/ApiGateway/Ocelot.Samples.Eureka.ApiGateway.csproj",
"samples/Eureka/ApiGateway/packages.lock.json",
"src/Ocelot.Provider.Eureka/Eureka.cs",
"src/Ocelot.Provider.Eureka/EurekaMiddlewareConfigurationProvider.cs",
"src/Ocelot.Provider.Eureka/EurekaProviderFacto... | [] | diff --git a/test/Ocelot.AcceptanceTests/Ocelot.AcceptanceTests.csproj b/test/Ocelot.AcceptanceTests/Ocelot.AcceptanceTests.csproj
index 062aefdb0..21cfb4273 100644
--- a/test/Ocelot.AcceptanceTests/Ocelot.AcceptanceTests.csproj
+++ b/test/Ocelot.AcceptanceTests/Ocelot.AcceptanceTests.csproj
@@ -34,7 +34,6 @@
<ItemG... | true |
ThreeMammals/Ocelot | 2,369 | issue_to_patch | Pre-Release 25.0 aka Beta 2 | ## Pre-release 2 for [.NET 10](https://dotnet.microsoft.com/en-us/download/dotnet/10.0) SDK (version [25.0.0-beta.2](https://www.nuget.org/packages/Ocelot/25.0.0-beta.2))
> Milestone: [.NET 10](https://github.com/ThreeMammals/Ocelot/milestone/13)
This is **Pre-release 2** for the [.NET 10](https://dotnet.microsoft.... | 086c7b15c2724fe21a40e92b8ec2fdc0ae7a398c | d7957b42e912b01a26188cacce375e3110cd3f69 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 5921b1057..6d88f3aa6 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -3,13 +3,13 @@
"isRoot": true,
"tools": {
"cake.tool": {
- "version": "6.0.0",
+ "version": "6.1.0",
"commands": [
... | [
".config/dotnet-tools.json",
".github/workflows/pr.yml",
"ReleaseNotes.md",
"build.cake"
] | [] | true | ||
ThreeMammals/Ocelot | 2,365 | issue_to_patch | Follow-up #2363 #2364: Exclude `Ocelot.Testing` from Cobertura coverage via Coverlet `.runsettings` | ## Follow-up #2363 #2364
- #2363
- #2364
| e4e73af462e36e6e59d114c5a6a6d13a8b13fef3 | 87743b52944f3938bef911734ec2b529fb2f06ce | diff --git a/.github/workflows/develop.yml b/.github/workflows/develop.yml
index bc9ce91e6..e11d1a04e 100644
--- a/.github/workflows/develop.yml
+++ b/.github/workflows/develop.yml
@@ -32,9 +32,9 @@ jobs:
- name: Build
run: dotnet build --no-restore ./Ocelot.slnx --framework net10.0
- name: Unit ... | [
".github/workflows/develop.yml",
".github/workflows/pr.yml",
".github/workflows/release.yml",
"build.cake",
"coverlet.runsettings"
] | [] | true | ||
ThreeMammals/Ocelot | 2,364 | issue_to_patch | Embed `Ocelot.Testing` back into the Ocelot mono-repo
## Subject
- [Ocelot.Testing](https://www.nuget.org/packages/Ocelot.Testing/) extension package
- [Ocelot.Testing](https://github.com/ThreeMammals/Ocelot.Testing) repository
## Goal
We want to avoid creating Ocelot abstraction interfaces or classes to be reference... | #2363 Embed `Ocelot.Testing` back into the Ocelot mono-repo | ## Closes #2363
- #2363
| d38a001898191527c8154286c61701533542dcc9 | e1c3f7dc0c77a21266460f863e895a354ff75664 | diff --git a/Ocelot.sln b/Ocelot.sln
index 7cb8765f9..7e3949079 100644
--- a/Ocelot.sln
+++ b/Ocelot.sln
@@ -1,102 +1,177 @@
-
-Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio Version 18
-VisualStudioVersion = 18.3.11520.95
-MinimumVisualStudioVersion = 10.0.40219.1
-Project("{2150E33... | [
"Ocelot.sln",
"Ocelot.slnx",
"ocelot_icon.png",
"ocelot_logo.png",
"src/Ocelot.Provider.Consul/Ocelot.Provider.Consul.csproj",
"src/Ocelot.Provider.Eureka/Ocelot.Provider.Eureka.csproj",
"src/Ocelot.Provider.Kubernetes/Ocelot.Provider.Kubernetes.csproj",
"src/Ocelot.Provider.Polly/Ocelot.Provider.Poll... | [] | diff --git a/test/Ocelot.AcceptanceTests/Ocelot.AcceptanceTests.csproj b/test/Ocelot.AcceptanceTests/Ocelot.AcceptanceTests.csproj
index 2d370ec2e..79cddfbb6 100644
--- a/test/Ocelot.AcceptanceTests/Ocelot.AcceptanceTests.csproj
+++ b/test/Ocelot.AcceptanceTests/Ocelot.AcceptanceTests.csproj
@@ -37,12 +37,9 @@
<Pr... | true |
ThreeMammals/Ocelot | 2,362 | issue_to_patch | Deprecate 3 abandoned projects
A long time ago, in a distant kingdom, King Tom migrated micro-projects to this repository to adopt the [mono-repo release strategy](https://github.com/ThreeMammals/Ocelot/pull/734). However, the three [Ocelot pack projects](https://github.com/ThreeMammals/Ocelot/tree/develop/src) are no... | #2334 Deprecate `Ocelot.Tracing.OpenTracing` project in favor of a dedicated repository | ## Closes #2334
- #2334
## New dedicated repository
- [Ocelot.Tracing.OpenTracing](https://github.com/ThreeMammals/Ocelot.Tracing.OpenTracing)
## Proposed Changes
- The project has been moved to the new repo
- All tests have been moved out of this repo to the new one
| f972f896c792c34444bc858355d3045fc508de5c | e570e477c292ede40c04847104c4c637da1f1ddf | diff --git a/Ocelot.Samples.sln b/Ocelot.Samples.sln
index dce2bc747..cef049115 100644
--- a/Ocelot.Samples.sln
+++ b/Ocelot.Samples.sln
@@ -1,7 +1,7 @@
Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio Version 17
-VisualStudioVersion = 17.9.34728.123
+# Visual Studio Version 18
+VisualSt... | [
"Ocelot.Samples.sln",
"Ocelot.sln",
"Ocelot.slnx",
"samples/OpenTracing/Ocelot.Samples.OpenTracing.csproj",
"samples/OpenTracing/packages.lock.json",
"src/Ocelot.Tracing.OpenTracing/Ocelot.Tracing.OpenTracing.csproj",
"src/Ocelot.Tracing.OpenTracing/OcelotBuilderExtensions.cs",
"src/Ocelot.Tracing.Ope... | [] | diff --git a/test/Ocelot.AcceptanceTests/Administration/OcelotBuilderExtensions.cs b/test/Ocelot.AcceptanceTests/Administration/OcelotBuilderExtensions.cs
index e563d73bd..19a5a4927 100644
--- a/test/Ocelot.AcceptanceTests/Administration/OcelotBuilderExtensions.cs
+++ b/test/Ocelot.AcceptanceTests/Administration/Ocelot... | true |
ThreeMammals/Ocelot | 2,361 | issue_to_patch | Deprecate 3 abandoned projects
A long time ago, in a distant kingdom, King Tom migrated micro-projects to this repository to adopt the [mono-repo release strategy](https://github.com/ThreeMammals/Ocelot/pull/734). However, the three [Ocelot pack projects](https://github.com/ThreeMammals/Ocelot/tree/develop/src) are no... | #2334 Deprecate `Ocelot.Tracing.Butterfly` project in favor of a dedicated repository | ## Closes #2334
- #2334
## New dedicated repository
- [Ocelot.Tracing.Butterfly](https://github.com/ThreeMammals/Ocelot.Tracing.Butterfly)
## Proposed Changes
- The project has been moved to the new repo
- All tests have been moved out of this repo to the new one
- Refactored some cucumber source cod... | 8921fb2f7d7e52b69d918b2bd309b98e1a41b265 | fff4df856b6f565a8af2056a252b56df9c5d0c79 | diff --git a/Ocelot.sln b/Ocelot.sln
index 6c568d2b7..3b0de2eeb 100644
--- a/Ocelot.sln
+++ b/Ocelot.sln
@@ -1,7 +1,7 @@
Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio Version 17
-VisualStudioVersion = 17.9.34728.123
+# Visual Studio Version 18
+VisualStudioVersion = 18.3.11520.95... | [
"Ocelot.sln",
"Ocelot.slnx",
"src/Ocelot.Tracing.Butterfly/ButterflyTracer.cs",
"src/Ocelot.Tracing.Butterfly/Ocelot.Tracing.Butterfly.csproj",
"src/Ocelot.Tracing.Butterfly/OcelotBuilderExtensions.cs",
"src/Ocelot.Tracing.Butterfly/StringValuesExtensions.cs",
"src/Ocelot.Tracing.Butterfly/Usings.cs",
... | [] | diff --git a/test/Ocelot.AcceptanceTests/Ocelot.AcceptanceTests.csproj b/test/Ocelot.AcceptanceTests/Ocelot.AcceptanceTests.csproj
index bfc6c2e96..919fac2b0 100644
--- a/test/Ocelot.AcceptanceTests/Ocelot.AcceptanceTests.csproj
+++ b/test/Ocelot.AcceptanceTests/Ocelot.AcceptanceTests.csproj
@@ -37,7 +37,6 @@
<Pro... | true |
ThreeMammals/Ocelot | 2,360 | issue_to_patch | Deprecate 3 abandoned projects
A long time ago, in a distant kingdom, King Tom migrated micro-projects to this repository to adopt the [mono-repo release strategy](https://github.com/ThreeMammals/Ocelot/pull/734). However, the three [Ocelot pack projects](https://github.com/ThreeMammals/Ocelot/tree/develop/src) are no... | #2334 Deprecate `Ocelot.Cache.CacheManager` project in favor of a dedicated repository | ## Closes #2334
- #2334
## New dedicated repository
- [Ocelot.Cache.CacheManager](https://github.com/ThreeMammals/Ocelot.Cache.CacheManager)
## Proposed Changes
- The project has been moved to the new repo
- All tests have been moved out of this repo to the new one
| bc196e9e42f52051fbaaa478b0b3462420a20dc8 | b33760e865b1037f191d8549678949a1428f4d79 | diff --git a/Ocelot.sln b/Ocelot.sln
index 66e5c2963..6c568d2b7 100644
--- a/Ocelot.sln
+++ b/Ocelot.sln
@@ -31,8 +31,6 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Ocelot.Benchmarks", "test\O
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Ocelot", "src\Ocelot\Ocelot.csproj", "{D6DF4206-0... | [
"Ocelot.sln",
"Ocelot.slnx",
"samples/Basic/packages.lock.json",
"samples/Configuration/packages.lock.json",
"samples/Eureka/ApiGateway/packages.lock.json",
"samples/GraphQL/packages.lock.json",
"samples/Kubernetes/ApiGateway/packages.lock.json",
"samples/Metadata/packages.lock.json",
"samples/OpenT... | [] | diff --git a/test/Ocelot.AcceptanceTests/Administration/CacheManagerTests.cs b/test/Ocelot.AcceptanceTests/Administration/CacheManagerTests.cs
index 0ae6d30bd..cd1b405ff 100644
--- a/test/Ocelot.AcceptanceTests/Administration/CacheManagerTests.cs
+++ b/test/Ocelot.AcceptanceTests/Administration/CacheManagerTests.cs
@@ ... | true |
ThreeMammals/Ocelot | 2,359 | issue_to_patch | Install Codecov coverage app | Project: https://app.codecov.io/github/ThreeMammals/Ocelot | 12b9204bf4000be14f67363cec9d91fc486fb004 | 9173c311cba0a6ccbf26291965eda4a977973844 | diff --git a/.github/steps/prepare-coveralls.sh b/.github/steps/prepare-coveralls.sh
index aba97725e..21eeaf887 100644
--- a/.github/steps/prepare-coveralls.sh
+++ b/.github/steps/prepare-coveralls.sh
@@ -1,7 +1,9 @@
#!/bin/bash
# Prepare Coveralls
-echo ------------ Listing environment variables ------------
+echo "... | [
".github/steps/prepare-coveralls.sh",
".github/workflows/develop.yml",
".github/workflows/pr.yml",
".github/workflows/release.yml",
"README.md",
"codecov.yml"
] | [] | true | ||
ThreeMammals/Ocelot | 2,358 | issue_to_patch | #2354 Follow-up: Redesign `PollKube` discovery using `PeriodicTimer` | ## Follow up #2354
- #2354
- and commit https://github.com/ThreeMammals/Ocelot/commit/070593c0da9284d24782608d7f04380216d6f467
## Proposed Changes
- Added the `Dispose` pattern for logging and `Kube` polling
- Fixed [xUnit1051](https://xunit.net/xunit.analyzers/rules/xUnit1051) warnings, which is a best practic... | fccf792f351c7f904e0c6375bdebe86b44adf536 | b93658bdef5091b6a81d961e7285da28d4f2fcd2 | diff --git a/src/Ocelot.Cache.CacheManager/Ocelot.Cache.CacheManager.csproj b/src/Ocelot.Cache.CacheManager/Ocelot.Cache.CacheManager.csproj
index a9633741d..66e8db7bf 100644
--- a/src/Ocelot.Cache.CacheManager/Ocelot.Cache.CacheManager.csproj
+++ b/src/Ocelot.Cache.CacheManager/Ocelot.Cache.CacheManager.csproj
@@ -40,... | [
"src/Ocelot.Cache.CacheManager/Ocelot.Cache.CacheManager.csproj",
"src/Ocelot.Cache.CacheManager/packages.lock.json",
"src/Ocelot.Provider.Consul/ConsulProviderFactory.cs",
"src/Ocelot.Provider.Consul/Ocelot.Provider.Consul.csproj",
"src/Ocelot.Provider.Consul/packages.lock.json",
"src/Ocelot.Provider.Eur... | [] | diff --git a/test/Ocelot.AcceptanceTests/Administration/AdministrationSteps.cs b/test/Ocelot.AcceptanceTests/Administration/AdministrationSteps.cs
index 077ff0dba..1882891ea 100644
--- a/test/Ocelot.AcceptanceTests/Administration/AdministrationSteps.cs
+++ b/test/Ocelot.AcceptanceTests/Administration/AdministrationStep... | true | |
TryGhost/Ghost | 28,588 | issue_to_patch | Switched to Knex for fake automations database schema | towards https://linear.app/ghost/issue/NY-1279
This dev-only change should have no user impact.
Before, we created tables with raw SQL. Now, we create them with Knex's schema builder.
I think this is a useful change on its own but it'll also make upcoming changes smaller.
| c15e7a19f254bc460b319b1de21c20944ec16b29 | bc00fbc8cff9ef0de782ec53ede51415ddd4898b | diff --git a/ghost/core/core/server/services/automations/temporary-fake-database.ts b/ghost/core/core/server/services/automations/temporary-fake-database.ts
index c6241802440..3c76b585ebc 100644
--- a/ghost/core/core/server/services/automations/temporary-fake-database.ts
+++ b/ghost/core/core/server/services/automation... | [
"ghost/core/core/server/services/automations/temporary-fake-database.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Preserve the previous SQLite `STRICT` behavior for these tables.**\n\nThe raw DDL used to create all six tables as `STRICT`, but the builder version drops that qualifier entirely. Because this temporary database is what the automations reposit... | true | ||
TryGhost/Ghost | 28,588 | comment_to_fix | Switched to Knex for fake automations database schema | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Preserve the previous SQLite `STRICT` behavior for these tables.**
The raw DDL used to create all six tables as `STRICT`, but the builder version drops that qualifier entirely. Because this temporary database is what the automations repository uses in testing/develo... | c15e7a19f254bc460b319b1de21c20944ec16b29 | bc00fbc8cff9ef0de782ec53ede51415ddd4898b | diff --git a/ghost/core/core/server/services/automations/temporary-fake-database.ts b/ghost/core/core/server/services/automations/temporary-fake-database.ts
index c6241802440..3c76b585ebc 100644
--- a/ghost/core/core/server/services/automations/temporary-fake-database.ts
+++ b/ghost/core/core/server/services/automation... | [
"ghost/core/core/server/services/automations/temporary-fake-database.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Preserve the previous SQLite `STRICT` behavior for these tables.**\n\nThe raw DDL used to create all six tables as `STRICT`, but the builder version drops that qualifier entirely. Because this temporary database is what the automations reposit... | true | ||
TryGhost/Ghost | 28,552 | issue_to_patch | Fixed flaky automations E2E test (another attempt) | closes https://linear.app/ghost/issue/NY-1341
ref 4250b43c67f8a95b62eb64bc68f9cbe52718088a
This test waits for `DomainEvents` to be flushed. But in this test, it flushed too early, which caused assertions to fail because automations polling wasn't finished.
This was because our helper, `oneAtATime`, returned imm... | 17429903f7eff6f2ce156c01334e0b9745a80f58 | 01663749e25da1a370d910f128dd0c84cdf186f3 | diff --git a/ghost/core/core/shared/one-at-a-time.ts b/ghost/core/core/shared/one-at-a-time.ts
index 58240364bb6..33d8007721c 100644
--- a/ghost/core/core/shared/one-at-a-time.ts
+++ b/ghost/core/core/shared/one-at-a-time.ts
@@ -1,7 +1,3 @@
-import {InternalServerError} from '@tryghost/errors';
-
-type State = 'idle' |... | [
"ghost/core/core/shared/one-at-a-time.ts",
"ghost/core/test/e2e-api/members/automations.test.js",
"ghost/core/test/unit/shared/one-at-a-time.test.js"
] | [] | diff --git a/ghost/core/test/e2e-api/members/automations.test.js b/ghost/core/test/e2e-api/members/automations.test.js
index b3f4cf34f43..b708954f1b1 100644
--- a/ghost/core/test/e2e-api/members/automations.test.js
+++ b/ghost/core/test/e2e-api/members/automations.test.js
@@ -135,8 +135,7 @@ describe('Members Automatio... | true | |
TryGhost/Ghost | 28,582 | issue_to_patch | Update github/gh-aw action to v0.79.4 | > ℹ️ **Note**
>
> This PR body was truncated due to platform limits.
This PR contains the following updates:
| Package | Type | Update | Change | Pending |
|---|---|---|---|---|
| [github/gh-aw](https://redirect.github.com/github/gh-aw) | action | minor | `v0.68.3` → `v0.79.4` | `v0.79.9` (+1) |
---
> [!WARNING]
>... | 1dc9dba04f560b708de76c3b06fde35288193b60 | cb73ce6ef14983db56db3cff90dac982f1392b37 | diff --git a/.github/workflows/copilot-setup-steps.yml b/.github/workflows/copilot-setup-steps.yml
index b67799bd486..88255a21d7b 100644
--- a/.github/workflows/copilot-setup-steps.yml
+++ b/.github/workflows/copilot-setup-steps.yml
@@ -21,6 +21,6 @@ jobs:
- name: Checkout repository
uses: actions/check... | [
".github/workflows/copilot-setup-steps.yml"
] | [] | true | ||
TryGhost/Ghost | 24,722 | issue_to_patch | 🐛 Fixed accent color styles disappearing in Admin design preview | When using the `{{ghost_head}}` helper with the exclude option (for example excluding `{{ghost_head exclude="comment_counts"}}`), the accent color style can disappear in the Admin Preview.
The issue occurs because the accent style is currently appended to the last style or script element in the head output. In the ... | 802268a631ef868d1080178d298f3989ca5568e6 | 16f6bce9b4cb13400f058927b25b0cc07f02168f | diff --git a/ghost/core/core/frontend/helpers/ghost_head.js b/ghost/core/core/frontend/helpers/ghost_head.js
index c2b272c4dc1..bfa55bc1721 100644
--- a/ghost/core/core/frontend/helpers/ghost_head.js
+++ b/ghost/core/core/frontend/helpers/ghost_head.js
@@ -125,7 +125,7 @@ function getAnnouncementBarHelper(data) {
... | [
"ghost/core/core/frontend/helpers/ghost_head.js",
"ghost/core/test/unit/frontend/helpers/__snapshots__/ghost-head.test.js.snap",
"ghost/core/test/unit/frontend/helpers/ghost-head.test.js"
] | [] | diff --git a/ghost/core/test/unit/frontend/helpers/__snapshots__/ghost-head.test.js.snap b/ghost/core/test/unit/frontend/helpers/__snapshots__/ghost-head.test.js.snap
index 66c80873177..cf42cb79eda 100644
--- a/ghost/core/test/unit/frontend/helpers/__snapshots__/ghost-head.test.js.snap
+++ b/ghost/core/test/unit/fronte... | true | |
TryGhost/Ghost | 28,576 | issue_to_patch | Update aws-sdk-js-v3 monorepo to v3.1066.0 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [@aws-sdk/client-s3](https://redirect.github.com/aws/aws-sdk-js-v3/tree/main/clients/client-s3) ([source](https://redir... | 697dc2c3bb924e1f997adc73436d25562fcfd27f | f41fb74b960d9b4b7b4b09937ba47fcb3cf7091e | diff --git a/ghost/core/package.json b/ghost/core/package.json
index b874e8de693..f79703f3a29 100644
--- a/ghost/core/package.json
+++ b/ghost/core/package.json
@@ -84,7 +84,7 @@
"cli": "^1.29.1"
},
"dependencies": {
- "@aws-sdk/client-s3": "3.1065.0",
+ "@aws-sdk/client-s3": "3.1066.0",
"@extract... | [
"ghost/core/package.json",
"pnpm-lock.yaml"
] | [] | true | ||
TryGhost/Ghost | 20,452 | issue_to_patch | 🐛 Fixed how Bookmark, Video and Audio cards look in RSS readers | Fixes Bookmark, Video and Audio cards when viewed within an RSS reader, by adjusting what markup is rendered in the RSS feed.
Addresses issues shared in the following forum topics:
- https://forum.ghost.org/t/bookmarks-feature-and-rss-issues/13479
- https://forum.ghost.org/t/bookmarks-render-horribly-in-rss-feed-r... | 73d255d1e45910651d18b698e6a5734945c5c84e | fae562da2d88e2651a57163dc5e306cc8dcf7947 | diff --git a/ghost/core/core/frontend/services/rss/generate-feed.js b/ghost/core/core/frontend/services/rss/generate-feed.js
index e90bfc48165..70c006511f9 100644
--- a/ghost/core/core/frontend/services/rss/generate-feed.js
+++ b/ghost/core/core/frontend/services/rss/generate-feed.js
@@ -24,6 +24,34 @@ const generateIt... | [
"ghost/core/core/frontend/services/rss/generate-feed.js",
"ghost/core/test/unit/frontend/services/rss/generate-feed.test.js"
] | [
{
"comment": "_⚠️ Potential issue_\n\n**Handle missing video poster attributes safely.**\n\nThe code sets the `poster` attribute even when both data attributes are falsy, which could result in `poster=\"undefined\"` or `poster=\"null\"` in the HTML output.\n\n\n\nApply this fix to handle missing poster attribut... | diff --git a/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js b/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js
index 4edcc6277f5..71300f51e23 100644
--- a/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js
+++ b/ghost/core/test/unit/frontend/services/rss/generate-feed.tes... | true | |
TryGhost/Ghost | 20,452 | comment_to_fix | 🐛 Fixed how Bookmark, Video and Audio cards look in RSS readers | _⚠️ Potential issue_
**Handle missing video poster attributes safely.**
The code sets the `poster` attribute even when both data attributes are falsy, which could result in `poster="undefined"` or `poster="null"` in the HTML output.
Apply this fix to handle missing poster attributes:
```diff
- // Video card
- ... | 73d255d1e45910651d18b698e6a5734945c5c84e | fae562da2d88e2651a57163dc5e306cc8dcf7947 | diff --git a/ghost/core/core/frontend/services/rss/generate-feed.js b/ghost/core/core/frontend/services/rss/generate-feed.js
index e90bfc48165..70c006511f9 100644
--- a/ghost/core/core/frontend/services/rss/generate-feed.js
+++ b/ghost/core/core/frontend/services/rss/generate-feed.js
@@ -24,6 +24,34 @@ const generateIt... | [
"ghost/core/core/frontend/services/rss/generate-feed.js"
] | [
{
"comment": "_⚠️ Potential issue_\n\n**Handle missing video poster attributes safely.**\n\nThe code sets the `poster` attribute even when both data attributes are falsy, which could result in `poster=\"undefined\"` or `poster=\"null\"` in the HTML output.\n\n\n\nApply this fix to handle missing poster attribut... | true | ||
TryGhost/Ghost | 20,452 | comment_to_fix | 🐛 Fixed how Bookmark, Video and Audio cards look in RSS readers | _⚠️ Potential issue_
**Fix missing semicolon after describe block.**
The describe block is missing a semicolon at the end.
Apply this diff to fix the syntax error:
```diff
- }
+ });
```
<!-- suggestion_start -->
<details>
<summary>📝 Committable suggestion</summary>
> ‼️ **IMPORTANT**
> Carefully review th... | 73d255d1e45910651d18b698e6a5734945c5c84e | fae562da2d88e2651a57163dc5e306cc8dcf7947 | diff --git a/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js b/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js
index 4edcc6277f5..71300f51e23 100644
--- a/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js
+++ b/ghost/core/test/unit/frontend/services/rss/generate-feed.tes... | [
"ghost/core/test/unit/frontend/services/rss/generate-feed.test.js"
] | [
{
"comment": "_⚠️ Potential issue_\n\n**Fix missing semicolon after describe block.**\n\nThe describe block is missing a semicolon at the end.\n\nApply this diff to fix the syntax error:\n\n```diff\n- }\n+ });\n```\n\n<!-- suggestion_start -->\n\n<details>\n<summary>📝 Committable suggestion</summary>\n\n... | true | ||
TryGhost/Ghost | 20,452 | comment_to_fix | 🐛 Fixed how Bookmark, Video and Audio cards look in RSS readers | _⚠️ Potential issue_
**Fix syntax error: Missing comma after describe block name.**
There's a missing comma after the describe block name, causing a syntax error.
Apply this diff to fix the syntax error:
```diff
- describe("Card reformatting"), function () {
+ describe('Card reformatting', function () {
```
... | 73d255d1e45910651d18b698e6a5734945c5c84e | fae562da2d88e2651a57163dc5e306cc8dcf7947 | diff --git a/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js b/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js
index 4edcc6277f5..71300f51e23 100644
--- a/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js
+++ b/ghost/core/test/unit/frontend/services/rss/generate-feed.tes... | [
"ghost/core/test/unit/frontend/services/rss/generate-feed.test.js"
] | [
{
"comment": "_⚠️ Potential issue_\n\n**Fix syntax error: Missing comma after describe block name.**\n\nThere's a missing comma after the describe block name, causing a syntax error.\n\nApply this diff to fix the syntax error:\n\n```diff\n- describe(\"Card reformatting\"), function () {\n+ describe('Card ... | true | ||
TryGhost/Ghost | 20,452 | comment_to_fix | 🐛 Fixed how Bookmark, Video and Audio cards look in RSS readers | _⚠️ Potential issue_
**Fix multiple syntax and logic errors in video card test.**
This test has several critical issues:
1. Missing comma after the test name
2. Incorrect quote style (should use single quotes)
3. Incorrect assertion method and wrong CSS class check
4. Missing data setup for `data.posts`
5. Missing s... | 73d255d1e45910651d18b698e6a5734945c5c84e | fae562da2d88e2651a57163dc5e306cc8dcf7947 | diff --git a/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js b/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js
index 4edcc6277f5..71300f51e23 100644
--- a/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js
+++ b/ghost/core/test/unit/frontend/services/rss/generate-feed.tes... | [
"ghost/core/test/unit/frontend/services/rss/generate-feed.test.js"
] | [
{
"comment": "_⚠️ Potential issue_\n\n**Fix multiple syntax and logic errors in video card test.**\n\nThis test has several critical issues:\n\n1. Missing comma after the test name\n2. Incorrect quote style (should use single quotes)\n3. Incorrect assertion method and wrong CSS class check\n4. Missing data setu... | true | ||
TryGhost/Ghost | 20,452 | comment_to_fix | 🐛 Fixed how Bookmark, Video and Audio cards look in RSS readers | _⚠️ Potential issue_
**Fix multiple syntax and logic errors in bookmark card test.**
This test has several critical issues:
1. Missing comma after the test name
2. Incorrect quote style (should use single quotes)
3. Incorrect assertion method - `should.not.exist()` checks for undefined values, not string content
4. ... | 73d255d1e45910651d18b698e6a5734945c5c84e | fae562da2d88e2651a57163dc5e306cc8dcf7947 | diff --git a/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js b/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js
index 4edcc6277f5..71300f51e23 100644
--- a/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js
+++ b/ghost/core/test/unit/frontend/services/rss/generate-feed.tes... | [
"ghost/core/test/unit/frontend/services/rss/generate-feed.test.js"
] | [
{
"comment": "_⚠️ Potential issue_\n\n**Fix multiple syntax and logic errors in bookmark card test.**\n\nThis test has several critical issues:\n\n1. Missing comma after the test name\n2. Incorrect quote style (should use single quotes)\n3. Incorrect assertion method - `should.not.exist()` checks for undefined ... | true | ||
TryGhost/Ghost | 20,452 | comment_to_fix | 🐛 Fixed how Bookmark, Video and Audio cards look in RSS readers | _⚠️ Potential issue_
**Fix multiple syntax and logic errors in audio card test.**
This test has several critical issues:
1. Missing comma after the test name
2. Incorrect quote style (should use single quotes)
3. Incorrect assertion method
4. Missing data setup for `data.posts`
5. Missing semicolon after function cl... | 73d255d1e45910651d18b698e6a5734945c5c84e | fae562da2d88e2651a57163dc5e306cc8dcf7947 | diff --git a/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js b/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js
index 4edcc6277f5..71300f51e23 100644
--- a/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js
+++ b/ghost/core/test/unit/frontend/services/rss/generate-feed.tes... | [
"ghost/core/test/unit/frontend/services/rss/generate-feed.test.js"
] | [
{
"comment": "_⚠️ Potential issue_\n\n**Fix multiple syntax and logic errors in audio card test.**\n\nThis test has several critical issues:\n\n1. Missing comma after the test name\n2. Incorrect quote style (should use single quotes)\n3. Incorrect assertion method\n4. Missing data setup for `data.posts`\n5. Mis... | true | ||
TryGhost/Ghost | 20,452 | comment_to_fix | 🐛 Fixed how Bookmark, Video and Audio cards look in RSS readers | _⚠️ Potential issue_
**Fix missing semicolon after the `before` function.**
The `before` function block is missing a semicolon at the end.
```diff
- })
+ });
```
<!-- suggestion_start -->
<details>
<summary>📝 Committable suggestion</summary>
> ‼️ **IMPORTANT**
> Carefully review the code before com... | 73d255d1e45910651d18b698e6a5734945c5c84e | fae562da2d88e2651a57163dc5e306cc8dcf7947 | diff --git a/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js b/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js
index 4edcc6277f5..71300f51e23 100644
--- a/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js
+++ b/ghost/core/test/unit/frontend/services/rss/generate-feed.tes... | [
"ghost/core/test/unit/frontend/services/rss/generate-feed.test.js"
] | [
{
"comment": "_⚠️ Potential issue_\n\n**Fix missing semicolon after the `before` function.**\n\nThe `before` function block is missing a semicolon at the end.\n\n```diff\n- })\n+ });\n```\n\n<!-- suggestion_start -->\n\n<details>\n<summary>📝 Committable suggestion</summary>\n\n> ‼️ **IMPORTANT**\... | true | ||
TryGhost/Ghost | 20,452 | comment_to_fix | 🐛 Fixed how Bookmark, Video and Audio cards look in RSS readers | _⚠️ Potential issue_
**Fix missing semicolons after assertions.**
Multiple assertion statements are missing semicolons.
```diff
- data.posts[2].html.html.should.match(/kg-audio-thumbnail/)
- data.posts[2].html.html.should.match(/kg-audio-player/)
- data.posts[2].html.html.should.matc... | 73d255d1e45910651d18b698e6a5734945c5c84e | fae562da2d88e2651a57163dc5e306cc8dcf7947 | diff --git a/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js b/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js
index 4edcc6277f5..71300f51e23 100644
--- a/ghost/core/test/unit/frontend/services/rss/generate-feed.test.js
+++ b/ghost/core/test/unit/frontend/services/rss/generate-feed.tes... | [
"ghost/core/test/unit/frontend/services/rss/generate-feed.test.js"
] | [
{
"comment": "_⚠️ Potential issue_\n\n**Fix missing semicolons after assertions.**\n\nMultiple assertion statements are missing semicolons.\n\n```diff\n- data.posts[2].html.html.should.match(/kg-audio-thumbnail/)\n- data.posts[2].html.html.should.match(/kg-audio-player/)\n- data... | true | ||
TryGhost/Ghost | 28,574 | issue_to_patch | Update dependency sanitize-html to v2.17.5 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [sanitize-html](https://redirect.github.com/apostrophecms/apostrophe/tree/main/packages/sanitize-html#readme) ([source]... | 73d255d1e45910651d18b698e6a5734945c5c84e | ed8d908e9c474cf429f7f7840c81b713a99a1a5f | diff --git a/ghost/core/package.json b/ghost/core/package.json
index 3f7edc86d59..8a6b33d5b5c 100644
--- a/ghost/core/package.json
+++ b/ghost/core/package.json
@@ -231,7 +231,7 @@
"probability-distributions": "0.9.1",
"probe-image-size": "7.3.0",
"rss": "1.2.2",
- "sanitize-html": "2.17.4",
+ "san... | [
"ghost/core/package.json",
"pnpm-lock.yaml"
] | [] | true | ||
TryGhost/Ghost | 28,573 | issue_to_patch | Update dependency file-type to v21.3.2 [SECURITY] | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [file-type](https://redirect.github.com/sindresorhus/file-type) | [`21.3.1` → `21.3.2`](https://renovatebot.com/diffs/n... | 73d255d1e45910651d18b698e6a5734945c5c84e | 76b901a061efbb0b7b92c4684646d4f8ff826620 | diff --git a/ghost/core/package.json b/ghost/core/package.json
index 3f7edc86d59..7bd2a644f0a 100644
--- a/ghost/core/package.json
+++ b/ghost/core/package.json
@@ -175,7 +175,7 @@
"express-query-boolean": "2.0.0",
"express-queue": "0.0.13",
"express-session": "1.19.0",
- "file-type": "21.3.1",
+ "... | [
"ghost/core/package.json",
"pnpm-lock.yaml",
"pnpm-workspace.yaml"
] | [] | true | ||
TryGhost/Ghost | 28,569 | issue_to_patch | Update dependency semver to v7.8.4 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [semver](https://redirect.github.com/npm/node-semver) | [`7.7.4` → `7.8.4`](https://renovatebot.com/diffs/npm/semver/7.... | f210c997ba6a07e44a0cbd60e79c0b7c79285149 | 6f925053e5727898901f8fed08512c7c08d66c7f | diff --git a/ghost/core/package.json b/ghost/core/package.json
index 165f3e43929..3f7edc86d59 100644
--- a/ghost/core/package.json
+++ b/ghost/core/package.json
@@ -232,7 +232,7 @@
"probe-image-size": "7.3.0",
"rss": "1.2.2",
"sanitize-html": "2.17.4",
- "semver": "7.7.4",
+ "semver": "7.8.4",
... | [
"ghost/core/package.json",
"package.json",
"pnpm-lock.yaml"
] | [] | true | ||
TryGhost/Ghost | 28,565 | issue_to_patch | Update dependency dompurify to v3.4.9 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [dompurify](https://redirect.github.com/cure53/DOMPurify) | [`3.4.8` → `3.4.9`](https://renovatebot.com/diffs/npm/dompu... | a22a2ff324b32048f60fcefd6e2f63afdb799f4e | d4d2dd0bc87cc7b42cac88bf8f450f601548236c | diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 3c6ee31e10d..afde21649fd 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -175,8 +175,8 @@ catalogs:
specifier: 2.0.3
version: 2.0.3
dompurify:
- specifier: 3.4.8
- version: 3.4.8
+ specifier: 3.4.9
+ version: 3.4.9
dotenv... | [
"pnpm-lock.yaml",
"pnpm-workspace.yaml"
] | [] | true | ||
TryGhost/Ghost | 28,533 | issue_to_patch | Update TryGhost runtime packages | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [@tryghost/adapter-base-cache](https://redirect.github.com/TryGhost/SDK) ([source](https://redirect.github.com/TryGhost... | a22a2ff324b32048f60fcefd6e2f63afdb799f4e | c260c9e2b419c8ef455710a517d2820813d46477 | diff --git a/ghost/core/package.json b/ghost/core/package.json
index 9e8dbba4f77..165f3e43929 100644
--- a/ghost/core/package.json
+++ b/ghost/core/package.json
@@ -90,8 +90,8 @@
"@isaacs/ttlcache": "1.4.1",
"@sentry/node": "7.120.4",
"@slack/webhook": "7.0.9",
- "@tryghost/adapter-base-cache": "0.1.2... | [
"ghost/core/package.json",
"pnpm-lock.yaml",
"pnpm-workspace.yaml"
] | [] | true | ||
TryGhost/Ghost | 24,511 | issue_to_patch | Fix: Layout and alignment inconsistencies in mobile/tablet views | This PR resolves several mobile UI issues outlined in [#24509](https://github.com/TryGhost/Ghost/issues/24509), improving alignment, spacing, and layout responsiveness across key settings views.
### 1. Signup embed modal layout is squished on mobile
In /settings, the Embed signup form modal previously used a two-... | b6375e528bc9a8890bca66eb30117bfc5fe7cb7c | f22e7492becba0f4f27c9ae437f972541263128d | diff --git a/apps/admin-x-settings/src/components/settings/growth/embed-signup/embed-signup-form-modal.tsx b/apps/admin-x-settings/src/components/settings/growth/embed-signup/embed-signup-form-modal.tsx
index ab404b73c29..8b446f599f3 100644
--- a/apps/admin-x-settings/src/components/settings/growth/embed-signup/embed-s... | [
"apps/admin-x-settings/src/components/settings/growth/embed-signup/embed-signup-form-modal.tsx",
"apps/admin-x-settings/src/components/settings/growth/embed-signup/embed-signup-preview.tsx",
"apps/admin-x-settings/src/components/settings/growth/embed-signup/embed-signup-sidebar.tsx",
"apps/admin-x-settings/sr... | [] | true | ||
TryGhost/Ghost | 28,546 | issue_to_patch | Importer failures are silent
### Issue Summary
I'm importing huge lists of authors into Ghost, by uploading a json file (or a zip containing a json file, depending on the day). Unfortunately, if an email address fails validation, the export fails silently, with no useful error either on the console or in the error e... | Fix silent importer failures by surfacing validation errors | ## Summary
When importing content with invalid data (e.g. invalid email addresses, too-long author bios), errors were rejected as arrays instead of proper Error objects. This caused Node.js to emit only a generic warning:
```
(node:916) Warning: a promise was rejected with a non-error: [object Array]
```
No useful i... | de4671eb0ecccf6394a5d3c12f89307997bc1610 | 140c97af9b52f7f9f66f0d0bf561728913426046 | diff --git a/ghost/core/core/server/data/importer/email-template.ts b/ghost/core/core/server/data/importer/email-template.ts
index aed0072e2de..d7068e55753 100644
--- a/ghost/core/core/server/data/importer/email-template.ts
+++ b/ghost/core/core/server/data/importer/email-template.ts
@@ -11,7 +11,39 @@ type EmailTempla... | [
"ghost/core/core/server/data/importer/email-template.ts",
"ghost/core/core/server/data/importer/import-manager.js",
"ghost/core/core/server/data/importer/importers/data/data-importer.js",
"ghost/core/test/integration/importer/v2.test.js",
"ghost/core/test/unit/server/data/importer/email-template.test.ts",
... | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Escape error text before interpolating into HTML email.**\n\nLine 145 injects `e.message`/`toString()` directly into HTML. Validation errors can carry user-controlled content from import files, so this should be HTML-escaped before rendering.\... | diff --git a/ghost/core/test/integration/importer/v2.test.js b/ghost/core/test/integration/importer/v2.test.js
index aa84235a90f..b0b32137674 100644
--- a/ghost/core/test/integration/importer/v2.test.js
+++ b/ghost/core/test/integration/importer/v2.test.js
@@ -6,6 +6,7 @@ const assert = require('node:assert/strict');
... | true |
TryGhost/Ghost | 28,546 | comment_to_fix | Fix silent importer failures by surfacing validation errors | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Escape error text before interpolating into HTML email.**
Line 145 injects `e.message`/`toString()` directly into HTML. Validation errors can carry user-controlled content from import files, so this should be HTML-escaped before rendering.
<details>
<summary>Sugges... | de4671eb0ecccf6394a5d3c12f89307997bc1610 | 140c97af9b52f7f9f66f0d0bf561728913426046 | diff --git a/ghost/core/core/server/data/importer/email-template.ts b/ghost/core/core/server/data/importer/email-template.ts
index aed0072e2de..d7068e55753 100644
--- a/ghost/core/core/server/data/importer/email-template.ts
+++ b/ghost/core/core/server/data/importer/email-template.ts
@@ -11,7 +11,39 @@ type EmailTempla... | [
"ghost/core/core/server/data/importer/email-template.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Escape error text before interpolating into HTML email.**\n\nLine 145 injects `e.message`/`toString()` directly into HTML. Validation errors can carry user-controlled content from import files, so this should be HTML-escaped before rendering.\... | true | ||
TryGhost/Ghost | 28,546 | comment_to_fix | Fix silent importer failures by surfacing validation errors | _⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_
**`errors.DataImportError` is resolving to the local array, not the error class.**
At Line 192, `errors` is the local `let errors = []` (Line 81), so `new errors.DataImportError(...)` throws a `TypeError` and prevents the intended import error from being surfaced.
... | de4671eb0ecccf6394a5d3c12f89307997bc1610 | 140c97af9b52f7f9f66f0d0bf561728913426046 | diff --git a/ghost/core/core/server/data/importer/importers/data/data-importer.js b/ghost/core/core/server/data/importer/importers/data/data-importer.js
index bcc91500ff2..9edc3b112f1 100644
--- a/ghost/core/core/server/data/importer/importers/data/data-importer.js
+++ b/ghost/core/core/server/data/importer/importers/d... | [
"ghost/core/core/server/data/importer/importers/data/data-importer.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_\n\n**`errors.DataImportError` is resolving to the local array, not the error class.**\n\nAt Line 192, `errors` is the local `let errors = []` (Line 81), so `new errors.DataImportError(...)` throws a `TypeError` and prevents the intended import e... | true | ||
TryGhost/Ghost | 28,532 | issue_to_patch | Update TryGhost packages | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [@tryghost/image-transform](https://redirect.github.com/TryGhost/SDK) ([source](https://redirect.github.com/TryGhost/SD... | a4f00a5316bbf4eea70ce01bbc726537f0ffdd2d | 0d242d03097b5c36f8de53328a438d482602b87c | diff --git a/ghost/core/package.json b/ghost/core/package.json
index 3f5fa244004..d2ad050bb64 100644
--- a/ghost/core/package.json
+++ b/ghost/core/package.json
@@ -105,7 +105,7 @@
"@tryghost/helpers": "catalog:",
"@tryghost/html-to-plaintext": "1.0.11",
"@tryghost/i18n": "workspace:*",
- "@tryghost/i... | [
"ghost/core/package.json",
"pnpm-lock.yaml"
] | [] | true | ||
TryGhost/Ghost | 28,571 | issue_to_patch | Update dependency terser to v5.48.0 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [terser](https://terser.org) ([source](https://redirect.github.com/terser/terser)) | [`5.46.1` → `5.48.0`](https://reno... | a4f00a5316bbf4eea70ce01bbc726537f0ffdd2d | 52cac1f5a323275c5ac55ef7117fd4959cc4f101 | diff --git a/ghost/core/package.json b/ghost/core/package.json
index 3f5fa244004..a27888fbb69 100644
--- a/ghost/core/package.json
+++ b/ghost/core/package.json
@@ -239,7 +239,7 @@
"stripe": "8.222.0",
"superagent": "5.3.1",
"superagent-throttle": "1.0.1",
- "terser": "5.46.1",
+ "terser": "5.48.0"... | [
"ghost/core/package.json",
"pnpm-lock.yaml"
] | [] | true | ||
TryGhost/Ghost | 28,570 | issue_to_patch | Update dependency tailwind-merge to v3.6.0 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [tailwind-merge](https://redirect.github.com/dcastil/tailwind-merge) | [`3.5.0` → `3.6.0`](https://renovatebot.com/diff... | a4f00a5316bbf4eea70ce01bbc726537f0ffdd2d | e776d088a85f629b7c2c3ce73b21cd035cef49cf | diff --git a/apps/shade/package.json b/apps/shade/package.json
index b63ff05bc21..f733be92158 100644
--- a/apps/shade/package.json
+++ b/apps/shade/package.json
@@ -152,7 +152,7 @@
"react-world-flags": "1.6.0",
"recharts": "2.15.4",
"sonner": "catalog:",
- "tailwind-merge": "3.5.0",
+ ... | [
"apps/shade/package.json",
"pnpm-lock.yaml"
] | [] | true | ||
TryGhost/Ghost | 28,269 | issue_to_patch | Update dependency file-type to v21 [SECURITY] | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [file-type](https://redirect.github.com/sindresorhus/file-type) | [`16.5.4` → `21.3.1`](https://renovatebot.com/diffs/n... | a4f00a5316bbf4eea70ce01bbc726537f0ffdd2d | 0a72739fecf58039579e5fd15c1f2a9c287477eb | diff --git a/ghost/core/core/server/services/media-inliner/external-media-inliner.js b/ghost/core/core/server/services/media-inliner/external-media-inliner.js
index db44850a9b1..a63dd1020ed 100644
--- a/ghost/core/core/server/services/media-inliner/external-media-inliner.js
+++ b/ghost/core/core/server/services/media-i... | [
"ghost/core/core/server/services/media-inliner/external-media-inliner.js",
"ghost/core/package.json",
"pnpm-lock.yaml",
"pnpm-workspace.yaml"
] | [] | true | ||
TryGhost/Ghost | 25,502 | issue_to_patch | Accessibility: tab navigation broken for collapsed sidebar
### Issue Summary
The collapsible sidebar (which I think is fairly new) appears to be inaccessible to tab navigation when collapsed. If it becomes collapsed somehow, it does not appear to be possible to get it open again (at which point tabbing works) withou... | 🧭 Fix collapsed sidebar keyboard navigation accessibility (#25054) | ### Why
The sidebar toggle and several sidebar controls weren't fully keyboard accessible (#25054):
- The toggle button exposed no state to assistive tech (no `aria-expanded` / `aria-controls`).
- The "view site" link and the hover-revealed compose/quick-action icons only appeared on mouse hover, so keyboard focus la... | 7164ec1611011e47fca70f6c92e4c854ba96fcbb | 633a01cad2443e47c23b3dea0c17878a4eec8d0f | diff --git a/apps/admin/src/layout/app-sidebar/app-sidebar-content.tsx b/apps/admin/src/layout/app-sidebar/app-sidebar-content.tsx
index ecaefb64837..07198a5a402 100644
--- a/apps/admin/src/layout/app-sidebar/app-sidebar-content.tsx
+++ b/apps/admin/src/layout/app-sidebar/app-sidebar-content.tsx
@@ -20,7 +20,7 @@ funct... | [
"apps/admin/src/layout/app-sidebar/app-sidebar-content.tsx",
"apps/admin/src/layout/app-sidebar/nav-content.tsx",
"apps/admin/src/layout/app-sidebar/nav-main.tsx",
"apps/admin/src/layout/app-sidebar/user-menu.tsx",
"apps/shade/src/components/ui/sidebar.tsx",
"apps/shade/test/unit/components/ui/sidebar.tes... | [
{
"comment": "### Bug: Sidebar toggle button invisible after keyboard expansion\n\n<!-- **High Severity** -->\n\n<!-- DESCRIPTION START -->\nThe toggle button container `.gh-toggle-nav-menu` reverts to `opacity: 0` when the sidebar is expanded (removing `.gh-nav-hidden`) via keyboard. This leaves focus on an in... | diff --git a/apps/shade/test/unit/components/ui/sidebar.test.tsx b/apps/shade/test/unit/components/ui/sidebar.test.tsx
new file mode 100644
index 00000000000..a723626300a
--- /dev/null
+++ b/apps/shade/test/unit/components/ui/sidebar.test.tsx
@@ -0,0 +1,70 @@
+import assert from 'assert/strict';
+import {beforeAll, des... | true |
TryGhost/Ghost | 28,566 | issue_to_patch | Update dependency react-hook-form to v7.78.0 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [react-hook-form](https://react-hook-form.com) ([source](https://redirect.github.com/react-hook-form/react-hook-form)) ... | 802268a631ef868d1080178d298f3989ca5568e6 | 9fd1e4bd463ca7fefe405cce0ba5748388a8c611 | diff --git a/apps/activitypub/package.json b/apps/activitypub/package.json
index 21c5e911fa1..df58781804d 100644
--- a/apps/activitypub/package.json
+++ b/apps/activitypub/package.json
@@ -91,7 +91,7 @@
"html2canvas-objectfit-fix": "1.2.0",
"react": "catalog:",
"react-dom": "catalog:",
- "react-hook-f... | [
"apps/activitypub/package.json",
"apps/shade/package.json",
"pnpm-lock.yaml"
] | [] | true | ||
TryGhost/Ghost | 28,567 | issue_to_patch | Update nodemailer to v8.0.11 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [nodemailer](https://nodemailer.com/) ([source](https://redirect.github.com/nodemailer/nodemailer)) | [`8.0.10` → `8.0.... | 802268a631ef868d1080178d298f3989ca5568e6 | 503fb36ed216573179ccbac4f3117aadcd82eedc | diff --git a/ghost/core/package.json b/ghost/core/package.json
index 3f4835e9f74..3f5fa244004 100644
--- a/ghost/core/package.json
+++ b/ghost/core/package.json
@@ -223,7 +223,7 @@
"node-fetch": "2.7.0",
"node-html-markdown": "catalog:",
"node-jose": "2.2.0",
- "nodemailer": "8.0.10",
+ "nodemailer... | [
"ghost/core/package.json",
"pnpm-lock.yaml"
] | [] | true | ||
TryGhost/Ghost | 28,535 | issue_to_patch | Update vitest monorepo to v4.1.8 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [@vitest/coverage-v8](https://vitest.dev/guide/coverage) ([source](https://redirect.github.com/vitest-dev/vitest/tree/H... | 802268a631ef868d1080178d298f3989ca5568e6 | 53a165383dade18f9a3c3d91a833293bc3b440bf | diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index ad1adb2899c..2609b22e3ea 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -148,8 +148,8 @@ catalogs:
specifier: 4.7.0
version: 4.7.0
'@vitest/coverage-v8':
- specifier: 4.1.7
- version: 4.1.7
+ specifier: 4.1.8
+ version: 4.1.8... | [
"pnpm-lock.yaml",
"pnpm-workspace.yaml"
] | [] | true | ||
TryGhost/Ghost | 28,534 | issue_to_patch | Update Types packages to v22.19.20 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [@types/node](https://redirect.github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://red... | cab523ed9ab4e0df2fc7b98d05716282af5cff38 | ff7b7124395280e23f475de1b28e9b5fd6d9319e | diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index ff2179f9aa0..ad1adb2899c 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -124,8 +124,8 @@ catalogs:
specifier: 29.5.14
version: 29.5.14
'@types/node':
- specifier: 22.19.19
- version: 22.19.19
+ specifier: 22.19.20
+ version: ... | [
"pnpm-lock.yaml",
"pnpm-workspace.yaml"
] | [] | true | ||
TryGhost/Ghost | 25,671 | issue_to_patch | Fixed brittle `scrollToTop` functions in Stats and PostAnalytics | ref https://linear.app/ghost/issue/BER-2999/
ref https://github.com/TryGhost/Ghost/pull/25583
ref https://github.com/TryGhost/Ghost/pull/25501
## Problem
- the [recently introduced](https://github.com/TryGhost/Ghost/pull/25583) `scrollToTop` functions use a brittle approach of assuming the first element found with an ... | 870e51098ba1d821fa97d7bae0302b38eb8da870 | 9883316c4d49ebd24d462060699bc71db00e3055 | diff --git a/apps/posts/src/components/virtual-table/get-scroll-parent.tsx b/apps/posts/src/components/virtual-table/get-scroll-parent.tsx
deleted file mode 100644
index 2efaaf57c22..00000000000
--- a/apps/posts/src/components/virtual-table/get-scroll-parent.tsx
+++ /dev/null
@@ -1,14 +0,0 @@
-export function getScroll... | [
"apps/posts/src/components/virtual-table/get-scroll-parent.tsx",
"apps/posts/src/components/virtual-table/use-infinite-virtual-scroll.tsx",
"apps/posts/src/components/virtual-table/use-scroll-restoration.tsx",
"apps/posts/src/views/PostAnalytics/Web/web.tsx",
"apps/posts/src/views/PostAnalytics/components/p... | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Fix non-element scrollability detection in `getScrollParent`.**\n\nOn Line 43, `isScrollable` can evaluate to `true` for non-`HTMLElement` nodes (`false !== 'visible' && false !== 'hidden'`), which then flows into the cast/check at Line 48.\n\... | true | ||
TryGhost/Ghost | 25,671 | comment_to_fix | Fixed brittle `scrollToTop` functions in Stats and PostAnalytics | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Fix non-element scrollability detection in `getScrollParent`.**
On Line 43, `isScrollable` can evaluate to `true` for non-`HTMLElement` nodes (`false !== 'visible' && false !== 'hidden'`), which then flows into the cast/check at Line 48.
<details>
<summary>Proposed... | 870e51098ba1d821fa97d7bae0302b38eb8da870 | 9883316c4d49ebd24d462060699bc71db00e3055 | diff --git a/apps/shade/src/lib/ds-utils.ts b/apps/shade/src/lib/ds-utils.ts
index 31929d7a6ed..9723f1911ba 100644
--- a/apps/shade/src/lib/ds-utils.ts
+++ b/apps/shade/src/lib/ds-utils.ts
@@ -36,6 +36,24 @@ export function debounce<T extends unknown[]>(func: (...args: T) => void, wait:
};
}
+// Helper to find ... | [
"apps/shade/src/lib/ds-utils.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Fix non-element scrollability detection in `getScrollParent`.**\n\nOn Line 43, `isScrollable` can evaluate to `true` for non-`HTMLElement` nodes (`false !== 'visible' && false !== 'hidden'`), which then flows into the cast/check at Line 48.\n\... | true | ||
TryGhost/Ghost | 25,975 | issue_to_patch | Accessibility Violation: Incorrect autocomplete token for email input field
### Issue Summary
The "Welcome to Ghost" [Admin page](http://localhost:2368/ghost/) contains an accessibility violation where the `autocomplete` attribute for the email input field uses an inappropriate token. According to WCAG Success Criter... | Fix Accessibility Violation: Incorrect autocomplete token in Setup Form | ## Description
This PR addresses an accessibility violation (#25974) on the setup page where the email input field used conflicting autocomplete tokens (`username email`).
According to **WCAG Success Criterion 1.3.5 (Identify Input Purpose)**, the autocomplete attribute must clearly and singularly define the purpos... | 4bfa4a8e9e6bf267fe94b0ce2085efca5f5a2642 | da6d43e7ef59f53eea4ffcfe0b70b781eb2f3530 | diff --git a/ghost/admin/app/templates/setup.hbs b/ghost/admin/app/templates/setup.hbs
index db40583602a..e5d8fbaea1a 100644
--- a/ghost/admin/app/templates/setup.hbs
+++ b/ghost/admin/app/templates/setup.hbs
@@ -50,7 +50,7 @@
@name="email"
@placeholder="jamie@example.c... | [
"ghost/admin/app/templates/setup.hbs",
"ghost/admin/app/templates/signup.hbs"
] | [] | true | |
TryGhost/Ghost | 28,564 | issue_to_patch | Update TryGhost content and email packages to v2.2.4 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [@tryghost/nodemailer](https://redirect.github.com/TryGhost/framework) ([source](https://redirect.github.com/TryGhost/f... | 6d0745b850fc58f885b116386d40276a33fe4d0d | 02d682a72070c1e7f1ac1b467d4d41e6fb02fd72 | diff --git a/ghost/core/package.json b/ghost/core/package.json
index 5177a686a1e..3f4835e9f74 100644
--- a/ghost/core/package.json
+++ b/ghost/core/package.json
@@ -124,7 +124,7 @@
"@tryghost/mongo-utils": "0.6.3",
"@tryghost/mw-error-handler": "1.0.13",
"@tryghost/mw-vhost": "1.0.6",
- "@tryghost/nod... | [
"ghost/core/package.json",
"pnpm-lock.yaml"
] | [] | true | ||
TryGhost/Ghost | 28,544 | issue_to_patch | Update dependency react-dropzone to v14.4.1 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [react-dropzone](https://redirect.github.com/react-dropzone/react-dropzone) | [`14.2.3` → `14.4.1`](https://renovatebot... | 6d0745b850fc58f885b116386d40276a33fe4d0d | cd9d38f2e2d2471cc8b630ff32a8ddca3c48e4af | diff --git a/apps/shade/package.json b/apps/shade/package.json
index 5108b5de247..78762db39df 100644
--- a/apps/shade/package.json
+++ b/apps/shade/package.json
@@ -147,7 +147,7 @@
"react": "catalog:",
"react-day-picker": "9.14.0",
"react-dom": "catalog:",
- "react-dropzone": "14.2.3",... | [
"apps/shade/package.json",
"pnpm-lock.yaml"
] | [] | true | ||
TryGhost/Ghost | 25,585 | issue_to_patch | Fixed Bluebird promise warnings when saving models | no issue
## Problem
Saving settings (e.g. labs flags) and other models logged this Bluebird warning:
```
Warning: a promise was created in a Promise.each handler at node_modules/bookshelf/lib/base/events.js:101:64 but was not returned from it
```
The model lifecycle hooks (`onCreated`/`onUpdated`/`onDestroyed`) and... | 6d0745b850fc58f885b116386d40276a33fe4d0d | 89f6ca3d02dc2f92120a2bfe9d2fdbd742db1114 | diff --git a/ghost/core/core/server/models/base/plugins/actions.js b/ghost/core/core/server/models/base/plugins/actions.js
index bd28e35f718..73504fb7fdd 100644
--- a/ghost/core/core/server/models/base/plugins/actions.js
+++ b/ghost/core/core/server/models/base/plugins/actions.js
@@ -24,7 +24,7 @@ module.exports = func... | [
"ghost/core/core/server/models/base/plugins/actions.js",
"ghost/core/core/server/models/base/plugins/events.js",
"ghost/core/core/server/models/comment-like.js",
"ghost/core/core/server/models/comment-report.js",
"ghost/core/core/server/models/comment.js",
"ghost/core/core/server/models/email.js",
"ghos... | [] | true | ||
TryGhost/Ghost | 28,514 | issue_to_patch | Preferred email design settings for welcome email sender details | towards https://linear.app/ghost/issue/NY-1333
*I recommend reviewing this by starting with the tests.*
This change should have no user impact because these fields on email design settings are empty. But soon, that'll change!
| 89604d00e6a9bf87298dfaa740afaf65d0145b96 | 3632216003e3767c553ba96c90b77ae49788a689 | diff --git a/ghost/core/core/server/services/member-welcome-emails/service.js b/ghost/core/core/server/services/member-welcome-emails/service.js
index 11eec0b3643..31535587ae0 100644
--- a/ghost/core/core/server/services/member-welcome-emails/service.js
+++ b/ghost/core/core/server/services/member-welcome-emails/servic... | [
"ghost/core/core/server/services/member-welcome-emails/service.js",
"ghost/core/test/integration/services/member-welcome-emails.test.js"
] | [] | diff --git a/ghost/core/test/integration/services/member-welcome-emails.test.js b/ghost/core/test/integration/services/member-welcome-emails.test.js
index 7d39c32a6ab..8e4a2d46445 100644
--- a/ghost/core/test/integration/services/member-welcome-emails.test.js
+++ b/ghost/core/test/integration/services/member-welcome-em... | true | |
TryGhost/Ghost | 28,543 | issue_to_patch | Update dependency react-colorful to v5.7.0 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [react-colorful](https://omgovich.github.io/react-colorful) ([source](https://redirect.github.com/omgovich/react-colorf... | c5bc7635ad081b2dd2f6893c6bb5a78ce9d9158b | 403653d07839c21768209e613deed58fe2f7ddb3 | diff --git a/apps/admin-x-design-system/package.json b/apps/admin-x-design-system/package.json
index 04ff35766de..64864acbe5e 100644
--- a/apps/admin-x-design-system/package.json
+++ b/apps/admin-x-design-system/package.json
@@ -80,7 +80,7 @@
"@tryghost/shade": "workspace:*",
"@uiw/react-codemirror": ... | [
"apps/admin-x-design-system/package.json",
"pnpm-lock.yaml"
] | [] | true | ||
TryGhost/Ghost | 28,542 | issue_to_patch | Update dependency knip to v6.16.1 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [knip](https://knip.dev) ([source](https://redirect.github.com/webpro-nl/knip/tree/HEAD/packages/knip)) | [`6.14.2` → `... | cd23bf61132822ff6d0ebe307102e2466d76395f | 9b868be60fb3de86c54a97862d9b422fee0a5d0f | diff --git a/package.json b/package.json
index b5f7e8ed9f2..d8cf36a3c73 100644
--- a/package.json
+++ b/package.json
@@ -77,7 +77,7 @@
"eslint-plugin-react": "7.37.5",
"husky": "9.1.7",
"jsonc-parser": "catalog:",
- "knip": "6.14.2",
+ "knip": "6.16.1",
"lint-staged": "17.0.7",
"nx": "22.... | [
"package.json",
"pnpm-lock.yaml"
] | [] | true | ||
TryGhost/Ghost | 28,560 | issue_to_patch | Update dependency @anthropic-ai/sdk to v0.104.1 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [@anthropic-ai/sdk](https://redirect.github.com/anthropics/anthropic-sdk-typescript) | [`0.102.0` → `0.104.1`](https://... | 17670cc64e4e68fe853f8d89bcbb42079df207c3 | e91bc8985995c46ecb0cc5495ee0fdcb0efef54f | diff --git a/.github/scripts/i18n-review/package-lock.json b/.github/scripts/i18n-review/package-lock.json
index 3e72f440448..2c269c648dd 100644
--- a/.github/scripts/i18n-review/package-lock.json
+++ b/.github/scripts/i18n-review/package-lock.json
@@ -8,7 +8,7 @@
"name": "@ghost-internal/i18n-review",
"v... | [
".github/scripts/i18n-review/package-lock.json",
".github/scripts/i18n-review/package.json"
] | [] | true | ||
TryGhost/Ghost | 28,563 | issue_to_patch | Update tryghost/actions digest to 9b2a4a4 | This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [tryghost/actions](https://redirect.github.com/tryghost/actions) ([changelog](https://redirect.github.com/tryghost/actions/compare/5b3f016a2426d87bd67cf4823f2cc0d87b94da63..9b2a4a48cd458728c438c7fc090b3863b494cd16)) | acti... | e7c08c25e840fb5bf26f2ac672669c89e325cbcc | d626c2f102e6b97d7468c2f7f907e2d84b30e32a | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 429d1671a53..c43e0891f8e 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -312,7 +312,7 @@ jobs:
NX_BASE: ${{ needs.job_setup.outputs.nx_base }}
NX_HEAD: ${{ env.HEAD_COMMIT }}
- - uses: tryghost/a... | [
".github/workflows/ci.yml",
".github/workflows/label-actions.yml"
] | [] | true | ||
TryGhost/Ghost | 28,562 | issue_to_patch | Update tinybirdco/tinybird-local:latest Docker digest to 8929a96 | This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| tinybirdco/tinybird-local | service | digest | `019d0d3` → `8929a96` |
| tinybirdco/tinybird-local | | digest | `019d0d3` → `8929a96` |
---
> [!WARNING]
> Some dependencies could not be looked up. Check the [Dependency ... | d51af86b2b387d4e790891efc2ecab99456a5b55 | ac7ffb73ccc65b85a7ccc26bd4833c73fbc2638d | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index dfc71ba6a59..429d1671a53 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -740,7 +740,7 @@ jobs:
working-directory: ghost/core/core/server/data/tinybird
services:
tinybird:
- image: tinybirdco/tin... | [
".github/workflows/ci.yml",
"compose.dev.analytics.yaml"
] | [] | true | ||
TryGhost/Ghost | 28,561 | issue_to_patch | Update stripe/stripe-cli:latest Docker digest to 2daa6a2 | This PR contains the following updates:
| Package | Update | Change |
|---|---|---|
| stripe/stripe-cli | digest | `ac5920c` → `2daa6a2` |
---
> [!WARNING]
> Some dependencies could not be looked up. Check the [Dependency Dashboard](../issues/28155) for more information.
---
### Configuration
📅 **Schedule**: (in... | 7dfe22a1de418eb1c26a636094858817cb70bf64 | bb31172ed986417c35cd4ec87f1413a28057d590 | diff --git a/compose.dev.yaml b/compose.dev.yaml
index 20e3abaa673..9d66a70fc1b 100644
--- a/compose.dev.yaml
+++ b/compose.dev.yaml
@@ -128,7 +128,7 @@ services:
condition: service_healthy
stripe:
- image: stripe/stripe-cli:latest@sha256:ac5920c06aa0ecd95e86366cb849de7acd39396e11cf2d0b16ea0e91cbb655ec... | [
"compose.dev.yaml"
] | [] | true | ||
TryGhost/Ghost | 28,559 | issue_to_patch | Update aws-sdk-js-v3 monorepo to v3.1065.0 | This PR contains the following updates:
| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [@aws-sdk/client-s3](https://redirect.github.com/aws/aws-sdk-js-v3/tree/main/clients/client-s3) ([source](https://redir... | c490404b1cecc04375face915cf365af9221ccd8 | d8839ccaf4d76647d46fa250423343a23868528d | diff --git a/ghost/core/package.json b/ghost/core/package.json
index 765892f7834..5177a686a1e 100644
--- a/ghost/core/package.json
+++ b/ghost/core/package.json
@@ -84,7 +84,7 @@
"cli": "^1.29.1"
},
"dependencies": {
- "@aws-sdk/client-s3": "3.1064.0",
+ "@aws-sdk/client-s3": "3.1065.0",
"@extract... | [
"ghost/core/package.json",
"pnpm-lock.yaml"
] | [] | true | ||
TryGhost/Ghost | 26,392 | issue_to_patch | Match small portal popover's X to large version | Currently, the colors used in portal for the gh-portal-close (X) button are inconsistent. the small popover uses --grey10 (which has poor contrast), while the larger popover (when showing tiers) uses --grey6. This PR changes gh-portal-close to consistently use --grey6, matching the current visual styling of the large... | 4bfa4a8e9e6bf267fe94b0ce2085efca5f5a2642 | 89b8eb7276fe73a91fec8d6bd636172452bb9cde | diff --git a/apps/portal/package.json b/apps/portal/package.json
index 8e8dfc468f3..c36e0c50109 100644
--- a/apps/portal/package.json
+++ b/apps/portal/package.json
@@ -1,6 +1,6 @@
{
"name": "@tryghost/portal",
- "version": "2.69.3",
+ "version": "2.69.4",
"license": "MIT",
"repository": "https://github.com... | [
"apps/portal/package.json",
"apps/portal/src/components/frame.styles.js"
] | [] | true | ||
TryGhost/Ghost | 24,949 | issue_to_patch | date helper locales don't match i18n locales
### Issue Summary
The docs say "Dates, with month names, are automatically translated. You don’t need to include them in the translation files." I was pretty sure I'd seen this before, so I was stumped why the Chinese (zh-Hant) site I'm working on wasn't getting translat... | 🐛 Fixed {{date}} helper rendering English for zh, zh-Hant, and pa locales | Fixes #24783
I have implemented the fix suggested in #24783.
Please check your PR against these items:
- [x] I've read and followed the [Contributor Guide](https://github.com/TryGhost/Ghost/blob/main/.github/CONTRIBUTING.md)
- [x] I've explained my change
- [ ] I've written an automated test to prove my chang... | 8f22426b836f96c524e545115d433aab2157d67b | 16b3f8cff45084e7e83d4bd84feaf35f5dc83fbc | diff --git a/ghost/core/core/frontend/helpers/date.js b/ghost/core/core/frontend/helpers/date.js
index 977661d63ca..0cb9c1cb6e7 100644
--- a/ghost/core/core/frontend/helpers/date.js
+++ b/ghost/core/core/frontend/helpers/date.js
@@ -46,7 +46,20 @@ module.exports = function (...attrs) {
// Documentation: http://mom... | [
"ghost/core/core/frontend/helpers/date.js",
"ghost/core/test/unit/frontend/helpers/date.test.js"
] | [
{
"comment": "_🛠️ Refactor suggestion_ | _🟠 Major_\n\n**Add test coverage for locale mapping.**\n\nPer the PR description, automated tests have not been written. Please add tests to verify:\n- `zh-Hant` correctly maps to `zh-tw` and produces translated dates\n- `zh` correctly maps to `zh-cn` and produces tran... | diff --git a/ghost/core/test/unit/frontend/helpers/date.test.js b/ghost/core/test/unit/frontend/helpers/date.test.js
index 3cbe5c1b1b4..0554898b4fe 100644
--- a/ghost/core/test/unit/frontend/helpers/date.test.js
+++ b/ghost/core/test/unit/frontend/helpers/date.test.js
@@ -116,6 +116,44 @@ describe('{{date}} helper', fu... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.