Datasets:
PotatoHD
/
github-pr-resolve

Dataset card Data Studio Files
xet
 Community
repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
TryGhost/Ghost
24,949
comment_to_fix
πŸ› Fixed {{date}} helper rendering English for zh, zh-Hant, and pa locales
_πŸ› οΈ Refactor suggestion_ | _🟠 Major_ **Add test coverage for locale mapping.** Per the PR description, automated tests have not been written. Please add tests to verify: - `zh-Hant` correctly maps to `zh-tw` and produces translated dates - `zh` correctly maps to `zh-cn` and produces translated dates - Other local...
8f22426b836f96c524e545115d433aab2157d67b
16b3f8cff45084e7e83d4bd84feaf35f5dc83fbc
diff --git a/ghost/core/core/frontend/helpers/date.js b/ghost/core/core/frontend/helpers/date.js index 977661d63ca..0cb9c1cb6e7 100644 --- a/ghost/core/core/frontend/helpers/date.js +++ b/ghost/core/core/frontend/helpers/date.js @@ -46,7 +46,20 @@ module.exports = function (...attrs) { // Documentation: http://mom...
[ "ghost/core/core/frontend/helpers/date.js" ]
[ { "comment": "_πŸ› οΈ Refactor suggestion_ | _🟠 Major_\n\n**Add test coverage for locale mapping.**\n\nPer the PR description, automated tests have not been written. Please add tests to verify:\n- `zh-Hant` correctly maps to `zh-tw` and produces translated dates\n- `zh` correctly maps to `zh-cn` and produces tran...
true
TryGhost/Ghost
28,547
issue_to_patch
Changed members Stripe customer count filter to an NQL aggregate relation
ref https://linear.app/ghost/issue/BER-3717/ ref https://github.com/TryGhost/NQL/pull/152 The `count.active_stripe_customers` members filter was hardcoded outside of NQL β€” the input serializer pattern-matched the exact filter string and the member model injected a bespoke knex subquery. That meant the filter only work...
9ede96c426bf0e32a3631d8bf0ace0b785a45a0e
df7ac4316f967d1417444648efce03fc21cb0799
diff --git a/ghost/core/core/server/api/endpoints/utils/serializers/input/members.js b/ghost/core/core/server/api/endpoints/utils/serializers/input/members.js index b1da44b2acd..eddf700a908 100644 --- a/ghost/core/core/server/api/endpoints/utils/serializers/input/members.js +++ b/ghost/core/core/server/api/endpoints/ut...
[ "ghost/core/core/server/api/endpoints/utils/serializers/input/members.js", "ghost/core/core/server/models/member.js", "ghost/core/core/server/services/members/members-api/repositories/member-repository.js", "ghost/core/package.json", "ghost/core/test/e2e-api/admin/members.test.js", "pnpm-lock.yaml", "pn...
[ { "comment": "_⚠️ Potential issue_ | _🟑 Minor_ | _⚑ Quick win_\n\n**Update the bulk-action error text to mention `search`.**\n\nThe guard on Line 966 accepts either `filter` or `search`, but `messages.bulkActionRequiresFilter` still tells callers that only `filter` or `all=true` are valid. That makes this 400 ...
diff --git a/ghost/core/test/e2e-api/admin/members.test.js b/ghost/core/test/e2e-api/admin/members.test.js index fa3fd00ba53..f0ec8b419a6 100644 --- a/ghost/core/test/e2e-api/admin/members.test.js +++ b/ghost/core/test/e2e-api/admin/members.test.js @@ -747,6 +747,21 @@ describe('Members API', function () { ...
true
TryGhost/Ghost
28,547
comment_to_fix
Changed members Stripe customer count filter to an NQL aggregate relation
_⚠️ Potential issue_ | _🟑 Minor_ | _⚑ Quick win_ **Update the bulk-action error text to mention `search`.** The guard on Line 966 accepts either `filter` or `search`, but `messages.bulkActionRequiresFilter` still tells callers that only `filter` or `all=true` are valid. That makes this 400 response misleading. <...
9ede96c426bf0e32a3631d8bf0ace0b785a45a0e
df7ac4316f967d1417444648efce03fc21cb0799
diff --git a/ghost/core/core/server/services/members/members-api/repositories/member-repository.js b/ghost/core/core/server/services/members/members-api/repositories/member-repository.js index a3d0ad8cc2c..d116b65fa91 100644 --- a/ghost/core/core/server/services/members/members-api/repositories/member-repository.js +++...
[ "ghost/core/core/server/services/members/members-api/repositories/member-repository.js" ]
[ { "comment": "_⚠️ Potential issue_ | _🟑 Minor_ | _⚑ Quick win_\n\n**Update the bulk-action error text to mention `search`.**\n\nThe guard on Line 966 accepts either `filter` or `search`, but `messages.bulkActionRequiresFilter` still tells callers that only `filter` or `all=true` are valid. That makes this 400 ...
true
TryGhost/Ghost
28,547
comment_to_fix
Changed members Stripe customer count filter to an NQL aggregate relation
_⚠️ Potential issue_ | _🟑 Minor_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell #!/bin/bash # Description: Verify `@tryghost/bookshelf-plugins`@2.2.4 exists and check its nql dependency # Check if version 2.2.4 exists and get its dependencies echo "Checking `@tryghost/bookshelf-plugins...
9ede96c426bf0e32a3631d8bf0ace0b785a45a0e
df7ac4316f967d1417444648efce03fc21cb0799
diff --git a/ghost/core/package.json b/ghost/core/package.json index a3cd21756d8..bff9b66dd9f 100644 --- a/ghost/core/package.json +++ b/ghost/core/package.json @@ -93,7 +93,7 @@ "@tryghost/adapter-base-cache": "0.1.25", "@tryghost/admin-api-schema": "4.7.4", "@tryghost/api-framework": "catalog:", - "...
[ "ghost/core/package.json" ]
[ { "comment": "_⚠️ Potential issue_ | _🟑 Minor_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Description: Verify `@tryghost/bookshelf-plugins`@2.2.4 exists and check its nql dependency\n\n# Check if version 2.2.4 exists and get its dependencies\necho \"Ch...
true
TryGhost/Ghost
28,541
issue_to_patch
Changed select option typing
This PR is a small code quality improvement without an associated issue. ## What does it do? Removes an unsafe `any` type from the Admin X design system `Select` component and replaces it with React Select's `OptionProps<SelectOption, false>` type. It also cleans up nearby type definition formatting i...
be948e9f5acbbd2255ae0ff28528292f60377e07
6e756311c2abeb588dd4d8eea8361329e5d51b61
diff --git a/apps/admin-x-design-system/src/global/form/select.tsx b/apps/admin-x-design-system/src/global/form/select.tsx index f6f1323db19..eda24ead958 100644 --- a/apps/admin-x-design-system/src/global/form/select.tsx +++ b/apps/admin-x-design-system/src/global/form/select.tsx @@ -32,7 +32,7 @@ export interface Sele...
[ "apps/admin-x-design-system/src/global/form/select.tsx" ]
[]
true
TryGhost/Ghost
26,678
issue_to_patch
πŸ› Admin API always saves revisions even when save_revision=false ### Issue Summary There's a sort order bug in Ghost's revision logic. Here's the chain: 1. post-revision.js:32-33 β€” orderDefaultRaw() returns 'created_at_ts DESC' β€” newest first 2. post.js:920-926 β€” revisions are fetched via findAll β†’ gets them in **...
πŸ› Fix Admin API Post update method to not save a revision when save_revision=false
fixes https://github.com/TryGhost/ghost/issues/26677 There's a sort order bug in Ghost's revision logic. Here's the chain: post-revision.js:32-33 β€” orderDefaultRaw() returns 'created_at_ts DESC' β€” newest first post.js:920-926 β€” revisions are fetched via findAll β†’ gets them in DESC order (newest first) pos...
4250b43c67f8a95b62eb64bc68f9cbe52718088a
57e62b1c7c6c91c83982c0c4cc10c23f120fb7d2
diff --git a/ghost/core/core/server/models/post.js b/ghost/core/core/server/models/post.js index a8d0380c199..beb8476b603 100644 --- a/ghost/core/core/server/models/post.js +++ b/ghost/core/core/server/models/post.js @@ -932,7 +932,9 @@ Post = ghostBookshelf.Model.extend({ columns: ['id', 'lexi...
[ "ghost/core/core/server/models/post.js", "ghost/core/test/e2e-api/admin/posts.test.js", "ghost/core/test/unit/server/lib/post-revisions.test.ts" ]
[ { "comment": "### Test doesn't actually validate the sort-order fix\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe new test claims to verify that no revision is created within the interval without `save_revision`, but it passes regardless of whether the `.reverse()` fix is applied. All revisions are ...
diff --git a/ghost/core/test/e2e-api/admin/posts.test.js b/ghost/core/test/e2e-api/admin/posts.test.js index 817d75f92c0..6aa557cde6c 100644 --- a/ghost/core/test/e2e-api/admin/posts.test.js +++ b/ghost/core/test/e2e-api/admin/posts.test.js @@ -496,6 +496,41 @@ describe('Posts API', function () { assert.eq...
true
TryGhost/Ghost
28,554
issue_to_patch
Improved MySQL acceptance test resets
## Summary - Cache the initialized MySQL acceptance-test database into in-database snapshot tables after the first truncating reset. - Restore subsequent MySQL resets from that snapshot instead of rerunning `knexMigrator.init({only: 3})` for every Ghost boot. - Invalidate and clean snapshot tables when using the full ...
4250b43c67f8a95b62eb64bc68f9cbe52718088a
3e9b83b75183ae89a35b134e22455ad47b785be1
[ "ghost/core/test/utils/db-utils.js", "ghost/core/test/utils/e2e-utils.js" ]
[]
diff --git a/ghost/core/test/utils/db-utils.js b/ghost/core/test/utils/db-utils.js index f8196474abf..f0b834040d6 100644 --- a/ghost/core/test/utils/db-utils.js +++ b/ghost/core/test/utils/db-utils.js @@ -22,6 +22,8 @@ const {sequence} = require('@tryghost/promise'); const urlServiceUtils = require('./url-service-util...
true
TryGhost/Ghost
28,555
issue_to_patch
Skipping flaky automations test
no ref This has been blocking CI from green and therefore our release for a while. We've looked at a few adjustments and are unlikely to have a concrete fix today.
e0a290760a6910e859d1eb8b4af7a75ebae3109e
075bc38758b2e2ee5a3cc479b7abe89b6a92dad2
[ "ghost/core/test/e2e-api/members/automations.test.js" ]
[]
diff --git a/ghost/core/test/e2e-api/members/automations.test.js b/ghost/core/test/e2e-api/members/automations.test.js index 0f585feaf65..b3f4cf34f43 100644 --- a/ghost/core/test/e2e-api/members/automations.test.js +++ b/ghost/core/test/e2e-api/members/automations.test.js @@ -135,7 +135,8 @@ describe('Members Automatio...
true
TryGhost/Ghost
25,560
issue_to_patch
Fix amazon link card
# Summary This PR resolves the issue described below. https://github.com/TryGhost/Ghost/issues/22417 As documented in the linked issue, images are not displayed in Amazon-embedded content. This behavior also occurs in the latest version (current HEAD) of Ghost. # Root Cause and Fix I investigated the pr...
89604d00e6a9bf87298dfaa740afaf65d0145b96
49815a42dd9c626340faa45513b5caacb5392864
diff --git a/ghost/core/core/server/services/oembed/oembed-service.js b/ghost/core/core/server/services/oembed/oembed-service.js index 0783ecb8dc9..8d425e79111 100644 --- a/ghost/core/core/server/services/oembed/oembed-service.js +++ b/ghost/core/core/server/services/oembed/oembed-service.js @@ -180,7 +180,7 @@ class O...
[ "ghost/core/core/server/services/oembed/oembed-service.js", "ghost/core/package.json", "ghost/core/test/unit/server/services/oembed/oembed-service.test.js", "pnpm-lock.yaml" ]
[]
diff --git a/ghost/core/test/unit/server/services/oembed/oembed-service.test.js b/ghost/core/test/unit/server/services/oembed/oembed-service.test.js index 89b3a535e50..a5d6947740d 100644 --- a/ghost/core/test/unit/server/services/oembed/oembed-service.test.js +++ b/ghost/core/test/unit/server/services/oembed/oembed-ser...
true
TryGhost/Ghost
26,878
issue_to_patch
πŸ› Fixed search navigating away during CJK IME composition
When using CJK input methods (Chinese, Japanese, Korean) in the sodo-search modal (Cmd+K), pressing Enter to confirm a character during IME composition incorrectly triggers navigation to the first search result. This makes search unusable for CJK users. The keyboard handler in the `Results` component used `keyup`, b...
2e369d783be56cba3e66303a26721ce70e14633b
19de1200d2436bf1dc2f2e906ef5586b62f13e6e
diff --git a/apps/sodo-search/package.json b/apps/sodo-search/package.json index 6e45c864a1f..a2f676cb46e 100644 --- a/apps/sodo-search/package.json +++ b/apps/sodo-search/package.json @@ -1,6 +1,6 @@ { "name": "@tryghost/sodo-search", - "version": "1.8.22", + "version": "1.8.23", "license": "MIT", "reposit...
[ "apps/sodo-search/package.json", "apps/sodo-search/src/components/popup-modal.js", "apps/sodo-search/test/unit/popup-modal.test.js" ]
[]
diff --git a/apps/sodo-search/test/unit/popup-modal.test.js b/apps/sodo-search/test/unit/popup-modal.test.js new file mode 100644 index 00000000000..b79871b766c --- /dev/null +++ b/apps/sodo-search/test/unit/popup-modal.test.js @@ -0,0 +1,55 @@ +import AppContext from '../../src/app-context'; +import React from 'react'...
true
TryGhost/Ghost
28,511
issue_to_patch
Made `automated_email_recipients.automated_email_id` nullable
closes https://linear.app/ghost/issue/NY-1335 This change should have no user impact. Soon, this field will no longer be set in all cases (for automation emails). This prepares us for that by making the relevant field nullable. Nobody sets this to null yet, but we will soon!
18dbfc49594ebc795de53e16b6fca444d6005605
d53d006aee27e392f8175d5b053c0ed0d5e5b26c
diff --git a/ghost/core/core/server/data/migrations/versions/6.45/2026-06-11-16-04-43-make-automated-email-recipient-email-id-nullable.js b/ghost/core/core/server/data/migrations/versions/6.45/2026-06-11-16-04-43-make-automated-email-recipient-email-id-nullable.js new file mode 100644 index 00000000000..8fe9dd03b8b ---...
[ "ghost/core/core/server/data/migrations/versions/6.45/2026-06-11-16-04-43-make-automated-email-recipient-email-id-nullable.js", "ghost/core/core/server/data/schema/schema.js", "ghost/core/test/unit/server/data/schema/integrity.test.js" ]
[ { "comment": "Necessary because `automated_email_id` is a foreign key.", "path": "ghost/core/core/server/data/migrations/versions/6.45/2026-06-11-16-04-43-make-automated-email-recipient-email-id-nullable.js", "hunk": "@@ -0,0 +1,19 @@\n+const {createSetNullableMigration} = require('../../utils');\n+\n+c...
diff --git a/ghost/core/test/unit/server/data/schema/integrity.test.js b/ghost/core/test/unit/server/data/schema/integrity.test.js index e385a6c35d9..8516a117e8d 100644 --- a/ghost/core/test/unit/server/data/schema/integrity.test.js +++ b/ghost/core/test/unit/server/data/schema/integrity.test.js @@ -35,7 +35,7 @@ const...
true
TryGhost/Ghost
28,550
issue_to_patch
Quick-fixed an automations test for reliability
towards https://linear.app/ghost/issue/NY-1341 ref https://github.com/TryGhost/Ghost/actions/runs/27403034105/ ref https://github.com/TryGhost/Ghost/pull/28549 This is a quick fix to make an automations test more reliable. We plan to make a proper fix in the future.
dbedeecc409060767358b789781ac961f426db2a
e597a057c46cfc4ac910492bf36bac5b4f96fdf1
[ "ghost/core/test/e2e-api/members/automations.test.js" ]
[]
diff --git a/ghost/core/test/e2e-api/members/automations.test.js b/ghost/core/test/e2e-api/members/automations.test.js index b708954f1b1..0f585feaf65 100644 --- a/ghost/core/test/e2e-api/members/automations.test.js +++ b/ghost/core/test/e2e-api/members/automations.test.js @@ -184,6 +184,11 @@ describe('Members Automati...
true
TryGhost/Ghost
28,545
issue_to_patch
πŸ› Fixed comment counts for lazy loaded posts
## What changed - Fixed the frontend comment-count loader so it fetches counts for markers inserted after initial page load. - Added a JSDOM regression test covering lazy-loaded post cards. ## Why Archive pagination inserts post cards after the initial page load. The mutation observer detected those new comment coun...
cb39915453dcf869ff40a3428ec5e88e85ef2270
aa585c0e8c5ce9f5737d67c2325473f994858387
diff --git a/ghost/core/core/frontend/src/comment-counts/comment-counts.js b/ghost/core/core/frontend/src/comment-counts/comment-counts.js index c128a8cbae4..ca7022be518 100644 --- a/ghost/core/core/frontend/src/comment-counts/comment-counts.js +++ b/ghost/core/core/frontend/src/comment-counts/comment-counts.js @@ -88,...
[ "ghost/core/core/frontend/src/comment-counts/comment-counts.js", "ghost/core/test/unit/frontend/src/comment-counts.test.js" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\n# Locate and display the target test file (short excerpt around the reported lines)\nFILE=\"ghost/core/test/unit/frontend/src/comment-counts.te...
diff --git a/ghost/core/test/unit/frontend/src/comment-counts.test.js b/ghost/core/test/unit/frontend/src/comment-counts.test.js new file mode 100644 index 00000000000..fb38947b9a8 --- /dev/null +++ b/ghost/core/test/unit/frontend/src/comment-counts.test.js @@ -0,0 +1,86 @@ +/* global expect, vi */ + +const fs = requir...
true
TryGhost/Ghost
28,545
comment_to_fix
πŸ› Fixed comment counts for lazy loaded posts
_⚠️ Potential issue_ | _🟠 Major_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell #!/bin/bash set -euo pipefail # Locate and display the target test file (short excerpt around the reported lines) FILE="ghost/core/test/unit/frontend/src/comment-counts.test.js" echo "== File existence ==" ...
cb39915453dcf869ff40a3428ec5e88e85ef2270
aa585c0e8c5ce9f5737d67c2325473f994858387
diff --git a/ghost/core/test/unit/frontend/src/comment-counts.test.js b/ghost/core/test/unit/frontend/src/comment-counts.test.js new file mode 100644 index 00000000000..fb38947b9a8 --- /dev/null +++ b/ghost/core/test/unit/frontend/src/comment-counts.test.js @@ -0,0 +1,86 @@ +/* global expect, vi */ + +const fs = requir...
[ "ghost/core/test/unit/frontend/src/comment-counts.test.js" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\n# Locate and display the target test file (short excerpt around the reported lines)\nFILE=\"ghost/core/test/unit/frontend/src/comment-counts.te...
true
TryGhost/Ghost
28,510
issue_to_patch
πŸ› Fixed label mutation errors being silently swallowed in the label picker
## Issue fixes https://linear.app/ghost/issue/BER-3493/label-createedit-mutation-errors-are-silently-swallowed ## Problem Label create, edit and delete failures in the posts label picker gave the user no feedback. The client-side duplicate-name check only saw locally-loaded labels, so duplicates slipped through to t...
97862f089049ba5de92e45a28ac611bd6636cc72
0a717238686c464b02ad67fb1b04ceafdc6d5407
diff --git a/apps/admin-x-design-system/src/providers/design-system-provider.tsx b/apps/admin-x-design-system/src/providers/design-system-provider.tsx index 815e98ff099..61498c53e3f 100644 --- a/apps/admin-x-design-system/src/providers/design-system-provider.tsx +++ b/apps/admin-x-design-system/src/providers/design-sys...
[ "apps/admin-x-design-system/src/providers/design-system-provider.tsx", "apps/admin-x-framework/package.json", "apps/admin-x-framework/src/api/labels.ts", "apps/admin-x-framework/src/hooks/use-filterable-api.ts", "apps/admin-x-framework/src/hooks/use-handle-error.ts", "apps/admin-x-framework/src/utils/api/...
[ { "comment": "_⚠️ Potential issue_ | _🟑 Minor_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Search for existing NQL escaping patterns and documentation in the codebase\n\necho \"=== Searching for NQL filter construction patterns ===\"\nrg -n --type ts --...
diff --git a/apps/admin-x-framework/test/unit/api/labels.test.tsx b/apps/admin-x-framework/test/unit/api/labels.test.tsx new file mode 100644 index 00000000000..a037663c108 --- /dev/null +++ b/apps/admin-x-framework/test/unit/api/labels.test.tsx @@ -0,0 +1,138 @@ +import {act} from '@testing-library/react'; +import {be...
true
TryGhost/Ghost
28,510
comment_to_fix
πŸ› Fixed label mutation errors being silently swallowed in the label picker
_⚠️ Potential issue_ | _🟑 Minor_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell #!/bin/bash # Search for existing NQL escaping patterns and documentation in the codebase echo "=== Searching for NQL filter construction patterns ===" rg -n --type ts --type js -B2 -A2 "filter.*name:" | he...
97862f089049ba5de92e45a28ac611bd6636cc72
0a717238686c464b02ad67fb1b04ceafdc6d5407
diff --git a/apps/admin-x-framework/src/api/labels.ts b/apps/admin-x-framework/src/api/labels.ts index bb2d5309922..85fdb5b85d8 100644 --- a/apps/admin-x-framework/src/api/labels.ts +++ b/apps/admin-x-framework/src/api/labels.ts @@ -1,5 +1,9 @@ import {InfiniteData} from '@tanstack/react-query'; import {Meta, createI...
[ "apps/admin-x-framework/src/api/labels.ts" ]
[ { "comment": "_⚠️ Potential issue_ | _🟑 Minor_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Search for existing NQL escaping patterns and documentation in the codebase\n\necho \"=== Searching for NQL filter construction patterns ===\"\nrg -n --type ts --...
true
TryGhost/Ghost
28,510
comment_to_fix
πŸ› Fixed label mutation errors being silently swallowed in the label picker
_⚠️ Potential issue_ | _🟠 Major_ | _⚑ Quick win_ **Guard against lookup failures during duplicate adoption.** If `findLabelByName` rejects (e.g., network error during the lookup), the promise will reject with the lookup error instead of the original `ValidationError`, making debugging harder. Wrap the lookup in a tr...
97862f089049ba5de92e45a28ac611bd6636cc72
0a717238686c464b02ad67fb1b04ceafdc6d5407
diff --git a/apps/posts/src/hooks/use-label-picker.ts b/apps/posts/src/hooks/use-label-picker.ts index 4192f0ea2de..48853a4617c 100644 --- a/apps/posts/src/hooks/use-label-picker.ts +++ b/apps/posts/src/hooks/use-label-picker.ts @@ -1,6 +1,8 @@ -import {Label, useCreateLabel, useDeleteLabel, useEditLabel} from '@trygho...
[ "apps/posts/src/hooks/use-label-picker.ts" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚑ Quick win_\n\n**Guard against lookup failures during duplicate adoption.**\n\nIf `findLabelByName` rejects (e.g., network error during the lookup), the promise will reject with the lookup error instead of the original `ValidationError`, making debugging harde...
true
TryGhost/Ghost
28,510
comment_to_fix
πŸ› Fixed label mutation errors being silently swallowed in the label picker
_⚠️ Potential issue_ | _🟑 Minor_ | _⚑ Quick win_ **Update test name to reflect silent duplicate adoption.** The test name claims it "surfaces the duplicate error", but line 42 asserts `toBeHidden()` for "Label already exists", verifying that duplicate adoption succeeds silently. Per the PR objectives, duplicate crea...
97862f089049ba5de92e45a28ac611bd6636cc72
0a717238686c464b02ad67fb1b04ceafdc6d5407
diff --git a/e2e/tests/admin/members/label-lifecycle.test.ts b/e2e/tests/admin/members/label-lifecycle.test.ts new file mode 100644 index 00000000000..3933b5fb644 --- /dev/null +++ b/e2e/tests/admin/members/label-lifecycle.test.ts @@ -0,0 +1,64 @@ +import {MemberFactory, createMemberFactory} from '@/data-factory'; +imp...
[ "e2e/tests/admin/members/label-lifecycle.test.ts" ]
[ { "comment": "_⚠️ Potential issue_ | _🟑 Minor_ | _⚑ Quick win_\n\n**Update test name to reflect silent duplicate adoption.**\n\nThe test name claims it \"surfaces the duplicate error\", but line 42 asserts `toBeHidden()` for \"Label already exists\", verifying that duplicate adoption succeeds silently. Per the...
true
TryGhost/Ghost
28,510
comment_to_fix
πŸ› Fixed label mutation errors being silently swallowed in the label picker
_⚠️ Potential issue_ | _🟑 Minor_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell #!/bin/bash # Description: Check label model schema for constraints beyond unique name # Find label model/schema definition fd -t f -e js schema | xargs rg -n -C5 'label' -i | rg -i 'constraint|unique|check...
97862f089049ba5de92e45a28ac611bd6636cc72
0a717238686c464b02ad67fb1b04ceafdc6d5407
diff --git a/ghost/core/core/server/api/endpoints/labels.js b/ghost/core/core/server/api/endpoints/labels.js index 92de6047e59..2cea0790575 100644 --- a/ghost/core/core/server/api/endpoints/labels.js +++ b/ghost/core/core/server/api/endpoints/labels.js @@ -9,6 +9,21 @@ const messages = { const ALLOWED_INCLUDES = ['c...
[ "ghost/core/core/server/api/endpoints/labels.js" ]
[ { "comment": "_⚠️ Potential issue_ | _🟑 Minor_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Description: Check label model schema for constraints beyond unique name\n\n# Find label model/schema definition\nfd -t f -e js schema | xargs rg -n -C5 'label' -...
true
TryGhost/Ghost
28,510
comment_to_fix
πŸ› Fixed label mutation errors being silently swallowed in the label picker
## CodeQL / Incomplete string escaping or encoding This does not escape backslash characters in the input. [Show more details](https://github.com/TryGhost/Ghost/security/code-scanning/490)
97862f089049ba5de92e45a28ac611bd6636cc72
0a717238686c464b02ad67fb1b04ceafdc6d5407
diff --git a/apps/admin-x-framework/src/utils/nql.ts b/apps/admin-x-framework/src/utils/nql.ts new file mode 100644 index 00000000000..183875540e0 --- /dev/null +++ b/apps/admin-x-framework/src/utils/nql.ts @@ -0,0 +1,9 @@ +// NQL's only escape sequences are \' and \" - there is no \\, so a backslash +// is a literal c...
[ "apps/admin-x-framework/src/utils/nql.ts" ]
[ { "comment": "## CodeQL / Incomplete string escaping or encoding\n\nThis does not escape backslash characters in the input.\n\n[Show more details](https://github.com/TryGhost/Ghost/security/code-scanning/490)", "path": "apps/admin-x-framework/src/utils/nql.ts", "hunk": "@@ -0,0 +1,5 @@\n+// NQL only une...
true
TryGhost/Ghost
28,519
issue_to_patch
✨ Added IndexNow to notify search engines of content changes
## Summary GA the IndexNow feature. It's been running as a private developer experiment and is proven in production, so this: - moves `indexnow` from `PRIVATE_FEATURES` to `GA_FEATURES` (always on), so Ghost pings the IndexNow API when posts are published or updated - removes the now-redundant developer-experiments t...
97862f089049ba5de92e45a28ac611bd6636cc72
654ba01033cf5c4b8a974f63fd0d05bb3e10c12d
diff --git a/apps/admin-x-settings/src/components/settings/advanced/labs/private-features.tsx b/apps/admin-x-settings/src/components/settings/advanced/labs/private-features.tsx index b57d390a349..f9a28c51294 100644 --- a/apps/admin-x-settings/src/components/settings/advanced/labs/private-features.tsx +++ b/apps/admin-x...
[ "apps/admin-x-settings/src/components/settings/advanced/labs/private-features.tsx", "ghost/core/core/shared/labs.js", "ghost/core/test/e2e-api/admin/__snapshots__/settings.test.js.snap" ]
[]
diff --git a/ghost/core/test/e2e-api/admin/__snapshots__/settings.test.js.snap b/ghost/core/test/e2e-api/admin/__snapshots__/settings.test.js.snap index 155518e66d9..702cb635f82 100644 --- a/ghost/core/test/e2e-api/admin/__snapshots__/settings.test.js.snap +++ b/ghost/core/test/e2e-api/admin/__snapshots__/settings.test...
true
TryGhost/Ghost
28,498
issue_to_patch
Restored @slack/webhook dependency for the Ghost(Pro) migrate script
## Problem Ghost(Pro) migrations are currently failing to alert. `migrate.js` (copied into the Ghost(Pro) image at release time) crashes with: ``` Error: Cannot find module '@slack/webhook' at Object.notifySlack (/home/ghost/migrate.js:101:31) ``` Because the require lives inside `notifySlack`, the `MOD...
c7be635df7d7e9fee686fe6e13f6a5d76e796894
f673a23732f21867d2f1888ab7dadb53ec29037f
diff --git a/ghost/core/package.json b/ghost/core/package.json index 01d44971f5d..5d603994730 100644 --- a/ghost/core/package.json +++ b/ghost/core/package.json @@ -89,6 +89,7 @@ "@faker-js/faker": "catalog:", "@isaacs/ttlcache": "1.4.1", "@sentry/node": "7.120.4", + "@slack/webhook": "7.0.9", "@...
[ "ghost/core/package.json", "knip.json", "pnpm-lock.yaml" ]
[]
true
Tyrrrz/DiscordChatExporter
1,545
issue_to_patch
HTML-encode markdown content when formatting is disabled
f4d1e630f7f27120c3be4320d92cc8b932e78688
e1cb29126a9f08821a5119c5c95df1049fab8927
diff --git a/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml b/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml index f0dba0dec..b3c068372 100644 --- a/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml +++ b/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml @@ -2,6...
[ "DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml", "DiscordChatExporter.Core/Exporting/PreambleTemplate.cshtml" ]
[]
true
Tyrrrz/DiscordChatExporter
1,544
issue_to_patch
Implement missing HTML encoding for several attribute injections
799dd1ad8151046c464762802c36dffefb1bd383
3a0f059a27b7fc8b01e048e7380ac9c3206e56f2
diff --git a/DiscordChatExporter.Core/Exporting/HtmlMarkdownVisitor.cs b/DiscordChatExporter.Core/Exporting/HtmlMarkdownVisitor.cs index 91232948a..0104a6d8c 100644 --- a/DiscordChatExporter.Core/Exporting/HtmlMarkdownVisitor.cs +++ b/DiscordChatExporter.Core/Exporting/HtmlMarkdownVisitor.cs @@ -162,7 +162,7 @@ protect...
[ "DiscordChatExporter.Core/Exporting/HtmlMarkdownVisitor.cs" ]
[]
true
Tyrrrz/DiscordChatExporter
1,540
issue_to_patch
Stream asset downloads to avoid OutOfMemoryException on large files
Exporting a channel with **Download assets** enabled crashes with an `OutOfMemoryException` as soon as it hits a large attachment ``` System.OutOfMemoryException at System.Net.Http.HttpContent.LimitArrayPoolWriteStream.GrowAndWrite(...) at System.Net.Http.HttpConnection.CopyToContentLengthAsync(...) at Sys...
45629c9d7f289275066c85ab9b4dfdec48417cff
6df84431010315fca0c0e7bbb6b193ef1bf8ac3a
diff --git a/DiscordChatExporter.Core/Exporting/ExportAssetDownloader.cs b/DiscordChatExporter.Core/Exporting/ExportAssetDownloader.cs index eb44d4a90..071616ecf 100644 --- a/DiscordChatExporter.Core/Exporting/ExportAssetDownloader.cs +++ b/DiscordChatExporter.Core/Exporting/ExportAssetDownloader.cs @@ -1,6 +1,7 @@ us...
[ "DiscordChatExporter.Core/Exporting/ExportAssetDownloader.cs" ]
[ { "comment": "The download response isn't validated before writing to disk. If the CDN returns 404/403/5xx, the exporter will currently save the error body as the β€œasset” file and return a local path (instead of falling back to the original URL). Also, if the copy fails mid-stream (cancellation/network), a part...
true
Tyrrrz/DiscordChatExporter
1,540
comment_to_fix
Stream asset downloads to avoid OutOfMemoryException on large files
The download response isn't validated before writing to disk. If the CDN returns 404/403/5xx, the exporter will currently save the error body as the β€œasset” file and return a local path (instead of falling back to the original URL). Also, if the copy fails mid-stream (cancellation/network), a partial file can be left b...
45629c9d7f289275066c85ab9b4dfdec48417cff
6df84431010315fca0c0e7bbb6b193ef1bf8ac3a
diff --git a/DiscordChatExporter.Core/Exporting/ExportAssetDownloader.cs b/DiscordChatExporter.Core/Exporting/ExportAssetDownloader.cs index eb44d4a90..071616ecf 100644 --- a/DiscordChatExporter.Core/Exporting/ExportAssetDownloader.cs +++ b/DiscordChatExporter.Core/Exporting/ExportAssetDownloader.cs @@ -1,6 +1,7 @@ us...
[ "DiscordChatExporter.Core/Exporting/ExportAssetDownloader.cs" ]
[ { "comment": "The download response isn't validated before writing to disk. If the CDN returns 404/403/5xx, the exporter will currently save the error body as the β€œasset” file and return a local path (instead of falling back to the original URL). Also, if the copy fails mid-stream (cancellation/network), a part...
true
Tyrrrz/DiscordChatExporter
1,541
issue_to_patch
Bump the actions group with 4 updates
Bumps the actions group with 4 updates: [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action), [actions/setup-dotnet](https://github.com/actions/setup-dotnet), [codecov/codecov-action](https://github.com/codecov/codecov-action) and [tyrrrz/action-http-request](https://github.com/tyrrrz/action-http...
45629c9d7f289275066c85ab9b4dfdec48417cff
0a88c3b6a0c9697ca194b88419b9ff7b3f308a7f
diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index 33177c503..ec56bde23 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -26,7 +26,7 @@ jobs: uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: Install Docker Build...
[ ".github/workflows/docker.yml", ".github/workflows/main.yml" ]
[]
true
Tyrrrz/DiscordChatExporter
1,542
issue_to_patch
Bump the nuget group with 13 updates
Updated [Avalonia](https://github.com/AvaloniaUI/Avalonia/) from 12.0.2 to 12.0.4. <details> <summary>Release notes</summary> _Sourced from [Avalonia's releases](https://github.com/AvaloniaUI/Avalonia//releases)._ No release notes found for this version range. Commits viewable in [compare view](https://github.com/A...
45629c9d7f289275066c85ab9b4dfdec48417cff
36773a0b34053a42b07ad55ddb9669071c2bcd97
diff --git a/Directory.Packages.props b/Directory.Packages.props index a2df34fd9..0f031eee7 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -7,33 +7,33 @@ <PackageVersion Include="AngleSharp" Version="1.4.0" /> <PackageVersion Include="AsyncImageLoader.Avalonia" Version="3.8.0" /> ...
[ "Directory.Packages.props" ]
[]
true
Tyrrrz/DiscordChatExporter
1,539
issue_to_patch
Extract app shutdown fallback into `App.Shutdown`
Ports [YoutubeDownloader#838](https://github.com/Tyrrrz/YoutubeDownloader/pull/838): centralizes the repeated shutdown-with-fallback pattern into a single static helper. ## Changes - **`App.axaml.cs`** β€” split into two partials; second partial adds: ```csharp public static void Shutdown(int exitCode = 0) { ...
6258394fc0b1c9645a06fa2eb0c6e459fc0703d7
36568bbbda9e269ce5e6305be6a761424863cc24
diff --git a/DiscordChatExporter.Gui/App.axaml.cs b/DiscordChatExporter.Gui/App.axaml.cs index 926406362..37179c5c9 100644 --- a/DiscordChatExporter.Gui/App.axaml.cs +++ b/DiscordChatExporter.Gui/App.axaml.cs @@ -7,6 +7,7 @@ using DiscordChatExporter.Gui.Framework; using DiscordChatExporter.Gui.Localization; using D...
[ "DiscordChatExporter.Gui/App.axaml.cs", "DiscordChatExporter.Gui/ViewModels/MainViewModel.cs" ]
[]
true
Tyrrrz/DiscordChatExporter
1,528
issue_to_patch
Bump actions/upload-artifact from 7.0.0 to 7.0.1 in the actions group
Bumps the actions group with 1 update: [actions/upload-artifact](https://github.com/actions/upload-artifact). Updates `actions/upload-artifact` from 7.0.0 to 7.0.1 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's rele...
0a623b24d114203c4d460738b9291a85976c404d
32751ebff1d43cfcccaa636f30a66a5e4b2329e7
diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index 6425ea9ac..33177c503 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -37,7 +37,7 @@ jobs: --output type=tar,dest=DiscordChatExporter.Cli.Docker.tar - name: Upload image - uses: actio...
[ ".github/workflows/docker.yml", ".github/workflows/main.yml" ]
[]
true
Tyrrrz/DiscordChatExporter
1,529
issue_to_patch
Bump the nuget group with 15 updates
Updated [AsyncImageLoader.Avalonia](https://github.com/AvaloniaUtils/AsyncImageLoader.Avalonia) from 3.7.0 to 3.8.0. <details> <summary>Release notes</summary> _Sourced from [AsyncImageLoader.Avalonia's releases](https://github.com/AvaloniaUtils/AsyncImageLoader.Avalonia/releases)._ ## 3.8.0 ## What's Changed * Ava...
0a623b24d114203c4d460738b9291a85976c404d
c2d7f7effca939e6a0add6a93f71cfd42b1c0981
diff --git a/Directory.Packages.props b/Directory.Packages.props index abcce00f4..bee2e4ffc 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -5,43 +5,43 @@ <ItemGroup> <PackageVersion Include="AngleSharp" Version="1.4.0" /> - <PackageVersion Include="AsyncImageLoader.Avalonia" Versio...
[ "Directory.Packages.props" ]
[]
true
Tyrrrz/DiscordChatExporter
1,525
issue_to_patch
Add PowerKit and replace custom utility extensions
- [x] Analyze PowerKit 1.0.0 package contents and identify overlaps with our utilities - [x] Add PowerKit to Directory.Packages.props and all 4 project files - [x] Delete extension files fully replaced by PowerKit (AsyncCollectionExtensions, CollectionExtensions, ExceptionExtensions, GenericExtensions, StringExtensions...
757daa7a6020167e30fc59392da11af3b7c06f6c
f6234a11293220349a4c11e43b00531560bf0faa
diff --git a/Directory.Packages.props b/Directory.Packages.props index 8c144c22f..a3a98c650 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -34,6 +34,7 @@ <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.3.0" /> <PackageVersion Include="Onova" Version="2.6.13" /> <Pack...
[ "Directory.Packages.props", "DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj", "DiscordChatExporter.Cli.Tests/Specs/DateRangeSpecs.cs", "DiscordChatExporter.Cli.Tests/Specs/FilterSpecs.cs", "DiscordChatExporter.Cli.Tests/Specs/HtmlContentSpecs.cs", "DiscordChatExporter.Cli.Tests/Specs/H...
[]
diff --git a/DiscordChatExporter.Cli.Tests/Specs/DateRangeSpecs.cs b/DiscordChatExporter.Cli.Tests/Specs/DateRangeSpecs.cs index 25e0cec98..58bf07888 100644 --- a/DiscordChatExporter.Cli.Tests/Specs/DateRangeSpecs.cs +++ b/DiscordChatExporter.Cli.Tests/Specs/DateRangeSpecs.cs @@ -5,11 +5,11 @@ using CliFx.Infrastructu...
true
Tyrrrz/DiscordChatExporter
1,520
issue_to_patch
Bump the nuget group with 17 updates
Updated [AsyncImageLoader.Avalonia](https://github.com/AvaloniaUtils/AsyncImageLoader.Avalonia) from 3.6.0 to 3.7.0. <details> <summary>Release notes</summary> _Sourced from [AsyncImageLoader.Avalonia's releases](https://github.com/AvaloniaUtils/AsyncImageLoader.Avalonia/releases)._ ## 3.7.0 ## What's Changed * Add...
5c613062318a0c35d942e657b7f20c2868aa4fb2
7b04e3fd244b26f41fdc3ec28d3cc587c2464c18
diff --git a/Directory.Packages.props b/Directory.Packages.props index 454054537..76bbb34fe 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -5,40 +5,40 @@ <ItemGroup> <PackageVersion Include="AngleSharp" Version="1.4.0" /> - <PackageVersion Include="AsyncImageLoader.Avalonia" Versio...
[ "Directory.Packages.props" ]
[]
true
Tyrrrz/DiscordChatExporter
1,519
issue_to_patch
Bump the actions group with 5 updates
Bumps the actions group with 5 updates: | Package | From | To | | --- | --- | --- | | [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) | `3.12.0` | `4.0.0` | | [actions/setup-dotnet](https://github.com/actions/setup-dotnet) | `5.1.0` | `5.2.0` | | [codecov/codecov-action](https://github.com/...
5c613062318a0c35d942e657b7f20c2868aa4fb2
99cc6bc3394374de2d81d54175b0502ce3a61cae
diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index acc92edd8..6425ea9ac 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -26,7 +26,7 @@ jobs: uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 - name: Install Docker Build...
[ ".github/workflows/docker.yml", ".github/workflows/main.yml" ]
[]
true
Tyrrrz/DiscordChatExporter
1,516
issue_to_patch
Migrate to CliFx v3
This adds full trimming/AOT support to the CLI, and also significantly improves performance
661f82c47856b0997202fa7e12d7daae828f908f
3bcbaf6b9a7f6df094465f7a23f76d4f7bc761d7
diff --git a/Directory.Packages.props b/Directory.Packages.props index ebbc74542..454054537 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -10,7 +10,7 @@ <PackageVersion Include="Avalonia" Version="11.3.12" /> <PackageVersion Include="Avalonia.Desktop" Version="11.3.12" /> <Packa...
[ "Directory.Packages.props", "DiscordChatExporter.Cli/Commands/Base/DiscordCommandBase.cs", "DiscordChatExporter.Cli/Commands/Base/ExportCommandBase.cs", "DiscordChatExporter.Cli/Commands/Converters/ThreadInclusionModeInputConverter.cs", "DiscordChatExporter.Cli/Commands/Converters/TruthyBooleanInputConverte...
[ { "comment": "`PublishMacOSBundle.csx` uses CliFx v3 namespaces (`CliFx.Binding`), but the script references the package via `#:package CliFx` without a version. That directive typically resolves to the latest *stable* version (likely CliFx v2.x), which would make this script fail to compile/run. Pin the script...
true
Tyrrrz/DiscordChatExporter
1,516
comment_to_fix
Migrate to CliFx v3
`PublishMacOSBundle.csx` uses CliFx v3 namespaces (`CliFx.Binding`), but the script references the package via `#:package CliFx` without a version. That directive typically resolves to the latest *stable* version (likely CliFx v2.x), which would make this script fail to compile/run. Pin the script’s package reference t...
661f82c47856b0997202fa7e12d7daae828f908f
3bcbaf6b9a7f6df094465f7a23f76d4f7bc761d7
diff --git a/DiscordChatExporter.Gui/PublishMacOSBundle.csx b/DiscordChatExporter.Gui/PublishMacOSBundle.csx index 080d5f244..3b2d7e808 100755 --- a/DiscordChatExporter.Gui/PublishMacOSBundle.csx +++ b/DiscordChatExporter.Gui/PublishMacOSBundle.csx @@ -2,16 +2,16 @@ #:package CliFx using CliFx; -using CliFx.Attribu...
[ "DiscordChatExporter.Gui/PublishMacOSBundle.csx" ]
[ { "comment": "`PublishMacOSBundle.csx` uses CliFx v3 namespaces (`CliFx.Binding`), but the script references the package via `#:package CliFx` without a version. That directive typically resolves to the latest *stable* version (likely CliFx v2.x), which would make this script fail to compile/run. Pin the script...
true
Tyrrrz/DiscordChatExporter
1,515
issue_to_patch
Replace `Publish-MacOSBundle.ps1` with a .NET 10 single-file C# script
- [x] Create `DiscordChatExporter.Gui/Publish-MacOSBundle.csx` - [x] Update `DiscordChatExporter.Gui/DiscordChatExporter.Gui.csproj` MSBuild target to invoke `dotnet run` - [x] Delete `DiscordChatExporter.Gui/Publish-MacOSBundle.ps1` - [x] Use CliFx for argument parsing with `[CommandOption]` attributes - [x] Add sheba...
5a26ba0b5adb9e330980e9666fc5e6076663d67f
80feb4739bf6f1ce13e0b4f725c389f8317fb14c
diff --git a/DiscordChatExporter.Gui/DiscordChatExporter.Gui.csproj b/DiscordChatExporter.Gui/DiscordChatExporter.Gui.csproj index e5e27df3f..73ed4d1d2 100644 --- a/DiscordChatExporter.Gui/DiscordChatExporter.Gui.csproj +++ b/DiscordChatExporter.Gui/DiscordChatExporter.Gui.csproj @@ -56,7 +56,7 @@ <Target Name="Pu...
[ "DiscordChatExporter.Gui/DiscordChatExporter.Gui.csproj", "DiscordChatExporter.Gui/Publish-MacOSBundle.csx", "DiscordChatExporter.Gui/Publish-MacOSBundle.ps1" ]
[ { "comment": "Can we use CliFx to handle command line arguments? @copilot \nWe already use it in the solution", "path": "DiscordChatExporter.Gui/Publish-MacOSBundle.csx", "hunk": "@@ -0,0 +1,97 @@\n+// Publishes the GUI app as a macOS .app bundle.", "resolving_sha": "80feb4739bf6f1ce13e0b4f725c389f8...
true
Tyrrrz/DiscordChatExporter
1,515
comment_to_fix
Replace `Publish-MacOSBundle.ps1` with a .NET 10 single-file C# script
Can we use CliFx to handle command line arguments? @copilot We already use it in the solution
5a26ba0b5adb9e330980e9666fc5e6076663d67f
80feb4739bf6f1ce13e0b4f725c389f8317fb14c
diff --git a/DiscordChatExporter.Gui/Publish-MacOSBundle.csx b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx new file mode 100644 index 000000000..ab6fc635b --- /dev/null +++ b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx @@ -0,0 +1,128 @@ +#!/usr/bin/env -S dotnet run -- +#:package CliFx + +using CliFx; +using Cl...
[ "DiscordChatExporter.Gui/Publish-MacOSBundle.csx" ]
[ { "comment": "Can we use CliFx to handle command line arguments? @copilot \nWe already use it in the solution", "path": "DiscordChatExporter.Gui/Publish-MacOSBundle.csx", "hunk": "@@ -0,0 +1,97 @@\n+// Publishes the GUI app as a macOS .app bundle.", "resolving_sha": "80feb4739bf6f1ce13e0b4f725c389f8...
true
Tyrrrz/DiscordChatExporter
1,515
comment_to_fix
Replace `Publish-MacOSBundle.ps1` with a .NET 10 single-file C# script
Let's use options instead?
5a26ba0b5adb9e330980e9666fc5e6076663d67f
80feb4739bf6f1ce13e0b4f725c389f8317fb14c
diff --git a/DiscordChatExporter.Gui/Publish-MacOSBundle.csx b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx new file mode 100644 index 000000000..ab6fc635b --- /dev/null +++ b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx @@ -0,0 +1,128 @@ +#!/usr/bin/env -S dotnet run -- +#:package CliFx + +using CliFx; +using Cl...
[ "DiscordChatExporter.Gui/Publish-MacOSBundle.csx" ]
[ { "comment": "Let's use options instead?", "path": "DiscordChatExporter.Gui/Publish-MacOSBundle.csx", "hunk": "@@ -0,0 +1,118 @@\n+#:package CliFx@2.3.6\n+\n+using CliFx;\n+using CliFx.Attributes;\n+using CliFx.Infrastructure;\n+\n+return await new CliApplicationBuilder()\n+ .AddCommand<PublishMacOSB...
true
Tyrrrz/DiscordChatExporter
1,515
comment_to_fix
Replace `Publish-MacOSBundle.ps1` with a .NET 10 single-file C# script
Can we just use the version specified in the CPM file? Also, missing shebang
5a26ba0b5adb9e330980e9666fc5e6076663d67f
80feb4739bf6f1ce13e0b4f725c389f8317fb14c
diff --git a/DiscordChatExporter.Gui/Publish-MacOSBundle.csx b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx new file mode 100644 index 000000000..ab6fc635b --- /dev/null +++ b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx @@ -0,0 +1,128 @@ +#!/usr/bin/env -S dotnet run -- +#:package CliFx + +using CliFx; +using Cl...
[ "DiscordChatExporter.Gui/Publish-MacOSBundle.csx" ]
[ { "comment": "Can we just use the version specified in the CPM file?\n\nAlso, missing shebang", "path": "DiscordChatExporter.Gui/Publish-MacOSBundle.csx", "hunk": "@@ -0,0 +1,118 @@\n+#:package CliFx@2.3.6", "resolving_sha": "80feb4739bf6f1ce13e0b4f725c389f8317fb14c", "resolving_diff": "diff --g...
true
Tyrrrz/DiscordChatExporter
1,515
comment_to_fix
Replace `Publish-MacOSBundle.ps1` with a .NET 10 single-file C# script
You don't need to create each intermediate directory, just the terminal ones
5a26ba0b5adb9e330980e9666fc5e6076663d67f
80feb4739bf6f1ce13e0b4f725c389f8317fb14c
diff --git a/DiscordChatExporter.Gui/Publish-MacOSBundle.csx b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx new file mode 100644 index 000000000..ab6fc635b --- /dev/null +++ b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx @@ -0,0 +1,128 @@ +#!/usr/bin/env -S dotnet run -- +#:package CliFx + +using CliFx; +using Cl...
[ "DiscordChatExporter.Gui/Publish-MacOSBundle.csx" ]
[ { "comment": "You don't need to create each intermediate directory, just the terminal ones", "path": "DiscordChatExporter.Gui/Publish-MacOSBundle.csx", "hunk": "@@ -0,0 +1,118 @@\n+#:package CliFx@2.3.6\n+\n+using CliFx;\n+using CliFx.Attributes;\n+using CliFx.Infrastructure;\n+\n+return await new CliAp...
true
Tyrrrz/DiscordChatExporter
1,515
comment_to_fix
Replace `Publish-MacOSBundle.ps1` with a .NET 10 single-file C# script
```suggestion // Set up paths ```
5a26ba0b5adb9e330980e9666fc5e6076663d67f
80feb4739bf6f1ce13e0b4f725c389f8317fb14c
diff --git a/DiscordChatExporter.Gui/Publish-MacOSBundle.csx b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx new file mode 100644 index 000000000..ab6fc635b --- /dev/null +++ b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx @@ -0,0 +1,128 @@ +#!/usr/bin/env -S dotnet run -- +#:package CliFx + +using CliFx; +using Cl...
[ "DiscordChatExporter.Gui/Publish-MacOSBundle.csx" ]
[ { "comment": "```suggestion\n // Set up paths\n```", "path": "DiscordChatExporter.Gui/Publish-MacOSBundle.csx", "hunk": "@@ -0,0 +1,118 @@\n+#:package CliFx@2.3.6\n+\n+using CliFx;\n+using CliFx.Attributes;\n+using CliFx.Infrastructure;\n+\n+return await new CliApplicationBuilder()\n+ .AddComm...
true
Tyrrrz/DiscordChatExporter
1,515
comment_to_fix
Replace `Publish-MacOSBundle.ps1` with a .NET 10 single-file C# script
Prepend `// lang=xml` comments before the string literal so that some IDEs can highlight the text inside
5a26ba0b5adb9e330980e9666fc5e6076663d67f
80feb4739bf6f1ce13e0b4f725c389f8317fb14c
diff --git a/DiscordChatExporter.Gui/Publish-MacOSBundle.csx b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx new file mode 100644 index 000000000..ab6fc635b --- /dev/null +++ b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx @@ -0,0 +1,128 @@ +#!/usr/bin/env -S dotnet run -- +#:package CliFx + +using CliFx; +using Cl...
[ "DiscordChatExporter.Gui/Publish-MacOSBundle.csx" ]
[ { "comment": "Prepend `// lang=xml` comments before the string literal so that some IDEs can highlight the text inside", "path": "DiscordChatExporter.Gui/Publish-MacOSBundle.csx", "hunk": "@@ -0,0 +1,118 @@\n+#:package CliFx@2.3.6\n+\n+using CliFx;\n+using CliFx.Attributes;\n+using CliFx.Infrastructure;...
true
Tyrrrz/DiscordChatExporter
1,515
comment_to_fix
Replace `Publish-MacOSBundle.ps1` with a .NET 10 single-file C# script
Omit all explicit parameter names
5a26ba0b5adb9e330980e9666fc5e6076663d67f
80feb4739bf6f1ce13e0b4f725c389f8317fb14c
diff --git a/DiscordChatExporter.Gui/Publish-MacOSBundle.csx b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx new file mode 100644 index 000000000..ab6fc635b --- /dev/null +++ b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx @@ -0,0 +1,128 @@ +#!/usr/bin/env -S dotnet run -- +#:package CliFx + +using CliFx; +using Cl...
[ "DiscordChatExporter.Gui/Publish-MacOSBundle.csx" ]
[ { "comment": "Omit all explicit parameter names", "path": "DiscordChatExporter.Gui/Publish-MacOSBundle.csx", "hunk": "@@ -0,0 +1,118 @@\n+#:package CliFx@2.3.6\n+\n+using CliFx;\n+using CliFx.Attributes;\n+using CliFx.Infrastructure;\n+\n+return await new CliApplicationBuilder()\n+ .AddCommand<Publis...
true
Tyrrrz/DiscordChatExporter
1,515
comment_to_fix
Replace `Publish-MacOSBundle.ps1` with a .NET 10 single-file C# script
Use the `async` version here? And check if there are other places where this might be relevant @copilot
5a26ba0b5adb9e330980e9666fc5e6076663d67f
80feb4739bf6f1ce13e0b4f725c389f8317fb14c
diff --git a/DiscordChatExporter.Gui/Publish-MacOSBundle.csx b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx new file mode 100644 index 000000000..ab6fc635b --- /dev/null +++ b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx @@ -0,0 +1,128 @@ +#!/usr/bin/env -S dotnet run -- +#:package CliFx + +using CliFx; +using Cl...
[ "DiscordChatExporter.Gui/Publish-MacOSBundle.csx" ]
[ { "comment": "Use the `async` version here? And check if there are other places where this might be relevant @copilot ", "path": "DiscordChatExporter.Gui/Publish-MacOSBundle.csx", "hunk": "@@ -0,0 +1,118 @@\n+#!/usr/bin/env -S dotnet run\n+#:package CliFx\n+\n+using CliFx;\n+using CliFx.Attributes;\n+us...
true
Tyrrrz/DiscordChatExporter
1,515
comment_to_fix
Replace `Publish-MacOSBundle.ps1` with a .NET 10 single-file C# script
@copilot 1. Inline `...DirPath` variables that are not used in more than one place. 2. Move `Directory.CreateDirectory` closer to places in code where the corresponding files are written to those directories.
5a26ba0b5adb9e330980e9666fc5e6076663d67f
80feb4739bf6f1ce13e0b4f725c389f8317fb14c
diff --git a/DiscordChatExporter.Gui/Publish-MacOSBundle.csx b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx new file mode 100644 index 000000000..ab6fc635b --- /dev/null +++ b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx @@ -0,0 +1,128 @@ +#!/usr/bin/env -S dotnet run -- +#:package CliFx + +using CliFx; +using Cl...
[ "DiscordChatExporter.Gui/Publish-MacOSBundle.csx" ]
[ { "comment": "@copilot \n\n1. Inline `...DirPath` variables that are not used in more than one place.\n2. Move `Directory.CreateDirectory` closer to places in code where the corresponding files are written to those directories.", "path": "DiscordChatExporter.Gui/Publish-MacOSBundle.csx", "hunk": "@@ -0,...
true
Tyrrrz/DiscordChatExporter
1,515
comment_to_fix
Replace `Publish-MacOSBundle.ps1` with a .NET 10 single-file C# script
Convert to a constant at the top of the class
5a26ba0b5adb9e330980e9666fc5e6076663d67f
80feb4739bf6f1ce13e0b4f725c389f8317fb14c
diff --git a/DiscordChatExporter.Gui/Publish-MacOSBundle.csx b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx new file mode 100644 index 000000000..ab6fc635b --- /dev/null +++ b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx @@ -0,0 +1,128 @@ +#!/usr/bin/env -S dotnet run -- +#:package CliFx + +using CliFx; +using Cl...
[ "DiscordChatExporter.Gui/Publish-MacOSBundle.csx" ]
[ { "comment": "Convert to a constant at the top of the class", "path": "DiscordChatExporter.Gui/Publish-MacOSBundle.csx", "hunk": "@@ -0,0 +1,112 @@\n+#!/usr/bin/env -S dotnet run\n+#:package CliFx\n+\n+using CliFx;\n+using CliFx.Attributes;\n+using CliFx.Infrastructure;\n+\n+return await new CliApplicat...
true
Tyrrrz/DiscordChatExporter
1,515
comment_to_fix
Replace `Publish-MacOSBundle.ps1` with a .NET 10 single-file C# script
```suggestion foreach (var entryPath in Directory.GetFileSystemEntries(publishDirPath)) ```
5a26ba0b5adb9e330980e9666fc5e6076663d67f
80feb4739bf6f1ce13e0b4f725c389f8317fb14c
diff --git a/DiscordChatExporter.Gui/Publish-MacOSBundle.csx b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx new file mode 100644 index 000000000..ab6fc635b --- /dev/null +++ b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx @@ -0,0 +1,128 @@ +#!/usr/bin/env -S dotnet run -- +#:package CliFx + +using CliFx; +using Cl...
[ "DiscordChatExporter.Gui/Publish-MacOSBundle.csx" ]
[ { "comment": "```suggestion\n foreach (var entryPath in Directory.GetFileSystemEntries(publishDirPath))\n```", "path": "DiscordChatExporter.Gui/Publish-MacOSBundle.csx", "hunk": "@@ -0,0 +1,112 @@\n+#!/usr/bin/env -S dotnet run\n+#:package CliFx\n+\n+using CliFx;\n+using CliFx.Attributes;\n+u...
true
Tyrrrz/DiscordChatExporter
1,515
comment_to_fix
Replace `Publish-MacOSBundle.ps1` with a .NET 10 single-file C# script
```suggestion var destinationPath = Path.Combine(contentsDirPath, "MacOS", Path.GetFileName(entry)); ```
5a26ba0b5adb9e330980e9666fc5e6076663d67f
80feb4739bf6f1ce13e0b4f725c389f8317fb14c
diff --git a/DiscordChatExporter.Gui/Publish-MacOSBundle.csx b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx new file mode 100644 index 000000000..ab6fc635b --- /dev/null +++ b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx @@ -0,0 +1,128 @@ +#!/usr/bin/env -S dotnet run -- +#:package CliFx + +using CliFx; +using Cl...
[ "DiscordChatExporter.Gui/Publish-MacOSBundle.csx" ]
[ { "comment": "```suggestion\n var destinationPath = Path.Combine(contentsDirPath, \"MacOS\", Path.GetFileName(entry));\n```", "path": "DiscordChatExporter.Gui/Publish-MacOSBundle.csx", "hunk": "@@ -0,0 +1,112 @@\n+#!/usr/bin/env -S dotnet run\n+#:package CliFx\n+\n+using CliFx;\n+using Cl...
true
Tyrrrz/DiscordChatExporter
1,515
comment_to_fix
Replace `Publish-MacOSBundle.ps1` with a .NET 10 single-file C# script
```suggestion if (Directory.Exists(entryPath)) ```
5a26ba0b5adb9e330980e9666fc5e6076663d67f
80feb4739bf6f1ce13e0b4f725c389f8317fb14c
diff --git a/DiscordChatExporter.Gui/Publish-MacOSBundle.csx b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx new file mode 100644 index 000000000..ab6fc635b --- /dev/null +++ b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx @@ -0,0 +1,128 @@ +#!/usr/bin/env -S dotnet run -- +#:package CliFx + +using CliFx; +using Cl...
[ "DiscordChatExporter.Gui/Publish-MacOSBundle.csx" ]
[ { "comment": "```suggestion\n\n if (Directory.Exists(entryPath))\n```", "path": "DiscordChatExporter.Gui/Publish-MacOSBundle.csx", "hunk": "@@ -0,0 +1,117 @@\n+#!/usr/bin/env -S dotnet run\n+#:package CliFx\n+\n+using CliFx;\n+using CliFx.Attributes;\n+using CliFx.Infrastructure;\n+\n+ret...
true
Tyrrrz/DiscordChatExporter
1,515
comment_to_fix
Replace `Publish-MacOSBundle.ps1` with a .NET 10 single-file C# script
The shebang uses `dotnet run` without a `--` separator. When running this script directly (e.g., `./Publish-MacOSBundle.csx --publish-dir ...`), arguments starting with `--` are likely to be parsed by `dotnet run` instead of being forwarded to the script. Consider changing the shebang to include `--` so command options...
5a26ba0b5adb9e330980e9666fc5e6076663d67f
80feb4739bf6f1ce13e0b4f725c389f8317fb14c
diff --git a/DiscordChatExporter.Gui/Publish-MacOSBundle.csx b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx new file mode 100644 index 000000000..ab6fc635b --- /dev/null +++ b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx @@ -0,0 +1,128 @@ +#!/usr/bin/env -S dotnet run -- +#:package CliFx + +using CliFx; +using Cl...
[ "DiscordChatExporter.Gui/Publish-MacOSBundle.csx" ]
[ { "comment": "The shebang uses `dotnet run` without a `--` separator. When running this script directly (e.g., `./Publish-MacOSBundle.csx --publish-dir ...`), arguments starting with `--` are likely to be parsed by `dotnet run` instead of being forwarded to the script. Consider changing the shebang to include `...
true
Tyrrrz/DiscordChatExporter
1,515
comment_to_fix
Replace `Publish-MacOSBundle.ps1` with a .NET 10 single-file C# script
`tempDirPath` points to a fixed location. If a previous invocation crashed before cleanup, stale files under this directory could be picked up and end up inside the resulting .app bundle. Consider deleting `tempDirPath` at the start when it exists (or using a unique temp directory name per run) to ensure a clean bundle...
5a26ba0b5adb9e330980e9666fc5e6076663d67f
80feb4739bf6f1ce13e0b4f725c389f8317fb14c
diff --git a/DiscordChatExporter.Gui/Publish-MacOSBundle.csx b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx new file mode 100644 index 000000000..ab6fc635b --- /dev/null +++ b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx @@ -0,0 +1,128 @@ +#!/usr/bin/env -S dotnet run -- +#:package CliFx + +using CliFx; +using Cl...
[ "DiscordChatExporter.Gui/Publish-MacOSBundle.csx" ]
[ { "comment": "`tempDirPath` points to a fixed location. If a previous invocation crashed before cleanup, stale files under this directory could be picked up and end up inside the resulting .app bundle. Consider deleting `tempDirPath` at the start when it exists (or using a unique temp directory name per run) to...
true
Tyrrrz/DiscordChatExporter
1,515
comment_to_fix
Replace `Publish-MacOSBundle.ps1` with a .NET 10 single-file C# script
The `<Exec>` command does not quote `$(ProjectDir)`, `$(PublishDir)`, or the icons path. This can break the build on machines where these paths contain spaces (common on Windows agents). Consider quoting/escaping the path arguments in the command string. ```suggestion Command="dotnet run &quot;$(ProjectDir)/Publi...
5a26ba0b5adb9e330980e9666fc5e6076663d67f
80feb4739bf6f1ce13e0b4f725c389f8317fb14c
diff --git a/DiscordChatExporter.Gui/DiscordChatExporter.Gui.csproj b/DiscordChatExporter.Gui/DiscordChatExporter.Gui.csproj index e5e27df3f..73ed4d1d2 100644 --- a/DiscordChatExporter.Gui/DiscordChatExporter.Gui.csproj +++ b/DiscordChatExporter.Gui/DiscordChatExporter.Gui.csproj @@ -56,7 +56,7 @@ <Target Name="Pu...
[ "DiscordChatExporter.Gui/DiscordChatExporter.Gui.csproj" ]
[ { "comment": "The `<Exec>` command does not quote `$(ProjectDir)`, `$(PublishDir)`, or the icons path. This can break the build on machines where these paths contain spaces (common on Windows agents). Consider quoting/escaping the path arguments in the command string.\n```suggestion\n Command=\"dotnet run ...
true
Tyrrrz/DiscordChatExporter
1,515
comment_to_fix
Replace `Publish-MacOSBundle.ps1` with a .NET 10 single-file C# script
Extract relevant strings to constants below `BundleName` @copilot
5a26ba0b5adb9e330980e9666fc5e6076663d67f
80feb4739bf6f1ce13e0b4f725c389f8317fb14c
diff --git a/DiscordChatExporter.Gui/Publish-MacOSBundle.csx b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx new file mode 100644 index 000000000..ab6fc635b --- /dev/null +++ b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx @@ -0,0 +1,128 @@ +#!/usr/bin/env -S dotnet run -- +#:package CliFx + +using CliFx; +using Cl...
[ "DiscordChatExporter.Gui/Publish-MacOSBundle.csx" ]
[ { "comment": "Extract relevant strings to constants below `BundleName` @copilot ", "path": "DiscordChatExporter.Gui/Publish-MacOSBundle.csx", "hunk": "@@ -0,0 +1,118 @@\n+#!/usr/bin/env -S dotnet run\n+#:package CliFx\n+\n+using CliFx;\n+using CliFx.Attributes;\n+using CliFx.Infrastructure;\n+\n+return ...
true
Tyrrrz/DiscordChatExporter
1,515
comment_to_fix
Replace `Publish-MacOSBundle.ps1` with a .NET 10 single-file C# script
```suggestion var bundleDirPath = Path.Combine(tempDirPath, BundleName); ```
5a26ba0b5adb9e330980e9666fc5e6076663d67f
80feb4739bf6f1ce13e0b4f725c389f8317fb14c
diff --git a/DiscordChatExporter.Gui/Publish-MacOSBundle.csx b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx new file mode 100644 index 000000000..ab6fc635b --- /dev/null +++ b/DiscordChatExporter.Gui/Publish-MacOSBundle.csx @@ -0,0 +1,128 @@ +#!/usr/bin/env -S dotnet run -- +#:package CliFx + +using CliFx; +using Cl...
[ "DiscordChatExporter.Gui/Publish-MacOSBundle.csx" ]
[ { "comment": "```suggestion\n\n var bundleDirPath = Path.Combine(tempDirPath, BundleName);\n```", "path": "DiscordChatExporter.Gui/Publish-MacOSBundle.csx", "hunk": "@@ -0,0 +1,127 @@\n+#!/usr/bin/env -S dotnet run --\n+#:package CliFx\n+\n+using CliFx;\n+using CliFx.Attributes;\n+using CliFx.Inf...
true
Tyrrrz/DiscordChatExporter
1,514
issue_to_patch
Add `DISCORDCHATEXPORTER_ALLOW_AUTO_UPDATE` env var to suppress auto-update in GUI
- [x] Add `IsAutoUpdateAllowed` property to `StartOptions.cs` reading from `DISCORDCHATEXPORTER_ALLOW_AUTO_UPDATE` env var - [x] Update `UpdateService.cs` to use `IsAutoUpdateAllowed` - [x] Add `IsAutoUpdateAvailable` property to `SettingsViewModel.cs` using `IsAutoUpdateAllowed` - [x] Update `SettingsView.axaml` to bi...
b6e1f929892f89bbcc6be633f36e6ebfeb81f7f5
a1f16df9503d8718511868ffa3879076c8bc8197
diff --git a/DiscordChatExporter.Gui/Services/UpdateService.cs b/DiscordChatExporter.Gui/Services/UpdateService.cs index 2fc367da4..b249bb160 100644 --- a/DiscordChatExporter.Gui/Services/UpdateService.cs +++ b/DiscordChatExporter.Gui/Services/UpdateService.cs @@ -9,20 +9,21 @@ namespace DiscordChatExporter.Gui.Service...
[ "DiscordChatExporter.Gui/Services/UpdateService.cs", "DiscordChatExporter.Gui/StartOptions.cs", "DiscordChatExporter.Gui/ViewModels/Dialogs/SettingsViewModel.cs", "DiscordChatExporter.Gui/Views/Dialogs/SettingsView.axaml" ]
[ { "comment": "```suggestion\n public required bool IsAutoUpdateAllowed { get; init; }\n```", "path": "DiscordChatExporter.Gui/StartOptions.cs", "hunk": "@@ -6,6 +6,8 @@ namespace DiscordChatExporter.Gui;\n public partial class StartOptions\n {\n public required string SettingsPath { get; init; }\...
true
Tyrrrz/DiscordChatExporter
1,514
comment_to_fix
Add `DISCORDCHATEXPORTER_ALLOW_AUTO_UPDATE` env var to suppress auto-update in GUI
```suggestion public required bool IsAutoUpdateAllowed { get; init; } ```
b6e1f929892f89bbcc6be633f36e6ebfeb81f7f5
a1f16df9503d8718511868ffa3879076c8bc8197
diff --git a/DiscordChatExporter.Gui/StartOptions.cs b/DiscordChatExporter.Gui/StartOptions.cs index f29a04eab..d17752a85 100644 --- a/DiscordChatExporter.Gui/StartOptions.cs +++ b/DiscordChatExporter.Gui/StartOptions.cs @@ -6,6 +6,8 @@ namespace DiscordChatExporter.Gui; public partial class StartOptions { publi...
[ "DiscordChatExporter.Gui/StartOptions.cs" ]
[ { "comment": "```suggestion\n public required bool IsAutoUpdateAllowed { get; init; }\n```", "path": "DiscordChatExporter.Gui/StartOptions.cs", "hunk": "@@ -6,6 +6,8 @@ namespace DiscordChatExporter.Gui;\n public partial class StartOptions\n {\n public required string SettingsPath { get; init; }\...
true
Tyrrrz/DiscordChatExporter
1,514
comment_to_fix
Add `DISCORDCHATEXPORTER_ALLOW_AUTO_UPDATE` env var to suppress auto-update in GUI
```suggestion Environment.GetEnvironmentVariable("DISCORDCHATEXPORTER_ALLOW_AUTO_UPDATE") is { } v ```
b6e1f929892f89bbcc6be633f36e6ebfeb81f7f5
a1f16df9503d8718511868ffa3879076c8bc8197
diff --git a/DiscordChatExporter.Gui/StartOptions.cs b/DiscordChatExporter.Gui/StartOptions.cs index f29a04eab..d17752a85 100644 --- a/DiscordChatExporter.Gui/StartOptions.cs +++ b/DiscordChatExporter.Gui/StartOptions.cs @@ -6,6 +6,8 @@ namespace DiscordChatExporter.Gui; public partial class StartOptions { publi...
[ "DiscordChatExporter.Gui/StartOptions.cs" ]
[ { "comment": "```suggestion\n Environment.GetEnvironmentVariable(\"DISCORDCHATEXPORTER_ALLOW_AUTO_UPDATE\") is { } v\n```", "path": "DiscordChatExporter.Gui/StartOptions.cs", "hunk": "@@ -20,5 +22,8 @@ public partial class StartOptions\n ? Path.Combine(path, \"Sett...
true
Tyrrrz/DiscordChatExporter
1,514
comment_to_fix
Add `DISCORDCHATEXPORTER_ALLOW_AUTO_UPDATE` env var to suppress auto-update in GUI
Group the operands in `()` and invert the whole thing. Rename `v` to `env`. Only accept `false` as valid value. @copilot
b6e1f929892f89bbcc6be633f36e6ebfeb81f7f5
a1f16df9503d8718511868ffa3879076c8bc8197
diff --git a/DiscordChatExporter.Gui/StartOptions.cs b/DiscordChatExporter.Gui/StartOptions.cs index f29a04eab..d17752a85 100644 --- a/DiscordChatExporter.Gui/StartOptions.cs +++ b/DiscordChatExporter.Gui/StartOptions.cs @@ -6,6 +6,8 @@ namespace DiscordChatExporter.Gui; public partial class StartOptions { publi...
[ "DiscordChatExporter.Gui/StartOptions.cs" ]
[ { "comment": "Group the operands in `()` and invert the whole thing.\n\nRename `v` to `env`. Only accept `false` as valid value.\n\n@copilot ", "path": "DiscordChatExporter.Gui/StartOptions.cs", "hunk": "@@ -20,5 +22,9 @@ public partial class StartOptions\n ? Path.Combine(path, \...
true
Tyrrrz/DiscordChatExporter
1,514
comment_to_fix
Add `DISCORDCHATEXPORTER_ALLOW_AUTO_UPDATE` env var to suppress auto-update in GUI
`DISCORDCHATEXPORTER_ALLOW_AUTO_UPDATE` is only treated as false when the value equals "false" exactly; values like " false" or "false " (common when env vars are templated) will currently be ignored and auto-update will remain allowed. Consider trimming the env var value before comparison to make the switch more robus...
b6e1f929892f89bbcc6be633f36e6ebfeb81f7f5
a1f16df9503d8718511868ffa3879076c8bc8197
diff --git a/DiscordChatExporter.Gui/StartOptions.cs b/DiscordChatExporter.Gui/StartOptions.cs index f29a04eab..d17752a85 100644 --- a/DiscordChatExporter.Gui/StartOptions.cs +++ b/DiscordChatExporter.Gui/StartOptions.cs @@ -6,6 +6,8 @@ namespace DiscordChatExporter.Gui; public partial class StartOptions { publi...
[ "DiscordChatExporter.Gui/StartOptions.cs" ]
[ { "comment": "`DISCORDCHATEXPORTER_ALLOW_AUTO_UPDATE` is only treated as false when the value equals \"false\" exactly; values like \" false\" or \"false \" (common when env vars are templated) will currently be ignored and auto-update will remain allowed. Consider trimming the env var value before comparison t...
true
Tyrrrz/DiscordChatExporter
1,511
issue_to_patch
Instructions to get user token through console no longer work ### Version a91337c ### Flavor CLI (Command-Line Interface) ### Platform Linux/Firefox and Chrome ### Export format JSON ### Steps to reproduce Follow the instructions at https://github.com/Tyrrrz/DiscordChatExporter/blob/prime/.docs/Token-and-IDs....
Update token extraction script in docs
<!-- **Important** --> <!-- Please specify the issue(s) addressed by this pull request: --> Closes #1509 <!-- --> This pull request updates the Webpack console script in .docs/Token-and-IDs.md based on recent changes to Discord's web client. Using the suggestion given by @wavedevgit : https...
5cec162b4e73f218e50658f05e53fa7cc583c931
0d56021eb354e1b545b47438986ca055216e336d
diff --git a/.docs/Token-and-IDs.md b/.docs/Token-and-IDs.md index 52da3dc61..eae162ce7 100644 --- a/.docs/Token-and-IDs.md +++ b/.docs/Token-and-IDs.md @@ -27,7 +27,7 @@ Prerequisite step: Navigate to [discord.com](https://discord.com) and login. 3. Type ```js - let m;webpackChunkdiscord_app.push([[Math.ran...
[ ".docs/Token-and-IDs.md" ]
[]
true
Tyrrrz/DiscordChatExporter
1,480
issue_to_patch
Thread names get exported as `#deleted-channel` in mentions ### Version 2.43.3 ### Flavor CLI (Command-Line Interface) ### Platform Linux (Debian) ### Export format HTML ### Steps to reproduce - Make a mention to a thread in a channel - Export that channel - Observe the mention being converted to `#deleted-...
Resolve thread mentions on demand
Closes #1261 - [x] Add `TryGetChannelAsync` to `DiscordClient` for on-demand channel/thread lookup - [x] Add `PopulateChannelAsync` to `ExportContext` with caching (similar to `PopulateMemberAsync`), including negative caching - [x] Update `HtmlMarkdownVisitor` channel mention rendering to call `PopulateChannelAsync` ...
72f9e981de75ae28d29b96d9d01c150c53df7c43
2ba6b70a6a46ffe467da923130099aa46ba71e69
diff --git a/DiscordChatExporter.Core/Discord/DiscordClient.cs b/DiscordChatExporter.Core/Discord/DiscordClient.cs index 5ac33d554..28d5e255a 100644 --- a/DiscordChatExporter.Core/Discord/DiscordClient.cs +++ b/DiscordChatExporter.Core/Discord/DiscordClient.cs @@ -371,21 +371,40 @@ public async ValueTask<Channel> GetCh...
[ "DiscordChatExporter.Cli.Tests/Specs/HtmlMentionSpecs.cs", "DiscordChatExporter.Cli.Tests/Specs/JsonMentionSpecs.cs", "DiscordChatExporter.Core/Discord/DiscordClient.cs", "DiscordChatExporter.Core/Exporting/ExportContext.cs", "DiscordChatExporter.Core/Exporting/HtmlMarkdownVisitor.cs", "DiscordChatExporte...
[ { "comment": "Can we rewrite GetChannel so that it calls this instead? Or are there downsides to that?", "path": "DiscordChatExporter.Core/Discord/DiscordClient.cs", "hunk": "@@ -388,6 +388,32 @@ public async ValueTask<Channel> GetChannelAsync(\n }\n }\n \n+ public async ValueTask<Channel...
diff --git a/DiscordChatExporter.Cli.Tests/Specs/HtmlMentionSpecs.cs b/DiscordChatExporter.Cli.Tests/Specs/HtmlMentionSpecs.cs index afb21b8fc..13374a74b 100644 --- a/DiscordChatExporter.Cli.Tests/Specs/HtmlMentionSpecs.cs +++ b/DiscordChatExporter.Cli.Tests/Specs/HtmlMentionSpecs.cs @@ -61,4 +61,17 @@ public async Tas...
true
Tyrrrz/DiscordChatExporter
1,474
issue_to_patch
Youtube thumbnails not working ### Version v2.46.0 ### Flavor GUI (Graphical User Interface) ### Platform Windows 10 ### Export format HTML ### Steps to reproduce - Steps: 1. Export a channel of 100 messages 2. The youtube thumbnails dont load, as seen below <img width="1681" height="768" alt="Image" src="h...
Replace YouTube iframe embeds with clickable thumbnails
## Fix YouTube thumbnails not loading (Closes #1472) **Problem:** YouTube embeds are not loading because YouTube's iframe is being blocked (X-Frame-Options or CSP headers). **Solution:** Replace the iframe with a clickable thumbnail image that links to the YouTube video URL. ### Completed Work: - [x] Understand the ...
225230a20f636ba386ce81d311b33c2670de509b
c28ec13524a0f788030c005202c54d4d3114bfae
diff --git a/DiscordChatExporter.Core/Discord/Data/Embeds/YouTubeVideoEmbedProjection.cs b/DiscordChatExporter.Core/Discord/Data/Embeds/YouTubeVideoEmbedProjection.cs index ce13bdfd8..f6d095d28 100644 --- a/DiscordChatExporter.Core/Discord/Data/Embeds/YouTubeVideoEmbedProjection.cs +++ b/DiscordChatExporter.Core/Discor...
[ "DiscordChatExporter.Cli.Tests/Specs/HtmlEmbedSpecs.cs", "DiscordChatExporter.Core/Discord/Data/Embeds/YouTubeVideoEmbedProjection.cs", "DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml", "DiscordChatExporter.Core/Exporting/PreambleTemplate.cshtml" ]
[ { "comment": "Avoid relying on the HTML structure in tests as it's pretty volatile. Focus on actual data.", "path": "DiscordChatExporter.Cli.Tests/Specs/HtmlEmbedSpecs.cs", "hunk": "@@ -181,8 +181,24 @@ public async Task I_can_export_a_channel_that_contains_a_message_with_a_YouTube_\n );\n \n ...
diff --git a/DiscordChatExporter.Cli.Tests/Specs/HtmlEmbedSpecs.cs b/DiscordChatExporter.Cli.Tests/Specs/HtmlEmbedSpecs.cs index 207e80412..a959d462b 100644 --- a/DiscordChatExporter.Cli.Tests/Specs/HtmlEmbedSpecs.cs +++ b/DiscordChatExporter.Cli.Tests/Specs/HtmlEmbedSpecs.cs @@ -181,8 +181,14 @@ public async Task I_ca...
true
Tyrrrz/DiscordChatExporter
1,475
issue_to_patch
Asset viewing of HTML files broken (Firefox) ### Version 2.46.0 ### Flavor GUI (Graphical User Interface) ### Platform Windows 11 ### Export format HTML ### Steps to reproduce 1. Export HTML file with downloaded assets 2. Open 3. The assets do not show ### Details When replacing the asset path in the HTML f...
Add file:// protocol to absolute asset paths in HTML exports
HTML exports with absolute asset paths fail to load in Firefox when opened locally. Browsers require the `file://` protocol for local file URIs, but the current implementation only URL-encodes the path without adding the protocol prefix. Closes #1473 ## Changes Modified `Url.EncodeFilePath()` to detect absolute path...
225230a20f636ba386ce81d311b33c2670de509b
9372ef87e8056bc73d378cbe77cc832d96d73333
diff --git a/DiscordChatExporter.Core/Utils/Url.cs b/DiscordChatExporter.Core/Utils/Url.cs index 9ccbd30dc..6e1e478e3 100644 --- a/DiscordChatExporter.Core/Utils/Url.cs +++ b/DiscordChatExporter.Core/Utils/Url.cs @@ -1,4 +1,5 @@ ο»Ώusing System; +using System.IO; using System.Text; namespace DiscordChatExporter.Core...
[ "DiscordChatExporter.Core/Utils/Url.cs" ]
[ { "comment": "Can't we use something like Path.IsPathFullyQualified?", "path": "DiscordChatExporter.Core/Utils/Url.cs", "hunk": "@@ -10,6 +10,27 @@ public static string EncodeFilePath(string filePath)\n var buffer = new StringBuilder();\n var position = 0;\n \n+ // Check if the pa...
true
Tyrrrz/DiscordChatExporter
1,500
issue_to_patch
Add `DISCORDCHATEXPORTER_SETTINGS_PATH` env var override for settings file path
`SettingsService` hardcoded the settings file path to `AppContext.BaseDirectory/Settings.dat`. This adds support for overriding it via the `DISCORDCHATEXPORTER_SETTINGS_PATH` environment variable, mirroring the same pattern already used in `YoutubeDownloader`. ## Changes - **`DiscordChatExporter.Gui/StartOptions.cs`*...
dadfe5b8efc59422f9b66ba74c6bace5530e6ffd
d9f93c4b6a611ab4fdd666d2a741278d48aa9370
diff --git a/DiscordChatExporter.Gui/Services/SettingsService.cs b/DiscordChatExporter.Gui/Services/SettingsService.cs index ebd4ca784..50581178d 100644 --- a/DiscordChatExporter.Gui/Services/SettingsService.cs +++ b/DiscordChatExporter.Gui/Services/SettingsService.cs @@ -1,6 +1,4 @@ -ο»Ώusing System; -using System.IO; -...
[ "DiscordChatExporter.Gui/Services/SettingsService.cs", "DiscordChatExporter.Gui/StartOptions.cs" ]
[]
true
Tyrrrz/DiscordChatExporter
1,499
issue_to_patch
Guard App.Dispose() against double-invocation and late shutdown
On some platforms, `App.Dispose()` called from `Program.Main(...)` fires too late in the shutdown lifecycle, risking settings and other resources not being released correctly. ### Changes - **Early disposal via exit handler** β€” registers a self-unsubscribing `OnExit` local function on `desktop.Exit` in `OnFrameworkIn...
4f29fa63d0701fe116edbf644c992fa3b3e9f5f2
4abd80f9c16d29f17fec48fcc136fbc35b62ac76
diff --git a/DiscordChatExporter.Gui/App.axaml.cs b/DiscordChatExporter.Gui/App.axaml.cs index 0673e3f45..bb27f1d64 100644 --- a/DiscordChatExporter.Gui/App.axaml.cs +++ b/DiscordChatExporter.Gui/App.axaml.cs @@ -26,6 +26,8 @@ public class App : Application, IDisposable private readonly SettingsService _settingsSe...
[ "DiscordChatExporter.Gui/App.axaml.cs" ]
[]
true
Tyrrrz/DiscordChatExporter
1,495
issue_to_patch
Bump the actions group with 2 updates
Bumps the actions group with 2 updates: [actions/upload-artifact](https://github.com/actions/upload-artifact) and [actions/download-artifact](https://github.com/actions/download-artifact). Updates `actions/upload-artifact` from 6.0.0 to 7.0.0 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="http...
3be5bc6a21a378a2b0246e4a26c638645bd8c1a2
3edfc736c54f78c6489a1d96f97cd6f26374d21e
diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index 9bb825c41..d188536c9 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -37,7 +37,7 @@ jobs: --output type=tar,dest=DiscordChatExporter.Cli.Docker.tar - name: Upload image - uses: actio...
[ ".github/workflows/docker.yml", ".github/workflows/main.yml" ]
[]
true
Tyrrrz/DiscordChatExporter
1,496
issue_to_patch
Bump the nuget group with 15 updates
Updated [AsyncImageLoader.Avalonia](https://github.com/AvaloniaUtils/AsyncImageLoader.Avalonia) from 3.5.0 to 3.6.0. <details> <summary>Release notes</summary> _Sourced from [AsyncImageLoader.Avalonia's releases](https://github.com/AvaloniaUtils/AsyncImageLoader.Avalonia/releases)._ ## 3.6.0 ## What's Changed * Add...
3be5bc6a21a378a2b0246e4a26c638645bd8c1a2
104061d80eb8e11677c4b8623232542d4aeafbc0
diff --git a/Directory.Packages.props b/Directory.Packages.props index f4cfb4351..ebbc74542 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -5,16 +5,16 @@ <ItemGroup> <PackageVersion Include="AngleSharp" Version="1.4.0" /> - <PackageVersion Include="AsyncImageLoader.Avalonia" Versio...
[ "Directory.Packages.props" ]
[]
true
Tyrrrz/DiscordChatExporter
1,493
issue_to_patch
Double-clicking a channel auto-opens export setup
Adds a `DoubleTapped` handler to the individual channel's `Grid` inside the `TreeDataTemplate` in `DashboardView.axaml`. Double-clicking a non-category channel item directly invokes `ExportCommand`, opening the export setup dialog without needing to click the export button separately. Because the handler is attached d...
98e294f7e46b75b34eff45211da588ed9207f4ae
d6a70484c11f5710662bafb324d2370ac83c3e20
diff --git a/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml b/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml index f0218b4ee..6339b0f05 100644 --- a/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml +++ b/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml @@ -160,7 +160,...
[ "DiscordChatExporter.Gui/Views/Components/DashboardView.axaml", "DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs" ]
[ { "comment": "Just call `ExportCommand`. You can safely assume only one channel is selected. @copilot \n\nBut make sure that this only works when clicked on a channel that is not a category.", "path": "DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs", "hunk": "@@ -22,6 +23,9 @@ private v...
true
Tyrrrz/DiscordChatExporter
1,493
comment_to_fix
Double-clicking a channel auto-opens export setup
Just call `ExportCommand`. You can safely assume only one channel is selected. @copilot But make sure that this only works when clicked on a channel that is not a category.
98e294f7e46b75b34eff45211da588ed9207f4ae
d6a70484c11f5710662bafb324d2370ac83c3e20
diff --git a/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs b/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs index 0cf9d82cd..9ee315ed1 100644 --- a/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs +++ b/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs @@ ...
[ "DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs" ]
[ { "comment": "Just call `ExportCommand`. You can safely assume only one channel is selected. @copilot \n\nBut make sure that this only works when clicked on a channel that is not a category.", "path": "DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs", "hunk": "@@ -22,6 +23,9 @@ private v...
true
Tyrrrz/DiscordChatExporter
1,493
comment_to_fix
Double-clicking a channel auto-opens export setup
No, I meant the selected channel is singular and is not a category @copilot
98e294f7e46b75b34eff45211da588ed9207f4ae
d6a70484c11f5710662bafb324d2370ac83c3e20
diff --git a/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs b/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs index 0cf9d82cd..9ee315ed1 100644 --- a/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs +++ b/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs @@ ...
[ "DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs" ]
[ { "comment": "No, I meant the selected channel is singular and is not a category @copilot ", "path": "DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs", "hunk": "@@ -22,6 +23,21 @@ private void AvailableGuildsListBox_OnSelectionChanged(\n SelectionChangedEventArgs args\n ) => ...
true
Tyrrrz/DiscordChatExporter
1,493
comment_to_fix
Double-clicking a channel auto-opens export setup
This double-tap path relies on `AvailableChannels` already being loaded. When double-clicking a *new/unselected* guild, the first click triggers `SelectionChanged` -> `PullChannelsAsync()` which sets `IsBusy=true` (disabling the whole panel) and sets `AvailableChannels=null`, so the second click typically can't satisfy...
98e294f7e46b75b34eff45211da588ed9207f4ae
d6a70484c11f5710662bafb324d2370ac83c3e20
diff --git a/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs b/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs index 0cf9d82cd..9ee315ed1 100644 --- a/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs +++ b/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs @@ ...
[ "DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs" ]
[ { "comment": "This double-tap path relies on `AvailableChannels` already being loaded. When double-clicking a *new/unselected* guild, the first click triggers `SelectionChanged` -> `PullChannelsAsync()` which sets `IsBusy=true` (disabling the whole panel) and sets `AvailableChannels=null`, so the second click t...
true
Tyrrrz/DiscordChatExporter
1,493
comment_to_fix
Double-clicking a channel auto-opens export setup
The handler doesn't verify that the double-tap occurred on an actual `ListBoxItem` (vs empty space inside the `ListBox`). With the current wiring, double-clicking the guild list background could unexpectedly open export if the currently loaded guild happens to have exactly one eligible channel. Consider checking `args....
98e294f7e46b75b34eff45211da588ed9207f4ae
d6a70484c11f5710662bafb324d2370ac83c3e20
diff --git a/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs b/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs index 0cf9d82cd..9ee315ed1 100644 --- a/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs +++ b/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs @@ ...
[ "DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs" ]
[ { "comment": "The handler doesn't verify that the double-tap occurred on an actual `ListBoxItem` (vs empty space inside the `ListBox`). With the current wiring, double-clicking the guild list background could unexpectedly open export if the currently loaded guild happens to have exactly one eligible channel. Co...
true
Tyrrrz/DiscordChatExporter
1,493
comment_to_fix
Double-clicking a channel auto-opens export setup
Add braces
98e294f7e46b75b34eff45211da588ed9207f4ae
d6a70484c11f5710662bafb324d2370ac83c3e20
diff --git a/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs b/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs index 0cf9d82cd..9ee315ed1 100644 --- a/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs +++ b/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs @@ ...
[ "DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs" ]
[ { "comment": "Add braces", "path": "DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs", "hunk": "@@ -22,6 +23,17 @@ private void AvailableGuildsListBox_OnSelectionChanged(\n SelectionChangedEventArgs args\n ) => DataContext.PullChannelsCommand.Execute(null);\n \n+ private vo...
true
Tyrrrz/DiscordChatExporter
1,493
comment_to_fix
Double-clicking a channel auto-opens export setup
Why not add this handler to the channels tree view item template?
98e294f7e46b75b34eff45211da588ed9207f4ae
d6a70484c11f5710662bafb324d2370ac83c3e20
diff --git a/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml b/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml index f0218b4ee..6339b0f05 100644 --- a/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml +++ b/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml @@ -160,7 +160,...
[ "DiscordChatExporter.Gui/Views/Components/DashboardView.axaml" ]
[ { "comment": "Why not add this handler to the channels tree view item template?", "path": "DiscordChatExporter.Gui/Views/Components/DashboardView.axaml", "hunk": "@@ -100,6 +100,7 @@\n BorderThickness=\"0,0,1,0\">\n <ListBox\n x:Name=\"Avai...
true
Tyrrrz/DiscordChatExporter
1,493
comment_to_fix
Double-clicking a channel auto-opens export setup
Why guild when we're exporting channels?
98e294f7e46b75b34eff45211da588ed9207f4ae
d6a70484c11f5710662bafb324d2370ac83c3e20
diff --git a/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs b/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs index 0cf9d82cd..9ee315ed1 100644 --- a/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs +++ b/DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs @@ ...
[ "DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs" ]
[ { "comment": "Why guild when we're exporting channels?", "path": "DiscordChatExporter.Gui/Views/Components/DashboardView.axaml.cs", "hunk": "@@ -22,6 +23,25 @@ private void AvailableGuildsListBox_OnSelectionChanged(\n SelectionChangedEventArgs args\n ) => DataContext.PullChannelsCommand.Exec...
true
Tyrrrz/DiscordChatExporter
1,451
issue_to_patch
Forwarded messages appear as empty in export ### Version v2.44.0 ### Flavor GUI (Graphical User Interface), CLI (Command-Line Interface) ### Platform Windows 10 ### Export format HTML, TXT, JSON, CSV ### Steps to reproduce - Export any channel containing forwarded messages with any settings. - Download asse...
Implement exporting for forwarded messages
IMPORTANT DISCLAIMER: The changes here were implemented with Cursor using Claude Opus 4.5. Please review all changes made diligently. So I have been using this application quite a bit recently and as quite a few people have already realized, it does not yet have functionality to handle forwarded messages. As that...
d490fd0a3886a163defc1b595b9e255a27baa242
c682fd438178935bbdb48871312652871582dbce
diff --git a/DiscordChatExporter.Core/Discord/Data/Message.cs b/DiscordChatExporter.Core/Discord/Data/Message.cs index 22407f6f4..81496ef42 100644 --- a/DiscordChatExporter.Core/Discord/Data/Message.cs +++ b/DiscordChatExporter.Core/Discord/Data/Message.cs @@ -27,7 +27,8 @@ public partial record Message( IReadOnly...
[ "DiscordChatExporter.Core/Discord/Data/Message.cs", "DiscordChatExporter.Core/Discord/Data/MessageReference.cs", "DiscordChatExporter.Core/Discord/Data/MessageReferenceKind.cs", "DiscordChatExporter.Core/Discord/Data/MessageSnapshot.cs", "DiscordChatExporter.Core/Exporting/JsonMessageWriter.cs", "DiscordC...
[ { "comment": "```suggestion\n public bool IsForwarded { get; } = Reference?.Kind == MessageReferenceKind.Forward;\n```\n\nAnd maybe move it after `IsReplyLike`", "path": "DiscordChatExporter.Core/Discord/Data/Message.cs", "hunk": "@@ -27,14 +27,18 @@ public partial record Message(\n IReadOnlyList...
true
Tyrrrz/DiscordChatExporter
1,451
comment_to_fix
Implement exporting for forwarded messages
When might this occur?
d490fd0a3886a163defc1b595b9e255a27baa242
c682fd438178935bbdb48871312652871582dbce
diff --git a/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml b/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml index 556f92105..9ec95032b 100644 --- a/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml +++ b/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml @@ -262...
[ "DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml" ]
[ { "comment": "When might this occur?", "path": "DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml", "hunk": "@@ -262,6 +262,99 @@\n </div>\n }\n \n+ @* Forwarded message content *@\n+ @if (message.IsForward &&...
true
Tyrrrz/DiscordChatExporter
1,451
comment_to_fix
Implement exporting for forwarded messages
Why was this needed?
d490fd0a3886a163defc1b595b9e255a27baa242
c682fd438178935bbdb48871312652871582dbce
diff --git a/DiscordChatExporter.Gui/Framework/DialogManager.cs b/DiscordChatExporter.Gui/Framework/DialogManager.cs index 65666ceae..c87622f09 100644 --- a/DiscordChatExporter.Gui/Framework/DialogManager.cs +++ b/DiscordChatExporter.Gui/Framework/DialogManager.cs @@ -40,7 +40,7 @@ await DialogHost.Show( )...
[ "DiscordChatExporter.Gui/Framework/DialogManager.cs" ]
[ { "comment": "Why was this needed?", "path": "DiscordChatExporter.Gui/Framework/DialogManager.cs", "hunk": "@@ -38,6 +38,10 @@ await DialogHost.Show(\n }\n );\n \n+ // Small delay to allow DialogHost to fully reset its state\n+ // before another dialog c...
true
Tyrrrz/DiscordChatExporter
1,451
comment_to_fix
Implement exporting for forwarded messages
This delay appears to be a workaround for a timing issue rather than a proper fix. A hardcoded 100ms delay is fragile and may not work reliably across different systems or under different load conditions. Consider investigating the root cause of why DialogHost needs time to reset its state, or implement a more robust s...
d490fd0a3886a163defc1b595b9e255a27baa242
c682fd438178935bbdb48871312652871582dbce
diff --git a/DiscordChatExporter.Gui/Framework/DialogManager.cs b/DiscordChatExporter.Gui/Framework/DialogManager.cs index 65666ceae..c87622f09 100644 --- a/DiscordChatExporter.Gui/Framework/DialogManager.cs +++ b/DiscordChatExporter.Gui/Framework/DialogManager.cs @@ -40,7 +40,7 @@ await DialogHost.Show( )...
[ "DiscordChatExporter.Gui/Framework/DialogManager.cs" ]
[ { "comment": "This delay appears to be a workaround for a timing issue rather than a proper fix. A hardcoded 100ms delay is fragile and may not work reliably across different systems or under different load conditions. Consider investigating the root cause of why DialogHost needs time to reset its state, or imp...
true
Tyrrrz/DiscordChatExporter
1,451
comment_to_fix
Implement exporting for forwarded messages
The condition checks ForwardedMessage is not null but the IsForward property already exists on the Message class. Since IsForward is designed to indicate when a message is a forward (Reference?.Kind == MessageReferenceKind.Forward), consider using IsForward here for better semantic clarity and consistency. However, not...
d490fd0a3886a163defc1b595b9e255a27baa242
c682fd438178935bbdb48871312652871582dbce
diff --git a/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml b/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml index 556f92105..9ec95032b 100644 --- a/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml +++ b/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml @@ -262...
[ "DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml" ]
[ { "comment": "The condition checks ForwardedMessage is not null but the IsForward property already exists on the Message class. Since IsForward is designed to indicate when a message is a forward (Reference?.Kind == MessageReferenceKind.Forward), consider using IsForward here for better semantic clarity and con...
true
Tyrrrz/DiscordChatExporter
1,451
comment_to_fix
Implement exporting for forwarded messages
This feature implementation lacks test coverage. Based on the existing test suite structure (e.g., HtmlReplySpecs.cs, JsonContentSpecs.cs), consider adding test cases for forwarded messages across all export formats (HTML, JSON, CSV, PlainText). Tests should verify that forwarded message content, attachments, stickers,...
d490fd0a3886a163defc1b595b9e255a27baa242
c682fd438178935bbdb48871312652871582dbce
diff --git a/DiscordChatExporter.Core/Discord/Data/Message.cs b/DiscordChatExporter.Core/Discord/Data/Message.cs index 22407f6f4..81496ef42 100644 --- a/DiscordChatExporter.Core/Discord/Data/Message.cs +++ b/DiscordChatExporter.Core/Discord/Data/Message.cs @@ -27,7 +27,8 @@ public partial record Message( IReadOnly...
[ "DiscordChatExporter.Core/Discord/Data/Message.cs" ]
[ { "comment": "This feature implementation lacks test coverage. Based on the existing test suite structure (e.g., HtmlReplySpecs.cs, JsonContentSpecs.cs), consider adding test cases for forwarded messages across all export formats (HTML, JSON, CSV, PlainText). Tests should verify that forwarded message content, ...
true
Tyrrrz/DiscordChatExporter
1,451
comment_to_fix
Implement exporting for forwarded messages
The HTML template does not render embeds for forwarded messages. While attachments and stickers are handled (lines 285-342), embeds from fwd.Embeds are never displayed. This is inconsistent with how regular message embeds are rendered and with the other export formats (JSON and PlainText) which do include forwarded emb...
d490fd0a3886a163defc1b595b9e255a27baa242
c682fd438178935bbdb48871312652871582dbce
diff --git a/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml b/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml index 556f92105..9ec95032b 100644 --- a/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml +++ b/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml @@ -262...
[ "DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml" ]
[ { "comment": "The HTML template does not render embeds for forwarded messages. While attachments and stickers are handled (lines 285-342), embeds from fwd.Embeds are never displayed. This is inconsistent with how regular message embeds are rendered and with the other export formats (JSON and PlainText) which do...
true
Tyrrrz/DiscordChatExporter
1,451
comment_to_fix
Implement exporting for forwarded messages
The CSS class chatlog__forward-symbol is defined but never used in the MessageGroupTemplate. This styling appears intended to provide a visual indicator similar to chatlog__reply-symbol for replies, but it's not being applied anywhere in the template. Consider adding this visual element to the forwarded message renderi...
d490fd0a3886a163defc1b595b9e255a27baa242
c682fd438178935bbdb48871312652871582dbce
diff --git a/DiscordChatExporter.Core/Exporting/PreambleTemplate.cshtml b/DiscordChatExporter.Core/Exporting/PreambleTemplate.cshtml index 792612c78..3b9cad68a 100644 --- a/DiscordChatExporter.Core/Exporting/PreambleTemplate.cshtml +++ b/DiscordChatExporter.Core/Exporting/PreambleTemplate.cshtml @@ -304,6 +304,52 @@ ...
[ "DiscordChatExporter.Core/Exporting/PreambleTemplate.cshtml" ]
[ { "comment": "The CSS class chatlog__forward-symbol is defined but never used in the MessageGroupTemplate. This styling appears intended to provide a visual indicator similar to chatlog__reply-symbol for replies, but it's not being applied anywhere in the template. Consider adding this visual element to the for...
true
Tyrrrz/DiscordChatExporter
1,451
comment_to_fix
Implement exporting for forwarded messages
Inconsistent CSS class usage for audio attachments in forwarded messages. While images and videos use the `chatlog__forwarded-attachment` class, audio elements use `chatlog__attachment-media`. For consistency, audio attachments should also use `chatlog__forwarded-attachment` like the other media types in this section. ...
d490fd0a3886a163defc1b595b9e255a27baa242
c682fd438178935bbdb48871312652871582dbce
diff --git a/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml b/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml index 556f92105..9ec95032b 100644 --- a/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml +++ b/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml @@ -262...
[ "DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml" ]
[ { "comment": "Inconsistent CSS class usage for audio attachments in forwarded messages. While images and videos use the `chatlog__forwarded-attachment` class, audio elements use `chatlog__attachment-media`. For consistency, audio attachments should also use `chatlog__forwarded-attachment` like the other media t...
true
Tyrrrz/DiscordChatExporter
1,492
issue_to_patch
Cleanup: fix filename typo, replace AsyncNonKeyedLocker, drop WithIndex(), use ProcessStartInfo ctor arg
Four small consistency fixes to align with patterns used in sibling repos. - **Rename** `DialogVIewModelBase.cs` β†’ `DialogViewModelBase.cs` (capital `I` typo) - **`DialogManager`**: replace `AsyncNonKeyedLocker` (third-party) with `SemaphoreSlim`, remove `using AsyncKeyedLock` ```csharp // Before private readonl...
3391e755fc9431fe19877c57682117001e31cce1
2027b1380a1b4b63edbdad5dd4e404773367e6c3
diff --git a/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml b/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml index 641c2ada5..556f92105 100644 --- a/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml +++ b/DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml @@ -34,...
[ "DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml", "DiscordChatExporter.Core/Exporting/PlainTextMessageWriter.cs", "DiscordChatExporter.Core/Utils/Extensions/CollectionExtensions.cs", "DiscordChatExporter.Gui/Framework/DialogManager.cs", "DiscordChatExporter.Gui/Framework/DialogViewModelBase....
[]
true
Tyrrrz/DiscordChatExporter
1,491
issue_to_patch
Encrypt Discord token at rest in settings file (machine-bound)
- [x] In `Read()`: `cipher` naming (encrypted data being read) - [x] In `Write()`: `cipherSource` variable for plaintext span before in-place encryption; layout comment with size annotation - [x] Fix CSharpier formatting in 5 localization files (`PersistTokenTooltip = """` inline) - [x] Fix CSharpier formatting in `Tok...
c59374598a47008b0e86ba37cfaf47207739241d
98bd5d9578af346214e3158392d538cbdfa6fb09
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 5bccbc84c..eccfb44a1 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -127,6 +127,7 @@ jobs: dotnet publish ${{ matrix.app }} -p:Version=${{ github.ref_type == 'tag' && github.ref_name || format('...
[ ".github/workflows/main.yml", "Directory.Packages.props", "DiscordChatExporter.Gui/DiscordChatExporter.Gui.csproj", "DiscordChatExporter.Gui/Localization/LocalizationManager.English.cs", "DiscordChatExporter.Gui/Localization/LocalizationManager.French.cs", "DiscordChatExporter.Gui/Localization/Localizatio...
[ { "comment": "```suggestion\n```", "path": "DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs", "hunk": "@@ -0,0 +1,74 @@\n+using System;\n+using System.Security.Cryptography;\n+using System.Text;\n+using System.Text.Json;\n+using System.Text.Json.Serialization;\n+\n+namespace DiscordChatExpo...
true
Tyrrrz/DiscordChatExporter
1,491
comment_to_fix
Encrypt Discord token at rest in settings file (machine-bound)
```suggestion ```
c59374598a47008b0e86ba37cfaf47207739241d
98bd5d9578af346214e3158392d538cbdfa6fb09
diff --git a/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs new file mode 100644 index 000000000..c9e70d6ce --- /dev/null +++ b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs @@ -0,0 +1,90 @@ +using System; +using System.Security...
[ "DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs" ]
[ { "comment": "```suggestion\n```", "path": "DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs", "hunk": "@@ -0,0 +1,74 @@\n+using System;\n+using System.Security.Cryptography;\n+using System.Text;\n+using System.Text.Json;\n+using System.Text.Json.Serialization;\n+\n+namespace DiscordChatExpo...
true
Tyrrrz/DiscordChatExporter
1,491
comment_to_fix
Encrypt Discord token at rest in settings file (machine-bound)
```suggestion if (string.IsNullOrWhiteSpace(value) || !value.StartsWith(Prefix, StringComparison.Ordinal)) ```
c59374598a47008b0e86ba37cfaf47207739241d
98bd5d9578af346214e3158392d538cbdfa6fb09
diff --git a/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs new file mode 100644 index 000000000..c9e70d6ce --- /dev/null +++ b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs @@ -0,0 +1,90 @@ +using System; +using System.Security...
[ "DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs" ]
[ { "comment": "```suggestion\n if (string.IsNullOrWhiteSpace(value) || !value.StartsWith(Prefix, StringComparison.Ordinal))\n```", "path": "DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs", "hunk": "@@ -0,0 +1,73 @@\n+using System;\n+using System.Security.Cryptography;\n+using System....
true
Tyrrrz/DiscordChatExporter
1,491
comment_to_fix
Encrypt Discord token at rest in settings file (machine-bound)
The serialized payload has no explicit format/version marker (prefix is just `enc:`), even though the key is labeled `...-v1`. If the key/algorithm ever changes, existing tokens will become undecryptable and will be silently cleared. Consider embedding a version (e.g., `enc:v1:` or a version byte in the blob) so future...
c59374598a47008b0e86ba37cfaf47207739241d
98bd5d9578af346214e3158392d538cbdfa6fb09
diff --git a/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs new file mode 100644 index 000000000..c9e70d6ce --- /dev/null +++ b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs @@ -0,0 +1,90 @@ +using System; +using System.Security...
[ "DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs" ]
[ { "comment": "The serialized payload has no explicit format/version marker (prefix is just `enc:`), even though the key is labeled `...-v1`. If the key/algorithm ever changes, existing tokens will become undecryptable and will be silently cleared. Consider embedding a version (e.g., `enc:v1:` or a version byte ...
true
Tyrrrz/DiscordChatExporter
1,491
comment_to_fix
Encrypt Discord token at rest in settings file (machine-bound)
`Read()` swallows all exceptions and returns `null`. This can hide unexpected failures and also makes any malformed `enc:` value (too short, invalid Base64, out-of-range pad length) silently wipe the persisted token on the next save. Consider validating `data.Length` / `padLen` up-front and narrowing the catch to expec...
c59374598a47008b0e86ba37cfaf47207739241d
98bd5d9578af346214e3158392d538cbdfa6fb09
diff --git a/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs new file mode 100644 index 000000000..c9e70d6ce --- /dev/null +++ b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs @@ -0,0 +1,90 @@ +using System; +using System.Security...
[ "DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs" ]
[ { "comment": "`Read()` swallows all exceptions and returns `null`. This can hide unexpected failures and also makes any malformed `enc:` value (too short, invalid Base64, out-of-range pad length) silently wipe the persisted token on the next save. Consider validating `data.Length` / `padLen` up-front and narrow...
true
Tyrrrz/DiscordChatExporter
1,491
comment_to_fix
Encrypt Discord token at rest in settings file (machine-bound)
Use `RandomNumberGenerator.GetBytes(int)`
c59374598a47008b0e86ba37cfaf47207739241d
98bd5d9578af346214e3158392d538cbdfa6fb09
diff --git a/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs new file mode 100644 index 000000000..c9e70d6ce --- /dev/null +++ b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs @@ -0,0 +1,90 @@ +using System; +using System.Security...
[ "DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs" ]
[ { "comment": "Use `RandomNumberGenerator.GetBytes(int)`", "path": "DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs", "hunk": "@@ -0,0 +1,73 @@\n+using System;\n+using System.Security.Cryptography;\n+using System.Text;\n+using System.Text.Json;\n+using System.Text.Json.Serialization;\n+\n+na...
true
Tyrrrz/DiscordChatExporter
1,491
comment_to_fix
Encrypt Discord token at rest in settings file (machine-bound)
```suggestion "Save the last used token to a file so that it can be persisted between sessions. **Warning**: although the token is stored encrypted, it may still be recovered by an attacker who has access to your system.", ``` Let's update other translations accordingly
c59374598a47008b0e86ba37cfaf47207739241d
98bd5d9578af346214e3158392d538cbdfa6fb09
diff --git a/DiscordChatExporter.Gui/Localization/LocalizationManager.English.cs b/DiscordChatExporter.Gui/Localization/LocalizationManager.English.cs index 7f7fc479d..165ac567e 100644 --- a/DiscordChatExporter.Gui/Localization/LocalizationManager.English.cs +++ b/DiscordChatExporter.Gui/Localization/LocalizationManage...
[ "DiscordChatExporter.Gui/Localization/LocalizationManager.English.cs" ]
[ { "comment": "```suggestion\n \"Save the last used token to a file so that it can be persisted between sessions. **Warning**: although the token is stored encrypted, it may still be recovered by an attacker who has access to your system.\",\n```\n\nLet's update other translations accordingly", ...
true
Tyrrrz/DiscordChatExporter
1,491
comment_to_fix
Encrypt Discord token at rest in settings file (machine-bound)
I think the salt should be injected in CI during build, while local builds use a fallback. Let's find a way how to best achieve that.
c59374598a47008b0e86ba37cfaf47207739241d
98bd5d9578af346214e3158392d538cbdfa6fb09
diff --git a/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs new file mode 100644 index 000000000..c9e70d6ce --- /dev/null +++ b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs @@ -0,0 +1,90 @@ +using System; +using System.Security...
[ "DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs" ]
[ { "comment": "I think the salt should be injected in CI during build, while local builds use a fallback. Let's find a way how to best achieve that.", "path": "DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs", "hunk": "@@ -0,0 +1,146 @@\n+using System;\n+using System.IO;\n+using System.Secur...
true
Tyrrrz/DiscordChatExporter
1,491
comment_to_fix
Encrypt Discord token at rest in settings file (machine-bound)
```suggestion // Key is derived from a machine-specific identifier so that a stolen settings file ```
c59374598a47008b0e86ba37cfaf47207739241d
98bd5d9578af346214e3158392d538cbdfa6fb09
diff --git a/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs new file mode 100644 index 000000000..c9e70d6ce --- /dev/null +++ b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs @@ -0,0 +1,90 @@ +using System; +using System.Security...
[ "DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs" ]
[ { "comment": "```suggestion\n // Key is derived from a machine-specific identifier so that a stolen settings file\n```", "path": "DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs", "hunk": "@@ -0,0 +1,146 @@\n+using System;\n+using System.IO;\n+using System.Security.Cryptography;\n+using ...
true
Tyrrrz/DiscordChatExporter
1,491
comment_to_fix
Encrypt Discord token at rest in settings file (machine-bound)
```suggestion // cannot be easily decrypted on a different machine. ```
c59374598a47008b0e86ba37cfaf47207739241d
98bd5d9578af346214e3158392d538cbdfa6fb09
diff --git a/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs new file mode 100644 index 000000000..c9e70d6ce --- /dev/null +++ b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs @@ -0,0 +1,90 @@ +using System; +using System.Security...
[ "DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs" ]
[ { "comment": "```suggestion\n // cannot be easily decrypted on a different machine.\n```", "path": "DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs", "hunk": "@@ -0,0 +1,146 @@\n+using System;\n+using System.IO;\n+using System.Security.Cryptography;\n+using System.Text;\n+using System.Te...
true
Tyrrrz/DiscordChatExporter
1,491
comment_to_fix
Encrypt Discord token at rest in settings file (machine-bound)
```suggestion if (regKey?.GetValue("MachineGuid") is string guid && !string.IsNullOrWhiteSpace(guid)) ```
c59374598a47008b0e86ba37cfaf47207739241d
98bd5d9578af346214e3158392d538cbdfa6fb09
diff --git a/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs new file mode 100644 index 000000000..c9e70d6ce --- /dev/null +++ b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs @@ -0,0 +1,90 @@ +using System; +using System.Security...
[ "DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs" ]
[ { "comment": "```suggestion\n if (regKey?.GetValue(\"MachineGuid\") is string guid && !string.IsNullOrWhiteSpace(guid))\n```", "path": "DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs", "hunk": "@@ -0,0 +1,146 @@\n+using System;\n+using System.IO;\n+using System.Security.Cryp...
true
Tyrrrz/DiscordChatExporter
1,491
comment_to_fix
Encrypt Discord token at rest in settings file (machine-bound)
Use string.IsNullOrWhiteSpace
c59374598a47008b0e86ba37cfaf47207739241d
98bd5d9578af346214e3158392d538cbdfa6fb09
diff --git a/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs new file mode 100644 index 000000000..c9e70d6ce --- /dev/null +++ b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs @@ -0,0 +1,90 @@ +using System; +using System.Security...
[ "DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs" ]
[ { "comment": "Use string.IsNullOrWhiteSpace", "path": "DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs", "hunk": "@@ -0,0 +1,146 @@\n+using System;\n+using System.IO;\n+using System.Security.Cryptography;\n+using System.Text;\n+using System.Text.Json;\n+using System.Text.Json.Serialization;...
true
Tyrrrz/DiscordChatExporter
1,491
comment_to_fix
Encrypt Discord token at rest in settings file (machine-bound)
```suggestion // No prefix means the token is stored as plain text, which was // the case for older versions of the application. // Load it as is and encrypt it next time we save it. ```
c59374598a47008b0e86ba37cfaf47207739241d
98bd5d9578af346214e3158392d538cbdfa6fb09
diff --git a/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs new file mode 100644 index 000000000..c9e70d6ce --- /dev/null +++ b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs @@ -0,0 +1,90 @@ +using System; +using System.Security...
[ "DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs" ]
[ { "comment": "```suggestion\n // No prefix means the token is stored as plain text, which was\n // the case for older versions of the application.\n // Load it as is and encrypt it next time we save it.\n```", "path": "DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs", "...
true
Tyrrrz/DiscordChatExporter
1,491
comment_to_fix
Encrypt Discord token at rest in settings file (machine-bound)
Just warp the whole method in `try/catch` and handle `FormatException`/`CryptographicException` etc. We simply return `null` on all of them so it doesn't matter where that exception occurs.
c59374598a47008b0e86ba37cfaf47207739241d
98bd5d9578af346214e3158392d538cbdfa6fb09
diff --git a/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs new file mode 100644 index 000000000..c9e70d6ce --- /dev/null +++ b/DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs @@ -0,0 +1,90 @@ +using System; +using System.Security...
[ "DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs" ]
[ { "comment": "Just warp the whole method in `try/catch` and handle `FormatException`/`CryptographicException` etc. We simply return `null` on all of them so it doesn't matter where that exception occurs.", "path": "DiscordChatExporter.Gui/Services/TokenEncryptionConverter.cs", "hunk": "@@ -0,0 +1,146 @@...
true