repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
Tyrrrz/DiscordChatExporter | 1,482 | comment_to_fix | Add localization | Let's rename to `ErrorPullingServersTitle` to stay consistent with our internal naming conventions | 18086aa209f00a28262fc7287e96d0745c53da54 | c559f9eaded0ea7be5f1553ab4e175497ed9606c | diff --git a/DiscordChatExporter.Gui/ViewModels/Components/DashboardViewModel.cs b/DiscordChatExporter.Gui/ViewModels/Components/DashboardViewModel.cs
index ebd416c2d..ecbead8f8 100644
--- a/DiscordChatExporter.Gui/ViewModels/Components/DashboardViewModel.cs
+++ b/DiscordChatExporter.Gui/ViewModels/Components/Dashboard... | [
"DiscordChatExporter.Gui/ViewModels/Components/DashboardViewModel.cs"
] | [
{
"comment": "Let's rename to `ErrorPullingServersTitle` to stay consistent with our internal naming conventions",
"path": "DiscordChatExporter.Gui/ViewModels/Components/DashboardViewModel.cs",
"hunk": "@@ -141,7 +143,7 @@ private async Task PullGuildsAsync()\n catch (Exception ex)\n {\n... | true | ||
Tyrrrz/DiscordChatExporter | 1,482 | comment_to_fix | Add localization | Add curly braces for symmetry | 18086aa209f00a28262fc7287e96d0745c53da54 | c559f9eaded0ea7be5f1553ab4e175497ed9606c | diff --git a/DiscordChatExporter.Gui/Views/Controls/HyperLink.axaml.cs b/DiscordChatExporter.Gui/Views/Controls/HyperLink.axaml.cs
index 08452c12f..479303de5 100644
--- a/DiscordChatExporter.Gui/Views/Controls/HyperLink.axaml.cs
+++ b/DiscordChatExporter.Gui/Views/Controls/HyperLink.axaml.cs
@@ -1,7 +1,9 @@
-using Sys... | [
"DiscordChatExporter.Gui/Views/Controls/HyperLink.axaml.cs"
] | [
{
"comment": "Add curly braces for symmetry",
"path": "DiscordChatExporter.Gui/Views/Controls/HyperLink.axaml.cs",
"hunk": "@@ -36,14 +44,20 @@ public object? CommandParameter\n set => SetValue(CommandParameterProperty, value);\n }\n \n- private void TextBlock_OnPointerReleased(object? se... | true | ||
Tyrrrz/DiscordChatExporter | 1,482 | comment_to_fix | Add localization | The Url is opened in the default browser without any validation or sanitization. While the PR description mentions allowing "any valid absolute URI scheme", there's no actual validation that the URL is safe or well-formed. Consider adding URL validation to prevent potential security issues, such as verifying the URL sc... | 18086aa209f00a28262fc7287e96d0745c53da54 | c559f9eaded0ea7be5f1553ab4e175497ed9606c | diff --git a/DiscordChatExporter.Gui/Views/Controls/HyperLink.axaml.cs b/DiscordChatExporter.Gui/Views/Controls/HyperLink.axaml.cs
index 08452c12f..479303de5 100644
--- a/DiscordChatExporter.Gui/Views/Controls/HyperLink.axaml.cs
+++ b/DiscordChatExporter.Gui/Views/Controls/HyperLink.axaml.cs
@@ -1,7 +1,9 @@
-using Sys... | [
"DiscordChatExporter.Gui/Views/Controls/HyperLink.axaml.cs"
] | [
{
"comment": "The Url is opened in the default browser without any validation or sanitization. While the PR description mentions allowing \"any valid absolute URI scheme\", there's no actual validation that the URL is safe or well-formed. Consider adding URL validation to prevent potential security issues, such... | true | ||
Tyrrrz/DiscordChatExporter | 1,482 | comment_to_fix | Add localization | The bullet type is being rendered using the enum value directly (e.g., "Dash", "Plus") instead of the actual bullet character. For markdown lists with dash syntax, this will display "Dash " instead of "- ". Consider mapping the BulletType enum to the appropriate character (e.g., '-' for Dash, '+' for Plus, '*' for As... | 18086aa209f00a28262fc7287e96d0745c53da54 | c559f9eaded0ea7be5f1553ab4e175497ed9606c | diff --git a/DiscordChatExporter.Gui/Converters/MarkdownToInlinesConverter.cs b/DiscordChatExporter.Gui/Converters/MarkdownToInlinesConverter.cs
new file mode 100644
index 000000000..cb740fee6
--- /dev/null
+++ b/DiscordChatExporter.Gui/Converters/MarkdownToInlinesConverter.cs
@@ -0,0 +1,176 @@
+using System;
+using Sy... | [
"DiscordChatExporter.Gui/Converters/MarkdownToInlinesConverter.cs"
] | [
{
"comment": "The bullet type is being rendered using the enum value directly (e.g., \"Dash\", \"Plus\") instead of the actual bullet character. For markdown lists with dash syntax, this will display \"Dash \" instead of \"- \". Consider mapping the BulletType enum to the appropriate character (e.g., '-' for ... | true | ||
Tyrrrz/DiscordChatExporter | 1,482 | comment_to_fix | Add localization | The Convert method does not handle potential exceptions that could be thrown by Markdown.Parse() or during the processing of markdown blocks. If malformed markdown is provided or an unexpected block type is encountered, this could cause an unhandled exception. Consider wrapping the parsing and processing in a try-catch... | 18086aa209f00a28262fc7287e96d0745c53da54 | c559f9eaded0ea7be5f1553ab4e175497ed9606c | diff --git a/DiscordChatExporter.Gui/Converters/MarkdownToInlinesConverter.cs b/DiscordChatExporter.Gui/Converters/MarkdownToInlinesConverter.cs
new file mode 100644
index 000000000..cb740fee6
--- /dev/null
+++ b/DiscordChatExporter.Gui/Converters/MarkdownToInlinesConverter.cs
@@ -0,0 +1,176 @@
+using System;
+using Sy... | [
"DiscordChatExporter.Gui/Converters/MarkdownToInlinesConverter.cs"
] | [
{
"comment": "The Convert method does not handle potential exceptions that could be thrown by Markdown.Parse() or during the processing of markdown blocks. If malformed markdown is provided or an unexpected block type is encountered, this could cause an unhandled exception. Consider wrapping the parsing and pro... | true | ||
Tyrrrz/DiscordChatExporter | 1,481 | issue_to_patch | Fix second dialog not appearing when dialogs are shown sequentially | When two dialogs are shown back-to-back (e.g., "Support Ukraine" + "Unstable build warning" on first launch), the second dialog fails to appear and a `DialogHost` error is thrown.
`DialogHost.RemoveHost()` calls `TrySetResult()` to complete `ShowCore`'s task *before* setting `IsOpen = false`. When continuations run in... | dd7196b6a590169f4014165aae62ec801affbd6c | faf7250cebbe02186c8ed5a3fbe0e81ac3094684 | diff --git a/DiscordChatExporter.Gui/Framework/DialogManager.cs b/DiscordChatExporter.Gui/Framework/DialogManager.cs
index 0f6a8f861..68d49435c 100644
--- a/DiscordChatExporter.Gui/Framework/DialogManager.cs
+++ b/DiscordChatExporter.Gui/Framework/DialogManager.cs
@@ -38,6 +38,10 @@ await DialogHost.Show(
... | [
"DiscordChatExporter.Gui/Framework/DialogManager.cs"
] | [] | true | ||
Tyrrrz/DiscordChatExporter | 1,467 | issue_to_patch | Bump the actions group with 2 updates | Bumps the actions group with 2 updates: [actions/checkout](https://github.com/actions/checkout) and [actions/setup-dotnet](https://github.com/actions/setup-dotnet).
Updates `actions/checkout` from 6.0.1 to 6.0.2
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout... | 95953f8cf0ac551fb46c8e3cb7a3226c8e490629 | b95beaf1dbd2c9ad3d2fa858a76e8a5ebff9ea00 | diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml
index 2778981d4..9bb825c41 100644
--- a/.github/workflows/docker.yml
+++ b/.github/workflows/docker.yml
@@ -23,7 +23,7 @@ jobs:
steps:
- name: Checkout
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1... | [
".github/workflows/docker.yml",
".github/workflows/main.yml"
] | [] | true | ||
Tyrrrz/DiscordChatExporter | 1,468 | issue_to_patch | Bump the nuget group with 9 updates | Updated [AsyncKeyedLock](https://github.com/MarkCiliaVincenti/AsyncKeyedLock) from 7.1.8 to 8.0.1.
<details>
<summary>Release notes</summary>
_Sourced from [AsyncKeyedLock's releases](https://github.com/MarkCiliaVincenti/AsyncKeyedLock/releases)._
## 8.0.1
Cleaning and enforcing consistent SDK version for total rep... | 95953f8cf0ac551fb46c8e3cb7a3226c8e490629 | 295e9d897d93f41bf48455c53c47e496ce405bd7 | diff --git a/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj b/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj
index 500e7bedc..9cd8d3295 100644
--- a/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj
+++ b/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Test... | [
"DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj",
"DiscordChatExporter.Core/DiscordChatExporter.Core.csproj",
"DiscordChatExporter.Gui/DiscordChatExporter.Gui.csproj"
] | [] | true | ||
Tyrrrz/DiscordChatExporter | 1,460 | issue_to_patch | Change in data package structure
### Version
v2.46
### Flavor
CLI (Command-Line Interface)
### Platform
Linux
### Export format
HTML
### Steps to reproduce
Get current data package from Discord and try to use it with Cli
### Details
Got myself a new data package from Discord to export all messages from 2025... | Fix case-insensitive lookup for data package index file | ## Plan to Fix Case-Insensitive Data Package Structure Issue
- [x] Understand the issue: Discord changed data package structure from lowercase "messages/index.json" to "Messages/index.json"
- [x] Modify DataDump.cs to perform case-insensitive lookup for the channel index file
- [x] Build the Core project to verify cha... | f555ab3f00d4505c6d8a9457065bc75b37cd6b9b | 975ce249b7cc9274a114cac984822f2140e5b246 | diff --git a/.gitignore b/.gitignore
index ef8150c0e..20d4f3155 100644
--- a/.gitignore
+++ b/.gitignore
@@ -9,4 +9,4 @@ bin/
obj/
# Test results
-TestResults/
\ No newline at end of file
+TestResults/
diff --git a/DiscordChatExporter.Cli.Tests/Utils/TempDir.cs b/DiscordChatExporter.Cli.Tests/Utils/TempDir.cs
index... | [
".gitignore",
"DiscordChatExporter.Cli.Tests/Utils/TempDir.cs",
"DiscordChatExporter.Cli.Tests/Utils/TempFile.cs",
"DiscordChatExporter.Core/Discord/Data/Channel.cs",
"DiscordChatExporter.Core/Discord/Data/Embeds/Embed.cs",
"DiscordChatExporter.Core/Discord/Data/Guild.cs",
"DiscordChatExporter.Core/Disc... | [
{
"comment": "@copilot please add a link to the issue which highlights why this is necessary",
"path": "DiscordChatExporter.Core/Discord/Dump/DataDump.cs",
"hunk": "@@ -42,7 +43,12 @@ public static async ValueTask<DataDump> LoadAsync(\n {\n using var archive = ZipFile.OpenRead(zipFilePath);\... | true | |
Tyrrrz/DiscordChatExporter | 1,460 | comment_to_fix | Fix case-insensitive lookup for data package index file | @copilot please add a link to the issue which highlights why this is necessary | f555ab3f00d4505c6d8a9457065bc75b37cd6b9b | 975ce249b7cc9274a114cac984822f2140e5b246 | diff --git a/DiscordChatExporter.Core/Discord/Dump/DataDump.cs b/DiscordChatExporter.Core/Discord/Dump/DataDump.cs
index be3deb1c2..10a4832ca 100644
--- a/DiscordChatExporter.Core/Discord/Dump/DataDump.cs
+++ b/DiscordChatExporter.Core/Discord/Dump/DataDump.cs
@@ -1,6 +1,7 @@
using System;
using System.Collections.G... | [
"DiscordChatExporter.Core/Discord/Dump/DataDump.cs"
] | [
{
"comment": "@copilot please add a link to the issue which highlights why this is necessary",
"path": "DiscordChatExporter.Core/Discord/Dump/DataDump.cs",
"hunk": "@@ -42,7 +43,12 @@ public static async ValueTask<DataDump> LoadAsync(\n {\n using var archive = ZipFile.OpenRead(zipFilePath);\... | true | ||
Tyrrrz/DiscordChatExporter | 1,457 | issue_to_patch | Bump the actions group with 5 updates | Bumps the actions group with 5 updates:
| Package | From | To |
| --- | --- | --- |
| [actions/checkout](https://github.com/actions/checkout) | `6.0.0` | `6.0.1` |
| [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) | `3.11.1` | `3.12.0` |
| [actions/upload-artifact](https://github.com/action... | 1f63d4fa2655e0f63ad4573e2d7fd98f58e6047a | 49148fb07676e8a8f74c1cb59cc0d6c9f63fb268 | diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml
index 96a6869b6..2778981d4 100644
--- a/.github/workflows/docker.yml
+++ b/.github/workflows/docker.yml
@@ -23,10 +23,10 @@ jobs:
steps:
- name: Checkout
- uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0... | [
".github/workflows/docker.yml",
".github/workflows/main.yml"
] | [] | true | ||
Tyrrrz/DiscordChatExporter | 1,458 | issue_to_patch | Bump the nuget group with 11 updates | Updated [AsyncImageLoader.Avalonia](https://github.com/AvaloniaUtils/AsyncImageLoader.Avalonia) from 3.4.3 to 3.5.0.
<details>
<summary>Release notes</summary>
_Sourced from [AsyncImageLoader.Avalonia's releases](https://github.com/AvaloniaUtils/AsyncImageLoader.Avalonia/releases)._
## 3.5.0
## What's Changed
* Rem... | 1f63d4fa2655e0f63ad4573e2d7fd98f58e6047a | eb81d9fc5a07eee5514b7ce562648d871054e2b8 | diff --git a/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj b/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj
index ecba760be..500e7bedc 100644
--- a/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj
+++ b/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Test... | [
"DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj",
"DiscordChatExporter.Cli/DiscordChatExporter.Cli.csproj",
"DiscordChatExporter.Core/DiscordChatExporter.Core.csproj",
"DiscordChatExporter.Gui/DiscordChatExporter.Gui.csproj"
] | [] | true | ||
Tyrrrz/DiscordChatExporter | 1,456 | issue_to_patch | Save original URLs of embed files and such
### Version
2.46.0
### Flavor
GUI (Graphical User Interface)
### Platform
Arch
### Export format
HTML
### Steps to reproduce
already happens
### Details
Hello, Can you add this feature to save original urls into the html files?
Or point to the code where it can be... | Preserve original URLs for proxied embed assets | ## Implementation Complete ✅
- [x] Analyze current code structure for URL handling in embeds
- [x] Update HTML export to include `data-canonical-url` attribute for embed assets with ProxyUrl
- [x] EmbedAuthor icon
- [x] EmbedImage
- [x] EmbedVideo
- [x] EmbedThumbnail
- [x] EmbedFooter icon
- [x] Update JS... | 58dd40bf3e0cb29250dc5f53a233e76f98bfe2b1 | 27c0d60812719e628367bf71cb53989ef454e323 | diff --git a/DiscordChatExporter.Core/Exporting/JsonMessageWriter.cs b/DiscordChatExporter.Core/Exporting/JsonMessageWriter.cs
index 5b1dfe482..1b90ec024 100644
--- a/DiscordChatExporter.Core/Exporting/JsonMessageWriter.cs
+++ b/DiscordChatExporter.Core/Exporting/JsonMessageWriter.cs
@@ -138,6 +138,7 @@ await Context.R... | [
"DiscordChatExporter.Core/Exporting/JsonMessageWriter.cs",
"DiscordChatExporter.Core/Exporting/MessageGroupTemplate.cshtml"
] | [
{
"comment": "@copilot feel free to assume that `...ProxyUrl` is always set for simplicity. It's acceptable if we emit the same URL in both fields. This comment applies to all other similar occurences.",
"path": "DiscordChatExporter.Core/Exporting/JsonMessageWriter.cs",
"hunk": "@@ -138,6 +138,12 @@ awa... | true | |
Tyrrrz/DiscordChatExporter | 1,455 | issue_to_patch | Invalid filename characters when exporting to NTFS on non-Windows systems
### Version
v2.46.0
### Flavor
GUI (Graphical User Interface)
### Platform
Ubuntu
### Export format
HTML
### Steps to reproduce
<img width="499" height="1000" alt="Image" src="https://github.com/user-attachments/assets/14d758a3-5ae9-4de... | Fix filename sanitization for NTFS filesystems on non-Windows systems | Exporting channels with NTFS-forbidden characters (`?`, `:`, `*`, `<`, `>`, `|`, `"`, `\`) in their names fails on Linux/macOS when targeting NTFS drives. `Path.GetInvalidFileNameChars()` only returns OS-specific invalid characters (e.g., just `\0` and `/` on Linux), not filesystem-specific ones.
## Changes
- **PathE... | a74ba4da0c4aa20ad36495e76dbb9c89608cf291 | 9a272fde43d024740f4a7dccb16e7ec721f4a7fb | diff --git a/DiscordChatExporter.Core/Utils/Extensions/PathExtensions.cs b/DiscordChatExporter.Core/Utils/Extensions/PathExtensions.cs
index a7c240485..4ae267fe8 100644
--- a/DiscordChatExporter.Core/Utils/Extensions/PathExtensions.cs
+++ b/DiscordChatExporter.Core/Utils/Extensions/PathExtensions.cs
@@ -1,11 +1,32 @@
... | [
"DiscordChatExporter.Core/Utils/Extensions/PathExtensions.cs"
] | [
{
"comment": "The comment references issue #1417, but based on the PR description, this change is fixing issue #1452. The issue reference in the comment should be updated to match the actual issue being fixed.\n```suggestion\n // https://github.com/Tyrrrz/DiscordChatExporter/issues/1452\n```",
"path": "D... | true | |
Tyrrrz/DiscordChatExporter | 1,455 | comment_to_fix | Fix filename sanitization for NTFS filesystems on non-Windows systems | The comment references issue #1417, but based on the PR description, this change is fixing issue #1452. The issue reference in the comment should be updated to match the actual issue being fixed.
```suggestion
// https://github.com/Tyrrrz/DiscordChatExporter/issues/1452
``` | a74ba4da0c4aa20ad36495e76dbb9c89608cf291 | 9a272fde43d024740f4a7dccb16e7ec721f4a7fb | diff --git a/DiscordChatExporter.Core/Utils/Extensions/PathExtensions.cs b/DiscordChatExporter.Core/Utils/Extensions/PathExtensions.cs
index a7c240485..4ae267fe8 100644
--- a/DiscordChatExporter.Core/Utils/Extensions/PathExtensions.cs
+++ b/DiscordChatExporter.Core/Utils/Extensions/PathExtensions.cs
@@ -1,11 +1,32 @@
... | [
"DiscordChatExporter.Core/Utils/Extensions/PathExtensions.cs"
] | [
{
"comment": "The comment references issue #1417, but based on the PR description, this change is fixing issue #1452. The issue reference in the comment should be updated to match the actual issue being fixed.\n```suggestion\n // https://github.com/Tyrrrz/DiscordChatExporter/issues/1452\n```",
"path": "D... | true | ||
Tyrrrz/DiscordChatExporter | 1,402 | issue_to_patch | Fix token retrieval through console | Fixed token retrieval through console. | 303f5667bfcd75c7c71b153c1122b28d81e84275 | f8a0103b7a109427ae8dd7f77e724b9ddb463342 | diff --git a/.docs/Token-and-IDs.md b/.docs/Token-and-IDs.md
index f83bcef83..b8147de16 100644
--- a/.docs/Token-and-IDs.md
+++ b/.docs/Token-and-IDs.md
@@ -27,7 +27,7 @@ Prerequisite step: Navigate to [discord.com](https://discord.com) and login.
3. Type
```js
- (webpackChunkdiscord_app.push([[''],{},e=>{m=... | [
".docs/Token-and-IDs.md"
] | [] | true | ||
Tyrrrz/DiscordChatExporter | 1,445 | issue_to_patch | Bump the nuget group with 17 updates | Updated [AngleSharp](https://github.com/AngleSharp/AngleSharp) from 1.3.0 to 1.4.0.
<details>
<summary>Release notes</summary>
_Sourced from [AngleSharp's releases](https://github.com/AngleSharp/AngleSharp/releases)._
## 1.4.0
Released on Wednesday, November 12 2025.
- Fixed handling of carriage return in text sou... | f0a74fbc6edfb27d0496844509eb2c6242e17b38 | 47b4e0bf1a613d97d66b9acc0299de0c5e683001 | diff --git a/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj b/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj
index b9b23c555..ecba760be 100644
--- a/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj
+++ b/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Test... | [
"DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj",
"DiscordChatExporter.Cli/DiscordChatExporter.Cli.csproj",
"DiscordChatExporter.Core/DiscordChatExporter.Core.csproj",
"DiscordChatExporter.Gui/DiscordChatExporter.Gui.csproj"
] | [] | true | ||
Tyrrrz/DiscordChatExporter | 1,446 | issue_to_patch | Bump the actions group with 2 updates | Bumps the actions group with 2 updates: [actions/checkout](https://github.com/actions/checkout) and [actions/setup-dotnet](https://github.com/actions/setup-dotnet).
Updates `actions/checkout` from 5.0.0 to 6.0.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout... | f0a74fbc6edfb27d0496844509eb2c6242e17b38 | 4d3c217d099569052b8b929ef38e1bdaf8970520 | diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml
index c624d934c..96a6869b6 100644
--- a/.github/workflows/docker.yml
+++ b/.github/workflows/docker.yml
@@ -23,7 +23,7 @@ jobs:
steps:
- name: Checkout
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0... | [
".github/workflows/docker.yml",
".github/workflows/main.yml"
] | [] | true | ||
Tyrrrz/DiscordChatExporter | 1,440 | issue_to_patch | Bump the actions group with 2 updates | Bumps the actions group with 2 updates: [actions/upload-artifact](https://github.com/actions/upload-artifact) and [actions/download-artifact](https://github.com/actions/download-artifact).
Updates `actions/upload-artifact` from 4.6.2 to 5.0.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="http... | 42ebb9928ecd679fbe6f8b632a0bee004b09e50e | 96f323528d3c7fd4284b7c094223703c7e725543 | diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml
index 4eaef748f..c624d934c 100644
--- a/.github/workflows/docker.yml
+++ b/.github/workflows/docker.yml
@@ -37,7 +37,7 @@ jobs:
--output type=tar,dest=DiscordChatExporter.Cli.Docker.tar
- name: Upload image
- uses: actio... | [
".github/workflows/docker.yml",
".github/workflows/main.yml"
] | [] | true | ||
Tyrrrz/DiscordChatExporter | 1,441 | issue_to_patch | Bump the nuget group with 14 updates | Updated [AsyncKeyedLock](https://github.com/MarkCiliaVincenti/AsyncKeyedLock) from 7.1.6 to 7.1.7.
<details>
<summary>Release notes</summary>
_Sourced from [AsyncKeyedLock's releases](https://github.com/MarkCiliaVincenti/AsyncKeyedLock/releases)._
## 7.1.7
Minor optimization; dependency update.
Commits viewable in... | 42ebb9928ecd679fbe6f8b632a0bee004b09e50e | 1737d4c815f2c092df32c4ff5e04a065526b9825 | diff --git a/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj b/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj
index e0dfd9237..e9b17c2b9 100644
--- a/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj
+++ b/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Test... | [
"DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj",
"DiscordChatExporter.Cli/DiscordChatExporter.Cli.csproj",
"DiscordChatExporter.Core/DiscordChatExporter.Core.csproj",
"DiscordChatExporter.Gui/DiscordChatExporter.Gui.csproj"
] | [] | true | ||
Tyrrrz/DiscordChatExporter | 1,431 | issue_to_patch | Bump the nuget group with 13 updates | Updated [AsyncImageLoader.Avalonia](https://github.com/AvaloniaUtils/AsyncImageLoader.Avalonia) from 3.3.0 to 3.4.3.
<details>
<summary>Release notes</summary>
_Sourced from [AsyncImageLoader.Avalonia's releases](https://github.com/AvaloniaUtils/AsyncImageLoader.Avalonia/releases)._
## 3.4.3
## What's Changed
* Add... | 27a434a663c1f6c9fba910c0bba9980223ef4dd6 | 87b1d9ec3d51e597006b08cc940c3fb5b7d2c419 | diff --git a/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj b/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj
index 2a22d3a65..e0dfd9237 100644
--- a/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj
+++ b/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Test... | [
"DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj",
"DiscordChatExporter.Cli/DiscordChatExporter.Cli.csproj",
"DiscordChatExporter.Core/DiscordChatExporter.Core.csproj",
"DiscordChatExporter.Gui/DiscordChatExporter.Gui.csproj"
] | [] | true | ||
Tyrrrz/DiscordChatExporter | 1,430 | issue_to_patch | Bump the actions group with 2 updates | Bumps the actions group with 2 updates: [actions/setup-dotnet](https://github.com/actions/setup-dotnet) and [codecov/codecov-action](https://github.com/codecov/codecov-action).
Updates `actions/setup-dotnet` from 4.3.1 to 5.0.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/... | 27a434a663c1f6c9fba910c0bba9980223ef4dd6 | 18ae518d27e31865712489b8e5ea07f641d52584 | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 226b1208e..9af743c9a 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -29,7 +29,7 @@ jobs:
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
- name: Install .NET
- uses: ... | [
".github/workflows/main.yml"
] | [] | true | ||
Tyrrrz/DiscordChatExporter | 1,429 | issue_to_patch | Bump the nuget group with 12 updates | Updated [Avalonia](https://github.com/AvaloniaUI/Avalonia/) from 11.3.2 to 11.3.4.
<details>
<summary>Release notes</summary>
_Sourced from [Avalonia's releases](https://github.com/AvaloniaUI/Avalonia//releases)._
No release notes found for this version range.
Commits viewable in [compare view](https://github.com/A... | 8fcf5e5377d1adcc76eec2191af67ef884c94544 | c52b02233bf6af33258ea92c46a97447b8f3162a | diff --git a/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj b/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj
index 2183cf8af..2a22d3a65 100644
--- a/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj
+++ b/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Test... | [
"DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj",
"DiscordChatExporter.Cli/DiscordChatExporter.Cli.csproj",
"DiscordChatExporter.Core/DiscordChatExporter.Core.csproj",
"DiscordChatExporter.Gui/DiscordChatExporter.Gui.csproj"
] | [] | true | ||
Tyrrrz/DiscordChatExporter | 1,428 | issue_to_patch | Bump the actions group with 3 updates | Bumps the actions group with 3 updates: [actions/checkout](https://github.com/actions/checkout), [codecov/codecov-action](https://github.com/codecov/codecov-action) and [actions/download-artifact](https://github.com/actions/download-artifact).
Updates `actions/checkout` from 4.2.2 to 5.0.0
<details>
<summary>Release n... | 8fcf5e5377d1adcc76eec2191af67ef884c94544 | 43d40d8b6a6a95f95fc965ec9831e6a9e7d81c20 | diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml
index b4a7ebd75..4eaef748f 100644
--- a/.github/workflows/docker.yml
+++ b/.github/workflows/docker.yml
@@ -23,7 +23,7 @@ jobs:
steps:
- name: Checkout
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2... | [
".github/workflows/docker.yml",
".github/workflows/main.yml"
] | [] | true | ||
Tyrrrz/DiscordChatExporter | 1,417 | issue_to_patch | Bump the nuget group with 7 updates | Updated [FluentAssertions](https://github.com/fluentassertions/fluentassertions) from 8.4.0 to 8.5.0.
<details>
<summary>Release notes</summary>
_Sourced from [FluentAssertions's releases](https://github.com/fluentassertions/fluentassertions/releases)._
## 8.5.0
<!-- Release notes generated using configuration in .... | 845e2a52feae67db014ff45907ab185c29816887 | 53c60752647bbb01d85623615ec9a38351cdc399 | diff --git a/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj b/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj
index d48bbab13..2183cf8af 100644
--- a/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj
+++ b/DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Test... | [
"DiscordChatExporter.Cli.Tests/DiscordChatExporter.Cli.Tests.csproj",
"DiscordChatExporter.Core/DiscordChatExporter.Core.csproj",
"DiscordChatExporter.Gui/DiscordChatExporter.Gui.csproj"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 845 | issue_to_patch | Open Settings when dismissing the FFmpeg missing dialog | When FFmpeg isn't found and the user dismisses the prompt (instead of downloading), the app would shut down with no way to configure a custom path without first clicking Download and aborting.
## Changes
- **`EnsureFFmpegAsync`** — On dismiss (CLOSE), open the Settings dialog instead of calling `App.Shutdown`. The us... | 895c4807e55b98eee116d293958630ba801651fa | 8c668102cb7f0f7a6b7cfaf3bd2fcccef71cc192 | diff --git a/YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs b/YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs
index bf1376700..830758f94 100644
--- a/YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs
+++ b/YoutubeDownloader/Localization/Localization... | [
"YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs",
"YoutubeDownloader/Localization/LocalizationManager.English.cs",
"YoutubeDownloader/Localization/LocalizationManager.French.cs",
"YoutubeDownloader/Localization/LocalizationManager.German.cs",
"YoutubeDownloader/Localization/Localiza... | [
{
"comment": "Looks like remntants from previous commits? @copilot ",
"path": "YoutubeDownloader/Framework/ViewModelManager.cs",
"hunk": "@@ -85,7 +85,8 @@ public MessageBoxViewModel GetMessageBoxViewModel(\n string title,\n string message,\n string? okButtonText,\n- strin... | true | ||
Tyrrrz/YoutubeDownloader | 845 | comment_to_fix | Open Settings when dismissing the FFmpeg missing dialog | I think the message should:
1. Leave a blank line before "Alternatively"
2. Be worded like "Alternatively, you can click on CLOSE and set a custom FFmpeg path in settings". (with equivalents in other languages)
@copilot | 895c4807e55b98eee116d293958630ba801651fa | 8c668102cb7f0f7a6b7cfaf3bd2fcccef71cc192 | diff --git a/YoutubeDownloader/Localization/LocalizationManager.English.cs b/YoutubeDownloader/Localization/LocalizationManager.English.cs
index 83e7047f2..3f75de67b 100644
--- a/YoutubeDownloader/Localization/LocalizationManager.English.cs
+++ b/YoutubeDownloader/Localization/LocalizationManager.English.cs
@@ -114,8 +... | [
"YoutubeDownloader/Localization/LocalizationManager.English.cs"
] | [
{
"comment": "I think the message should:\n\n1. Leave a blank line before \"Alternatively\"\n2. Be worded like \"Alternatively, you can click on CLOSE and set a custom FFmpeg path in settings\". (with equivalents in other languages)\n\n@copilot ",
"path": "YoutubeDownloader/Localization/LocalizationManager.... | true | ||
Tyrrrz/YoutubeDownloader | 845 | comment_to_fix | Open Settings when dismissing the FFmpeg missing dialog | The updated FFmpeg-missing prompt doesn't match the new flow described in this PR: dismissing/closing the dialog now opens Settings, but the message only says that a custom path can be set in Settings. To avoid surprising users, the text should explicitly say that closing the dialog will open Settings. | 895c4807e55b98eee116d293958630ba801651fa | 8c668102cb7f0f7a6b7cfaf3bd2fcccef71cc192 | diff --git a/YoutubeDownloader/Localization/LocalizationManager.English.cs b/YoutubeDownloader/Localization/LocalizationManager.English.cs
index 83e7047f2..3f75de67b 100644
--- a/YoutubeDownloader/Localization/LocalizationManager.English.cs
+++ b/YoutubeDownloader/Localization/LocalizationManager.English.cs
@@ -114,8 +... | [
"YoutubeDownloader/Localization/LocalizationManager.English.cs"
] | [
{
"comment": "The updated FFmpeg-missing prompt doesn't match the new flow described in this PR: dismissing/closing the dialog now opens Settings, but the message only says that a custom path can be set in Settings. To avoid surprising users, the text should explicitly say that closing the dialog will open Sett... | true | ||
Tyrrrz/YoutubeDownloader | 845 | comment_to_fix | Open Settings when dismissing the FFmpeg missing dialog | This localized FFmpeg-missing message also doesn't explicitly mention the new behavior that closing/dismissing the dialog will open Settings to configure a custom FFmpeg path. Please update the translation to reflect that flow, consistent with the PR description. | 895c4807e55b98eee116d293958630ba801651fa | 8c668102cb7f0f7a6b7cfaf3bd2fcccef71cc192 | diff --git a/YoutubeDownloader/Localization/LocalizationManager.French.cs b/YoutubeDownloader/Localization/LocalizationManager.French.cs
index 45fc93e23..285a3d5c6 100644
--- a/YoutubeDownloader/Localization/LocalizationManager.French.cs
+++ b/YoutubeDownloader/Localization/LocalizationManager.French.cs
@@ -118,8 +118,... | [
"YoutubeDownloader/Localization/LocalizationManager.French.cs"
] | [
{
"comment": "This localized FFmpeg-missing message also doesn't explicitly mention the new behavior that closing/dismissing the dialog will open Settings to configure a custom FFmpeg path. Please update the translation to reflect that flow, consistent with the PR description.",
"path": "YoutubeDownloader/L... | true | ||
Tyrrrz/YoutubeDownloader | 845 | comment_to_fix | Open Settings when dismissing the FFmpeg missing dialog | This localized FFmpeg-missing message also doesn't explicitly mention the new behavior that closing/dismissing the dialog will open Settings to configure a custom FFmpeg path. Please update the translation to reflect that flow, consistent with the PR description. | 895c4807e55b98eee116d293958630ba801651fa | 8c668102cb7f0f7a6b7cfaf3bd2fcccef71cc192 | diff --git a/YoutubeDownloader/Localization/LocalizationManager.German.cs b/YoutubeDownloader/Localization/LocalizationManager.German.cs
index 12702ffe9..c2872b958 100644
--- a/YoutubeDownloader/Localization/LocalizationManager.German.cs
+++ b/YoutubeDownloader/Localization/LocalizationManager.German.cs
@@ -117,8 +117,... | [
"YoutubeDownloader/Localization/LocalizationManager.German.cs"
] | [
{
"comment": "This localized FFmpeg-missing message also doesn't explicitly mention the new behavior that closing/dismissing the dialog will open Settings to configure a custom FFmpeg path. Please update the translation to reflect that flow, consistent with the PR description.",
"path": "YoutubeDownloader/L... | true | ||
Tyrrrz/YoutubeDownloader | 845 | comment_to_fix | Open Settings when dismissing the FFmpeg missing dialog | This localized FFmpeg-missing message also doesn't explicitly mention the new behavior that closing/dismissing the dialog will open Settings to configure a custom FFmpeg path. Please update the translation to reflect that flow, consistent with the PR description. | 895c4807e55b98eee116d293958630ba801651fa | 8c668102cb7f0f7a6b7cfaf3bd2fcccef71cc192 | diff --git a/YoutubeDownloader/Localization/LocalizationManager.Spanish.cs b/YoutubeDownloader/Localization/LocalizationManager.Spanish.cs
index 82ac6559b..309a70bcb 100644
--- a/YoutubeDownloader/Localization/LocalizationManager.Spanish.cs
+++ b/YoutubeDownloader/Localization/LocalizationManager.Spanish.cs
@@ -117,8 +... | [
"YoutubeDownloader/Localization/LocalizationManager.Spanish.cs"
] | [
{
"comment": "This localized FFmpeg-missing message also doesn't explicitly mention the new behavior that closing/dismissing the dialog will open Settings to configure a custom FFmpeg path. Please update the translation to reflect that flow, consistent with the PR description.",
"path": "YoutubeDownloader/L... | true | ||
Tyrrrz/YoutubeDownloader | 845 | comment_to_fix | Open Settings when dismissing the FFmpeg missing dialog | This localized FFmpeg-missing message also doesn't explicitly mention the new behavior that closing/dismissing the dialog will open Settings to configure a custom FFmpeg path. Please update the translation to reflect that flow, consistent with the PR description. | 895c4807e55b98eee116d293958630ba801651fa | 8c668102cb7f0f7a6b7cfaf3bd2fcccef71cc192 | diff --git a/YoutubeDownloader/Localization/LocalizationManager.Ukrainian.cs b/YoutubeDownloader/Localization/LocalizationManager.Ukrainian.cs
index a07ef61f0..9faa0d3a7 100644
--- a/YoutubeDownloader/Localization/LocalizationManager.Ukrainian.cs
+++ b/YoutubeDownloader/Localization/LocalizationManager.Ukrainian.cs
@@ ... | [
"YoutubeDownloader/Localization/LocalizationManager.Ukrainian.cs"
] | [
{
"comment": "This localized FFmpeg-missing message also doesn't explicitly mention the new behavior that closing/dismissing the dialog will open Settings to configure a custom FFmpeg path. Please update the translation to reflect that flow, consistent with the PR description.",
"path": "YoutubeDownloader/L... | true | ||
Tyrrrz/YoutubeDownloader | 845 | comment_to_fix | Open Settings when dismissing the FFmpeg missing dialog | This localized FFmpeg-missing message also doesn't explicitly mention the new behavior that closing/dismissing the dialog will open Settings to configure a custom FFmpeg path. Please update the translation to reflect that flow, consistent with the PR description. | 895c4807e55b98eee116d293958630ba801651fa | 8c668102cb7f0f7a6b7cfaf3bd2fcccef71cc192 | diff --git a/YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs b/YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs
index bf1376700..830758f94 100644
--- a/YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs
+++ b/YoutubeDownloader/Localization/Localization... | [
"YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs"
] | [
{
"comment": "This localized FFmpeg-missing message also doesn't explicitly mention the new behavior that closing/dismissing the dialog will open Settings to configure a custom FFmpeg path. Please update the translation to reflect that flow, consistent with the PR description.",
"path": "YoutubeDownloader/L... | true | ||
Tyrrrz/YoutubeDownloader | 845 | comment_to_fix | Open Settings when dismissing the FFmpeg missing dialog | The dialog text refers to the Settings dialog as "settings" (lowercase), but the UI/localization uses the proper name "Settings" (e.g., SettingsTitle/tooltip). Capitalizing this improves consistency and clarity for users looking for the exact dialog name. | 895c4807e55b98eee116d293958630ba801651fa | 8c668102cb7f0f7a6b7cfaf3bd2fcccef71cc192 | diff --git a/YoutubeDownloader/Localization/LocalizationManager.English.cs b/YoutubeDownloader/Localization/LocalizationManager.English.cs
index 83e7047f2..3f75de67b 100644
--- a/YoutubeDownloader/Localization/LocalizationManager.English.cs
+++ b/YoutubeDownloader/Localization/LocalizationManager.English.cs
@@ -114,8 +... | [
"YoutubeDownloader/Localization/LocalizationManager.English.cs"
] | [
{
"comment": "The dialog text refers to the Settings dialog as \"settings\" (lowercase), but the UI/localization uses the proper name \"Settings\" (e.g., SettingsTitle/tooltip). Capitalizing this improves consistency and clarity for users looking for the exact dialog name.",
"path": "YoutubeDownloader/Local... | true | ||
Tyrrrz/YoutubeDownloader | 845 | comment_to_fix | Open Settings when dismissing the FFmpeg missing dialog | @copilot let's update all localizations to:
```
...
Alternatively, you can close this dialog and manually set a custom FFmpeg path in settings.
``` | 895c4807e55b98eee116d293958630ba801651fa | 8c668102cb7f0f7a6b7cfaf3bd2fcccef71cc192 | diff --git a/YoutubeDownloader/Localization/LocalizationManager.English.cs b/YoutubeDownloader/Localization/LocalizationManager.English.cs
index 83e7047f2..3f75de67b 100644
--- a/YoutubeDownloader/Localization/LocalizationManager.English.cs
+++ b/YoutubeDownloader/Localization/LocalizationManager.English.cs
@@ -114,8 +... | [
"YoutubeDownloader/Localization/LocalizationManager.English.cs"
] | [
{
"comment": "@copilot let's update all localizations to:\n\n```\n...\n\nAlternatively, you can close this dialog and manually set a custom FFmpeg path in settings.\n```",
"path": "YoutubeDownloader/Localization/LocalizationManager.English.cs",
"hunk": "@@ -114,8 +114,11 @@ Click LEARN MORE to find ways... | true | ||
Tyrrrz/YoutubeDownloader | 846 | issue_to_patch | Bump the actions group with 3 updates | Bumps the actions group with 3 updates: [actions/checkout](https://github.com/actions/checkout), [actions/setup-dotnet](https://github.com/actions/setup-dotnet) and [tyrrrz/action-http-request](https://github.com/tyrrrz/action-http-request).
Updates `actions/checkout` from 6.0.2 to 6.0.3
<details>
<summary>Release not... | 895c4807e55b98eee116d293958630ba801651fa | 98c2e055ce885b62180f7237de99de8a488174cb | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 3120f5270..7bd76d07d 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -26,10 +26,10 @@ jobs:
steps:
- name: Checkout
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
+ ... | [
".github/workflows/main.yml"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 847 | issue_to_patch | Bump the nuget group with 4 updates | Updated [Avalonia](https://github.com/AvaloniaUI/Avalonia/) from 12.0.2 to 12.0.4.
<details>
<summary>Release notes</summary>
_Sourced from [Avalonia's releases](https://github.com/AvaloniaUI/Avalonia//releases)._
No release notes found for this version range.
Commits viewable in [compare view](https://github.com/A... | 895c4807e55b98eee116d293958630ba801651fa | d784693c87a7095a018f87dcf5f9cc5d54f96a77 | diff --git a/Directory.Packages.props b/Directory.Packages.props
index 41304251e..801371cc0 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -5,7 +5,7 @@
<ItemGroup>
<PackageVersion Include="AsyncImageLoader.Avalonia" Version="3.8.0" />
- <PackageVersion Include="Avalonia" Version="1... | [
"Directory.Packages.props"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 781 | issue_to_patch | Add user-configurable FFmpeg executable path | - [x] `FFmpegFilePath` (`string?`) in `SettingsService`, placed after `IsAuthPersisted`
- [x] `DashboardViewModel` passes `FFmpegFilePath` directly, no pre-existence check
- [x] `SettingsViewModel`: `partial`, `[RelayCommand]`, `OperatingSystem.IsWindows()`, `*.exe` filter, `!IsNullOrWhiteSpace` setter
- [x] `SettingsV... | 8ec35c26ff725f4cd7a483425fff66c6eb3e8df9 | 5e1e6e60d51d96c30713b6fab727876501813f9e | diff --git a/YoutubeDownloader.Core/Downloading/FFmpeg.cs b/YoutubeDownloader.Core/Downloading/FFmpeg.cs
index 8e8d628c0..960bedac2 100644
--- a/YoutubeDownloader.Core/Downloading/FFmpeg.cs
+++ b/YoutubeDownloader.Core/Downloading/FFmpeg.cs
@@ -65,6 +65,4 @@ public static IEnumerable<string> GetProbeDirectoryPaths()
... | [
"YoutubeDownloader.Core/Downloading/FFmpeg.cs",
"YoutubeDownloader.Core/Downloading/VideoDownloader.cs",
"YoutubeDownloader/Framework/DialogManager.cs",
"YoutubeDownloader/Services/SettingsService.cs",
"YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs",
"YoutubeDownloader/ViewModels/Dialogs/S... | [
{
"comment": "Should be under IsAuthPersisted. Update the order of properties in the view model too.",
"path": "YoutubeDownloader/Services/SettingsService.cs",
"hunk": "@@ -60,6 +60,12 @@ public partial class SettingsService()\n public partial VideoQualityPreference LastVideoQualityPreference { get;... | true | ||
Tyrrrz/YoutubeDownloader | 781 | comment_to_fix | Add user-configurable FFmpeg executable path | Should be under IsAuthPersisted. Update the order of properties in the view model too. | 8ec35c26ff725f4cd7a483425fff66c6eb3e8df9 | 5e1e6e60d51d96c30713b6fab727876501813f9e | diff --git a/YoutubeDownloader/Services/SettingsService.cs b/YoutubeDownloader/Services/SettingsService.cs
index 1ff86fb21..e5ebc8a14 100644
--- a/YoutubeDownloader/Services/SettingsService.cs
+++ b/YoutubeDownloader/Services/SettingsService.cs
@@ -31,6 +31,9 @@ public partial class SettingsService()
[ObservablePr... | [
"YoutubeDownloader/Services/SettingsService.cs"
] | [
{
"comment": "Should be under IsAuthPersisted. Update the order of properties in the view model too.",
"path": "YoutubeDownloader/Services/SettingsService.cs",
"hunk": "@@ -60,6 +60,12 @@ public partial class SettingsService()\n public partial VideoQualityPreference LastVideoQualityPreference { get;... | true | ||
Tyrrrz/YoutubeDownloader | 781 | comment_to_fix | Add user-configurable FFmpeg executable path | Remove this check, we'll get an error anyway if the file is not found | 8ec35c26ff725f4cd7a483425fff66c6eb3e8df9 | 5e1e6e60d51d96c30713b6fab727876501813f9e | diff --git a/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs b/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
index 601b5a8b5..a9dc43416 100644
--- a/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
+++ b/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
@@ -117,6 +... | [
"YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs"
] | [
{
"comment": "Remove this check, we'll get an error anyway if the file is not found ",
"path": "YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs",
"hunk": "@@ -112,11 +112,16 @@ private async void EnqueueDownload(DownloadViewModel download, int position = 0)\n download.C... | true | ||
Tyrrrz/YoutubeDownloader | 781 | comment_to_fix | Add user-configurable FFmpeg executable path | Commands are auto-generated by the framework | 8ec35c26ff725f4cd7a483425fff66c6eb3e8df9 | 5e1e6e60d51d96c30713b6fab727876501813f9e | diff --git a/YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs b/YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs
index b8f2f83de..bcc986166 100644
--- a/YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs
+++ b/YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs
@@ -1,5 +1,8 @@
using Sys... | [
"YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs"
] | [
{
"comment": "Commands are auto-generated by the framework",
"path": "YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs",
"hunk": "@@ -9,15 +13,20 @@ namespace YoutubeDownloader.ViewModels.Dialogs;\n \n public class SettingsViewModel : DialogViewModelBase\n {\n+ private readonly DialogManager... | true | ||
Tyrrrz/YoutubeDownloader | 781 | comment_to_fix | Add user-configurable FFmpeg executable path | Use OperatingSystem | 8ec35c26ff725f4cd7a483425fff66c6eb3e8df9 | 5e1e6e60d51d96c30713b6fab727876501813f9e | diff --git a/YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs b/YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs
index b8f2f83de..bcc986166 100644
--- a/YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs
+++ b/YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs
@@ -1,5 +1,8 @@
using Sys... | [
"YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs"
] | [
{
"comment": "Use OperatingSystem",
"path": "YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs",
"hunk": "@@ -76,6 +85,34 @@ public int ParallelLimit\n set => _settingsService.ParallelLimit = Math.Clamp(value, 1, 10);\n }\n \n+ public string FFmpegPath\n+ {\n+ get => _se... | true | ||
Tyrrrz/YoutubeDownloader | 781 | comment_to_fix | Add user-configurable FFmpeg executable path | Let's not force the file name, only extension | 8ec35c26ff725f4cd7a483425fff66c6eb3e8df9 | 5e1e6e60d51d96c30713b6fab727876501813f9e | diff --git a/YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs b/YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs
index b8f2f83de..bcc986166 100644
--- a/YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs
+++ b/YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs
@@ -1,5 +1,8 @@
using Sys... | [
"YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs"
] | [
{
"comment": "Let's not force the file name, only extension ",
"path": "YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs",
"hunk": "@@ -76,6 +85,34 @@ public int ParallelLimit\n set => _settingsService.ParallelLimit = Math.Clamp(value, 1, 10);\n }\n \n+ public string FFmpegPath\n... | true | ||
Tyrrrz/YoutubeDownloader | 781 | comment_to_fix | Add user-configurable FFmpeg executable path | ```suggestion
FFmpeg is required for {Program.Name} to work. Please download it and make it available in the application directory or on the system PATH, or configure the location in settings.
```
Instead of the following line
| 8ec35c26ff725f4cd7a483425fff66c6eb3e8df9 | 5e1e6e60d51d96c30713b6fab727876501813f9e | diff --git a/YoutubeDownloader/ViewModels/MainViewModel.cs b/YoutubeDownloader/ViewModels/MainViewModel.cs
index 1d6d0ae43..c412d4c6a 100644
--- a/YoutubeDownloader/ViewModels/MainViewModel.cs
+++ b/YoutubeDownloader/ViewModels/MainViewModel.cs
@@ -1,5 +1,6 @@
using System;
using System.Diagnostics;
+using System.IO... | [
"YoutubeDownloader/ViewModels/MainViewModel.cs"
] | [
{
"comment": "```suggestion\n FFmpeg is required for {Program.Name} to work. Please download it and make it available in the application directory or on the system PATH, or configure the location in settings.\n```\n\nInstead of the following line\n",
"path": "YoutubeDownloader/ViewModels/MainView... | true | ||
Tyrrrz/YoutubeDownloader | 781 | comment_to_fix | Add user-configurable FFmpeg executable path | Shouldn't this be a textbox? Also, add a default text (when path is null) saying "Auto-detected" | 8ec35c26ff725f4cd7a483425fff66c6eb3e8df9 | 5e1e6e60d51d96c30713b6fab727876501813f9e | diff --git a/YoutubeDownloader/Views/Dialogs/SettingsView.axaml b/YoutubeDownloader/Views/Dialogs/SettingsView.axaml
index 57b3fff91..ce71ddb66 100644
--- a/YoutubeDownloader/Views/Dialogs/SettingsView.axaml
+++ b/YoutubeDownloader/Views/Dialogs/SettingsView.axaml
@@ -3,6 +3,7 @@
xmlns="https://github.com/avalonia... | [
"YoutubeDownloader/Views/Dialogs/SettingsView.axaml"
] | [
{
"comment": "Shouldn't this be a textbox? Also, add a default text (when path is null) saying \"Auto-detected\"",
"path": "YoutubeDownloader/Views/Dialogs/SettingsView.axaml",
"hunk": "@@ -159,6 +159,32 @@\n Value=\"{Binding ParallelLimit}\" />\n ... | true | ||
Tyrrrz/YoutubeDownloader | 781 | comment_to_fix | Add user-configurable FFmpeg executable path | Invert the conditional for readability and use IsNullOrWhitespace | 8ec35c26ff725f4cd7a483425fff66c6eb3e8df9 | 5e1e6e60d51d96c30713b6fab727876501813f9e | diff --git a/YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs b/YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs
index b8f2f83de..bcc986166 100644
--- a/YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs
+++ b/YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs
@@ -1,5 +1,8 @@
using Sys... | [
"YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs"
] | [
{
"comment": "Invert the conditional for readability and use IsNullOrWhitespace",
"path": "YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs",
"hunk": "@@ -40,6 +45,12 @@ public bool IsAuthPersisted\n set => _settingsService.IsAuthPersisted = value;\n }\n \n+ public string? FFmpeg... | true | ||
Tyrrrz/YoutubeDownloader | 781 | comment_to_fix | Add user-configurable FFmpeg executable path | This line is not relevant when an explicit path is set | 8ec35c26ff725f4cd7a483425fff66c6eb3e8df9 | 5e1e6e60d51d96c30713b6fab727876501813f9e | diff --git a/YoutubeDownloader/ViewModels/MainViewModel.cs b/YoutubeDownloader/ViewModels/MainViewModel.cs
index 1d6d0ae43..c412d4c6a 100644
--- a/YoutubeDownloader/ViewModels/MainViewModel.cs
+++ b/YoutubeDownloader/ViewModels/MainViewModel.cs
@@ -1,5 +1,6 @@
using System;
using System.Diagnostics;
+using System.IO... | [
"YoutubeDownloader/ViewModels/MainViewModel.cs"
] | [
{
"comment": "This line is not relevant when an explicit path is set",
"path": "YoutubeDownloader/ViewModels/MainViewModel.cs",
"hunk": "@@ -75,18 +77,53 @@ private async Task ShowDevelopmentBuildMessageAsync()\n \n private async Task ShowFFmpegMessageAsync()\n {\n- if (FFmpeg.IsAvailable... | true | ||
Tyrrrz/YoutubeDownloader | 781 | comment_to_fix | Add user-configurable FFmpeg executable path | Here we should replace the download button with a SETTINGS button that opens settings. | 8ec35c26ff725f4cd7a483425fff66c6eb3e8df9 | 5e1e6e60d51d96c30713b6fab727876501813f9e | diff --git a/YoutubeDownloader/ViewModels/MainViewModel.cs b/YoutubeDownloader/ViewModels/MainViewModel.cs
index 1d6d0ae43..c412d4c6a 100644
--- a/YoutubeDownloader/ViewModels/MainViewModel.cs
+++ b/YoutubeDownloader/ViewModels/MainViewModel.cs
@@ -1,5 +1,6 @@
using System;
using System.Diagnostics;
+using System.IO... | [
"YoutubeDownloader/ViewModels/MainViewModel.cs"
] | [
{
"comment": "Here we should replace the download button with a SETTINGS button that opens settings.",
"path": "YoutubeDownloader/ViewModels/MainViewModel.cs",
"hunk": "@@ -75,18 +77,53 @@ private async Task ShowDevelopmentBuildMessageAsync()\n \n private async Task ShowFFmpegMessageAsync()\n {\... | true | ||
Tyrrrz/YoutubeDownloader | 781 | comment_to_fix | Add user-configurable FFmpeg executable path | ```suggestion
private async Task ShowFFmpeg MissingMessageAsync()
```
| 8ec35c26ff725f4cd7a483425fff66c6eb3e8df9 | 5e1e6e60d51d96c30713b6fab727876501813f9e | diff --git a/YoutubeDownloader/ViewModels/MainViewModel.cs b/YoutubeDownloader/ViewModels/MainViewModel.cs
index 1d6d0ae43..c412d4c6a 100644
--- a/YoutubeDownloader/ViewModels/MainViewModel.cs
+++ b/YoutubeDownloader/ViewModels/MainViewModel.cs
@@ -1,5 +1,6 @@
using System;
using System.Diagnostics;
+using System.IO... | [
"YoutubeDownloader/ViewModels/MainViewModel.cs"
] | [
{
"comment": "```suggestion\n private async Task ShowFFmpeg MissingMessageAsync()\n```\n",
"path": "YoutubeDownloader/ViewModels/MainViewModel.cs",
"hunk": "@@ -75,18 +77,53 @@ private async Task ShowDevelopmentBuildMessageAsync()\n \n private async Task ShowFFmpegMessageAsync()",
"resolving... | true | ||
Tyrrrz/YoutubeDownloader | 781 | comment_to_fix | Add user-configurable FFmpeg executable path | At this point, let's just have a massive if/else block, splitting the method in two branches. Any repetition is fine. | 8ec35c26ff725f4cd7a483425fff66c6eb3e8df9 | 5e1e6e60d51d96c30713b6fab727876501813f9e | diff --git a/YoutubeDownloader/ViewModels/MainViewModel.cs b/YoutubeDownloader/ViewModels/MainViewModel.cs
index 1d6d0ae43..c412d4c6a 100644
--- a/YoutubeDownloader/ViewModels/MainViewModel.cs
+++ b/YoutubeDownloader/ViewModels/MainViewModel.cs
@@ -1,5 +1,6 @@
using System;
using System.Diagnostics;
+using System.IO... | [
"YoutubeDownloader/ViewModels/MainViewModel.cs"
] | [
{
"comment": "At this point, let's just have a massive if/else block, splitting the method in two branches. Any repetition is fine.",
"path": "YoutubeDownloader/ViewModels/MainViewModel.cs",
"hunk": "@@ -73,26 +75,65 @@ private async Task ShowDevelopmentBuildMessageAsync()\n Process.StartShe... | true | ||
Tyrrrz/YoutubeDownloader | 781 | comment_to_fix | Add user-configurable FFmpeg executable path | The file picker on non-Windows platforms has no file type filter, which means users can select any file including directories or non-executable files. Consider adding a basic validation after the file is selected to ensure it's an actual file (not a directory) and optionally verify the filename matches the expected pat... | 8ec35c26ff725f4cd7a483425fff66c6eb3e8df9 | 5e1e6e60d51d96c30713b6fab727876501813f9e | diff --git a/YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs b/YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs
index b8f2f83de..bcc986166 100644
--- a/YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs
+++ b/YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs
@@ -1,5 +1,8 @@
using Sys... | [
"YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs"
] | [
{
"comment": "The file picker on non-Windows platforms has no file type filter, which means users can select any file including directories or non-executable files. Consider adding a basic validation after the file is selected to ensure it's an actual file (not a directory) and optionally verify the filename ma... | true | ||
Tyrrrz/YoutubeDownloader | 781 | comment_to_fix | Add user-configurable FFmpeg executable path | When a configured FFmpeg path does not exist at startup, the dialog offers a "SETTINGS" button but doesn't pre-populate or highlight the invalid path in the settings UI. Consider passing the invalid path context to the settings view model so it can be highlighted or provide better UX feedback to help users quickly iden... | 8ec35c26ff725f4cd7a483425fff66c6eb3e8df9 | 5e1e6e60d51d96c30713b6fab727876501813f9e | diff --git a/YoutubeDownloader/ViewModels/MainViewModel.cs b/YoutubeDownloader/ViewModels/MainViewModel.cs
index 1d6d0ae43..c412d4c6a 100644
--- a/YoutubeDownloader/ViewModels/MainViewModel.cs
+++ b/YoutubeDownloader/ViewModels/MainViewModel.cs
@@ -1,5 +1,6 @@
using System;
using System.Diagnostics;
+using System.IO... | [
"YoutubeDownloader/ViewModels/MainViewModel.cs"
] | [
{
"comment": "When a configured FFmpeg path does not exist at startup, the dialog offers a \"SETTINGS\" button but doesn't pre-populate or highlight the invalid path in the settings UI. Consider passing the invalid path context to the settings view model so it can be highlighted or provide better UX feedback to... | true | ||
Tyrrrz/YoutubeDownloader | 781 | comment_to_fix | Add user-configurable FFmpeg executable path | The XAML references `StringConverters.IsNotNullOrEmpty` converter which does not appear to exist in the codebase. This will cause a runtime error when the Settings dialog is opened. Either this converter needs to be created (similar to the existing converters in the Converters directory), or the binding should be chang... | 8ec35c26ff725f4cd7a483425fff66c6eb3e8df9 | 5e1e6e60d51d96c30713b6fab727876501813f9e | diff --git a/YoutubeDownloader/Views/Dialogs/SettingsView.axaml b/YoutubeDownloader/Views/Dialogs/SettingsView.axaml
index 57b3fff91..ce71ddb66 100644
--- a/YoutubeDownloader/Views/Dialogs/SettingsView.axaml
+++ b/YoutubeDownloader/Views/Dialogs/SettingsView.axaml
@@ -3,6 +3,7 @@
xmlns="https://github.com/avalonia... | [
"YoutubeDownloader/Views/Dialogs/SettingsView.axaml"
] | [
{
"comment": "The XAML references `StringConverters.IsNotNullOrEmpty` converter which does not appear to exist in the codebase. This will cause a runtime error when the Settings dialog is opened. Either this converter needs to be created (similar to the existing converters in the Converters directory), or the b... | true | ||
Tyrrrz/YoutubeDownloader | 781 | comment_to_fix | Add user-configurable FFmpeg executable path | The horizontal line uses the Unicode character '――' (U+2015 HORIZONTAL BAR) repeated. While this works, it's a non-standard approach that may not render consistently across all terminals and text displays, particularly in message boxes. Consider using a standard separator like a simple line of hyphens '---' or equals s... | 8ec35c26ff725f4cd7a483425fff66c6eb3e8df9 | 5e1e6e60d51d96c30713b6fab727876501813f9e | diff --git a/YoutubeDownloader/ViewModels/MainViewModel.cs b/YoutubeDownloader/ViewModels/MainViewModel.cs
index 1d6d0ae43..c412d4c6a 100644
--- a/YoutubeDownloader/ViewModels/MainViewModel.cs
+++ b/YoutubeDownloader/ViewModels/MainViewModel.cs
@@ -1,5 +1,6 @@
using System;
using System.Diagnostics;
+using System.IO... | [
"YoutubeDownloader/ViewModels/MainViewModel.cs"
] | [
{
"comment": "The horizontal line uses the Unicode character '――' (U+2015 HORIZONTAL BAR) repeated. While this works, it's a non-standard approach that may not render consistently across all terminals and text displays, particularly in message boxes. Consider using a standard separator like a simple line of hyp... | true | ||
Tyrrrz/YoutubeDownloader | 781 | comment_to_fix | Add user-configurable FFmpeg executable path | The error message for a missing configured FFmpeg path could be improved by being more specific about what action the user should take. Currently it says "Please update the FFmpeg path in settings or clear it to use auto-detection", but could provide more guidance such as verifying the path, checking if the file was mo... | 8ec35c26ff725f4cd7a483425fff66c6eb3e8df9 | 5e1e6e60d51d96c30713b6fab727876501813f9e | diff --git a/YoutubeDownloader/ViewModels/MainViewModel.cs b/YoutubeDownloader/ViewModels/MainViewModel.cs
index 1d6d0ae43..c412d4c6a 100644
--- a/YoutubeDownloader/ViewModels/MainViewModel.cs
+++ b/YoutubeDownloader/ViewModels/MainViewModel.cs
@@ -1,5 +1,6 @@
using System;
using System.Diagnostics;
+using System.IO... | [
"YoutubeDownloader/ViewModels/MainViewModel.cs"
] | [
{
"comment": "The error message for a missing configured FFmpeg path could be improved by being more specific about what action the user should take. Currently it says \"Please update the FFmpeg path in settings or clear it to use auto-detection\", but could provide more guidance such as verifying the path, che... | true | ||
Tyrrrz/YoutubeDownloader | 781 | comment_to_fix | Add user-configurable FFmpeg executable path | I think with the explicit path option being available, IsAvailable() is a bit confusing. Let's remove it and inline in call sites. | 8ec35c26ff725f4cd7a483425fff66c6eb3e8df9 | 5e1e6e60d51d96c30713b6fab727876501813f9e | diff --git a/YoutubeDownloader/ViewModels/MainViewModel.cs b/YoutubeDownloader/ViewModels/MainViewModel.cs
index 1d6d0ae43..c412d4c6a 100644
--- a/YoutubeDownloader/ViewModels/MainViewModel.cs
+++ b/YoutubeDownloader/ViewModels/MainViewModel.cs
@@ -1,5 +1,6 @@
using System;
using System.Diagnostics;
+using System.IO... | [
"YoutubeDownloader/ViewModels/MainViewModel.cs"
] | [
{
"comment": "I think with the explicit path option being available, IsAvailable() is a bit confusing. Let's remove it and inline in call sites.",
"path": "YoutubeDownloader/ViewModels/MainViewModel.cs",
"hunk": "@@ -74,31 +75,61 @@ private async Task ShowDevelopmentBuildMessageAsync()\n Pro... | true | ||
Tyrrrz/YoutubeDownloader | 836 | issue_to_patch | Stop after FFmpeg auto-download failure | This closes the app if the automatic FFmpeg download fails.
If FFmpeg is missing and the user chooses not to download it, the app already exits. This makes the failed-download case behave the same way instead of leaving the app open in a state where downloads will still fail.
Checked with `dotnet build YoutubeDownloa... | e7267443dea7988552f685999314510a2a544ba2 | da4f9be38a201b1a3dfce82db4617e07089c34e2 | diff --git a/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs b/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
index 8af326a6b..816f45323 100644
--- a/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
+++ b/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
@@ -127,6 +... | [
"YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs"
] | [
{
"comment": "This introduces a second copy of the shutdown/exit fallback logic with a hard-coded exit code (3). To reduce duplication and improve readability, consider extracting a small helper (e.g., `ShutdownAndExit(int code)`) and/or defining a named constant for these exit codes (especially since other exi... | true | ||
Tyrrrz/YoutubeDownloader | 836 | comment_to_fix | Stop after FFmpeg auto-download failure | This introduces a second copy of the shutdown/exit fallback logic with a hard-coded exit code (3). To reduce duplication and improve readability, consider extracting a small helper (e.g., `ShutdownAndExit(int code)`) and/or defining a named constant for these exit codes (especially since other exit paths use different ... | e7267443dea7988552f685999314510a2a544ba2 | da4f9be38a201b1a3dfce82db4617e07089c34e2 | diff --git a/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs b/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
index 8af326a6b..816f45323 100644
--- a/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
+++ b/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
@@ -127,6 +... | [
"YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs"
] | [
{
"comment": "This introduces a second copy of the shutdown/exit fallback logic with a hard-coded exit code (3). To reduce duplication and improve readability, consider extracting a small helper (e.g., `ShutdownAndExit(int code)`) and/or defining a named constant for these exit codes (especially since other exi... | true | ||
Tyrrrz/YoutubeDownloader | 838 | issue_to_patch | Extract app shutdown fallback into `App.Shutdown` | This addresses the review feedback on PR #836 to remove duplicated shutdown/exit fallback logic in `DashboardViewModel`. The decline path for the FFmpeg prompt now uses a single app-level helper, as requested.
- **Refactor: centralize shutdown fallback**
- Added static helper on `App`:
- `App.Shutdown(int exitCo... | 0832b9406c0018802c65d8cf10b1b93683da904b | 3e0eb80445297606e7e0ae6d1749839e32ce5383 | diff --git a/YoutubeDownloader/App.axaml.cs b/YoutubeDownloader/App.axaml.cs
index a10c17276..068181f42 100644
--- a/YoutubeDownloader/App.axaml.cs
+++ b/YoutubeDownloader/App.axaml.cs
@@ -11,13 +11,14 @@
using YoutubeDownloader.Framework;
using YoutubeDownloader.Localization;
using YoutubeDownloader.Services;
+usin... | [
"YoutubeDownloader/App.axaml.cs",
"YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs"
] | [
{
"comment": "1. Similar to the pattern already established in the codebase, split the `App` class into two `partial`s in the same file, move the static members to the second partial.\n2. Rename `ShutdownAndExit` to just `Shutdown`. Make `exitCode = 0` by default.\n@copilot ",
"path": "YoutubeDownloader/App... | true | ||
Tyrrrz/YoutubeDownloader | 838 | comment_to_fix | Extract app shutdown fallback into `App.Shutdown` | 1. Similar to the pattern already established in the codebase, split the `App` class into two `partial`s in the same file, move the static members to the second partial.
2. Rename `ShutdownAndExit` to just `Shutdown`. Make `exitCode = 0` by default.
@copilot | 0832b9406c0018802c65d8cf10b1b93683da904b | 3e0eb80445297606e7e0ae6d1749839e32ce5383 | diff --git a/YoutubeDownloader/App.axaml.cs b/YoutubeDownloader/App.axaml.cs
index a10c17276..068181f42 100644
--- a/YoutubeDownloader/App.axaml.cs
+++ b/YoutubeDownloader/App.axaml.cs
@@ -11,13 +11,14 @@
using YoutubeDownloader.Framework;
using YoutubeDownloader.Localization;
using YoutubeDownloader.Services;
+usin... | [
"YoutubeDownloader/App.axaml.cs"
] | [
{
"comment": "1. Similar to the pattern already established in the codebase, split the `App` class into two `partial`s in the same file, move the static members to the second partial.\n2. Rename `ShutdownAndExit` to just `Shutdown`. Make `exitCode = 0` by default.\n@copilot ",
"path": "YoutubeDownloader/App... | true | ||
Tyrrrz/YoutubeDownloader | 835 | issue_to_patch | Share MusicBrainz request throttle | This makes the MusicBrainz request throttle shared across downloads.
The throttle was per `MusicBrainzClient` instance, so parallel downloads could each make requests at the configured rate. Since the client is created per download, this keeps the same limit but applies it app-wide.
Checked with `dotnet build Youtube... | 0832b9406c0018802c65d8cf10b1b93683da904b | 5195109d21fc3fc9106258d93262653124917b6a | diff --git a/YoutubeDownloader.Core/Tagging/MusicBrainzClient.cs b/YoutubeDownloader.Core/Tagging/MusicBrainzClient.cs
index 4ef45ffb7..ae987536f 100644
--- a/YoutubeDownloader.Core/Tagging/MusicBrainzClient.cs
+++ b/YoutubeDownloader.Core/Tagging/MusicBrainzClient.cs
@@ -13,7 +13,7 @@ namespace YoutubeDownloader.Core.... | [
"YoutubeDownloader.Core/Tagging/MusicBrainzClient.cs"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 826 | issue_to_patch | Hardening: deterministic key fallback in AuthCookies encryption and missing host boundary on WebView URL check
Two minor hardening items spotted while reading the auth flow on the current `master`. Neither is exploitable on its own, both are about narrowing the attack surface if another protection fails.
## 1. `AuthC... | Harden login URL match | Implements the two hardening items from #825.
## Changes
### `SettingsService.AuthCookiesEncryptionConverter`
- `Key` is now `Lazy<byte[]?>` and returns `null` when `Environment.TryGetMachineId()` returns `null` or whitespace.
- `Read` and `Write` check for that and skip the encryption path: cookies stay in memory fo... | c4ef72403a963d2a78b750b4508d5f1ba40f22e9 | c1154953da1056362501227a311732cdaf52a905 | diff --git a/YoutubeDownloader/Views/Dialogs/AuthSetupView.axaml.cs b/YoutubeDownloader/Views/Dialogs/AuthSetupView.axaml.cs
index b9bfe2e24..c0cf6ec10 100644
--- a/YoutubeDownloader/Views/Dialogs/AuthSetupView.axaml.cs
+++ b/YoutubeDownloader/Views/Dialogs/AuthSetupView.axaml.cs
@@ -64,11 +64,12 @@ WebViewUrlLoadingEv... | [
"YoutubeDownloader/Views/Dialogs/AuthSetupView.axaml.cs"
] | [
{
"comment": "Isn't `args.Url` already a `Uri` instance?",
"path": "YoutubeDownloader/Views/Dialogs/AuthSetupView.axaml.cs",
"hunk": "@@ -64,11 +64,12 @@ WebViewUrlLoadingEventArg args\n \n // Extract the cookies after being redirected to the home page (i.e. after logging in)\n if (\n- ... | true | |
Tyrrrz/YoutubeDownloader | 826 | comment_to_fix | Harden login URL match | Isn't `args.Url` already a `Uri` instance? | c4ef72403a963d2a78b750b4508d5f1ba40f22e9 | c1154953da1056362501227a311732cdaf52a905 | diff --git a/YoutubeDownloader/Views/Dialogs/AuthSetupView.axaml.cs b/YoutubeDownloader/Views/Dialogs/AuthSetupView.axaml.cs
index b9bfe2e24..c0cf6ec10 100644
--- a/YoutubeDownloader/Views/Dialogs/AuthSetupView.axaml.cs
+++ b/YoutubeDownloader/Views/Dialogs/AuthSetupView.axaml.cs
@@ -64,11 +64,12 @@ WebViewUrlLoadingEv... | [
"YoutubeDownloader/Views/Dialogs/AuthSetupView.axaml.cs"
] | [
{
"comment": "Isn't `args.Url` already a `Uri` instance?",
"path": "YoutubeDownloader/Views/Dialogs/AuthSetupView.axaml.cs",
"hunk": "@@ -64,11 +64,12 @@ WebViewUrlLoadingEventArg args\n \n // Extract the cookies after being redirected to the home page (i.e. after logging in)\n if (\n- ... | true | ||
Tyrrrz/YoutubeDownloader | 822 | issue_to_patch | Bump the nuget group with 4 updates | Updated [AsyncImageLoader.Avalonia](https://github.com/AvaloniaUtils/AsyncImageLoader.Avalonia) from 3.7.0 to 3.8.0.
<details>
<summary>Release notes</summary>
_Sourced from [AsyncImageLoader.Avalonia's releases](https://github.com/AvaloniaUtils/AsyncImageLoader.Avalonia/releases)._
## 3.8.0
## What's Changed
* Ava... | 3a3a9d41a8a4339d30a0b7aa567481e36ace165e | a0d0b4a4cdfafabbe11fe473ef0a69b30f825bb1 | diff --git a/Directory.Packages.props b/Directory.Packages.props
index 1555e5360..8144b4369 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -4,8 +4,8 @@
</PropertyGroup>
<ItemGroup>
- <PackageVersion Include="AsyncImageLoader.Avalonia" Version="3.7.0" />
- <PackageVersion Include="... | [
"Directory.Packages.props"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 821 | issue_to_patch | Bump actions/upload-artifact from 7.0.0 to 7.0.1 in the actions group | Bumps the actions group with 1 update: [actions/upload-artifact](https://github.com/actions/upload-artifact).
Updates `actions/upload-artifact` from 7.0.0 to 7.0.1
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's rele... | 3a3a9d41a8a4339d30a0b7aa567481e36ace165e | 0ac94434f510fc4fa28c14af0ec9177ba2a7d14f | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 8546e2859..3120f5270 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -91,7 +91,7 @@ jobs:
--self-contained
- name: Upload app binaries
- uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b... | [
".github/workflows/main.yml"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 649 | issue_to_patch | Add Avalonia temporary build tasks to `.gitignore` | Ignore Avalonia Build tasks files in git so they are not mistakenly staged
Closes #648
| eed035de66208c712b0f598198509f06b26fbf6a | abbe960e0aff2de528321733add0197b707357fc | diff --git a/.gitignore b/.gitignore
index ef8150c0e..1733d4799 100644
--- a/.gitignore
+++ b/.gitignore
@@ -8,5 +8,8 @@
bin/
obj/
+# Avalonia
+.avalonia-build-tasks/
+
# Test results
-TestResults/
\ No newline at end of file
+TestResults/
| [
".gitignore"
] | [
{
"comment": "```suggestion\r\n\r\n# Avalonia\r\n.avalonia-build-tasks/\r\n```",
"path": ".gitignore",
"hunk": "@@ -7,6 +7,7 @@\n # Build results\n bin/\n obj/\n+.avalonia-build-tasks/",
"resolving_sha": "abbe960e0aff2de528321733add0197b707357fc",
"resolving_diff": "diff --git a/.gitignore b/.gi... | true | ||
Tyrrrz/YoutubeDownloader | 649 | comment_to_fix | Add Avalonia temporary build tasks to `.gitignore` | ```suggestion
# Avalonia
.avalonia-build-tasks/
``` | eed035de66208c712b0f598198509f06b26fbf6a | abbe960e0aff2de528321733add0197b707357fc | diff --git a/.gitignore b/.gitignore
index ef8150c0e..1733d4799 100644
--- a/.gitignore
+++ b/.gitignore
@@ -8,5 +8,8 @@
bin/
obj/
+# Avalonia
+.avalonia-build-tasks/
+
# Test results
-TestResults/
\ No newline at end of file
+TestResults/
| [
".gitignore"
] | [
{
"comment": "```suggestion\r\n\r\n# Avalonia\r\n.avalonia-build-tasks/\r\n```",
"path": ".gitignore",
"hunk": "@@ -7,6 +7,7 @@\n # Build results\n bin/\n obj/\n+.avalonia-build-tasks/",
"resolving_sha": "abbe960e0aff2de528321733add0197b707357fc",
"resolving_diff": "diff --git a/.gitignore b/.gi... | true | ||
Tyrrrz/YoutubeDownloader | 820 | issue_to_patch | Change how the Simplified Chinese language is displayed | #819 That PR cannot implement this feature.
If you want to use `Chinese(Simplified)` - it's better to just change the `Description` in `Language.cs`. That will do it. | 58059369886710a65bd8144fac4db19a59782d9f | 74d86c0bbe7efff12e4e99869dbf65538c6ce4cb | diff --git a/YoutubeDownloader/Converters/EnumDisplayConverter.cs b/YoutubeDownloader/Converters/EnumDisplayConverter.cs
new file mode 100644
index 000000000..96985f83a
--- /dev/null
+++ b/YoutubeDownloader/Converters/EnumDisplayConverter.cs
@@ -0,0 +1,37 @@
+using System;
+using System.ComponentModel.DataAnnotations;
... | [
"YoutubeDownloader/Converters/EnumDisplayConverter.cs",
"YoutubeDownloader/Localization/Language.cs",
"YoutubeDownloader/Views/Dialogs/SettingsView.axaml"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 810 | issue_to_patch | Add Chinese (Simplified) localization | add chinese
| f67f12c3655459c8bb3a8ae1a1358b8369cce209 | fd05ce6bfdd82999f644d39b9b3fbad6d93d5f38 | diff --git a/YoutubeDownloader/Localization/Language.cs b/YoutubeDownloader/Localization/Language.cs
index 88168ac8a..d20af9a7f 100644
--- a/YoutubeDownloader/Localization/Language.cs
+++ b/YoutubeDownloader/Localization/Language.cs
@@ -8,4 +8,5 @@ public enum Language
German,
French,
Spanish,
+ Chine... | [
"YoutubeDownloader/Localization/Language.cs",
"YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs",
"YoutubeDownloader/Localization/LocalizationManager.cs"
] | [
{
"comment": "This translation string includes mixed languages (`\"语言Language\"`), unlike the other localizations where the label is only in the target language. This will show an inconsistent UI in Chinese; it should likely be just the Chinese label (e.g., \"语言\").\n",
"path": "YoutubeDownloader/Localizati... | true | ||
Tyrrrz/YoutubeDownloader | 810 | comment_to_fix | Add Chinese (Simplified) localization | This translation string includes mixed languages (`"语言Language"`), unlike the other localizations where the label is only in the target language. This will show an inconsistent UI in Chinese; it should likely be just the Chinese label (e.g., "语言").
| f67f12c3655459c8bb3a8ae1a1358b8369cce209 | fd05ce6bfdd82999f644d39b9b3fbad6d93d5f38 | diff --git a/YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs b/YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs
new file mode 100644
index 000000000..4213897e7
--- /dev/null
+++ b/YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs
@@ -0,0 +1,126 @@
+us... | [
"YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs"
] | [
{
"comment": "This translation string includes mixed languages (`\"语言Language\"`), unlike the other localizations where the label is only in the target language. This will show an inconsistent UI in Chinese; it should likely be just the Chinese label (e.g., \"语言\").\n",
"path": "YoutubeDownloader/Localizati... | true | ||
Tyrrrz/YoutubeDownloader | 810 | comment_to_fix | Add Chinese (Simplified) localization | The enum order was changed (and a new member inserted near the top). Since `SettingsService` is serialized via `System.Text.Json` without an explicit string-enum converter, enum values are very likely persisted as integers; reordering/inserting will cause existing users' saved language to deserialize to the wrong value... | f67f12c3655459c8bb3a8ae1a1358b8369cce209 | fd05ce6bfdd82999f644d39b9b3fbad6d93d5f38 | diff --git a/YoutubeDownloader/Localization/Language.cs b/YoutubeDownloader/Localization/Language.cs
index 88168ac8a..d20af9a7f 100644
--- a/YoutubeDownloader/Localization/Language.cs
+++ b/YoutubeDownloader/Localization/Language.cs
@@ -8,4 +8,5 @@ public enum Language
German,
French,
Spanish,
+ Chine... | [
"YoutubeDownloader/Localization/Language.cs"
] | [
{
"comment": "The enum order was changed (and a new member inserted near the top). Since `SettingsService` is serialized via `System.Text.Json` without an explicit string-enum converter, enum values are very likely persisted as integers; reordering/inserting will cause existing users' saved language to deserial... | true | ||
Tyrrrz/YoutubeDownloader | 810 | comment_to_fix | Add Chinese (Simplified) localization | `CultureInfo.CurrentUICulture.ThreeLetterISOLanguageName` returns ISO codes (e.g., `zho` for Chinese), so checking for `"chs"` will likely never match and the System language mode won’t auto-select Chinese. Consider matching `"zho"` (and/or switching to `TwoLetterISOLanguageName == "zh"` with a script/region check for ... | f67f12c3655459c8bb3a8ae1a1358b8369cce209 | fd05ce6bfdd82999f644d39b9b3fbad6d93d5f38 | diff --git a/YoutubeDownloader/Localization/LocalizationManager.cs b/YoutubeDownloader/Localization/LocalizationManager.cs
index 326f2a9c5..bb25b43d1 100644
--- a/YoutubeDownloader/Localization/LocalizationManager.cs
+++ b/YoutubeDownloader/Localization/LocalizationManager.cs
@@ -36,21 +36,30 @@ private string Get([Cal... | [
"YoutubeDownloader/Localization/LocalizationManager.cs"
] | [
{
"comment": "`CultureInfo.CurrentUICulture.ThreeLetterISOLanguageName` returns ISO codes (e.g., `zho` for Chinese), so checking for `\"chs\"` will likely never match and the System language mode won’t auto-select Chinese. Consider matching `\"zho\"` (and/or switching to `TwoLetterISOLanguageName == \"zh\"` wit... | true | ||
Tyrrrz/YoutubeDownloader | 810 | comment_to_fix | Add Chinese (Simplified) localization | This Chinese translation says the Download button will open a FFmpeg download web page, but in code the button triggers an in-app FFmpeg download (`FFmpeg.DownloadAsync`) after the dialog. The message should be adjusted to match the actual behavior (similar intent to the English/French/German/Spanish strings).
| f67f12c3655459c8bb3a8ae1a1358b8369cce209 | fd05ce6bfdd82999f644d39b9b3fbad6d93d5f38 | diff --git a/YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs b/YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs
new file mode 100644
index 000000000..4213897e7
--- /dev/null
+++ b/YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs
@@ -0,0 +1,126 @@
+us... | [
"YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs"
] | [
{
"comment": "This Chinese translation says the Download button will open a FFmpeg download web page, but in code the button triggers an in-app FFmpeg download (`FFmpeg.DownloadAsync`) after the dialog. The message should be adjusted to match the actual behavior (similar intent to the English/French/German/Span... | true | ||
Tyrrrz/YoutubeDownloader | 810 | comment_to_fix | Add Chinese (Simplified) localization | This localization dictionary contains keys that don’t exist in `EnglishLocalization` / `LocalizationManager` properties (e.g., `SettingsButton`), which makes it easy for the translation set to drift and for unused strings to accumulate. Recommend keeping the key set aligned with `EnglishLocalization.Keys` (remove unuse... | f67f12c3655459c8bb3a8ae1a1358b8369cce209 | fd05ce6bfdd82999f644d39b9b3fbad6d93d5f38 | diff --git a/YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs b/YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs
new file mode 100644
index 000000000..4213897e7
--- /dev/null
+++ b/YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs
@@ -0,0 +1,126 @@
+us... | [
"YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs"
] | [
{
"comment": "This localization dictionary contains keys that don’t exist in `EnglishLocalization` / `LocalizationManager` properties (e.g., `SettingsButton`), which makes it easy for the translation set to drift and for unused strings to accumulate. Recommend keeping the key set aligned with `EnglishLocalizati... | true | ||
Tyrrrz/YoutubeDownloader | 810 | comment_to_fix | Add Chinese (Simplified) localization | `FFmpegPathMissingMessage`/`FFmpegMissingSearchedLabel` don’t have corresponding properties in `LocalizationManager` and aren’t referenced elsewhere, while `FFmpegDownloadingTitle` and `FFmpegDownloadCompletedTitle` (used by `DashboardViewModel`) are missing from this dictionary so they’ll fall back to English. It woul... | f67f12c3655459c8bb3a8ae1a1358b8369cce209 | fd05ce6bfdd82999f644d39b9b3fbad6d93d5f38 | diff --git a/YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs b/YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs
new file mode 100644
index 000000000..4213897e7
--- /dev/null
+++ b/YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs
@@ -0,0 +1,126 @@
+us... | [
"YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs"
] | [
{
"comment": "`FFmpegPathMissingMessage`/`FFmpegMissingSearchedLabel` don’t have corresponding properties in `LocalizationManager` and aren’t referenced elsewhere, while `FFmpegDownloadingTitle` and `FFmpegDownloadCompletedTitle` (used by `DashboardViewModel`) are missing from this dictionary so they’ll fall ba... | true | ||
Tyrrrz/YoutubeDownloader | 810 | comment_to_fix | Add Chinese (Simplified) localization | Because the settings ComboBox binds directly to `AvailableLanguages` without an item template/converter, the UI will display the enum name via `ToString()`. `ChineseSimplified` will show as a concatenated identifier (unlike e.g. `English`, `German`, `Spanish`), so consider adding a display-name mechanism (e.g., a conve... | f67f12c3655459c8bb3a8ae1a1358b8369cce209 | fd05ce6bfdd82999f644d39b9b3fbad6d93d5f38 | diff --git a/YoutubeDownloader/Localization/Language.cs b/YoutubeDownloader/Localization/Language.cs
index 88168ac8a..d20af9a7f 100644
--- a/YoutubeDownloader/Localization/Language.cs
+++ b/YoutubeDownloader/Localization/Language.cs
@@ -8,4 +8,5 @@ public enum Language
German,
French,
Spanish,
+ Chine... | [
"YoutubeDownloader/Localization/Language.cs"
] | [
{
"comment": "Because the settings ComboBox binds directly to `AvailableLanguages` without an item template/converter, the UI will display the enum name via `ToString()`. `ChineseSimplified` will show as a concatenated identifier (unlike e.g. `English`, `German`, `Spanish`), so consider adding a display-name me... | true | ||
Tyrrrz/YoutubeDownloader | 810 | comment_to_fix | Add Chinese (Simplified) localization | The System-language detection for Simplified Chinese only matches cultures starting with `zh-Hans` or `zh-CN`. This will miss common Simplified Chinese cultures like `zh-SG` (and potentially legacy/neutral names like `zh-CHS` or just `zh`), causing the UI to fall back to English even though a Simplified Chinese localiz... | f67f12c3655459c8bb3a8ae1a1358b8369cce209 | fd05ce6bfdd82999f644d39b9b3fbad6d93d5f38 | diff --git a/YoutubeDownloader/Localization/LocalizationManager.cs b/YoutubeDownloader/Localization/LocalizationManager.cs
index 326f2a9c5..bb25b43d1 100644
--- a/YoutubeDownloader/Localization/LocalizationManager.cs
+++ b/YoutubeDownloader/Localization/LocalizationManager.cs
@@ -36,21 +36,30 @@ private string Get([Cal... | [
"YoutubeDownloader/Localization/LocalizationManager.cs"
] | [
{
"comment": "The System-language detection for Simplified Chinese only matches cultures starting with `zh-Hans` or `zh-CN`. This will miss common Simplified Chinese cultures like `zh-SG` (and potentially legacy/neutral names like `zh-CHS` or just `zh`), causing the UI to fall back to English even though a Simp... | true | ||
Tyrrrz/YoutubeDownloader | 815 | issue_to_patch | Why do I see super resolution (AI enhanced) options when selecting video quality & they're not even labelled
### Version
1.16.3
### Environment
MacOS Sequoia 15.7.5 m1 silicon
### Steps to reproduce
An example video which has super resolution https://www.youtube.com/watch?v=IFACrIx5SZ0
Try downloading it in Youtu... | Refactor the video quality label and add the "Upscaled" badge | Closes #813 | 7663dbb8248985267696a665b2aaf05b8313c3cd | 69dadc2ba4060e4b91226d119d30869c756fa9c6 | diff --git a/Directory.Packages.props b/Directory.Packages.props
index ceea4f42f..1555e5360 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -28,7 +28,7 @@
<PackageVersion Include="TagLibSharp" Version="2.3.0" />
<PackageVersion Include="WebView.Avalonia" Version="11.0.0.1" />
<Pac... | [
"Directory.Packages.props",
"YoutubeDownloader.Core/Downloading/VideoDownloadOption.cs",
"YoutubeDownloader/Localization/LocalizationManager.ChineseSimplified.cs",
"YoutubeDownloader/Localization/LocalizationManager.English.cs",
"YoutubeDownloader/Localization/LocalizationManager.French.cs",
"YoutubeDownl... | [] | true | |
Tyrrrz/YoutubeDownloader | 812 | issue_to_patch | Add PowerKit and Gress integrations; replace redundant utilities/extensions | - Update PowerKit to `1.1.1`
- Update Gress to `2.2.0`
- Delete `ResizableSemaphore.cs` — now in PowerKit
- Delete `ThrottleLock.cs` — now in PowerKit
- Delete `DirectoryExtensions.cs` — `Directory.CreateForFile` now in PowerKit
- Delete `CommandExtensions.cs` — `ExecuteIfCan` now in PowerKit
- Delete `NotifyPropertyCh... | f67f12c3655459c8bb3a8ae1a1358b8369cce209 | 91facbad6cd89c38fc5b972ff70a13d7722610f3 | diff --git a/Directory.Packages.props b/Directory.Packages.props
index 47a653e63..0170a698e 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -15,7 +15,7 @@
<PackageVersion Include="Deorcify" Version="1.1.0" />
<PackageVersion Include="ThisAssembly.Project" Version="2.1.2" />
<Packa... | [
"Directory.Packages.props",
"YoutubeDownloader.Core/Downloading/FFmpeg.cs",
"YoutubeDownloader.Core/Downloading/FileNameTemplate.cs",
"YoutubeDownloader.Core/Downloading/VideoDownloadOption.cs",
"YoutubeDownloader.Core/Tagging/MediaTagInjector.cs",
"YoutubeDownloader.Core/Tagging/MusicBrainzClient.cs",
... | [
{
"comment": "`using PowerKit.Extensions;` appears to be unused in this file. With `TreatWarningsAsErrors=true`, this will fail the build (CS8019). Remove the unused using directive (or use an API from that namespace if it was intended).",
"path": "YoutubeDownloader.Core/Tagging/MediaTagInjector.cs",
"h... | true | ||
Tyrrrz/YoutubeDownloader | 812 | comment_to_fix | Add PowerKit and Gress integrations; replace redundant utilities/extensions | `using PowerKit.Extensions;` appears to be unused in this file. With `TreatWarningsAsErrors=true`, this will fail the build (CS8019). Remove the unused using directive (or use an API from that namespace if it was intended). | f67f12c3655459c8bb3a8ae1a1358b8369cce209 | 91facbad6cd89c38fc5b972ff70a13d7722610f3 | diff --git a/YoutubeDownloader.Core/Tagging/MediaTagInjector.cs b/YoutubeDownloader.Core/Tagging/MediaTagInjector.cs
index c24fae1f7..8cf677a41 100644
--- a/YoutubeDownloader.Core/Tagging/MediaTagInjector.cs
+++ b/YoutubeDownloader.Core/Tagging/MediaTagInjector.cs
@@ -2,6 +2,7 @@
using System.Linq;
using System.Threa... | [
"YoutubeDownloader.Core/Tagging/MediaTagInjector.cs"
] | [
{
"comment": "`using PowerKit.Extensions;` appears to be unused in this file. With `TreatWarningsAsErrors=true`, this will fail the build (CS8019). Remove the unused using directive (or use an API from that namespace if it was intended).",
"path": "YoutubeDownloader.Core/Tagging/MediaTagInjector.cs",
"h... | true | ||
Tyrrrz/YoutubeDownloader | 812 | comment_to_fix | Add PowerKit and Gress integrations; replace redundant utilities/extensions | `new Uri(thumbnail.Url, ...)` can throw `UriFormatException`, which makes `TryGetImageFormat()` unexpectedly throw despite its "Try*" name. Prefer using `Uri.TryCreate(...)` (and returning null on failure) to keep this method exception-free for malformed/edge-case thumbnail URLs.
| f67f12c3655459c8bb3a8ae1a1358b8369cce209 | 91facbad6cd89c38fc5b972ff70a13d7722610f3 | diff --git a/YoutubeDownloader.Core/Utils/Extensions/ThumbnailExtensions.cs b/YoutubeDownloader.Core/Utils/Extensions/ThumbnailExtensions.cs
new file mode 100644
index 000000000..c110aff48
--- /dev/null
+++ b/YoutubeDownloader.Core/Utils/Extensions/ThumbnailExtensions.cs
@@ -0,0 +1,20 @@
+using System;
+using System.I... | [
"YoutubeDownloader.Core/Utils/Extensions/ThumbnailExtensions.cs"
] | [
{
"comment": "`new Uri(thumbnail.Url, ...)` can throw `UriFormatException`, which makes `TryGetImageFormat()` unexpectedly throw despite its \"Try*\" name. Prefer using `Uri.TryCreate(...)` (and returning null on failure) to keep this method exception-free for malformed/edge-case thumbnail URLs.\n",
"path":... | true | ||
Tyrrrz/YoutubeDownloader | 801 | issue_to_patch | Bump the actions group with 3 updates | Bumps the actions group with 3 updates: [actions/setup-dotnet](https://github.com/actions/setup-dotnet), [actions/download-artifact](https://github.com/actions/download-artifact) and [tyrrrz/action-http-request](https://github.com/tyrrrz/action-http-request).
Updates `actions/setup-dotnet` from 5.1.0 to 5.2.0
<details... | ddc448a56c8fa4ba9eb20738321399ebf6e8e49c | e4f3520253c925fe810d0c3e11de8d6613797e9d | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 54b34f724..8546e2859 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -29,7 +29,7 @@ jobs:
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
- name: Install .NET
- uses: ... | [
".github/workflows/main.yml"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 802 | issue_to_patch | Bump the nuget group with 5 updates | Updated [AsyncImageLoader.Avalonia](https://github.com/AvaloniaUtils/AsyncImageLoader.Avalonia) from 3.6.0 to 3.7.0.
<details>
<summary>Release notes</summary>
_Sourced from [AsyncImageLoader.Avalonia's releases](https://github.com/AvaloniaUtils/AsyncImageLoader.Avalonia/releases)._
## 3.7.0
## What's Changed
* Add... | ddc448a56c8fa4ba9eb20738321399ebf6e8e49c | b97146f396122796e1f0a74a469b47d356c9d40d | diff --git a/Directory.Packages.props b/Directory.Packages.props
index b0d34d468..d8f9d137b 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -4,21 +4,21 @@
</PropertyGroup>
<ItemGroup>
- <PackageVersion Include="AsyncImageLoader.Avalonia" Version="3.6.0" />
+ <PackageVersion Include... | [
"Directory.Packages.props"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 800 | issue_to_patch | Remove Bare distribution; auto-download FFmpeg at run time | Eliminates the `*.Bare` distribution by having the app auto-download FFmpeg at startup if not detected, using the dashboard's existing progress bar for visual feedback. The dialog ViewModel/View renames are not included.
## Changes
### Remove `*.Bare` distribution
- CI `pack` and `deploy` jobs no longer have a `bundl... | db201b6c18959d5ed4e73f41ec4fdd33457545d2 | a5beeebcf9206ed0cab87ee8fb9b1cc05ddac66f | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 31c0e395b..54b34f724 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -63,14 +63,6 @@ jobs:
- linux-x64
- osx-arm64
- osx-x64
- bundle-ffmpeg:
- - true
- - fals... | [
".github/workflows/main.yml",
"Readme.md",
"YoutubeDownloader.Core/Downloading/FFmpeg.cs",
"YoutubeDownloader/DownloadFFmpeg.csx",
"YoutubeDownloader/Localization/LocalizationManager.English.cs",
"YoutubeDownloader/Localization/LocalizationManager.French.cs",
"YoutubeDownloader/Localization/Localization... | [
{
"comment": "Remove the `DownloadFFmpeg` task, associated script, and any other references @copilot \n\nDevelopment builds will also rely on the newly introduced auto-download functionality.",
"path": ".github/workflows/main.yml",
"hunk": "@@ -92,7 +84,7 @@ jobs:\n -p:Version=${{ github.ref_t... | true | ||
Tyrrrz/YoutubeDownloader | 800 | comment_to_fix | Remove Bare distribution; auto-download FFmpeg at run time | Remove the `DownloadFFmpeg` task, associated script, and any other references @copilot
Development builds will also rely on the newly introduced auto-download functionality. | db201b6c18959d5ed4e73f41ec4fdd33457545d2 | a5beeebcf9206ed0cab87ee8fb9b1cc05ddac66f | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 31c0e395b..54b34f724 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -63,14 +63,6 @@ jobs:
- linux-x64
- osx-arm64
- osx-x64
- bundle-ffmpeg:
- - true
- - fals... | [
".github/workflows/main.yml"
] | [
{
"comment": "Remove the `DownloadFFmpeg` task, associated script, and any other references @copilot \n\nDevelopment builds will also rely on the newly introduced auto-download functionality.",
"path": ".github/workflows/main.yml",
"hunk": "@@ -92,7 +84,7 @@ jobs:\n -p:Version=${{ github.ref_t... | true | ||
Tyrrrz/YoutubeDownloader | 800 | comment_to_fix | Remove Bare distribution; auto-download FFmpeg at run time | We could probably specify a file path even, since we're always downloading just one executable @copilot | db201b6c18959d5ed4e73f41ec4fdd33457545d2 | a5beeebcf9206ed0cab87ee8fb9b1cc05ddac66f | diff --git a/YoutubeDownloader.Core/Downloading/FFmpeg.cs b/YoutubeDownloader.Core/Downloading/FFmpeg.cs
index 960bedac2..2d7012981 100644
--- a/YoutubeDownloader.Core/Downloading/FFmpeg.cs
+++ b/YoutubeDownloader.Core/Downloading/FFmpeg.cs
@@ -1,12 +1,21 @@
using System;
using System.Collections.Generic;
using Sys... | [
"YoutubeDownloader.Core/Downloading/FFmpeg.cs"
] | [
{
"comment": "We could probably specify a file path even, since we're always downloading just one executable @copilot ",
"path": "YoutubeDownloader.Core/Downloading/FFmpeg.cs",
"hunk": "@@ -65,4 +73,106 @@ public static IEnumerable<string> GetProbeDirectoryPaths()\n \n public static bool IsBundled()... | true | ||
Tyrrrz/YoutubeDownloader | 800 | comment_to_fix | Remove Bare distribution; auto-download FFmpeg at run time | Use this implementation for reference: https://github.com/Tyrrrz/YoutubeExplode/blob/prime/YoutubeExplode.Converter.Tests/Utils/FFmpeg.cs
Use FFmpeg v8.1.0 as it's the newest version
@copilot | db201b6c18959d5ed4e73f41ec4fdd33457545d2 | a5beeebcf9206ed0cab87ee8fb9b1cc05ddac66f | diff --git a/YoutubeDownloader.Core/Downloading/FFmpeg.cs b/YoutubeDownloader.Core/Downloading/FFmpeg.cs
index 960bedac2..2d7012981 100644
--- a/YoutubeDownloader.Core/Downloading/FFmpeg.cs
+++ b/YoutubeDownloader.Core/Downloading/FFmpeg.cs
@@ -1,12 +1,21 @@
using System;
using System.Collections.Generic;
using Sys... | [
"YoutubeDownloader.Core/Downloading/FFmpeg.cs"
] | [
{
"comment": "Use this implementation for reference: https://github.com/Tyrrrz/YoutubeExplode/blob/prime/YoutubeExplode.Converter.Tests/Utils/FFmpeg.cs\n\nUse FFmpeg v8.1.0 as it's the newest version\n\n@copilot ",
"path": "YoutubeDownloader.Core/Downloading/FFmpeg.cs",
"hunk": "@@ -65,4 +73,106 @@ publ... | true | ||
Tyrrrz/YoutubeDownloader | 800 | comment_to_fix | Remove Bare distribution; auto-download FFmpeg at run time | There should be a user prompt first @copilot | db201b6c18959d5ed4e73f41ec4fdd33457545d2 | a5beeebcf9206ed0cab87ee8fb9b1cc05ddac66f | diff --git a/YoutubeDownloader/ViewModels/MainViewModel.cs b/YoutubeDownloader/ViewModels/MainViewModel.cs
index 7def43eab..e7ea4b310 100644
--- a/YoutubeDownloader/ViewModels/MainViewModel.cs
+++ b/YoutubeDownloader/ViewModels/MainViewModel.cs
@@ -1,11 +1,8 @@
using System;
using System.Diagnostics;
-using System.I... | [
"YoutubeDownloader/ViewModels/MainViewModel.cs"
] | [
{
"comment": "There should be a user prompt first @copilot ",
"path": "YoutubeDownloader/ViewModels/MainViewModel.cs",
"hunk": "@@ -67,51 +66,43 @@ private async Task ShowDevelopmentBuildMessageAsync()\n Process.StartShellExecute(Program.ProjectReleasesUrl);\n }\n \n- private async Ta... | true | ||
Tyrrrz/YoutubeDownloader | 800 | comment_to_fix | Remove Bare distribution; auto-download FFmpeg at run time | Can we use the shared Http client? | db201b6c18959d5ed4e73f41ec4fdd33457545d2 | a5beeebcf9206ed0cab87ee8fb9b1cc05ddac66f | diff --git a/YoutubeDownloader.Core/Downloading/FFmpeg.cs b/YoutubeDownloader.Core/Downloading/FFmpeg.cs
index 960bedac2..2d7012981 100644
--- a/YoutubeDownloader.Core/Downloading/FFmpeg.cs
+++ b/YoutubeDownloader.Core/Downloading/FFmpeg.cs
@@ -1,12 +1,21 @@
using System;
using System.Collections.Generic;
using Sys... | [
"YoutubeDownloader.Core/Downloading/FFmpeg.cs"
] | [
{
"comment": "Can we use the shared Http client?",
"path": "YoutubeDownloader.Core/Downloading/FFmpeg.cs",
"hunk": "@@ -65,4 +73,118 @@ public static IEnumerable<string> GetProbeDirectoryPaths()\n \n public static bool IsBundled() =>\n File.Exists(Path.Combine(AppContext.BaseDirectory, CliFi... | true | ||
Tyrrrz/YoutubeDownloader | 800 | comment_to_fix | Remove Bare distribution; auto-download FFmpeg at run time | Show an error dialog | db201b6c18959d5ed4e73f41ec4fdd33457545d2 | a5beeebcf9206ed0cab87ee8fb9b1cc05ddac66f | diff --git a/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs b/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
index 12abb0ecf..397db4fdd 100644
--- a/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
+++ b/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
@@ -4,6 +4,... | [
"YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs"
] | [
{
"comment": "Show an error dialog",
"path": "YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs",
"hunk": "@@ -82,11 +85,86 @@ SettingsService settingsService\n \n public ObservableCollection<DownloadViewModel> Downloads { get; } = [];\n \n+ public async Task EnsureFFmpegAsync()\n+ ... | true | ||
Tyrrrz/YoutubeDownloader | 800 | comment_to_fix | Remove Bare distribution; auto-download FFmpeg at run time | Make it an optional parameter | db201b6c18959d5ed4e73f41ec4fdd33457545d2 | a5beeebcf9206ed0cab87ee8fb9b1cc05ddac66f | diff --git a/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs b/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
index 12abb0ecf..397db4fdd 100644
--- a/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
+++ b/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
@@ -4,6 +4,... | [
"YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs"
] | [
{
"comment": "Make it an optional parameter",
"path": "YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs",
"hunk": "@@ -82,11 +85,86 @@ SettingsService settingsService\n \n public ObservableCollection<DownloadViewModel> Downloads { get; } = [];\n \n+ public async Task EnsureFFmpegAsyn... | true | ||
Tyrrrz/YoutubeDownloader | 800 | comment_to_fix | Remove Bare distribution; auto-download FFmpeg at run time | Run `dotnet build` to fix all formatting issues | db201b6c18959d5ed4e73f41ec4fdd33457545d2 | a5beeebcf9206ed0cab87ee8fb9b1cc05ddac66f | diff --git a/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs b/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
index 12abb0ecf..397db4fdd 100644
--- a/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
+++ b/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
@@ -4,6 +4,... | [
"YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs"
] | [
{
"comment": "Run `dotnet build` to fix all formatting issues",
"path": "YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs",
"hunk": "@@ -82,11 +85,86 @@ SettingsService settingsService\n \n public ObservableCollection<DownloadViewModel> Downloads { get; } = [];\n \n+ public async Tas... | true | ||
Tyrrrz/YoutubeDownloader | 800 | comment_to_fix | Remove Bare distribution; auto-download FFmpeg at run time | Run this from the dashboard instead. | db201b6c18959d5ed4e73f41ec4fdd33457545d2 | a5beeebcf9206ed0cab87ee8fb9b1cc05ddac66f | diff --git a/YoutubeDownloader/ViewModels/MainViewModel.cs b/YoutubeDownloader/ViewModels/MainViewModel.cs
index 7def43eab..e7ea4b310 100644
--- a/YoutubeDownloader/ViewModels/MainViewModel.cs
+++ b/YoutubeDownloader/ViewModels/MainViewModel.cs
@@ -1,11 +1,8 @@
using System;
using System.Diagnostics;
-using System.I... | [
"YoutubeDownloader/ViewModels/MainViewModel.cs"
] | [
{
"comment": "Run this from the dashboard instead.",
"path": "YoutubeDownloader/ViewModels/MainViewModel.cs",
"hunk": "@@ -159,7 +105,7 @@ private async Task InitializeAsync()\n {\n await ShowUkraineSupportMessageAsync();\n await ShowDevelopmentBuildMessageAsync();\n- await Sh... | true | ||
Tyrrrz/YoutubeDownloader | 800 | comment_to_fix | Remove Bare distribution; auto-download FFmpeg at run time | ```suggestion
var dialog = _viewModelManager.CreateMessageBoxViewModel(
```
@copilot | db201b6c18959d5ed4e73f41ec4fdd33457545d2 | a5beeebcf9206ed0cab87ee8fb9b1cc05ddac66f | diff --git a/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs b/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
index 12abb0ecf..397db4fdd 100644
--- a/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
+++ b/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
@@ -4,6 +4,... | [
"YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs"
] | [
{
"comment": "```suggestion\n var dialog = _viewModelManager.CreateMessageBoxViewModel(\n```\n\n@copilot ",
"path": "YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs",
"hunk": "@@ -82,6 +85,84 @@ SettingsService settingsService\n \n public ObservableCollection<DownloadViewMod... | true | ||
Tyrrrz/YoutubeDownloader | 800 | comment_to_fix | Remove Bare distribution; auto-download FFmpeg at run time | `totalSize` is a nullable `long` (`ContentLength`), so `if (totalSize > 0)` produces a nullable bool and won't compile (and `totalSize.Value` can only be used after a non-null check). Use a pattern like `if (totalSize is > 0)` (or `if (totalSize.HasValue && totalSize.Value > 0)`) before reporting progress. | db201b6c18959d5ed4e73f41ec4fdd33457545d2 | a5beeebcf9206ed0cab87ee8fb9b1cc05ddac66f | diff --git a/YoutubeDownloader.Core/Downloading/FFmpeg.cs b/YoutubeDownloader.Core/Downloading/FFmpeg.cs
index 960bedac2..2d7012981 100644
--- a/YoutubeDownloader.Core/Downloading/FFmpeg.cs
+++ b/YoutubeDownloader.Core/Downloading/FFmpeg.cs
@@ -1,12 +1,21 @@
using System;
using System.Collections.Generic;
using Sys... | [
"YoutubeDownloader.Core/Downloading/FFmpeg.cs"
] | [
{
"comment": "`totalSize` is a nullable `long` (`ContentLength`), so `if (totalSize > 0)` produces a nullable bool and won't compile (and `totalSize.Value` can only be used after a non-null check). Use a pattern like `if (totalSize is > 0)` (or `if (totalSize.HasValue && totalSize.Value > 0)`) before reporting ... | true | ||
Tyrrrz/YoutubeDownloader | 800 | comment_to_fix | Remove Bare distribution; auto-download FFmpeg at run time | After the user chooses to open Settings due to a missing explicitly-configured FFmpeg path, the code immediately proceeds to shutdown/exit without re-checking whether the user fixed/cleared the path. Re-validate availability after the Settings dialog returns (and return if resolved) to avoid forcing an unnecessary app ... | db201b6c18959d5ed4e73f41ec4fdd33457545d2 | a5beeebcf9206ed0cab87ee8fb9b1cc05ddac66f | diff --git a/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs b/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
index 12abb0ecf..397db4fdd 100644
--- a/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
+++ b/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
@@ -4,6 +4,... | [
"YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs"
] | [
{
"comment": "After the user chooses to open Settings due to a missing explicitly-configured FFmpeg path, the code immediately proceeds to shutdown/exit without re-checking whether the user fixed/cleared the path. Re-validate availability after the Settings dialog returns (and return if resolved) to avoid forci... | true | ||
Tyrrrz/YoutubeDownloader | 800 | comment_to_fix | Remove Bare distribution; auto-download FFmpeg at run time | The workflow now publishes only `YoutubeDownloader.<rid>.zip` assets, but the in-app updater logic still selects `YoutubeDownloader.Bare.<rid>.zip` when FFmpeg isn't bundled. With Bare builds removed (and FFmpeg downloaded at runtime), this will make auto-update fail on fresh installs until FFmpeg is downloaded (and ma... | db201b6c18959d5ed4e73f41ec4fdd33457545d2 | a5beeebcf9206ed0cab87ee8fb9b1cc05ddac66f | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 31c0e395b..54b34f724 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -63,14 +63,6 @@ jobs:
- linux-x64
- osx-arm64
- osx-x64
- bundle-ffmpeg:
- - true
- - fals... | [
".github/workflows/main.yml"
] | [
{
"comment": "The workflow now publishes only `YoutubeDownloader.<rid>.zip` assets, but the in-app updater logic still selects `YoutubeDownloader.Bare.<rid>.zip` when FFmpeg isn't bundled. With Bare builds removed (and FFmpeg downloaded at runtime), this will make auto-update fail on fresh installs until FFmpeg... | true | ||
Tyrrrz/YoutubeDownloader | 800 | comment_to_fix | Remove Bare distribution; auto-download FFmpeg at run time | If a custom path is set, just trust that the user knows what they're doing. Don't perform any additional checks. @copilot | db201b6c18959d5ed4e73f41ec4fdd33457545d2 | a5beeebcf9206ed0cab87ee8fb9b1cc05ddac66f | diff --git a/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs b/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
index 12abb0ecf..397db4fdd 100644
--- a/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
+++ b/YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs
@@ -4,6 +4,... | [
"YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs"
] | [
{
"comment": "If a custom path is set, just trust that the user knows what they're doing. Don't perform any additional checks. @copilot ",
"path": "YoutubeDownloader/ViewModels/Components/DashboardViewModel.cs",
"hunk": "@@ -82,6 +85,84 @@ SettingsService settingsService\n \n public ObservableCollec... | true | ||
Tyrrrz/YoutubeDownloader | 799 | issue_to_patch | Replace `Publish-MacOSBundle.ps1` and `Download-FFmpeg.ps1` with .NET 10 single-file C# scripts using CliFx | Replaces the PowerShell scripts with .NET 10 file-based C# scripts (`.csx`) that use `dotnet run --file`, and adopts CliFx for structured argument handling — matching the approach used in <a href="https://github.com/Tyrrrz/DiscordChatExporter/pull/1515">DiscordChatExporter#1515</a>.
## Changes
- **`PublishMacOSBundle... | 43fde91b4e1789a8f30dfd908044b4c23f7c7ada | 8f8f8ac00193d1c3386c637363d79a042394fed6 | diff --git a/Directory.Packages.props b/Directory.Packages.props
index 0e58c424e..b0d34d468 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -9,6 +9,7 @@
<PackageVersion Include="Avalonia.Controls.DataGrid" Version="11.3.0" />
<PackageVersion Include="Avalonia.Desktop" Version="11.3.0" ... | [
"Directory.Packages.props",
"YoutubeDownloader/Download-FFmpeg.ps1",
"YoutubeDownloader/DownloadFFmpeg.csx",
"YoutubeDownloader/Publish-MacOSBundle.ps1",
"YoutubeDownloader/PublishMacOSBundle.csx",
"YoutubeDownloader/YoutubeDownloader.csproj"
] | [
{
"comment": "Rename to `DownloadFFmpeg.csx`",
"path": "YoutubeDownloader/DownloadFFmpeg.csx",
"hunk": "",
"resolving_sha": "8f8f8ac00193d1c3386c637363d79a042394fed6",
"resolving_diff": "diff --git a/YoutubeDownloader/DownloadFFmpeg.csx b/YoutubeDownloader/DownloadFFmpeg.csx\nnew file mode 10075... | true | ||
Tyrrrz/YoutubeDownloader | 799 | comment_to_fix | Replace `Publish-MacOSBundle.ps1` and `Download-FFmpeg.ps1` with .NET 10 single-file C# scripts using CliFx | Rename to `DownloadFFmpeg.csx` | 43fde91b4e1789a8f30dfd908044b4c23f7c7ada | 8f8f8ac00193d1c3386c637363d79a042394fed6 | diff --git a/YoutubeDownloader/DownloadFFmpeg.csx b/YoutubeDownloader/DownloadFFmpeg.csx
new file mode 100755
index 000000000..31ff4584b
--- /dev/null
+++ b/YoutubeDownloader/DownloadFFmpeg.csx
@@ -0,0 +1,96 @@
+#!/usr/bin/dotnet --
+#:package CliFx
+
+using System.IO.Compression;
+using System.Runtime.InteropServices;... | [
"YoutubeDownloader/DownloadFFmpeg.csx"
] | [
{
"comment": "Rename to `DownloadFFmpeg.csx`",
"path": "YoutubeDownloader/DownloadFFmpeg.csx",
"hunk": "",
"resolving_sha": "8f8f8ac00193d1c3386c637363d79a042394fed6",
"resolving_diff": "diff --git a/YoutubeDownloader/DownloadFFmpeg.csx b/YoutubeDownloader/DownloadFFmpeg.csx\nnew file mode 10075... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.