repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
Tyrrrz/YoutubeDownloader | 799 | comment_to_fix | Replace `Publish-MacOSBundle.ps1` and `Download-FFmpeg.ps1` with .NET 10 single-file C# scripts using CliFx | Propagate cancellations | 43fde91b4e1789a8f30dfd908044b4c23f7c7ada | 8f8f8ac00193d1c3386c637363d79a042394fed6 | diff --git a/YoutubeDownloader/DownloadFFmpeg.csx b/YoutubeDownloader/DownloadFFmpeg.csx
new file mode 100755
index 000000000..31ff4584b
--- /dev/null
+++ b/YoutubeDownloader/DownloadFFmpeg.csx
@@ -0,0 +1,96 @@
+#!/usr/bin/dotnet --
+#:package CliFx
+
+using System.IO.Compression;
+using System.Runtime.InteropServices;... | [
"YoutubeDownloader/DownloadFFmpeg.csx"
] | [
{
"comment": "Propagate cancellations",
"path": "YoutubeDownloader/DownloadFFmpeg.csx",
"hunk": "@@ -0,0 +1,85 @@\n+#!/usr/bin/dotnet --\n+#:package CliFx\n+\n+using System.IO.Compression;\n+using System.Runtime.InteropServices;\n+using CliFx;\n+using CliFx.Attributes;\n+using CliFx.Infrastructure;\n+\n... | true | ||
Tyrrrz/YoutubeDownloader | 799 | comment_to_fix | Replace `Publish-MacOSBundle.ps1` and `Download-FFmpeg.ps1` with .NET 10 single-file C# scripts using CliFx | Propagate cancellations | 43fde91b4e1789a8f30dfd908044b4c23f7c7ada | 8f8f8ac00193d1c3386c637363d79a042394fed6 | diff --git a/YoutubeDownloader/PublishMacOSBundle.csx b/YoutubeDownloader/PublishMacOSBundle.csx
new file mode 100755
index 000000000..c3c8cb3a7
--- /dev/null
+++ b/YoutubeDownloader/PublishMacOSBundle.csx
@@ -0,0 +1,128 @@
+#!/usr/bin/dotnet --
+#:package CliFx
+
+using CliFx;
+using CliFx.Attributes;
+using CliFx.Inf... | [
"YoutubeDownloader/PublishMacOSBundle.csx"
] | [
{
"comment": "Propagate cancellations",
"path": "YoutubeDownloader/PublishMacOSBundle.csx",
"hunk": "@@ -0,0 +1,128 @@\n+#!/usr/bin/dotnet --\n+#:package CliFx\n+\n+using CliFx;\n+using CliFx.Attributes;\n+using CliFx.Infrastructure;\n+\n+return await new CliApplicationBuilder()\n+ .AddCommand<Publis... | true | ||
Tyrrrz/YoutubeDownloader | 799 | comment_to_fix | Replace `Publish-MacOSBundle.ps1` and `Download-FFmpeg.ps1` with .NET 10 single-file C# scripts using CliFx | Quote paths | 43fde91b4e1789a8f30dfd908044b4c23f7c7ada | 8f8f8ac00193d1c3386c637363d79a042394fed6 | diff --git a/YoutubeDownloader/YoutubeDownloader.csproj b/YoutubeDownloader/YoutubeDownloader.csproj
index 9226627fe..9e8a3e312 100644
--- a/YoutubeDownloader/YoutubeDownloader.csproj
+++ b/YoutubeDownloader/YoutubeDownloader.csproj
@@ -86,12 +86,14 @@
Condition="$(DownloadFFmpeg) AND !Exists('ffmpeg.exe') AND !Ex... | [
"YoutubeDownloader/YoutubeDownloader.csproj"
] | [
{
"comment": "Quote paths",
"path": "YoutubeDownloader/YoutubeDownloader.csproj",
"hunk": "@@ -110,7 +112,8 @@\n <!-- Publish macOS bundle -->\n <Target Name=\"PublishMacOSBundle\" AfterTargets=\"Publish\" Condition=\"$(PublishMacOSBundle)\">\n <Exec\n- Command=\"pwsh -ExecutionPolicy Bypas... | true | ||
Tyrrrz/YoutubeDownloader | 799 | comment_to_fix | Replace `Publish-MacOSBundle.ps1` and `Download-FFmpeg.ps1` with .NET 10 single-file C# scripts using CliFx | ```suggestion
var archiveFilePath = outputPath + ".zip";
```
@copilot | 43fde91b4e1789a8f30dfd908044b4c23f7c7ada | 8f8f8ac00193d1c3386c637363d79a042394fed6 | diff --git a/YoutubeDownloader/DownloadFFmpeg.csx b/YoutubeDownloader/DownloadFFmpeg.csx
new file mode 100755
index 000000000..31ff4584b
--- /dev/null
+++ b/YoutubeDownloader/DownloadFFmpeg.csx
@@ -0,0 +1,96 @@
+#!/usr/bin/dotnet --
+#:package CliFx
+
+using System.IO.Compression;
+using System.Runtime.InteropServices;... | [
"YoutubeDownloader/DownloadFFmpeg.csx"
] | [
{
"comment": "```suggestion\n var archiveFilePath = outputPath + \".zip\";\n```\n\n@copilot ",
"path": "YoutubeDownloader/DownloadFFmpeg.csx",
"hunk": "@@ -0,0 +1,88 @@\n+#!/usr/bin/dotnet --\n+#:package CliFx\n+\n+using System.IO.Compression;\n+using System.Runtime.InteropServices;\n+using CliFx... | true | ||
Tyrrrz/YoutubeDownloader | 799 | comment_to_fix | Replace `Publish-MacOSBundle.ps1` and `Download-FFmpeg.ps1` with .NET 10 single-file C# scripts using CliFx | ```suggestion
$"https://github.com/Tyrrrz/FFmpegBin/releases/download/{FFmpegVersion}/ffmpeg-{platform}.zip",
```
Move FFmpeg version to an additional input with the default value of 8.0.1
@copilot | 43fde91b4e1789a8f30dfd908044b4c23f7c7ada | 8f8f8ac00193d1c3386c637363d79a042394fed6 | diff --git a/YoutubeDownloader/DownloadFFmpeg.csx b/YoutubeDownloader/DownloadFFmpeg.csx
new file mode 100755
index 000000000..31ff4584b
--- /dev/null
+++ b/YoutubeDownloader/DownloadFFmpeg.csx
@@ -0,0 +1,96 @@
+#!/usr/bin/dotnet --
+#:package CliFx
+
+using System.IO.Compression;
+using System.Runtime.InteropServices;... | [
"YoutubeDownloader/DownloadFFmpeg.csx"
] | [
{
"comment": "```suggestion\n $\"https://github.com/Tyrrrz/FFmpegBin/releases/download/{FFmpegVersion}/ffmpeg-{platform}.zip\",\n```\n\nMove FFmpeg version to an additional input with the default value of 8.0.1\n\n@copilot ",
"path": "YoutubeDownloader/DownloadFFmpeg.csx",
"hunk": "@@ -0,0 +1... | true | ||
Tyrrrz/YoutubeDownloader | 799 | comment_to_fix | Replace `Publish-MacOSBundle.ps1` and `Download-FFmpeg.ps1` with .NET 10 single-file C# scripts using CliFx | The archive file is created before the download completes, but cleanup is only in the extraction try/finally. If the HTTP request/copy fails or is cancelled, a partially downloaded `.zip` will be left on disk. Wrap the entire download+extract flow in a single try/finally (or delete the archive in a catch/finally) so th... | 43fde91b4e1789a8f30dfd908044b4c23f7c7ada | 8f8f8ac00193d1c3386c637363d79a042394fed6 | diff --git a/YoutubeDownloader/DownloadFFmpeg.csx b/YoutubeDownloader/DownloadFFmpeg.csx
new file mode 100755
index 000000000..31ff4584b
--- /dev/null
+++ b/YoutubeDownloader/DownloadFFmpeg.csx
@@ -0,0 +1,96 @@
+#!/usr/bin/dotnet --
+#:package CliFx
+
+using System.IO.Compression;
+using System.Runtime.InteropServices;... | [
"YoutubeDownloader/DownloadFFmpeg.csx"
] | [
{
"comment": "The archive file is created before the download completes, but cleanup is only in the extraction try/finally. If the HTTP request/copy fails or is cancelled, a partially downloaded `.zip` will be left on disk. Wrap the entire download+extract flow in a single try/finally (or delete the archive in ... | true | ||
Tyrrrz/YoutubeDownloader | 799 | comment_to_fix | Replace `Publish-MacOSBundle.ps1` and `Download-FFmpeg.ps1` with .NET 10 single-file C# scripts using CliFx | This uses a generic `Exception` for a user-facing error case (missing zip entry). Prefer throwing `CommandException` (as used above) so CliFx reports a clean message without an unexpected stack trace and with a proper exit code.
```suggestion
?? throw new CommandException($"Entry '{fileName}' not found ... | 43fde91b4e1789a8f30dfd908044b4c23f7c7ada | 8f8f8ac00193d1c3386c637363d79a042394fed6 | diff --git a/YoutubeDownloader/DownloadFFmpeg.csx b/YoutubeDownloader/DownloadFFmpeg.csx
new file mode 100755
index 000000000..31ff4584b
--- /dev/null
+++ b/YoutubeDownloader/DownloadFFmpeg.csx
@@ -0,0 +1,96 @@
+#!/usr/bin/dotnet --
+#:package CliFx
+
+using System.IO.Compression;
+using System.Runtime.InteropServices;... | [
"YoutubeDownloader/DownloadFFmpeg.csx"
] | [
{
"comment": "This uses a generic `Exception` for a user-facing error case (missing zip entry). Prefer throwing `CommandException` (as used above) so CliFx reports a clean message without an unexpected stack trace and with a proper exit code.\n```suggestion\n ?? throw new CommandException($\"Entr... | true | ||
Tyrrrz/YoutubeDownloader | 799 | comment_to_fix | Replace `Publish-MacOSBundle.ps1` and `Download-FFmpeg.ps1` with .NET 10 single-file C# scripts using CliFx | `platform.ToLower().Replace("win-", "windows-")` will replace the substring anywhere in the identifier (e.g., `darwin-x64` becomes `darwindows-x64`). If the intent is to normalize only the `win-` prefix, use a prefix check (e.g., `StartsWith("win-")`) and replace only the leading segment.
```suggestion
platform... | 43fde91b4e1789a8f30dfd908044b4c23f7c7ada | 8f8f8ac00193d1c3386c637363d79a042394fed6 | diff --git a/YoutubeDownloader/DownloadFFmpeg.csx b/YoutubeDownloader/DownloadFFmpeg.csx
new file mode 100755
index 000000000..31ff4584b
--- /dev/null
+++ b/YoutubeDownloader/DownloadFFmpeg.csx
@@ -0,0 +1,96 @@
+#!/usr/bin/dotnet --
+#:package CliFx
+
+using System.IO.Compression;
+using System.Runtime.InteropServices;... | [
"YoutubeDownloader/DownloadFFmpeg.csx"
] | [
{
"comment": "`platform.ToLower().Replace(\"win-\", \"windows-\")` will replace the substring anywhere in the identifier (e.g., `darwin-x64` becomes `darwindows-x64`). If the intent is to normalize only the `win-` prefix, use a prefix check (e.g., `StartsWith(\"win-\")`) and replace only the leading segment.\n`... | true | ||
Tyrrrz/YoutubeDownloader | 799 | comment_to_fix | Replace `Publish-MacOSBundle.ps1` and `Download-FFmpeg.ps1` with .NET 10 single-file C# scripts using CliFx | The `#:package CliFx` directive doesn't pin a version, which makes builds non-deterministic and can break CI if a future CliFx release introduces breaking changes. Specify an explicit package version in the directive to make the script reproducible.
```suggestion
#:package CliFx 2.4.0
``` | 43fde91b4e1789a8f30dfd908044b4c23f7c7ada | 8f8f8ac00193d1c3386c637363d79a042394fed6 | diff --git a/YoutubeDownloader/DownloadFFmpeg.csx b/YoutubeDownloader/DownloadFFmpeg.csx
new file mode 100755
index 000000000..31ff4584b
--- /dev/null
+++ b/YoutubeDownloader/DownloadFFmpeg.csx
@@ -0,0 +1,96 @@
+#!/usr/bin/dotnet --
+#:package CliFx
+
+using System.IO.Compression;
+using System.Runtime.InteropServices;... | [
"YoutubeDownloader/DownloadFFmpeg.csx"
] | [
{
"comment": "The `#:package CliFx` directive doesn't pin a version, which makes builds non-deterministic and can break CI if a future CliFx release introduces breaking changes. Specify an explicit package version in the directive to make the script reproducible.\n```suggestion\n#:package CliFx 2.4.0\n```",
... | true | ||
Tyrrrz/YoutubeDownloader | 799 | comment_to_fix | Replace `Publish-MacOSBundle.ps1` and `Download-FFmpeg.ps1` with .NET 10 single-file C# scripts using CliFx | The `#:package CliFx` directive doesn't pin a version, which makes builds non-deterministic and can break CI if a future CliFx release introduces breaking changes. Specify an explicit package version in the directive to make the script reproducible.
```suggestion
#:package CliFx 2.4.0
``` | 43fde91b4e1789a8f30dfd908044b4c23f7c7ada | 8f8f8ac00193d1c3386c637363d79a042394fed6 | diff --git a/YoutubeDownloader/PublishMacOSBundle.csx b/YoutubeDownloader/PublishMacOSBundle.csx
new file mode 100755
index 000000000..c3c8cb3a7
--- /dev/null
+++ b/YoutubeDownloader/PublishMacOSBundle.csx
@@ -0,0 +1,128 @@
+#!/usr/bin/dotnet --
+#:package CliFx
+
+using CliFx;
+using CliFx.Attributes;
+using CliFx.Inf... | [
"YoutubeDownloader/PublishMacOSBundle.csx"
] | [
{
"comment": "The `#:package CliFx` directive doesn't pin a version, which makes builds non-deterministic and can break CI if a future CliFx release introduces breaking changes. Specify an explicit package version in the directive to make the script reproducible.\n```suggestion\n#:package CliFx 2.4.0\n```",
... | true | ||
Tyrrrz/YoutubeDownloader | 799 | comment_to_fix | Replace `Publish-MacOSBundle.ps1` and `Download-FFmpeg.ps1` with .NET 10 single-file C# scripts using CliFx | ```suggestion
using var http = new HttpClient();
using var responseStream = await http.GetStreamAsync(
$"https://github.com/Tyrrrz/FFmpegBin/releases/download/7.1.2/ffmpeg-{platform}.zip",
console.CancellationToken
);
await using (var arch... | 43fde91b4e1789a8f30dfd908044b4c23f7c7ada | 8f8f8ac00193d1c3386c637363d79a042394fed6 | diff --git a/YoutubeDownloader/DownloadFFmpeg.csx b/YoutubeDownloader/DownloadFFmpeg.csx
new file mode 100755
index 000000000..31ff4584b
--- /dev/null
+++ b/YoutubeDownloader/DownloadFFmpeg.csx
@@ -0,0 +1,96 @@
+#!/usr/bin/dotnet --
+#:package CliFx
+
+using System.IO.Compression;
+using System.Runtime.InteropServices;... | [
"YoutubeDownloader/DownloadFFmpeg.csx"
] | [
{
"comment": "```suggestion\n using var http = new HttpClient();\n using var responseStream = await http.GetStreamAsync(\n $\"https://github.com/Tyrrrz/FFmpegBin/releases/download/7.1.2/ffmpeg-{platform}.zip\",\n console.CancellationToken\n );\n\n ... | true | ||
Tyrrrz/YoutubeDownloader | 799 | comment_to_fix | Replace `Publish-MacOSBundle.ps1` and `Download-FFmpeg.ps1` with .NET 10 single-file C# scripts using CliFx | This should reference `FFmpegVersion` instead of a constant version @copilot | 43fde91b4e1789a8f30dfd908044b4c23f7c7ada | 8f8f8ac00193d1c3386c637363d79a042394fed6 | diff --git a/YoutubeDownloader/DownloadFFmpeg.csx b/YoutubeDownloader/DownloadFFmpeg.csx
new file mode 100755
index 000000000..31ff4584b
--- /dev/null
+++ b/YoutubeDownloader/DownloadFFmpeg.csx
@@ -0,0 +1,96 @@
+#!/usr/bin/dotnet --
+#:package CliFx
+
+using System.IO.Compression;
+using System.Runtime.InteropServices;... | [
"YoutubeDownloader/DownloadFFmpeg.csx"
] | [
{
"comment": "This should reference `FFmpegVersion` instead of a constant version @copilot ",
"path": "YoutubeDownloader/DownloadFFmpeg.csx",
"hunk": "@@ -0,0 +1,94 @@\n+#!/usr/bin/dotnet --\n+#:package CliFx\n+\n+using System.IO.Compression;\n+using System.Runtime.InteropServices;\n+using CliFx;\n+usin... | true | ||
Tyrrrz/YoutubeDownloader | 799 | comment_to_fix | Replace `Publish-MacOSBundle.ps1` and `Download-FFmpeg.ps1` with .NET 10 single-file C# scripts using CliFx | ```suggestion
var cancellationToken = console.RegisterCancellationHandler();
await responseStream.CopyToAsync(archiveFile, cancellationToken);
``` | 43fde91b4e1789a8f30dfd908044b4c23f7c7ada | 8f8f8ac00193d1c3386c637363d79a042394fed6 | diff --git a/YoutubeDownloader/DownloadFFmpeg.csx b/YoutubeDownloader/DownloadFFmpeg.csx
new file mode 100755
index 000000000..31ff4584b
--- /dev/null
+++ b/YoutubeDownloader/DownloadFFmpeg.csx
@@ -0,0 +1,96 @@
+#!/usr/bin/dotnet --
+#:package CliFx
+
+using System.IO.Compression;
+using System.Runtime.InteropServices;... | [
"YoutubeDownloader/DownloadFFmpeg.csx"
] | [
{
"comment": "```suggestion\n var cancellationToken = console.RegisterCancellationHandler();\n await responseStream.CopyToAsync(archiveFile, cancellationToken);\n```",
"path": "YoutubeDownloader/DownloadFFmpeg.csx",
"hunk": "@@ -0,0 +1,94 @@\n+#!/usr/bin/dotnet --\n+#:packa... | true | ||
Tyrrrz/YoutubeDownloader | 799 | comment_to_fix | Replace `Publish-MacOSBundle.ps1` and `Download-FFmpeg.ps1` with .NET 10 single-file C# scripts using CliFx | ```suggestion
var entry =
zip.GetEntry(fileName)
?? throw new CommandException($"Entry '{fileName}' not found in the downloaded archive.");
entry.ExtractToFile(outputPath, true);
``` | 43fde91b4e1789a8f30dfd908044b4c23f7c7ada | 8f8f8ac00193d1c3386c637363d79a042394fed6 | diff --git a/YoutubeDownloader/DownloadFFmpeg.csx b/YoutubeDownloader/DownloadFFmpeg.csx
new file mode 100755
index 000000000..31ff4584b
--- /dev/null
+++ b/YoutubeDownloader/DownloadFFmpeg.csx
@@ -0,0 +1,96 @@
+#!/usr/bin/dotnet --
+#:package CliFx
+
+using System.IO.Compression;
+using System.Runtime.InteropServices;... | [
"YoutubeDownloader/DownloadFFmpeg.csx"
] | [
{
"comment": "```suggestion\n\n var entry =\n zip.GetEntry(fileName)\n ?? throw new CommandException($\"Entry '{fileName}' not found in the downloaded archive.\");\n\n entry.ExtractToFile(outputPath, true);\n```",
"path": "YoutubeDownloader/DownloadFFmpeg.... | true | ||
Tyrrrz/YoutubeDownloader | 798 | issue_to_patch | Add `YOUTUBEDOWNLOADER_ALLOW_AUTO_UPDATE` env var to suppress auto-update | Deployments and package managers need a way to disable the auto-update mechanism without patching settings files. Setting `YOUTUBEDOWNLOADER_ALLOW_AUTO_UPDATE=false` now disables both the `UpdateManager` initialization and the auto-update toggle in Settings UI.
## Changes
- **`StartOptions.cs`** — added `IsAutoUpdate... | a38f16fc931419e4403437d11f35e909942f46d5 | ac19a9357e9cfbcfccf3bd2ec0a10d23faa2d272 | diff --git a/YoutubeDownloader/Services/UpdateService.cs b/YoutubeDownloader/Services/UpdateService.cs
index 57ddab397..10ff2105e 100644
--- a/YoutubeDownloader/Services/UpdateService.cs
+++ b/YoutubeDownloader/Services/UpdateService.cs
@@ -10,23 +10,24 @@ namespace YoutubeDownloader.Services;
public class UpdateSer... | [
"YoutubeDownloader/Services/UpdateService.cs",
"YoutubeDownloader/StartOptions.cs",
"YoutubeDownloader/ViewModels/Dialogs/SettingsViewModel.cs",
"YoutubeDownloader/Views/Dialogs/SettingsView.axaml"
] | [
{
"comment": "Env var parsing for `YOUTUBEDOWNLOADER_ALLOW_AUTO_UPDATE` only matches the exact string \"false\" (case-insensitive) but does not handle leading/trailing whitespace (e.g., \" false \"), which will unexpectedly keep auto-updates enabled. Consider trimming the value (or using `bool.TryParse` with a ... | true | ||
Tyrrrz/YoutubeDownloader | 798 | comment_to_fix | Add `YOUTUBEDOWNLOADER_ALLOW_AUTO_UPDATE` env var to suppress auto-update | Env var parsing for `YOUTUBEDOWNLOADER_ALLOW_AUTO_UPDATE` only matches the exact string "false" (case-insensitive) but does not handle leading/trailing whitespace (e.g., " false "), which will unexpectedly keep auto-updates enabled. Consider trimming the value (or using `bool.TryParse` with a default-to-true fallback) ... | a38f16fc931419e4403437d11f35e909942f46d5 | ac19a9357e9cfbcfccf3bd2ec0a10d23faa2d272 | diff --git a/YoutubeDownloader/StartOptions.cs b/YoutubeDownloader/StartOptions.cs
index 40b2fd0f4..3e44ec59c 100644
--- a/YoutubeDownloader/StartOptions.cs
+++ b/YoutubeDownloader/StartOptions.cs
@@ -6,6 +6,8 @@ namespace YoutubeDownloader;
public partial class StartOptions
{
public required string SettingsPath... | [
"YoutubeDownloader/StartOptions.cs"
] | [
{
"comment": "Env var parsing for `YOUTUBEDOWNLOADER_ALLOW_AUTO_UPDATE` only matches the exact string \"false\" (case-insensitive) but does not handle leading/trailing whitespace (e.g., \" false \"), which will unexpectedly keep auto-updates enabled. Consider trimming the value (or using `bool.TryParse` with a ... | true | ||
Tyrrrz/YoutubeDownloader | 658 | issue_to_patch | Download FFmpeg via a project target | 1041df00078268596f05f12d33cee92d971a1d15 | 6dbfd290faae4d1473dd59155160db3a284251ed | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index a6ff706c8..fad35e8d1 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -92,16 +92,12 @@ jobs:
with:
dotnet-version: 9.0.x
- - name: Download FFmpeg
- if: ${{ matrix.bundle-ffmpeg }}
- ... | [
".github/workflows/main.yml",
"YoutubeDownloader/Download-FFmpeg.ps1",
"YoutubeDownloader/DownloadFFmpeg.ps1",
"YoutubeDownloader/YoutubeDownloader.csproj"
] | [] | true | |||
Tyrrrz/YoutubeDownloader | 780 | issue_to_patch | Update YoutubeExplode to 6.5.7 to fix 403 errors | Recent YouTube API changes caused 403 errors when downloading videos. YoutubeExplode 6.5.7 switches to ANDROID_VR client to bypass the new PO token requirement.
## Changes
- Updated `YoutubeExplode` from 6.5.6 → 6.5.7
- Updated `YoutubeExplode.Converter` from 6.5.6 → 6.5.7
> [!WARNING]
>
> <details>
> <summary>Firewa... | 5ebb2c9554be981156b61aa0115904110774158f | 0c16fe1abfbdf0ac79a006781db29a496ee0704b | diff --git a/YoutubeDownloader.Core/YoutubeDownloader.Core.csproj b/YoutubeDownloader.Core/YoutubeDownloader.Core.csproj
index 4be2b92c1..1072a091a 100644
--- a/YoutubeDownloader.Core/YoutubeDownloader.Core.csproj
+++ b/YoutubeDownloader.Core/YoutubeDownloader.Core.csproj
@@ -4,7 +4,7 @@
<PackageReference Include=... | [
"YoutubeDownloader.Core/YoutubeDownloader.Core.csproj"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 779 | issue_to_patch | "Lowest Quality" Option Selects "Highest Quality" Instead of 144p
### Version
1.15.2
### Platform
Windows 11
### Steps to reproduce
Playlist URL:
https://www.youtube.com/playlist?list=PLBtp_AFLHDXFgIKrJI62INCZWTxS_t8Qv
<img width="1919" height="1199" alt="Image" src="https://github.com/user-attachments/assets/eb... | Fix "Lowest Quality" Option Selects "Highest Quality" Instead of 144p | ## Summary
Fixed issue #759 where selecting "Lowest Quality" option was downloading the highest quality (2160p) instead of the lowest (144p).
Closes #759
## Bug Description
When users selected "Lowest Quality" preference for video downloads, the application incorrectly downloaded the highest available quality (e.g.... | fab3441ab80e64000fe3ae802bdb514ca0569013 | d720379b73768c54e0cd73ffa31ea1d0d5aea73f | diff --git a/YoutubeDownloader.Core/Downloading/VideoDownloadPreference.cs b/YoutubeDownloader.Core/Downloading/VideoDownloadPreference.cs
index 68a2047fd..970961ba6 100644
--- a/YoutubeDownloader.Core/Downloading/VideoDownloadPreference.cs
+++ b/YoutubeDownloader.Core/Downloading/VideoDownloadPreference.cs
@@ -40,7 +4... | [
"YoutubeDownloader.Core/Downloading/VideoDownloadPreference.cs"
] | [
{
"comment": "`orderedOptions` is built from `options.OrderBy(o => o.VideoQuality)`, and audio-only options have `VideoQuality == null` (see `VideoDownloadOption.VideoQuality`), which will sort first. Switching `Lowest` to `FirstOrDefault` can therefore select an audio-only option that shares the same container... | true | |
Tyrrrz/YoutubeDownloader | 794 | issue_to_patch | Add support for custom settings path | To easily allow packaging the app in environments that don't allow modifications to the package directory (like NixOS), this PR adds the option to define a custom directory to store the settings in. The directory can be defined with an environment variable.
Proposed variable name is `SETTINGS_PATH`
This solution ... | 1ffa2e154cb83b0b4584ca4b8208fb9e1df3b089 | baa0e3e17d0491055515cf23f650a3e77aa229cf | diff --git a/YoutubeDownloader/Services/SettingsService.cs b/YoutubeDownloader/Services/SettingsService.cs
index d063fa13d..3ecff487b 100644
--- a/YoutubeDownloader/Services/SettingsService.cs
+++ b/YoutubeDownloader/Services/SettingsService.cs
@@ -1,6 +1,5 @@
using System;
using System.Collections.Generic;
-using S... | [
"YoutubeDownloader/Services/SettingsService.cs",
"YoutubeDownloader/StartOptions.cs"
] | [
{
"comment": "This name is too generic for an environment variable, let's prefix with the app name: `YOUTUBEDOWNLOADER_SETTINGS_PATH`",
"path": "YoutubeDownloader/StartOptions.cs",
"hunk": "@@ -0,0 +1,63 @@\n+using System;\n+using System.Collections;\n+using System.Diagnostics.CodeAnalysis;\n+using Syst... | true | ||
Tyrrrz/YoutubeDownloader | 794 | comment_to_fix | Add support for custom settings path | `TryMakeValidPath` is using `Uri.TryCreate(..., UriKind.RelativeOrAbsolute, ...)` and then returning `uri.ToString()`. For Windows paths like `C:\...`, this will produce a `file:///C:/...` URI string, which is not a valid filesystem path for `SettingsBase`/IO APIs. Also, `Uri.TryCreate` will succeed for many strings th... | 1ffa2e154cb83b0b4584ca4b8208fb9e1df3b089 | baa0e3e17d0491055515cf23f650a3e77aa229cf | diff --git a/YoutubeDownloader/StartOptions.cs b/YoutubeDownloader/StartOptions.cs
new file mode 100644
index 000000000..7f1b2cfc1
--- /dev/null
+++ b/YoutubeDownloader/StartOptions.cs
@@ -0,0 +1,33 @@
+using System;
+using System.IO;
+
+namespace YoutubeDownloader;
+
+public partial class StartOptions
+{
+ public r... | [
"YoutubeDownloader/StartOptions.cs"
] | [
{
"comment": "`TryMakeValidPath` is using `Uri.TryCreate(..., UriKind.RelativeOrAbsolute, ...)` and then returning `uri.ToString()`. For Windows paths like `C:\\...`, this will produce a `file:///C:/...` URI string, which is not a valid filesystem path for `SettingsBase`/IO APIs. Also, `Uri.TryCreate` will succ... | true | ||
Tyrrrz/YoutubeDownloader | 794 | comment_to_fix | Add support for custom settings path | `SETTINGS_PATH` being set to an empty/whitespace string currently results in `Path.Combine(pathToDirectory, SettingsFileName)` producing a relative `Settings.dat` (i.e., in the current working directory) instead of falling back to `DefaultSettingsPath`. Treat empty/whitespace values as invalid and fall back to the defa... | 1ffa2e154cb83b0b4584ca4b8208fb9e1df3b089 | baa0e3e17d0491055515cf23f650a3e77aa229cf | diff --git a/YoutubeDownloader/StartOptions.cs b/YoutubeDownloader/StartOptions.cs
new file mode 100644
index 000000000..7f1b2cfc1
--- /dev/null
+++ b/YoutubeDownloader/StartOptions.cs
@@ -0,0 +1,33 @@
+using System;
+using System.IO;
+
+namespace YoutubeDownloader;
+
+public partial class StartOptions
+{
+ public r... | [
"YoutubeDownloader/StartOptions.cs"
] | [
{
"comment": "`SETTINGS_PATH` being set to an empty/whitespace string currently results in `Path.Combine(pathToDirectory, SettingsFileName)` producing a relative `Settings.dat` (i.e., in the current working directory) instead of falling back to `DefaultSettingsPath`. Treat empty/whitespace values as invalid and... | true | ||
Tyrrrz/YoutubeDownloader | 794 | comment_to_fix | Add support for custom settings path | The env var name `SETTINGS_PATH` suggests it should contain a full settings file path, but the implementation treats it as a *directory* and appends `Settings.dat`. This ambiguity can easily lead to misconfiguration (e.g., users setting it to a file path and ending up with `.../Settings.dat/Settings.dat`). Consider eit... | 1ffa2e154cb83b0b4584ca4b8208fb9e1df3b089 | baa0e3e17d0491055515cf23f650a3e77aa229cf | diff --git a/YoutubeDownloader/StartOptions.cs b/YoutubeDownloader/StartOptions.cs
new file mode 100644
index 000000000..7f1b2cfc1
--- /dev/null
+++ b/YoutubeDownloader/StartOptions.cs
@@ -0,0 +1,33 @@
+using System;
+using System.IO;
+
+namespace YoutubeDownloader;
+
+public partial class StartOptions
+{
+ public r... | [
"YoutubeDownloader/StartOptions.cs"
] | [
{
"comment": "The env var name `SETTINGS_PATH` suggests it should contain a full settings file path, but the implementation treats it as a *directory* and appends `Settings.dat`. This ambiguity can easily lead to misconfiguration (e.g., users setting it to a file path and ending up with `.../Settings.dat/Settin... | true | ||
Tyrrrz/YoutubeDownloader | 794 | comment_to_fix | Add support for custom settings path | ```suggestion
private static readonly string SettingsPathVariable = "YOUTUBEDOWNLOADER_SETTINGS_PATH";
```
We can handle both directory and file paths | 1ffa2e154cb83b0b4584ca4b8208fb9e1df3b089 | baa0e3e17d0491055515cf23f650a3e77aa229cf | diff --git a/YoutubeDownloader/StartOptions.cs b/YoutubeDownloader/StartOptions.cs
new file mode 100644
index 000000000..7f1b2cfc1
--- /dev/null
+++ b/YoutubeDownloader/StartOptions.cs
@@ -0,0 +1,33 @@
+using System;
+using System.IO;
+
+namespace YoutubeDownloader;
+
+public partial class StartOptions
+{
+ public r... | [
"YoutubeDownloader/StartOptions.cs"
] | [
{
"comment": "```suggestion\n private static readonly string SettingsPathVariable = \"YOUTUBEDOWNLOADER_SETTINGS_PATH\";\n```\n\nWe can handle both directory and file paths",
"path": "YoutubeDownloader/StartOptions.cs",
"hunk": "@@ -0,0 +1,69 @@\n+using System;\n+using System.Collections;\n+using Sys... | true | ||
Tyrrrz/YoutubeDownloader | 794 | comment_to_fix | Add support for custom settings path | In case with environment variables, we can drop the `Parse` method since they're already in key-value pairs. See my next comment.
Also can remove `GetSettingsPath` | 1ffa2e154cb83b0b4584ca4b8208fb9e1df3b089 | baa0e3e17d0491055515cf23f650a3e77aa229cf | diff --git a/YoutubeDownloader/StartOptions.cs b/YoutubeDownloader/StartOptions.cs
new file mode 100644
index 000000000..7f1b2cfc1
--- /dev/null
+++ b/YoutubeDownloader/StartOptions.cs
@@ -0,0 +1,33 @@
+using System;
+using System.IO;
+
+namespace YoutubeDownloader;
+
+public partial class StartOptions
+{
+ public r... | [
"YoutubeDownloader/StartOptions.cs"
] | [
{
"comment": "In case with environment variables, we can drop the `Parse` method since they're already in key-value pairs. See my next comment.\r\n\r\nAlso can remove `GetSettingsPath`",
"path": "YoutubeDownloader/StartOptions.cs",
"hunk": "@@ -0,0 +1,69 @@\n+using System;\n+using System.Collections;\n+... | true | ||
Tyrrrz/YoutubeDownloader | 794 | comment_to_fix | Add support for custom settings path | ```suggestion
public static StartOptions Current { get; } = new()
{
SettingsPath = Environment.GetEnvironmentVariable(SettingsPathVariable) is { } path
? Path.EndsInDirectorySeparator(path) || Directory.Exists(path)
? Path.Combine(path, SettingsFileName)
: pat... | 1ffa2e154cb83b0b4584ca4b8208fb9e1df3b089 | baa0e3e17d0491055515cf23f650a3e77aa229cf | diff --git a/YoutubeDownloader/StartOptions.cs b/YoutubeDownloader/StartOptions.cs
new file mode 100644
index 000000000..7f1b2cfc1
--- /dev/null
+++ b/YoutubeDownloader/StartOptions.cs
@@ -0,0 +1,33 @@
+using System;
+using System.IO;
+
+namespace YoutubeDownloader;
+
+public partial class StartOptions
+{
+ public r... | [
"YoutubeDownloader/StartOptions.cs"
] | [
{
"comment": "```suggestion\n public static StartOptions Current { get; } = new()\n {\n SettingsPath = Environment.GetEnvironmentVariable(SettingsPathVariable) is { } path\n ? Path.EndsInDirectorySeparator(path) || Directory.Exists(path)\n ? Path.Combine(path, SettingsFile... | true | ||
Tyrrrz/YoutubeDownloader | 794 | comment_to_fix | Add support for custom settings path | We don't have to do this. If the user provides an incorrect path, they will get an exception when `SettingsService` tries to initialize. Otherwise, paths are resolved to their full forms automatically, based on current working directory. | 1ffa2e154cb83b0b4584ca4b8208fb9e1df3b089 | baa0e3e17d0491055515cf23f650a3e77aa229cf | diff --git a/YoutubeDownloader/StartOptions.cs b/YoutubeDownloader/StartOptions.cs
new file mode 100644
index 000000000..7f1b2cfc1
--- /dev/null
+++ b/YoutubeDownloader/StartOptions.cs
@@ -0,0 +1,33 @@
+using System;
+using System.IO;
+
+namespace YoutubeDownloader;
+
+public partial class StartOptions
+{
+ public r... | [
"YoutubeDownloader/StartOptions.cs"
] | [
{
"comment": "We don't have to do this. If the user provides an incorrect path, they will get an exception when `SettingsService` tries to initialize. Otherwise, paths are resolved to their full forms automatically, based on current working directory.",
"path": "YoutubeDownloader/StartOptions.cs",
"hunk... | true | ||
Tyrrrz/YoutubeDownloader | 796 | issue_to_patch | Possible race condition when closing the app on Linux
### Version
v1.16
### Platform
Linux x64 (Tested on NixOS and Fedora)
### Steps to reproduce
1. Take note of the current content of Settings.dat
2. Open the app via the terminal
3. Wait for the UI to show
4. Change settings in the app UI
5. Close the UI using ... | Fix a race condition that could prevent the app from persisting settings | Moved the shutdown logic from `MainViewModel.Dispose()` to `IControlledApplicationLifetime.Exit` event handler.
This makes sure the save logic is executed reliably.
Out of my ~20 test runs no exception was thrown and changes persisted as expected.
<!--
**Important**
This pull request should be linked to an i... | 1ffa2e154cb83b0b4584ca4b8208fb9e1df3b089 | 7f5adc5c3e3593243699055b1181173c84f48d2b | diff --git a/YoutubeDownloader/App.axaml.cs b/YoutubeDownloader/App.axaml.cs
index d821106f5..8c57a4f9b 100644
--- a/YoutubeDownloader/App.axaml.cs
+++ b/YoutubeDownloader/App.axaml.cs
@@ -27,6 +27,8 @@ public class App : Application, IDisposable
private readonly SettingsService _settingsService;
private read... | [
"YoutubeDownloader/App.axaml.cs"
] | [
{
"comment": "Can't we just call `_mainViewModel.Dispose()` here instead?",
"path": "YoutubeDownloader/App.axaml.cs",
"hunk": "@@ -120,6 +125,15 @@ public override void OnFrameworkInitializationCompleted()\n _settingsService.Load();\n }\n \n+ private void DesktopOnExit(object? sender, Con... | true | |
Tyrrrz/YoutubeDownloader | 796 | comment_to_fix | Fix a race condition that could prevent the app from persisting settings | Can't we just call `_mainViewModel.Dispose()` here instead? | 1ffa2e154cb83b0b4584ca4b8208fb9e1df3b089 | 7f5adc5c3e3593243699055b1181173c84f48d2b | diff --git a/YoutubeDownloader/App.axaml.cs b/YoutubeDownloader/App.axaml.cs
index d821106f5..8c57a4f9b 100644
--- a/YoutubeDownloader/App.axaml.cs
+++ b/YoutubeDownloader/App.axaml.cs
@@ -27,6 +27,8 @@ public class App : Application, IDisposable
private readonly SettingsService _settingsService;
private read... | [
"YoutubeDownloader/App.axaml.cs"
] | [
{
"comment": "Can't we just call `_mainViewModel.Dispose()` here instead?",
"path": "YoutubeDownloader/App.axaml.cs",
"hunk": "@@ -120,6 +125,15 @@ public override void OnFrameworkInitializationCompleted()\n _settingsService.Load();\n }\n \n+ private void DesktopOnExit(object? sender, Con... | true | ||
Tyrrrz/YoutubeDownloader | 796 | comment_to_fix | Fix a race condition that could prevent the app from persisting settings | ```suggestion
private void Desktop_OnExit(object? sender, ControlledApplicationLifetimeExitEventArgs e)
``` | 1ffa2e154cb83b0b4584ca4b8208fb9e1df3b089 | 7f5adc5c3e3593243699055b1181173c84f48d2b | diff --git a/YoutubeDownloader/App.axaml.cs b/YoutubeDownloader/App.axaml.cs
index d821106f5..8c57a4f9b 100644
--- a/YoutubeDownloader/App.axaml.cs
+++ b/YoutubeDownloader/App.axaml.cs
@@ -27,6 +27,8 @@ public class App : Application, IDisposable
private readonly SettingsService _settingsService;
private read... | [
"YoutubeDownloader/App.axaml.cs"
] | [
{
"comment": "```suggestion\n private void Desktop_OnExit(object? sender, ControlledApplicationLifetimeExitEventArgs e)\n```",
"path": "YoutubeDownloader/App.axaml.cs",
"hunk": "@@ -120,6 +123,11 @@ public override void OnFrameworkInitializationCompleted()\n _settingsService.Load();\n }\n... | true | ||
Tyrrrz/YoutubeDownloader | 796 | comment_to_fix | Fix a race condition that could prevent the app from persisting settings | ```suggestion
_mainViewModel.Dispose();
desktop.Exit -= Desktop_OnExit;
```
Probably should unsubscribe here just in case. | 1ffa2e154cb83b0b4584ca4b8208fb9e1df3b089 | 7f5adc5c3e3593243699055b1181173c84f48d2b | diff --git a/YoutubeDownloader/App.axaml.cs b/YoutubeDownloader/App.axaml.cs
index d821106f5..8c57a4f9b 100644
--- a/YoutubeDownloader/App.axaml.cs
+++ b/YoutubeDownloader/App.axaml.cs
@@ -27,6 +27,8 @@ public class App : Application, IDisposable
private readonly SettingsService _settingsService;
private read... | [
"YoutubeDownloader/App.axaml.cs"
] | [
{
"comment": "```suggestion\n _mainViewModel.Dispose();\n desktop.Exit -= Desktop_OnExit;\n```\n\nProbably should unsubscribe here just in case.",
"path": "YoutubeDownloader/App.axaml.cs",
"hunk": "@@ -120,6 +123,11 @@ public override void OnFrameworkInitializationCompleted()\n _se... | true | ||
Tyrrrz/YoutubeDownloader | 796 | comment_to_fix | Fix a race condition that could prevent the app from persisting settings | ```suggestion
desktop.Exit += Desktop_OnExit;
``` | 1ffa2e154cb83b0b4584ca4b8208fb9e1df3b089 | 7f5adc5c3e3593243699055b1181173c84f48d2b | diff --git a/YoutubeDownloader/App.axaml.cs b/YoutubeDownloader/App.axaml.cs
index d821106f5..8c57a4f9b 100644
--- a/YoutubeDownloader/App.axaml.cs
+++ b/YoutubeDownloader/App.axaml.cs
@@ -27,6 +27,8 @@ public class App : Application, IDisposable
private readonly SettingsService _settingsService;
private read... | [
"YoutubeDownloader/App.axaml.cs"
] | [
{
"comment": "```suggestion\n desktop.Exit += Desktop_OnExit;\n```",
"path": "YoutubeDownloader/App.axaml.cs",
"hunk": "@@ -109,7 +109,10 @@ private void InitializeTheme()\n public override void OnFrameworkInitializationCompleted()\n {\n if (ApplicationLifetime is IClassicDesk... | true | ||
Tyrrrz/YoutubeDownloader | 796 | comment_to_fix | Fix a race condition that could prevent the app from persisting settings | `_mainViewModel` is created via `ServiceProvider` (DI) and implements `IDisposable`, so `_services.Dispose()` in `App.Dispose()` will also dispose it. Disposing it here on `desktop.Exit` means the shutdown logic in `MainViewModel.Dispose(bool)` (settings save + update finalize) will run twice, which can lead to duplica... | 1ffa2e154cb83b0b4584ca4b8208fb9e1df3b089 | 7f5adc5c3e3593243699055b1181173c84f48d2b | diff --git a/YoutubeDownloader/App.axaml.cs b/YoutubeDownloader/App.axaml.cs
index d821106f5..8c57a4f9b 100644
--- a/YoutubeDownloader/App.axaml.cs
+++ b/YoutubeDownloader/App.axaml.cs
@@ -27,6 +27,8 @@ public class App : Application, IDisposable
private readonly SettingsService _settingsService;
private read... | [
"YoutubeDownloader/App.axaml.cs"
] | [
{
"comment": "`_mainViewModel` is created via `ServiceProvider` (DI) and implements `IDisposable`, so `_services.Dispose()` in `App.Dispose()` will also dispose it. Disposing it here on `desktop.Exit` means the shutdown logic in `MainViewModel.Dispose(bool)` (settings save + update finalize) will run twice, whi... | true | ||
Tyrrrz/YoutubeDownloader | 796 | comment_to_fix | Fix a race condition that could prevent the app from persisting settings | ```suggestion
if (_isDisposed)
return;
_isDisposed = true;
_eventRoot.Dispose();
_services.Dispose();
``` | 1ffa2e154cb83b0b4584ca4b8208fb9e1df3b089 | 7f5adc5c3e3593243699055b1181173c84f48d2b | diff --git a/YoutubeDownloader/App.axaml.cs b/YoutubeDownloader/App.axaml.cs
index d821106f5..8c57a4f9b 100644
--- a/YoutubeDownloader/App.axaml.cs
+++ b/YoutubeDownloader/App.axaml.cs
@@ -27,6 +27,8 @@ public class App : Application, IDisposable
private readonly SettingsService _settingsService;
private read... | [
"YoutubeDownloader/App.axaml.cs"
] | [
{
"comment": "```suggestion\n if (_isDisposed)\n return;\n\n _isDisposed = true;\n\n_eventRoot.Dispose();\n_services.Dispose();\n```",
"path": "YoutubeDownloader/App.axaml.cs",
"hunk": "@@ -120,13 +125,26 @@ public override void OnFrameworkInitializationCompleted()\n _se... | true | ||
Tyrrrz/YoutubeDownloader | 796 | comment_to_fix | Fix a race condition that could prevent the app from persisting settings | ```suggestion
if (sender is IControlledApplicationLifetime lifetime)
lifetime.Exit -= Desktop_OnExit;
Dispose();
``` | 1ffa2e154cb83b0b4584ca4b8208fb9e1df3b089 | 7f5adc5c3e3593243699055b1181173c84f48d2b | diff --git a/YoutubeDownloader/App.axaml.cs b/YoutubeDownloader/App.axaml.cs
index d821106f5..8c57a4f9b 100644
--- a/YoutubeDownloader/App.axaml.cs
+++ b/YoutubeDownloader/App.axaml.cs
@@ -27,6 +27,8 @@ public class App : Application, IDisposable
private readonly SettingsService _settingsService;
private read... | [
"YoutubeDownloader/App.axaml.cs"
] | [
{
"comment": "```suggestion\n if (sender is IControlledApplicationLifetime lifetime)\n lifetime.Exit -= Desktop_OnExit;\n\n Dispose();\n```",
"path": "YoutubeDownloader/App.axaml.cs",
"hunk": "@@ -120,13 +125,26 @@ public override void OnFrameworkInitializationCompleted()\n ... | true | ||
Tyrrrz/YoutubeDownloader | 796 | comment_to_fix | Fix a race condition that could prevent the app from persisting settings | ```suggestion
if (_isDisposed)
return;
_isDisposed = true;
_eventRoot.Dispose();
_services.Dispose();
``` | 1ffa2e154cb83b0b4584ca4b8208fb9e1df3b089 | 7f5adc5c3e3593243699055b1181173c84f48d2b | diff --git a/YoutubeDownloader/App.axaml.cs b/YoutubeDownloader/App.axaml.cs
index d821106f5..8c57a4f9b 100644
--- a/YoutubeDownloader/App.axaml.cs
+++ b/YoutubeDownloader/App.axaml.cs
@@ -27,6 +27,8 @@ public class App : Application, IDisposable
private readonly SettingsService _settingsService;
private read... | [
"YoutubeDownloader/App.axaml.cs"
] | [
{
"comment": "```suggestion\n if (_isDisposed)\n return;\n\n _isDisposed = true;\n\n\t\t\t\t_eventRoot.Dispose();\n\t\t\t\t_services.Dispose();\n```",
"path": "YoutubeDownloader/App.axaml.cs",
"hunk": "@@ -120,13 +125,26 @@ public override void OnFrameworkInitializationCompleted... | true | ||
Tyrrrz/YoutubeDownloader | 796 | comment_to_fix | Fix a race condition that could prevent the app from persisting settings | ```suggestion
_eventRoot.Dispose();
_services.Dispose();
``` | 1ffa2e154cb83b0b4584ca4b8208fb9e1df3b089 | 7f5adc5c3e3593243699055b1181173c84f48d2b | diff --git a/YoutubeDownloader/App.axaml.cs b/YoutubeDownloader/App.axaml.cs
index d821106f5..8c57a4f9b 100644
--- a/YoutubeDownloader/App.axaml.cs
+++ b/YoutubeDownloader/App.axaml.cs
@@ -27,6 +27,8 @@ public class App : Application, IDisposable
private readonly SettingsService _settingsService;
private read... | [
"YoutubeDownloader/App.axaml.cs"
] | [
{
"comment": "```suggestion\n _eventRoot.Dispose();\n _services.Dispose();\n```",
"path": "YoutubeDownloader/App.axaml.cs",
"hunk": "@@ -120,13 +125,26 @@ public override void OnFrameworkInitializationCompleted()\n _settingsService.Load();\n }\n \n+ private void Desktop_OnEx... | true | ||
Tyrrrz/YoutubeDownloader | 796 | comment_to_fix | Fix a race condition that could prevent the app from persisting settings | ```suggestion
// App's `Dispose()` method may not be called on some systems,
// so we add this handlers as a fallback.
// https://github.com/Tyrrrz/YoutubeDownloader/issues/795
desktop.Exit += Desktop_OnExit;
``` | 1ffa2e154cb83b0b4584ca4b8208fb9e1df3b089 | 7f5adc5c3e3593243699055b1181173c84f48d2b | diff --git a/YoutubeDownloader/App.axaml.cs b/YoutubeDownloader/App.axaml.cs
index d821106f5..8c57a4f9b 100644
--- a/YoutubeDownloader/App.axaml.cs
+++ b/YoutubeDownloader/App.axaml.cs
@@ -27,6 +27,8 @@ public class App : Application, IDisposable
private readonly SettingsService _settingsService;
private read... | [
"YoutubeDownloader/App.axaml.cs"
] | [
{
"comment": "```suggestion\n\n // App's `Dispose()` method may not be called on some systems,\n // so we add this handlers as a fallback.\n // https://github.com/Tyrrrz/YoutubeDownloader/issues/795\n desktop.Exit += Desktop_OnExit;\n```",
"path": "YoutubeDownload... | true | ||
Tyrrrz/YoutubeDownloader | 796 | comment_to_fix | Fix a race condition that could prevent the app from persisting settings | In the comment, "we add this handlers" is grammatically incorrect (and it’s a single subscription). Consider changing it to "we add this handler" (or "we add an Exit handler").
```suggestion
// so we add this handler as a fallback.
``` | 1ffa2e154cb83b0b4584ca4b8208fb9e1df3b089 | 7f5adc5c3e3593243699055b1181173c84f48d2b | diff --git a/YoutubeDownloader/App.axaml.cs b/YoutubeDownloader/App.axaml.cs
index d821106f5..8c57a4f9b 100644
--- a/YoutubeDownloader/App.axaml.cs
+++ b/YoutubeDownloader/App.axaml.cs
@@ -27,6 +27,8 @@ public class App : Application, IDisposable
private readonly SettingsService _settingsService;
private read... | [
"YoutubeDownloader/App.axaml.cs"
] | [
{
"comment": "In the comment, \"we add this handlers\" is grammatically incorrect (and it’s a single subscription). Consider changing it to \"we add this handler\" (or \"we add an Exit handler\").\n```suggestion\n // so we add this handler as a fallback.\n```",
"path": "YoutubeDownloader/App.axam... | true | ||
Tyrrrz/YoutubeDownloader | 796 | comment_to_fix | Fix a race condition that could prevent the app from persisting settings | The comment says `App.Dispose()` may not be called on some systems, but `Program.Main` always calls `builder.Instance.Dispose()` in a `finally` block (Program.cs:46-50). If the real problem is that disposal happens too late (after platform teardown) or not reliably before settings persistence, consider rewording this c... | 1ffa2e154cb83b0b4584ca4b8208fb9e1df3b089 | 7f5adc5c3e3593243699055b1181173c84f48d2b | diff --git a/YoutubeDownloader/App.axaml.cs b/YoutubeDownloader/App.axaml.cs
index d821106f5..8c57a4f9b 100644
--- a/YoutubeDownloader/App.axaml.cs
+++ b/YoutubeDownloader/App.axaml.cs
@@ -27,6 +27,8 @@ public class App : Application, IDisposable
private readonly SettingsService _settingsService;
private read... | [
"YoutubeDownloader/App.axaml.cs"
] | [
{
"comment": "The comment says `App.Dispose()` may not be called on some systems, but `Program.Main` always calls `builder.Instance.Dispose()` in a `finally` block (Program.cs:46-50). If the real problem is that disposal happens too late (after platform teardown) or not reliably before settings persistence, con... | true | ||
Tyrrrz/YoutubeDownloader | 796 | comment_to_fix | Fix a race condition that could prevent the app from persisting settings | ```suggestion
// Although `App.Dispose()` is invoked from `Program.Main(...)`, on some platforms
// it may be called too late in the shutdown lifecycle. Attach an exit
// handler to ensure timely disposal as a safeguard.
``` | 1ffa2e154cb83b0b4584ca4b8208fb9e1df3b089 | 7f5adc5c3e3593243699055b1181173c84f48d2b | diff --git a/YoutubeDownloader/App.axaml.cs b/YoutubeDownloader/App.axaml.cs
index d821106f5..8c57a4f9b 100644
--- a/YoutubeDownloader/App.axaml.cs
+++ b/YoutubeDownloader/App.axaml.cs
@@ -27,6 +27,8 @@ public class App : Application, IDisposable
private readonly SettingsService _settingsService;
private read... | [
"YoutubeDownloader/App.axaml.cs"
] | [
{
"comment": "```suggestion\n // Although `App.Dispose()` is invoked from `Program.Main(...)`, on some platforms\n // it may be called too late in the shutdown lifecycle. Attach an exit\n // handler to ensure timely disposal as a safeguard.\n```",
"path": "YoutubeDownloader/... | true | ||
Tyrrrz/YoutubeDownloader | 792 | issue_to_patch | Bump the actions group with 2 updates | Bumps the actions group with 2 updates: [actions/upload-artifact](https://github.com/actions/upload-artifact) and [actions/download-artifact](https://github.com/actions/download-artifact).
Updates `actions/upload-artifact` from 6.0.0 to 7.0.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="http... | 32db50186537c4340922335154a329a41f970bc0 | 583f88e4fc637fba982879c73bc105b3565f5c70 | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 3360634b8..0ce104581 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -100,7 +100,7 @@ jobs:
--self-contained
- name: Upload app binaries
- uses: actions/upload-artifact@b7c566a772e6b6bfb58ed... | [
".github/workflows/main.yml"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 793 | issue_to_patch | Bump the nuget group with 1 update | Updated [Markdig](https://github.com/xoofx/markdig) from 1.0.0 to 1.1.0.
<details>
<summary>Release notes</summary>
_Sourced from [Markdig's releases](https://github.com/xoofx/markdig/releases)._
## 1.1.0
# Changes
## 🚀 Enhancements
- Add CJK-friendly Emphasis Extension (PR #921) by @tats-u
## 🧰 Misc
- docs... | 32db50186537c4340922335154a329a41f970bc0 | c596253425116e8ee2d5f517543075c0317df058 | diff --git a/Directory.Packages.props b/Directory.Packages.props
index 7c037c730..0e58c424e 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -17,7 +17,7 @@
<PackageVersion Include="DialogHost.Avalonia" Version="0.10.4" />
<PackageVersion Include="Gress" Version="2.1.1" />
<PackageV... | [
"Directory.Packages.props"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 790 | issue_to_patch | Encrypt auth cookies at rest in settings file (machine-bound) | - [x] Add `ThisAssembly.Project` NuGet package to `Directory.Packages.props` and `YoutubeDownloader.csproj`
- [x] Add `EncryptionSalt` MSBuild property to `YoutubeDownloader.csproj`, expose via `ThisAssembly.Project`
- [x] Create `EnvironmentExtensions.cs` for machine ID detection
- [x] Create `AuthCookiesEncryptionCon... | e8b84f87f89ac7129ba45f358f3493913214fd41 | 45b611eb3aa90709edc4d4d4e018e233c03da3c0 | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index d36b23aaa..3360634b8 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -91,6 +91,7 @@ jobs:
dotnet publish YoutubeDownloader
-p:Version=${{ github.ref_type == 'tag' && github.ref_name || format('99... | [
".github/workflows/main.yml",
"Directory.Packages.props",
"YoutubeDownloader/Localization/LocalizationManager.English.cs",
"YoutubeDownloader/Localization/LocalizationManager.French.cs",
"YoutubeDownloader/Localization/LocalizationManager.German.cs",
"YoutubeDownloader/Localization/LocalizationManager.Spa... | [
{
"comment": "No need for backwards compat here",
"path": "YoutubeDownloader/Services/AuthCookiesEncryptionConverter.cs",
"hunk": "@@ -0,0 +1,162 @@\n+using System;\n+using System.Collections.Generic;\n+using System.Linq;\n+using System.Net;\n+using System.Security.Cryptography;\n+using System.Text;\n+u... | true | ||
Tyrrrz/YoutubeDownloader | 790 | comment_to_fix | Encrypt auth cookies at rest in settings file (machine-bound) | We don't need prefix in this case @copilot | e8b84f87f89ac7129ba45f358f3493913214fd41 | 45b611eb3aa90709edc4d4d4e018e233c03da3c0 | diff --git a/YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs b/YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs
new file mode 100644
index 000000000..b4c1555d1
--- /dev/null
+++ b/YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs
@@ -0,... | [
"YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs"
] | [
{
"comment": "We don't need prefix in this case @copilot ",
"path": "YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs",
"hunk": "@@ -0,0 +1,113 @@\n+using System;\n+using System.Collections.Generic;\n+using System.Linq;\n+using System.Net;\n+using System.Security.Cryptography... | true | ||
Tyrrrz/YoutubeDownloader | 790 | comment_to_fix | Encrypt auth cookies at rest in settings file (machine-bound) | ```suggestion
if (string.IsNullOrWhiteSpace(value))
``` | e8b84f87f89ac7129ba45f358f3493913214fd41 | 45b611eb3aa90709edc4d4d4e018e233c03da3c0 | diff --git a/YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs b/YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs
new file mode 100644
index 000000000..b4c1555d1
--- /dev/null
+++ b/YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs
@@ -0,... | [
"YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs"
] | [
{
"comment": "```suggestion\n if (string.IsNullOrWhiteSpace(value))\n```",
"path": "YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs",
"hunk": "@@ -0,0 +1,111 @@\n+using System;\n+using System.Collections.Generic;\n+using System.Linq;\n+using System.Net;\n+using Sy... | true | ||
Tyrrrz/YoutubeDownloader | 790 | comment_to_fix | Encrypt auth cookies at rest in settings file (machine-bound) | ```suggestion
var value = reader.GetString();
``` | e8b84f87f89ac7129ba45f358f3493913214fd41 | 45b611eb3aa90709edc4d4d4e018e233c03da3c0 | diff --git a/YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs b/YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs
new file mode 100644
index 000000000..b4c1555d1
--- /dev/null
+++ b/YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs
@@ -0,... | [
"YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs"
] | [
{
"comment": "```suggestion\n var value = reader.GetString();\n```",
"path": "YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs",
"hunk": "@@ -0,0 +1,110 @@\n+using System;\n+using System.Collections.Generic;\n+using System.Linq;\n+using System.Net;\n+using System.S... | true | ||
Tyrrrz/YoutubeDownloader | 790 | comment_to_fix | Encrypt auth cookies at rest in settings file (machine-bound) | ```suggestion
if (reader.TokenType != JsonTokenType.String)
return null;
var value = reader.GetString();
``` | e8b84f87f89ac7129ba45f358f3493913214fd41 | 45b611eb3aa90709edc4d4d4e018e233c03da3c0 | diff --git a/YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs b/YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs
new file mode 100644
index 000000000..b4c1555d1
--- /dev/null
+++ b/YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs
@@ -0,... | [
"YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs"
] | [
{
"comment": "```suggestion\n if (reader.TokenType != JsonTokenType.String)\n return null;\n\n var value = reader.GetString();\n```",
"path": "YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs",
"hunk": "@@ -0,0 +1,104 @@\n+using System;\n+... | true | ||
Tyrrrz/YoutubeDownloader | 790 | comment_to_fix | Encrypt auth cookies at rest in settings file (machine-bound) | Inline this @copilot | e8b84f87f89ac7129ba45f358f3493913214fd41 | 45b611eb3aa90709edc4d4d4e018e233c03da3c0 | diff --git a/YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs b/YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs
new file mode 100644
index 000000000..b4c1555d1
--- /dev/null
+++ b/YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs
@@ -0,... | [
"YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs"
] | [
{
"comment": "Inline this @copilot ",
"path": "YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs",
"hunk": "@@ -0,0 +1,107 @@\n+using System;\n+using System.Collections.Generic;\n+using System.Linq;\n+using System.Net;\n+using System.Security.Cryptography;\n+using System.Text;... | true | ||
Tyrrrz/YoutubeDownloader | 790 | comment_to_fix | Encrypt auth cookies at rest in settings file (machine-bound) | ```suggestion
var encryptedData = new byte[28 + cookieData.Length];
``` | e8b84f87f89ac7129ba45f358f3493913214fd41 | 45b611eb3aa90709edc4d4d4e018e233c03da3c0 | diff --git a/YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs b/YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs
new file mode 100644
index 000000000..b4c1555d1
--- /dev/null
+++ b/YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs
@@ -0,... | [
"YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs"
] | [
{
"comment": "```suggestion\n\n var encryptedData = new byte[28 + cookieData.Length];\n```",
"path": "YoutubeDownloader/Services/SettingsService.AuthCookiesEncryptionConverter.cs",
"hunk": "@@ -0,0 +1,108 @@\n+using System;\n+using System.Collections.Generic;\n+using System.Linq;\n+using Syst... | true | ||
Tyrrrz/YoutubeDownloader | 790 | comment_to_fix | Encrypt auth cookies at rest in settings file (machine-bound) | `Environment.MachineName` as a fallback makes the “machine-bound” key lower-entropy and also unstable (renaming the machine would make existing encrypted cookies undecryptable). Consider returning null when a stable machine-id source isn’t available and letting the settings layer skip persisting cookies in that case.
`... | e8b84f87f89ac7129ba45f358f3493913214fd41 | 45b611eb3aa90709edc4d4d4e018e233c03da3c0 | diff --git a/YoutubeDownloader/Utils/Extensions/EnvironmentExtensions.cs b/YoutubeDownloader/Utils/Extensions/EnvironmentExtensions.cs
new file mode 100644
index 000000000..bcd1ceabf
--- /dev/null
+++ b/YoutubeDownloader/Utils/Extensions/EnvironmentExtensions.cs
@@ -0,0 +1,54 @@
+using System;
+using System.IO;
+
+name... | [
"YoutubeDownloader/Utils/Extensions/EnvironmentExtensions.cs"
] | [
{
"comment": "`Environment.MachineName` as a fallback makes the “machine-bound” key lower-entropy and also unstable (renaming the machine would make existing encrypted cookies undecryptable). Consider returning null when a stable machine-id source isn’t available and letting the settings layer skip persisting c... | true | ||
Tyrrrz/YoutubeDownloader | 791 | issue_to_patch | Fix three inconsistencies: filename typo, overload formatting, and string extension rename | Three small inconsistencies identified by comparing against sibling repos, each a straightforward cleanup.
## Changes
- **`DialogVIewModelBase.cs` → `DialogViewModelBase.cs`** — corrects capital `I` typo in filename
- **`CreateMessageBoxViewModel` two-arg overload** — fixed formatting (missing blank line between met... | e8b84f87f89ac7129ba45f358f3493913214fd41 | c0fe813ff4fa3baba9c878727b32ef5524afb96a | diff --git a/YoutubeDownloader.Core/Utils/Extensions/StringExtensions.cs b/YoutubeDownloader.Core/Utils/Extensions/StringExtensions.cs
index 53a7a4f17..9697cbcd0 100644
--- a/YoutubeDownloader.Core/Utils/Extensions/StringExtensions.cs
+++ b/YoutubeDownloader.Core/Utils/Extensions/StringExtensions.cs
@@ -4,6 +4,6 @@ pub... | [
"YoutubeDownloader.Core/Utils/Extensions/StringExtensions.cs",
"YoutubeDownloader.Core/Utils/Url.cs",
"YoutubeDownloader/Framework/DialogViewModelBase.cs"
] | [
{
"comment": "The 2-arg overload now delegates by passing null button texts, but the 4-arg overload assigns those values directly. This clears the default button labels set in MessageBoxViewModel’s constructor, likely resulting in a dialog with no visible buttons for existing 2-arg call sites. Preserve the prev... | true | ||
Tyrrrz/YoutubeDownloader | 789 | issue_to_patch | Render `AutoUpdateTooltip` warning in bold via `MarkdownToInlinesConverter` | `AutoUpdateTooltip` had an unformatted warning sentence and was bound as plain text, so markdown was never rendered. This adds bold markers to the warning keyword in all locale files and switches the binding to use `MarkdownToInlinesConverter`, consistent with `FileNameTemplateTooltip`.
## Changes
- **Localization fi... | 404878961a8b087162f8867903fdf22a5b7cdc78 | afb5e945d4a1ec9b83fb53b778e6c1dbf695f470 | diff --git a/YoutubeDownloader/Localization/LocalizationManager.English.cs b/YoutubeDownloader/Localization/LocalizationManager.English.cs
index 3a93bd0be..bcaed74ae 100644
--- a/YoutubeDownloader/Localization/LocalizationManager.English.cs
+++ b/YoutubeDownloader/Localization/LocalizationManager.English.cs
@@ -42,7 +4... | [
"YoutubeDownloader/Localization/LocalizationManager.English.cs",
"YoutubeDownloader/Localization/LocalizationManager.French.cs",
"YoutubeDownloader/Localization/LocalizationManager.German.cs",
"YoutubeDownloader/Localization/LocalizationManager.Spanish.cs",
"YoutubeDownloader/Localization/LocalizationManage... | [] | true | ||
Tyrrrz/YoutubeDownloader | 788 | issue_to_patch | Migrate to Centralized NuGet Package Management (CPM) | - [x] Explore repository structure and `.csproj` files
- [x] Create `Directory.Packages.props` with all package versions sorted alphabetically
- [x] Update `YoutubeDownloader/YoutubeDownloader.csproj` to remove `Version` attributes from `<PackageReference>` elements
- [x] Update `YoutubeDownloader.Core/YoutubeDownloade... | dfb394f00e33b7b14fea96a49c9f49971fd68e63 | 9af442f2cecc6ead27ba47126cebc7167f76fe38 | diff --git a/Directory.Packages.props b/Directory.Packages.props
new file mode 100644
index 000000000..99e8f35c5
--- /dev/null
+++ b/Directory.Packages.props
@@ -0,0 +1,31 @@
+<Project>
+ <PropertyGroup>
+ <ManagePackageVersionsCentrally>true</ManagePackageVersionsCentrally>
+ </PropertyGroup>
+
+ <ItemGroup>
+ ... | [
"Directory.Packages.props",
"YoutubeDownloader.Core/YoutubeDownloader.Core.csproj",
"YoutubeDownloader.sln",
"YoutubeDownloader/YoutubeDownloader.csproj"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 787 | issue_to_patch | Rename `InlineMarkup` converter to `MarkdownToInlinesConverter` | Renames the Avalonia `IValueConverter` class `InlineMarkup` to `MarkdownToInlinesConverter` and updates all references across the codebase.
## Changes
- **`Converters/InlineMarkup.cs` → `Converters/MarkdownToInlinesConverter.cs`** — file and class renamed; `Instance` static field type updated accordingly
- **`Views/Di... | ec3aefbb247d61a8c93f6df543f254f4a8f8afc1 | f3258c589fc229cb4f26e25845e35b38e91e0bde | diff --git a/YoutubeDownloader/Converters/InlineMarkup.cs b/YoutubeDownloader/Converters/MarkdownToInlinesConverter.cs
similarity index 96%
rename from YoutubeDownloader/Converters/InlineMarkup.cs
rename to YoutubeDownloader/Converters/MarkdownToInlinesConverter.cs
index 60422a6da..f91382249 100644
--- a/YoutubeDownloa... | [
"YoutubeDownloader/Converters/MarkdownToInlinesConverter.cs",
"YoutubeDownloader/Views/Components/DashboardView.axaml",
"YoutubeDownloader/Views/Dialogs/SettingsView.axaml"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 785 | issue_to_patch | Replace file name template tooltip runs with markdown-formatted text | - [x] Update `InlineMarkup.cs` to add `LineBreak`s between markdown paragraphs (separated by blank lines)
- [x] Update `LocalizationManager.English.cs` to replace separate `FileNameTemplateTooltip`, `FileNameTemplateAvailableTokensLabel`, and `FileNameTemplateToken*Desc` keys with a single combined markdown `FileNameTe... | efc526b94a9aece745f0421cabcd0400e9d76aee | 019ca983a5a49d9961671fc4b5914b36eeab771d | diff --git a/YoutubeDownloader/Converters/InlineMarkup.cs b/YoutubeDownloader/Converters/InlineMarkup.cs
index bde312475..60422a6da 100644
--- a/YoutubeDownloader/Converters/InlineMarkup.cs
+++ b/YoutubeDownloader/Converters/InlineMarkup.cs
@@ -93,11 +93,21 @@ private static void ProcessInline(
if (value is no... | [
"YoutubeDownloader/Converters/InlineMarkup.cs",
"YoutubeDownloader/Localization/LocalizationManager.English.cs",
"YoutubeDownloader/Localization/LocalizationManager.French.cs",
"YoutubeDownloader/Localization/LocalizationManager.German.cs",
"YoutubeDownloader/Localization/LocalizationManager.Spanish.cs",
... | [
{
"comment": "Can you explain this one to me? @copilot ",
"path": "YoutubeDownloader/Converters/InlineMarkup.cs",
"hunk": "@@ -93,11 +93,20 @@ private static void ProcessInline(\n if (value is not string { Length: > 0 } text)\n return inlines;\n \n+ var isFirstParagraph = true... | true | ||
Tyrrrz/YoutubeDownloader | 785 | comment_to_fix | Replace file name template tooltip runs with markdown-formatted text | Can you explain this one to me? @copilot | efc526b94a9aece745f0421cabcd0400e9d76aee | 019ca983a5a49d9961671fc4b5914b36eeab771d | diff --git a/YoutubeDownloader/Converters/InlineMarkup.cs b/YoutubeDownloader/Converters/InlineMarkup.cs
index bde312475..60422a6da 100644
--- a/YoutubeDownloader/Converters/InlineMarkup.cs
+++ b/YoutubeDownloader/Converters/InlineMarkup.cs
@@ -93,11 +93,21 @@ private static void ProcessInline(
if (value is no... | [
"YoutubeDownloader/Converters/InlineMarkup.cs"
] | [
{
"comment": "Can you explain this one to me? @copilot ",
"path": "YoutubeDownloader/Converters/InlineMarkup.cs",
"hunk": "@@ -93,11 +93,20 @@ private static void ProcessInline(\n if (value is not string { Length: > 0 } text)\n return inlines;\n \n+ var isFirstParagraph = true... | true | ||
Tyrrrz/YoutubeDownloader | 786 | issue_to_patch | Add tooltip to Language dropdown in Settings | The Language dropdown in Settings was the only control lacking a tooltip, inconsistent with all other settings entries.
### Changes
- **`SettingsView.axaml`** — Added `ToolTip.Tip` binding to the Language `DockPanel`, mirroring the pattern used by Theme and other settings
- **`LocalizationManager.cs`** — Added `Langu... | efc526b94a9aece745f0421cabcd0400e9d76aee | 446065bc64cbe977826a75ebf722587bd2961c94 | diff --git a/YoutubeDownloader/Localization/LocalizationManager.English.cs b/YoutubeDownloader/Localization/LocalizationManager.English.cs
index 3bbdafcc2..563326aa6 100644
--- a/YoutubeDownloader/Localization/LocalizationManager.English.cs
+++ b/YoutubeDownloader/Localization/LocalizationManager.English.cs
@@ -38,6 +3... | [
"YoutubeDownloader/Localization/LocalizationManager.English.cs",
"YoutubeDownloader/Localization/LocalizationManager.French.cs",
"YoutubeDownloader/Localization/LocalizationManager.German.cs",
"YoutubeDownloader/Localization/LocalizationManager.Spanish.cs",
"YoutubeDownloader/Localization/LocalizationManage... | [] | true | ||
Tyrrrz/YoutubeDownloader | 783 | issue_to_patch | Add localization support (EN, UK, DE, FR, ES) with system language auto-detection | - [x] `App.axaml.cs`: `InitializeLanguage()` method removed; `WatchProperty` callback inlined as a single lambda `() => Localization.Current.Language = _settingsService.Language`
- [x] `Converters/InlineMarkup.cs:63`: `fontWeight.HasValue` → `fontWeight is not null`
- [x] `Converters/InlineMarkup.cs:77-88`: emphasis tu... | 5d3a87a538ca9708ad87436e9dbeeab9c40366c2 | 0a6522720a542502aa91a86312bc816151ff6f32 | diff --git a/YoutubeDownloader/App.axaml.cs b/YoutubeDownloader/App.axaml.cs
index 0f0d74a08..225a81756 100644
--- a/YoutubeDownloader/App.axaml.cs
+++ b/YoutubeDownloader/App.axaml.cs
@@ -71,6 +71,14 @@ public App()
}
)
);
+
+ // Apply the selected language when the user c... | [
"YoutubeDownloader/App.axaml.cs",
"YoutubeDownloader/Converters/InlineMarkup.cs",
"YoutubeDownloader/Framework/ViewModelBase.cs",
"YoutubeDownloader/Framework/ViewModelManager.cs",
"YoutubeDownloader/Language.cs",
"YoutubeDownloader/Localization.cs",
"YoutubeDownloader/Localization.deu.cs",
"YoutubeDo... | [
{
"comment": "Let's rename to Localization / Localization.Current",
"path": "YoutubeDownloader/Framework/ViewModelBase.cs",
"hunk": "@@ -1,10 +1,13 @@\n using System;\n using CommunityToolkit.Mvvm.ComponentModel;\n+using YoutubeDownloader.Localization;\n \n namespace YoutubeDownloader.Framework;\n \n p... | true | ||
Tyrrrz/YoutubeDownloader | 783 | comment_to_fix | Add localization support (EN, UK, DE, FR, ES) with system language auto-detection | The language initialization is performed before loading the settings, which means the language selection will always default to system language on startup, ignoring any previously saved language preference. The order should be reversed: first load settings at line 145, then initialize language at line 142. This ensures... | 5d3a87a538ca9708ad87436e9dbeeab9c40366c2 | 0a6522720a542502aa91a86312bc816151ff6f32 | diff --git a/YoutubeDownloader/App.axaml.cs b/YoutubeDownloader/App.axaml.cs
index 0f0d74a08..225a81756 100644
--- a/YoutubeDownloader/App.axaml.cs
+++ b/YoutubeDownloader/App.axaml.cs
@@ -71,6 +71,14 @@ public App()
}
)
);
+
+ // Apply the selected language when the user c... | [
"YoutubeDownloader/App.axaml.cs"
] | [
{
"comment": "The language initialization is performed before loading the settings, which means the language selection will always default to system language on startup, ignoring any previously saved language preference. The order should be reversed: first load settings at line 145, then initialize language at ... | true | ||
Tyrrrz/YoutubeDownloader | 783 | comment_to_fix | Add localization support (EN, UK, DE, FR, ES) with system language auto-detection | `ViewModelBase.Localization` recursively references itself because the property name `Localization` shadows the `YoutubeDownloader.Localization` type, so `Localization.Current` resolves to `this.Localization.Current` and will stack overflow at runtime. Fully qualify the type name in the getter (e.g., `YoutubeDownloader... | 5d3a87a538ca9708ad87436e9dbeeab9c40366c2 | 0a6522720a542502aa91a86312bc816151ff6f32 | diff --git a/YoutubeDownloader/Framework/ViewModelBase.cs b/YoutubeDownloader/Framework/ViewModelBase.cs
index 730b281a7..d7426f4b2 100644
--- a/YoutubeDownloader/Framework/ViewModelBase.cs
+++ b/YoutubeDownloader/Framework/ViewModelBase.cs
@@ -5,6 +5,8 @@ namespace YoutubeDownloader.Framework;
public abstract class... | [
"YoutubeDownloader/Framework/ViewModelBase.cs"
] | [
{
"comment": "`ViewModelBase.Localization` recursively references itself because the property name `Localization` shadows the `YoutubeDownloader.Localization` type, so `Localization.Current` resolves to `this.Localization.Current` and will stack overflow at runtime. Fully qualify the type name in the getter (e.... | true | ||
Tyrrrz/YoutubeDownloader | 783 | comment_to_fix | Add localization support (EN, UK, DE, FR, ES) with system language auto-detection | Use three letter codes in the file names | 5d3a87a538ca9708ad87436e9dbeeab9c40366c2 | 0a6522720a542502aa91a86312bc816151ff6f32 | diff --git a/YoutubeDownloader/Localization.deu.cs b/YoutubeDownloader/Localization.deu.cs
new file mode 100644
index 000000000..230f15426
--- /dev/null
+++ b/YoutubeDownloader/Localization.deu.cs
@@ -0,0 +1,138 @@
+using System.Collections.Generic;
+
+namespace YoutubeDownloader;
+
+public partial class Localization
+... | [
"YoutubeDownloader/Localization.deu.cs"
] | [
{
"comment": "Use three letter codes in the file names",
"path": "YoutubeDownloader/Localization.deu.cs",
"hunk": "@@ -0,0 +1,143 @@\n+using System.Collections.Generic;\n+",
"resolving_sha": "0a6522720a542502aa91a86312bc816151ff6f32",
"resolving_diff": "diff --git a/YoutubeDownloader/Localizatio... | true | ||
Tyrrrz/YoutubeDownloader | 783 | comment_to_fix | Add localization support (EN, UK, DE, FR, ES) with system language auto-detection | Does markdig not provide specific inlines for bold/italic etc? | 5d3a87a538ca9708ad87436e9dbeeab9c40366c2 | 0a6522720a542502aa91a86312bc816151ff6f32 | diff --git a/YoutubeDownloader/Converters/InlineMarkup.cs b/YoutubeDownloader/Converters/InlineMarkup.cs
new file mode 100644
index 000000000..d0ab92364
--- /dev/null
+++ b/YoutubeDownloader/Converters/InlineMarkup.cs
@@ -0,0 +1,100 @@
+using System;
+using System.Globalization;
+using Avalonia.Controls.Documents;
+usi... | [
"YoutubeDownloader/Converters/InlineMarkup.cs"
] | [
{
"comment": "Does markdig not provide specific inlines for bold/italic etc?",
"path": "YoutubeDownloader/Converters/InlineMarkup.cs",
"hunk": "@@ -0,0 +1,100 @@\n+using Avalonia;\n+using Avalonia.Controls;\n+using Avalonia.Controls.Documents;\n+using Avalonia.Media;\n+using Markdig;\n+using Markdig.Syn... | true | ||
Tyrrrz/YoutubeDownloader | 783 | comment_to_fix | Add localization support (EN, UK, DE, FR, ES) with system language auto-detection | The language initialization happens before settings are loaded, which means InitializeLanguage will use the default Language.System value instead of the user's saved preference. Move the InitializeLanguage call to after the _settingsService.Load() call so that the correct language preference is applied on startup. The ... | 5d3a87a538ca9708ad87436e9dbeeab9c40366c2 | 0a6522720a542502aa91a86312bc816151ff6f32 | diff --git a/YoutubeDownloader/App.axaml.cs b/YoutubeDownloader/App.axaml.cs
index 0f0d74a08..225a81756 100644
--- a/YoutubeDownloader/App.axaml.cs
+++ b/YoutubeDownloader/App.axaml.cs
@@ -71,6 +71,14 @@ public App()
}
)
);
+
+ // Apply the selected language when the user c... | [
"YoutubeDownloader/App.axaml.cs"
] | [
{
"comment": "The language initialization happens before settings are loaded, which means InitializeLanguage will use the default Language.System value instead of the user's saved preference. Move the InitializeLanguage call to after the _settingsService.Load() call so that the correct language preference is ap... | true | ||
Tyrrrz/YoutubeDownloader | 783 | comment_to_fix | Add localization support (EN, UK, DE, FR, ES) with system language auto-detection | Inconsistent null checking patterns for nullable value types. Line 63 uses `fontWeight is not null` while line 65 uses `fontStyle.HasValue`. Both fontWeight and fontStyle are nullable value types (FontWeight? and FontStyle?), so they should use the same pattern for consistency. Consider using the same pattern for both ... | 5d3a87a538ca9708ad87436e9dbeeab9c40366c2 | 0a6522720a542502aa91a86312bc816151ff6f32 | diff --git a/YoutubeDownloader/Converters/InlineMarkup.cs b/YoutubeDownloader/Converters/InlineMarkup.cs
new file mode 100644
index 000000000..d0ab92364
--- /dev/null
+++ b/YoutubeDownloader/Converters/InlineMarkup.cs
@@ -0,0 +1,100 @@
+using System;
+using System.Globalization;
+using Avalonia.Controls.Documents;
+usi... | [
"YoutubeDownloader/Converters/InlineMarkup.cs"
] | [
{
"comment": "Inconsistent null checking patterns for nullable value types. Line 63 uses `fontWeight is not null` while line 65 uses `fontStyle.HasValue`. Both fontWeight and fontStyle are nullable value types (FontWeight? and FontStyle?), so they should use the same pattern for consistency. Consider using the ... | true | ||
Tyrrrz/YoutubeDownloader | 783 | comment_to_fix | Add localization support (EN, UK, DE, FR, ES) with system language auto-detection | ```suggestion
if (fontStyle is not null)
```
| 5d3a87a538ca9708ad87436e9dbeeab9c40366c2 | 0a6522720a542502aa91a86312bc816151ff6f32 | diff --git a/YoutubeDownloader/Converters/InlineMarkup.cs b/YoutubeDownloader/Converters/InlineMarkup.cs
new file mode 100644
index 000000000..d0ab92364
--- /dev/null
+++ b/YoutubeDownloader/Converters/InlineMarkup.cs
@@ -0,0 +1,100 @@
+using System;
+using System.Globalization;
+using Avalonia.Controls.Documents;
+usi... | [
"YoutubeDownloader/Converters/InlineMarkup.cs"
] | [
{
"comment": "```suggestion\n if (fontStyle is not null)\n```\n",
"path": "YoutubeDownloader/Converters/InlineMarkup.cs",
"hunk": "@@ -0,0 +1,100 @@\n+using System;\n+using System.Globalization;\n+using Avalonia.Controls.Documents;\n+using Avalonia.Data.Converters;\n+using Avalonia.Media;... | true | ||
Tyrrrz/YoutubeDownloader | 783 | comment_to_fix | Add localization support (EN, UK, DE, FR, ES) with system language auto-detection | ```suggestion
if (emphasis.DelimiterChar is '*' or '_' && emphasis.DelimiterCount == 2)
```
*** Etc have different meanings | 5d3a87a538ca9708ad87436e9dbeeab9c40366c2 | 0a6522720a542502aa91a86312bc816151ff6f32 | diff --git a/YoutubeDownloader/Converters/InlineMarkup.cs b/YoutubeDownloader/Converters/InlineMarkup.cs
new file mode 100644
index 000000000..d0ab92364
--- /dev/null
+++ b/YoutubeDownloader/Converters/InlineMarkup.cs
@@ -0,0 +1,100 @@
+using System;
+using System.Globalization;
+using Avalonia.Controls.Documents;
+usi... | [
"YoutubeDownloader/Converters/InlineMarkup.cs"
] | [
{
"comment": "```suggestion\n if (emphasis.DelimiterChar is '*' or '_' && emphasis.DelimiterCount == 2)\n```\n\n*** Etc have different meanings ",
"path": "YoutubeDownloader/Converters/InlineMarkup.cs",
"hunk": "@@ -0,0 +1,100 @@\n+using System;\n+using System.Globalization;\n+using Avalo... | true | ||
Tyrrrz/YoutubeDownloader | 783 | comment_to_fix | Add localization support (EN, UK, DE, FR, ES) with system language auto-detection | ```suggestion
private partial void OnLanguageChanged(Language value) =>
```
| 5d3a87a538ca9708ad87436e9dbeeab9c40366c2 | 0a6522720a542502aa91a86312bc816151ff6f32 | diff --git a/YoutubeDownloader/Localization.cs b/YoutubeDownloader/Localization.cs
new file mode 100644
index 000000000..26d382643
--- /dev/null
+++ b/YoutubeDownloader/Localization.cs
@@ -0,0 +1,152 @@
+using System.Globalization;
+using System.Runtime.CompilerServices;
+using CommunityToolkit.Mvvm.ComponentModel;
+
+... | [
"YoutubeDownloader/Localization.cs"
] | [
{
"comment": "```suggestion\n private partial void OnLanguageChanged(Language value) =>\n```\n",
"path": "YoutubeDownloader/Localization.cs",
"hunk": "@@ -0,0 +1,152 @@\n+using System.Globalization;\n+using System.Runtime.CompilerServices;\n+using CommunityToolkit.Mvvm.ComponentModel;\n+\n+namespace ... | true | ||
Tyrrrz/YoutubeDownloader | 784 | issue_to_patch | Fix second dialog not shown when dialogs are shown sequentially | `DialogHost.RemoveHost()` calls `TrySetResult()` before setting `IsOpen = false`. When continuations run inline, the semaphore is released while `IsOpen` is still `true`, causing the next `ShowDialogAsync` call to throw `InvalidOperationException("DialogHost is already open")`.
## Change
- **`DialogManager.ShowDialog... | 5d3a87a538ca9708ad87436e9dbeeab9c40366c2 | a2c4443800bb74cd5dde9d56ac94f53f8101178a | diff --git a/YoutubeDownloader/Framework/DialogManager.cs b/YoutubeDownloader/Framework/DialogManager.cs
index a3005845f..bb3c0fd33 100644
--- a/YoutubeDownloader/Framework/DialogManager.cs
+++ b/YoutubeDownloader/Framework/DialogManager.cs
@@ -39,6 +39,10 @@ await DialogHost.Show(
}
);
... | [
"YoutubeDownloader/Framework/DialogManager.cs"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 782 | issue_to_patch | Add FFmpeg diagnostic info to "FFmpeg is missing" message | On macOS (and other platforms), GUI apps often inherit a minimal PATH, causing FFmpeg detection to fail even when FFmpeg is installed. The error message provided no actionable information to diagnose why detection failed.
## Changes
### `FFmpeg.cs` (Core)
- Made `CliFileName` **public** so it can be referenced at the... | 30eb28d24d69f25fe24bb10ef73f4460a44678a9 | 9629265c8f43652bda9a3a1246e03bae79325605 | diff --git a/YoutubeDownloader.Core/Downloading/FFmpeg.cs b/YoutubeDownloader.Core/Downloading/FFmpeg.cs
index 759666f31..8e8d628c0 100644
--- a/YoutubeDownloader.Core/Downloading/FFmpeg.cs
+++ b/YoutubeDownloader.Core/Downloading/FFmpeg.cs
@@ -7,60 +7,61 @@ namespace YoutubeDownloader.Core.Downloading;
public stati... | [
"YoutubeDownloader.Core/Downloading/FFmpeg.cs",
"YoutubeDownloader/ViewModels/MainViewModel.cs"
] | [
{
"comment": "Inline this in the call site ",
"path": "YoutubeDownloader.Core/Downloading/FFmpeg.cs",
"hunk": "@@ -10,60 +11,87 @@ public static class FFmpeg\n private static string CliFileName { get; } =\n OperatingSystem.IsWindows() ? \"ffmpeg.exe\" : \"ffmpeg\";\n \n- public static str... | true | ||
Tyrrrz/YoutubeDownloader | 782 | comment_to_fix | Add FFmpeg diagnostic info to "FFmpeg is missing" message | The original PR requirements and the linked issue #756 suggest showing whether ffmpeg exists in each probe directory. The issue mentions ffmpeg was installed via brew but not detected, which could indicate PATH visibility issues. Adding an existence indicator per directory (e.g., "- /usr/local/bin [found]" vs "- /usr/b... | 30eb28d24d69f25fe24bb10ef73f4460a44678a9 | 9629265c8f43652bda9a3a1246e03bae79325605 | diff --git a/YoutubeDownloader/ViewModels/MainViewModel.cs b/YoutubeDownloader/ViewModels/MainViewModel.cs
index 6db6b7a2b..1d6d0ae43 100644
--- a/YoutubeDownloader/ViewModels/MainViewModel.cs
+++ b/YoutubeDownloader/ViewModels/MainViewModel.cs
@@ -1,5 +1,6 @@
using System;
using System.Diagnostics;
+using System.Li... | [
"YoutubeDownloader/ViewModels/MainViewModel.cs"
] | [
{
"comment": "The original PR requirements and the linked issue #756 suggest showing whether ffmpeg exists in each probe directory. The issue mentions ffmpeg was installed via brew but not detected, which could indicate PATH visibility issues. Adding an existence indicator per directory (e.g., \"- /usr/local/bi... | true | ||
Tyrrrz/YoutubeDownloader | 770 | issue_to_patch | Bump the actions group with 2 updates | Bumps the actions group with 2 updates: [actions/checkout](https://github.com/actions/checkout) and [actions/setup-dotnet](https://github.com/actions/setup-dotnet).
Updates `actions/checkout` from 6.0.1 to 6.0.2
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout... | d23f54a03c9c6baa12d962269ce47b3c61bfa699 | 000549951eba761101a850f9bf1a4ef8f2709ba7 | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index b24593c4c..d36b23aaa 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -26,10 +26,10 @@ jobs:
steps:
- name: Checkout
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
+ ... | [
".github/workflows/main.yml"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 771 | issue_to_patch | Bump the nuget group with 2 updates | Updated [AsyncImageLoader.Avalonia](https://github.com/AvaloniaUtils/AsyncImageLoader.Avalonia) from 3.5.0 to 3.6.0.
<details>
<summary>Release notes</summary>
_Sourced from [AsyncImageLoader.Avalonia's releases](https://github.com/AvaloniaUtils/AsyncImageLoader.Avalonia/releases)._
## 3.6.0
## What's Changed
* Add... | d23f54a03c9c6baa12d962269ce47b3c61bfa699 | 7ac0c1716f9fe1ce883f06a231a9b2d14b3e5c49 | diff --git a/YoutubeDownloader/YoutubeDownloader.csproj b/YoutubeDownloader/YoutubeDownloader.csproj
index 0c649af12..8f12fbe53 100644
--- a/YoutubeDownloader/YoutubeDownloader.csproj
+++ b/YoutubeDownloader/YoutubeDownloader.csproj
@@ -26,7 +26,7 @@
<None Include="ffmpeg" CopyToOutputDirectory="PreserveNewest" Co... | [
"YoutubeDownloader/YoutubeDownloader.csproj"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 757 | issue_to_patch | Bump the actions group with 3 updates | Bumps the actions group with 3 updates: [actions/checkout](https://github.com/actions/checkout), [actions/upload-artifact](https://github.com/actions/upload-artifact) and [actions/download-artifact](https://github.com/actions/download-artifact).
Updates `actions/checkout` from 6.0.0 to 6.0.1
<details>
<summary>Release... | 453e88241d91134930955679befc87766379e9ef | 078195e403a0e5c5bff876b679c469964a4fe264 | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 748a52c14..b24593c4c 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -26,7 +26,7 @@ jobs:
steps:
- name: Checkout
- uses: actions/checkout@1af3b93b6815bc44a9784bd300feb67ff0d1eeb3 # v6.0.0
+ ... | [
".github/workflows/main.yml"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 758 | issue_to_patch | Bump the nuget group with 2 updates | Updated [AsyncImageLoader.Avalonia](https://github.com/AvaloniaUtils/AsyncImageLoader.Avalonia) from 3.4.3 to 3.5.0.
<details>
<summary>Release notes</summary>
_Sourced from [AsyncImageLoader.Avalonia's releases](https://github.com/AvaloniaUtils/AsyncImageLoader.Avalonia/releases)._
## 3.5.0
## What's Changed
* Rem... | 453e88241d91134930955679befc87766379e9ef | 070b5ff83fa11181ba6a6a6635f4e8d6a4b7d89e | diff --git a/YoutubeDownloader/YoutubeDownloader.csproj b/YoutubeDownloader/YoutubeDownloader.csproj
index 23fc35605..0c649af12 100644
--- a/YoutubeDownloader/YoutubeDownloader.csproj
+++ b/YoutubeDownloader/YoutubeDownloader.csproj
@@ -26,7 +26,7 @@
<None Include="ffmpeg" CopyToOutputDirectory="PreserveNewest" Co... | [
"YoutubeDownloader/YoutubeDownloader.csproj"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 749 | issue_to_patch | Bump the nuget group with 1 update | Updated [DialogHost.Avalonia](https://github.com/AvaloniaUtils/DialogHost.Avalonia) from 0.9.3 to 0.10.2.
<details>
<summary>Release notes</summary>
_Sourced from [DialogHost.Avalonia's releases](https://github.com/AvaloniaUtils/DialogHost.Avalonia/releases)._
## 0.10.2
## What's Changed
* Throw exception in IsDial... | 59f9c3a3195813baddb5fb49378507c7ef446daf | 94d2a7f73330a76db5e9f8bf7853fd983537f931 | diff --git a/YoutubeDownloader/YoutubeDownloader.csproj b/YoutubeDownloader/YoutubeDownloader.csproj
index 1be18fb56..23fc35605 100644
--- a/YoutubeDownloader/YoutubeDownloader.csproj
+++ b/YoutubeDownloader/YoutubeDownloader.csproj
@@ -39,7 +39,7 @@
<PackageReference Include="CommunityToolkit.Mvvm" Version="8.4.0... | [
"YoutubeDownloader/YoutubeDownloader.csproj"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 750 | issue_to_patch | Bump the actions group with 2 updates | Bumps the actions group with 2 updates: [actions/checkout](https://github.com/actions/checkout) and [actions/setup-dotnet](https://github.com/actions/setup-dotnet).
Updates `actions/checkout` from 5.0.0 to 6.0.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout... | 59f9c3a3195813baddb5fb49378507c7ef446daf | 061a65993e0b2486cc70b96c5efe0de68a62e89e | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 5d29bc34c..748a52c14 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -26,10 +26,10 @@ jobs:
steps:
- name: Checkout
- uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
+ ... | [
".github/workflows/main.yml"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 745 | issue_to_patch | Bump the actions group with 2 updates | Bumps the actions group with 2 updates: [actions/upload-artifact](https://github.com/actions/upload-artifact) and [actions/download-artifact](https://github.com/actions/download-artifact).
Updates `actions/upload-artifact` from 4.6.2 to 5.0.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="http... | a7909b7649a04bf5a42c8c31cc89905bb737beb9 | 6b1beb3ce68dbe155d57573bdb507df8b6bce012 | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 281e737aa..96e4366d2 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -103,7 +103,7 @@ jobs:
--self-contained
- name: Upload app binaries
- uses: actions/upload-artifact@ea165f8d65b6e75b54044... | [
".github/workflows/main.yml"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 720 | issue_to_patch | Bump the nuget group with 1 update | Updated [AsyncImageLoader.Avalonia](https://github.com/AvaloniaUtils/AsyncImageLoader.Avalonia) from 3.3.0 to 3.4.3.
<details>
<summary>Release notes</summary>
_Sourced from [AsyncImageLoader.Avalonia's releases](https://github.com/AvaloniaUtils/AsyncImageLoader.Avalonia/releases)._
## 3.4.3
## What's Changed
* Add... | fa893a860616ff2702c4bbda68f3257569dad988 | 89ae0e2875de2084354ffefa1cc5ca9bd74e465f | diff --git a/YoutubeDownloader/YoutubeDownloader.csproj b/YoutubeDownloader/YoutubeDownloader.csproj
index aa2128153..fac532d51 100644
--- a/YoutubeDownloader/YoutubeDownloader.csproj
+++ b/YoutubeDownloader/YoutubeDownloader.csproj
@@ -25,7 +25,7 @@
<None Include="ffmpeg" CopyToOutputDirectory="PreserveNewest" Co... | [
"YoutubeDownloader/YoutubeDownloader.csproj"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 719 | issue_to_patch | Bump actions/setup-dotnet from 4.3.1 to 5.0.0 in the actions group | Bumps the actions group with 1 update: [actions/setup-dotnet](https://github.com/actions/setup-dotnet).
Updates `actions/setup-dotnet` from 4.3.1 to 5.0.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/setup-dotnet/releases">actions/setup-dotnet's releases</a>.</em><... | fa893a860616ff2702c4bbda68f3257569dad988 | 2f4d3ee47597e4dd7e3dccac13c8955f2d2b36ea | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 2b452133e..cae76013d 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -29,7 +29,7 @@ jobs:
uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
- name: Install .NET
- uses: ... | [
".github/workflows/main.yml"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 710 | issue_to_patch | Bump the actions group with 2 updates | Bumps the actions group with 2 updates: [actions/checkout](https://github.com/actions/checkout) and [actions/download-artifact](https://github.com/actions/download-artifact).
Updates `actions/checkout` from 4.2.2 to 5.0.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/action... | ef2ef82744b1319d7d30d9dbf67c4bac0da023a8 | f1fc22cdd1e524505a51d72d5b20968b38a005b1 | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 6d338d412..2b452133e 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -26,7 +26,7 @@ jobs:
steps:
- name: Checkout
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+ ... | [
".github/workflows/main.yml"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 690 | issue_to_patch | Bump the nuget group with 1 update | Performed the following updates:
- Updated DialogHost.Avalonia from 0.9.2 to 0.9.3 in /Directory.Build.props, /YoutubeDownloader/YoutubeDownloader.csproj
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=DialogHost.Avalonia&package-manager=nuget&previ... | 5486335855fc827cb3b3a095bf0d30fa612b58fe | e913bec332ae59a83333a1d6cc28c9bdc4de74a8 | diff --git a/YoutubeDownloader/YoutubeDownloader.csproj b/YoutubeDownloader/YoutubeDownloader.csproj
index b4cff33d4..aa2128153 100644
--- a/YoutubeDownloader/YoutubeDownloader.csproj
+++ b/YoutubeDownloader/YoutubeDownloader.csproj
@@ -38,7 +38,7 @@
<PackageReference Include="CommunityToolkit.Mvvm" Version="8.4.0... | [
"YoutubeDownloader/YoutubeDownloader.csproj"
] | [] | true | ||
Tyrrrz/YoutubeDownloader | 687 | issue_to_patch | Set application name to fix macOS app menu title | 6c20aa5cc9c43147bf6d7fea7546272d0237cbe1 | c41f90db9a8996e80c6c14d3696534b4aa351289 | diff --git a/YoutubeDownloader/App.axaml b/YoutubeDownloader/App.axaml
index 516ebadf9..c04e09e13 100644
--- a/YoutubeDownloader/App.axaml
+++ b/YoutubeDownloader/App.axaml
@@ -8,6 +8,7 @@
xmlns:materialControls="clr-namespace:Material.Styles.Controls;assembly=Material.Styles"
xmlns:materialIcons="clr-namespa... | [
"YoutubeDownloader/App.axaml"
] | [] | true | |||
Tyrrrz/YoutubeDownloader | 686 | issue_to_patch | Add bundled builds (+FFmpeg) for Linux arm64 | fda2585b3c14f4055e1e567209e8ad99e0f5825e | a0cdc3ebad13f4ff866dd56a0f71eab22027a04b | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 1bc0deaca..edad5dc7f 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -60,6 +60,8 @@ jobs:
- win-x86
- win-x64
- linux-arm64
+ # Linux x86 is not supported by .NET
+ #... | [
".github/workflows/main.yml",
"YoutubeDownloader/Download-FFmpeg.ps1"
] | [] | true | |||
Uahh/ToastFish | 112 | issue_to_patch | 修复导入execl 时用户点击取消操作，弹出错误提示问题 | #111 | 637c133706ba492d42e988a5ace4a3e4f96de55c | 9f11465cd9bf933ad55d924b1f3b5b38ec209d87 | diff --git a/View/ToastFish.xaml.cs b/View/ToastFish.xaml.cs
index 6f0d828..1fee98e 100644
--- a/View/ToastFish.xaml.cs
+++ b/View/ToastFish.xaml.cs
@@ -406,7 +406,10 @@ private void ImportWords_Click(object sender, EventArgs e)
{
OpenFileDialog Dialog = new OpenFileDialog();
Dialog.F... | [
"View/ToastFish.xaml.cs"
] | [] | true | ||
Uahh/ToastFish | 76 | issue_to_patch | 功能增强 | 增加了SM2+（Tag3.2.2：3键版，Tag3.3.3：4键版），快捷键，音标切换 | eca4ce9b96f124b9d93041d0d864a8c8b5c3fe0b | 48aa9af4fe99b25eafc5e2f443513ccb84a6ed91 | diff --git a/.gitignore b/.gitignore
index 165c342..c71e7df 100644
--- a/.gitignore
+++ b/.gitignore
@@ -66,3 +66,4 @@ obj/Debug/ToastFish.TrustInfo.xml
obj/Release/ToastFish.application
obj/Release/ToastFish.exe.manifest
obj/Release/ToastFish.TrustInfo.xml
+/token.txt
diff --git a/Model/Mp3/DownloadMp3.cs b/Model/M... | [
".gitignore",
"Model/Mp3/DownloadMp3.cs",
"Model/Mp3/PlayMp3.cs",
"Model/PushControl/PushCustomizeWords.cs",
"Model/PushControl/PushWords.cs",
"Model/SM2plus/Card.cs",
"Model/SM2plus/Parameters.cs",
"Model/SqliteControl/Select.cs",
"Model/StartWithWindows/HotKey.cs",
"README.md",
"ToastFish.cspr... | [] | true | ||
Uahh/ToastFish | 56 | issue_to_patch | Create LICENSE | 6dad54caf484b1ad0a07981cd096118ee771aea7 | f80664727df7e9be7667d9dd9819bd99512213b3 | diff --git a/LICENSE b/LICENSE
new file mode 100644
index 0000000..4dede83
--- /dev/null
+++ b/LICENSE
@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2021 Uahh
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+... | [
"LICENSE"
] | [] | true | |||
Uahh/ToastFish | 35 | issue_to_patch | 的地得警察出警 | 嘟嘟—— | ce6c76b2bbfd09ac7a1e2e104cf37dcc27ad52db | 9bf686a1757454733841268df16873e2295cec8c | diff --git a/README.md b/README.md
index b0476a6..4c4bbcb 100644
--- a/README.md
+++ b/README.md
@@ -1,6 +1,6 @@
# ToastFish
-这是一个利用Windows通知栏背单词的软件。可以让你在上班、上课等恶劣环境下安全隐蔽的背单词。
+这是一个利用Windows通知栏背单词的软件。可以让你在上班、上课等恶劣环境下安全隐蔽地背单词。
## 使用
@@ -18,7 +18,7 @@
软件运行系统： Windows 10
-请灵活使用 Win + A 键隐蔽的使用本软件！
+请灵活使用 Win + ... | [
"README.md"
] | [] | true | ||
Uahh/ToastFish | 21 | issue_to_patch | Auto Build ToastFish! | # 利用GitHub action编译ToastFish。
每次提交代码或合并PR时自动编译 ToastFish。
提交或合并PR后点击仓库actions找到最新Workflows，进入后最下方有个ToastFish_Build。
ToastFish_Build为编译后的压缩包，解压后双击ToastFish.exe可直接使用。 | 213ea0dcde0ed0cda669dcc8e96105fe0c49067b | 67666e19d315c541bb570123c2c3644da09b783c | diff --git a/.github/workflows/dotnet-desktop.yml b/.github/workflows/dotnet-desktop.yml
new file mode 100644
index 0000000..d76c7f4
--- /dev/null
+++ b/.github/workflows/dotnet-desktop.yml
@@ -0,0 +1,71 @@
+name: .NET Core Desktop
+on:
+ push:
+ branches: [ main ]
+ pull_request:
+ branches: [ main ]
+
+jobs:
... | [
".github/workflows/dotnet-desktop.yml"
] | [] | true | ||
ValdikSS/GoodbyeDPI | 830 | issue_to_patch | Fix grammar error in README and YAML syntax errors in workflow | This commit corrects a grammar error in the README documentation and fixes GitHub Actions workflow environment variable references that had extra spaces preventing proper variable resolution. | 754ff6ff06b1fa72f3ac09be80549417253df8fb | 9b154468153c0fc506e89f6daa38d7e4868b4fcc | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 4e4f6da4..f48821ad 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -36,17 +36,17 @@ jobs:
id: windivert-cache
uses: actions/cache@v4
with:
- path: ${{ env. WINDIVERT_NAME }}
- ... | [
".github/workflows/build.yml",
"README.md"
] | [] | true | ||
ValdikSS/GoodbyeDPI | 817 | issue_to_patch | Fixed missing newline | Added \n after `sc stop windivert14`. | ae7398035ac7723a9e3570cc58e93003c05e159d | 9c5e88abf78eb8f43145668195d38b8460be0336 | diff --git a/src/goodbyedpi.c b/src/goodbyedpi.c
index 2ec31a85..0c303dcb 100644
--- a/src/goodbyedpi.c
+++ b/src/goodbyedpi.c
@@ -327,7 +327,7 @@ static HANDLE init(char *filter, UINT64 flags) {
"Please unload it with the following commands ran as administrator:\n\n"
"sc stop windivert\... | [
"src/goodbyedpi.c"
] | [] | true | ||
ValdikSS/GoodbyeDPI | 665 | issue_to_patch | Add TLS ClientHello fake packet generator | Добавил опцию `--fake-with-sni имя_домена`, позволяющую генерировать и отправлять фейковый пакет ClientHello с заданным в параметре SNI.
Помогает пробивать некоторые сервера Гугла, если подставлять SNI от незаблокированного гуглового домена.
Избавляет от портянок `--fake-from-hex`, который некоторые велосипедисты уже... | abd2e77ca43e01702dec8260dbccb481f0e21771 | 8de0478b4a557c40505e19fcfda07ff02c104dff | diff --git a/README.md b/README.md
index 14fa59f9..b9f07d7b 100644
--- a/README.md
+++ b/README.md
@@ -67,6 +67,10 @@ Usage: goodbyedpi.exe [OPTION...]
--fake-from-hex <value> Load fake packets for Fake Request Mode from HEX values (like 1234abcDEF).
This option can be supplied multiple ti... | [
"README.md",
"src/fakepackets.c",
"src/fakepackets.h",
"src/goodbyedpi.c"
] | [] | true | ||
ValdikSS/GoodbyeDPI | 713 | issue_to_patch | Adds a clearer description | The main readme shows only the most recently committed features. But it will be more useful for the user to know the functionality of the version he has. | ee009cf107e0e6be885c509be8dde971362feaa9 | 9108866436bdeaed94cabc044eb75082519eff1e | diff --git a/README.md b/README.md
index 2cd333a5..2e3bd26c 100644
--- a/README.md
+++ b/README.md
@@ -19,6 +19,8 @@ If it works — congratulations! You can use it as-is or configure further.
Download [latest version from Releases page](https://github.com/ValdikSS/GoodbyeDPI/releases) and run.
+## Supported argumen... | [
"README.md"
] | [] | true | ||
ValdikSS/GoodbyeDPI | 706 | issue_to_patch | Update README.md, fix a typo (QUIC -> QUIK as trading software, not protocol) | https://ru.wikipedia.org/wiki/QUIK | 810aef6aedf2f14f25e5726736c0baa635c18eb0 | e26e8e49ee5dae7893868b6b85f84d3c079d4735 | diff --git a/README.md b/README.md
index 6d536250..2cd333a5 100644
--- a/README.md
+++ b/README.md
@@ -153,7 +153,7 @@ Modify them according to your own needs.
* Horribly outdated Windows 7 installations are not able to load WinDivert driver due to missing support for SHA256 digital signatures. Install KB3033929 [x8... | [
"README.md"
] | [] | true | ||
ValdikSS/GoodbyeDPI | 680 | issue_to_patch | Fixed typo | abd2e77ca43e01702dec8260dbccb481f0e21771 | d859c379fbd9e12dcf2c7da74f3edb220618d51d | diff --git a/.github/ISSUE_TEMPLATE/bug.yml b/.github/ISSUE_TEMPLATE/bug.yml
index 4ea3ba6c..2cd0609d 100644
--- a/.github/ISSUE_TEMPLATE/bug.yml
+++ b/.github/ISSUE_TEMPLATE/bug.yml
@@ -6,7 +6,7 @@ body:
attributes:
value: |
### Carefully read all the text IN FULL. Take this seriously.
- ##... | [
".github/ISSUE_TEMPLATE/bug.yml"
] | [] | true | |||
ValdikSS/GoodbyeDPI | 644 | issue_to_patch | add `.gitignore` | Refs: https://github.com/ValdikSS/GoodbyeDPI/issues/489, https://github.com/ValdikSS/GoodbyeDPI/pull/643 | 311b26e7440c2317592a64ee4dbfd955511dcb9f | 7f2af6e567788ba776a033fc0cb27ea75b410003 | diff --git a/.gitignore b/.gitignore
new file mode 100644
index 00000000..25a7384d
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,2 @@
+*.o
+*.exe
| [
".gitignore"
] | [] | true | ||
ValdikSS/GoodbyeDPI | 634 | issue_to_patch | docs: update README.md | incompabitle -> incompatible | 14fb025468db344116731bd07ba04d13d79c7e20 | 960a4fe3dacbafbd136e9d3567c09414e0c1e77c | diff --git a/README.md b/README.md
index 5dbc432a..ce16d1c4 100644
--- a/README.md
+++ b/README.md
@@ -148,7 +148,7 @@ Modify them according to your own needs.
# Known issues
* Horribly outdated Windows 7 installations are not able to load WinDivert driver due to missing support for SHA256 digital signatures. Insta... | [
"README.md"
] | [] | true | ||
ValdikSS/GoodbyeDPI | 551 | issue_to_patch | add youtubeUnblock link | updated readme with youtubeUnblock link for OpenWRT/Entware routers and Linux | fb552640b62b86f7d4b524de1b69752c2cc4199c | 7a12fc7028bb8f960168b0a70e5b5bfd36b77484 | diff --git a/README.md b/README.md
index aa2db74c..4345586d 100644
--- a/README.md
+++ b/README.md
@@ -156,6 +156,7 @@ Modify them according to your own needs.
- **[SpoofDPI](https://github.com/xvzc/SpoofDPI)** by @xvzc (for macOS and Linux)
- **[GhosTCP](https://github.com/macronut/ghostcp)** by @macronut (for Windo... | [
"README.md"
] | [] | true | ||
ValdikSS/GoodbyeDPI | 533 | issue_to_patch | Removed not recommended --image-base linker param | Tested only on windows 10 locally and in github actions image | dcff8389b302cef904166986250f2e4a0f23e5fd | ed210cdf44087ae880776281e940d08562f7bc0b | diff --git a/src/Makefile b/src/Makefile
index 986ae233..015490ea 100644
--- a/src/Makefile
+++ b/src/Makefile
@@ -27,7 +27,7 @@ CFLAGS = -std=c99 -pie -fPIE -pipe -I$(WINDIVERTHEADERS) -L$(WINDIVERTLIBS) \
-Wfloat-equal -Wcast-align -Wsign-conversion \
#-fstack-protector-strong
LDFLAGS = -fstack-p... | [
"src/Makefile"
] | [] | true | ||
ValdikSS/GoodbyeDPI | 512 | issue_to_patch | Added argument --debug-exit | Argument force exit before infinite loop starts.
Если нужно чтоб программа закрылась с возвратом кода успеха даже если аргументы обработались.
| c517169e944ca697873d4f044b4584724fa8fed2 | 868a0d59de7c5f9b397d53933380cb8386fd1f90 | diff --git a/src/goodbyedpi.c b/src/goodbyedpi.c
index 61da21ce..15317bfe 100644
--- a/src/goodbyedpi.c
+++ b/src/goodbyedpi.c
@@ -187,6 +187,7 @@ static struct option long_options[] = {
{"native-frag", no_argument, 0, '*' },
{"reverse-frag",no_argument, 0, '(' },
{"max-payload", optional_a... | [
"src/goodbyedpi.c"
] | [
{
"comment": "Пробел, пожалуйста.",
"path": "src/goodbyedpi.c",
"hunk": "@@ -577,6 +578,7 @@ int main(int argc, char *argv[]) {\n ipv4_tcp, ipv4_tcp_data, ipv4_udp_data,\n ipv6_tcp, ipv6_tcp_data, ipv6_udp_data\n } packet_type;\n+ bool debug_exit=false;",
"resolving_sha": "868... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.