repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
TheAngryByrd/MiniScaffold | 260 | issue_to_patch | add sayed's template validation package and hook it up | ## Proposed Changes
The same tool that gave me the info for my last set of revisions now has an MSBuild task for template validation. I've hooked it up here, but we shouldn't commit this yet: there's a bit of manual work a user has to do in order to get the validations to run, and I want to work with @sayedihashimi ... | 04d23f9f0183c466afb88df9c6f87f205ac38475 | 58422fa5cebb44ff4b88e0ae157680871971c34e | diff --git a/MiniScaffold.csproj b/MiniScaffold.csproj
index 6dc1fa1a..3c93c1c8 100644
--- a/MiniScaffold.csproj
+++ b/MiniScaffold.csproj
@@ -1,26 +1,54 @@
<Project Sdk="Microsoft.NET.Sdk">
- <PropertyGroup>
- <Description>F# Template for creating and publishing libraries targeting .NET 6.0 or console apps .NET 6... | [
"MiniScaffold.csproj"
] | [
{
"comment": "we have to do this right now because of authoring issues in the package. those should get fixed before merge.",
"path": "MiniScaffold.csproj",
"hunk": "@@ -1,26 +1,54 @@\n <Project Sdk=\"Microsoft.NET.Sdk\">\n- <PropertyGroup>\n- <Description>F# Template for creating and publishing lib... | true | ||
TheAngryByrd/MiniScaffold | 265 | issue_to_patch | Updated install instructions | ## Proposed Changes
Update the install command to reflect the new `dotnet` api.
## Types of changes
What types of changes does your code introduce to MiniScaffold?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds... | c77b76bfba47b74e10774a7c3be61c6aa395d4f5 | 4c7fe4282c840b0f30c34033655b5f189eef63a3 | diff --git a/README.md b/README.md
index 6d8f1b7a..bf8fb854 100644
--- a/README.md
+++ b/README.md
@@ -66,7 +66,7 @@ This takes away the ambiguity that developers face when creating an OSS project.
### Install the [dotnet template](https://docs.microsoft.com/en-us/dotnet/core/tools/custom-templates) from NuGet:
```... | [
"README.md"
] | [] | true | ||
TheAngryByrd/MiniScaffold | 261 | issue_to_patch | Fantomas5 | ## Proposed Changes
Updates to [Fantomas 5.0](https://github.com/fsprojects/fantomas/releases/tag/v5.0.0)
## Types of changes
What types of changes does your code introduce to MiniScaffold?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-... | 3df569605e8d1bca7e3475ff5b69f98206792eb1 | 62aa746fe0b244345ceec9d502b0067e43593dd6 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index a135a9b4..08722b16 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -1,12 +1,18 @@
{
- "version": 1,
- "isRoot": true,
- "tools": {
- "paket": {
- "version": "6.2.1",
- "commands": [
... | [
".config/dotnet-tools.json",
".editorconfig",
".git-blame-ignore-revs",
"Content/Console/.config/dotnet-tools.json",
"Content/Console/.editorconfig",
"Content/Console/.git-blame-ignore-revs",
"Content/Console/src/MyLib.1/Main.fs",
"Content/Console/tests/MyLib.1.Tests/Tests.fs",
"Content/Library/.con... | [] | diff --git a/Content/Console/tests/MyLib.1.Tests/Tests.fs b/Content/Console/tests/MyLib.1.Tests/Tests.fs
index 6ec2a60d..4b83cd9f 100644
--- a/Content/Console/tests/MyLib.1.Tests/Tests.fs
+++ b/Content/Console/tests/MyLib.1.Tests/Tests.fs
@@ -6,13 +6,13 @@ open MyLib._1
module SayTests =
[<Tests>]
let tests ... | true | |
TheAngryByrd/MiniScaffold | 259 | issue_to_patch | add an ide.host.json for nicer display in VS | ## Proposed Changes
This adds some additional configuration that
* enables the VS New Project Dialog
* makes that New Project Dialog experience look nice
I got this information partially from @sayedihashimi's template validation dotnet tool: https://github.com/sayedihashimi/template-sample, which is a great too... | 282ebb79db14430d9c829e0668659444a8e3c696 | 1693f3c973b85f57ae5a268b0f2741b9998b0cf0 | diff --git a/Content/.template.config/ide.host.json b/Content/.template.config/ide.host.json
new file mode 100644
index 00000000..99d8bd28
--- /dev/null
+++ b/Content/.template.config/ide.host.json
@@ -0,0 +1,26 @@
+{
+ "$schema": "http://json.schemastore.org/vs-2017.3.host",
+ "symbolInfo": [
+ {
+ ... | [
"Content/.template.config/ide.host.json",
"Content/.template.config/template.json",
"MiniScaffold.csproj"
] | [
{
"comment": "These are tags that the VS new project dialog uses to filter templates",
"path": "Content/.template.config/template.json",
"hunk": "@@ -2,25 +2,28 @@\n \"$schema\": \"http://json.schemastore.org/template\",\n \"author\": \"Jimmy Byrd\",\n \"classifications\": [\n- \"Scaf... | true | ||
TheAngryByrd/MiniScaffold | 257 | issue_to_patch | Adjust Dockerfiles to copy install-dotnets.sh correctly on new versions of Docker. | I faced an issue using the devcontainer locally, and turned out to be resolved by this little change:
https://stackoverflow.com/questions/53650492/when-using-copy-with-more-than-one-source-file-the-destination-must-be-a-direct
This adjusts the Dockerfiles to have a trailing `/` on the end of the
`COPY ./.devcontai... | 22326c12d5c29a9fc3086c26ff6842d86c1e6015 | 09e8de38dfd1de145cc541f98ada1fd751e06e07 | diff --git a/Content/Console/.devcontainer/Dockerfile b/Content/Console/.devcontainer/Dockerfile
index 7d75080a..2392de83 100644
--- a/Content/Console/.devcontainer/Dockerfile
+++ b/Content/Console/.devcontainer/Dockerfile
@@ -26,7 +26,7 @@ ENV \
DOTNET_INSTALL_DIR=/usr/share/dotnet/ \
DOTNET_ROOT=/usr/share/... | [
"Content/Console/.devcontainer/Dockerfile",
"Content/Library/.devcontainer/Dockerfile"
] | [] | true | ||
TheAngryByrd/MiniScaffold | 254 | issue_to_patch | Update to Fantomas 4.6 | ## Proposed Changes
Bump to the latest version.
| ff2f33bcb3a70eff97b64c38f97c5256056dab3d | ff2fadf1ac24ec06057a2e62ff284221721f13da | diff --git a/Content/Console/.config/dotnet-tools.json b/Content/Console/.config/dotnet-tools.json
index c8ff2c18..a9995f46 100644
--- a/Content/Console/.config/dotnet-tools.json
+++ b/Content/Console/.config/dotnet-tools.json
@@ -27,10 +27,10 @@
]
},
"fantomas-tool": {
- "version": "4.5.4",
+ ... | [
"Content/Console/.config/dotnet-tools.json",
"Content/Console/src/MyLib.1/Main.fs",
"Content/Library/.config/dotnet-tools.json"
] | [] | true | ||
TheAngryByrd/MiniScaffold | 250 | issue_to_patch | Net 6 0 | ## Proposed Changes
Updates MiniScaffold for .NET 6.0 and FSharp.Core 6.0 support
## Types of changes
What types of changes does your code introduce to MiniScaffold?
_Put an `x` in the boxes that apply_
- [x] New feature (non-breaking change which adds functionality)
## Checklist
_Put an `x` in the... | b6731ded99cb0cd6d1528b97f70f7cb7d392d4e3 | 7dc5cbac297ac5d15a505fbd897e44b453f79301 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 043a4849..a135a9b4 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -3,7 +3,7 @@
"isRoot": true,
"tools": {
"paket": {
- "version": "6.0.13",
+ "version": "6.2.1",
"com... | [
".config/dotnet-tools.json",
".devcontainer/install-dotnets.sh",
".github/workflows/build.yml",
"Content/Console/.config/dotnet-tools.json",
"Content/Console/.devcontainer/install-dotnets.sh",
"Content/Console/.github/workflows/build.yml",
"Content/Console/build.cmd",
"Content/Console/build.sh",
"Co... | [] | diff --git a/Content/Console/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj b/Content/Console/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj
index b48a30a8..6bc0c609 100755
--- a/Content/Console/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj
+++ b/Content/Console/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj
@@ -2,7 +2,7 @@
<Project Sdk="Mi... | true | |
TheAngryByrd/MiniScaffold | 247 | issue_to_patch | Update Fantomas and format using dotnet tool. | ## Proposed Changes
Hi @TheAngryByrd, sorry for now opening an issue first.
I'd like to bump the Fantomas version here, the current version 3.2 is quite old. And nowadays it is recommended to format outside of the FAKE process using the local .NET tool.
## Types of changes
What types of changes does your code... | 934318273716e6451a052f261fecf67228c7e908 | 98278ce8db4f75c106f5a90bb6bf55117306ef24 | diff --git a/Content/Console/.config/dotnet-tools.json b/Content/Console/.config/dotnet-tools.json
index bdf313a0..cf0aa42f 100644
--- a/Content/Console/.config/dotnet-tools.json
+++ b/Content/Console/.config/dotnet-tools.json
@@ -25,6 +25,12 @@
"commands": [
"fsharp-analyzers"
]
+ },
+ "fa... | [
"Content/Console/.config/dotnet-tools.json",
"Content/Console/.editorconfig",
"Content/Console/build/build.fs",
"Content/Console/build/paket.references",
"Content/Console/paket.dependencies",
"Content/Console/paket.lock",
"Content/Console/src/MyLib.1/Main.fs",
"Content/Console/tests/MyLib.1.Tests/Test... | [
{
"comment": "Fantomas respects this these days.",
"path": "Content/Console/.editorconfig",
"hunk": "@@ -11,6 +11,7 @@ root = true\n insert_final_newline = true\n indent_style = space\n indent_size = 4\n+end_of_line = lf",
"resolving_sha": "98278ce8db4f75c106f5a90bb6bf55117306ef24",
"resolving_d... | diff --git a/Content/Console/tests/MyLib.1.Tests/Tests.fs b/Content/Console/tests/MyLib.1.Tests/Tests.fs
index 170bfb54..6ec2a60d 100644
--- a/Content/Console/tests/MyLib.1.Tests/Tests.fs
+++ b/Content/Console/tests/MyLib.1.Tests/Tests.fs
@@ -6,10 +6,13 @@ open MyLib._1
module SayTests =
[<Tests>]
let tests ... | true | |
TheAngryByrd/MiniScaffold | 247 | comment_to_fix | Update Fantomas and format using dotnet tool. | Fantomas respects this these days. | 934318273716e6451a052f261fecf67228c7e908 | 98278ce8db4f75c106f5a90bb6bf55117306ef24 | diff --git a/Content/Console/.editorconfig b/Content/Console/.editorconfig
index 60948cd5..304fc051 100644
--- a/Content/Console/.editorconfig
+++ b/Content/Console/.editorconfig
@@ -11,6 +11,7 @@ root = true
insert_final_newline = true
indent_style = space
indent_size = 4
+end_of_line = lf
[*.{fs,fsi,fsx,config}... | [
"Content/Console/.editorconfig"
] | [
{
"comment": "Fantomas respects this these days.",
"path": "Content/Console/.editorconfig",
"hunk": "@@ -11,6 +11,7 @@ root = true\n insert_final_newline = true\n indent_style = space\n indent_size = 4\n+end_of_line = lf",
"resolving_sha": "98278ce8db4f75c106f5a90bb6bf55117306ef24",
"resolving_d... | true | ||
TheAngryByrd/MiniScaffold | 247 | comment_to_fix | Update Fantomas and format using dotnet tool. | Any idea why this is ignored? We also have a concept called [.fantomasignore](https://github.com/fsprojects/fantomas/blob/master/docs/Documentation.md#ignore-files-fantomasignore).
We could also use that if you want. | 934318273716e6451a052f261fecf67228c7e908 | 98278ce8db4f75c106f5a90bb6bf55117306ef24 | diff --git a/Content/Console/build/build.fs b/Content/Console/build/build.fs
index 7ded31c2..5a88e551 100644
--- a/Content/Console/build/build.fs
+++ b/Content/Console/build/build.fs
@@ -11,8 +11,6 @@ open Fake.IO.Globbing.Operators
open Fake.Core.TargetOperators
open Fake.Api
open Fake.BuildServer
-open Fantomas
-o... | [
"Content/Console/build/build.fs"
] | [
{
"comment": "Any idea why this is ignored? We also have a concept called [.fantomasignore](https://github.com/fsprojects/fantomas/blob/master/docs/Documentation.md#ignore-files-fantomasignore).\r\nWe could also use that if you want.",
"path": "Content/Console/build/build.fs",
"hunk": "@@ -540,22 +538,4... | true | ||
TheAngryByrd/MiniScaffold | 247 | comment_to_fix | Update Fantomas and format using dotnet tool. | The check target verifies whether the code was formatted.
We use this on a daily basis to fail CI, it really enforces the team to format each time.
Again, let me know if you want this or not. | 934318273716e6451a052f261fecf67228c7e908 | 98278ce8db4f75c106f5a90bb6bf55117306ef24 | diff --git a/Content/Console/build/build.fs b/Content/Console/build/build.fs
index 7ded31c2..5a88e551 100644
--- a/Content/Console/build/build.fs
+++ b/Content/Console/build/build.fs
@@ -11,8 +11,6 @@ open Fake.IO.Globbing.Operators
open Fake.Core.TargetOperators
open Fake.Api
open Fake.BuildServer
-open Fantomas
-o... | [
"Content/Console/build/build.fs"
] | [
{
"comment": "The check target verifies whether the code was formatted.\r\nWe use this on a daily basis to fail CI, it really enforces the team to format each time.\r\nAgain, let me know if you want this or not.",
"path": "Content/Console/build/build.fs",
"hunk": "@@ -540,22 +538,40 @@ let githubRelease... | true | ||
TheAngryByrd/MiniScaffold | 247 | comment_to_fix | Update Fantomas and format using dotnet tool. | I recommend making a helper function for this tool. Look at [this module](https://github.com/TheAngryByrd/MiniScaffold/blob/master/Content/Console/build/build.fs#L202) for reference. | 934318273716e6451a052f261fecf67228c7e908 | 98278ce8db4f75c106f5a90bb6bf55117306ef24 | diff --git a/Content/Console/build/build.fs b/Content/Console/build/build.fs
index 7ded31c2..5a88e551 100644
--- a/Content/Console/build/build.fs
+++ b/Content/Console/build/build.fs
@@ -11,8 +11,6 @@ open Fake.IO.Globbing.Operators
open Fake.Core.TargetOperators
open Fake.Api
open Fake.BuildServer
-open Fantomas
-o... | [
"Content/Console/build/build.fs"
] | [
{
"comment": "I recommend making a helper function for this tool. Look at [this module](https://github.com/TheAngryByrd/MiniScaffold/blob/master/Content/Console/build/build.fs#L202) for reference.",
"path": "Content/Console/build/build.fs",
"hunk": "@@ -540,22 +538,40 @@ let githubRelease _ =\n |> A... | true | ||
TheAngryByrd/MiniScaffold | 246 | issue_to_patch | Move off fake-cli | ## Proposed Changes
This moves the build scripts away from using `fake-cli` and using a dotnet project to run it. `fake-cli` hasn't been updated in quite a long time and isn't using the latest version of FSharp.Compiler.Services so tooling like Ionide work with it anymore.
There aren't major changes to the buil... | 969c1f7201316eeab32fcbc934e5f2964c858504 | 815d3f6d07dcd210aca874993766f11fa1f3414d | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index bb83d856..043a4849 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -1,18 +1,12 @@
{
- "version": 1,
- "isRoot": true,
- "tools": {
- "fake-cli": {
- "version": "5.20.4-alpha.1642",
- "commands": [
- ... | [
".config/dotnet-tools.json",
".paket/Paket.Restore.targets",
"Content/Console/.config/dotnet-tools.json",
"Content/Console/.paket/Paket.Restore.targets",
"Content/Console/MyLib.1.sln",
"Content/Console/build.cmd",
"Content/Console/build.sh",
"Content/Console/build/build.fs",
"Content/Console/build/b... | [] | diff --git a/Content/Library/tests/MyLib.1.Tests/coverage.xml.acv b/Content/Library/tests/MyLib.1.Tests/coverage.xml.acv
deleted file mode 100644
index e69de29b..00000000
diff --git a/tests/MiniScaffold.Tests/Asserts.fs b/tests/MiniScaffold.Tests/Asserts.fs
index adad67de..7f1742c2 100644
--- a/tests/MiniScaffold.Tests... | true | |
TheAngryByrd/MiniScaffold | 243 | issue_to_patch | pin Octokit to 0.48 until FAKE is upgraded | ## Proposed Changes
Pin Octokit to 0.48, until https://github.com/fsharp/FAKE/pull/2594 is merged and released in FAKE. Currently, the scaffold pulls in a floating version of Octokit through FAKE. Octokit had a breaking interface change in [0.50](https://github.com/octokit/octokit.net/releases/tag/v0.50.0) to Upload... | 0f112bc26bcac6ab26622b5cde85d4e1d78d247b | 2349c7884e0131d446985d02a5595b81b8a5d54b | diff --git a/Content/Console/paket.dependencies b/Content/Console/paket.dependencies
index c6945e8d..e8abdfee 100644
--- a/Content/Console/paket.dependencies
+++ b/Content/Console/paket.dependencies
@@ -27,6 +27,7 @@ group Build
nuget Fake.Api.GitHub 5.20.4-alpha.1642
nuget Fake.BuildServer.GitHubActions 5.20... | [
"Content/Console/paket.dependencies",
"Content/Console/paket.lock",
"Content/Library/paket.dependencies",
"Content/Library/paket.lock",
"paket.dependencies",
"paket.lock"
] | [] | true | ||
TheAngryByrd/MiniScaffold | 245 | issue_to_patch | update default release branch name to `main`. Add `--releaseBranch` parameter to allow overriding this. | ## Proposed Changes
The [default branch name for new GitHub repositories is now `main`](https://github.blog/changelog/2020-10-01-the-default-branch-for-newly-created-repositories-is-now-main/). This diff changes the default release branch name for the scaffold to `main`, to align with that, but also adds a `--releas... | 84f17035cca64cde91a183bcf23e7e6fd474f110 | 4a38010e25a69669e4ed6ee54a0d6568dc714bf2 | diff --git a/Content/.template.config/template.json b/Content/.template.config/template.json
index 3d6a96ad..624bb719 100644
--- a/Content/.template.config/template.json
+++ b/Content/.template.config/template.json
@@ -32,7 +32,12 @@
"description": "Creates a template for console projects"
... | [
"Content/.template.config/template.json",
"Content/Console/build.fsx",
"Content/Library/build.fsx",
"README.md",
"paket.dependencies",
"paket.lock",
"tests/MiniScaffold.Tests/Asserts.fs",
"tests/MiniScaffold.Tests/Tests.fs"
] | [] | diff --git a/tests/MiniScaffold.Tests/Asserts.fs b/tests/MiniScaffold.Tests/Asserts.fs
index 428ea9f0..adad67de 100644
--- a/tests/MiniScaffold.Tests/Asserts.fs
+++ b/tests/MiniScaffold.Tests/Asserts.fs
@@ -262,8 +262,28 @@ module Effect =
i <- i + 1
lines |> File.writeNew buildScript
- ... | true | |
TheAngryByrd/MiniScaffold | 235 | issue_to_patch | Add EFCore.FSharp to list of projects using MiniScaffold | ## Proposed Changes
Add EFCore.FSharp to the list of projects using MiniScaffold
## Types of changes
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not wo... | b736d81ba5bec52ba33b18fcfc7bd1ecb8fc95ae | 4e2410271aca4bba10b0180532de91ca93bf3e33 | diff --git a/README.md b/README.md
index 8f456c71..5a4d95df 100644
--- a/README.md
+++ b/README.md
@@ -142,6 +142,7 @@ Appveyor's conventions around generating URLs based on the project name has some
* [FSharp.Control.Redis.Streams](https://github.com/TheAngryByrd/FSharp.Control.Redis.Streams)
* [FsLibLog](https://gi... | [
"README.md"
] | [] | true | ||
TheAngryByrd/MiniScaffold | 244 | issue_to_patch | Workaround to get FAKE to read v13 of msbuild binlogs | ## Proposed Changes
Uses the transitive workout listed in https://github.com/fsharp/FAKE/issues/2595 to get FAKE to read the binlog correctly
## Types of changes
What types of changes does your code introduce to MiniScaffold?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixe... | b98fd4a74b1db101b2a36fbf80905c5b4bb23d92 | ab125d3fa8e93b20c322b007cede02387de57e10 | diff --git a/Content/Console/.config/dotnet-tools.json b/Content/Console/.config/dotnet-tools.json
index 4870aaf3..36b4d18d 100644
--- a/Content/Console/.config/dotnet-tools.json
+++ b/Content/Console/.config/dotnet-tools.json
@@ -27,7 +27,7 @@
]
},
"fsharp-analyzers": {
- "version": "0.8.0",
+ ... | [
"Content/Console/.config/dotnet-tools.json",
"Content/Console/global.json",
"Content/Library/.config/dotnet-tools.json",
"Content/Library/global.json",
"Content/Library/tests/MyLib.1.Tests/coverage.xml.acv",
"global.json",
"paket.lock"
] | [] | diff --git a/Content/Library/tests/MyLib.1.Tests/coverage.xml.acv b/Content/Library/tests/MyLib.1.Tests/coverage.xml.acv
new file mode 100644
index 00000000..e69de29b
| true | |
TheAngryByrd/MiniScaffold | 242 | issue_to_patch | Include README on publish
**Is your feature request related to a problem? Please describe.**
As of `5.0.300`, you [can package your `README.md` in your nuget package](https://devblogs.microsoft.com/nuget/add-a-readme-to-your-nuget-package/).
**Describe the solution you'd like**
The suggested solution from the... | 237 readme packaged | ## Proposed Changes
Closes #237
## Types of changes
What types of changes does your code introduce to MiniScaffold?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ x] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or... | ab0d907bd77d9547d0237fc52bf50c46b6d80870 | 7335657ba483e3cbbb6769f542ba441c13965a81 | diff --git a/Content/Library/src/Directory.Build.props b/Content/Library/src/Directory.Build.props
index a31b8220..ad7a116f 100644
--- a/Content/Library/src/Directory.Build.props
+++ b/Content/Library/src/Directory.Build.props
@@ -4,9 +4,13 @@
<GenerateDocumentationFile>true</GenerateDocumentationFile>
... | [
"Content/Library/src/Directory.Build.props",
"MiniScaffold.csproj"
] | [] | true | |
TheAngryByrd/MiniScaffold | 241 | issue_to_patch | Executing test project with `dotnet run -p` fails unless `--framework` option is passed to dotnet run
**Describe the bug**
If I create a new project from the MiniScaffold template, then try to run the Expecto unit tests with `dotnet run -p tests/Foo.Tests/Foo.Tests.fsproj`, I get the error "Unable to run your project... | Uses TargetFramework since we're only targetting net5.0 | This helps when running tests in expectos runner vs the dotnet test runner
## Proposed Changes
Closes #239
## Types of changes
What types of changes does your code introduce to MiniScaffold?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (... | dc7de73e001ed9b0b9dba0d69e6688fb72bae12f | 574ae6eef9372dbdb6127d66f6c22d4b446ad733 | diff --git a/Content/Library/src/MyLib.1/MyLib.1.fsproj b/Content/Library/src/MyLib.1/MyLib.1.fsproj
index 534d219d..6e61786e 100755
--- a/Content/Library/src/MyLib.1/MyLib.1.fsproj
+++ b/Content/Library/src/MyLib.1/MyLib.1.fsproj
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<Project Sdk="Microsoft.NET.Sdk"... | [
"Content/Console/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj",
"Content/Library/src/MyLib.1/MyLib.1.fsproj",
"Content/Library/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj"
] | [] | diff --git a/Content/Console/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj b/Content/Console/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj
index b48bdb50..b48a30a8 100755
--- a/Content/Console/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj
+++ b/Content/Console/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj
@@ -2,7 +2,7 @@
<Project Sdk="Mi... | true |
TheAngryByrd/MiniScaffold | 238 | issue_to_patch | Update to use BinaryDefense.FSharp.Analyzers.Hashing 0.2.2. Pinned Fantomas version to 3.2. | ## Proposed Changes
This updates the `paket.dependencies` used by the template projects, to pull in BinaryDefense.FSharp.Analyzers.Hashing 0.2.2, and fsharp-analyzers 0.8.0, for compatibility with the latest F# compiler service, analyzer SDK, etc. The `paket.lock` file for the templates was also updated, resulting i... | d7c8cc1f1e4007e15ce0a33ef8e7dc35fed578f1 | 5c8531a45f356fe1af4ad761bbc80f5c1cf1b32c | diff --git a/Content/Console/.config/dotnet-tools.json b/Content/Console/.config/dotnet-tools.json
index 4c0c3273..4870aaf3 100644
--- a/Content/Console/.config/dotnet-tools.json
+++ b/Content/Console/.config/dotnet-tools.json
@@ -27,7 +27,7 @@
]
},
"fsharp-analyzers": {
- "version": "0.7.0",
+ ... | [
"Content/Console/.config/dotnet-tools.json",
"Content/Console/paket.dependencies",
"Content/Console/paket.lock",
"Content/Library/.config/dotnet-tools.json",
"Content/Library/paket.dependencies",
"Content/Library/paket.lock"
] | [] | true | ||
TheAngryByrd/MiniScaffold | 233 | issue_to_patch | Makes devcontainers more flexible with dotnet versions | ## Proposed Changes
This makes devcontainers more flexible with installing specific versions of dotnet.
## Types of changes
What types of changes does your code introduce to MiniScaffold?
_Put an `x` in the boxes that apply_
- [x] New feature (non-breaking change which adds functionality)
## Checklis... | 725e1ecf609258bda0f0d73f4268a926a4b0273c | 9fa85a1f19d5b9ff23828d6f5adc1c8205644308 | diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile
new file mode 100644
index 00000000..7d75080a
--- /dev/null
+++ b/.devcontainer/Dockerfile
@@ -0,0 +1,40 @@
+FROM debian:buster-slim
+
+
+RUN apt-get update \
+ && apt-get install -y --no-install-recommends \
+ ca-certificates \
+ \
+ ... | [
".devcontainer/Dockerfile",
".devcontainer/devcontainer.json",
".devcontainer/install-dotnets.sh",
".devcontainer/settings.vscode.json",
"Content/Console/.devcontainer/Dockerfile",
"Content/Console/.devcontainer/devcontainer.json",
"Content/Console/.devcontainer/install-dotnets.sh",
"Content/Library/.... | [] | true | ||
TheAngryByrd/MiniScaffold | 234 | issue_to_patch | Makes github install dotnet from global.json | ## Proposed Changes
Makes github install dotnet from global.json
## Types of changes
What types of changes does your code introduce to MiniScaffold?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
## Checklist
_Put an `x` in the boxes that apply. You can... | 2d7bb0379f9ac222a1da2dc63fd604c1f599f06c | f9bb6c03eb40c20f8134097a21d5d61fa53c8300 | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 6052f759..b7a70724 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -19,10 +19,9 @@ jobs:
uses: actions/setup-dotnet@v1
with:
dotnet-version: '3.1.x'
- - name: Use .NET Core 5.0 SDK
+ #... | [
".github/workflows/build.yml",
"Content/Console/.github/workflows/build.yml",
"Content/Library/.github/workflows/build.yml",
"tests/MiniScaffold.Tests/Tests.fs"
] | [] | diff --git a/tests/MiniScaffold.Tests/Tests.fs b/tests/MiniScaffold.Tests/Tests.fs
index 0d650cfd..5d1ab640 100755
--- a/tests/MiniScaffold.Tests/Tests.fs
+++ b/tests/MiniScaffold.Tests/Tests.fs
@@ -69,6 +69,10 @@ module Tests =
Dotnet.New.cmd (fun opt -> { opt with WorkingDirectory = directory}) newArgs.ToS... | true | |
TheAngryByrd/MiniScaffold | 232 | issue_to_patch | Fixes GitHub Workflow FAKE integration | ## Proposed Changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to MiniScaffold?
_Put a... | fe314e42985c8ee73b272644750d3d1821312937 | 59836c163667e5013240c716caeb54416dc0bed5 | diff --git a/Content/Console/build.fsx b/Content/Console/build.fsx
index 3c42c427..a2d25ea8 100644
--- a/Content/Console/build.fsx
+++ b/Content/Console/build.fsx
@@ -19,8 +19,7 @@ open Fantomas
open Fantomas.FakeHelpers
BuildServer.install [
- AppVeyor.Installer
- Travis.Installer
+ GitHubActions.Installe... | [
"Content/Console/build.fsx",
"Content/Console/paket.dependencies",
"Content/Console/paket.lock",
"Content/Library/build.fsx",
"Content/Library/paket.dependencies",
"Content/Library/paket.lock",
"build.fsx",
"paket.dependencies",
"paket.lock"
] | [] | true | ||
TheCherno/Hazel | 617 | issue_to_patch | Folder msdf-atlas-gen empty upon recursive clone
I just cloned the Hazel engine to use it, but the msdf-atlas-gen folder is empty, which crashes the setup.bat file.
Win-GenProjects.bat can't find msdf-atlas-gen
#### Describe the bug
I'm trying to use the Hazel engine for the first time. I ran `git clone --recursive... | Fix for cloning issues with msdf-atlas-gen | Cloning with git will not include msdf-atlas-gen because of the backslash characters in .gitmodules. | 5e20b232b749a8f1339e32074c254c44d7c9c263 | 205a0d337ceff6e9454cf20a59b14c92f9b5bfeb | diff --git a/.gitmodules b/.gitmodules
index b8652c942..5e21494cf 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -23,6 +23,6 @@
[submodule "Hazel/vendor/Box2D"]
path = Hazel/vendor/Box2D
url = https://github.com/thecherno/box2d
-[submodule "Hazel\\vendor\\msdf-atlas-gen"]
- path = Hazel\\vendor\\msdf-atlas-gen
+[su... | [
".gitmodules"
] | [] | true | |
TheCherno/Hazel | 516 | issue_to_patch | Add missing Save feature | #### Describe the issue (if no issue has been made)
This PR does not fix any issue.
This PR add the long-missing Save feature (so far we only have Save As...).
Also, `Save` and `Save As...` menu will be disabled if no scene is loaded.
#### PR impact
List of related issues/PRs this will solve:
Impact ... | d87b9b460d4c1508d7bf6510825357c9d9f2d31d | 7e2327c3c930d982dd3776fd3080e4af0a2a9aee | diff --git a/Hazelnut/src/EditorLayer.cpp b/Hazelnut/src/EditorLayer.cpp
index 066f50f76..aca524e3f 100644
--- a/Hazelnut/src/EditorLayer.cpp
+++ b/Hazelnut/src/EditorLayer.cpp
@@ -234,7 +234,10 @@ namespace Hazel {
if (ImGui::MenuItem("Open...", "Ctrl+O"))
OpenScene();
- if (ImGui::MenuItem("Save As...... | [
"Hazelnut/src/EditorLayer.cpp",
"Hazelnut/src/EditorLayer.h"
] | [] | true | ||
TheCherno/Hazel | 564 | issue_to_patch | Add selected entity outline rendering | #### Describe the issue (if no issue has been made)
This PR aims to implement an outline to selected entities to help users differentiate between selected vs. nonselected entities.
#### PR impact _(Mak... | 220f424706bd852e297c39bf99ed52a25ecab468 | 36ea3c5061c8698f7caa43ee56bdb5bc88a5b6aa | diff --git a/Hazelnut/src/EditorLayer.cpp b/Hazelnut/src/EditorLayer.cpp
index 863d8f22f..67f7af953 100644
--- a/Hazelnut/src/EditorLayer.cpp
+++ b/Hazelnut/src/EditorLayer.cpp
@@ -558,6 +558,14 @@ namespace Hazel {
}
}
+ // Draw selected entity outline
+ if (Entity selectedEntity = m_SceneHierarchyPanel.Ge... | [
"Hazelnut/src/EditorLayer.cpp"
] | [] | true | ||
TheCherno/Hazel | 491 | issue_to_patch | Simplify UUID hash specialization | Just a quick note I wanted to call out after watching the UUID video which popped up on my feed the other day.
The purpose of `std::hash` is to create a uniformly distributed value from some type. `std::hash<uint64_t>` exists because arbitrary `uint64_t` values aren't inherently uniformly distributed. However, the `... | 7aa36c8f686e2cb9b47ea5679b508f64ab054b81 | 11296918a967d2d303c886b0209548de19dfd31a | diff --git a/Hazel/src/Hazel/Core/UUID.h b/Hazel/src/Hazel/Core/UUID.h
index 47238ba05..85840a4c3 100644
--- a/Hazel/src/Hazel/Core/UUID.h
+++ b/Hazel/src/Hazel/Core/UUID.h
@@ -1,7 +1,5 @@
#pragma once
-#include <xhash>
-
namespace Hazel {
// "UUID" (universally unique identifier) or GUID is (usually) a 128-bit... | [
"Hazel/src/Hazel/Core/UUID.h"
] | [] | true | ||
TheCherno/Hazel | 536 | issue_to_patch | static_assert(false) only compiles with Visual C++
#### Describe the bug
In `Hazel/Scene/Scene.cpp` there is a `static_assert(false)`, which gives us the kind reminder to add the `OnComponentAdded` function for a new component we add. Compilation fails if we have not added every template variant for every component. ... | Changed static assert condition | #### Describe the issue (if no issue has been made)
In `Hazel/Scene/Scene.cpp` there is a `static_assert(false)`, which gives us the kind reminder to add the `OnComponentAdded` function for a new component we add. Compilation fails if we have not added every template variant for every component. This is the desired fu... | 6dba23b3429e7fb774bb6b2853f2143f6869842e | b831585bc5d383048ef32e339a00587cf7b99f45 | diff --git a/Hazel/src/Hazel/Scene/Scene.cpp b/Hazel/src/Hazel/Scene/Scene.cpp
index cf4d784cd..9d639b21c 100644
--- a/Hazel/src/Hazel/Scene/Scene.cpp
+++ b/Hazel/src/Hazel/Scene/Scene.cpp
@@ -301,12 +301,6 @@ namespace Hazel {
CopyComponentIfExists(AllComponents{}, newEntity, entity);
}
- template<typename T>
-... | [
"Hazel/src/Hazel/Scene/Scene.cpp"
] | [] | true | |
TheCherno/Hazel | 502 | issue_to_patch | Refactored #include order | #### Describe the issue
In a recent video, Cherno explained how he wants the include order of his files to be like. The priority from top to bottom is:
- Pre-compiled header
- User-defined headers
- External library headers / Standard Library headers
In some of the files, this order isn't followed.
#### PR im... | 6dba23b3429e7fb774bb6b2853f2143f6869842e | b4fabe88062e95ed069f2817dc0e14d369a1c32c | diff --git a/Hazel/src/Hazel/Core/Base.h b/Hazel/src/Hazel/Core/Base.h
index 426baa0d2..dac2ccaa3 100644
--- a/Hazel/src/Hazel/Core/Base.h
+++ b/Hazel/src/Hazel/Core/Base.h
@@ -1,9 +1,9 @@
#pragma once
-#include <memory>
-
#include "Hazel/Core/PlatformDetection.h"
+#include <memory>
+
#ifdef HZ_DEBUG
#if defin... | [
"Hazel/src/Hazel/Core/Base.h",
"Hazel/src/Hazel/Core/Input.h",
"Hazel/src/Hazel/Core/Window.h",
"Hazel/src/Hazel/Debug/Instrumentor.h",
"Hazel/src/Hazel/Events/Event.h",
"Hazel/src/Hazel/Renderer/RendererAPI.h",
"Hazel/src/Hazel/Renderer/Texture.h",
"Hazel/src/Hazel/Renderer/VertexArray.h",
"Hazel/s... | [] | true | ||
TheCherno/Hazel | 489 | issue_to_patch | AddComponent code-block refactor | #### Describe the issue
In `SceneHierarchyPanel` , when we press AddComponent button to open the `AddComponent` popup, it displays a list of menu items stating which components could be added to the entity. The code for drawing the menu items with ImGui was a bit repetitive and could be made concise.
#### PR impact... | 6dba23b3429e7fb774bb6b2853f2143f6869842e | 979e2e0c90bad058439c3a193237699de95e2085 | diff --git a/Hazelnut/src/Panels/SceneHierarchyPanel.cpp b/Hazelnut/src/Panels/SceneHierarchyPanel.cpp
index bc52373e7..3119f899e 100644
--- a/Hazelnut/src/Panels/SceneHierarchyPanel.cpp
+++ b/Hazelnut/src/Panels/SceneHierarchyPanel.cpp
@@ -239,59 +239,12 @@ namespace Hazel {
if (ImGui::BeginPopup("AddComponent"))... | [
"Hazelnut/src/Panels/SceneHierarchyPanel.cpp",
"Hazelnut/src/Panels/SceneHierarchyPanel.h"
] | [] | true | ||
TheCherno/Hazel | 556 | issue_to_patch | Implemented platform agnostic GetTime() | Provides a way to just import platform utils and get time in seconds by calling Time::GetTime(), without hard coding the glfw way of obtaining it.
#### Describe the issue (if no issue has been made)
Watching the episode named TIMESTEPS and DELTA TIME from the engine series I realized that the platform agnostic way ... | 6dba23b3429e7fb774bb6b2853f2143f6869842e | 40c65160ec94836081e447a4d5d60f2e2cc586c2 | diff --git a/Hazel/src/Hazel/Core/Application.cpp b/Hazel/src/Hazel/Core/Application.cpp
index 80628a6fa..011144d19 100644
--- a/Hazel/src/Hazel/Core/Application.cpp
+++ b/Hazel/src/Hazel/Core/Application.cpp
@@ -6,8 +6,7 @@
#include "Hazel/Renderer/Renderer.h"
#include "Hazel/Core/Input.h"
-
-#include <GLFW/glfw3.... | [
"Hazel/src/Hazel/Core/Application.cpp",
"Hazel/src/Hazel/Utils/PlatformUtils.h",
"Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp"
] | [] | true | ||
TheCherno/Hazel | 551 | issue_to_patch | Update the old texture comparison behavior | Replaced unnecessary casting with GetRendererID
| f627b9c90923382f735350cd3060892bbd4b1e75 | 0dd7e0147cf53f8b27293748bb057574326a31db | diff --git a/Hazel/src/Platform/OpenGL/OpenGLTexture.h b/Hazel/src/Platform/OpenGL/OpenGLTexture.h
index ca45a0cc5..3f590fe71 100644
--- a/Hazel/src/Platform/OpenGL/OpenGLTexture.h
+++ b/Hazel/src/Platform/OpenGL/OpenGLTexture.h
@@ -25,7 +25,7 @@ namespace Hazel {
virtual bool operator==(const Texture& other) cons... | [
"Hazel/src/Platform/OpenGL/OpenGLTexture.h"
] | [] | true | ||
TheCherno/Hazel | 539 | issue_to_patch | Fixed use of "std::filesystem::relative" in Content Browser main loop | #### Describe the issue
The use of "std::filesystem::relative" in the main loop of the content browser results in huge slow downs (visible when not limiting VSYNC).
#### Proposed fix
Using the path to get the filenamestring, and only obtaining the relative path when doing the actual drag and drop.
Discovered th... | f627b9c90923382f735350cd3060892bbd4b1e75 | c11c8f821c570b9cf010e23cf46ba32a292fb9eb | diff --git a/Hazelnut/src/Panels/ContentBrowserPanel.cpp b/Hazelnut/src/Panels/ContentBrowserPanel.cpp
index 067a01772..201a458bc 100644
--- a/Hazelnut/src/Panels/ContentBrowserPanel.cpp
+++ b/Hazelnut/src/Panels/ContentBrowserPanel.cpp
@@ -41,8 +41,7 @@ namespace Hazel {
for (auto& directoryEntry : std::filesystem:... | [
"Hazelnut/src/Panels/ContentBrowserPanel.cpp"
] | [] | true | ||
TheCherno/Hazel | 527 | issue_to_patch | EditorCamera should only process events during edit time | #### Describe the issue
Currently the editor camera is receiving events whilst the game is running, leading to odd behaviour:
1. Open PinkCube scene
2. Scroll up to zoom into the cube
3. Click run
4. Scroll down to zoom out, you won't see any zoom as we're only showing the runtime camera
5. Click stop
6. The edi... | f627b9c90923382f735350cd3060892bbd4b1e75 | 40f932d15b906c2d96f2c3e62589d1ee3ef02810 | diff --git a/Hazelnut/src/EditorLayer.cpp b/Hazelnut/src/EditorLayer.cpp
index 454a5d4c6..0de056ccd 100644
--- a/Hazelnut/src/EditorLayer.cpp
+++ b/Hazelnut/src/EditorLayer.cpp
@@ -380,7 +380,10 @@ namespace Hazel {
void EditorLayer::OnEvent(Event& e)
{
m_CameraController.OnEvent(e);
- m_EditorCamera.OnEvent(e)... | [
"Hazelnut/src/EditorLayer.cpp"
] | [] | true | ||
TheCherno/Hazel | 518 | issue_to_patch | Added missing entityID parameter | #### Describe the issue (if no issue has been made)
"entityID" isn't passed to the Renderer2D::DrawLine() function calls in Renderer2D::DrawRect()
#### PR impact
List of related issues/PRs this will solve:
Impact | Issue/PR
------------------------ | ------
Issues this solves | None
O... | 344acd31b18eab52d6a942af76a2f49993ec5f87 | 08e759cbbabf9e89ae913bc5851fe56d5194ed63 | diff --git a/Hazel/src/Hazel/Renderer/Renderer2D.cpp b/Hazel/src/Hazel/Renderer/Renderer2D.cpp
index e606d1055..0a4b8b4fa 100644
--- a/Hazel/src/Hazel/Renderer/Renderer2D.cpp
+++ b/Hazel/src/Hazel/Renderer/Renderer2D.cpp
@@ -469,10 +469,10 @@ namespace Hazel {
glm::vec3 p2 = glm::vec3(position.x + size.x * 0.5f, pos... | [
"Hazel/src/Hazel/Renderer/Renderer2D.cpp"
] | [] | true | ||
TheCherno/Hazel | 406 | issue_to_patch | At GLFW input check, removed "button state" check which is never invoked. | #### Describe the issue (if no issue has been made)
In `WindowsInput` class implementation, in function `Input::IsKeyPressed` the GLFW window is checked for key press. We're performing 2 checks there (1 for button pressed and 1 for button repeat), but from the description of the `GLFWwindow::glfwGetKey`, this "repeat"... | 9749d0c980ca1ac7f1758ebea48c019c17e16699 | 35dec24c639d557347c0cc55d456ca4145164a7b | diff --git a/Hazel/src/Platform/Windows/WindowsInput.cpp b/Hazel/src/Platform/Windows/WindowsInput.cpp
index f18f8e972..3d56e0612 100644
--- a/Hazel/src/Platform/Windows/WindowsInput.cpp
+++ b/Hazel/src/Platform/Windows/WindowsInput.cpp
@@ -10,7 +10,7 @@ namespace Hazel {
{
auto* window = static_cast<GLFWwindow*>(... | [
"Hazel/src/Platform/Windows/WindowsInput.cpp"
] | [] | true | ||
TheCherno/Hazel | 495 | issue_to_patch | CopyComponent and CopyComponentIfExists as a variadic template functions. | #### Describe the issue (if no issue has been made)
A clear and concise description of what the issue is. Explain the difference between the expected and the current behavior.
A screenshot or copy of the error could be helpful as well.
This is just to reduce duplicate code.
#### PR impact _(Make sure to add [cl... | 7aa36c8f686e2cb9b47ea5679b508f64ab054b81 | cfef38e1bf4a361c3eeeed3bc725b94ea0876106 | diff --git a/Hazel/src/Hazel/Scene/Components.h b/Hazel/src/Hazel/Scene/Components.h
index acbd9a7b1..985794623 100644
--- a/Hazel/src/Hazel/Scene/Components.h
+++ b/Hazel/src/Hazel/Scene/Components.h
@@ -121,5 +121,14 @@ namespace Hazel {
BoxCollider2DComponent() = default;
BoxCollider2DComponent(const BoxCollid... | [
"Hazel/src/Hazel/Scene/Components.h",
"Hazel/src/Hazel/Scene/Scene.cpp"
] | [] | true | ||
TheCherno/Hazel | 483 | issue_to_patch | Fixed typo in Log.h file | #### Describe the issue
In PR #361 , overloaded operators were added to the `Log.h` file to properly convert the `glm` data types into a stream.
One of the operators, the operator for quaternion, has the typo mistake error, where the word "quaternion" is spelled as "quaternio", in it's definition.
#### PR impact
... | 0f8fa94e22ed352512ac0a16bf703d631377d7e2 | 6240078655731abeae125978442599d984b8858c | diff --git a/Hazel/src/Hazel/Core/Log.h b/Hazel/src/Hazel/Core/Log.h
index 9568bcde4..124ad2f59 100644
--- a/Hazel/src/Hazel/Core/Log.h
+++ b/Hazel/src/Hazel/Core/Log.h
@@ -40,9 +40,9 @@ inline OStream& operator<<(OStream& os, const glm::mat<C, R, T, Q>& matrix)
}
template<typename OStream, typename T, glm::qualifi... | [
"Hazel/src/Hazel/Core/Log.h"
] | [] | true | ||
TheCherno/Hazel | 361 | issue_to_patch | Added loging glm vectors, matrix and quaternios | #### The issue
If you want log a glm vector, matrix or quaternio, you must type HAZEL_INFO(glm::to_string(some_vector)) and that glm::to_string is very annoying. So, now you can type HAZEL_INFO(some_vector) with out that glm::to_string.
#### PR impact
Impact | Issue/PR
------------------------... | a014633bb728106b03dce214c765b7e7892f6d70 | 595b153e0f38cd8ca5204a6b877268c4ef16ed39 | diff --git a/Hazel/src/Hazel/Core/Log.h b/Hazel/src/Hazel/Core/Log.h
index 06b9a2d6a..494992769 100644
--- a/Hazel/src/Hazel/Core/Log.h
+++ b/Hazel/src/Hazel/Core/Log.h
@@ -1,5 +1,7 @@
#pragma once
+#include "glm/gtx/string_cast.hpp"
+
#include "Hazel/Core/Base.h"
// This ignores all warnings raised inside Exter... | [
"Hazel/src/Hazel/Core/Log.h"
] | [
{
"comment": "```suggestion\r\n\treturn os << glm::to_string(quaternio);\r\n```",
"path": "Hazel/src/Hazel/Core/Log.h",
"hunk": "@@ -25,6 +27,25 @@ namespace Hazel {\n \n }\n \n+template<typename OStream, glm::length_t L, typename T, glm::qualifier Q>\n+inline OStream& operator<<(OStream& os, const glm:... | true | ||
TheCherno/Hazel | 361 | comment_to_fix | Added loging glm vectors, matrix and quaternios | ```suggestion
return os << glm::to_string(quaternio);
``` | a014633bb728106b03dce214c765b7e7892f6d70 | 595b153e0f38cd8ca5204a6b877268c4ef16ed39 | diff --git a/Hazel/src/Hazel/Core/Log.h b/Hazel/src/Hazel/Core/Log.h
index 06b9a2d6a..494992769 100644
--- a/Hazel/src/Hazel/Core/Log.h
+++ b/Hazel/src/Hazel/Core/Log.h
@@ -1,5 +1,7 @@
#pragma once
+#include "glm/gtx/string_cast.hpp"
+
#include "Hazel/Core/Base.h"
// This ignores all warnings raised inside Exter... | [
"Hazel/src/Hazel/Core/Log.h"
] | [
{
"comment": "```suggestion\r\n\treturn os << glm::to_string(quaternio);\r\n```",
"path": "Hazel/src/Hazel/Core/Log.h",
"hunk": "@@ -25,6 +27,25 @@ namespace Hazel {\n \n }\n \n+template<typename OStream, glm::length_t L, typename T, glm::qualifier Q>\n+inline OStream& operator<<(OStream& os, const glm:... | true | ||
TheCherno/Hazel | 455 | issue_to_patch | Set staticruntime to off in Glad project | Set staticruntime off. No issues yet with it being on but the rest of the projects are off. | 04ad1c897602f415e9ae51361ac180b20ad5a920 | 83d09080140878974a3456c9badaf54f6833848b | diff --git a/Hazel/vendor/Glad/premake5.lua b/Hazel/vendor/Glad/premake5.lua
index 5c87ad133..80ca10ab3 100644
--- a/Hazel/vendor/Glad/premake5.lua
+++ b/Hazel/vendor/Glad/premake5.lua
@@ -1,7 +1,7 @@
project "Glad"
kind "StaticLib"
language "C"
- staticruntime "on"
+ staticruntime "off"
tar... | [
"Hazel/vendor/Glad/premake5.lua"
] | [] | true | ||
TheCherno/Hazel | 462 | issue_to_patch | Fix typo in README | Just a little typo in README | 74e7ed1d04c028dd5390763da3202db11521ed01 | 2a962bf9be999d568252b3008ab40230281dfcea | diff --git a/README.md b/README.md
index e62b74ee8..840dba620 100644
--- a/README.md
+++ b/README.md
@@ -20,7 +20,7 @@ If the repository was cloned non-recursively previously, use `git submodule upda
1. Run the [Setup.bat](https://github.com/TheCherno/Hazel/blob/master/scripts/Setup.bat) file found in `scripts` folder... | [
"README.md"
] | [] | true | ||
TheCherno/Hazel | 464 | issue_to_patch | Edited texture.glsl to work properly with textures... | #### Describe the issue (if no issue has been made)
This is a pull for the latest game-engine-series video, which changes the shader in order to properly show textures that aren't the standard white!
#### PR impact _(Make sure to add [closing keywords](https://help.github.com/en/articles/closing-issues-using-keywor... | 99936f6128dded42f56d4cf38d592c248ed35577 | d204bb354ef7b9cafcfc33a0d9614bd16d3b29e9 | diff --git a/Hazelnut/assets/shaders/Texture.glsl b/Hazelnut/assets/shaders/Texture.glsl
index d6858cad6..20c1ff192 100644
--- a/Hazelnut/assets/shaders/Texture.glsl
+++ b/Hazelnut/assets/shaders/Texture.glsl
@@ -19,19 +19,19 @@ struct VertexOutput
{
vec4 Color;
vec2 TexCoord;
- float TexIndex;
float TilingFacto... | [
"Hazelnut/assets/shaders/Texture.glsl"
] | [] | true | ||
TheCherno/Hazel | 476 | issue_to_patch | yaml crash on fresh build: mismatch detected for 'RuntimeLibrary': value 'MTd_StaticDebug' doesn't match value 'MDd_DynamicDebug'.
Hey I am getting a bunch of errors in the Hazel Engine when I added Python and Vulkan I am Listing down some of these errors can someone help me in solving it
![image](https://user-images... | Update yaml-cpp submodule | #### Describe the issue
Clean checkout of Hazel does not build cleanly due to mismatch in CRT library settings
#### PR impact
List of related issues/PRs this will solve:
Impact | Issue/PR
------------------------ | ------
Issues this solves | #457
Other PRs this solves | None
##... | 74e7ed1d04c028dd5390763da3202db11521ed01 | 5121e1a8a8d2acf6fc05c7f8cb8f6f0183f79a5a | diff --git a/Hazel/vendor/yaml-cpp b/Hazel/vendor/yaml-cpp
index 3b3c66937..25be1f208 160000
--- a/Hazel/vendor/yaml-cpp
+++ b/Hazel/vendor/yaml-cpp
@@ -1,1 +1,1 @@
-Subproject commit 3b3c66937382f2be67da198da8c634dad853a93a
+Subproject commit 25be1f208665b9732ba40aa7b05ec2da97104192
| [
"Hazel/vendor/yaml-cpp"
] | [] | true | |
TheCherno/Hazel | 454 | issue_to_patch | Fixes so a fresh checkout of master compiles, Hazelnut and Sandbox both work | #### Describe the issue (if no issue has been made)
1) After the "new shader system" commit, Hazel does not compile cleanly after a fresh checkout from master.
2) Even supposing you can get it to compile, the Sandbox app does not render anything.
#### PR impact _(Make sure to add [closing keywords](https://help.g... | 2210e897005e96e39129cca068b5009acaeffa30 | 85574bf40d782148c3db216986998234d424bcb9 | diff --git a/Hazel/src/Hazel/Renderer/Renderer2D.cpp b/Hazel/src/Hazel/Renderer/Renderer2D.cpp
index 302d71bad..4f9c01c20 100644
--- a/Hazel/src/Hazel/Renderer/Renderer2D.cpp
+++ b/Hazel/src/Hazel/Renderer/Renderer2D.cpp
@@ -127,8 +127,8 @@ namespace Hazel {
{
HZ_PROFILE_FUNCTION();
- s_Data.TextureShader->Bind... | [
"Hazel/src/Hazel/Renderer/Renderer2D.cpp",
"Sandbox/assets/fonts/opensans/LICENSE.txt",
"Sandbox/assets/fonts/opensans/OpenSans-Bold.ttf",
"Sandbox/assets/fonts/opensans/OpenSans-BoldItalic.ttf",
"Sandbox/assets/fonts/opensans/OpenSans-ExtraBold.ttf",
"Sandbox/assets/fonts/opensans/OpenSans-ExtraBoldItali... | [] | true | ||
TheCherno/Hazel | 446 | issue_to_patch | Mentioned an installation instruction in README.md | #### Describe the issue
The README has instructions about cloning the repository and it's submodules. But it doesn't mention how to create a Visual Studio solution file. Earlier this wasn't the problem, because a single `.bat` file existed which can be executed.
With latest additions of SPIR-V, as of right now, the... | 63b23f702b8fad758d81f6490dfa842c62802cb7 | 2d91188d193a1a7c72501e221e7a1e5fd7205252 | diff --git a/README.md b/README.md
index 0e2a27af1..e62b74ee8 100644
--- a/README.md
+++ b/README.md
@@ -4,13 +4,28 @@
Hazel is primarily an early-stage interactive application and rendering engine for Windows. Currently not much is implemented, however (almost) everything inside this repository is being created wit... | [
"README.md"
] | [
{
"comment": "either use VulkanSDK or Vulkan SDK, but don't mix them, be consistent.",
"path": "README.md",
"hunk": "@@ -11,6 +11,25 @@ Start by cloning the repository with `git clone --recursive https://github.com/T\n \n If the repository was cloned non-recursively previously, use `git submodule update... | true | ||
TheCherno/Hazel | 446 | comment_to_fix | Mentioned an installation instruction in README.md | either use VulkanSDK or Vulkan SDK, but don't mix them, be consistent. | 63b23f702b8fad758d81f6490dfa842c62802cb7 | 2d91188d193a1a7c72501e221e7a1e5fd7205252 | diff --git a/README.md b/README.md
index 0e2a27af1..e62b74ee8 100644
--- a/README.md
+++ b/README.md
@@ -4,13 +4,28 @@
Hazel is primarily an early-stage interactive application and rendering engine for Windows. Currently not much is implemented, however (almost) everything inside this repository is being created wit... | [
"README.md"
] | [
{
"comment": "either use VulkanSDK or Vulkan SDK, but don't mix them, be consistent.",
"path": "README.md",
"hunk": "@@ -11,6 +11,25 @@ Start by cloning the repository with `git clone --recursive https://github.com/T\n \n If the repository was cloned non-recursively previously, use `git submodule update... | true | ||
TheCherno/Hazel | 446 | comment_to_fix | Mentioned an installation instruction in README.md | I would not specify what the script downloads, as this may change over time (think about downloading premake using the setup script).
```suggestion
1. Run the [Setup.bat](https://github.com/TheCherno/Hazel/blob/master/scripts/Setup.bat) file found in `scripts` folder. This will download the required prerequisites for... | 63b23f702b8fad758d81f6490dfa842c62802cb7 | 2d91188d193a1a7c72501e221e7a1e5fd7205252 | diff --git a/README.md b/README.md
index 0e2a27af1..e62b74ee8 100644
--- a/README.md
+++ b/README.md
@@ -4,13 +4,28 @@
Hazel is primarily an early-stage interactive application and rendering engine for Windows. Currently not much is implemented, however (almost) everything inside this repository is being created wit... | [
"README.md"
] | [
{
"comment": "I would not specify what the script downloads, as this may change over time (think about downloading premake using the setup script).\r\n```suggestion\r\n1. Run the [Setup.bat](https://github.com/TheCherno/Hazel/blob/master/scripts/Setup.bat) file found in `scripts` folder. This will download the ... | true | ||
TheCherno/Hazel | 446 | comment_to_fix | Mentioned an installation instruction in README.md | ```suggestion
## Getting Started
Visual Studio 2017 or 2019 is recommended, Hazel is officially untested on other development environments whilst we focus on a Windows build.
<ins>**1. Downloading the repository:**</ins>
Start by cloning the repository with `git clone --recursive https://github.com/TheCherno/Ha... | 63b23f702b8fad758d81f6490dfa842c62802cb7 | 2d91188d193a1a7c72501e221e7a1e5fd7205252 | diff --git a/README.md b/README.md
index 0e2a27af1..e62b74ee8 100644
--- a/README.md
+++ b/README.md
@@ -4,13 +4,28 @@
Hazel is primarily an early-stage interactive application and rendering engine for Windows. Currently not much is implemented, however (almost) everything inside this repository is being created wit... | [
"README.md"
] | [
{
"comment": "```suggestion\r\n## Getting Started\r\nVisual Studio 2017 or 2019 is recommended, Hazel is officially untested on other development environments whilst we focus on a Windows build.\r\n\r\n<ins>**1. Downloading the repository:**</ins>\r\n\r\nStart by cloning the repository with `git clone --recursi... | true | ||
TheCherno/Hazel | 449 | issue_to_patch | Build fails if Hazel folder path contains spaces (missing "")
When building with VisualStudio, project "Premake" build fails with this error:
```
5>Regenerating project files with Premake5!
5>'G:\Path' is not recognized as an internal or external command, operable program or batch file.
5>Microsoft.CppCommon.targe... | Updated premake post build to work with white spaces | #### Describe the issue
Paths with white spaces won't work unless the `%{prj.location}bin/premake5` are wrapped in `""` so that the command works properly
#### PR impact
List of related issues/PRs this will solve:
Impact | Issue/PR
------------------------ | ------
Issues this solves ... | 1747dce7ea3bd4013f80128ebbb3de7296a8b5d4 | 406d3dd260532edac67dc0f1515105cf73d265db | diff --git a/vendor/premake/premake5.lua b/vendor/premake/premake5.lua
index ab734b15f..15cf8219f 100644
--- a/vendor/premake/premake5.lua
+++ b/vendor/premake/premake5.lua
@@ -12,5 +12,5 @@ project "Premake"
postbuildmessage "Regenerating project files with Premake5!"
postbuildcommands
{
- "%{prj.location}bin/p... | [
"vendor/premake/premake5.lua"
] | [] | true | |
TheCherno/Hazel | 437 | issue_to_patch | The code execution cannot proceed because shaderc_sharedd.dll was not found
#### Error :- The code execution cannot proceed because shaderc_sharedd.dll was not found. Reinstalling the program may fix this problem
I was following the hazel series and i got this bug so i tried to download the solution from github an... | Added post-build commands for copying Vulkan .dlls to output directory | #### Describe the issue
After pulling the repository, if we try running Hazelnut, the application crashes because the required `.dll` files at `vendor\VulkanSDK\Bin` are not in proper place.
#### PR impact
List of related issues/PRs this will solve:
Impact | Issue/PR
------------------------ ... | 2210e897005e96e39129cca068b5009acaeffa30 | c8413b2e72ed60e5c91e52c2a58b4d063846eef4 | diff --git a/Dependencies.lua b/Dependencies.lua
index d2461c514..2b2817ce1 100644
--- a/Dependencies.lua
+++ b/Dependencies.lua
@@ -20,6 +20,7 @@ LibraryDir = {}
LibraryDir["VulkanSDK"] = "%{VULKAN_SDK}/Lib"
LibraryDir["VulkanSDK_Debug"] = "%{wks.location}/Hazel/vendor/VulkanSDK/Lib"
+LibraryDir["VulkanSDK_DebugDL... | [
"Dependencies.lua",
"Hazelnut/premake5.lua",
"Sandbox/premake5.lua"
] | [
{
"comment": "Doesn't this only need to be done for DEBUG build?\r\nFor the destination, does replacing `%{wks.location}/bin/\" .. outputdir .. \"/%{prj.name}` with `%{cfg.targetdir}` work? The latter is more succinct.",
"path": "Hazelnut/premake5.lua",
"hunk": "@@ -27,6 +27,11 @@ project \"Haze... | true | |
TheCherno/Hazel | 437 | comment_to_fix | Added post-build commands for copying Vulkan .dlls to output directory | Doesn't this only need to be done for DEBUG build?
For the destination, does replacing `%{wks.location}/bin/" .. outputdir .. "/%{prj.name}` with `%{cfg.targetdir}` work? The latter is more succinct. | 2210e897005e96e39129cca068b5009acaeffa30 | c8413b2e72ed60e5c91e52c2a58b4d063846eef4 | diff --git a/Hazelnut/premake5.lua b/Hazelnut/premake5.lua
index eb109f6d1..1f82742b8 100644
--- a/Hazelnut/premake5.lua
+++ b/Hazelnut/premake5.lua
@@ -35,6 +35,11 @@ project "Hazelnut"
defines "HZ_DEBUG"
runtime "Debug"
symbols "on"
+
+ postbuildcommands
+ {
+ "{COPYDIR} \"%{LibraryDir.VulkanSDK_DebugD... | [
"Hazelnut/premake5.lua"
] | [
{
"comment": "Doesn't this only need to be done for DEBUG build?\r\nFor the destination, does replacing `%{wks.location}/bin/\" .. outputdir .. \"/%{prj.name}` with `%{cfg.targetdir}` work? The latter is more succinct.",
"path": "Hazelnut/premake5.lua",
"hunk": "@@ -27,6 +27,11 @@ project \"Haze... | true | ||
TheCherno/Hazel | 437 | comment_to_fix | Added post-build commands for copying Vulkan .dlls to output directory | Might be better named VulkanSDK_DebugDLL (assuming the post build step only needs to be done for DEBUG build) | 2210e897005e96e39129cca068b5009acaeffa30 | c8413b2e72ed60e5c91e52c2a58b4d063846eef4 | diff --git a/Dependencies.lua b/Dependencies.lua
index d2461c514..2b2817ce1 100644
--- a/Dependencies.lua
+++ b/Dependencies.lua
@@ -20,6 +20,7 @@ LibraryDir = {}
LibraryDir["VulkanSDK"] = "%{VULKAN_SDK}/Lib"
LibraryDir["VulkanSDK_Debug"] = "%{wks.location}/Hazel/vendor/VulkanSDK/Lib"
+LibraryDir["VulkanSDK_DebugDL... | [
"Dependencies.lua"
] | [
{
"comment": "Might be better named VulkanSDK_DebugDLL (assuming the post build step only needs to be done for DEBUG build)",
"path": "Dependencies.lua",
"hunk": "@@ -20,6 +20,7 @@ LibraryDir = {}\n \n LibraryDir[\"VulkanSDK\"] = \"%{VULKAN_SDK}/Lib\"\n LibraryDir[\"VulkanSDK_Debug\"] = \"%{wks.locati... | true | ||
TheCherno/Hazel | 441 | issue_to_patch | Add python scripts to install Premake | #### Describe the issue (if no issue has been made)
This PR doesn't fix any issue.
This PR adds a python script to check and automatically download Premake5.exe if the file is not presented.
#### PR impact
List of related issues/PRs this will solve:
Impact | Issue/PR
------------------------... | 93eef739adc2cc862a20e66dc2aad8739502d585 | a298272209b803949de8a6e5885498336acc2f77 | diff --git a/.gitignore b/.gitignore
index 77c158480..cad34d1ac 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,6 +1,5 @@
# Binaries
**/bin/
-!vendor/premake/bin/
bin-int/
# Hazel files
diff --git a/Hazel/src/Hazel/ImGui/ImGuiLayer.h b/Hazel/src/Hazel/ImGui/ImGuiLayer.h
index 571cea8b2..7c8959de1 100644
--- a/Haze... | [
".gitignore",
"Hazel/src/Hazel/ImGui/ImGuiLayer.h",
"Hazel/src/Hazel/Utils/PlatformUtils.h",
"scripts/CheckPython.py",
"scripts/Setup.py",
"scripts/SetupPremake.py",
"scripts/SetupPython.py",
"scripts/SetupVulkan.py",
"scripts/Utils.py",
"scripts/Vulkan.py",
"vendor/premake/bin/LICENSE.txt",
"... | [
{
"comment": "You did update the gitignore to ignore changes in the `vendor/premake/bin/` folder, which is good...\r\n\r\nHowever, by doing so, the actual [`premake.exe`](https://github.com/3x3y3z3t/Hazel/blob/automate-premake-install/vendor/premake/bin/premake5.exe) and [`LICENSE.txt`](https://github.com/3x3y3... | true | ||
TheCherno/Hazel | 441 | comment_to_fix | Add python scripts to install Premake | You did update the gitignore to ignore changes in the `vendor/premake/bin/` folder, which is good...
However, by doing so, the actual [`premake.exe`](https://github.com/3x3y3z3t/Hazel/blob/automate-premake-install/vendor/premake/bin/premake5.exe) and [`LICENSE.txt`](https://github.com/3x3y3z3t/Hazel/blob/automate-pr... | 93eef739adc2cc862a20e66dc2aad8739502d585 | a298272209b803949de8a6e5885498336acc2f77 | diff --git a/.gitignore b/.gitignore
index 77c158480..cad34d1ac 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,6 +1,5 @@
# Binaries
**/bin/
-!vendor/premake/bin/
bin-int/
# Hazel files
| [
".gitignore"
] | [
{
"comment": "You did update the gitignore to ignore changes in the `vendor/premake/bin/` folder, which is good...\r\n\r\nHowever, by doing so, the actual [`premake.exe`](https://github.com/3x3y3z3t/Hazel/blob/automate-premake-install/vendor/premake/bin/premake5.exe) and [`LICENSE.txt`](https://github.com/3x3y3... | true | ||
TheCherno/Hazel | 441 | comment_to_fix | Add python scripts to install Premake | There is an option to actually install the premake.exe file, however, since it is still alpha, we opted to only download the exe file and just use it without installing it. For this reason I would suggest to change the wording `install` to `download`.
Also found a small typo `Preamake` --> `Premake`.
```suggestio... | 93eef739adc2cc862a20e66dc2aad8739502d585 | a298272209b803949de8a6e5885498336acc2f77 | diff --git a/scripts/SetupPremake.py b/scripts/SetupPremake.py
new file mode 100644
index 000000000..729c489e5
--- /dev/null
+++ b/scripts/SetupPremake.py
@@ -0,0 +1,51 @@
+import sys
+import os
+from pathlib import Path
+
+import Utils
+
+class PremakeConfiguration:
+ premakeVersion = "5.0.0-alpha16"
+ premakeZi... | [
"scripts/SetupPremake.py"
] | [
{
"comment": "There is an option to actually install the premake.exe file, however, since it is still alpha, we opted to only download the exe file and just use it without installing it. For this reason I would suggest to change the wording `install` to `download`.\r\n\r\nAlso found a small typo `Preamake` --> ... | true | ||
TheCherno/Hazel | 441 | comment_to_fix | Add python scripts to install Premake | By defining both a version and an url, you kinda define the version twice (once in the version, once in the url). I suggest only defining the version in the version variable for consistency. as the `premakeVersion` is only used for display to the user, while the `premakeZipUrls` is used for the download process.
```... | 93eef739adc2cc862a20e66dc2aad8739502d585 | a298272209b803949de8a6e5885498336acc2f77 | diff --git a/scripts/SetupPremake.py b/scripts/SetupPremake.py
new file mode 100644
index 000000000..729c489e5
--- /dev/null
+++ b/scripts/SetupPremake.py
@@ -0,0 +1,51 @@
+import sys
+import os
+from pathlib import Path
+
+import Utils
+
+class PremakeConfiguration:
+ premakeVersion = "5.0.0-alpha16"
+ premakeZi... | [
"scripts/SetupPremake.py"
] | [
{
"comment": "By defining both a version and an url, you kinda define the version twice (once in the version, once in the url). I suggest only defining the version in the version variable for consistency. as the `premakeVersion` is only used for display to the user, while the `premakeZipUrls` is used for the do... | true | ||
TheCherno/Hazel | 441 | comment_to_fix | Add python scripts to install Premake | I do like that you use the same way of downloading/unzipping the files. However, it would be nice to have some feedback to the user about the 'progress'. I know premake is 'small', but even on a slow internet connection, this could take a few seconds. I suggest to:
1. Download the ZIP onto the bin directory using `Uti... | 93eef739adc2cc862a20e66dc2aad8739502d585 | a298272209b803949de8a6e5885498336acc2f77 | diff --git a/scripts/SetupPremake.py b/scripts/SetupPremake.py
new file mode 100644
index 000000000..729c489e5
--- /dev/null
+++ b/scripts/SetupPremake.py
@@ -0,0 +1,51 @@
+import sys
+import os
+from pathlib import Path
+
+import Utils
+
+class PremakeConfiguration:
+ premakeVersion = "5.0.0-alpha16"
+ premakeZi... | [
"scripts/SetupPremake.py"
] | [
{
"comment": "I do like that you use the same way of downloading/unzipping the files. However, it would be nice to have some feedback to the user about the 'progress'. I know premake is 'small', but even on a slow internet connection, this could take a few seconds. I suggest to:\r\n1. Download the ZIP onto the ... | true | ||
TheCherno/Hazel | 441 | comment_to_fix | Add python scripts to install Premake | In addition of downloading the exe file, we should also download the license file as we did, in order to stay consistent with how the repo looks after running Setup. | 93eef739adc2cc862a20e66dc2aad8739502d585 | a298272209b803949de8a6e5885498336acc2f77 | diff --git a/scripts/SetupPremake.py b/scripts/SetupPremake.py
new file mode 100644
index 000000000..729c489e5
--- /dev/null
+++ b/scripts/SetupPremake.py
@@ -0,0 +1,51 @@
+import sys
+import os
+from pathlib import Path
+
+import Utils
+
+class PremakeConfiguration:
+ premakeVersion = "5.0.0-alpha16"
+ premakeZi... | [
"scripts/SetupPremake.py"
] | [
{
"comment": "In addition of downloading the exe file, we should also download the license file as we did, in order to stay consistent with how the repo looks after running Setup.",
"path": "scripts/SetupPremake.py",
"hunk": "@@ -0,0 +1,45 @@\n+import sys\n+import subprocess\n+import platform\n+from pat... | true | ||
TheCherno/Hazel | 441 | comment_to_fix | Add python scripts to install Premake | Consistency with other downloads should state the location
```suggestion
print(f"Correct Premake located at {os.path.abspath(premakeDirectory)}")
``` | 93eef739adc2cc862a20e66dc2aad8739502d585 | a298272209b803949de8a6e5885498336acc2f77 | diff --git a/scripts/SetupPremake.py b/scripts/SetupPremake.py
new file mode 100644
index 000000000..729c489e5
--- /dev/null
+++ b/scripts/SetupPremake.py
@@ -0,0 +1,51 @@
+import sys
+import os
+from pathlib import Path
+
+import Utils
+
+class PremakeConfiguration:
+ premakeVersion = "5.0.0-alpha16"
+ premakeZi... | [
"scripts/SetupPremake.py"
] | [
{
"comment": "Consistency with other downloads should state the location\r\n\r\n\r\n```suggestion\r\n print(f\"Correct Premake located at {os.path.abspath(premakeDirectory)}\")\r\n```",
"pat... | true | ||
TheCherno/Hazel | 441 | comment_to_fix | Add python scripts to install Premake | If we want to go 100% for consistency, the permission should be asked in `InstallPremake` while `CheckIfPremakeInstalled` should determine and inform if premake is installed or not. | 93eef739adc2cc862a20e66dc2aad8739502d585 | a298272209b803949de8a6e5885498336acc2f77 | diff --git a/scripts/SetupPremake.py b/scripts/SetupPremake.py
new file mode 100644
index 000000000..729c489e5
--- /dev/null
+++ b/scripts/SetupPremake.py
@@ -0,0 +1,51 @@
+import sys
+import os
+from pathlib import Path
+
+import Utils
+
+class PremakeConfiguration:
+ premakeVersion = "5.0.0-alpha16"
+ premakeZi... | [
"scripts/SetupPremake.py"
] | [
{
"comment": "If we want to go 100% for consistency, the permission should be asked in `InstallPremake` while `CheckIfPremakeInstalled` should determine and inform if premake is installed or not.",
"path": "scripts/SetupPremake.py",
"hunk": "@@ -0,0 +1,45 @@\n+import sys\n+import subprocess\n+import pla... | true | ||
TheCherno/Hazel | 441 | comment_to_fix | Add python scripts to install Premake | If you look at the current state of the [`license.txt`](https://github.com/TheCherno/Hazel/blob/b29332e58962fb75e2e61f16e301f124cc88fac4/vendor/premake/bin/LICENSE.txt) file, you'll see that it downloaded the actual github page rather than the txt file. This is easily resolved by changing the `premakeLicenseUrl` to the... | 93eef739adc2cc862a20e66dc2aad8739502d585 | a298272209b803949de8a6e5885498336acc2f77 | diff --git a/scripts/SetupPremake.py b/scripts/SetupPremake.py
new file mode 100644
index 000000000..729c489e5
--- /dev/null
+++ b/scripts/SetupPremake.py
@@ -0,0 +1,51 @@
+import sys
+import os
+from pathlib import Path
+
+import Utils
+
+class PremakeConfiguration:
+ premakeVersion = "5.0.0-alpha16"
+ premakeZi... | [
"scripts/SetupPremake.py"
] | [
{
"comment": "If you look at the current state of the [`license.txt`](https://github.com/TheCherno/Hazel/blob/b29332e58962fb75e2e61f16e301f124cc88fac4/vendor/premake/bin/LICENSE.txt) file, you'll see that it downloaded the actual github page rather than the txt file. This is easily resolved by changing the `pre... | true | ||
TheCherno/Hazel | 441 | comment_to_fix | Add python scripts to install Premake | I think what you did here (and similar for premake.exe), you did run the script and then committed the changes. Rather than doing that, you should delete the bin directory completely, that way these files will be **deleted** rather than **updated** to the latest version. The premake script is there to download these fi... | 93eef739adc2cc862a20e66dc2aad8739502d585 | a298272209b803949de8a6e5885498336acc2f77 | diff --git a/vendor/premake/bin/LICENSE.txt b/vendor/premake/bin/LICENSE.txt
deleted file mode 100644
index 66c3ad6fc..000000000
--- a/vendor/premake/bin/LICENSE.txt
+++ /dev/null
@@ -1,27 +0,0 @@
-Copyright (c) 2003-2016 Jason Perkins and individual contributors.
-All rights reserved.
-
-Redistribution and use in sour... | [
"vendor/premake/bin/LICENSE.txt"
] | [
{
"comment": "I think what you did here (and similar for premake.exe), you did run the script and then committed the changes. Rather than doing that, you should delete the bin directory completely, that way these files will be **deleted** rather than **updated** to the latest version. The premake script is ther... | true | ||
TheCherno/Hazel | 441 | comment_to_fix | Add python scripts to install Premake | Due to the small file size of license.txt I ran into a small error, which I already fixed in the unzip function, but now also rises in the download function:
1. Due to the small file size, there is an issue as downloaded > total (due to rounding), which can even become 0 in some cases
2. Because of a decent downloa... | 93eef739adc2cc862a20e66dc2aad8739502d585 | a298272209b803949de8a6e5885498336acc2f77 | diff --git a/scripts/Utils.py b/scripts/Utils.py
index 7022e7979..c88861255 100644
--- a/scripts/Utils.py
+++ b/scripts/Utils.py
@@ -1,13 +1,56 @@
-import requests
import sys
+import os
+import winreg
+
+import requests
import time
+import urllib
+
+from zipfile import ZipFile
+
+def GetSystemEnvironmentVariable(name... | [
"scripts/Utils.py"
] | [
{
"comment": "Due to the small file size of license.txt I ran into a small error, which I already fixed in the unzip function, but now also rises in the download function:\r\n\r\n1. Due to the small file size, there is an issue as downloaded > total (due to rounding), which can even become 0 in some cases\r\n2.... | true | ||
TheCherno/Hazel | 441 | comment_to_fix | Add python scripts to install Premake | Found another copy paste error (I swear this is the last one)
```suggestion
print("Downloading {0:s} to {1:s}".format(cls.premakeLicenseUrl, premakeLicensePath))
``` | 93eef739adc2cc862a20e66dc2aad8739502d585 | a298272209b803949de8a6e5885498336acc2f77 | diff --git a/scripts/SetupPremake.py b/scripts/SetupPremake.py
new file mode 100644
index 000000000..729c489e5
--- /dev/null
+++ b/scripts/SetupPremake.py
@@ -0,0 +1,51 @@
+import sys
+import os
+from pathlib import Path
+
+import Utils
+
+class PremakeConfiguration:
+ premakeVersion = "5.0.0-alpha16"
+ premakeZi... | [
"scripts/SetupPremake.py"
] | [
{
"comment": "Found another copy paste error (I swear this is the last one)\r\n```suggestion\r\n print(\"Downloading {0:s} to {1:s}\".format(cls.premakeLicenseUrl, premakeLicensePath))\r\n```",
"path": "scripts/SetupPremake.py",
"hunk": "@@ -0,0 +1,51 @@\n+import sys\n+import os\n+from pathlib im... | true | ||
TheCherno/Hazel | 447 | issue_to_patch | Removed debug non-working URL from URL list | #### Describe the issue
In PR #438, which got merged, the Python setup scripts got completely reworked, courtesy of @LovelySanta .
One of the features was, the `DownloadFile()` function of `Utils.py` class also accepts a list of URLs to process through.
One of the URLs is a test URL (the 1st one in the list), which ... | d39b736a73d5f31c02f498089db52817ad7aa0a4 | e03b5c63e1d2d2fbbc5f4b24115bc37befda4bfc | diff --git a/scripts/SetupVulkan.py b/scripts/SetupVulkan.py
index c9f004a07..49d2dfbdc 100644
--- a/scripts/SetupVulkan.py
+++ b/scripts/SetupVulkan.py
@@ -62,10 +62,8 @@ def CheckVulkanSDKDebugLibs(cls):
shadercdLib = Path(f"{cls.vulkanDirectory}/Lib/shaderc_sharedd.lib")
VulkanSDKDebugLib... | [
"scripts/SetupVulkan.py"
] | [] | true | ||
TheCherno/Hazel | 438 | issue_to_patch | VulkanSDK directory will be created if it doesn't exist + more Setup features | #### Describe the issue
When running `Setup.bat` file for the first time, it will throw the following error -
```
FileNotFoundError: [Errno 2] No such file or directory
```
That's because since there's no directory named 'VulkanSDK' which exists in the 'vendor' folder, as well as there's no provision in the curren... | 93eef739adc2cc862a20e66dc2aad8739502d585 | d38835bb6f51ce317ea39aa109a55efb0fa3e1a4 | diff --git a/scripts/CheckPython.py b/scripts/CheckPython.py
deleted file mode 100644
index 683e298ed..000000000
--- a/scripts/CheckPython.py
+++ /dev/null
@@ -1,18 +0,0 @@
-import subprocess
-import pkg_resources
-
-def install(package):
- print(f"Installing {package} module...")
- subprocess.check_call(['python... | [
"scripts/CheckPython.py",
"scripts/Setup.py",
"scripts/SetupPython.py",
"scripts/SetupVulkan.py",
"scripts/Utils.py",
"scripts/Vulkan.py"
] | [
{
"comment": "This should be changed to ``Hazel/vendor/VulkanSDK``",
"path": "scripts/Vulkan.py",
"hunk": "@@ -12,10 +12,12 @@\n VULKAN_SDK = os.environ.get('VULKAN_SDK')\n VULKAN_SDK_INSTALLER_URL = 'https://sdk.lunarg.com/sdk/download/1.2.170.0/windows/vulkan_sdk.exe'\n HAZEL_VULKAN_VERSION = '1.2.170... | true | ||
TheCherno/Hazel | 438 | comment_to_fix | VulkanSDK directory will be created if it doesn't exist + more Setup features | This should be changed to ``Hazel/vendor/VulkanSDK`` | 93eef739adc2cc862a20e66dc2aad8739502d585 | d38835bb6f51ce317ea39aa109a55efb0fa3e1a4 | diff --git a/scripts/Vulkan.py b/scripts/Vulkan.py
deleted file mode 100644
index 4133f5c38..000000000
--- a/scripts/Vulkan.py
+++ /dev/null
@@ -1,60 +0,0 @@
-import os
-import subprocess
-import sys
-from pathlib import Path
-
-import Utils
-
-from io import BytesIO
-from urllib.request import urlopen
-from zipfile im... | [
"scripts/Vulkan.py"
] | [
{
"comment": "This should be changed to ``Hazel/vendor/VulkanSDK``",
"path": "scripts/Vulkan.py",
"hunk": "@@ -12,10 +12,12 @@\n VULKAN_SDK = os.environ.get('VULKAN_SDK')\n VULKAN_SDK_INSTALLER_URL = 'https://sdk.lunarg.com/sdk/download/1.2.170.0/windows/vulkan_sdk.exe'\n HAZEL_VULKAN_VERSION = '1.2.170... | true | ||
TheCherno/Hazel | 438 | comment_to_fix | VulkanSDK directory will be created if it doesn't exist + more Setup features | Derive `VULKAN_SDK_EXE_DIR` from `VULKAN_SDK_EXE_PATH`
```suggestion
VULKAN_SDK_EXE_PATH = 'Hazel/vendor/VulkanSDK/VulkanSDK.exe'
def InstallVulkanSDK():
print('Downloading {} to {}'.format(VULKAN_SDK_INSTALLER_URL, VULKAN_SDK_EXE_PATH))
os.makedirs(os.path.dirname(VULKAN_SDK_EXE_PATH), exist_ok=True)
`... | 93eef739adc2cc862a20e66dc2aad8739502d585 | d38835bb6f51ce317ea39aa109a55efb0fa3e1a4 | diff --git a/scripts/Vulkan.py b/scripts/Vulkan.py
deleted file mode 100644
index 4133f5c38..000000000
--- a/scripts/Vulkan.py
+++ /dev/null
@@ -1,60 +0,0 @@
-import os
-import subprocess
-import sys
-from pathlib import Path
-
-import Utils
-
-from io import BytesIO
-from urllib.request import urlopen
-from zipfile im... | [
"scripts/Vulkan.py"
] | [
{
"comment": "Derive `VULKAN_SDK_EXE_DIR` from `VULKAN_SDK_EXE_PATH`\r\n```suggestion\r\nVULKAN_SDK_EXE_PATH = 'Hazel/vendor/VulkanSDK/VulkanSDK.exe'\r\n\r\ndef InstallVulkanSDK():\r\n print('Downloading {} to {}'.format(VULKAN_SDK_INSTALLER_URL, VULKAN_SDK_EXE_PATH))\r\n os.makedirs(os.path.dirname(VULKA... | true | ||
TheCherno/Hazel | 438 | comment_to_fix | VulkanSDK directory will be created if it doesn't exist + more Setup features | hazel version requires to be defined first
```suggestion
HAZEL_VULKAN_VERSION = '1.2.170.0'
VULKAN_SDK_INSTALLER_URL = f"https://sdk.lunarg.com/sdk/download/{HAZEL_VULKAN_VERSION}/windows/VulkanSDK-{HAZEL_VULKAN_VERSION}-Installer.exe"
``` | 93eef739adc2cc862a20e66dc2aad8739502d585 | d38835bb6f51ce317ea39aa109a55efb0fa3e1a4 | diff --git a/scripts/Vulkan.py b/scripts/Vulkan.py
deleted file mode 100644
index 4133f5c38..000000000
--- a/scripts/Vulkan.py
+++ /dev/null
@@ -1,60 +0,0 @@
-import os
-import subprocess
-import sys
-from pathlib import Path
-
-import Utils
-
-from io import BytesIO
-from urllib.request import urlopen
-from zipfile im... | [
"scripts/Vulkan.py"
] | [
{
"comment": "hazel version requires to be defined first\r\n```suggestion\r\nHAZEL_VULKAN_VERSION = '1.2.170.0'\r\nVULKAN_SDK_INSTALLER_URL = f\"https://sdk.lunarg.com/sdk/download/{HAZEL_VULKAN_VERSION}/windows/VulkanSDK-{HAZEL_VULKAN_VERSION}-Installer.exe\"\r\n```",
"path": "scripts/Vulkan.py",
"hunk... | true | ||
TheCherno/Hazel | 438 | comment_to_fix | VulkanSDK directory will be created if it doesn't exist + more Setup features | @LovelySanta Just checked, this link doesn't download the files. Instead it throws a HTTP Error 403. I guess this needs to be reverted back to Cherno's link. | 93eef739adc2cc862a20e66dc2aad8739502d585 | d38835bb6f51ce317ea39aa109a55efb0fa3e1a4 | diff --git a/scripts/Vulkan.py b/scripts/Vulkan.py
deleted file mode 100644
index 4133f5c38..000000000
--- a/scripts/Vulkan.py
+++ /dev/null
@@ -1,60 +0,0 @@
-import os
-import subprocess
-import sys
-from pathlib import Path
-
-import Utils
-
-from io import BytesIO
-from urllib.request import urlopen
-from zipfile im... | [
"scripts/Vulkan.py"
] | [
{
"comment": "@LovelySanta Just checked, this link doesn't download the files. Instead it throws a HTTP Error 403. I guess this needs to be reverted back to Cherno's link.",
"path": "scripts/Vulkan.py",
"hunk": "@@ -43,7 +44,7 @@ def CheckVulkanSDK():\n print(f\"Correct Vulkan SDK located at {VULKAN... | true | ||
TheCherno/Hazel | 438 | comment_to_fix | VulkanSDK directory will be created if it doesn't exist + more Setup features | Some minor debug things were still in place
```suggestion
if not shadercdLib.exists():
``` | 93eef739adc2cc862a20e66dc2aad8739502d585 | d38835bb6f51ce317ea39aa109a55efb0fa3e1a4 | diff --git a/scripts/SetupVulkan.py b/scripts/SetupVulkan.py
new file mode 100644
index 000000000..c9f004a07
--- /dev/null
+++ b/scripts/SetupVulkan.py
@@ -0,0 +1,83 @@
+import os
+import sys
+import subprocess
+from pathlib import Path
+
+import Utils
+
+from io import BytesIO
+from urllib.request import urlopen
+
+cl... | [
"scripts/SetupVulkan.py"
] | [
{
"comment": "Some minor debug things were still in place\r\n```suggestion\r\n if not shadercdLib.exists():\r\n```",
"path": "scripts/SetupVulkan.py",
"hunk": "@@ -0,0 +1,77 @@\n+import os\n+import sys\n+import subprocess\n+from pathlib import Path\n+\n+import Utils\n+\n+from io import BytesIO\n+... | true | ||
TheCherno/Hazel | 436 | issue_to_patch | Removed unnecessary header file | #### Describe the issue
In the latest commit, which saw the introduction of SPIR-V shader pipeline, the `std::optional<>` part in `PlatformUtils.h` is removed, but not the corresponding include file.
#### PR impact
List of related issues/PRs this will solve:
Impact | Issue/PR
----------------... | 93eef739adc2cc862a20e66dc2aad8739502d585 | 62238c2bacb6869a723df041dfeeb6da6f0c7b86 | diff --git a/Hazel/src/Hazel/Utils/PlatformUtils.h b/Hazel/src/Hazel/Utils/PlatformUtils.h
index b8b47c36d..4ce2a5183 100644
--- a/Hazel/src/Hazel/Utils/PlatformUtils.h
+++ b/Hazel/src/Hazel/Utils/PlatformUtils.h
@@ -1,7 +1,6 @@
#pragma once
#include <string>
-#include <optional>
namespace Hazel {
| [
"Hazel/src/Hazel/Utils/PlatformUtils.h"
] | [] | true | ||
TheCherno/Hazel | 432 | issue_to_patch | Removed 'm_Time' in ImGuiLayer | Removed the variable 'm_Time' because it is no longer used in 'ImGuiLayer.cpp'. | a16f605b3aa82ecf1c47ebd5d505127de81028f2 | 691b4aa3db1438047ff67a20e9733a3d3137c7b2 | diff --git a/Hazel/src/Hazel/ImGui/ImGuiLayer.h b/Hazel/src/Hazel/ImGui/ImGuiLayer.h
index 571cea8b2..7c8959de1 100644
--- a/Hazel/src/Hazel/ImGui/ImGuiLayer.h
+++ b/Hazel/src/Hazel/ImGui/ImGuiLayer.h
@@ -26,7 +26,6 @@ namespace Hazel {
void SetDarkThemeColors();
private:
bool m_BlockEvents = true;
- float m_T... | [
"Hazel/src/Hazel/ImGui/ImGuiLayer.h"
] | [] | true | ||
TheCherno/Hazel | 247 | issue_to_patch | sampler2D should not use vertex attribute as index
#### Describe the bug
*Credit to @KronosB#2408 (discord)*
Some people have been complaining about some visual glitches (see picture) on textures. Recently another report [on trello](https://trello.com/c/dTDRRXUU) came in where it did only render black triangles.
... | Branching instead of indexing the texture sampler | #### Describe the issue (if no issue has been made)
As stated in #238, the texture sampler can only be indexed with a dynamically uniform integral expression. Not doing so results in quads rendering black instead of rendering textures on certain systems.
#### PR impact _(Make sure to add [closing keywords](https://... | 5389cf65333a18a374f95b74ba0878202a5ed08b | a9abe4b3fa3e1f9a8f7cc097f9c50dc5051ea13d | diff --git a/Sandbox/assets/shaders/Texture.glsl b/Sandbox/assets/shaders/Texture.glsl
index 938711d03..4415ae98c 100644
--- a/Sandbox/assets/shaders/Texture.glsl
+++ b/Sandbox/assets/shaders/Texture.glsl
@@ -39,5 +39,40 @@ uniform sampler2D u_Textures[32];
void main()
{
- color = texture(u_Textures[int(v_TexIndex)... | [
"Sandbox/assets/shaders/Texture.glsl"
] | [] | true | |
TheCherno/Hazel | 165 | issue_to_patch | Code maintenance | #### Describe the issue (if no issue has been made)
Code maintenance of things Cherno did start but not finish or mensioned before but did not do in the code maintenance video.
#### PR impact _(Make sure to add [closing keywords](https://help.github.com/en/articles/closing-issues-using-keywords))_
List of related ... | 8c35857cc442706ec0196d0298fefa11dfcbe0bf | f1676f4378d5c57018bc5c598a8e7437200e6ba4 | diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index e0c9abd42..729405fd8 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -1,9 +1,3 @@
----
-name: 'Pull Request'
-about: Propose a fix for a (small) issue in Hazel
-
----
-
#### Describe the issue... | [
".github/PULL_REQUEST_TEMPLATE.md",
"Hazel/src/Hazel.h",
"Hazel/src/Hazel/Core/Application.cpp",
"Hazel/src/Hazel/Core/Application.h",
"Hazel/src/Hazel/Core/Core.h",
"Hazel/src/Hazel/Core/EntryPoint.h",
"Hazel/src/Hazel/Core/Input.h",
"Hazel/src/Hazel/Core/Layer.cpp",
"Hazel/src/Hazel/Core/Layer.h",... | [
{
"comment": "We should discuss what should we name the `Core.h` file. Cherno did say he named it `Base.h` in his Hazel-dev repository, so we should apply that to here. Makes more sense.",
"path": "Hazel/src/Hazel.h",
"hunk": "@@ -2,6 +2,8 @@\n \n // For use by Hazel applications\n \n+#include \"Hazel/C... | true | ||
TheCherno/Hazel | 165 | comment_to_fix | Code maintenance | We should discuss what should we name the `Core.h` file. Cherno did say he named it `Base.h` in his Hazel-dev repository, so we should apply that to here. Makes more sense. | 8c35857cc442706ec0196d0298fefa11dfcbe0bf | f1676f4378d5c57018bc5c598a8e7437200e6ba4 | diff --git a/Hazel/src/Hazel.h b/Hazel/src/Hazel.h
index a04221b76..f8ba6b44b 100644
--- a/Hazel/src/Hazel.h
+++ b/Hazel/src/Hazel.h
@@ -2,6 +2,8 @@
// For use by Hazel applications
+#include "Hazel/Core/Core.h"
+
#include "Hazel/Core/Application.h"
#include "Hazel/Core/Layer.h"
#include "Hazel/Core/Log.h"
| [
"Hazel/src/Hazel.h"
] | [
{
"comment": "We should discuss what should we name the `Core.h` file. Cherno did say he named it `Base.h` in his Hazel-dev repository, so we should apply that to here. Makes more sense.",
"path": "Hazel/src/Hazel.h",
"hunk": "@@ -2,6 +2,8 @@\n \n // For use by Hazel applications\n \n+#include \"Hazel/C... | true | ||
TheCherno/Hazel | 165 | comment_to_fix | Code maintenance | Does Cherno really want go static-lib with his game engine? | 8c35857cc442706ec0196d0298fefa11dfcbe0bf | f1676f4378d5c57018bc5c598a8e7437200e6ba4 | diff --git a/Hazel/src/Hazel/Core/Core.h b/Hazel/src/Hazel/Core/Core.h
index c7e224263..989b9de36 100644
--- a/Hazel/src/Hazel/Core/Core.h
+++ b/Hazel/src/Hazel/Core/Core.h
@@ -43,22 +43,6 @@
#error "Unknown platform!"
#endif // End of platform detection
-
-// DLL support
-#ifdef HZ_PLATFORM_WINDOWS
- #if HZ_DYNAM... | [
"Hazel/src/Hazel/Core/Core.h"
] | [
{
"comment": "Does Cherno really want go static-lib with his game engine?",
"path": "Hazel/src/Hazel/Core/Core.h",
"hunk": "@@ -43,22 +43,6 @@\n \t#error \"Unknown platform!\"\n #endif // End of platform detection\n \n-\n-// DLL support\n-#ifdef HZ_PLATFORM_WINDOWS",
"resolving_sha": "f1676f4378d5c5... | true | ||
TheCherno/Hazel | 165 | comment_to_fix | Code maintenance | I remember that Cherno wanted full control over when application gets closed. | 8c35857cc442706ec0196d0298fefa11dfcbe0bf | f1676f4378d5c57018bc5c598a8e7437200e6ba4 | diff --git a/Hazel/src/Hazel/Core/EntryPoint.h b/Hazel/src/Hazel/Core/EntryPoint.h
index a257abdbd..de69dbad5 100644
--- a/Hazel/src/Hazel/Core/EntryPoint.h
+++ b/Hazel/src/Hazel/Core/EntryPoint.h
@@ -1,4 +1,5 @@
#pragma once
+#include "Hazel/Core/Core.h"
#ifdef HZ_PLATFORM_WINDOWS
@@ -16,4 +17,4 @@ int main(int ... | [
"Hazel/src/Hazel/Core/EntryPoint.h"
] | [
{
"comment": "I remember that Cherno wanted full control over when application gets closed.",
"path": "Hazel/src/Hazel/Core/EntryPoint.h",
"hunk": "@@ -1,8 +1,9 @@\n #pragma once\n+#include \"Hazel/Core/Core.h\"\n \n #ifdef HZ_PLATFORM_WINDOWS\n \n-extern Hazel::Application* Hazel::CreateApplication();\... | true | ||
TheCherno/Hazel | 165 | comment_to_fix | Code maintenance | Same thing. | 8c35857cc442706ec0196d0298fefa11dfcbe0bf | f1676f4378d5c57018bc5c598a8e7437200e6ba4 | diff --git a/Sandbox/src/SandboxApp.cpp b/Sandbox/src/SandboxApp.cpp
index d7cac4dda..52cb51707 100644
--- a/Sandbox/src/SandboxApp.cpp
+++ b/Sandbox/src/SandboxApp.cpp
@@ -1,9 +1,7 @@
#include <Hazel.h>
#include <Hazel/Core/EntryPoint.h>
-#include "Platform/OpenGL/OpenGLShader.h"
-
-#include "imgui/imgui.h"
+#incl... | [
"Sandbox/src/SandboxApp.cpp"
] | [
{
"comment": "Same thing.",
"path": "Sandbox/src/SandboxApp.cpp",
"hunk": "@@ -218,7 +215,7 @@ class Sandbox : public Hazel::Application\n \t}\n };\n \n-Hazel::Application* Hazel::CreateApplication()\n+Hazel::Scope<Hazel::Application> Hazel::CreateApplication()\n {\n-\treturn new Sandbox();\n+\treturn H... | true | ||
TheCherno/Hazel | 165 | comment_to_fix | Code maintenance | Convert spaces to tabs
```suggestion
delete app;
``` | 8c35857cc442706ec0196d0298fefa11dfcbe0bf | f1676f4378d5c57018bc5c598a8e7437200e6ba4 | diff --git a/Hazel/src/Hazel/Core/EntryPoint.h b/Hazel/src/Hazel/Core/EntryPoint.h
index a257abdbd..de69dbad5 100644
--- a/Hazel/src/Hazel/Core/EntryPoint.h
+++ b/Hazel/src/Hazel/Core/EntryPoint.h
@@ -1,4 +1,5 @@
#pragma once
+#include "Hazel/Core/Core.h"
#ifdef HZ_PLATFORM_WINDOWS
@@ -16,4 +17,4 @@ int main(int ... | [
"Hazel/src/Hazel/Core/EntryPoint.h"
] | [
{
"comment": "Convert spaces to tabs\r\n```suggestion\r\n\tdelete app;\r\n```",
"path": "Hazel/src/Hazel/Core/EntryPoint.h",
"hunk": "@@ -13,7 +14,7 @@ int main(int argc, char** argv)\n \n \tauto app = Hazel::CreateApplication();\n \tapp->Run();\n-\tdelete app;\n+ delete app;",
"resolving_sha": "... | true | ||
TheCherno/Hazel | 165 | comment_to_fix | Code maintenance | Should @TheCherno cover/mention this in a video? Since it's introducing a new file to the project. | 8c35857cc442706ec0196d0298fefa11dfcbe0bf | f1676f4378d5c57018bc5c598a8e7437200e6ba4 | diff --git a/Hazel/src/Hazel/Renderer/GraphicsContext.cpp b/Hazel/src/Hazel/Renderer/GraphicsContext.cpp
new file mode 100644
index 000000000..7dae467c8
--- /dev/null
+++ b/Hazel/src/Hazel/Renderer/GraphicsContext.cpp
@@ -0,0 +1,21 @@
+#include "hzpch.h"
+#include "Hazel/Renderer/GraphicsContext.h"
+
+#include "Hazel/R... | [
"Hazel/src/Hazel/Renderer/GraphicsContext.cpp"
] | [
{
"comment": "Should @TheCherno cover/mention this in a video? Since it's introducing a new file to the project.",
"path": "Hazel/src/Hazel/Renderer/GraphicsContext.cpp",
"hunk": "@@ -0,0 +1,21 @@\n+#include \"hzpch.h\"\n+#include \"Hazel/Renderer/GraphicsContext.h\"\n+\n+#include \"Hazel/Renderer/Rende... | true | ||
TheCherno/Hazel | 165 | comment_to_fix | Code maintenance | We should maybe consider having this create method take in the API as a parameter and then set `RendererAPI::s_API` along with the other code. It might, however, also be better to do this somewhere else and I think it falls outside the scope of this PR. | 8c35857cc442706ec0196d0298fefa11dfcbe0bf | f1676f4378d5c57018bc5c598a8e7437200e6ba4 | diff --git a/Hazel/src/Hazel/Renderer/RendererAPI.cpp b/Hazel/src/Hazel/Renderer/RendererAPI.cpp
index aded22f80..d0dea128b 100644
--- a/Hazel/src/Hazel/Renderer/RendererAPI.cpp
+++ b/Hazel/src/Hazel/Renderer/RendererAPI.cpp
@@ -1,8 +1,22 @@
#include "hzpch.h"
-#include "RendererAPI.h"
+#include "Hazel/Renderer/Render... | [
"Hazel/src/Hazel/Renderer/RendererAPI.cpp"
] | [
{
"comment": "We should maybe consider having this create method take in the API as a parameter and then set `RendererAPI::s_API` along with the other code. It might, however, also be better to do this somewhere else and I think it falls outside the scope of this PR.",
"path": "Hazel/src/Hazel/Renderer/Rend... | true | ||
TheCherno/Hazel | 165 | comment_to_fix | Code maintenance | We could keep this in. Otherwise we should probably also remove the extra logging in `EntryPoint` (the "Hello! Var = ..." thing). | 8c35857cc442706ec0196d0298fefa11dfcbe0bf | f1676f4378d5c57018bc5c598a8e7437200e6ba4 | diff --git a/Hazel/src/Platform/Windows/WindowsWindow.cpp b/Hazel/src/Platform/Windows/WindowsWindow.cpp
index fdd339b16..b27215e9a 100644
--- a/Hazel/src/Platform/Windows/WindowsWindow.cpp
+++ b/Hazel/src/Platform/Windows/WindowsWindow.cpp
@@ -1,5 +1,5 @@
#include "hzpch.h"
-#include "WindowsWindow.h"
+#include "Plat... | [
"Hazel/src/Platform/Windows/WindowsWindow.cpp"
] | [
{
"comment": "We could keep this in. Otherwise we should probably also remove the extra logging in `EntryPoint` (the \"Hello! Var = ...\" thing).",
"path": "Hazel/src/Platform/Windows/WindowsWindow.cpp",
"hunk": "@@ -41,7 +41,6 @@ namespace Hazel {\n \n \t\tif (s_GLFWWindowCount == 0)\n \t\t{\n-\t\t\tHZ... | true | ||
TheCherno/Hazel | 165 | comment_to_fix | Code maintenance | Same as with the init message. | 8c35857cc442706ec0196d0298fefa11dfcbe0bf | f1676f4378d5c57018bc5c598a8e7437200e6ba4 | diff --git a/Hazel/src/Platform/Windows/WindowsWindow.cpp b/Hazel/src/Platform/Windows/WindowsWindow.cpp
index fdd339b16..b27215e9a 100644
--- a/Hazel/src/Platform/Windows/WindowsWindow.cpp
+++ b/Hazel/src/Platform/Windows/WindowsWindow.cpp
@@ -1,5 +1,5 @@
#include "hzpch.h"
-#include "WindowsWindow.h"
+#include "Plat... | [
"Hazel/src/Platform/Windows/WindowsWindow.cpp"
] | [
{
"comment": "Same as with the init message.",
"path": "Hazel/src/Platform/Windows/WindowsWindow.cpp",
"hunk": "@@ -151,10 +149,10 @@ namespace Hazel {\n \tvoid WindowsWindow::Shutdown()\n \t{\n \t\tglfwDestroyWindow(m_Window);\n+\t\t--s_GLFWWindowCount;\n \n-\t\tif (--s_GLFWWindowCount == 0)\n+\t\tif (... | true | ||
TheCherno/Hazel | 165 | comment_to_fix | Code maintenance | `Core.h` is now part of `Hazel.h` so we don't need to include it again. | 8c35857cc442706ec0196d0298fefa11dfcbe0bf | f1676f4378d5c57018bc5c598a8e7437200e6ba4 | diff --git a/Sandbox/src/SandboxApp.cpp b/Sandbox/src/SandboxApp.cpp
index d7cac4dda..52cb51707 100644
--- a/Sandbox/src/SandboxApp.cpp
+++ b/Sandbox/src/SandboxApp.cpp
@@ -1,9 +1,7 @@
#include <Hazel.h>
#include <Hazel/Core/EntryPoint.h>
-#include "Platform/OpenGL/OpenGLShader.h"
-
-#include "imgui/imgui.h"
+#incl... | [
"Sandbox/src/SandboxApp.cpp"
] | [
{
"comment": "`Core.h` is now part of `Hazel.h` so we don't need to include it again.",
"path": "Sandbox/src/SandboxApp.cpp",
"hunk": "@@ -1,9 +1,10 @@\n #include <Hazel.h>\n+#include <Hazel/Core/Core.h>",
"resolving_sha": "f1676f4378d5c57018bc5c598a8e7437200e6ba4",
"resolving_diff": "diff --git... | true | ||
TheCherno/Hazel | 22 | issue_to_patch | Postbuild command for Hazel project modified | this will ensure that XCOPY command will know that argument number 2 is folder not a file | 70e959ec24e44f3de00ea4e57654e8976e583e30 | 7ac370a36952f2ca0f9b346f78f7a8408805d87e | diff --git a/premake5.lua b/premake5.lua
index dd859c9ce..c8ce9da1e 100644
--- a/premake5.lua
+++ b/premake5.lua
@@ -69,7 +69,7 @@ project "Hazel"
postbuildcommands
{
- ("{COPY} %{cfg.buildtarget.relpath} ../bin/" .. outputdir .. "/Sandbox")
+ ("{COPY} %{cfg.buildtarget.relpath} \"../bin/" .. outputdir .. "... | [
"premake5.lua"
] | [] | true | ||
TheCherno/Hazel | 419 | issue_to_patch | Incorrect viewport position being fed to ImGuizmo
#### Describe the bug
ImGuizmo::SetRect(...) is being fed with ImGui::GetWIndowPos() which does not account for tab bar height, this causes ImGuizmo to render widgets in the wrong position when the tab bar is visible.
#### To Reproduce
Steps to reproduce the behav... | Fix wrong viewport bounds when tab is visible | #### Describe the issue (if no issue has been made)
The viewport bound does not account for the tab bar correctly. As a result, when the tab bar is visible, the mouse picking is vertically offset. Also, when the cursor is right below the tab bar, `Framebuffer::ReadPixel()` returns an undefined integer.
![ezgif com-... | a0ea5bd655ada71b5175f10688d29ebff64f93d0 | f8c9219e1181d9e3599330ecdd09077344008722 | diff --git a/Hazelnut/src/EditorLayer.cpp b/Hazelnut/src/EditorLayer.cpp
index da1b32eb8..c9e0130ef 100644
--- a/Hazelnut/src/EditorLayer.cpp
+++ b/Hazelnut/src/EditorLayer.cpp
@@ -236,7 +236,11 @@ namespace Hazel {
ImGui::PushStyleVar(ImGuiStyleVar_WindowPadding, ImVec2{ 0, 0 });
ImGui::Begin("Viewport");
- a... | [
"Hazelnut/src/EditorLayer.cpp"
] | [
{
"comment": "```suggestion\r\n\t\tauto viewportMinRegion = ImGui::GetWindowContentRegionMin();\r\n\t\tauto viewportMaxRegion = ImGui::GetWindowContentRegionMax();\r\n\t\tauto viewportOffset = ImGui::GetWindowPos();\r\n\t\tm_ViewportBounds[0] = { viewportMinRegion.x + viewportOffset.x, viewportMinRegion.y + vie... | true | |
TheCherno/Hazel | 419 | comment_to_fix | Fix wrong viewport bounds when tab is visible | ```suggestion
auto viewportMinRegion = ImGui::GetWindowContentRegionMin();
auto viewportMaxRegion = ImGui::GetWindowContentRegionMax();
auto viewportOffset = ImGui::GetWindowPos();
m_ViewportBounds[0] = { viewportMinRegion.x + viewportOffset.x, viewportMinRegion.y + viewportOffset.y };
m_ViewportBounds[1... | a0ea5bd655ada71b5175f10688d29ebff64f93d0 | f8c9219e1181d9e3599330ecdd09077344008722 | diff --git a/Hazelnut/src/EditorLayer.cpp b/Hazelnut/src/EditorLayer.cpp
index da1b32eb8..c9e0130ef 100644
--- a/Hazelnut/src/EditorLayer.cpp
+++ b/Hazelnut/src/EditorLayer.cpp
@@ -236,7 +236,11 @@ namespace Hazel {
ImGui::PushStyleVar(ImGuiStyleVar_WindowPadding, ImVec2{ 0, 0 });
ImGui::Begin("Viewport");
- a... | [
"Hazelnut/src/EditorLayer.cpp"
] | [
{
"comment": "```suggestion\r\n\t\tauto viewportMinRegion = ImGui::GetWindowContentRegionMin();\r\n\t\tauto viewportMaxRegion = ImGui::GetWindowContentRegionMax();\r\n\t\tauto viewportOffset = ImGui::GetWindowPos();\r\n\t\tm_ViewportBounds[0] = { viewportMinRegion.x + viewportOffset.x, viewportMinRegion.y + vie... | true | ||
TheCherno/Hazel | 419 | comment_to_fix | Fix wrong viewport bounds when tab is visible | ```suggestion
ImGuizmo::SetRect(m_ViewportBounds[0].x, m_ViewportBounds[0].y, m_ViewportBounds[1].x - m_ViewportBounds[0].x, m_ViewportBounds[1].y - m_ViewportBounds[0].y);
``` | a0ea5bd655ada71b5175f10688d29ebff64f93d0 | f8c9219e1181d9e3599330ecdd09077344008722 | diff --git a/Hazelnut/src/EditorLayer.cpp b/Hazelnut/src/EditorLayer.cpp
index da1b32eb8..c9e0130ef 100644
--- a/Hazelnut/src/EditorLayer.cpp
+++ b/Hazelnut/src/EditorLayer.cpp
@@ -236,7 +236,11 @@ namespace Hazel {
ImGui::PushStyleVar(ImGuiStyleVar_WindowPadding, ImVec2{ 0, 0 });
ImGui::Begin("Viewport");
- a... | [
"Hazelnut/src/EditorLayer.cpp"
] | [
{
"comment": "```suggestion\r\n\t\t\tImGuizmo::SetRect(m_ViewportBounds[0].x, m_ViewportBounds[0].y, m_ViewportBounds[1].x - m_ViewportBounds[0].x, m_ViewportBounds[1].y - m_ViewportBounds[0].y);\r\n```",
"path": "Hazelnut/src/EditorLayer.cpp",
"hunk": "@@ -248,25 +257,14 @@ namespace Hazel {\n \t\tuint... | true | ||
TheCherno/Hazel | 407 | issue_to_patch | Added missing 'SetFloat2' in Renderer | Nothing to explain, just added the missing `SetFloat2()` in the `Shader.h` 🙂
| 9749d0c980ca1ac7f1758ebea48c019c17e16699 | 0f7abf3685b57ac15c960c285083651a5f9bcbc8 | diff --git a/Hazel/src/Hazel/Renderer/Shader.h b/Hazel/src/Hazel/Renderer/Shader.h
index 008af85ee..5e93947e2 100644
--- a/Hazel/src/Hazel/Renderer/Shader.h
+++ b/Hazel/src/Hazel/Renderer/Shader.h
@@ -18,6 +18,7 @@ namespace Hazel {
virtual void SetInt(const std::string& name, int value) = 0;
virtual void SetIntA... | [
"Hazel/src/Hazel/Renderer/Shader.h",
"Hazel/src/Platform/OpenGL/OpenGLShader.cpp",
"Hazel/src/Platform/OpenGL/OpenGLShader.h"
] | [] | true | ||
TheCherno/Hazel | 379 | issue_to_patch | Fixed unexpected behaviour in OpenGLVertexArray when using int attributes | glVertexAttribPointer will auto cast any int types to float between setting the buffer data and data being passed into the shader program. Even when the shader layout states the attribute is an int, the value passed has already been cast to a float, and it is then reinterpreted as an int, ie. the shader program literal... | 5f9c132a198f2a539129fdc79535bd0295929197 | f41ee5c5436a5083cb8218da28f5b9460b4bb04f | diff --git a/Hazel/src/Platform/OpenGL/OpenGLVertexArray.cpp b/Hazel/src/Platform/OpenGL/OpenGLVertexArray.cpp
index 4bf79496d..762041dce 100644
--- a/Hazel/src/Platform/OpenGL/OpenGLVertexArray.cpp
+++ b/Hazel/src/Platform/OpenGL/OpenGLVertexArray.cpp
@@ -72,6 +72,17 @@ namespace Hazel {
case ShaderDataType::Floa... | [
"Hazel/src/Platform/OpenGL/OpenGLVertexArray.cpp"
] | [] | true | ||
TheCherno/Hazel | 400 | issue_to_patch | Crash when changing gizmos while using them
#### Description
Found an issue, if you change gizmos while using it, it will crash
#### My fix
i fixed it by locking the changing when i use it. not the best but it works
Im opening this issue, because i know that my fix is not the best and can be improved
#### Rep... | ImGuizmo Crash Fix | The issue
When you change a gizmo while using it, it will crash entire engine.
List of related issues/PRs this will solve:
- Crash when changing gizmos while using them #383
Impact | Issue/PR
------------------------ | ------
Issues this solves | Resolves #383
Other PRs this solve... | 9749d0c980ca1ac7f1758ebea48c019c17e16699 | acb120a0a84e5e0cc2f3e4c8c099f3e9f52d2c47 | diff --git a/Hazelnut/src/EditorLayer.cpp b/Hazelnut/src/EditorLayer.cpp
index 62aa7b9ce..b94b77b29 100644
--- a/Hazelnut/src/EditorLayer.cpp
+++ b/Hazelnut/src/EditorLayer.cpp
@@ -305,6 +305,7 @@ namespace Hazel {
bool control = Input::IsKeyPressed(Key::LeftControl) || Input::IsKeyPressed(Key::RightControl);
b... | [
"Hazelnut/src/EditorLayer.cpp"
] | [
{
"comment": "no need to store it as a variable, it is only used in the switch case anyway (once)\r\n\r\n```suggestion\r\n\r\n``` ",
"path": "Hazelnut/src/EditorLayer.cpp",
"hunk": "@@ -303,7 +303,7 @@ namespace Hazel {\n \t\tif (e.GetRepeatCount() > 0)\n \t\t\treturn false;\n \n-\t\tint gizmoChange = -... | true | |
TheCherno/Hazel | 388 | issue_to_patch | Fixed Math Function Declaration | #### Fixed function declaration of DecomposeTransform() function
When @TheCherno copied the DecomposeTransform() function diff, the declaration he created in Math.h class was different from the definition, which could lead to some inconsistencies
#### PR impact
List of related issues/PRs this will solve:
Impac... | b833c1bb06c00ce4bebdd895d4abbcaec90ca342 | c0264d75dfc8e16879f9ff0740164e5f1a432f24 | diff --git a/Hazel/src/Hazel/Math/Math.h b/Hazel/src/Hazel/Math/Math.h
index e654f91d9..44fe45029 100644
--- a/Hazel/src/Hazel/Math/Math.h
+++ b/Hazel/src/Hazel/Math/Math.h
@@ -4,6 +4,6 @@
namespace Hazel::Math {
- bool DecomposeTransform(const glm::mat4& transform, glm::vec3& outTranslation, glm::vec3& outRotatio... | [
"Hazel/src/Hazel/Math/Math.h"
] | [
{
"comment": "I remember he wanted to prefix them with out to indicate they are the output... In any case, you should leave the new lines in there\r\n\r\n```suggestion\r\n\r\n\tbool DecomposeTransform(const glm::mat4& transform, glm::vec3& translation, glm::vec3& rotation, glm::vec3& scale);\r\n\r\n```",
"p... | true | ||
TheCherno/Hazel | 388 | comment_to_fix | Fixed Math Function Declaration | I remember he wanted to prefix them with out to indicate they are the output... In any case, you should leave the new lines in there
```suggestion
bool DecomposeTransform(const glm::mat4& transform, glm::vec3& translation, glm::vec3& rotation, glm::vec3& scale);
``` | b833c1bb06c00ce4bebdd895d4abbcaec90ca342 | c0264d75dfc8e16879f9ff0740164e5f1a432f24 | diff --git a/Hazel/src/Hazel/Math/Math.h b/Hazel/src/Hazel/Math/Math.h
index e654f91d9..44fe45029 100644
--- a/Hazel/src/Hazel/Math/Math.h
+++ b/Hazel/src/Hazel/Math/Math.h
@@ -4,6 +4,6 @@
namespace Hazel::Math {
- bool DecomposeTransform(const glm::mat4& transform, glm::vec3& outTranslation, glm::vec3& outRotatio... | [
"Hazel/src/Hazel/Math/Math.h"
] | [
{
"comment": "I remember he wanted to prefix them with out to indicate they are the output... In any case, you should leave the new lines in there\r\n\r\n```suggestion\r\n\r\n\tbool DecomposeTransform(const glm::mat4& transform, glm::vec3& translation, glm::vec3& rotation, glm::vec3& scale);\r\n\r\n```",
"p... | true | ||
TheCherno/Hazel | 389 | issue_to_patch | Removed redundant include in WindowsPlatformUtils.cpp file | #### Redundant include in WindowsPlatformUtils.cpp file
In pull request [355](https://github.com/TheCherno/Hazel/pull/355#issue-509596608), over the course of discussion with other developers and implementation of the mechanism, I forgot to remove the `sstream` header file.
#### PR impact
List of related issues/P... | 362248056e917dfa87d113bfa8a6d1c280fe52c7 | caa5c75b5356286af4c52a43a4b5784d69020666 | diff --git a/Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp b/Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp
index f13416bcc..77fba2841 100644
--- a/Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp
+++ b/Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp
@@ -1,7 +1,6 @@
#include "hzpch.h"
#include "Haze... | [
"Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp"
] | [] | true | ||
TheCherno/Hazel | 355 | issue_to_patch | Added a default extension string | #### Added Default Extension
On saving files, if the extension is not specified, the file isn't saved with a `.hazel` extension, and hence doesn't turn up in the OpenFile Dialog.
Impact | Issue/PR
------------------------ | ------
Issues this solves | None
Other PRs this solves | None
... | a014633bb728106b03dce214c765b7e7892f6d70 | 6ea7cc7486eeabd0d982e0bd2483ec743cf83084 | diff --git a/Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp b/Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp
index cb8869319..4159ab4fb 100644
--- a/Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp
+++ b/Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp
@@ -1,6 +1,7 @@
#include "hzpch.h"
#include "Haze... | [
"Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp"
] | [
{
"comment": "Because each individual filter is null terminated, and assuming the first filter is the default filter, you could replace everything with \r\n```\r\nofn.lpstrDefExt = strchr(filter, '\\0') + 1;\r\n```",
"path": "Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp",
"hunk": "@@ -40,12 +41,2... | true | ||
TheCherno/Hazel | 355 | comment_to_fix | Added a default extension string | Because each individual filter is null terminated, and assuming the first filter is the default filter, you could replace everything with
```
ofn.lpstrDefExt = strchr(filter, '\0') + 1;
``` | a014633bb728106b03dce214c765b7e7892f6d70 | 6ea7cc7486eeabd0d982e0bd2483ec743cf83084 | diff --git a/Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp b/Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp
index cb8869319..4159ab4fb 100644
--- a/Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp
+++ b/Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp
@@ -1,6 +1,7 @@
#include "hzpch.h"
#include "Haze... | [
"Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp"
] | [
{
"comment": "Because each individual filter is null terminated, and assuming the first filter is the default filter, you could replace everything with \r\n```\r\nofn.lpstrDefExt = strchr(filter, '\\0') + 1;\r\n```",
"path": "Hazel/src/Platform/Windows/WindowsPlatformUtils.cpp",
"hunk": "@@ -40,12 +41,2... | true | ||
TheCherno/Hazel | 316 | issue_to_patch | Added #define NOMINMAX to pch file | #### Describe the issue
While compiling the project, especially on Windows, a bunch of compilation errors turn up. A quick check on the internet revealed conflicts with the Windows.h header library and std::max and std::min functions being used (in this case the entt library is using std::max)
#### PR impact
List ... | 6f0596b8c5a2b67eaeef546cb0caa59624ce37db | 5e89624be5144cb9736ea583f989392a3d8514f1 | diff --git a/Hazel/src/Hazel/Core/Base.h b/Hazel/src/Hazel/Core/Base.h
index 419505ed4..f553fdfc4 100644
--- a/Hazel/src/Hazel/Core/Base.h
+++ b/Hazel/src/Hazel/Core/Base.h
@@ -2,46 +2,7 @@
#include <memory>
-// Platform detection using predefined macros
-#ifdef _WIN32
- /* Windows x64/x86 */
- #ifdef _WIN64
- /*... | [
"Hazel/src/Hazel/Core/Base.h",
"Hazel/src/Hazel/Core/PlatformDetection.h",
"Hazel/src/hzpch.h",
"Hazelnut/imgui.ini"
] | [] | true | ||
TheCherno/Hazel | 362 | issue_to_patch | Fixed Z-Fighting bug in Texture Shader and updated GLSL version | Without this change, going 3D with a perspective camera will affect how the textures are rendered. If you don't make v_TexIndex flat, the texture will glitch out when changing the yaw of the camera. Making it flat will solve this issue. I also updated the GLSL version so that it's compatible with flat.
Edit :
Anot... | a014633bb728106b03dce214c765b7e7892f6d70 | ddf9e5da105da40e03875bfe383326b5edd63e0d | diff --git a/Hazelnut/assets/shaders/Texture.glsl b/Hazelnut/assets/shaders/Texture.glsl
index abc58e89c..e386bacbe 100644
--- a/Hazelnut/assets/shaders/Texture.glsl
+++ b/Hazelnut/assets/shaders/Texture.glsl
@@ -1,7 +1,7 @@
// Basic Texture Shader
#type vertex
-#version 330 core
+#version 450
layout(location = ... | [
"Hazelnut/assets/shaders/Texture.glsl",
"Sandbox/assets/shaders/Texture.glsl"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.