repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
TheAlgorithms/Rust | 721 | comment_to_fix | add algorithms to detect cycle in graph | What do you think about expressing the tests in a more _parametrized_ way? By the way, I think I have found two scenarios, in which I get a wrong result - they are currently _commented out_.
```suggestion
#[cfg(test)]
mod test {
use crate::data_structures::{graph::Graph, DirectedGraph, UndirectedGraph};
... | d920c9b3701c09bb5b509d6e46d70d558563cf4c | 0f7c1960f25ec28e321d4cd67927aaef1ef58c63 | diff --git a/src/graph/detect_cycle.rs b/src/graph/detect_cycle.rs
new file mode 100644
index 00000000000..0243b44eede
--- /dev/null
+++ b/src/graph/detect_cycle.rs
@@ -0,0 +1,294 @@
+use std::collections::{HashMap, HashSet, VecDeque};
+
+use crate::data_structures::{graph::Graph, DirectedGraph, UndirectedGraph};
+
+pu... | [
"src/graph/detect_cycle.rs"
] | [
{
"comment": "What do you think about expressing the tests in a more _parametrized_ way? By the way, I think I have found two scenarios, in which I get a wrong result - they are currently _commented out_.\r\n\r\n```suggestion\r\n#[cfg(test)]\r\nmod test {\r\n use crate::data_structures::{graph::Graph, Direct... | true | ||
TheAlgorithms/Rust | 868 | issue_to_patch | style: include `match_same_arms` | # Pull Request Template
## Description
This PR removes [`match_same_arms`](https://rust-lang.github.io/rust-clippy/master/index.html#match_same_arms) from the list of from the list of suppressed lints.
Continuation of #743.
## Checklist:
- [x] I ran bellow commands using the latest version of **rust nigh... | 798c73af8c25ff7380afb0b95036ef6b85ed775b | 5fdae55f3eb8c6e4fdea34ab2edd58707d5c262d | diff --git a/Cargo.toml b/Cargo.toml
index e0f7bcd8e32..f6afbf3d3ab 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -46,7 +46,6 @@ manual_let_else = { level = "allow", priority = 1 }
manual_string_new = { level = "allow", priority = 1 }
many_single_char_names = { level = "allow", priority = 1 }
match_on_vec_items = { le... | [
"Cargo.toml",
"src/geometry/closest_points.rs",
"src/graph/depth_first_search_tic_tac_toe.rs",
"src/math/miller_rabin.rs"
] | [] | true | ||
TheAlgorithms/Rust | 603 | issue_to_patch | Handle nonunique max frequency elements in `mode` | # Pull Request Template
## Description
The current implementation of [`mode`](https://github.com/TheAlgorithms/Rust/blob/e7888f46dec0d96c764d710faa53994ac1d59e25/src/math/average.rs#L52) does not handle properly the inputs like `vec![1, 1, 2, 2]`.
This PR fixes that by changing the `mode` to return a `HashSet`... | 113a257b04e808a0cf732dda0f013ec3ce43df03 | 0f6227496041cd1286db8ef66080e0cd506d26f4 | diff --git a/src/math/average.rs b/src/math/average.rs
index 3eb27c0eddc..b4842def20e 100644
--- a/src/math/average.rs
+++ b/src/math/average.rs
@@ -10,6 +10,7 @@ This program approximates the mean, median and mode of a finite sequence.
Note: `mean` function only limited to float 64 numbers. Floats sequences are not a... | [
"src/math/average.rs"
] | [] | true | ||
TheAlgorithms/Rust | 613 | issue_to_patch | redundant condition removal | Hi, this is my first PR in my life, I'm not a programmer, just a student and my English is very bad, but I noticed that this piece of code is redundant and I removed it. It's correct right? | 8eb5f38d48bafb88b94d3ad964b140a289c80798 | b749cbdd157e827c8d03c08b06c906dda0152443 | diff --git a/src/math/amicable_numbers.rs b/src/math/amicable_numbers.rs
index 4d466cd4134..35ff4d7fcfe 100644
--- a/src/math/amicable_numbers.rs
+++ b/src/math/amicable_numbers.rs
@@ -18,8 +18,7 @@ pub fn amicable_pairs_under_n(n: u32) -> Option<Vec<(u32, u32)>> {
let mut out = vec![(0, 0)];
// Check if numb... | [
"src/math/amicable_numbers.rs"
] | [
{
"comment": "This should fix the formatting.\r\n\r\n```suggestion\r\n if (*x < n) && (factor_sums[*x as usize] == i as u32) && (*x > i as u32) {\r\n```\r\n\r\nYou can just _click_ the `commit suggestion` button.",
"path": "src/math/amicable_numbers.rs",
"hunk": "@@ -18,7 +18,7 @@ pub fn amicable... | true | ||
TheAlgorithms/Rust | 613 | comment_to_fix | redundant condition removal | This should fix the formatting.
```suggestion
if (*x < n) && (factor_sums[*x as usize] == i as u32) && (*x > i as u32) {
```
You can just _click_ the `commit suggestion` button. | 8eb5f38d48bafb88b94d3ad964b140a289c80798 | b749cbdd157e827c8d03c08b06c906dda0152443 | diff --git a/src/math/amicable_numbers.rs b/src/math/amicable_numbers.rs
index 4d466cd4134..35ff4d7fcfe 100644
--- a/src/math/amicable_numbers.rs
+++ b/src/math/amicable_numbers.rs
@@ -18,8 +18,7 @@ pub fn amicable_pairs_under_n(n: u32) -> Option<Vec<(u32, u32)>> {
let mut out = vec![(0, 0)];
// Check if numb... | [
"src/math/amicable_numbers.rs"
] | [
{
"comment": "This should fix the formatting.\r\n\r\n```suggestion\r\n if (*x < n) && (factor_sums[*x as usize] == i as u32) && (*x > i as u32) {\r\n```\r\n\r\nYou can just _click_ the `commit suggestion` button.",
"path": "src/math/amicable_numbers.rs",
"hunk": "@@ -18,7 +18,7 @@ pub fn amicable... | true | ||
TheAlgorithms/Rust | 637 | issue_to_patch | Cholesky decomposition | # Pull Request Template
## Description
This pull request introduces a Cholesky decomposition algorithm implemented in Rust. Cholesky decomposition is a numerical method for decomposing a positive-definite matrix into the product of a lower triangular matrix and its transpose.
The `cholesky` function takes a ve... | f7f276962b564eb64425653c1e65d330968fc675 | 5e0ea2154357ca719cab93eac7cade0fb8e04fcc | diff --git a/DIRECTORY.md b/DIRECTORY.md
index e84742af5a6..1896d69be1d 100644
--- a/DIRECTORY.md
+++ b/DIRECTORY.md
@@ -65,6 +65,7 @@
* [Count Min Sketch](https://github.com/TheAlgorithms/Rust/blob/master/src/data_structures/probabilistic/count_min_sketch.rs)
* [Queue](https://github.com/TheAlgorithms/Rust... | [
"DIRECTORY.md",
"src/machine_learning/cholesky.rs",
"src/machine_learning/mod.rs"
] | [] | true | ||
TheAlgorithms/Rust | 825 | issue_to_patch | Refactor Anagram | ## Checklist:
- [x] I ran bellow commands using the latest version of **rust nightly**.
- [x] I ran `cargo clippy --all -- -D warnings` just before my last commit and fixed any issue that was found.
- [x] I ran `cargo fmt` just before my last commit.
- [x] I ran `cargo test` just before my last commit and all tes... | 858443e1b7c4106b3d82dcf4a829ff0de24eb15d | bd326fccb9f818085135c4958e2118b03c6ee885 | diff --git a/src/string/anagram.rs b/src/string/anagram.rs
index b81b7804707..9ea37dc4f6f 100644
--- a/src/string/anagram.rs
+++ b/src/string/anagram.rs
@@ -1,10 +1,68 @@
-pub fn check_anagram(s: &str, t: &str) -> bool {
- sort_string(s) == sort_string(t)
+use std::collections::HashMap;
+
+/// Custom error type repr... | [
"src/string/anagram.rs"
] | [
{
"comment": "```suggestion\r\nfn char_count(s: &str) -> HashMap<char, usize> {\r\n```\r\nIt is not the _frequency_.",
"path": "src/string/anagram.rs",
"hunk": "@@ -1,27 +1,101 @@\n-pub fn check_anagram(s: &str, t: &str) -> bool {\n- sort_string(s) == sort_string(t)\n+use std::collections::HashMap;\n... | true | ||
TheAlgorithms/Rust | 825 | comment_to_fix | Refactor Anagram | ```suggestion
fn char_count(s: &str) -> HashMap<char, usize> {
```
It is not the _frequency_. | 858443e1b7c4106b3d82dcf4a829ff0de24eb15d | bd326fccb9f818085135c4958e2118b03c6ee885 | diff --git a/src/string/anagram.rs b/src/string/anagram.rs
index b81b7804707..9ea37dc4f6f 100644
--- a/src/string/anagram.rs
+++ b/src/string/anagram.rs
@@ -1,10 +1,68 @@
-pub fn check_anagram(s: &str, t: &str) -> bool {
- sort_string(s) == sort_string(t)
+use std::collections::HashMap;
+
+/// Custom error type repr... | [
"src/string/anagram.rs"
] | [
{
"comment": "```suggestion\r\nfn char_count(s: &str) -> HashMap<char, usize> {\r\n```\r\nIt is not the _frequency_.",
"path": "src/string/anagram.rs",
"hunk": "@@ -1,27 +1,101 @@\n-pub fn check_anagram(s: &str, t: &str) -> bool {\n- sort_string(s) == sort_string(t)\n+use std::collections::HashMap;\n... | true | ||
TheAlgorithms/Rust | 825 | comment_to_fix | Refactor Anagram | ```suggestion
/// * A `HashMap` where the keys are characters and values are their count.
fn char_count(s: &str) -> HashMap<char, usize> {
let mut res = HashMap::new();
for c in s.chars() {
*res.entry(c).or_insert(0) += 1;
}
res
``` | 858443e1b7c4106b3d82dcf4a829ff0de24eb15d | bd326fccb9f818085135c4958e2118b03c6ee885 | diff --git a/src/string/anagram.rs b/src/string/anagram.rs
index b81b7804707..9ea37dc4f6f 100644
--- a/src/string/anagram.rs
+++ b/src/string/anagram.rs
@@ -1,10 +1,68 @@
-pub fn check_anagram(s: &str, t: &str) -> bool {
- sort_string(s) == sort_string(t)
+use std::collections::HashMap;
+
+/// Custom error type repr... | [
"src/string/anagram.rs"
] | [
{
"comment": "```suggestion\r\n/// * A `HashMap` where the keys are characters and values are their count.\r\nfn char_count(s: &str) -> HashMap<char, usize> {\r\n let mut res = HashMap::new();\r\n for c in s.chars() {\r\n *res.entry(c).or_insert(0) += 1;\r\n }\r\n res\r\n```",
"path": "sr... | true | ||
TheAlgorithms/Rust | 825 | comment_to_fix | Refactor Anagram | ```suggestion
/// Computes the histogram of characters in a string.
``` | 858443e1b7c4106b3d82dcf4a829ff0de24eb15d | bd326fccb9f818085135c4958e2118b03c6ee885 | diff --git a/src/string/anagram.rs b/src/string/anagram.rs
index b81b7804707..9ea37dc4f6f 100644
--- a/src/string/anagram.rs
+++ b/src/string/anagram.rs
@@ -1,10 +1,68 @@
-pub fn check_anagram(s: &str, t: &str) -> bool {
- sort_string(s) == sort_string(t)
+use std::collections::HashMap;
+
+/// Custom error type repr... | [
"src/string/anagram.rs"
] | [
{
"comment": "```suggestion\r\n/// Computes the histogram of characters in a string.\r\n```",
"path": "src/string/anagram.rs",
"hunk": "@@ -1,27 +1,111 @@\n-pub fn check_anagram(s: &str, t: &str) -> bool {\n- sort_string(s) == sort_string(t)\n+use std::collections::HashMap;\n+\n+/// Custom error type... | true | ||
TheAlgorithms/Rust | 679 | issue_to_patch | Add `RangeMinimumQuery` | # Sparse Table in Rust
## Description
I feel like a basic data structure like a sparse table would be well suited for this repo
## New feature
- [x] New feature (non-breaking change which adds functionality)
## Checklist:
- [x] I ran bellow commands using the latest version of **rust nightly**.
- [x]... | 2243c0a803d4d39536d6b7e271c9cf4b7216a91b | b66ea9035c54f01a1a9ff6b719e73bf29026ac84 | diff --git a/DIRECTORY.md b/DIRECTORY.md
index 9ce6bc01224..c0c91b38857 100644
--- a/DIRECTORY.md
+++ b/DIRECTORY.md
@@ -64,6 +64,7 @@
* [Bloom Filter](https://github.com/TheAlgorithms/Rust/blob/master/src/data_structures/probabilistic/bloom_filter.rs)
* [Count Min Sketch](https://github.com/TheAlgorithms... | [
"DIRECTORY.md",
"src/data_structures/mod.rs",
"src/data_structures/range_minimum_query.rs"
] | [
{
"comment": "```suggestion\r\npub struct RangeMinimumQuery<T: PartialOrd + Copy> {\r\n```\r\nSparse table is term used for all of such _RangeQuery_ data structures, and it might be misleading.",
"path": "src/data_structures/sparse_table.rs",
"hunk": "@@ -0,0 +1,82 @@\n+/*\n+ A Sparse Table, is a dat... | true | ||
TheAlgorithms/Rust | 891 | issue_to_patch | fix(logistic_regression): typo in comment | # Pull Request Template
## Description
Fixes a typo in the comment to clarify what the function returns
## Type of change
- [x] Bug fix (non-breaking change which fixes an issue)
## Checklist:
- [x] I ran bellow commands using the latest version of **rust nightly**.
- [x] I ran `cargo clippy --all -- -... | 05ee005c8e21d81385eae2221aa584130448fc96 | 8fc0372367beaef6c19741ceec87ae5a2f80a813 | diff --git a/src/machine_learning/logistic_regression.rs b/src/machine_learning/logistic_regression.rs
index fc020a795ac..645cd960f83 100644
--- a/src/machine_learning/logistic_regression.rs
+++ b/src/machine_learning/logistic_regression.rs
@@ -1,7 +1,7 @@
use super::optimization::gradient_descent;
use std::f64::cons... | [
"src/machine_learning/logistic_regression.rs"
] | [] | true | ||
TheAlgorithms/Rust | 689 | issue_to_patch | KMP solves the shortest palindrome | KMP solves the shortest palindrome | 95bf686ceda88d9828900fde8fe7e63a1671b9aa | 929c86c42b62eb655cc95a4e0bceb911aaae5857 | diff --git a/DIRECTORY.md b/DIRECTORY.md
index 839f82db8f0..83611ed4073 100644
--- a/DIRECTORY.md
+++ b/DIRECTORY.md
@@ -312,6 +312,7 @@
* [Rabin Karp](https://github.com/TheAlgorithms/Rust/blob/master/src/string/rabin_karp.rs)
* [Reverse](https://github.com/TheAlgorithms/Rust/blob/master/src/string/reverse.r... | [
"DIRECTORY.md",
"src/string/mod.rs",
"src/string/shortest_palindrome.rs"
] | [
{
"comment": "Please add some documentation, so that potential user or reader will know what is this function doing.",
"path": "src/string/shortest_palindrome.rs",
"hunk": "",
"resolving_sha": "929c86c42b62eb655cc95a4e0bceb911aaae5857",
"resolving_diff": "diff --git a/src/string/shortest_palindr... | diff --git a/src/string/shortest_palindrome.rs b/src/string/shortest_palindrome.rs
new file mode 100644
index 00000000000..80f52395194
--- /dev/null
+++ b/src/string/shortest_palindrome.rs
@@ -0,0 +1,72 @@
+/*
+The function shortest_palindrome expands the given string to shortest palindrome by adding a shortest prefix.... | true | |
TheAlgorithms/Rust | 689 | comment_to_fix | KMP solves the shortest palindrome | Please add some documentation, so that potential user or reader will know what is this function doing. | 95bf686ceda88d9828900fde8fe7e63a1671b9aa | 929c86c42b62eb655cc95a4e0bceb911aaae5857 | diff --git a/src/string/shortest_palindrome.rs b/src/string/shortest_palindrome.rs
new file mode 100644
index 00000000000..80f52395194
--- /dev/null
+++ b/src/string/shortest_palindrome.rs
@@ -0,0 +1,72 @@
+/*
+The function shortest_palindrome expands the given string to shortest palindrome by adding a shortest prefix.... | [
"src/string/shortest_palindrome.rs"
] | [
{
"comment": "Please add some documentation, so that potential user or reader will know what is this function doing.",
"path": "src/string/shortest_palindrome.rs",
"hunk": "",
"resolving_sha": "929c86c42b62eb655cc95a4e0bceb911aaae5857",
"resolving_diff": "diff --git a/src/string/shortest_palindr... | true | ||
TheAlgorithms/Rust | 689 | comment_to_fix | KMP solves the shortest palindrome | Why not like that?
```suggestion
pub fn shortest_palindrome(s: &str) -> String {
``` | 95bf686ceda88d9828900fde8fe7e63a1671b9aa | 929c86c42b62eb655cc95a4e0bceb911aaae5857 | diff --git a/src/string/shortest_palindrome.rs b/src/string/shortest_palindrome.rs
new file mode 100644
index 00000000000..80f52395194
--- /dev/null
+++ b/src/string/shortest_palindrome.rs
@@ -0,0 +1,72 @@
+/*
+The function shortest_palindrome expands the given string to shortest palindrome by adding a shortest prefix.... | [
"src/string/shortest_palindrome.rs"
] | [
{
"comment": "Why not like that?\r\n```suggestion\r\npub fn shortest_palindrome(s: &str) -> String {\r\n```",
"path": "src/string/shortest_palindrome.rs",
"hunk": "@@ -0,0 +1,48 @@\n+pub fn shortest_palindrome(s: String) -> String {",
"resolving_sha": "929c86c42b62eb655cc95a4e0bceb911aaae5857",
... | true | ||
TheAlgorithms/Rust | 689 | comment_to_fix | KMP solves the shortest palindrome | An empty string `""` is a palindrome. I think in this case an empty string should be returned:
```suggestion
return "".to_string();
``` | 95bf686ceda88d9828900fde8fe7e63a1671b9aa | 929c86c42b62eb655cc95a4e0bceb911aaae5857 | diff --git a/src/string/shortest_palindrome.rs b/src/string/shortest_palindrome.rs
new file mode 100644
index 00000000000..80f52395194
--- /dev/null
+++ b/src/string/shortest_palindrome.rs
@@ -0,0 +1,72 @@
+/*
+The function shortest_palindrome expands the given string to shortest palindrome by adding a shortest prefix.... | [
"src/string/shortest_palindrome.rs"
] | [
{
"comment": "An empty string `\"\"` is a palindrome. I think in this case an empty string should be returned:\r\n```suggestion\r\n return \"\".to_string();\r\n```",
"path": "src/string/shortest_palindrome.rs",
"hunk": "@@ -0,0 +1,48 @@\n+pub fn shortest_palindrome(s: String) -> String {\n+ if... | true | ||
TheAlgorithms/Rust | 689 | comment_to_fix | KMP solves the shortest palindrome | The duplicated code in the tests could be reduced. What do you think about the following?
```suggestion
use super::shortest_palindrome;
use crate::string::is_palindrome;
macro_rules! test_shortest_palindrome {
($($name:ident: $inputs:expr,)*) => {
$(
#[test]
... | 95bf686ceda88d9828900fde8fe7e63a1671b9aa | 929c86c42b62eb655cc95a4e0bceb911aaae5857 | diff --git a/src/string/shortest_palindrome.rs b/src/string/shortest_palindrome.rs
new file mode 100644
index 00000000000..80f52395194
--- /dev/null
+++ b/src/string/shortest_palindrome.rs
@@ -0,0 +1,72 @@
+/*
+The function shortest_palindrome expands the given string to shortest palindrome by adding a shortest prefix.... | [
"src/string/shortest_palindrome.rs"
] | [
{
"comment": "The duplicated code in the tests could be reduced. What do you think about the following?\r\n\r\n```suggestion\r\n use super::shortest_palindrome;\r\n use crate::string::is_palindrome;\r\n\r\n macro_rules! test_shortest_palindrome {\r\n ($($name:ident: $inputs:expr,)*) => {\r\n ... | true | ||
TheAlgorithms/Rust | 689 | comment_to_fix | KMP solves the shortest palindrome | Please describe _what does it do_. For example something like: The function `shortest_palindrome` expands the given string to shortest palindrome by adding a shortest prefix. | 95bf686ceda88d9828900fde8fe7e63a1671b9aa | 929c86c42b62eb655cc95a4e0bceb911aaae5857 | diff --git a/src/string/shortest_palindrome.rs b/src/string/shortest_palindrome.rs
new file mode 100644
index 00000000000..80f52395194
--- /dev/null
+++ b/src/string/shortest_palindrome.rs
@@ -0,0 +1,72 @@
+/*
+The function shortest_palindrome expands the given string to shortest palindrome by adding a shortest prefix.... | [
"src/string/shortest_palindrome.rs"
] | [
{
"comment": "Please describe _what does it do_. For example something like: The function `shortest_palindrome` expands the given string to shortest palindrome by adding a shortest prefix.",
"path": "src/string/shortest_palindrome.rs",
"hunk": "@@ -0,0 +1,54 @@\n+/*\n+KMP. Source：https://www.scaler.com/... | true | ||
TheAlgorithms/Rust | 689 | comment_to_fix | KMP solves the shortest palindrome | ```suggestion
#[cfg(test)]
mod tests {
use super::shortest_palindrome;
macro_rules! test_shortest_palindrome {
($($name:ident: $inputs:expr,)*) => {
$(
#[test]
fn $name() {
use crate::string::is_palindrome;
let... | 95bf686ceda88d9828900fde8fe7e63a1671b9aa | 929c86c42b62eb655cc95a4e0bceb911aaae5857 | diff --git a/src/string/shortest_palindrome.rs b/src/string/shortest_palindrome.rs
new file mode 100644
index 00000000000..80f52395194
--- /dev/null
+++ b/src/string/shortest_palindrome.rs
@@ -0,0 +1,72 @@
+/*
+The function shortest_palindrome expands the given string to shortest palindrome by adding a shortest prefix.... | [
"src/string/shortest_palindrome.rs"
] | [
{
"comment": "```suggestion\r\n#[cfg(test)]\r\nmod tests {\r\n use super::shortest_palindrome;\r\n macro_rules! test_shortest_palindrome {\r\n ($($name:ident: $inputs:expr,)*) => {\r\n $(\r\n #[test]\r\n fn $name() {\r\n use crate::string:... | true | ||
TheAlgorithms/Rust | 689 | comment_to_fix | KMP solves the shortest palindrome | Please add tests with Unicode characters. | 95bf686ceda88d9828900fde8fe7e63a1671b9aa | 929c86c42b62eb655cc95a4e0bceb911aaae5857 | diff --git a/src/string/shortest_palindrome.rs b/src/string/shortest_palindrome.rs
new file mode 100644
index 00000000000..80f52395194
--- /dev/null
+++ b/src/string/shortest_palindrome.rs
@@ -0,0 +1,72 @@
+/*
+The function shortest_palindrome expands the given string to shortest palindrome by adding a shortest prefix.... | [
"src/string/shortest_palindrome.rs"
] | [
{
"comment": "Please add tests with Unicode characters.",
"path": "src/string/shortest_palindrome.rs",
"hunk": "@@ -0,0 +1,54 @@\n+/*\n+KMP. Source：https://www.scaler.com/topics/data-structures/kmp-algorithm/\n+Prefix Functions and KPM. Source：https://oi-wiki.org/string/kmp/\n+*/\n+\n+pub fn shortest_pa... | true | ||
TheAlgorithms/Rust | 689 | comment_to_fix | KMP solves the shortest palindrome | I see that you are using TDD :smile:. | 95bf686ceda88d9828900fde8fe7e63a1671b9aa | 929c86c42b62eb655cc95a4e0bceb911aaae5857 | diff --git a/src/string/shortest_palindrome.rs b/src/string/shortest_palindrome.rs
new file mode 100644
index 00000000000..80f52395194
--- /dev/null
+++ b/src/string/shortest_palindrome.rs
@@ -0,0 +1,72 @@
+/*
+The function shortest_palindrome expands the given string to shortest palindrome by adding a shortest prefix.... | [
"src/string/shortest_palindrome.rs"
] | [
{
"comment": "I see that you are using TDD :smile:.",
"path": "src/string/shortest_palindrome.rs",
"hunk": "@@ -0,0 +1,57 @@\n+/*\n+The function shortest_palindrome expands the given string to shortest palindrome by adding a shortest prefix.\n+KMP. Source：https://www.scaler.com/topics/data-structures/km... | true | ||
TheAlgorithms/Rust | 689 | comment_to_fix | KMP solves the shortest palindrome | I think one should add at least one more test case:
```suggestion
unicode_2: ("牛", "牛"),
unicode_3: ("a牛", "牛a牛"),
``` | 95bf686ceda88d9828900fde8fe7e63a1671b9aa | 929c86c42b62eb655cc95a4e0bceb911aaae5857 | diff --git a/src/string/shortest_palindrome.rs b/src/string/shortest_palindrome.rs
new file mode 100644
index 00000000000..80f52395194
--- /dev/null
+++ b/src/string/shortest_palindrome.rs
@@ -0,0 +1,72 @@
+/*
+The function shortest_palindrome expands the given string to shortest palindrome by adding a shortest prefix.... | [
"src/string/shortest_palindrome.rs"
] | [
{
"comment": "I think one should add at least one more test case:\r\n```suggestion\r\n unicode_2: (\"牛\", \"牛\"),\r\n unicode_3: (\"a牛\", \"牛a牛\"),\r\n```",
"path": "src/string/shortest_palindrome.rs",
"hunk": "@@ -0,0 +1,57 @@\n+/*\n+The function shortest_palindrome expands the given string to sh... | true | ||
TheAlgorithms/Rust | 689 | comment_to_fix | KMP solves the shortest palindrome | What happens here? I think that it could be moved to a separate function. | 95bf686ceda88d9828900fde8fe7e63a1671b9aa | 929c86c42b62eb655cc95a4e0bceb911aaae5857 | diff --git a/src/string/shortest_palindrome.rs b/src/string/shortest_palindrome.rs
new file mode 100644
index 00000000000..80f52395194
--- /dev/null
+++ b/src/string/shortest_palindrome.rs
@@ -0,0 +1,72 @@
+/*
+The function shortest_palindrome expands the given string to shortest palindrome by adding a shortest prefix.... | [
"src/string/shortest_palindrome.rs"
] | [
{
"comment": "What happens here? I think that it could be moved to a separate function.",
"path": "src/string/shortest_palindrome.rs",
"hunk": "@@ -0,0 +1,57 @@\n+/*\n+The function shortest_palindrome expands the given string to shortest palindrome by adding a shortest prefix.\n+KMP. Source：https://www.... | true | ||
TheAlgorithms/Rust | 689 | comment_to_fix | KMP solves the shortest palindrome | Same as above. | 95bf686ceda88d9828900fde8fe7e63a1671b9aa | 929c86c42b62eb655cc95a4e0bceb911aaae5857 | diff --git a/src/string/shortest_palindrome.rs b/src/string/shortest_palindrome.rs
new file mode 100644
index 00000000000..80f52395194
--- /dev/null
+++ b/src/string/shortest_palindrome.rs
@@ -0,0 +1,72 @@
+/*
+The function shortest_palindrome expands the given string to shortest palindrome by adding a shortest prefix.... | [
"src/string/shortest_palindrome.rs"
] | [
{
"comment": "Same as above.",
"path": "src/string/shortest_palindrome.rs",
"hunk": "@@ -0,0 +1,57 @@\n+/*\n+The function shortest_palindrome expands the given string to shortest palindrome by adding a shortest prefix.\n+KMP. Source：https://www.scaler.com/topics/data-structures/kmp-algorithm/\n+Prefix F... | true | ||
TheAlgorithms/Rust | 689 | comment_to_fix | KMP solves the shortest palindrome | Same as above. | 95bf686ceda88d9828900fde8fe7e63a1671b9aa | 929c86c42b62eb655cc95a4e0bceb911aaae5857 | diff --git a/src/string/shortest_palindrome.rs b/src/string/shortest_palindrome.rs
new file mode 100644
index 00000000000..80f52395194
--- /dev/null
+++ b/src/string/shortest_palindrome.rs
@@ -0,0 +1,72 @@
+/*
+The function shortest_palindrome expands the given string to shortest palindrome by adding a shortest prefix.... | [
"src/string/shortest_palindrome.rs"
] | [
{
"comment": "Same as above.",
"path": "src/string/shortest_palindrome.rs",
"hunk": "@@ -0,0 +1,57 @@\n+/*\n+The function shortest_palindrome expands the given string to shortest palindrome by adding a shortest prefix.\n+KMP. Source：https://www.scaler.com/topics/data-structures/kmp-algorithm/\n+Prefix F... | true | ||
TheAlgorithms/Rust | 689 | comment_to_fix | KMP solves the shortest palindrome | There are few changes in this _monster suggestion_:
```suggestion
pub fn shortest_palindrome(s: &str) -> String {
if s.is_empty() {
return "".to_string();
}
let p_chars: Vec<char> = s.chars().collect();
let suffix = raw_suffix_function(&p_chars);
let mut s_chars: Vec<char> = s.... | 95bf686ceda88d9828900fde8fe7e63a1671b9aa | 929c86c42b62eb655cc95a4e0bceb911aaae5857 | diff --git a/src/string/shortest_palindrome.rs b/src/string/shortest_palindrome.rs
new file mode 100644
index 00000000000..80f52395194
--- /dev/null
+++ b/src/string/shortest_palindrome.rs
@@ -0,0 +1,72 @@
+/*
+The function shortest_palindrome expands the given string to shortest palindrome by adding a shortest prefix.... | [
"src/string/shortest_palindrome.rs"
] | [
{
"comment": "There are few changes in this _monster suggestion_:\r\n\r\n```suggestion\r\npub fn shortest_palindrome(s: &str) -> String {\r\n if s.is_empty() {\r\n return \"\".to_string();\r\n }\r\n\r\n let p_chars: Vec<char> = s.chars().collect();\r\n let suffix = raw_suffix_function(&p_char... | true | ||
TheAlgorithms/Rust | 689 | comment_to_fix | KMP solves the shortest palindrome | One should avoid clones. Here cloning is not needed. | 95bf686ceda88d9828900fde8fe7e63a1671b9aa | 929c86c42b62eb655cc95a4e0bceb911aaae5857 | diff --git a/src/string/shortest_palindrome.rs b/src/string/shortest_palindrome.rs
new file mode 100644
index 00000000000..80f52395194
--- /dev/null
+++ b/src/string/shortest_palindrome.rs
@@ -0,0 +1,72 @@
+/*
+The function shortest_palindrome expands the given string to shortest palindrome by adding a shortest prefix.... | [
"src/string/shortest_palindrome.rs"
] | [
{
"comment": "One should avoid clones. Here cloning is not needed.",
"path": "src/string/shortest_palindrome.rs",
"hunk": "@@ -0,0 +1,73 @@\n+/*\n+The function shortest_palindrome expands the given string to shortest palindrome by adding a shortest prefix.\n+KMP. Source：https://www.scaler.com/topics/dat... | true | ||
TheAlgorithms/Rust | 689 | comment_to_fix | KMP solves the shortest palindrome | computing `s.chars().count()` is very expensive. The number of characters can be obtained from `p_chars`. | 95bf686ceda88d9828900fde8fe7e63a1671b9aa | 929c86c42b62eb655cc95a4e0bceb911aaae5857 | diff --git a/src/string/shortest_palindrome.rs b/src/string/shortest_palindrome.rs
new file mode 100644
index 00000000000..80f52395194
--- /dev/null
+++ b/src/string/shortest_palindrome.rs
@@ -0,0 +1,72 @@
+/*
+The function shortest_palindrome expands the given string to shortest palindrome by adding a shortest prefix.... | [
"src/string/shortest_palindrome.rs"
] | [
{
"comment": "computing `s.chars().count()` is very expensive. The number of characters can be obtained from `p_chars`.",
"path": "src/string/shortest_palindrome.rs",
"hunk": "@@ -0,0 +1,73 @@\n+/*\n+The function shortest_palindrome expands the given string to shortest palindrome by adding a shortest pr... | true | ||
TheAlgorithms/Rust | 689 | comment_to_fix | KMP solves the shortest palindrome | ```suggestion
#[cfg(test)]
mod tests {
use crate::string::shortest_palindrome;
macro_rules! test_shortest_palindrome {
($($name:ident: $inputs:expr,)*) => {
$(
#[test]
fn $name() {
use crate::string::is_palindrome;
let (s, expected) =... | 95bf686ceda88d9828900fde8fe7e63a1671b9aa | 929c86c42b62eb655cc95a4e0bceb911aaae5857 | diff --git a/src/string/shortest_palindrome.rs b/src/string/shortest_palindrome.rs
new file mode 100644
index 00000000000..80f52395194
--- /dev/null
+++ b/src/string/shortest_palindrome.rs
@@ -0,0 +1,72 @@
+/*
+The function shortest_palindrome expands the given string to shortest palindrome by adding a shortest prefix.... | [
"src/string/shortest_palindrome.rs"
] | [
{
"comment": "```suggestion\r\n#[cfg(test)]\r\nmod tests {\r\n use crate::string::shortest_palindrome;\r\n macro_rules! test_shortest_palindrome {\r\n ($($name:ident: $inputs:expr,)*) => {\r\n $(\r\n #[test]\r\n fn $name() {\r\n use crate::string::is_palindro... | true | ||
TheAlgorithms/Rust | 845 | issue_to_patch | chore: suppress new clippy warnings | # Pull Request Template
## Description
This PR suppresses these new clippy warnings, which cause problems. Similar to
- #754
- #789
- #838
## Type of change
Please delete options that are not relevant.
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which... | dadb978f633d8eb0cc92c5bc483adca5d8974c6b | f8fb558313e6dab2e829c1b1d197af124b348b5e | diff --git a/Cargo.toml b/Cargo.toml
index b4e9d7cc8bf..ea4dc987b9b 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -76,6 +76,7 @@ unnested_or_patterns = { level = "allow", priority = 1 }
unreadable_literal = { level = "allow", priority = 1 }
unused_self = { level = "allow", priority = 1 }
used_underscore_binding = { le... | [
"Cargo.toml",
"src/data_structures/veb_tree.rs"
] | [] | true | ||
TheAlgorithms/Rust | 828 | issue_to_patch | fibonacci: add binary lifting version | # Pull Request Template
## Description
Reference: https://1-oi--wiki-org.translate.goog/math/combinatorics/fibonacci/?_x_tr_sl=auto&_x_tr_tl=en&_x_tr_hl=zh-CN&_x_tr_pto=wapp&_x_tr_enc=1#%E5%BF%AB%E9%80%9F%E5%80%8D%E5%A2%9E%E6%B3%95
## Type of change
Please delete options that are not relevant.
- [x] New ... | f5ab10280deabb02dafd5e1a1da1265678acfaa3 | 095cd00d269dfa8db60d6de75c47eec0586d791b | diff --git a/src/dynamic_programming/fibonacci.rs b/src/dynamic_programming/fibonacci.rs
index 2ea0c672bd5..a7db9f9562c 100644
--- a/src/dynamic_programming/fibonacci.rs
+++ b/src/dynamic_programming/fibonacci.rs
@@ -180,6 +180,33 @@ fn matrix_multiply(multiplier: &[Vec<u128>], multiplicand: &[Vec<u128>]) -> Vec<
... | [
"src/dynamic_programming/fibonacci.rs",
"src/dynamic_programming/mod.rs"
] | [] | true | ||
TheAlgorithms/Rust | 716 | issue_to_patch | feat: add `multiply.rs` | Given two non-negative integers num1 and num2 expressed as strings, returns the product of num1 and num2, which is also expressed as a string.
Note: You cannot use any of the built-in BigInteger libraries or directly convert the input to an integer. | bba0b0dc929d15110538c70c4582b6190c0436a5 | 78623af8b4668e2b7733c15e39c813e66e7bf168 | diff --git a/DIRECTORY.md b/DIRECTORY.md
index ccece909ffa..220e7815dda 100644
--- a/DIRECTORY.md
+++ b/DIRECTORY.md
@@ -10,6 +10,7 @@
* [Sudoku](https://github.com/TheAlgorithms/Rust/blob/master/src/backtracking/sudoku.rs)
* Big Integer
* [Fast Factorial](https://github.com/TheAlgorithms/Rust/blob/master/... | [
"DIRECTORY.md",
"src/big_integer/mod.rs",
"src/big_integer/multiply.rs"
] | [
{
"comment": "This is a _problem statement_. Please change it to a proper _documentation_ (i.e. an explanation what does your code do)",
"path": "src/string/multiply.rs",
"hunk": "@@ -0,0 +1,54 @@\n+/*\n+Given two non-negative integers num1 and num2 expressed as strings, returns the product of num1 and ... | true | ||
TheAlgorithms/Rust | 716 | comment_to_fix | feat: add `multiply.rs` | What do you think about moving this file into the [src/big_integer](https://github.com/TheAlgorithms/Rust/tree/master/src/big_integer)? | bba0b0dc929d15110538c70c4582b6190c0436a5 | 78623af8b4668e2b7733c15e39c813e66e7bf168 | diff --git a/DIRECTORY.md b/DIRECTORY.md
index ccece909ffa..220e7815dda 100644
--- a/DIRECTORY.md
+++ b/DIRECTORY.md
@@ -10,6 +10,7 @@
* [Sudoku](https://github.com/TheAlgorithms/Rust/blob/master/src/backtracking/sudoku.rs)
* Big Integer
* [Fast Factorial](https://github.com/TheAlgorithms/Rust/blob/master/... | [
"DIRECTORY.md"
] | [
{
"comment": "What do you think about moving this file into the [src/big_integer](https://github.com/TheAlgorithms/Rust/tree/master/src/big_integer)?",
"path": "DIRECTORY.md",
"hunk": "",
"resolving_sha": "78623af8b4668e2b7733c15e39c813e66e7bf168",
"resolving_diff": "diff --git a/DIRECTORY.md b/... | true | ||
TheAlgorithms/Rust | 716 | comment_to_fix | feat: add `multiply.rs` | Maybe something like
```suggestion
/// Performs a long multiplication on numbers represented by strings.
```
Also please document, that both of the strings should actually represent non-negative numbers. | bba0b0dc929d15110538c70c4582b6190c0436a5 | 78623af8b4668e2b7733c15e39c813e66e7bf168 | diff --git a/src/big_integer/multiply.rs b/src/big_integer/multiply.rs
new file mode 100644
index 00000000000..1f7d1a57de3
--- /dev/null
+++ b/src/big_integer/multiply.rs
@@ -0,0 +1,77 @@
+/// Performs long multiplication on string representations of non-negative numbers.
+pub fn multiply(num1: &str, num2: &str) -> Str... | [
"src/big_integer/multiply.rs"
] | [
{
"comment": "Maybe something like\r\n```suggestion\r\n/// Performs a long multiplication on numbers represented by strings.\r\n```\r\nAlso please document, that both of the strings should actually represent non-negative numbers.",
"path": "src/big_integer/multiply.rs",
"hunk": "@@ -0,0 +1,64 @@\n+/// C... | true | ||
TheAlgorithms/Rust | 716 | comment_to_fix | feat: add `multiply.rs` | This line is never executed, because the line above panics. | bba0b0dc929d15110538c70c4582b6190c0436a5 | 78623af8b4668e2b7733c15e39c813e66e7bf168 | diff --git a/src/big_integer/multiply.rs b/src/big_integer/multiply.rs
new file mode 100644
index 00000000000..1f7d1a57de3
--- /dev/null
+++ b/src/big_integer/multiply.rs
@@ -0,0 +1,77 @@
+/// Performs long multiplication on string representations of non-negative numbers.
+pub fn multiply(num1: &str, num2: &str) -> Str... | [
"src/big_integer/multiply.rs"
] | [
{
"comment": "This line is never executed, because the line above panics.",
"path": "src/big_integer/multiply.rs",
"hunk": "@@ -0,0 +1,64 @@\n+/// Compute the multiplier of two strings of numbers\n+///（Negative numbers and strings of numbers starting with 0 are not supported at this time）\n+\n+pub fn mu... | true | ||
TheAlgorithms/Rust | 716 | comment_to_fix | feat: add `multiply.rs` | ```suggestion
let mul = c1.to_digit(10).unwrap() * c2.to_digit(10).unwrap();
``` | bba0b0dc929d15110538c70c4582b6190c0436a5 | 78623af8b4668e2b7733c15e39c813e66e7bf168 | diff --git a/src/big_integer/multiply.rs b/src/big_integer/multiply.rs
new file mode 100644
index 00000000000..1f7d1a57de3
--- /dev/null
+++ b/src/big_integer/multiply.rs
@@ -0,0 +1,77 @@
+/// Performs long multiplication on string representations of non-negative numbers.
+pub fn multiply(num1: &str, num2: &str) -> Str... | [
"src/big_integer/multiply.rs"
] | [
{
"comment": "```suggestion\r\n let mul = c1.to_digit(10).unwrap() * c2.to_digit(10).unwrap();\r\n```",
"path": "src/big_integer/multiply.rs",
"hunk": "@@ -0,0 +1,64 @@\n+/// Compute the multiplier of two strings of numbers\n+///（Negative numbers and strings of numbers starting with 0 are not... | true | ||
TheAlgorithms/Rust | 716 | comment_to_fix | feat: add `multiply.rs` | `multiply("wrong_input", "0")` will still return `"0"`. | bba0b0dc929d15110538c70c4582b6190c0436a5 | 78623af8b4668e2b7733c15e39c813e66e7bf168 | diff --git a/src/big_integer/multiply.rs b/src/big_integer/multiply.rs
new file mode 100644
index 00000000000..1f7d1a57de3
--- /dev/null
+++ b/src/big_integer/multiply.rs
@@ -0,0 +1,77 @@
+/// Performs long multiplication on string representations of non-negative numbers.
+pub fn multiply(num1: &str, num2: &str) -> Str... | [
"src/big_integer/multiply.rs"
] | [
{
"comment": "`multiply(\"wrong_input\", \"0\")` will still return `\"0\"`.",
"path": "src/big_integer/multiply.rs",
"hunk": "@@ -0,0 +1,73 @@\n+/// Performs long multiplication on string representations of non-negative numbers.\n+\n+pub fn multiply(num1: &str, num2: &str) -> String {\n+ if num1 == \... | true | ||
TheAlgorithms/Rust | 716 | comment_to_fix | feat: add `multiply.rs` | Why don't you introduce a function like
```rust
fun is_valid_nonnegative(num: &str) -> bool {
//...
}
```
and then
```suggestion
if !is_valid_nonnegative(num1) || !is_valid_nonnegative(num2)
{
panic!("String does not conform to specification")
}
``` | bba0b0dc929d15110538c70c4582b6190c0436a5 | 78623af8b4668e2b7733c15e39c813e66e7bf168 | diff --git a/src/big_integer/multiply.rs b/src/big_integer/multiply.rs
new file mode 100644
index 00000000000..1f7d1a57de3
--- /dev/null
+++ b/src/big_integer/multiply.rs
@@ -0,0 +1,77 @@
+/// Performs long multiplication on string representations of non-negative numbers.
+pub fn multiply(num1: &str, num2: &str) -> Str... | [
"src/big_integer/multiply.rs"
] | [
{
"comment": "Why don't you introduce a function like\r\n```rust\r\nfun is_valid_nonnegative(num: &str) -> bool {\r\n //...\r\n}\r\n```\r\n\r\nand then\r\n```suggestion\r\n if !is_valid_nonnegative(num1) || !is_valid_nonnegative(num2)\r\n {\r\n panic!(\"String does not conform to specification\"... | true | ||
TheAlgorithms/Rust | 716 | comment_to_fix | feat: add `multiply.rs` | ```suggestion
macro_rules! test_multiply_with_wrong_input {
($($name:ident: $inputs:expr,)*) => {
$(
#[test]
#[should_panic]
fn $name() {
let (s, t) = $inputs;
multiply(s, t);
}
)*
}
}
... | bba0b0dc929d15110538c70c4582b6190c0436a5 | 78623af8b4668e2b7733c15e39c813e66e7bf168 | diff --git a/src/big_integer/multiply.rs b/src/big_integer/multiply.rs
new file mode 100644
index 00000000000..1f7d1a57de3
--- /dev/null
+++ b/src/big_integer/multiply.rs
@@ -0,0 +1,77 @@
+/// Performs long multiplication on string representations of non-negative numbers.
+pub fn multiply(num1: &str, num2: &str) -> Str... | [
"src/big_integer/multiply.rs"
] | [
{
"comment": "```suggestion\r\n macro_rules! test_multiply_with_wrong_input {\r\n ($($name:ident: $inputs:expr,)*) => {\r\n $(\r\n #[test]\r\n #[should_panic]\r\n fn $name() {\r\n let (s, t) = $inputs;\r\n multiply(s, t);\r\n ... | true | ||
TheAlgorithms/Rust | 716 | comment_to_fix | feat: add `multiply.rs` | ```suggestion
num.chars().all(char::is_numeric) && !num.is_empty() && (!num.starts_with('0') || num == "0")
``` | bba0b0dc929d15110538c70c4582b6190c0436a5 | 78623af8b4668e2b7733c15e39c813e66e7bf168 | diff --git a/src/big_integer/multiply.rs b/src/big_integer/multiply.rs
new file mode 100644
index 00000000000..1f7d1a57de3
--- /dev/null
+++ b/src/big_integer/multiply.rs
@@ -0,0 +1,77 @@
+/// Performs long multiplication on string representations of non-negative numbers.
+pub fn multiply(num1: &str, num2: &str) -> Str... | [
"src/big_integer/multiply.rs"
] | [
{
"comment": "```suggestion\r\n num.chars().all(char::is_numeric) && !num.is_empty() && (!num.starts_with('0') || num == \"0\")\r\n```",
"path": "src/big_integer/multiply.rs",
"hunk": "@@ -0,0 +1,78 @@\n+/// Performs long multiplication on string representations of non-negative numbers.\n+\n+pub fn m... | true | ||
TheAlgorithms/Rust | 716 | comment_to_fix | feat: add `multiply.rs` | ```suggestion
leading_zero: ("01", "3"),
``` | bba0b0dc929d15110538c70c4582b6190c0436a5 | 78623af8b4668e2b7733c15e39c813e66e7bf168 | diff --git a/src/big_integer/multiply.rs b/src/big_integer/multiply.rs
new file mode 100644
index 00000000000..1f7d1a57de3
--- /dev/null
+++ b/src/big_integer/multiply.rs
@@ -0,0 +1,77 @@
+/// Performs long multiplication on string representations of non-negative numbers.
+pub fn multiply(num1: &str, num2: &str) -> Str... | [
"src/big_integer/multiply.rs"
] | [
{
"comment": "```suggestion\r\n leading_zero: (\"01\", \"3\"),\r\n```",
"path": "src/big_integer/multiply.rs",
"hunk": "@@ -0,0 +1,78 @@\n+/// Performs long multiplication on string representations of non-negative numbers.\n+\n+pub fn multiply(num1: &str, num2: &str) -> String {\n+ if !is_vali... | true | ||
TheAlgorithms/Rust | 716 | comment_to_fix | feat: add `multiply.rs` | ```suggestion
``` | bba0b0dc929d15110538c70c4582b6190c0436a5 | 78623af8b4668e2b7733c15e39c813e66e7bf168 | diff --git a/src/big_integer/multiply.rs b/src/big_integer/multiply.rs
new file mode 100644
index 00000000000..1f7d1a57de3
--- /dev/null
+++ b/src/big_integer/multiply.rs
@@ -0,0 +1,77 @@
+/// Performs long multiplication on string representations of non-negative numbers.
+pub fn multiply(num1: &str, num2: &str) -> Str... | [
"src/big_integer/multiply.rs"
] | [
{
"comment": "```suggestion\r\n```",
"path": "src/big_integer/multiply.rs",
"hunk": "@@ -0,0 +1,78 @@\n+/// Performs long multiplication on string representations of non-negative numbers.\n+",
"resolving_sha": "78623af8b4668e2b7733c15e39c813e66e7bf168",
"resolving_diff": "diff --git a/src/big_in... | true | ||
TheAlgorithms/Rust | 912 | issue_to_patch | fix(huffman): Handle edge cases and improve error handling | ## Description
This PR improves the robustness of the Huffman encoding implementation by properly handling edge cases that previously caused undefined behavior or panics.
### Summary of changes:
- Changed `HuffmanDictionary::new()` to return `Option<Self>` for safer API design
- Added proper handling for empty ... | f2a23e9efcd3b44a130dd89a5c902b0eaf764e4d | d64d56d5bc8ea35ba2910787849576dfb0d2b5e4 | diff --git a/src/general/huffman_encoding.rs b/src/general/huffman_encoding.rs
index fc26d3cb5ee..4582d419f8f 100644
--- a/src/general/huffman_encoding.rs
+++ b/src/general/huffman_encoding.rs
@@ -77,10 +77,50 @@ pub struct HuffmanDictionary<T> {
}
impl<T: Clone + Copy + Ord> HuffmanDictionary<T> {
- /// The lis... | [
"src/general/huffman_encoding.rs"
] | [
{
"comment": "This seems not relevant. Please revert it here and create another tiny PR - we will merge it.",
"path": "src/machine_learning/loss_function/kl_divergence_loss.rs",
"hunk": "@@ -16,7 +16,7 @@ pub fn kld_loss(actual: &[f64], predicted: &[f64]) -> f64 {\n let loss: f64 = actual\n ... | true | ||
TheAlgorithms/Rust | 854 | issue_to_patch | style: include `redundant_clone` | # Pull Request Template
## Description
This PR removes [`redundant_clone`](https://rust-lang.github.io/rust-clippy/master/index.html#redundant_clone) from the list of from the list of suppressed lints.
Continuation of #743.
## Checklist:
- [x] I ran bellow commands using the latest version of **rust nigh... | ff1df124f2c9e493d1c9fad5f69183c01a463b63 | 86c76667a29ef50504d5068cbdc4635ae1a28445 | diff --git a/Cargo.toml b/Cargo.toml
index ad29212e814..12e6fed2e2c 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -160,7 +160,6 @@ imprecise_flops = { level = "allow", priority = 1 }
missing_const_for_fn = { level = "allow", priority = 1 }
nonstandard_macro_braces = { level = "allow", priority = 1 }
option_if_let_else... | [
"Cargo.toml",
"src/graph/decremental_connectivity.rs",
"src/machine_learning/cholesky.rs",
"src/math/softmax.rs"
] | [] | true | ||
TheAlgorithms/Rust | 804 | issue_to_patch | Improve Work Break | ## Checklist:
- [x] I ran bellow commands using the latest version of **rust nightly**.
- [x] I ran `cargo clippy --all -- -D warnings` just before my last commit and fixed any issue that was found.
- [x] I ran `cargo fmt` just before my last commit.
- [x] I ran `cargo test` just before my last commit and all tes... | be27f2c49247c4eebcbb915e81748c6215b49c85 | 258761fb70e569b69a4813b9a7b5d6be9705bd68 | diff --git a/src/dynamic_programming/word_break.rs b/src/dynamic_programming/word_break.rs
index fa7e9491cfc..f3153525f6e 100644
--- a/src/dynamic_programming/word_break.rs
+++ b/src/dynamic_programming/word_break.rs
@@ -1,27 +1,38 @@
-// Given a string and a list of words, return true if the string can be
-// segmente... | [
"src/dynamic_programming/word_break.rs"
] | [] | true | ||
TheAlgorithms/Rust | 877 | issue_to_patch | chore: suppress new clippy lints | # Pull Request Template
## Description
This PR suppresses new clippy lints (cf. [logs](https://github.com/TheAlgorithms/Rust/actions/runs/14371434231/job/40295111895)).
Similar to:
- #754
- #755
- #845
- #865
- #871
## Checklist:
- [x] I ran bellow commands using the latest version of **rust nightly**... | 6493799d76ab908a56bc233643f7aa1c3f886c9e | f163277185fdd2e205f621676f4945ce3557a959 | diff --git a/Cargo.toml b/Cargo.toml
index d2707aa5e3b..5ac4b4e1f77 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -68,6 +68,7 @@ unreadable_literal = { level = "allow", priority = 1 }
unused_self = { level = "allow", priority = 1 }
used_underscore_binding = { level = "allow", priority = 1 }
ref_option = { level = "all... | [
"Cargo.toml"
] | [] | true | ||
TheAlgorithms/Rust | 700 | issue_to_patch | fix: suppress clippy warning | # Pull Request Template
## Description
One of the [recent jobs](https://github.com/TheAlgorithms/Rust/actions/runs/8481497233/job/23238945730?pr=695#step:3:91) has failed due to some new clippy warning. Basically the problem is that the second coordinate of `Point` defined in:
https://github.com/TheAlgorithms/Ru... | 1d72d9fa706af87d9e90db91140bcd6d6adc14eb | cf7e08f6a37f3e4c12948974996f52aa1295bb58 | diff --git a/src/data_structures/heap.rs b/src/data_structures/heap.rs
index c6032edfd91..2d882f7af48 100644
--- a/src/data_structures/heap.rs
+++ b/src/data_structures/heap.rs
@@ -156,6 +156,7 @@ mod tests {
assert_eq!(heap.pop(), Some(2));
}
+ #[allow(dead_code)]
struct Point(/* x */ i32, /* y... | [
"src/data_structures/heap.rs"
] | [] | true | ||
TheAlgorithms/Rust | 792 | issue_to_patch | Simplify Binary Search Recursive Implementation | Reference from Binary Search Implementation
## Checklist:
- [x] I ran bellow commands using the latest version of **rust nightly**.
- [x] I ran `cargo clippy --all -- -D warnings` just before my last commit and fixed any issue that was found.
- [x] I ran `cargo fmt` just before my last commit.
- [x] I ran `car... | 157c14a78fbe2965ad6706b53d78e539a809e14e | a1ee8ab19d8d543444b9d73603e622005fe0540b | diff --git a/src/searching/binary_search_recursive.rs b/src/searching/binary_search_recursive.rs
index 14740e4800d..e83fa2f48d5 100644
--- a/src/searching/binary_search_recursive.rs
+++ b/src/searching/binary_search_recursive.rs
@@ -1,31 +1,42 @@
use std::cmp::Ordering;
-pub fn binary_search_rec<T: Ord>(
- list_o... | [
"src/searching/binary_search_recursive.rs"
] | [] | true | ||
TheAlgorithms/Rust | 780 | issue_to_patch | Add custom error types `HammingDistanceError` | ## Checklist
- [x] I ran bellow commands using the latest version of **rust nightly**.
- [x] I ran `cargo clippy --all -- -D warnings` just before my last commit and fixed any issue that was found.
- [x] I ran `cargo fmt` just before my last commit.
- [x] I ran `cargo test` just before my last commit and all tes... | c51bc8927817e363f08e663fd0107b80ebf92b0f | ef167ef4a308c32f6ba5dc415af5e71924e10226 | diff --git a/src/string/hamming_distance.rs b/src/string/hamming_distance.rs
index 4858db24542..3137d5abc7c 100644
--- a/src/string/hamming_distance.rs
+++ b/src/string/hamming_distance.rs
@@ -1,13 +1,24 @@
-pub fn hamming_distance(string_a: &str, string_b: &str) -> usize {
+/// Error type for Hamming distance calculat... | [
"src/string/hamming_distance.rs"
] | [] | true | ||
TheAlgorithms/Rust | 760 | issue_to_patch | style: include `inefficient_to_string` | # Pull Request Template
## Description
This PR removes the [`inefficient_to_string`](https://rust-lang.github.io/rust-clippy/master/#/inefficient_to_string) from the list of suppressed lints.
Continuation of #743.
## Checklist:
- [x] I ran bellow commands using the latest version of **rust nightly**.
- [x... | 218c4a8758667fc6d3784bda563fbe1e98fc04b4 | f2420c00744e8fc06955fe5decad0b31f92e3270 | diff --git a/Cargo.toml b/Cargo.toml
index 162eebed55a..4ecc28a2de7 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -43,7 +43,6 @@ from_iter_instead_of_collect = { level = "allow", priority = 1 }
if_not_else = { level = "allow", priority = 1 }
implicit_clone = { level = "allow", priority = 1 }
implicit_hasher = { level ... | [
"Cargo.toml",
"src/ciphers/morse_code.rs"
] | [] | true | ||
TheAngryByrd/MiniScaffold | 320 | issue_to_patch | Use MsBuild assemblyInfo generation
**Is your feature request related to a problem? Please describe.**
We generate assemblyinfo in FAKE with https://github.com/TheAngryByrd/MiniScaffold/blob/7aaf75fa222b943b42ce959cca15571775ed83b6/Content/Library/build/build.fs#L512, however it would be nice to generate all this thr... | Move template AssemblyInfo generation from FAKE files to MSBuild pack-time metadata | - [x] Inspect latest workflow runs and isolate debug macOS failure logs
- [x] Reproduce or reason about failure from logs and current code
- [x] Apply minimal fix for the failing case
- [x] Run minimal targeted validation
- [x] Run code review and CodeQL checks
- [ ] Reply to PR comment with addressing commit hash
<!-... | 7aaf75fa222b943b42ce959cca15571775ed83b6 | 0e24dd8d8bd7d5d515bcbf453bed7421b21f5ae6 | diff --git a/Content/Console/.fantomasignore b/Content/Console/.fantomasignore
deleted file mode 100644
index d9f2aa7f..00000000
--- a/Content/Console/.fantomasignore
+++ /dev/null
@@ -1,2 +0,0 @@
-# Ignore AssemblyInfo files
-AssemblyInfo.fs
diff --git a/Content/Console/Directory.Packages.props b/Content/Console/Direc... | [
"Content/Console/.fantomasignore",
"Content/Console/Directory.Packages.props",
"Content/Console/README.md",
"Content/Console/build/build.fs",
"Content/Console/build/build.fsproj",
"Content/Console/src/Directory.Build.props",
"Content/Console/src/Directory.Build.targets",
"Content/Console/src/MyLib.1/A... | [
{
"comment": "Are these needed if we’re setting them via FAKE?",
"path": "Content/Library/src/Directory.Build.targets",
"hunk": "@@ -1,7 +1,13 @@\n <Project>\n- <PropertyGroup>\n+ <PropertyGroup>\n <RunAnalyzersDuringBuild>true</RunAnalyzersDuringBuild>\n <FSharpAnalyzersOtherFlags>... | diff --git a/tests/MiniScaffold.Tests/Asserts.fs b/tests/MiniScaffold.Tests/Asserts.fs
index fbf5db30..f7ef6f60 100644
--- a/tests/MiniScaffold.Tests/Asserts.fs
+++ b/tests/MiniScaffold.Tests/Asserts.fs
@@ -1,6 +1,10 @@
namespace MiniScaffold.Tests
open System.IO
+open System.IO.Compression
+open System.Diagnostics... | true |
TheAngryByrd/MiniScaffold | 320 | comment_to_fix | Move template AssemblyInfo generation from FAKE files to MSBuild pack-time metadata | Are these needed if we’re setting them via FAKE? | 7aaf75fa222b943b42ce959cca15571775ed83b6 | 0e24dd8d8bd7d5d515bcbf453bed7421b21f5ae6 | diff --git a/Content/Library/src/Directory.Build.targets b/Content/Library/src/Directory.Build.targets
index cde61a89..388db2ad 100644
--- a/Content/Library/src/Directory.Build.targets
+++ b/Content/Library/src/Directory.Build.targets
@@ -1,7 +1,22 @@
<Project>
- <PropertyGroup>
+ <PropertyGroup>
<RunAna... | [
"Content/Library/src/Directory.Build.targets"
] | [
{
"comment": "Are these needed if we’re setting them via FAKE?",
"path": "Content/Library/src/Directory.Build.targets",
"hunk": "@@ -1,7 +1,13 @@\n <Project>\n- <PropertyGroup>\n+ <PropertyGroup>\n <RunAnalyzersDuringBuild>true</RunAnalyzersDuringBuild>\n <FSharpAnalyzersOtherFlags>... | true | ||
TheAngryByrd/MiniScaffold | 320 | comment_to_fix | Move template AssemblyInfo generation from FAKE files to MSBuild pack-time metadata | `<Product>MyLib.1</Product>` is set in `src/Directory.Build.props`, which applies to *all* projects under `src`. In multi-project scenarios (e.g., when additional `projLib` projects are added under `src`), this will stamp every assembly with the same `AssemblyProduct`, which is incorrect. Prefer a per-project value suc... | 7aaf75fa222b943b42ce959cca15571775ed83b6 | 0e24dd8d8bd7d5d515bcbf453bed7421b21f5ae6 | diff --git a/Content/Library/src/Directory.Build.props b/Content/Library/src/Directory.Build.props
index 133c4195..de83db80 100644
--- a/Content/Library/src/Directory.Build.props
+++ b/Content/Library/src/Directory.Build.props
@@ -9,6 +9,8 @@
Project="$([MSBuild]::GetPathOfFileAbove('Directory.Build.props', '$... | [
"Content/Library/src/Directory.Build.props"
] | [
{
"comment": "`<Product>MyLib.1</Product>` is set in `src/Directory.Build.props`, which applies to *all* projects under `src`. In multi-project scenarios (e.g., when additional `projLib` projects are added under `src`), this will stamp every assembly with the same `AssemblyProduct`, which is incorrect. Prefer a... | true | ||
TheAngryByrd/MiniScaffold | 320 | comment_to_fix | Move template AssemblyInfo generation from FAKE files to MSBuild pack-time metadata | `assembly info values are set after pack` loads the DLL into a collectible `AssemblyLoadContext`, but `Unload()` is only called at the end of the function. If any Expecto assertion throws before line 214, the context won't be unloaded and can leave the DLL file locked (especially on Windows), causing later cleanup/test... | 7aaf75fa222b943b42ce959cca15571775ed83b6 | 0e24dd8d8bd7d5d515bcbf453bed7421b21f5ae6 | diff --git a/tests/MiniScaffold.Tests/Asserts.fs b/tests/MiniScaffold.Tests/Asserts.fs
index fbf5db30..f7ef6f60 100644
--- a/tests/MiniScaffold.Tests/Asserts.fs
+++ b/tests/MiniScaffold.Tests/Asserts.fs
@@ -1,6 +1,10 @@
namespace MiniScaffold.Tests
open System.IO
+open System.IO.Compression
+open System.Diagnostics... | [
"tests/MiniScaffold.Tests/Asserts.fs"
] | [
{
"comment": "`assembly info values are set after pack` loads the DLL into a collectible `AssemblyLoadContext`, but `Unload()` is only called at the end of the function. If any Expecto assertion throws before line 214, the context won't be unloaded and can leave the DLL file locked (especially on Windows), caus... | true | ||
TheAngryByrd/MiniScaffold | 320 | comment_to_fix | Move template AssemblyInfo generation from FAKE files to MSBuild pack-time metadata | This assertion hardcodes the build output path to `bin/Debug/net8.0/...dll`. That makes the integration test brittle if the configuration changes (e.g., Release in publish/release scenarios) or if the set/order of TFMs changes. Since the intent is “after pack”, consider locating the packed DLL from the produced `.nupkg... | 7aaf75fa222b943b42ce959cca15571775ed83b6 | 0e24dd8d8bd7d5d515bcbf453bed7421b21f5ae6 | diff --git a/tests/MiniScaffold.Tests/Asserts.fs b/tests/MiniScaffold.Tests/Asserts.fs
index fbf5db30..f7ef6f60 100644
--- a/tests/MiniScaffold.Tests/Asserts.fs
+++ b/tests/MiniScaffold.Tests/Asserts.fs
@@ -1,6 +1,10 @@
namespace MiniScaffold.Tests
open System.IO
+open System.IO.Compression
+open System.Diagnostics... | [
"tests/MiniScaffold.Tests/Asserts.fs"
] | [
{
"comment": "This assertion hardcodes the build output path to `bin/Debug/net8.0/...dll`. That makes the integration test brittle if the configuration changes (e.g., Release in publish/release scenarios) or if the set/order of TFMs changes. Since the intent is “after pack”, consider locating the packed DLL fro... | true | ||
TheAngryByrd/MiniScaffold | 320 | comment_to_fix | Move template AssemblyInfo generation from FAKE files to MSBuild pack-time metadata | `dotnetBuild` conditionally adds `assemblyInfoMsBuildArgs()` when `DotnetPack` is present in the target graph. Since the default target is `DotnetPack`, running the normal build pipeline will now also stamp `Version/AssemblyVersion/FileVersion/InformationalVersion` during the *build* step, not just during packing, whic... | 7aaf75fa222b943b42ce959cca15571775ed83b6 | 0e24dd8d8bd7d5d515bcbf453bed7421b21f5ae6 | diff --git a/Content/Library/build/build.fs b/Content/Library/build/build.fs
index cdd665e2..a0028174 100644
--- a/Content/Library/build/build.fs
+++ b/Content/Library/build/build.fs
@@ -364,6 +364,30 @@ let deleteChangelogBackupFile _ =
if String.isNotNullOrEmpty Changelog.changelogBackupFilename then
Sh... | [
"Content/Library/build/build.fs"
] | [
{
"comment": "`dotnetBuild` conditionally adds `assemblyInfoMsBuildArgs()` when `DotnetPack` is present in the target graph. Since the default target is `DotnetPack`, running the normal build pipeline will now also stamp `Version/AssemblyVersion/FileVersion/InformationalVersion` during the *build* step, not jus... | true | ||
TheAngryByrd/MiniScaffold | 320 | comment_to_fix | Move template AssemblyInfo generation from FAKE files to MSBuild pack-time metadata | `generateAssemblyInfo` is now a hardcoded no-op but the target is still created and wired into the dependency graph (and release flow). This adds confusing dead weight to the build script and makes it unclear where assembly info is supposed to come from. Either remove the `GenerateAssemblyInfo` target/dependencies enti... | 7aaf75fa222b943b42ce959cca15571775ed83b6 | 0e24dd8d8bd7d5d515bcbf453bed7421b21f5ae6 | diff --git a/Content/Library/build/build.fs b/Content/Library/build/build.fs
index cdd665e2..a0028174 100644
--- a/Content/Library/build/build.fs
+++ b/Content/Library/build/build.fs
@@ -364,6 +364,30 @@ let deleteChangelogBackupFile _ =
if String.isNotNullOrEmpty Changelog.changelogBackupFilename then
Sh... | [
"Content/Library/build/build.fs"
] | [
{
"comment": "`generateAssemblyInfo` is now a hardcoded no-op but the target is still created and wired into the dependency graph (and release flow). This adds confusing dead weight to the build script and makes it unclear where assembly info is supposed to come from. Either remove the `GenerateAssemblyInfo` ta... | true | ||
TheAngryByrd/MiniScaffold | 317 | issue_to_patch | MiniScaffold docs page out of date
This page https://www.jimmybyrd.me/MiniScaffold/Reference/Library_Output.html is out of date. The file list at the top does not match the points at the bottom. In both sections there are files that are not in the other section. | Update Library_Output.md to reflect current template file structure | The `Library_Output.md` reference page had a stale file tree and description list that no longer matched the actual generated library template — with entries referencing removed artifacts (`docsTool/`, old bootstrap CSS/JS) and missing entries for files added since.
### File tree
- **Added**: `.config/`, `.devcontaine... | d83974a87db34d544ce4278f4fd6cafaea0583b8 | 1f232e7543b6fc998faec7f6483d641741ec3b74 | diff --git a/docsSrc/Reference/Library_Output.md b/docsSrc/Reference/Library_Output.md
index 9e8cc94f..c56d0304 100644
--- a/docsSrc/Reference/Library_Output.md
+++ b/docsSrc/Reference/Library_Output.md
@@ -4,14 +4,42 @@ When you do an initial scaffold, your folder will be filled with this set of fil
[lang=bash]... | [
"docsSrc/Reference/Library_Output.md"
] | [] | true | |
TheAngryByrd/MiniScaffold | 316 | issue_to_patch | Convert .sln to .slnx | - [x] Convert all `.sln` files to `.slnx` format via `dotnet sln migrate`
- [x] Update `build.fs` references in root, library template, and console template
- [x] Update `.editorconfig` files to use `indent_size = 2` for `.slnx`
- [x] Update documentation references in READMEs and `docsSrc/Reference/Library_Output.md`
... | 8a050fb06499a1df47eb4951bd50f8bba44f84a7 | dcbcc6a8534c64ef2cb76caae5a6e75844707c63 | diff --git a/.editorconfig b/.editorconfig
index 96f80c7f..706cdd18 100644
--- a/.editorconfig
+++ b/.editorconfig
@@ -28,8 +28,8 @@ fsharp_multi_line_lambda_closing_newline=true
# Visual Studio Solution Files
-[*.sln]
-indent_style = tab
+[*.slnx]
+indent_size = 2
# XML project files
[*.{csproj,vbproj,vcxproj... | [
".editorconfig",
"Content/Console/.editorconfig",
"Content/Console/MyLib.1.sln",
"Content/Console/MyLib.1.slnx",
"Content/Console/README.md",
"Content/Console/build/build.fs",
"Content/Library/.editorconfig",
"Content/Library/MyLib.1.sln",
"Content/Library/MyLib.1.slnx",
"Content/Library/README.md... | [] | true | ||
TheAngryByrd/MiniScaffold | 312 | issue_to_patch | Use test-reporter in GitHub actions to display test results.
**Is your feature request related to a problem? Please describe.**
Incorporate https://github.com/dorny/test-reporter to display test results
**Describe the solution you'd like**
A clear and concise description of what you want to happen.
**Describ... | Add test-reporter action to display test results in GitHub Actions | - [x] Add test-reporter action to template workflows (Library and Console)
- [x] Update template build scripts to generate TRX test results with proper naming
- [x] Add test-reporter action to main repository workflow
- [x] Update main repository build script to generate TRX test results
- [x] Fix integration test argu... | 542421e3263f786d47a9b894595f8f6db9bb4c56 | cab2c3504cefff734c8a73dced2e3dab42e839d5 | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 741b48a4..0c748518 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -41,6 +41,13 @@ jobs:
env:
CONFIGURATION: ${{ matrix.configuration }}
CI: true
+ - name: Test Report
+ ... | [
".github/workflows/build.yml",
"Content/Console/.github/workflows/build.yml",
"Content/Console/build/build.fs",
"Content/Library/.github/workflows/build.yml",
"Content/Library/build/build.fs",
"build/build.fs"
] | [] | true | |
TheAngryByrd/MiniScaffold | 315 | issue_to_patch | Prepare for .NET 10: update TFMs, workflows, and infrastructure | - [x] Update root `global.json` to SDK 10.0.100
- [x] Update root `Directory.Packages.props` FSharp.Core 8.0.403 (reverted from 10.0.102 - root build tools don't need .NET 10 FSharp.Core, generated templates have their own)
- [x] Update root `.devcontainer/devcontainer.json` to dotnet 10.0 + additionalVersions 8.0,9.0
... | 357ed2a41a26a0590e946bbecc43437e59dcad53 | 350fb7a71a113753b1471f59a593b840b026ba65 | diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json
index 4f917805..02776440 100644
--- a/.devcontainer/devcontainer.json
+++ b/.devcontainer/devcontainer.json
@@ -23,7 +23,8 @@
"ghcr.io/devcontainers-contrib/features/starship:1": {},
// https://github.com/devcontainers/feat... | [
".devcontainer/devcontainer.json",
".github/workflows/build.yml",
"Content/Console/.devcontainer/devcontainer.json",
"Content/Console/.github/workflows/build.yml",
"Content/Console/Directory.Packages.props",
"Content/Console/README.md",
"Content/Console/global.json",
"Content/Console/src/MyLib.1/Main.... | [
{
"comment": "Package lock file shows a version mismatch: FSharp.Core is requested as \"[10.0.102, )\" but resolved to \"8.0.301\". This indicates that either FSharp.Core 10.0.102 doesn't exist yet, or the package sources don't have it available. The lock file needs to be regenerated once FSharp.Core 10.0.102 i... | diff --git a/Content/Console/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj b/Content/Console/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj
index 18b26887..389837d5 100755
--- a/Content/Console/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj
+++ b/Content/Console/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj
@@ -2,7 +2,7 @@
<Project Sdk="Mi... | true | |
TheAngryByrd/MiniScaffold | 315 | comment_to_fix | Prepare for .NET 10: update TFMs, workflows, and infrastructure | The publish workflow is missing the `10.x` SDK version. Since the library template now multi-targets `net8.0;net9.0;net10.0`, the workflow needs to install .NET 10 SDK to successfully build the net10.0 target framework. Add `10.x` to the dotnet-version list, similar to the build.yml workflow.
```suggestion
... | 357ed2a41a26a0590e946bbecc43437e59dcad53 | 350fb7a71a113753b1471f59a593b840b026ba65 | diff --git a/Content/Library/.github/workflows/publish.yml b/Content/Library/.github/workflows/publish.yml
index 89906bd9..acbe4023 100644
--- a/Content/Library/.github/workflows/publish.yml
+++ b/Content/Library/.github/workflows/publish.yml
@@ -21,7 +21,9 @@ jobs:
with:
global-json-file: global.js... | [
"Content/Library/.github/workflows/publish.yml"
] | [
{
"comment": "The publish workflow is missing the `10.x` SDK version. Since the library template now multi-targets `net8.0;net9.0;net10.0`, the workflow needs to install .NET 10 SDK to successfully build the net10.0 target framework. Add `10.x` to the dotnet-version list, similar to the build.yml workflow.\n```... | true | ||
TheAngryByrd/MiniScaffold | 315 | comment_to_fix | Prepare for .NET 10: update TFMs, workflows, and infrastructure | The fsdocs-gh-pages workflow is missing the `10.x` SDK version. Since the library template now multi-targets `net8.0;net9.0;net10.0`, the workflow needs to install .NET 10 SDK to successfully build documentation for all target frameworks. Add `10.x` to the dotnet-version list, similar to the build.yml workflow.
```sugg... | 357ed2a41a26a0590e946bbecc43437e59dcad53 | 350fb7a71a113753b1471f59a593b840b026ba65 | diff --git a/Content/Library/.github/workflows/fsdocs-gh-pages.yml b/Content/Library/.github/workflows/fsdocs-gh-pages.yml
index 03890cd8..e5116d0d 100644
--- a/Content/Library/.github/workflows/fsdocs-gh-pages.yml
+++ b/Content/Library/.github/workflows/fsdocs-gh-pages.yml
@@ -34,7 +34,9 @@ jobs:
with:
... | [
"Content/Library/.github/workflows/fsdocs-gh-pages.yml"
] | [
{
"comment": "The fsdocs-gh-pages workflow is missing the `10.x` SDK version. Since the library template now multi-targets `net8.0;net9.0;net10.0`, the workflow needs to install .NET 10 SDK to successfully build documentation for all target frameworks. Add `10.x` to the dotnet-version list, similar to the build... | true | ||
TheAngryByrd/MiniScaffold | 306 | issue_to_patch | Optimize SourceLink to only run on Release builds to prevent increment builds from breaking on new commits
**Is your feature request related to a problem? Please describe.**
Update any places that are using SourceLink to only be run during Release Configurations
```
<PropertyGroup Condition="'$(Configuration)' ... | Optimize SourceLink to only run on Release builds to prevent incremental build breakage | ## Optimize SourceLink to only run on Release builds
This PR addresses the issue where SourceLink breaks incremental builds on new commits by optimizing it to only run during Release configurations.
**✅ Rebase Completed and Merged**
The branch has been successfully rebased on the latest master branch (commit 946cd40... | 946cd406d9c8dc716d69b3c1d9700b6673cd003b | 000562893c0857f74c18d307a04eb434ddc2b224 | diff --git a/Content/Library/src/Directory.Build.props b/Content/Library/src/Directory.Build.props
index 758c77d7..133c4195 100644
--- a/Content/Library/src/Directory.Build.props
+++ b/Content/Library/src/Directory.Build.props
@@ -24,6 +24,13 @@
$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</Al... | [
"Content/Library/src/Directory.Build.props"
] | [
{
"comment": "@copilot remove this file",
"path": ".rebase-marker",
"hunk": "@@ -0,0 +1 @@\n+# Rebase completed",
"resolving_sha": "000562893c0857f74c18d307a04eb434ddc2b224",
"resolving_diff": ""
}
] | true | |
TheAngryByrd/MiniScaffold | 311 | issue_to_patch | Consider updating .gitattributes
**Is your feature request related to a problem? Please describe.**
https://rehansaeed.com/gitattributes-best-practices/
https://gist.github.com/Yousha/497397913525af7da814d1711c1eea8d
**Describe the solution you'd like**
A clear and concise description of what you want to happen.
... | Update .gitattributes with comprehensive best practices for .NET projects | Modernizes `.gitattributes` to implement Git LFS for binary assets, proper line ending normalization, and .NET-specific file handling per current best practices.
## Changes
### **Binary File Handling**
- Added Git LFS configuration for images, documents, archives, and media files
- Excludes .NET build artifacts (*.ex... | 5024e28c84f5fb509977e4e1312da418053b60a8 | c989e87cbff1316fab6fdc8dc62dccb74da209ad | diff --git a/.gitattributes b/.gitattributes
index cb6f883d..73947f05 100644
--- a/.gitattributes
+++ b/.gitattributes
@@ -1,27 +1,105 @@
-# Auto detect text files
+# Normalize line endings for all text files
* text=auto
-# Custom for Visual Studio
-*.cs diff=csharp text=auto eol=lf
-*.vb diff=csharp text=auto eol=l... | [
".gitattributes",
"Content/Console/.gitattributes",
"Content/Console/README.md",
"Content/Library/.gitattributes",
"Content/Library/README.md"
] | [
{
"comment": "Git LFS must be installed and initialized in the repository before these filter rules take effect. Consider adding installation/setup instructions to the README or documenting this requirement in the PR description to prevent confusion when team members encounter LFS pointer files instead of actua... | true | |
TheAngryByrd/MiniScaffold | 311 | comment_to_fix | Update .gitattributes with comprehensive best practices for .NET projects | Git LFS must be installed and initialized in the repository before these filter rules take effect. Consider adding installation/setup instructions to the README or documenting this requirement in the PR description to prevent confusion when team members encounter LFS pointer files instead of actual binary content. | 5024e28c84f5fb509977e4e1312da418053b60a8 | c989e87cbff1316fab6fdc8dc62dccb74da209ad | diff --git a/.gitattributes b/.gitattributes
index cb6f883d..73947f05 100644
--- a/.gitattributes
+++ b/.gitattributes
@@ -1,27 +1,105 @@
-# Auto detect text files
+# Normalize line endings for all text files
* text=auto
-# Custom for Visual Studio
-*.cs diff=csharp text=auto eol=lf
-*.vb diff=csharp text=auto eol=l... | [
".gitattributes"
] | [
{
"comment": "Git LFS must be installed and initialized in the repository before these filter rules take effect. Consider adding installation/setup instructions to the README or documenting this requirement in the PR description to prevent confusion when team members encounter LFS pointer files instead of actua... | true | ||
TheAngryByrd/MiniScaffold | 311 | comment_to_fix | Update .gitattributes with comprehensive best practices for .NET projects | Tracking compiled .NET binaries (*.exe, *.dll) in Git contradicts standard .NET practices. These files should be excluded via .gitignore as they are build artifacts. Git LFS is intended for source binary assets (images, documents), not compiler output. Only commit these file types if they represent third-party dependen... | 5024e28c84f5fb509977e4e1312da418053b60a8 | c989e87cbff1316fab6fdc8dc62dccb74da209ad | diff --git a/.gitattributes b/.gitattributes
index cb6f883d..73947f05 100644
--- a/.gitattributes
+++ b/.gitattributes
@@ -1,27 +1,105 @@
-# Auto detect text files
+# Normalize line endings for all text files
* text=auto
-# Custom for Visual Studio
-*.cs diff=csharp text=auto eol=lf
-*.vb diff=csharp text=auto eol=l... | [
".gitattributes"
] | [
{
"comment": "Tracking compiled .NET binaries (*.exe, *.dll) in Git contradicts standard .NET practices. These files should be excluded via .gitignore as they are build artifacts. Git LFS is intended for source binary assets (images, documents), not compiler output. Only commit these file types if they represen... | true | ||
TheAngryByrd/MiniScaffold | 311 | comment_to_fix | Update .gitattributes with comprehensive best practices for .NET projects | @copilot make these lf not crlf
```suggestion
*.csproj text eol=lf merge=union
*.vbproj text eol=lf merge=union
*.fsproj text eol=lf merge=union
*.dbproj text eol=lf merge=union
*.props text eol=lf
*.targets text eol=lf
``` | 5024e28c84f5fb509977e4e1312da418053b60a8 | c989e87cbff1316fab6fdc8dc62dccb74da209ad | diff --git a/.gitattributes b/.gitattributes
index cb6f883d..73947f05 100644
--- a/.gitattributes
+++ b/.gitattributes
@@ -1,27 +1,105 @@
-# Auto detect text files
+# Normalize line endings for all text files
* text=auto
-# Custom for Visual Studio
-*.cs diff=csharp text=auto eol=lf
-*.vb diff=csharp text=auto eol=l... | [
".gitattributes"
] | [
{
"comment": "@copilot make these lf not crlf\r\n```suggestion\r\n*.csproj text eol=lf merge=union\r\n*.vbproj text eol=lf merge=union\r\n*.fsproj text eol=lf merge=union\r\n*.dbproj text eol=lf merge=union\r\n*.props text eol=lf\r\n*.targets text eol=lf\r\n```",
"path": ".gitattributes",
"hunk": "@@ -1... | true | ||
TheAngryByrd/MiniScaffold | 310 | issue_to_patch | Re-enable F# Analyzers
**Is your feature request related to a problem? Please describe.**
Reference work done in https://github.com/TheAngryByrd/IcedTasks/pull/60
Apply this to `Content/Library` and `Content/Console` projects.
**Describe the solution you'd like**
A clear and concise description of what you want to ... | Re-enable F# analyzers in Library and Console templates | ## F# Analyzers Integration Plan - COMPLETED ✅
Based on the IcedTasks PR #60, successfully re-enabled F# Analyzers for both Content/Library and Content/Console templates with latest analyzer package versions.
### Changes Required:
- [x] Add F# analyzer packages to Directory.Packages.props in both Library and Console ... | 5024e28c84f5fb509977e4e1312da418053b60a8 | b0db3a6937618ceb36301f496a267ec39d73728c | diff --git a/Content/Console/.config/dotnet-tools.json b/Content/Console/.config/dotnet-tools.json
index 829f19c8..3e271eda 100644
--- a/Content/Console/.config/dotnet-tools.json
+++ b/Content/Console/.config/dotnet-tools.json
@@ -9,7 +9,7 @@
]
},
"fsharp-analyzers": {
- "version": " 0.10.1",
+ ... | [
"Content/Console/.config/dotnet-tools.json",
"Content/Console/Directory.Packages.props",
"Content/Console/src/Directory.Build.props",
"Content/Console/src/Directory.Build.targets",
"Content/Library/.config/dotnet-tools.json",
"Content/Library/Directory.Packages.props",
"Content/Library/src/Directory.Bui... | [] | true | |
TheAngryByrd/MiniScaffold | 309 | issue_to_patch | Add various properties
**Is your feature request related to a problem? Please describe.**
Add `ProduceReferenceAssembly` to Directory.Build.props
**Describe the solution you'd like**
A clear and concise description of what you want to happen.
**Describe alternatives you've considered**
A clear and concise descript... | Refactor project files to enhance package management and build quality settings | Closes #302 #298
## Proposed Changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to M... | 24a74dd0b1516c029bd77d84b62b5ad54e4729e5 | 841d5f46de543b6abc2035144f36c3ab6f9d788f | diff --git a/.gitignore b/.gitignore
index d35971f0..241a3e52 100644
--- a/.gitignore
+++ b/.gitignore
@@ -270,7 +270,8 @@ coverage.*.xml
# Content specific
Content/Library/docs/
Content/Console/docs/
-Content/**/package.lock.json
+Content/**/packages.lock.json
+
# fsdocs generated
tmp/
diff --git a/Content/Cons... | [
".gitignore",
"Content/Console/Directory.Build.props",
"Content/Console/Directory.Packages.props",
"Content/Console/build/build.fsproj",
"Content/Console/src/Directory.Build.props",
"Content/Library/Directory.Build.props",
"Content/Library/Directory.Packages.props",
"Content/Library/build/build.fs",
... | [] | true | |
TheAngryByrd/MiniScaffold | 308 | issue_to_patch | Run FsharpFormat once per TFM | ## Proposed Changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to MiniScaffold?
_Put a... | 161b97e23e2a8333d308fecc082ed42c0f82e868 | 0443a0c7ce9b71107cdfb65dd2718393e5cb0335 | diff --git a/Content/Console/Directory.Build.targets b/Content/Console/Directory.Build.targets
index 15fe9d8b..206ab2ff 100644
--- a/Content/Console/Directory.Build.targets
+++ b/Content/Console/Directory.Build.targets
@@ -28,7 +28,7 @@ https://learn.microsoft.com/en-us/visualstudio/msbuild/customize-by-directory?vi
... | [
"Content/Console/Directory.Build.targets",
"Content/Library/Directory.Build.targets"
] | [] | true | ||
TheAngryByrd/MiniScaffold | 305 | issue_to_patch | Add dotnet watch to `.props/.targets` files
**Is your feature request related to a problem? Please describe.**
Add
```
<ItemGroup>
<!-- Dotnet Watch to know about this file -->
<Watch Include="$(MSBuildThisFileFullPath)"/>
</ItemGroup>
```
to all `.props` and `.targets` files.
Reference:
... | Add dotnet watch support to .props/.targets files | This PR adds `dotnet watch` support to all `.props` and `.targets` files in the MiniScaffold template project to improve the development experience.
## What this fixes
When using `dotnet watch` during development, changes to MSBuild configuration files (`.props` and `.targets`) were not being detected, requiring manu... | c47c0ec3884d2604684dbc5bda6ede7635e525c1 | a4d8a305c500de36b6c43d9b77c72fee331435ff | diff --git a/Content/Console/Directory.Build.props b/Content/Console/Directory.Build.props
index 26a15e25..ff839db3 100644
--- a/Content/Console/Directory.Build.props
+++ b/Content/Console/Directory.Build.props
@@ -4,6 +4,11 @@ See https://learn.microsoft.com/en-us/visualstudio/msbuild/customize-by-director
-->
<Pr... | [
"Content/Console/Directory.Build.props",
"Content/Console/Directory.Build.targets",
"Content/Console/Directory.Packages.props",
"Content/Console/src/Directory.Build.props",
"Content/Console/tests/Directory.Build.props",
"Content/Library/Directory.Build.props",
"Content/Library/Directory.Build.targets",
... | [] | diff --git a/Content/Console/tests/Directory.Build.props b/Content/Console/tests/Directory.Build.props
index dea99a40..c101424c 100644
--- a/Content/Console/tests/Directory.Build.props
+++ b/Content/Console/tests/Directory.Build.props
@@ -1,4 +1,9 @@
<Project>
+ <ItemGroup>
+ <!-- Dotnet Watch to know about ... | true |
TheAngryByrd/MiniScaffold | 294 | issue_to_patch | ✨ Set up Copilot instructions
Configure instructions for this repository as documented in [Best practices for Copilot coding agent in your repository](https://gh.io/copilot-coding-agent-tips).
<Onboard this repo> | Add comprehensive GitHub Copilot instructions for MiniScaffold development | This PR adds a comprehensive `.github/copilot-instructions.md` file that provides GitHub Copilot coding agents with detailed instructions for working effectively in the MiniScaffold codebase.
## Key Features
The instructions include:
- **Complete setup workflow** with exact commands and timing expectations
- **Templ... | ab9e1edd39644cf233ed1a026d1c27ac4efd48f8 | c9f3dad81da26856687346ae49c66184d179c952 | diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md
new file mode 100644
index 00000000..ddf5b94d
--- /dev/null
+++ b/.github/copilot-instructions.md
@@ -0,0 +1,162 @@
+# MiniScaffold Development Instructions
+
+MiniScaffold is a .NET 8.0 F# template project that generates scaffolding for F# ... | [
".github/copilot-instructions.md"
] | [] | true | |
TheAngryByrd/MiniScaffold | 291 | issue_to_patch | Update GitHub Actions to use latest action versions | ## Proposed Changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to MiniScaffold?
_Put a... | b334dc68a6cbe0d18b9f3c774b6018dd1a342337 | f814cb1cb171b688f0ceb56de549a9712bc63a57 | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index d5e3aa5b..19d349d5 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -18,7 +18,7 @@ jobs:
runs-on: ${{ matrix.os }}
steps:
- - uses: actions/checkout@v4
+ - uses: actions/checkout@v5
- n... | [
".github/workflows/build.yml",
".github/workflows/fsdocs-gh-pages.yml",
".github/workflows/publish.yml",
"Content/Console/.github/workflows/build.yml",
"Content/Library/.github/workflows/build.yml",
"Content/Library/.github/workflows/fsdocs-gh-pages.yml",
"Content/Library/.github/workflows/publish.yml"
... | [] | true | ||
TheAngryByrd/MiniScaffold | 290 | issue_to_patch | Update fantomas version to 7.0.3 in dotnet-tools.json files and fix s… | …pacing in build.fs
## Proposed Changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce t... | 5eec1a5a8204ec2081779c19241c57173c54eaed | 6df241c6e23c004a787588eac29ceb931b886f2e | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 859a91a8..fd371137 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -3,16 +3,18 @@
"isRoot": true,
"tools": {
"fantomas": {
- "version": "6.0.1",
+ "version": "7.0.3",
"commands": [
"fa... | [
".config/dotnet-tools.json",
"Content/Console/.config/dotnet-tools.json",
"Content/Console/build/build.fs",
"Content/Library/.config/dotnet-tools.json",
"Content/Library/build/build.fs"
] | [] | true | ||
TheAngryByrd/MiniScaffold | 289 | issue_to_patch | Paket to nuget | ## Proposed Changes
Removes paket in favor of nuget's [Centralized Package Management](https://learn.microsoft.com/en-us/nuget/consume-packages/central-package-management). Even though there still isn't a [solution level lock file](https://github.com/NuGet/Home/issues/12409), it really only matters for applications.... | cbef1f34ac9db74321e22c0d52eb9bf9c886515b | bc664b07fad399639b096ea5477d16168e3db1f6 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 660814c9..859a91a8 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -2,12 +2,6 @@
"version": 1,
"isRoot": true,
"tools": {
- "paket": {
- "version": "8.0.3",
- "commands": [
- "paket"
- ]
... | [
".config/dotnet-tools.json",
".gitignore",
".paket/Paket.Restore.targets",
"Content/Console/.config/dotnet-tools.json",
"Content/Console/.paket/Paket.Restore.targets",
"Content/Console/Directory.Packages.props",
"Content/Console/NuGet.config",
"Content/Console/build/build.fs",
"Content/Console/build... | [
{
"comment": "There's an extra space before the version number. Remove the leading space.\n```suggestion\n <PackageVersion Include=\"Microsoft.NET.Test.Sdk\" Version=\"17.13.0\" />\n```",
"path": "Directory.Packages.props",
"hunk": "@@ -0,0 +1,30 @@\n+<!-- https://learn.microsoft.com/en-us/nuget/cons... | diff --git a/Content/Console/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj b/Content/Console/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj
index 24e8429e..18b26887 100755
--- a/Content/Console/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj
+++ b/Content/Console/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj
@@ -5,6 +5,12 @@
<Target... | true | |
TheAngryByrd/MiniScaffold | 289 | comment_to_fix | Paket to nuget | There's an extra space before the version number. Remove the leading space.
```suggestion
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
``` | cbef1f34ac9db74321e22c0d52eb9bf9c886515b | bc664b07fad399639b096ea5477d16168e3db1f6 | diff --git a/Directory.Packages.props b/Directory.Packages.props
new file mode 100644
index 00000000..33c41740
--- /dev/null
+++ b/Directory.Packages.props
@@ -0,0 +1,30 @@
+<!-- https://learn.microsoft.com/en-us/nuget/consume-packages/Central-Package-Management -->
+<Project>
+ <PropertyGroup>
+ <RestorePackagesWi... | [
"Directory.Packages.props"
] | [
{
"comment": "There's an extra space before the version number. Remove the leading space.\n```suggestion\n <PackageVersion Include=\"Microsoft.NET.Test.Sdk\" Version=\"17.13.0\" />\n```",
"path": "Directory.Packages.props",
"hunk": "@@ -0,0 +1,30 @@\n+<!-- https://learn.microsoft.com/en-us/nuget/cons... | true | ||
TheAngryByrd/MiniScaffold | 289 | comment_to_fix | Paket to nuget | There's an extra space before the version number. Remove the leading space.
```suggestion
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
``` | cbef1f34ac9db74321e22c0d52eb9bf9c886515b | bc664b07fad399639b096ea5477d16168e3db1f6 | diff --git a/Content/Library/Directory.Packages.props b/Content/Library/Directory.Packages.props
new file mode 100644
index 00000000..0fe73715
--- /dev/null
+++ b/Content/Library/Directory.Packages.props
@@ -0,0 +1,33 @@
+<!-- https://learn.microsoft.com/en-us/nuget/consume-packages/Central-Package-Management -->
+<Pro... | [
"Content/Library/Directory.Packages.props"
] | [
{
"comment": "There's an extra space before the version number. Remove the leading space.\n```suggestion\n <PackageVersion Include=\"Microsoft.NET.Test.Sdk\" Version=\"17.13.0\" />\n```",
"path": "Content/Library/Directory.Packages.props",
"hunk": "@@ -0,0 +1,33 @@\n+<!-- https://learn.microsoft.com/... | true | ||
TheAngryByrd/MiniScaffold | 289 | comment_to_fix | Paket to nuget | There's an extra space before the version number. Remove the leading space.
```suggestion
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
``` | cbef1f34ac9db74321e22c0d52eb9bf9c886515b | bc664b07fad399639b096ea5477d16168e3db1f6 | diff --git a/Content/Console/Directory.Packages.props b/Content/Console/Directory.Packages.props
new file mode 100644
index 00000000..933d9f53
--- /dev/null
+++ b/Content/Console/Directory.Packages.props
@@ -0,0 +1,34 @@
+<!-- https://learn.microsoft.com/en-us/nuget/consume-packages/Central-Package-Management -->
+<Pro... | [
"Content/Console/Directory.Packages.props"
] | [
{
"comment": "There's an extra space before the version number. Remove the leading space.\n```suggestion\n <PackageVersion Include=\"Microsoft.NET.Test.Sdk\" Version=\"17.13.0\" />\n```",
"path": "Content/Console/Directory.Packages.props",
"hunk": "@@ -0,0 +1,34 @@\n+<!-- https://learn.microsoft.com/... | true | ||
TheAngryByrd/MiniScaffold | 289 | comment_to_fix | Paket to nuget | The function name 'NuGet.NuGet.NuGetPublish' appears to have redundant namespace/module prefixes. This should likely be 'NuGet.NuGetPublish' or similar, as the repeated 'NuGet' suggests an incorrect API reference. | cbef1f34ac9db74321e22c0d52eb9bf9c886515b | bc664b07fad399639b096ea5477d16168e3db1f6 | diff --git a/build/build.fs b/build/build.fs
index aee48a12..f7dab732 100644
--- a/build/build.fs
+++ b/build/build.fs
@@ -1,3 +1,5 @@
+module Build
+
open System
open Fake.Core
open Fake.DotNet
@@ -156,7 +158,7 @@ let failOnBadExitAndPrint (p: ProcessResult) =
failwithf "failed with exitcode %d" p.ExitCode... | [
"build/build.fs"
] | [
{
"comment": "The function name 'NuGet.NuGet.NuGetPublish' appears to have redundant namespace/module prefixes. This should likely be 'NuGet.NuGetPublish' or similar, as the repeated 'NuGet' suggests an incorrect API reference.",
"path": "build/build.fs",
"hunk": "@@ -410,15 +409,14 @@ let dotnetPack ct... | true | ||
TheAngryByrd/MiniScaffold | 289 | comment_to_fix | Paket to nuget | The function name 'NuGet.NuGet.NuGetPublish' appears to have redundant namespace/module prefixes. This should likely be 'NuGet.NuGetPublish' or similar, as the repeated 'NuGet' suggests an incorrect API reference. | cbef1f34ac9db74321e22c0d52eb9bf9c886515b | bc664b07fad399639b096ea5477d16168e3db1f6 | diff --git a/Content/Library/build/build.fs b/Content/Library/build/build.fs
index 4ca63142..e42f9186 100644
--- a/Content/Library/build/build.fs
+++ b/Content/Library/build/build.fs
@@ -1,3 +1,5 @@
+module Build
+
open System
open Fake.Core
open Fake.DotNet
@@ -327,9 +329,6 @@ let clean _ =
)
|> Shell.cle... | [
"Content/Library/build/build.fs"
] | [
{
"comment": "The function name 'NuGet.NuGet.NuGetPublish' appears to have redundant namespace/module prefixes. This should likely be 'NuGet.NuGetPublish' or similar, as the repeated 'NuGet' suggests an incorrect API reference.",
"path": "Content/Library/build/build.fs",
"hunk": "@@ -589,18 +588,19 @@ l... | true | ||
TheAngryByrd/MiniScaffold | 288 | issue_to_patch | Move to .net 8.0 | ## Proposed Changes
Upgrade to .NET 8.0
Bump dependencies
## Types of changes
What types of changes does your code introduce to MiniScaffold?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [ ... | e55be409d0e5917b404d2bf3701d44de938ca4a3 | 7ac3d70e49bca0500dafc852b42a41652f14c02c | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index f2be8be7..660814c9 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -3,7 +3,7 @@
"isRoot": true,
"tools": {
"paket": {
- "version": "7.2.0",
+ "version": "8.0.3",
"commands": [
"paket"
... | [
".config/dotnet-tools.json",
".devcontainer/devcontainer.json",
".github/workflows/build.yml",
".paket/Paket.Restore.targets",
"CHANGELOG.md",
"Content/Console/.config/dotnet-tools.json",
"Content/Console/.devcontainer/devcontainer.json",
"Content/Console/.github/workflows/build.yml",
"Content/Conso... | [] | diff --git a/Content/Console/tests/MyLib.1.Tests/Main.fs b/Content/Console/tests/MyLib.1.Tests/Main.fs
index 0cc12116..29419b21 100644
--- a/Content/Console/tests/MyLib.1.Tests/Main.fs
+++ b/Content/Console/tests/MyLib.1.Tests/Main.fs
@@ -6,4 +6,4 @@ module ExpectoTemplate =
[<EntryPoint>]
let main argv =
-... | true | |
TheAngryByrd/MiniScaffold | 285 | issue_to_patch | Incorrect release guide on github pages
**Describe the bug**
The steps to add NUGET_TOKEN from https://www.jimmybyrd.me/MiniScaffold/Tutorials/Getting_Started_With_Libraries.html#Add-your-NUGET_TOKEN-to-your-environment are incorrect.
**Expected behavior**
"[Create an Environment](https://docs.github.com/en/acti... | Use GitHub Environments for Nuget Publish | ## Proposed Changes
Fix TheAngryByrd/MiniScaffold#284
## Types of changes
What types of changes does your code introduce to MiniScaffold?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bre... | 755f63a4b8daf70f10266b1e124d7c39fffcaac7 | ac1553af570ec00f46a12b7c6937eb79624c1919 | diff --git a/Content/Library/.github/workflows/publish.yml b/Content/Library/.github/workflows/publish.yml
index 4e46a4d3..35c0fb6b 100644
--- a/Content/Library/.github/workflows/publish.yml
+++ b/Content/Library/.github/workflows/publish.yml
@@ -11,6 +11,8 @@ jobs:
# Sets permissions of the GITHUB_TOKEN to allow ... | [
"Content/Library/.github/workflows/publish.yml",
"Content/Library/README.md"
] | [] | true | |
TheAngryByrd/MiniScaffold | 272 | issue_to_patch | Coverage report tweaks | ## Proposed Changes
This PR:
- Restores the GenerateCoverageReport dependency chain broken in #271
- Сloses #251
- Adds the handy ShowCoverageReport target to the library template
## Types of changes
What types of changes does your code introduce to MiniScaffold?
- [x] Bugfix (non-breaking change which... | 972265c72a83d21f2b7e60b3a00ee747d8d761ba | ea4a01b33fa1cf603cbc749c9d281290ff8e3925 | diff --git a/Content/Library/.github/workflows/build.yml b/Content/Library/.github/workflows/build.yml
index 510da2d7..4e82db7c 100644
--- a/Content/Library/.github/workflows/build.yml
+++ b/Content/Library/.github/workflows/build.yml
@@ -31,8 +31,10 @@ jobs:
./build.sh
env:
CI: true
+ ... | [
"Content/Library/.github/workflows/build.yml",
"Content/Library/.github/workflows/publish.yml",
"Content/Library/README.md",
"Content/Library/build/build.fs"
] | [
{
"comment": "I seem to remember this won't work on osx/linux. ",
"path": "Content/Library/build/build.fs",
"hunk": "@@ -449,6 +457,15 @@ let generateCoverageReport _ =\n \n dotnet.reportgenerator id args\n \n+let showCoverageReport _ =\n+ failOnCIBuild ()\n+ coverageReportDir </> \"index.html... | true | ||
TheAngryByrd/MiniScaffold | 272 | comment_to_fix | Coverage report tweaks | I seem to remember this won't work on osx/linux. | 972265c72a83d21f2b7e60b3a00ee747d8d761ba | ea4a01b33fa1cf603cbc749c9d281290ff8e3925 | diff --git a/Content/Library/build/build.fs b/Content/Library/build/build.fs
index c46fdec6..347db41a 100644
--- a/Content/Library/build/build.fs
+++ b/Content/Library/build/build.fs
@@ -131,7 +131,7 @@ let mutable changelogBackupFilename = ""
let publishUrl = "https://www.nuget.org"
-let disableCodeCoverage = env... | [
"Content/Library/build/build.fs"
] | [
{
"comment": "I seem to remember this won't work on osx/linux. ",
"path": "Content/Library/build/build.fs",
"hunk": "@@ -449,6 +457,15 @@ let generateCoverageReport _ =\n \n dotnet.reportgenerator id args\n \n+let showCoverageReport _ =\n+ failOnCIBuild ()\n+ coverageReportDir </> \"index.html... | true | ||
TheAngryByrd/MiniScaffold | 274 | issue_to_patch | AssemblyInfo.fs are ignored
**Describe the bug**
Versions of assemblies/files in builded [library](https://github.com/TheAngryByrd/MiniScaffold/blob/master/Content/Library/README.md), library test project, [application](https://github.com/TheAngryByrd/MiniScaffold/blob/master/Content/Console/README.md) test project a... | Fix #273 | ## Proposed Changes
Fix #273
## Types of changes
What types of changes does your code introduce to MiniScaffold?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feat... | f2416b7bc19ecd760f6e2afd3fd1301e43575e17 | e68a1399e5927f526864ff41b9a4905773d0dadd | diff --git a/Content/Console/Directory.Build.props b/Content/Console/Directory.Build.props
index a64efed6..88bf2b9b 100644
--- a/Content/Console/Directory.Build.props
+++ b/Content/Console/Directory.Build.props
@@ -10,4 +10,7 @@
<RepositoryUrl>https://github.com/MyGithubUsername/MyLib.1</RepositoryUrl>
... | [
"Content/Console/Directory.Build.props",
"Content/Console/build/build.fs",
"Content/Console/src/MyLib.1/MyLib.1.fsproj",
"Content/Console/tests/MyLib.1.Tests/AssemblyInfo.fs",
"Content/Console/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj",
"Content/Library/Directory.Build.props",
"Content/Library/build/buil... | [
{
"comment": "Do you think this change makes sense to be in the one of the `Directory.Build.props`? Either root or the one under `src`.",
"path": "Content/Library/src/MyLib.1/MyLib.1.fsproj",
"hunk": "@@ -2,6 +2,7 @@\n <Project Sdk=\"Microsoft.NET.Sdk\">\n <PropertyGroup>\n <TargetFramework>net6.0... | diff --git a/Content/Console/tests/MyLib.1.Tests/AssemblyInfo.fs b/Content/Console/tests/MyLib.1.Tests/AssemblyInfo.fs
deleted file mode 100644
index 923df5ad..00000000
--- a/Content/Console/tests/MyLib.1.Tests/AssemblyInfo.fs
+++ /dev/null
@@ -1,23 +0,0 @@
-// Auto-Generated by FAKE; do not edit
-namespace System
-op... | true |
TheAngryByrd/MiniScaffold | 274 | comment_to_fix | Fix #273 | Should tests have this set? Just curious about this. | f2416b7bc19ecd760f6e2afd3fd1301e43575e17 | e68a1399e5927f526864ff41b9a4905773d0dadd | diff --git a/Content/Library/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj b/Content/Library/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj
index 756bbc71..89125db9 100755
--- a/Content/Library/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj
+++ b/Content/Library/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj
@@ -9,7 +9,6 @@
<Project... | [
"Content/Library/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj"
] | [
{
"comment": "Should tests have this set? Just curious about this.",
"path": "Content/Library/tests/MyLib.1.Tests/MyLib.1.Tests.fsproj",
"hunk": "@@ -3,6 +3,7 @@\n <PropertyGroup>\n <OutputType>Exe</OutputType>\n <TargetFramework>net6.0</TargetFramework>\n+ <GenerateAssemblyIn... | true | ||
TheAngryByrd/MiniScaffold | 276 | issue_to_patch | Fix #275 | ## Proposed Changes
Remove trailing slash from gitHubRepoUrl value in build.fs files.
## Types of changes
What types of changes does your code introduce to MiniScaffold?
_Put an `x` in the boxes that apply_
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change whic... | 8d2be790e393782cad8f8ebb33580c5560394a49 | 03fe0e60a31de30c3df109c1ecb5f668d338265a | diff --git a/CHANGELOG.md b/CHANGELOG.md
index d77a6df7..6a128905 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -683,19 +683,19 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Added
- Initial release
-[Unreleased]: https://github.com/TheAngryByrd/MiniScaffold//compare/v0.34... | [
"CHANGELOG.md",
"Content/Library/build/build.fs",
"build/build.fs"
] | [] | true | ||
TheAngryByrd/MiniScaffold | 170 | issue_to_patch | Fix typo in readme | ## Proposed Changes
I propose to fix a spelling error in the readme file.
## Types of changes
What types of changes does your code introduce to MiniScaffold?
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix ... | 5a880c247f95e8d3aa995053063d167dc3f8b554 | e9955a8f47ad1ad2080805ab68a480abf7e31264 | diff --git a/README.md b/README.md
index d463feee..ce2c263b 100644
--- a/README.md
+++ b/README.md
@@ -15,7 +15,7 @@ This takes away the ambiguity that developers face when creating an OSS project.
- How do I structure my project?
- How do I create repeatable builds?
- Which test framework should I use?
-- How to I ... | [
"README.md"
] | [] | true | ||
TheAngryByrd/MiniScaffold | 283 | issue_to_patch | New project specific templates | ## Proposed Changes
This adds the ability for people to add `classlib`/`console`/`test` projects using MiniScaffolds assumed structure.
To create an individual project, you can use the `--outputType` argument with one of the follow choices:
- projLib
- projConsole
- projTesting
This should make it much e... | 696fac6b1659f476a000de0ec9caae59ba40a373 | d62018d8e3f85e00f23582bf86becb637f140d65 | diff --git a/Content/.template.config/ide.host.json b/Content/.template.config/ide.host.json
index 99d8bd28..0796821a 100644
--- a/Content/.template.config/ide.host.json
+++ b/Content/.template.config/ide.host.json
@@ -1,5 +1,5 @@
{
- "$schema": "http://json.schemastore.org/vs-2017.3.host",
+ "$schema": "https:/... | [
"Content/.template.config/ide.host.json",
"Content/.template.config/template.json",
"Content/Console/build/Changelog.fs",
"Content/Console/build/build.fs",
"Content/Library/build/Changelog.fs",
"Content/Library/build/build.fs",
"Content/ProjConsole/AssemblyInfo.fs",
"Content/ProjConsole/MyLib.1.fsproj... | [] | diff --git a/tests/MiniScaffold.Tests/Asserts.fs b/tests/MiniScaffold.Tests/Asserts.fs
index 9eeca7ec..12d7600f 100644
--- a/tests/MiniScaffold.Tests/Asserts.fs
+++ b/tests/MiniScaffold.Tests/Asserts.fs
@@ -132,10 +132,65 @@ module Assert =
let ``README exists`` = tryFindFile "README.md"
+ let ``File exists... | true | |
TheAngryByrd/MiniScaffold | 282 | issue_to_patch | Fix Changelog compare link on github releases | ## Proposed Changes
When creating a `GitHub Release` on the `Publish` path, the changelog link compare generation was incorrectly generating a link to itself.
```
## [0.36.1] - 2023-10-21
[0.36.1]: https://github.com/TheAngryByrd/MiniScaffold/compare/v0.36.1...v0.36.1
### Changed
- [Adds devcontainer buil... | 8109934ca28788c922dddcd8057cf8df0476cdf8 | b82b3c266b18119e5532b9a770a41afea4a5a367 | diff --git a/Content/Console/build/Changelog.fs b/Content/Console/build/Changelog.fs
index 1c1c8428..fe84b5a0 100644
--- a/Content/Console/build/Changelog.fs
+++ b/Content/Console/build/Changelog.fs
@@ -47,7 +47,7 @@ let mkLinkReference (newVersion: SemVerInfo) (changelog: Changelog.Changelog) gi
changelog... | [
"Content/Console/build/Changelog.fs",
"Content/Library/build/Changelog.fs",
"build/Changelog.fs"
] | [] | true | ||
TheAngryByrd/MiniScaffold | 281 | issue_to_patch | Adds devcontainer builds to CI | ## Proposed Changes
Allows verification of devcontainer working for project
## Types of changes
What types of changes does your code introduce to MiniScaffold?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds fun... | 07cee142de7ee9249fc927806c33a8a1f1e9c395 | bbf550fb60676737b1017f16549c5dac73cb8526 | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 6fadb7f1..33755ac7 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -41,3 +41,17 @@ jobs:
env:
CONFIGURATION: ${{ matrix.configuration }}
CI: true
+
+ # Builds the project in a dev c... | [
".github/workflows/build.yml",
"Content/Console/.github/workflows/build.yml",
"Content/Library/.github/workflows/build.yml"
] | [] | true | ||
TheAngryByrd/MiniScaffold | 280 | issue_to_patch | Better devcontainers | ## Proposed Changes
Devcontainers have grown up quite a bit since the last time i've used them. Specifically the use of [features](https://github.com/devcontainers/features) which allow for more customization with less dockerfile mess.
## Types of changes
What types of changes does your code introduce to MiniS... | a717b3c575401ee9f91f19abb6e78864ce7dcdd7 | 2e43fb3f6f8dfa9a069622650e5093e76f1fb207 | diff --git a/.devcontainer/Dockerfile b/.devcontainer/Dockerfile
index 7d75080a..96c07a33 100644
--- a/.devcontainer/Dockerfile
+++ b/.devcontainer/Dockerfile
@@ -1,40 +1,17 @@
-FROM debian:buster-slim
-
-
-RUN apt-get update \
- && apt-get install -y --no-install-recommends \
- ca-certificates \
- \
-... | [
".devcontainer/Dockerfile",
".devcontainer/devcontainer.json",
".devcontainer/install-dotnets.sh",
".devcontainer/settings.vscode.json",
"Content/Console/.devcontainer/Dockerfile",
"Content/Console/.devcontainer/devcontainer.json",
"Content/Console/.devcontainer/install-dotnets.sh",
"Content/Console/.... | [] | true | ||
TheAngryByrd/MiniScaffold | 277 | issue_to_patch | Force Tool Restore and Formatting. Build for Debug and Release Configuration | ## Proposed Changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to MiniScaffold?
_Put a... | 807cdfda42f06372610b7e82637bf5296c2ce95c | b0491d41e23c15a2e435b57d2a3b709b93fc2421 | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index c5b558c3..6fadb7f1 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -11,7 +11,9 @@ on:
jobs:
build:
strategy:
+ fail-fast: false
matrix:
+ configuration: [Debug, Release]
os: [u... | [
".github/workflows/build.yml",
"Content/Console/.github/workflows/build.yml",
"Content/Console/Directory.Build.props",
"Content/Console/Directory.Build.targets",
"Content/Console/build.cmd",
"Content/Console/build.sh",
"Content/Console/build/build.fs",
"Content/Library/.github/workflows/build.yml",
... | [
{
"comment": "@Tarmil, I used the `Directory.Build.targets` file from `FSharp.SystemTextJson` but I still had to make some changes to make it work from a complete clean clone. \r\n\r\nSpecifically the `MakeDir` to ensure the path exists and the `BeforeTargets=PaketRestore`.\r\n\r\nTagging you in case you want t... | true | ||
TheAngryByrd/MiniScaffold | 279 | issue_to_patch | Disable requiring msbuild.structuredlogger always being up to date | ## Proposed Changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to MiniScaffold?
_Put a... | bd785740e2fa3c3420552b61b5a9c1bd0085e246 | 2dc31fe62b3539c719cd67bc4643c9c7e2540027 | diff --git a/Content/Console/build/build.fs b/Content/Console/build/build.fs
index 9b856e62..6425bcd3 100644
--- a/Content/Console/build/build.fs
+++ b/Content/Console/build/build.fs
@@ -230,6 +230,9 @@ module FSharpAnalyzers =
// Target Implementations
//--------------------------------------------------------------... | [
"Content/Console/build/build.fs",
"Content/Library/build/build.fs",
"build/build.fs"
] | [] | true | ||
TheAngryByrd/MiniScaffold | 278 | issue_to_patch | Ensure .fantomasignore is used | ## Proposed Changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to MiniScaffold?
_Put a... | 071f8d3ebf4eecee98ec1d68c38cf3fa9105863c | aee2b1315224928b04782d2c43baf44a93f22e29 | diff --git a/Content/Console/Directory.Build.targets b/Content/Console/Directory.Build.targets
index 21da1237..09d67361 100644
--- a/Content/Console/Directory.Build.targets
+++ b/Content/Console/Directory.Build.targets
@@ -20,7 +20,7 @@ See https://learn.microsoft.com/en-us/visualstudio/msbuild/customize-by-director
... | [
"Content/Console/Directory.Build.targets",
"Content/Library/Directory.Build.targets",
"Directory.Build.targets"
] | [] | true | ||
TheAngryByrd/MiniScaffold | 271 | issue_to_patch | Publish via CI
**Is your feature request related to a problem? Please describe.**
I've moved a few projects like [Marten.FSharp](https://github.com/TheAngryByrd/Marten.FSharp/blob/master/.github/workflows/dotnet-publish.yml) and [IcedTasks](https://github.com/TheAngryByrd/IcedTasks/blob/master/.github/workflows/pub... | Closes #262, closes #270 | ## Proposed Changes
Almost line by line copying of the 'build' project and GitHub Actions from TheAngryByrd/IcedTasks repository. Similar changes have been made to the Content/Library template.
- Closes #262
- Closes #270
## Types of changes
What types of changes does your code introduce to MiniScaffold?
... | 29381226895900a16b33e4f24cb4779477a57d05 | ccab474715dbf93168463dc96f67fac938547079 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 9400ebfe..f2be8be7 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -1,18 +1,24 @@
{
- "version": 1,
- "isRoot": true,
- "tools": {
- "paket": {
- "version": "7.2.0",
- "commands": [
... | [
".config/dotnet-tools.json",
".github/workflows/build.yml",
".github/workflows/fsdocs-gh-pages.yml",
".github/workflows/publish.yml",
".gitignore",
".vscode/settings.json",
"Content/Library/.config/dotnet-tools.json",
"Content/Library/.github/workflows/build.yml",
"Content/Library/.github/workflows/... | [
{
"comment": "Could you revert the changes to Changelog.fs to keep it in a separate file? Might involve dealing with some unpleasant merging though.",
"path": "Content/Library/build/Changelog.fs",
"hunk": "",
"resolving_sha": "ccab474715dbf93168463dc96f67fac938547079",
"resolving_diff": "diff --... | diff --git a/tests/Directory.Build.props b/tests/Directory.Build.props
new file mode 100644
index 00000000..bd387fc4
--- /dev/null
+++ b/tests/Directory.Build.props
@@ -0,0 +1,6 @@
+<Project>
+ <PropertyGroup>
+ <IsPackable>false</IsPackable>
+ <IsTestProject>true</IsTestProject>
+ </PropertyGroup>
... | true |
TheAngryByrd/MiniScaffold | 271 | comment_to_fix | Closes #262, closes #270 | Could you revert the changes to Changelog.fs to keep it in a separate file? Might involve dealing with some unpleasant merging though. | 29381226895900a16b33e4f24cb4779477a57d05 | ccab474715dbf93168463dc96f67fac938547079 | diff --git a/Content/Library/build/Changelog.fs b/Content/Library/build/Changelog.fs
index 1c1c8428..265692f0 100644
--- a/Content/Library/build/Changelog.fs
+++ b/Content/Library/build/Changelog.fs
@@ -14,7 +14,9 @@ let isEmptyChange =
| Changelog.Change.Security s
| Changelog.Change.Custom(_, s) -> String.I... | [
"Content/Library/build/Changelog.fs"
] | [
{
"comment": "Could you revert the changes to Changelog.fs to keep it in a separate file? Might involve dealing with some unpleasant merging though.",
"path": "Content/Library/build/Changelog.fs",
"hunk": "",
"resolving_sha": "ccab474715dbf93168463dc96f67fac938547079",
"resolving_diff": "diff --... | true | ||
TheAngryByrd/MiniScaffold | 269 | issue_to_patch | Build changes | ## Proposed Changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to MiniScaffold?
_Put a... | e2c7bdac1b6b4d8bef34e71f4e2b41c41f699403 | cf5c077e01285a87f626134f0d935f5d7589114a | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 802b6006..9400ebfe 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -1,18 +1,18 @@
{
- "version": 1,
- "isRoot": true,
- "tools": {
- "paket": {
- "version": "7.2.0",
- "commands": [
- "paket"
- ... | [
".config/dotnet-tools.json",
".editorconfig",
".fantomasignore",
".github/workflows/build.yml",
"Content/Console/.config/dotnet-tools.json",
"Content/Console/.editorconfig",
"Content/Console/.fantomasignore",
"Content/Console/.github/workflows/build.yml",
"Content/Console/build/Changelog.fs",
"Con... | [] | diff --git a/tests/MiniScaffold.Tests/Asserts.fs b/tests/MiniScaffold.Tests/Asserts.fs
index bff6465b..3a85b032 100644
--- a/tests/MiniScaffold.Tests/Asserts.fs
+++ b/tests/MiniScaffold.Tests/Asserts.fs
@@ -137,6 +137,9 @@ module Effect =
open Fake.IO
open Fake.Tools
+ let ``format build`` (d: DirectoryI... | true | |
TheAngryByrd/MiniScaffold | 267 | issue_to_patch | Trying to port a library fails because of linksource test
**Describe the bug**
I am trying to port an existing [project](https://github.com/informedica/Informedica.Utils.Lib) to the MiniScaffold setup. I could create an [empty scaffold project](https://github.com/informedica/Informedica.Build.Template). But with my U... | Update dependencies | ## Proposed Changes
closes #228
Updates:
- FAKE 6.0
- Paket 7.2
- Fantomas 5.2
- dotnet-reportgenerator-globaltool
Removes:
- Sourcelink
## Types of changes
What types of changes does your code introduce to MiniScaffold?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking chan... | b44292cb3482509eb2ca81d979c460e1a6b02342 | 1d5ccc09e8c353f9ebd970ea75727144d2e7e4ea | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 08722b16..802b6006 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -3,13 +3,13 @@
"isRoot": true,
"tools": {
"paket": {
- "version": "6.2.1",
+ "version": "7.2.0",
"commands": [
"paket... | [
".config/dotnet-tools.json",
".vscode/settings.json",
"Content/Console/.config/dotnet-tools.json",
"Content/Console/paket.dependencies",
"Content/Console/paket.lock",
"Content/Console/src/MyLib.1/MyLib.1.fsproj",
"Content/Library/.config/dotnet-tools.json",
"Content/Library/Directory.Build.props",
"... | [] | diff --git a/tests/MiniScaffold.Tests/Asserts.fs b/tests/MiniScaffold.Tests/Asserts.fs
index 3c0bf280..bff6465b 100644
--- a/tests/MiniScaffold.Tests/Asserts.fs
+++ b/tests/MiniScaffold.Tests/Asserts.fs
@@ -155,7 +155,7 @@ module Effect =
|> Array.tryFind (startPredicate)
with
| None -> N... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.