repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
SteveGilham/altcover | 255 | issue_to_patch | Bump actions/upload-artifact from 5 to 6 | Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 5 to 6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v6.0.0</h2>
<h2>v6 - What's new</h2>
<bl... | bcfd9a9a0ff14c77624678a22f940b4f37642426 | e9e5b668fdeb328d36ef6055a175a00e5a4aa03c | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 90fe6a2c..48b4b795 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -48,11 +48,11 @@ jobs:
COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}
NUGET_API_TOKEN: ${{ secrets.NUGET_API_TOKEN }}
... | [
".github/workflows/main.yml"
] | [] | true | ||
SteveGilham/altcover | 254 | issue_to_patch | Bump actions/checkout from 6.0.0 to 6.0.1 | Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.0 to 6.0.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v6.0.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Update all refe... | 9e44f38dd7b300b95f4f4e55176e5ea466705b35 | ada0d1343e7ecd89950d41d2dff9fa68cf0d0c71 | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index e438acc4..90fe6a2c 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -27,7 +27,7 @@ jobs:
windows:
runs-on: windows-latest
steps:
- - uses: actions/checkout@v6.0.0
+ - uses: actions/checkout@v6.0.1
... | [
".github/workflows/main.yml"
] | [] | true | ||
SteveGilham/altcover | 253 | issue_to_patch | Bump actions/checkout from 5.0.1 to 6.0.0 | Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.1 to 6.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v6.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update README t... | 1800d2a9e4e6dd9dd28ca75e81458fec6941058e | 98627c1b43033acce2b2f4a3f4ebc87d20f6d5f2 | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 48640b06..e438acc4 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -27,7 +27,7 @@ jobs:
windows:
runs-on: windows-latest
steps:
- - uses: actions/checkout@v5.0.1
+ - uses: actions/checkout@v6.0.0
... | [
".github/workflows/main.yml"
] | [] | true | ||
SteveGilham/altcover | 252 | issue_to_patch | Bump actions/checkout from 5.0.0 to 5.0.1 | Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.0 to 5.0.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v5.0.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Port v6 cleanup... | 6da5c5a06dbc676f67ed67913dbe55620fc1424d | c306b5dfba8da79d493d31c7f10b7b2e86a016ff | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 41a75637..48640b06 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -27,7 +27,7 @@ jobs:
windows:
runs-on: windows-latest
steps:
- - uses: actions/checkout@v5.0.0
+ - uses: actions/checkout@v5.0.1
... | [
".github/workflows/main.yml"
] | [] | true | ||
SteveGilham/altcover | 251 | issue_to_patch | Ready for net10.0 support release |
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
* **New Features**
* Official support for .NET 10.0 across projects and build tooling.
* **Updates**
* Bumped core tooling and many packages (FAKE, Cake, FSharp.Core, Avalonia, test SDKs, SDK to 10.0).
* Test a... | 3394d66e2b820d0343b695d91ee62788b339b399 | 165d9adc2dad75a5d84668ea3242882f7481c787 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 0630d457..6f8f77de 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -3,7 +3,7 @@
"isRoot": true,
"tools": {
"dotnet-reportgenerator-globaltool": {
- "version": "5.4.14",
+ "version": "5.5.0",
"c... | [
".config/dotnet-tools.json",
".gitignore",
"AltCover.Api.Tests/AltCover.Api.Tests.fsproj",
"AltCover.Async/AltCover.Async.csproj",
"AltCover.Avalonia/AltCover.Avalonia.fsproj",
"AltCover.Avalonia/MainWindow.fs",
"AltCover.Base/AltCover.Base.csproj",
"AltCover.DataCollector/AltCover.DataCollector.cspro... | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n**Verify package name casing for consistency.**\n\nThe package references use inconsistent casing: `Fake.Core.environment`, `Fake.Core.process`, and `Fake.dotNet.*` use lowercase, while `Fake.Core.Target` us... | diff --git a/Demo/Echo/Test/Test.csproj b/Demo/Echo/Test/Test.csproj
index 38dad9b3..4afb6665 100644
--- a/Demo/Echo/Test/Test.csproj
+++ b/Demo/Echo/Test/Test.csproj
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
- <TargetFramework>net9.0</TargetFramework>
+ <TargetFramework>net10.0</Tar... | true | |
SteveGilham/altcover | 251 | comment_to_fix | Ready for net10.0 support release | _⚠️ Potential issue_ | _🔴 Critical_
<details>
<summary>🧩 Analysis chain</summary>
**Verify package name casing for consistency.**
The package references use inconsistent casing: `Fake.Core.environment`, `Fake.Core.process`, and `Fake.dotNet.*` use lowercase, while `Fake.Core.Target` uses proper case. While NuGet i... | 3394d66e2b820d0343b695d91ee62788b339b399 | 165d9adc2dad75a5d84668ea3242882f7481c787 | diff --git a/Build/Build.fsproj b/Build/Build.fsproj
index 5c234f33..21c0d3c8 100644
--- a/Build/Build.fsproj
+++ b/Build/Build.fsproj
@@ -1,57 +1,55 @@
<Project Sdk="Microsoft.NET.Sdk">
- <PropertyGroup>
- <NoWarn>NU1902,NU1903,NU1904</NoWarn>
- <MSBuildWarningsAsMessages>NU1901;NU1902;NU1903;NU1904</MSBuil... | [
"Build/Build.fsproj"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n**Verify package name casing for consistency.**\n\nThe package references use inconsistent casing: `Fake.Core.environment`, `Fake.Core.process`, and `Fake.dotNet.*` use lowercase, while `Fake.Core.Target` us... | true | ||
SteveGilham/altcover | 251 | comment_to_fix | Ready for net10.0 support release | _⚠️ Potential issue_ | _🔴 Critical_
<details>
<summary>🧩 Analysis chain</summary>
**Verify package compatibility with .NET 10.0.**
The framework update looks correct. However, ensure that all package references are compatible with .NET 10.0, particularly `Microsoft.NET.Test.Sdk` (v17.9.0) and `FSharp.Core` (v8.0.2... | 3394d66e2b820d0343b695d91ee62788b339b399 | 165d9adc2dad75a5d84668ea3242882f7481c787 | diff --git a/Demo/MultiTest/Test1/Test1.fsproj b/Demo/MultiTest/Test1/Test1.fsproj
index aa421060..f91e4e20 100644
--- a/Demo/MultiTest/Test1/Test1.fsproj
+++ b/Demo/MultiTest/Test1/Test1.fsproj
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
- <TargetFramework>net9.0</TargetFramework>
+ <... | [
"Demo/MultiTest/Test1/Test1.fsproj"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n**Verify package compatibility with .NET 10.0.**\n\nThe framework update looks correct. However, ensure that all package references are compatible with .NET 10.0, particularly `Microsoft.NET.Test.Sdk` (v17.9... | true | ||
SteveGilham/altcover | 251 | comment_to_fix | Ready for net10.0 support release | _⚠️ Potential issue_ | _🔴 Critical_
<details>
<summary>🧩 Analysis chain</summary>
**TFM upgraded to net10.0 but xunit.runner.visualstudio is pinned to 2.3.1**
This old runner is very likely incompatible with net10.0. Suggest either:
- remove the VersionOverride to use the centrally-managed 3.1.5, or
- bump the ove... | 3394d66e2b820d0343b695d91ee62788b339b399 | 165d9adc2dad75a5d84668ea3242882f7481c787 | diff --git a/RegressionTesting/issue20/xunit-tests/xunit-tests.xml b/RegressionTesting/issue20/xunit-tests/xunit-tests.xml
index 315913f8..ff8f4d5a 100644
--- a/RegressionTesting/issue20/xunit-tests/xunit-tests.xml
+++ b/RegressionTesting/issue20/xunit-tests/xunit-tests.xml
@@ -1,20 +1,19 @@
<Project Sdk="Microsoft.NE... | [
"RegressionTesting/issue20/xunit-tests/xunit-tests.xml"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n**TFM upgraded to net10.0 but xunit.runner.visualstudio is pinned to 2.3.1**\n\nThis old runner is very likely incompatible with net10.0. Suggest either:\n- remove the VersionOverride to use the centrally-ma... | true | ||
SteveGilham/altcover | 251 | comment_to_fix | Ready for net10.0 support release | _⚠️ Potential issue_ | _🟡 Minor_
**Fix typo in release note.**
Line 8 contains a typo: "instrumention" should be "instrumentation".
Apply this diff to fix the typo:
```diff
-* Fix issue #238 - some symbol errors cause instrumention to abort rather than skip that assembly.
+* Fix issue #238 - some symbol errors ca... | 3394d66e2b820d0343b695d91ee62788b339b399 | 165d9adc2dad75a5d84668ea3242882f7481c787 | diff --git a/ReleaseNotes.md b/ReleaseNotes.md
index 73a7a1bf..c637f8f3 100644
--- a/ReleaseNotes.md
+++ b/ReleaseNotes.md
@@ -4,6 +4,10 @@ A. Start with the Quick Start guide : https://github.com/SteveGilham/altcover/wi
read the FAQ : https://github.com/SteveGilham/altcover/wiki/FAQ
# (Indori series release 2)
+* ... | [
"ReleaseNotes.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Fix typo in release note.**\n\nLine 8 contains a typo: \"instrumention\" should be \"instrumentation\".\n\n\nApply this diff to fix the typo:\n\n```diff\n-* Fix issue #238 - some symbol errors cause instrumention to abort rather than skip that assembly.\n+* F... | true | ||
SteveGilham/altcover | 250 | issue_to_patch | Bump actions/upload-artifact from 4 to 5 | Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v5.0.0</h2>
<h2>What's Changed</h2>
<p><... | 1fb4511c24e4535e2585c733feffff7baca99ac1 | 38d663734615f319520010a4c5f478184e9d23dc | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index a2884ed0..41a75637 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -48,11 +48,11 @@ jobs:
COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}
NUGET_API_TOKEN: ${{ secrets.NUGET_API_TOKEN }}
... | [
".github/workflows/main.yml"
] | [] | true | ||
SteveGilham/altcover | 248 | issue_to_patch | Routine SDK updates | net 9.0.305 and other tooling
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
- Chores
- Upgraded key dependencies for improved stability and compatibility (Avalonia 11.3.6, Newtonsoft.Json 13.0.4, Markdig 0.42.0, System.* and others).
- Updated .NET SDK to 9.0.... | f910ef24ca8ca18f41958e705b9971bcb646a7c5 | 57bde67ad9f396b53a96999445eae7562f553fd8 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 1b601012..0630d457 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -3,7 +3,7 @@
"isRoot": true,
"tools": {
"dotnet-reportgenerator-globaltool": {
- "version": "5.4.12",
+ "version": "5.4.14",
"... | [
".config/dotnet-tools.json",
"AltCover.Engine/Args.fs",
"Build/actions.fs",
"Build/targets.fs",
"Directory.Packages.props",
"global.json"
] | [
{
"comment": "_⚠️ Potential issue_\n\n<details>\n<summary>❓ Verification inconclusive</summary>\n\n**Quote args and avoid passing the Coveralls token on the command line (breakage + secret leak).**\n\n- Unquoted values (coverage path, author, commit message) will break when they contain spaces; commit is curren... | true | ||
SteveGilham/altcover | 247 | issue_to_patch | Bump actions/setup-dotnet from 4 to 5 | Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 4 to 5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/setup-dotnet/releases">actions/setup-dotnet's releases</a>.</em></p>
<blockquote>
<h2>v5.0.0</h2>
<h2>What's Changed</h2>
<h3>Breaking Cha... | fa42405057a0a2fe6432835b40b388a47ffb2b20 | 33f78d6e7d28a58f1a680bf69d54edd52c3e4d4b | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 42281b83..a5bb5deb 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -30,7 +30,7 @@ jobs:
- uses: actions/checkout@v5
with:
fetch-depth: 0
- - uses: actions/setup-dotnet@v4
+ - uses: actions/s... | [
".github/workflows/main.yml"
] | [] | true | ||
SteveGilham/altcover | 246 | issue_to_patch | Develop/maintenance | Update dependencies and adjust to new NUnit TestMultiple behaviour.
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
- Chores
- Updated .NET SDK to 9.0.304 in local config and CI; enabled dependency caching in CI.
- Bumped developer tools (reportgenerator, fsharp... | 756dfed01696a0c44256ac2f6826200b0df68700 | c3dc6d2379c99ac58a18cfed2e38b306c4241b17 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 6b73bc1e..1b601012 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -3,7 +3,7 @@
"isRoot": true,
"tools": {
"dotnet-reportgenerator-globaltool": {
- "version": "5.4.8",
+ "version": "5.4.12",
"c... | [
".config/dotnet-tools.json",
".github/workflows/main.yml",
"AltCover.Monitor.Tests/MonitorTest.fs",
"AltCover.TestData/TestCommon.fs",
"Directory.Packages.props",
"global.json"
] | [] | true | ||
SteveGilham/altcover | 245 | issue_to_patch | Bump actions/checkout from 4 to 5 | Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v5.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update actions checkout... | 76b3b4e87a9e065539dd758a9d34b7cd146020e2 | 5090857eb8bb1325915a7a239feae81990d911da | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 8e125990..04b1777b 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -27,7 +27,7 @@ jobs:
windows:
runs-on: windows-latest
steps:
- - uses: actions/checkout@v4
+ - uses: actions/checkout@v5
wit... | [
".github/workflows/main.yml"
] | [] | true | ||
SteveGilham/altcover | 244 | issue_to_patch | Update Fsharplint and fantomas |
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
* **Chores**
* Updated .NET SDK version to 9.0.302 and refreshed tool versions for improved compatibility.
* Added fsharplint.json to the solution items.
* Simplified linter configuration and removed redundant l... | f80f6871dacbc0102c26c0a598f57089bcbbc852 | df556336cdf030aab3ad9f48b9770d4ae2d2be77 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 08889c4d..6b73bc1e 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -3,7 +3,7 @@
"isRoot": true,
"tools": {
"dotnet-reportgenerator-globaltool": {
- "version": "5.4.7",
+ "version": "5.4.8",
"co... | [
".config/dotnet-tools.json",
".github/workflows/main.yml",
"AltCover.Api.Tests/FSApiTests.fs",
"AltCover.Avalonia/MainWindow.fs",
"AltCover.DotNet/DotNet.fs",
"AltCover.Engine.Tests/Arguments.fs",
"AltCover.Engine.Tests/Augment.fs",
"AltCover.Engine.Tests/CommandLine.fs",
"AltCover.Engine.Tests/Cove... | [
{
"comment": "_🛠️ Refactor suggestion_\n\n**Drop the suppression and the redundant `new` to stay consistent**\n\nThe rest of the PR removes `RedundantNewKeyword` suppressions; this is the last one left. \nYou can avoid the warning altogether by deleting the `new` keyword – F# permits `Bitmap(x)`.\n\n```diff\n... | true | ||
SteveGilham/altcover | 235 | issue_to_patch | Bump dotnet-sdk from 9.0.102 to 9.0.200 | Bumps [dotnet-sdk](https://github.com/dotnet/sdk) from 9.0.102 to 9.0.200.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dotnet/sdk/releases">dotnet-sdk's releases</a>.</em></p>
<blockquote>
<h2>.NET 9.0.2</h2>
<p><a href="https://github.com/dotnet/core/releases/tag/v9.0.2">... | 292edea6b71ec3cb94bd6bfd3a82639659b92f77 | 0daef8f219a1376630dd12f06874d42e637b3c9b | diff --git a/global.json b/global.json
index fc238931..20d6e56e 100644
--- a/global.json
+++ b/global.json
@@ -1,6 +1,6 @@
{
"sdk": {
- "version": "9.0.102",
+ "version": "9.0.200",
"rollForward": "latestMinor"
}
}
\ No newline at end of file
| [
"global.json"
] | [] | true | ||
SteveGilham/altcover | 201 | issue_to_patch | Bump actions/upload-artifact from 3 to 4 | Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v4.0.0</h2>
<h2>What's Changed</h2>
<p>T... | 1be0d6bdc410e646002b9b7365b7a8dd195bed6a | 8e3e5ea4141e62da3e641ba5ed251e0e9b581e60 | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 5821c941..d58915bf 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -42,11 +42,11 @@ jobs:
COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}
NUGET_API_TOKEN: ${{ secrets.NUGET_API_TOKEN }}
... | [
".github/workflows/main.yml"
] | [] | true | ||
SteveGilham/altcover | 200 | issue_to_patch | Bump actions/setup-dotnet from 3 to 4 | Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 3 to 4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/setup-dotnet/releases">actions/setup-dotnet's releases</a>.</em></p>
<blockquote>
<h2>v4.0.0</h2>
<h2>What's Changed</h2>
<p>In the scope ... | e5dba86823a5a9aa2adb89e0fe7cf6306e24087a | 1f0ac01d33658f6757616d005dc0ad185545ace5 | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index d8723cd8..5821c941 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -30,7 +30,7 @@ jobs:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- - uses: actions/setup-dotnet@v3
+ - uses: actions/s... | [
".github/workflows/main.yml",
"Build/actions.fs"
] | [] | true | ||
SteveGilham/altcover | 194 | issue_to_patch | Bump actions/checkout from 3 to 4 | Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v4.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update default runtime ... | 1c897daab1dad5362d1cff36e16ace803d850ba0 | fccb94811067bdb2dedd7927c44362d1002ec3ab | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 0fa1cd84..297bed0e 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -27,12 +27,12 @@ jobs:
windows:
runs-on: windows-latest
steps:
- - uses: actions/checkout@v3
+ - uses: actions/checkout@v4
w... | [
".github/workflows/main.yml",
"Build/actions.fs",
"global.json"
] | [] | true | ||
SteveGilham/altcover | 168 | issue_to_patch | Bump actions/setup-dotnet from 2 to 3 | Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 2 to 3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/setup-dotnet/releases">actions/setup-dotnet's releases</a>.</em></p>
<blockquote>
<h2>v3.0.0</h2>
<p>This major release includes the follo... | 79d4bb392aa817a3d8d616df961ce338435677ac | a5ecbd331b8817ac818087a1d1865a99be35ee51 | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index d05b1a5c8..d77098f67 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -17,7 +17,7 @@ jobs:
- uses: actions/checkout@v3
with:
fetch-depth: 2
- - uses: actions/setup-dotnet@v2
+ - uses: actions... | [
".github/workflows/main.yml"
] | [] | true | ||
SteveGilham/altcover | 166 | issue_to_patch | Bump NuGet.CommandLine from 6.2.1 to 6.3.0 in /Build | Bumps [NuGet.CommandLine](https://github.com/NuGet/NuGet.Client) from 6.2.1 to 6.3.0.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/NuGet/NuGet.Client/commits">compare view</a></li>
</ul>
</details>
<br />
[![Dependabot compatibility score](https://dependabot-badges.github... | 4ecc72603227b991718299a7977c6c3e4322354e | c094c70bef3c781197c63aaaaff302093468d669 | diff --git a/Build/NuGet.csproj b/Build/NuGet.csproj
index e6dd8414b..49374cf4b 100644
--- a/Build/NuGet.csproj
+++ b/Build/NuGet.csproj
@@ -8,7 +8,7 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="BlackFox.CommandLine" version="1.0.0" />
- <PackageReference Include="NuGet.CommandLine" version="6.2... | [
"Build/NuGet.csproj"
] | [] | true | ||
SteveGilham/altcover | 162 | issue_to_patch | Bump xunit.runner.console from 2.4.1 to 2.4.2 in /Build | Bumps [xunit.runner.console](https://github.com/xunit/xunit) from 2.4.1 to 2.4.2.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/xunit/xunit/commit/f110e5bee5dfd4c08339587c9c3df9292fcb597c"><code>f110e5b</code></a> v2.4.2</li>
<li><a href="https://github.com/xunit/xunit/commit/848d94d57fe9fd8... | 15796e6c68f5d0d35d76c03fb1393dab59fe95f8 | 9732dc6c4b3f9c4a23c0bb6a73b20af88ca03b70 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index b55837ec4..4050fdcd8 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -9,7 +9,7 @@
]
},
"fake-cli": {
- "version": "5.22.0",
+ "version": "5.23.0",
"commands": [
"fake"
]
d... | [
".config/dotnet-tools.json",
"AltCover.Avalonia/AltCover.Avalonia.fsproj",
"AltCover.FontSupport/AltCover.FontSupport.csproj",
"Build/NuGet.csproj",
"Build/build.fsx.lock",
"Build/paket.lock",
"Build/setup.fsx.lock",
"Samples/Sample10/Sample10.csproj",
"Samples/Sample18/Sample18.fsproj",
"Samples/... | [] | true | ||
SteveGilham/altcover | 154 | issue_to_patch | Bump NuGet.CommandLine from 6.1.0 to 6.2.0 in /Build | Bumps [NuGet.CommandLine](https://github.com/NuGet/NuGet.Client) from 6.1.0 to 6.2.0.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/NuGet/NuGet.Client/commits">compare view</a></li>
</ul>
</details>
<br />
[![Dependabot compatibility score](https://dependabot-badges.github... | 5cc497b3fc6d8dde24e00ed5204a22220c00214d | edd13e2d0d204b031e9323ca39c96db5c5f2d39f | diff --git a/Build/NuGet.csproj b/Build/NuGet.csproj
index f7098cc9c..d4f15ba81 100644
--- a/Build/NuGet.csproj
+++ b/Build/NuGet.csproj
@@ -8,7 +8,7 @@
</ItemGroup>
<ItemGroup>
<PackageReference Include="BlackFox.CommandLine" version="1.0.0" />
- <PackageReference Include="NuGet.CommandLine" version="6.1... | [
"Build/NuGet.csproj"
] | [] | true | ||
SteveGilham/altcover | 153 | issue_to_patch | Bump altcode.gendarme from 2022.2.17.8350 to 2022.5.15.11273 in /Build | Bumps [altcode.gendarme](https://github.com/SteveGilham/Gendarme) from 2022.2.17.8350 to 2022.5.15.11273.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/SteveGilham/Gendarme/commits">compare view</a></li>
</ul>
</details>
<br />
[![Dependabot compatibility score](https://de... | a7d46b25b27a6fb93557c3ebb39c51fe64f06aaa | fa6dfeb8a5572dae7d76df87fbdadcb4a2b11b62 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 2e6c65cf2..0528d26b8 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -3,7 +3,7 @@
"isRoot": true,
"tools": {
"dotnet-reportgenerator-globaltool": {
- "version": "5.1.4",
+ "version": "5.1.6",
"... | [
".config/dotnet-tools.json",
".github/workflows/main.yml",
".gitignore",
"AltCover.Api.Tests/AltCover.Api.Tests.fsproj",
"AltCover.Avalonia/AltCover.Avalonia.fsproj",
"AltCover.DotNet/AltCover.DotNet.fsproj",
"AltCover.Engine/AltCover.Engine.fsproj",
"AltCover.Engine/CommandLine.fs",
"AltCover.Engin... | [] | true | ||
SteveGilham/altcover | 152 | issue_to_patch | Bump Pester from 5.3.2 to 5.3.3 in /Build | Bumps [Pester](https://github.com/Pester/Pester) from 5.3.2 to 5.3.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/Pester/Pester/releases">Pester's releases</a>.</em></p>
<blockquote>
<h2>5.3.3</h2>
<h3>Issues Fixed</h3>
<ul>
<li>Fix container failure output <a href="https:... | 8e6d76e4890f38c1a2a9c62a6e340219e8f5b7c8 | d3085d6719161b798c37dc8c458e17de83b1186b | diff --git a/AltCover.Engine/Tasks.fsi b/AltCover.Engine/Tasks.fsi
index 925579ddb..1a255ef26 100644
--- a/AltCover.Engine/Tasks.fsi
+++ b/AltCover.Engine/Tasks.fsi
@@ -1,8 +1,8 @@
-// Both the .net framework/mono and .net core releases publish MSBuild tasks from the main assembly (AltCover.exe or AltCover.dll, respec... | [
"AltCover.Engine/Tasks.fsi",
"Build/NuGet.csproj",
"Build/pester.ps1",
"docs/AltCover.Engine/Tasks-fsapidoc.md"
] | [] | true | ||
SteveGilham/altcover | 150 | issue_to_patch | Bump Pester from 5.3.1 to 5.3.2 in /Build | Bumps [Pester](https://github.com/Pester/Pester) from 5.3.1 to 5.3.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/Pester/Pester/releases">Pester's releases</a>.</em></p>
<blockquote>
<h2>5.3.2</h2>
<h3>Issues Fixed</h3>
<ul>
<li>fix ForEach casing in Context <a href="https... | 8ab61709461f721596475768ef2a397b525ad237 | 429bbee3dc87fbc6995be747fd111272a2b03071 | diff --git a/Build/NuGet.csproj b/Build/NuGet.csproj
index 7fde07e86..80294ce02 100644
--- a/Build/NuGet.csproj
+++ b/Build/NuGet.csproj
@@ -24,7 +24,7 @@
<PackageReference Include="NUnit.ConsoleRunner" Condition="'$(OS)' == 'Windows_NT'" version="3.15.0" />
<PackageReference Include="OpenCover" version="4.7.... | [
"Build/NuGet.csproj",
"Build/pester.ps1"
] | [] | true | ||
SteveGilham/altcover | 148 | issue_to_patch | Bump actions/upload-artifact from 2 to 3 | Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 2 to 3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v3.0.0</h2>
<h2>What's Changed</h2>
<ul>... | 428c24b93c097aca38d8892ad9c185a2a08130c8 | 38f2b3e8a5e092b8ae1669fd9a4a937f581f3f43 | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 6c3945a55..af9958dc4 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -28,11 +28,11 @@ jobs:
env:
COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}
run: dotnet fake run ./Build/build.fsx
... | [
".github/workflows/main.yml"
] | [] | true | ||
SteveGilham/altcover | 147 | issue_to_patch | Bump NuGet.CommandLine from 6.0.0 to 6.1.0 in /Build | Bumps [NuGet.CommandLine](https://github.com/NuGet/NuGet.Client) from 6.0.0 to 6.1.0.
<details>
<summary>Commits</summary>
<ul>
<li>See full diff in <a href="https://github.com/NuGet/NuGet.Client/commits">compare view</a></li>
</ul>
</details>
<br />
[![Dependabot compatibility score](https://dependabot-badges.github... | 381c684b3bf8712af2cead5b3db398aa0aae381f | 1beb2a95f345b487e9b54ffd55ff7e016a6b9c6e | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 9ff8ebe93..2e6c65cf2 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -3,7 +3,7 @@
"isRoot": true,
"tools": {
"dotnet-reportgenerator-globaltool": {
- "version": "5.0.4",
+ "version": "5.1.4",
"... | [
".config/dotnet-tools.json",
".github/workflows/main.yml",
"AltCover.Api.Tests/AltCover.Api.Tests.fsproj",
"AltCover.Avalonia.FuncUI/About.fs",
"AltCover.Avalonia.FuncUI/AltCover.Avalonia.FuncUI.fsproj",
"AltCover.Avalonia.FuncUI/Counter.fs",
"AltCover.Avalonia.FuncUI/DotnetToolSettings.xml",
"AltCove... | [] | true | ||
SteveGilham/altcover | 146 | issue_to_patch | [ImgBot] Optimize images | ## Beep boop. Your images are optimized!
Your image file size has been reduced by **31%** 🎉
<details>
<summary>
Details
</summary>
| File | Before | After | Percent reduction |
|:--|:--|:--|:--|
| /AltCover.Visualizer/Screenshot-Avalonia.png | 94.68kb | 58.85kb | 37.84% |
| /AltCover.Visualizer/wiki/Ann... | dbaa6d9f86088ab7a766420439286771179d723a | a9c1a63df73568db4839c49938f03d04a9338fa8 | diff --git a/AltCover.UICommon/RawCodeCoverageDataFile.png b/AltCover.UICommon/RawCodeCoverageDataFile.png
index c30445c0a..62402115d 100644
Binary files a/AltCover.UICommon/RawCodeCoverageDataFile.png and b/AltCover.UICommon/RawCodeCoverageDataFile.png differ
diff --git a/AltCover.Visualizer/Screenshot-Avalonia.png b/... | [
"AltCover.UICommon/RawCodeCoverageDataFile.png",
"AltCover.Visualizer/Screenshot-Avalonia.png",
"AltCover.Visualizer/Screenshot-GTK.png",
"AltCover.Visualizer/Screenshot-GTK3.png",
"AltCover.Visualizer/wiki/Annotated.png",
"AltCover.Visualizer/wiki/Annotation66a.png",
"AltCover.Visualizer/wiki/Annotatio... | [] | true | ||
SteveGilham/altcover | 145 | issue_to_patch | [ImgBot] Optimize images | ## Beep boop. Your images are optimized!
Your image file size has been reduced by **26%** 🎉
<details>
<summary>
Details
</summary>
| File | Before | After | Percent reduction |
|:--|:--|:--|:--|
| /AltCover.Visualizer/wiki/FontSelection.png | 4.29kb | 2.74kb | 36.29% |
| /AltCover.Visualizer/wiki/Annota... | f9f11517d929176d35cb016bd80ac1f756b62633 | 35cd21bd50d238700b904029bd9be836b5186b3b | diff --git a/AltCover.Visualizer/wiki/Annotated.png b/AltCover.Visualizer/wiki/Annotated.png
index 547da52da..476e4d43d 100644
Binary files a/AltCover.Visualizer/wiki/Annotated.png and b/AltCover.Visualizer/wiki/Annotated.png differ
diff --git a/AltCover.Visualizer/wiki/Annotation66a.png b/AltCover.Visualizer/wiki/Anno... | [
"AltCover.Visualizer/wiki/Annotated.png",
"AltCover.Visualizer/wiki/Annotation66a.png",
"AltCover.Visualizer/wiki/Annotation66b.png",
"AltCover.Visualizer/wiki/FontSelection.png"
] | [] | true | ||
SteveGilham/altcover | 144 | issue_to_patch | [ImgBot] Optimize images | ## Beep boop. Your images are optimized!
Your image file size has been reduced by **21%** 🎉
<details>
<summary>
Details
</summary>
| File | Before | After | Percent reduction |
|:--|:--|:--|:--|
| /AltCover.Visualizer/Screenshot-GTK.png | 70.22kb | 48.00kb | 31.64% |
| /AltCover.Visualizer/Screenshot-GT... | 8de8300b9fe5d31cf2fadca4e876c4f175b03edd | f3ecc1dbe2069672dc2a2bdee7fd229b26babf60 | diff --git a/AltCover.UICommon/Assembly.png b/AltCover.UICommon/Assembly.png
index dce52a2ca..94d98842e 100644
Binary files a/AltCover.UICommon/Assembly.png and b/AltCover.UICommon/Assembly.png differ
diff --git a/AltCover.UICommon/Blank.png b/AltCover.UICommon/Blank.png
index 9bf60ade3..8e0b98042 100644
Binary files a... | [
"AltCover.UICommon/Assembly.png",
"AltCover.UICommon/Blank.png",
"AltCover.UICommon/Class.png",
"AltCover.UICommon/Effect.png",
"AltCover.UICommon/Exit.png",
"AltCover.UICommon/ExpandDown.png",
"AltCover.UICommon/ExpandRight.png",
"AltCover.UICommon/Font.png",
"AltCover.UICommon/MethodMissing.png",
... | [] | true | ||
SteveGilham/altcover | 142 | issue_to_patch | Bump actions/checkout from 2 to 3 | Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v3.0.0</h2>
<ul>
<li>Update default runtime to node16</li>
</ul>
<h2... | be33aee30f6a38e2967bb40eced1bc8365784f34 | 6af97aa8f8481e0f35eb1f457be3aed823ac9416 | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index bf38946dc..3426d76fe 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -14,7 +14,7 @@ jobs:
windows:
runs-on: windows-latest
steps:
- - uses: actions/checkout@v2
+ - uses: actions/checkout@v3
w... | [
".github/workflows/main.yml"
] | [] | true | ||
SteveGilham/altcover | 140 | issue_to_patch | Bump actions/setup-dotnet from 1 to 2 | Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 1 to 2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/setup-dotnet/releases">actions/setup-dotnet's releases</a>.</em></p>
<blockquote>
<h2>v2.0.0</h2>
<p>In scope of this release we changed v... | a92628d5cbf591fe32989c934fe48105bb14b7f9 | e8c0277d79505a8a20e54f76584697a32c45abd1 | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 1a576154f..bf38946dc 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -17,7 +17,7 @@ jobs:
- uses: actions/checkout@v2
with:
fetch-depth: 2
- - uses: actions/setup-dotnet@v1
+ - uses: actions... | [
".github/workflows/main.yml",
"Build/targets.fsx"
] | [] | true | ||
SteveGilham/altcover | 109 | issue_to_patch | Update `dotnet-test`-integration.md | ce4d9c8da14f80e238fac8b88238c2dfab16a495 | 5a07f1de4e60935c717537df14545a074133f20c | diff --git a/docs/`dotnet-test`-integration.md b/docs/`dotnet-test`-integration.md
index 6e524d3f3..950f0d25e 100644
--- a/docs/`dotnet-test`-integration.md
+++ b/docs/`dotnet-test`-integration.md
@@ -66,6 +66,6 @@ And if you want more control over what happens to the files, then is is still po
## Example
```
-dotn... | [
"docs/`dotnet-test`-integration.md"
] | [] | true | |||
SteveGilham/altcover | 101 | issue_to_patch | attempt at fixing #100 | This is an attempt at fixing https://github.com/SteveGilham/altcover/issues/100. However, we have not had a chance to test it, so it shouldn't be merged unless you are sure it fixes the issue. | f31aac19b23853833bf2b3e2b92a0131c12943d2 | 4bcef7fb2e002b0f9455565bc9537fb823e91fa3 | diff --git a/AltCover.Engine/LCov.fs b/AltCover.Engine/LCov.fs
index 11f83f1c5..221c518b7 100644
--- a/AltCover.Engine/LCov.fs
+++ b/AltCover.Engine/LCov.fs
@@ -83,6 +83,7 @@ FN:4,(anonymous_0)
// containing filename and coverage data:
//
// SF:<absolute path to the s... | [
"AltCover.Engine/LCov.fs"
] | [] | true | ||
SteveGilham/altcover | 21 | issue_to_patch | Fix expression in MSBuild target | I was thinking about creating a `.targets` file and then noticed it was done just a few days ago. It mostly worked for me, but for some projects the `AltCover.Prepare` task would run forever. I noticed a problem with incorrect `SplitContext` value from looking at the verbose MSBuild log:
```
SplitContext=
.Split... | 506279947a43ab5d041974a3ea4dae5ff29ce35f | 91fe378d0c96e2320b577e551c5ddef5dac0b7a5 | diff --git a/nupkg/build/netstandard2.0/AltCover.targets b/nupkg/build/netstandard2.0/AltCover.targets
index 44a31635f..3c6db19e2 100644
--- a/nupkg/build/netstandard2.0/AltCover.targets
+++ b/nupkg/build/netstandard2.0/AltCover.targets
@@ -7,7 +7,7 @@
<Target Name="InstrumentModulesNoBuild" BeforeTargets="VSTest"... | [
"nupkg/build/netstandard2.0/AltCover.targets"
] | [] | true | ||
SteveLTN/https-portal | 382 | issue_to_patch | Use nginx 1.30.2 | Another security vulnerability was discovered and patched in 1.30.2 aswell as 1.31.1
https://cybersecuritynews.com/nginx-poolslip-vulnerability/
I decided to stick with the stable release that's why I chose 1.30.2 over 1.31.1
| 0c957c62d59d38bed832ca65c842fde7fe4519fd | 9bb501b6ed8413719b7ace651df0fe843ebb224e | diff --git a/Dockerfile b/Dockerfile
index b3fc489..bdd8583 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,4 +1,4 @@
-ARG DIST=nginx:1.30.1
+ARG DIST=nginx:1.30.2
FROM $DIST
# Set by `docker buildx build`
diff --git a/fs_overlay/etc/cont-init.d/00-welcome b/fs_overlay/etc/cont-init.d/00-welcome
index 5d2af89..a21... | [
"Dockerfile",
"fs_overlay/etc/cont-init.d/00-welcome"
] | [] | true | ||
SteveLTN/https-portal | 381 | issue_to_patch | Use nginx 1.30.1 | Use latest nginx.
Needed to patch some severe security vulnerabilities.
https://nginx.org/en/security_advisories.html
| f666dc997dc62150df530f978c7b66cf0e0e516c | 6728f38a616f1325ea6d12170a3f846169eba545 | diff --git a/Dockerfile b/Dockerfile
index 451c127..41f8326 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,4 +1,4 @@
-ARG DIST=nginx:1.27.0
+ARG DIST=nginx:1.30.1
FROM $DIST
# Set by `docker buildx build`
diff --git a/fs_overlay/etc/cont-init.d/00-welcome b/fs_overlay/etc/cont-init.d/00-welcome
index 12a3c1e..024... | [
"Dockerfile",
"fs_overlay/etc/cont-init.d/00-welcome"
] | [] | true | ||
SteveLTN/https-portal | 378 | issue_to_patch | Backwards compatibility from 1.24 | When user upgrades the image from 1.24 to 1.25, we should not create a new config file who has explicit "443" written in the name for backwards compatibility. | a33353b0f55c9e3b359541578b4c9dd51090f3bf | 26d9f0f96709e1006e5347fa095c99cd0faa86d8 | diff --git a/fs_overlay/etc/cont-init.d/00-welcome b/fs_overlay/etc/cont-init.d/00-welcome
index bb672f06..12a3c1e8 100644
--- a/fs_overlay/etc/cont-init.d/00-welcome
+++ b/fs_overlay/etc/cont-init.d/00-welcome
@@ -2,6 +2,6 @@
echo '
========================================
-HTTPS-PORTAL v1.25.1
+HTTPS-PORTAL v1.25... | [
"fs_overlay/etc/cont-init.d/00-welcome",
"fs_overlay/opt/certs_manager/lib/nginx.rb"
] | [] | true | ||
SteveLTN/https-portal | 377 | issue_to_patch | Add SAN value to local certificate | c0f1be25837bb1dc3e715cbb1256fb61bb966ef0 | 5840700aeb6dbdab3ca168ed8cb633b6f2aa4673 | diff --git a/fs_overlay/opt/certs_manager/lib/open_ssl.rb b/fs_overlay/opt/certs_manager/lib/open_ssl.rb
index c4b59429..a03869a8 100644
--- a/fs_overlay/opt/certs_manager/lib/open_ssl.rb
+++ b/fs_overlay/opt/certs_manager/lib/open_ssl.rb
@@ -58,7 +58,8 @@ def self.self_sign(domain)
-out #{domain.ongoing_cert_pa... | [
"fs_overlay/opt/certs_manager/lib/open_ssl.rb"
] | [] | true | |||
SteveLTN/https-portal | 376 | issue_to_patch | Implement support for different port configuration | fbb2ec98be30aec047cbce0a2f06120361152e58 | c34b5cfe2a09bbd13d88d29b15e6a022d4c71ea7 | diff --git a/README.md b/README.md
index bd0da507..d3c84ad7 100644
--- a/README.md
+++ b/README.md
@@ -27,6 +27,7 @@ Thanks to [@yamada28go](https://github.com/yamada28go), there is a [Japanese ver
- [Automatic Container Discovery](#automatic-container-discovery)
- [Hybrid Setup with Non-Dockerized Apps](#hyb... | [
"README.md",
"fs_overlay/etc/cont-init.d/00-welcome",
"fs_overlay/opt/certs_manager/certs_manager.rb",
"fs_overlay/opt/certs_manager/lib/na_config.rb",
"fs_overlay/opt/certs_manager/lib/nginx.rb",
"fs_overlay/opt/certs_manager/models/domain.rb",
"fs_overlay/var/lib/nginx-conf/default.ssl.conf.erb",
"s... | [] | diff --git a/spec/models/domain_spec.rb b/spec/models/domain_spec.rb
index 076e987a..37c0f083 100644
--- a/spec/models/domain_spec.rb
+++ b/spec/models/domain_spec.rb
@@ -8,34 +8,35 @@
end
it 'returns correct names, upstream. redirect_target_url, stage etc.' do
- keys = [:descriptor, :name, :env_format_name,... | true | ||
SteveLTN/https-portal | 372 | issue_to_patch | Support for ports different from 443 | It allows to do configurations like:
```
environment:
DOMAINS: >
myserver.example.com:1443 -> http://localhost:8081,
myserver.example.com:2443 -> http://localhost:8082
``` | 5fdc07b65da5869b0c2b7036364ec6aa1925ffd5 | 7d007eb7f6c66a35131513cd5e1e76240505dfe0 | diff --git a/fs_overlay/opt/certs_manager/lib/na_config.rb b/fs_overlay/opt/certs_manager/lib/na_config.rb
index de2cc382..d9a28e40 100644
--- a/fs_overlay/opt/certs_manager/lib/na_config.rb
+++ b/fs_overlay/opt/certs_manager/lib/na_config.rb
@@ -4,7 +4,7 @@ def self.portal_base_dir
end
def self.domains
- (e... | [
"fs_overlay/opt/certs_manager/lib/na_config.rb",
"fs_overlay/opt/certs_manager/lib/nginx.rb",
"fs_overlay/opt/certs_manager/models/domain.rb",
"fs_overlay/var/lib/nginx-conf/default.ssl.conf.erb"
] | [] | true | ||
SteveLTN/https-portal | 375 | issue_to_patch | Revert "Support for ports different from 443" | Reverts SteveLTN/https-portal#372 | 17c2040d388ec352b09d9340f73532de34b07128 | c228bccfffe5d2ba5388f28f049fff9342fe29bc | diff --git a/fs_overlay/opt/certs_manager/lib/na_config.rb b/fs_overlay/opt/certs_manager/lib/na_config.rb
index d9a28e40..de2cc382 100644
--- a/fs_overlay/opt/certs_manager/lib/na_config.rb
+++ b/fs_overlay/opt/certs_manager/lib/na_config.rb
@@ -4,7 +4,7 @@ def self.portal_base_dir
end
def self.domains
- (e... | [
"fs_overlay/opt/certs_manager/lib/na_config.rb",
"fs_overlay/opt/certs_manager/lib/nginx.rb",
"fs_overlay/opt/certs_manager/models/domain.rb",
"fs_overlay/var/lib/nginx-conf/default.ssl.conf.erb"
] | [] | true | ||
SteveLTN/https-portal | 371 | issue_to_patch | Update README / Multiple Domains section | There is a multiline folding operator in yaml '>'. It greatly fits the use case of multiple entries in the DOMAINS env var. | 5fdc07b65da5869b0c2b7036364ec6aa1925ffd5 | 466e97b2e32b20ee09d15c5db2eb56c860ea70b9 | diff --git a/README.md b/README.md
index 7b2e9380..bd0da507 100644
--- a/README.md
+++ b/README.md
@@ -306,6 +306,19 @@ You can also specify the stage (`local`, `staging`, or `production`) for each in
DOMAINS: 'wordpress.example.com -> http://wordpress #local, gitlab.example.com #staging'
```
+If you have multiple ... | [
"README.md"
] | [] | true | ||
SteveLTN/https-portal | 359 | issue_to_patch | Enable HTTP/2 support regardless of IPv6 setting | In the latest update 1.24.0 HTTP/2 support was incorrectly tied to the `LISTEN_IPV6` env-var. This PR fixes that so that HTTP/2 support is always enabled as it was in versions prior to `1.24.0` . | f53de5140ec9bcdeab0ed30f06999f0915080e79 | d1e9925352541a3e12e525a85b8e1161ba310e24 | diff --git a/fs_overlay/var/lib/nginx-conf/default.ssl.conf.erb b/fs_overlay/var/lib/nginx-conf/default.ssl.conf.erb
index 5c3fabc1..e2bc2803 100644
--- a/fs_overlay/var/lib/nginx-conf/default.ssl.conf.erb
+++ b/fs_overlay/var/lib/nginx-conf/default.ssl.conf.erb
@@ -10,8 +10,9 @@ server {
listen 443 ssl;
<% i... | [
"fs_overlay/var/lib/nginx-conf/default.ssl.conf.erb"
] | [] | true | ||
SteveLTN/https-portal | 357 | issue_to_patch | [WIP] Update all dependencies (including nginx) | I marked the PR as WIP since I couldn't test it yet.
This PR updates the used nginx base image to 1.26.1.
Since the last update some things changed that's why I made some changes.
- /bin is now a symlink to /usr/bin
Since `/bin` is now a symlink to `/usr/bin` I moved the `fs_overlay/bin` to `fs_overlay/usr/bin`... | ea366ec0b2e7f3b85637feb7df774fd2962218bf | 23f704ac50878d6de0515f8f1d230f67fc1a4f3c | diff --git a/Dockerfile b/Dockerfile
index 4d4bfb68..4dc4d95a 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,4 +1,4 @@
-ARG DIST=nginx:1.23.1
+ARG DIST=nginx:1.27.0
FROM $DIST
# Set by `docker buildx build`
@@ -12,21 +12,25 @@ WORKDIR /root
RUN apt-get clean && \
apt-get update && \
- apt-get install -... | [
"Dockerfile",
"fs_overlay/etc/cont-init.d/00-welcome",
"fs_overlay/etc/cont-init.d/20-setup",
"fs_overlay/etc/services.d/00-nginx/finish",
"fs_overlay/etc/services.d/00-nginx/run",
"fs_overlay/etc/services.d/10-docker-gen/finish",
"fs_overlay/etc/services.d/10-docker-gen/run",
"fs_overlay/etc/services... | [
{
"comment": "HTTPS-PORTAL version does not really follow NGINX version. I will later change it to 1.24.",
"path": "fs_overlay/etc/cont-init.d/00-welcome",
"hunk": "@@ -2,6 +2,6 @@\n \n echo '\n ========================================\n-HTTPS-PORTAL v1.23.1\n+HTTPS-PORTAL v1.26.1",
"resolving_sha":... | true | ||
SteveLTN/https-portal | 347 | issue_to_patch | Japanese readme file | I am very grateful for HTTPS-Portal.
As a Japanese person, I find that a language barrier exists, and I believe having a Japanese version of the README would make it more user-friendly.
Therefore, I have translated it.
I would be delighted if you could incorporate this translation. | 1a4f095494616591dd6c701f3a14f738a2e8ebe8 | 095b3e3acc3e442dfb50735c8d3d44962da13c41 | diff --git a/README-ja.md b/README-ja.md
new file mode 100644
index 00000000..07a79a57
--- /dev/null
+++ b/README-ja.md
@@ -0,0 +1,707 @@
+# HTTPS-PORTAL
+
+HTTPS-PORTALは、[Nginx](http://nginx.org)、[Let's Encrypt](https://letsencrypt.org)、および
+[Docker](https://www.docker.com)を利用した、完全自動化されたHTTPSサーバーです。
+これを使用することで、追加の設定を... | [
"README-ja.md"
] | [] | true | ||
SteveLTN/https-portal | 327 | issue_to_patch | Create self-signed certificate with CSR | Current implementation ignores CSR when self-signing and force creates new RSA keypair, so
`CERTIFICATE_ALGORITHM=prime256v1` is not working for `STAGE=local`.
This PR fixes this by stop creating new RSA key on `self_sign` and
sign to CSR instead. | b429a034907b2f195a6a724ab9c944a1864c61b7 | 24d53bdbdd415237daa7965cc5fc3980dae3114b | diff --git a/fs_overlay/opt/certs_manager/lib/open_ssl.rb b/fs_overlay/opt/certs_manager/lib/open_ssl.rb
index 144fc4ba..c4b59429 100644
--- a/fs_overlay/opt/certs_manager/lib/open_ssl.rb
+++ b/fs_overlay/opt/certs_manager/lib/open_ssl.rb
@@ -53,13 +53,11 @@ def self.self_sign(domain)
command = <<-EOC
opens... | [
"fs_overlay/opt/certs_manager/lib/open_ssl.rb"
] | [] | true | ||
SteveLTN/https-portal | 328 | issue_to_patch | prime256v1 no longer works?
Apparently, prime256v1 certificates no longer work:
1. I had problems with https-portal on ARM (official image) yesterday with clients complaining about "No common ciphers"; the only thing that fixed it was removing `CERTIFICATE_ALGORITHM: 'prime256v1'` from `docker-compose.yml` environm... | Add ECDSA ciphers for TLSv1.2 | Current nginx template for ssl sites does not have ssl_ciphers for ECDSA server certs + TLSv1.2 so
using ECDSA certs results in `No common ciphers` error in clients.
This PR fixes:
- Add ECDSA ciphers for TLSv1.2
- Drop ciphers for TLSv1.1 and SSLv3 since these protocols are already dropped in
`fs_overlay/var/... | b429a034907b2f195a6a724ab9c944a1864c61b7 | 4125e4e16c8973859ab0ff888be74ff0850ef5f4 | diff --git a/fs_overlay/var/lib/nginx-conf/default.ssl.conf.erb b/fs_overlay/var/lib/nginx-conf/default.ssl.conf.erb
index 00c01c1f..24d740dc 100644
--- a/fs_overlay/var/lib/nginx-conf/default.ssl.conf.erb
+++ b/fs_overlay/var/lib/nginx-conf/default.ssl.conf.erb
@@ -17,7 +17,7 @@ server {
ssl_certificate_key <%= d... | [
"fs_overlay/var/lib/nginx-conf/default.ssl.conf.erb"
] | [] | true | |
SteveLTN/https-portal | 334 | issue_to_patch | feat: add healthcheck | I added two strategies: one with wget commented , and the other based on systemd (service nginx).
Maybe the config for intervals, timeout, start-period and retries is not optimal for a wide range of cases, but it is fine in my case.
Let me know if is interesting
| b429a034907b2f195a6a724ab9c944a1864c61b7 | 876e31ac2a71bc98f0566a9fe357f61e2182693e | diff --git a/Dockerfile b/Dockerfile
index 21934f0d..4d4bfb68 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -45,4 +45,9 @@ RUN chmod a+x /bin/* && \
VOLUME /var/lib/https-portal
VOLUME /var/log/nginx
+
+# HEALTHCHECK --interval=5s --timeout=3s --start-period=10s --retries=3 CMD wget -q -O /dev/null http://localhost:8... | [
"Dockerfile"
] | [] | true | ||
SteveLTN/https-portal | 321 | issue_to_patch | Version in the welcome msg updated. | Just a minor fix cause printing an outdated version in stdout is a bit confusing. | ed002016f0c9bef47402b99c58b6f0e3c26e3527 | d0af7ef8d77b48c0a831eb5b4695f7269f9d95a3 | diff --git a/fs_overlay/etc/cont-init.d/00-welcome b/fs_overlay/etc/cont-init.d/00-welcome
index 07e0cc19..ffc53e84 100644
--- a/fs_overlay/etc/cont-init.d/00-welcome
+++ b/fs_overlay/etc/cont-init.d/00-welcome
@@ -2,6 +2,6 @@
echo '
========================================
-HTTPS-PORTAL v1.21.0
+HTTPS-PORTAL v1.22... | [
"fs_overlay/etc/cont-init.d/00-welcome"
] | [] | true | ||
SteveLTN/https-portal | 319 | issue_to_patch | Update README.md | Use lvh.me second level domains for local testing, you do not need to change hosts file not use dnsmasq | ed002016f0c9bef47402b99c58b6f0e3c26e3527 | 71e0176ccb7f76bf1a2e61987e5167d008ebaf0e | diff --git a/README.md b/README.md
index 30a0053c..aa7e4dc5 100644
--- a/README.md
+++ b/README.md
@@ -159,12 +159,16 @@ stack.
Note that HTTPS-PORTAL only listens to `example.com`, as you specified in the compose file.
In order to make HTTPS-PORTAL respond to your connection, you need to either:
-* modify your `ho... | [
"README.md"
] | [] | true | ||
SteveLTN/https-portal | 315 | issue_to_patch | Fixing grammar in error message | Saw this typo when I was setting up.
BTW this is a great project!
Thank y'all so much! | d9cbd4c2f91ada8cc7bd366f8f5a577fb7d17d1d | 787ac40c439f42f37161561b31c9e38337047734 | diff --git a/fs_overlay/opt/certs_manager/lib/acme.rb b/fs_overlay/opt/certs_manager/lib/acme.rb
index 54598c77..b63ba114 100644
--- a/fs_overlay/opt/certs_manager/lib/acme.rb
+++ b/fs_overlay/opt/certs_manager/lib/acme.rb
@@ -37,7 +37,7 @@ def self.le_sign(domain)
puts <<-HERE
===================================... | [
"fs_overlay/opt/certs_manager/lib/acme.rb"
] | [] | true | ||
SteveLTN/https-portal | 314 | issue_to_patch | increased timeout for signing domain in order to prevent failing | before increasing timeout I was not be able to sign domain but it fixed the problem | 60a2f8587e11cb2b3235d047e14b73fe23234a0e | 6cc55ba82ef19198ca98bfec485d28a484ee71ea | diff --git a/fs_overlay/opt/certs_manager/lib/acme.rb b/fs_overlay/opt/certs_manager/lib/acme.rb
index 6fd2e62c..54598c77 100644
--- a/fs_overlay/opt/certs_manager/lib/acme.rb
+++ b/fs_overlay/opt/certs_manager/lib/acme.rb
@@ -17,7 +17,7 @@ def self.sign(domain)
private
def self.le_sign(domain)
- Timeout.tim... | [
"fs_overlay/opt/certs_manager/lib/acme.rb"
] | [] | true | ||
SteveLTN/https-portal | 308 | issue_to_patch | Readme filename schema `.conf.ssl` to `.ssl.conf` | 52fd22b8f0e8a7a8660f8669947d2fd86afffec5 | cc881d3e9898cc73faf2d6afb810197f1a13a5e8 | diff --git a/README.md b/README.md
index 0ce4a62f..30a0053c 100644
--- a/README.md
+++ b/README.md
@@ -625,7 +625,7 @@ You can either just override one single site's config or all sites' configs.
#### Override just one single site's config
-In this case, you provide `<your-domain>.conf.erb` and `<your-domain>.conf... | [
"README.md"
] | [] | true | |||
SteveLTN/https-portal | 306 | issue_to_patch | Added variables escape example to the README.md | Using NGINX variables required escaping them, otherwise NGINX won't start with
`nginx: [emerg] invalid number of arguments in "variable_name_here" directive in /etc/nginx/nginx.conf:31`. | 69eafa45202ae864c436286c58c9e5833a41dd11 | 93b505230000e76ac454c354e24b37ee296ff80e | diff --git a/README.md b/README.md
index b9bb60fc..0ce4a62f 100644
--- a/README.md
+++ b/README.md
@@ -576,6 +576,14 @@ You can also make it multi-line:
add_header Strict-Transport-Security "max-age=60" always;
auth_basic "Password";
```
+When using variables, you need to escape them with $:
+
+```yaml
+ ... | [
"README.md"
] | [] | true | ||
SteveLTN/https-portal | 305 | issue_to_patch | Forgot dynamic env for renewal | When adding the dynamic environment feature, I missed to upgrade the renewal cron job. Here is a fix that will run the time-based renewal with the correct environment. (This bug is especially bothersome if `DOMAINS` is dynamic and therefore updates only happen on container restarts or on changes to the dynamic environm... | 53920c8150433f8b05ef33515dbbf3a3fb0f9513 | 018c266975b2a2ad509eea4469b225f8edda20f1 | diff --git a/fs_overlay/var/lib/crontab.erb b/fs_overlay/var/lib/crontab.erb
index 6572b23f..4c5c3196 100644
--- a/fs_overlay/var/lib/crontab.erb
+++ b/fs_overlay/var/lib/crontab.erb
@@ -13,5 +13,5 @@ SHELL=/bin/sh
PATH=/usr/local/sbin:/usr/local/bin:/sbin:/bin:/usr/sbin:/usr/bin
# m h dom mon dow user command
-<%... | [
"fs_overlay/var/lib/crontab.erb"
] | [] | true | ||
SteveLTN/https-portal | 298 | issue_to_patch | Fix typo | Thanks for greet job!
This small PR fix typo in README.md | b4c9917f6c940890e9de846d21539fa12be5c201 | 94a4d9c859d1d1280b21a80dc59c8fa59e0b6917 | diff --git a/README.md b/README.md
index bc4e2529..b9bb60fc 100644
--- a/README.md
+++ b/README.md
@@ -596,7 +596,7 @@ server {
The variables `CUSTOM_NGINX_GLOBAL_HTTP_CONFIG_BLOCK` and `CUSTOM_NGINX_SERVER_PLAIN_CONFIG_BLOCK` can be used to add your own Nginx statements to the global `http` block or to the plaintex... | [
"README.md"
] | [] | true | ||
SteveLTN/https-portal | 297 | issue_to_patch | Make Nginx configuration more modular | Of course, It is possible to override the `*.erb` template files with your own template using `volume:` in `docker-compose.yml`. However, updates to the original templates inside the docker image will remain unnoticed, and will not be reflected, potentially causing problems as bug fixes (e.g. 0c35a4f4acfd99) or behavio... | df6d2c7ea9b69d2e3276d2e118411fd656966425 | 44f289b0d58320bb8403b046ad6661557e18f9da | diff --git a/README.md b/README.md
index f069894f..8a8ef624 100644
--- a/README.md
+++ b/README.md
@@ -590,6 +590,10 @@ server {
}
```
+The variables `CUSTOM_NGINX_GLOBAL_HTTP_CONFIG_BLOCK` and `CUSTOM_NGINX_SERVER_PLAIN_CONFIG_BLOCK` can be used to add your own Nginx statements to the global `http` block or to the... | [
"README.md",
"fs_overlay/opt/certs_manager/lib/nginx.rb",
"fs_overlay/var/lib/nginx-conf/default.conf.erb",
"fs_overlay/var/lib/nginx-conf/nginx.conf.erb"
] | [] | true | ||
SteveLTN/https-portal | 296 | issue_to_patch | Index file names configurable | When serving legacy static sites, they may use different conventions for naming the index file. For example, a site I serve uses `Welcome.html`. Making the index filename configurable helps here, in this case with `INDEX_FILES="index.html Welcome.html"` | df6d2c7ea9b69d2e3276d2e118411fd656966425 | b511316ded371b790a3771ea7e394407cbbb1463 | diff --git a/README.md b/README.md
index f069894f..7c626cda 100644
--- a/README.md
+++ b/README.md
@@ -498,6 +498,7 @@ They correspond to the configuration options that you would normally put in `ngi
The following are the available params with their default values:
```
+INDEX_FILES=index.html # A s... | [
"README.md",
"fs_overlay/var/lib/nginx-conf/default.ssl.conf.erb"
] | [] | true | ||
SteveLTN/https-portal | 295 | issue_to_patch | Only use temporary redirects | Not all redirects are meant to be permanent. Permanent redirects are cached for a long time in browsers (which bit me). So it is safer to keep them as temporary.
If there are good reasons to have a permanent redirect, it could be made configurable, e.g. by using a new arrow style (`~>`?). | df6d2c7ea9b69d2e3276d2e118411fd656966425 | e057019f982192b1cdf6966ec508bba8c5dfefeb | diff --git a/README.md b/README.md
index f069894f..96f81981 100644
--- a/README.md
+++ b/README.md
@@ -514,6 +514,7 @@ PROXY_SEND_TIMEOUT=60;
PROXY_READ_TIMEOUT=60;
ACCESS_LOG=off;
ACCESS_LOG_INCLUDE_HOST=off; # include vhost in access log (useful for goaccess => use log-format=VCOMBINED)
+REDIRECT_CODE=3... | [
"README.md",
"fs_overlay/var/lib/nginx-conf/default.ssl.conf.erb"
] | [] | true | ||
SteveLTN/https-portal | 278 | issue_to_patch | Fix grammatical mistake | 02591b536993002cec1de2bcd1ece10f71ab0c2c | 81613954ba3fe723bb5fd692e0e3023124506089 | diff --git a/README.md b/README.md
index 5c29d3ab..341cbdef 100644
--- a/README.md
+++ b/README.md
@@ -601,7 +601,7 @@ nginx.conf containing a valid `server` block. The custom nginx configurations
are [ERB](http://www.stuartellis.eu/articles/erb/) templates and will be
rendered before usage.
-You can either overrid... | [
"README.md"
] | [] | true | |||
SteveLTN/https-portal | 276 | issue_to_patch | Support for prime256v1 as recommended by Mozilla | [Mozilla recommends the use of `prime256v1` (aka `P-256`) for certificates](https://wiki.mozilla.org/Security/Server_Side_TLS#Modern_compatibility). This PR allows to set `CERTIFICATE_ALGORITHM=prime256v1` to use this for newly generated certificates/keys.
| 8cd566cc453d13a6fc4da3e17e95fa22ef599c7d | 87797a91c9e752e2cf8afcc6fa0b9bf35971218a | diff --git a/README.md b/README.md
index f4875497..5c29d3ab 100644
--- a/README.md
+++ b/README.md
@@ -35,6 +35,7 @@ Docker Hub page:
- [Configure Nginx through Environment Variables](#configure-nginx-through-environment-variables)
- [Change Configuration Dynamically](#change-configuration-dynamically)
-... | [
"README.md",
"fs_overlay/opt/certs_manager/lib/na_config.rb",
"fs_overlay/opt/certs_manager/lib/open_ssl.rb"
] | [] | true | ||
SteveLTN/https-portal | 271 | issue_to_patch | Need to import default environment | Otherwise, dynamic changes *only* use the dynamic environment,
not *in addition to* the default environment.
(Sorry, had too many branches related to `seamless-adding-domains`, resulting in the (wrong) conflict in #270 and accidentally closing it in a way I could not reopen it. So this replaces it.) | 4f520ee9e47938d7af2d05327e4ebb2c31a5f4e4 | 6ef2f52b6525846aea01d5548a130f318e0756b8 | diff --git a/fs_overlay/etc/services.d/30-dynamic-env/run b/fs_overlay/etc/services.d/30-dynamic-env/run
index 69724129..ce37dd4d 100644
--- a/fs_overlay/etc/services.d/30-dynamic-env/run
+++ b/fs_overlay/etc/services.d/30-dynamic-env/run
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/usr/bin/with-contenv sh
dir=/var/lib/https-portal... | [
"fs_overlay/etc/services.d/30-dynamic-env/run"
] | [] | true | ||
SteveLTN/https-portal | 267 | issue_to_patch | Allow on-the-fly reconfiguration | Reducing down-time even further using live reconfiguration. `reconfig` now essentially does the same thing as `setup`, but without stopping/starting nginx, just reloading it.
Also, domains can now be removed and will also disappear (the certificates will remain as a cache).
Files placed in `/var/lib/https-portal/... | c663b2db556255249673f7b7937c64f7a37574e1 | dd2f3e0d28193bd3fa88c2d1d1f250623dcc61cf | diff --git a/Dockerfile b/Dockerfile
index a1875aaa..78235768 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -11,7 +11,7 @@ RUN rm /var/log/nginx/access.log && \
WORKDIR /root
RUN apt-get update && \
- apt-get install -y python ruby cron iproute2 apache2-utils logrotate wget && \
+ apt-get install -y python ruby... | [
"Dockerfile",
"README.md",
"fs_overlay/bin/setup",
"fs_overlay/etc/cont-init.d/20-setup",
"fs_overlay/etc/services.d/10-docker-gen/run",
"fs_overlay/etc/services.d/30-dynamic-env/finish",
"fs_overlay/etc/services.d/30-dynamic-env/run",
"fs_overlay/opt/certs_manager/certs_manager.rb",
"fs_overlay/opt... | [
{
"comment": "I guess you can move this line up to the prevoius `if` block.",
"path": "fs_overlay/opt/certs_manager/certs_manager.rb",
"hunk": "@@ -29,13 +37,23 @@ def setup\n config_domains(NAConfig.domains)\n Nginx.setup\n \n- Nginx.start\n+ if initial\n+ Nginx.start\n+ ... | true | ||
SteveLTN/https-portal | 262 | issue_to_patch | Use s6-overlay mechanisms for cron environment | While trying to understand the `s6-overlay` and `https-portal` workings more in depth for #261, I noticed that `s6-overlay` provides `with-contenv`. Using that obviates the need for maintaining the environment in `/etc/cron_env.sh` a second time. This PR makes things more `s6-overlay`-ish (and simplifies operation). Th... | e6c7d8c016526df29de48e0fdc37fe3b2902bec0 | 6c3eb953f9b41d9f818e6c5a8f11fed3aad40c06 | diff --git a/fs_overlay/etc/cont-init.d/10-persist-env b/fs_overlay/etc/cont-init.d/10-persist-env
deleted file mode 100644
index 5da2542c..00000000
--- a/fs_overlay/etc/cont-init.d/10-persist-env
+++ /dev/null
@@ -1,5 +0,0 @@
-#!/usr/bin/with-contenv sh
-
-# Persist envs for cron jobs to use
-
-export > /etc/cron_env.... | [
"fs_overlay/etc/cont-init.d/10-persist-env",
"fs_overlay/var/lib/crontab.erb"
] | [] | true | ||
SteveLTN/https-portal | 260 | issue_to_patch | Get rid of 4095 byte limit per environment variable | Only the first 4095 of `DOMAINS` (or any other environment variable) will be used, truncating the rest, causing weird problems.
After double-checking all the ruby code that it that nothing limited the length of `ENV['DOMAINS']` and successfully running the ruby code from within `docker exec`, I tracked this down to ... | 6f98ae8d7b33d74667533223b8a9e63461a5e6fa | 32c918e79d17dfc98c5784dee82c382639f9b9af | diff --git a/Dockerfile b/Dockerfile
index 381ea634..1959dac1 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -18,7 +18,7 @@ RUN apt-get update && \
# Need this already now, but cannot copy remainder of fs_overlay yet
COPY ./fs_overlay/bin/archname /bin/
-ENV S6_OVERLAY_VERSION v1.22.1.0
+ENV S6_OVERLAY_VERSION v2.2.0.... | [
"Dockerfile"
] | [] | true | ||
SteveLTN/https-portal | 259 | issue_to_patch | Distribute certificate renewal time over the day
Right now, all certificates of all `https-portal` instances worldwide are renewed at 07:42 sharp (UTC). This is bad for our friends at Let's Encrypt that provide that great service, [as it causes peaks](https://github.com/acmesh-official/acme.sh/pull/944#issuecomment-70... | Evenly distribute certificate renewal time | This resolves #255.
I modeled the code after `ensure_welcome_page`, including using two functions. After adaptation, it were only a few lines of code remaining, which I preferred not to create a new file for. (And there also was not a good place to add it to, either.)
The original `crontab` needs to be deleted as... | cf7175b92f3e99d978e272adb799ba82d7fae556 | 4118edad9eb5e87b6025ce60bb0ee53acbbe67b6 | diff --git a/Dockerfile b/Dockerfile
index 79587953..381ea634 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -28,7 +28,7 @@ RUN sh -c "wget -q https://github.com/jwilder/docker-gen/releases/download/$DOCK
tar xzC /bin
RUN wget -q https://raw.githubusercontent.com/diafygi/acme-tiny/$ACME_TINY_VERSION/acme_tiny.py -O ... | [
"Dockerfile",
"fs_overlay/opt/certs_manager/certs_manager.rb",
"fs_overlay/var/lib/crontab.erb"
] | [] | true | |
SteveLTN/https-portal | 256 | issue_to_patch | Support building multi-platform docker images | Using `sudo make docker-multiarch`, it is now possible to create a multi-platform docker image for i386, amd64, armv7 and arm64v8 in one go.
It is based on https://netfuture.ch/2020/05/multi-arch-docker-image-easy/, which I have been using in several projects.
Complications arose from:
* S6-Overlay and Docker-Ge... | 18729967a557162fb7cd94b356da7ce14ade95bd | cb4b09f035e4178ca9f582b3eb40d0d0703e71fc | diff --git a/Dockerfile b/Dockerfile
index ea04baf2..79587953 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,6 +1,8 @@
ARG DIST=nginx:1.19.6
FROM $DIST
-ARG ARCH=amd64
+
+# Set by `docker buildx build`
+ARG TARGETPLATFORM
# Delete sym links from nginx image, install logrotate
RUN rm /var/log/nginx/access.log &... | [
"Dockerfile",
"Makefile",
"Readme.armhf",
"fs_overlay/bin/archname"
] | [
{
"comment": "What does the `*` mean here?\r\n\r\nWhen `Nginx` image is `linux/386`, `arch` command outputs `x86_64`. Does it mean Nginx Docker image put `linx/386` Nginx binary in a x86_64 container? ",
"path": "fs_overlay/bin/archname",
"hunk": "@@ -0,0 +1,80 @@\n+#/bin/sh\n+# Usage: archname.sh <PACK... | true | ||
SteveLTN/https-portal | 256 | comment_to_fix | Support building multi-platform docker images | What does the `*` mean here?
When `Nginx` image is `linux/386`, `arch` command outputs `x86_64`. Does it mean Nginx Docker image put `linx/386` Nginx binary in a x86_64 container? | 18729967a557162fb7cd94b356da7ce14ade95bd | cb4b09f035e4178ca9f582b3eb40d0d0703e71fc | diff --git a/fs_overlay/bin/archname b/fs_overlay/bin/archname
new file mode 100755
index 00000000..b93f296b
--- /dev/null
+++ b/fs_overlay/bin/archname
@@ -0,0 +1,80 @@
+#/bin/sh
+# Usage: archname.sh <PACKAGE>
+#
+# Outputs the correct architecture string for the named package, translating
+# between the different pl... | [
"fs_overlay/bin/archname"
] | [
{
"comment": "What does the `*` mean here?\r\n\r\nWhen `Nginx` image is `linux/386`, `arch` command outputs `x86_64`. Does it mean Nginx Docker image put `linx/386` Nginx binary in a x86_64 container? ",
"path": "fs_overlay/bin/archname",
"hunk": "@@ -0,0 +1,80 @@\n+#/bin/sh\n+# Usage: archname.sh <PACK... | true | ||
SteveLTN/https-portal | 254 | issue_to_patch | Allow per-domain config blocks | Some configurations require different redirects or proxy settings for different locations. If the portal only handles a single domain/backend, this is usually no problem and can be handled with a `CUSTOM_NGINX_SERVER_CONFIG_BLOCK`. However, with multiple domains (the case where https-portal really excels), things get t... | 2649418f83781940ec91a415d1e1cb534e7302cb | f6afcb366baab88d7f8040401e1db281abda6289 | diff --git a/README.md b/README.md
index 8007aff3..94286156 100644
--- a/README.md
+++ b/README.md
@@ -551,12 +551,15 @@ You can also make it multi-line:
The `CUSTOM_NGINX_SERVER_CONFIG_BLOCK` will be inserted after all other configuration blocks listed in section "Configure Nginx through Environment Variables", and... | [
"README.md",
"fs_overlay/opt/certs_manager/models/domain.rb",
"fs_overlay/var/lib/nginx-conf/default.ssl.conf.erb",
"spec/models/domain_spec.rb"
] | [] | diff --git a/spec/models/domain_spec.rb b/spec/models/domain_spec.rb
index d8b561a0..986a4769 100644
--- a/spec/models/domain_spec.rb
+++ b/spec/models/domain_spec.rb
@@ -7,34 +7,35 @@
allow(FileUtils).to receive(:mkdir_p)
end
- it 'returns correct name, upstream. redirect_target_url and stage' do
- keys ... | true | |
SteveLTN/https-portal | 252 | issue_to_patch | log rotation doesn't work
Hello!
I found logrotate doesn't work correctly.
https://github.com/SteveLTN/https-portal/commit/ada778c0759a0536f5758f6dbf4a532fb007537b#diff-0d569d44c262f49774d8bfa6db5529395f2c897ffacc2f7063de1e42d287545cR18
logrotate uses invoke-rc.d to reload nginx but this container doesn't con... | WIP: Fixed #248 Use nginx command for postrotate because invoke-rc.d doesn… | This PR fixes #248.
test environment:
```
version: '2'
services:
https-portal:
build:
context: '.'
environment:
DOMAINS: 'https-portal -> http://nginx'
STAGE: 'local'
ERROR_LOG: 'default'
ACCESS_LOG: 'default'
nginx:
image: 'nginx'
curl:
imag... | f8ca4607d8a6f0ee5caa70d9422ac90a9963c596 | 2dbe88b7f3eb97a78510961d6a10e907b9c3e8e2 | diff --git a/fs_overlay/etc/logrotate.d/nginx b/fs_overlay/etc/logrotate.d/nginx
index 2b386372..59a35cb5 100644
--- a/fs_overlay/etc/logrotate.d/nginx
+++ b/fs_overlay/etc/logrotate.d/nginx
@@ -15,6 +15,6 @@
fi \
endscript
postrotate
- invoke-rc.d nginx rotate >/dev/null 2>&1
+ nginx -... | [
"fs_overlay/etc/logrotate.d/nginx"
] | [] | true | |
SteveLTN/https-portal | 249 | issue_to_patch | Support for multiple upstreams | I have added support for multiple upstreams so that Loadbalancing or HA is possible.
A few changes to the templates were necessary. I tried to make the changes as backward-compatible
as possible for people who use custom templates. | bd12750a027a3537092b57b82102c16ecf75957c | 716489bfc571ab216a674373eb5c5a2202bddf72 | diff --git a/README.md b/README.md
index 88d8c5e7..8007aff3 100644
--- a/README.md
+++ b/README.md
@@ -23,6 +23,7 @@ Docker Hub page:
- [Automatic Container Discovery](#automatic-container-discovery)
- [Hybrid Setup with Non-Dockerized Apps](#hybrid-setup-with-non-dockerized-apps)
- [Multiple Domains](#m... | [
"README.md",
"fs_overlay/opt/certs_manager/models/domain.rb",
"fs_overlay/var/lib/nginx-conf/default.ssl.conf.erb",
"spec/models/domain_spec.rb"
] | [
{
"comment": "I guess this is for backwards compatibility for those who uses custom Nginx configuration? If so, could you add a comment?",
"path": "fs_overlay/opt/certs_manager/models/domain.rb",
"hunk": "@@ -73,20 +73,50 @@ def name\n parsed_descriptor[:domain]\n end\n \n+ def upstream_backend_n... | diff --git a/spec/models/domain_spec.rb b/spec/models/domain_spec.rb
index 28df8d52..d8b561a0 100644
--- a/spec/models/domain_spec.rb
+++ b/spec/models/domain_spec.rb
@@ -8,29 +8,33 @@
end
it 'returns correct name, upstream. redirect_target_url and stage' do
- keys = [:descriptor, :name, :upstream, :redirect... | true | |
SteveLTN/https-portal | 247 | issue_to_patch | Fixed little typo in README | At the very end of the README file "HTTPS-PORTAL" was written with a lowercase "l" instead of an uppercase "L". | 241592545e85b734d9aae973f579054d22e0780b | c11880a60ea704b59e4b9682f626ff10e8f35729 | diff --git a/README.md b/README.md
index 44851afc..88d8c5e7 100644
--- a/README.md
+++ b/README.md
@@ -204,7 +204,7 @@ services:
**Caveat**: Your web application must be created in the same network as HTTPS-PORTAL.
-Note that here is **no need** to link your web service to HTTPS-PORTAL, and you **shouldn't** put `... | [
"README.md"
] | [] | true | ||
SteveLTN/https-portal | 232 | issue_to_patch | Added built-in log rotation for Nginx | Added built-in Nginx log rotation and log configuration:
* Default behaviour is not changed
* Added a shortcut to redirect Nginx logs to stderr/stdout
* Added a shortcut to redirect Nginx logs to default location (`/var/log/nginx/access.log` and `/var/log/nginx/error.log`
* Added a pre-configured logrotate tool t... | 6158bdaa6fdd252e41c3952f24943b67df67fd07 | ada778c0759a0536f5758f6dbf4a532fb007537b | diff --git a/Dockerfile b/Dockerfile
index 41486b50..47449887 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -2,6 +2,12 @@ ARG DIST=nginx:1.17.3
FROM $DIST
ARG ARCH=amd64
+# Delete sym links from nginx image, install logrotate
+RUN rm /var/log/nginx/access.log && \
+ rm /var/log/nginx/error.log && \
+ apt-get ... | [
"Dockerfile",
"README.md",
"fs_overlay/etc/crontab",
"fs_overlay/etc/logrotate.d/nginx",
"fs_overlay/var/lib/nginx-conf/nginx.conf.erb"
] | [
{
"comment": "This isn't valid Ruby syntax. An error is raised when running.",
"path": "fs_overlay/var/lib/nginx-conf/nginx.conf.erb",
"hunk": "@@ -24,16 +24,40 @@ http {\n '\"$http_user_agent\" \"$http_x_forwarded_for\"';\n <% end %>\n \n- access_log <%= ENV['ACCESS_LOG'] |... | true | ||
SteveLTN/https-portal | 234 | issue_to_patch | Fixed #233 - websocket proxying was affecting POST requests | Fixed issue #233
Variable `$connection_upgrade` is already mapped [here](https://github.com/SteveLTN/https-portal/blob/master/fs_overlay/var/lib/nginx-conf/nginx.conf.erb#L30) so there was no need to map it. | 6158bdaa6fdd252e41c3952f24943b67df67fd07 | d584ee86359193324fcc01b001f874e44482e2a1 | diff --git a/fs_overlay/var/lib/nginx-conf/default.ssl.conf.erb b/fs_overlay/var/lib/nginx-conf/default.ssl.conf.erb
index 58d571e6..e58da165 100644
--- a/fs_overlay/var/lib/nginx-conf/default.ssl.conf.erb
+++ b/fs_overlay/var/lib/nginx-conf/default.ssl.conf.erb
@@ -54,7 +54,7 @@ server {
<% if ENV['WEBSOCKET'... | [
"fs_overlay/var/lib/nginx-conf/default.ssl.conf.erb"
] | [] | true | ||
SteveLTN/https-portal | 227 | issue_to_patch | Modify Dockerfile to allow docker cross build (fix #152) | I propose this PR to allow cross build of armhf image on amd64 platform.
I also provide Readme.armhf with short instructions.
This Dockerfile will need args to be passed to build the armhf image (DIST and ARCH). If no args are passed, the Dockerfile shall behave as before the PR (aka build the image for amd64)
| 4e04ec6e611cd3206225cb2c120280d62d6ecaeb | 74b0dc2d6dd3b0701c8527bfa889206b592e614b | diff --git a/Dockerfile b/Dockerfile
index 5276b8ed..41486b50 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,4 +1,6 @@
-FROM nginx:1.17.3
+ARG DIST=nginx:1.17.3
+FROM $DIST
+ARG ARCH=amd64
WORKDIR /root
@@ -6,14 +8,14 @@ ENV S6_OVERLAY_VERSION v1.22.1.0
ENV DOCKER_GEN_VERSION 0.7.4
ENV ACME_TINY_VERSION 4.1.0
... | [
"Dockerfile",
"Readme.armhf"
] | [] | true | ||
SteveLTN/https-portal | 225 | issue_to_patch | Fix a timeout of acme_tiny | In my case, increasing the timeout fix the following problem.
https://github.com/SteveLTN/https-portal/issues/223 | 6dd1346a2dc2f52cfa062705335ce349a3d1e1fb | babcdef79a22605870c6e11f2a53f4758f5122b5 | diff --git a/fs_overlay/opt/certs_manager/lib/acme.rb b/fs_overlay/opt/certs_manager/lib/acme.rb
index 9a56c37c..861daf6f 100644
--- a/fs_overlay/opt/certs_manager/lib/acme.rb
+++ b/fs_overlay/opt/certs_manager/lib/acme.rb
@@ -17,7 +17,7 @@ def self.sign(domain)
private
def self.le_sign(domain)
- Timeout.tim... | [
"fs_overlay/opt/certs_manager/lib/acme.rb"
] | [] | true | ||
SteveLTN/https-portal | 224 | issue_to_patch | Add IPv6 listening option | I have added an environment variable to enable listening on IPv6.
```
services:
https-portal:
# ...
environment:
LISTEN_IPV6: "true"
``` | d1fdc2ff835b555084e44377c7fc771da9944eed | e712db455e1e4cd0cae60524650b8b4ba3d5574c | diff --git a/README.md b/README.md
index b5c8c65c..1c7498b7 100644
--- a/README.md
+++ b/README.md
@@ -431,6 +431,16 @@ You can use the follow environment variable to set HSTS header.
HSTS_MAX_AGE=60 # in seconds
```
+#### IPv6 connectivity
+
+**Notice:** IPv6 is only supported on Linux hosts.
+
+You can enable IP... | [
"README.md",
"fs_overlay/var/lib/nginx-conf/default.conf.erb",
"fs_overlay/var/lib/nginx-conf/default.ssl.conf.erb"
] | [] | true | ||
SteveLTN/https-portal | 221 | issue_to_patch | Add flag to enable vhost in access logs | This merge requests adds a new flag so that the vhost can be included in the `nginx` access logs. This is useful when pushing the logs from https-portal into [goaccess](https://goaccess.io/) since it allows distinction between the different host names.
Please note that at first I wanted to make it completely dynami... | 87202defba0e21e60f3981b54e3ad2fa306bdaac | 93063e3a8970686ab03427051c0c60d51faf9db1 | diff --git a/README.md b/README.md
index 1e793e37..7104da2c 100644
--- a/README.md
+++ b/README.md
@@ -399,6 +399,7 @@ PROXY_CONNECT_TIMEOUT=60;
PROXY_SEND_TIMEOUT=60;
PROXY_READ_TIMEOUT=60;
ACCESS_LOG=off;
+ACCESS_LOG_INCLUDE_HOST=off; # include vhost in access log (useful for goaccess => use log-format=... | [
"README.md",
"fs_overlay/var/lib/nginx-conf/nginx.conf.erb"
] | [] | true | ||
SteveLTN/https-portal | 217 | issue_to_patch | Container crashing after 12 seconds: acme:error:malformed
Around december 6th I started getting the following issue:
```
================================================================================
Failed to sign redacted.domain, is DNS set up properly?
======================================================... | Bump acme-tiny version to 4.1.0 | Fixes #216
Related issue in the acme-tiny repository: https://github.com/diafygi/acme-tiny/issues/236 | dca8b69901b168cfe3d8a5eb5e4a50b68b4ed419 | db6315a30cdcf8c845754967936d69693b93bea7 | diff --git a/Dockerfile b/Dockerfile
index 6e4e7f58..58713588 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -6,10 +6,11 @@ WORKDIR /root
ENV S6_OVERLAY_VERSION v1.22.1.0
ENV DOCKER_GEN_VERSION 0.7.4
+ENV ACME_TINY_VERSION 4.1.0
ADD https://github.com/just-containers/s6-overlay/releases/download/$S6_OVERLAY_VERSION... | [
"Dockerfile"
] | [] | true | |
SteveLTN/https-portal | 204 | issue_to_patch | Update nginx for NFLX-2019-002 | Ref: https://github.com/Netflix/security-bulletins/blob/master/advisories/third-party/2019-002.md
http://mailman.nginx.org/pipermail/nginx-announce/2019/000249.html | a46a46e8abb82482886248282d9f495c22cd7405 | d969c063f1b47b9939f642ef0bfd545578cb99a4 | diff --git a/Dockerfile b/Dockerfile
index db0f36af..6e4e7f58 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,4 +1,4 @@
-FROM nginx:1.17.0
+FROM nginx:1.17.3
MAINTAINER Weiyan Shao "lighteningman@gmail.com"
| [
"Dockerfile"
] | [] | true | ||
SteveLTN/https-portal | 201 | issue_to_patch | upgrade libs | - Update nginx to 1.17 from 1.15
- Use ENV for s6-overlay version
- update docker-gen to 0.7.4
- Use latest acme_tiny | 876b240f879e4da010158dd4a0a2003e9484e78d | db66ab514fb14a3ecb67e55aa3d590b834541202 | diff --git a/Dockerfile b/Dockerfile
index 27afe8da..db0f36af 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,14 +1,15 @@
-FROM nginx:1.15.10
+FROM nginx:1.17.0
MAINTAINER Weiyan Shao "lighteningman@gmail.com"
WORKDIR /root
-ENV DOCKER_GEN_VERSION 0.7.3
+ENV S6_OVERLAY_VERSION v1.22.1.0
+ENV DOCKER_GEN_VERSION 0... | [
"Dockerfile"
] | [] | true | ||
SteveLTN/https-portal | 190 | issue_to_patch | cert renew is blocked when global access restriction is used
with an active global access restriction the request from the LE-Server is blocked too.
```yml
https-portal:
image: steveltn/https-portal:latest
environment:
ACCESS_RESTRICTION: "x.x.x.x"
```
```
https-portal_1 | 2019/03/29 11... | Ignore access restriction for acme challenge location | fixes SteveLTN/https-portal#189 | 660b7cfab07f8fb248a117774bdb88ad9c8200ae | 0366a9debb551b74c61b447c85f6c8ba178621cd | diff --git a/fs_overlay/opt/certs_manager/lib/nginx.rb b/fs_overlay/opt/certs_manager/lib/nginx.rb
index 4c3b8ac7..2445eeb1 100644
--- a/fs_overlay/opt/certs_manager/lib/nginx.rb
+++ b/fs_overlay/opt/certs_manager/lib/nginx.rb
@@ -63,6 +63,7 @@ def self.template_path(domain, ssl)
def self.acme_challenge_location_sni... | [
"fs_overlay/opt/certs_manager/lib/nginx.rb"
] | [] | true | |
SteveLTN/https-portal | 185 | issue_to_patch | Minor spelling fixes | 6411d9dbbaf65c3bffe5303c49367b1586de95eb | 99b7758d9743d63347e13d6c881640d18c89952b | diff --git a/fs_overlay/var/www/default/index.html.erb b/fs_overlay/var/www/default/index.html.erb
index 13cd337c..66e50b3f 100644
--- a/fs_overlay/var/www/default/index.html.erb
+++ b/fs_overlay/var/www/default/index.html.erb
@@ -15,12 +15,12 @@
<% if domain.stage == 'production' %>
<p>
- Your site is avaible in ... | [
"fs_overlay/var/www/default/index.html.erb"
] | [] | true | |||
SteveLTN/https-portal | 176 | issue_to_patch | nginx 1.14.2 | works out of the box | beb3580504edcf76e307b9158ec56d4226e7a8e3 | 6f43df0d29e440f2fb0e0d3dc4e8394cfeef94fe | diff --git a/Dockerfile b/Dockerfile
index 82412fe2..6cc690be 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,4 +1,4 @@
-FROM nginx:1.12.2
+FROM nginx:1.14.2
MAINTAINER Weiyan Shao "lighteningman@gmail.com"
| [
"Dockerfile"
] | [] | true | ||
SteveLTN/https-portal | 164 | issue_to_patch | Add note for ufw | Add command to allow communication from containers to docker host when using ufw | 3b93229852340f70cae05bbe9b6bbdc4e5b76192 | abf46a146cb6d3b43838c06041a5798f797a7725 | diff --git a/README.md b/README.md
index c35d2e38..773149b3 100644
--- a/README.md
+++ b/README.md
@@ -235,6 +235,20 @@ https-portal:
DOMAINS: 'example.com -> http://dockerhost:8080'
```
+#### Firewall settings ####
+
+If you use a firewall like [ufw](https://help.ubuntu.com/community/UFW), you
+might need to a... | [
"README.md"
] | [] | true | ||
StockSharp/StockSharp | 662 | issue_to_patch | Fix critical bugs in Diagram.Core | 1. Fix typo: Rename property Directon -> Direction in DiagramSocket
- Fixed property definition in DiagramSocket.cs
- Updated all usages across DiagramElement.cs, CompositionDiagramElement.cs, ICompositionModel.cs
2. Fix logic error in DiagramDebugger.Load()
- Changed 'return' to 'continue' when breakpoi... | aa978ea53ff95c7785cc6c5ade88f3e32bb65fb1 | 8ad128d275a3441a8a8df6bc4b39a340a09ed2a5 | diff --git a/Diagram.Core/CompositionDiagramElement.cs b/Diagram.Core/CompositionDiagramElement.cs
index e89b143621..89fc397926 100644
--- a/Diagram.Core/CompositionDiagramElement.cs
+++ b/Diagram.Core/CompositionDiagramElement.cs
@@ -553,7 +553,7 @@ public DiagramSocket InternalSocket
get
{
var node = Int... | [
"Diagram.Core/CompositionDiagramElement.cs",
"Diagram.Core/DiagramDebugger.cs",
"Diagram.Core/DiagramElement.cs",
"Diagram.Core/DiagramSocket.cs",
"Diagram.Core/ICompositionModel.cs"
] | [] | true | ||
StockSharp/StockSharp | 664 | issue_to_patch | Debug Algo/Candles Trading Algorithm | f3248cbb78c97b92805165d2a1812b60e6130c76 | 6b6139c28654f77c45ba924bd3846afb2c64489f | diff --git a/Algo/Candles/CandleHelper.cs b/Algo/Candles/CandleHelper.cs
index 3cbf76f7f0..d581636cc4 100644
--- a/Algo/Candles/CandleHelper.cs
+++ b/Algo/Candles/CandleHelper.cs
@@ -278,8 +278,13 @@ public static CandlePriceLevel PoC(this VolumeProfileBuilder volumeProfile)
if (volumeProfile == null)
throw new ... | [
"Algo/Candles/CandleHelper.cs",
"Algo/Candles/Compression/VolumeProfileBuilder.cs",
"Tests/CandleTests.cs"
] | [] | diff --git a/Tests/CandleTests.cs b/Tests/CandleTests.cs
index 17d8f87732..6c44d4560d 100644
--- a/Tests/CandleTests.cs
+++ b/Tests/CandleTests.cs
@@ -1,5 +1,6 @@
namespace StockSharp.Tests;
+using StockSharp.Algo.Candles;
using StockSharp.Algo.Candles.Compression;
[TestClass]
@@ -872,4 +873,221 @@ public void ... | true | ||
StockSharp/StockSharp | 665 | issue_to_patch | Debug Algo/Commission Code Errors | Added four new test methods to expose existing bugs in commission rules:
1. TurnOverRuleRepeatedTrigger - Exposes bug where _currentTurnOver is not reset after threshold is reached, causing commission to be charged on every subsequent trade instead of after each 1000 turnover
2. PerOrderVolumeRuleWithPercent - Expo... | f3248cbb78c97b92805165d2a1812b60e6130c76 | 3baadb535c0f5b747691fe203b2607397527e35a | [
"Tests/CommissionTests.cs"
] | [] | diff --git a/Tests/CommissionTests.cs b/Tests/CommissionTests.cs
index 9a0dcc2084..8e0840eb76 100644
--- a/Tests/CommissionTests.cs
+++ b/Tests/CommissionTests.cs
@@ -893,6 +893,114 @@ public void PerOrderTradeTurnover()
rule.Process(msg).AssertEqual(4.8m);
}
+ [TestMethod]
+ public void TurnOverRuleRepeatedTrig... | true | ||
StockSharp/StockSharp | 666 | issue_to_patch | Debug Algo/PnL Calculation Errors | 38ba53a0caed29675ba95d421fae56058f24cfa1 | 8d2233eebf942b32490db8d5020d91f5c2b80050 | [
"Tests/PnLTests.cs"
] | [
{
"comment": "**<sub><sub></sub></sub> Candle test assumes bid/ask cache is cleared**\n\nThe new `StalePrices_QuoteThenCandle` assertion expects UnrealizedPnL to jump from 30 to 50 when a candle closes at 150. `PnLQueue.ProcessCandle` currently only... | diff --git a/Tests/PnLTests.cs b/Tests/PnLTests.cs
index 53dc3d6f86..507abeb9b3 100644
--- a/Tests/PnLTests.cs
+++ b/Tests/PnLTests.cs
@@ -411,13 +411,261 @@ public void UnrealizedPnL_ByDataType()
public void SaveLoad()
{
var manager = new PnLManager { UseLevel1 = true };
-
+
var storage = manager.Save();
... | true | |||
StockSharp/StockSharp | 628 | issue_to_patch | Add GPU Demand Index calculator | ## Summary
- add GPU parameter struct and calculator for the Demand Index indicator
- implement ILGPU kernel with moving-average window management for multi-series execution
## Testing
- not run (dotnet CLI not available in environment)
------
https://chatgpt.com/codex/tasks/task_e_68e256be52a8832382173899ce46a022 | 9bb9d7ded60aea7d97121c7f4c9c33c203614675 | 6ac9e10f46a6216465adb8f7a83d265435b15022 | diff --git a/Algo.Gpu/Indicators/GpuDemandIndexCalculator.cs b/Algo.Gpu/Indicators/GpuDemandIndexCalculator.cs
new file mode 100644
index 0000000000..56d86db627
--- /dev/null
+++ b/Algo.Gpu/Indicators/GpuDemandIndexCalculator.cs
@@ -0,0 +1,264 @@
+namespace StockSharp.Algo.Gpu.Indicators;
+
+/// <summary>
+/// Paramete... | [
"Algo.Gpu/Indicators/GpuDemandIndexCalculator.cs"
] | [] | true | ||
StockSharp/StockSharp | 527 | issue_to_patch | Add GPU calculator for McClellan Oscillator | ## Summary
- add GPU parameter struct and calculator for the McClellan Oscillator indicator
- implement ILGPU kernel that computes paired fast/slow EMA values per series and parameter set
- populate GPU parameters from the indicator, including default EMA lengths and source price
## Testing
- dotnet build Algo.Gpu/Alg... | 9bb9d7ded60aea7d97121c7f4c9c33c203614675 | 7490cecc6c38d974d8f9050fa136f4bdcf0d06f9 | diff --git a/Algo.Gpu/Indicators/GpuMcClellanOscillatorCalculator.cs b/Algo.Gpu/Indicators/GpuMcClellanOscillatorCalculator.cs
new file mode 100644
index 0000000000..483ea4b78a
--- /dev/null
+++ b/Algo.Gpu/Indicators/GpuMcClellanOscillatorCalculator.cs
@@ -0,0 +1,239 @@
+namespace StockSharp.Algo.Gpu.Indicators;
+
+usi... | [
"Algo.Gpu/Indicators/GpuMcClellanOscillatorCalculator.cs"
] | [] | true | ||
StockSharp/StockSharp | 610 | issue_to_patch | Add GPU Envelope indicator calculator | ## Summary
- add GPU parameter/result structs and calculator implementation for the Envelope indicator
- document Envelope GPU support alongside existing calculators in the README
## Testing
- not run (not requested)
------
https://chatgpt.com/codex/tasks/task_e_68e2572610508323859c2f13a53b5401 | 9bb9d7ded60aea7d97121c7f4c9c33c203614675 | 023f00319642539bc87884e2647bb3c2d8f13d0b | diff --git a/Algo.Gpu/Indicators/GpuEnvelopeCalculator.cs b/Algo.Gpu/Indicators/GpuEnvelopeCalculator.cs
new file mode 100644
index 0000000000..50ce5cbc87
--- /dev/null
+++ b/Algo.Gpu/Indicators/GpuEnvelopeCalculator.cs
@@ -0,0 +1,263 @@
+namespace StockSharp.Algo.Gpu.Indicators;
+
+/// <summary>
+/// Parameter set for... | [
"Algo.Gpu/Indicators/GpuEnvelopeCalculator.cs",
"Algo.Gpu/README.md"
] | [] | true | ||
StockSharp/StockSharp | 587 | issue_to_patch | Add GPU Positive Volume Index calculator | ## Summary
- implement GPU parameter struct and calculator for Positive Volume Index (PVI)
- add ILGPU kernel to compute PVI results across multiple series and parameter sets
## Testing
- not run
------
https://chatgpt.com/codex/tasks/task_e_68e2655476b883238bbd5f25099d7545 | 9bb9d7ded60aea7d97121c7f4c9c33c203614675 | c9c0e82d3128e365cbee70cd61c36b46626aebbe | diff --git a/Algo.Gpu/Indicators/GpuPositiveVolumeIndexCalculator.cs b/Algo.Gpu/Indicators/GpuPositiveVolumeIndexCalculator.cs
new file mode 100644
index 0000000000..f65201c02a
--- /dev/null
+++ b/Algo.Gpu/Indicators/GpuPositiveVolumeIndexCalculator.cs
@@ -0,0 +1,169 @@
+namespace StockSharp.Algo.Gpu.Indicators;
+
+///... | [
"Algo.Gpu/Indicators/GpuPositiveVolumeIndexCalculator.cs"
] | [] | true | ||
StockSharp/StockSharp | 575 | issue_to_patch | Add GPU Ultimate Oscillator calculator | ## Summary
- add a GPU calculator for Ultimate Oscillator including XML docs and parameter struct
- implement the ILGPU kernel with ring buffers to mirror CPU indicator logic and host-side orchestration
## Testing
- `dotnet build Algo.Gpu/Algo.Gpu.csproj` *(fails: dotnet command not available in container)*
------
ht... | 9bb9d7ded60aea7d97121c7f4c9c33c203614675 | 0c59bbd1e7204d1469ccefc86ac75904c9b6ccc9 | diff --git a/Algo.Gpu/Indicators/GpuUltimateOscillatorCalculator.cs b/Algo.Gpu/Indicators/GpuUltimateOscillatorCalculator.cs
new file mode 100644
index 0000000000..603f27e32f
--- /dev/null
+++ b/Algo.Gpu/Indicators/GpuUltimateOscillatorCalculator.cs
@@ -0,0 +1,390 @@
+namespace StockSharp.Algo.Gpu.Indicators;
+
+/// <s... | [
"Algo.Gpu/Indicators/GpuUltimateOscillatorCalculator.cs"
] | [] | true | ||
StockSharp/StockSharp | 498 | issue_to_patch | Add GPU calculator for Price Channels indicator | ## Summary
- add GPU parameters, result container, and calculator for the Price Channels indicator
- convert GPU outputs into PriceChannelsValue instances with populated upper and lower channel values
## Testing
- dotnet build Algo.Gpu/Algo.Gpu.csproj *(fails: dotnet command not available in container)*
------
https:... | 9bb9d7ded60aea7d97121c7f4c9c33c203614675 | c43e7e6f899a3771c36b2d5c34dd0f942247e2e1 | diff --git a/Algo.Gpu/Indicators/GpuPriceChannelsCalculator.cs b/Algo.Gpu/Indicators/GpuPriceChannelsCalculator.cs
new file mode 100644
index 0000000000..414cc36278
--- /dev/null
+++ b/Algo.Gpu/Indicators/GpuPriceChannelsCalculator.cs
@@ -0,0 +1,287 @@
+namespace StockSharp.Algo.Gpu.Indicators;
+
+using System.Runtime.... | [
"Algo.Gpu/Indicators/GpuPriceChannelsCalculator.cs"
] | [] | true | ||
StockSharp/StockSharp | 499 | issue_to_patch | Add GPU calculator for Pretty Good Oscillator | ## Summary
- add GPU parameter struct for Pretty Good Oscillator (PGO) calculations
- implement a GPU calculator and ILGPU kernel to compute PGO values across series and parameter sets
## Testing
- dotnet build Algo.Gpu/Algo.Gpu.csproj *(fails: `dotnet` not available in container)*
------
https://chatgpt.com/codex/ta... | 9bb9d7ded60aea7d97121c7f4c9c33c203614675 | cad2d09a51936dacefadc2a6b9b090097aa38f81 | diff --git a/Algo.Gpu/Indicators/GpuPrettyGoodOscillatorCalculator.cs b/Algo.Gpu/Indicators/GpuPrettyGoodOscillatorCalculator.cs
new file mode 100644
index 0000000000..cd09604266
--- /dev/null
+++ b/Algo.Gpu/Indicators/GpuPrettyGoodOscillatorCalculator.cs
@@ -0,0 +1,179 @@
+namespace StockSharp.Algo.Gpu.Indicators;
+
+... | [
"Algo.Gpu/Indicators/GpuPrettyGoodOscillatorCalculator.cs"
] | [] | true | ||
StockSharp/StockSharp | 497 | issue_to_patch | Add GPU calculator for Price Volume Trend indicator | ## Summary
- add GPU parameter struct and calculator implementation for the Price Volume Trend indicator
- provide ILGPU kernel to compute PVT values across series and parameter sets
## Testing
- dotnet build Algo.Gpu/Algo.Gpu.csproj *(fails: command not found: dotnet)*
------
https://chatgpt.com/codex/tasks/task_e_6... | 9bb9d7ded60aea7d97121c7f4c9c33c203614675 | c426c641157caaa05056921cc64df507b7bd52e2 | diff --git a/Algo.Gpu/Indicators/GpuPriceVolumeTrendCalculator.cs b/Algo.Gpu/Indicators/GpuPriceVolumeTrendCalculator.cs
new file mode 100644
index 0000000000..286ec13013
--- /dev/null
+++ b/Algo.Gpu/Indicators/GpuPriceVolumeTrendCalculator.cs
@@ -0,0 +1,156 @@
+namespace StockSharp.Algo.Gpu.Indicators;
+
+/// <summary... | [
"Algo.Gpu/Indicators/GpuPriceVolumeTrendCalculator.cs"
] | [] | true | ||
StockSharp/StockSharp | 500 | issue_to_patch | Add GPU Pivot Points indicator calculator | ## Summary
- add GPU parameter and result structs for Pivot Points
- implement ILGPU-based calculator that mirrors the CPU Pivot Points logic
## Testing
- dotnet build Algo.Gpu/Algo.Gpu.csproj *(fails: dotnet not installed in container)*
------
https://chatgpt.com/codex/tasks/task_e_68e2654ef81c8323b5e4962cc24cd37b | 9bb9d7ded60aea7d97121c7f4c9c33c203614675 | c46f94319e2961988ce0ce1ae30938bbc745a997 | diff --git a/Algo.Gpu/Indicators/GpuPivotPointsCalculator.cs b/Algo.Gpu/Indicators/GpuPivotPointsCalculator.cs
new file mode 100644
index 0000000000..d86dd3f650
--- /dev/null
+++ b/Algo.Gpu/Indicators/GpuPivotPointsCalculator.cs
@@ -0,0 +1,252 @@
+namespace StockSharp.Algo.Gpu.Indicators;
+
+/// <summary>
+/// Paramete... | [
"Algo.Gpu/Indicators/GpuPivotPointsCalculator.cs"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.