repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
SortableJS/Sortable | 1,700 | issue_to_patch | Bump mixin-deep from 1.3.1 to 1.3.2 | Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2.
<details>
<summary>Commits</summary>
- [`754f0c2`](https://github.com/jonschlinkert/mixin-deep/commit/754f0c20e1bc13ea5a21a64fbc7d6ba5f7b359b9) 1.3.2
- [`90ee1fa`](https://github.com/jonschlinkert/mixin-deep/commit/90ee1fab375fccfd9b9... | 1a796461af8f84b7c0d5de870fd80d92ac6ade49 | eea402765a1e5320e00d1e926c41130b8941918d | diff --git a/package-lock.json b/package-lock.json
index e14c8db0f..dbc696bd5 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -1,6 +1,6 @@
{
"name": "sortablejs",
- "version": "1.10.0-rc3",
+ "version": "1.10.1",
"lockfileVersion": 1,
"requires": true,
"dependencies": {
@@ -3862,9 +3862,9 @@
"dev... | [
"package-lock.json"
] | [] | true | ||
SortableJS/Sortable | 1,689 | issue_to_patch | Added type check for 'dragStarted' variable as this is causing thousa… | Added type check for 'dragStarted' variable as this is causing thousands of console errors in Chrome, Firefox, Edge, IE, Safari before the first drag.
This change is harmless because it is just checking if the variable **dragStarted** is declared before using it.
Tested across all of the above browsers and working ... | ec7b5e9469f3d246b192d1bb3988fddcef057cdb | ac5ec44ac666c1278699e84f79046ea60ef8af3e | diff --git a/plugins/MultiDrag/MultiDrag.js b/plugins/MultiDrag/MultiDrag.js
index 7b2c32cda..61f690137 100644
--- a/plugins/MultiDrag/MultiDrag.js
+++ b/plugins/MultiDrag/MultiDrag.js
@@ -467,7 +467,7 @@ function MultiDragPlugin() {
},
_deselectMultiDrag(evt) {
- if (dragStarted) return;
+ if (typeof dragS... | [
"plugins/MultiDrag/MultiDrag.js"
] | [] | true | ||
SortableJS/Sortable | 1,674 | issue_to_patch | add MSCSSMatrix to matrixFn options | Related to #1532 | 118828dc12f7debabf4e4d3068c499207ef5d823 | caca04a00eddf478945120a143c676e51fc3d898 | diff --git a/src/utils.js b/src/utils.js
index 7109c973b..2758830b1 100644
--- a/src/utils.js
+++ b/src/utils.js
@@ -122,7 +122,7 @@ function matrix(el, selfOnly) {
} while (!selfOnly && (el = el.parentNode));
}
- const matrixFn = window.DOMMatrix || window.WebKitCSSMatrix || window.CSSMatrix;
+ const matrixFn =... | [
"src/utils.js"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,368 | issue_to_patch | Handle concurrent temporary directory creation | 1️⃣ Why should it be added? What are the benefits of this change?
I am seeing errors in our CI that look like this:
```php
ErrorException: mkdir(): File exists in /builds/myapp/applications/my-app/api/vendor/maatwebsite/excel/src/Files/TemporaryFileFactory.php:49
Stack trace:
#0 /builds/myapp/applications/my-ap... | 13b990f9810f9e2a3a04ac8ce5165cbbc8fc7db7 | d9e1ea0786ba44088ed81d70409ccf9a3c04d912 | diff --git a/src/Files/TemporaryFileFactory.php b/src/Files/TemporaryFileFactory.php
index b67a97fb..e02c60e8 100644
--- a/src/Files/TemporaryFileFactory.php
+++ b/src/Files/TemporaryFileFactory.php
@@ -46,7 +46,7 @@ public function make(?string $fileExtension = null): TemporaryFile
*/
public function makeLo... | [
"src/Files/TemporaryFileFactory.php",
"tests/TemporaryFileTest.php"
] | [] | diff --git a/tests/TemporaryFileTest.php b/tests/TemporaryFileTest.php
index 5d37832b..284d1be2 100644
--- a/tests/TemporaryFileTest.php
+++ b/tests/TemporaryFileTest.php
@@ -4,6 +4,7 @@
use Maatwebsite\Excel\Files\TemporaryFileFactory;
use Maatwebsite\Excel\Tests\Helpers\FileHelper;
+use RuntimeException;
class... | true | |
SpartnerNL/Laravel-Excel | 4,387 | issue_to_patch | Update composer.json - Patch for CVE-2026-34084 | 1️⃣ Why should it be added? What are the benefits of this change?
Fix the vulnerability in the underlying package with release https://github.com/PHPOffice/PhpSpreadsheet/releases/tag/1.30.5
See: https://github.com/advisories/GHSA-87m4-826x-3crx
2️⃣ Does it contain multiple, unrelated changes? Please separate th... | aa832714ba6be64f429ffafc6010adbc1a034dc2 | 2c093db639bf5fe3e630594b9fde247018a79bf9 | diff --git a/composer.json b/composer.json
index 7d5724f1..7fa8d98d 100644
--- a/composer.json
+++ b/composer.json
@@ -22,7 +22,7 @@
"require": {
"ext-json": "*",
"php": "^7.0||^8.0",
- "phpoffice/phpspreadsheet": "^1.30.4",
+ "phpoffice/phpspreadsheet": "^1.30.5",
"illuminate/support": "5.8.*||... | [
"composer.json"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,382 | issue_to_patch | V4: Support the #[Queue] and #[Connection] attributes on imports | ## What
Resolve an import's queue and connection from the native Laravel `#[Queue(...)]` and `#[Connection(...)]` attributes, in addition to the existing `queue`/`connection` properties.
```php
use Illuminate\Queue\Attributes\Queue;
#[Queue('imports')] // string or backed enum
class UsersImport implements ToModel,... | 41d00212ac198d2bcda9c01ad73d5c897a1ea605 | 31498aadb87e376eb87130f647589ebb116a08a5 | diff --git a/phpstan-baseline-queue-attributes-pre-13.neon b/phpstan-baseline-queue-attributes-pre-13.neon
new file mode 100644
index 00000000..765e28dd
--- /dev/null
+++ b/phpstan-baseline-queue-attributes-pre-13.neon
@@ -0,0 +1,8 @@
+parameters:
+ excludePaths:
+ # The #[Queue]/#[Connection] attributes and ... | [
"phpstan-baseline-queue-attributes-pre-13.neon",
"phpstan-baseline.neon.php",
"src/ChunkReader.php",
"src/Helpers/QueueResolver.php",
"src/Jobs/ReadChunk.php",
"tests/Concerns/ShouldQueueWithoutChainTest.php",
"tests/Data/Stubs/Enums/QueueChannel.php",
"tests/Data/Stubs/QueuedImportWithQueueAttribute.... | [] | diff --git a/tests/Concerns/ShouldQueueWithoutChainTest.php b/tests/Concerns/ShouldQueueWithoutChainTest.php
index 339a2ded..c708c4a0 100644
--- a/tests/Concerns/ShouldQueueWithoutChainTest.php
+++ b/tests/Concerns/ShouldQueueWithoutChainTest.php
@@ -8,6 +8,7 @@
use Maatwebsite\Excel\Jobs\AfterImportJob;
use Maatwebs... | true | |
SpartnerNL/Laravel-Excel | 4,383 | issue_to_patch | chore: remove ext-json dependency from composer.json and normalize it | > For composer.json file that had ext-json in the require section, this requirement is no longer necessary if already requires php ^8.0.
https://php.watch/versions/8.0/ext-json | 41d00212ac198d2bcda9c01ad73d5c897a1ea605 | 1f166affefdcae35b6aaeff28966369576cad558 | diff --git a/composer.json b/composer.json
index 6972d8fa..a730d52a 100644
--- a/composer.json
+++ b/composer.json
@@ -20,28 +20,29 @@
}
],
"require": {
- "ext-json": "*",
"php": "^8.3",
+ "composer/semver": "^3.3",
+ "illuminate/support": "^12.0 || ^13.0",
"phpoffice/phpspreadsheet": "^5.... | [
"composer.json"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,380 | issue_to_patch | fix comment indentation in Cell Middleware config being 1 space off | The comment for Cell Middleware in the `excel.php` publishable config file were one space off.
The rest of the comments in the file are indented properly. Only this one was off.
- [X] Checked the codebase to ensure that your feature doesn't already exist.
- [X] Take note of the contributing guidelines.
- [X] Ch... | e00e9f1ab72d138839354f65ac622776179cc123 | 41c726acd1ce8d08a14338f3a26c99474be82085 | diff --git a/config/excel.php b/config/excel.php
index c1fd34a6..f8595dcf 100644
--- a/config/excel.php
+++ b/config/excel.php
@@ -152,13 +152,13 @@
],
/*
- |--------------------------------------------------------------------------
- | Cell Middleware
- |--------------------------... | [
"config/excel.php"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,378 | issue_to_patch | PHPStan level 3 | `BatchCache` was making an assumption that the keys would always be an array in, which isn't the case but handeling it is a lot of extra work.
PHPStan level 4 is also mostly handled here, it mostly deals with unreachable code and redundant checks which is especially true now that we have native types on things. | 86cce13606e7cdf0f0b02007307c82d5c0b5fb3e | 2fe5659529f5946a93f34cde42fc6a7c2b5d1450 | diff --git a/phpstan.neon b/phpstan.neon
index 8538e4e8..e656bbe1 100644
--- a/phpstan.neon
+++ b/phpstan.neon
@@ -2,7 +2,7 @@ includes:
- phpstan-baseline.neon.php
parameters:
- level: 2
+ level: 3
paths:
- ./src
- ./tests
diff --git a/src/Cache/BatchCache.php b/src/Cache/BatchCach... | [
"phpstan.neon",
"src/Cache/BatchCache.php",
"src/Cache/CacheManager.php",
"src/Concerns/Importable.php",
"src/Excel.php",
"src/Fakes/ExcelFake.php",
"src/Files/Disk.php",
"src/Importer.php",
"src/QueuedWriter.php",
"src/Reader.php",
"src/Sheet.php",
"src/Validators/ValidationException.php",
... | [] | diff --git a/tests/Concerns/FromCollectionTest.php b/tests/Concerns/FromCollectionTest.php
index cd0ba324..eee3ad8c 100644
--- a/tests/Concerns/FromCollectionTest.php
+++ b/tests/Concerns/FromCollectionTest.php
@@ -50,8 +50,6 @@ public function test_can_export_from_lazy_collection(): void
{
if (!class_exi... | true | |
SpartnerNL/Laravel-Excel | 4,376 | issue_to_patch | Test lowest dependencies in CI and improve DX | Fixes https://github.com/SpartnerNL/Laravel-Excel/issues/4375
This configures tests to run in parallel via SQLite :memory: + Paratest cutting time to run the test suite down to just 15s on my machine (from 60s to 20s on CI), and makes it dead trivial to setup for anyone since all you now need is to satisfy `composer... | 5ebc91d1a3789354a92a77c021e2d253bf8b32ee | 58acd08b5cd76ab95fe645e1d66d92e0a5121a6f | diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index 4dd951af..c4a607ca 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -11,23 +11,12 @@ jobs:
if: "!contains(github.event.head_commit.message, 'skip ci')"
runs-on: ubuntu-latest
- servic... | [
".github/workflows/run-tests.yml",
".gitignore",
"composer.json",
"phpstan-baseline-psr-cache-3.neon",
"phpstan-baseline-psr-cache-pre-3.neon",
"phpstan-baseline.neon.php",
"phpstan.neon",
"phpunit.xml.dist",
"src/Cache/BatchCacheDeprecated.php",
"src/Cache/MemoryCacheDeprecated.php",
"tests/Cac... | [] | diff --git a/tests/Cache/BatchCacheTest.php b/tests/Cache/BatchCacheTest.php
index d21442a9..9d431b5c 100644
--- a/tests/Cache/BatchCacheTest.php
+++ b/tests/Cache/BatchCacheTest.php
@@ -12,7 +12,7 @@
use Maatwebsite\Excel\Cache\BatchCache;
use Maatwebsite\Excel\Cache\BatchCacheDeprecated;
use Maatwebsite\Excel\Cach... | true | |
SpartnerNL/Laravel-Excel | 4,374 | issue_to_patch | 4.x: Resolve PHPStan level 2 | This resolve PHPStan level 1 and 2 issues.
I have created an issue with PHPOffice regarding `listWorksheetInfo()` missing from there interface:
- https://github.com/PHPOffice/PhpSpreadsheet/issues/4883
For now I'm adding an `assert()` to catch anyone that might not have implemented the method.
Similarly `remem... | f06a267246a1ac2df870ce21361e81f0143c44e7 | 36a72aae908015a9bd61a4fb6bb3d03180dd28e0 | diff --git a/composer.json b/composer.json
index 0048d7cd..cd33a9a1 100644
--- a/composer.json
+++ b/composer.json
@@ -37,7 +37,8 @@
"driftingly/rector-laravel": "^2.3",
"phpstan/phpstan": "^2.1",
"larastan/larastan": "^3.0",
- "phpstan/extension-installer": "^1.4"
+ "phpstan/extension-installer": ... | [
"composer.json",
"phpstan.neon",
"src/Concerns/FromCollection.php",
"src/Fakes/ExcelFake.php",
"src/Imports/ModelManager.php",
"src/Reader.php",
"src/RegistersCustomConcerns.php",
"tests/Concerns/ShouldQueueWithoutChainTest.php",
"tests/Concerns/SkipsEmptyRowsTest.php",
"tests/Concerns/SkipsOnFail... | [] | diff --git a/tests/Concerns/ShouldQueueWithoutChainTest.php b/tests/Concerns/ShouldQueueWithoutChainTest.php
index 499f543d..5c3d82d8 100644
--- a/tests/Concerns/ShouldQueueWithoutChainTest.php
+++ b/tests/Concerns/ShouldQueueWithoutChainTest.php
@@ -73,6 +73,7 @@ public function test_the_cleanup_only_runs_when_all_job... | true | |
SpartnerNL/Laravel-Excel | 4,372 | issue_to_patch | Revert typed CacheInterface methods on deprecated cache drivers | ## Problem
Commit [9173150](https://github.com/SpartnerNL/Laravel-Excel/commit/9173150877bec0f1fabb6dfe2b26be1fad8a4ac4) (PR #4359) added PSR-16 3.0 native types to `MemoryCacheDeprecated` and `BatchCacheDeprecated` while `composer.json` still allows `psr/simple-cache` `^1.0||^2.0||^3.0`.
`CacheManager` already uses ... | 9fa5999adfda66efc42fe2218a76f8faea90b28a | 5aac7611bbeb3a4d30338351e9d092fe044cb1d8 | diff --git a/phpstan.neon b/phpstan.neon
index cded210f..55f8c38d 100644
--- a/phpstan.neon
+++ b/phpstan.neon
@@ -9,3 +9,8 @@ parameters:
configDirectories:
- ./tests
- ./config
+ # MemoryCacheDeprecated / BatchCacheDeprecated use untyped CacheInterface methods for psr/simple-cache ^1|^2.
+ ... | [
"phpstan.neon",
"src/Cache/BatchCacheDeprecated.php",
"src/Cache/MemoryCacheDeprecated.php"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,371 | issue_to_patch | Apply native types | This was made using PHP-cs-fixers to do a mostly automated conversion of PHPDoc to native type hints, but I still had to correct several and apply them manually to classes (mostly tests) that extends the base classes and fix existing type errors in the lib.
I did also apply a few bugfixes here as there as I hit them... | 4ecf0939105b0dd193d30a34e63cc8db45f504cd | 7b93d115c740a779d6554f70e094615e7adcaa05 | diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index da70597e..4dd951af 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -63,7 +63,8 @@ jobs:
composer require "laravel/framework:${{ matrix.laravel }}.*" "orchestra/testbench:${{ matrix.testb... | [
".github/workflows/run-tests.yml",
"composer.json",
"phpstan.neon",
"src/Cache/BatchCache.php",
"src/Cache/BatchCacheDeprecated.php",
"src/Cache/MemoryCache.php",
"src/Cache/MemoryCacheDeprecated.php",
"src/Cache/MemoryInterface.php",
"src/Cell.php",
"src/ChunkReader.php",
"src/Concerns/Exportab... | [] | diff --git a/tests/Cache/BatchCacheTest.php b/tests/Cache/BatchCacheTest.php
index 62ebb643..d21442a9 100644
--- a/tests/Cache/BatchCacheTest.php
+++ b/tests/Cache/BatchCacheTest.php
@@ -19,15 +19,9 @@
class BatchCacheTest extends TestCase
{
- /**
- * @var Repository
- */
- private $cache;
+ privat... | true | |
SpartnerNL/Laravel-Excel | 4,370 | issue_to_patch | Modernise (PHP 8.3) using PHP-cs-fixer | This applies the PHP-cs-fixers PHP 8.3 and 8.2-risky rules except for strict types. I have done over the result and made sure nothing bad happen from the risky changes, mostly it's just adding native `void` return, new octal annotation and const viability. | 9173150877bec0f1fabb6dfe2b26be1fad8a4ac4 | e73fea379ef1248eae4b23bfb0f9045912831a13 | diff --git a/src/Cache/BatchCache.php b/src/Cache/BatchCache.php
index 8f1cff04..532949ba 100644
--- a/src/Cache/BatchCache.php
+++ b/src/Cache/BatchCache.php
@@ -37,7 +37,7 @@ public function __sleep()
return ['memory'];
}
- public function __wakeup()
+ public function __wakeup(): void
{
... | [
"src/Cache/BatchCache.php",
"src/Cache/BatchCacheDeprecated.php",
"src/Cache/CacheManager.php",
"src/ChunkReader.php",
"src/Concerns/MapsCsvSettings.php",
"src/Concerns/RemembersChunkOffset.php",
"src/Concerns/RemembersRowNumber.php",
"src/Concerns/SkipsErrors.php",
"src/Concerns/SkipsFailures.php",... | [] | diff --git a/tests/Cache/BatchCacheTest.php b/tests/Cache/BatchCacheTest.php
index b7face91..62ebb643 100644
--- a/tests/Cache/BatchCacheTest.php
+++ b/tests/Cache/BatchCacheTest.php
@@ -29,7 +29,7 @@ class BatchCacheTest extends TestCase
*/
private $memory;
- public function test_will_get_multiple_from... | true | |
SpartnerNL/Laravel-Excel | 4,362 | issue_to_patch | 4.x: Replace StyleCI wtih Pint | Add and configure Pint so we can have a local code style tool that aligns with CI.
Don't worry to much about conflicts here, just merge the other PRs and I'll rebase this.
- [x] Checked the codebase to ensure that your feature doesn't already exist.
- [x] Take note of the contributing guidelines.
- [x] Checked ... | 3bc21797550bb5920e33c6d90175e1c504001e36 | 5c8076a98f2cc7f0db7dfcf15a573f666d0461e4 | diff --git a/.github/workflows/pint.yml b/.github/workflows/pint.yml
new file mode 100644
index 00000000..742648f1
--- /dev/null
+++ b/.github/workflows/pint.yml
@@ -0,0 +1,25 @@
+name: Code Style
+
+on:
+ push:
+ pull_request:
+
+jobs:
+ pint:
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Checkout code
+... | [
".github/workflows/pint.yml",
"composer.json",
"config/excel.php",
"pint.json",
"src/Cache/BatchCache.php",
"src/Cache/BatchCacheDeprecated.php",
"src/Cache/CacheManager.php",
"src/Cache/MemoryCache.php",
"src/Cache/MemoryCacheDeprecated.php",
"src/Cell.php",
"src/ChunkReader.php",
"src/Concer... | [
{
"comment": "```suggestion\n uses: actions/checkout@v6\n```\n\nThis should be updated to v6 because of node 20 being deprecated in runners: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/",
"path": ".github/workflows/pint.yml",
"hunk": "@@ -0,0 +1,25 @@... | diff --git a/tests/Cache/BatchCacheTest.php b/tests/Cache/BatchCacheTest.php
index bdc4c583..b7face91 100644
--- a/tests/Cache/BatchCacheTest.php
+++ b/tests/Cache/BatchCacheTest.php
@@ -68,7 +68,7 @@ public function test_will_get_multiple_from_cache_if_cells_are_persisted()
public function test_will_get_multipl... | true | |
SpartnerNL/Laravel-Excel | 4,362 | comment_to_fix | 4.x: Replace StyleCI wtih Pint | ```suggestion
uses: actions/checkout@v6
```
This should be updated to v6 because of node 20 being deprecated in runners: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/ | 3bc21797550bb5920e33c6d90175e1c504001e36 | 5c8076a98f2cc7f0db7dfcf15a573f666d0461e4 | diff --git a/.github/workflows/pint.yml b/.github/workflows/pint.yml
new file mode 100644
index 00000000..742648f1
--- /dev/null
+++ b/.github/workflows/pint.yml
@@ -0,0 +1,25 @@
+name: Code Style
+
+on:
+ push:
+ pull_request:
+
+jobs:
+ pint:
+ runs-on: ubuntu-latest
+
+ steps:
+ - name: Checkout code
+... | [
".github/workflows/pint.yml"
] | [
{
"comment": "```suggestion\n uses: actions/checkout@v6\n```\n\nThis should be updated to v6 because of node 20 being deprecated in runners: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/",
"path": ".github/workflows/pint.yml",
"hunk": "@@ -0,0 +1,25 @@... | true | ||
SpartnerNL/Laravel-Excel | 4,359 | issue_to_patch | 4.x: Address most issues found by PHPStan at level 0 | - `unset()` swapped for resetting the value to avoid possible issues with property hooks in extending classes.
- Corrected signatures to match the classes they extend
- Define properties used by traits
- Marked constructor as final when `new static` is being used, there are options, this is the simples and safest.
... | 8e355315967afc9d97cb55a5a32e278a1330ee5f | aa73ede463e8370e18a77845426a11ea9653f04d | diff --git a/composer.json b/composer.json
index 6ed3d193..7f9bc27d 100644
--- a/composer.json
+++ b/composer.json
@@ -33,7 +33,8 @@
"laravel/scout": "^10.0||^11.0",
"laravel/pint": "^1.0",
"rector/rector": "^2.4.2",
- "driftingly/rector-laravel": "^2.3"
+ "driftingly/rector-laravel": "^2.3",
+ ... | [
"composer.json",
"phpstan.neon",
"src/Cache/BatchCacheDeprecated.php",
"src/Cache/MemoryCacheDeprecated.php",
"src/Cell.php",
"src/Concerns/Exportable.php",
"src/Concerns/Importable.php",
"src/ExcelServiceProvider.php",
"src/Exceptions/ConcernConflictException.php",
"src/Exceptions/NoFilePathGiven... | [
{
"comment": "could this have php types instead of phpdoc?\n\n```php\nprotected ?Spreadsheet $spreadsheet = null;\n```",
"path": "src/Reader.php",
"hunk": "@@ -37,12 +37,12 @@ class Reader\n use DelegatedMacroable, HasEventBus;\n \n /**\n- * @var Spreadsheet\n+ * @var ?Spreadsheet\n ... | diff --git a/tests/Concerns/WithMultipleSheetsTest.php b/tests/Concerns/WithMultipleSheetsTest.php
index d62fe214..55901a4d 100644
--- a/tests/Concerns/WithMultipleSheetsTest.php
+++ b/tests/Concerns/WithMultipleSheetsTest.php
@@ -95,7 +95,8 @@ public function test_unknown_sheet_index_will_throw_sheet_not_found_excepti... | true | |
SpartnerNL/Laravel-Excel | 4,359 | comment_to_fix | 4.x: Address most issues found by PHPStan at level 0 | could this have php types instead of phpdoc?
```php
protected ?Spreadsheet $spreadsheet = null;
``` | 8e355315967afc9d97cb55a5a32e278a1330ee5f | aa73ede463e8370e18a77845426a11ea9653f04d | diff --git a/src/Reader.php b/src/Reader.php
index 566f6031..a0ebcc65 100644
--- a/src/Reader.php
+++ b/src/Reader.php
@@ -37,12 +37,12 @@ class Reader
use DelegatedMacroable, HasEventBus;
/**
- * @var Spreadsheet
+ * @var ?Spreadsheet
*/
protected $spreadsheet;
/**
- * @var ob... | [
"src/Reader.php"
] | [
{
"comment": "could this have php types instead of phpdoc?\n\n```php\nprotected ?Spreadsheet $spreadsheet = null;\n```",
"path": "src/Reader.php",
"hunk": "@@ -37,12 +37,12 @@ class Reader\n use DelegatedMacroable, HasEventBus;\n \n /**\n- * @var Spreadsheet\n+ * @var ?Spreadsheet\n ... | true | ||
SpartnerNL/Laravel-Excel | 4,359 | comment_to_fix | 4.x: Address most issues found by PHPStan at level 0 | same here | 8e355315967afc9d97cb55a5a32e278a1330ee5f | aa73ede463e8370e18a77845426a11ea9653f04d | diff --git a/src/Writer.php b/src/Writer.php
index 43193c19..18576006 100644
--- a/src/Writer.php
+++ b/src/Writer.php
@@ -28,9 +28,9 @@ class Writer
use DelegatedMacroable, HasEventBus;
/**
- * @var Spreadsheet
+ * @var ?Spreadsheet
*/
- protected $spreadsheet;
+ protected $spreadsheet ... | [
"src/Writer.php"
] | [
{
"comment": "same here",
"path": "src/Writer.php",
"hunk": "@@ -28,9 +28,9 @@ class Writer\n use DelegatedMacroable, HasEventBus;\n \n /**\n- * @var Spreadsheet\n+ * @var ?Spreadsheet\n */\n- protected $spreadsheet;\n+ protected $spreadsheet = null;",
"resolving_sha": "aa... | true | ||
SpartnerNL/Laravel-Excel | 4,364 | issue_to_patch | 4.x: Specify supported PHPUnit versions and modernize phpunit.xml.dist | Declare phpunit/phpunit ^12.0.1 || ^13.0.0 in require-dev (PHPUnit 11 went EOL Feb 2026), bump the schema URL to 12.5 (the lowest supported version), and surface deprecations/notices/warnings/errors via displayDetailsOn* attributes.
| 3bc21797550bb5920e33c6d90175e1c504001e36 | 54971210511165ad11aea34d2849ab84a869697e | diff --git a/composer.json b/composer.json
index e71e933d..72b1f429 100644
--- a/composer.json
+++ b/composer.json
@@ -29,6 +29,7 @@
},
"require-dev": {
"orchestra/testbench": "^10.0||^11.0",
+ "phpunit/phpunit": "^12.0.1||^13.0.0",
"predis/predis": "^1.1",
"laravel/scout": "^10.0||^11.0",
... | [
"composer.json",
"phpunit.xml.dist"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,369 | issue_to_patch | Docs: warn that FromQuery requires a unique ORDER BY | ## Why
`FromQuery` exports walk the supplied builder through Laravel's
`Builder::chunk()`, which paginates with `LIMIT/OFFSET`. If the source
query lacks a *unique* `ORDER BY`, the database engine is free to
reorder tied rows between subsequent paginated queries. The result: at
every chunk boundary one row can appear ... | 8e355315967afc9d97cb55a5a32e278a1330ee5f | 9c6f15c7854be5e1eaa9abeeef7ee821841a01b4 | diff --git a/src/Concerns/FromQuery.php b/src/Concerns/FromQuery.php
index 9e7ef49f..e36b3698 100644
--- a/src/Concerns/FromQuery.php
+++ b/src/Concerns/FromQuery.php
@@ -10,6 +10,34 @@
interface FromQuery
{
/**
+ * Return the builder whose rows should be exported.
+ *
+ * The export walks this query... | [
"src/Concerns/FromQuery.php"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,360 | issue_to_patch | 4.x: Initialize rector, apply targeted rule sets up to minimum currently supported php version (8.3) | ## Motivation
- Initialize Rector and apply targeted refactoring to bring the codebase
up to the new PHP 8.3 minimum (raised from 8.2 by upstream's drop of
PHP 8.2 / Laravel 11 support, merged in here).
- Layer in `driftingly/rector-laravel` so the project can track
Laravel-version migrations alongside the P... | 100d3d34b489049d45b67f94413619ea93f09aa3 | a26c1176000b2fb099d1d2fe1c03dfea07e743ba | diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index 2f015f11..da70597e 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -69,3 +69,39 @@ jobs:
run: vendor/bin/phpunit --testdox --configuration phpunit.xml.dist
env:
DB_PORT... | [
".github/workflows/run-tests.yml",
"composer.json",
"rector.php",
"src/Cell.php",
"src/ChunkReader.php",
"src/Concerns/Exportable.php",
"src/Concerns/Importable.php",
"src/Concerns/WithConditionalSheets.php",
"src/Console/ExportMakeCommand.php",
"src/Console/ImportMakeCommand.php",
"src/DefaultV... | [
{
"comment": "should we do an up to php 83 here as well or does it do that autoatmically?",
"path": "rector.php",
"hunk": "@@ -0,0 +1,30 @@\n+<?php\n+\n+declare(strict_types=1);\n+\n+use Rector\\Caching\\ValueObject\\Storage\\FileCacheStorage;\n+use Rector\\Config\\RectorConfig;\n+use Rector\\Php70\\Rec... | diff --git a/tests/Cache/BatchCacheTest.php b/tests/Cache/BatchCacheTest.php
index 589040e3..bdc4c583 100644
--- a/tests/Cache/BatchCacheTest.php
+++ b/tests/Cache/BatchCacheTest.php
@@ -178,9 +178,7 @@ public function test_it_writes_to_cache_with_default_ttl($defaultTTL, $receivedA
$dispatchedCollection = E... | true | |
SpartnerNL/Laravel-Excel | 4,363 | issue_to_patch | Upgrade GitHub Actions versions in run-tests.yml | This pull request updates the GitHub Actions workflow to use the latest versions of key action, because of upcoming deprecation of Node 20 actions.
- [x] Checked the codebase to ensure that your feature doesn't already exist.
- [x] Take note of the contributing guidelines.
- [x] Checked the pull requests to ensure... | ae5d65b7c9a2fac43bff4d44f796ac95d7a8e760 | 4e6d5b1507645ced7263e2d9590cc12adee7793f | diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index da5caede..39e54af2 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -137,10 +137,10 @@ jobs:
steps:
- name: Checkout code
- uses: actions/checkout@v4
+ uses: actions/chec... | [
".github/workflows/run-tests.yml"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,361 | issue_to_patch | 4.x: Bump required PHP and Laravel versions | Drop support for PHP versions before 8.3 and Laravel before 12
- [x] Checked the codebase to ensure that your feature doesn't already exist.
- [x] Take note of the contributing guidelines.
- [x] Checked the pull requests to ensure that another person hasn't already submitted a fix.
- [x] Added tests to ensure aga... | 4ff49665499e2698a3861d5804063b1424269e28 | d7c660c6e01f177674a6deb1abe495e57009cfb7 | diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index ecf3f061..2f015f11 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -24,8 +24,8 @@ jobs:
strategy:
fail-fast: false
matrix:
- php: [ 8.2, 8.3, 8.4, 8.5 ]
- laravel: ... | [
".github/workflows/run-tests.yml",
"composer.json"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,355 | issue_to_patch | Update minimum phpspreadsheet version to 1.30.4 (CVE-2026-40296) | Info here: https://github.com/advisories/GHSA-hrmw-qprp-wgmc
+ composer audit || { echo "✖ Composer audit found vulnerabilities"; exit 1; }
Found 2 security vulnerability advisories affecting 1 package:
+-------------------+----------------------------------------------------------------------------------+
| Pack... | 1854739267d81d38eae7d8c623caf523f30f256b | e06b7ac261e17ddfc4cbc1281d471462dcff19fb | diff --git a/composer.json b/composer.json
index b1325e2a..7d5724f1 100644
--- a/composer.json
+++ b/composer.json
@@ -22,7 +22,7 @@
"require": {
"ext-json": "*",
"php": "^7.0||^8.0",
- "phpoffice/phpspreadsheet": "^1.30.0",
+ "phpoffice/phpspreadsheet": "^1.30.4",
"illuminate/support": "5.8.*||... | [
"composer.json"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,351 | issue_to_patch | Sync 3.x to 4.x | 1️⃣ Why should it be added? What are the benefits of this change?
Sync commits from 3.x into next release branch
2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No
3️⃣ Does it include tests, if possible?
N/A
4️⃣ Any drawbacks? Possible breaking changes?
No
5️⃣ Mark the... | c143d1e573d7de088d2fce4f15a44df60ff8abe4 | 062fadedebd60b70948a266407b075dfa30058a4 | diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index 240daa02..ecf3f061 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -25,10 +25,13 @@ jobs:
fail-fast: false
matrix:
php: [ 8.2, 8.3, 8.4, 8.5 ]
- laravel: [ 12, 11 ]
+ ... | [
".github/workflows/run-tests.yml",
"composer.json"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,347 | issue_to_patch | Add additional tests explicitly for latest phpspreadsheet version | 1️⃣ Why should it be added? What are the benefits of this change?
Hopefully addresses concerns of missing tests against the v3+ changes in phpspreadsheet. I'm happy to split these tests across other test files or otherwise update the organization of them, but figured for initial discussion having them colocated would... | b774e3458a0d9a895f69b1d4baa0af3df90a4414 | 9babb3ac6f6c3cc793b72890230983ca608eb7e9 | [
"tests/PhpSpreadsheetV5CompatibilityTest.php"
] | [] | diff --git a/tests/PhpSpreadsheetV5CompatibilityTest.php b/tests/PhpSpreadsheetV5CompatibilityTest.php
new file mode 100644
index 00000000..3f8956aa
--- /dev/null
+++ b/tests/PhpSpreadsheetV5CompatibilityTest.php
@@ -0,0 +1,364 @@
+<?php
+
+namespace Maatwebsite\Excel\Tests;
+
+use Maatwebsite\Excel\Concerns\Exportable... | true | ||
SpartnerNL/Laravel-Excel | 4,325 | issue_to_patch | Fix: correct Laravel version range from 11.x to 12.x in compatibility | 1️⃣ Why should it be added? What are the benefits of this change?
This PR corrects a small documentation inaccuracy in the version compatibility table.
Currently, the table lists “<=11.x” for Laravel support under version 3.1, but the package is also compatible with Laravel 12.x.
Updating it improves clarity and pre... | e508e34a502a3acc3329b464dad257378a7edb4d | f59d45c7d6d497fc4064d1be638ce989089f9ae0 | diff --git a/README.md b/README.md
index 8ff5228a..f84f32a0 100644
--- a/README.md
+++ b/README.md
@@ -102,4 +102,4 @@ Versions will be supported for a limited amount of time.
|---- |----|----|----|
| 2.1 | <=5.6 | <=7.0 | Unsupported since 15-5-2018 |
| 3.0 | ^5.5 | ^7.0 | Unsupported since 31-12-2018 |
-| 3.1 | >... | [
"README.md"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,348 | issue_to_patch | feat: Update composer.json for Laravel 13 support | Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
1️⃣ Why should it be ... | 94cdb04e4a19eed76b95fd4443625a3e070dbd04 | d99d040ec0fec4bb1100281613cc9816390cf22b | diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index 18451c4b..785c85b2 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -24,10 +24,13 @@ jobs:
strategy:
matrix:
php: [7.4, 8.0, 8.1, 8.2, 8.3, 8.4, 8.5]
- laravel: [12, 11, ... | [
".github/workflows/run-tests.yml",
"composer.json"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,343 | issue_to_patch | Sync latest changes from 3.1 to 4.x | 1️⃣ **Why should it be added? What are the benefits of this change?**
This PR merges the 3.1 branch into 4.x, bringing over bug fixes, improvements, and feature consistency from 3.1 into the 4.x codebase. It ensures backward compatibility where possible and reduces maintenance overhead by consolidating the codebase.
... | 4ca1c4993446fb519c5b2d51cfbff133c7027702 | 8567638a3baf21a1fea358aabd5e4faf2d77aaf5 | diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index c5cf852c..240daa02 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -38,6 +38,8 @@ jobs:
exclude:
- laravel: 12
php: 8.1
+ - laravel: 11
+ php: 8... | [
".github/workflows/run-tests.yml",
"README.md",
"src/Exporter.php",
"src/Factories/WriterFactory.php",
"src/Jobs/QueueExport.php",
"src/Writer.php"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,334 | issue_to_patch | Fix 8.5 deprecation | Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
1️⃣ Why should it be ... | 8b55991b3f8e207e2c6758814b63b811890ddd0e | ac75707c34fc07498cfa70365fe3087ec67d5154 | diff --git a/src/Sheet.php b/src/Sheet.php
index 302da016..af25a8b5 100644
--- a/src/Sheet.php
+++ b/src/Sheet.php
@@ -766,8 +766,17 @@ protected function validated(WithValidation $import, int $startRow, $rows)
*/
protected function buildColumnRange(string $lower, string $upper)
{
- $upper++;
- ... | [
"src/Sheet.php"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,341 | issue_to_patch | Allow queue jobs with batches | 1️⃣ Why should it be added? What are the benefits of this change?
Allow import and export files with batches (New laravel feature for job batching).
2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No
3️⃣ Does it include tests, if possible?
No
4️⃣ Any drawbacks? Possible bre... | 44855f100d6a081afc73237d8232725c66944bdc | 241c040f2420bf86717fdcf0337197b095bc34ec | diff --git a/src/ChunkReader.php b/src/ChunkReader.php
index 3e55cc92..4c783214 100644
--- a/src/ChunkReader.php
+++ b/src/ChunkReader.php
@@ -2,6 +2,7 @@
namespace Maatwebsite\Excel;
+use Illuminate\Bus\PendingBatch;
use Illuminate\Bus\Queueable;
use Illuminate\Container\Container;
use Illuminate\Contracts\Que... | [
"src/ChunkReader.php",
"src/Concerns/ShouldBatch.php",
"src/Excel.php",
"src/Fakes/ExcelFake.php",
"src/Jobs/AfterImportJob.php",
"src/Jobs/AppendDataToSheet.php",
"src/Jobs/AppendPaginatedToSheet.php",
"src/Jobs/AppendQueryToSheet.php",
"src/Jobs/AppendViewToSheet.php",
"src/Jobs/CloseSheet.php",... | [] | diff --git a/tests/Data/Stubs/ShouldBatchExport.php b/tests/Data/Stubs/ShouldBatchExport.php
new file mode 100644
index 00000000..58160d88
--- /dev/null
+++ b/tests/Data/Stubs/ShouldBatchExport.php
@@ -0,0 +1,24 @@
+<?php
+
+namespace Maatwebsite\Excel\Tests\Data\Stubs;
+
+use Maatwebsite\Excel\Concerns\Exportable;
+us... | true | |
SpartnerNL/Laravel-Excel | 4,330 | issue_to_patch | Fix TSV processing, queued export crashes, and interface parameter consistency | 1️⃣ Why should it be added? What are the benefits of this change?
1. **TSV Files Work Correctly**: Add automatic TSV tab delimiter detection for proper TSV file handling
2. **Queued Exports No Longer Crash**: Undefined variable `$sheetExport` causing fatal errors in queued export jobs
3. **PHP 8+ Named Parameters S... | 294808cd1313c33d2181e933f7dccde4f9b3a8ba | d55a57684224c372753ffa40bfda3207b9767774 | diff --git a/src/Exporter.php b/src/Exporter.php
index 06c2c7dc..90f8548d 100644
--- a/src/Exporter.php
+++ b/src/Exporter.php
@@ -27,7 +27,7 @@ public function download($export, string $fileName, ?string $writerType = null,
* @throws \PhpOffice\PhpSpreadsheet\Exception
* @throws \PhpOffice\PhpSpreadsheet\W... | [
"src/Exporter.php",
"src/Factories/WriterFactory.php",
"src/Jobs/QueueExport.php",
"src/Writer.php"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,302 | issue_to_patch | [4.x] Upgrade PHPOffice to v5 | Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
1️⃣ Why should it be ... | e508e34a502a3acc3329b464dad257378a7edb4d | 310b937618ff7642d36f51aeeb142e94fdebb975 | diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index 537be5e9..c0adccab 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -9,11 +9,11 @@ on:
jobs:
tests:
if: "!contains(github.event.head_commit.message, 'skip ci')"
- runs-on: ${{ matrix.os ... | [
".github/workflows/run-tests.yml",
".gitignore",
".phpunit.cache/test-results",
"composer.json",
"src/DefaultValueBinder.php",
"src/Filters/ChunkReadFilter.php",
"src/Filters/LimitFilter.php",
"src/Reader.php",
"tests/Cache/BatchCacheTest.php",
"tests/Concerns/FromQueryTest.php",
"tests/Concerns... | [
{
"comment": "Should this be commented?",
"path": "src/Reader.php",
"hunk": "@@ -400,7 +400,8 @@ private function buildSheetImports($import): array\n method_exists($this->reader, 'setLoadSheetsOnly')\n && count(array_filter(array_keys($sheetImports), 'is_numeric')) === 0\... | diff --git a/tests/Cache/BatchCacheTest.php b/tests/Cache/BatchCacheTest.php
index 106643e6..589040e3 100644
--- a/tests/Cache/BatchCacheTest.php
+++ b/tests/Cache/BatchCacheTest.php
@@ -165,9 +165,6 @@ public function test_it_persists_to_cache_when_memory_limit_reached_on_setting_m
], $cache->getMultiple(['A1... | true | |
SpartnerNL/Laravel-Excel | 4,302 | comment_to_fix | [4.x] Upgrade PHPOffice to v5 | Should this be commented? | e508e34a502a3acc3329b464dad257378a7edb4d | 310b937618ff7642d36f51aeeb142e94fdebb975 | diff --git a/src/Reader.php b/src/Reader.php
index b2fbc1c2..0f109e20 100644
--- a/src/Reader.php
+++ b/src/Reader.php
@@ -402,6 +402,10 @@ private function buildSheetImports($import): array
) {
$this->reader->setLoadSheetsOnly(array_keys($sheetImports));
}
+
+ if (... | [
"src/Reader.php"
] | [
{
"comment": "Should this be commented?",
"path": "src/Reader.php",
"hunk": "@@ -400,7 +400,8 @@ private function buildSheetImports($import): array\n method_exists($this->reader, 'setLoadSheetsOnly')\n && count(array_filter(array_keys($sheetImports), 'is_numeric')) === 0\... | true | ||
SpartnerNL/Laravel-Excel | 4,302 | comment_to_fix | [4.x] Upgrade PHPOffice to v5 | You can drop all unsupported php and laravel versions here | e508e34a502a3acc3329b464dad257378a7edb4d | 310b937618ff7642d36f51aeeb142e94fdebb975 | diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index 537be5e9..c0adccab 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -9,11 +9,11 @@ on:
jobs:
tests:
if: "!contains(github.event.head_commit.message, 'skip ci')"
- runs-on: ${{ matrix.os ... | [
".github/workflows/run-tests.yml"
] | [
{
"comment": "You can drop all unsupported php and laravel versions here",
"path": ".github/workflows/run-tests.yml",
"hunk": "@@ -22,11 +22,12 @@ jobs:\n options: --health-cmd=\"mysqladmin ping\" --health-interval=10s --health-timeout=5s --health-retries=3\n \n strategy:\n+ fail-fast: ... | true | ||
SpartnerNL/Laravel-Excel | 4,302 | comment_to_fix | [4.x] Upgrade PHPOffice to v5 | the `--no-update` can stay here as we are calling update in the next line | e508e34a502a3acc3329b464dad257378a7edb4d | 310b937618ff7642d36f51aeeb142e94fdebb975 | diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index 537be5e9..c0adccab 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -9,11 +9,11 @@ on:
jobs:
tests:
if: "!contains(github.event.head_commit.message, 'skip ci')"
- runs-on: ${{ matrix.os ... | [
".github/workflows/run-tests.yml"
] | [
{
"comment": "the `--no-update` can stay here as we are calling update in the next line",
"path": ".github/workflows/run-tests.yml",
"hunk": "@@ -129,14 +91,9 @@ jobs:\n \n - name: Install dependencies\n run: |\n- composer require \"laravel/framework:${{ matrix.laravel }}.*\" \"or... | true | ||
SpartnerNL/Laravel-Excel | 4,302 | comment_to_fix | [4.x] Upgrade PHPOffice to v5 | only v4 | e508e34a502a3acc3329b464dad257378a7edb4d | 310b937618ff7642d36f51aeeb142e94fdebb975 | diff --git a/composer.json b/composer.json
index 10da2274..c407a585 100644
--- a/composer.json
+++ b/composer.json
@@ -21,16 +21,16 @@
],
"require": {
"ext-json": "*",
- "php": "^7.0||^8.0",
- "phpoffice/phpspreadsheet": "^1.30.0",
- "illuminate/support": "5.8.*||^6.0||^7.0||^8.0||^9.0||^10.0||^11.0... | [
"composer.json"
] | [
{
"comment": "only v4",
"path": "composer.json",
"hunk": "@@ -21,9 +21,9 @@\n ],\n \"require\": {\n \"ext-json\": \"*\",\n- \"php\": \"^7.0||^8.0\",\n- \"phpoffice/phpspreadsheet\": \"^1.29.9\",\n- \"illuminate/support\": \"5.8.*||^6.0||^7.0||^8.0||^9.0||^10.0||^11.0||^12.0\",\n+ \"p... | true | ||
SpartnerNL/Laravel-Excel | 4,302 | comment_to_fix | [4.x] Upgrade PHPOffice to v5 | So this is only a problem when the user provided invalid sheet names? | e508e34a502a3acc3329b464dad257378a7edb4d | 310b937618ff7642d36f51aeeb142e94fdebb975 | diff --git a/src/Reader.php b/src/Reader.php
index b2fbc1c2..0f109e20 100644
--- a/src/Reader.php
+++ b/src/Reader.php
@@ -402,6 +402,10 @@ private function buildSheetImports($import): array
) {
$this->reader->setLoadSheetsOnly(array_keys($sheetImports));
}
+
+ if (... | [
"src/Reader.php"
] | [
{
"comment": "So this is only a problem when the user provided invalid sheet names? ",
"path": "src/Reader.php",
"hunk": "@@ -400,7 +400,8 @@ private function buildSheetImports($import): array\n method_exists($this->reader, 'setLoadSheetsOnly')\n && count(array_filter(arr... | true | ||
SpartnerNL/Laravel-Excel | 4,302 | comment_to_fix | [4.x] Upgrade PHPOffice to v5 | If this fails on v4, we can just remove the test. If they don't support it, nothing we can do :) | e508e34a502a3acc3329b464dad257378a7edb4d | 310b937618ff7642d36f51aeeb142e94fdebb975 | diff --git a/tests/Concerns/WithCustomValueBinderTest.php b/tests/Concerns/WithCustomValueBinderTest.php
index 1e7c2f2d..2a20b4ef 100644
--- a/tests/Concerns/WithCustomValueBinderTest.php
+++ b/tests/Concerns/WithCustomValueBinderTest.php
@@ -6,16 +6,13 @@
use Illuminate\Support\Collection;
use Maatwebsite\Excel\Conc... | [
"tests/Concerns/WithCustomValueBinderTest.php"
] | [
{
"comment": "If this fails on v4, we can just remove the test. If they don't support it, nothing we can do :)",
"path": "tests/Concerns/WithCustomValueBinderTest.php",
"hunk": "@@ -97,12 +97,13 @@ public function bindValue(Cell $cell, $value)\n \n public function test_can_set_a_value_binder_on_impo... | true | ||
SpartnerNL/Laravel-Excel | 4,333 | issue_to_patch | Bump PhpSpreadsheet to 5.3 | Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
1️⃣ Why should it be ... | 1f9330666e3b84d772b3563765bd6725ec28fd82 | 6b7de8725e1f8c7192e4e32e204c1adfef91be04 | diff --git a/composer.json b/composer.json
index c407a585..9a2e2c32 100644
--- a/composer.json
+++ b/composer.json
@@ -22,7 +22,7 @@
"require": {
"ext-json": "*",
"php": "^8.1",
- "phpoffice/phpspreadsheet": "^5.1",
+ "phpoffice/phpspreadsheet": "^5.3",
"illuminate/support": "^10.0||^11.0||^12.0... | [
"composer.json"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,332 | issue_to_patch | Add PHP 8.5 to test matrix in CI workflow | Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
1️⃣ Why should it be ... | 294808cd1313c33d2181e933f7dccde4f9b3a8ba | cd3b146a87091d1dc798be6340bedd92de0308cc | diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index 537be5e9..18451c4b 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -23,7 +23,7 @@ jobs:
strategy:
matrix:
- php: [7.4, 8.0, 8.1, 8.2, 8.3, 8.4]
+ php: [7.4, 8.0, 8.1, 8.... | [
".github/workflows/run-tests.yml"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,327 | issue_to_patch | docs: edited the MIT license link | Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
1️⃣ Why should it be ... | 607fa209ba719fe4a99b59eb2b27439060247b99 | 47d2869fe9f76be0f83e983e7b79ddb81b9b2c05 | diff --git a/README.md b/README.md
index fd5a364d..8e6130ff 100644
--- a/README.md
+++ b/README.md
@@ -47,7 +47,7 @@ exports and imports.
<img src="https://poser.pugx.org/maatwebsite/excel/downloads.png" alt="Total Downloads">
</a>
- <a href="https://packagist.org/packages/maatwebsite/excel">
+ <a href="h... | [
"README.md"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,321 | issue_to_patch | chore: edited the Run tests badge | Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
1️⃣ Why should it be ... | e508e34a502a3acc3329b464dad257378a7edb4d | 3ed517daf954e45b2d5a10d6478d01fca00c2ea7 | diff --git a/README.md b/README.md
index 8ff5228a..22c03f6f 100644
--- a/README.md
+++ b/README.md
@@ -32,7 +32,7 @@ exports and imports.
<p align="center">
<a href="https://github.com/SpartnerNL/Laravel-Excel/actions">
- <img src="https://github.com/Maatwebsite/Laravel-Excel/workflows/Run%20tests/badge.svg?br... | [
"README.md"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,290 | issue_to_patch | fix: preserve RemoteTemporaryFile type when working with remote storage | ### 1️⃣ Why should it be added? What are the benefits of this change?
This PR fixes a critical bug in distributed environments where Laravel Excel exports are queued but processed across multiple servers. When using a remote disk for temporary files, if a different server processes the initial export job than the on... | 047cf457e1c234ae639cbc7f9b17e748a04b7676 | 228e4af70a75dc2f9c494075f87ebb0aa564e133 | diff --git a/src/Files/RemoteTemporaryFile.php b/src/Files/RemoteTemporaryFile.php
index 90e5b892..40fa4eda 100644
--- a/src/Files/RemoteTemporaryFile.php
+++ b/src/Files/RemoteTemporaryFile.php
@@ -93,14 +93,14 @@ public function delete(): bool
/**
* @return TemporaryFile
*/
- public function sync(... | [
"src/Files/RemoteTemporaryFile.php",
"src/Writer.php"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,306 | issue_to_patch | Bugfix stream_copy_to_stream() | https://github.com/SpartnerNL/Laravel-Excel/issues/4305
Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be close... | 047cf457e1c234ae639cbc7f9b17e748a04b7676 | ecdabee83d6f52dc91961830ff7a7ba7055fdcc6 | diff --git a/src/Files/Disk.php b/src/Files/Disk.php
index 023e9329..8eff156e 100644
--- a/src/Files/Disk.php
+++ b/src/Files/Disk.php
@@ -68,6 +68,10 @@ public function copy(TemporaryFile $source, string $destination): bool
{
$readStream = $source->readStream();
+ if (!is_resource($readStream)) ... | [
"src/Files/Disk.php"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,314 | issue_to_patch | fix: missing InteractsWithQueue trait in QueueExport class | Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
1️⃣ Why should it be ... | 4ef746726f9515784846e4d02f3c0f8f3eae0f29 | a40f397acc3c8cb56e288615513ac98d5ded03b8 | diff --git a/src/Jobs/QueueExport.php b/src/Jobs/QueueExport.php
index 768b7ae9..a5276fca 100644
--- a/src/Jobs/QueueExport.php
+++ b/src/Jobs/QueueExport.php
@@ -4,6 +4,7 @@
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Bus\Dispatchable;
+use Illuminate\Queue\InteractsWithQueue;
use Maatwe... | [
"src/Jobs/QueueExport.php",
"tests/InteractsWithQueueTest.php"
] | [] | diff --git a/tests/InteractsWithQueueTest.php b/tests/InteractsWithQueueTest.php
index bba0f74a..46786ded 100644
--- a/tests/InteractsWithQueueTest.php
+++ b/tests/InteractsWithQueueTest.php
@@ -6,6 +6,7 @@
use Maatwebsite\Excel\Jobs\AppendDataToSheet;
use Maatwebsite\Excel\Jobs\AppendQueryToSheet;
use Maatwebsite\E... | true | |
SpartnerNL/Laravel-Excel | 4,303 | issue_to_patch | Support `SkipsOnError` with `OnEachRow` | 1️⃣ Why should it be added? What are the benefits of this change?
This adds support for using the `SkipsOnError` interface when using the `OnEachRow` interface, allowing users to not have to catch exceptions themselves in `OnEachRow` and utilize a dedicated handle method.
2️⃣ Does it contain multiple, unrelated c... | e25d44a2d91da9179cd2d7fec952313548597a79 | 31d652360f87effd5e6a38341ecb26b898021dd8 | diff --git a/src/Sheet.php b/src/Sheet.php
index d403c0d2..302da016 100644
--- a/src/Sheet.php
+++ b/src/Sheet.php
@@ -15,6 +15,7 @@
use Maatwebsite\Excel\Concerns\OnEachRow;
use Maatwebsite\Excel\Concerns\ShouldAutoSize;
use Maatwebsite\Excel\Concerns\SkipsEmptyRows;
+use Maatwebsite\Excel\Concerns\SkipsOnError;
u... | [
"src/Sheet.php",
"tests/Concerns/SkipsOnErrorTest.php"
] | [
{
"comment": "should this be placed lower, not it only works when it has a WithValidation concern right?",
"path": "src/Sheet.php",
"hunk": "@@ -297,7 +299,11 @@ public function import($import, int $startRow = 1)\n try {\n app(RowValidator::class)->val... | diff --git a/tests/Concerns/SkipsOnErrorTest.php b/tests/Concerns/SkipsOnErrorTest.php
index efdacd38..d0ab99b5 100644
--- a/tests/Concerns/SkipsOnErrorTest.php
+++ b/tests/Concerns/SkipsOnErrorTest.php
@@ -4,12 +4,17 @@
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\QueryException;
+use Illuminate... | true | |
SpartnerNL/Laravel-Excel | 4,303 | comment_to_fix | Support `SkipsOnError` with `OnEachRow` | should this be placed lower, not it only works when it has a WithValidation concern right? | e25d44a2d91da9179cd2d7fec952313548597a79 | 31d652360f87effd5e6a38341ecb26b898021dd8 | diff --git a/src/Sheet.php b/src/Sheet.php
index d403c0d2..302da016 100644
--- a/src/Sheet.php
+++ b/src/Sheet.php
@@ -15,6 +15,7 @@
use Maatwebsite\Excel\Concerns\OnEachRow;
use Maatwebsite\Excel\Concerns\ShouldAutoSize;
use Maatwebsite\Excel\Concerns\SkipsEmptyRows;
+use Maatwebsite\Excel\Concerns\SkipsOnError;
u... | [
"src/Sheet.php"
] | [
{
"comment": "should this be placed lower, not it only works when it has a WithValidation concern right?",
"path": "src/Sheet.php",
"hunk": "@@ -297,7 +299,11 @@ public function import($import, int $startRow = 1)\n try {\n app(RowValidator::class)->val... | true | ||
SpartnerNL/Laravel-Excel | 4,303 | comment_to_fix | Support `SkipsOnError` with `OnEachRow` | Here we should also have a test with `new class implements OnEachRow, SkipsOnError` and throw an exception within the onRow | e25d44a2d91da9179cd2d7fec952313548597a79 | 31d652360f87effd5e6a38341ecb26b898021dd8 | diff --git a/tests/Concerns/SkipsOnErrorTest.php b/tests/Concerns/SkipsOnErrorTest.php
index efdacd38..d0ab99b5 100644
--- a/tests/Concerns/SkipsOnErrorTest.php
+++ b/tests/Concerns/SkipsOnErrorTest.php
@@ -4,12 +4,17 @@
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\QueryException;
+use Illuminate... | [
"tests/Concerns/SkipsOnErrorTest.php"
] | [
{
"comment": "Here we should also have a test with `new class implements OnEachRow, SkipsOnError` and throw an exception within the onRow",
"path": "tests/Concerns/SkipsOnErrorTest.php",
"hunk": "@@ -113,4 +118,126 @@ public function model(array $row)\n 'email' => 'taylor@laravel.com',\n ... | true | ||
SpartnerNL/Laravel-Excel | 4,278 | issue_to_patch | Include end row in `LimitFilter` | Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
1️⃣ Why should it be ... | 047cf457e1c234ae639cbc7f9b17e748a04b7676 | caf3685227b6edc2d85e1aca14f69f10a6c9ffae | diff --git a/src/Filters/LimitFilter.php b/src/Filters/LimitFilter.php
index 60dc41b3..91049043 100644
--- a/src/Filters/LimitFilter.php
+++ b/src/Filters/LimitFilter.php
@@ -34,6 +34,6 @@ public function __construct(int $startRow, int $limit)
*/
public function readCell($column, $row, $worksheetName = '')
... | [
"src/Filters/LimitFilter.php",
"tests/Concerns/WithLimitTest.php"
] | [] | diff --git a/tests/Concerns/WithLimitTest.php b/tests/Concerns/WithLimitTest.php
index cef81d1f..4edfc266 100644
--- a/tests/Concerns/WithLimitTest.php
+++ b/tests/Concerns/WithLimitTest.php
@@ -6,6 +6,7 @@
use Maatwebsite\Excel\Concerns\Importable;
use Maatwebsite\Excel\Concerns\ToArray;
use Maatwebsite\Excel\Conce... | true | |
SpartnerNL/Laravel-Excel | 4,269 | issue_to_patch | Support for Laravel 12 | Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
1️⃣ Why should it be ... | c7b9e2ef465f7e2d774220f72b936cd41e05c576 | d280f48e5483b8e2b3f3a7c3ae8bb6116be988ff | diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index 9ef87e56..537be5e9 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -24,10 +24,13 @@ jobs:
strategy:
matrix:
php: [7.4, 8.0, 8.1, 8.2, 8.3, 8.4]
- laravel: [11, 10, 9, 8,... | [
".github/workflows/run-tests.yml",
"composer.json"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,217 | issue_to_patch | [Bug]: Using WithLimit getting last record with null values
### Is the bug applicable and reproducable to the latest version of the package and hasn't it been reported before?
- [X] Yes, it's still reproducable
### What version of Laravel Excel are you using?
3.1.33
### What version of Laravel are you using?
8.11... | Exclude heading row when limiting imported rows | Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
1️⃣ Why should it be ... | 62616317c5ec07e885c5d7f6b537f57a7239c2ff | e7e27e7f9ae74ea09ca7eb558e97de84a7bd4dc7 | diff --git a/src/Factories/ReaderFactory.php b/src/Factories/ReaderFactory.php
index fbe4cfc3..0433d78a 100644
--- a/src/Factories/ReaderFactory.php
+++ b/src/Factories/ReaderFactory.php
@@ -4,6 +4,7 @@
use Maatwebsite\Excel\Concerns\MapsCsvSettings;
use Maatwebsite\Excel\Concerns\WithCustomCsvSettings;
+use Maatwe... | [
"src/Factories/ReaderFactory.php",
"tests/Concerns/WithLimitTest.php"
] | [
{
"comment": "Shouldn't we test here the exact contents of the array to be sure that it give the right now?",
"path": "tests/Concerns/WithLimitTest.php",
"hunk": "@@ -104,6 +105,32 @@ public function limit(): int\n $import->import('import-users.xlsx');\n }\n \n+ public function test_can_i... | diff --git a/tests/Concerns/WithLimitTest.php b/tests/Concerns/WithLimitTest.php
index cef81d1f..29a9acaf 100644
--- a/tests/Concerns/WithLimitTest.php
+++ b/tests/Concerns/WithLimitTest.php
@@ -6,6 +6,7 @@
use Maatwebsite\Excel\Concerns\Importable;
use Maatwebsite\Excel\Concerns\ToArray;
use Maatwebsite\Excel\Conce... | true |
SpartnerNL/Laravel-Excel | 4,272 | issue_to_patch | Revert "Exclude heading row when limiting imported rows" | Reverts SpartnerNL/Laravel-Excel#4217 | fccd234da23b39ab03e1a1f6fe9178fb96ec1be1 | 0882921e0d75b543616443b3d6dc1e70fcfb744d | diff --git a/src/Factories/ReaderFactory.php b/src/Factories/ReaderFactory.php
index 8ee3f5b4..dcab8f6e 100644
--- a/src/Factories/ReaderFactory.php
+++ b/src/Factories/ReaderFactory.php
@@ -4,7 +4,6 @@
use Maatwebsite\Excel\Concerns\MapsCsvSettings;
use Maatwebsite\Excel\Concerns\WithCustomCsvSettings;
-use Maatwe... | [
"src/Factories/ReaderFactory.php",
"tests/Concerns/WithLimitTest.php"
] | [] | diff --git a/tests/Concerns/WithLimitTest.php b/tests/Concerns/WithLimitTest.php
index 29a9acaf..cef81d1f 100644
--- a/tests/Concerns/WithLimitTest.php
+++ b/tests/Concerns/WithLimitTest.php
@@ -6,7 +6,6 @@
use Maatwebsite\Excel\Concerns\Importable;
use Maatwebsite\Excel\Concerns\ToArray;
use Maatwebsite\Excel\Conce... | true | |
SpartnerNL/Laravel-Excel | 4,221 | issue_to_patch | Avoid calling query() twice by adding a local var, fixes #4133 and #4140 | 1️⃣ Why should it be added? What are the benefits of this change?
This is a fix for [an issue reported in the Laravel Nova Excel project](https://github.com/SpartnerNL/Laravel-Nova-Excel/issues/181) - though it turned out that the issue was here, not there.
The problem is that if query() makes non-idempotent cha... | 62616317c5ec07e885c5d7f6b537f57a7239c2ff | f3515541004b9e2d7f10a5844254fb669e4fa377 | diff --git a/src/Sheet.php b/src/Sheet.php
index fdc59b46..23f0ef5c 100644
--- a/src/Sheet.php
+++ b/src/Sheet.php
@@ -465,13 +465,18 @@ public function fromView(FromView $sheetExport, $sheetIndex = null)
*/
public function fromQuery(FromQuery $sheetExport, Worksheet $worksheet)
{
- if ($sheetExp... | [
"src/Sheet.php",
"tests/Concerns/FromQueryTest.php",
"tests/Data/Stubs/FromUsersQueryWithJoinExport.php"
] | [] | diff --git a/tests/Concerns/FromQueryTest.php b/tests/Concerns/FromQueryTest.php
index 8ffcb726..112f38e8 100644
--- a/tests/Concerns/FromQueryTest.php
+++ b/tests/Concerns/FromQueryTest.php
@@ -11,6 +11,7 @@
use Maatwebsite\Excel\Tests\Data\Stubs\FromUsersQueryExport;
use Maatwebsite\Excel\Tests\Data\Stubs\FromUsers... | true | |
SpartnerNL/Laravel-Excel | 4,196 | issue_to_patch | Format rule for required_without | fix https://github.com/SpartnerNL/Laravel-Excel/pull/4183 | decfb9140161fcc117571e47e35ddf27983189ce | abd04755497d26128bc1104971170b8cea2d6277 | diff --git a/.phpunit.cache/test-results b/.phpunit.cache/test-results
index 1c2719cc..c68454c7 100644
--- a/.phpunit.cache/test-results
+++ b/.phpunit.cache/test-results
@@ -1,1 +1,1 @@
-{"version":1,"defects":{"Maatwebsite\\Excel\\Tests\\QueuedImportTest::can_queue_an_import_with_batch_cache":5,"Maatwebsite\\Excel\\T... | [
".phpunit.cache/test-results",
"src/Validators/RowValidator.php",
"tests/Validators/RowValidatorTest.php"
] | [] | diff --git a/tests/Validators/RowValidatorTest.php b/tests/Validators/RowValidatorTest.php
new file mode 100644
index 00000000..04258c71
--- /dev/null
+++ b/tests/Validators/RowValidatorTest.php
@@ -0,0 +1,96 @@
+<?php
+
+namespace Maatwebsite\Excel\Tests\Validators;
+
+use Illuminate\Contracts\Validation\Factory;
+use... | true | |
SpartnerNL/Laravel-Excel | 4,264 | issue_to_patch | Update phpspreadsheet to 1.29.8 to tackle CVE issue | Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
1️⃣ Why should it be ... | decfb9140161fcc117571e47e35ddf27983189ce | b671d7f130ad6eb7eabaa7cfaca2f8d606e0122c | diff --git a/composer.json b/composer.json
index 24e50357..1c9d2cd5 100644
--- a/composer.json
+++ b/composer.json
@@ -22,7 +22,7 @@
"require": {
"ext-json": "*",
"php": "^7.0||^8.0",
- "phpoffice/phpspreadsheet": "^1.29.7",
+ "phpoffice/phpspreadsheet": "^1.29.8",
"illuminate/support": "5.8.*||... | [
"composer.json"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,257 | issue_to_patch | fix XXE notice | Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
1️⃣ Why should it be ... | 62616317c5ec07e885c5d7f6b537f57a7239c2ff | d15f7d08d3db75db7b1eb09bb5cb6f4060d51598 | diff --git a/composer.json b/composer.json
index a52b93ab..24e50357 100644
--- a/composer.json
+++ b/composer.json
@@ -22,7 +22,7 @@
"require": {
"ext-json": "*",
"php": "^7.0||^8.0",
- "phpoffice/phpspreadsheet": "^1.29.4",
+ "phpoffice/phpspreadsheet": "^1.29.7",
"illuminate/support": "5.8.*||... | [
"composer.json"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,251 | issue_to_patch | refactor: explicit nullable parameters | 1️⃣ Why should it be added? What are the benefits of this change?
This PR makes Laravel-Excel compatible with PHP 8.4 without throwing deprecation warnings while maintaining backwards compatibility. There is a similar PR (#4248), but that one is also incorporating some breaking changes.
2️⃣ Does it contain mult... | 2caa5416d67c88ca03ac31533cc942f2d0ecbc50 | 01b2d356f1c20d38c2867d82d77f02a873a85377 | diff --git a/src/Cache/MemoryCache.php b/src/Cache/MemoryCache.php
index 8854529b..97745855 100644
--- a/src/Cache/MemoryCache.php
+++ b/src/Cache/MemoryCache.php
@@ -20,7 +20,7 @@ class MemoryCache implements CacheInterface
/**
* @param int|null $memoryLimit
*/
- public function __construct(int $... | [
"src/Cache/MemoryCache.php",
"src/Cache/MemoryCacheDeprecated.php",
"src/Concerns/Exportable.php",
"src/Concerns/Importable.php",
"src/Excel.php",
"src/Exceptions/NoFilePathGivenException.php",
"src/Exceptions/NoFilenameGivenException.php",
"src/Exceptions/NoTypeDetectedException.php",
"src/Exceptio... | [] | true | ||
SpartnerNL/Laravel-Excel | 4,249 | issue_to_patch | Php8.4 | Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
1️⃣ Why should it be ... | 08fa5a0840519ce003f9c641e26f92b1ec3194a1 | 9939043fdcbf9db698184167b264e8d8e6c1608e | diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
index 9d3f4932..9ef87e56 100644
--- a/.github/workflows/run-tests.yml
+++ b/.github/workflows/run-tests.yml
@@ -23,7 +23,7 @@ jobs:
strategy:
matrix:
- php: [7.4, 8.0, 8.1, 8.2, 8.3]
+ php: [7.4, 8.0, 8.1, 8.2, 8.... | [
".github/workflows/run-tests.yml"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,241 | issue_to_patch | Change parameters of NoTypeDetectedException because of php deprecati… | Hello,
When exception is thrown with parameters as null, PHP deprecation messages are shown. I tried to change parameters to empty string and 0 for code - basically defaults. I think, that this could not break anything, but it would remove these deprecation messages.
1️⃣ Why should it be added? What are the bene... | 4906dc57fbe6a41c405a77e1f7cac9078982c9c7 | 24941a0140591c5296cdcee763612293f0d468fa | diff --git a/src/Factories/ReaderFactory.php b/src/Factories/ReaderFactory.php
index fbe4cfc3..3a0ee7de 100644
--- a/src/Factories/ReaderFactory.php
+++ b/src/Factories/ReaderFactory.php
@@ -81,7 +81,7 @@ private static function identify(TemporaryFile $temporaryFile): string
try {
return IOFactory... | [
"src/Factories/ReaderFactory.php"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,227 | issue_to_patch | Adjust WithCharts into function close() | Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
1️⃣ Why should it be ... | c407d2ea32cd889dbaf69d3b9ba50b1cedfe23d0 | b85b4f52fa3ff10769b4a3b43b71b9f310610f99 | diff --git a/src/Sheet.php b/src/Sheet.php
index fdc59b46..26d0b8f2 100644
--- a/src/Sheet.php
+++ b/src/Sheet.php
@@ -189,10 +189,6 @@ public function open($sheetExport)
$this->hasStrictNullComparison($sheetExport)
);
}
-
- if ($sheetExport instanceof WithCharts) {
- ... | [
"src/Sheet.php"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,228 | issue_to_patch | Fixes TTL cache key name | Please take note of our contributing guidelines: https://docs.laravel-excel.com/3.1/getting-started/contributing.html
Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
1️⃣ Why should it be ... | c407d2ea32cd889dbaf69d3b9ba50b1cedfe23d0 | 944da5d3b7c586be9ebaecd4ad8e7f47a32fe31e | diff --git a/src/Cache/CacheManager.php b/src/Cache/CacheManager.php
index 5037847e..72e3917f 100644
--- a/src/Cache/CacheManager.php
+++ b/src/Cache/CacheManager.php
@@ -60,14 +60,14 @@ public function createBatchDriver(): CacheInterface
return new BatchCacheDeprecated(
$this->createIllum... | [
"src/Cache/CacheManager.php"
] | [] | true | ||
SpartnerNL/Laravel-Excel | 4,225 | issue_to_patch | Fix typo in missing file exception | Please forgive me for not filling in the template, but this is an extremely straightforward typo fix. | e848f23cf3e53e075fef94537bb90a91abbf19df | 922ce75878dde45ac870cc34c6e36dffaae6ac5d | diff --git a/src/Files/TemporaryFile.php b/src/Files/TemporaryFile.php
index 5827b99c..ebf849c1 100644
--- a/src/Files/TemporaryFile.php
+++ b/src/Files/TemporaryFile.php
@@ -66,7 +66,7 @@ public function copyFrom($filePath, string $disk = null): TemporaryFile
$logPath .= ' (' . $disk . ')';
... | [
"src/Files/TemporaryFile.php"
] | [] | true | ||
StereoDB/StereoDB | 49 | issue_to_patch | Add thread locking based on CAS
**Benchmarks results**
**CPU under using ReaderWriterLockSlim**
**CPU under using ... | added a basic impl for CasSpinLock | bbf2fd477ee0cc9546e51cbb1ca0f6a80692db00 | 75ca3067646d70a797b9230fdf47bae636a2fd09 | diff --git a/benchmarks/StereoDB.Benchmarks/Benchmarks/StereoDbBenchmark.cs b/benchmarks/StereoDB.Benchmarks/Benchmarks/StereoDbBenchmark.cs
index becea5b..101af53 100644
--- a/benchmarks/StereoDB.Benchmarks/Benchmarks/StereoDbBenchmark.cs
+++ b/benchmarks/StereoDB.Benchmarks/Benchmarks/StereoDbBenchmark.cs
@@ -1,5 +1,... | [
"benchmarks/StereoDB.Benchmarks/Benchmarks/StereoDbBenchmark.cs",
"benchmarks/StereoDB.Benchmarks/Program.cs",
"examples/StorageDemo/StorageDemo.csproj",
"src/StereoDB/AssemblyInfo.fs",
"src/StereoDB/Infra/ConcurrencyControl.fs",
"src/StereoDB/StereoDB.fsproj",
"src/StereoDB/StereoDb.fs"
] | [] | true | ||
StereoDB/StereoDB | 46 | issue_to_patch | adds redpanda docker compose | ed6064df8b901930b94886a0d3edaef5bca276a9 | 7fd529019428bd5b6133ad44ad021804b54a3ad7 | diff --git a/redpanda-docker-compose.yml b/redpanda-docker-compose.yml
new file mode 100644
index 0000000..a14b38c
--- /dev/null
+++ b/redpanda-docker-compose.yml
@@ -0,0 +1,59 @@
+name: stereodb-redpanda-cluster
+networks:
+ redpanda_network:
+ driver: bridge
+volumes:
+ redpanda-0: null
+ redpanda-1: null
+ re... | [
"redpanda-docker-compose.yml"
] | [
{
"comment": "Should I nitpick here ?",
"path": "redpanda-docker-compose.yml",
"hunk": "@@ -0,0 +1,59 @@\n+name: redpanda-quickstart",
"resolving_sha": "7fd529019428bd5b6133ad44ad021804b54a3ad7",
"resolving_diff": "diff --git a/redpanda-docker-compose.yml b/redpanda-docker-compose.yml\nnew file ... | true | |||
StereoDB/StereoDB | 46 | comment_to_fix | adds redpanda docker compose | ```suggestion
name: stereodb-redpanda-cluster
``` | ed6064df8b901930b94886a0d3edaef5bca276a9 | 7fd529019428bd5b6133ad44ad021804b54a3ad7 | diff --git a/redpanda-docker-compose.yml b/redpanda-docker-compose.yml
new file mode 100644
index 0000000..a14b38c
--- /dev/null
+++ b/redpanda-docker-compose.yml
@@ -0,0 +1,59 @@
+name: stereodb-redpanda-cluster
+networks:
+ redpanda_network:
+ driver: bridge
+volumes:
+ redpanda-0: null
+ redpanda-1: null
+ re... | [
"redpanda-docker-compose.yml"
] | [
{
"comment": "```suggestion\r\nname: stereodb-redpanda-cluster\r\n```",
"path": "redpanda-docker-compose.yml",
"hunk": "@@ -0,0 +1,59 @@\n+name: redpanda-quickstart",
"resolving_sha": "7fd529019428bd5b6133ad44ad021804b54a3ad7",
"resolving_diff": "diff --git a/redpanda-docker-compose.yml b/redpan... | true | ||
StereoDB/StereoDB | 45 | issue_to_patch | Implement Cluster Discovery based on Kafka topic
We need to have a mechanic that allows us to discover nodes in the cluster.
For this, we would like to use Kafka (Readpanda)
- [ ] Create a topic `stereodb_cluster_{cluster_id}` with a single partition (for simplicity we can use `auto.create.topics.enable` on kafka ... | 43: adds kafka service discovery | What was done in following PR
+ added creation of heartbeat topic and producing message in configured heartbeat interval
+ added sample consume task which subscribes on all stereodb topics with regex
+ added sample test to check if produce works as expected and marked with Integration category so they will be igno... | d084e7d934433c18044516263e1d612cd6ff2f41 | a0159082251aace60feef7bc900c43d950b70ca2 | diff --git a/.gitignore b/.gitignore
index f5b4c14..df94e44 100644
--- a/.gitignore
+++ b/.gitignore
@@ -122,6 +122,9 @@ $tf/
# Guidance Automation Toolkit
*.gpState
+# VS Code
+.vscode
+
# ReSharper is a .NET coding add-in
_ReSharper*/
*.[Rr]e[Ss]harper
diff --git a/src/StereoDB/Infra/Heartbeat.fs b/src/StereoD... | [
".gitignore",
"src/StereoDB/Infra/Heartbeat.fs",
"src/StereoDB/Infra/Utils.fs",
"src/StereoDB/StereoDB.fsproj",
"src/StereoDB/StereoDb.fs",
"tests/StereoDB.Tests/HeartbeatTests.fs",
"tests/StereoDB.Tests/StereoDB.Tests.fsproj"
] | [
{
"comment": "TODO @oleksiikraievyi add handling if topic exists + reasonable error messages \r\nalso discuss if we should retry or fail db spinning up",
"path": "src/StereoDB/StereoDb.fs",
"hunk": "@@ -122,8 +130,44 @@ type internal StereoDb<'TSchema when 'TSchema :> IDbSchema>(logger: ILogger, sch\n ... | diff --git a/tests/StereoDB.Tests/HeartbeatTests.fs b/tests/StereoDB.Tests/HeartbeatTests.fs
new file mode 100644
index 0000000..73a6d0f
--- /dev/null
+++ b/tests/StereoDB.Tests/HeartbeatTests.fs
@@ -0,0 +1,50 @@
+module Tests.HeartbeatTests
+
+open System.Collections.Concurrent
+open System.Threading.Tasks
+
+open Swe... | true |
StereoDB/StereoDB | 45 | comment_to_fix | 43: adds kafka service discovery | TODO @oleksiikraievyi add reasonable error message | d084e7d934433c18044516263e1d612cd6ff2f41 | a0159082251aace60feef7bc900c43d950b70ca2 | diff --git a/src/StereoDB/StereoDb.fs b/src/StereoDB/StereoDb.fs
index ea0c0cb..b97995b 100644
--- a/src/StereoDB/StereoDb.fs
+++ b/src/StereoDB/StereoDb.fs
@@ -2,32 +2,42 @@
#nowarn "3261"
open System
+open System.Linq
open System.Runtime.InteropServices
open System.Threading
open System.Threading.Tasks
+open C... | [
"src/StereoDB/StereoDb.fs"
] | [
{
"comment": "TODO @oleksiikraievyi add reasonable error message",
"path": "src/StereoDB/StereoDb.fs",
"hunk": "@@ -122,8 +130,44 @@ type internal StereoDb<'TSchema when 'TSchema :> IDbSchema>(logger: ILogger, sch\n with\n ex -> ()\n }\n+\n+ let createHeartbeatTopic = ... | true | ||
StereoDB/StereoDB | 45 | comment_to_fix | 43: adds kafka service discovery | TODO @oleksiikraievyi add retention.ms to config | d084e7d934433c18044516263e1d612cd6ff2f41 | a0159082251aace60feef7bc900c43d950b70ca2 | diff --git a/src/StereoDB/StereoDb.fs b/src/StereoDB/StereoDb.fs
index ea0c0cb..b97995b 100644
--- a/src/StereoDB/StereoDb.fs
+++ b/src/StereoDB/StereoDb.fs
@@ -2,32 +2,42 @@
#nowarn "3261"
open System
+open System.Linq
open System.Runtime.InteropServices
open System.Threading
open System.Threading.Tasks
+open C... | [
"src/StereoDB/StereoDb.fs"
] | [
{
"comment": "TODO @oleksiikraievyi add retention.ms to config",
"path": "src/StereoDB/StereoDb.fs",
"hunk": "@@ -122,8 +130,44 @@ type internal StereoDb<'TSchema when 'TSchema :> IDbSchema>(logger: ILogger, sch\n with\n ex -> ()\n }\n+\n+ let createHeartbeatTopic = ta... | true | ||
StereoDB/StereoDB | 45 | comment_to_fix | 43: adds kafka service discovery | TODO @oleksiikraievyi discuss if we should use acks.all or acks.leader | d084e7d934433c18044516263e1d612cd6ff2f41 | a0159082251aace60feef7bc900c43d950b70ca2 | diff --git a/src/StereoDB/StereoDb.fs b/src/StereoDB/StereoDb.fs
index ea0c0cb..b97995b 100644
--- a/src/StereoDB/StereoDb.fs
+++ b/src/StereoDB/StereoDb.fs
@@ -2,32 +2,42 @@
#nowarn "3261"
open System
+open System.Linq
open System.Runtime.InteropServices
open System.Threading
open System.Threading.Tasks
+open C... | [
"src/StereoDB/StereoDb.fs"
] | [
{
"comment": "TODO @oleksiikraievyi discuss if we should use acks.all or acks.leader",
"path": "src/StereoDB/StereoDb.fs",
"hunk": "@@ -122,8 +130,44 @@ type internal StereoDb<'TSchema when 'TSchema :> IDbSchema>(logger: ILogger, sch\n with\n ex -> ()\n }\n+\n+ let cre... | true | ||
StereoDB/StereoDB | 45 | comment_to_fix | 43: adds kafka service discovery | TODO @oleksiikraievyi add new lines at the EOF | d084e7d934433c18044516263e1d612cd6ff2f41 | a0159082251aace60feef7bc900c43d950b70ca2 | diff --git a/src/StereoDB/Infra/Utils.fs b/src/StereoDB/Infra/Utils.fs
index aabc898..f837acc 100644
--- a/src/StereoDB/Infra/Utils.fs
+++ b/src/StereoDB/Infra/Utils.fs
@@ -1,7 +1,9 @@
module internal StereoDB.Infra.Utils
open System
+open System.Linq
open System.Collections.Generic
+open System.Net.Sockets
open... | [
"src/StereoDB/Infra/Utils.fs"
] | [
{
"comment": "TODO @oleksiikraievyi add new lines at the EOF",
"path": "src/StereoDB/Infra/Utils.fs",
"hunk": "@@ -48,4 +48,12 @@ module Seq =\n module MessagePack =\n \n let defaultOptions =\n- MessagePackSerializerOptions.Standard.WithResolver(ContractlessStandardResolverAllowPrivate.In... | true | ||
StereoDB/StereoDB | 45 | comment_to_fix | 43: adds kafka service discovery | you can remove |
```
try
some code
with
ex -> ()
``` | d084e7d934433c18044516263e1d612cd6ff2f41 | a0159082251aace60feef7bc900c43d950b70ca2 | diff --git a/src/StereoDB/StereoDb.fs b/src/StereoDB/StereoDb.fs
index ea0c0cb..b97995b 100644
--- a/src/StereoDB/StereoDb.fs
+++ b/src/StereoDB/StereoDb.fs
@@ -2,32 +2,42 @@
#nowarn "3261"
open System
+open System.Linq
open System.Runtime.InteropServices
open System.Threading
open System.Threading.Tasks
+open C... | [
"src/StereoDB/StereoDb.fs"
] | [
{
"comment": "you can remove |\r\n```\r\ntry\r\n some code\r\nwith\r\n ex -> ()\r\n```",
"path": "src/StereoDB/StereoDb.fs",
"hunk": "@@ -122,8 +130,44 @@ type internal StereoDb<'TSchema when 'TSchema :> IDbSchema>(logger: ILogger, sch\n with\n ex -> ()\n }\n+\n+ ... | true | ||
StereoDB/StereoDB | 45 | comment_to_fix | 43: adds kafka service discovery | Maybe we can mark with using category, and document command how we can run with test category disabled? | d084e7d934433c18044516263e1d612cd6ff2f41 | a0159082251aace60feef7bc900c43d950b70ca2 | diff --git a/tests/StereoDB.Tests/HeartbeatTests.fs b/tests/StereoDB.Tests/HeartbeatTests.fs
new file mode 100644
index 0000000..73a6d0f
--- /dev/null
+++ b/tests/StereoDB.Tests/HeartbeatTests.fs
@@ -0,0 +1,50 @@
+module Tests.HeartbeatTests
+
+open System.Collections.Concurrent
+open System.Threading.Tasks
+
+open Swe... | [
"tests/StereoDB.Tests/HeartbeatTests.fs"
] | [
{
"comment": "Maybe we can mark with using category, and document command how we can run with test category disabled?",
"path": "tests/StereoDB.Tests/HeartbeatTests.fs",
"hunk": "@@ -14,25 +14,30 @@ open Tests.TestHelper\n open System\n open System.Threading\n \n-[<Fact>]\n+[<Fact(Skip = \"requires loca... | true | ||
StereoDB/StereoDB | 45 | comment_to_fix | 43: adds kafka service discovery | you can use
```let _ = adminClient.CreateTopicsAsync```
I suppose you don't even need
```r |> ignore``` | d084e7d934433c18044516263e1d612cd6ff2f41 | a0159082251aace60feef7bc900c43d950b70ca2 | diff --git a/src/StereoDB/StereoDb.fs b/src/StereoDB/StereoDb.fs
index ea0c0cb..b97995b 100644
--- a/src/StereoDB/StereoDb.fs
+++ b/src/StereoDB/StereoDb.fs
@@ -2,32 +2,42 @@
#nowarn "3261"
open System
+open System.Linq
open System.Runtime.InteropServices
open System.Threading
open System.Threading.Tasks
+open C... | [
"src/StereoDB/StereoDb.fs"
] | [
{
"comment": "you can use\r\n```let _ = adminClient.CreateTopicsAsync```\r\nI suppose you don't even need \r\n```r |> ignore```",
"path": "src/StereoDB/StereoDb.fs",
"hunk": "@@ -122,10 +135,53 @@ type internal StereoDb<'TSchema when 'TSchema :> IDbSchema>(logger: ILogger, sch\n with\n ... | true | ||
StereoDB/StereoDB | 45 | comment_to_fix | 43: adds kafka service discovery | maybe
```while not cts.IsCancellationRequested do``` | d084e7d934433c18044516263e1d612cd6ff2f41 | a0159082251aace60feef7bc900c43d950b70ca2 | diff --git a/tests/StereoDB.Tests/HeartbeatTests.fs b/tests/StereoDB.Tests/HeartbeatTests.fs
new file mode 100644
index 0000000..73a6d0f
--- /dev/null
+++ b/tests/StereoDB.Tests/HeartbeatTests.fs
@@ -0,0 +1,50 @@
+module Tests.HeartbeatTests
+
+open System.Collections.Concurrent
+open System.Threading.Tasks
+
+open Swe... | [
"tests/StereoDB.Tests/HeartbeatTests.fs"
] | [
{
"comment": "maybe \r\n```while not cts.IsCancellationRequested do```",
"path": "tests/StereoDB.Tests/HeartbeatTests.fs",
"hunk": "@@ -0,0 +1,47 @@\n+module Tests.HeartbeatTests\n+\n+open System.Collections.Concurrent\n+open System.Threading.Tasks\n+\n+open Swensen.Unquote\n+open Xunit\n+\n+open Conflu... | true | ||
StereoDB/StereoDB | 45 | comment_to_fix | 43: adds kafka service discovery | It seems your consumer should listen Heartbeats only from your ClusterId | d084e7d934433c18044516263e1d612cd6ff2f41 | a0159082251aace60feef7bc900c43d950b70ca2 | diff --git a/src/StereoDB/StereoDb.fs b/src/StereoDB/StereoDb.fs
index ea0c0cb..b97995b 100644
--- a/src/StereoDB/StereoDb.fs
+++ b/src/StereoDB/StereoDb.fs
@@ -2,32 +2,42 @@
#nowarn "3261"
open System
+open System.Linq
open System.Runtime.InteropServices
open System.Threading
open System.Threading.Tasks
+open C... | [
"src/StereoDB/StereoDb.fs"
] | [
{
"comment": "It seems your consumer should listen Heartbeats only from your ClusterId",
"path": "src/StereoDB/StereoDb.fs",
"hunk": "@@ -122,10 +136,70 @@ type internal StereoDb<'TSchema when 'TSchema :> IDbSchema>(logger: ILogger, sch\n with\n ex -> ()\n }\n+\n+ let ... | true | ||
StereoDB/StereoDB | 45 | comment_to_fix | 43: adds kafka service discovery | F# is nice, you can write
```cts.CancelAfter(TimeSpan.FromSeconds 10)``` | d084e7d934433c18044516263e1d612cd6ff2f41 | a0159082251aace60feef7bc900c43d950b70ca2 | diff --git a/tests/StereoDB.Tests/HeartbeatTests.fs b/tests/StereoDB.Tests/HeartbeatTests.fs
new file mode 100644
index 0000000..73a6d0f
--- /dev/null
+++ b/tests/StereoDB.Tests/HeartbeatTests.fs
@@ -0,0 +1,50 @@
+module Tests.HeartbeatTests
+
+open System.Collections.Concurrent
+open System.Threading.Tasks
+
+open Swe... | [
"tests/StereoDB.Tests/HeartbeatTests.fs"
] | [
{
"comment": "F# is nice, you can write\r\n```cts.CancelAfter(TimeSpan.FromSeconds 10)```",
"path": "tests/StereoDB.Tests/HeartbeatTests.fs",
"hunk": "@@ -0,0 +1,51 @@\n+module Tests.HeartbeatTests\n+\n+open System.Collections.Concurrent\n+open System.Threading.Tasks\n+\n+open Swensen.Unquote\n+open Xun... | true | ||
StereoDB/StereoDB | 45 | comment_to_fix | 43: adds kafka service discovery | why do you need Task Yielding for each iteration?
It seems you can use it only once, on top of while
```
do! Task.Yield()
try
while not cts.IsCancellationRequested do
``` | d084e7d934433c18044516263e1d612cd6ff2f41 | a0159082251aace60feef7bc900c43d950b70ca2 | diff --git a/tests/StereoDB.Tests/HeartbeatTests.fs b/tests/StereoDB.Tests/HeartbeatTests.fs
new file mode 100644
index 0000000..73a6d0f
--- /dev/null
+++ b/tests/StereoDB.Tests/HeartbeatTests.fs
@@ -0,0 +1,50 @@
+module Tests.HeartbeatTests
+
+open System.Collections.Concurrent
+open System.Threading.Tasks
+
+open Swe... | [
"tests/StereoDB.Tests/HeartbeatTests.fs"
] | [
{
"comment": "why do you need Task Yielding for each iteration?\r\nIt seems you can use it only once, on top of while\r\n\r\n```\r\ndo! Task.Yield()\r\ntry\r\n while not cts.IsCancellationRequested do\r\n```",
"path": "tests/StereoDB.Tests/HeartbeatTests.fs",
"hunk": "@@ -0,0 +1,51 @@\n+module Tests.... | true | ||
StereoDB/StereoDB | 39 | issue_to_patch | Try to add CollectionsMarshal for Dictionary operations
- https://blog.ndepend.com/faster-dictionary-in-c/
- https://github.com/dotnet/runtime/issues/27062 | added CollectionsMarshal GetValueRefOrAddDefault | 9ac25e4beedd33523bbe753297443ad78ae6a6e7 | b8ac9078468e3904b318d6aec6b7ad56b1635367 | diff --git a/benchmarks/StereoDB.Benchmarks/Benchmarks/StereoDbBenchmark.cs b/benchmarks/StereoDB.Benchmarks/Benchmarks/StereoDbBenchmark.cs
index 427cfc6..becea5b 100644
--- a/benchmarks/StereoDB.Benchmarks/Benchmarks/StereoDbBenchmark.cs
+++ b/benchmarks/StereoDB.Benchmarks/Benchmarks/StereoDbBenchmark.cs
@@ -34,6 +3... | [
"benchmarks/StereoDB.Benchmarks/Benchmarks/StereoDbBenchmark.cs",
"benchmarks/StereoDB.Benchmarks/StereoDB.Benchmarks.csproj",
"src/StereoDB/Constants.fs",
"src/StereoDB/SecondaryIndex/MultiValueIndex.fs",
"src/StereoDB/SecondaryIndex/ValueIndex.fs",
"src/StereoDB/StereoDB.fsproj",
"src/StereoDB/Storage... | [] | diff --git a/tests/StereoDB.Tests/StereoDB.Tests.fsproj b/tests/StereoDB.Tests/StereoDB.Tests.fsproj
index adb51e0..ca27071 100644
--- a/tests/StereoDB.Tests/StereoDB.Tests.fsproj
+++ b/tests/StereoDB.Tests/StereoDB.Tests.fsproj
@@ -34,7 +34,7 @@
<PackageReference Include="FsCheck" Version="2.16.6" />
... | true | |
StereoDB/StereoDB | 36 | issue_to_patch | Add file persistence | - Writes should be handled in non-blocking manner (on background)
- Use FASTER append log for writing records
- Use Sqlite for checkpoint key's addresses | f6b8e1c2633d4721bfcb751f89f6e9e2a9f7918b | 453822199a3b97f513862b47aee3ead382e79495 | diff --git a/README.md b/README.md
index 364e667..1a5ec16 100644
--- a/README.md
+++ b/README.md
@@ -13,10 +13,11 @@ Supported features:
- [x] Basic SQL support
- [x] Transactions (read-only, read-write)
- [x] Secondary Indexes
- - [x] Value Index (hash-based index)
+ - [x] Value Index
+ - [x] MultiValue Index
... | [
"README.md",
"StereoDB.sln",
"benchmarks/StereoDB.Benchmarks/Benchmarks/StereoDbBenchmark.cs",
"examples/Demo/DbSchema.cs",
"examples/Demo/Demo.csproj",
"examples/Demo/Dockerfile",
"examples/Demo/Program.cs",
"examples/StorageDemo/DbSchema.cs",
"examples/StorageDemo/Program.cs",
"examples/StorageD... | [] | diff --git a/tests/StereoDB.Sql.Tests/Sql/Delete.fs b/tests/StereoDB.Sql.Tests/Sql/Delete.fs
index 9731d19..80ed39f 100644
--- a/tests/StereoDB.Sql.Tests/Sql/Delete.fs
+++ b/tests/StereoDB.Sql.Tests/Sql/Delete.fs
@@ -9,8 +9,8 @@ open StereoDB.FSharp
open Tests.TestHelper
[<Fact>]
-let ``Delete all rows in table`` (... | true | |
StereoDB/StereoDB | 28 | issue_to_patch | Move SQL support to StereoDB.SQL
https://github.com/StereoDB/StereoDB.SQL | Extract SQL support into separate library | Other unrelated changes
- Net 7.0 removed from list of tested configurations, use .NET 6 and .NET 8
- I notice that StereoDB target netstanard2.1 which is pointless.
- I have to keep .NET 7 support in the tests for StereoDB.Sql, since it appear that I rely on autoconversion behavior of Linq which appears in the .NET... | 128e02bb4951b43fad94572e0d64dff768ac26d8 | 668b734683d6b33bc6a5ae9c4433a0f2caa50f96 | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index d3b0148..c8833e8 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -16,7 +16,10 @@ jobs:
- name: Setup .NET
uses: actions/setup-dotnet@v2
with:
- dotnet-version: 7.x.x
+ dotnet-versi... | [
".github/workflows/build.yml",
"StereoDB.sln",
"src/StereoDB.Sql/Sql.fs",
"src/StereoDB.Sql/SqlExtensions.fs",
"src/StereoDB.Sql/SqlParser.fs",
"src/StereoDB.Sql/StereoDB.Sql.fsproj",
"src/StereoDB/Contracts/FSharp.fs",
"src/StereoDB/StereoDB.fsproj",
"src/StereoDB/StereoDb.fs",
"tests/StereoDB.Sq... | [] | diff --git a/tests/StereoDB.Sql.Tests/Program.fs b/tests/StereoDB.Sql.Tests/Program.fs
new file mode 100644
index 0000000..5a6f28c
--- /dev/null
+++ b/tests/StereoDB.Sql.Tests/Program.fs
@@ -0,0 +1,5 @@
+module Program =
+
+ [<EntryPoint>]
+ let main _ =
+ 0
diff --git a/tests/StereoDB.Tests/Sql/Delete.fs... | true |
StereoDB/StereoDB | 25 | issue_to_patch | Add support for IS NULL/IS NOT NULL | 301f86dccbaf3bf2f3e90f03c593d90c839a0470 | daa1fb46cddd34cbbdb9eade16c22b0c3d167d3e | diff --git a/src/StereoDB/Infra/Sql/Sql.fs b/src/StereoDB/Infra/Sql/Sql.fs
index 0309752..c481f06 100644
--- a/src/StereoDB/Infra/Sql/Sql.fs
+++ b/src/StereoDB/Infra/Sql/Sql.fs
@@ -232,8 +232,12 @@ module internal QueryBuilder =
| "=" -> Expression.Equal(leftExpression, rightExpression)
... | [
"src/StereoDB/Infra/Sql/Sql.fs",
"tests/StereoDB.Tests/Sql/Select.fs",
"tests/StereoDB.Tests/TestHelper.fs"
] | [] | diff --git a/tests/StereoDB.Tests/Sql/Select.fs b/tests/StereoDB.Tests/Sql/Select.fs
index bfa8519..565ae52 100644
--- a/tests/StereoDB.Tests/Sql/Select.fs
+++ b/tests/StereoDB.Tests/Sql/Select.fs
@@ -17,6 +17,12 @@ type SuperBook =
Quantity: int
}
+type BookTitle =
+ {
+ Id: int
+ Titl... | true | ||
StereoDB/StereoDB | 26 | issue_to_patch | ADD Support for Between | https://github.com/StereoDB/StereoDB/issues/24 | f4f25a7f7005a72d05a6d1c9c4b41de92a64d75b | 008a4ea6d45ec57dc470ba9a18958461ab090766 | diff --git a/src/StereoDB/Infra/Sql/Sql.fs b/src/StereoDB/Infra/Sql/Sql.fs
index 7be2511..0309752 100644
--- a/src/StereoDB/Infra/Sql/Sql.fs
+++ b/src/StereoDB/Infra/Sql/Sql.fs
@@ -234,6 +234,15 @@ module internal QueryBuilder =
| UnaryLogicalOperator (op, expr) -> failwith "Not implemented"
|... | [
"src/StereoDB/Infra/Sql/Sql.fs",
"src/StereoDB/Infra/Sql/SqlParser.fs",
"tests/StereoDB.Tests/Sql/Select.fs"
] | [] | diff --git a/tests/StereoDB.Tests/Sql/Select.fs b/tests/StereoDB.Tests/Sql/Select.fs
index 15bac26..bfa8519 100644
--- a/tests/StereoDB.Tests/Sql/Select.fs
+++ b/tests/StereoDB.Tests/Sql/Select.fs
@@ -282,3 +282,19 @@ let ``Alias for table`` (sql) =
let book2 = result.Value[2]
test <@ book2.SuperId = 7 @>
... | true | |
StereoDB/StereoDB | 23 | issue_to_patch | Add support for alias in UPDATE and DELETE statements | 4bce3c23b652d3dfd5c911e4512e386fa5c2b947 | 66f56ffe9829ab4a97415349027a537bbcd28b2f | diff --git a/src/StereoDB/Infra/Sql/Sql.fs b/src/StereoDB/Infra/Sql/Sql.fs
index 7228569..7be2511 100644
--- a/src/StereoDB/Infra/Sql/Sql.fs
+++ b/src/StereoDB/Infra/Sql/Sql.fs
@@ -433,7 +433,17 @@ module internal QueryBuilder =
let readTransaction = Expression.Lambda (resultLambdaType, letFunction, co... | [
"src/StereoDB/Infra/Sql/Sql.fs",
"src/StereoDB/Infra/Sql/SqlParser.fs",
"tests/StereoDB.Tests/Sql/Delete.fs",
"tests/StereoDB.Tests/Sql/Update.fs"
] | [] | diff --git a/tests/StereoDB.Tests/Sql/Delete.fs b/tests/StereoDB.Tests/Sql/Delete.fs
index 4e75d7d..c837282 100644
--- a/tests/StereoDB.Tests/Sql/Delete.fs
+++ b/tests/StereoDB.Tests/Sql/Delete.fs
@@ -35,8 +35,12 @@ let ``Delete all rows in table`` () =
let allIdsCount = result.Value
test <@ allIdsCount = 0 @... | true | ||
StereoDB/StereoDB | 22 | issue_to_patch | Add table alias support for select | 565556683243a185a703f81d200bf81fa7f7d1af | 24a30191de80a2e41b59f6bb404314a7e419b531 | diff --git a/src/StereoDB/Infra/Sql/Sql.fs b/src/StereoDB/Infra/Sql/Sql.fs
index a9664b2..7228569 100644
--- a/src/StereoDB/Infra/Sql/Sql.fs
+++ b/src/StereoDB/Infra/Sql/Sql.fs
@@ -92,6 +92,11 @@ module internal QueryBuilder =
Some (schemaProperty, tableEntityType, keyType.GenericTypeArguments[0])
... | [
"src/StereoDB/Infra/Sql/Sql.fs",
"src/StereoDB/Infra/Sql/SqlParser.fs",
"tests/StereoDB.Tests/Sql/Select.fs"
] | [] | diff --git a/tests/StereoDB.Tests/Sql/Select.fs b/tests/StereoDB.Tests/Sql/Select.fs
index 0360388..15bac26 100644
--- a/tests/StereoDB.Tests/Sql/Select.fs
+++ b/tests/StereoDB.Tests/Sql/Select.fs
@@ -11,6 +11,12 @@ type SubBook =
Quantity: int
}
+type SuperBook =
+ {
+ SuperId: int
+ Q... | true | ||
StereoDB/StereoDB | 21 | issue_to_patch | This is TOP Obviously this is support for TOP :) | Obviously this is support for TOP :) | 7ba17b923124316a7daa83389cad52015d7d1f0e | 64b1521f511837c08ad5cb23bfe4af47fad1f7c8 | diff --git a/src/StereoDB/Infra/Sql/Sql.fs b/src/StereoDB/Infra/Sql/Sql.fs
index 6aeb80a..a9664b2 100644
--- a/src/StereoDB/Infra/Sql/Sql.fs
+++ b/src/StereoDB/Infra/Sql/Sql.fs
@@ -86,23 +86,23 @@ module internal QueryBuilder =
member this.TryGetTable tableName =
let schemaProperty = sc... | [
"src/StereoDB/Infra/Sql/Sql.fs",
"src/StereoDB/Infra/Sql/SqlParser.fs",
"tests/StereoDB.Tests/Sql/Select.fs"
] | [
{
"comment": "here you can try inline keyword for perf reasons",
"path": "src/StereoDB/Infra/Sql/Sql.fs",
"hunk": "@@ -131,6 +131,9 @@ module internal QueryBuilder =\n | ValueSome x -> action.Invoke(x)\n | _ -> false) seq\n \n+ let take count (seq: 'T seq) =",
"resolving_s... | diff --git a/tests/StereoDB.Tests/Sql/Select.fs b/tests/StereoDB.Tests/Sql/Select.fs
index 4566515..0360388 100644
--- a/tests/StereoDB.Tests/Sql/Select.fs
+++ b/tests/StereoDB.Tests/Sql/Select.fs
@@ -220,3 +220,30 @@ let ``Order by DESC`` () =
test <@ book2.Id = 2 @>
test <@ book2.Quantity = 4 @>
+[<Fact>]... | true | |
StereoDB/StereoDB | 19 | issue_to_patch | Remove a lot of duplicate logic for each query | This result in the extraction of expession builder which transform SqlExpression to Expression from Expr Trees. At this point we have unified expression processing and can start looking into type conversion. | 00b11960b76fc1d16cb825d6e3659f570a446941 | c28b1d534b351e7692012437c7c7727aef3fb02a | diff --git a/src/StereoDB/Infra/Sql/Sql.fs b/src/StereoDB/Infra/Sql/Sql.fs
index 5ee40ca..6aeb80a 100644
--- a/src/StereoDB/Infra/Sql/Sql.fs
+++ b/src/StereoDB/Infra/Sql/Sql.fs
@@ -99,6 +99,13 @@ module internal QueryBuilder =
if columnProperty <> null then
Some col... | [
"src/StereoDB/Infra/Sql/Sql.fs"
] | [
{
"comment": "Please use C# naming here: \r\n```\r\nthis.GetExpressionType(expr: type)\r\n```",
"path": "src/StereoDB/Infra/Sql/Sql.fs",
"hunk": "@@ -148,16 +155,66 @@ module internal QueryBuilder =\n let tableScanExpresion = Expression.Lambda (result, entity)\n tableScanExpresion\n \n- ... | true | ||
StereoDB/StereoDB | 18 | issue_to_patch | Simplified StereoDB builder API
AC:
- [x] - redesign StereoDB API to create db as a black box without forcing the user to implement IStereoDB
- [x] - merge CSharp API and FSharp in one project
- [x] - use shared implementation of StereoDB Table and StereoDB Engine
```csharp
var db = StereoDb.Create(new Schema(... | simplified StereoDB builder API, merged CSharp and FSharp projects | 66940fb23eb75b1f878d373a7c3ede3772e71712 | d065a1983f986fa1d2d30cd64f71c9c1c8350529 | diff --git a/README.md b/README.md
index d26bd81..32c1262 100644
--- a/README.md
+++ b/README.md
@@ -86,10 +86,10 @@ public class Schema
{
Books = new BooksSchema
{
- Table = StereoDbEngine.CreateTable<int, Book>()
+ Table = StereoDb.CreateTable<int, Book>()
};
- ... | [
"README.md",
"StereoDB.sln",
"benchmarks/StereoDB.Benchmarks/Benchmarks/StereoDbBenchmark.cs",
"examples/Demo/Db.cs",
"examples/Demo/Program.cs",
"src/StereoDB.FSharp/StereoDB.FSharp.fsproj",
"src/StereoDB.FSharp/StereoDb.fs",
"src/StereoDB.FSharp/Table.fs",
"src/StereoDB/AssemblyInfo.fs",
"src/St... | [] | diff --git a/tests/StereoDB.Tests/BasicReadWriteTests.fs b/tests/StereoDB.Tests/BasicReadWriteTests.fs
index 0a24841..3dc1d29 100644
--- a/tests/StereoDB.Tests/BasicReadWriteTests.fs
+++ b/tests/StereoDB.Tests/BasicReadWriteTests.fs
@@ -11,7 +11,7 @@ open Tests.TestHelper
[<Fact>]
let ``Get and Set operations shoul... | true | |
StereoDB/StereoDB | 16 | issue_to_patch | Create helper method which executes query in the current transaction context | This allow have multiple read queries in same read transaction for example.
Also I take this as opportunity as extract SQL parser to separate file.
Example
```fsharp
db.ReadTransaction(fun ctx ->
let part1 = db.ExecuteSql<SubBook> ((ctx, "SELECT * FROM Books WHERE Id = 1"))
let part2 = db.ExecuteSql<SubBo... | 06ca58a21d7658ac2a6bffc3be78e4eb4b2f5bc0 | 3ba51e086da1ceaeba16fb93d210b2857033bd5b | diff --git a/src/StereoDB.FSharp/Sql.fs b/src/StereoDB.FSharp/Sql.fs
index 9f1903d..da3e546 100644
--- a/src/StereoDB.FSharp/Sql.fs
+++ b/src/StereoDB.FSharp/Sql.fs
@@ -1,139 +1,9 @@
namespace StereoDB.Sql
-open FParsec
open System.Linq.Expressions
open StereoDB.FSharp
-module internal SqlParser =
-
- let ws... | [
"src/StereoDB.FSharp/Sql.fs",
"src/StereoDB.FSharp/SqlParser.fs",
"src/StereoDB.FSharp/StereoDB.FSharp.fsproj",
"src/StereoDB.FSharp/StereoDb.fs",
"tests/StereoDB.Tests/Sql/Select.fs",
"tests/StereoDB.Tests/SqlParsing.fs",
"tests/StereoDB.Tests/TestHelper.fs"
] | [] | diff --git a/tests/StereoDB.Tests/Sql/Select.fs b/tests/StereoDB.Tests/Sql/Select.fs
index f86b475..b460c8e 100644
--- a/tests/StereoDB.Tests/Sql/Select.fs
+++ b/tests/StereoDB.Tests/Sql/Select.fs
@@ -113,6 +113,31 @@ let ``Select star into sub-type`` () =
let book2 = result.Value[1]
test <@ book2.Id = 2 @>
... | true | |
StereoDB/StereoDB | 13 | issue_to_patch | Add support for SELECT * | If we map query to object without properties in table entity, these properties would be ignored.
If error required in this case, let's discuss. | a4b9823c0524d33e6ef787f15a8ed53f39ed8c48 | f7abc41650b19d5ef7bd6f8d7f263ca6c65695fd | diff --git a/src/StereoDB.FSharp/Sql.fs b/src/StereoDB.FSharp/Sql.fs
index a7640de..7011ac4 100644
--- a/src/StereoDB.FSharp/Sql.fs
+++ b/src/StereoDB.FSharp/Sql.fs
@@ -21,38 +21,43 @@ module internal SqlParser =
let identifier_ws = identifier .>> ws
type SqlPrimitiveExpression =
- | SqlIntConstant ... | [
"src/StereoDB.FSharp/Sql.fs",
"tests/StereoDB.Tests/Sql/Select.fs"
] | [] | diff --git a/tests/StereoDB.Tests/Sql/Select.fs b/tests/StereoDB.Tests/Sql/Select.fs
index e7805b6..9753cba 100644
--- a/tests/StereoDB.Tests/Sql/Select.fs
+++ b/tests/StereoDB.Tests/Sql/Select.fs
@@ -69,3 +69,47 @@ let ``Select filtered rows`` () =
let booksCount6 = (db.ExecuteSql<SubBook> "SELECT Id, Quantity FR... | true | |
StereoDB/StereoDB | 15 | issue_to_patch | Add support for the ORDER BY | Right now comparison performed by calling `CompareTo` method of the resulting expression. Also for strings we should mention order of `book_10` and `book_1` comparison. | f6578b3f9b6039fff7711176aa9efe1a333c452e | 446fa65db915dea193553c0ae853a73d6f25412f | diff --git a/src/StereoDB.FSharp/Sql.fs b/src/StereoDB.FSharp/Sql.fs
index 7011ac4..9f1903d 100644
--- a/src/StereoDB.FSharp/Sql.fs
+++ b/src/StereoDB.FSharp/Sql.fs
@@ -54,8 +54,13 @@ module internal SqlParser =
type WhereClause =
| WhereCondition of SqlLogicalExpression
+ type OrderDirection = Asce... | [
"src/StereoDB.FSharp/Sql.fs",
"tests/StereoDB.Tests/Sql/Select.fs"
] | [] | diff --git a/tests/StereoDB.Tests/Sql/Select.fs b/tests/StereoDB.Tests/Sql/Select.fs
index 9753cba..f86b475 100644
--- a/tests/StereoDB.Tests/Sql/Select.fs
+++ b/tests/StereoDB.Tests/Sql/Select.fs
@@ -113,3 +113,84 @@ let ``Select star into sub-type`` () =
let book2 = result.Value[1]
test <@ book2.Id = 2 @>
... | true | |
StereoDB/StereoDB | 12 | issue_to_patch | Rudimentary SQL support | This adds simple SQL parser for basic SELECT/UPDATE/DELETE statements and generate code for these queries.
There no checks and safeguards yet. For example if record would try to update property of the record which cannot be mutated it will blowup at runtime with not very pleasant message.
Adding support for other... | 2318486ceb4de6944c7f1b3645884db0dd889f36 | d5c9eb21be190a330c0e4ded6fcf61ae75042b29 | diff --git a/src/StereoDB.FSharp/Sql.fs b/src/StereoDB.FSharp/Sql.fs
new file mode 100644
index 0000000..a7640de
--- /dev/null
+++ b/src/StereoDB.FSharp/Sql.fs
@@ -0,0 +1,666 @@
+namespace StereoDB.Sql
+
+open FParsec
+open System.Linq.Expressions
+open StereoDB.FSharp
+
+module internal SqlParser =
+
+ let ws = sp... | [
"src/StereoDB.FSharp/Sql.fs",
"src/StereoDB.FSharp/StereoDB.FSharp.fsproj",
"src/StereoDB.FSharp/StereoDb.fs",
"src/StereoDB.FSharp/Table.fs",
"tests/StereoDB.Tests/Sql/Delete.fs",
"tests/StereoDB.Tests/Sql/Select.fs",
"tests/StereoDB.Tests/Sql/Update.fs",
"tests/StereoDB.Tests/SqlParsing.fs",
"test... | [] | diff --git a/tests/StereoDB.Tests/Sql/Delete.fs b/tests/StereoDB.Tests/Sql/Delete.fs
new file mode 100644
index 0000000..34da541
--- /dev/null
+++ b/tests/StereoDB.Tests/Sql/Delete.fs
@@ -0,0 +1,68 @@
+module Tests.Sql.Delete
+
+open System.Linq
+open FsToolkit.ErrorHandling
+open Swensen.Unquote
+open Tests.TestHelpe... | true | |
StereoDB/StereoDB | 6 | issue_to_patch | added redis benchmark | 20213355ddb5403b988a70c514ed006d5f79a63b | 9c2312e5547b2afd7c2e4d5230a6ae943dd837a4 | diff --git a/README.md b/README.md
index 4813036..f585006 100644
--- a/README.md
+++ b/README.md
@@ -20,14 +20,27 @@ Supported features:
- [ ] Server and client discovery
- [ ] Range-based sharding
-#### Benchmarks
-TBD
-
#### Intro to Stateful Services
<p align="center">
<img src="https://github.com/Stere... | [
"README.md",
"StereoDB.sln",
"benchmarks/LoadTests/Dockerfile",
"benchmarks/LoadTests/LoadTests.csproj",
"benchmarks/LoadTests/Program.cs",
"benchmarks/LoadTests/Redis/Configs/docker/docker-compose.yaml",
"benchmarks/LoadTests/Redis/Configs/docker/swarm-stack.yaml",
"benchmarks/LoadTests/Redis/Configs... | [] | true | |||
StereoDB/StereoDB | 5 | issue_to_patch | added range scan index | 85a1634fc8df0af8db134f4f52f8732ba50e6bc8 | 37ebe511e47347aab1b4b12b51c2d7191f5afe65 | diff --git a/README.md b/README.md
index 7d8e7a4..5811e23 100644
--- a/README.md
+++ b/README.md
@@ -13,7 +13,7 @@ Supported features:
- [x] Transactions (read-only, read-write)
- [x] Secondary Indexes
- [x] Value Index (hash-based index)
- - [ ] Range Scan Index
+ - [x] Range Scan Index
- [ ] Data size larger ... | [
"README.md",
"benchmarks/StereoDB.Benchmarks/StereoDB.Benchmarks.csproj",
"examples/Demo/Db.cs",
"examples/Demo/Program.cs",
"src/StereoDB.FSharp/StereoDb.fs",
"src/StereoDB.FSharp/Table.fs",
"src/StereoDB/AssemblyInfo.fs",
"src/StereoDB/CSharp/StereoDb.fs",
"src/StereoDB/CSharp/Table.fs",
"src/St... | [] | diff --git a/tests/StereoDB.Tests/Program.fs b/tests/StereoDB.Tests/Program.fs
index 881da55..82efade 100644
--- a/tests/StereoDB.Tests/Program.fs
+++ b/tests/StereoDB.Tests/Program.fs
@@ -2,5 +2,4 @@ module Program =
[<EntryPoint>]
let main _ =
-
0
diff --git a/tests/StereoDB.Tests/Seconda... | true | ||
StereoDB/StereoDB | 4 | issue_to_patch | Updated docs | d65a926fc194365e365e30b748aa6d8514e91125 | 4eff465b80ea5fbc91cb0e05cca67a52278c4d21 | diff --git a/.dockerignore b/.dockerignore
new file mode 100644
index 0000000..cd967fc
--- /dev/null
+++ b/.dockerignore
@@ -0,0 +1,25 @@
+**/.dockerignore
+**/.env
+**/.git
+**/.gitignore
+**/.project
+**/.settings
+**/.toolstarget
+**/.vs
+**/.vscode
+**/.idea
+**/*.*proj.user
+**/*.dbmdl
+**/*.jfm
+**/azds.yaml
+**... | [
".dockerignore",
"README.md",
"StereoDB.sln",
"examples/Demo/Db.cs",
"examples/Demo/Demo.csproj",
"examples/Demo/Dockerfile",
"examples/Demo/Program.cs",
"tests/StereoDB.Tests/BasicReadWriteTests.fs"
] | [] | diff --git a/tests/StereoDB.Tests/BasicReadWriteTests.fs b/tests/StereoDB.Tests/BasicReadWriteTests.fs
index 7c61386..6cc64bb 100644
--- a/tests/StereoDB.Tests/BasicReadWriteTests.fs
+++ b/tests/StereoDB.Tests/BasicReadWriteTests.fs
@@ -43,10 +43,6 @@ type Db() =
member this.WriteTransaction<'T>(transaction) =... | true | ||
StereoDB/StereoDB | 3 | issue_to_patch | Add support for table.GetIds(): TId seq | #1 Add support for table.GetIds | 93fa97489474dc00b93d99fd773c7e0c0d67ac21 | c09bdcce5c16f4437fdc285540c4e3211f408fb2 | diff --git a/src/StereoDB.FSharp/Table.fs b/src/StereoDB.FSharp/Table.fs
index 0b86d65..223ebc3 100644
--- a/src/StereoDB.FSharp/Table.fs
+++ b/src/StereoDB.FSharp/Table.fs
@@ -6,6 +6,7 @@ open StereoDB
type IReadOnlyTable<'TId, 'TEntity when 'TEntity :> IEntity<'TId>> =
inherit ITable<'TId, 'TEntity>
+ abst... | [
"src/StereoDB.FSharp/Table.fs",
"src/StereoDB/CSharp/Table.fs",
"tests/StereoDB.Tests/BasicReadWriteTests.fs"
] | [] | diff --git a/tests/StereoDB.Tests/BasicReadWriteTests.fs b/tests/StereoDB.Tests/BasicReadWriteTests.fs
index 7f77a05..7c61386 100644
--- a/tests/StereoDB.Tests/BasicReadWriteTests.fs
+++ b/tests/StereoDB.Tests/BasicReadWriteTests.fs
@@ -97,4 +97,30 @@ let ``Get and Set operations should work correctly`` () =
... | true | |
SteveGilham/altcover | 260 | issue_to_patch | Bump actions/checkout from 6.0.2 to 6.0.3 | Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.2 to 6.0.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v6.0.3</h2>
<h2>What's Changed</h2>
<ul>
<li>Update changelo... | eade120ac218a7ce1a1a18010149dfaf30dad253 | 7a11b19fa4004deecd626aa5668281f584c583a2 | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 29190f82..5a68ccd8 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -27,7 +27,7 @@ jobs:
windows:
runs-on: windows-latest
steps:
- - uses: actions/checkout@v6.0.2
+ - uses: actions/checkout@v6.0.3
... | [
".github/workflows/main.yml"
] | [] | true | ||
SteveGilham/altcover | 258 | issue_to_patch | Bump actions/upload-artifact from 6 to 7 | Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 6 to 7.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v7.0.0</h2>
<h2>v7 What's new</h2>
<h3>D... | 430a37f8059982bd8e77b1141f3b917740b97ed5 | 8765f783af16380c8a55d8fc1091f8aaf094e8fc | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 0889adae..29190f82 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -48,11 +48,11 @@ jobs:
COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}
NUGET_API_TOKEN: ${{ secrets.NUGET_API_TOKEN }}
... | [
".github/workflows/main.yml"
] | [] | true | ||
SteveGilham/altcover | 256 | issue_to_patch | Bump actions/checkout from 6.0.1 to 6.0.2 | Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.1 to 6.0.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v6.0.2</h2>
<h2>What's Changed</h2>
<ul>
<li>Add orchestrati... | e4ccd439bb447d583a27d1568fa793f133ded31e | 86a1d829b3ff21f5053e31a1b22fde0c436f8366 | diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 48b4b795..0889adae 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -27,7 +27,7 @@ jobs:
windows:
runs-on: windows-latest
steps:
- - uses: actions/checkout@v6.0.1
+ - uses: actions/checkout@v6.0.2
... | [
".github/workflows/main.yml"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.