repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
SoftEtherVPN/SoftEtherVPN | 2,221 | issue_to_patch | Fix data race on Tick64 | Thread Sanitizer detected data race:
```
WARNING: ThreadSanitizer: data race (pid=5147)
Write of size 1 at 0x721800000348 by main thread:
#0 FreeTick64 /home/runner/work/SoftEtherVPN/SoftEtherVPN/src/Mayaqua/Tick64.c:289 (libmayaqua.so+0x2616e0) (BuildId: 7647956240b597b45293d534cf6ea5b7ed2f8c4c)
#1 Free... | 68e9f0b5939f7fe3546d34109eb5be16d74a80d1 | fe460de5a69979eb2bbc3ee1a581a2083edcaaae | diff --git a/src/Mayaqua/Tick64.c b/src/Mayaqua/Tick64.c
index 029326779..887d52b80 100644
--- a/src/Mayaqua/Tick64.c
+++ b/src/Mayaqua/Tick64.c
@@ -139,6 +139,7 @@ void Tick64Thread(THREAD *thread, void *param)
{
UINT tick;
UINT64 tick64;
+ bool halt;
#ifndef OS_WIN32
tick = TickRealtime(); // Ge... | [
"src/Mayaqua/Tick64.c"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,224 | issue_to_patch | Revert "Fix data race on Tick64" | Reverts SoftEtherVPN/SoftEtherVPN#2221
@chipitsine My apologies, but it appears this commit is unnecessary, similar to the case with https://github.com/SoftEtherVPN/SoftEtherVPN/pull/2222#issuecomment-3864903699. Could you please revert this change? | 9d27b935b7449f28bf69e0c31ada8298e4b32dbd | 6016f84315bb87c2af0ade7aaabfe7c08af5107b | diff --git a/src/Mayaqua/Tick64.c b/src/Mayaqua/Tick64.c
index 887d52b80..029326779 100644
--- a/src/Mayaqua/Tick64.c
+++ b/src/Mayaqua/Tick64.c
@@ -139,7 +139,6 @@ void Tick64Thread(THREAD *thread, void *param)
{
UINT tick;
UINT64 tick64;
- bool halt;
#ifndef OS_WIN32
tick = TickRealtime(); // Ge... | [
"src/Mayaqua/Tick64.c"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,232 | issue_to_patch | Add ThreadSanitizer suppression file | Using `__attribute__(no_sanitize("thread"))`disables instrumentation for the entire stack frame, meaning functions called within that scope are also not checked. By using `race_top` in a suppression file, we can suppress erros only when they occur at the top of the stack. This provides more granular control over errors... | 6f749ab71c172f6e0fe5b2a0cb055e741e80a1ac | c075bd85a882ff7d41cab16b449c72e364a965ac | diff --git a/tsan_suppressions.txt b/tsan_suppressions.txt
new file mode 100644
index 000000000..bc2943fa5
--- /dev/null
+++ b/tsan_suppressions.txt
@@ -0,0 +1,12 @@
+# This file contains suppressions for Thread Sanitizer.
+# For the specification, refer to: https://github.com/google/sanitizers/wiki/threadsanitizersupp... | [
"tsan_suppressions.txt"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,225 | issue_to_patch | Add macro to disable thread sanitizer | Define `ATTRIBUTE_NO_TSAN` as `__attribute__((no_sanitize(\"thread\")))` when building with thread sanitizer enabled. Falls back to empty definition when thread sanitizer is not active or not supported compiler.
Changes proposed in this pull request:
- Add macro to disable thread sanitizer
| 9d27b935b7449f28bf69e0c31ada8298e4b32dbd | 0a87ff8fbde10f75c8c09f0e209ea9d1da037d2d | diff --git a/src/Mayaqua/Mayaqua.h b/src/Mayaqua/Mayaqua.h
index 15a38af43..75a9df38f 100644
--- a/src/Mayaqua/Mayaqua.h
+++ b/src/Mayaqua/Mayaqua.h
@@ -72,11 +72,26 @@ int PASCAL WinMain(HINSTANCE hInst, HINSTANCE hPrev, char *CmdLine, int CmdShow)
// Compiler dependent
#ifndef OS_WIN32
-// Gcc compiler
+// GC... | [
"src/Mayaqua/Mayaqua.h"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,234 | issue_to_patch | Add Thread Sanitizer suppressions for FreeTick64 and UnixLock | Changes proposed in this pull request:
- Add suppression for FreeTick64 (#2221).
- Add suppression for UnixLock (#2219).
| cfe854b3393f7c338afbd186eddaf12369f0ea5b | ae448abdad164f3abb56c343cdc1163b61786602 | diff --git a/tsan_suppressions.txt b/tsan_suppressions.txt
index bc2943fa5..fc128a69c 100644
--- a/tsan_suppressions.txt
+++ b/tsan_suppressions.txt
@@ -2,11 +2,27 @@
# For the specification, refer to: https://github.com/google/sanitizers/wiki/threadsanitizersuppressions
+
+## Set/Wait
+# This provides synchroniza... | [
"tsan_suppressions.txt"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,240 | issue_to_patch | Suppress Thread Sanitizer for ThreadPoolProc | Thread Sanitizer detected data race:
```
WARNING: ThreadSanitizer: data race (pid=5147)
Write of size 1 at 0x722800013f38 by thread T2:
#0 ThreadPoolProc /home/runner/work/SoftEtherVPN/SoftEtherVPN/src/Mayaqua/Kernel.c:879 (libmayaqua.so+0x198acd) (BuildId: 7647956240b597b45293d534cf6ea5b7ed2f8c4c)
#1 ... | e0c86ab4a69017c804180205c94b8f54dae846ac | 5b356616a7409b7863914f98651fff2683bbf92e | diff --git a/tsan_suppressions.txt b/tsan_suppressions.txt
index fc128a69c..6719eb916 100644
--- a/tsan_suppressions.txt
+++ b/tsan_suppressions.txt
@@ -17,6 +17,10 @@ race_top:BindConnectThreadForIPv4
race_top:BindConnectThreadForIPv6
race_top:BindConnectEx5
+# Thread Sanitizer reports data races on PoolHalting in... | [
"tsan_suppressions.txt"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,239 | issue_to_patch | Add comment for UnixLock | followup #2219
Changes proposed in this pull request:
- add comment for UnixLock
| e0c86ab4a69017c804180205c94b8f54dae846ac | 93bf90ba95c805d6ab4b93f186bf2f5e02924217 | diff --git a/src/Mayaqua/Unix.c b/src/Mayaqua/Unix.c
index 84da93266..dbdb5e477 100644
--- a/src/Mayaqua/Unix.c
+++ b/src/Mayaqua/Unix.c
@@ -1849,6 +1849,8 @@ void UnixUnlockEx(LOCK *lock, bool inner)
}
// Lock
+// Recursive locking is implemented manually instead of using PTHREAD_MUTEX_RECURSIVE.
+// See: http... | [
"src/Mayaqua/Unix.c"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,241 | issue_to_patch | Suppress Thread Sanitizer for Accept and Disconnect | Thread Sanitizer detected data race:
```
WARNING: ThreadSanitizer: data race (pid=5147)
Read of size 1 at 0x72640003fdf0 by thread T2:
#0 Accept /home/runner/work/SoftEtherVPN/SoftEtherVPN/src/Mayaqua/Network.c:12947 (libmayaqua.so+0x202c57) (BuildId: 7647956240b597b45293d534cf6ea5b7ed2f8c4c)
#1 CheckNet... | 61b920f9572a61853ec20fbf33f3c138954f3e65 | a247e3ecdc2ea0d13dcd9d3d499f1bbaa0ba0f6f | diff --git a/tsan_suppressions.txt b/tsan_suppressions.txt
index 6719eb916..4cbcddc7c 100644
--- a/tsan_suppressions.txt
+++ b/tsan_suppressions.txt
@@ -22,6 +22,16 @@ race_top:BindConnectEx5
# WaitThread simply returns.
race_top:ThreadPoolProc
+
+## Accept/Disconnect cancellation
+# Thread Sanitizer reports two da... | [
"tsan_suppressions.txt"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,211 | issue_to_patch | Add CI for Sanitizer | This PR is adding CI for Sanitizers. Sanitizer is runtime diagnostic tools that detect varios memory-related issues.
Enabling the following four sanitizers:
- Address Sanitizer (ASan)
Detects heap/stack buffer overflows, use-after-free, and double free.
- Leak Sanitizer (LSan)
Detects memory leaks.
- Thread Sani... | e247cf0513519cb3dcc372640ae21baf739559e1 | 7d86756e7216860be724c6ed6cdbec1b81824411 | diff --git a/.github/workflows/sanitizer.yml b/.github/workflows/sanitizer.yml
new file mode 100644
index 000000000..9f9373c6b
--- /dev/null
+++ b/.github/workflows/sanitizer.yml
@@ -0,0 +1,80 @@
+name: Sanitizer
+
+on: [push, pull_request]
+
+permissions:
+ contents: read
+
+jobs:
+ run_sanitizer:
+ runs-on: ubun... | [
".github/workflows/sanitizer.yml"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,274 | issue_to_patch | CI: apply to windows.yml automatical VS detection | d9f46760ffa1ed3a5db670336a9e85a0ff3fde45 | 4c66118bf349131ba236122440fdc24d15019623 | diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
index 87065dfbc..8205bfaf6 100644
--- a/.github/workflows/windows.yml
+++ b/.github/workflows/windows.yml
@@ -8,9 +8,9 @@ jobs:
strategy:
matrix:
platform: [
- { ARCHITECTURE: x86, COMPILER_PATH: "C:/Program Files/M... | [
".github/workflows/windows.yml"
] | [] | true | |||
SoftEtherVPN/SoftEtherVPN | 2,271 | issue_to_patch | CI: detect VS version on the fly | 597cdab4648701140566debc277a3bcb8728b05d | c7bfb30f2a2cc4ff0e5807fa5de6f773d04f10bb | diff --git a/.github/workflows/windows_release.yml b/.github/workflows/windows_release.yml
index cc9ff703d..39b5ef8b5 100644
--- a/.github/workflows/windows_release.yml
+++ b/.github/workflows/windows_release.yml
@@ -31,9 +31,9 @@ jobs:
strategy:
matrix:
platform: [
- { ARCHITECTURE: x86, ... | [
".github/workflows/windows_release.yml"
] | [] | true | |||
SoftEtherVPN/SoftEtherVPN | 2,267 | issue_to_patch | Bump fast-uri from 3.1.0 to 3.1.2 in /developer_tools/vpnserver-jsonrpc-clients/vpnserver-jsonrpc-client-nodejs-package | Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.0 to 3.1.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/fastify/fast-uri/releases">fast-uri's releases</a>.</em></p>
<blockquote>
<h2>v3.1.2</h2>
<h2>⚠️ Security Release</h2>
<ul>
<li>Fix for <a href="https://g... | 41c85953c1e346e6ee5f9ad10dfb001344fc068f | f67769bb8c106c33f78d88e57f4dd165ea2cf344 | diff --git a/developer_tools/vpnserver-jsonrpc-clients/vpnserver-jsonrpc-client-nodejs-package/package-lock.json b/developer_tools/vpnserver-jsonrpc-clients/vpnserver-jsonrpc-client-nodejs-package/package-lock.json
index ae3ce0876..588847337 100644
--- a/developer_tools/vpnserver-jsonrpc-clients/vpnserver-jsonrpc-clien... | [
"developer_tools/vpnserver-jsonrpc-clients/vpnserver-jsonrpc-client-nodejs-package/package-lock.json"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,266 | issue_to_patch | Bump fast-uri from 3.1.0 to 3.1.2 in /src/bin/hamcore/wwwroot/admin/default | Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.0 to 3.1.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/fastify/fast-uri/releases">fast-uri's releases</a>.</em></p>
<blockquote>
<h2>v3.1.2</h2>
<h2>⚠️ Security Release</h2>
<ul>
<li>Fix for <a href="https://g... | 41c85953c1e346e6ee5f9ad10dfb001344fc068f | 50d740a802ed9c0e2746f1356acfe10d05621fab | diff --git a/src/bin/hamcore/wwwroot/admin/default/package-lock.json b/src/bin/hamcore/wwwroot/admin/default/package-lock.json
index 3e1938ac2..7f931a2f9 100644
--- a/src/bin/hamcore/wwwroot/admin/default/package-lock.json
+++ b/src/bin/hamcore/wwwroot/admin/default/package-lock.json
@@ -838,9 +838,9 @@
"license... | [
"src/bin/hamcore/wwwroot/admin/default/package-lock.json"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,263 | issue_to_patch | CI: Switch FreeBSD CI from Cirrus CI to GitHub Actions | See how it works here: https://github.com/metalefty/SoftEtherVPN/actions/runs/25041165714/job/73344506008
Do we need a periodic scheduled run like Fedora Rawhide? | cf559617b1845e0892e51f41d0c67e7382f02c4c | d77c258dac450993b5a6fb9cacbbe4c98022bf49 | diff --git a/.cirrus.yml b/.cirrus.yml
deleted file mode 100644
index 7bce22a5e..000000000
--- a/.cirrus.yml
+++ /dev/null
@@ -1,25 +0,0 @@
-FreeBSD_task:
- matrix:
- env:
- SSL: openssl
- OPENSSL_ROOT_DIR: /usr/local
- env:
- SSL: openssl36
- OPENSSL_ROOT_DIR: /usr/local
- env:
- # b... | [
".cirrus.yml",
".github/workflows/freebsd.yml"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,257 | issue_to_patch | Fix PPP bugs | Changes proposed in this pull request:
- Fixes a hub double-release
- Fixes TLS fragmented size too large by capping it
| 193ebdba1241cee1925ad53b092bcbe266f47e61 | 11fa0a4891839da336764d9cbeb008803310b984 | diff --git a/src/Cedar/Proto_PPP.c b/src/Cedar/Proto_PPP.c
index e9908e0a6..ccb31c062 100644
--- a/src/Cedar/Proto_PPP.c
+++ b/src/Cedar/Proto_PPP.c
@@ -3615,6 +3615,8 @@ bool PPPProcessEAPTlsResponse(PPP_SESSION *p, PPP_EAP *eap_packet, UINT eapSize)
dataBuffer = eap_packet->Tls.TlsDataWithLength.Data;
dataSize... | [
"src/Cedar/Proto_PPP.c"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,255 | issue_to_patch | Bump serialize-javascript and terser-webpack-plugin in /src/bin/hamcore/wwwroot/admin/default | Removes [serialize-javascript](https://github.com/yahoo/serialize-javascript). It's no longer used after updating ancestor dependency [terser-webpack-plugin](https://github.com/webpack/terser-webpack-plugin). These dependencies need to be updated together.
Removes `serialize-javascript`
Updates `terser-webpack-plugin... | a0cbe2daf68a8067ce420d8c08329652438dd2b8 | 617d6686513ace93e47d1065e1f8a4c2ef148aa6 | diff --git a/src/bin/hamcore/wwwroot/admin/default/package-lock.json b/src/bin/hamcore/wwwroot/admin/default/package-lock.json
index d1d68e882..3e1938ac2 100644
--- a/src/bin/hamcore/wwwroot/admin/default/package-lock.json
+++ b/src/bin/hamcore/wwwroot/admin/default/package-lock.json
@@ -1359,16 +1359,6 @@
"no... | [
"src/bin/hamcore/wwwroot/admin/default/package-lock.json"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,175 | issue_to_patch | Build(deps-dev): Bump js-yaml from 3.13.1 to 3.14.2 in /developer_tools/vpnserver-jsonrpc-clients/vpnserver-jsonrpc-client-nodejs-package | Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.13.1 to 3.14.2.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md">js-yaml's changelog</a>.</em></p>
<blockquote>
<h2>[3.14.2] - 2025-11-15</h2>
<h3>Security</h3>
<ul>
<li>Backported v4... | 9fbe3d74887f5aafeb8ea18311344d82cceae96b | 59f19f1a125b12a5f8499bcec34b95016545a3f6 | diff --git a/developer_tools/vpnserver-jsonrpc-clients/vpnserver-jsonrpc-client-nodejs-package/package-lock.json b/developer_tools/vpnserver-jsonrpc-clients/vpnserver-jsonrpc-client-nodejs-package/package-lock.json
index 877e0c5ba..ae3ce0876 100644
--- a/developer_tools/vpnserver-jsonrpc-clients/vpnserver-jsonrpc-clien... | [
"developer_tools/vpnserver-jsonrpc-clients/vpnserver-jsonrpc-client-nodejs-package/package-lock.json"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,252 | issue_to_patch | Build(deps-dev): Bump picomatch from 2.3.1 to 2.3.2 in /developer_tools/vpnserver-jsonrpc-clients/vpnserver-jsonrpc-client-nodejs-package | Bumps [picomatch](https://github.com/micromatch/picomatch) from 2.3.1 to 2.3.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/micromatch/picomatch/releases">picomatch's releases</a>.</em></p>
<blockquote>
<h2>2.3.2</h2>
<p>This is a security release fixing several security r... | 6bbb2b5e075f0b4318e2ce898d9f334c2f6bdcff | 325b76e463119af5476c185cc7466a0abb4c50b7 | diff --git a/developer_tools/vpnserver-jsonrpc-clients/vpnserver-jsonrpc-client-nodejs-package/package-lock.json b/developer_tools/vpnserver-jsonrpc-clients/vpnserver-jsonrpc-client-nodejs-package/package-lock.json
index 82f27f266..877e0c5ba 100644
--- a/developer_tools/vpnserver-jsonrpc-clients/vpnserver-jsonrpc-clien... | [
"developer_tools/vpnserver-jsonrpc-clients/vpnserver-jsonrpc-client-nodejs-package/package-lock.json"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,253 | issue_to_patch | Build(deps-dev): Bump picomatch from 2.3.1 to 2.3.2 in /src/bin/hamcore/wwwroot/admin/default | Bumps [picomatch](https://github.com/micromatch/picomatch) from 2.3.1 to 2.3.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/micromatch/picomatch/releases">picomatch's releases</a>.</em></p>
<blockquote>
<h2>2.3.2</h2>
<p>This is a security release fixing several security r... | 427ada239f1ea70c022cedbd1cf77f0ac0ccbd19 | 98264709fba0c29d4d67351128c40c8ff973b466 | diff --git a/src/bin/hamcore/wwwroot/admin/default/package-lock.json b/src/bin/hamcore/wwwroot/admin/default/package-lock.json
index 1f8b50123..d1d68e882 100644
--- a/src/bin/hamcore/wwwroot/admin/default/package-lock.json
+++ b/src/bin/hamcore/wwwroot/admin/default/package-lock.json
@@ -1335,10 +1335,11 @@
"lic... | [
"src/bin/hamcore/wwwroot/admin/default/package-lock.json"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,245 | issue_to_patch | update src/libhamcore submodule | we want to update because of the following improvement https://github.com/SoftEtherVPN/libhamcore/pull/3
| 7c7933302686a4ea95cc89b2137443aedb57949a | 98940d339d4b49c006ba3ae62d71043ca82e8ec5 | diff --git a/src/libhamcore b/src/libhamcore
index 2951ae5b6..fb8d49782 160000
--- a/src/libhamcore
+++ b/src/libhamcore
@@ -1,1 +1,1 @@
-Subproject commit 2951ae5b61b16c1f4e03ceee88d6db7e1e45362b
+Subproject commit fb8d49782a68f5c2fb8e2d081d8cb2157582e9eb
| [
"src/libhamcore"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,244 | issue_to_patch | Build(deps-dev): Bump minimatch from 3.1.2 to 3.1.5 in /developer_tools/vpnserver-jsonrpc-clients/vpnserver-jsonrpc-client-nodejs-package | Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.1.2 to 3.1.5.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/isaacs/minimatch/commit/7bba97888a27a6162983056bcce2a6e28f668712"><code>7bba978</code></a> 3.1.5</li>
<li><a href="https://github.com/isaacs/minimatch/commit/bd259425b2ca... | 068330b24ba7ed4636adbdaf05cf6a0bec9cab5b | 3f372db86dfd96a1e05f2a9d5a9e8e8fba0069dc | diff --git a/developer_tools/vpnserver-jsonrpc-clients/vpnserver-jsonrpc-client-nodejs-package/package-lock.json b/developer_tools/vpnserver-jsonrpc-clients/vpnserver-jsonrpc-client-nodejs-package/package-lock.json
index b854915a1..82f27f266 100644
--- a/developer_tools/vpnserver-jsonrpc-clients/vpnserver-jsonrpc-clien... | [
"developer_tools/vpnserver-jsonrpc-clients/vpnserver-jsonrpc-client-nodejs-package/package-lock.json"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,243 | issue_to_patch | Build(deps-dev): Bump minimatch from 3.1.2 to 3.1.5 in /src/bin/hamcore/wwwroot/admin/default | Bumps [minimatch](https://github.com/isaacs/minimatch) from 3.1.2 to 3.1.5.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/isaacs/minimatch/commit/7bba97888a27a6162983056bcce2a6e28f668712"><code>7bba978</code></a> 3.1.5</li>
<li><a href="https://github.com/isaacs/minimatch/commit/bd259425b2ca... | 9a42563bbcac55bc9c1b580c5931d9e70f2c7322 | a0d16dd2e8be37956b6360f5d64fe6c68996df3d | diff --git a/src/bin/hamcore/wwwroot/admin/default/package-lock.json b/src/bin/hamcore/wwwroot/admin/default/package-lock.json
index 6e15f41e9..1f8b50123 100644
--- a/src/bin/hamcore/wwwroot/admin/default/package-lock.json
+++ b/src/bin/hamcore/wwwroot/admin/default/package-lock.json
@@ -1203,10 +1203,11 @@
}
... | [
"src/bin/hamcore/wwwroot/admin/default/package-lock.json"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,236 | issue_to_patch | follow up of https://github.com/SoftEtherVPN/SoftEtherVPN/pull/2161 | fixes an issue in https://github.com/SoftEtherVPN/SoftEtherVPN/pull/2161
which have been accidently merged by pressing wrong button
```
/__w/SoftEtherVPN/SoftEtherVPN/src/Cedar/Hub.c:6425:89: error: passing argument 8 of 'GetRadiusServerEx2' makes pointer from integer without a cast [-Wint-conversion]
6425 | ... | 13f15384f252f3f6cf43fad922b795b936743338 | 5130f1a4da6d606cc7d2f35a9b934fbb65aff591 | diff --git a/src/Cedar/Hub.c b/src/Cedar/Hub.c
index 774da34d1..99304eb12 100644
--- a/src/Cedar/Hub.c
+++ b/src/Cedar/Hub.c
@@ -6422,7 +6422,7 @@ bool GetRadiusServer(HUB *hub, char *name, UINT size, UINT *port, char *secret,
bool GetRadiusServerEx(HUB *hub, char *name, UINT size, UINT *port, char *secret, UINT secre... | [
"src/Cedar/Hub.c"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,161 | issue_to_patch | Feature Request - Allow to configure RADIUS timeout
I would like to request the ability to set the timeout for RADIUS authentication requests. Currently it looks like it's hard-coded to 10 seconds before aborting. In some scenarios it might be useful to increase that timeout.
For example we would like to authentica... | Add RadiusRetryTimeout option | Fixes https://github.com/SoftEtherVPN/SoftEtherVPN/issues/80
This PR adds an option to change the timeout length when connecting to RADIUS authentication.
I don't know how to add the option in the GUI, my best guess is to edit one of the .rc files with Visual Studio, but I can't seem to get it set up. I'm getting ... | e42aa6bf789e6ec54b5c27b33f49321e96115c8a | bbda0c298d1500e6acd1c0f7046b549f843c1290 | diff --git a/src/Cedar/Admin.c b/src/Cedar/Admin.c
index eeb992012..a6c59f484 100644
--- a/src/Cedar/Admin.c
+++ b/src/Cedar/Admin.c
@@ -8739,7 +8739,7 @@ UINT StSetHubRadius(ADMIN *a, RPC_RADIUS *t)
}
//SetRadiusServer(h, t->RadiusServerName, t->RadiusPort, t->RadiusSecret);
- SetRadiusServerEx(h, t->RadiusSe... | [
"src/Cedar/Admin.c",
"src/Cedar/Admin.h",
"src/Cedar/Command.c",
"src/Cedar/Hub.c",
"src/Cedar/Hub.h",
"src/Cedar/Protocol.c",
"src/Cedar/Protocol.h",
"src/Cedar/Radius.c",
"src/Cedar/Radius.h",
"src/Cedar/Sam.c",
"src/Cedar/Server.c",
"src/Mayaqua/HTTP.c",
"src/Mayaqua/Network.h",
"src/Ma... | [] | true | |
SoftEtherVPN/SoftEtherVPN | 2,235 | issue_to_patch | Add Windows ARM 64 builds to GitHub Windows Actions | Now that Windows ARM64 support has been added via: https://github.com/SoftEtherVPN/SoftEtherVPN/pull/2209
I've modified the Windows GitHub Windows build actions to also build Windows ARM 64 build artifacts. | a0afd987449b7358e808920312a92fcbdbc25de9 | ef05c4f0c4a9aa060f1f044fcd20da30633086d5 | diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml
index d5cccba3d..87065dfbc 100644
--- a/.github/workflows/windows.yml
+++ b/.github/workflows/windows.yml
@@ -8,10 +8,11 @@ jobs:
strategy:
matrix:
platform: [
- { ARCHITECTURE: x86, COMPILER_PATH: "C:/Program Files... | [
".github/workflows/windows.yml",
".github/workflows/windows_release.yml"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,181 | issue_to_patch | Openvpn: only send AUTH_FAILED reply on auth errors | Changes proposed in this pull request:
- Only send a "AUTH_FAILED" response in case the connection was really rejected due to auth problems.
Note:
Through this errors which appear e.g. due to timeout errors won't be recognized by the client as auth error. Instead, if configured (default), the client would run int... | acbc514b87f3a8fdffbb4042fb34e69c7dd21c6f | 4a4c1c79de006b273f7b81b89fc9dd54a3b4a448 | diff --git a/src/Cedar/Proto_OpenVPN.c b/src/Cedar/Proto_OpenVPN.c
index 9143d46ff..dcdb138a7 100644
--- a/src/Cedar/Proto_OpenVPN.c
+++ b/src/Cedar/Proto_OpenVPN.c
@@ -2562,9 +2562,16 @@ void OvsRecvPacket(OPENVPN_SERVER *s, LIST *recv_packet_list, UINT protocol)
Debug("OpenVPN Channel %u Failed.\n", j);
... | [
"src/Cedar/Proto_OpenVPN.c"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,229 | issue_to_patch | ci: run coverity workflow on demand | df3ea19f0ee8a3982a41c9fa3053d66ead0e540d | 34e4d4a54b8eaf5adbfdc82d7c752f33f8af412c | diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml
index 513f3df55..e9d9dcd3b 100644
--- a/.github/workflows/coverity.yml
+++ b/.github/workflows/coverity.yml
@@ -4,6 +4,7 @@ name: Coverity
on:
schedule:
- cron: "0 0 * * *"
+ workflow_dispatch:
permissions:
contents: read
@@ -11,... | [
".github/workflows/coverity.yml"
] | [] | true | |||
SoftEtherVPN/SoftEtherVPN | 2,226 | issue_to_patch | Add Win Arm64 Doc | Add Win Arm64 Doc | b551b77e258c0ca9668cdd402207ab23bb8bafde | 9da4aabda57a0e54a5bef4812069983da378d778 | diff --git a/src/BUILD_WINDOWS.md b/src/BUILD_WINDOWS.md
index 88f51810e..1a62a30ed 100644
--- a/src/BUILD_WINDOWS.md
+++ b/src/BUILD_WINDOWS.md
@@ -87,6 +87,10 @@ into it. So that is what will be described below.
- x86-on-x64
Cross compile x86 executables with 64-bit compiler
+
+ - arm64-on-x64
+
+ ... | [
"src/BUILD_WINDOWS.md",
"src/BUILD_WinArm64.md"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,218 | issue_to_patch | Build(deps-dev): Bump webpack from 5.94.0 to 5.105.0 in /src/bin/hamcore/wwwroot/admin/default | Bumps [webpack](https://github.com/webpack/webpack) from 5.94.0 to 5.105.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/webpack/webpack/releases">webpack's releases</a>.</em></p>
<blockquote>
<h2>v5.105.0</h2>
<h3>Minor Changes</h3>
<ul>
<li>
<p>Allow resolving worker modu... | 1411d4ceb42e59d0f54c2d9b542d6001f4e09f46 | f1012da5fb2d27eb98611348187139908579d00b | diff --git a/src/bin/hamcore/wwwroot/admin/default/package-lock.json b/src/bin/hamcore/wwwroot/admin/default/package-lock.json
index 1782a7bf6..6e15f41e9 100644
--- a/src/bin/hamcore/wwwroot/admin/default/package-lock.json
+++ b/src/bin/hamcore/wwwroot/admin/default/package-lock.json
@@ -52,17 +52,14 @@
}
}... | [
"src/bin/hamcore/wwwroot/admin/default/package-lock.json"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,216 | issue_to_patch | Fix undefined behavior of left shift | The Sanitizer detected the following Undefined Behavior:
```
/home/runner/work/SoftEtherVPN/SoftEtherVPN/src/Mayaqua/Encrypt.c:4764:20: runtime error: left shift of 128 by 24 places cannot be represented in type 'int'
```
This is caused by `UCHAR` being promoted to a signed integer during a left shift.
I fixed i... | e722f78608ed9fe75590adf5d0ee54499058d284 | 38f102e2e7bc3d472ec0a9bb6d26e365ca8ef530 | diff --git a/src/Mayaqua/Encrypt.c b/src/Mayaqua/Encrypt.c
index e9b8b7455..c52ed16a1 100644
--- a/src/Mayaqua/Encrypt.c
+++ b/src/Mayaqua/Encrypt.c
@@ -4761,7 +4761,7 @@ static void MY_SHA0_Transform(MY_SHA0_CTX* ctx) {
UCHAR* p = ctx->buf;
int t;
for(t = 0; t < 16; ++t) {
- UINT tmp = *p++ << 24;
+ UINT ... | [
"src/Mayaqua/Encrypt.c"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,200 | issue_to_patch | Fix dangling pointer | Hi there, this is my first contribution in this project.
Changes proposed in this pull request:
- Previously, The address of a local stack variable was passed to a new thread. Fix dangling pointer by switching to dynamic allocation. This problem is also known as CVE-2025-25568(but this is not vulnerability).
| 041581ce3022c51d51f5d4242d03facf28da2ebe | 1b9ac396ba7716e3d2fc1f452d3b8c70a0dc4ce9 | diff --git a/src/Cedar/Command.c b/src/Cedar/Command.c
index dce502bb9..b1c719f37 100644
--- a/src/Cedar/Command.c
+++ b/src/Cedar/Command.c
@@ -99,6 +99,8 @@ void CheckNetworkAcceptThread(THREAD *thread, void *param)
Disconnect(s);
ReleaseSock(s);
+
+ Free(c);
}
@@ -155,15 +157,15 @@ void CheckNetwo... | [
"src/Cedar/Command.c"
] | [
{
"comment": "Potential memory leak if thread creation fails. If NewThread returns NULL, the allocated memory 'c' will be leaked. Consider adding a NULL check after NewThread and freeing 'c' if thread creation fails.\n```suggestion\n\t\t\tif (t == NULL)\n\t\t\t{\n\t\t\t\t// Thread creation failed: clean up allo... | true | ||
SoftEtherVPN/SoftEtherVPN | 2,200 | comment_to_fix | Fix dangling pointer | Potential memory leak if thread creation fails. If NewThread returns NULL, the allocated memory 'c' will be leaked. Consider adding a NULL check after NewThread and freeing 'c' if thread creation fails.
```suggestion
if (t == NULL)
{
// Thread creation failed: clean up allocated resources
Disconnect(new_s... | 041581ce3022c51d51f5d4242d03facf28da2ebe | 1b9ac396ba7716e3d2fc1f452d3b8c70a0dc4ce9 | diff --git a/src/Cedar/Command.c b/src/Cedar/Command.c
index dce502bb9..b1c719f37 100644
--- a/src/Cedar/Command.c
+++ b/src/Cedar/Command.c
@@ -99,6 +99,8 @@ void CheckNetworkAcceptThread(THREAD *thread, void *param)
Disconnect(s);
ReleaseSock(s);
+
+ Free(c);
}
@@ -155,15 +157,15 @@ void CheckNetwo... | [
"src/Cedar/Command.c"
] | [
{
"comment": "Potential memory leak if thread creation fails. If NewThread returns NULL, the allocated memory 'c' will be leaked. Consider adding a NULL check after NewThread and freeing 'c' if thread creation fails.\n```suggestion\n\t\t\tif (t == NULL)\n\t\t\t{\n\t\t\t\t// Thread creation failed: clean up allo... | true | ||
SoftEtherVPN/SoftEtherVPN | 2,209 | issue_to_patch | in the arm windows10,can't create virtual network adapter
I am using version 4.34, my operating system is macos (m1 chip), I use Parallels Desktop to create an arm windows10, I cannot create a virtual network adapter。
in the client_log,don't find error logs.
If you can get help, I am very grateful. | Add Windows ARM64 support and ARM64 Neo6 driver | ### Summary
This pull request adds **Windows ARM64 support** to SoftEtherVPN, including build system updates, CPU feature handling, cryptography optimizations, and an ARM64 Neo6 NDIS driver package.
The changes enable cross-compiling ARM64 binaries on x64 Windows hosts and provide a functional VPN Client driver f... | d8be1e4ddc96318f826ebe807cc4869785131dae | 969812e0f29129a69b4bb1d587cc5ceca8118214 | diff --git a/CMakeSettings.json b/CMakeSettings.json
index 4817c8607..eb5240723 100644
--- a/CMakeSettings.json
+++ b/CMakeSettings.json
@@ -136,6 +136,78 @@
"type": "STRING"
}
]
+ },
+ {
+ "name": "arm64-on-x64",
+ "description": "Cross compile Windows ARM64 on x64",
+ "... | [
"CMakeSettings.json",
"src/CMakeLists.txt",
"src/Cedar/CMakeLists.txt",
"src/Mayaqua/Encrypt.c",
"src/Neo6/NDIS6.c",
"src/Neo6/NDIS6.h",
"src/Neo6/Neo6.vcxproj",
"src/bin/hamcore/DriverPackages/Neo6_Win10/arm64/Neo6_arm64_VPN.inf",
"src/bin/hamcore/DriverPackages/Neo6_Win10/arm64/Neo6_arm64_VPN.sys"... | [] | true | |
SoftEtherVPN/SoftEtherVPN | 2,205 | issue_to_patch | Linux: Backspace/Delete and Arrow keys malfunction during password input in vpncmd
### Are you using SoftEther VPN 5.x?
- [x] Yes, I'm using SoftEther VPN 5.x, not 4.x.
### Version
master
### Component
VPN Tools
### Operating system & version
Ubuntu 24.04
### Architecture or Hardware model
x86_64
### Steps t... | Fix password input handling on Linux | Hi, there. This commit fixes #2203.
Changes proposed in this pull request:
- The password input handling on Linux to match the behavior on Windows. It allows deleting characters using the Backspace, Delete, and Left arrow keys, and correctly handles other input sequences are handling correctly.
| 06c93414f24967aa3a5069e8ecd3061f08d5264f | eaef60a582d88fc5ec08f6cc93ab25901fb8cfcb | diff --git a/src/Cedar/Console.c b/src/Cedar/Console.c
index 45bab426a..b95d19307 100644
--- a/src/Cedar/Console.c
+++ b/src/Cedar/Console.c
@@ -1938,6 +1938,7 @@ bool PasswordPrompt(char *password, UINT size)
c = _getch();
#else // OS_WIN32
c = getc(stdin);
+PROCESS_CH:
#endif // OS_WIN32
if (c >= 0... | [
"src/Cedar/Console.c"
] | [] | true | |
SoftEtherVPN/SoftEtherVPN | 2,204 | issue_to_patch | some translation guide kindly contributed by copilot | d75aba986648169f3995abb28d095bddd4d5f4cb | e065752618e88a849e6721b6c93a5588b120628c | diff --git a/README.md b/README.md
index 894a4d95e..6a62f6d0b 100644
--- a/README.md
+++ b/README.md
@@ -293,6 +293,8 @@ We hope that you can reach one of the above URLs at least!
Your contribution to SoftEther VPN Project is much appreciated.
Please send patches to us through GitHub.
+Here you find how to submi... | [
"README.md",
"TRANSLATION_GUIDE.md"
] | [] | true | |||
SoftEtherVPN/SoftEtherVPN | 2,193 | issue_to_patch | Add Turkish translation (strtable_tr.stb) | Added the missing Turkish translation file (strtable_tr.stb).
Resolved accelerator key conflicts using a custom script.
Verified printf-style parameters (%s, %d) to prevent crashes.
Ensured correct UTF-8 encoding.
And lastly, translated it 😄 | e884c4ef7648ae27c01c9a5da0bc404ae5b8520b | ca745bd2349af2c1db5f4caaeb7640ae5c93ad72 | diff --git a/src/bin/hamcore/languages.txt b/src/bin/hamcore/languages.txt
index 9cd8ab37e..dc22672be 100644
--- a/src/bin/hamcore/languages.txt
+++ b/src/bin/hamcore/languages.txt
@@ -10,3 +10,4 @@
5 ru Russian Русский 1049 ru
6 pt_br Portuguese-Brazil Português-Brasil 1046 pt_br
7 id Indonesian Bahasa 1057 id
+... | [
"src/bin/hamcore/languages.txt",
"src/bin/hamcore/languages_wine.txt",
"src/bin/hamcore/strtable_tr.stb"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,195 | issue_to_patch | Fix logical contradiction in ERR_137 | Changes proposed in this pull request:
- Fixed a logical contradiction in (ERR_137): Changed "too long" to "too short" to align with the requirement ("longer than 3 letters").
- Corrected (ERR_137): Changed "equal of longer" to "equal or longer".
- Improved the clarity and grammatical correctness of the error messag... | 85c814a0fb8f137c76eed0cd57764244069d4af0 | 355609b3390e46a4bb2fd3bb9fdfc69e73149975 | diff --git a/src/bin/hamcore/strtable_en.stb b/src/bin/hamcore/strtable_en.stb
index be3f9aa55..22612caf9 100644
--- a/src/bin/hamcore/strtable_en.stb
+++ b/src/bin/hamcore/strtable_en.stb
@@ -200,7 +200,7 @@ ERR_133 The specified Dynamic DNS hostname is already used. Please change th
ERR_134 The specified Dyn... | [
"src/bin/hamcore/strtable_en.stb"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,194 | issue_to_patch | Fix: Correct the wrong data type passed to the log output function | Changes proposed in this pull request:
- Wrong data type is passed to the log output function
- Correct it
-
Run vpntest.exe as server
Enable secure NAT
Wrong DHCP server address will be displayed
Attached A
Before modification
<img width="1222" height="637" alt="SECNAT_LOG_NG_20260108A" src="https://g... | 770aef28660d8cc03c3759238468f1622089efdb | 90a77cfddfe7334c509b49f4d950444e39977ef6 | diff --git a/src/Cedar/Virtual.c b/src/Cedar/Virtual.c
index f5d105cfc..6cfed3011 100644
--- a/src/Cedar/Virtual.c
+++ b/src/Cedar/Virtual.c
@@ -2815,6 +2815,7 @@ void NativeNatThread(THREAD *thread, void *param)
if (a != NULL)
{
char macstr[64];
+ IP dhcp_ip;
// Acquisition success
Debug("NnGe... | [
"src/Cedar/Virtual.c"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,192 | issue_to_patch | Fix: Kernel-mode NAT not available | Changes proposed in this pull request:
-
- Secure NAT does not work in kernel mode.
Run vpntest.exe as server
Enable secure NAT
Secure NAT mode never gets into kernel mode
Attached A
Before modification
<img width="672" height="602" alt="KERNELNAT_NO20260104" src="https://github.com/user-attachments/asse... | e884c4ef7648ae27c01c9a5da0bc404ae5b8520b | b92294fc527b121a6708eafe7827b3921b472e71 | diff --git a/src/Cedar/IPC.c b/src/Cedar/IPC.c
index eeed8f7d7..36e69fd8c 100644
--- a/src/Cedar/IPC.c
+++ b/src/Cedar/IPC.c
@@ -567,6 +567,9 @@ IPC *NewIPCBySock(CEDAR *cedar, SOCK *s, void *mac_address)
ipc->Sock = s;
AddRef(s->ref);
+ // Initialize to pass the validity check on the source IP address perform... | [
"src/Cedar/IPC.c"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,189 | issue_to_patch | Bump js-yaml from 3.13.1 to 3.14.2 in /src/bin/hamcore/wwwroot/admin/default | Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 3.13.1 to 3.14.2.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md">js-yaml's changelog</a>.</em></p>
<blockquote>
<h2>[3.14.2] - 2025-11-15</h2>
<h3>Security</h3>
<ul>
<li>Backported v4... | 85561f35845e91701b14cc475749be12d35b47ab | 859ff5ca5e4b5cc212154ddbf0d0b7f521f32ff1 | diff --git a/src/bin/hamcore/wwwroot/admin/default/package-lock.json b/src/bin/hamcore/wwwroot/admin/default/package-lock.json
index 41592787f..1782a7bf6 100644
--- a/src/bin/hamcore/wwwroot/admin/default/package-lock.json
+++ b/src/bin/hamcore/wwwroot/admin/default/package-lock.json
@@ -1,207 +1,237 @@
{
"name": "... | [
"src/bin/hamcore/wwwroot/admin/default/package-lock.json"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,188 | issue_to_patch | Update macos runners | The macos-13 runner has been removed, and is causing failures, which you can see [here](https://github.com/SoftEtherVPN/SoftEtherVPN/actions/runs/20419671332/job/58668861734?pr=2161) for example.
This PR removes macos-13 and adds macos-26 (for the year 2026), that uses the newer version Apple is using. macos-26 is i... | d5c2e33175f7924840e5590e5c08daefaf9a741f | 6880886e5a46799d96163c4ea43b5b66806f951e | diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml
index 8e65a8397..52e594c60 100644
--- a/.github/workflows/macos.yml
+++ b/.github/workflows/macos.yml
@@ -7,7 +7,7 @@ jobs:
build_and_test:
strategy:
matrix:
- os: [macos-15, macos-14, macos-13]
+ os: [macos-26, macos-15... | [
".github/workflows/macos.yml"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,180 | issue_to_patch | Config value for dhcp discover timeout | Changes proposed in this pull request:
- Make the timeout on DHCP discover requests configurable per VHUB as ExtOption
- Default value is kept as it is
| acbc514b87f3a8fdffbb4042fb34e69c7dd21c6f | 137d7f551fcfbab511e56da22b4119f2daf3aca8 | diff --git a/src/Cedar/Hub.c b/src/Cedar/Hub.c
index 01412ddc9..1677d6057 100644
--- a/src/Cedar/Hub.c
+++ b/src/Cedar/Hub.c
@@ -630,6 +630,7 @@ void DataToHubOptionStruct(HUB_OPTION *o, RPC_ADMIN_OPTION *ao)
GetHubAdminOptionDataAndSet(ao, "UseHubNameAsDhcpUserClassOption", o->UseHubNameAsDhcpUserClassOption);
Ge... | [
"src/Cedar/Hub.c",
"src/Cedar/Hub.h",
"src/Cedar/IPC.c",
"src/Cedar/IPC.h",
"src/Cedar/Server.c"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 2,184 | issue_to_patch | Microsoft Defender Flags SoftEther VPN 5.x Client Components as Trojan:Win32/KepavII!rfn (False Positive)
### Are you using SoftEther VPN 5.x?
- [x] Yes, I'm using SoftEther VPN 5.x, not 4.x.
### Version
5.02.5187
### Component
VPN Client
### Operating system & version
Windows 11 Pro for Workstations 25H2 / OS ... | Add comprehensive documentation for Microsoft Defender false positive detections | Changes proposed in this pull request:
## Problem
Microsoft Defender flags SoftEther VPN 5.x binaries as `Trojan:Win32/KepavII!rfn`, quarantining executables, services, registry entries, and shortcuts. This breaks installations on Windows 11. The detection is a false positive triggered by heuristic analysis of legiti... | 204ab85e51ff216094cd781cf85a47f3a76ae4be | 1ec05c0cb690b70ca375a44c2bbb3762e90a0b66 | diff --git a/.github/ISSUE_TEMPLATE/bug_report_or_issue_report.yml b/.github/ISSUE_TEMPLATE/bug_report_or_issue_report.yml
index cd9bc40f6..bcd368b9c 100644
--- a/.github/ISSUE_TEMPLATE/bug_report_or_issue_report.yml
+++ b/.github/ISSUE_TEMPLATE/bug_report_or_issue_report.yml
@@ -7,6 +7,8 @@ body:
value: |
... | [
".github/ISSUE_TEMPLATE/bug_report_or_issue_report.yml",
".github/ISSUE_TEMPLATE/config.yml",
"ANTIVIRUS.md",
"README.md",
"SECURITY.md",
"WINDOWS_README.txt"
] | [] | true | |
SoftEtherVPN/SoftEtherVPN | 2,182 | issue_to_patch | Please update liboqs or backport a fix for powerpc
### Are you using SoftEther VPN 5.x?
- [X] Yes, I'm using SoftEther VPN 5.x, not 4.x.
### Version
5.02.5187
### Component
VPN Client
### Operating system & version
macOS 10.6.8
### Architecture or Hardware model
ppc
### Steps to reproduce
Run the build, see... | Update liboqs and oqs-provider submodules | Closes #2179, Closes #2088
Update liboqs to https://github.com/open-quantum-safe/liboqs/releases/tag/0.14.0
Update oqs-provider to https://github.com/open-quantum-safe/oqs-provider/releases/tag/0.10.0
Also remove the building of unnecessary algorithms that we don't use to greatly speed up compilation time | 9be944a9b295c479ee7df04e3cb908f3ec579ccd | 2628c562be080323a1682d95b771a8a30d6a0025 | diff --git a/src/Mayaqua/3rdparty/liboqs b/src/Mayaqua/3rdparty/liboqs
index f4b96220e..94b421ebb 160000
--- a/src/Mayaqua/3rdparty/liboqs
+++ b/src/Mayaqua/3rdparty/liboqs
@@ -1,1 +1,1 @@
-Subproject commit f4b96220e4bd208895172acc4fedb5a191d9f5b1
+Subproject commit 94b421ebb82405c843dba4e9aa521a56ee5a333d
diff --git ... | [
"src/Mayaqua/3rdparty/liboqs",
"src/Mayaqua/3rdparty/oqs-provider",
"src/Mayaqua/CMakeLists.txt"
] | [] | true | |
SoftEtherVPN/SoftEtherVPN | 1,965 | issue_to_patch | New issue form | Hi,
Some people are still reporting issues with 4.x Stable Edition here. I suggest introducing an [issue form](https://docs.github.com/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#creating-issue-forms), a new type of issue template. The ne... | 09b7e4f6e5850fd4941e6f34d0a64b00245c9f78 | 370d83ffa0e2c591736228a469a586d094d20496 | diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md
deleted file mode 100644
index 160aa8714..000000000
--- a/.github/ISSUE_TEMPLATE.md
+++ /dev/null
@@ -1,51 +0,0 @@
-Hi, there!
-
-Thank you for using SoftEther.
-
-If you are running SoftEther VPN 4.x (i.e. Stable Edition), please read the comparison wi... | [
".github/ISSUE_TEMPLATE.md",
".github/ISSUE_TEMPLATE/bug_report_or_issue_report.yml",
".github/ISSUE_TEMPLATE/config.yml"
] | [
{
"comment": "@chipitsine \r\nIssue form requires at least one default label. I choose \"needs-triage\" for the default label.\r\nCould you add \"needs-triage\" label?\r\nhttps://github.com/SoftEtherVPN/SoftEtherVPN/labels?page=1&sort=name-asc",
"path": ".github/ISSUE_TEMPLATE/bug_report_or_issue_report.yml... | true | ||
SoftEtherVPN/SoftEtherVPN | 1,960 | issue_to_patch | Update BUILD_UNIX.md for fix location | # Using SoftEther without installation
Correct location for build output dir.
Changes proposed in this pull request:
- In this build instruction, artifacts are outputs to **build/** directory. But, _'using without installation'_ heads to the **bin/** directory, so correct to **build/**. | 48cb3fdebedf23ba5ad4d0a30face5ee03daa340 | 0dfc82c14e93c2b46d60f9b1edcd1cd0f0bfc8f7 | diff --git a/src/BUILD_UNIX.md b/src/BUILD_UNIX.md
index 340afabc8..7034dd4ee 100644
--- a/src/BUILD_UNIX.md
+++ b/src/BUILD_UNIX.md
@@ -228,7 +228,7 @@ You can write your own VPN Server management application in your favorite langua
You can use any SoftEtherVPN component (server, client, bridge) without installing... | [
"src/BUILD_UNIX.md"
] | [] | true | ||
SoftEtherVPN/SoftEtherVPN | 1,833 | issue_to_patch | several potential null pointer dereferences fix | aadc0689645a1e4c0d4dcb3cc85a084d29932804 | c59df8266697321dc02e76bb8a5545577e8fa542 | diff --git a/src/Mayaqua/Secure.c b/src/Mayaqua/Secure.c
index 18078cd5c..af2b9136f 100644
--- a/src/Mayaqua/Secure.c
+++ b/src/Mayaqua/Secure.c
@@ -404,6 +404,28 @@ bool WriteSecKey(SECURE *sec, bool private_obj, char *name, K *k)
UCHAR modules[MAX_SIZE], pub[MAX_SIZE], pri[MAX_SIZE], prime1[MAX_SIZE], prime2[MAX_SI... | [
"src/Mayaqua/Secure.c"
] | [] | true | |||
SortableJS/Sortable | 2,369 | issue_to_patch | Fixes leaky savedInputChecked across multiple instances | ### Steps to Reproduce Issue
1) Create two sortables on the same page: List A and List B
2) The `options.handle` must be specified for some reason
3) Add an event when a checkbox is unchecked inside List A
4) Set event to destroy and replace SortableJS on List B
### Problem
All checkboxes on List A a... | e7b4859ae29e7cdcde9435ad64ffc5b87229fb9d | 0a88f9a1ebb67a6f15ea17e6871c19fd53c84815 | diff --git a/src/Sortable.js b/src/Sortable.js
index 81ff84494..b6532a5b5 100644
--- a/src/Sortable.js
+++ b/src/Sortable.js
@@ -1538,8 +1538,11 @@ Sortable.prototype = /** @lends Sortable.prototype */ {
Sortable.clone =
Sortable.active = null;
- savedInputChecked.forEach(function (el) {
- el.checked = true;... | [
"src/Sortable.js"
] | [] | true | ||
SortableJS/Sortable | 2,431 | issue_to_patch | Fix: Sortable Freezes Browser (Shadow DOM) | When an element that is a (light DOM) child of a shadow DOM element triggers an event (e.g., a click event), `getParentOrHost` checks for the parent shadow DOM's host (which refers to itself) causing [the do..while loop in `closest`](https://github.com/SortableJS/Sortable/blob/master/src/utils.js#L50-L65) to be called ... | 63ecb31937d19fcb30aa924e82ee8a769ef34492 | bd74abb22ade431c0e1af0cd552796ec1e0bcb0c | diff --git a/src/utils.js b/src/utils.js
index c26c5bb90..43112a4d3 100644
--- a/src/utils.js
+++ b/src/utils.js
@@ -38,7 +38,7 @@ function matches(/**HTMLElement*/el, /**String*/selector) {
}
function getParentOrHost(el) {
- return (el.host && el !== document && el.host.nodeType)
+ return (el.host && el !== docume... | [
"src/utils.js"
] | [] | true | ||
SortableJS/Sortable | 2,347 | issue_to_patch | fix: set the target as the host element when target contains a shadowRoot | ## Fix for sorting elements that contain web components
See https://github.com/SortableJS/Sortable/issues/2346 for explanation and code samples of the issue.
When sortable elements contain web components with shadowRoot, and forceFallback is enabled, swapping elements is not working correctly.
DOM Example:
... | 07708fa1e7d9cf9d4563a7b1a09f7a47771522ed | 9fab4b9230d0456601078b271cd9a0b7f0de7fac | diff --git a/src/Sortable.js b/src/Sortable.js
index 74045d4f4..3c85a0e5c 100644
--- a/src/Sortable.js
+++ b/src/Sortable.js
@@ -35,7 +35,8 @@ import {
scrollBy,
clone,
expando,
- getChildContainingRectFromElement
+ getChildContainingRectFromElement,
+ getParentOrHost
} from './utils.js';
@@ -781,7 +782,7 @@... | [
"src/Sortable.js"
] | [] | true | ||
SortableJS/Sortable | 2,309 | issue_to_patch | docs: properly capitalize forceAutoScrollFallback option | Corrects one instance in which the property is written with a lowercase "s" | c5a882267542456d75b16d000dc1b603a907613a | 029d0d47b257019afc4dd1bf9f540178ea7e3f21 | diff --git a/plugins/AutoScroll/README.md b/plugins/AutoScroll/README.md
index dd77aede6..4514b30c9 100644
--- a/plugins/AutoScroll/README.md
+++ b/plugins/AutoScroll/README.md
@@ -26,7 +26,7 @@ Sortable.mount(new AutoScroll());
```js
new Sortable(el, {
scroll: true, // Enable the plugin. Can be HTMLElement.
- forc... | [
"plugins/AutoScroll/README.md"
] | [] | true | ||
SortableJS/Sortable | 2,291 | issue_to_patch | docs: remove dollar sign from code blocks | For code blocks on github there is a button that lets you copy the input. Before it would include the dollar sign which would not work in the terminal
example before:
$ npm install sortablejs --save
after:
npm install sortablejs --save | 7af63fdc5d7512e7f0b8abb10970d473521b31a5 | d3a7f096ca77d61213d7648385f4798585edf2b5 | diff --git a/README.md b/README.md
index f56ae451c..9feb83e38 100644
--- a/README.md
+++ b/README.md
@@ -54,12 +54,12 @@ Demo: http://sortablejs.github.io/Sortable/
Install with NPM:
```bash
-$ npm install sortablejs --save
+npm install sortablejs --save
```
Install with Bower:
```bash
-$ bower install --save ... | [
"README.md"
] | [] | true | ||
SortableJS/Sortable | 2,263 | issue_to_patch | Added conditional statement whether dragged element should be dropped | Added fix for following issue:
https://github.com/SortableJS/Vue.Draggable/issues/1199 | babf6ab85fdfc5e13be1027827cecfbba2fb0d1e | 87fc7417983246aa27d6333b0fc3d60e655735b7 | diff --git a/Sortable.js b/Sortable.js
index c394160e7..af5b2ab10 100644
--- a/Sortable.js
+++ b/Sortable.js
@@ -2476,7 +2476,9 @@
el.removeAttribute('draggable');
});
- this._onDrop();
+ if (el === rootEl) {
+ this._onDrop();
+ }
this._disableDelayedDragEvents();
| [
"Sortable.js"
] | [] | true | ||
SortableJS/Sortable | 2,084 | issue_to_patch | avoid implicit deselect on outside click | https://github.com/SortableJS/Sortable/issues/1612
Added a key to the MultiDragPlugin to avoid canceling selected items when clicking outside the block | 21f7ede93326cd02f8613075146fdabc6d3a769e | 796bb3f7f2a59da8de2244c26ce787d3b9be7374 | diff --git a/plugins/MultiDrag/MultiDrag.js b/plugins/MultiDrag/MultiDrag.js
index 03f0077c5..db9b7bc09 100644
--- a/plugins/MultiDrag/MultiDrag.js
+++ b/plugins/MultiDrag/MultiDrag.js
@@ -35,11 +35,13 @@ function MultiDragPlugin() {
}
}
- if (sortable.options.supportPointer) {
- on(document, 'pointerup', t... | [
"plugins/MultiDrag/MultiDrag.js",
"plugins/MultiDrag/README.md"
] | [] | true | ||
SortableJS/Sortable | 2,095 | issue_to_patch | Prevent ignored touches on Android Chrome. | Android Chrome will not trigger a click event if a user drags an item,
even if the item is dropped back into its original placement. This
means that whenever the "ignore next click" handling is activated, the
user's _next_ click (unrelated to dragging) will be ignored.
This commit solves this by never activating ... | daaefedad3c59204edfdbb27706e1447e6eb41d8 | cf04481aa4f18ebcabf2665625c7425068746989 | diff --git a/src/Sortable.js b/src/Sortable.js
index 431679173..99bff13dd 100644
--- a/src/Sortable.js
+++ b/src/Sortable.js
@@ -298,7 +298,7 @@ let dragEl,
// #1184 fix - Prevent click event on fallback if dragged but item not changed position
-if (documentExists) {
+if (documentExists && !ChromeForAndroid) {
d... | [
"src/Sortable.js"
] | [] | true | ||
SortableJS/Sortable | 2,094 | issue_to_patch | Issue #2093 remove ID from the cloned element prior to adding to the … | …DOM.
We should not create a duplicate CSS ID. | daaefedad3c59204edfdbb27706e1447e6eb41d8 | 840f9aef8452e2944e6984d49965bcc86ed96863 | diff --git a/src/Sortable.js b/src/Sortable.js
index 431679173..6d3d6c670 100644
--- a/src/Sortable.js
+++ b/src/Sortable.js
@@ -924,7 +924,7 @@ Sortable.prototype = /** @lends Sortable.prototype */ {
pluginEvent('setupClone', this);
if (!Sortable.eventCanceled) {
cloneEl = clone(dragEl);
-
+ cloneEl.remove... | [
"src/Sortable.js"
] | [] | true | ||
SortableJS/Sortable | 2,104 | issue_to_patch | Update package.json | Windows packaging cannot generate root directory sotrable.js problem fit | daaefedad3c59204edfdbb27706e1447e6eb41d8 | bf6690240cf86d277014d6288c02809b3bb03ef4 | diff --git a/package.json b/package.json
index ece28b678..d634cef3a 100644
--- a/package.json
+++ b/package.json
@@ -19,7 +19,7 @@
"main": "./Sortable.min.js",
"module": "modular/sortable.esm.js",
"scripts": {
- "build:umd": "NODE_ENV=umd rollup -c ./scripts/umd-build.js",
+ "build:umd": "set NODE_ENV=umd&& rol... | [
"package.json"
] | [
{
"comment": "```suggestion\r\n\t\t\"build:umd\": \"set NODE_ENV=umd && rollup -c ./scripts/umd-build.js\",\r\n```",
"path": "package.json",
"hunk": "@@ -19,7 +19,7 @@\n \t\"main\": \"./Sortable.min.js\",\n \t\"module\": \"modular/sortable.esm.js\",\n \t\"scripts\": {\n-\t\t\"build:umd\": \"NODE_ENV=umd... | true | ||
SortableJS/Sortable | 2,072 | issue_to_patch | fix the drag position problem when existing non draggable elements at the end of the list | When dragging an element to the end of the list, and existing non draggable elements at the end of the list. Appending it to the end of the list is not incorrect, It should be inserted before the next sibling of the last draggable element. | 21f7ede93326cd02f8613075146fdabc6d3a769e | 6bf291431e3b0cd4881d5ce43d4aead5687fbc42 | diff --git a/src/Sortable.js b/src/Sortable.js
index d66b8e7f6..431679173 100644
--- a/src/Sortable.js
+++ b/src/Sortable.js
@@ -1188,7 +1188,12 @@ Sortable.prototype = /** @lends Sortable.prototype */ {
if (onMove(rootEl, el, dragEl, dragRect, target, targetRect, evt, !!target) !== false) {
capture();
- ... | [
"src/Sortable.js"
] | [] | true | ||
SortableJS/Sortable | 2,034 | issue_to_patch | Trick for emptyInsertThreshold | Hi,
The emptyInsertThreshold is not really needed (at least in recent browsers), as the function can be obtained by a pure css solution.
I propose this in the README - of course you're free to rewrite it and/or put it somewhere else.
Other ideas :
- Managing automatically an "empty" class when the list is emp... | e83eb7ee0b2e9289e87160fb713d43ad37a30039 | 7d0c6a062ca1929c71778e044b2d815a2e51fae0 | diff --git a/README.md b/README.md
index 6beb663c7..f56ae451c 100644
--- a/README.md
+++ b/README.md
@@ -521,6 +521,19 @@ The distance (in pixels) the mouse must be from an empty sortable while dragging
Demo: https://jsbin.com/becavoj/edit?js,output
+An alternative to this option would be to set a padding on your ... | [
"README.md"
] | [] | true | ||
SortableJS/Sortable | 2,028 | issue_to_patch | Update package.json: The entry file uses the compiled | 0656d6245f222c4dc26cd08777d7bd04b7699c29 | ff4585f562a0b38cd62436c4bf361505e836a91d | diff --git a/package.json b/package.json
index 5d12970d7..4d9b8e669 100644
--- a/package.json
+++ b/package.json
@@ -16,7 +16,7 @@
"uglify-js": "^3.5.12"
},
"description": "JavaScript library for reorderable drag-and-drop lists on modern browsers and touch devices. No jQuery required. Supports Meteor, AngularJS,... | [
"package.json"
] | [] | true | |||
SortableJS/Sortable | 1,519 | issue_to_patch | Modularization & Plugin system | No breaking changes | 90384f5b55f346a9591843d978030a211ae13cba | c7a0a991957f8d4f7d7a314f2f076b3c61726b4c | diff --git a/.jshintrc b/.jshintrc
index 3f67a098b..ffbcc18f9 100644
--- a/.jshintrc
+++ b/.jshintrc
@@ -1,10 +1,11 @@
{
- "strict": true,
+ "strict": false,
"newcap": false,
"node": true,
"expr": true,
"supernew": true,
"laxbreak": true,
+ "esversion": 9,
"white": true,
"globals": {
"define": true,
d... | [
".jshintrc",
"README.md",
"Sortable.js",
"Sortable.min.js",
"babel.config.js",
"build/banner.js",
"build/build.js",
"build/esm-build.js",
"build/minify.js",
"build/umd-build.js",
"entry/entry-complete.js",
"entry/entry-core.js",
"entry/entry-defaults.js",
"gulpfile.js",
"modular/sortable... | [] | true | ||
SortableJS/Sortable | 1,560 | issue_to_patch | Testcafe tests | a09bddb7ef0af5f51a2f8aeb0a5ee557004acfb4 | 2108dd7260e21dbb82b9fa4d47fe3d457e0a54df | diff --git a/.circleci/config.yml b/.circleci/config.yml
new file mode 100644
index 000000000..a42a1c975
--- /dev/null
+++ b/.circleci/config.yml
@@ -0,0 +1,27 @@
+version: 2.0
+jobs:
+ build:
+ docker:
+ - image: circleci/node:10.16-browsers
+ steps:
+ - checkout
+
+ - restore_cache:
+ k... | [
".circleci/config.yml",
".editorconfig",
".testcaferc.json",
"README.md",
"package-lock.json",
"package.json",
"plugins/AutoScroll/AutoScroll.js",
"scripts/banner.js",
"scripts/build.js",
"scripts/esm-build.js",
"scripts/minify.js",
"scripts/test-compat.js",
"scripts/test.js",
"scripts/umd... | [] | diff --git a/tests/Sortable.compat.test.js b/tests/Sortable.compat.test.js
new file mode 100644
index 000000000..7c00396b9
--- /dev/null
+++ b/tests/Sortable.compat.test.js
@@ -0,0 +1,39 @@
+import { Selector } from 'testcafe';
+
+
+fixture `Simple Sorting`
+ .page `./single-list.html`;
+
+let list1 = Selector('#list1'... | true | ||
SortableJS/Sortable | 892 | issue_to_patch | Revert "Fix Destroy workflow" | Reverts RubaXa/Sortable#864
| ff33930ebbe2da18568ed88f04f4c87bc4414f55 | caf43c8799e46051a2e6ae26cde69410e700d965 | diff --git a/Sortable.js b/Sortable.js
index f290782c2..d6f04237f 100644
--- a/Sortable.js
+++ b/Sortable.js
@@ -813,8 +813,9 @@
this.save();
}
}
- this._nulling();
+
}
+ this._nulling();
},
_nulling: function() {
| [
"Sortable.js"
] | [] | true | ||
SortableJS/Sortable | 1,466 | issue_to_patch | IOS Ghost fix | 452436a183ec57dadc1f9fcc881dbeb3e547da94 | b5334e25562fa423b0f5c7e127f53f11943e2f84 | diff --git a/Sortable.js b/Sortable.js
index 582449bd7..7e93fd9f6 100644
--- a/Sortable.js
+++ b/Sortable.js
@@ -70,6 +70,10 @@
targetMoveDistance,
+ // For positioning ghost absolutely
+ ghostRelativeParent,
+ ghostRelativeParentInitialScroll = [], // (left, top)
+
forRepaintDummy,
realDragElRect, //... | [
"Sortable.js"
] | [] | true | |||
SortableJS/Sortable | 1,524 | issue_to_patch | Next version | b321482d5110e36b5c214c022cd417e6a198ff55 | 2e95d0625f1375bbc645e10d9732ed4de1fd9d73 | diff --git a/.gitignore b/.gitignore
index f9f1ef482..bb83eae77 100644
--- a/.gitignore
+++ b/.gitignore
@@ -4,4 +4,3 @@ mock.png
.build*
jquery.fn.*
.idea/
-package-lock.json
diff --git a/.jshintrc b/.jshintrc
index 3f67a098b..ffbcc18f9 100644
--- a/.jshintrc
+++ b/.jshintrc
@@ -1,10 +1,11 @@
{
- "strict": true,
+... | [
".gitignore",
".jshintrc",
"README.md",
"Sortable.js",
"Sortable.min.js",
"babel.config.js",
"build/banner.js",
"build/build.js",
"build/esm-build.js",
"build/minify.js",
"build/umd-build.js",
"entry/entry-complete.js",
"entry/entry-core.js",
"entry/entry-defaults.js",
"gulpfile.js",
"... | [] | true | |||
SortableJS/Sortable | 1,950 | issue_to_patch | Removed Dead Link | 22b80e31994a1e873625d039b86a3346fbe41636 | 2ad95c44c5a01b869d2de48d3909c8b018e6cd86 | diff --git a/README.md b/README.md
index 58ef354fa..79f2f38f4 100644
--- a/README.md
+++ b/README.md
@@ -45,7 +45,7 @@ Please replace your usage of bower with npm, yarn or a JavaScript package manage
- Support for CSS transforms
- Built using native HTML5 drag and drop API
- Supports
-- Supports any CSS library, e.g... | [
"README.md"
] | [] | true | |||
SortableJS/Sortable | 1,913 | issue_to_patch | convert repo to monorepo
The repository is a mess currently.
The below changes can be made without becoming breaking changes.
new structure:
```sh
> packages
> utilities # all utilities that aren't sortable
> plugins # all the plugins
> auto-scroll
> on-spill
> multi-drag
> swap
... | refactor: monorepo, microbundler, docs, deprecation | Now this may not be the best practice, but I've made huge amount of changes due to the nature of the changes
## Monorepo
Create a monorepo configuration with Lerna.
Lerna was chosen because it can be used with NPM or Yarn and aids us in publishing and bumping up the value of packages.
Each plugin is now a sepa... | aa19cf332079d03be82a57222f200d46ffed4b8a | 86f86dc6397a2c840d3e57937f922e66b955b4e5 | diff --git a/.circleci/config.yml b/.circleci/config.yml
index cf67d6952..fb37bf1d8 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -7,18 +7,24 @@ jobs:
- checkout
- restore_cache:
+ name: Restore Yarn Package Cache
keys:
- - v1-dependencies-{{ checksum "pa... | [
".circleci/config.yml",
".prettierignore",
".vscode/settings.json",
"README.md",
"Sortable.js",
"babel.config.js",
"bower.json",
"docs/examples.md",
"docs/plugins.md",
"docs/sortable-options.md",
"entry/entry-complete.js",
"entry/entry-core.js",
"entry/entry-defaults.js",
"lerna.json",
"... | [] | diff --git a/tests/e2e-fixtures/dual-list.html b/tests/e2e-fixtures/dual-list.html
index 93942630d..eb38d0cc0 100644
--- a/tests/e2e-fixtures/dual-list.html
+++ b/tests/e2e-fixtures/dual-list.html
@@ -21,7 +21,7 @@
<div>Item 2.5</div>
</div>
- <script src="../../Sortable.js"></script>
+ <script src=... | true |
SortableJS/Sortable | 1,939 | issue_to_patch | Fix demo link | Fix demo link | 663a466a35d410ee13fa9dfa61ec5e18ebb01597 | 4c9db863dba3f8c67b5f8465aba80cac9f866c36 | diff --git a/README.md b/README.md
index cc2778c5e..58ef354fa 100644
--- a/README.md
+++ b/README.md
@@ -2,7 +2,7 @@
Sortable is a JavaScript library for reorderable drag-and-drop lists.
-Demo: http://sortablejs.github.io/Sortable/
+Demo: https://sortablejs.github.io/sortablejs/
[<img width="250px" src="https:/... | [
"README.md"
] | [] | true | ||
SortableJS/Sortable | 1,203 | issue_to_patch | Support Composer package manager | After merging this PR, the `RubaXa/Sortable` repo can be submitted to Packagist.org under the `RubaXa` org. Clean and simple no more maintaining of [forks](https://github.com/components/Sortable). Hooray! | 2addddd67387b6e4b6b5e51806eb698f0a3eee88 | 262842bffa3b7ff6eb9bc46802b801a89d2e4cc5 | diff --git a/composer.json b/composer.json
new file mode 100644
index 000000000..a0af95660
--- /dev/null
+++ b/composer.json
@@ -0,0 +1,41 @@
+{
+ "name": "SortableJS/Sortable",
+ "type": "component",
+ "description": "Sortable is a JavaScript library for reorderable drag-and-drop lists.",
+ "homepage": "ht... | [
"composer.json"
] | [
{
"comment": "```suggestion\r\n \"authors\": [\r\n {\r\n \"name\": \"Wayne Van Son\",\r\n \"email\": \"waynevanson@gmail.com\"\r\n },\r\n {\r\n \"name\": \"Owen Mills\",\r\n \"email\" \"owen23355@gmail.com\"\r\n }\r\n ],\r\n```\r\n\r\nAlthough we're ... | true | ||
SortableJS/Sortable | 1,203 | comment_to_fix | Support Composer package manager | ```suggestion
"authors": [
{
"name": "Wayne Van Son",
"email": "waynevanson@gmail.com"
},
{
"name": "Owen Mills",
"email" "owen23355@gmail.com"
}
],
```
Although we're not the true authors, we're the individuals maintaining the projec... | 2addddd67387b6e4b6b5e51806eb698f0a3eee88 | 262842bffa3b7ff6eb9bc46802b801a89d2e4cc5 | diff --git a/composer.json b/composer.json
new file mode 100644
index 000000000..a0af95660
--- /dev/null
+++ b/composer.json
@@ -0,0 +1,41 @@
+{
+ "name": "SortableJS/Sortable",
+ "type": "component",
+ "description": "Sortable is a JavaScript library for reorderable drag-and-drop lists.",
+ "homepage": "ht... | [
"composer.json"
] | [
{
"comment": "```suggestion\r\n \"authors\": [\r\n {\r\n \"name\": \"Wayne Van Son\",\r\n \"email\": \"waynevanson@gmail.com\"\r\n },\r\n {\r\n \"name\": \"Owen Mills\",\r\n \"email\" \"owen23355@gmail.com\"\r\n }\r\n ],\r\n```\r\n\r\nAlthough we're ... | true | ||
SortableJS/Sortable | 1,203 | comment_to_fix | Support Composer package manager | ```suggestion
"name": "SortableJS/Sortable",
```
Does this change affect those in PHP land? | 2addddd67387b6e4b6b5e51806eb698f0a3eee88 | 262842bffa3b7ff6eb9bc46802b801a89d2e4cc5 | diff --git a/composer.json b/composer.json
new file mode 100644
index 000000000..a0af95660
--- /dev/null
+++ b/composer.json
@@ -0,0 +1,41 @@
+{
+ "name": "SortableJS/Sortable",
+ "type": "component",
+ "description": "Sortable is a JavaScript library for reorderable drag-and-drop lists.",
+ "homepage": "ht... | [
"composer.json"
] | [
{
"comment": "```suggestion\r\n \"name\": \"SortableJS/Sortable\",\r\n```\r\n\r\nDoes this change affect those in PHP land?",
"path": "composer.json",
"hunk": "@@ -0,0 +1,42 @@\n+{\n+ \"name\": \"rubaxa/sortable\",",
"resolving_sha": "262842bffa3b7ff6eb9bc46802b801a89d2e4cc5",
"resolving_d... | true | ||
SortableJS/Sortable | 1,203 | comment_to_fix | Support Composer package manager | ```suggestion
"homepage": "http://sortablejs.github.io/Sortable/",
``` | 2addddd67387b6e4b6b5e51806eb698f0a3eee88 | 262842bffa3b7ff6eb9bc46802b801a89d2e4cc5 | diff --git a/composer.json b/composer.json
new file mode 100644
index 000000000..a0af95660
--- /dev/null
+++ b/composer.json
@@ -0,0 +1,41 @@
+{
+ "name": "SortableJS/Sortable",
+ "type": "component",
+ "description": "Sortable is a JavaScript library for reorderable drag-and-drop lists.",
+ "homepage": "ht... | [
"composer.json"
] | [
{
"comment": "```suggestion\r\n \"homepage\": \"http://sortablejs.github.io/Sortable/\",\r\n```",
"path": "composer.json",
"hunk": "@@ -0,0 +1,42 @@\n+{\n+ \"name\": \"rubaxa/sortable\",\n+ \"type\": \"component\",\n+ \"description\": \"Sortable is a JavaScript library for reorderable drag-a... | true | ||
SortableJS/Sortable | 1,203 | comment_to_fix | Support Composer package manager | ```suggestion
"issues": "https://github.com/SortableJS/Sortable/issues",
``` | 2addddd67387b6e4b6b5e51806eb698f0a3eee88 | 262842bffa3b7ff6eb9bc46802b801a89d2e4cc5 | diff --git a/composer.json b/composer.json
new file mode 100644
index 000000000..a0af95660
--- /dev/null
+++ b/composer.json
@@ -0,0 +1,41 @@
+{
+ "name": "SortableJS/Sortable",
+ "type": "component",
+ "description": "Sortable is a JavaScript library for reorderable drag-and-drop lists.",
+ "homepage": "ht... | [
"composer.json"
] | [
{
"comment": "```suggestion\r\n \"issues\": \"https://github.com/SortableJS/Sortable/issues\",\r\n```",
"path": "composer.json",
"hunk": "@@ -0,0 +1,42 @@\n+{\n+ \"name\": \"rubaxa/sortable\",\n+ \"type\": \"component\",\n+ \"description\": \"Sortable is a JavaScript library for reordera... | true | ||
SortableJS/Sortable | 1,203 | comment_to_fix | Support Composer package manager | ```suggestion
"source": "https://github.com/SortableJS/Sortable.git"
``` | 2addddd67387b6e4b6b5e51806eb698f0a3eee88 | 262842bffa3b7ff6eb9bc46802b801a89d2e4cc5 | diff --git a/composer.json b/composer.json
new file mode 100644
index 000000000..a0af95660
--- /dev/null
+++ b/composer.json
@@ -0,0 +1,41 @@
+{
+ "name": "SortableJS/Sortable",
+ "type": "component",
+ "description": "Sortable is a JavaScript library for reorderable drag-and-drop lists.",
+ "homepage": "ht... | [
"composer.json"
] | [
{
"comment": "```suggestion\r\n \"source\": \"https://github.com/SortableJS/Sortable.git\"\r\n```",
"path": "composer.json",
"hunk": "@@ -0,0 +1,42 @@\n+{\n+ \"name\": \"rubaxa/sortable\",\n+ \"type\": \"component\",\n+ \"description\": \"Sortable is a JavaScript library for reorderable ... | true | ||
SortableJS/Sortable | 1,203 | comment_to_fix | Support Composer package manager | I don't think file exists here anymore. Should this be removed? | 2addddd67387b6e4b6b5e51806eb698f0a3eee88 | 262842bffa3b7ff6eb9bc46802b801a89d2e4cc5 | diff --git a/composer.json b/composer.json
new file mode 100644
index 000000000..a0af95660
--- /dev/null
+++ b/composer.json
@@ -0,0 +1,41 @@
+{
+ "name": "SortableJS/Sortable",
+ "type": "component",
+ "description": "Sortable is a JavaScript library for reorderable drag-and-drop lists.",
+ "homepage": "ht... | [
"composer.json"
] | [
{
"comment": "I don't think file exists here anymore. Should this be removed?",
"path": "composer.json",
"hunk": "@@ -0,0 +1,42 @@\n+{\n+ \"name\": \"rubaxa/sortable\",\n+ \"type\": \"component\",\n+ \"description\": \"Sortable is a JavaScript library for reorderable drag-and-drop lists.\",\n+ ... | true | ||
SortableJS/Sortable | 1,934 | issue_to_patch | docs(README): fix typo | Update some minor typos | 6e3ac78dbb7e110ba73eadfcc2af6fd6b7ac1cca | 4b69847fc63e719a4850406f422da2b3b6196bd6 | diff --git a/README.md b/README.md
index c2b2ff177..cc2778c5e 100644
--- a/README.md
+++ b/README.md
@@ -30,7 +30,7 @@ These files now trigger console.warn with a message to come here:
### Bower
Bower has been deprecated, which means we will no longer support it.
-Please replace your usage of bower with npm, yarn o... | [
"README.md"
] | [] | true | ||
SortableJS/Sortable | 1,933 | issue_to_patch | fix(plugins): ignore mounting duplicate plugins | closes #1581
@beljand Thank you making these changes.
We had a repo refactor and it broke your PR so I made the PR. All credit to you! :)
| 87c35752a37d4763a5e9cbcfce53cb319a274465 | 65066070554e6fd10a5a4613c030e90fff5914b8 | diff --git a/packages/sortable/src/PluginManager.ts b/packages/sortable/src/PluginManager.ts
index 70ddc9cac..5e62d50ca 100644
--- a/packages/sortable/src/PluginManager.ts
+++ b/packages/sortable/src/PluginManager.ts
@@ -12,7 +12,11 @@ const pluginManager = {
plugin[option] = defaults[option];
}
}
... | [
"packages/sortable/src/PluginManager.ts"
] | [] | true | ||
SortableJS/Sortable | 1,932 | issue_to_patch | fix: (IE11 "SCRIPT16389) | closes #1904 | 6d54aa6a8f6b726745200c53862dfa3b3246fbf5 | 8d50d5871f443552e3d1ee38a476ad993fec846b | diff --git a/lerna.json b/lerna.json
index c020abd94..a514c17dd 100644
--- a/lerna.json
+++ b/lerna.json
@@ -5,6 +5,6 @@
"packages/plugins/*",
"packages/utils"
],
- "version": "1.12.0",
+ "version": "1.13.0",
"npmClient": "yarn"
}
diff --git a/packages/sortable/package.json b/packages/sortable/packag... | [
"lerna.json",
"packages/sortable/package.json",
"packages/utils/src/utils.ts"
] | [] | true | ||
SortableJS/Sortable | 1,927 | issue_to_patch | [bug] pkg.main, pkg.module are incompatible, so require("sortablejs") behaves differently under Rollup/Webpack
In some environments like Node and Browserify, `require("sortablejs")` returns `Sortable`, but in others like Rollup and Webpack, `require("sortablejs")` returns a module `{ Sortable: Sortable, default: Sorta... | Fix/no modules | closes #1891 after reoppening
| 77112076111a2521244dba3e3eb9487a7f4b5c1e | d7af518e2cb9fd481ea5f49d1a4ec48e548798eb | diff --git a/lerna.json b/lerna.json
index c63d29465..c020abd94 100644
--- a/lerna.json
+++ b/lerna.json
@@ -5,6 +5,6 @@
"packages/plugins/*",
"packages/utils"
],
- "version": "1.11.2-alpha.4",
+ "version": "1.12.0",
"npmClient": "yarn"
}
diff --git a/package.json b/package.json
index 918db6e7d..de34... | [
"lerna.json",
"package.json",
"packages/plugins/auto-scroll/package.json",
"packages/plugins/multi-drag/package.json",
"packages/plugins/on-spill/package.json",
"packages/plugins/swap/package.json",
"packages/sortable/package.json",
"packages/sortablejs/package.json",
"packages/utils/package.json"
] | [] | true | |
SortableJS/Sortable | 1,926 | issue_to_patch | [bug] pkg.main, pkg.module are incompatible, so require("sortablejs") behaves differently under Rollup/Webpack
In some environments like Node and Browserify, `require("sortablejs")` returns `Sortable`, but in others like Rollup and Webpack, `require("sortablejs")` returns a module `{ Sortable: Sortable, default: Sorta... | fix(build): corrects exports for compatibility | closes #1891 | c5220e2254175a5ecb726e442ec1d9d1de94389f | e740aebd3e19cf551a584d873b37446f58b42d16 | diff --git a/packages/sortablejs/package.json b/packages/sortablejs/package.json
index 84a25fd6b..97be26a59 100644
--- a/packages/sortablejs/package.json
+++ b/packages/sortablejs/package.json
@@ -2,16 +2,14 @@
"name": "sortablejs",
"version": "1.11.2-alpha.4",
"description": "JavaScript library for reorderabl... | [
"packages/sortablejs/package.json",
"packages/sortablejs/src/core-umd.ts",
"packages/sortablejs/src/default-umd.ts",
"packages/sortablejs/src/modular-complete.ts",
"packages/sortablejs/src/modular-core.ts",
"packages/sortablejs/src/modular-default.ts",
"packages/sortablejs/src/umd.ts"
] | [] | true | |
SortableJS/Sortable | 1,925 | issue_to_patch | update to v1.12.1-alpha-4 | This doesn't quite work as expected, being tracked in issue #1891
More to document the changes from alpha-3 to alpha-4.
I am working on a PR now so alpha-5 and therefore all of the sortable exports work correctly. Sorry about this.
We'll implement some smoke tests to ensure it doesn't happen again. | 21c5ecf0904a71ce84a385c4588a85e83de42e3c | 28e8c6634aa5286d580a69cf28ad120ec42513de | diff --git a/lerna.json b/lerna.json
index 37bde8fdb..c63d29465 100644
--- a/lerna.json
+++ b/lerna.json
@@ -5,6 +5,6 @@
"packages/plugins/*",
"packages/utils"
],
- "version": "1.11.2-alpha.3",
+ "version": "1.11.2-alpha.4",
"npmClient": "yarn"
}
diff --git a/packages/sortable/package.json b/packages... | [
"lerna.json",
"packages/sortable/package.json",
"packages/sortablejs/package.json",
"packages/sortablejs/yarn.lock"
] | [] | true | ||
SortableJS/Sortable | 1,921 | issue_to_patch | critical: package /dist/sortable.js via npm
Currently this is not packaging the main export. Users may experience issues with v1.12.0-alpha3. | fix(build): critical - ensure sortable deploys dist/sortable.js | alpha-3 doesn't have the MAIN export. This fixes that.
closes #1920 | 62b34925557d095aee60a31e3923271399d3bc81 | b3d470c40f770c11c67a04a4615924a7e973f47e | diff --git a/lerna.json b/lerna.json
index 37bde8fdb..c63d29465 100644
--- a/lerna.json
+++ b/lerna.json
@@ -5,6 +5,6 @@
"packages/plugins/*",
"packages/utils"
],
- "version": "1.11.2-alpha.3",
+ "version": "1.11.2-alpha.4",
"npmClient": "yarn"
}
diff --git a/packages/sortable/package.json b/packages... | [
"lerna.json",
"packages/sortable/package.json",
"packages/sortablejs/package.json",
"packages/sortablejs/yarn.lock"
] | [] | true | |
SortableJS/Sortable | 1,919 | issue_to_patch | [Bug] Invalid hyperlinks in README
### Scenario
Invalid hyperlinks in [README.md](https://github.com/SortableJS/Sortable/blob/master/README.md), navigating to mentioned links results in page not found (404) error.
### Steps to Reproduce
1. Go to https://github.com/SortableJS/Sortable#options
2. Click... | Readme invalid hyperlinks corrected | Readme invalid hyperlinks corrected Fixes #1918 | 1dff5e13df0b5660e247348ae6b73914a1a3dbaa | 650cd1c4bb1b358ff3eee8463e00bb80330d8c67 | diff --git a/README.md b/README.md
index ecd0a0abe..c2b2ff177 100644
--- a/README.md
+++ b/README.md
@@ -41,7 +41,7 @@ Please replace your usage of bower with npm, yarn or a javascript package manage
- Smart auto-scrolling
- Advanced swap detection
- Smooth animations
-- [Multi-drag](https://github.com/SortableJS/So... | [
"README.md"
] | [] | true | |
SortableJS/Sortable | 1,914 | issue_to_patch | docs: update github issue templates and contribution guide | a798fcff3aeb6d6d8ae818168a073f75ce1e7ef4 | 32f64d6e779ae43546e7059d6ed1bff485c7c06d | diff --git a/.editorconfig b/.editorconfig
deleted file mode 100644
index 09d275186..000000000
--- a/.editorconfig
+++ /dev/null
@@ -1,15 +0,0 @@
-# editorconfig.org
-root = true
-
-[*]
-indent_style = tab
-end_of_line = lf
-charset = utf-8
-trim_trailing_whitespace = true
-insert_final_newline = true
-
-[*.md]
-trim_t... | [
".editorconfig",
".github/ISSUE_TEMPLATE/bug-report.md",
".github/ISSUE_TEMPLATE/custom-template.md",
".github/ISSUE_TEMPLATE/discussion.md",
".github/ISSUE_TEMPLATE/feature-request.md",
".jshintrc",
"CONTRIBUTING.md"
] | [] | true | |||
SortableJS/Sortable | 1,884 | issue_to_patch | build: upgrade to 1.11.0 | 02be9a8fadbcba7ac88845ade94360cd35202d75 | 5f66a525984eb4c81321cdf207f884a188390515 | diff --git a/Sortable.js b/Sortable.js
index 7e8b755e2..11b7cec3e 100644
--- a/Sortable.js
+++ b/Sortable.js
@@ -1,5 +1,5 @@
/**!
- * Sortable 1.10.2
+ * Sortable 1.11.0
* @author RubaXa <trash@rubaxa.org>
* @author owenm <owen23355@gmail.com>
* @license MIT
@@ -10,7 +10,7 @@
(global = typeof globalThis ... | [
"Sortable.js",
"Sortable.min.js",
"modular/sortable.complete.esm.js",
"modular/sortable.core.esm.js",
"modular/sortable.esm.js",
"package-lock.json",
"package.json",
"scripts/test-compat.ts",
"scripts/test.ts"
] | [] | true | |||
SortableJS/Sortable | 1,882 | issue_to_patch | build: upgrade rollup to v2 for typescript bundling | We cannot compile typescript properly with v1 of rollup.
This PR upgrades it to ^v2.14, allowing us to implement typescript incrementally. | e6110af1e5dd7a55dbf85aafd395b403294263f2 | 58ff61c870a55140c1740167d70ee3fa0b6b175d | diff --git a/.prettierignore b/.prettierignore
new file mode 100644
index 000000000..649f37d0c
--- /dev/null
+++ b/.prettierignore
@@ -0,0 +1,1 @@
+src/utils.ts
\ No newline at end of file
diff --git a/Sortable.js b/Sortable.js
index c6d7f9da6..7e8b755e2 100644
--- a/Sortable.js
+++ b/Sortable.js
@@ -7,298 +7,181 @@
(... | [
".prettierignore",
"Sortable.js",
"Sortable.min.js",
"modular/sortable.complete.esm.js",
"modular/sortable.core.esm.js",
"modular/sortable.esm.js",
"package-lock.json",
"package.json",
"scripts/build.js",
"src/Sortable.js",
"src/utils.ts",
"tsconfig.json"
] | [] | true | ||
SortableJS/Sortable | 1,878 | issue_to_patch | Clarifying the signature of the onMove callback
**Custom**
The doc for options in the readme describes 3 return values for `onMove` corresponding to the special behaviors (`false`, `1` and `-1`): https://github.com/SortableJS/Sortable/tree/88838bfa5647e278f4cf87fdd4c3e34cd24fb33c#options
Reading the source code at... | Fix the doc about the onMove return values | The doc was missing the case of keeping the default insertion point based on the direction.
closes #1861 | 51e73bcac510fcf25f4087256fb42f4b6e90fd41 | be6a62a238fcca41fc8a124f866a09fb9875a905 | diff --git a/README.md b/README.md
index 956564bae..cb1218e42 100644
--- a/README.md
+++ b/README.md
@@ -220,6 +220,8 @@ var sortable = new Sortable(el, {
// return false; — for cancel
// return -1; — insert before target
// return 1; — insert after target
+ // return true; — keep default insertion point base... | [
"README.md"
] | [] | true | |
SortableJS/Sortable | 1,881 | issue_to_patch | refactor(tests): change dir structure for tests | - refactor(tests): move HTML fixtures into own dir
- refactor(tests): separate e2e tests into folders
- refactor(deps): packagejson reformat
- refactor(deps): remove cypress from dev deps
- refactor(ci): add description to circleci
Refactoring directories to help with the following:
- Moving from TestCafe to Selenium... | 340e8a252d7f710a95469c84debb50142ba5520b | ff1f0223e368365e2d3c8650efe16f6ad40e1276 | diff --git a/.circleci/config.yml b/.circleci/config.yml
index 1e8e25755..cf67d6952 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -22,6 +22,8 @@ jobs:
- run:
name: Compatibility Test
+ # Only run e2e-tests if the PR
+ # is published by the Sortable Organization
... | [
".circleci/config.yml",
"package-lock.json",
"package.json",
"scripts/test-compat.ts",
"scripts/test.ts",
"tests/Sortable.compat.test.js",
"tests/Sortable.test.js",
"tests/dual-list.html",
"tests/e2e-fixtures/dual-list.html",
"tests/e2e-fixtures/empty-list.html",
"tests/e2e-fixtures/filter.html"... | [] | diff --git a/tests/Sortable.compat.test.js b/tests/Sortable.compat.test.js
deleted file mode 100644
index 7c00396b9..000000000
--- a/tests/Sortable.compat.test.js
+++ /dev/null
@@ -1,39 +0,0 @@
-import { Selector } from 'testcafe';
-
-
-fixture `Simple Sorting`
- .page `./single-list.html`;
-
-let list1 = Selector('#li... | true | |
SortableJS/Sortable | 1,875 | issue_to_patch | tests,ci: replace yarn ci with npm ci, use typescript to run tests | When attempting to use yarn workspaces in a previous PR, I messed up the config file for circle CI.
This fixes that.
We're going to incrementally adopt typescript to the project. Getting TS to run the tests is a good way to start integrating it into the project. | 88838bfa5647e278f4cf87fdd4c3e34cd24fb33c | 1c37ccd0cab03f76a37271629cfb7bed59d2c067 | diff --git a/.circleci/config.yml b/.circleci/config.yml
index ffbb4f1a7..1e8e25755 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -8,8 +8,8 @@ jobs:
- restore_cache:
keys:
- - v1-dependencies-{{ checksum "package.json" }}
- - v1-dependencies-
+ - v1-dep... | [
".circleci/config.yml",
".prettierrc",
"package-lock.json",
"package.json",
"scripts/test-compat.js",
"scripts/test-compat.ts",
"scripts/test.js",
"scripts/test.ts",
"tsconfig.json"
] | [] | true | ||
SortableJS/Sortable | 1,834 | issue_to_patch | No animations when compiling with Angular CLI
Hi
When compiling SortableJS in production mode with angular CLI, there is no animations. I think, the build-optimizer maybe is removing some code.
I have found an old issue about the same here: https://github.com/SortableJS/ngx-sortablejs/issues/70
I'm using the ... | Not tree-shake repaint function by compressors like terser | Closes #1658 | e02baa8ebb2a71e93d61c1281ae63e286212ee78 | 541e6c3217eb847fbdf9f057aff8d345b9a14986 | diff --git a/src/Animation.js b/src/Animation.js
index 194799147..6aa8e3ef8 100644
--- a/src/Animation.js
+++ b/src/Animation.js
@@ -144,7 +144,7 @@ export default function AnimationStateManager() {
css(target, 'transform', 'translate3d(' + translateX + 'px,' + translateY + 'px,0)');
- repaint(target); // r... | [
"src/Animation.js"
] | [] | true | |
SortableJS/Sortable | 1,784 | issue_to_patch | Solves "insert Before error" issue on nested lists | That solves an issue with nested sortables.
example of error https://jsbin.com/xabonox/edit?html,css,js
An error appears when all following conditions are met:
1)You have two nested sortable containers
2)option “pull:clone” i set at least on the parent container
3)You drag an item from the parent container into th... | c36f49b770692267698181f8d5856c86c171de18 | c724964869515c7c4cd50c491461eb45e15a8197 | diff --git a/src/Sortable.js b/src/Sortable.js
index 7a096301d..89b3a20e4 100644
--- a/src/Sortable.js
+++ b/src/Sortable.js
@@ -1692,7 +1692,7 @@ Sortable.prototype = /** @lends Sortable.prototype */ {
if (Sortable.eventCanceled) return;
// show clone at dragEl or original position
- if (rootEl.contains(dr... | [
"src/Sortable.js"
] | [
{
"comment": "```suggestion\r\n\t\t\tif ( (rootEl.contains(dragEl) || dragEl.parentNode == rootEl ) && !this.options.group.revertClone) {\r\n```\r\n\r\nI have a feeling this might be safer. I'm unsure what remove the old check might do.",
"path": "src/Sortable.js",
"hunk": "@@ -1692,7 +1692,7 @@ Sortab... | true | ||
SortableJS/Sortable | 1,793 | issue_to_patch | creates new github issue templates | We've got a few codesandboxes to help with the many issues we receive.
Hope this helps.
@owen-m1 If Github doesn't automatically use this change, could you please change it in settings? I don't have access of that level. | c36f49b770692267698181f8d5856c86c171de18 | 2f2d88020b2998d260e9b355966378d036e87861 | diff --git a/.github/bug-report.md b/.github/bug-report.md
new file mode 100644
index 000000000..53a033cfd
--- /dev/null
+++ b/.github/bug-report.md
@@ -0,0 +1,73 @@
+---
+name: Bug report
+about: Create a report to help us improve
+title: "[bug] "
+labels: ""
+assignees: ""
+---
+
+<!--
+
+PLEASE READ BEFORE POSTING Y... | [
".github/bug-report.md",
".github/custom-template.md",
".github/feature-request.md",
"ISSUE_TEMPLATE.md"
] | [] | true | ||
SortableJS/Sortable | 1,794 | issue_to_patch | moves issue templates to the correct folder | a4b8846e5aff6e3009e78710f1b1399598144d6e | 49216127b747c22658a68c2da21c9950996366d7 | diff --git a/.github/bug-report.md b/.github/ISSUE_TEMPLATE/bug-report.md
similarity index 100%
rename from .github/bug-report.md
rename to .github/ISSUE_TEMPLATE/bug-report.md
diff --git a/.github/custom-template.md b/.github/ISSUE_TEMPLATE/custom-template.md
similarity index 100%
rename from .github/custom-template.m... | [
".github/ISSUE_TEMPLATE/bug-report.md",
".github/ISSUE_TEMPLATE/custom-template.md",
".github/ISSUE_TEMPLATE/feature-request.md"
] | [] | true | |||
SortableJS/Sortable | 1,764 | issue_to_patch | Fixed a typo in the description of the 'closest' method | As requested in https://github.com/SortableJS/Sortable/issues/1763 | edc9c317a07d5ad4ee3f982d2507bf8a8e4226da | 44972f429654de913c6fda288fe71ab985466580 | diff --git a/README.md b/README.md
index cc06e8223..956564bae 100644
--- a/README.md
+++ b/README.md
@@ -555,7 +555,7 @@ Get or set the option.
-##### closest(el:`String`[, selector:`HTMLElement`]):`HTMLElement|null`
+##### closest(el:`HTMLElement`[, selector:`String`]):`HTMLElement|null`
For each element in the... | [
"README.md"
] | [] | true | ||
SortableJS/Sortable | 1,681 | issue_to_patch | Clicking SELECT in Safari with forceFallback
#### Problem:
0. Desktop Safari (13.0.3)
1. Add SELECT input to sortable list
2. Use `{ forceFallback: true }` configuration
3. Click on select input
4. Click outside for closing the list box
5. The list item is started dragging
#### JSBin/JSFiddle demonstrating ... | Fix clicking select tag | Fixes #1680 | 2addddd67387b6e4b6b5e51806eb698f0a3eee88 | 61a06e7c62590addfae6bcbe4d8eead00efb6429 | diff --git a/src/Sortable.js b/src/Sortable.js
index 048a38b1c..a509a83c5 100644
--- a/src/Sortable.js
+++ b/src/Sortable.js
@@ -484,6 +484,11 @@ Sortable.prototype = /** @lends Sortable.prototype */ {
return;
}
+ // Safari ignores further event handling after mousedown
+ if (!this.nativeDraggable && Safari ... | [
"src/Sortable.js"
] | [] | true | |
SortableJS/Sortable | 1,732 | issue_to_patch | Minor fix for IE compatibility in st/app.js UI of thresholds demo | Related to #1731 | 2addddd67387b6e4b6b5e51806eb698f0a3eee88 | ed7042acfc8931fbbf9e196a52306fee1e1a5193 | diff --git a/st/app.js b/st/app.js
index 3c9e93d06..c29177ed0 100644
--- a/st/app.js
+++ b/st/app.js
@@ -102,7 +102,7 @@ var example7SizeProperty = 'width';
function renderThresholdWidth(evt) {
example7SwapThreshold = Number(evt.target.value);
- example7SwapThresholdCode.innerHTML = evt.target.value.indexOf('.') >... | [
"st/app.js"
] | [] | true | ||
SortableJS/Sortable | 1,719 | issue_to_patch | Debugging circle ci DO NOT MERGE | jUST CHECKING TO SEE IF IT BUILD | e2df04c6b15a2f3bca9d0a4435d4fbe1d9c7e0e6 | 603289a2a480ea3ffe861f250b01be2d2f11620e | diff --git a/Sortable.js b/Sortable.js
index 70b5ab395..a76e6b1eb 100644
--- a/Sortable.js
+++ b/Sortable.js
@@ -8,7 +8,7 @@
typeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() :
typeof define === 'function' && define.amd ? define(factory) :
(global = global || self, global.S... | [
"Sortable.js",
"package-lock.json",
"package.json"
] | [] | true | ||
SortableJS/Sortable | 1,717 | issue_to_patch | Typescript Merge Prep | This creates the setup to incrementally adapt typescript into the library.
It builds and it tests with `FAILED COUNT 0`.
I've only added `src/utils.ts` as a converted file. The rest are `.js`. This means we can add one file at a time if we wish and it will still build correctly.
In util.ts, I've added bunch o... | 2addddd67387b6e4b6b5e51806eb698f0a3eee88 | 9b2cf9ce2898402f7ffd98da71aee03d1eb484bb | diff --git a/Sortable.js b/Sortable.js
index c6d7f9da6..70b5ab395 100644
--- a/Sortable.js
+++ b/Sortable.js
@@ -5,3705 +5,3729 @@
* @license MIT
*/
(function (global, factory) {
- typeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() :
- typeof define === 'function' && define... | [
"Sortable.js",
"Sortable.min.js",
"babel.config.js",
"modular/sortable.complete.esm.js",
"modular/sortable.core.esm.js",
"modular/sortable.esm.js",
"package-lock.json",
"package.json",
"plugins/AutoScroll/AutoScroll.js",
"plugins/MultiDrag/MultiDrag.js",
"plugins/OnSpill/OnSpill.js",
"plugins/... | [] | true | ||
SortableJS/Sortable | 1,647 | issue_to_patch | Fix(utils): Chrome < 44 not support scrollingElement | When I use Chrome 41, got a lot of error of 'TypeError: Cannot read property getBoundingClientRect of undefined'.Because in 'utils.js' 'getWindowScrollingElement' function, Chrome < 44 FF < 47 not support scrollingElement too. | 82ce396042600f03e3cc63dd6f12a4966e417cad | 3f0a9bde8c82d0a3f57f5d5aa03c5b1480e00233 | diff --git a/src/utils.js b/src/utils.js
index 7109c973b..bd30854dd 100644
--- a/src/utils.js
+++ b/src/utils.js
@@ -147,10 +147,12 @@ function find(ctx, tagName, iterator) {
function getWindowScrollingElement() {
- if (IE11OrLess) {
- return document.documentElement;
+ let scrollingElement = document.scrollingEl... | [
"src/utils.js"
] | [] | true | ||
SortableJS/Sortable | 1,705 | issue_to_patch | Update README.md | Adds Typescript definitions package in Features | 143c63c47d2251d244b552b875dc2f8fef54dda9 | 4105c13108da8ce51d585d56393a1a731558a0a7 | diff --git a/README.md b/README.md
index 1126c18d5..cc06e8223 100644
--- a/README.md
+++ b/README.md
@@ -35,6 +35,7 @@ Demo: http://sortablejs.github.io/Sortable/
* Support for [plugins](#plugins)
* [CDN](#cdn)
* No jQuery required (but there is [support](https://github.com/SortableJS/jquery-sortablejs))
+ * Type... | [
"README.md"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.