repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
Shopify/liquid | 2,001 | comment_to_fix | Introduce Inline Snippets tag | Non blocking: we should name this `snippet_name` instead? So that we'd call `{% render snippet_name %}`?
Looks like the docs for assign are using `variable_name`. We can try to be consistent here. | c357f91e0c677327180c8e745b6e1bf867d65ab2 | c4a6987a307be14a6714375b64c5878bdb246608 | diff --git a/lib/liquid/tags/snippet.rb b/lib/liquid/tags/snippet.rb
new file mode 100644
index 000000000..87e2a0ded
--- /dev/null
+++ b/lib/liquid/tags/snippet.rb
@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+module Liquid
+ # @liquid_public_docs
+ # @liquid_type tag
+ # @liquid_category variable
+ # @liquid_... | [
"lib/liquid/tags/snippet.rb"
] | [
{
"comment": "Non blocking: we should name this `snippet_name` instead? So that we'd call `{% render snippet_name %}`? \n\nLooks like the docs for assign are using `variable_name`. We can try to be consistent here. ",
"path": "lib/liquid/tags/snippet.rb",
"hunk": "@@ -0,0 +1,44 @@\n+# frozen_string_lite... | true | ||
Shopify/liquid | 2,001 | comment_to_fix | Introduce Inline Snippets tag | We're missing a `p.consume(:end_of_text)`, otherwise folks could do stuff like `{% snippet foo bar baz %}` and we wouldn't be throwing an error | c357f91e0c677327180c8e745b6e1bf867d65ab2 | c4a6987a307be14a6714375b64c5878bdb246608 | diff --git a/lib/liquid/tags/snippet.rb b/lib/liquid/tags/snippet.rb
new file mode 100644
index 000000000..87e2a0ded
--- /dev/null
+++ b/lib/liquid/tags/snippet.rb
@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+module Liquid
+ # @liquid_public_docs
+ # @liquid_type tag
+ # @liquid_category variable
+ # @liquid_... | [
"lib/liquid/tags/snippet.rb"
] | [
{
"comment": "We're missing a `p.consume(:end_of_text)`, otherwise folks could do stuff like `{% snippet foo bar baz %}` and we wouldn't be throwing an error",
"path": "lib/liquid/tags/snippet.rb",
"hunk": "@@ -0,0 +1,44 @@\n+# frozen_string_literal: true\n+\n+module Liquid\n+ # @liquid_public_docs\n+ ... | true | ||
Shopify/liquid | 2,001 | comment_to_fix | Introduce Inline Snippets tag | this should already be taken care of from the line below | c357f91e0c677327180c8e745b6e1bf867d65ab2 | c4a6987a307be14a6714375b64c5878bdb246608 | diff --git a/lib/liquid/tags/render.rb b/lib/liquid/tags/render.rb
index 4d29e420e..dec725ed4 100644
--- a/lib/liquid/tags/render.rb
+++ b/lib/liquid/tags/render.rb
@@ -27,7 +27,7 @@ module Liquid
# @liquid_syntax_keyword filename The name of the snippet to render, without the `.liquid` extension.
class Render < ... | [
"lib/liquid/tags/render.rb"
] | [
{
"comment": "this should already be taken care of from the line below",
"path": "lib/liquid/tags/render.rb",
"hunk": "@@ -55,6 +55,9 @@ def render_tag(context, output)\n elsif @template_name_expr.is_a?(String)\n partial = PartialCache.load(template, context: context, parse_context: parse_... | true | ||
Shopify/liquid | 2,001 | comment_to_fix | Introduce Inline Snippets tag | we do not want foo to be there, because it's rather confusing. if an error happens inside an inline snippet the filename should not get changed, as the inline snippet is inline, thus it's in the same file. | c357f91e0c677327180c8e745b6e1bf867d65ab2 | c4a6987a307be14a6714375b64c5878bdb246608 | diff --git a/test/integration/tags/snippet_test.rb b/test/integration/tags/snippet_test.rb
new file mode 100644
index 000000000..6d1cb35d7
--- /dev/null
+++ b/test/integration/tags/snippet_test.rb
@@ -0,0 +1,1087 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+class SnippetTest < Minitest::Test
+ include... | [
"test/integration/tags/snippet_test.rb"
] | [
{
"comment": "we do not want foo to be there, because it's rather confusing. if an error happens inside an inline snippet the filename should not get changed, as the inline snippet is inline, thus it's in the same file.",
"path": "test/integration/tags/snippet_test.rb",
"hunk": "@@ -480,6 +480,25 @@ def... | true | ||
Shopify/liquid | 2,001 | comment_to_fix | Introduce Inline Snippets tag | we should not change this IMO. it's effectively a breaking change | c357f91e0c677327180c8e745b6e1bf867d65ab2 | c4a6987a307be14a6714375b64c5878bdb246608 | diff --git a/lib/liquid/tags/render.rb b/lib/liquid/tags/render.rb
index 4d29e420e..dec725ed4 100644
--- a/lib/liquid/tags/render.rb
+++ b/lib/liquid/tags/render.rb
@@ -27,7 +27,7 @@ module Liquid
# @liquid_syntax_keyword filename The name of the snippet to render, without the `.liquid` extension.
class Render < ... | [
"lib/liquid/tags/render.rb"
] | [
{
"comment": "we should not change this IMO. it's effectively a breaking change",
"path": "lib/liquid/tags/render.rb",
"hunk": "@@ -51,16 +51,16 @@ def render_tag(context, output)\n \n if template.respond_to?(:to_partial)\n partial = template.to_partial\n- template_name = template.n... | true | ||
Shopify/liquid | 2,036 | issue_to_patch | Update the specs to new signature and fix CI | - Remove on pull_request CI trigger, it's redundant with push
- Add the options to the CI check name to distinguish between them
- Update the specs to the new signature | eaa9f215bf90d05ef5113055dfc42e85e991dd3c | aa817c4cfd8a0ca693698193a4d6d19c1ecbe42e | diff --git a/.github/workflows/liquid.yml b/.github/workflows/liquid.yml
index de57dd68d..c018a4954 100644
--- a/.github/workflows/liquid.yml
+++ b/.github/workflows/liquid.yml
@@ -1,5 +1,5 @@
name: Liquid
-on: [push, pull_request]
+on: [push]
env:
BUNDLE_JOBS: 4
@@ -32,7 +32,7 @@ jobs:
}
... | [
".github/workflows/liquid.yml",
"Gemfile",
"spec/ruby_liquid.rb",
"spec/ruby_liquid_lax.rb",
"spec/ruby_liquid_with_active_support.rb",
"spec/ruby_liquid_yjit.rb"
] | [] | diff --git a/spec/ruby_liquid.rb b/spec/ruby_liquid.rb
index 062e635f9..628fbbfe3 100644
--- a/spec/ruby_liquid.rb
+++ b/spec/ruby_liquid.rb
@@ -14,15 +14,14 @@
# Compile a template string into a Liquid::Template
LiquidSpec.compile do |ctx, source, options|
- Liquid::Template.parse(source, **options)
+ ctx[:templ... | true | |
Shopify/liquid | 2,034 | issue_to_patch | Require liquid-spec to be run on commit automatically and related fixes | ## Summary
Adds liquid-spec conformance testing to CI and fixes Liquid to work correctly without ActiveSupport.
## Changes
### CI Integration
- Add `liquid-spec` gem dependency for conformance testing
- Add `spec` job to GitHub Actions that runs all adapters in `spec/*.rb`
- Two adapters: `ruby_liquid.rb` (without A... | a60a6c0d9370b45de2e2b0e2d8c00515a8f0eb12 | 0058e4322ba0099206f9b263b9b80f25e2d1be30 | diff --git a/.github/workflows/liquid.yml b/.github/workflows/liquid.yml
index bd0df8e5b..de57dd68d 100644
--- a/.github/workflows/liquid.yml
+++ b/.github/workflows/liquid.yml
@@ -9,26 +9,29 @@ jobs:
test:
runs-on: ubuntu-latest
strategy:
+ fail-fast: false
matrix:
entry:
- -... | [
".github/workflows/liquid.yml",
".rubocop_todo.yml",
"Gemfile",
"lib/liquid/condition.rb",
"lib/liquid/drop.rb",
"lib/liquid/expression.rb",
"lib/liquid/i18n.rb",
"lib/liquid/standardfilters.rb",
"lib/liquid/tokenizer.rb",
"lib/liquid/utils.rb",
"lib/liquid/variable_lookup.rb",
"spec/ruby_liqu... | [] | diff --git a/spec/ruby_liquid.rb b/spec/ruby_liquid.rb
new file mode 100644
index 000000000..5eda72da4
--- /dev/null
+++ b/spec/ruby_liquid.rb
@@ -0,0 +1,36 @@
+# frozen_string_literal: true
+
+# Liquid Spec Adapter for Shopify/liquid (Ruby reference implementation)
+#
+# Run with: bundle exec liquid-spec run spec/ruby... | true | |
Shopify/liquid | 2,007 | issue_to_patch | Unable to call "key?" and "[]=" on Liquid::Context when strict_variable is true
While building a Custom Tag, I want to check if a variable exist in the context, but calling "key?" gives an error
Example code:
```
>> context = Liquid::Context.new({})
#<Liquid::Context:0x00000003027ffe68
>> context.strict_variables=tr... | Don't raise if no variable found when `using context.key?` with `strict_variables` | - Closes https://github.com/Shopify/liquid/issues/1990
Previously if you set `strict_variables` to `true` on the context using `key?('key_name')` would raise a `Liquid::UndefinedVariable` error. Raising this error makes sense if you're trying to access the variable directly with something like `context['key_name']`... | 248f3a412f59da16fc184bc0bbd92522a1f62393 | 9973f3399e6531ac381e798039f41f33d65aa508 | diff --git a/lib/liquid/context.rb b/lib/liquid/context.rb
index 1ef272d46..433b6d003 100644
--- a/lib/liquid/context.rb
+++ b/lib/liquid/context.rb
@@ -184,7 +184,7 @@ def [](expression)
end
def key?(key)
- self[key] != nil
+ find_variable(key, raise_on_not_found: false) != nil
end
de... | [
"lib/liquid/context.rb",
"test/integration/context_test.rb"
] | [
{
"comment": "This is an opinionated change. Instead of evaluating `Expression.parse` to look up the tree if we don't find a match we should assume that somebody is passing a simple lookup to `key?` and check for it directly.",
"path": "lib/liquid/context.rb",
"hunk": "@@ -184,7 +184,7 @@ def [](express... | diff --git a/test/integration/context_test.rb b/test/integration/context_test.rb
index f59147e29..d230734f6 100644
--- a/test/integration/context_test.rb
+++ b/test/integration/context_test.rb
@@ -639,6 +639,21 @@ def test_has_key_will_not_add_an_error_for_missing_keys
end
end
+ def test_key_lookup_will_rais... | true |
Shopify/liquid | 2,022 | issue_to_patch | Use floating-point format for BigDecimal stringification | ## Summary
- BigDecimal values now stringify using `to_s("F")` format instead of the default `to_s`
## Why
Ruby's default `BigDecimal#to_s` produces engineering/scientific notation for certain values:
```ruby
BigDecimal("0.00001").to_s # => "0.1E-4"
BigDecimal("12345678.9").to_s # => "0.123456789E8... | 735d551168fcbf205b4699d422b707acbd54357f | 4988f7bbd429949603933670b6076e2aa6fffd00 | diff --git a/lib/liquid/utils.rb b/lib/liquid/utils.rb
index 2bdb0c521..eb0a02a9f 100644
--- a/lib/liquid/utils.rb
+++ b/lib/liquid/utils.rb
@@ -95,6 +95,8 @@ def self.to_liquid_value(obj)
def self.to_s(obj, seen = {})
case obj
+ when BigDecimal
+ obj.to_s("F")
when Hash
# If t... | [
"lib/liquid/utils.rb"
] | [] | true | ||
Shopify/liquid | 2,016 | issue_to_patch | Preserve literal semantics in strict2 case/when | Previously, `strict2` used `safe_parse_expression` to parse `when` expressions causing `blank` and `empty` to be treated as string literals (Expression::LITERALS maps 'empty' => ''), rather than method literals
This caused unexpected behaviour:
```liquid
{%- case products -%}
{%- when empty -%}
previousl... | 32b50ecafecae41b924f3e3120c6dc587efdd800 | fa27bfe6e0eff396407bfb031ef1de5f5014e206 | diff --git a/lib/liquid/tags/case.rb b/lib/liquid/tags/case.rb
index b32ea1ae7..e87e402e5 100644
--- a/lib/liquid/tags/case.rb
+++ b/lib/liquid/tags/case.rb
@@ -118,7 +118,7 @@ def parse_strict2_when(markup, body)
parser = @parse_context.new_parser(markup)
loop do
- expr = safe_parse_expression(p... | [
"lib/liquid/tags/case.rb",
"test/unit/tags/case_tag_unit_test.rb"
] | [
{
"comment": "I'm only adding a test for `empty` as `blank` requires activesupport in order to render as we expect, however both have parity with `lax`",
"path": "test/unit/tags/case_tag_unit_test.rb",
"hunk": "@@ -82,6 +82,26 @@ def test_case_when_with_or\n end\n end\n \n+ def test_case_when_emp... | diff --git a/test/unit/tags/case_tag_unit_test.rb b/test/unit/tags/case_tag_unit_test.rb
index 9d7d34a39..11458db80 100644
--- a/test/unit/tags/case_tag_unit_test.rb
+++ b/test/unit/tags/case_tag_unit_test.rb
@@ -82,6 +82,26 @@ def test_case_when_with_or
end
end
+ def test_case_when_empty
+ template = <<~... | true | |
Shopify/liquid | 2,012 | issue_to_patch | Bump Liquid to 5.11.0 | This PR reverts the Inline Snippets tag (https://github.com/Shopify/liquid/pull/2001) and bumps Liquid to 5.11. For now, the inclusion of Inline Snippets in the latest Liquid release is being treated as a bug.
While https://github.com/Shopify/liquid/pull/2001 does implement the scope contained in [RFC#1916](https://... | cbd8a0a2ee2cd3f12516c52558e5a894d1fd792a | 55f9cc04fcedaf19bf2c71605fbbc52b81d9eab3 | diff --git a/History.md b/History.md
index 183a8ab93..94feaabfd 100644
--- a/History.md
+++ b/History.md
@@ -1,13 +1,11 @@
# Liquid Change Log
+## 5.11.0
+* Revert the Inline Snippets tag (#2001), treat its inclusion in the latest Liquid release as a bug, and allow for feedback on RFC#1916 to better support Liquid d... | [
"History.md",
"README.md",
"Rakefile",
"bin/render",
"lib/liquid.rb",
"lib/liquid/environment.rb",
"lib/liquid/locales/en.yml",
"lib/liquid/parse_context.rb",
"lib/liquid/parser_switching.rb",
"lib/liquid/snippet_drop.rb",
"lib/liquid/tags.rb",
"lib/liquid/tags/case.rb",
"lib/liquid/tags/cyc... | [] | diff --git a/test/integration/tags/cycle_tag_test.rb b/test/integration/tags/cycle_tag_test.rb
index f3f865f08..dfb5984d8 100644
--- a/test/integration/tags/cycle_tag_test.rb
+++ b/test/integration/tags/cycle_tag_test.rb
@@ -101,7 +101,7 @@ def test_cycle_tag_with_error_mode
assert_template_result("a", template2... | true | |
Shopify/liquid | 1,943 | issue_to_patch | Revert `Utils.to_s` on all array filters | dbe709c3bf2f8521764ae51b36dd551905dfad7e | f676e699a4d707e19f780ea29f9add9971d91280 | diff --git a/lib/liquid/standardfilters.rb b/lib/liquid/standardfilters.rb
index daa2c5806..7359062ea 100644
--- a/lib/liquid/standardfilters.rb
+++ b/lib/liquid/standardfilters.rb
@@ -386,7 +386,6 @@ def sort(input, property = nil)
end
elsif ary.all? { |el| el.respond_to?(:[]) }
begin
- ... | [
"lib/liquid/standardfilters.rb",
"lib/liquid/version.rb",
"test/integration/standard_filter_test.rb"
] | [] | diff --git a/test/integration/standard_filter_test.rb b/test/integration/standard_filter_test.rb
index 6a2737bba..6b931de59 100644
--- a/test/integration/standard_filter_test.rb
+++ b/test/integration/standard_filter_test.rb
@@ -560,26 +560,6 @@ def test_map_returns_empty_on_2d_input_array
end
end
- def test... | true | ||
Shopify/liquid | 2,006 | issue_to_patch | Bump to 5.10.0 | Bumping Liquid to 5.10.0 with the addition of Inline Snippets.
```liquid
{%- snippet snowdevil -%}
Snowdevil
{%- endsnippet -%}
{% render snowdevil %}
``` | a16ec56a402e898145354e8a213bb7f0a2408b43 | 448d98ce2fae3f9d456aa653deb796020e2e6cc5 | diff --git a/History.md b/History.md
index 763b80533..183a8ab93 100644
--- a/History.md
+++ b/History.md
@@ -1,5 +1,14 @@
# Liquid Change Log
+## 5.10.0
+* Introduce support for Inline Snippets [Julia Boutin]
+ ```
+ {%- snippet snowdevil -%}
+ Snowdevil
+ {%- endsnippet -%}
+ {% render snowdevil %}
+ ```
+
... | [
"History.md",
"lib/liquid/version.rb"
] | [] | true | ||
Shopify/liquid | 2,004 | issue_to_patch | Bump to 5.9.0 | Bumping Liquid to 5.9.0 with the addition of the `rigid` parser mode. | 1f58216f48b5671fe25090d1cb251bb083cc3858 | b599ca682398cb0c6bd5b9491c826042edab6df3 | diff --git a/lib/liquid/version.rb b/lib/liquid/version.rb
index 9c5807b63..6f3e83e7d 100644
--- a/lib/liquid/version.rb
+++ b/lib/liquid/version.rb
@@ -2,5 +2,5 @@
# frozen_string_literal: true
module Liquid
- VERSION = "5.8.7"
+ VERSION = "5.9.0"
end
| [
"lib/liquid/version.rb"
] | [] | true | ||
Shopify/liquid | 1,991 | issue_to_patch | Introduce `:rigid` parsing mode | This PR introduces the `:rigid` parsing mode, as the existing `:strict` parser can still be too forgiving in certain cases.
For example:
```liquid
<table>
{% tablerow i in (1..10) limit: foo=>bar %}
{{ i }}
{% endtablerow %}
</table>
```
With this change, parsing for the `case/when`, `cycle`, `fo... | 1c1e7119065b0fa915149b9e2bdc303490a0dfff | 462a8b28cd02f287141b7904c8edaec2122ee324 | diff --git a/History.md b/History.md
index 3d979dc14..763b80533 100644
--- a/History.md
+++ b/History.md
@@ -1,5 +1,8 @@
# Liquid Change Log
+## 5.9.0
+* Introduce `:rigid` error mode for stricter, safer parsing of all tags [CP Clermont, Guilherme Carreiro]
+
## 5.8.7
* Expose body content in the `Doc` tag [James ... | [
"History.md",
"README.md",
"Rakefile",
"bin/render",
"lib/liquid/condition.rb",
"lib/liquid/environment.rb",
"lib/liquid/expression.rb",
"lib/liquid/locales/en.yml",
"lib/liquid/parse_context.rb",
"lib/liquid/parser_switching.rb",
"lib/liquid/tag.rb",
"lib/liquid/tags/case.rb",
"lib/liquid/t... | [
{
"comment": "maybe I'd order them in order of rigid -> lax? ",
"path": "lib/liquid/environment.rb",
"hunk": "@@ -34,7 +34,7 @@ class << self\n # @param file_system The default file system that is used\n # to load templates from.\n # @param error_mode [Symbol] The default error mode f... | diff --git a/test/integration/context_test.rb b/test/integration/context_test.rb
index f6afaca52..f59147e29 100644
--- a/test/integration/context_test.rb
+++ b/test/integration/context_test.rb
@@ -632,7 +632,7 @@ def notice(output)
end
def test_has_key_will_not_add_an_error_for_missing_keys
- with_error_mode... | true | |
Shopify/liquid | 1,991 | comment_to_fix | Introduce `:rigid` parsing mode | maybe I'd order them in order of rigid -> lax? | 1c1e7119065b0fa915149b9e2bdc303490a0dfff | 462a8b28cd02f287141b7904c8edaec2122ee324 | diff --git a/lib/liquid/environment.rb b/lib/liquid/environment.rb
index 31b17b234..59719c4ad 100644
--- a/lib/liquid/environment.rb
+++ b/lib/liquid/environment.rb
@@ -34,7 +34,7 @@ class << self
# @param file_system The default file system that is used
# to load templates from.
# @param error_mo... | [
"lib/liquid/environment.rb"
] | [
{
"comment": "maybe I'd order them in order of rigid -> lax? ",
"path": "lib/liquid/environment.rb",
"hunk": "@@ -34,7 +34,7 @@ class << self\n # @param file_system The default file system that is used\n # to load templates from.\n # @param error_mode [Symbol] The default error mode f... | true | ||
Shopify/liquid | 1,991 | comment_to_fix | Introduce `:rigid` parsing mode | I feel like that's a job for the methods themselves. OW we'd probably double parse expressions.
It's common for parse_expression to be called with `p.expression` as argument
e.g. in `if`
```
def parse_comparison(p)
a = parse_expression(p.expression)
if (op = p.consume?(:comparison))
b = parse_e... | 1c1e7119065b0fa915149b9e2bdc303490a0dfff | 462a8b28cd02f287141b7904c8edaec2122ee324 | diff --git a/lib/liquid/parse_context.rb b/lib/liquid/parse_context.rb
index 60cdf9e41..476123393 100644
--- a/lib/liquid/parse_context.rb
+++ b/lib/liquid/parse_context.rb
@@ -50,7 +50,22 @@ def new_tokenizer(source, start_line_number: nil, for_liquid_tag: false)
)
end
- def parse_expression(markup)
+... | [
"lib/liquid/parse_context.rb"
] | [
{
"comment": "I feel like that's a job for the methods themselves. OW we'd probably double parse expressions. \n\nIt's common for parse_expression to be called with `p.expression` as argument\n\ne.g. in `if`\n```\n def parse_comparison(p)\n a = parse_expression(p.expression)\n if (op = p.consume?(:co... | true | ||
Shopify/liquid | 1,991 | comment_to_fix | Introduce `:rigid` parsing mode | Made it so we can easily override this to allow for `render block` | 1c1e7119065b0fa915149b9e2bdc303490a0dfff | 462a8b28cd02f287141b7904c8edaec2122ee324 | diff --git a/lib/liquid/tags/render.rb b/lib/liquid/tags/render.rb
index 26004d647..4d29e420e 100644
--- a/lib/liquid/tags/render.rb
+++ b/lib/liquid/tags/render.rb
@@ -35,22 +35,7 @@ class Render < Tag
def initialize(tag_name, markup, options)
super
-
- raise SyntaxError, options[:locale].t("errors.... | [
"lib/liquid/tags/render.rb"
] | [
{
"comment": "Made it so we can easily override this to allow for `render block`",
"path": "lib/liquid/tags/render.rb",
"hunk": "@@ -99,6 +84,64 @@ def render_tag(context, output)\n output\n end\n \n+ # render (string) (with|for expression)? (as id)? (key: value)*\n+ def rigid_parse(mark... | true | ||
Shopify/liquid | 1,991 | comment_to_fix | Introduce `:rigid` parsing mode | Should at least be minor, no? | 1c1e7119065b0fa915149b9e2bdc303490a0dfff | 462a8b28cd02f287141b7904c8edaec2122ee324 | diff --git a/History.md b/History.md
index 3d979dc14..763b80533 100644
--- a/History.md
+++ b/History.md
@@ -1,5 +1,8 @@
# Liquid Change Log
+## 5.9.0
+* Introduce `:rigid` error mode for stricter, safer parsing of all tags [CP Clermont, Guilherme Carreiro]
+
## 5.8.7
* Expose body content in the `Doc` tag [James ... | [
"History.md"
] | [
{
"comment": "Should at least be minor, no?",
"path": "History.md",
"hunk": "@@ -1,5 +1,8 @@\n # Liquid Change Log\n \n+## 5.8.8",
"resolving_sha": "462a8b28cd02f287141b7904c8edaec2122ee324",
"resolving_diff": "diff --git a/History.md b/History.md\nindex 3d979dc14..763b80533 100644\n--- a/Histor... | true | ||
Shopify/liquid | 1,991 | comment_to_fix | Introduce `:rigid` parsing mode | LOL this will definitely confuse so many folks; should we just say "deprecated" | 1c1e7119065b0fa915149b9e2bdc303490a0dfff | 462a8b28cd02f287141b7904c8edaec2122ee324 | diff --git a/README.md b/README.md
index 3734a290f..34884464d 100644
--- a/README.md
+++ b/README.md
@@ -99,14 +99,14 @@ Setting the error mode of Liquid lets you specify how strictly you want your tem
Normally the parser is very lax and will accept almost anything without error. Unfortunately this can make
it very h... | [
"README.md"
] | [
{
"comment": "LOL this will definitely confuse so many folks; should we just say \"deprecated\"",
"path": "README.md",
"hunk": "@@ -99,14 +99,14 @@ Setting the error mode of Liquid lets you specify how strictly you want your tem\n Normally the parser is very lax and will accept almost anything without e... | true | ||
Shopify/liquid | 1,991 | comment_to_fix | Introduce `:rigid` parsing mode | ```suggestion
desc('runs test suite with lax, strict, and rigid parsers')
```
since we don't do `warn` | 1c1e7119065b0fa915149b9e2bdc303490a0dfff | 462a8b28cd02f287141b7904c8edaec2122ee324 | diff --git a/Rakefile b/Rakefile
index 6ccd2c866..878536bf5 100755
--- a/Rakefile
+++ b/Rakefile
@@ -33,7 +33,7 @@ task :rubocop do
end
end
-desc('runs test suite with both strict and lax parsers')
+desc('runs test suite with lax, strict, and rigid parsers')
task :test do
ENV['LIQUID_PARSER_MODE'] = 'lax'
... | [
"Rakefile"
] | [
{
"comment": "```suggestion\r\ndesc('runs test suite with lax, strict, and rigid parsers')\r\n```\r\n\r\nsince we don't do `warn`",
"path": "Rakefile",
"hunk": "@@ -33,7 +33,7 @@ task :rubocop do\n end\n end\n \n-desc('runs test suite with both strict and lax parsers')\n+desc('runs test suite with all... | true | ||
Shopify/liquid | 1,991 | comment_to_fix | Introduce `:rigid` parsing mode | ```suggestion
@@method_literals[markup] || parse_context.parse_expression(markup, safe:)
``` | 1c1e7119065b0fa915149b9e2bdc303490a0dfff | 462a8b28cd02f287141b7904c8edaec2122ee324 | diff --git a/lib/liquid/condition.rb b/lib/liquid/condition.rb
index e5c321dca..9ab350f07 100644
--- a/lib/liquid/condition.rb
+++ b/lib/liquid/condition.rb
@@ -48,8 +48,8 @@ def self.operators
@@operators
end
- def self.parse_expression(parse_context, markup)
- @@method_literals[markup] || parse_... | [
"lib/liquid/condition.rb"
] | [
{
"comment": "```suggestion\r\n @@method_literals[markup] || parse_context.parse_expression(markup, safe:)\r\n```",
"path": "lib/liquid/condition.rb",
"hunk": "@@ -48,8 +48,8 @@ def self.operators\n @@operators\n end\n \n- def self.parse_expression(parse_context, markup)\n- @@meth... | true | ||
Shopify/liquid | 1,991 | comment_to_fix | Introduce `:rigid` parsing mode | Wait, so when you do
```
{% assign a = "1" %}
{%- cycle a, "2" -%}
{%- cycle a, "2" -%}
{%- cycle a, "2" -%}
```
it outputs "111"
When you do
```
{%- cycle "1", "2" -%}
{%- cycle "1", "2" -%}
{%- cycle "1", "2" -%}
```
it outputs "121" wtf - that's not unobvious
Maybe we should have ke... | 1c1e7119065b0fa915149b9e2bdc303490a0dfff | 462a8b28cd02f287141b7904c8edaec2122ee324 | diff --git a/test/integration/tags/cycle_tag_test.rb b/test/integration/tags/cycle_tag_test.rb
index a034db17e..f3f865f08 100644
--- a/test/integration/tags/cycle_tag_test.rb
+++ b/test/integration/tags/cycle_tag_test.rb
@@ -3,20 +3,10 @@
require 'test_helper'
class CycleTagTest < Minitest::Test
- def test_simple_... | [
"test/integration/tags/cycle_tag_test.rb"
] | [
{
"comment": "Wait, so when you do\r\n```\r\n {% assign a = \"1\" %}\r\n {%- cycle a, \"2\" -%}\r\n {%- cycle a, \"2\" -%}\r\n {%- cycle a, \"2\" -%}\r\n```\r\nit outputs \"111\"\r\n\r\nWhen you do\r\n```\r\n {%- cycle \"1\", \"2\" -%}\r\n {%- cycle \"1\", \"2\" -%}\r\n {%- cycle \"1\", \"2\" -%}\r\n```\... | true | ||
Shopify/liquid | 1,991 | comment_to_fix | Introduce `:rigid` parsing mode | ```suggestion
def test_render_tag_caches_second_read_of_same_partial
``` | 1c1e7119065b0fa915149b9e2bdc303490a0dfff | 462a8b28cd02f287141b7904c8edaec2122ee324 | diff --git a/test/integration/tags/render_tag_test.rb b/test/integration/tags/render_tag_test.rb
index eda80a040..d6453fb51 100644
--- a/test/integration/tags/render_tag_test.rb
+++ b/test/integration/tags/render_tag_test.rb
@@ -105,7 +105,33 @@ def test_dynamically_choosen_templates_are_not_allowed
assert_syntax_... | [
"test/integration/tags/render_tag_test.rb"
] | [
{
"comment": "```suggestion\r\n def test_render_tag_caches_second_read_of_same_partial\r\n```",
"path": "test/integration/tags/render_tag_test.rb",
"hunk": "@@ -105,6 +105,32 @@ def test_dynamically_choosen_templates_are_not_allowed\n assert_syntax_error(\"{% assign name = 'snippet' %}{% render nam... | true | ||
Shopify/liquid | 1,991 | comment_to_fix | Introduce `:rigid` parsing mode | ```suggestion
def test_case_when_with_trailing_element
```
This follows the pattern you have with other test cases in this file | 1c1e7119065b0fa915149b9e2bdc303490a0dfff | 462a8b28cd02f287141b7904c8edaec2122ee324 | diff --git a/test/unit/tags/case_tag_unit_test.rb b/test/unit/tags/case_tag_unit_test.rb
index a94d167f5..5e181f3eb 100644
--- a/test/unit/tags/case_tag_unit_test.rb
+++ b/test/unit/tags/case_tag_unit_test.rb
@@ -9,4 +9,120 @@ def test_case_nodelist
template = Liquid::Template.parse('{% case var %}{% when true %}W... | [
"test/unit/tags/case_tag_unit_test.rb"
] | [
{
"comment": "```suggestion\r\n def test_case_when_with_trailing_element\r\n```\r\n\r\nThis follows the pattern you have with other test cases in this file",
"path": "test/unit/tags/case_tag_unit_test.rb",
"hunk": "@@ -9,4 +9,120 @@ def test_case_nodelist\n template = Liquid::Template.parse('{% cas... | true | ||
Shopify/liquid | 1,991 | comment_to_fix | Introduce `:rigid` parsing mode | ```suggestion
def with_error_modes(*modes)
``` | 1c1e7119065b0fa915149b9e2bdc303490a0dfff | 462a8b28cd02f287141b7904c8edaec2122ee324 | diff --git a/test/test_helper.rb b/test/test_helper.rb
index 4f4447384..293ea4766 100755
--- a/test/test_helper.rb
+++ b/test/test_helper.rb
@@ -34,7 +34,7 @@ module Assertions
def assert_template_result(
expected, template, assigns = {},
- message: nil, partials: nil, error_mode: nil, render_errors:... | [
"test/test_helper.rb"
] | [
{
"comment": "```suggestion\r\n def with_error_modes(*modes)\r\n```",
"path": "test/test_helper.rb",
"hunk": "@@ -82,10 +82,12 @@ def with_global_filter(*globals, &blk)\n Environment.dangerously_override(environment, &blk)\n end\n \n- def with_error_mode(mode)\n+ def with_error_mode(*... | true | ||
Shopify/liquid | 1,991 | comment_to_fix | Introduce `:rigid` parsing mode | All the test situations like these in this file are pretty much why i say `strict` should be "deprecated" rather than just say that it validates _some_ tags. Strict is just failing to parse because of linting issues. | 1c1e7119065b0fa915149b9e2bdc303490a0dfff | 462a8b28cd02f287141b7904c8edaec2122ee324 | diff --git a/test/integration/variable_test.rb b/test/integration/variable_test.rb
index 19922c191..f0f2bc409 100644
--- a/test/integration/variable_test.rb
+++ b/test/integration/variable_test.rb
@@ -209,4 +209,69 @@ def test_variable_lookup_should_not_hang_with_invalid_syntax
end
end
end
+
+ def test_... | [
"test/integration/variable_test.rb"
] | [
{
"comment": "All the test situations like these in this file are pretty much why i say `strict` should be \"deprecated\" rather than just say that it validates _some_ tags. Strict is just failing to parse because of linting issues.",
"path": "test/integration/variable_test.rb",
"hunk": "@@ -209,4 +209,... | true | ||
Shopify/liquid | 1,991 | comment_to_fix | Introduce `:rigid` parsing mode | Is this staying in the PR? | 1c1e7119065b0fa915149b9e2bdc303490a0dfff | 462a8b28cd02f287141b7904c8edaec2122ee324 | diff --git a/bin/render b/bin/render
new file mode 100755
index 000000000..26d9b53d8
--- /dev/null
+++ b/bin/render
@@ -0,0 +1,46 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+require 'bundler/setup'
+require 'liquid'
+
+class VirtualFileSystem
+ def initialize
+ snippet_1 = <<~LIQUID
+ <h1>
+ ... | [
"bin/render"
] | [
{
"comment": "Is this staying in the PR?",
"path": "bin/render",
"hunk": "",
"resolving_sha": "462a8b28cd02f287141b7904c8edaec2122ee324",
"resolving_diff": "diff --git a/bin/render b/bin/render\nnew file mode 100755\nindex 000000000..26d9b53d8\n--- /dev/null\n+++ b/bin/render\n@@ -0,0 +1,46 @@\n... | true | ||
Shopify/liquid | 1,991 | comment_to_fix | Introduce `:rigid` parsing mode | [nit]
```suggestion
@variable_name_expr = if with_or_for
@variable_name_expr = safe_parse_expression(p)
end
``` | 1c1e7119065b0fa915149b9e2bdc303490a0dfff | 462a8b28cd02f287141b7904c8edaec2122ee324 | diff --git a/lib/liquid/tags/include.rb b/lib/liquid/tags/include.rb
index 1fefa16f4..5b2aaa432 100644
--- a/lib/liquid/tags/include.rb
+++ b/lib/liquid/tags/include.rb
@@ -27,24 +27,7 @@ class Include < Tag
def initialize(tag_name, markup, options)
super
-
- if markup =~ SYNTAX
-
- template_n... | [
"lib/liquid/tags/include.rb"
] | [
{
"comment": "[nit]\r\n```suggestion\r\n @variable_name_expr = if with_or_for\r\n @variable_name_expr = safe_parse_expression(p)\r\n end\r\n```",
"path": "lib/liquid/tags/include.rb",
"hunk": "@@ -101,6 +84,61 @@ def render_to_output_buffer(context, output)\n alias_method :parse_con... | true | ||
Shopify/liquid | 1,991 | comment_to_fix | Introduce `:rigid` parsing mode | [nit]
```suggestion
@alias_name = if p.id?("as")
alias_name = p.consume(:id)
end
``` | 1c1e7119065b0fa915149b9e2bdc303490a0dfff | 462a8b28cd02f287141b7904c8edaec2122ee324 | diff --git a/lib/liquid/tags/include.rb b/lib/liquid/tags/include.rb
index 1fefa16f4..5b2aaa432 100644
--- a/lib/liquid/tags/include.rb
+++ b/lib/liquid/tags/include.rb
@@ -27,24 +27,7 @@ class Include < Tag
def initialize(tag_name, markup, options)
super
-
- if markup =~ SYNTAX
-
- template_n... | [
"lib/liquid/tags/include.rb"
] | [
{
"comment": "[nit]\r\n```suggestion\r\n @alias_name = if p.id?(\"as\")\r\n alias_name = p.consume(:id)\r\n end\r\n```",
"path": "lib/liquid/tags/include.rb",
"hunk": "@@ -101,6 +84,61 @@ def render_to_output_buffer(context, output)\n alias_method :parse_context, :options\n priv... | true | ||
Shopify/liquid | 1,991 | comment_to_fix | Introduce `:rigid` parsing mode | [nit] do we need to consume this? | 1c1e7119065b0fa915149b9e2bdc303490a0dfff | 462a8b28cd02f287141b7904c8edaec2122ee324 | diff --git a/lib/liquid/tags/cycle.rb b/lib/liquid/tags/cycle.rb
index c2d94d5f4..7e17a9662 100644
--- a/lib/liquid/tags/cycle.rb
+++ b/lib/liquid/tags/cycle.rb
@@ -17,23 +17,13 @@ module Liquid
class Cycle < Tag
SimpleSyntax = /\A#{QuotedFragment}+/o
NamedSyntax = /\A(#{QuotedFragment})\s*\:\s*(.*)/om
+ ... | [
"lib/liquid/tags/cycle.rb"
] | [
{
"comment": "[nit] do we need to consume this?",
"path": "lib/liquid/tags/cycle.rb",
"hunk": "@@ -65,19 +54,82 @@ def render_to_output_buffer(context, output)\n \n private\n \n+ # cycle [name:] expression(, expression)*\n+ def rigid_parse(markup)\n+ p = @parse_context.new_parser(markup)\... | true | ||
Shopify/liquid | 1,991 | comment_to_fix | Introduce `:rigid` parsing mode | [nit] We should create a constant regex variable | 1c1e7119065b0fa915149b9e2bdc303490a0dfff | 462a8b28cd02f287141b7904c8edaec2122ee324 | diff --git a/lib/liquid/tags/cycle.rb b/lib/liquid/tags/cycle.rb
index c2d94d5f4..7e17a9662 100644
--- a/lib/liquid/tags/cycle.rb
+++ b/lib/liquid/tags/cycle.rb
@@ -17,23 +17,13 @@ module Liquid
class Cycle < Tag
SimpleSyntax = /\A#{QuotedFragment}+/o
NamedSyntax = /\A(#{QuotedFragment})\s*\:\s*(.*)/om
+ ... | [
"lib/liquid/tags/cycle.rb"
] | [
{
"comment": "[nit] We should create a constant regex variable",
"path": "lib/liquid/tags/cycle.rb",
"hunk": "@@ -65,19 +54,82 @@ def render_to_output_buffer(context, output)\n \n private\n \n+ # cycle [name:] expression(, expression)*\n+ def rigid_parse(markup)\n+ p = @parse_context.new_... | true | ||
Shopify/liquid | 1,991 | comment_to_fix | Introduce `:rigid` parsing mode | [nit] Shouldn't rubocop have caught this empty line 🤔
```suggestion
``` | 1c1e7119065b0fa915149b9e2bdc303490a0dfff | 462a8b28cd02f287141b7904c8edaec2122ee324 | diff --git a/lib/liquid/tags/include.rb b/lib/liquid/tags/include.rb
index 1fefa16f4..5b2aaa432 100644
--- a/lib/liquid/tags/include.rb
+++ b/lib/liquid/tags/include.rb
@@ -27,24 +27,7 @@ class Include < Tag
def initialize(tag_name, markup, options)
super
-
- if markup =~ SYNTAX
-
- template_n... | [
"lib/liquid/tags/include.rb"
] | [
{
"comment": "[nit] Shouldn't rubocop have caught this empty line 🤔 \r\n```suggestion\r\n```",
"path": "lib/liquid/tags/include.rb",
"hunk": "@@ -101,6 +84,61 @@ def render_to_output_buffer(context, output)\n alias_method :parse_context, :options\n private :parse_context\n \n+ def rigid_pars... | true | ||
Shopify/liquid | 1,991 | comment_to_fix | Introduce `:rigid` parsing mode | ```suggestion
Liquid also comes with different parsers that can be used when editing templates to give better error messages
``` | 1c1e7119065b0fa915149b9e2bdc303490a0dfff | 462a8b28cd02f287141b7904c8edaec2122ee324 | diff --git a/README.md b/README.md
index 3734a290f..34884464d 100644
--- a/README.md
+++ b/README.md
@@ -99,14 +99,14 @@ Setting the error mode of Liquid lets you specify how strictly you want your tem
Normally the parser is very lax and will accept almost anything without error. Unfortunately this can make
it very h... | [
"README.md"
] | [
{
"comment": "```suggestion\nLiquid also comes with different parsers that can be used when editing templates to give better error messages\n```",
"path": "README.md",
"hunk": "@@ -99,14 +99,14 @@ Setting the error mode of Liquid lets you specify how strictly you want your tem\n Normally the parser is v... | true | ||
Shopify/liquid | 1,991 | comment_to_fix | Introduce `:rigid` parsing mode | Not 100% sold on the value of these tests since `Condition` doesn't actually implement this behavior itself. I'm not opposed to leaving it in but not sure if it's actually testing something. | 1c1e7119065b0fa915149b9e2bdc303490a0dfff | 462a8b28cd02f287141b7904c8edaec2122ee324 | diff --git a/test/unit/condition_unit_test.rb b/test/unit/condition_unit_test.rb
index acc71dc4e..f5206ff53 100644
--- a/test/unit/condition_unit_test.rb
+++ b/test/unit/condition_unit_test.rb
@@ -166,6 +166,37 @@ def test_default_context_is_deprecated
assert_includes(err.lines.map(&:strip), expected)
end
+ ... | [
"test/unit/condition_unit_test.rb"
] | [
{
"comment": "Not 100% sold on the value of these tests since `Condition` doesn't actually implement this behavior itself. I'm not opposed to leaving it in but not sure if it's actually testing something.",
"path": "test/unit/condition_unit_test.rb",
"hunk": "@@ -166,6 +166,37 @@ def test_default_contex... | true | ||
Shopify/liquid | 1,991 | comment_to_fix | Introduce `:rigid` parsing mode | nit
```suggestion
``` | 1c1e7119065b0fa915149b9e2bdc303490a0dfff | 462a8b28cd02f287141b7904c8edaec2122ee324 | diff --git a/test/integration/tags/table_row_test.rb b/test/integration/tags/table_row_test.rb
index ddc0877df..44cdcdd99 100644
--- a/test/integration/tags/table_row_test.rb
+++ b/test/integration/tags/table_row_test.rb
@@ -138,7 +138,7 @@ def test_nil_offset_is_treated_as_zero
def test_tablerow_loop_drop_attribu... | [
"test/integration/tags/table_row_test.rb"
] | [
{
"comment": "nit\n```suggestion\n```",
"path": "test/integration/tags/table_row_test.rb",
"hunk": "@@ -255,4 +258,212 @@ def test_table_row_does_not_leak_interrupts\n template,\n )\n end\n+\n+ def test_tablerow_with_cols_attribute_in_rigid_mode\n+ template = <<~LIQUID.chomp\n+ {% t... | true | ||
Shopify/liquid | 1,991 | comment_to_fix | Introduce `:rigid` parsing mode | Should we add some explicit tests for the mixed case? | 1c1e7119065b0fa915149b9e2bdc303490a0dfff | 462a8b28cd02f287141b7904c8edaec2122ee324 | diff --git a/lib/liquid/variable.rb b/lib/liquid/variable.rb
index 209570654..3fd947a7d 100644
--- a/lib/liquid/variable.rb
+++ b/lib/liquid/variable.rb
@@ -54,7 +54,7 @@ def lax_parse(markup)
next unless f =~ /\w+/
filtername = Regexp.last_match(0)
filterargs = f.scan(FilterArgsRegex).... | [
"lib/liquid/variable.rb"
] | [
{
"comment": "Should we add some explicit tests for the mixed case?",
"path": "lib/liquid/variable.rb",
"hunk": "@@ -138,6 +149,46 @@ def parse_filter_expressions(filter_name, unparsed_args)\n result\n end\n \n+ # Surprisingly, positional and keyword arguments can be mixed.",
"resolving... | true | ||
Shopify/liquid | 1,995 | issue_to_patch | avoid new regex allocation in util functions | Avoid allocating new regex object on `Utils#to_date` and `Utils#to_number` | 9942592ea859c13a034fc011a821a670122496b9 | b5b36665e618935ea796d7c108dbe1fc1734cdbe | diff --git a/lib/liquid/utils.rb b/lib/liquid/utils.rb
index a75b9fa37..2bdb0c521 100644
--- a/lib/liquid/utils.rb
+++ b/lib/liquid/utils.rb
@@ -2,6 +2,9 @@
module Liquid
module Utils
+ DECIMAL_REGEX = /\A-?\d+\.\d+\z/
+ UNIX_TIMESTAMP_REGEX = /\A\d+\z/
+
def self.slice_collection(collection, from, to)... | [
"lib/liquid/utils.rb"
] | [
{
"comment": "Would it be worth `.freeze`ing these?",
"path": "lib/liquid/utils.rb",
"hunk": "@@ -2,6 +2,9 @@\n \n module Liquid\n module Utils\n+ DECIMAL_REGEX = /\\A-?\\d+\\.\\d+\\z/",
"resolving_sha": "b5b36665e618935ea796d7c108dbe1fc1734cdbe",
"resolving_diff": "diff --git a/lib/liquid/... | true | ||
Shopify/liquid | 1,984 | issue_to_patch | Update liquid docs for loop's named params | Checked the docs, those are named params:
https://shopify.dev/docs/api/liquid/tags/for
https://shopify.dev/docs/api/liquid/tags/tablerow | 8ad91b5e3688a70bdc9246b0cee488d7c1cb4975 | 786381c762031db5cec030df172311911492740b | diff --git a/lib/liquid/tags/for.rb b/lib/liquid/tags/for.rb
index 27af15bf1..6aa308f1c 100644
--- a/lib/liquid/tags/for.rb
+++ b/lib/liquid/tags/for.rb
@@ -20,8 +20,8 @@ module Liquid
# @liquid_syntax_keyword variable The current item in the array.
# @liquid_syntax_keyword array The array to iterate over.
# @... | [
"lib/liquid/tags/for.rb",
"lib/liquid/tags/table_row.rb"
] | [] | true | ||
Shopify/liquid | 1,952 | issue_to_patch | template.rb: Correct typo in docs | ea864f11771f626b1147e0c83bbfb57f333865ad | aefd48e34141ee534edec16d148d7feeb117094d | diff --git a/lib/liquid/template.rb b/lib/liquid/template.rb
index 9fb4089a4..a6d80e0ae 100644
--- a/lib/liquid/template.rb
+++ b/lib/liquid/template.rb
@@ -2,7 +2,7 @@
module Liquid
# Templates are central to liquid.
- # Interpretating templates is a two step process. First you compile the
+ # Interpreting tem... | [
"lib/liquid/template.rb"
] | [] | true | |||
Shopify/liquid | 1,968 | issue_to_patch | Inline some information that previously lived at category level | https://github.com/Shopify/shopify-dev/issues/57754
Inline some information that previously lived at category level in the [shopify.dev Liquid docs](https://shopify.dev/docs/api/liquid). | 9bd408f5d027f09164b9ff967e2554a13827ce33 | 8555fd8a2012aafe88978ce68e03b7c84d418309 | diff --git a/lib/liquid/tags/assign.rb b/lib/liquid/tags/assign.rb
index 702831781..4743ab0b8 100644
--- a/lib/liquid/tags/assign.rb
+++ b/lib/liquid/tags/assign.rb
@@ -9,6 +9,10 @@ module Liquid
# Creates a new variable.
# @liquid_description
# You can create variables of any [basic type](/docs/api/liquid... | [
"lib/liquid/tags/assign.rb",
"lib/liquid/tags/capture.rb",
"lib/liquid/tags/decrement.rb",
"lib/liquid/tags/increment.rb"
] | [] | true | ||
Shopify/liquid | 1,965 | issue_to_patch | Bump Liquid to 5.8.7 | Bumping Liquid to 5.8.7 to include https://github.com/Shopify/liquid/pull/1954 in the latest release | aebd75e5e865a5136f5a49f70bfbf22f11e86c18 | 79b831d96cff319afb693e2775dcb202d8dec9bb | diff --git a/History.md b/History.md
index ccb885a69..3d979dc14 100644
--- a/History.md
+++ b/History.md
@@ -1,6 +1,7 @@
# Liquid Change Log
-## 5.8.1 (unreleased)
+## 5.8.7
+* Expose body content in the `Doc` tag [James Meng]
## 5.8.1
diff --git a/lib/liquid/version.rb b/lib/liquid/version.rb
index f1d61adad..... | [
"History.md",
"lib/liquid/version.rb"
] | [] | true | ||
Shopify/liquid | 1,954 | issue_to_patch | Expose tag body in the Doc tag | Closes https://github.com/Shopify/developer-tools-team/issues/686
## Summary
- Modify the Doc tag to expose its `body` content as this was previously ignored as a raw tag | fc96e66e1415726196e3d460ad0cc96c83ce95cd | 7f2f8a226b013d7fe8abb140f2dea83405ca6623 | diff --git a/lib/liquid/tags/doc.rb b/lib/liquid/tags/doc.rb
index 2138b641d..499102d72 100644
--- a/lib/liquid/tags/doc.rb
+++ b/lib/liquid/tags/doc.rb
@@ -36,6 +36,8 @@ def initialize(tag_name, markup, parse_context)
end
def parse(tokens)
+ @body = +""
+
while (token = tokens.shift)
t... | [
"lib/liquid/tags/doc.rb",
"test/unit/tags/doc_tag_unit_test.rb"
] | [
{
"comment": "Should we set `@body` to an empty string in `initialize`? It feels weird to have an attr_reader on something that doesn't exist until `parse` gets run.",
"path": "lib/liquid/tags/doc.rb",
"hunk": "@@ -31,21 +31,26 @@ module Liquid\n class Doc < Block\n NO_UNEXPECTED_ARGS = /\\A\\s*\\... | diff --git a/test/unit/tags/doc_tag_unit_test.rb b/test/unit/tags/doc_tag_unit_test.rb
index a0a366295..223f3ca0d 100644
--- a/test/unit/tags/doc_tag_unit_test.rb
+++ b/test/unit/tags/doc_tag_unit_test.rb
@@ -20,6 +20,21 @@ def test_doc_tag
assert_template_result('', template)
end
+ def test_doc_tag_body_con... | true | |
Shopify/liquid | 1,953 | issue_to_patch | Pin GitHub Actions to commit | This is an automated PR to update actions in this repo. The operation should be no-op, as we are only switching out the version tag with the matching commit SHA.
To align with industry best practices, we are going to pin Github Actions to a specific commit SHA.
To read more about why pinning actions is recommended c... | ea864f11771f626b1147e0c83bbfb57f333865ad | 6b3f6c6fb43a6ae5dd2481f4b86dc437d0136c4c | diff --git a/.github/dependabot.yaml b/.github/dependabot.yaml
new file mode 100644
index 000000000..c75e875a0
--- /dev/null
+++ b/.github/dependabot.yaml
@@ -0,0 +1,6 @@
+version: 2
+updates:
+ - package-ecosystem: github-actions
+ directory: "/"
+ schedule:
+ interval: weekly
diff --git a/.github/workflow... | [
".github/dependabot.yaml",
".github/workflows/liquid.yml"
] | [] | true | ||
Shopify/liquid | 1,960 | issue_to_patch | Add unit test for custom Liquid tag registration | Adds EnvironmentTest to verify custom tag registration and rendering.
cc: #1959 | c6f05eaf832dd8f9461e7544682d9cf04dfb029a | 4398f037f5841c8aaf48d71c675926c86e07e350 | [
"test/unit/environment_test.rb"
] | [] | diff --git a/test/unit/environment_test.rb b/test/unit/environment_test.rb
new file mode 100644
index 000000000..e989dc9bc
--- /dev/null
+++ b/test/unit/environment_test.rb
@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+require 'test_helper'
+
+class EnvironmentTest < Minitest::Test
+ include Liquid
+
+ class Uns... | true | ||
Shopify/liquid | 1,955 | issue_to_patch | Remove {{ foo }} and {{ bar }} from `doc` tag description | Simply removes the `# {{ foo }}, {{ bar }}!` excerpt at the end of the description | ea864f11771f626b1147e0c83bbfb57f333865ad | eabbd5cb6fe3786d084d90cdec1e2823f4669d26 | diff --git a/lib/liquid/tags/doc.rb b/lib/liquid/tags/doc.rb
index ef5d5d801..2138b641d 100644
--- a/lib/liquid/tags/doc.rb
+++ b/lib/liquid/tags/doc.rb
@@ -27,7 +27,6 @@ module Liquid
# @example
# {% render 'message', foo: 'Hello', bar: 'World' %}
# {% enddoc %}
- # {{ foo }}, {{ bar }}!
class... | [
"lib/liquid/tags/doc.rb"
] | [] | true | ||
Shopify/liquid | 1,951 | issue_to_patch | Fully revert calling to_s on filter array | follow up to https://github.com/Shopify/liquid/pull/1943 | cc04892e546422fa2a903d797a65cde25a3c0842 | c34dd812c5a8031dfa13a44b4130f4564ca70757 | diff --git a/lib/liquid/standardfilters.rb b/lib/liquid/standardfilters.rb
index 7359062ea..6e072fcf5 100644
--- a/lib/liquid/standardfilters.rb
+++ b/lib/liquid/standardfilters.rb
@@ -982,8 +982,6 @@ def filter_array(input, property, target_value, default_value = [], &block)
return default_value if ary.empty?... | [
"lib/liquid/standardfilters.rb",
"lib/liquid/version.rb",
"test/integration/standard_filter_test.rb"
] | [] | diff --git a/test/integration/standard_filter_test.rb b/test/integration/standard_filter_test.rb
index 6b931de59..e1370fae1 100644
--- a/test/integration/standard_filter_test.rb
+++ b/test/integration/standard_filter_test.rb
@@ -1054,10 +1054,11 @@ def test_where_with_empty_string_is_a_no_op
def test_where_with_ni... | true | |
Shopify/liquid | 1,948 | issue_to_patch | Use to_liquid_value in uniq filter | Update the `uniq` filter to use `to_liquid_value` for more consistent comparison in line with other array filters. | 2b75bfaff412c23c9b9434a11eafcef869d89c17 | d307919c70bdee89bdce465454b3aa10895e8cec | diff --git a/lib/liquid/standardfilters.rb b/lib/liquid/standardfilters.rb
index 4d69f5bc3..daa2c5806 100644
--- a/lib/liquid/standardfilters.rb
+++ b/lib/liquid/standardfilters.rb
@@ -1081,7 +1081,10 @@ def reverse
end
def uniq(&block)
- to_a.uniq(&block)
+ to_a.uniq do |item|
+ ... | [
"lib/liquid/standardfilters.rb",
"lib/liquid/version.rb",
"test/integration/standard_filter_test.rb",
"test/test_helper.rb"
] | [] | diff --git a/test/integration/standard_filter_test.rb b/test/integration/standard_filter_test.rb
index ddf66333f..6a2737bba 100644
--- a/test/integration/standard_filter_test.rb
+++ b/test/integration/standard_filter_test.rb
@@ -1340,6 +1340,22 @@ def test_sum_with_non_string_property
assert_equal(0, @filters.sum(... | true | |
Shopify/liquid | 1,944 | issue_to_patch | Fix regression when using empty/nil properties with array filters | Fixed a regression where empty properties like `{{ array | where: '' }}` would return an empty array. Now both empty strings and nil properties act as no-ops, simply returning the original array. This makes the library more forgiving when properties are missing or blank, reducing unexpected errors in your templates. | 87bc6e7cfaf61833b32b51190eeacfb516c0fea0 | 19e287dda27ac38ad28c0c53f661def3ce331297 | diff --git a/lib/liquid/standardfilters.rb b/lib/liquid/standardfilters.rb
index 4771b2427..4d69f5bc3 100644
--- a/lib/liquid/standardfilters.rb
+++ b/lib/liquid/standardfilters.rb
@@ -3,7 +3,6 @@
require 'cgi'
require 'base64'
require 'bigdecimal'
-
module Liquid
module StandardFilters
MAX_I32 = (1 << 31) ... | [
"lib/liquid/standardfilters.rb",
"lib/liquid/version.rb",
"test/integration/standard_filter_test.rb"
] | [] | diff --git a/test/integration/standard_filter_test.rb b/test/integration/standard_filter_test.rb
index 5c80fe3ce..ddf66333f 100644
--- a/test/integration/standard_filter_test.rb
+++ b/test/integration/standard_filter_test.rb
@@ -560,15 +560,47 @@ def test_map_returns_empty_on_2d_input_array
end
end
- def tes... | true | |
Shopify/liquid | 1,895 | issue_to_patch | Add support to LiquidDoc with the new `{% doc %}` tag | This PR implements [RFC#1865](https://github.com/Shopify/liquid/discussions/1865) and introduces support for the new `{% doc %}` tag, which will be used to document elements of Liquid templates, primarily snippets.
Snippets are the primary method for reusing logic in Liquid. However, their weak interfaces make it ea... | da4afd4156e6228e02107b79d36f42b81fee2aee | cae1041ee26418f0b8d62d8fd8a16cf989bef6e8 | diff --git a/lib/liquid/locales/en.yml b/lib/liquid/locales/en.yml
index f33c61cec..cd1607b3c 100644
--- a/lib/liquid/locales/en.yml
+++ b/lib/liquid/locales/en.yml
@@ -2,12 +2,14 @@
errors:
syntax:
tag_unexpected_args: "Syntax Error in '%{tag}' - Valid syntax: %{tag}"
+ block_tag_unexpected_args: "... | [
"lib/liquid/locales/en.yml",
"lib/liquid/tags.rb",
"lib/liquid/tags/doc.rb",
"test/unit/block_unit_test.rb",
"test/unit/tags/doc_tag_unit_test.rb"
] | [
{
"comment": "One of the weird things about comment is that you can nest them. Do we really want similar behaviour for doc? I don't think we do 🤔? ",
"path": "lib/liquid/tags/doc.rb",
"hunk": "@@ -0,0 +1,30 @@\n+# frozen_string_literal: true\n+\n+module Liquid\n+ # @liquid_public_docs\n+ # @liquid_ty... | diff --git a/test/unit/block_unit_test.rb b/test/unit/block_unit_test.rb
index f28c30e16..cfaf3f663 100644
--- a/test/unit/block_unit_test.rb
+++ b/test/unit/block_unit_test.rb
@@ -47,12 +47,18 @@ def test_variable_many_embedded_fragments
)
end
- def test_with_block
+ def test_comment_tag_with_block
te... | true | |
Shopify/liquid | 1,895 | comment_to_fix | Add support to LiquidDoc with the new `{% doc %}` tag | One of the weird things about comment is that you can nest them. Do we really want similar behaviour for doc? I don't think we do 🤔? | da4afd4156e6228e02107b79d36f42b81fee2aee | cae1041ee26418f0b8d62d8fd8a16cf989bef6e8 | diff --git a/lib/liquid/tags/doc.rb b/lib/liquid/tags/doc.rb
new file mode 100644
index 000000000..f2c299dd7
--- /dev/null
+++ b/lib/liquid/tags/doc.rb
@@ -0,0 +1,70 @@
+# frozen_string_literal: true
+
+module Liquid
+ # @liquid_public_docs
+ # @liquid_type tag
+ # @liquid_category syntax
+ # @liquid_name doc
+ # ... | [
"lib/liquid/tags/doc.rb"
] | [
{
"comment": "One of the weird things about comment is that you can nest them. Do we really want similar behaviour for doc? I don't think we do 🤔? ",
"path": "lib/liquid/tags/doc.rb",
"hunk": "@@ -0,0 +1,30 @@\n+# frozen_string_literal: true\n+\n+module Liquid\n+ # @liquid_public_docs\n+ # @liquid_ty... | true | ||
Shopify/liquid | 1,869 | issue_to_patch | Add `find`, `find_index`, `has`, and `reject` filters to arrays | This PR implements the [RFC#1864](https://github.com/Shopify/liquid/discussions/1864) and introduces support for the `find`, `find_index`, `has`, and `reject` filters into the Liquid Array API.
```liquid
{% assign product = products | find: 'price_unit', 'BRL' %}
```
For the sake of consistency, multi-level acc... | fdd8c714b203f1378356a8ae57edb92fca447991 | 2186981c061814cce28f390c1bcbaad1e1b65ecc | diff --git a/lib/liquid/standardfilters.rb b/lib/liquid/standardfilters.rb
index ffaceb32f..fa506f91c 100644
--- a/lib/liquid/standardfilters.rb
+++ b/lib/liquid/standardfilters.rb
@@ -378,7 +378,7 @@ def sort(input, property = nil)
end
elsif ary.all? { |el| el.respond_to?(:[]) }
begin
- ... | [
"lib/liquid/standardfilters.rb",
"test/integration/standard_filter_test.rb"
] | [
{
"comment": "```suggestion\r\n def get_property(drop, property_or_keys)\r\n```\r\n\r\nI would probably name this method `get_`. My understanding of the wording, is that get is internal, and fetch is external.\r\n\r\n[Other languages](https://laravel.com/docs/11.x/helpers) also use `get` for this kind of thi... | diff --git a/test/integration/standard_filter_test.rb b/test/integration/standard_filter_test.rb
index eae4a1c9c..e4eb3bec6 100644
--- a/test/integration/standard_filter_test.rb
+++ b/test/integration/standard_filter_test.rb
@@ -54,6 +54,30 @@ def each(&block)
end
end
+class TestDeepEnumerable < Liquid::Drop
+ i... | true | |
Shopify/liquid | 1,869 | comment_to_fix | Add `find`, `find_index`, `has`, and `reject` filters to arrays | ```suggestion
def get_property(drop, property_or_keys)
```
I would probably name this method `get_`. My understanding of the wording, is that get is internal, and fetch is external.
[Other languages](https://laravel.com/docs/11.x/helpers) also use `get` for this kind of thing. | fdd8c714b203f1378356a8ae57edb92fca447991 | 2186981c061814cce28f390c1bcbaad1e1b65ecc | diff --git a/lib/liquid/standardfilters.rb b/lib/liquid/standardfilters.rb
index ffaceb32f..fa506f91c 100644
--- a/lib/liquid/standardfilters.rb
+++ b/lib/liquid/standardfilters.rb
@@ -378,7 +378,7 @@ def sort(input, property = nil)
end
elsif ary.all? { |el| el.respond_to?(:[]) }
begin
- ... | [
"lib/liquid/standardfilters.rb"
] | [
{
"comment": "```suggestion\r\n def get_property(drop, property_or_keys)\r\n```\r\n\r\nI would probably name this method `get_`. My understanding of the wording, is that get is internal, and fetch is external.\r\n\r\n[Other languages](https://laravel.com/docs/11.x/helpers) also use `get` for this kind of thi... | true | ||
Shopify/liquid | 1,869 | comment_to_fix | Add `find`, `find_index`, `has`, and `reject` filters to arrays | Without providing an associated value, the following test cases currently pass. Is this intended behaviour? The situation is similar for other filters that use `filter_array()`.
```ruby
def test_find_index_without_target_value
products = [
{ "title" => "Pro goggles", "price" => 1299 },
{ "titl... | fdd8c714b203f1378356a8ae57edb92fca447991 | 2186981c061814cce28f390c1bcbaad1e1b65ecc | diff --git a/lib/liquid/standardfilters.rb b/lib/liquid/standardfilters.rb
index ffaceb32f..fa506f91c 100644
--- a/lib/liquid/standardfilters.rb
+++ b/lib/liquid/standardfilters.rb
@@ -378,7 +378,7 @@ def sort(input, property = nil)
end
elsif ary.all? { |el| el.respond_to?(:[]) }
begin
- ... | [
"lib/liquid/standardfilters.rb"
] | [
{
"comment": "Without providing an associated value, the following test cases currently pass. Is this intended behaviour? The situation is similar for other filters that use `filter_array()`.\r\n\r\n```ruby\r\ndef test_find_index_without_target_value\r\n products = [\r\n { \"title\" => \"Pro goggles\", ... | true | ||
Shopify/liquid | 1,869 | comment_to_fix | Add `find`, `find_index`, `has`, and `reject` filters to arrays | The PR description says "new filters support multi-level access to drops", and this method names its first argument `drop`, but `fetch_property` does work on hashes too, or anything that responds to `:[]` with a string key. For example, this test case passes.
(I'm assuming `drop` is any class inheriting from `Liquid... | fdd8c714b203f1378356a8ae57edb92fca447991 | 2186981c061814cce28f390c1bcbaad1e1b65ecc | diff --git a/lib/liquid/standardfilters.rb b/lib/liquid/standardfilters.rb
index ffaceb32f..fa506f91c 100644
--- a/lib/liquid/standardfilters.rb
+++ b/lib/liquid/standardfilters.rb
@@ -378,7 +378,7 @@ def sort(input, property = nil)
end
elsif ary.all? { |el| el.respond_to?(:[]) }
begin
- ... | [
"lib/liquid/standardfilters.rb"
] | [
{
"comment": "The PR description says \"new filters support multi-level access to drops\", and this method names its first argument `drop`, but `fetch_property` does work on hashes too, or anything that responds to `:[]` with a string key. For example, this test case passes.\r\n\r\n(I'm assuming `drop` is any c... | true | ||
Shopify/liquid | 1,869 | comment_to_fix | Add `find`, `find_index`, `has`, and `reject` filters to arrays | I don't know how much we care in this context, but isn't that a lot of work for potentially "hot" code to be doing for cases that don't have the `.` in it? Should we consider doing an early return if the string property doesn't have a `.` in it to at least make it run about as fast as `[]`?
Or am I tripping and thi... | fdd8c714b203f1378356a8ae57edb92fca447991 | 2186981c061814cce28f390c1bcbaad1e1b65ecc | diff --git a/lib/liquid/standardfilters.rb b/lib/liquid/standardfilters.rb
index ffaceb32f..fa506f91c 100644
--- a/lib/liquid/standardfilters.rb
+++ b/lib/liquid/standardfilters.rb
@@ -378,7 +378,7 @@ def sort(input, property = nil)
end
elsif ary.all? { |el| el.respond_to?(:[]) }
begin
- ... | [
"lib/liquid/standardfilters.rb"
] | [
{
"comment": "I don't know how much we care in this context, but isn't that a lot of work for potentially \"hot\" code to be doing for cases that don't have the `.` in it? Should we consider doing an early return if the string property doesn't have a `.` in it to at least make it run about as fast as `[]`? \r\n... | true | ||
Shopify/liquid | 1,940 | issue_to_patch | Update snippet URLs in documentation links to point to newly created snippet page | Updates `architecture#snippets` links to point to the newly created `architecture/snippets` page, which contains more detailed information than the previous link
This is related to the LiquidDoc project in [Vault](https://vault.shopify.io/gsd/projects/44310-Internal-Dev-Tools-LiquidDoc)
The new pages reference... | aa1640035f172bcbd064959d8e7d00aac07243d7 | 7f122aeed2890e860e95c2ba3e809b4c88f9887b | diff --git a/lib/liquid/tags/decrement.rb b/lib/liquid/tags/decrement.rb
index 677166621..49d43bc62 100644
--- a/lib/liquid/tags/decrement.rb
+++ b/lib/liquid/tags/decrement.rb
@@ -10,7 +10,7 @@ module Liquid
# @liquid_description
# Variables that are declared with `decrement` are unique to the [layout](/themes... | [
"lib/liquid/tags/decrement.rb",
"lib/liquid/tags/include.rb",
"lib/liquid/tags/increment.rb",
"lib/liquid/tags/render.rb"
] | [] | true | ||
Shopify/liquid | 1,154 | issue_to_patch | Enabled frozen string literals | @dylanahsmith @pushrax @fw42 @ashmaroli | 9a42c8c8b237cba60266a7877fb245869640b3c6 | a2814443bbe30c368d5a44ae2bbc9a440c9d47e7 | diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 83ced97aa..127162899 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -84,13 +84,6 @@ Style/DateTime:
Exclude:
- 'test/unit/context_unit_test.rb'
-# Offense count: 119
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
... | [
".rubocop_todo.yml",
"Gemfile",
"Rakefile",
"example/server/example_servlet.rb",
"example/server/liquid_servlet.rb",
"example/server/server.rb",
"lib/liquid.rb",
"lib/liquid/block.rb",
"lib/liquid/block_body.rb",
"lib/liquid/condition.rb",
"lib/liquid/context.rb",
"lib/liquid/document.rb",
"... | [
{
"comment": "I'm not sure if this is the best approach. This means frozen strings will fail if passed in to `render_to_output_buffer`. The other option is to allow frozen strings to be passed in and `render_to_output_buffer` does the unfreezing",
"path": "lib/liquid/block_body.rb",
"hunk": "@@ -113,7 +... | diff --git a/test/integration/assign_test.rb b/test/integration/assign_test.rb
index 550228999..ffcb8a3f0 100644
--- a/test/integration/assign_test.rb
+++ b/test/integration/assign_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
require 'test_helper'
class AssignTest < Minitest::Test
diff --git a/test/inte... | true | |
Shopify/liquid | 1,154 | comment_to_fix | Enabled frozen string literals | ?? | 9a42c8c8b237cba60266a7877fb245869640b3c6 | a2814443bbe30c368d5a44ae2bbc9a440c9d47e7 | diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml
index 83ced97aa..127162899 100644
--- a/.rubocop_todo.yml
+++ b/.rubocop_todo.yml
@@ -84,13 +84,6 @@ Style/DateTime:
Exclude:
- 'test/unit/context_unit_test.rb'
-# Offense count: 119
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
... | [
".rubocop_todo.yml"
] | [
{
"comment": "??",
"path": ".rubocop_todo.yml",
"hunk": "@@ -83,14 +83,7 @@ Style/ClassVars:\n Style/DateTime:\n Exclude:\n - 'test/unit/context_unit_test.rb'\n-\n-# Offense count: 119\n-# Cop supports --auto-correct.\n-# Configuration parameters: EnforcedStyle.\n-# SupportedStyles: always, never\... | true | ||
Shopify/liquid | 1,154 | comment_to_fix | Enabled frozen string literals | ```suggestion
"catchall_method: #{method}"
``` | 9a42c8c8b237cba60266a7877fb245869640b3c6 | a2814443bbe30c368d5a44ae2bbc9a440c9d47e7 | diff --git a/test/integration/drop_test.rb b/test/integration/drop_test.rb
index 9294b2ffc..6069713de 100644
--- a/test/integration/drop_test.rb
+++ b/test/integration/drop_test.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
require 'test_helper'
class ContextDrop < Liquid::Drop
@@ -31,7 +33,7 @@ def text
... | [
"test/integration/drop_test.rb"
] | [
{
"comment": "```suggestion\r\n \"catchall_method: #{method}\"\r\n```",
"path": "test/integration/drop_test.rb",
"hunk": "@@ -31,7 +33,7 @@ def text\n \n class CatchallDrop < Liquid::Drop\n def liquid_method_missing(method)\n- 'catchall_method: ' << method.to_s\n+ +'catchall_method:... | true | ||
Shopify/liquid | 1,844 | issue_to_patch | Faster Expression parser / Tokenizer with StringScanner | # Faster Tokenizer & Expression Parser
Inspired by @tenderlove 's [Rails World 2024 Closing Keynote](https://www.youtube.com/watch?v=ZE6F3drGhA8) and
@ianks 's https://github.com/Shopify/liquid/pull/1832 PR ❤️
This PR updates the `Expression` Parser and `Tokenizer` to use the new `StringScanner` to improve the pe... | b4667adadff0b648b33678d5db958e59b59c7f80 | 10114b333eac9e46454e335dea9a6ba906552630 | diff --git a/Gemfile b/Gemfile
index 013b1700a..fd9d00b02 100644
--- a/Gemfile
+++ b/Gemfile
@@ -13,6 +13,7 @@ group :benchmark, :test do
gem 'benchmark-ips'
gem 'memory_profiler'
gem 'terminal-table'
+ gem "lru_redux"
install_if -> { RUBY_PLATFORM !~ /mingw|mswin|java/ && RUBY_ENGINE != 'truffleruby' } ... | [
"Gemfile",
"Rakefile",
"lib/liquid.rb",
"lib/liquid/context.rb",
"lib/liquid/expression.rb",
"lib/liquid/lexer.rb",
"lib/liquid/parse_context.rb",
"lib/liquid/parser.rb",
"lib/liquid/range_lookup.rb",
"lib/liquid/tags/cycle.rb",
"lib/liquid/tags/for.rb",
"lib/liquid/tags/if.rb",
"lib/liquid/... | [
{
"comment": "It seems like it might be possible to make this method faster by _not_ using string scanner and manually iterating over the bytes in the string. It looks like `markup` is a string and we're just setting it on the string scanner.\r\n\r\nJust as a rough outline, something like this:\r\n\r\n```ruby\... | diff --git a/test/integration/expression_test.rb b/test/integration/expression_test.rb
index 80f6f4173..0eef5dc9d 100644
--- a/test/integration/expression_test.rb
+++ b/test/integration/expression_test.rb
@@ -1,6 +1,7 @@
# frozen_string_literal: true
require 'test_helper'
+require 'lru_redux'
class ExpressionTes... | true | |
Shopify/liquid | 1,844 | comment_to_fix | Faster Expression parser / Tokenizer with StringScanner | Why default to empty? Wouldn't you want:
```suggestion
def tokenize(input, ss = StringScanner.new(input))
``` | b4667adadff0b648b33678d5db958e59b59c7f80 | 10114b333eac9e46454e335dea9a6ba906552630 | diff --git a/lib/liquid/lexer.rb b/lib/liquid/lexer.rb
index b9e5443c1..b28e87842 100644
--- a/lib/liquid/lexer.rb
+++ b/lib/liquid/lexer.rb
@@ -1,66 +1,7 @@
# frozen_string_literal: true
-require "strscan"
-
module Liquid
- class Lexer1
- SPECIALS = {
- '|' => :pipe,
- '.' => :dot,
- ':' => :col... | [
"lib/liquid/lexer.rb"
] | [
{
"comment": "Why default to empty? Wouldn't you want:\r\n\r\n```suggestion\r\n def tokenize(input, ss = StringScanner.new(input))\r\n```",
"path": "lib/liquid/lexer.rb",
"hunk": "@@ -25,38 +25,37 @@ class Lexer1\n COMPARISON_OPERATOR = /==|!=|<>|<=?|>=?|contains(?=\\s)/\n WHITESPACE_OR_N... | true | ||
Shopify/liquid | 1,844 | comment_to_fix | Faster Expression parser / Tokenizer with StringScanner | We should freeze anything put in the cache IMO
```suggestion
cache[markup] = inner_parse(markup, ss, cache).freeze
``` | b4667adadff0b648b33678d5db958e59b59c7f80 | 10114b333eac9e46454e335dea9a6ba906552630 | diff --git a/lib/liquid/expression.rb b/lib/liquid/expression.rb
index a1426732c..f2abb2fc1 100644
--- a/lib/liquid/expression.rb
+++ b/lib/liquid/expression.rb
@@ -1,5 +1,7 @@
# frozen_string_literal: true
+require "lru_redux"
+
module Liquid
class Expression
LITERALS = {
@@ -10,37 +12,106 @@ class Express... | [
"lib/liquid/expression.rb"
] | [
{
"comment": "We should freeze anything put in the cache IMO\r\n\r\n```suggestion\r\n cache[markup] = inner_parse(markup, ss, cache).freeze\r\n```",
"path": "lib/liquid/expression.rb",
"hunk": "@@ -33,16 +35,130 @@ def self.parse(markup)\n when INTEGERS_REGEX\n Regexp.last_match(1... | true | ||
Shopify/liquid | 1,844 | comment_to_fix | Faster Expression parser / Tokenizer with StringScanner | ```suggestion
inner_parse(markup, ss, nil).freeze
``` | b4667adadff0b648b33678d5db958e59b59c7f80 | 10114b333eac9e46454e335dea9a6ba906552630 | diff --git a/lib/liquid/expression.rb b/lib/liquid/expression.rb
index a1426732c..f2abb2fc1 100644
--- a/lib/liquid/expression.rb
+++ b/lib/liquid/expression.rb
@@ -1,5 +1,7 @@
# frozen_string_literal: true
+require "lru_redux"
+
module Liquid
class Expression
LITERALS = {
@@ -10,37 +12,106 @@ class Express... | [
"lib/liquid/expression.rb"
] | [
{
"comment": "```suggestion\r\n inner_parse(markup, ss, nil).freeze\r\n```",
"path": "lib/liquid/expression.rb",
"hunk": "@@ -33,16 +35,130 @@ def self.parse(markup)\n when INTEGERS_REGEX\n Regexp.last_match(1).to_i\n when RANGES_REGEX\n- RangeLookup.parse(Regexp.last... | true | ||
Shopify/liquid | 1,844 | comment_to_fix | Faster Expression parser / Tokenizer with StringScanner | ```suggestion
Integer(markup, 10)
``` | b4667adadff0b648b33678d5db958e59b59c7f80 | 10114b333eac9e46454e335dea9a6ba906552630 | diff --git a/lib/liquid/expression.rb b/lib/liquid/expression.rb
index a1426732c..f2abb2fc1 100644
--- a/lib/liquid/expression.rb
+++ b/lib/liquid/expression.rb
@@ -1,5 +1,7 @@
# frozen_string_literal: true
+require "lru_redux"
+
module Liquid
class Expression
LITERALS = {
@@ -10,37 +12,106 @@ class Express... | [
"lib/liquid/expression.rb"
] | [
{
"comment": "```suggestion\r\n Integer(markup, 10)\r\n```",
"path": "lib/liquid/expression.rb",
"hunk": "@@ -33,16 +35,130 @@ def self.parse(markup)\n when INTEGERS_REGEX\n Regexp.last_match(1).to_i\n when RANGES_REGEX\n- RangeLookup.parse(Regexp.last_match(1), Regex... | true | ||
Shopify/liquid | 1,844 | comment_to_fix | Faster Expression parser / Tokenizer with StringScanner | these should be private i think?
```suggestion
attr_reader :partial, :warnings, :error_mode, :environment
``` | b4667adadff0b648b33678d5db958e59b59c7f80 | 10114b333eac9e46454e335dea9a6ba906552630 | diff --git a/lib/liquid/parse_context.rb b/lib/liquid/parse_context.rb
index 7bd5418d5..60cdf9e41 100644
--- a/lib/liquid/parse_context.rb
+++ b/lib/liquid/parse_context.rb
@@ -12,6 +12,18 @@ def initialize(options = Const::EMPTY_HASH)
@locale = @template_options[:locale] ||= I18n.new
@warnings = []
+... | [
"lib/liquid/parse_context.rb"
] | [
{
"comment": "these should be private i think?\r\n```suggestion\r\n attr_reader :partial, :warnings, :error_mode, :environment\r\n```",
"path": "lib/liquid/parse_context.rb",
"hunk": "@@ -3,7 +3,7 @@\n module Liquid\n class ParseContext\n attr_accessor :locale, :line_number, :trim_whitespace, :... | true | ||
Shopify/liquid | 1,844 | comment_to_fix | Faster Expression parser / Tokenizer with StringScanner | ```suggestion
cache.fetch(markup) { inner_parse(markup, ss, cache) }
``` | b4667adadff0b648b33678d5db958e59b59c7f80 | 10114b333eac9e46454e335dea9a6ba906552630 | diff --git a/lib/liquid/expression.rb b/lib/liquid/expression.rb
index a1426732c..f2abb2fc1 100644
--- a/lib/liquid/expression.rb
+++ b/lib/liquid/expression.rb
@@ -1,5 +1,7 @@
# frozen_string_literal: true
+require "lru_redux"
+
module Liquid
class Expression
LITERALS = {
@@ -10,37 +12,106 @@ class Express... | [
"lib/liquid/expression.rb"
] | [
{
"comment": "```suggestion\r\n cache.fetch(markup) { inner_parse(markup, ss, cache) }\r\n```",
"path": "lib/liquid/expression.rb",
"hunk": "@@ -33,16 +35,130 @@ def self.parse(markup)\n when INTEGERS_REGEX\n Regexp.last_match(1).to_i\n when RANGES_REGEX\n- RangeLooku... | true | ||
Shopify/liquid | 1,844 | comment_to_fix | Faster Expression parser / Tokenizer with StringScanner | Can we make this a constant or something? we do it twice now | b4667adadff0b648b33678d5db958e59b59c7f80 | 10114b333eac9e46454e335dea9a6ba906552630 | diff --git a/lib/liquid/expression.rb b/lib/liquid/expression.rb
index a1426732c..f2abb2fc1 100644
--- a/lib/liquid/expression.rb
+++ b/lib/liquid/expression.rb
@@ -1,5 +1,7 @@
# frozen_string_literal: true
+require "lru_redux"
+
module Liquid
class Expression
LITERALS = {
@@ -10,37 +12,106 @@ class Express... | [
"lib/liquid/expression.rb"
] | [
{
"comment": "Can we make this a constant or something? we do it twice now",
"path": "lib/liquid/expression.rb",
"hunk": "@@ -33,16 +35,130 @@ def self.parse(markup)\n when INTEGERS_REGEX\n Regexp.last_match(1).to_i\n when RANGES_REGEX\n- RangeLookup.parse(Regexp.last_match(1)... | true | ||
Shopify/liquid | 1,936 | issue_to_patch | Always stringify properties in all array filters | similar to https://github.com/Shopify/liquid/pull/1929 but for all other array filters
| f5d6a36574b7ddf5e1a00395f553a0f872fb9f16 | fe498086d083b97c91f7d1f18e04bd0153b1db78 | diff --git a/lib/liquid/standardfilters.rb b/lib/liquid/standardfilters.rb
index 63d080dd1..4771b2427 100644
--- a/lib/liquid/standardfilters.rb
+++ b/lib/liquid/standardfilters.rb
@@ -387,6 +387,7 @@ def sort(input, property = nil)
end
elsif ary.all? { |el| el.respond_to?(:[]) }
begin
+ ... | [
"lib/liquid/standardfilters.rb",
"lib/liquid/version.rb",
"test/integration/standard_filter_test.rb"
] | [] | diff --git a/test/integration/standard_filter_test.rb b/test/integration/standard_filter_test.rb
index 913dfa25b..5c80fe3ce 100644
--- a/test/integration/standard_filter_test.rb
+++ b/test/integration/standard_filter_test.rb
@@ -1281,6 +1281,17 @@ def test_sum_with_floats_and_indexable_map_values
assert_template_r... | true | |
Shopify/liquid | 1,929 | issue_to_patch | Stringify properties before filtering arrays | Previously, filtering code allowed would blindly pass the `property` when calling `#[]` on the target input. While this usually works, it falls apart with non-string keys and can lead to some strange behaviors:
```ruby
template = Liquid::Template.parse("{{ input | where: property, 0 }}")
template.render({ "input" ... | c5711c095f4269038b411dc960280e4f5981609f | 95ad9844cfc1aeca3c9fb5c848bbc39efef3819d | diff --git a/lib/liquid/standardfilters.rb b/lib/liquid/standardfilters.rb
index 618cd71b2..63d080dd1 100644
--- a/lib/liquid/standardfilters.rb
+++ b/lib/liquid/standardfilters.rb
@@ -979,8 +979,10 @@ def sum(input, property = nil)
attr_reader :context
def filter_array(input, property, target_value, defaul... | [
"lib/liquid/standardfilters.rb",
"test/integration/standard_filter_test.rb"
] | [] | diff --git a/test/integration/standard_filter_test.rb b/test/integration/standard_filter_test.rb
index ef1278322..913dfa25b 100644
--- a/test/integration/standard_filter_test.rb
+++ b/test/integration/standard_filter_test.rb
@@ -1061,6 +1061,19 @@ def test_where_with_false_value
assert_template_result(expected_out... | true | |
Shopify/liquid | 1,920 | issue_to_patch | Improve docs of `date` filter | The docs previously emphasized Ruby's date filter, but we shouldn't mention implementation details. Also, format `date` docs in the standard way. | 2d0442798b5bf43e52a7e300727a646209eb32cc | 77f781dfc67a649442d0f94e628cb471d3d6e482 | diff --git a/lib/liquid/standardfilters.rb b/lib/liquid/standardfilters.rb
index 08361a46a..618cd71b2 100644
--- a/lib/liquid/standardfilters.rb
+++ b/lib/liquid/standardfilters.rb
@@ -712,7 +712,16 @@ def newline_to_br(input)
input.gsub(/\r?\n/, "<br />\n")
end
- # Reformat a date using Ruby's core Ti... | [
"lib/liquid/standardfilters.rb"
] | [] | true | ||
Shopify/liquid | 1,928 | issue_to_patch | Add a link to the LiquidDoc tooling reference in `doc` tag documentation | This will point users to LiquidDoc Reference which will ship with [this PR](https://github.com/Shopify/shopify-dev/pull/54338)
⚠️⚠️⚠️ I copied the reference URL from [here](https://github.com/search?q=repo%3AShopify%2Fliquid+%22%2Fthemes%2F%22&type=code)
Which [should work](https://shopify.dev/docs/api/liquid/tag... | e38f730c0035a6a7a0c51803590a21bf6df0e262 | 21432928d0b815693cff9b81613a967debec67d6 | diff --git a/lib/liquid/tags/doc.rb b/lib/liquid/tags/doc.rb
index 6f061650d..ef5d5d801 100644
--- a/lib/liquid/tags/doc.rb
+++ b/lib/liquid/tags/doc.rb
@@ -13,6 +13,10 @@ module Liquid
# Liquid code inside will be parsed but not executed. This facilitates
# tooling support for features like code completion, ... | [
"lib/liquid/tags/doc.rb"
] | [] | true | ||
Shopify/liquid | 1,919 | issue_to_patch | Update LiquidDoc documentation | Update `{% doc %}` documentation. | 6453a0ea483d697c03056dabb21ba1aeb89ba8eb | 4a945a085fafee93dede3730233b7510a59b2d40 | diff --git a/lib/liquid/tags/doc.rb b/lib/liquid/tags/doc.rb
index 425e3d5bc..6f061650d 100644
--- a/lib/liquid/tags/doc.rb
+++ b/lib/liquid/tags/doc.rb
@@ -17,8 +17,8 @@ module Liquid
# {% doc %}
# Renders a message.
#
- # @param {string} foo - A foo value.
- # @param {string} [bar] - An optio... | [
"lib/liquid/tags/doc.rb"
] | [] | true | ||
Shubhamsaboo/awesome-llm-apps | 779 | issue_to_patch | Add multimodal agentic RAG demo | 9d885c306d2cdbf53dbef8cfeb56e02b4c9996b6 | 148872ffaec50e71930733d74f75e74e52ef42fd | diff --git a/.gitignore b/.gitignore
index 47702b3c92..e005923995 100644
--- a/.gitignore
+++ b/.gitignore
@@ -14,3 +14,5 @@ venv/
# Node
node_modules/
.next/
+dist/
+*.tsbuildinfo
diff --git a/README.md b/README.md
index a2c68c10f4..d78e017910 100644
--- a/README.md
+++ b/README.md
@@ -218,6 +218,7 @@ streamlit run... | [
".gitignore",
"README.md",
"rag_tutorials/multimodal_agentic_rag/README.md",
"rag_tutorials/multimodal_agentic_rag/assets/multimodal-agentic-rag-architecture.png",
"rag_tutorials/multimodal_agentic_rag/backend/agentic_rag_agent/__init__.py",
"rag_tutorials/multimodal_agentic_rag/backend/agentic_rag_agent/... | [] | true | |||
Shubhamsaboo/awesome-llm-apps | 789 | issue_to_patch | Add earnings call analyst agent | ## Summary
- Add the Earnings Call Analyst Agent under `advanced_ai_agents/single_agent_apps`
- Add the app to the root README featured table and Advanced AI Agents list
- Include Vertex AI-first setup docs, ADK-backed analysis/research/transcription paths, tests, and the architecture image
- Polish the app entry emoji... | a35897449fe8b0fab12e8f0fd9f2e2a40e872ab7 | 18454ecfd628fae20039bd0ba09bc0c4d39fd77e | diff --git a/README.md b/README.md
index d78e017910..34e9fa2168 100644
--- a/README.md
+++ b/README.md
@@ -92,6 +92,7 @@ streamlit run travel_agent.py
| Template | What it does | Stack |
|---|---|---|
+| [📡 Earnings Call Analyst Agent](advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/) | YouTube ea... | [
"README.md",
"advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/.env.example",
"advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/README.md",
"advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/__init__.py",
"advanced_ai_agents/single_agent_apps/earnings_call_anal... | [] | diff --git a/advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/tests/test_core_contracts.py b/advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/tests/test_core_contracts.py
new file mode 100644
index 0000000000..60d02a41d0
--- /dev/null
+++ b/advanced_ai_agents/single_agent_apps/earnings_c... | true | |
Shubhamsaboo/awesome-llm-apps | 793 | issue_to_patch | Fix earnings call analyst ADK auth detection | ## Summary
- centralize ADK credential detection and JSON parsing for the Earnings Call Analyst Agent
- treat Vertex AI env (`GOOGLE_GENAI_USE_VERTEXAI=True` + `GOOGLE_CLOUD_PROJECT`) as a valid ADK runtime path
- make health/diagnostics report ADK auth mode instead of only checking for API keys
- update tests to cover... | 20381f90984488c304886be80254407c65ee638f | 6320331cd2a054eb4a2c823e3c96e3e32ec1ee97 | diff --git a/advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/README.md b/advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/README.md
index 2677a63313..e958d67230 100644
--- a/advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/README.md
+++ b/advanced_ai_agents/single_agent_... | [
"advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/README.md",
"advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/adk_runtime.py",
"advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/agent.py",
"advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/live_d... | [] | diff --git a/advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/tests/test_core_contracts.py b/advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/tests/test_core_contracts.py
index 60d02a41d0..4ec651e3ff 100644
--- a/advanced_ai_agents/single_agent_apps/earnings_call_analyst_agent/tests/test... | true | |
Shubhamsaboo/awesome-llm-apps | 796 | issue_to_patch | Remove multimodal RAG fallback paths | ## Summary
- remove deterministic local vector fallback and seeded startup sources from the multimodal RAG app
- return setup-required state when GOOGLE_API_KEY or ADK setup is missing
- update README and agent instruction text to match the real Gemini/ADK-only path
## Testing
- python3 -m py_compile rag_tutorials/mul... | 844cda76bfff452ba722403fbae8b3556024aaff | 7886415ce415d0bae5dffd01561efb9b8dc54a76 | diff --git a/rag_tutorials/multimodal_agentic_rag/README.md b/rag_tutorials/multimodal_agentic_rag/README.md
index f316f30704..f83da5337d 100644
--- a/rag_tutorials/multimodal_agentic_rag/README.md
+++ b/rag_tutorials/multimodal_agentic_rag/README.md
@@ -1,6 +1,6 @@
# Multimodal Agentic RAG
-This is a local multimod... | [
"rag_tutorials/multimodal_agentic_rag/README.md",
"rag_tutorials/multimodal_agentic_rag/backend/agentic_rag_agent/agent.py",
"rag_tutorials/multimodal_agentic_rag/backend/rag_store.py",
"rag_tutorials/multimodal_agentic_rag/backend/server.py"
] | [] | true | ||
Shubhamsaboo/awesome-llm-apps | 830 | issue_to_patch | fix: remove Python stdlib modules from requirements.txt | ## Summary
Removes `asyncio` and `uuid` from 8 `requirements.txt` files across the repo. These are Python standard library modules (available since Python 3.4+) and should not be listed as pip dependencies.
## Problem
Listing stdlib modules in `requirements.txt` causes two issues:
1. **Wrong package installed**: Th... | 795212bfb3ba7d25db04c7879d39621429fd093d | 156511e74923a568563950eef3146ade0698b27a | diff --git a/advanced_ai_agents/multi_agent_apps/ai_financial_coach_agent/requirements.txt b/advanced_ai_agents/multi_agent_apps/ai_financial_coach_agent/requirements.txt
index 5d3f81500f..a847f21ba5 100644
--- a/advanced_ai_agents/multi_agent_apps/ai_financial_coach_agent/requirements.txt
+++ b/advanced_ai_agents/mult... | [
"advanced_ai_agents/multi_agent_apps/ai_financial_coach_agent/requirements.txt",
"ai_agent_framework_crash_course/google_adk_crash_course/5_memory_agent/5_1_in_memory_conversation_agent/requirements.txt",
"ai_agent_framework_crash_course/google_adk_crash_course/5_memory_agent/5_2_persistent_conversation_agent/r... | [] | true | ||
Shubhamsaboo/awesome-llm-apps | 820 | issue_to_patch | fix: guard against empty choices and None message in DeepSeek API responses | ## Summary
Add safety checks before accessing `deepseek_response.choices[0].message` to prevent crashes when the DeepSeek API returns empty or filtered responses.
## Changes
- `ai_3dpygame_r1.py` — Guard `choices[0].message.reasoning_content` access
- `ai_system_architect_r1.py` — Guard both `reasoning_content` and ... | 795212bfb3ba7d25db04c7879d39621429fd093d | 1c0a5b74501d0ea6c0e8b1f7c71d9b038a146f86 | diff --git a/advanced_ai_agents/autonomous_game_playing_agent_apps/ai_3dpygame_r1/ai_3dpygame_r1.py b/advanced_ai_agents/autonomous_game_playing_agent_apps/ai_3dpygame_r1/ai_3dpygame_r1.py
index 2a85f78c60..5e929b01b4 100644
--- a/advanced_ai_agents/autonomous_game_playing_agent_apps/ai_3dpygame_r1/ai_3dpygame_r1.py
++... | [
"advanced_ai_agents/autonomous_game_playing_agent_apps/ai_3dpygame_r1/ai_3dpygame_r1.py",
"advanced_ai_agents/single_agent_apps/ai_system_architect_r1/ai_system_architect_r1.py"
] | [] | true | ||
Shubhamsaboo/awesome-llm-apps | 774 | issue_to_patch | Upgrade travel planner agent team to agno 2.x (CVE-2026-35002) | Migrates the AI travel planner agent team from agno 1.x to 2.x, fixing the critical eval injection vulnerability (CVE-2026-35002).
API changes: show_tool_calls removed, add_datetime_to_instructions renamed to add_datetime_to_context, add_member_tools_to_system_message renamed to add_member_tools_to_context, enable_a... | a3ba80b4be84baaa4293c1073c3ee758d9c13487 | 644957619a0a7e522a3290af63facb626b36ad20 | diff --git a/advanced_ai_agents/multi_agent_apps/agent_teams/ai_travel_planner_agent_team/backend/agents/destination.py b/advanced_ai_agents/multi_agent_apps/agent_teams/ai_travel_planner_agent_team/backend/agents/destination.py
index b82b8535ac..17eabffcd6 100644
--- a/advanced_ai_agents/multi_agent_apps/agent_teams/a... | [
"advanced_ai_agents/multi_agent_apps/agent_teams/ai_travel_planner_agent_team/backend/agents/destination.py",
"advanced_ai_agents/multi_agent_apps/agent_teams/ai_travel_planner_agent_team/backend/agents/flight.py",
"advanced_ai_agents/multi_agent_apps/agent_teams/ai_travel_planner_agent_team/backend/agents/food... | [] | true | ||
Shubhamsaboo/awesome-llm-apps | 767 | issue_to_patch | Add insurance claim live agent to README | 584b26d87d7d19ee5b1fc97ad3552ab843c63297 | 76eb3bc9bbc319f53db158abccab1b7d3d4974b2 | diff --git a/README.md b/README.md
index 46e37dd4f9..f9e5e10fee 100644
--- a/README.md
+++ b/README.md
@@ -191,6 +191,7 @@ streamlit run travel_agent.py
* [🗣️ AI Audio Tour Agent](voice_ai_agents/ai_audio_tour_agent/)
* [📞 Customer Support Voice Agent](voice_ai_agents/customer_support_voice_agent/)
+* [🛡️ ... | [
"README.md"
] | [] | true | |||
Shubhamsaboo/awesome-llm-apps | 766 | issue_to_patch | New Voice Agent: Live Insurance Claim Intake Agent | fe8154c0a463eabfefb1e6ea41f2bfe14c7f00d9 | 3d0784a7ff99da64de9d9644e0781e471f395963 | diff --git a/voice_ai_agents/insurance_claim_live_agent_team/.env.example b/voice_ai_agents/insurance_claim_live_agent_team/.env.example
new file mode 100644
index 0000000000..79446d1631
--- /dev/null
+++ b/voice_ai_agents/insurance_claim_live_agent_team/.env.example
@@ -0,0 +1,8 @@
+# Local ADK Web development with Go... | [
"voice_ai_agents/insurance_claim_live_agent_team/.env.example",
"voice_ai_agents/insurance_claim_live_agent_team/README.md",
"voice_ai_agents/insurance_claim_live_agent_team/__init__.py",
"voice_ai_agents/insurance_claim_live_agent_team/agent.py",
"voice_ai_agents/insurance_claim_live_agent_team/assets/insu... | [] | true | |||
Shubhamsaboo/awesome-llm-apps | 732 | issue_to_patch | duckduckgo-search==6.4.1 not available
Hello,
the duckduckgo-search==6.4.1 is not available.
You can use instead the version 6.4.2 | fix: unpin duckduckgo-search==6.4.1 (yanked from PyPI) | ## Summary
`duckduckgo-search==6.4.1` is no longer available on PyPI (6.4.2 is the closest release in the 6.4.x line), so a clean `pip install -r requirements.txt` fails hard on four projects in this repo.
Originally reported in #63 by @benouarred, who cited the repo-level problem but did not list specific projects. ... | 5d9c0b282a630bbc74e67740e7978c441f03eaca | 78ee6b005fdf565ea0c0ea659808ee4abdbf190d | diff --git a/advanced_ai_agents/multi_agent_apps/agent_teams/ai_teaching_agent_team/requirements.txt b/advanced_ai_agents/multi_agent_apps/agent_teams/ai_teaching_agent_team/requirements.txt
index b7d538c423..9207622261 100644
--- a/advanced_ai_agents/multi_agent_apps/agent_teams/ai_teaching_agent_team/requirements.txt... | [
"advanced_ai_agents/multi_agent_apps/agent_teams/ai_teaching_agent_team/requirements.txt",
"rag_tutorials/rag_agent_cohere/requirements.txt",
"rag_tutorials/rag_database_routing/requirements.txt",
"starter_ai_agents/ai_medical_imaging_agent/requirements.txt"
] | [] | true | |
Shubhamsaboo/awesome-llm-apps | 733 | issue_to_patch | feat(browser_mcp_agent): document and unblock local Ollama / OpenAI-compatible providers | ## Summary
Issue [#329](https://github.com/Shubhamsaboo/awesome-llm-apps/issues/329) (7 comments, unresolved) asked how to run `browser_mcp_agent` against a local Ollama instance. As @AndrewHoh (mcp-agent maintainer) noted in that thread, the framework already supports this — Ollama's `/v1` endpoint is OpenAI-compatib... | 5d9c0b282a630bbc74e67740e7978c441f03eaca | 664e65c593f89dc6599ab93d849521c1f9078279 | diff --git a/mcp_ai_agents/browser_mcp_agent/README.md b/mcp_ai_agents/browser_mcp_agent/README.md
index 9a415713d9..eb21f51d57 100644
--- a/mcp_ai_agents/browser_mcp_agent/README.md
+++ b/mcp_ai_agents/browser_mcp_agent/README.md
@@ -43,12 +43,45 @@ A Streamlit application that allows you to browse and interact with w... | [
"mcp_ai_agents/browser_mcp_agent/README.md",
"mcp_ai_agents/browser_mcp_agent/main.py",
"mcp_ai_agents/browser_mcp_agent/mcp_agent.config.yaml",
"mcp_ai_agents/browser_mcp_agent/mcp_agent.secrets.yaml.example"
] | [] | true | ||
Shubhamsaboo/awesome-llm-apps | 720 | issue_to_patch | Skill Python-expert refers to rules, but has no rules
The [Python Expert](https://github.com/Shubhamsaboo/awesome-llm-apps/tree/main/awesome_agent_skills/python-expert) skill refers to "rules" in several places. But no such directory exists. | fix: remove broken rules/ directory references in python-expert skill | ## Summary
Fixes #660.
The `python-expert` skill referenced a `rules/` directory that does not exist. `SKILL.md` linked to 8 non-existent rule files and `AGENTS.md` ended each rule section with a "Full details" link pointing into the same missing directory. The "References" section also listed the missing directory.
... | 3c93c9296429312d4fc26b37a0df048d912ac269 | 5b503953550069b5784971e145c39623a02fb018 | diff --git a/awesome_agent_skills/python-expert/AGENTS.md b/awesome_agent_skills/python-expert/AGENTS.md
index d3a34893ed..5a3b3ee096 100644
--- a/awesome_agent_skills/python-expert/AGENTS.md
+++ b/awesome_agent_skills/python-expert/AGENTS.md
@@ -66,8 +66,6 @@ def add_item(item: str, items: list[str] | None = None) -> ... | [
"awesome_agent_skills/python-expert/AGENTS.md",
"awesome_agent_skills/python-expert/SKILL.md"
] | [] | true | |
Shubhamsaboo/awesome-llm-apps | 638 | issue_to_patch | Add Trust-Gated Multi-Agent Research Team with Cryptographic Audit Trail | ## Summary
- Streamlit app where GPT-4o-mini agents must pass a **trust verification** before participating in a research pipeline
- Every agent action is recorded in a **SHA-256 hash-chained audit trail** — tamper-evident and independently verifiable
- Fully self-contained: only `openai` and `streamlit` as dependenci... | b70e07790cd64539ecf95515ed8576f1f871e6c3 | 0d654a4f01d8615b7f1abc11570b59bbfe6b358d | diff --git a/README.md b/README.md
index 4cfa95c163..19a0437370 100644
--- a/README.md
+++ b/README.md
@@ -160,6 +160,7 @@ streamlit run travel_agent.py
* [👨🏻💼 AI Sales Intelligence Agent Team](advanced_ai_agents/multi_agent_apps/agent_teams/ai_sales_intelligence_agent_team)
* [🎧 AI Social Media News and Pod... | [
"README.md",
"advanced_ai_agents/multi_agent_apps/trust_gated_agent_team/README.md",
"advanced_ai_agents/multi_agent_apps/trust_gated_agent_team/requirements.txt",
"advanced_ai_agents/multi_agent_apps/trust_gated_agent_team/trust_gated_agents.py"
] | [] | true | ||
Snailclimb/JavaGuide | 2,874 | issue_to_patch | docs(ai-coding): 新增 Claude Desktop + CC Switch 接入第三方模型实战 | ## Summary
- 新增文章《Claude Desktop 接入第三方模型实战：CC Switch 配置与本地代理原理》，放在 `docs/ai-coding/cases/` 下，与现有 `cc-glm5.1.md`、`deepseek-v4-claude-code.md`、`cc-m3.md` 等接入第三方模型案例并列。
- 内容覆盖三块：CC Switch 接入 DeepSeek 的完整配置流程（含常见坑）、本地代理网关原理拆解（配置接管 / 模型映射 / 协议转换 / 断路器 / 热切换差异）、可复用到 AI 应用工程的设计思路（代理网关模式、SSOT 配置管理、断路器状态机、局限性）。
- 同步在 `docs/ai-... | 8b95e8bcfa95bed08752c919e96838ee6042bcd5 | 335119db735b5a3f1affdc04f39ecccf0037c4ed | diff --git a/docs/.vuepress/sidebar/ai-coding.ts b/docs/.vuepress/sidebar/ai-coding.ts
index a061bbf94ef..ad7f07973d9 100644
--- a/docs/.vuepress/sidebar/ai-coding.ts
+++ b/docs/.vuepress/sidebar/ai-coding.ts
@@ -72,6 +72,10 @@ export const aiCoding = arraySidebar([
text: "MiniMax M3 + Claude Code 实战",
... | [
"docs/.vuepress/sidebar/ai-coding.ts",
"docs/ai-coding/README.md",
"docs/ai-coding/cases/claude-desktop-cc-switch.md"
] | [
{
"comment": "这里的 Markdown 表格行都以 `||` 开头，会导致渲染出一个“空白第一列”（或在部分渲染器下直接变形）。建议改为标准的 `| ... | ... |` 表格写法（单个前导 `|`），以确保在 GitHub/VitePress 等渲染环境中一致显示。",
"path": "docs/ai-coding/cases/claude-desktop-cc-switch.md",
"hunk": "@@ -0,0 +1,347 @@\n+---\n+title: Claude Desktop 接入第三方模型实战：CC Switch 配置与本地代理原理\n+descripti... | true | ||
Snailclimb/JavaGuide | 2,875 | issue_to_patch | fix(docs): 修正类加载器文档中的错别字 | - 修正了"也说说了"为"也说了"的错误
- 确保文档表述更加准确清晰 | 8b95e8bcfa95bed08752c919e96838ee6042bcd5 | c79182c9fdc248bf886e13617d046ac8219d6d0c | diff --git a/docs/java/jvm/classloader.md b/docs/java/jvm/classloader.md
index 8e034414485..cab40ae33b9 100644
--- a/docs/java/jvm/classloader.md
+++ b/docs/java/jvm/classloader.md
@@ -164,7 +164,7 @@ public class PrintClassLoaderTree {
### 自定义类加载器
-我们前面也说说了，除了 `BootstrapClassLoader` 其他类加载器均由 Java 实现且全部继承自`java.la... | [
"docs/java/jvm/classloader.md"
] | [] | true | ||
Snailclimb/JavaGuide | 2,872 | issue_to_patch | docs: add Japanese README | I created Japanese translated README. | 887c6c6088641ae6bbc9b1908892e12844a55f05 | 4a8400a25427b9ea7629a2e50c0a9244b273c16c | diff --git a/README_JA.md b/README_JA.md
new file mode 100644
index 00000000000..1ca8bc8626e
--- /dev/null
+++ b/README_JA.md
@@ -0,0 +1,452 @@
+より快適でスピーディーな体験のため、オンライン閲覧プラットフォームでの閲覧をおすすめします！リンク: [javaguide.cn](https://javaguide.cn/)。
+
+<div align="center">
+
+[![logo](https://oss.javaguide.cn/github/javaguide/csdn/1c... | [
"README_JA.md"
] | [] | true | ||
Snailclimb/JavaGuide | 2,866 | issue_to_patch | docs(mysql): add the order by condition to the pagination statement. | ### 修改
- 为分页子查询添加显示 `ORDER BY` 条件
测试示例：
```sql
CREATE TABLE EMPLOYEE (
id INTEGER PRIMARY KEY,
name VARCHAR(50) NOT NULL,
dept VARCHAR(50) NOT NULL
);
ALTER TABLE EMPLOYEE ADD INDEX idx_dept(dept);
```
```sql
explain select e.id, name, dept from EMPLOYEE e inner join
( select id from EMPLOY... | bc53e52630ff0b4e0a999bd5156f181588806c6c | 4f3b65d8065b725e2f2865ea14a6c5b0dfb61e6f | diff --git a/docs/high-performance/deep-pagination-optimization.md b/docs/high-performance/deep-pagination-optimization.md
index 460cc7f4f96..57d238095f2 100644
--- a/docs/high-performance/deep-pagination-optimization.md
+++ b/docs/high-performance/deep-pagination-optimization.md
@@ -91,13 +91,13 @@ SELECT t1.*
FROM t... | [
"docs/high-performance/deep-pagination-optimization.md"
] | [] | true | ||
Snailclimb/JavaGuide | 2,869 | issue_to_patch | docs: 修正 README.md 中文标点符号错误 | ## 修改说明
修正 README.md 中的中文标点符号使用错误。
### 修改内容
1. 中文冒号前多余空格：`**总结** : (必看` → `**总结**（必看`
2. 英文括号含中文：`JVM (必看 :+1:)` → `JVM（必看 :+1:）`
3. 中文逗号/句号前多余空格：`算法 ，` → `算法，`
4. 中文文本中多余空格
所有修改仅涉及标点符号和空格，不影响任何实际内容。 | bc53e52630ff0b4e0a999bd5156f181588806c6c | 93ed5624449f750b52bef00c0d37188a19b72ce2 | diff --git a/README.md b/README.md
index 237bdab61e3..910fc1a7705 100755
--- a/README.md
+++ b/README.md
@@ -11,7 +11,7 @@
</div>
-> - **大模型实战项目**： [⭐AI 智能面试辅助平台 + RAG 知识库](https://javaguide.cn/zhuanlan/interview-guide.html)（基于 Spring Boot 4.0 + Java 21 + Spring AI 2.0 ，非常适合作为学习和简历项目，学习门槛低）。
+> - **大模型实战项目**： [⭐AI... | [
"README.md"
] | [] | true | ||
Snailclimb/JavaGuide | 2,867 | issue_to_patch | fix(docs): 修正线程池调度描述中的错别字 | - 修正了"以达到"为"已达到"的语法错误
- 保持了文档的技术准确性和可读性 | bc53e52630ff0b4e0a999bd5156f181588806c6c | 72fb9065755949a48288f8798a9809d75ea7adb3 | diff --git a/docs/java/concurrent/java-concurrent-questions-03.md b/docs/java/concurrent/java-concurrent-questions-03.md
index a84c7efa882..8eb4e0a5db5 100644
--- a/docs/java/concurrent/java-concurrent-questions-03.md
+++ b/docs/java/concurrent/java-concurrent-questions-03.md
@@ -795,7 +795,7 @@ public class ThreadPool... | [
"docs/java/concurrent/java-concurrent-questions-03.md"
] | [] | true | ||
Snailclimb/JavaGuide | 2,865 | issue_to_patch | docs(network): Enhance TCP reliability guarantee documentation | Add detailed explanations on TCP reliability mechanisms including Fast Retransmit, SACK, and D-SACK. | 1a9a92d24a37f45898545b1368a4cfdb4e0eaca4 | 7d40e31df8a391a4fe3083718e40811a20172e90 | diff --git a/docs/cs-basics/network/tcp-reliability-guarantee.md b/docs/cs-basics/network/tcp-reliability-guarantee.md
index 892764952c3..7ac6b8d8dd3 100644
--- a/docs/cs-basics/network/tcp-reliability-guarantee.md
+++ b/docs/cs-basics/network/tcp-reliability-guarantee.md
@@ -111,6 +111,39 @@ Karn 算法的核心点是：对已经重传过的报文段，其 ... | [
"docs/cs-basics/network/tcp-reliability-guarantee.md"
] | [] | true | ||
Snailclimb/JavaGuide | 2,858 | issue_to_patch | fix(mybatis): correcting the description of namespace in the mybatis | ## 修改
题目：`MyBatis 的 xml 映射文件中，不同的 xml 映射文件，id 是否可以重复？` 的答案中关于 `namespace` 不是必须的描述是错误的。（参考 MyBatis [XMLMapperBuilder#configurationElement](https://github.com/mybatis/mybatis-3/blob/master/src/main/java/org/apache/ibatis/builder/xml/XMLMapperBuilder.java) 源码）
```java
private void configurationElement(XNode context... | 10033d302b7dc22e05a9948c57adf9316a0c65b1 | abb0e9b9e02e0e226df1cc684b7b6d4911893b03 | diff --git a/docs/system-design/framework/mybatis/mybatis-interview.md b/docs/system-design/framework/mybatis/mybatis-interview.md
index e05a9da4428..857307330c5 100644
--- a/docs/system-design/framework/mybatis/mybatis-interview.md
+++ b/docs/system-design/framework/mybatis/mybatis-interview.md
@@ -248,9 +248,9 @@ MyB... | [
"docs/system-design/framework/mybatis/mybatis-interview.md"
] | [] | true | ||
Snailclimb/JavaGuide | 2,859 | issue_to_patch | 深度分页介绍及优化建议中存在冗余的LIMIT语句
#### 页面
https://javaguide.cn/high-performance/deep-pagination-optimization.html#%E5%BB%B6%E8%BF%9F%E5%85%B3%E8%81%94
#### 截图
“INNER JOIN”中已经限制了10条数据，关联出来的数据也应该是10条，所以我觉得第四行的“LIMIT 10”是冗余的... | docs(mysql): align delayed join pagination example | ## Summary
- align the delayed `INNER JOIN` pagination example with the maintainer-suggested SQL in #2273
- update the comma-join variant and explanation so the `LIMIT` window is only shown in the subquery
Fixes #2273
## Tests
- `git diff --check`
Note: I also attempted `pnpm exec markdownlint-cli2 docs/high-perform... | 2dcbd22d72751056da962c872e80196597f4001f | 9e2be8afbccb5038dec043fa0b01b4a6431401e3 | diff --git a/docs/high-performance/deep-pagination-optimization.md b/docs/high-performance/deep-pagination-optimization.md
index 4288e67bc88..8c395f966b9 100644
--- a/docs/high-performance/deep-pagination-optimization.md
+++ b/docs/high-performance/deep-pagination-optimization.md
@@ -93,14 +93,13 @@ SELECT t1.*
FROM t... | [
"docs/high-performance/deep-pagination-optimization.md"
] | [] | true | |
Snailclimb/JavaGuide | 2,860 | issue_to_patch | docs(mysql): clarify UNSIGNED storage requirements | ## Summary
- clarify that `UNSIGNED` changes the integer value range, not the storage bytes
- link the MySQL integer type and storage requirements docs for the corrected statement
## Tests
- `git diff --check`
- `markdownlint-cli2 docs/high-performance/sql-optimization.md` via an existing local JavaGuide install repor... | 2dcbd22d72751056da962c872e80196597f4001f | 5568904826fbfba65a1e99104038cef61fe9936c | diff --git a/docs/high-performance/sql-optimization.md b/docs/high-performance/sql-optimization.md
index e4c9e24c09f..45304fa49fc 100644
--- a/docs/high-performance/sql-optimization.md
+++ b/docs/high-performance/sql-optimization.md
@@ -94,13 +94,15 @@ MySQL 提供了两个方法来处理 ip 地址
**b.对于非负型的数据 (如自增 ID,整型 IP，年龄) 来说,要优先使用无符... | [
"docs/high-performance/sql-optimization.md"
] | [] | true | ||
Snailclimb/JavaGuide | 2,855 | issue_to_patch | 修复Unsafe CAS的代码仍存在的问题 | # 相关issue
#2650
# 相关pull request
#2801
# 问题
按照当前版本的文章，代码应该是：
```java
import sun.misc.Unsafe;
import java.lang.reflect.Field;
public class CasTest {
// 1. 共享变量，必须用 volatile 保证可见性
private volatile int a = 0;
private static Unsafe unsafe;
private static long fieldOffset;
... | 4a4378d0567414636a4a86f6df995435c5b0f6fa | c9ffd033b8c61d197aa2b0a1ae083d70ab37b2be | diff --git a/docs/java/basis/unsafe.md b/docs/java/basis/unsafe.md
index 9acffc941cd..46a537feecb 100644
--- a/docs/java/basis/unsafe.md
+++ b/docs/java/basis/unsafe.md
@@ -568,10 +568,12 @@ private void incrementAndPrint(int targetValue) {
return;
}
// 尝试 CAS 操作：如果当前值等于 targetValue - 1，则... | [
"docs/java/basis/unsafe.md"
] | [] | true | ||
Snailclimb/JavaGuide | 2,856 | issue_to_patch | fix(spring-bean-lifecycle): correcting the description of the instantiation and property population phases | ## 修改
`创建 Bean 的实例` 阶段已经完成了**构造函数注入**相关处理（参考 Spring Javadoc说明）
```java
/**
* Create a new instance for the specified bean, using an appropriate instantiation strategy:
* factory method, constructor autowiring, or simple instantiation.
* ... ...
*/
protected BeanWrapper createBeanInstance(String beanName, Ro... | 4a4378d0567414636a4a86f6df995435c5b0f6fa | 1f29c17677b96325429fa081f307fcad6156e398 | diff --git a/docs/system-design/framework/spring/spring-knowledge-and-questions-summary.md b/docs/system-design/framework/spring/spring-knowledge-and-questions-summary.md
index ef65d2b9de5..6fdb343175a 100644
--- a/docs/system-design/framework/spring/spring-knowledge-and-questions-summary.md
+++ b/docs/system-design/fr... | [
"docs/system-design/framework/spring/spring-knowledge-and-questions-summary.md"
] | [] | true | ||
Snailclimb/JavaGuide | 2,853 | issue_to_patch | fix(docs): fix typo | ### 修改
topic change -> topic exchange | b6834f3cce343d8776ccb2164cb3033e7b6f9504 | c6b787f273a2e9fc362fd6790ea8354826033f9b | diff --git a/docs/high-performance/message-queue/message-queue.md b/docs/high-performance/message-queue/message-queue.md
index ea8a25c6613..113c52d1087 100644
--- a/docs/high-performance/message-queue/message-queue.md
+++ b/docs/high-performance/message-queue/message-queue.md
@@ -169,7 +169,7 @@ AMQP，即 Advanced Message... | [
"docs/high-performance/message-queue/message-queue.md"
] | [] | true | ||
Snailclimb/JavaGuide | 2,849 | issue_to_patch | fix(database): 修正 MySQL MVCC机制描述中的概念错误 | fix(database): 修正 MySQL MVCC机制描述中的概念错误
1. 问题描述 (Issue Description)
在 docs/database/mysql/innodb-implementation-of-mvcc.md（请根据实际文件路径确认）中，关于 MVCC 修改操作的描述存在严重的概念性错误。
原文错误描述：
> “当一个事务要对数据库中的数据进行修改时，MVCC 会为该事务创建一个数据快照，而不是直接修改实际的数据行。”
错误原因：
该描述混淆了 MVCC（读视图） 与 InnoDB 存储引擎底层更新机制。
- InnoDB 采用的是 原地更新（Update-in-Pla... | 37057a0c7230ca7ba02c01a70ba78ff4f277ff66 | 87d30796898cc58f6dbaab6c14472ed1bb4e8165 | diff --git a/docs/database/mysql/innodb-implementation-of-mvcc.md b/docs/database/mysql/innodb-implementation-of-mvcc.md
index b4df7745026..9a6c5787674 100644
--- a/docs/database/mysql/innodb-implementation-of-mvcc.md
+++ b/docs/database/mysql/innodb-implementation-of-mvcc.md
@@ -12,7 +12,7 @@ head:
## 多版本并发控制 (Mult... | [
"docs/database/mysql/innodb-implementation-of-mvcc.md"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.