repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
SeleniumHQ/selenium | 17,613 | issue_to_patch | [build] delete .skipped-tests file entries |
### 💥 What does this PR do?
~Removes the `.skipped-tests` deselection list and the reference to it in the RBE CI build script.~
I still think we shouldn't use this, but there's no harm keeping it and just removing references we don't need for now.
We should either tag targets as skip-rbe or guard them against R... | aba540ca181d1c5c6daef841663837392b54ab99 | fb698181e6bafcaf9a8b987557aaf87a1484ac61 | diff --git a/.skipped-tests b/.skipped-tests
index 4814fe97ca671..e69de29bb2d1d 100644
--- a/.skipped-tests
+++ b/.skipped-tests
@@ -1,26 +0,0 @@
--//java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest
--//java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest-remote
--//java/test/org/openqa/seleni... | [
".skipped-tests"
] | [
{
"comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Deleted <b><i>.skipped-tests</i></b> breaks ci <code>📘 Rule violation</code> <code>☼ Reliability</code>\n\n<pre>\nThis PR removes or empties the <b><i>.skipped-tests</i><... | true | ||
SeleniumHQ/selenium | 17,613 | comment_to_fix | [build] delete .skipped-tests file entries | <img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required">
1\. Deleted <b><i>.skipped-tests</i></b> breaks ci <code>📘 Rule violation</code> <code>☼ Reliability</code>
<pre>
This PR removes or empties the <b><i>.skipped-tests</i></b> file, but <b><i>scripts/github... | aba540ca181d1c5c6daef841663837392b54ab99 | fb698181e6bafcaf9a8b987557aaf87a1484ac61 | diff --git a/.skipped-tests b/.skipped-tests
index 4814fe97ca671..e69de29bb2d1d 100644
--- a/.skipped-tests
+++ b/.skipped-tests
@@ -1,26 +0,0 @@
--//java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest
--//java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest-remote
--//java/test/org/openqa/seleni... | [
".skipped-tests"
] | [
{
"comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Deleted <b><i>.skipped-tests</i></b> breaks ci <code>📘 Rule violation</code> <code>☼ Reliability</code>\n\n<pre>\nThis PR removes or empties the <b><i>.skipped-tests</i><... | true | ||
SeleniumHQ/selenium | 17,599 | issue_to_patch | Add logs to Grid to debug downloading files | ### 🔗 Related Issues
https://github.com/selenide/selenide/issues/3328
### 💥 What does this PR do?
Adds INFO and DEBUG logs to Grid:
- what was the desired downloads directory
- what files were found during file download
- what files were deleted etc.
### 🤖 AI assistance
- [x] No substantial AI assistance... | d59db6d9a91c0add575a46d8f033fb33923da7e5 | 11bbff4227d11ba2585f9427bef6322310c04a68 | diff --git a/java/src/org/openqa/selenium/HasDownloads.java b/java/src/org/openqa/selenium/HasDownloads.java
index ac2e3aa076f72..1cd9c53a4ff13 100644
--- a/java/src/org/openqa/selenium/HasDownloads.java
+++ b/java/src/org/openqa/selenium/HasDownloads.java
@@ -110,5 +110,11 @@ public long getLastModifiedTime() {
p... | [
"java/src/org/openqa/selenium/HasDownloads.java",
"java/src/org/openqa/selenium/grid/data/NodeStatus.java",
"java/src/org/openqa/selenium/grid/distributor/local/LocalDistributor.java",
"java/src/org/openqa/selenium/grid/distributor/local/LocalGridModel.java",
"java/src/org/openqa/selenium/grid/distributor/r... | [
{
"comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Downloads dir index crash <code>🐞 Bug</code> <code>☼ Reliability</code>\n\n<pre>\nLocalNode.downloadFile() indexes listFiles()[0] without checking for null/empty, which c... | diff --git a/java/test/org/openqa/selenium/bidi/browser/BrowserCommandsTest.java b/java/test/org/openqa/selenium/bidi/browser/BrowserCommandsTest.java
index eb196ca12a034..91d4b616a25cd 100644
--- a/java/test/org/openqa/selenium/bidi/browser/BrowserCommandsTest.java
+++ b/java/test/org/openqa/selenium/bidi/browser/Brow... | true | |
SeleniumHQ/selenium | 17,599 | comment_to_fix | Add logs to Grid to debug downloading files | <img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required">
1\. Downloads dir index crash <code>🐞 Bug</code> <code>☼ Reliability</code>
<pre>
LocalNode.downloadFile() indexes listFiles()[0] without checking for null/empty, which can throw
ArrayIndexOutOfBoundsExce... | d59db6d9a91c0add575a46d8f033fb33923da7e5 | 11bbff4227d11ba2585f9427bef6322310c04a68 | diff --git a/java/src/org/openqa/selenium/grid/node/local/LocalNode.java b/java/src/org/openqa/selenium/grid/node/local/LocalNode.java
index 96dbf0b0ca60e..06b78eaa89405 100644
--- a/java/src/org/openqa/selenium/grid/node/local/LocalNode.java
+++ b/java/src/org/openqa/selenium/grid/node/local/LocalNode.java
@@ -610,6 +... | [
"java/src/org/openqa/selenium/grid/node/local/LocalNode.java"
] | [
{
"comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Downloads dir index crash <code>🐞 Bug</code> <code>☼ Reliability</code>\n\n<pre>\nLocalNode.downloadFile() indexes listFiles()[0] without checking for null/empty, which c... | true | ||
SeleniumHQ/selenium | 17,599 | comment_to_fix | Add logs to Grid to debug downloading files | this might leak userinfo from the url to the logs. | d59db6d9a91c0add575a46d8f033fb33923da7e5 | 11bbff4227d11ba2585f9427bef6322310c04a68 | diff --git a/java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java b/java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java
index 24f09edd3fc4e..e56d60efd717e 100644
--- a/java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java
+++ b/java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.... | [
"java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java"
] | [
{
"comment": "this might leak userinfo from the url to the logs.",
"path": "java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java",
"hunk": "@@ -161,7 +161,11 @@ public WebSocket openSocket(HttpRequest request, WebSocket.Listener listener) {\n try {\n uri = getWebSocketUri(request);\... | true | ||
SeleniumHQ/selenium | 17,599 | comment_to_fix | Add logs to Grid to debug downloading files | this might leak userinfo from the url to the logs. | d59db6d9a91c0add575a46d8f033fb33923da7e5 | 11bbff4227d11ba2585f9427bef6322310c04a68 | diff --git a/java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java b/java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java
index 24f09edd3fc4e..e56d60efd717e 100644
--- a/java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java
+++ b/java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.... | [
"java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java"
] | [
{
"comment": "this might leak userinfo from the url to the logs.",
"path": "java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java",
"hunk": "@@ -251,13 +255,16 @@ public void onError(java.net.http.WebSocket webSocket, Throwable error) {\n } catch (ExecutionException e) {\n Throwable ... | true | ||
SeleniumHQ/selenium | 17,599 | comment_to_fix | Add logs to Grid to debug downloading files | this might leak userinfo from the url to the logs. | d59db6d9a91c0add575a46d8f033fb33923da7e5 | 11bbff4227d11ba2585f9427bef6322310c04a68 | diff --git a/java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java b/java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java
index 24f09edd3fc4e..e56d60efd717e 100644
--- a/java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java
+++ b/java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.... | [
"java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java"
] | [
{
"comment": "this might leak userinfo from the url to the logs.",
"path": "java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java",
"hunk": "@@ -251,13 +255,16 @@ public void onError(java.net.http.WebSocket webSocket, Throwable error) {\n } catch (ExecutionException e) {\n Throwable ... | true | ||
SeleniumHQ/selenium | 17,599 | comment_to_fix | Add logs to Grid to debug downloading files | this might leak userinfo from the url to the logs. | d59db6d9a91c0add575a46d8f033fb33923da7e5 | 11bbff4227d11ba2585f9427bef6322310c04a68 | diff --git a/java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java b/java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java
index 24f09edd3fc4e..e56d60efd717e 100644
--- a/java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java
+++ b/java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.... | [
"java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java"
] | [
{
"comment": "this might leak userinfo from the url to the logs.",
"path": "java/src/org/openqa/selenium/remote/http/jdk/JdkHttpClient.java",
"hunk": "@@ -251,13 +255,16 @@ public void onError(java.net.http.WebSocket webSocket, Throwable error) {\n } catch (ExecutionException e) {\n Throwable ... | true | ||
SeleniumHQ/selenium | 17,610 | issue_to_patch | [build] use pinned browser and driver for starting grid in python and ruby tests | Several long-running tests on GitHub actions are running out of disk space because #17602 deleted the installed browsers.
The expectation is that either browsers are pinned, or selenium manager caches the binaries on HOME.
Except there are 3 issues with this
1. When Ruby and Python run tests against the grid the... | 25d50fb61c3290bcbdda186f932ec520314cc29d | 1c0b3c97a265b09d996cbc2e0ef5c66036f733ce | diff --git a/.bazelrc.remote b/.bazelrc.remote
index d659f8bda4130..464d3526a9c3c 100644
--- a/.bazelrc.remote
+++ b/.bazelrc.remote
@@ -41,6 +41,9 @@ build:rbe --action_env=PATH=/bin:/usr/bin:/usr/local/bin
test:rbe --test_env=PATH=/bin:/usr/bin:/usr/local/bin
test:rbe --test_env=HOME=/home/dev
+# This should only... | [
".bazelrc.remote",
"java/src/org/openqa/selenium/grid/node/config/NodeFlags.java",
"py/conftest.py",
"py/selenium/webdriver/remote/server.py",
"py/test/selenium/webdriver/remote/remote_server_tests.py",
"py/test/unit/selenium/webdriver/remote/remote_server_tests.py",
"rb/spec/integration/selenium/webdri... | [
{
"comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Pinned args ignore drivers <code>🐞 Bug</code> <code>≡ Correctness</code>\n\n<pre>\nPython’s <b><i>_pinned_grid_args</i></b> selects only the first matching driver from <b... | diff --git a/py/test/selenium/webdriver/remote/remote_server_tests.py b/py/test/selenium/webdriver/remote/remote_server_tests.py
index b1ea60abaf18d..717f90be9dfd9 100644
--- a/py/test/selenium/webdriver/remote/remote_server_tests.py
+++ b/py/test/selenium/webdriver/remote/remote_server_tests.py
@@ -38,6 +38,10 @@ def ... | true | |
SeleniumHQ/selenium | 17,610 | comment_to_fix | [build] use pinned browser and driver for starting grid in python and ruby tests | <img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required">
1\. Pinned args ignore drivers <code>🐞 Bug</code> <code>≡ Correctness</code>
<pre>
Python’s <b><i>_pinned_grid_args</i></b> selects only the first matching driver from <b><i>--driver/--browser</i></b> (wh... | 25d50fb61c3290bcbdda186f932ec520314cc29d | 1c0b3c97a265b09d996cbc2e0ef5c66036f733ce | diff --git a/py/conftest.py b/py/conftest.py
index aa0a718cc8e49..c1f53000e644e 100644
--- a/py/conftest.py
+++ b/py/conftest.py
@@ -16,6 +16,7 @@
# under the License.
import http.server
+import json
import os
import socketserver
import sys
@@ -208,6 +209,43 @@ def _resolve_bazel_path(path):
return path
... | [
"py/conftest.py"
] | [
{
"comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Pinned args ignore drivers <code>🐞 Bug</code> <code>≡ Correctness</code>\n\n<pre>\nPython’s <b><i>_pinned_grid_args</i></b> selects only the first matching driver from <b... | true | ||
SeleniumHQ/selenium | 17,610 | comment_to_fix | [build] use pinned browser and driver for starting grid in python and ruby tests | `driver_configuration` adds a vendor options `binary` capability whenever `driver_path` is set, but `browser_path` may be unset. That produces a stereotype with `binary: null`, which can cause Grid/node startup or session matching failures. Only set the vendor options when a browser binary path is actually present. | 25d50fb61c3290bcbdda186f932ec520314cc29d | 1c0b3c97a265b09d996cbc2e0ef5c66036f733ce | diff --git a/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb b/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb
index e4109b88f5ebd..8ce4419095f4b 100644
--- a/rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb
+++ b/rb/spec/integration/selenium/webdri... | [
"rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb"
] | [
{
"comment": "`driver_configuration` adds a vendor options `binary` capability whenever `driver_path` is set, but `browser_path` may be unset. That produces a stereotype with `binary: null`, which can cause Grid/node startup or session matching failures. Only set the vendor options when a browser binary path is... | true | ||
SeleniumHQ/selenium | 17,610 | comment_to_fix | [build] use pinned browser and driver for starting grid in python and ruby tests | `Server` now supports overriding the standalone server CLI args via the new `args` parameter, but the existing unit tests for this class don't cover the default args behavior or the override path. Adding a small unit test would help prevent regressions in how the final `command` list is constructed. | 25d50fb61c3290bcbdda186f932ec520314cc29d | 1c0b3c97a265b09d996cbc2e0ef5c66036f733ce | diff --git a/py/selenium/webdriver/remote/server.py b/py/selenium/webdriver/remote/server.py
index 615a9963fa0b2..6c2ed89b351d9 100644
--- a/py/selenium/webdriver/remote/server.py
+++ b/py/selenium/webdriver/remote/server.py
@@ -44,8 +44,13 @@ class Server:
Available levels: "SEVERE", "WARNING", "INFO", "C... | [
"py/selenium/webdriver/remote/server.py"
] | [
{
"comment": "`Server` now supports overriding the standalone server CLI args via the new `args` parameter, but the existing unit tests for this class don't cover the default args behavior or the override path. Adding a small unit test would help prevent regressions in how the final `command` list is constructe... | true | ||
SeleniumHQ/selenium | 17,610 | comment_to_fix | [build] use pinned browser and driver for starting grid in python and ruby tests | <img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required">
1\. Empty cache path uses cwd <code>🐞 Bug</code> <code>☼ Reliability</code>
<pre>
<b><i>.bazelrc.remote</i></b> forces <b><i>SE_CACHE_PATH</i></b> to an empty string for <b><i>test:rbe</i></b>, which the ... | 25d50fb61c3290bcbdda186f932ec520314cc29d | 1c0b3c97a265b09d996cbc2e0ef5c66036f733ce | diff --git a/.bazelrc.remote b/.bazelrc.remote
index d659f8bda4130..464d3526a9c3c 100644
--- a/.bazelrc.remote
+++ b/.bazelrc.remote
@@ -41,6 +41,9 @@ build:rbe --action_env=PATH=/bin:/usr/bin:/usr/local/bin
test:rbe --test_env=PATH=/bin:/usr/bin:/usr/local/bin
test:rbe --test_env=HOME=/home/dev
+# This should only... | [
".bazelrc.remote"
] | [
{
"comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. Empty cache path uses cwd <code>🐞 Bug</code> <code>☼ Reliability</code>\n\n<pre>\n<b><i>.bazelrc.remote</i></b> forces <b><i>SE_CACHE_PATH</i></b> to an empty string for ... | true | ||
SeleniumHQ/selenium | 17,604 | issue_to_patch | [rb] tag integration tests with browser family | It's not obvious what filtering for "chrome" tag is supposed to do in Ruby.
We have chrome-remote, chrome-beta, chrome-beta-bidi, chrome-beta-remote, etc
Bazel's `--test_tag_filters` does exact matching, so filtering on `chrome` only catches the local target — never beta, remote, or bidi siblings. Fanning out to "ever... | 2eaf118a849488c65c84b00344bcbf1956cfb9bb | c450ceadb2b65102534c8f87042b88bea88431db | diff --git a/.github/workflows/ci-ruby.yml b/.github/workflows/ci-ruby.yml
index 5af21e568b541..9f71339a14b2e 100644
--- a/.github/workflows/ci-ruby.yml
+++ b/.github/workflows/ci-ruby.yml
@@ -84,6 +84,6 @@ jobs:
--flaky_test_attempts 2
--local_test_jobs 1
--test_size_filters large
- -... | [
".github/workflows/ci-ruby.yml",
"README.md",
"rb/spec/integration/selenium/webdriver/bidi/browsing_context_spec.rb",
"rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb",
"rb/spec/tests.bzl"
] | [] | diff --git a/rb/spec/integration/selenium/webdriver/bidi/browsing_context_spec.rb b/rb/spec/integration/selenium/webdriver/bidi/browsing_context_spec.rb
index bcad86441d1bc..9d89b066c0d04 100644
--- a/rb/spec/integration/selenium/webdriver/bidi/browsing_context_spec.rb
+++ b/rb/spec/integration/selenium/webdriver/bidi/... | true | |
SeleniumHQ/selenium | 17,606 | issue_to_patch | [py] Extract feature-specific modules from //py:common | ## Summary
- Five modules were bundled in `//py:common` but are only imported by a small subset of tests. Changing any of them triggered a full rebuild of all ~700 browser test targets.
- This PR extracts them into dedicated libraries and wires per-feature test sub-suites so that the dep graph is precise.
## New libr... | 2eaf118a849488c65c84b00344bcbf1956cfb9bb | 75b5d2044fd7a183d58abeb45d18abc83df26823 | diff --git a/py/BUILD.bazel b/py/BUILD.bazel
index ce379617cf6d2..190c359c69cf0 100644
--- a/py/BUILD.bazel
+++ b/py/BUILD.bazel
@@ -296,8 +296,13 @@ py_library(
exclude = [
"selenium/webdriver/common/action_chains.py",
"selenium/webdriver/common/actions/**",
+ "selenium/we... | [
"py/BUILD.bazel",
"py/selenium/webdriver/remote/webdriver.py"
] | [] | true | ||
SeleniumHQ/selenium | 17,589 | issue_to_patch | [rust] Switch reqwest TLS backend from aws-lc-rs to ring | ## Summary
- Switches `reqwest` from the `rustls` feature to `rustls-no-provider`, eliminating the `aws-lc-rs` → `aws-lc-sys` dependency chain
- Adds a direct `rustls` dependency with the `ring` feature so ring is the only compiled crypto provider
- Installs ring as the process-default TLS provider at startup in `main... | abd7aa29444443c581e96ccaef3901f7c4587c18 | 88621a319dc662639fef126251a1dac4f8a8672d | diff --git a/rust/Cargo.lock b/rust/Cargo.lock
index 93146b57f4484..82b53e19960ad 100644
--- a/rust/Cargo.lock
+++ b/rust/Cargo.lock
@@ -162,31 +162,9 @@ checksum = "1505bd5d3d116872e7271a6d4e16d81d0c8570876c8de68093a09ac269d8aac0"
[[package]]
name = "autocfg"
-version = "1.5.0"
-source = "registry+https://github.c... | [
"rust/Cargo.lock",
"rust/Cargo.toml",
"rust/src/lib.rs"
] | [] | true | ||
SeleniumHQ/selenium | 17,605 | issue_to_patch | [py] Extract actions subpackage into //py:common_actions | ## Summary
- The `actions/` subpackage and `action_chains.py` were part of the monolithic `//py:common` library, which every browser test depends on. Changing any file in `actions/` triggered a full rebuild of all ~700 test targets across every browser × OS combination.
- Only 4 test files actually import from `action... | 6a6846609c11d182aa46c18601e09fa043a1d94f | 95615ca9af29ee1d6a1e08aa066ecab1f73f8c63 | diff --git a/py/BUILD.bazel b/py/BUILD.bazel
index 860b96289d930..ce379617cf6d2 100644
--- a/py/BUILD.bazel
+++ b/py/BUILD.bazel
@@ -294,6 +294,8 @@ py_library(
srcs = glob(
["selenium/webdriver/common/**/*.py"],
exclude = [
+ "selenium/webdriver/common/action_chains.py",
+ ... | [
"py/BUILD.bazel",
"py/private/suite.bzl"
] | [] | true | ||
SeleniumHQ/selenium | 17,376 | issue_to_patch | [java][BiDi] add clearListners via browsingContextIds for inspectors | <!-- Thanks for Contributing to Selenium! -->
<!-- Please read our contribution guidelines: https://github.com/SeleniumHQ/selenium/blob/trunk/CONTRIBUTING.md -->
### 🔗 Related Issues
<!-- Example: Fixes #1234 or Closes #5678 -->
<!-- If the reason for this PR is not obvious, consider creating an issue for it fir... | 50613c290e4ddc1d39376f0a7935b61bab4bac75 | 06b140c080d705150a6a7e439da22a930c42dd16 | diff --git a/java/src/org/openqa/selenium/bidi/BiDi.java b/java/src/org/openqa/selenium/bidi/BiDi.java
index 50b4ae35ca4f3..63d65ed52efb2 100644
--- a/java/src/org/openqa/selenium/bidi/BiDi.java
+++ b/java/src/org/openqa/selenium/bidi/BiDi.java
@@ -24,6 +24,8 @@
import java.util.List;
import java.util.Map;
import ja... | [
"java/src/org/openqa/selenium/bidi/BiDi.java",
"java/src/org/openqa/selenium/bidi/module/BrowsingContextInspector.java",
"java/src/org/openqa/selenium/bidi/module/LogInspector.java",
"java/src/org/openqa/selenium/bidi/module/SpeculationInspector.java",
"java/test/org/openqa/selenium/bidi/browsingcontext/Bro... | [
{
"comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. <b><i>clearlisteners</i></b> accepts empty set <code>📘 Rule violation</code> <code>≡ Correctness</code>\n\n<pre>\nNew <b><i>clearListener(Set<String>, ...)</i></b> ... | diff --git a/java/test/org/openqa/selenium/bidi/browsingcontext/BrowsingContextInspectorTest.java b/java/test/org/openqa/selenium/bidi/browsingcontext/BrowsingContextInspectorTest.java
index 46045194da2a0..c9b7ba10d5c14 100644
--- a/java/test/org/openqa/selenium/bidi/browsingcontext/BrowsingContextInspectorTest.java
++... | true | |
SeleniumHQ/selenium | 17,376 | comment_to_fix | [java][BiDi] add clearListners via browsingContextIds for inspectors | <img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required">
1\. <b><i>clearlisteners</i></b> accepts empty set <code>📘 Rule violation</code> <code>≡ Correctness</code>
<pre>
New <b><i>clearListener(Set<String>, ...)</i></b> APIs only validate non-null input,... | 50613c290e4ddc1d39376f0a7935b61bab4bac75 | 06b140c080d705150a6a7e439da22a930c42dd16 | diff --git a/java/src/org/openqa/selenium/bidi/BiDi.java b/java/src/org/openqa/selenium/bidi/BiDi.java
index 50b4ae35ca4f3..63d65ed52efb2 100644
--- a/java/src/org/openqa/selenium/bidi/BiDi.java
+++ b/java/src/org/openqa/selenium/bidi/BiDi.java
@@ -24,6 +24,8 @@
import java.util.List;
import java.util.Map;
import ja... | [
"java/src/org/openqa/selenium/bidi/BiDi.java"
] | [
{
"comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. <b><i>clearlisteners</i></b> accepts empty set <code>📘 Rule violation</code> <code>≡ Correctness</code>\n\n<pre>\nNew <b><i>clearListener(Set<String>, ...)</i></b> ... | true | ||
SeleniumHQ/selenium | 17,376 | comment_to_fix | [java][BiDi] add clearListners via browsingContextIds for inspectors | <img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required">
2\. Context clear drops callbacks <code>🐞 Bug</code> <code>≡ Correctness</code>
<pre>
<b><i>BiDi.clearListener(Set<String>, Event)</i></b> unsubscribes for specific contexts but then removes the
ent... | 50613c290e4ddc1d39376f0a7935b61bab4bac75 | 06b140c080d705150a6a7e439da22a930c42dd16 | diff --git a/java/src/org/openqa/selenium/bidi/BiDi.java b/java/src/org/openqa/selenium/bidi/BiDi.java
index 50b4ae35ca4f3..63d65ed52efb2 100644
--- a/java/src/org/openqa/selenium/bidi/BiDi.java
+++ b/java/src/org/openqa/selenium/bidi/BiDi.java
@@ -24,6 +24,8 @@
import java.util.List;
import java.util.Map;
import ja... | [
"java/src/org/openqa/selenium/bidi/BiDi.java"
] | [
{
"comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n2\\. Context clear drops callbacks <code>🐞 Bug</code> <code>≡ Correctness</code>\n\n<pre>\n<b><i>BiDi.clearListener(Set<String>, Event)</i></b> unsubscribes for specific... | true | ||
SeleniumHQ/selenium | 17,376 | comment_to_fix | [java][BiDi] add clearListners via browsingContextIds for inspectors | <img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required">
3\. Loginspector close no-ops <code>🐞 Bug</code> <code>☼ Reliability</code>
<pre>
<b><i>LogInspector.close()</i></b> creates a new <b><i>Event</i></b> instance (<b><i>Log.entryAdded()</i></b>) when cleari... | 50613c290e4ddc1d39376f0a7935b61bab4bac75 | 06b140c080d705150a6a7e439da22a930c42dd16 | diff --git a/java/src/org/openqa/selenium/bidi/module/LogInspector.java b/java/src/org/openqa/selenium/bidi/module/LogInspector.java
index cc1d30f8bf7b2..26fb5415ffe14 100644
--- a/java/src/org/openqa/selenium/bidi/module/LogInspector.java
+++ b/java/src/org/openqa/selenium/bidi/module/LogInspector.java
@@ -152,8 +152,... | [
"java/src/org/openqa/selenium/bidi/module/LogInspector.java"
] | [
{
"comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n3\\. Loginspector close no-ops <code>🐞 Bug</code> <code>☼ Reliability</code>\n\n<pre>\n<b><i>LogInspector.close()</i></b> creates a new <b><i>Event</i></b> instance (<b><i>Log... | true | ||
SeleniumHQ/selenium | 17,376 | comment_to_fix | [java][BiDi] add clearListners via browsingContextIds for inspectors | <img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required">
1\. <b><i>contextlistenerids</i></b> map not synchronized <code>📘 Rule violation</code> <code>☼ Reliability</code>
<pre>
<b><i>BiDi</i></b> introduces shared mutable state (<b><i>contextListenerIds</i></b... | 50613c290e4ddc1d39376f0a7935b61bab4bac75 | 06b140c080d705150a6a7e439da22a930c42dd16 | diff --git a/java/src/org/openqa/selenium/bidi/BiDi.java b/java/src/org/openqa/selenium/bidi/BiDi.java
index 50b4ae35ca4f3..63d65ed52efb2 100644
--- a/java/src/org/openqa/selenium/bidi/BiDi.java
+++ b/java/src/org/openqa/selenium/bidi/BiDi.java
@@ -24,6 +24,8 @@
import java.util.List;
import java.util.Map;
import ja... | [
"java/src/org/openqa/selenium/bidi/BiDi.java"
] | [
{
"comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. <b><i>contextlistenerids</i></b> map not synchronized <code>📘 Rule violation</code> <code>☼ Reliability</code>\n\n<pre>\n<b><i>BiDi</i></b> introduces shared mutable stat... | true | ||
SeleniumHQ/selenium | 17,376 | comment_to_fix | [java][BiDi] add clearListners via browsingContextIds for inspectors | <img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required">
2\. String context clears globally <code>🐞 Bug</code> <code>≡ Correctness</code>
<pre>
<b><i>BiDi.addListener(String, ...)</i></b> performs a context-scoped <b><i>session.subscribe</i></b> but does not re... | 50613c290e4ddc1d39376f0a7935b61bab4bac75 | 06b140c080d705150a6a7e439da22a930c42dd16 | diff --git a/java/src/org/openqa/selenium/bidi/BiDi.java b/java/src/org/openqa/selenium/bidi/BiDi.java
index 50b4ae35ca4f3..63d65ed52efb2 100644
--- a/java/src/org/openqa/selenium/bidi/BiDi.java
+++ b/java/src/org/openqa/selenium/bidi/BiDi.java
@@ -24,6 +24,8 @@
import java.util.List;
import java.util.Map;
import ja... | [
"java/src/org/openqa/selenium/bidi/BiDi.java"
] | [
{
"comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n2\\. String context clears globally <code>🐞 Bug</code> <code>≡ Correctness</code>\n\n<pre>\n<b><i>BiDi.addListener(String, ...)</i></b> performs a context-scoped <b><i>session... | true | ||
SeleniumHQ/selenium | 17,376 | comment_to_fix | [java][BiDi] add clearListners via browsingContextIds for inspectors | <img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required">
1\. <b><i>receivedentries</i></b> arraylist data race <code>📘 Rule violation</code> <code>☼ Reliability</code>
<pre>
<b><i>LogInspectorTest</i></b> mutates a plain <b><i>ArrayList</i></b> (<b><i>receivedE... | 50613c290e4ddc1d39376f0a7935b61bab4bac75 | 06b140c080d705150a6a7e439da22a930c42dd16 | diff --git a/java/test/org/openqa/selenium/bidi/log/LogInspectorTest.java b/java/test/org/openqa/selenium/bidi/log/LogInspectorTest.java
index 35ddedfaf8a58..bff1d5ee11e22 100644
--- a/java/test/org/openqa/selenium/bidi/log/LogInspectorTest.java
+++ b/java/test/org/openqa/selenium/bidi/log/LogInspectorTest.java
@@ -20,... | [
"java/test/org/openqa/selenium/bidi/log/LogInspectorTest.java"
] | [
{
"comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n1\\. <b><i>receivedentries</i></b> arraylist data race <code>📘 Rule violation</code> <code>☼ Reliability</code>\n\n<pre>\n<b><i>LogInspectorTest</i></b> mutates a plain <b><i>... | true | ||
SeleniumHQ/selenium | 17,376 | comment_to_fix | [java][BiDi] add clearListners via browsingContextIds for inspectors | <img src="https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png" height="20" alt="Action required">
2\. <b><i>events</i></b> arraylist data race <code>📘 Rule violation</code> <code>☼ Reliability</code>
<pre>
<b><i>SpeculationInspectorTest</i></b> mutates plain <b><i>ArrayList</i></b> instances (<b><i>ev... | 50613c290e4ddc1d39376f0a7935b61bab4bac75 | 06b140c080d705150a6a7e439da22a930c42dd16 | diff --git a/java/test/org/openqa/selenium/bidi/speculation/SpeculationInspectorTest.java b/java/test/org/openqa/selenium/bidi/speculation/SpeculationInspectorTest.java
index 459a3e058bbe3..249db36281109 100644
--- a/java/test/org/openqa/selenium/bidi/speculation/SpeculationInspectorTest.java
+++ b/java/test/org/openqa... | [
"java/test/org/openqa/selenium/bidi/speculation/SpeculationInspectorTest.java"
] | [
{
"comment": "<img src=\"https://www.qodo.ai/wp-content/uploads/2026/01/action-required.png\" height=\"20\" alt=\"Action required\">\n\n2\\. <b><i>events</i></b> arraylist data race <code>📘 Rule violation</code> <code>☼ Reliability</code>\n\n<pre>\n<b><i>SpeculationInspectorTest</i></b> mutates plain <b><i>Arr... | true | ||
Semantic-Org/Semantic-UI | 881 | issue_to_patch | Clarify meaning of "secondary menu"
http://semantic-ui.com/collections/menu.html defines a secondary menu as: `A secondary menu allows for a section of content on a page to be activated`.
I don't understand this explanation. If the menu is supposed to "activate" a section of content on a page, why does nothing happen... | Clarifying intended use of the secondary menu (fixes #875) | This fixes #875 by clarifying that the secondary menu doesn't have any special behavior by itself, it's just good for formatting sections on a page.
| cbcdb1f4a91588c437ee878ad142a00c80f40413 | 3f239e660c23be57c5697d2f73e1e76957346e94 | diff --git a/server/documents/collections/menu.html.eco b/server/documents/collections/menu.html.eco
index f6f537ac8f..b1515ff80f 100755
--- a/server/documents/collections/menu.html.eco
+++ b/server/documents/collections/menu.html.eco
@@ -47,7 +47,7 @@ type : 'UI Collection'
<div class="example">
<h4 c... | [
"server/documents/collections/menu.html.eco"
] | [] | true | |
Semantic-Org/Semantic-UI | 7,103 | issue_to_patch | fixed typo | $subject | daa2438f048e6d98a330171a83ec74c3a13e9bd1 | f84dc09c6a9dd3d63aa1e00953b5244cb784c7ed | diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index b0d268c1ba..d811dd1651 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -5,7 +5,7 @@
Questions about usage should be asked in our [Gitter chatroom](https://gitter.im/Semantic-Org/Semantic-UI), on [Semantic UI forums](http://forums.semantic-ui.com) or [StackOver... | [
"CONTRIBUTING.md"
] | [] | true | ||
Semantic-Org/Semantic-UI | 7,089 | issue_to_patch | [BUG] Error using semantic-ui-css to create-react-app
### Title (Put in field above)
Use the format: [Component] Component Should Do X
i.e. [Checkbox] onChange Should Fire When Update Triggered via DOM
### Steps
1). Create proyect React to command
`npx create-react-app myapp`
2). Move to folder project
`cd ... | remove extra semicolon | Webpack v5's CSS loader fails when seeing this double semicolon. The error looks something like:
```
Module build failed (from ./node_modules/mini-css-extract-plugin/dist/loader.js):
TypeError: Cannot read property 'get' of undefined
at /var/www/node_modules/webpack/lib/asset/AssetModulesPlugin.js:212:52
... | 825c5b7e21b3bbe277a8a4034a931e79979f2476 | d965bead0224a08e524d9befb3ea094fbccee270 | diff --git a/src/themes/default/elements/step.overrides b/src/themes/default/elements/step.overrides
index e7aca52513..98f3e69028 100644
--- a/src/themes/default/elements/step.overrides
+++ b/src/themes/default/elements/step.overrides
@@ -5,7 +5,7 @@
@font-face {
font-family: 'Step';
src:
- url(data:applicati... | [
"src/themes/default/elements/step.overrides"
] | [] | true | |
Semantic-Org/Semantic-UI | 7,023 | issue_to_patch | [Icon] Fixed background issue when Icon is used as Labeled Icon for Button as loading one | ### Description
See my initial issue https://github.com/Semantic-Org/Semantic-UI-React/issues/4088
I moved `icon-loading` animation into `:before` element itself.
### Testcase
**Before**: https://jsfiddle.net/afkm1v7w/
**After**: https://jsfiddle.net/t16y3wLk/
(I demonstrated my changes in temporary CSS ... | 9fe42b1bff3ad5d5237b0151774c8cfab871cce1 | 3c179e96b3621456174b466d2facdd270ccd7554 | diff --git a/src/definitions/elements/icon.less b/src/definitions/elements/icon.less
index 88b870d3dc..0cfc3dee29 100755
--- a/src/definitions/elements/icon.less
+++ b/src/definitions/elements/icon.less
@@ -71,15 +71,19 @@ i.icon:before {
i.icon.loading {
height: 1em;
line-height: 1;
+}
+
+i.icon.loading:before ... | [
"src/definitions/elements/icon.less"
] | [] | true | ||
Semantic-Org/Semantic-UI | 6,833 | issue_to_patch | [Modal] destroy should tear down mutation observer
### Steps
- Show a modal with `{observeChanges: true}`
- Hide the modal (either programmatically or by, e.g. clicking on the dimmer)
- Some DOM updates are performed during the hide/destruction phase of the modal
### Expected Result
Scroll lock is removed f... | [Modal] Tears down mutation observer on modal destruction | Fixes #6832 | b2e83777090c6b8737283ccb17544633964014a3 | 9b49d4935230f731c78ecaac53bcd34f52a3588b | diff --git a/src/definitions/modules/modal.js b/src/definitions/modules/modal.js
index d2793ee0a7..915b2c29dd 100755
--- a/src/definitions/modules/modal.js
+++ b/src/definitions/modules/modal.js
@@ -138,6 +138,9 @@ $.fn.modal = function(parameters) {
},
destroy: function() {
+ if (observer)... | [
"src/definitions/modules/modal.js"
] | [
{
"comment": "`if (observer)` should do it alone, because this variable is already declared here https://github.com/Semantic-Org/Semantic-UI/blob/0a42dcdcb400d6fc275b04d6cb052a48efd68536/src/definitions/modules/modal.js#L79",
"path": "src/definitions/modules/modal.js",
"hunk": "@@ -138,6 +138,9 @@ $.fn.... | true | |
Semantic-Org/Semantic-UI | 3,665 | issue_to_patch | fix modal/dimmer inverted bug #3192 | During the second dimmer run the color was extracted from the DOM. At
least Firefox automatically converts RGBA to RGB if possible which
caused the bug.
With this fix the dimmer module can now detect both RGB and RGBA colors.
| 7599cf8d26e6055db186479349c8cb2e6555d8ee | a385ee5f627a297e305f88b7bd210276df66d20f | diff --git a/src/definitions/modules/dimmer.js b/src/definitions/modules/dimmer.js
index c68d904799..d972cec68c 100644
--- a/src/definitions/modules/dimmer.js
+++ b/src/definitions/modules/dimmer.js
@@ -383,10 +383,11 @@ $.fn.dimmer = function(parameters) {
var
color = $dimmer.css('back... | [
"src/definitions/modules/dimmer.js"
] | [] | true | ||
Semantic-Org/Semantic-UI | 6,815 | issue_to_patch | [Build Tools] Fix invalid composer.json file. | Invalid `composer.json` file caused issues when installing Semantic UI in my theme folder in a Sylius project. It searches for `composer.json` files and validates them. Because it was invalid Sylius/Symfony would throw a configuration error.
## Testing steps
Go into `tasks/config/admin/templates` and run `composer ... | 724bb8bf851bf11d00cba271083c5cc5d71205f2 | f31b03bc6080b25f61301c6e91b5be7fae015d6b | diff --git a/tasks/config/admin/templates/composer.json b/tasks/config/admin/templates/composer.json
index b47d2e17a7..1cc402e5d6 100644
--- a/tasks/config/admin/templates/composer.json
+++ b/tasks/config/admin/templates/composer.json
@@ -6,7 +6,7 @@
{
"name" : "Jack Lukic",
"email": "jacklukic@gmail... | [
"tasks/config/admin/templates/composer.json"
] | [] | true | ||
Semantic-Org/Semantic-UI | 4,631 | issue_to_patch | Fix inverted dimmer text color | The definition references the wrong variable: `@textColor` instead of `@invertedTextColor` which is defined in https://github.com/Semantic-Org/Semantic-UI/blob/ebb1cab098cad4509d8b173bd1d185b7472711f6/src/themes/default/modules/dimmer.variables#L54.
| 0992f41e90c1cb9702c5b506af1549822d3bf912 | bb35b93c4ca8eb0cfeeb759f38fa8f4cd3542cb6 | diff --git a/src/definitions/modules/dimmer.less b/src/definitions/modules/dimmer.less
index ff6c60503e..2f09736ac8 100755
--- a/src/definitions/modules/dimmer.less
+++ b/src/definitions/modules/dimmer.less
@@ -153,7 +153,7 @@ body.dimmable > .dimmer {
background-color: @invertedBackgroundColor;
}
.ui.inverted.dim... | [
"src/definitions/modules/dimmer.less"
] | [] | true | ||
Semantic-Org/Semantic-UI | 7,047 | issue_to_patch | [Docs] Fix first link to gitter.im | ### Description
The first link to Gitter isn't a link...
(I'm partially filing this to see if this project is still alive.) | deb275d2d5fe9a522a0b7bd8b6b6a1c939552718 | 38de2884d3424eb300d35972f33d33bbc6aa6d58 | diff --git a/README.md b/README.md
index 974c20e77c..3c0446fe98 100644
--- a/README.md
+++ b/README.md
@@ -68,7 +68,7 @@ Although some components will work in IE9, [grids](http://semantic-ui.com/collec
## Community
#### Getting Help
-Please **do not post** usage questions to GitHub Issues. For these types of questi... | [
"README.md"
] | [] | true | ||
Semantic-Org/Semantic-UI | 7,062 | issue_to_patch | Fix typo in dimmer.js | occured -> occurred
| deb275d2d5fe9a522a0b7bd8b6b6a1c939552718 | 6879d3aa662dd39b96c8c9bb089b0d199de5e343 | diff --git a/src/definitions/modules/dimmer.js b/src/definitions/modules/dimmer.js
index 49bf63e601..a16cb663c1 100755
--- a/src/definitions/modules/dimmer.js
+++ b/src/definitions/modules/dimmer.js
@@ -151,7 +151,7 @@ $.fn.dimmer = function(parameters) {
event: {
click: function(event) {
- ... | [
"src/definitions/modules/dimmer.js"
] | [] | true | ||
Semantic-Org/Semantic-UI | 6,790 | issue_to_patch | [Build Tools] Meteor package: Use `api.addAssets` for static files | ### Description
Trying add the semantic-ui package to a meteor project raise the next error:
```
$ meteor add semantic:ui-css
=> Errors while adding packages:
While building package semantic:ui-css:
error: No plugin known to handle file 'themes/def... | c17037825839c77ed220c4594dcd0f8a2f39c92f | c3b231ffc407570b5a13b8f98566f0618b822b73 | diff --git a/tasks/config/admin/templates/css-package.js b/tasks/config/admin/templates/css-package.js
index 0949ce3c64..907c9feecb 100644
--- a/tasks/config/admin/templates/css-package.js
+++ b/tasks/config/admin/templates/css-package.js
@@ -15,7 +15,7 @@ Package.onUse(function(api) {
api.use('jquery', 'client');... | [
"tasks/config/admin/templates/css-package.js"
] | [] | true | ||
Semantic-Org/Semantic-UI | 6,876 | issue_to_patch | [Theme]: allow null @site | ### [Theme]: allow null @site
allow "null" values for @site theme config variable, like all other variables already allow.
as the default theme is always imported, using "null" values for all variables decreases dramatically the bundle size by avoiding duplicates when using default theme. this improvement is notice... | 42565016b2c8e87d0e437293a388466b6d80a436 | 191dcf4d63b3031968ad1384df7686435a9022f0 | diff --git a/src/theme.less b/src/theme.less
index ffaf4f8118..97bf99608a 100644
--- a/src/theme.less
+++ b/src/theme.less
@@ -16,7 +16,7 @@
@import "@{themesFolder}/default/globals/site.variables";
/* Packaged site.variables */
-@import "@{themesFolder}/@{site}/globals/site.variables";
+@import (optional) "@{theme... | [
"src/theme.less"
] | [] | true | ||
Semantic-Org/Semantic-UI | 6,983 | issue_to_patch | Gulp 4 | Adds V4 style gulp tasks | 22a0c7b413890d3daaa67e4f951aa5dce5c72de7 | eafcc70e934e266882e9a008eaa53074e4e3855b | diff --git a/.browserlistrc b/.browserlistrc
new file mode 100644
index 0000000000..ef556a3a01
--- /dev/null
+++ b/.browserlistrc
@@ -0,0 +1,5 @@
+last 2 versions
+> 1%
+opera 12.1
+bb 10
+android 4
diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
index faad1783f1..0fe483ecbc 100755
--- a/RELEASE-NOTES.md
+++ b/RELEASE... | [
".browserlistrc",
"RELEASE-NOTES.md",
"dist/components/accordion.css",
"dist/components/accordion.js",
"dist/components/accordion.min.css",
"dist/components/ad.css",
"dist/components/ad.min.css",
"dist/components/api.js",
"dist/components/breadcrumb.css",
"dist/components/breadcrumb.min.css",
"d... | [] | true | ||
Semantic-Org/Semantic-UI | 6,495 | issue_to_patch | Fixed scrolling for mobile devices while using dimmer (Fix #6449) | Module binding for a page did preventScroll. I fixed it, I moved the preventScroll to show event | 403a37799030c246db46aa45302f0c915c17b610 | e49faf0c01dd1f19017edcfae8bae139fa5413f2 | diff --git a/src/definitions/modules/dimmer.js b/src/definitions/modules/dimmer.js
index bdfc39abb2..985d4f3c84 100755
--- a/src/definitions/modules/dimmer.js
+++ b/src/definitions/modules/dimmer.js
@@ -114,10 +114,6 @@ $.fn.dimmer = function(parameters) {
bind: {
events: function() {
- ... | [
"src/definitions/modules/dimmer.js"
] | [] | true | ||
Semantic-Org/Semantic-UI | 6,562 | issue_to_patch | Legacy modals | Fixes #6185 #6267 #6272 and addresses the comment from `2.3.3`
Modal and dimmer are now implemented with a setting `useFlex` which either defaults to `auto` (modal) or `true` dimmer.
Fixes support for
* `detachable: false` modals not positioning correctly
* Multiple modals when `allowMultiple: true` not workin... | 403a37799030c246db46aa45302f0c915c17b610 | bbad43026d0d0c6f52a62d2d1260039f4657b397 | diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
index 96812b762d..c6a82c298d 100755
--- a/RELEASE-NOTES.md
+++ b/RELEASE-NOTES.md
@@ -1,5 +1,16 @@
## RELEASE NOTES
+### Version 2.3.4 - Aug xx, 2018
+
+**Enhancements**
+
+- **Modal/Dimmer** - Modals and dimmers now include a new setting `useFlex` which defaults to `... | [
"RELEASE-NOTES.md",
"src/definitions/modules/dimmer.js",
"src/definitions/modules/dimmer.less",
"src/definitions/modules/modal.js",
"src/definitions/modules/modal.less"
] | [] | true | ||
Semantic-Org/Semantic-UI | 6,171 | issue_to_patch | Add font weight global variables | Adds font weight variables ala #6167 | 43e71792b53b9e4c8eacdaae32b228464e5b61af | ff7e36982ff5f30040bfe778fca2ffdb3c8177ce | diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
index 5858d7cf16..59a44fe6d2 100755
--- a/RELEASE-NOTES.md
+++ b/RELEASE-NOTES.md
@@ -5,6 +5,7 @@
**Major Enhancements**
- **Icons** - Font Awesome 5 is now included in Semantic UI **Thanks @hammy2899** #6085
- **Search** - Category search can now work with local sear... | [
"RELEASE-NOTES.md",
"src/definitions/collections/table.less",
"src/definitions/elements/header.less",
"src/definitions/elements/icon.less",
"src/definitions/elements/input.less",
"src/definitions/elements/list.less",
"src/definitions/modules/popup.less",
"src/definitions/modules/rating.less",
"src/d... | [
{
"comment": "`@headerTextTransform: @normal;`\r\n\r\nThis is right? ",
"path": "src/themes/default/collections/menu.variables",
"hunk": "@@ -64,8 +64,8 @@\n \n /* Header */\n @headerBackground: '';\n-@headerWeight: bold;\n-@headerTextTransform: normal;\n+@headerWeight: @bold;\n+@headerTextTransform: @n... | true | ||
Semantic-Org/Semantic-UI | 6,447 | issue_to_patch | [Dependency] Add compatibility with Less 3.x | ### Closed Issues
https://github.com/Semantic-Org/Semantic-UI-LESS/issues/30
### Description
The two issues are related to commits in Less: less/less.js@9fd1ef5 and less/less.js@77fde7e. The first change causes variables to be undefined, the second change makes the `.loadFonts()` import the Google Fonts CSS incorr... | 44cf50b61ce2570190e56fc374beba2c68a9de33 | 92261675c25bfce8b1cf96aa5d70f6b07d2b93a6 | diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
index 8ac8380f50..aff2a141c9 100755
--- a/RELEASE-NOTES.md
+++ b/RELEASE-NOTES.md
@@ -1,20 +1,20 @@
## RELEASE NOTES
-### Version 2.3.2 - June 17, 2018
+### Version 2.3.2 - June 18, 2018
**Enhancements**
- **Modal** - Modal and Dimmer now prevent background page f... | [
"RELEASE-NOTES.md",
"src/README.md",
"src/theme.config.example",
"src/theme.less",
"tasks/admin/components/init.js",
"tasks/admin/components/update.js",
"tasks/admin/distributions/update.js"
] | [] | true | ||
Semantic-Org/Semantic-UI | 6,396 | issue_to_patch | Fixed some formatting | [src/readme.md] Fixed formatting and bash comments. | de1dc5d11e2fc7f844935074928f2dbb54729249 | ec7e0897b3a7cf9d45a777fb7eb94abf3cec3042 | diff --git a/src/README.md b/src/README.md
index b725d670f8..20d35241d9 100644
--- a/src/README.md
+++ b/src/README.md
@@ -3,6 +3,7 @@
### Built-In Tools
From the Semantic directory you can setup gulp to build Semantic by running.
+
```bash
npm install
```
@@ -10,11 +11,12 @@ npm install
Semantic will automatic... | [
"src/README.md"
] | [] | true | ||
Semantic-Org/Semantic-UI | 6,431 | issue_to_patch | Fix #6429: [Icon] Wechat icon doesn't display | ### Issue Titles
[Icon] Wechat icon doesn't display
### Closed Issues
#6429
### Description
Add wechat to 'brand-icons' overrides
| a91907027108cfe870c10e66a4e7f952dbdfb0d2 | b421dc2e397dc116be62700c15ac588ab9f2ac38 | diff --git a/.github/stale.yml b/.github/stale.yml
index ef6bb16ccb..e99f6ebef4 100644
--- a/.github/stale.yml
+++ b/.github/stale.yml
@@ -2,21 +2,32 @@
daysUntilStale: 90
# Number of days of inactivity before a stale issue is closed
-daysUntilClose: 30
+daysUntilClose: 90
# Issues with these labels will never b... | [
".github/stale.yml",
"src/themes/default/elements/icon.overrides"
] | [] | true | ||
Semantic-Org/Semantic-UI | 6,405 | issue_to_patch | [Site] fix @inputLineHeight comment spelling error | Minor change, as described | a6e8c0bd73715f55616adcf03888ad44bc44fe7b | 22ceceff9cc39a5483c12be2461a29032ae72d09 | diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
index 932187d054..38fc0a6636 100755
--- a/RELEASE-NOTES.md
+++ b/RELEASE-NOTES.md
@@ -1,6 +1,5 @@
## RELEASE NOTES
-
### Version 2.3.2 - June 17, 2018
**Enhancements**
@@ -14,31 +13,31 @@
### Version 2.3.1 - Mar 18, 2018
-**Note on Flex Modals**
-There will b... | [
"RELEASE-NOTES.md",
"src/themes/default/globals/site.variables"
] | [] | true | ||
Semantic-Org/Semantic-UI | 6,220 | issue_to_patch | [Label] Use basicBackground in all basic rules | Fixes #4476
As noted in the issue, currently, all `.ui.basic.labels` use a solid white background. This prevents there usage on any other color background.
The proposed fix was to use a transparent background. However, there is already a variable for basic background color. I've simply used that variable in a... | 18ecf158a355eaf8da8ff4844f0030aa72159d48 | a2fa55143405b6c903d12ee1afb310b574b875f5 | diff --git a/src/definitions/elements/label.less b/src/definitions/elements/label.less
index 58fced2b18..fcd066a1d7 100755
--- a/src/definitions/elements/label.less
+++ b/src/definitions/elements/label.less
@@ -566,7 +566,7 @@ a.ui.red.label:hover{
}
/* Basic */
.ui.basic.red.label {
- background-color: @white !imp... | [
"src/definitions/elements/label.less"
] | [] | true | ||
Semantic-Org/Semantic-UI | 3,492 | issue_to_patch | Add a style option | It allows some tools like `npm-css` and `postcss` to import styles from the node_modules directory. It's awesome to write just `@import "semantic-ui"` to load css.
| 49a8ea9d7222a7846ae685362aa6282d090a5bba | ed28bc046a32c808ac8242745f74afc879803b61 | diff --git a/package.json b/package.json
index b18ab866db..bcdb8d83a4 100644
--- a/package.json
+++ b/package.json
@@ -61,5 +61,6 @@
"gulp-git": "*",
"gulp-tap": "*",
"merge-stream": "*"
- }
+ },
+ "style": "dist/semantic.css"
}
| [
"package.json"
] | [] | true | ||
Semantic-Org/Semantic-UI | 4,157 | issue_to_patch | [Icon Input] Fix for issue #4057 | A fix for my own issue #4057 which pertained to having a multiple select dropdown inside a popup that was attached to an icon input.
The fix is that an icon input applies padding-right: @iconMargin !important; to all input children of an icon input. This caused problems with the inputs inside the popup which also rece... | 6fea79b6698974e755e8cf450f1f9abe137c90bc | 4731246f285a2ebcdd8a511111bb62f3f3ac3271 | diff --git a/src/definitions/elements/input.less b/src/definitions/elements/input.less
index fc4e5b604a..c935d53b00 100755
--- a/src/definitions/elements/input.less
+++ b/src/definitions/elements/input.less
@@ -273,7 +273,7 @@
.ui.icon.input > i.icon:not(.link) {
pointer-events: none;
}
-.ui.icon.input input {
+.u... | [
"src/definitions/elements/input.less"
] | [] | true | ||
Semantic-Org/Semantic-UI | 6,205 | issue_to_patch | Created issue template | Created an issue template as discussed https://github.com/Semantic-Org/Semantic-UI/issues/6109#issuecomment-366872453
Feel free to make changes 😄 | ee0b5cb222a23033a1847820bd92df45f04a1930 | 36f77a8791f0e7bb714cfd2ad27305fd83782325 | diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md
new file mode 100644
index 0000000000..a66fd7b515
--- /dev/null
+++ b/.github/ISSUE_TEMPLATE.md
@@ -0,0 +1,100 @@
+<!--
+
+ ✖ Please do not post usage questions to GitHub Issues.
+ For these types of questions use our Gitter chatroom or StackOverflo... | [
".github/ISSUE_TEMPLATE.md"
] | [] | true | ||
Semantic-Org/Semantic-UI | 6,226 | issue_to_patch | [Icons] FA5 Report | Reported FA5 using a new method so that the icons can use the FA5 font files. It also allows the ability to enable/disable solid, outline and brand icons so you can choose which icons you want in your theme. This method also eliminates the risk of bugs.
The method is using a much more reliable script to do the port ... | 050d182d6a473abd1b00bd02f2a42ab41fac82a2 | c1a450dad36f2058918f9c13c446e6f93a22b41f | diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
index 6288193b7d..bcd8c78770 100755
--- a/RELEASE-NOTES.md
+++ b/RELEASE-NOTES.md
@@ -8,6 +8,8 @@
**Bugs**
- **Dropdown** - Fixed `onChange` missing `text` from callback when dropdown is set to `action: 'select'` #4183 #4510
- **Search** - Fixes using category search ... | [
"RELEASE-NOTES.md",
"src/definitions/elements/icon.less",
"src/themes/default/assets/fonts/brand-icons.eot",
"src/themes/default/assets/fonts/brand-icons.svg",
"src/themes/default/assets/fonts/brand-icons.ttf",
"src/themes/default/assets/fonts/brand-icons.woff",
"src/themes/default/assets/fonts/brand-ic... | [] | true | ||
Semantic-Org/Semantic-UI | 6,225 | issue_to_patch | [Search] add disabled style | ### Closed Issues
#6158
### Description
Allow the disabled state for the search component. | 7fab7974a7ffa3a4c74ed760c41ae21d7407dc4e | c177e82cd03872cd8e7f00a269457540df3e2363 | diff --git a/src/definitions/modules/search.less b/src/definitions/modules/search.less
index e99146242a..06e7eced14 100755
--- a/src/definitions/modules/search.less
+++ b/src/definitions/modules/search.less
@@ -270,6 +270,18 @@
color: @resultActiveDescriptionColor;
}
+/*--------------------
+ Disabled
+---... | [
"src/definitions/modules/search.less"
] | [] | true | ||
Semantic-Org/Semantic-UI | 6,268 | issue_to_patch | [Menu] Disabled menu items still changing state on hover | ### Closed Issues
#6147
### Description
Previously, a disabled item in a ui.menu.secondary would still change state when hovered over.
This PR makes the relevant tags important, preventing this from happening
### Testcase
[Before](https://jsfiddle.net/awei01/xho6Lxv9/)
[Fixed](https://jsfiddle.net... | b78dc75fc17c93996dc2c1164b1c756f606fb4bc | b291a2641b708228177ea134efa36dd4ea5d1c7e | diff --git a/src/definitions/collections/menu.less b/src/definitions/collections/menu.less
index dff7744fb8..10ae94fc86 100755
--- a/src/definitions/collections/menu.less
+++ b/src/definitions/collections/menu.less
@@ -452,9 +452,9 @@
.ui.menu .item.disabled,
.ui.menu .item.disabled:hover {
- cursor: default;
+ c... | [
"src/definitions/collections/menu.less"
] | [] | true | ||
Semantic-Org/Semantic-UI | 4,510 | issue_to_patch | Fix for #4183 | `text` argument missing for select action
| 4eef97737bcaa349bfb0870ddd9ce6c6f1bcd110 | 77d2739079519f65b7c2545b4334b8dd8684a895 | diff --git a/src/definitions/modules/dropdown.js b/src/definitions/modules/dropdown.js
index 0ae40b02b7..0e6d78ef9f 100644
--- a/src/definitions/modules/dropdown.js
+++ b/src/definitions/modules/dropdown.js
@@ -1558,7 +1558,7 @@ $.fn.dropdown = function(parameters) {
: text
;
if... | [
"src/definitions/modules/dropdown.js"
] | [] | true | ||
Semantic-Org/Semantic-UI | 6,223 | issue_to_patch | Fix #3486: [Search] add exactResults on duplicate check | ### Closed Issues
#6221
### Description
Avoid possible duplicate results when `fullTextSearch` is set to `exact`.
| 87c62ffcc74b11c9cc5c78961ed1076d31a87ea8 | 884298381e0bb46d5641a2facbfa4508606d8822 | diff --git a/.github/ISSUE_TEMPLATE.md b/.github/ISSUE_TEMPLATE.md
new file mode 100644
index 0000000000..a09507814c
--- /dev/null
+++ b/.github/ISSUE_TEMPLATE.md
@@ -0,0 +1,24 @@
+✖ USAGE QUESTIONS → Use these dedicated resources:
+ Docs - http://www.semantic-ui.com
+ Chat - https://gitter.im/Semantic-Org/Se... | [
".github/ISSUE_TEMPLATE.md",
".github/PULL_REQUEST_TEMPLATE.md",
"src/definitions/modules/search.js"
] | [] | true | ||
Semantic-Org/Semantic-UI | 1,607 | issue_to_patch | Meteor integration | Hi Jack,
As you might know, the [Meteor](https://www.meteor.com/) community loves Semantic-UI. We had many different wrapper packages all doing the same thing, so I'm submitting a PR that integrates Meteor packaging directly into your repository.
All you have to do after accepting this PR is:
1. create an account at ... | f08a6c06f9d4becf3289767b1710b2a4b7c08f1b | 7b8621edcb862e424a5773715bf088f14d42527e | diff --git a/.gitignore b/.gitignore
index d25210f28f..ec2b069a7a 100644
--- a/.gitignore
+++ b/.gitignore
@@ -33,3 +33,4 @@ Thumbs.db
nbproject
*.sublime-project
*.sublime-workspace
+.build*
diff --git a/README.md b/README.md
index 496e7eddc5..c97d6f521a 100644
--- a/README.md
+++ b/README.md
@@ -78,6 +78,14 @@ gul... | [
".gitignore",
"README.md",
"gulpfile.js",
"meteor/README.md",
"meteor/tests/test_fonts.js",
"meteor/tests/test_images.js",
"package.js",
"package.json",
"tasks/admin/release.js",
"tasks/admin/templates/README.md",
"tasks/admin/templates/package-component.js",
"tasks/admin/templates/package.js"... | [] | diff --git a/meteor/tests/test_fonts.js b/meteor/tests/test_fonts.js
new file mode 100644
index 0000000000..40c208162a
--- /dev/null
+++ b/meteor/tests/test_fonts.js
@@ -0,0 +1,14 @@
+// Check that the font files are downloadable. Meteor places assets at /packages/<packageName>/.
+['eot', 'otf', 'svg', 'ttf', 'woff'].f... | true | |
Semantic-Org/Semantic-UI | 6,182 | issue_to_patch | Setup stalebot for stale issue management | This PR adds the config for [stalebot](https://github.com/probot/stale). This was agreed in the [recent conversation](https://github.com/Semantic-Org/Semantic-UI/issues/6109#issuecomment-366872453) about how to help move things forward.
I've set issues to be marked stale at 90 days of no activity and closed if no a... | 5b681ca84e756d0d6080ecc6a3e2cdd40c0e3d50 | 862955bd65fa5ae79c2b648569a7dea4b5b1c09b | diff --git a/.github/stale.yml b/.github/stale.yml
new file mode 100644
index 0000000000..ef6bb16ccb
--- /dev/null
+++ b/.github/stale.yml
@@ -0,0 +1,22 @@
+# Number of days of inactivity before an issue becomes stale
+daysUntilStale: 90
+
+# Number of days of inactivity before a stale issue is closed
+daysUntilClose: ... | [
".github/stale.yml"
] | [
{
"comment": "Neither of these labels are in current use.\r\nPerhaps `Confirmed Bug` would be a good starting label.",
"path": ".github/stale.yml",
"hunk": "@@ -0,0 +1,22 @@\n+# Number of days of inactivity before an issue becomes stale\n+daysUntilStale: 90\n+\n+# Number of days of inactivity before a s... | true | ||
Semantic-Org/Semantic-UI | 6,181 | issue_to_patch | Fixed the icon bugs raised in the issues | Fixed exchange.alternate icon Fixes #6175
Fixed arrows.alternate.horizontal
Fixed arrows.alternate.vertical
Fixed arrow.alternate.circle.*
Fixed user.circle.outline Fixes #6176
Removed link and left linkify icon Fixes #6180
Bumped envelope unicode to stop conflict with resize.vertical | de7d4b460256f40a614e24c9ae4dff8304a157a4 | dbe840ae3e9bb58a040bdc6edf4def98f05d476f | diff --git a/src/themes/default/assets/fonts/icons.eot b/src/themes/default/assets/fonts/icons.eot
index 769e6fabef..62fbeeda76 100644
Binary files a/src/themes/default/assets/fonts/icons.eot and b/src/themes/default/assets/fonts/icons.eot differ
diff --git a/src/themes/default/assets/fonts/icons.svg b/src/themes/defau... | [
"src/themes/default/assets/fonts/icons.eot",
"src/themes/default/assets/fonts/icons.svg",
"src/themes/default/assets/fonts/icons.ttf",
"src/themes/default/assets/fonts/icons.woff",
"src/themes/default/assets/fonts/icons.woff2",
"src/themes/default/elements/icon.overrides"
] | [] | true | ||
Semantic-Org/Semantic-UI | 4,614 | issue_to_patch | Take content settings before attr title | Since settings starts off as false, if it was passed in, it should be taken before title is returned. Workflow should still stay the same, since settings.content false would still default to title.
| 06e16f2ce540a94744e680ea711cce53ab1ff3a8 | 8f38205254f0e3ac5517a4de44ef922e1ac33342 | diff --git a/src/definitions/modules/popup.js b/src/definitions/modules/popup.js
index 0e4a6142c5..ee138a4008 100644
--- a/src/definitions/modules/popup.js
+++ b/src/definitions/modules/popup.js
@@ -488,7 +488,7 @@ $.fn.popup = function(parameters) {
},
content: function() {
$module.r... | [
"src/definitions/modules/popup.js"
] | [] | true | ||
Semantic-Org/Semantic-UI | 6,127 | issue_to_patch | Cleanup documentation HTML structure | Cleanup documentation HTML structure, fixing invalid element nesting etc. | 7b1864970355ba146905c1ac39d990e8071a5ed0 | 90cbd99e50b7c5d73e90563c849fc858dbb0a980 | diff --git a/examples/grid.html b/examples/grid.html
index fea3f9ee4d..9553162b43 100644
--- a/examples/grid.html
+++ b/examples/grid.html
@@ -330,7 +330,6 @@ <h3>Specifying Device Visibility</h3>
</div>
</div>
- </div>
</div>
diff --git a/examples/responsive.html b/examples/responsive.html
... | [
"examples/grid.html",
"examples/responsive.html",
"examples/sticky.html"
] | [] | true | ||
Semantic-Org/Semantic-UI | 5,892 | issue_to_patch | Added onChanging callback to accordion | There are callbacks that happen before open and close, so why not change as well?
Well this fixes that!
I added it so that I have a folder icon on the accordion, so I could just add
`onChanging: function() { $('#file_icon').toggleClass("open"); }`
to initialization to make it change the icon to be open or closed ... | 54491f49252fc5d6e6027d794d73e0ddb1950789 | 94e6e8195f051a3169d76f51bd73e2ee288206c7 | diff --git a/dist/semantic.js b/dist/semantic.js
index de52e03282..12a5403db2 100644
--- a/dist/semantic.js
+++ b/dist/semantic.js
@@ -2374,6 +2374,7 @@ $.fn.accordion = function(parameters) {
}
module.debug('Opening accordion content', $activeTitle);
settings.onOpening.call($activeCont... | [
"dist/semantic.js"
] | [] | true | ||
Semantic-Org/Semantic-UI | 3,396 | issue_to_patch | [Modal] Support modification of 'closable' setting while modal is open | If the `closable` property of modal is modified while the modal is visible using `$('.ui.modal').modal('setting', 'closable', value);`, it does not take effect for mouse events until it is hidden and shown again. This is because the `closable` setting affects whether a click event is bound, rather than checking the set... | 29b30aefdee16bb60cd148532344a6575fd56c56 | 7481cc3089c9ba64da8a0f160f6ba7132c1d3066 | diff --git a/src/definitions/modules/modal.js b/src/definitions/modules/modal.js
index 4f8c30fc02..2e58ba3f2b 100644
--- a/src/definitions/modules/modal.js
+++ b/src/definitions/modules/modal.js
@@ -250,16 +250,21 @@ $.fn.modal = function(parameters) {
isInDOM = $.contains(document.documentElement, eve... | [
"src/definitions/modules/modal.js"
] | [] | true | ||
Semantic-Org/Semantic-UI | 4,423 | issue_to_patch | 'on: change' causes error prompts to appear when blurring field | https://github.com/Semantic-Org/Semantic-UI/issues/4422
| 961b4c90680e8d3c1e423fbf9c0fdaf20d1e87af | b85ae81de35cf61bd6a0a57bcf473dc4b79e54f2 | diff --git a/src/definitions/behaviors/form.js b/src/definitions/behaviors/form.js
index d40d1688c3..90ca678abe 100644
--- a/src/definitions/behaviors/form.js
+++ b/src/definitions/behaviors/form.js
@@ -326,7 +326,7 @@ $.fn.form = function(parameters) {
module.validate.field( validationRules );
... | [
"src/definitions/behaviors/form.js"
] | [] | true | ||
Semantic-Org/Semantic-UI | 6,172 | issue_to_patch | Revert "'on: change' causes error prompts to appear when blurring field " | Reverts Semantic-Org/Semantic-UI#4423 | 6b176dd89c15bb0ac445235a357cb5fb9368f859 | 19ff5c99461e471359a6b18e87620b6528bc4456 | diff --git a/src/definitions/behaviors/form.js b/src/definitions/behaviors/form.js
index 35353ffbe5..1451ab9dac 100644
--- a/src/definitions/behaviors/form.js
+++ b/src/definitions/behaviors/form.js
@@ -358,7 +358,7 @@ $.fn.form = function(parameters) {
module.validate.field( validationRules );
... | [
"src/definitions/behaviors/form.js"
] | [] | true | ||
Semantic-Org/Semantic-UI | 5,902 | issue_to_patch | Swap huge and big in menu.variables #5899 | Issue #5899
Closes #5899
Changed menu variables to be _big -> huge -> massive_ to be consistent with global variables. | 3bbaf137b575c660af12cc89d6b811a8ae15cb8c | b9d5690df2361507a79e29fdf03f5df4116150e5 | diff --git a/src/themes/default/collections/menu.variables b/src/themes/default/collections/menu.variables
index 2e4bb79f6a..61e25836ea 100644
--- a/src/themes/default/collections/menu.variables
+++ b/src/themes/default/collections/menu.variables
@@ -443,8 +443,8 @@
@tiny: @12px;
@small: @13px;
@large: @15px;
-@huge... | [
"src/themes/default/collections/menu.variables"
] | [] | true | ||
Semantic-Org/Semantic-UI | 6,059 | issue_to_patch | [Popup] Use @background value for arrow background color | To customize Popup color you have to explicitly set both `@background` and `@arrowBackground` variables.
In most cases arrow color should match popup background color. | 26a3b602473ec1d2245dc669d636d7aa556b6c47 | d807a542d823d9905747d1c3106668bce19e64e5 | diff --git a/src/themes/default/modules/popup.variables b/src/themes/default/modules/popup.variables
index c7e0db826b..1b06ae1966 100644
--- a/src/themes/default/modules/popup.variables
+++ b/src/themes/default/modules/popup.variables
@@ -43,7 +43,7 @@
@border: @borderWidth solid @borderColor;
/* Arrow */
-@arrowBa... | [
"src/themes/default/modules/popup.variables"
] | [] | true | ||
Semantic-Org/Semantic-UI | 6,136 | issue_to_patch | Add missing comma: makes 9 global vars local | This PR fixes a simple typo with significant consequences.
The missing colon at the end of line 68 causes implicit semicolon
insertion to happen, this ends the variable declaration statement that
starts on line 67. The nine assignments on the 69-79 then becomes
assignments to global variables.
I found this e... | 7b1864970355ba146905c1ac39d990e8071a5ed0 | 0791675de6091d99b48e2cf7a9f6630d7e83c968 | diff --git a/tasks/admin/components/init.js b/tasks/admin/components/init.js
index 7f836d3724..986f9783df 100644
--- a/tasks/admin/components/init.js
+++ b/tasks/admin/components/init.js
@@ -65,7 +65,7 @@ module.exports = function(callback) {
}
var
- component = release.components[index]
+ ... | [
"tasks/admin/components/init.js"
] | [] | true | ||
SerenityOS/serenity | 26,803 | issue_to_patch | Kernel+Tests: Fix two small ptrace()-related bugs and add basic ptrace() tests | Previously, we didn't have any ptrace() test cases, except one checking that attaching to your own thread fails.
See commit descriptions for details. | b656cc30f59a51ba382259e64a49e191817d9bb6 | 122a2abf5126d0606e7550c80cef2e3ce36e985c | diff --git a/Kernel/Syscalls/ptrace.cpp b/Kernel/Syscalls/ptrace.cpp
index 85ebc205932395..ecf97dd7416064 100644
--- a/Kernel/Syscalls/ptrace.cpp
+++ b/Kernel/Syscalls/ptrace.cpp
@@ -68,7 +68,7 @@ static ErrorOr<FlatPtr> handle_ptrace(Kernel::Syscall::SC_ptrace_params const& p
if (tracer->tracer_pid() != caller.pi... | [
"Kernel/Syscalls/ptrace.cpp",
"Kernel/Tasks/Thread.cpp",
"Tests/Kernel/TestPtrace.cpp"
] | [
{
"comment": "Can't this be implemented as `run_generic_test([](int){}, [](int){})`?\n\n(The only diff I see is the `PT_CONTINUE`, but I don't know it that's significant, if it is, an option would be to pass `parent_callback` as a `Function` and only run the `PT_CONTINUE` line if the parent is not `nullptr`.)",... | diff --git a/Tests/Kernel/TestPtrace.cpp b/Tests/Kernel/TestPtrace.cpp
index dabed269ff97c6..0c6d4fcf5e10ff 100644
--- a/Tests/Kernel/TestPtrace.cpp
+++ b/Tests/Kernel/TestPtrace.cpp
@@ -1,14 +1,17 @@
/*
* Copyright (c) 2026, the SerenityOS developers.
+ * Copyright (c) 2026, Sönke Holz <soenke.holz@serenityos.org>
... | true | |
SerenityOS/serenity | 26,803 | comment_to_fix | Kernel+Tests: Fix two small ptrace()-related bugs and add basic ptrace() tests | Can't this be implemented as `run_generic_test([](int){}, [](int){})`?
(The only diff I see is the `PT_CONTINUE`, but I don't know it that's significant, if it is, an option would be to pass `parent_callback` as a `Function` and only run the `PT_CONTINUE` line if the parent is not `nullptr`.) | b656cc30f59a51ba382259e64a49e191817d9bb6 | 122a2abf5126d0606e7550c80cef2e3ce36e985c | diff --git a/Tests/Kernel/TestPtrace.cpp b/Tests/Kernel/TestPtrace.cpp
index dabed269ff97c6..0c6d4fcf5e10ff 100644
--- a/Tests/Kernel/TestPtrace.cpp
+++ b/Tests/Kernel/TestPtrace.cpp
@@ -1,14 +1,17 @@
/*
* Copyright (c) 2026, the SerenityOS developers.
+ * Copyright (c) 2026, Sönke Holz <soenke.holz@serenityos.org>
... | [
"Tests/Kernel/TestPtrace.cpp"
] | [
{
"comment": "Can't this be implemented as `run_generic_test([](int){}, [](int){})`?\n\n(The only diff I see is the `PT_CONTINUE`, but I don't know it that's significant, if it is, an option would be to pass `parent_callback` as a `Function` and only run the `PT_CONTINUE` line if the parent is not `nullptr`.)",... | true | ||
SerenityOS/serenity | 26,813 | issue_to_patch | Kernel/SDHC: Use microseconds_delay | The old implementation used TimeManagement::monotonic_time for delays. Since this function defaults to TimePrecision::Coarse, the resulting timeouts were far too long. The default timeout caused us to wait for 4 s instead 100 µs.
As microseconds_delay expects a time delta in microseconds, change the "delay between t... | cb6f86aa49ac74bf0fcb572b763ed22847f80e64 | cf7f2f94b2f0139a61432fb25e8deb167bb69598 | diff --git a/Kernel/Devices/Storage/SD/SDHostController.cpp b/Kernel/Devices/Storage/SD/SDHostController.cpp
index d1bc3f8507fd11..dbef98e6b76b08 100644
--- a/Kernel/Devices/Storage/SD/SDHostController.cpp
+++ b/Kernel/Devices/Storage/SD/SDHostController.cpp
@@ -6,6 +6,7 @@
#include <AK/Format.h>
#include <AK/StdLi... | [
"Kernel/Devices/Storage/SD/SDHostController.cpp",
"Kernel/Devices/Storage/SD/SDHostController.h"
] | [
{
"comment": "nit: I like putting units at the end, like in physics: `delay_between_tries_us`",
"path": "Kernel/Devices/Storage/SD/SDHostController.cpp",
"hunk": "@@ -330,14 +323,14 @@ ErrorOr<NonnullRefPtr<SDMemoryCard>> SDHostController::try_initialize_inserted_c\n card_capacity_in_blocks, rca... | true | ||
SerenityOS/serenity | 26,813 | comment_to_fix | Kernel/SDHC: Use microseconds_delay | nit: I like putting units at the end, like in physics: `delay_between_tries_us` | cb6f86aa49ac74bf0fcb572b763ed22847f80e64 | cf7f2f94b2f0139a61432fb25e8deb167bb69598 | diff --git a/Kernel/Devices/Storage/SD/SDHostController.cpp b/Kernel/Devices/Storage/SD/SDHostController.cpp
index d1bc3f8507fd11..dbef98e6b76b08 100644
--- a/Kernel/Devices/Storage/SD/SDHostController.cpp
+++ b/Kernel/Devices/Storage/SD/SDHostController.cpp
@@ -6,6 +6,7 @@
#include <AK/Format.h>
#include <AK/StdLi... | [
"Kernel/Devices/Storage/SD/SDHostController.cpp"
] | [
{
"comment": "nit: I like putting units at the end, like in physics: `delay_between_tries_us`",
"path": "Kernel/Devices/Storage/SD/SDHostController.cpp",
"hunk": "@@ -330,14 +323,14 @@ ErrorOr<NonnullRefPtr<SDMemoryCard>> SDHostController::try_initialize_inserted_c\n card_capacity_in_blocks, rca... | true | ||
SerenityOS/serenity | 26,812 | issue_to_patch | Kernal/aarch64: Support RP1 xHCI controller interrupts | This means we no longer need to fall back to polling xHCI interrupts on the Pi 5, resulting in a huge performance boost.
---
Boot time with my USB thumb drive is reduced from 1m25s down to 45s. Excluding the time spent in the firmware during netboot (35s), we now boot in 10s instead of 50s!
`cp Videos/test-webm.... | a442674bfa670a0533daa4897eb94d6273567242 | 5240cb15ed72eb3bc288e85c3f82561d1c0f943e | diff --git a/Kernel/Arch/aarch64/RPi/RP1.cpp b/Kernel/Arch/aarch64/RPi/RP1.cpp
deleted file mode 100644
index d7551cc5ae22b1..00000000000000
--- a/Kernel/Arch/aarch64/RPi/RP1.cpp
+++ /dev/null
@@ -1,93 +0,0 @@
-/*
- * Copyright (c) 2025, Sönke Holz <soenke.holz@serenityos.org>
- *
- * SPDX-License-Identifier: BSD-2-Cla... | [
"Kernel/Arch/aarch64/RPi/RP1.cpp",
"Kernel/Arch/aarch64/RPi/RP1.h",
"Kernel/Arch/aarch64/RPi/RP1/RP1.cpp",
"Kernel/Arch/aarch64/RPi/RP1/RP1.h",
"Kernel/Arch/aarch64/RPi/RP1/xHCI.cpp",
"Kernel/Arch/aarch64/RPi/RP1/xHCI.h",
"Kernel/Bus/USB/xHCI/DeviceTreexHCIController.cpp",
"Kernel/Bus/USB/xHCI/DeviceT... | [] | true | ||
SerenityOS/serenity | 26,809 | issue_to_patch | ResourceGraph: Show network speed in the tooltip | Before:
<img width="1026" height="831" alt="image" src="https://github.com/user-attachments/assets/98d05afc-c16d-4c34-8273-c00dbebe8a1e" />
After:
<img width="1026" height="831" alt="Screenshot From 2026-06-08 10-26-55-1" src="https://github.com/user-attachments/assets/ce64d000-f878-42b4-90c8-02849ddf7b62" />
(... | b656cc30f59a51ba382259e64a49e191817d9bb6 | f12e4a0408ecab99a7538b5480d5ee2e078e28c5 | diff --git a/Userland/Applets/ResourceGraph/main.cpp b/Userland/Applets/ResourceGraph/main.cpp
index 62e7851040d57f..7876cb0578b924 100644
--- a/Userland/Applets/ResourceGraph/main.cpp
+++ b/Userland/Applets/ResourceGraph/main.cpp
@@ -8,6 +8,7 @@
#include <AK/CircularQueue.h>
#include <AK/JsonObject.h>
+#include <A... | [
"Userland/Applets/ResourceGraph/main.cpp"
] | [
{
"comment": "Can this not be a union?",
"path": "Userland/Applets/ResourceGraph/main.cpp",
"hunk": "@@ -222,8 +225,13 @@ class GraphWidget final : public GUI::Frame {\n Gfx::Color m_graph_color;\n Gfx::Color m_graph_error_color;\n CircularQueue<float, history_size> m_history;\n- u64 m_la... | true | ||
SerenityOS/serenity | 26,811 | issue_to_patch | Kernel/Net: Don't use TimePrecision::Precise when delaying TCP ACKs | If the peer is able to wait for ~500ms before receiving the ACK, it will survive waiting the few more milliseconds that come with the imprecision of the Coarse setting.
On x86_64, during a SFTP file transfer, the time spent on fetching the precise clock can be as high as 10% of the total runtime.
---
Before:
... | fd75caeb6fafcff5a9aa654e03aa0d9d50ba5418 | e254756e7914e939800c487c81f6c3fe908d6313 | diff --git a/Kernel/Net/TCPSocket.cpp b/Kernel/Net/TCPSocket.cpp
index b13699ed11de04..89cf01fd9300a3 100644
--- a/Kernel/Net/TCPSocket.cpp
+++ b/Kernel/Net/TCPSocket.cpp
@@ -396,7 +396,7 @@ bool TCPSocket::should_delay_next_ack() const
return false;
// RFC 1122 says we should not delay ACKs for more th... | [
"Kernel/Net/TCPSocket.cpp"
] | [] | true | ||
SerenityOS/serenity | 26,808 | issue_to_patch | CI: Bump actions/checkout from 6.0.2 to 6.0.3 | Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.2 to 6.0.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v6.0.3</h2>
<h2>What's Changed</h2>
<ul>
<li>Update changelo... | b656cc30f59a51ba382259e64a49e191817d9bb6 | 39b21c7a53baa64802b401f915f0ec79d75a41e3 | diff --git a/.github/workflows/dev-container.yml b/.github/workflows/dev-container.yml
index 5fc6b2c4d19a86..8d56998f19bf07 100644
--- a/.github/workflows/dev-container.yml
+++ b/.github/workflows/dev-container.yml
@@ -22,7 +22,7 @@ jobs:
steps:
- name: Checkout
- uses: actions/checkout@v6.0.2
+ ... | [
".github/workflows/dev-container.yml",
".github/workflows/label-pull-requests.yml",
".github/workflows/lagom-template.yml",
".github/workflows/manpages.yml",
".github/workflows/serenity-template.yml",
".github/workflows/social-media.yml",
".github/workflows/wasm.yml"
] | [] | true | ||
SerenityOS/serenity | 26,810 | issue_to_patch | Ports: Update ffmpeg to 8.1.1 | <img width="2560" height="1440" alt="image" src="https://github.com/user-attachments/assets/973c265f-b9e1-4030-b1c7-96710a64ba7c" />
| b656cc30f59a51ba382259e64a49e191817d9bb6 | 1a7fd4ab724925e21a87b969c6d2ae3d6b9752fa | diff --git a/Ports/AvailablePorts.md b/Ports/AvailablePorts.md
index d22f6b17d9da2c..9b1d53a7ddce1b 100644
--- a/Ports/AvailablePorts.md
+++ b/Ports/AvailablePorts.md
@@ -74,7 +74,7 @@ This list is also available at [ports.serenityos.net](https://ports.serenityos.n
| [`epsilon`](epsilon/) | g... | [
"Ports/AvailablePorts.md",
"Ports/ffmpeg/package.sh"
] | [] | true | ||
SerenityOS/serenity | 26,806 | issue_to_patch | SSHServer: Honor the maximum packet size when sending channel data | Otherwise, the client is free to ignore the packet which of course result in hangs.
---
Without this patch, SSHServer hangs while the client shows:
```bash
scp -vvv -P 2222 127.0.0.1:/home/lucas/progress_file_800MB.txt ./out.txt
[...]
channel 0: rcvd big packet 32781, maxpack 32768
```
`scp` asks for a chun... | 640e09b7b10541e3e0b94cd65ed35ae947b1ce5c | a28fd1cf9da8de5b84e0f0359023fe23a8baed40 | diff --git a/Userland/Services/SSHServer/SSHClient.cpp b/Userland/Services/SSHServer/SSHClient.cpp
index dc17f17125c754..a0155c60e62bc8 100644
--- a/Userland/Services/SSHServer/SSHClient.cpp
+++ b/Userland/Services/SSHServer/SSHClient.cpp
@@ -753,16 +753,31 @@ ErrorOr<void> SSHClient::send_channel_success_message(Sessi... | [
"Userland/Services/SSHServer/SSHClient.cpp"
] | [] | true | ||
SerenityOS/serenity | 26,802 | issue_to_patch | SSHServer: Allow sessions to transfer more data | Second commit let the client know that it can send more data to us.
Third commit makes us resilient to the Kernel telling us to keep calm before sending more data.
Together, they make this work on Lagom:
```bash
ssh -p 2222 127.0.0.1 cat - < ~/progress_file_800MB.txt
```
(#26805 is required to satisfy the cla... | 640e09b7b10541e3e0b94cd65ed35ae947b1ce5c | e224fe68d87940f4943eb79933f66d8d67d5386a | diff --git a/Userland/Libraries/LibCore/Socket.cpp b/Userland/Libraries/LibCore/Socket.cpp
index f34f0059bf2e7c..08f64ec6552b50 100644
--- a/Userland/Libraries/LibCore/Socket.cpp
+++ b/Userland/Libraries/LibCore/Socket.cpp
@@ -134,6 +134,36 @@ ErrorOr<size_t> PosixSocketHelper::write(ReadonlyBytes buffer, int flags)
... | [
"Userland/Libraries/LibCore/Socket.cpp",
"Userland/Libraries/LibCore/Socket.h",
"Userland/Libraries/LibSSH/Session.cpp",
"Userland/Libraries/LibSSH/Session.h",
"Userland/Services/SSHServer/SSHClient.cpp",
"Userland/Services/SSHServer/SSHClient.h"
] | [] | true | ||
SerenityOS/serenity | 26,805 | issue_to_patch | LibSSH/SFTP: Handle partials and consecutive packets | I don't have a 100% reproducible way to hit that issue on master, but I know that I've hit it at multiple occasion in the past.
A way to trigger it is to use this patch:
```diff
diff --git a/Userland/Libraries/LibSSH/SFTP/Server.cpp b/Userland/Libraries/LibSSH/SFTP/Server.cpp
index 5e6d30b4ab..40b5e76ce5 100644
... | dd28f85c3f5efe2151cae8c06eaee44be5e2136b | cdfef25cba996905b0973e7b106194ef3e3f8c86 | diff --git a/Userland/Libraries/LibSSH/SFTP/Peer.cpp b/Userland/Libraries/LibSSH/SFTP/Peer.cpp
index 09791859e40923..22bf221cf2fda8 100644
--- a/Userland/Libraries/LibSSH/SFTP/Peer.cpp
+++ b/Userland/Libraries/LibSSH/SFTP/Peer.cpp
@@ -11,12 +11,25 @@
namespace SSH::SFTP {
+// 3. General Packet Format
+// https://d... | [
"Tests/LibSSH/SFTP/Shared.h",
"Tests/LibSSH/SFTP/TestSFTPPeer.cpp",
"Tests/LibSSH/SFTP/TestSFTPRead.cpp",
"Tests/LibSSH/SFTP/TestSFTPServerBasic.cpp",
"Tests/LibSSH/SFTP/TestSFTPStat.cpp",
"Tests/LibSSH/SFTP/TestSFTPWrite.cpp",
"Userland/Libraries/LibSSH/SFTP/Peer.cpp",
"Userland/Libraries/LibSSH/SFTP... | [] | diff --git a/Tests/LibSSH/SFTP/Shared.h b/Tests/LibSSH/SFTP/Shared.h
index 8ebe07cd969888..8562b17d975b85 100644
--- a/Tests/LibSSH/SFTP/Shared.h
+++ b/Tests/LibSSH/SFTP/Shared.h
@@ -19,6 +19,7 @@ class PeerMock : public SSH::SFTP::Peer {
{
}
+ using SSH::SFTP::Peer::is_buffer_containing_a_full_packet;
... | true | |
SerenityOS/serenity | 26,799 | issue_to_patch | Kernel+LibC: Second batch of wait fixes and tests | See individual commits for details. | a4268db46b873905dfd8c4e63b2a41dc0df012b9 | bc166f1aec7e9f4c991dfe87e17ea96b0ff819d9 | diff --git a/Kernel/Tasks/Process.cpp b/Kernel/Tasks/Process.cpp
index 8286568bf788da..809648fdeb0b80 100644
--- a/Kernel/Tasks/Process.cpp
+++ b/Kernel/Tasks/Process.cpp
@@ -950,6 +950,8 @@ void Process::finalize()
{
if (is_fully_initialized()) {
+ unblock_waiters(Thread::WaitBlocker::Unbloc... | [
"Kernel/Tasks/Process.cpp",
"Tests/Kernel/Wait/CMakeLists.txt",
"Tests/Kernel/Wait/TestWaitFirstNoHang.cpp",
"Userland/Libraries/LibC/sys/wait.cpp"
] | [
{
"comment": "How does this ensure that? Which stale data?",
"path": "Tests/Kernel/Wait/TestWaitFirstNoHang.cpp",
"hunk": "@@ -0,0 +1,79 @@\n+/*\n+ * Copyright (c) 2026, Lucas Chollet <lucas.chollet@serenityos.org>\n+ *\n+ * SPDX-License-Identifier: BSD-2-Clause\n+ */\n+\n+#include <LibCore/System.h>\n+... | diff --git a/Tests/Kernel/Wait/CMakeLists.txt b/Tests/Kernel/Wait/CMakeLists.txt
index dbd9d3b8b19b98..5ddabf86ff4e73 100644
--- a/Tests/Kernel/Wait/CMakeLists.txt
+++ b/Tests/Kernel/Wait/CMakeLists.txt
@@ -1,6 +1,7 @@
set(KERNEL_WAIT_SOURCES
TestWait.cpp
TestWaitDoesReap.cpp
+ TestWaitFirstNoHang.cpp
... | true | |
SerenityOS/serenity | 26,799 | comment_to_fix | Kernel+LibC: Second batch of wait fixes and tests | How does this ensure that? Which stale data? | a4268db46b873905dfd8c4e63b2a41dc0df012b9 | bc166f1aec7e9f4c991dfe87e17ea96b0ff819d9 | diff --git a/Tests/Kernel/Wait/TestWaitFirstNoHang.cpp b/Tests/Kernel/Wait/TestWaitFirstNoHang.cpp
new file mode 100644
index 00000000000000..3e6235172aee1e
--- /dev/null
+++ b/Tests/Kernel/Wait/TestWaitFirstNoHang.cpp
@@ -0,0 +1,75 @@
+/*
+ * Copyright (c) 2026, Lucas Chollet <lucas.chollet@serenityos.org>
+ *
+ * SPD... | [
"Tests/Kernel/Wait/TestWaitFirstNoHang.cpp"
] | [
{
"comment": "How does this ensure that? Which stale data?",
"path": "Tests/Kernel/Wait/TestWaitFirstNoHang.cpp",
"hunk": "@@ -0,0 +1,79 @@\n+/*\n+ * Copyright (c) 2026, Lucas Chollet <lucas.chollet@serenityos.org>\n+ *\n+ * SPDX-License-Identifier: BSD-2-Clause\n+ */\n+\n+#include <LibCore/System.h>\n+... | true | ||
SerenityOS/serenity | 26,799 | comment_to_fix | Kernel+LibC: Second batch of wait fixes and tests | I think you usually should make variables `volatile` if they are used in signal handlers to prevent the compiler from doing silly optimizations.
([Per the C++ spec](https://en.cppreference.com/cpp/utility/program/signal#Signal_handler), only using `volatile sig_atomic_t` or *lock-free* atomics is allowed. But that sho... | a4268db46b873905dfd8c4e63b2a41dc0df012b9 | bc166f1aec7e9f4c991dfe87e17ea96b0ff819d9 | diff --git a/Tests/Kernel/Wait/TestWaitFirstNoHang.cpp b/Tests/Kernel/Wait/TestWaitFirstNoHang.cpp
new file mode 100644
index 00000000000000..3e6235172aee1e
--- /dev/null
+++ b/Tests/Kernel/Wait/TestWaitFirstNoHang.cpp
@@ -0,0 +1,75 @@
+/*
+ * Copyright (c) 2026, Lucas Chollet <lucas.chollet@serenityos.org>
+ *
+ * SPD... | [
"Tests/Kernel/Wait/TestWaitFirstNoHang.cpp"
] | [
{
"comment": "I think you usually should make variables `volatile` if they are used in signal handlers to prevent the compiler from doing silly optimizations.\n\n([Per the C++ spec](https://en.cppreference.com/cpp/utility/program/signal#Signal_handler), only using `volatile sig_atomic_t` or *lock-free* atomics ... | true | ||
SerenityOS/serenity | 26,801 | issue_to_patch | SSHServer: Fix two children-related issues | See individual commits for details.
SSHServer is now able to sustain a continuous stream of sequential connections without acting weird. | e86ef471f6b5e3484fe6888eeef0c46af130b124 | 6d44463751b445c5dcfb0a53be6ee771a75da93a | diff --git a/Userland/Services/SSHServer/main.cpp b/Userland/Services/SSHServer/main.cpp
index 27f1fd60e5a063..3a4b36b6d852fb 100644
--- a/Userland/Services/SSHServer/main.cpp
+++ b/Userland/Services/SSHServer/main.cpp
@@ -36,6 +36,7 @@ ErrorOr<void> accept_connection()
// We need to ensure the socket survives... | [
"Userland/Services/SSHServer/main.cpp"
] | [] | true | ||
SerenityOS/serenity | 26,800 | issue_to_patch | AK: Remove unused static members in JsonPath | Found by Valgrind by reporting a false positive leak emerging from these :clown_face: | e86ef471f6b5e3484fe6888eeef0c46af130b124 | 5dea27dd74f4244eca4fd3210fc65d8c4e89eb13 | diff --git a/AK/JsonPath.cpp b/AK/JsonPath.cpp
index 27ecaa2b07ba9c..a9c55cd37d4714 100644
--- a/AK/JsonPath.cpp
+++ b/AK/JsonPath.cpp
@@ -10,9 +10,6 @@
namespace AK {
-JsonPathElement JsonPathElement::any_array_element { Kind::AnyIndex };
-JsonPathElement JsonPathElement::any_object_element { Kind::AnyKey };
-
E... | [
"AK/JsonPath.cpp",
"AK/JsonPath.h"
] | [] | true | ||
SerenityOS/serenity | 26,781 | issue_to_patch | LibSSH/SFTP: Support the write command | The diff looks bigger than it really is, the bulk of it is mainly code moves and tests while the actual code changes are quite simple.
Due to other limitations, it only works with small files and randomly fail because of a very similar reason to #26767 but applied to the SFTP layer.
<img width="1027" height="831"... | 15ea8e970bc30c7e754e5009fb1d057a8c8dcf18 | b95cb22e4c729cdec141c17bbbbe943dfdef755e | diff --git a/Userland/Libraries/LibCore/System.cpp b/Userland/Libraries/LibCore/System.cpp
index 0700934c6cb22f..1220d6a825b476 100644
--- a/Userland/Libraries/LibCore/System.cpp
+++ b/Userland/Libraries/LibCore/System.cpp
@@ -696,6 +696,17 @@ ErrorOr<ssize_t> write(int fd, ReadonlyBytes buffer)
return rc;
}
+E... | [
"Tests/LibSSH/CMakeLists.txt",
"Tests/LibSSH/SFTP/Shared.h",
"Tests/LibSSH/SFTP/TestSFTPAttributes.cpp",
"Tests/LibSSH/SFTP/TestSFTPRead.cpp",
"Tests/LibSSH/SFTP/TestSFTPStat.cpp",
"Tests/LibSSH/SFTP/TestSFTPWrite.cpp",
"Userland/Libraries/LibCore/System.cpp",
"Userland/Libraries/LibCore/System.h",
... | [] | diff --git a/Tests/LibSSH/CMakeLists.txt b/Tests/LibSSH/CMakeLists.txt
index 250c1cdcce1490..8f75dad3b12c69 100644
--- a/Tests/LibSSH/CMakeLists.txt
+++ b/Tests/LibSSH/CMakeLists.txt
@@ -1,8 +1,10 @@
set(TEST_SOURCES
+ SFTP/TestSFTPAttributes.cpp
SFTP/TestSFTPPeer.cpp
SFTP/TestSFTPServerBasic.cpp
SFT... | true | |
SerenityOS/serenity | 26,670 | issue_to_patch | TerminalSettings: Add default option and some other small setting apps fixes | See commit messages for individual changes | e8e1a1ee7331312f5ae7d87d26f889f0c426cadf | 39f96803339a03e4cef297ab7d5e98a03b97d74b | diff --git a/Userland/Applications/ClockSettings/ClockSettingsWidget.cpp b/Userland/Applications/ClockSettings/ClockSettingsWidget.cpp
index ba93905ea4fbff..64e6d07f31c800 100644
--- a/Userland/Applications/ClockSettings/ClockSettingsWidget.cpp
+++ b/Userland/Applications/ClockSettings/ClockSettingsWidget.cpp
@@ -112,7... | [
"Userland/Applications/ClockSettings/ClockSettingsWidget.cpp",
"Userland/Applications/SystemMonitor/main.cpp",
"Userland/Applications/Terminal/main.cpp",
"Userland/Applications/TerminalSettings/Defaults.h",
"Userland/Applications/TerminalSettings/MainWidget.cpp",
"Userland/Applications/TerminalSettings/Ma... | [
{
"comment": "Is that used anywhere?\nWhen there is a single tab it is already focused by default, right?",
"path": "Userland/Applications/CertificateSettings/main.cpp",
"hunk": "@@ -17,6 +18,11 @@ ErrorOr<int> serenity_main(Main::Arguments args)\n {\n TRY(Core::System::pledge(\"stdio rpath wpath cp... | true | ||
SerenityOS/serenity | 26,670 | comment_to_fix | TerminalSettings: Add default option and some other small setting apps fixes | I think this would be a better commit title: "Remove mention of non-existing hardware tab" | e8e1a1ee7331312f5ae7d87d26f889f0c426cadf | 39f96803339a03e4cef297ab7d5e98a03b97d74b | diff --git a/Userland/Applications/SystemMonitor/main.cpp b/Userland/Applications/SystemMonitor/main.cpp
index 3ef95bf88ebb3b..c5ae0a026e3fb4 100644
--- a/Userland/Applications/SystemMonitor/main.cpp
+++ b/Userland/Applications/SystemMonitor/main.cpp
@@ -271,7 +271,7 @@ ErrorOr<int> serenity_main(Main::Arguments argume... | [
"Userland/Applications/SystemMonitor/main.cpp"
] | [
{
"comment": "I think this would be a better commit title: \"Remove mention of non-existing hardware tab\"",
"path": "Userland/Applications/SystemMonitor/main.cpp",
"hunk": "@@ -271,7 +271,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)\n ",
"resolving_sha": "39f96803339a03e4cef297ab7d5e9... | true | ||
SerenityOS/serenity | 26,670 | comment_to_fix | TerminalSettings: Add default option and some other small setting apps fixes | No action required, but these guys seem to be out of sync with the actual tab name in the application. | e8e1a1ee7331312f5ae7d87d26f889f0c426cadf | 39f96803339a03e4cef297ab7d5e98a03b97d74b | diff --git a/Userland/Applications/SystemMonitor/main.cpp b/Userland/Applications/SystemMonitor/main.cpp
index 3ef95bf88ebb3b..c5ae0a026e3fb4 100644
--- a/Userland/Applications/SystemMonitor/main.cpp
+++ b/Userland/Applications/SystemMonitor/main.cpp
@@ -271,7 +271,7 @@ ErrorOr<int> serenity_main(Main::Arguments argume... | [
"Userland/Applications/SystemMonitor/main.cpp"
] | [
{
"comment": "No action required, but these guys seem to be out of sync with the actual tab name in the application.",
"path": "Userland/Applications/SystemMonitor/main.cpp",
"hunk": "@@ -271,7 +271,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)\n \n StringView args_tab = \"processes\"sv... | true | ||
SerenityOS/serenity | 26,670 | comment_to_fix | TerminalSettings: Add default option and some other small setting apps fixes | Let's use a namespace instead of using a `default_` prefix.
Also, please use SCREAMING_SNAKE_CASE for constants:
https://github.com/SerenityOS/serenity/blob/master/Documentation/CodingStyle.md#names | e8e1a1ee7331312f5ae7d87d26f889f0c426cadf | 39f96803339a03e4cef297ab7d5e98a03b97d74b | diff --git a/Userland/Applications/TerminalSettings/Defaults.h b/Userland/Applications/TerminalSettings/Defaults.h
new file mode 100644
index 00000000000000..96ab51f868d872
--- /dev/null
+++ b/Userland/Applications/TerminalSettings/Defaults.h
@@ -0,0 +1,23 @@
+/*
+ * Copyright (c) 2025, the SerenityOS developers.
+ *
+... | [
"Userland/Applications/TerminalSettings/Defaults.h"
] | [
{
"comment": "Let's use a namespace instead of using a `default_` prefix.\nAlso, please use SCREAMING_SNAKE_CASE for constants:\nhttps://github.com/SerenityOS/serenity/blob/master/Documentation/CodingStyle.md#names",
"path": "Userland/Applications/TerminalSettings/Defaults.h",
"hunk": "@@ -0,0 +1,23 @@\... | true | ||
SerenityOS/serenity | 26,670 | comment_to_fix | TerminalSettings: Add default option and some other small setting apps fixes | Seems unrelated. | e8e1a1ee7331312f5ae7d87d26f889f0c426cadf | 39f96803339a03e4cef297ab7d5e98a03b97d74b | diff --git a/Userland/Applications/TerminalSettings/main.cpp b/Userland/Applications/TerminalSettings/main.cpp
index 38bc80a2dc2bc0..e309210aeea53d 100644
--- a/Userland/Applications/TerminalSettings/main.cpp
+++ b/Userland/Applications/TerminalSettings/main.cpp
@@ -11,6 +11,7 @@
#include <LibCore/System.h>
#include ... | [
"Userland/Applications/TerminalSettings/main.cpp"
] | [
{
"comment": "Seems unrelated.",
"path": "Userland/Applications/TerminalSettings/main.cpp",
"hunk": "@@ -11,6 +11,7 @@\n #include <LibCore/System.h>\n #include <LibGUI/Application.h>\n #include <LibGUI/ConnectionToWindowServer.h>\n+#include <LibGUI/Icon.h>",
"resolving_sha": "39f96803339a03e4cef297a... | true | ||
SerenityOS/serenity | 26,670 | comment_to_fix | TerminalSettings: Add default option and some other small setting apps fixes | No change required here, but in the future please try to split your commits a little bit more.
Here it would have been better to have a first commit introducing the Default constants and a second one implementing the reset logic. | e8e1a1ee7331312f5ae7d87d26f889f0c426cadf | 39f96803339a03e4cef297ab7d5e98a03b97d74b | diff --git a/Userland/Applications/Terminal/main.cpp b/Userland/Applications/Terminal/main.cpp
index d092a3d0cbf858..e20a5ecca23bfa 100644
--- a/Userland/Applications/Terminal/main.cpp
+++ b/Userland/Applications/Terminal/main.cpp
@@ -7,6 +7,7 @@
#include <AK/FixedArray.h>
#include <AK/QuickSort.h>
#include <AK/Type... | [
"Userland/Applications/Terminal/main.cpp"
] | [
{
"comment": "No change required here, but in the future please try to split your commits a little bit more.\nHere it would have been better to have a first commit introducing the Default constants and a second one implementing the reset logic.",
"path": "Userland/Applications/Terminal/main.cpp",
"hunk"... | true | ||
SerenityOS/serenity | 26,670 | comment_to_fix | TerminalSettings: Add default option and some other small setting apps fixes | I don't think this one needs to be a member value. | e8e1a1ee7331312f5ae7d87d26f889f0c426cadf | 39f96803339a03e4cef297ab7d5e98a03b97d74b | diff --git a/Userland/Applications/TerminalSettings/ViewWidget.h b/Userland/Applications/TerminalSettings/ViewWidget.h
index e35845ba272f48..3edac5161b7ac7 100644
--- a/Userland/Applications/TerminalSettings/ViewWidget.h
+++ b/Userland/Applications/TerminalSettings/ViewWidget.h
@@ -6,11 +6,15 @@
#pragma once
+#inc... | [
"Userland/Applications/TerminalSettings/ViewWidget.h"
] | [
{
"comment": "I don't think this one needs to be a member value.",
"path": "Userland/Applications/TerminalSettings/ViewWidget.h",
"hunk": "@@ -43,5 +48,19 @@ class ViewWidget final : public GUI::SettingsWindow::Tab {\n bool m_original_cursor_is_blinking_set;\n size_t m_original_max_history_size;... | true | ||
SerenityOS/serenity | 26,670 | comment_to_fix | TerminalSettings: Add default option and some other small setting apps fixes | Same for this one. | e8e1a1ee7331312f5ae7d87d26f889f0c426cadf | 39f96803339a03e4cef297ab7d5e98a03b97d74b | diff --git a/Userland/Applications/TerminalSettings/ViewWidget.h b/Userland/Applications/TerminalSettings/ViewWidget.h
index e35845ba272f48..3edac5161b7ac7 100644
--- a/Userland/Applications/TerminalSettings/ViewWidget.h
+++ b/Userland/Applications/TerminalSettings/ViewWidget.h
@@ -6,11 +6,15 @@
#pragma once
+#inc... | [
"Userland/Applications/TerminalSettings/ViewWidget.h"
] | [
{
"comment": "Same for this one.",
"path": "Userland/Applications/TerminalSettings/ViewWidget.h",
"hunk": "@@ -43,5 +48,19 @@ class ViewWidget final : public GUI::SettingsWindow::Tab {\n bool m_original_cursor_is_blinking_set;\n size_t m_original_max_history_size;\n bool m_original_show_scro... | true | ||
SerenityOS/serenity | 26,670 | comment_to_fix | TerminalSettings: Add default option and some other small setting apps fixes | Let's use the full path here too:
```
#include <Applications/TerminalSettings/Defaults.h>
``` | e8e1a1ee7331312f5ae7d87d26f889f0c426cadf | 39f96803339a03e4cef297ab7d5e98a03b97d74b | diff --git a/Userland/Applications/TerminalSettings/MainWidget.cpp b/Userland/Applications/TerminalSettings/MainWidget.cpp
index c4ba4865e93550..c2e0e0d44807b1 100644
--- a/Userland/Applications/TerminalSettings/MainWidget.cpp
+++ b/Userland/Applications/TerminalSettings/MainWidget.cpp
@@ -8,6 +8,7 @@
#include <AK/Ass... | [
"Userland/Applications/TerminalSettings/MainWidget.cpp"
] | [
{
"comment": "Let's use the full path here too:\n```\n#include <Applications/TerminalSettings/Defaults.h>\n```",
"path": "Userland/Applications/TerminalSettings/MainWidget.cpp",
"hunk": "@@ -4,6 +4,7 @@\n * SPDX-License-Identifier: BSD-2-Clause\n */\n \n+#include \"Defaults.h\"",
"resolving_sha": ... | true | ||
SerenityOS/serenity | 26,670 | comment_to_fix | TerminalSettings: Add default option and some other small setting apps fixes | Check that you don't move this anymore when rebasing. | e8e1a1ee7331312f5ae7d87d26f889f0c426cadf | 39f96803339a03e4cef297ab7d5e98a03b97d74b | diff --git a/Userland/Applications/TerminalSettings/MainWidget.cpp b/Userland/Applications/TerminalSettings/MainWidget.cpp
index c4ba4865e93550..c2e0e0d44807b1 100644
--- a/Userland/Applications/TerminalSettings/MainWidget.cpp
+++ b/Userland/Applications/TerminalSettings/MainWidget.cpp
@@ -8,6 +8,7 @@
#include <AK/Ass... | [
"Userland/Applications/TerminalSettings/MainWidget.cpp"
] | [
{
"comment": "Check that you don't move this anymore when rebasing.",
"path": "Userland/Applications/TerminalSettings/MainWidget.cpp",
"hunk": "@@ -4,8 +4,8 @@\n * SPDX-License-Identifier: BSD-2-Clause\n */\n \n-#include \"Defaults.h\"\n #include \"MainWidget.h\"\n+#include \"Defaults.h\"",
"resol... | true | ||
SerenityOS/serenity | 26,670 | comment_to_fix | TerminalSettings: Add default option and some other small setting apps fixes | For consistency, call `set_checked` before setting `on_checked`. That's what is done for every other widget. | e8e1a1ee7331312f5ae7d87d26f889f0c426cadf | 39f96803339a03e4cef297ab7d5e98a03b97d74b | diff --git a/Userland/Applications/TerminalSettings/ViewWidget.cpp b/Userland/Applications/TerminalSettings/ViewWidget.cpp
index 1520d3c1ae9d43..8333b163767207 100644
--- a/Userland/Applications/TerminalSettings/ViewWidget.cpp
+++ b/Userland/Applications/TerminalSettings/ViewWidget.cpp
@@ -5,6 +5,7 @@
*/
#include ... | [
"Userland/Applications/TerminalSettings/ViewWidget.cpp"
] | [
{
"comment": "For consistency, call `set_checked` before setting `on_checked`. That's what is done for every other widget.",
"path": "Userland/Applications/TerminalSettings/ViewWidget.cpp",
"hunk": "@@ -119,40 +115,34 @@ ErrorOr<void> ViewWidget::setup()\n m_cursor_blinking_checkbox->on_checked = [t... | true | ||
SerenityOS/serenity | 26,670 | comment_to_fix | TerminalSettings: Add default option and some other small setting apps fixes | Is this required? If the callback isn't set yet, the parameter is useless right?
Sorry if that wasn't clear, that's why I suggested moving it above. | e8e1a1ee7331312f5ae7d87d26f889f0c426cadf | 39f96803339a03e4cef297ab7d5e98a03b97d74b | diff --git a/Userland/Applications/TerminalSettings/ViewWidget.cpp b/Userland/Applications/TerminalSettings/ViewWidget.cpp
index 1520d3c1ae9d43..8333b163767207 100644
--- a/Userland/Applications/TerminalSettings/ViewWidget.cpp
+++ b/Userland/Applications/TerminalSettings/ViewWidget.cpp
@@ -5,6 +5,7 @@
*/
#include ... | [
"Userland/Applications/TerminalSettings/ViewWidget.cpp"
] | [
{
"comment": "Is this required? If the callback isn't set yet, the parameter is useless right?\r\nSorry if that wasn't clear, that's why I suggested moving it above.",
"path": "Userland/Applications/TerminalSettings/ViewWidget.cpp",
"hunk": "@@ -116,35 +112,30 @@ ErrorOr<void> ViewWidget::setup()\n ... | true | ||
SerenityOS/serenity | 26,791 | issue_to_patch | Kernel: First batch of wait fixes and tests | See individual commits for details. | aed345cae965706d0a44f94c19583ba917a25779 | 6e71a499351e304cd980b864ca31165f5a9b4503 | diff --git a/Kernel/Syscalls/disown.cpp b/Kernel/Syscalls/disown.cpp
index 8b37946b9fe9eb..449585ca08fea6 100644
--- a/Kernel/Syscalls/disown.cpp
+++ b/Kernel/Syscalls/disown.cpp
@@ -21,7 +21,7 @@ ErrorOr<FlatPtr> Process::sys$disown(ProcessID pid)
protected_data.ppid = 0;
return {};
}));
- pr... | [
"Kernel/Syscalls/disown.cpp",
"Kernel/Syscalls/waitid.cpp",
"Kernel/Tasks/Process.cpp",
"Kernel/Tasks/Process.h",
"Kernel/Tasks/Thread.h",
"Kernel/Tasks/ThreadBlockers.cpp",
"Meta/Lagom/CMakeLists.txt",
"Tests/Kernel/CMakeLists.txt",
"Tests/Kernel/Wait/CMakeLists.txt",
"Tests/Kernel/Wait/TestWait.... | [
{
"comment": "Commit description: That POSIX link you used points to the main POSIX spec page. The POSIX spec uses HTML frames and the URL in the address bar doesn't change if you click on any of the links, so you can't just copy it from there.\n\nI usually get the URL by right clicking on a link and select the... | diff --git a/Tests/Kernel/CMakeLists.txt b/Tests/Kernel/CMakeLists.txt
index 61d9e5bd0e1dea..216ca41dfd7acc 100644
--- a/Tests/Kernel/CMakeLists.txt
+++ b/Tests/Kernel/CMakeLists.txt
@@ -63,7 +63,6 @@ set(LIBTEST_BASED_SOURCES
TestSigHandler.cpp
TestSignalDispatch.cpp
TestTCPSocket.cpp
- TestWait.cpp
... | true | |
SerenityOS/serenity | 26,791 | comment_to_fix | Kernel: First batch of wait fixes and tests | Commit description: That POSIX link you used points to the main POSIX spec page. The POSIX spec uses HTML frames and the URL in the address bar doesn't change if you click on any of the links, so you can't just copy it from there.
I usually get the URL by right clicking on a link and select the option to copy the link... | aed345cae965706d0a44f94c19583ba917a25779 | 6e71a499351e304cd980b864ca31165f5a9b4503 | diff --git a/Kernel/Syscalls/waitid.cpp b/Kernel/Syscalls/waitid.cpp
index 9c6edcbe993434..8ba28be6896385 100644
--- a/Kernel/Syscalls/waitid.cpp
+++ b/Kernel/Syscalls/waitid.cpp
@@ -15,7 +15,6 @@ ErrorOr<siginfo_t> Process::do_waitid(Variant<Empty, NonnullRefPtr<Process>, Non
ErrorOr<siginfo_t> result = siginfo_t... | [
"Kernel/Syscalls/waitid.cpp"
] | [
{
"comment": "Commit description: That POSIX link you used points to the main POSIX spec page. The POSIX spec uses HTML frames and the URL in the address bar doesn't change if you click on any of the links, so you can't just copy it from there.\n\nI usually get the URL by right clicking on a link and select the... | true | ||
SerenityOS/serenity | 26,791 | comment_to_fix | Kernel: First batch of wait fixes and tests | Do we still want to add processes to this list in `Thread::WaitBlockerSet::unblock` when they die? Wouldn't this cause duplicate entries?
(I'm also not really a fan of that `release_value_but_fixme_should_propagate_errors`. This could even be an intrusive list I think, but that's not related to this PR of course.) | aed345cae965706d0a44f94c19583ba917a25779 | 6e71a499351e304cd980b864ca31165f5a9b4503 | diff --git a/Kernel/Tasks/ThreadBlockers.cpp b/Kernel/Tasks/ThreadBlockers.cpp
index 080649cdfe1d10..dd363d17a6cf02 100644
--- a/Kernel/Tasks/ThreadBlockers.cpp
+++ b/Kernel/Tasks/ThreadBlockers.cpp
@@ -528,8 +528,8 @@ void Thread::WaitBlockerSet::try_unblock(Thread::WaitBlocker& blocker)
if (blocker.unblock(i... | [
"Kernel/Tasks/ThreadBlockers.cpp"
] | [
{
"comment": "Do we still want to add processes to this list in `Thread::WaitBlockerSet::unblock` when they die? Wouldn't this cause duplicate entries?\n\n(I'm also not really a fan of that `release_value_but_fixme_should_propagate_errors`. This could even be an intrusive list I think, but that's not related to... | true | ||
SerenityOS/serenity | 26,791 | comment_to_fix | Kernel: First batch of wait fixes and tests | very nit: I usually avoid `&` or `=` catch-all capture rules and prefer being explicit with lambda captures. I think you only need `this` here. | aed345cae965706d0a44f94c19583ba917a25779 | 6e71a499351e304cd980b864ca31165f5a9b4503 | diff --git a/Kernel/Tasks/ThreadBlockers.cpp b/Kernel/Tasks/ThreadBlockers.cpp
index 080649cdfe1d10..dd363d17a6cf02 100644
--- a/Kernel/Tasks/ThreadBlockers.cpp
+++ b/Kernel/Tasks/ThreadBlockers.cpp
@@ -528,8 +528,8 @@ void Thread::WaitBlockerSet::try_unblock(Thread::WaitBlocker& blocker)
if (blocker.unblock(i... | [
"Kernel/Tasks/ThreadBlockers.cpp"
] | [
{
"comment": "very nit: I usually avoid `&` or `=` catch-all capture rules and prefer being explicit with lambda captures. I think you only need `this` here.",
"path": "Kernel/Tasks/ThreadBlockers.cpp",
"hunk": "@@ -540,6 +540,25 @@ void Thread::WaitBlockerSet::try_unblock(Thread::WaitBlocker& blocker)\... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.